Context Navigation

platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
platform/efl/WidgetEfl.cpp: (WebCore::Widget::frameRectsChanged): (WebCore::Widget::setEvasObject):

11:27 PM Changeset in webkit [80542] by aestes@apple.com

5 edits in trunk

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

A change to the date parser to handle the case where the year is
specified before the time zone inadvertently started accepting strings
such as '+0000' as valid years. Those strings actually represent time
zones in an offset of hours and minutes from UTC, not years.

wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): If the current character in dateString is '+' or '-', do not try to parse the next token as a year.

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

fast/js/date-parse-test-expected.txt:
fast/js/script-tests/date-parse-test.js:

11:18 PM Changeset in webkit [80541] by dcheng@chromium.org

4 edits in trunk/Source/WebCore

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

More build fixes for r80536.

CMakeLists.txt:
platform/chromium/ClipboardChromium.cpp:
platform/chromium/ClipboardChromium.h:

11:05 PM Changeset in webkit [80540] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917

Adjust webkit style to ScrollbarEfl files.

platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage): (ScrollbarEfl::setParent): (ScrollbarEfl::updateThumbPositionAndProportion): (ScrollbarEfl::frameRectsChanged): (ScrollbarEfl::paint):
platform/efl/ScrollbarEfl.h:

10:45 PM Changeset in webkit [80539] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Fix jquery/effects.html and fast/viewpoert/viewport-129.html

platform/chromium/test_expectations.txt:

10:18 PM Changeset in webkit [80538] by dcheng@chromium.org

3 edits in trunk/Source/WebCore

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Build fix for Chromium after r80536.

platform/chromium/DataTransferItemChromium.cpp:
platform/chromium/DataTransferItemsChromium.cpp:

9:58 PM Changeset in webkit [80537] by ojan@chromium.org

5 edits
1 add in trunk/Tools

2011-03-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add webkit-patch attach-to-bug for posting to bugzilla from the commandline
https://bugs.webkit.org/show_bug.cgi?id=55749

Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/steps/init.py:
Scripts/webkitpy/tool/steps/attachtobug.py: Added.
Scripts/webkitpy/tool/steps/options.py:

9:48 PM Changeset in webkit [80536] by dcheng@chromium.org

28 edits
14 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Layout test to verify that the basic properties of dataTransfer.items function as expected.

editing/pasteboard/data-transfer-items-expected.txt: Added.
editing/pasteboard/data-transfer-items.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
all functionality on the DataTransferItems collection has been implemented.
This change does not actually hook up DataTransferItems to reflect the actual contents of a
drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
enabled via several followup patches.

Test: editing/pasteboard/data-transfer-items.html

Android.mk:
CMakeLists.txt:
CodeGenerators.pri:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
dom/Clipboard.h: (WebCore::Clipboard::policy):
dom/Clipboard.idl:
dom/DataTransferItem.cpp: Added.
dom/DataTransferItem.h: Added. (WebCore::DataTransferItem::~DataTransferItem):
dom/DataTransferItem.idl: Added.
dom/DataTransferItems.h: Added. (WebCore::DataTransferItems::~DataTransferItems):
dom/DataTransferItems.idl: Added.
dom/StringCallback.cpp: Added. (WebCore::StringCallback::scheduleCallback):
dom/StringCallback.h: Added. (WebCore::StringCallback::~StringCallback):
dom/StringCallback.idl: Added.
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
platform/chromium/ClipboardChromium.h:
platform/chromium/DataTransferItemChromium.cpp: Added. (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::kind): (WebCore::DataTransferItemChromium::type): (WebCore::DataTransferItemChromium::getAsString):
platform/chromium/DataTransferItemChromium.h: Added.
platform/chromium/DataTransferItemsChromium.cpp: Added. (WebCore::DataTransferItemsChromium::create): (WebCore::DataTransferItemsChromium::DataTransferItemsChromium): (WebCore::DataTransferItemsChromium::length): (WebCore::DataTransferItemsChromium::item): (WebCore::DataTransferItemsChromium::deleteItem): (WebCore::DataTransferItemsChromium::clear): (WebCore::DataTransferItemsChromium::add):
platform/chromium/DataTransferItemsChromium.h: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Add new runtime enabled flag for data transfer items feature.

public/WebRuntimeFeatures.h:
src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDataTransferItems): (WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Enable data transfer items in DRT.

DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):

9:41 PM Changeset in webkit [80535] by ojan@chromium.org

2 edits in trunk/Tools

2011-03-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[test dashboard] pull treemap files
https://bugs.webkit.org/show_bug.cgi?id=55852

TestResultServer/handlers/dashboardhandler.py:

9:22 PM Changeset in webkit [80534] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char.html on Windows

platform/chromium/test_expectations.txt:

9:19 PM Changeset in webkit [80533] by commit-queue@webkit.org

8 edits in trunk/LayoutTests

2011-03-07 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

Rebaseline GPU media/video-display-toggle.html for snow leopard
https://bugs.webkit.org/show_bug.cgi?id=55920

platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
platform/chromium-gpu-mac/media/video-no-audio-expected.png:
platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
platform/chromium/test_expectations.txt:

9:06 PM Changeset in webkit [80532] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/viewport/viewport-{128,129}.html

platform/chromium/test_expectations.txt:

8:49 PM Changeset in webkit [80531] by dcheng@chromium.org

4 edits in trunk/LayoutTests

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Updated Skipped lists for editing/pasteboard/onpaste-text-html-types.html.
https://bugs.webkit.org/show_bug.cgi?id=55921
https://bugs.webkit.org/show_bug.cgi?id=55922

platform/qt-wk2/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

8:07 PM Changeset in webkit [80530] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Chromium build fix.

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

8:02 PM Changeset in webkit [80529] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char-dos.html

platform/chromium/test_expectations.txt:

7:54 PM Changeset in webkit [80528] by rniwa@webkit.org

13 edits in trunk/Source

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Calls selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

WebView/WebHTMLView.mm: Removed unused selectionHasStyle. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.

Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
call sites of these two functions.

WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports selectionStartHasStyle because it's not called anywhere outside of WebCore.
WebCore.order: Ditto.
editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id and a property value. (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
editing/EditingStyle.h: (WebCore::EditingStyle::create): Added.
editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of a CSSStyleDeclaration. (WebCore::Editor::selectionHasStyle): Ditto.
editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
editing/EditorCommand.cpp: (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle. (WebCore::stateStyle): Ditto.
page/ContextMenuController.cpp: (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.

7:31 PM Changeset in webkit [80527] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Add svg/css/rect-gradient-stroke-shadow.svg added by webkit r80515

platform/chromium/test_expectations.txt:

7:17 PM Changeset in webkit [80526] by ap@apple.com

8 edits in trunk

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

platform/mac/fast/text/large-text-composed-char-expected.txt: The huge text run is split into multiple text nodes again.

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

<rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
linkifying e-mail addresses in in -[DOMCharacterData setData:]

Changes render tree of fast/text/large-text-composed-char.html, but not image results.

dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().

dom/CharacterData.h: Moved a constant for maximum length from Text.h.

dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
dom/Text.h: This function was unused in ToT. Moved code around to share with CharacterData.

html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode): Chnaged to split large text nodes while parsing again.

7:13 PM Changeset in webkit [80525] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

svg/W3C-SVG-1.1/struct-image-07-t.svg failing

platform/chromium/test_expectations.txt:

7:07 PM Changeset in webkit [80524] by hayato@chromium.org

4 edits in trunk/Tools

2011-03-03 Hayato Ito <hayato@chromium.org>

Reviewed by Mihai Parparita.

[NRWT] Clear output image file used by DumpRenderTree to make sure the
previous image should not be used in the ChromiumDriver.

Also make sure that output image from the ChromiumDriver should be
(empty string) if a test crashes for consistency with the WebKitDriver
implementation.

https://bugs.webkit.org/show_bug.cgi?id=55746

Scripts/webkitpy/layout_tests/port/chromium.py:

6:32 PM Changeset in webkit [80523] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-03-07 Damian Kaleta <dkaleta@apple.com>

Reviewed by Anders Carlsson.

QuickTime plugin should opt in to a 32-bit non-executable heap
https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/8105706>

UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap. By default it should opt-out. (WebKit::PluginProcessProxy::PluginProcessProxy):

6:25 PM Changeset in webkit [80522] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark several jquery tests slow for debug build.

platform/chromium/test_expectations.txt:

6:19 PM Changeset in webkit [80521] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-07 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Adam Barth.

Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522

Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.

No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.

platform/image-encoders/JPEGImageEncoder.cpp: (WebCore::jpegEmptyOutputBuffer):

6:13 PM Changeset in webkit [80520] by commit-queue@webkit.org

4 edits
2 adds in trunk

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

svg/dom/vkern-element-crash-expected.txt: Added.
svg/dom/vkern-element-crash.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

Test: svg/dom/vkern-element-crash.html

svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument):
svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument):

6:09 PM Changeset in webkit [80519] by ukai@chromium.org

3 edits in trunk/Source/WebCore

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80514.
http://trac.webkit.org/changeset/80514
https://bugs.webkit.org/show_bug.cgi?id=55915

Caused assertion failures (Requested by ukai on #webkit).

platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):

5:55 PM Changeset in webkit [80518] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-03-07 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] fast/js/navigator-language.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=55880

Add LANG variable to the clean environment when running
old-run-webkit-tests script.

Scripts/old-run-webkit-tests:

5:55 PM Changeset in webkit [80517] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark jquery/effects.html slow.

platform/chromium/test_expectations.txt:

5:51 PM Changeset in webkit [80516] by commit-queue@webkit.org

3 edits
5 adds in trunk

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

svg/custom/resources/rgb.svg: Added.
svg/custom/use-image-in-g-expected.checksum: Added.
svg/custom/use-image-in-g-expected.png: Added.
svg/custom/use-image-in-g-expected.txt: Added.
svg/custom/use-image-in-g.svg: Added.

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

The result of sourceURI must use the URL of the enclosing document as base.
Otherwise, the base may sometimes be empty, and, as a consequence,
the intermediate KURL object may be invalid.

Test: svg/custom/use-image-in-g.svg

svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):

5:49 PM Changeset in webkit [80515] by helder@sencha.com

5 edits
9 adds in trunk

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
fast/canvas/canvas-strokeRect-gradient-shadow.html: Added.
fast/canvas/script-tests/canvas-strokeRect-gradient-shadow.js: Added.
platform/chromium/test_expectations.txt: Skip new test since it fails.
platform/mac/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
platform/qt/Skipped: Skip new test since it fails.
platform/qt/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
svg/css/rect-gradient-stroke-shadow-expected.txt: Added.
svg/css/rect-gradient-stroke-shadow.svg: Added.

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html

svg/css/rect-gradient-stroke-shadow.svg

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeRect):

5:37 PM Changeset in webkit [80514] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-03-07 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

Fix for blurs behind bitmap images in Chromium, and boosting
shadow blur quality
Bug URLs:

https://bugs.webkit.org/show_bug.cgi?id=55410
https://bugs.webkit.org/show_bug.cgi?id=55506

No new tests. Covered by existing layout tests.

platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): Propagate the draw looper from context to painter

5:14 PM Changeset in webkit [80513] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Some fast/viewport tests are missing expectations.

platform/chromium/test_expectations.txt:

5:02 PM Changeset in webkit [80512] by andreas.kling@nokia.com

2 edits in trunk/Source/WebCore

2011-03-07 Andreas Kling <kling@webkit.org>

Unreviewed Mac build fix after r80508.

WebCore.exp.in:

4:57 PM Changeset in webkit [80511] by abarth@webkit.org

1 edit
125 adds in trunk/LayoutTests

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Import jquery test suite
https://bugs.webkit.org/show_bug.cgi?id=55911

This test suite is imported from https://github.com/jquery/jquery. I
tried to make as few changes as possible in case we want to merge with
upstream in the future. The test suite was original licensed under the
MIT license, which is compatible with WebKit's license.

jquery: Added.

4:50 PM Changeset in webkit [80510] by enrica@apple.com

3 edits
2 deletes in trunk/Source/WebCore

Unreviewed build fix.

Rolling back http://trac.webkit.org/changeset/80497 due to the
32-bit build failures.

WebCore.xcodeproj/project.pbxproj:
platform/mac/HTMLConverter.h: Removed.
platform/mac/HTMLConverter.mm: Removed.
platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

4:45 PM Changeset in webkit [80509] by dcheng@chromium.org

3 edits in trunk/LayoutTests

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Skip onpaste-text-html-types.html on Mac and Qt since parts of the test
infrastructure to support it aren't there.

platform/mac/Skipped:
platform/qt-wk2/Skipped:

4:36 PM Changeset in webkit [80508] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

2011-03-07 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.

page/FrameView.cpp: (WebCore::FrameView::setBaseBackgroundColor):
page/FrameView.h:

4:17 PM Changeset in webkit [80507] by abarth@webkit.org

3 edits
2 adds in trunk

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

fast/parser/document-write-into-initial-document-expected.txt: Added.
fast/parser/document-write-into-initial-document.html: Added.

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

The m_frame can disappear out from under us, and there's no point in
checking whether the load is complete in a non-existant frame.

Test: fast/parser/document-write-into-initial-document.html

dom/Document.cpp: (WebCore::Document::explicitClose):

3:57 PM Changeset in webkit [80506] by mitz@apple.com

2 edits in trunk/Source/WebKit/mac

LLVM Compiler build fix.

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkGrammarOfString):

3:50 PM Changeset in webkit [80505] by tony@chromium.org

1 edit
325 deletes in trunk/LayoutTests

2011-03-07 Tony Chang <tony@chromium.org>

Unreviewed, delete chromium layout test pngs that don't have
corresponding checksum files. They're not getting picked up by
run-webkit-tests without a checksum, so just remove them.

platform/chromium-linux/animations/suspend-transform-animation-expected.png: Removed.
platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Removed.
platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
platform/chromium-linux/svg/text/text-hkern-expected.png: Removed.
platform/chromium-linux/svg/text/text-vkern-expected.png: Removed.
platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Removed.
platform/chromium-mac-leopard/animations/3d/state-at-end-event-transform-expected.png: Removed.
platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Removed.
platform/chromium-mac/animations/state-at-end-event-expected.png: Removed.
platform/chromium-mac/editing/deleting/5390681-2-expected.png: Removed.
platform/chromium-mac/editing/execCommand/5138441-expected.png: Removed.
platform/chromium-mac/editing/execCommand/5481523-expected.png: Removed.
platform/chromium-mac/editing/execCommand/indent-selection-expected.png: Removed.
platform/chromium-mac/editing/selection/4960116-expected.png: Removed.
platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
platform/chromium-mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Removed.
platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Removed.
platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
platform/chromium-mac/fast/css/apple-prefix-expected.png: Removed.
platform/chromium-mac/fast/css/compare-content-style-expected.png: Removed.
platform/chromium-mac/fast/css/css3-space-in-nth-and-lang-expected.png: Removed.
platform/chromium-mac/fast/css/font-face-woff-expected.png: Removed.
platform/chromium-mac/fast/css/namespaces/namespaces-comments-expected.png: Removed.
platform/chromium-mac/fast/css/namespaces/namespaces-empty-expected.png: Removed.
platform/chromium-mac/fast/css/namespaces/namespaces-escapes-expected.png: Removed.
platform/chromium-mac/fast/css/namespaces/namespaces-invalid-at-expected.png: Removed.
platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png: Removed.
platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Removed.
platform/chromium-mac/fast/lists/anonymous-items-expected.png: Removed.
platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Removed.
platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Removed.
platform/chromium-mac/fast/overflow/line-clamp-expected.png: Removed.
platform/chromium-mac/fast/reflections/opacity-reflection-transform-expected.png: Removed.
platform/chromium-mac/fast/runin/generated2-expected.png: Removed.
platform/chromium-mac/fast/runin/generated3-expected.png: Removed.
platform/chromium-mac/fast/runin/generated4-expected.png: Removed.
platform/chromium-mac/fast/text/stripNullFromText-expected.png: Removed.
platform/chromium-mac/http/tests/misc/slow-loading-mask-expected.png: Removed.
platform/chromium-mac/media/video-transformed-expected.png: Removed.
platform/chromium-mac/svg/batik/text/textProperties-expected.png: Removed.
platform/chromium-mac/svg/css/css-box-min-width-expected.png: Removed.
platform/chromium-mac/svg/custom/container-opacity-clip-viewBox-expected.png: Removed.
platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.png: Removed.
platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.png: Removed.
platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
platform/chromium-mac/svg/custom/mask-invalidation-expected.png: Removed.
platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Removed.
platform/chromium-mac/svg/custom/transformedMaskFails-expected.png: Removed.
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug6674-expected.png: Removed.
platform/chromium-mac/transitions/transition-end-event-rendering-expected.png: Removed.
platform/chromium-mac/webarchive/test-link-rel-icon-expected.png: Removed.
platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Removed.
platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Removed.
platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Removed.
platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Removed.
platform/chromium-win-xp/svg/batik/text/textProperties-expected.png: Removed.
platform/chromium-win-xp/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Removed.
platform/chromium-win/fast/backgrounds/size/backgroundSize03-expected.png: Removed.
platform/chromium-win/fast/block/float/009-expected.png: Removed.
platform/chromium-win/fast/block/float/034-expected.png: Removed.
platform/chromium-win/fast/block/float/4145535Crash-expected.png: Removed.
platform/chromium-win/fast/block/float/br-with-clear-expected.png: Removed.
platform/chromium-win/fast/block/float/float-on-zero-height-line-expected.png: Removed.
platform/chromium-win/fast/block/float/narrow-after-wide-expected.png: Removed.
platform/chromium-win/fast/block/float/negative-margin-clear-expected.png: Removed.
platform/chromium-win/fast/block/float/nowrap-clear-min-width-expected.png: Removed.
platform/chromium-win/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Removed.
platform/chromium-win/fast/block/positioning/003-expected.png: Removed.
platform/chromium-win/fast/block/positioning/004-expected.png: Removed.
platform/chromium-win/fast/block/positioning/005-expected.png: Removed.
platform/chromium-win/fast/block/positioning/006-expected.png: Removed.
platform/chromium-win/fast/block/positioning/007-expected.png: Removed.
platform/chromium-win/fast/block/positioning/008-expected.png: Removed.
platform/chromium-win/fast/block/positioning/009-expected.png: Removed.
platform/chromium-win/fast/block/positioning/010-expected.png: Removed.
platform/chromium-win/fast/block/positioning/011-expected.png: Removed.
platform/chromium-win/fast/block/positioning/012-expected.png: Removed.
platform/chromium-win/fast/block/positioning/013-expected.png: Removed.
platform/chromium-win/fast/block/positioning/014-expected.png: Removed.
platform/chromium-win/fast/block/positioning/015-expected.png: Removed.
platform/chromium-win/fast/block/positioning/016-expected.png: Removed.
platform/chromium-win/fast/block/positioning/017-expected.png: Removed.
platform/chromium-win/fast/block/positioning/018-expected.png: Removed.
platform/chromium-win/fast/block/positioning/019-expected.png: Removed.
platform/chromium-win/fast/block/positioning/020-expected.png: Removed.
platform/chromium-win/fast/block/positioning/021-expected.png: Removed.
platform/chromium-win/fast/block/positioning/022-expected.png: Removed.
platform/chromium-win/fast/block/positioning/023-expected.png: Removed.
platform/chromium-win/fast/block/positioning/024-expected.png: Removed.
platform/chromium-win/fast/block/positioning/025-expected.png: Removed.
platform/chromium-win/fast/block/positioning/026-expected.png: Removed.
platform/chromium-win/fast/block/positioning/027-expected.png: Removed.
platform/chromium-win/fast/block/positioning/028-expected.png: Removed.
platform/chromium-win/fast/block/positioning/029-expected.png: Removed.
platform/chromium-win/fast/block/positioning/030-expected.png: Removed.
platform/chromium-win/fast/block/positioning/031-expected.png: Removed.
platform/chromium-win/fast/block/positioning/032-expected.png: Removed.
platform/chromium-win/fast/block/positioning/033-expected.png: Removed.
platform/chromium-win/fast/block/positioning/034-expected.png: Removed.
platform/chromium-win/fast/block/positioning/035-expected.png: Removed.
platform/chromium-win/fast/block/positioning/036-expected.png: Removed.
platform/chromium-win/fast/block/positioning/037-expected.png: Removed.
platform/chromium-win/fast/block/positioning/038-expected.png: Removed.
platform/chromium-win/fast/block/positioning/039-expected.png: Removed.
platform/chromium-win/fast/block/positioning/040-expected.png: Removed.
platform/chromium-win/fast/block/positioning/041-expected.png: Removed.
platform/chromium-win/fast/block/positioning/042-expected.png: Removed.
platform/chromium-win/fast/block/positioning/043-expected.png: Removed.
platform/chromium-win/fast/block/positioning/044-expected.png: Removed.
platform/chromium-win/fast/block/positioning/045-expected.png: Removed.
platform/chromium-win/fast/block/positioning/046-expected.png: Removed.
platform/chromium-win/fast/block/positioning/048-expected.png: Removed.
platform/chromium-win/fast/block/positioning/049-expected.png: Removed.
platform/chromium-win/fast/block/positioning/050-expected.png: Removed.
platform/chromium-win/fast/block/positioning/062-expected.png: Removed.
platform/chromium-win/fast/block/positioning/move-with-auto-width-expected.png: Removed.
platform/chromium-win/fast/block/positioning/relative-overconstrained-expected.png: Removed.
platform/chromium-win/fast/borders/outline-offset-min-assert-expected.png: Removed.
platform/chromium-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
platform/chromium-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
platform/chromium-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
platform/chromium-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
platform/chromium-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
platform/chromium-win/fast/clip/017-expected.png: Removed.
platform/chromium-win/fast/css/006-expected.png: Removed.
platform/chromium-win/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
platform/chromium-win/fast/css/content-dynamic-expected.png: Removed.
platform/chromium-win/fast/css/last-child-style-sharing-expected.png: Removed.
platform/chromium-win/fast/css/transition-color-unspecified-expected.png: Removed.
platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
platform/chromium-win/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Removed.
platform/chromium-win/fast/dom/css-cached-import-rule-expected.png: Removed.
platform/chromium-win/fast/dom/css-insert-import-rule-expected.png: Removed.
platform/chromium-win/fast/dom/delete-contents-expected.png: Removed.
platform/chromium-win/fast/dynamic/001-expected.png: Removed.
platform/chromium-win/fast/dynamic/005-expected.png: Removed.
platform/chromium-win/fast/dynamic/float-no-longer-overhanging-expected.png: Removed.
platform/chromium-win/fast/dynamic/float-withdrawal-2-expected.png: Removed.
platform/chromium-win/fast/dynamic/floating-to-positioned-2-expected.png: Removed.
platform/chromium-win/fast/dynamic/floating-to-positioned-expected.png: Removed.
platform/chromium-win/fast/dynamic/genContentDestroyChildren-expected.png: Removed.
platform/chromium-win/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Removed.
platform/chromium-win/fast/dynamic/staticY-expected.png: Removed.
platform/chromium-win/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
platform/chromium-win/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
platform/chromium-win/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
platform/chromium-win/fast/events/onloadFrameCrash-expected.png: Removed.
platform/chromium-win/fast/frames/002-expected.png: Removed.
platform/chromium-win/fast/frames/calculate-fixed-expected.png: Removed.
platform/chromium-win/fast/frames/calculate-order-expected.png: Removed.
platform/chromium-win/fast/frames/calculate-percentage-expected.png: Removed.
platform/chromium-win/fast/frames/calculate-relative-expected.png: Removed.
platform/chromium-win/fast/frames/calculate-round-expected.png: Removed.
platform/chromium-win/fast/frames/empty-cols-attribute-expected.png: Removed.
platform/chromium-win/fast/frames/empty-frame-src-expected.png: Removed.
platform/chromium-win/fast/frames/frame-length-fractional-expected.png: Removed.
platform/chromium-win/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
platform/chromium-win/fast/frames/no-frame-borders-expected.png: Removed.
platform/chromium-win/fast/images/image-in-map-expected.png: Removed.
platform/chromium-win/fast/images/pdf-as-tiled-background-expected.png: Removed.
platform/chromium-win/fast/images/svg-as-background-expected.png: Removed.
platform/chromium-win/fast/images/svg-as-image-expected.png: Removed.
platform/chromium-win/fast/images/svg-as-relative-image-expected.png: Removed.
platform/chromium-win/fast/images/svg-width-100p-as-background-expected.png: Removed.
platform/chromium-win/fast/inline-block/004-expected.png: Removed.
platform/chromium-win/fast/inline-block/005-expected.png: Removed.
platform/chromium-win/fast/invalid/015-expected.png: Removed.
platform/chromium-win/fast/invalid/table-residual-style-crash-expected.png: Removed.
platform/chromium-win/fast/js/exception-linenums-in-html-3-expected.png: Removed.
platform/chromium-win/fast/js/missing-style-end-tag-js-expected.png: Removed.
platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Removed.
platform/chromium-win/fast/layers/positioned-inside-root-with-margins-expected.png: Removed.
platform/chromium-win/fast/layers/zindex-ridonkulous-expected.png: Removed.
platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Removed.
platform/chromium-win/fast/overflow/position-relative-expected.png: Removed.
platform/chromium-win/fast/overflow/unreachable-content-test-expected.png: Removed.
platform/chromium-win/fast/parser/style-script-head-test-expected.png: Removed.
platform/chromium-win/fast/reflections/table-cell-expected.png: Removed.
platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
platform/chromium-win/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
platform/chromium-win/fast/replaced/008-expected.png: Removed.
platform/chromium-win/fast/table/024-expected.png: Removed.
platform/chromium-win/fast/table/031-expected.png: Removed.
platform/chromium-win/fast/table/caption-relayout-expected.png: Removed.
platform/chromium-win/fast/table/div-as-col-span-expected.png: Removed.
platform/chromium-win/fast/table/giantCellspacing-expected.png: Removed.
platform/chromium-win/fast/table/growCellForImageQuirk-expected.png: Removed.
platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Removed.
platform/chromium-win/fast/table/percent-widths-stretch-expected.png: Removed.
platform/chromium-win/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
platform/chromium-win/fast/text/align-center-rtl-spill-expected.png: Removed.
platform/chromium-win/fast/text/apply-start-width-after-skipped-text-expected.png: Removed.
platform/chromium-win/fast/text/fixed-pitch-control-characters-expected.png: Removed.
platform/chromium-win/fast/text/selection-painted-separately-expected.png: Removed.
platform/chromium-win/fast/text/soft-hyphen-3-expected.png: Removed.
platform/chromium-win/fast/text/stripNullFromText-expected.png: Removed.
platform/chromium-win/fast/tokenizer/missing-style-end-tag-1-expected.png: Removed.
platform/chromium-win/fast/tokenizer/missing-style-end-tag-2-expected.png: Removed.
platform/chromium-win/fast/tokenizer/script-after-frameset-expected.png: Removed.
platform/chromium-win/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Removed.
platform/chromium-win/svg/custom/SVGNumber-interface-expected.png: Removed.
platform/chromium-win/svg/custom/SVGPoint-interface-expected.png: Removed.
platform/chromium-win/svg/custom/SVGRect-interface-expected.png: Removed.
platform/chromium-win/svg/custom/attribute-namespace-check-expected.png: Removed.
platform/chromium-win/svg/custom/class-selector-expected.png: Removed.
platform/chromium-win/svg/custom/clip-path-child-changes-expected.png: Removed.
platform/chromium-win/svg/custom/clip-path-href-changes-expected.png: Removed.
platform/chromium-win/svg/custom/clip-path-units-changes-expected.png: Removed.
platform/chromium-win/svg/custom/clip-path-with-transform-expected.png: Removed.
platform/chromium-win/svg/custom/conditional-processing-outside-switch-expected.png: Removed.
platform/chromium-win/svg/custom/create-metadata-element-expected.png: Removed.
platform/chromium-win/svg/custom/createelement-expected.png: Removed.
platform/chromium-win/svg/custom/css-pixels-dpi-expected.png: Removed.
platform/chromium-win/svg/custom/display-none-expected.png: Removed.
platform/chromium-win/svg/custom/dynamic-viewBox-expected.png: Removed.
platform/chromium-win/svg/custom/evt-onload-expected.png: Removed.
platform/chromium-win/svg/custom/fill-update-expected.png: Removed.
platform/chromium-win/svg/custom/filter-source-alpha-expected.png: Removed.
platform/chromium-win/svg/custom/gradient-add-stops-expected.png: Removed.
platform/chromium-win/svg/custom/gradient-attr-update-expected.png: Removed.
platform/chromium-win/svg/custom/gradient-stop-style-change-expected.png: Removed.
platform/chromium-win/svg/custom/hover-default-fill-expected.png: Removed.
platform/chromium-win/svg/custom/image-with-aspect-ratio-stretch-expected.png: Removed.
platform/chromium-win/svg/custom/inner-percent-expected.png: Removed.
platform/chromium-win/svg/custom/inner-svg-hit-test-expected.png: Removed.
platform/chromium-win/svg/custom/invalid-transforms-expected.png: Removed.
platform/chromium-win/svg/custom/mask-excessive-malloc-expected.png: Removed.
platform/chromium-win/svg/custom/mask-inside-defs-expected.png: Removed.
platform/chromium-win/svg/custom/pattern-in-defs-expected.png: Removed.
platform/chromium-win/svg/custom/percentage-rect2-expected.png: Removed.
platform/chromium-win/svg/custom/poly-identify-expected.png: Removed.
platform/chromium-win/svg/custom/polyline-hittest-expected.png: Removed.
platform/chromium-win/svg/custom/polyline-invalid-points-expected.png: Removed.
platform/chromium-win/svg/custom/polyline-setattribute-points-null-expected.png: Removed.
platform/chromium-win/svg/custom/prevent-default-expected.png: Removed.
platform/chromium-win/svg/custom/repaint-on-image-bounds-change-expected.png: Removed.
platform/chromium-win/svg/custom/resource-client-removal-expected.png: Removed.
platform/chromium-win/svg/custom/rgbcolor-syntax-expected.png: Removed.
platform/chromium-win/svg/custom/rootelement-expected.png: Removed.
platform/chromium-win/svg/custom/scroll-hit-test-expected.png: Removed.
platform/chromium-win/svg/custom/sheet-title-expected.png: Removed.
platform/chromium-win/svg/custom/svg-absolute-children-expected.png: Removed.
platform/chromium-win/svg/custom/text-gradient-no-content-expected.png: Removed.
platform/chromium-win/svg/custom/transform-ignore-after-invalid-expected.png: Removed.
platform/chromium-win/svg/custom/transform-invalid-expected.png: Removed.
platform/chromium-win/svg/custom/transform-removeAttributeNS-expected.png: Removed.
platform/chromium-win/svg/custom/transform-scale-parse-expected.png: Removed.
platform/chromium-win/svg/custom/transform-with-ending-space-expected.png: Removed.
platform/chromium-win/svg/custom/transformedMaskFails-expected.png: Removed.
platform/chromium-win/svg/custom/use-empty-reference-expected.png: Removed.
platform/chromium-win/svg/custom/use-recalcStyle-crash-expected.png: Removed.
platform/chromium-win/svg/custom/use-symbol-overflow-expected.png: Removed.
platform/chromium-win/svg/custom/viewport-clip-expected.png: Removed.
platform/chromium-win/svg/custom/viewport-no-width-height-expected.png: Removed.
platform/chromium-win/svg/custom/viewport-update-expected.png: Removed.
platform/chromium-win/svg/custom/viewport-update2-expected.png: Removed.
platform/chromium-win/svg/custom/visibility-override-clip-expected.png: Removed.
platform/chromium-win/svg/custom/visibility-override-expected.png: Removed.
platform/chromium-win/svg/custom/visibility-override-mask-expected.png: Removed.
platform/chromium-win/svg/custom/xhtml-no-svg-renderer-expected.png: Removed.
platform/chromium-win/svg/custom/xml-stylesheet-expected.png: Removed.
platform/chromium-win/svg/hixie/dynamic/003-expected.png: Removed.
platform/chromium-win/svg/hixie/dynamic/004-expected.png: Removed.
platform/chromium-win/svg/hixie/dynamic/006-expected.png: Removed.
platform/chromium-win/svg/hixie/error/001-expected.png: Removed.
platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
platform/chromium-win/svg/hixie/error/006-expected.png: Removed.
platform/chromium-win/svg/hixie/error/007-expected.png: Removed.
platform/chromium-win/svg/hixie/error/008-expected.png: Removed.
platform/chromium-win/svg/hixie/error/009-expected.png: Removed.
platform/chromium-win/svg/hixie/error/014-expected.png: Removed.
platform/chromium-win/svg/hixie/error/014-test-expected.png: Removed.
platform/chromium-win/svg/hixie/error/015-expected.png: Removed.
platform/chromium-win/svg/hixie/error/016-expected.png: Removed.
platform/chromium-win/svg/hixie/painting/001-expected.png: Removed.
platform/chromium-win/svg/hixie/processing-model/005-expected.png: Removed.
platform/chromium-win/svg/hixie/rendering-model/003a-expected.png: Removed.
platform/chromium-win/svg/hixie/use/001-expected.png: Removed.
platform/chromium-win/svg/hixie/use/002-expected.png: Removed.
platform/chromium-win/svg/hixie/use/002-test-expected.png: Removed.
platform/chromium-win/svg/hixie/viewbox/001-expected.png: Removed.
platform/chromium-win/svg/hixie/viewbox/002-expected.png: Removed.
platform/chromium-win/svg/hixie/viewbox/003-expected.png: Removed.
platform/chromium-win/svg/hixie/viewbox/004-expected.png: Removed.
platform/chromium-win/svg/webarchive/svg-script-subresouces-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug103533-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug222336-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug222467-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug269566-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug277062-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug28933-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug2954-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
platform/chromium-win/tables/mozilla/bugs/bug9024-expected.png: Removed.
platform/chromium-win/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
platform/chromium-win/transitions/transition-end-event-rendering-expected.png: Removed.
platform/chromium-win/webarchive/archive-with-unencoded-url-expected.png: Removed.
platform/chromium-win/webarchive/test-body-background-expected.png: Removed.
platform/chromium-win/webarchive/test-img-src-expected.png: Removed.
platform/chromium-win/webarchive/test-input-src-expected.png: Removed.
platform/chromium-win/webarchive/test-link-rel-icon-expected.png: Removed.
platform/chromium-win/webarchive/test-object-data-expected.png: Removed.
platform/chromium-win/webarchive/test-script-src-expected.png: Removed.
platform/chromium-win/webarchive/test-table-background-expected.png: Removed.
platform/chromium-win/webarchive/test-td-background-expected.png: Removed.
platform/chromium-win/webarchive/test-xml-stylesheet-expected.png: Removed.

3:40 PM Changeset in webkit [80504] by tony@chromium.org

1 edit
1 add in trunk/Tools

2011-03-07 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Find .checksum files without .pngs and vice-versa
https://bugs.webkit.org/show_bug.cgi?id=55236

Scripts/find-mismatched-layout-test-results: Added. A script for finding

mismatched results.

3:18 PM Changeset in webkit [80503] by xji@chromium.org

2 edits in trunk/LayoutTests

2011-03-07 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip test caretRangeFromPoint-in-zoom-and-scroll.html in mac-wk2 since
EventSender.mouseMoveTo is not yet supported.

platform/mac-wk2/Skipped:

3:14 PM Changeset in webkit [80502] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80500.
http://trac.webkit.org/changeset/80500
https://bugs.webkit.org/show_bug.cgi?id=55908

Caused mysterious GYP error (Requested by abarth on #webkit).

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

2:54 PM Changeset in webkit [80501] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Fix Chromium Mac build. This header should only be included when the
feature is enabled.

platform/cf/RunLoopTimerCF.cpp:

2:37 PM Changeset in webkit [80500] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add WML files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55905

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

2:34 PM Changeset in webkit [80499] by enne@google.com

2 edits in trunk/Source/WebCore

2011-03-07 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Add missing include to #define Skia parameter
https://bugs.webkit.org/show_bug.cgi?id=55885

platform/graphics/chromium/ShaderChromium.h:

2:31 PM Changeset in webkit [80498] by Chris Fleizach

17 edits in trunk

Source/WebCore: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

WebCore.exp.in:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootObjectForFrame):

accessibility/AXObjectCache.h:
accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):

accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::firstChild):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/mac: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
returns the scroll bar objects).
Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
will expect that as its child, instead of the WebCore ScrollView object.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Tools: AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.

DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::focusedElement):

Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
because it could change at any time.

(AccessibilityController::rootElement):

LayoutTests: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

platform/mac/accessibility/webkit-scrollarea-expected.txt:
platform/mac/accessibility/webkit-scrollarea-position-expected.txt:
platform/mac/accessibility/webkit-scrollarea-position.html:
platform/mac/accessibility/webkit-scrollarea.html:

2:13 PM Changeset in webkit [80497] by enrica@apple.com

3 edits
2 adds in trunk/Source/WebCore

REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

WebCore.xcodeproj/project.pbxproj: Added new file.
platform/mac/HTMLConverter.h: Added.
platform/mac/HTMLConverter.mm: Added.
platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

2:04 PM Changeset in webkit [80496] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some missing platform files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55897

There are a bunch more, but this is a start.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

1:56 PM Changeset in webkit [80495] by barraclough@apple.com

4 edits in trunk

Source/JavaScriptCore: Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

Patch by Yuta Kitamura <yutak@chromium.org> on 2011-03-06
Reviewed by Kent Tamura.

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

GNUmakefile.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/MD5.cpp:

(WTF::MD5::MD5):

wtf/SHA1.cpp: Added.

(WTF::testSHA1): This function will be run the first time SHA1
constructor is called. This function computes a few hash values
and checks the results in debug builds. However, constructor is
probably not a good place to run these tests, so we need to find
a good place for it (bug 55853).
(WTF::expectSHA1):
(WTF::f):
(WTF::k):
(WTF::rotateLeft):
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):
(WTF::SHA1::finalize):
(WTF::SHA1::processBlock):
(WTF::SHA1::reset):

wtf/SHA1.h: Added.

(WTF::SHA1::addBytes):

wtf/wtf.pri:

LayoutTests: Bug 55815 - Should throw an exception from JSObject::defineOwnProperty if !isExtensible().

Reviewed by Cameron Zwarich.

ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:

Now with added passingness!

1:52 PM Changeset in webkit [80494] by steveblock@google.com

7 edits
2 moves in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55879

No new tests, refactoring only.

Android.v8bindings.mk:
WebCore.gypi:
bridge/jni/v8/JavaClassV8.cpp:
bridge/jni/v8/JavaClassV8.h:
bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp. (JavaField::JavaField):
bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaField::type): (JSC::Bindings::JavaField::getJNIType):
bridge/jni/v8/JavaInstanceV8.cpp:
bridge/jni/v8/JavaNPObjectV8.cpp:

1:31 PM Changeset in webkit [80493] by dcheng@chromium.org

9 edits
2 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
platform/chromium/ChromiumDataObject.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
platform/chromium/ClipboardMimeTypes.cpp:
platform/chromium/ClipboardMimeTypes.h:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This requires a DEPS roll for a Chromium-side change to support DRT testing of
event.dataTransfer.types.

DEPS:

1:22 PM Changeset in webkit [80492] by xji@chromium.org

8 edits in trunk/LayoutTests

2011-03-07 Xiaomei Ji <xji@chromium.org>

Reviewed by Martin Robinson.

Make fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html less port-dependent.
Preiously, the test clicked at a specific pixel so different fonts result in slightly different positions.
Change the test to click on a specific character offset.
https://bugs.webkit.org/show_bug.cgi?id=30816

fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt:
fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:

1:01 PM Changeset in webkit [80491] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-07 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Clean up fast/viewport expectations and remove a test that no longer
crashes (the underlying V8 bug was fixed).

platform/chromium/test_expectations.txt:

12:52 PM Changeset in webkit [80490] by Joseph Pecoraro

61 edits
6 adds in trunk/LayoutTests

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Include expected results for r80483.

Numerous LayoutTests/fast/viewport tests.

12:43 PM Changeset in webkit [80489] by commit-queue@webkit.org

8 edits in trunk/Source

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Use preferred locale information when choosing fallback
font using fontconfig on Linux platform.
http://bugs.webkit.org/show_bug.cgi?id=55453

No new tests, as it depends on ICU and locale setting, so it will be
covered by Chromium side.

platform/chromium/PlatformBridge.h:
platform/graphics/chromium/FontCacheLinux.cpp:

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

Use preferred locale information when choosing fallback font using
fontconfig on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=55453

Tests will be covered by Chromium side.

public/gtk/WebFontInfo.h: (WebKit::WebFontInfo::familyForChars): added 3rd parameter |preferredLocale|
public/linux/WebSandboxSupport.h: (WebKit::WebSandboxSupport::getFontFamilyForCharacters): added 3rd parameter |preferredLocale|
src/PlatformBridge.cpp:
src/gtk/WebFontInfo.cpp:

12:31 PM BuildingQtOnLinux edited by srikumar.b@gmail.com

by default, ubuntu does not come with g++. And aptitude tells unknown … (diff)

12:14 PM Changeset in webkit [80488] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add gobject, cpp, and objc bindings to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55892

These are also excluded from the Chromium build but needed for various
other ports.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

12:10 PM Changeset in webkit [80487] by commit-queue@webkit.org

5 edits
2 adds in trunk

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

fast/dom/dom-method-document-change-expected.txt: Added.
fast/dom/dom-method-document-change.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

Test: fast/dom/dom-method-document-change.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
dom/Node.cpp: (WebCore::Node::checkReplaceChild): (WebCore::Node::checkAddChild):
dom/Node.h:

11:55 AM Changeset in webkit [80486] by dcheng@chromium.org

7 edits
2 deletes in trunk

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

editing/pasteboard/onpaste-text-html-types-expected.txt: Removed.
editing/pasteboard/onpaste-text-html-types.html: Removed.

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types):
platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsFilenames):
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
platform/chromium/ClipboardMimeTypes.cpp:
platform/chromium/ClipboardMimeTypes.h:

11:52 AM Changeset in webkit [80485] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add missing bindings/js files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55888

These files are excluded from the Chromium build but needed for the Mac
build.

WebCore.gypi:

11:48 AM Changeset in webkit [80484] by dcheng@chromium.org

7 edits
2 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
platform/chromium/ChromiumDataObject.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
platform/chromium/ClipboardMimeTypes.cpp:
platform/chromium/ClipboardMimeTypes.h:

11:41 AM Changeset in webkit [80483] by Joseph Pecoraro

4 edits
6 adds in trunk

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Added tests specifically to test Console warnings.

fast/viewport/viewport-warnings-1.html: Added.
fast/viewport/viewport-warnings-2.html: Added.
fast/viewport/viewport-warnings-3.html: Added.
fast/viewport/viewport-warnings-4.html: Added.
fast/viewport/viewport-warnings-5.html: Added.
fast/viewport/viewport-warnings-6.html: Added.

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Correct and improve the error messages for viewport parsing.

Tests: fast/viewport/viewport-warnings-1.html

fast/viewport/viewport-warnings-2.html
fast/viewport/viewport-warnings-3.html
fast/viewport/viewport-warnings-4.html
fast/viewport/viewport-warnings-5.html
fast/viewport/viewport-warnings-6.html

dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findSizeValue): remove incorrect device-width / height tips. (WebCore::setViewportFeature): report a warning for an unrecognized key. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key. (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
dom/ViewportArguments.h: removed no longer used warnings.

11:37 AM Changeset in webkit [80482] by jamesr@google.com

9 edits in trunk/Source

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

This splits up LayerRendererChromium::drawLayers() into two phases,
one that updates layers and one that actually draws them. Most of the
patch is moving the bodies of drawLayers() and updateLayersRecursive()
into smaller helper functions.

The main entry point is renamed updateAndDrawLayers(), but otherwise
has the same signature as drawLayers() did. Internally it does the
following:

1.) Updates the root layer's contents
2.) Updates the root layer's scrollbars
3.) Updates the RenderSurface tree and the contents of all child
layers
4.) Draws the root layer and root layer scrollbars
5.) Draws all child layers using the previously updated
CCLayerImpl/RenderSurface data.

A few things still need to be done after this patch to complete the separation
of the update and draw step, but they can happen in later patches:
*) The root layer and root layer scrollbars contents should be
uploaded to textures at draw time, not update time.
*) The RenderSurface tree should be updated at draw time, not update
time.

Covered by the compositing/ tests.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::updateRootLayerScrollbars): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateContentsRecursive): (WebCore::LayerRendererChromium::drawLayer):
platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::visibleRectSize):
platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
platform/graphics/chromium/cc/CCLayerImpl.cpp:
platform/graphics/chromium/cc/CCLayerImpl.h:

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the "update" and "draw" portions of LayerRendererChromium's drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

Call updated LayerRendererChromium APIs.

src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::doComposite):

11:34 AM Changeset in webkit [80481] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sort WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55887

These files should be in order. This is preparation for adding in the
missing files.

WebCore.gypi:

11:19 AM Changeset in webkit [80480] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Unreviewed buildfix after r80478.

dom/Document.cpp: Add suggested parentheses to make GCC happy.

(WebCore::Document::didReceiveTask):

11:05 AM Changeset in webkit [80479] by weinig@apple.com

13 edits in trunk

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::unableToImplementPolicy):
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebPolicyClient.cpp: (WebKit::WebPolicyClient::unableToImplementPolicy):
UIProcess/WebPolicyClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: (WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):
WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): Pipe unableToImplementPolicy through both the bundle and the main WebKit2 API.

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Update policy client initialization struct for new member.

10:54 AM Changeset in webkit [80478] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WebCore

2011-03-07 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401

Manual test added: manual-tests/database-callback-deferred.html.

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::didReceiveTask): (WebCore::Document::postTask): (WebCore::Document::pendingTasksTimerFired): (WebCore::Document::willDeferLoading): (WebCore::Document::didResumeLoading):
dom/Document.h:
manual-tests/database-callback-deferred.html: Added.
page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

10:53 AM Changeset in webkit [80477] by Antti Koivisto

3 edits in trunk/Source/WebCore

Use HashMaps for caching primitive values
https://bugs.webkit.org/show_bug.cgi?id=55873

Reviewed by Sam Weinig.

Most documents use only small subset of cacheable primitive values. By replacing
fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
expanding the range of cacheable values.

css/CSSPrimitiveValueCache.cpp:

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

css/CSSPrimitiveValueCache.h:

10:50 AM Changeset in webkit [80476] by steveblock@google.com

8 edits
1 copy
1 move
2 adds
1 delete in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55881

No new tests, refactoring only.

Android.jscbindings.mk:
GNUmakefile.am:
WebCore.xcodeproj/project.pbxproj:
bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
bridge/jni/jsc/JNIBridgeJSC.h: Removed.
bridge/jni/jsc/JNIUtilityPrivate.cpp:
bridge/jni/jsc/JavaClassJSC.cpp:
bridge/jni/jsc/JavaClassJSC.h:
bridge/jni/jsc/JavaInstanceJSC.cpp:

10:28 AM Changeset in webkit [80475] by weinig@apple.com

48 edits in trunk

Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827

Reviewed by Anders Carlsson.

Source/WebCore:

loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):

loader/FrameLoaderClient.h:
loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkContentPolicy):

loader/PolicyChecker.h:

Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

Source/WebKit/chromium:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForResponse):

src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):

WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):

WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForResponse):

WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Source/WebKit/qt:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebFrame.cpp:

(WebFrame::dispatchDecidePolicyForResponse):

WebFrame.h:

Source/WebKit/wince:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):

WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDecidePolicyForResponse):

WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse and pass the entire response, instead of just the MIMEType.
Updated both UIProcess API and bundle API to also be based on the whole response, not just the MIMEType.

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForResponse):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForResponse):

UIProcess/WebPolicyClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):

WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForResponse):
(-[BrowserWindowController awakeFromNib]):

TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Update tools for new name.

10:20 AM Changeset in webkit [80474] by bulach@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-03-07 Marcus Bulach <bulach@chromium.org>

Reviewed by Dan Bernstein.

WebViewImpl::focusedWebCoreFrame() should be const.
https://bugs.webkit.org/show_bug.cgi?id=55870

src/WebViewImpl.cpp: (WebKit::WebViewImpl::focusedWebCoreFrame):
src/WebViewImpl.h:

10:13 AM Changeset in webkit [80473] by eric.carlson@apple.com

13 edits in trunk/Source

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>

No new tests, this is just more plumbing.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
html/HTMLMediaElement.h:

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions. (WebCore::addMediaEngine): Ditto. (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
platform/graphics/MediaPlayer.h:

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.

platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267

src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::registerSelf): Update for MediaEngineRegistrar change.

10:09 AM Changeset in webkit [80472] by steveblock@google.com

12 edits
1 copy
2 moves in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55774

No new tests, refactoring only.

Android.jscbindings.mk:
Android.v8bindings.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature): (JavaMethod::JNIReturnType): (JavaMethod::methodID):
bridge/jni/JavaMethod.h: (JSC::Bindings::JavaMethod::name): (JSC::Bindings::JavaMethod::returnType): (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters): (JSC::Bindings::JavaMethod::isStatic):
bridge/jni/JavaString.h: (JSC::Bindings::JavaString::JavaString): (JSC::Bindings::JavaString::utf8): (JSC::Bindings::JavaString::length): (JSC::Bindings::JavaString::impl):
bridge/jni/jni_jsobject.mm:
bridge/jni/jsc/JNIBridgeJSC.h:
bridge/jni/v8/JNIBridgeV8.h:
bridge/jni/v8/JavaClassV8.cpp:
bridge/jni/v8/JavaClassV8.h:
bridge/jni/v8/JavaInstanceV8.cpp:

9:33 AM Changeset in webkit [80471] by jorlow@chromium.org

16 edits in trunk

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBIndex, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update.html:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

This brings us in line with what's in the spec:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html

storage/IDBCursor.cpp: (WebCore::IDBCursor::create): (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::source):
storage/IDBCursor.h:
storage/IDBCursor.idl:
storage/IDBCursorWithValue.cpp: (WebCore::IDBCursorWithValue::create): (WebCore::IDBCursorWithValue::IDBCursorWithValue):
storage/IDBCursorWithValue.h:
storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex):
storage/IDBIndex.h: (WebCore::IDBIndex::create): (WebCore::IDBIndex::objectStore):
storage/IDBIndex.idl:
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index):
storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):

9:20 AM Changeset in webkit [80470] by Chris Fleizach

3 edits
2 adds in trunk

AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
https://bugs.webkit.org/show_bug.cgi?id=55735

Reviewed by Beth Dakin.

Source/WebCore:

The ARIA grid implementation needed to verify the row/column range of a cell instead of
assuming a 1-1 mapping between children and row/column.

Test: platform/mac/accessibility/aria-table-with-colspan-cells.html

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

LayoutTests:

platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
platform/mac/accessibility/aria-table-with-colspan-cells.html: Added.

8:47 AM Changeset in webkit [80469] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

Bump version.

win/tools/scripts/VERSION:

7:38 AM Changeset in webkit [80468] by andreip@google.com

9 edits in trunk/Source

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
IDBObjectStore objects used to be created asynchronously, so we needed
this method to be invoked, with the new object store as the parameter,
whenever the creation succeeded. The spec has changed so that IDBObjectStore
objects are created synchronously, so this method is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=55777

No new tests, just refactoring.

storage/IDBCallbacks.h:
storage/IDBRequest.cpp:
storage/IDBRequest.h:

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
https://bugs.webkit.org/show_bug.cgi?id=55777

src/IDBCallbacksProxy.cpp:
src/IDBCallbacksProxy.h:
src/WebIDBCallbacksImpl.cpp:
src/WebIDBCallbacksImpl.h:

7:15 AM Changeset in webkit [80467] by steveblock@google.com

8 edits in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaParameter should be removed
https://bugs.webkit.org/show_bug.cgi?id=55772

No new tests, refactoring only.

bridge/jni/JNIBridge.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (JavaMethod::signature):
bridge/jni/JNIBridge.h: (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters):
bridge/jni/JNIUtility.h:
bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
bridge/jni/v8/JNIUtilityPrivate.h:
bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):

5:39 AM Changeset in webkit [80466] by andreip@google.com

2 edits in trunk/LayoutTests

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

[Chromium] test_expectations.txt cannot be parsed correctly
https://bugs.webkit.org/show_bug.cgi?id=55871

platform/chromium/test_expectations.txt:

4:20 AM Changeset in webkit [80465] by andreas.kling@nokia.com

1 edit
6 adds in trunk/LayoutTests

2011-03-07 Kenneth Rohde Christiansen <kenneth@webkit.org>

Unreviewed.

Add expected results to the new viewport tests

fast/viewport/viewport-91-expected.txt: Added.
fast/viewport/viewport-92-expected.txt: Added.
fast/viewport/viewport-93-expected.txt: Added.
fast/viewport/viewport-94-expected.txt: Added.
fast/viewport/viewport-95-expected.txt: Added.
fast/viewport/viewport-96-expected.txt: Added.

3:23 AM Changeset in webkit [80464] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/inspector/resource-parameters.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55867

platform/qt/Skipped: Add http/tests/inspector/resource-parameters.html to make buildbot happy.

3:19 AM Changeset in webkit [80463] by Antti Koivisto

16 edits
5 adds in trunk

Source/WebCore: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

Make CSS primitive value cache per-document.

Test: http/tests/security/cross-origin-css-primitive.html

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionXY):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitNumber):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

css/CSSParser.h:

(WebCore::CSSParser::primitiveValueCache):

css/CSSPrimitiveValue.cpp:
css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createColor):
(WebCore::CSSPrimitiveValue::create):

css/CSSPrimitiveValueCache.cpp: Added.

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

css/CSSPrimitiveValueCache.h: Added.

(WebCore::CSSPrimitiveValueCache::create):
(WebCore::CSSPrimitiveValueCache::createValue):

dom/Document.cpp:

(WebCore::Document::cssPrimitiveValueCache):

dom/Document.h:

LayoutTests: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

http/tests/security/cross-origin-css-primitive-expected.txt: Added.
http/tests/security/cross-origin-css-primitive.html: Added.
http/tests/security/resources/cross-origin-css-primitive-iframe.html: Added.

2:40 AM Changeset in webkit [80462] by alex

1 edit
6 adds in trunk/LayoutTests

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Added new GTK+ test results.

platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
platform/gtk/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
platform/gtk/fast/text/hyphenate-limit-before-after-expected.png: Added.
platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt: Added.

1:55 AM Changeset in webkit [80461] by ukai@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80458.
http://trac.webkit.org/changeset/80458
https://bugs.webkit.org/show_bug.cgi?id=55863

caused tests to crash on several chromium bots (Requested by
ukai on #webkit).

src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
src/AssociatedURLLoader.h:

1:35 AM Changeset in webkit [80460] by alex

2 edits in trunk/LayoutTests

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Skipped failing test that requires a missing feature in
layoutTestController. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=55862

platform/gtk/Skipped:

1:25 AM Changeset in webkit [80459] by abarth@webkit.org

4 edits in trunk/Source

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Filter sources in WebCore GYP build for Mac
https://bugs.webkit.org/show_bug.cgi?id=55857

This patch removes a large number of files that do not build as part of
the Mac build. I'm not fully sold on this method of
including/excluding files, but it's the "gyp way" so we should probably
try it first.

This patch also sets xcode_list_excluded_files to 0, which removes the
excluded files from the Xcode project file, which is necessary in order
to prevent the header map feature from including the wrong header file.

gyp/WebCore.gyp:

12:46 AM Changeset in webkit [80458] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

2011-03-07 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925

No tests needed. Exposes no new functionality.

src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
src/AssociatedURLLoader.h: (WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):

12:20 AM Changeset in webkit [80457] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed EFL build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=55858

platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):

12:19 AM Changeset in webkit [80456] by commit-queue@webkit.org

44 edits in trunk/LayoutTests

2011-03-07 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Tony Gentilcore.

In layout tests, iframe's onload handler should not use script function
defined after the iframe.
https://bugs.webkit.org/show_bug.cgi?id=54942

Found and fixed more tests in addition to the first patch to bug 54942.
Tried best to avoid expectation changes.

editing/execCommand/find-after-replace.html:
editing/input/option-page-up-down.html:
editing/input/scroll-viewport-page-up-down.html:
editing/pasteboard/copy-standalone-image.html:
editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
editing/pasteboard/paste-noscript-xhtml.xhtml:
editing/selection/drag-in-iframe.html:
editing/undo/undo-iframe-location-change.html:
fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:
fast/dom/DOMImplementation/createDocument-with-used-doctype.html:
fast/dom/Window/window-postmessage-clone-frames.html:
fast/dynamic/paused-event-dispatch.html:
fast/events/keydown-remove-frame.html:
fast/events/mousedown-in-subframe-scrollbar.html:
fast/frames/content-opacity-2.html:
fast/frames/viewsource-plain-text-tags.html:
fast/frames/viewsource-unfinished-tags.html:
fast/history/form-submit-in-frame-via-onclick.html:
fast/history/form-submit-in-frame.html:
fast/xsl/xslt-text-expected.txt:
fast/xsl/xslt-text.html:
http/tests/messaging/cross-domain-message-send.html:
http/tests/misc/cached-scripts-expected.txt:
http/tests/misc/cached-scripts.html:
http/tests/plugins/post-url-file-expected.txt:
http/tests/plugins/post-url-file.html:
http/tests/security/listener/xss-inactive-closure-expected.html:
http/tests/security/listener/xss-inactive-closure.html:
http/tests/security/postMessage/delivery-order.html:
http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
http/tests/security/postMessage/invalid-origin-throws-exception.html:
http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
http/tests/security/postMessage/target-origin.html:
http/tests/security/xss-DENIED-getSVGDocument-iframe.html:
http/tests/xmlhttprequest/detaching-frame-2.html:
media/media-document-audio-repaint.html:
media/media-document-audio-size.html:
platform/mac/fast/dom/wrapper-classes-objc.html:
platform/mac/fast/loader/non-html-load-event-expected.txt:
platform/mac/fast/loader/non-html-load-event.html:
scrollbars/hidden-iframe-scrollbar-crash2.html:
storage/close-during-stress-test.html:
svg/custom/js-update-transform-changes.svg:

Mar 6, 2011:

11:57 PM Changeset in webkit [80455] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

inspector/styles/styles-add-blank-property.html becomes flaky.

platform/chromium/test_expectations.txt:

11:22 PM Changeset in webkit [80454] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewd, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109) on Mac

platform/chromium/fast/text/international/complex-text-rectangle.html

platform/chromium/test_expectations.txt:

10:25 PM Changeset in webkit [80453] by tkent@chromium.org

1 edit
5 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium expectation files for r80449.

platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.

10:02 PM Changeset in webkit [80452] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webcore_derived_source_files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55856

This is the list of files generated by the Mac port. It's possible
other ports generate a different list of files.

WebCore.gypi:
gyp/WebCore.gyp:

9:41 PM Changeset in webkit [80451] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium.
https://bugs.webkit.org/show_bug.cgi?id=55844

Chromium will find it useful to know the page dismissal status (i.e.,
whether a frame is in the midst of executing a beforeunload or unload
handler), so expose that information through the chromium port in the
WebKit API.

This is my second attempt at this patch. The previous one broke
downstream Chromium builds of some unit tests which had classes derived
from WebFrame (and thus became uninstantiable because of this new pure
virtual method). Those have now been fixed (http://crrev.com/77101).

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
src/WebFrameImpl.h:

9:14 PM Changeset in webkit [80450] by tkent@chromium.org

1 edit
3 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add a Mac expectation for a new test of r80449.

platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.

9:12 PM Changeset in webkit [80449] by tkent@chromium.org

3 edits
4 adds in trunk

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.

Test: fast/forms/input-appearance-spinbutton-visibility.html

rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

fast/forms/input-appearance-spinbutton-visibility.html: Added for the test to make sure input type=number spin buttons are shown or hidden correctly with Javascript.
platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added for the expectation checksum.
platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added for the expectation image.
platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added for the expectation render tree txt.

8:50 PM Changeset in webkit [80448] by commit-queue@webkit.org

2 edits
1 add in trunk/Source/WebCore

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.

Test: manual-tests/popup-width-restriction-within-screen.html

manual-tests/popup-width-restriction-within-screen.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.

8:02 PM Changeset in webkit [80447] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80440 (bug 55854) also on mac.

fast/forms/onchange-setvalueforuser.html

platform/chromium/test_expectations.txt:

7:17 PM Changeset in webkit [80446] by yutak@chromium.org

11 edits
3 adds in trunk/Source

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

GNUmakefile.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/MD5.cpp: (WTF::MD5::MD5):
wtf/SHA1.cpp: Added. (WTF::testSHA1): This function will be run the first time SHA1 constructor is called. This function computes a few hash values and checks the results in debug builds. However, constructor is probably not a good place to run these tests, so we need to find a good place for it (bug 55853). (WTF::expectSHA1): (WTF::f): (WTF::k): (WTF::rotateLeft): (WTF::SHA1::SHA1): (WTF::SHA1::addBytes): (WTF::SHA1::computeHash): (WTF::SHA1::finalize): (WTF::SHA1::processBlock): (WTF::SHA1::reset):
wtf/SHA1.h: Added. (WTF::SHA1::addBytes):
wtf/wtf.pri:

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

ForwardingHeaders/wtf/SHA1.h: Added.

6:23 PM Changeset in webkit [80445] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109)

fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
platform/chromium/fast/text/international/complex-text-rectangle.html
svg/css/getComputedStyle-basic.xhtml
fast/text/hyphenate-limit-before-after.html

Regression at WebKit r80440 (bug 55854)

fast/forms/onchange-setvalueforuser.html

platform/chromium/test_expectations.txt:

5:35 PM Changeset in webkit [80444] by mitz@apple.com

2 edits in trunk/Source/WebKit/mac

LLVM Compiler build fix.

DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setValueForUser:]):

5:11 PM Changeset in webkit [80443] by dbates@webkit.org

2 edits in trunk/Tools

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel and David Kilzer.

Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
https://bugs.webkit.org/show_bug.cgi?id=55503

Fix misspelled word "Dowloads" [sic] in the message printed to standard output
in checkForJavaSDK().

Also, remove extraneous space in function prototype for unlinkZeroFiles.

Scripts/build-webkit:

5:00 PM Changeset in webkit [80442] by eric.carlson@apple.com

11 edits in trunk/Source/WebCore

2011-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

QuickTime based media engines should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55848

No new tests, it is only possible to test this by manually deleting and monitoring the
the Quicktime caches.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing. (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine. (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when

creating new movie.

(WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in

m_privateBrowsing and set movie attribute.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):

Initialize m_privateBrowsing.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store

privacy setting in m_privateBrowsing and call QTMovie.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing. (QTMovie::load):Pass private browsing property when creating new movie. (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and

set movie property.

platform/graphics/win/QTMovie.h:

4:44 PM Changeset in webkit [80441] by mitz@apple.com

2 edits
1 move in trunk/LayoutTests

Updated more platform-specific results after r80438.

platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Copied from platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt.

4:34 PM Changeset in webkit [80440] by mitz@apple.com

4 edits
1 add in trunk/LayoutTests

Updated platform-specific results after r80438.

platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

4:22 PM Changeset in webkit [80439] by dbates@webkit.org

4 edits
2 adds in trunk

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
the value for border-spacing from the value of the WebKit internal CSS
property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.

The CSS property border-spacing describes the horizontal and vertical border
spacing for an HTML Table element. Notice, WebKit internally represents the value
of this property as two properties: -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
respectively. And WebKit doesn't know to reconstitute these internal properties.
Therefore style.borderSpacing always returns the empty string.

Test: fast/css/table-border-spacing.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
css/CSSMutableStyleDeclaration.h:

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Tests that style.borderSpacing returns the correct result for valid, negative, and missing border-spacing values.

fast/css/table-border-spacing-expected.txt: Added.
fast/css/table-border-spacing.html: Added.

2:44 PM Changeset in webkit [80438] by mitz@apple.com

13 edits
6 adds in trunk

<rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=55850

Reviewed by Oliver Hunt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit.html

fast/text/hyphenate-limit-before-after.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedProperties) Updated this array with the new properties and some old properties
that it was missing.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
CSSPropertyWebkitHyphenateLimit{Before,After}.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
'auto' and non-negative integers.

css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.

rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
allow hyphenation if the prefix and the suffix are sufficiently long.
(WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitBefore): Added.
(WebCore::InheritedFlags::hyphenationLimitAfter): Added.
(WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
(WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
(WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
representation of 'auto'.
(WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
(WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.

rendering/style/StyleRareInheritedData.h:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/parsing-hyphenate-limit-expected.txt: Added.
fast/css/parsing-hyphenate-limit.html: Added.
fast/text/hyphenate-limit-before-after.html: Added.
platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
platform/mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
platform/mac/fast/text/hyphenate-limit-before-after-expected.txt: Added.
svg/css/getComputedStyle-basic-expected.txt:

2:00 PM Changeset in webkit [80437] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80436.
http://trac.webkit.org/changeset/80436
https://bugs.webkit.org/show_bug.cgi?id=55849

Broke Chromium compile across the board (Requested by dglazkov
on #webkit).

public/WebFrame.h:
src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

12:36 PM Changeset in webkit [80436] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium
https://bugs.webkit.org/show_bug.cgi?id=55844

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
src/WebFrameImpl.h:

10:39 AM Changeset in webkit [80435] by jberlin@webkit.org

19 edits in trunk

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Sam Weinig.

Source/WebCore:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

WebCore.exp.in:

Add the new WKSI functions.

platform/mac/WebCoreSystemInterface.h:

Ditto.

platform/mac/WebCoreSystemInterface.mm:

Ditto.

platform/mac/CookieJar.mm:

(WebCore::cookies):
If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
Otherwise, behave the same as before.
(WebCore::cookieRequestHeaderFieldValue):
Ditto.
(WebCore::setCookies):
Ditto.
(WebCore::cookiesEnabled):
Ditto
(WebCore::getRawCookies):
Ditto.
(WebCore::deleteCookie):
Ditto.

platform/network/CookieStorage.h:
platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
function instead of at the global scope.
(WebCore::currentCookieStorage):
Use privateBrowsingCookieStorage.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
wkCreatePrivateInMemoryHTTPCookieStorage.

platform/network/mac/CookieStorageMac.mm:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
Refactor the logic to determine whether or not to relax the third party cookie policy here.
If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
(WebCore::ResourceHandle::createNSURLConnection):
Use shouldRelaxThirdPartyCookiePolicy.
(WebCore::ResourceHandle::loadResourceSynchronously):
Ditto.

Source/WebKit/mac:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

Source/WebKit2:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

WebKitLibraries:

When Private Browsing is enabled, use cookies from a in-memory Cookie Storage based on the
Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:

10:29 AM Changeset in webkit [80434] by commit-queue@webkit.org

5 edits
6 adds in trunk/Source/WebKit2

2011-03-06 Oleg Romashin <romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part1
Adding dummy Qt files for Plugin Process implementation,
Adding missing sources into Qt pro files
https://bugs.webkit.org/show_bug.cgi?id=55719

DerivedSources.pro:
PluginProcess/qt: Added.
PluginProcess/qt/PluginControllerProxyQt.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
PluginProcess/qt/PluginProcessMainQt.cpp: Added. (WebKit::PluginProcessMain):
PluginProcess/qt/PluginProcessQt.cpp: Added. (WebKit::PluginProcess::platformInitialize):
UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
WebKit2.pri:
WebKit2.pro:
WebKit2API.pri:
WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Added. (WebKit::PluginProxy::needsBackingStore):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed