Timeline
Mar 9, 2011:
- 11:31 PM Changeset in webkit [80695] by
-
- 3 edits in trunk/Source/WebCore
Not reviewed.
Reverting crash catching code, the bug being hunted was fixed by
http://trac.webkit.org/changeset/80686
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):
- loader/cache/CachedResourceLoader.h:
- 10:54 PM Changeset in webkit [80694] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, build fix.
- StringsNotToBeLocalized.txt: Add function names I forgot.
- platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE, since they don't compile anyway. Use ZeroMemory() instead of "= {0}" since Qt is stupid and (sometimes?!) warns about it.
(WebCore::windowsVersion):
(WebCore::processorArchitecture):
- 10:31 PM Changeset in webkit [80693] by
-
- 3 edits in trunk/Source/WebCore
Add UA string tags for Windows 64.
https://bugs.webkit.org/show_bug.cgi?id=55226
Reviewed by Ryosuke Niwa.
- StringsNotToBeLocalized.txt:
- platform/win/SystemInfo.cpp:
(WebCore::osVersionForUAString):
(WebCore::isWOW64):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):
- 10:15 PM Changeset in webkit [80692] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: tweaking of Chromium test_expectations.txt
- platform/chromium/test_expectations.txt:
- 9:38 PM Changeset in webkit [80691] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-03-09 Daniel Bates <dbates@rim.com>
Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
(Bug #56041<https://bugs.webkit.org/show_bug.cgi?id=56041>).
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Substitute variable callFrame for exec in call to createSyntaxError().
- 8:50 PM Changeset in webkit [80690] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, attempted build fix.
- WebCore.pri: Try to update include path for Qt Windows build.
- 8:24 PM Changeset in webkit [80689] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix.
- platform/win/SystemInfo.cpp:
(WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.
- 8:19 PM Changeset in webkit [80688] by
-
- 20 edits in trunk/Source
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
Reviewed by Mihai Parparita.
Source/WebCore:
- GNUmakefile.am: Fix spaces -> tabs.
- StringsNotToBeLocalized.txt:
- WebCore.pro: Add SystemInfo.* to Qt build.
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
- platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
- platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
(WebCore::windowsVersion):
(WebCore::windowsVersionForUAString):
- platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
- rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButton):
Source/WebKit/gtk:
- webkit/webkitwebsettings.cpp:
(webkitOSVersion):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
Source/WebKit/win:
- WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
(webKitVersionString):
Source/WebKit2:
- UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
- 7:59 PM Writing Reftests edited by
- (diff)
- 7:30 PM Changeset in webkit [80687] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Mihai Parparita <mihaip@chromium.org>
JSC now implements Object.freeze/seal (as of r80378) and correct
expectations have been checked in, therefore we now pass more
ietestcenter tests.
- platform/chromium/test_expectations.txt:
- 6:55 PM Changeset in webkit [80686] by
-
- 2 edits in trunk/Source/WebCore
2011-03-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Gentilcore.
REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
https://bugs.webkit.org/show_bug.cgi?id=53045
Copy the URL out of the CachedResource that is being revalidated, so
that we can still use it (in m_validatedURLs) after removing the
resource from the memory cache, which may delete it.
No new tests, since I was not able to trigger this locally (in a layout
test or otherwise).
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource):
- 6:23 PM Changeset in webkit [80685] by
-
- 3 edits2 adds in trunk
VO reporting incorrect list count for http://www.macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064
Reviewed by Beth Dakin.
Source/WebCore:
<li> tags should not be ignored, because they provide valuable information
to screen readers.
Test: platform/mac/accessibility/list-items-ignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
- platform/mac/accessibility/list-items-ignored-expected.txt: Added.
- platform/mac/accessibility/list-items-ignored.html: Added.
- 6:22 PM Changeset in webkit [80684] by
-
- 13 edits in trunk
Bug 56041 - RexExp constructor should only accept flags "gim"
Fix for issues introduced in r80667.
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Invalid flags to a RegExp literal are a late syntax error!
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
- Pass a PassRefPtr<RegExp>
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
- bytecompiler/BytecodeGenerator.h:
- Pass a PassRefPtr<RegExp>
- bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Should not be ASSERTing that the flags are valid - this is a late(er) error.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Need to check for error from RegExp constructor.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Need to check for error from RegExp constructor.
- runtime/RegExp.h:
(JSC::RegExp::isValid):
- Make isValid check that the regexp was created with valid flags.
- runtime/RegExpKey.h:
- Since we'll not create RegExp objects with invalid flags, separate out the deleted value.
LayoutTests:
- fast/regex/script-tests/parentheses.js:
- fast/regex/script-tests/pcre-test-1.js:
- Providing invalid flags to RegExp literals is an error in ES5.
- 6:21 PM Changeset in webkit [80683] by
-
- 2 edits in trunk/Source/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=56068
<rdar://problem/9058245> WebKit2: Can't uncheck 'Spelling and Grammar' contextual items
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::contextMenuItemSelected):
Add cases for ContextMenuItemTagCorrectSpellingAutomatically, ContextMenuItemTagCheckSpellingWhileTyping,
and ContextMenuItemTagCheckGrammarWithSpelling
- 5:56 PM Changeset in webkit [80682] by
-
- 4 edits12 adds in trunk
Source/WebCore: <rdar://problem/8733254> Float disappears after incremental layout
Fixed the original bug and a copule more issues noticed while doing so.
Reviewed by Dave Hyatt.
Tests: fast/dynamic/dirty-float-in-clean-line.html
fast/dynamic/float-at-line-break.html
fast/dynamic/float-from-empty-line.html
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
update the line break info of the last line with the new line break position. This is tested
by float-from-empty-line.html.
(WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
into this new function.
(WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
(WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
floats, as they may yet become dirty because of the floats. This is tested by
dirty-float-in-clean-line.html.
(WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
next one does not, the float will not make it into any line. This is tested by
float-at-line-break.html.
LayoutTests: <rdar://problem/8733254> Float disappears after incremental layout
Reviewed by Dave Hyatt.
- fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
- fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
- fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
- fast/dynamic/dirty-float-in-clean-line.html: Added.
- fast/dynamic/float-at-line-break-expected.checksum: Added.
- fast/dynamic/float-at-line-break-expected.png: Added.
- fast/dynamic/float-at-line-break-expected.txt: Added.
- fast/dynamic/float-at-line-break.html: Added.
- fast/dynamic/float-from-empty-line-expected.checksum: Added.
- fast/dynamic/float-from-empty-line-expected.png: Added.
- fast/dynamic/float-from-empty-line-expected.txt: Added.
- fast/dynamic/float-from-empty-line.html: Added.
- 5:50 PM Changeset in webkit [80681] by
-
- 1 edit2 deletes in branches/chromium/696/LayoutTests
Revert 80406 - 2011-03-04 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Test that scripts with unknown types aren't loaded.
https://bugs.webkit.org/show_bug.cgi?id=51760
- fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt: Added.
- fast/dom/HTMLScriptElement/dont-load-unknown-type.html: Added.
- 5:49 PM Changeset in webkit [80680] by
-
- 13 edits in branches/chromium/696
Revert 79114 - 2011-02-19 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676
This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script
There are a couple of things missing from the spec that would be new functionality. These will be added later.
- Support for async=false
- Empty src attribute should dispatch an error.
There are a couple of slight behavioral changes to match the spec.
- An XHTML script that is loaded then copied will not fire load on the copy.
- If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.
The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.
- fast/dom/HTMLScriptElement/move-in-beforeload.html: Original author says test was only meant to check for crashes. Beforeload is not specified by HTML5. Test was modified to assume moved script wouldn't execute because wasAlreadyStarted is set.
- fast/dom/script-clone-rerun-src.xhtml: According to HTML5 spec, load should only fire after a script executes. Test was modified to match that. The old broken behavior was that load fired on the cloned element, even though it didn't execute.
2011-02-19 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676
This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script
There are a couple of things missing from the spec that would be new functionality. These will be added later.
- Support for async=false
- Empty src attribute should dispatch an error.
There are a couple of slight behavioral changes to match the spec.
- An XHTML script that is loaded then copied will not fire load on the copy.
- If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.
The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.
Test: All existing tests.
- dom/ScriptElement.cpp: Rewritten to match HTML5 spec. (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript. (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript. (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript. (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests. (WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript(). (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser. (WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here. (WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript. (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts. (WebCore::ScriptElement::execute): Renamed executeScript. (WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts. (WebCore::ScriptElement::ignoresLoadRequest): New variable names. (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance. (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
- dom/ScriptElement.h: (WebCore::ScriptElement::willBeParserExecuted): Added. (WebCore::ScriptElement::readyToBeParserExecuted): Added. (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added. (WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish. (WebCore::ScriptElement::isParserInserted): Added.
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url. (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
- html/HTMLScriptElement.h:
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement. (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names. (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url. (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone. (WebCore::SVGScriptElement::hasSourceAttribute): Added. (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
- svg/SVGScriptElement.h:
- 5:46 PM Changeset in webkit [80679] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
selectionStart reports wrong caret position when the last characters are newlines
https://bugs.webkit.org/show_bug.cgi?id=56061
The bug was caused by SelectionController::setSelection's not calling
notifyRendererOfSelectionChange when old selection was equal to new selection.
Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
this condition holds after the command is executed. However, the values of
selectionStart and selectionEnd still need to be updated in this case because
the offsets counted from the beginning of textarea have been increased by 1.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange when m_selection = s.
- manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
- 5:21 PM Changeset in webkit [80678] by
-
- 1 edit9 adds in trunk/LayoutTests
2011-03-09 Martin Robinson <mrobinson@igalia.com>
Add some new GTK+ test results.
- platform/gtk/fast/blockflow/text-orientation-basic-expected.checksum: Added.
- platform/gtk/fast/blockflow/text-orientation-basic-expected.png: Added.
- platform/gtk/fast/blockflow/text-orientation-basic-expected.txt: Added.
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
- 4:49 PM Changeset in webkit [80677] by
-
- 2 edits14 adds in trunk/LayoutTests
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, third and final set of baselines for chromium linux lucid x86_64.
These are small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.png: Added.
- platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:43 PM Changeset in webkit [80676] by
-
- 2 edits66 adds in trunk/LayoutTests
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, land a second set of baselines for chromium linux lucid x86_64.
These are differences due to a newer freetype and a few rounding
differences in gradients.
https://bugs.webkit.org/show_bug.cgi?id=55527
- platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.png: Added.
- platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
- platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.checksum: Added.
- platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
- platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.png: Added.
- platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
- platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.checksum: Added.
- platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png: Added.
- platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.checksum: Added.
- platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:39 PM Changeset in webkit [80675] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein.
Frequent crashes when printing in WebPageProxy::setAutodisplay
https://bugs.webkit.org/show_bug.cgi?id=56057
<rdar://problem/9053290>
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Null check the page, there is no reason for it to still exist.
- 4:29 PM Changeset in webkit [80674] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix part 2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:29 PM Changeset in webkit [80673] by
-
- 2 edits12 adds in trunk/LayoutTests
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, first set of baselines for chromium linux lucid x86_64.
These are just small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527
- platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-path-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/css/stars-with-shadow-expected.txt: Added.
- platform/chromium-linux-x86_64/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:18 PM Changeset in webkit [80672] by
-
- 3 edits2 adds in trunk
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955
- fast/parser/self-closing-foreign-content-expected.txt: Added.
- fast/parser/self-closing-foreign-content.html: Added.
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955
Test: fast/parser/self-closing-foreign-content.html
When the parser encounters an svg or mathml root element, it places the
insertion mode into InForeignContentMode. However, if the root element
is self-closing (e.g. <svg />) then the element is never placed on the
open elements stack. This leaves the parser in an inconsistent state
where it is in InForeignContentMode but no foreign content is in the
open element stack.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing foreign element is inserted into the tree, do not set the insertion mode to InForeignContentMode.
- 4:17 PM Changeset in webkit [80671] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix part 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:16 PM Changeset in webkit [80670] by
-
- 4 edits in trunk/LayoutTests
2011-03-09 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Mihai Parparita.
Fix some potentially flaky tests
https://bugs.webkit.org/show_bug.cgi?id=56049
These tests were not resilient to parser yields for reasons explained below.
- media/video-src-plus-source.html: loadstart or loadmetadata could have fired before the waitForEvent() calls. So define them prior to the <video> element.
- platform/mac/accessibility/aria-expanded-notifications.html: The aria events could have fired before successfullyParsed was set, so run the test in the onload handler.
- plugins/npruntime/npruntime.html: The plugin could have been loaded before successfullyParsed was set, so set it before including the plugin.
- 4:15 PM Changeset in webkit [80669] by
-
- 2 edits in trunk/Source/WebCore
Qt build fix.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
- 4:03 PM Changeset in webkit [80668] by
-
- 3 edits2 adds in trunk
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982
- fast/parser/fragment-foreign-content-misnested-expected.txt: Added.
- fast/parser/fragment-foreign-content-misnested.html: Added.
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982
Test: fast/parser/fragment-foreign-content-misnested.html
It is a parse error to encounter certain start tags while the parser's
insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
are to pop open elements off the HTMLElementStack until a foreign
content scope marker is encountered. Before the change in r80320 to not
insert a fake HTML element during fragment parsing, said fake HTML
element counted as a foreign content scope marker.
With r80320, no fake HTML element is inserted and the stack is popped
until empty in cases where no other element claims to be a foreign
content scope marker. Fix this by treating the DocumentFragment as a
foreign content scope marker.
- html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): Take a ContainerNode* instead of a Element*. (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass topNode() to isForeignContentScopeMarker() instead of top().
- 3:04 PM Changeset in webkit [80667] by
-
- 23 edits in trunk
Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!
Reviewed by Darin Adler.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Need to parse flags string to enum.
- runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
- Add method to parse flags string to enum, change constructor/create args to take enum.
- runtime/RegExp.h:
(JSC::RegExp::global):
(JSC::RegExp::ignoreCase):
(JSC::RegExp::multiline):
- Change to use new enum values.
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
- runtime/RegExpCache.h:
- Changed to use regExpFlags enum instead of int/const UString&.
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- Add use new enum parsing, check for error.
- runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- Pass NoFlags value instead of empty string.
(JSC::regExpProtoFuncCompile):
- Add use new enum parsing, check for error.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- Pass NoFlags value instead of empty string.
Source/WebCore:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
- Need to parse flags string back to enum.
LayoutTests:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T1-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T3-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T4-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T5-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T6-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T8-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T9-expected.txt:
- Check in passing results!
- 2:46 PM Changeset in webkit [80666] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Martin Robinson <mrobinson@igalia.com>
jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019
Skip jquery test failing on the GTK+ debug bots. Move another
failing test to the appropriate section.
- platform/gtk/Skipped: Update skipped list.
- 2:27 PM Changeset in webkit [80665] by
-
- 3 edits4 adds in trunk
2011-03-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021
Adds a test for basic functionality of the backface-visibility
property.
- compositing/backface-visibility-expected.checksum: Added.
- compositing/backface-visibility-expected.png: Added.
- compositing/backface-visibility-expected.txt: Added.
- compositing/backface-visibility.html: Added.
2011-03-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021
Initializes the m_doubleSided flag of LayerChromiums to the default
value of true so the back sides of layers without
backface-visibility:hidden are rendered.
Test: compositing/backface-visibility.html
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
- 2:22 PM Changeset in webkit [80664] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/lists/008-vertical-expected.txt
Restore lists layout test to its pre-text-orientation patch results now that ex units are fixed for vertical text.
- 2:21 PM Changeset in webkit [80663] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] test_expectations.txt needs updating to expect crashes in tests
that trigger the assertion in FontCache::releaseFontData.
https://bugs.webkit.org/show_bug.cgi?id=56051
We have started seeing an assertion failure in FontCache.cpp:310 after r80582.
It is unclear whether r80582 caused the assertion or whether the problem was
already present at r80582 just made it manifest itself more often. Update the
test_expectations.txt file while we're investigating.
- platform/chromium/test_expectations.txt:
- 2:20 PM Changeset in webkit [80662] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
Reviewed by Dan Bernstein.
Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
text. That way we use the same metrics as for horizontal.
This fixes regressions in fast/lists and fast/overflow vertical text tests.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
- 2:07 PM Changeset in webkit [80661] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build correction.
- UIProcess/DrawingAreaProxy.messages.in: Exclude the other method using LayerTreeContext for non-accelerated composition case.
- 1:47 PM Changeset in webkit [80660] by
-
- 2 edits14 adds in trunk/LayoutTests
2011-03-09 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r80622.
- platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
- platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
- platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
- platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
- platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
- platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
- platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
- platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:18 PM Changeset in webkit [80659] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Abhishek Arya <inferno@chromium.org>
Unreviewed. Rebaselining after text orientation change in r80582.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 12:25 PM Changeset in webkit [80658] by
-
- 3 edits2 adds in trunk
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004
Added a regression test.
- editing/selection/extend-by-line-in-empty-document-expected.txt: Added.
- editing/selection/extend-by-line-in-empty-document.html: Added.
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004
The crash was caused by the false assumption that rootEditableElement() or documentElement()
always return non-null pointer. Fixed the bug by adding an early exit.
Test: editing/selection/extend-by-line-in-empty-document.html
- editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
- 11:49 AM Changeset in webkit [80657] by
-
- 2 edits in trunk/Tools
Hide Leaks Viewer's URL prompt by default
We will show it as needed. I think I left it visible by default by accident after doing some
testing.
Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
URL is passed as a query parameter, but does
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
- 11:42 AM Changeset in webkit [80656] by
-
- 3 edits in trunk/Tools
Don't use Element.classList or box-shadow in Leaks Viewer
They aren't supported by Safari 5. Luckily we have substitutes for them!
Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Use -webkit-box-shadow instead of box-shadow.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.urlPromptButtonClicked):
(LeaksViewer._displayURLPrompt):
(LeaksViewer._setLoadingIndicatorHidden):
Use add/removeStyleClass (from utilities.js) instead of Element.classList.
- 11:21 AM Changeset in webkit [80655] by
-
- 3 edits in trunk/Source/WebCore
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=56024
- English.lproj/localizedStrings.js:
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._contextMenu):
- 11:17 AM Changeset in webkit [80654] by
-
- 5 edits in trunk/Source/WebCore
Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
and FontCache.
Reviewed by Darin Adler.
- platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
- 11:14 AM Changeset in webkit [80653] by
-
- 4 edits in trunk/Source/WebCore
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaNPObject should not use JNI directly
https://bugs.webkit.org/show_bug.cgi?id=56009
We move the JNI code to access a Java object's fields into
a new JavaInstance::getField() method.
No new tests, refactoring only.
- bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::getField):
- bridge/jni/v8/JavaInstanceV8.h:
- bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectGetProperty):
- 10:55 AM Changeset in webkit [80652] by
-
- 2 edits in trunk/Tools
Add a link to the Leaks Viewer tool on the build.webkit.org homepage
Rubber-stamped by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 10:50 AM Changeset in webkit [80651] by
-
- 1 edit6 adds in trunk/Tools
Add a Leaks Viewer tool to build.webkit.org
This tool parses leaks from the files generated by the leaks bot and displays them in a
view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
code).
The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
be passed to the tool via the "url" query parameter.
Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
Inspector's Heavy profile view. But it's still pretty useful as-is.
Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
(#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
(#url-prompt): This is the prompt itself.
(#loading-indicator):
(#loading-indicator > img):
These show a spinner in the bottom-right when we're loading a leaks file.
(.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
as percentages.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
(LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
URL if one wasn't given to us as a query parameter).
(LeaksViewer.get loading):
(LeaksViewer.set loading):
(LeaksViewer.get url):
(LeaksViewer.set url):
Pretty simple accessors.
(LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
prompt.
(LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
(LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
the profile to the Web Inspector code once it's been created.
(LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
(LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
(LeaksViewer._updateTitle): Set our title based on our URL and loading status.
(getResource): Helper function to fetch a resource via XHR and pass it to a callback.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
(WebInspector.UIString): Just a simple implementation since this tool isn't localized.
(ProfilerAgent.getProfile): Store the callback.
(ProfilerAgent.profileReady): Call the callback.
(monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
count and total leak counts as real values, not percentages or milliseconds.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
(onmessage): Create a profile based on the leaks file and pass it back to our caller.
(parseLeaks): Extract call stacks out of a leaks file.
(createNode): Helper function to create a new empty profile node.
(createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
WebInspector.ProfileView.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
- 10:24 AM Changeset in webkit [80650] by
-
- 2 edits in trunk/LayoutTests
Update expected results of svg/css/getComputedStyle-basic after r80582.
- svg/css/getComputedStyle-basic-expected.txt:
- 10:21 AM Changeset in webkit [80649] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Mihai Parparita <mihaip@chromium.org>
Update chromium-gpu expectations.
- platform/chromium/test_expectations.txt:
- 10:19 AM Changeset in webkit [80648] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/lists
Update lists vertical tests after text-orientation landing.
- 10:17 AM Changeset in webkit [80647] by
-
- 4 edits in trunk/Source/WebCore
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
NPAPI - jvalue conversion should not be in JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=55967
No new tests, refactoring only.
- bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
- bridge/jni/v8/JavaInstanceV8.h:
- bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke):
- 10:06 AM Changeset in webkit [80646] by
-
- 3 edits2 copies in trunk/Source/WebKit2
Change plugins to use their own executable on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=55991
Reviewed by Anders Carlsson.
- Configurations/PluginProcess.xcconfig: Copied from Source/WebKit2/Configurations/WebProcess.xcconfig.
- PluginProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
Add files necessary for adding PluginProcess.app.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Launch the PluginProcess.app when launching a plugin process.
- WebKit2.xcodeproj/project.pbxproj:
Add new executable and new files, removes some unneeded copying
and duplicate compiling of files.
- WebProcess/Info.plist:
Sorted.
- 10:03 AM Changeset in webkit [80645] by
-
- 3 edits in trunk/LayoutTests
Update expected results of computed-style and computed-style-without-renderer after
r80582.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 9:47 AM Changeset in webkit [80644] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019
- platform/qt/Skipped:Add jquery tests to make buildbots happier.
- 8:41 AM Changeset in webkit [80643] by
-
- 16 edits in trunk
Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986
Reviewed by Adam Roben.
Source/WebCore:
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Just copy the cookie storage from the private browsing storage session.
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- 8:15 AM Changeset in webkit [80642] by
-
- 2 edits in trunk/Tools
Combine multiple --ignore-tests values
https://bugs.webkit.org/show_bug.cgi?id=56016
Reviewed by Adam Roben.
- Scripts/old-run-webkit-tests:
- 6:49 AM Changeset in webkit [80641] by
-
- 2 edits in trunk/Source/WebCore
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
- 6:02 AM Changeset in webkit [80640] by
-
- 7 edits in trunk
2011-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820
- http/tests/inspector-enabled/open-close-open-expected.txt:
- http/tests/inspector-enabled/open-close-open.html:
- http/tests/inspector/inspector-test.js: ():
2011-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
- 5:40 AM Changeset in webkit [80639] by
-
- 3 edits in trunk/Source/WebCore
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource errors are not reported before front-end is opened
https://bugs.webkit.org/show_bug.cgi?id=55939
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveResourceResponse): (WebCore::InspectorInstrumentation::didFailLoading):
- 5:34 AM Changeset in webkit [80638] by
-
- 2 edits2 adds in trunk/Source/WebKit2
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix compilation after r80596, add soup Download stubs.
- GNUmakefile.am:
- WebProcess/Downloads/soup/DownloadSoup.cpp: Added. (WebKit::Download::start): (WebKit::Download::startWithHandle): (WebKit::Download::cancel): (WebKit::Download::platformInvalidate): (WebKit::Download::didDecideDestination): (WebKit::Download::platformDidFinish):
- 5:32 AM Changeset in webkit [80637] by
-
- 2 edits in trunk/Source/WebKit2
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix GTK+ compilation after r80619. Add WebFullScreenManager.
- GNUmakefile.am:
- 5:05 AM Changeset in webkit [80636] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: assign bug entries to Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 4:05 AM Changeset in webkit [80635] by
-
- 12 edits in trunk/Source
2011-03-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948
Add a parameter that allows for selection of alternative backing store
implementations.
No new tests: no new functionality.
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
2011-03-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948
Add a parameter that allows for selection of alternative backing store
implementations.
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- src/AssertMatchingEnums.cpp:
- src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
- src/WebIDBFactoryImpl.h:
- 3:52 AM Changeset in webkit [80634] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Move fast/canvas/rgba-parsing.html to the group of
tests failing due to rounding color problems in cairo/pixman.
- platform/gtk/Skipped:
- 3:09 AM Changeset in webkit [80633] by
-
- 5 edits in trunk/Source/WebCore
2011-03-08 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Factor out JNI method call to be used by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55966
No new tests, refactoring only.
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::callJNIMethod):
- bridge/jni/JNIUtility.h:
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
- bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
- 3:01 AM Changeset in webkit [80632] by
-
- 2 edits in trunk/Source/WebCore
2011-03-09 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
https://bugs.webkit.org/show_bug.cgi?id=55818
- inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
- 2:53 AM Changeset in webkit [80631] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: more vertical text fallout for the chromium test expectations.
Also, a rebaseline.
- platform/chromium-mac/fast/lists/003-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/lists/003-vertical-expected.png: Added.
- platform/chromium-mac/fast/lists/003-vertical-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:00 AM Changeset in webkit [80630] by
-
- 5 edits in trunk
2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998
- inspector/protocol/console-agent-expected.txt:
- inspector/protocol/runtime-agent-expected.txt:
2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998
- inspector/InjectedScriptSource.js:
- 1:57 AM Changeset in webkit [80629] by
-
- 14 edits in trunk
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
- inspector/console/console-dir-expected.txt:
- inspector/console/console-dir.html:
- inspector/debugger/debugger-expand-scope-expected.txt:
- inspector/debugger/debugger-expand-scope.html:
- platform/chromium/inspector/console/console-dir-expected.txt:
- platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846
- inspector/InjectedScriptSource.js:
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/RemoteObject.js: (WebInspector.LocalJSONObject.prototype.get description):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/inspector.css: (.console-formatted-string, .console-formatted-regexp):
- 1:53 AM Changeset in webkit [80628] by
-
- 6 edits in trunk
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220
- inspector/console/console-format-expected.txt:
- inspector/console/console-format.html:
- platform/chromium/inspector/console/console-format-expected.txt:
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220
- inspector/InjectedScriptSource.js:
- 1:25 AM Changeset in webkit [80627] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: yet more tweaking of the chromium test expectations.
- platform/chromium/test_expectations.txt:
- 1:07 AM Changeset in webkit [80626] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: fix chromium test expectations file.
- platform/chromium/test_expectations.txt:
- 12:46 AM Changeset in webkit [80625] by
-
- 2 edits in trunk/LayoutTests
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: update chromium test expectations
- platform/chromium/test_expectations.txt:
Mar 8, 2011:
- 11:36 PM Writing Reftests edited by
- (diff)
- 11:26 PM Writing Reftests edited by
- (diff)
- 11:23 PM Writing Reftests edited by
- (diff)
- 11:21 PM Writing Reftests edited by
- (diff)
- 11:18 PM Writing Reftests edited by
- (diff)
- 10:58 PM Changeset in webkit [80624] by
-
- 2 edits in trunk/LayoutTests
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
- inspector/protocol/runtime-agent-expected.txt:
- 10:32 PM Changeset in webkit [80623] by
-
- 4 edits in trunk
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
- inspector/protocol/runtime-agent-expected.txt:
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
- inspector/InjectedScriptSource.js:
- 10:23 PM Changeset in webkit [80622] by
-
- 3 edits8 adds in trunk
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
- fast/dom/scroll-reveal-left-overflow.html: Added.
- fast/dom/scroll-reveal-top-overflow.html: Added.
- platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
- platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
- platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
- platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
- platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.
Tests: fast/dom/scroll-reveal-left-overflow.html
fast/dom/scroll-reveal-top-overflow.html
- platform/ScrollView.cpp: (WebCore::ScrollView::calculateOverhangAreasForPainting):
- 10:08 PM Writing Reftests created by
- 9:57 PM Changeset in webkit [80621] by
-
- 3 edits3 adds in trunk
Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).
Reviewed by Sam Weinig
Source/JavaScriptCore:
Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
LayoutTests:
Added test cases.
- fast/js/array-proto-func-length-getter-except-expected.txt: Added.
- fast/js/array-proto-func-length-getter-except.html: Added.
- fast/js/script-tests/array-proto-func-length-getter-except.js: Added.
(lengthGetter):
(test):
- 9:57 PM Changeset in webkit [80620] by
-
- 3 edits in trunk/Source/WebCore
2011-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351
By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
can be called on an array A without the caller explicitly specifying the size of A.
No functionality was changed. So no new tests.
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}(). (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size" to better reflect its purpose - to be the size of the passed array. (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto. (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine the size of a passed array. Changed type of second argument to size_t since it represents the size of an array. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto. (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
- 9:51 PM WikiStart edited by
- (diff)
- 9:50 PM WikiStart edited by
- (diff)
- 9:19 PM Changeset in webkit [80619] by
-
- 16 edits7 adds in trunk/Source/WebKit2
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the FULLSCREEN_API Chrome client calls
https://bugs.webkit.org/show_bug.cgi?id=55273
The FULLSCREEN_API Chrome client calls need to be plumbed through from the
WebProcess to the UIProcess. To do this, WebFullScreenManager (and Proxy)
classes have been added to WebPage.
- DerivedSources.make: Added rules necessary to build DerivedSources for new .in files.
- DerivedSources.pro: Ditto.
- Platform/CoreIPC/MessageID.h: Added message types for WebFullScreenManager.
- Shared/API/c/WKBase.h: Added WKFullScreenManagerRef.
- Shared/APIObject.h: Added APIType for WebFullScreenManager.
- UIProcess/WebFullScreenManagerProxy.cpp: Added.
- UIProcess/WebFullScreenManagerProxy.h: Added.
- UIProcess/WebFullScreenManagerProxy.messages.in: Added.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Invalidate and clear m_fullScreenManager. (WebKit::WebPageProxy::processDidCrash): Ditto. (WebKit::WebPageProxy::didReceiveMessage): Pass messages on to WebFullScreenManagerProxy. (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto. (WebKit::WebPageProxy::fullScreenManager): Added. Lazy instantiation of m_fullScreenManager.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebKit2.xcodeproj/project.pbxproj: Added references to new classes in project file.
- WebKit2.pro: Ditto.
- win/WebKit2.vcproj: Ditto.
- WebKit2.pri: Added new directories to include file path.
- win/WebKit2Common.vsprops: Ditto.
- WebProcess/FullScreen/WebFullScreenManager.cpp: Added.
- WebProcess/FullScreen/WebFullScreenManager.h: Added.
- WebProcess/FullScreen/WebFullScreenManager.messages.in: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::supportsFullScreenForElement): Pass through to WebFullScreenManager. (WebKit::WebChromeClient::enterFullScreenForElement): Ditto. (WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Invalidate and clear m_fullScreenManager. (WebKit::WebPage::fullScreenManager): Lazy instantiation of m_fullScreenManager. (WebKit::WebPage::didReceiveMessage): Pass messages through to WebFullScreenManager.
- WebProcess/WebPage/WebPage.h:
- 7:44 PM Changeset in webkit [80618] by
-
- 2 edits in trunk/LayoutTests
2011-03-08 Mihai Parparita <mihaip@chromium.org>
Add failing expectation for compositing/webgl/
webgl-nonpremultiplied-blend.html.
- platform/chromium/test_expectations.txt:
- 7:15 PM Changeset in webkit [80617] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-03-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Destroying WorkerFileSystemCallbacksBridge on main thread results in ASSERT in WorkerContext::Observer::~Observer
https://bugs.webkit.org/show_bug.cgi?id=55895
- src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread): Added stopObserving() so that releasing the bridge on the main thread (this could happen before or after the runTaskOnWorkerThread) does not cause the assertion error.
- 7:04 PM Changeset in webkit [80616] by
-
- 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
There's more chance that this will work if the file is compiled.
- 6:28 PM Changeset in webkit [80615] by
-
- 3 edits2 adds in trunk/Source/WebCore
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>
Reviewed by Darin Adler.
This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/HTMLConverter.h: Added.
- platform/mac/HTMLConverter.mm: Added.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
- 6:25 PM Changeset in webkit [80614] by
-
- 6 edits in trunk/Source/WebCore
2011-03-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55900
This adds an explicit step to synchronize properties from
LayerChromiums to their corresponding CCLayerImpls.
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setBounds):
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::doubleSided): (WebCore::LayerChromium::setDoubleSided):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::updateFromLayer): (WebCore::CCLayerImpl::descendantsDrawsContent):
- platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::anchorPoint): (WebCore::CCLayerImpl::anchorPointZ): (WebCore::CCLayerImpl::masksToBounds): (WebCore::CCLayerImpl::opacity): (WebCore::CCLayerImpl::position): (WebCore::CCLayerImpl::preserves3D): (WebCore::CCLayerImpl::sublayerTransform): (WebCore::CCLayerImpl::transform):
- 6:22 PM Changeset in webkit [80613] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 James Robinson <jamesr@chromium.org>
Chromium compile fix.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
- 6:09 PM Changeset in webkit [80612] by
-
- 5 edits in trunk/Source/WebKit2
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the "supportsFullScreen" preference.
https://bugs.webkit.org/show_bug.cgi?id=55261
The "supportsFullScreen" preference needs to be plumbed through from
the UIProcess to the WebProcess.
- Shared/WebPreferencesStore.h: Add a new macro entry.
- UIProcess/API/C/WKPreferences.cpp: Implement preferences getter and setter. (WKPreferencesSetFullScreenEnabled): (WKPreferencesGetFullScreenEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Sync the fullScreenEnabled setting through to
the settings object.
- 5:44 PM Changeset in webkit [80611] by
-
- 7 edits2 deletes in trunk/Source/WebCore
Unify Windows version checks, part 1.
https://bugs.webkit.org/show_bug.cgi?id=55979
Reviewed by James Robinson.
Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
now-unnecessary WindowsVersion.cpp from Chromium.
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
- platform/chromium/WindowsVersion.cpp: Removed.
- platform/chromium/WindowsVersion.h: Removed.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
- 5:39 PM Changeset in webkit [80610] by
-
- 4 edits in trunk/Source/WebCore
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Chromium Linux build fix attempt after r80582.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::GlyphPage::fill):
- 5:35 PM Changeset in webkit [80609] by
-
- 8 edits2 adds in trunk/Source/WebKit2
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Adele Peterson.
WebKit2: Implement Windows glue for Undo/Redo
https://bugs.webkit.org/show_bug.cgi?id=55961
Expose Undo/Redo infrastructure through WKView on Windows by
adding an undo client as well as APIs to reapply and unapply
an edit command.
- UIProcess/API/C/win/WKView.cpp: (WKViewSetViewUndoClient): Added. (WKViewReapplyEditCommand): Added. (WKViewUnapplyEditCommand): Added.
- UIProcess/API/C/win/WKView.h: Added WKViewUndoClient, WKViewSetViewUndoClient(), and WKViewUnapplyEditCommand().
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isValidEditCommand): Added, used to validated an edit command from a WKView API.
- UIProcess/WebPageProxy.h: Added isValidEditCommand().
- UIProcess/win/WebUndoClient.cpp: Added, APIClient for WKViewUndoClient. (WebKit::WebUndoClient::registerEditCommand): Added. (WebKit::WebUndoClient::clearAllEditCommands): Added.
- UIProcess/win/WebUndoClient.h: Added, APIClient for WKViewUndoClient.
- UIProcess/win/WebView.cpp: (WebKit::WebView::initializeUndoClient): Added. (WebKit::WebView::close): Clear out undo client. (WebKit::WebView::registerEditCommand): Implemented to call through to WKViewUndoClient. (WebKit::WebView::clearAllEditCommands): Implmented to call through to WKViewUndoClient. (WebKit::WebView::reapplyEditCommand): Added. (WebKit::WebView::unapplyEditCommand): Added.
- UIProcess/win/WebView.h: Added undo client support.
- win/WebKit2.vcproj: Added WebUndoClient.cpp and WebUndoClient.h.
- 5:27 PM Changeset in webkit [80608] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Mac build fix attempt for r80582.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::disableLigatures):
- 5:25 PM Changeset in webkit [80607] by
-
- 2 edits in trunk/Tools
Adding myself to the committer file.
Reviewed by David Levin.
- Scripts/webkitpy/common/config/committers.py:
- 5:16 PM Changeset in webkit [80606] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Clean up Media GPU test expectation since
http://crbug.com?id=74887 was fixed. These expectations are based
on the results on flakiness dashboard.
Reviewed by David Levin.
- platform/chromium/test_expectations.txt:
- 5:00 PM Changeset in webkit [80605] by
-
- 5 edits in trunk/Source/WebKit2
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
WebKit2: Expose WebEditCommandProxy in the C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=55962
Make WebEditCommandProxy a subclass of APIObject, and define
WKEditCommandRef as the type that will be exposed through the C API.
- Shared/API/c/win/WKBaseWin.h: Add WKEditCommandRef.
- Shared/APIObject.h: Add platform-specific TypeEditCommandProxy.
- UIProcess/API/C/win/WKAPICastWin.h: Add API mapping for WKEditCommandRef.
- UIProcess/WebEditCommandProxy.h: Subclass WebEditCommandProxy from APIObject. (WebKit::WebEditCommandProxy::type): Added.
- 4:51 PM Changeset in webkit [80604] by
-
- 4 edits in trunk/Source/WebCore
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=54937
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain the document. Also restrained the lifetime of document variable. (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode() to determine whether or not position becomes null after removing a node. (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container so call containerNode() instead of deprecatedNode(). (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer() instead of deprecatedNode() and deprecatedEditingOffset() respectively. (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode() instead of deprecatedNode to determine whether or not selection inside a password field. Also assert that the specified position is not before or after the shadow root as it violates our assumption.
- editing/VisibleSelection.cpp: (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode() and deprecatedEditingOffset() respectively because start is always parent anchored and therefore guaranteed to be an offset inside an anchor node. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode() instead of deprecatedNode() to look for the lowest editable ancestor because position before or after an editable element isn't editable.
- page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode() and deprecatedEditingOffset() respectively in the following functions because they are exposed to DOM, which doesn't have before/after concept. (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::extentOffset):
- 4:18 PM Changeset in webkit [80603] by
-
- 2 edits in trunk/Source/WebKit2
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Oliver Hunt.
WebKit2: Redo is broken
https://bugs.webkit.org/show_bug.cgi?id=55978
WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
For example, when we unapply(), we should register a Redo command, not an Undo command.
- UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command. (WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.
- 4:02 PM Changeset in webkit [80602] by
-
- 2 edits2 moves1 add in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55977
Refine CF/CFNet distinctions for better code sharing.
- Rename Downloads/cf/win/DownloadCFNetWin.cpp to DownloadCFWin.cpp since it does not use any CFNETWORK features.
- Create new cfnet directory.
- Move Downloads/cf/DownloadCFNet.cpp to Downloads/cfnet
- Update project file.
Reviewed by Adam Roben.
- WebProcess/Downloads/cf/DownloadCFNet.cpp: Removed.
- WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp: Removed.
- WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Copied from WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp.
- WebProcess/Downloads/cfnet: Added.
- WebProcess/Downloads/cfnet/DownloadCFNet.cpp: Copied from WebProcess/Downloads/cf/DownloadCFNet.cpp.
- win/WebKit2.vcproj:
- 4:00 PM Changeset in webkit [80601] by
-
- 2 edits in trunk/Source/WebCore
Correct uninitialized variable in PolicyCallback found while
running WebKit in BoundsChecker.
https://bugs.webkit.org/show_bug.cgi?id=45199.
Reviewed by Adam Roben.
- loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::PolicyCallback): Initialize
m_argument.
- 3:44 PM Changeset in webkit [80600] by
-
- 3 edits in trunk/Source/WebKit2
<http://webkit.org/b/55976> Provisional URL should be loaded when restoring session state even if there are back / forward list entries.
Reviewed by Brady Eidson.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If there's a provisional URL that we will load then restore the session state
without navigating to the current item.
- WebProcess/WebPage/WebPage.messages.in: Expose the ability to restore the session state without navigating to the current item.
- 3:43 PM Changeset in webkit [80599] by
-
- 2 edits in trunk/Tools
Fix two leaks I introduced into the API tests.
Rubber-stamped by Adam Roben.
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
- 3:17 PM Changeset in webkit [80598] by
-
- 30 edits in trunk/Source/JavaScriptCore
2011-03-07 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make CodeBlock GC write barrier safe
https://bugs.webkit.org/show_bug.cgi?id=55910
In order to make CodeBlock WriteBarrier safe it was necessary
to make it have a single GC owner, and for that reason I have
made ExecutableBase a GC allocated object. This required
updating their creation routines as well as all sites that hold
a reference to them. GC objects that held Executable's have been
converted to WriteBarriers, and all other sites now use Global<>.
As an added benefit this gets rid of JSGlobalData's list of
GlobalCodeBlocks.
Perf testing shows a 0.5% progression on v8, vs. a 0.3% regression
on SunSpider. Given none of the tests that show regressions
demonstrate a regression on their own, and sampling shows up nothing.
I suspect we're just getting one or two additional gc passes at
the end of the run.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::EvalCodeCache::markAggregate): (JSC::CodeBlock::markAggregate):
- bytecode/CodeBlock.h: (JSC::CodeBlock::ownerExecutable): (JSC::CodeBlock::addConstant): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::getConstant): (JSC::CodeBlock::addFunctionDecl): (JSC::CodeBlock::addFunctionExpr): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ExecState::r):
- bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
- bytecode/SamplingTool.h: (JSC::ScriptSampleRecord::ScriptSampleRecord):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction):
- debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
- interpreter/Interpreter.cpp: (JSC::Interpreter::callEval):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs):
- jit/JITStubs.h:
- runtime/Completion.cpp: (JSC::checkSyntax): (JSC::evaluate):
- runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::FunctionExecutable::~FunctionExecutable): (JSC::EvalExecutable::markChildren): (JSC::ProgramExecutable::markChildren): (JSC::FunctionExecutable::markChildren): (JSC::FunctionExecutable::fromGlobalCode):
- runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::create): (JSC::NativeExecutable::NativeExecutable): (JSC::VPtrHackExecutable::VPtrHackExecutable): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::create): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::createStructure):
- runtime/FunctionConstructor.cpp: (JSC::constructFunction):
- runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots):
- runtime/Heap.h:
- runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::markChildren):
- runtime/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
- runtime/JSCell.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::~JSFunction): (JSC::JSFunction::markChildren):
- runtime/JSFunction.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
- runtime/JSObject.cpp:
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObjectData::JSStaticScopeObjectData): (JSC::JSStaticScopeObject::JSStaticScopeObject):
- runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):
- runtime/JSZombie.h: (JSC::JSZombie::createStructure):
- runtime/MarkedSpace.h:
- 3:13 PM Changeset in webkit [80597] by
-
- 2 edits in trunk/LayoutTests
2011-03-08 Martin Robinson <mrobinson@igalia.com>
Rebaseline a GTK+ result after r80582.
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 3:06 PM Changeset in webkit [80596] by
-
- 11 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55956
WebKit2 Changes to correct WinCairo port build
Reviewed by Anders Carlsson.
- Shared/LayerTreeContext.h: Don't exclude CoreIPC declarations for non-accelerated compositing case.
- UIProcess/DrawingAreaProxy.h: Add "stdint.h" include needed for Cairo build.
- UIProcess/DrawingAreaProxyImpl.cpp: Exclude accelerated compositing code for WinCairo build.
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
- UIProcess/DrawingAreaProxyImpl.h: Exclude declarations for code only used when accelerated compositing is enabled.
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):
- UIProcess/win/WebView.cpp: Protect CG-specific drawing code.
(WebKit::WebView::setFindIndicator):
- WebProcess/Downloads/Download.h: Allow CFLite implentation to share overwrite flag, as well as destination and bundle paths.
- WebProcess/Downloads/curl/DownloadCurl.cpp: Remove stub (to share CFNet implementation of file handling. This will be moved to a common area in a future patch.)
- WebProcess/WebPage/DrawingAreaImpl.cpp: Exclude accelerated-compositing paths.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.cpp: Protect CG-specific drawing code.
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
- win/WebKit2.vcproj: Exclude unused LayerTreeContext from WinCairo
- 2:49 PM Changeset in webkit [80595] by
-
- 3 edits in trunk/LayoutTests
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Update Qt specific expected results after r80582.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 2:37 PM Changeset in webkit [80594] by
-
- 2 edits in trunk/Source/WebCore
More build bustage fix.
- platform/graphics/win/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation): Duplicate accessor
in WinCairo-local header. This is such a mess!
- 2:16 PM Changeset in webkit [80593] by
-
- 2 edits in trunk/Source/WebKit2
2011-03-08 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Re-fix: can't paste from 3rd party text editor into WebKit2 window
<rdar://problem/8978624>
- WebProcess/com.apple.WebProcess.sb:
- 2:15 PM Fingerprinting edited by
- (diff)
- 2:10 PM Changeset in webkit [80592] by
-
- 1 copy in branches/chromium/696
Branching Chromium 696.
- 2:09 PM Changeset in webkit [80591] by
-
- 1 delete in branches/chromium/696
Un-Branching Chromium 696.
- 2:07 PM Changeset in webkit [80590] by
-
- 1 copy in branches/chromium/696
Branching Chromium 696.
- 2:05 PM Changeset in webkit [80589] by
-
- 10 edits in trunk/Source/WebCore
Fix build bustage. Hide orientation setting behind a setter and stub it out in all
FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
- platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/freetype/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/wince/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
- 1:57 PM Changeset in webkit [80588] by
-
- 3 edits in trunk/Source/WebKit2
2011-03-08 Martin Robinson <mrobinson@igalia.com>
Fix the WebKit2 compilation after r80578.
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::setFocus): Added.
- UIProcess/gtk/WebView.h:
- 1:49 PM Changeset in webkit [80587] by
-
- 9 edits in trunk
2011-03-08 Joe Wild <joseph.wild@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
2011-03-08 Joe Wild <joseph.wild@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
- features.pri:
- page/DOMWindow.idl:
- 1:42 PM Changeset in webkit [80586] by
-
- 4 edits1 add in trunk
Crash in CFNetwork visiting google.com
https://bugs.webkit.org/show_bug.cgi?id=55958
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCopyCFURLResponse):
If the response to copy is null, return 0;
Tools:
Add a test for not trying to copy a null CFURLResponse.
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 1:19 PM Changeset in webkit [80585] by
-
- 3 edits in trunk/Source/WebKit2
Reverted the patch for https://bugs.webkit.org/show_bug.cgi?id=55940
The patch was insufficient, and it wasn't useful for the intended client use either.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- 1:18 PM Changeset in webkit [80584] by
-
- 6 edits in trunk/Source
2011-03-08 Alok priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242
No test needed. A simple get function is added.
- platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::getTextureId):
2011-03-08 Alok priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242
It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.
- public/WebPluginContainer.h:
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId):
- src/WebPluginContainerImpl.h:
- 1:18 PM Changeset in webkit [80583] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp
Fix Lion build bustage.
- 12:53 PM Changeset in webkit [80582] by
-
- 45 edits5 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Reviewed by Dan Bernstein.
This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
vertically oriented font that rotates all glyphs.
The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
simple or complex code paths, although the simple code path at least gets close.
Added fast/blockflow/text-orientation-basic.html
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData):
- loader/cache/CachedFont.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::setTextOrientation):
(WebCore::FontDescription::operator==):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter):
(WebCore::offsetToMiddleOfGlyph):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::hasVerticalGlyphs):
(WebCore::SimpleFontData::isTextOrientationFallback):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/haiku/FontCustomPlatformData.h:
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/pango/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/skia/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.h:
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
- platform/text/TextOrientation.h: Added.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialTextOrientation):
LayoutTests:
- fast/blockflow/text-orientation-basic.html: Added.
- platform/mac/fast/blockflow/text-orientation-basic-expected.checksum: Added.
- platform/mac/fast/blockflow/text-orientation-basic-expected.png: Added.
- platform/mac/fast/blockflow/text-orientation-basic-expected.txt: Added.
- 12:14 PM Changeset in webkit [80581] by
-
- 3 edits in trunk/Source/WebKit2
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK+ compilation after r80569.
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::windowToScreen):
- UIProcess/gtk/WebView.h:
- 12:12 PM Changeset in webkit [80580] by
-
- 6 edits in trunk/Source/WebCore
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
addInlineStyleIfNeeded should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55950
Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration. (WebCore::StyleChange::init): Ditto. (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement instead of manually merging styles. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
- editing/ApplyStyleCommand.h:
- editing/CompositeEditCommand.h:
- editing/EditingStyle.cpp: (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
- editing/EditingStyle.h:
- 12:07 PM Changeset in webkit [80579] by
-
- 3 edits2 adds in trunk
2011-03-08 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951
- fast/canvas/shadow-huge-blur-expected.txt: Added.
- fast/canvas/shadow-huge-blur.html: Added.
2011-03-08 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951
Move the clamping code out of an if branch, so that it happens in the
canvas case as well.
Test: fast/canvas/shadow-huge-blur.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 12:04 PM Changeset in webkit [80578] by
-
- 12 edits in trunk/Source
Source/WebCore: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
Reviewed by Sam Weinig.
In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
Instead, the focus/unfocus messages need to be sent to the UIProcess side.
- platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):
Source/WebKit2: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
Reviewed by Sam Weinig.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFocus):
- UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setFocus):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFocus):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.h:
(WebKit::WebView::setFocus):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focus):
(WebKit::WebChromeClient::unfocus):
- 11:50 AM Changeset in webkit [80577] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fix last change so WKBaseWin.h is in alphabetical order in the project XML.
- win/WebKit2.vcproj: Move WKBaseWin.h to be in alphabetical order.
- 11:40 AM Changeset in webkit [80576] by
-
- 1 edit8 adds in trunk/LayoutTests
2011-03-08 Tony Chang <tony@chromium.org>
Unreviewed, add pngs to chromium and chromium-linux .checksum files
that are missing pngs. I generated these on my local desktop.
- platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
- platform/chromium-linux/fast/blockflow/english-bt-text-expected.png: Added.
- platform/chromium-linux/fast/blockflow/english-lr-text-expected.png: Added.
- platform/chromium-linux/fast/blockflow/english-rl-text-expected.png: Added.
- platform/chromium-linux/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/chromium-linux/fast/multicol/margin-collapse-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Added.
- platform/chromium/fast/images/png_per_row_alpha_decoding-expected.png: Added.
- 11:33 AM Changeset in webkit [80575] by
-
- 2 edits in trunk/LayoutTests
2011-03-08 Martin Maly <mmaly@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Expectation updates for strict mode V8 features.
https://bugs.webkit.org/show_bug.cgi?id=55789
- platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt:
- 11:32 AM Changeset in webkit [80574] by
-
- 2 edits1 delete in trunk/Source/WebKit2
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Remove Source/WebKit2/UIProcess/API/C/win/WKBaseWin.h
https://bugs.webkit.org/show_bug.cgi?id=55952
- UIProcess/API/C/win/WKBaseWin.h: Removed.
- win/WebKit2.vcproj: Refer to the Shared version of WKBaseWin.h instead of the one in UIProcess.
- 11:24 AM Changeset in webkit [80573] by
-
- 5 edits in trunk/Source/WebKit/mac
2011-03-08 Darin Adler <Darin Adler>
Reviewed by Timothy Hatcher.
Promote a method used outside WebKit from internal to private
https://bugs.webkit.org/show_bug.cgi?id=55949
- Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration. Minor tweak, not directly related to the rest of this patch.
- WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved this method from the internal category into the private category. Streamlined the code a bit.
- WebView/WebFrameInternal.h: Removed _computePageRects method.
- WebView/WebFramePrivate.h: Added _computePageRects method.
- 11:02 AM Changeset in webkit [80572] by
-
- 2 edits in trunk/Source/WebCore
Overflow: scroll areas should not paint white in scroll corner if the
scrollbars are overlay.
<rdar://problem/9082871>
Reviewed by Anders Carlsson.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintScrollCorner):
Don't paint the scroll corner white if we have overlay scrollbars.
- 10:42 AM Changeset in webkit [80571] by
-
- 3 edits in trunk/Source/WebKit2
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add new files to compilation after r77974
https://bugs.webkit.org/show_bug.cgi?id=54076
The commit added new code to allow passing context to policy
delegate methods, we also added dummy ResourceRequest and
ResourceResponse decoders until we implement them.
- GNUmakefile.am:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
- 10:29 AM Changeset in webkit [80570] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
The first time animations are committed they have a bad start time
https://bugs.webkit.org/show_bug.cgi?id=55947
Do a check for a returned lastCommitTime of <=0 and replace it
with the mediaTime.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
- 10:18 AM Changeset in webkit [80569] by
-
- 14 edits in trunk/Source/WebKit2
AX: Webkit2 not sending UAZoomFocusChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=55916
Reviewed by Darin Adler.
Needed to implement the windowToScreen() method so that the right frame
could be calculated to send for zoom focus changes.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::windowToScreen):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::windowToScreen):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowToScreen):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::windowToScreen):
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowToScreen):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowToScreen):
- WebProcess/WebPage/WebPage.h:
- 10:10 AM Changeset in webkit [80568] by
-
- 3 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55940
WebKit2 should support Ignore policy from injected bundle client
Reviewed by Darin Adler.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added WKBundlePagePolicyActionIgnore.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
If the injected bundle client returns WKBundlePagePolicyActionIgnore, convert it
to the loader's PolicyIgnore.
- 10:03 AM Changeset in webkit [80567] by
-
- 1 edit18 deletes in trunk/LayoutTests
2011-03-08 Tony Chang <tony@chromium.org>
Unreviewed, remove png layout test results that don't have
corresponding checksum files. I checked a few of these and they
were cases where the .checksum was removed and the .png forgotten.
- platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/gtk/svg/hixie/error/004-expected.png: Removed.
- platform/gtk/svg/hixie/error/005-expected.png: Removed.
- platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
- platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
- platform/mac/editing/selection/contenteditable-click-outside-expected.png: Removed.
- platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/mac/fast/dynamic/8952-reduction-expected.png: Removed.
- platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/mac/fast/js/Plug-ins-expected.png: Removed.
- platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
- platform/mac/svg/hixie/error/004-expected.png: Removed.
- platform/mac/svg/hixie/error/005-expected.png: Removed.
- platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
- platform/win/fast/table/row-height-recalc2-expected.png: Removed.
- 9:41 AM Changeset in webkit [80566] by
-
- 4 edits in trunk/Source/WebCore
2011-03-08 James Kozianski <koz@chromium.org>
Reviewed by David Levin.
Expose isValidProtocol() in KURL.h.
https://bugs.webkit.org/show_bug.cgi?id=54594
This is needed to validate protocols used in calls to
navigator.registerProtocolHandler().
- platform/KURL.cpp:
- platform/KURL.h:
- platform/KURLGoogle.cpp: (WebCore::isValidProtocol):
- 9:32 AM Changeset in webkit [80565] by
-
- 10 edits in trunk/Source/WebCore
Set svn:mime-type to text/css for all Inspector CSS files
This will cause them to be served with the correct MIME type from svn.webkit.org's web
interface.
Rubber-stamped by Tim Hatcher.
- inspector/front-end/audits.css: Added property svn:mime-type.
- inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
- inspector/front-end/heapProfiler.css: Added property svn:mime-type.
- inspector/front-end/helpScreen.css: Added property svn:mime-type.
- inspector/front-end/inspector.css: Added property svn:mime-type.
- inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
- inspector/front-end/networkPanel.css: Added property svn:mime-type.
- inspector/front-end/popover.css: Added property svn:mime-type.
- inspector/front-end/textViewer.css: Added property svn:mime-type.
- 8:05 AM Changeset in webkit [80564] by
-
- 11 edits in trunk/Source
2011-03-08 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
The IndexedDatabase specification changed and IDBIndex objects are no
longer created asynchronously. We therefore no longer need this method.
No new tests, just cleanup.
- storage/IDBCallbacks.h:
- storage/IDBRequest.cpp:
- storage/IDBRequest.h:
2011-03-08 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
- public/WebIDBCallbacks.h:
- src/IDBCallbacksProxy.cpp:
- src/IDBCallbacksProxy.h:
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBCallbacksImpl.h:
- src/WebIDBObjectStoreImpl.cpp:
- 7:42 AM Changeset in webkit [80563] by
-
- 5 edits in trunk/Source/WebKit/efl
2011-03-08 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Kent Tamura.
[EFL] Doxygen documentation for ewk_window_features and ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=55026
- ewk/ewk_contextmenu.cpp: (ewk_context_menu_item_select): returns EINA_FALSE when CONTEXT_MENU is disabled
- ewk/ewk_contextmenu.h:
- ewk/ewk_window_features.cpp:
- ewk/ewk_window_features.h:
- 7:20 AM Changeset in webkit [80562] by
-
- 2 edits in trunk/LayoutTests
2011-03-08 Philippe Normand <pnormand@igalia.com>
REGRESSION (r80478): broke GTK inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55941
Unreviewed, skipping inspector crashing tests on GTK.
- platform/gtk/Skipped:
- 6:48 AM Changeset in webkit [80561] by
-
- 14 edits2 adds in trunk
[GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510
Reviewed by Martin Robinson.
- GNUmakefile.am:
- WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on
the icon database for new icons.
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitglobals.cpp:
- webkit/webkitglobals.h: Add a function to obtain the global
icon database.
- webkit/webkiticondatabase.cpp:
- webkit/webkiticondatabase.h: Implement public icon database
object with methods for obtaining icon URLs, pixbufs, clearing
waiting for new icons.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h: Add a method to obtain an icon pixbuf
for the web view.
- 5:03 AM Changeset in webkit [80560] by
-
- 8 edits2 deletes in trunk/Source/WebCore
2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80551.
http://trac.webkit.org/changeset/80551
https://bugs.webkit.org/show_bug.cgi?id=55933
It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
- WebCore.pro:
- platform/SharedBuffer.cpp:
- platform/SharedBuffer.h:
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData):
- platform/qt/QtByteBlock.cpp: Removed.
- platform/qt/QtByteBlock.h: Removed.
- platform/qt/SharedBufferQt.cpp:
- 4:35 AM Changeset in webkit [80559] by
-
- 4 edits in trunk/Source/WebCore
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
RenderObject: Pass complex type arguments as const-references.
- WebCore.exp.in:
- rendering/RenderObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath): (WebCore::RenderObject::drawArcForBoxSide): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal):
- 3:47 AM Changeset in webkit [80558] by
-
- 2 edits in trunk/Tools
2011-03-08 Hayato Ito <hayato@chromium.org>
Reviewed by Ojan Vafai.
[NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- 3:18 AM Changeset in webkit [80557] by
-
- 10 edits in trunk/Source/WebCore
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
Path: Make measurement functions const
https://bugs.webkit.org/show_bug.cgi?id=55914
- platform/graphics/Path.cpp: (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
- platform/graphics/Path.h:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::strokeBoundingRect): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/wince/PathWinCE.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeBoundingRect):
- 2:17 AM Changeset in webkit [80556] by
-
- 6 edits in trunk/LayoutTests
2011-03-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated GTK baselines of fast/text and 2 SVG
text-related tests after r80526.
- platform/gtk/fast/text/international/complex-character-based-fallback-expected.txt:
- platform/gtk/fast/text/international/thai-line-breaks-expected.txt:
- platform/gtk/fast/text/large-text-composed-char-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/gtk/svg/text/text-intro-05-t-expected.txt:
- 2:04 AM Changeset in webkit [80555] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Do not set juntion sides on scrollbar stepper buttons
https://bugs.webkit.org/show_bug.cgi?id=55868
Fixes rendering of steppers for themes using rounded stepper
buttons on scrollbars like Adwaita.
- platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintButton):
- 2:00 AM Changeset in webkit [80554] by
-
- 3 edits in trunk/Source/WebCore
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use doubles instead of integers for coordinates when rendering arrows
https://bugs.webkit.org/show_bug.cgi?id=55866
To prevent off-by-one rounding errors.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
- platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintButton):
- 1:54 AM Changeset in webkit [80553] by
-
- 7 edits in trunk
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
- platform/gtk/Skipped: Unskip test fast/forms/onchange-setvalueforuser.html that passes now.
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
Add setValueForUser method to DumpRenderTreeSupportGTK.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setValueForUser):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Implement setValueForUser()
- 1:27 AM Changeset in webkit [80552] by
-
- 3 edits in trunk/Source/WebKit2
2011-03-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] [WK2] Fix building WebKit 2 API tests
https://bugs.webkit.org/show_bug.cgi?id=55876
Make sure TESTS_SOURCE_DIR is set for Symbian the same way
as it is for WK1.
- UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyPage):
- UIProcess/API/qt/tests/tests.pri:
- 1:14 AM Changeset in webkit [80551] by
-
- 8 edits2 adds in trunk/Source/WebCore
2011-03-08 Markus Goetz <guruz@guruz.de>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use the QNetworkAccessManager zerocopy feature
https://bugs.webkit.org/show_bug.cgi?id=50082
The feature will be introduced in Qt 4.8.
This patch is backwards compatible with Qt 4.7.
- WebCore.pro:
- platform/SharedBuffer.cpp:
- platform/SharedBuffer.h:
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::bufferedData): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::downloadProgress): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData):
- platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::wrapQtByteBlock): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData): (WebCore::SharedBuffer::platformDataSize): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::clearPlatformData):
- 1:13 AM Changeset in webkit [80550] by
-
- 2 edits26 adds in trunk/LayoutTests
2011-03-08 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[Chromium] Rebaseline CSS3 elliptical gradient tests linux, win32
https://bugs.webkit.org/show_bug.cgi?id=55742
Skia CSS3 elliptical gradient support was added on r79063; rebaseline the associated
win32 and linux tests. There are separate linux results herein due to (minor) pixel
differences with win32. See the bug for the diff images.
- platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.png: Added.
- platform/chromium-linux/fast/gradients/css3-color-stops-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Added.
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png: Added.
- platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
- platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-color-stop-units-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-color-stops-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-color-stops-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:06 AM Changeset in webkit [80549] by
-
- 5 edits in trunk/Tools
2011-03-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Add script_shell_command to WebKitPort
https://bugs.webkit.org/show_bug.cgi?id=55925
Add a central place where we generate the shell command from the script name.
This function will be used later to detect the correct script interpreter on Win32.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- 12:45 AM Changeset in webkit [80548] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix compilation warnings after r80429
https://bugs.webkit.org/show_bug.cgi?id=55864
- platform/gtk/WidgetGtk.cpp:
- 12:21 AM Changeset in webkit [80547] by
-
- 2 edits in trunk/Source/WebCore
2011-03-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix after r80536
- GNUmakefile.am:
- 12:10 AM Changeset in webkit [80546] by
-
- 4 edits in trunk
2011-03-08 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878
Enable a passing test now that we properly use the quality value when requesting
a GdkPixbuf to be saved into a buffer.
- platform/gtk/Skipped:
2011-03-08 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878
Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
when saving GdkPixbuf to a buffer.
- platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
