⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 13, 2011:

1:30 AM Changeset in webkit [80958] by levin@chromium.org
  • 12 edits
    40 adds in trunk/LayoutTests

Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

Mar 12, 2011:

11:24 PM Changeset in webkit [81003] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=56285

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):

  • storage/StorageTracker.h:
11:20 PM Changeset in webkit [81002] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
​https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

11:02 PM Changeset in webkit [81001] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

10:47 PM Changeset in webkit [81000] by beidson@apple.com
  • 16 edits in trunk/Source/WebKit2

<rdar://problem/9127270> and ​https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI to set the path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory):

  • UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setLocalStorageDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

10:35 PM Changeset in webkit [80999] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Mark Rowe.

WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
​https://bugs.webkit.org/show_bug.cgi?id=56260

Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

  • UIProcess/mac/WKFullScreenWindowController.mm:
10:23 PM Changeset in webkit [80998] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve my hasitly added build fix and added a bug ​https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:23 PM Changeset in webkit [80997] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Clean up overlapping test_expectation which I mistakenly added in my haste.

  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80996] by mitz@apple.com
  • 13 edits in trunk

Include hyphenation information in text representation of render tree
​https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

  • fast/text/soft-hyphen-4-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphenate-first-word-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
9:56 PM Changeset in webkit [80995] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

A few Heap-related renames (sans file moves, which should come next)
​https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):

  • runtime/ConservativeSet.h:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):

  • runtime/Heap.h:

(JSC::Heap::machineThreads):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):

  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h:

(JSC::MarkStack::append):

9:53 PM Changeset in webkit [80994] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<​https://bugs.webkit.org/show_bug.cgi?id=56270>

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

9:37 PM Changeset in webkit [80993] by levin@chromium.org
  • 4 edits in trunk

Build fix adding remaining enum values to switch statement.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80992] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80991] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [80990] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

8:01 PM Changeset in webkit [80989] by mrowe@apple.com
  • 1 copy in tags/Safari-534.24

New tag.

7:36 PM Changeset in webkit [80988] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after r80982.

  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
6:35 PM Changeset in webkit [80987] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix the Mac build.

ConervativeSet.h, since it's now visible when compiling other projects.

6:27 PM Changeset in webkit [80986] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):
Add missing constructor.

6:16 PM Changeset in webkit [80985] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (ConservativeSet)
​https://bugs.webkit.org/show_bug.cgi?id=56281


The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append. (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated the size of the set based on sizeof(DeprecatedPtr<T>*) instead of sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not. (JSC::ConservativeSet::size): (JSC::ConservativeSet::set): Use direct pointers, as stated above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MarkStack.h: (JSC::MarkStack::append): Created a special case of append for ConservativeSet. I didn't want to add back a generic "append JSCell*" function, since other class might start using that wrong. (In the end, this function might go away, since the Heap will want to do something slightly more interesting with the conservative set, but this is OK for now.)
6:09 PM Changeset in webkit [80984] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Source/WebCore: REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

  • fast/text/soft-hyphen-4-expected.checksum: Added.
  • fast/text/soft-hyphen-4-expected.png: Added.
  • fast/text/soft-hyphen-4-expected.txt: Added.
  • fast/text/soft-hyphen-4.html: Added.
5:58 PM Changeset in webkit [80983] by levin@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [80982] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
​https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

5:34 PM Changeset in webkit [80981] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Add ability to create a WKErrorRef
<rdar://problem/9115768>
​https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add new exports.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

  • Shared/API/c/cf/WKErrorCF.cpp: Added.

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

  • Shared/API/c/cf/WKErrorCF.h: Added.

Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:34 PM Changeset in webkit [80980] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (PutPropertySlot)
​https://bugs.webkit.org/show_bug.cgi?id=56278

  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot, since it's a stack-allocated temporary.
5:31 PM Changeset in webkit [80979] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add one more failure which is related to change in this range:

​http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860

that I haven't been able to narrow down yet.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [80978] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [80977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-13 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher does not load the same set of fonts as the DRT
​https://bugs.webkit.org/show_bug.cgi?id=34959

This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (initWebKitTestFonts): (launcherMain): (LauncherApplication::handleUserOptions):
5:14 PM Changeset in webkit [80976] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed one case of DeprecatedPtr (ScopeChainIterator)
​https://bugs.webkit.org/show_bug.cgi?id=56277

  • runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator, since it's a stack-allocated temporary.
5:10 PM Changeset in webkit [80975] by psolanki@apple.com
  • 15 edits in trunk

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:41 PM Changeset in webkit [80974] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [80973] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [80972] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

  • marked these methods const.

(JSC::AbstractMacroAssembler::Jump::isSet):

  • add a method to check whether a Jump object has been set to reference an instruction, or is in a null, unset state.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • add non-explicit constructor, for FunctionPtr's to C/C++ functions.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):

  • add three operand forms of these instructions.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::JmpSrc::isSet):

  • add a method to check whether a JmpSrc object has been set to reference an instruction, or is in a null, unset state.

(JSC::X86Assembler::movsd_rr):

  • added FP register-register move.

(JSC::X86Assembler::linkJump):

  • Add an assert to check jumps aren't linked more than once.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadInt32ToDouble):

  • load integers to the FPU via regsiters on x86-64.
3:05 PM Changeset in webkit [80971] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [80970] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load32):

2:16 PM Changeset in webkit [80969] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

  • bytecode/SamplingTool.h:
  • interpreter/Register.h:
  • interpreter/RegisterFile.h:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:
  • wtf/RefCounted.h:
    • Change these classes to no longer friend the JIT, add accessors for member offsets.
  • jit/JIT.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
    • Change the JIT to use class accessors, rather than taking object ofsets directly.
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
    • Since the accessors for objects members return const pointers to retain encapsulation, methods generating code with absolute addresses must be able to handle const pointers (the JIT doesn't write to these values, do dies treat the pointer to value as const from within the C++ code of the JIT, if not at runtime!).
1:30 PM Changeset in webkit [80968] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

WebPageProxy cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from

here to WebPageProxyMac.mm.

  • UIProcess/WebPageProxy.h: Cleaned up #includes.
  • UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations

here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

1:28 PM Changeset in webkit [80967] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
​https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

1:24 PM Changeset in webkit [80966] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash when dragging.

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap): Retain the saved context.

12:46 PM Changeset in webkit [80965] by jeremy@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Update comment in CSSValueKeywords.in
​https://bugs.webkit.org/show_bug.cgi?id=56266

The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

No tests - just updating a comment.

  • css/CSSValueKeywords.in:
12:07 PM Changeset in webkit [80964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Anton D'Auria <​adauria@apple.com>

Reviewed by Alice Liu.

StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
​https://bugs.webkit.org/show_bug.cgi?id=56259

Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker):
11:47 AM Changeset in webkit [80963] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-13 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
​https://bugs.webkit.org/show_bug.cgi?id=53470

Prefer !important over normal properties when dealing with duplicate properties in style rules.

Test: fast/css/duplicate-property-in-rule-important.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
11:42 AM Changeset in webkit [80962] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [80961] by levin@chromium.org
  • 5 edits
    11 adds in trunk/LayoutTests

Update test expections due to the OSX specific ex size change done in r80755.

  • platform/chromium-mac/fast/lists/008-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
10:04 AM Changeset in webkit [80960] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test expectations due to bad update:

r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [80959] by levin@chromium.org
  • 2 edits
    21 adds in trunk/LayoutTests

Added the following expectations:

fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Mar 12, 2011:

11:34 PM Changeset in webkit [80957] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80895.
​http://trac.webkit.org/changeset/80895
​https://bugs.webkit.org/show_bug.cgi?id=56261

Causing crashes in several tests including
t1202-counters-16-c.html (see
​http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
(Requested by dave_levin on #webkit).

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::create): (WebCore::CounterNode::resetRenderer): (WebCore::CounterNode::resetRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::showTreeAndMark):
  • rendering/CounterNode.h: (WebCore::CounterNode::renderer):
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::~RenderCounter): (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree):
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
  • rendering/RenderObjectChildList.h:
8:19 PM Changeset in webkit [80956] by levin@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add results for newly added test in r80883.
The differences appear to be very small in keep with the typical
font drawing differences.

  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.
8:05 PM Changeset in webkit [80955] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Fixed typo in a comment.

8:03 PM Changeset in webkit [80954] by levin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

r80743 updated the main baseline due to a jsc change.
chromium isn't affected by the change.

  • platform/chromium/fast/js/regexp-caching-expected.txt: Added.

chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.

  • platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.
7:46 PM Changeset in webkit [80953] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Remove bad test_expectation updates.

I fixed both of these already:

​http://trac.webkit.org/changeset/80911
​http://trac.webkit.org/changeset/80904

so it is unclear why they were added.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [80952] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-03-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
​https://bugs.webkit.org/show_bug.cgi?id=56258

No tests because the wrong hashing is mostly harmless. The only symptom
we have seen is an occasional assertion in debug builds about the size
not being a multiple of two. But a worse hash is worse for performance too.

  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather than the number of array entries.
7:36 PM Changeset in webkit [80951] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Fix the build with newer GCCs and remove some extra whitespae.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::uint8_t):

7:24 PM Changeset in webkit [80950] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Oliver Hunt.

Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):

7:18 PM Changeset in webkit [80949] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Oliver Hunt.

WebCore fails to build with Clang on ARM
​https://bugs.webkit.org/show_bug.cgi?id=56257

Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian):

7:11 PM Changeset in webkit [80948] by Darin Adler
  • 7 edits in trunk/Source

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebCore.exp.in: Added some additional exports. Re-sorted.

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::convertImageToBitmap): Added. Factored out from startDrag to make the startDrag code clearer. (WebKit::WebDragClient::startDrag): Streamlined code a bit. (WebKit::cachedImage): Added. Helper for function below. (WebKit::arrayForURLsWithTitles): Added. Helper for function below. (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file promises and removed a log of uneeded code. (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added. (promisedDataClient): Added. (-[WKPasteboardOwner clearImage]): Added. (-[WKPasteboardOwner initWithImage:]): Added. (-[WKPasteboardOwner dealloc]): Added. (-[WKPasteboardOwner finalize]): Added. (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added. (-[WKPasteboardOwner pasteboardChangedOwner:]): Added. (matchesExtensionOrEquivalent): Added. (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added. Much of the new code above came from the WebKit1 drag code.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
  • WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::setDragSource): Added. (WebKit::WebPage::platformDragEnded): Added.
2:32 PM Changeset in webkit [80947] by mitz@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
DumpRenderTree is being built for.

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/PerlSupport/Makefile:
2:15 PM Changeset in webkit [80946] by mrowe@apple.com
  • 7 edits in trunk/Source

Fix the 32-bit build.

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.

Source/WebKit2:

This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

1:42 PM Changeset in webkit [80945] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.

Reviewed by Sam Weinig.

(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.

(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.

1:30 PM Changeset in webkit [80944] by mitz@apple.com
  • 2 edits in trunk/Tools

Suggested by Mark Rowe.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled

as they were before r80915.

12:43 PM Changeset in webkit [80943] by andersca@apple.com
  • 12 edits in trunk

2011-03-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
​https://bugs.webkit.org/show_bug.cgi?id=56256

  • UIProcess/API/C/WKPage.h: Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView _applyPDFPreferences]): (-[WKPDFView _updatePreferences:]): Use new PDFViewController::page getter.

(-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
Call PDFViewController::savePDFToDownloadsFolder.

(WebKit::releaseCFData):
(WebKit::PDFViewController::savePDFToDownloadsFolder):
Create a WebData that wraps the CFData, then pass it along to
WebPageProxy::saveDataToFileInDownloadsFolder.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder): Call WebUIClient::saveDataToFileInDownloadsFolder.

(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/WebUIClient.h: Call the UI client callback function.

2011-03-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
​https://bugs.webkit.org/show_bug.cgi?id=56256

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): Update for API changes.
11:34 AM Changeset in webkit [80942] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

WebData should be able to wrap already existing data
​https://bugs.webkit.org/show_bug.cgi?id=56254

  • Shared/WebData.h: (WebKit::WebData::createWithoutCopying): (WebKit::WebData::create): (WebKit::WebData::~WebData): (WebKit::WebData::bytes): (WebKit::WebData::size): (WebKit::WebData::WebData): (WebKit::WebData::fastFreeBytes):
10:14 AM Changeset in webkit [80941] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
​https://bugs.webkit.org/show_bug.cgi?id=56250

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
8:44 AM Changeset in webkit [80940] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Update chromium expectations.

  • platform/chromium/test_expectations.txt:
8:07 AM Changeset in webkit [80939] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [80938] by loislo@chromium.org
  • 33 edits in trunk/Source

2011-03-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
​http://trac.webkit.org/changeset/80919
​https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/StructureStubInfo.cpp:
  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::payloadFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):
  • runtime/ArgList.cpp:
  • runtime/DateConversion.cpp:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/Identifier.cpp:
  • runtime/JSActivation.h: (JSC::asActivation):
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.cpp:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.cpp:
  • runtime/MarkedBlock.cpp:
  • runtime/MarkedSpace.cpp:
  • runtime/PropertyNameArray.cpp:
  • runtime/ScopeChain.h: (JSC::ExecState::globalThisValue):
  • wtf/DateMath.cpp:

2011-03-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
​http://trac.webkit.org/changeset/80919
​https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
7:47 AM Changeset in webkit [80937] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-12 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r80900.

  • CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
7:38 AM Changeset in webkit [80936] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Andras Becsi <​abecsi@webkit.org>

Unreviewed typo fix.

No new tests needed.

  • WebCore.pro: Fix typo in header name.
6:44 AM Changeset in webkit [80935] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:55 AM Fingerprinting edited by robert@roberthogan.net
(diff)
4:00 AM Changeset in webkit [80934] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Inspect Element action regression fix.

3:53 AM Changeset in webkit [80933] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. One line fix for inspector/dom-breakpoints.html

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
3:26 AM Changeset in webkit [80932] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Almost all inspector tests are crashing after r80928.

  • inspector/front-end/inspector.js:
1:10 AM Changeset in webkit [80931] by pfeldman@chromium.org
  • 27 edits in trunk

2011-03-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
​https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/elements/elements-panel-search.html:

2011-03-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
​https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::setPropertyValue):
  • inspector/InjectedScript.h:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setNodeName): (WebInspector.DOMNode.prototype.setNodeValue): (WebInspector.DOMNode.prototype.getChildNodes): (WebInspector.DOMNode.prototype.getOuterHTML): (WebInspector.DOMNode.prototype.setOuterHTML): (WebInspector.DOMNode.prototype.removeNode): (WebInspector.DOMNode.prototype.copyNode): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.EventListeners.getEventListenersForNode):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype.updateChildren): ():
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.evaluate):
  • inspector/front-end/inspector.js:
12:24 AM Changeset in webkit [80930] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

12:07 AM Changeset in webkit [80929] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-12 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
​https://bugs.webkit.org/show_bug.cgi?id=56244

  • CMakeLists.txt: Add missing files.
  • platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).

2011-03-12 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
​https://bugs.webkit.org/show_bug.cgi?id=56244

  • ewk/ewk_settings.cpp: (ewk_settings_icon_database_path_set):
Note: See TracTimeline for information about the timeline view.