⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 14, 2011:

11:58 PM Changeset in webkit [81119] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Another Chromium rebaseline for r81095.

  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
11:50 PM Changeset in webkit [81118] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Buildfix when JIT is not enabled after r81079
​https://bugs.webkit.org/show_bug.cgi?id=56361

  • runtime/Executable.cpp:
11:34 PM Changeset in webkit [81117] by Adam Roben
  • 1 edit
    1 add in trunk/Tools

Add forgotten file from r81116

  • TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
11:21 PM Changeset in webkit [81116] by weinig@apple.com
  • 12 edits
    1 add in trunk

about:blank fake responses don't get serialized when sent the UIProcess
<rdar://problem/9108119>
​https://bugs.webkit.org/show_bug.cgi?id=56357

Source/WebCore:

Reviewed by Adam Roben

Test: AboutBlankLoad

  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
Create a CFURLResponseRef if one does not exist yet as we do for
NSURLResponses on the mac.

Tools:

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Add test that loads of about:blank have a response with a MIMEType of text/html.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
Add helper to get the MIMEType from a WKURLResponse.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add new files.

11:11 PM Changeset in webkit [81115] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

REGRESSION: Print preview is blank when selecting multiple pages per sheet
​https://bugs.webkit.org/show_bug.cgi?id=56341
<rdar://problem/8991382>

  • UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected callback number after receiving a different one. We only update preview after receiving the latest expected page data (and the assumption is that AppKit will ask for pages in natural order for N-up).
10:59 PM Changeset in webkit [81114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
​https://bugs.webkit.org/show_bug.cgi?id=56145

We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
of a bug in QtMultimedia.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::seek): (WebCore::MediaPlayerPrivateQt::stateChanged): (WebCore::MediaPlayerPrivateQt::positionChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
10:56 PM Changeset in webkit [81113] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-14 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Graphics Context is not properly recovered if the GPU process dies.
​https://bugs.webkit.org/show_bug.cgi?id=56148

Split context recreation into two steps.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h:
10:50 PM Changeset in webkit [81112] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2011-03-14 MORITA Hajime <​morrita@google.com>

Unreviewed, skipped tests that uses an unsupported DRT API.

  • platform/qt/Skipped:
  • platform/win/Skipped:
10:48 PM Changeset in webkit [81111] by ap@apple.com
  • 5 edits in trunk

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=44138
Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests.

  • platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that locally, becasue most WebSocket tests time out on my machine.

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=44138
Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html

​https://bugs.webkit.org/show_bug.cgi?id=55375
http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

​https://bugs.webkit.org/show_bug.cgi?id=56185
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

  • platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that a pointer can be passed across threads when wrapped in a RefPtr.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists when executing a method on main thread by using RefPtr.
10:44 PM Changeset in webkit [81110] by rniwa@webkit.org
  • 20 edits
    1 delete in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaselines for r81095.

  • platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/selection/after-line-break-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
10:31 PM Changeset in webkit [81109] by rniwa@webkit.org
  • 21 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

GTK and Qt rebaselines for r81095.

  • platform/gtk/editing/deleting/smart-delete-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-002-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/gtk/editing/selection/expanding-selections-expected.txt:
  • platform/gtk/editing/selection/expanding-selections2-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/selection/expanding-selections-expected.txt:
  • platform/qt/editing/selection/expanding-selections2-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
10:24 PM Changeset in webkit [81108] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=56006

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
9:58 PM Changeset in webkit [81107] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix. Part 1 of N.

  • WebCore.exp.in:
9:49 PM Changeset in webkit [81106] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 James Kozianski <​koz@chromium.org>

Reviewed by Ojan Vafai.

Add method to make BuildBot return test outputs
​https://bugs.webkit.org/show_bug.cgi?id=54374

The Builder.latest_cached_build will be used by the new rebaseline
script to determine the build to use baselines from.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
9:30 PM Changeset in webkit [81105] by Adam Roben
  • 10 edits
    2 adds in trunk

Make WKBundlePageCanHandleRequest return true for empty document URLs

Reviewed by Sam Weinig.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
empty documents, and defer to the platform for everything else.

  • WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformCanHandleRequest):
Renamed from canHandleRequest.

Tools:

Test that WKBundlePageCanHandleRequest returns true for empty document URLs

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
(TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
(TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
ensure the web process is initialized, then ask the bundle to run the test and assert that
it succeeded.

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.

(TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
(TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
handle a given URL.
(TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
URL type cannot be handled).
(TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
result.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

Added new files to the project.

9:11 PM Changeset in webkit [81104] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
​https://bugs.webkit.org/show_bug.cgi?id=56316

  • http/tests/media/video-play-stall-before-meta-data-expected.txt: Added.
  • http/tests/media/video-play-stall-before-meta-data.html: Added.

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
​https://bugs.webkit.org/show_bug.cgi?id=56316

We should stop delaying the load event when the load has
stalled naturally, or if we require a user gesture to
continue the load.

Test: http/tests/media/video-play-stall-before-meta-data.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
8:56 PM Changeset in webkit [81103] by mrowe@apple.com
  • 12 edits in trunk

Roll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots.

8:50 PM Changeset in webkit [81102] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Possible leaks after splitting TextCheckerClientEnchant.
​https://bugs.webkit.org/show_bug.cgi?id=55989

Convert gchar* to GOwnPtr<gchar> and refactor the code.

  • WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
7:38 PM Changeset in webkit [81101] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-03-13 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
​https://bugs.webkit.org/show_bug.cgi?id=48799

  • editing/pasteboard/drop-file-svg.html: Added.
  • editing/pasteboard/resources/drop-file-svg.svg: Added.

2011-03-13 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
​https://bugs.webkit.org/show_bug.cgi?id=48799

DragController tried to dispatch textInput event even when the
drag destination is not the editable area.
This change skips the event dispatching on that case.

Test: editing/pasteboard/drop-file-svg.html

  • page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): (WebCore::DragController::concludeEditDrag):
7:28 PM Changeset in webkit [81100] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Made the global object moving-GC-safe
​https://bugs.webkit.org/show_bug.cgi?id=56348


SunSpider reports no change.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Removed a dubious comment that suggested we do not need to visit all our references during GC, since that is not true in a moving GC.

Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.

  • runtime/JSGlobalObject.h: Re-sorted data members by type.
7:27 PM Changeset in webkit [81099] by levin@chromium.org
  • 17 edits in trunk

Unreviewed, rolling out r81094.
​http://trac.webkit.org/changeset/81094
​https://bugs.webkit.org/show_bug.cgi?id=56355

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-03-14
Broke the chromium DRT related build. (Requested by dave_levin
on #webkit).

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText):

  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::layerTreeAsText):

  • src/WebFrameImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):
(TestShell::dump):

  • DumpRenderTree/chromium/TestShell.h:

(TestParams::TestParams):

7:24 PM Changeset in webkit [81098] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
the Chromium build, otherwise the objects visible in the global scope
change.

  • WebCore.gyp/WebCore.gyp:
7:17 PM Changeset in webkit [81097] by commit-queue@webkit.org
  • 12 edits in trunk

2011-03-14 Rik Cabanier <​cabanier@gmail.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-14 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
7:09 PM Changeset in webkit [81096] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Attempted Chromium build fix. Exclude AllInOne harder.

  • WebCore.gyp/WebCore.gyp:
7:07 PM Changeset in webkit [81095] by rniwa@webkit.org
  • 19 edits in trunk

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

EventHandler calls shouldChangeSelection needlessly
​https://bugs.webkit.org/show_bug.cgi?id=56324

Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
avoided calling shouldChangeSelection and setSelection when the existing
selection is identical to that of new selection.

  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): Extracted. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.
6:56 PM Changeset in webkit [81094] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
6:42 PM Changeset in webkit [81093] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add remaining files to WebCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=56351

Adding the remaining files to WebCore.gypi required updating the
include/exclude lists in WebCore.gyp. These lists aren't overly
elegant, but we can try to improve them in the future.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/ScriptCachedFrameData.cpp:
    • Added ifdefs to this file to match the header.
  • platform/graphics/WOFFFileFormat.cpp:
    • Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
6:19 PM Changeset in webkit [81092] by antonm@chromium.org
  • 13 edits in trunk

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::calculateRootStyleSheet): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping): (WebCore::V8GCController::gcPrologue):
  • bindings/v8/WrapperTypeInfo.h: (WebCore::WrapperTypeInfo::isSubclass):
  • css/CSSRuleList.h: (WebCore::CSSRuleList::styleList):
  • css/StyleSheetList.h: (WebCore::StyleSheetList::document):
6:15 PM Changeset in webkit [81091] by luiz@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping some tests on Windows due to problems on mouse click handling.
See ​https://bugs.webkit.org/show_bug.cgi?id=56347.

  • platform/win/Skipped:
6:13 PM Changeset in webkit [81090] by rniwa@webkit.org
  • 17 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).

  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
  • platform/mac-leopard/editing/selection/fake-drag-expected.png:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
6:11 PM Changeset in webkit [81089] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
​https://bugs.webkit.org/show_bug.cgi?id=56336

Reviewed by Beth Dakin.

Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
pointers.

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityHitTest:]):

5:53 PM Changeset in webkit [81088] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

Assertion failure by form validation message for <select required> with float:left
​https://bugs.webkit.org/show_bug.cgi?id=55995

Reviewed by James Robinson.

Source/WebCore:

Test: fast/forms/interactive-validation-select-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks):

isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().

LayoutTests:

  • fast/forms/interactive-validation-select-crash-expected.txt: Added.
  • fast/forms/interactive-validation-select-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:48 PM Changeset in webkit [81087] by alice.liu@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide API for creating WKImage from CGImageRef
​https://bugs.webkit.org/show_bug.cgi?id=56159

Reviewed by Sam Weinig.

Add function for creating a WKImage from CGImage data.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it.

  • Shared/API/c/cg/WKImageCG.h:
5:39 PM Changeset in webkit [81086] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Made JSWrapperObject and subclasses moving-GC-safe
​https://bugs.webkit.org/show_bug.cgi?id=56346


SunSpider reports no change.

  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code. This doesn't cause any problems in our existing code since the base class never reads the anonymous slot it declares, but it caused crashes when I tried to start using the slot in an initial version of this patch.
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue): Resolved a problem where our internal value was stored in two places: an anonymous slot, and a data member which was not always visited during GC. Now, we only use the data member, and we always visit it. (Instead of relying on certain subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/NumberObject.h: Removed meaningless declaration.
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/StringObject.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code.
5:36 PM Changeset in webkit [81085] by msaboff@apple.com
  • 4 edits
    3 adds in trunk

2011-03-14 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
​https://bugs.webkit.org/show_bug.cgi?id=56082

Changed parentheses assertion processing to temporarily back out the
number of known characters after the assertion while processing the
assertion. This was done so that assertions don't fail due to
checking the number of required characters as additional to the
rest of the express since assertions don't "consume" input.
Added a byte code to uncheck characters to support the change.

  • yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::uncheckInput): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::UncheckInput):

2011-03-14 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
​https://bugs.webkit.org/show_bug.cgi?id=56082

New tests to verify the corresponding changes.

  • fast/regex/assertion-expected.txt: Added.
  • fast/regex/assertion.html: Added.
  • fast/regex/script-tests/assertion.js: Added.
5:32 PM Changeset in webkit [81084] by kbalazs@webkit.org
  • 15 edits in trunk

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

No code changes so no new tests.

Revert the changes that were needed to use KURL
in WebKitTestRunner.

  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

Add API's to WKURL and WKString to satisfy
WebKitTestRunner's needs.

  • Shared/API/c/WKString.cpp: (WKStringIsEqualToUTF8CStringIgnoringCase):
  • Shared/API/c/WKString.h:
  • Shared/API/c/WKURL.cpp: (WKURLCopyHostName): (WKURLCopyScheme):
  • Shared/API/c/WKURL.h:
  • Shared/WebString.h: (WebKit::WebString::equalToUTF8StringIgnoringCase):
  • Shared/WebURL.h: Added OwnPtr<KURL> member to be able to lazily parse the URL and store the result. (WebKit::WebURL::host): (WebKit::WebURL::protocol): (WebKit::WebURL::parseURLIfNecessary):
  • win/WebKit2.def: Revert the symbol exports that were needed to use KURL in WebKitTestRunner.

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2 API's instead of KURL to analyze the URL.
  • WebKitTestRunner/StringFunctions.h: (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally in the WebKitTestRunner project. (WTR::toWK): Use adoptWK. (WTR::operator<<): Added helper for printing a WKURL.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link against WebCore.
4:59 PM Changeset in webkit [81083] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

It's the same old song (about the linux debug crash).

  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [81082] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-14 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56340

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetScrollOffsetOnNextResize): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size. (WebKit::WebView::setScrollOffsetOnNextResize): Added.
  • UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
4:47 PM Changeset in webkit [81081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
​https://bugs.webkit.org/show_bug.cgi?id=56133

Add condition to not compile webkit internal math round functions on RVCT compiler versions
from 3.0.0 because they are already defined in compiler math library.

  • wtf/MathExtras.h:
4:40 PM Changeset in webkit [81080] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix two memory leaks within LayoutTestController's storage support.

Reviewed by Adam Roben.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
by JSStringCreateWithCFString.
(LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
allocate.

4:31 PM Changeset in webkit [81079] by barraclough@apple.com
  • 5 edits
    20 adds in trunk/Source/JavaScriptCore

Bug 56284 - Add a dataflow intermediate representation for use in JIT generation.

Reviewed by Geoffrey Garen & Oliver Hunt.

The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.

This patch adds:

  • a dataflow intermediate representation capable of describing a single basic block of operations,
  • a mechanism to convert a simple, single-block bytecode functions to the new IR,
  • and a JIT code generator capable of generating code from this representation.

The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.

The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.

The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:

  • the policy to only generate arithmetic code on the speculative path using integer instructions, never using floating point.
  • the policy to only generate arithmetic code on the non-speculative path using floating point instructions, never using integer.
  • always generating JSValue adds on the non-speculative path as a call out to a C-function, never handling this in JIT code.
  • always assuming by-Value property accesses on the speculative path to be array accesses.
  • generating all by-Value property accesses from the non-speculative path as a call out to a C-function.
  • generating all by-Indentifer property accesses as a call out to a C-function.

Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files to Xcode project.
  • dfg: Added.
    • Added directory for new code.
  • dfg/DFGByteCodeParser.cpp: Added.
  • dfg/DFGByteCodeParser.h: Added.
    • Contruct a DFG::Graph representation from a bytecode CodeBlock.
  • dfg/DFGGenerationInfo.h: Added.
    • Track type & register information for VirtualRegisters during JIT code generation.
  • dfg/DFGGraph.cpp: Added.
  • dfg/DFGGraph.h: Added.
    • Dataflow graph intermediate representation for code generation.
  • dfg/DFGJITCodeGenerator.cpp: Added.
  • dfg/DFGJITCodeGenerator.h: Added.
    • Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
  • dfg/DFGJITCompiler.cpp: Added.
  • dfg/DFGJITCompiler.h: Added.
    • Class responsible for driving code generation of speculativeJIT & non-speculative code paths from the dataflow graph.
  • dfg/DFGNonSpeculativeJIT.cpp: Added.
  • dfg/DFGNonSpeculativeJIT.h: Added.
    • Used to generate the non-speculative code path, this make no assumptions about operand types.
  • dfg/DFGOperations.cpp: Added.
  • dfg/DFGOperations.h: Added.
    • Helper functions called from the JIT generated code.
  • dfg/DFGRegisterBank.h: Added.
    • Used to track contents of physical registers during JIT code generation.
  • dfg/DFGSpeculativeJIT.cpp: Added.
  • dfg/DFGSpeculativeJIT.h: Added.
    • Used to generate the speculative code path, this make assumptions about operand types to enable optimization.
  • runtime/Executable.cpp:
    • Add code to attempt to use the DFG JIT to compile a function, with fallback to the existing JIT.
  • wtf/Platform.h:
    • Added compile guards to enable the DFG JIT.
4:29 PM Changeset in webkit [81078] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more linux debug crashers to the sad list.

  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [81077] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
​https://bugs.webkit.org/show_bug.cgi?id=56321

  • Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c" to the list of exceptions for WebKit2 C API headers.
4:24 PM Changeset in webkit [81076] by Martin Robinson
  • 7 edits
    4 adds in trunk/LayoutTests

2011-03-14 Martin Robinson <​mrobinson@igalia.com>

Update GTK+ pixel results after r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.checksum:
  • platform/gtk/editing/selection/drag-select-1-expected.png:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
  • platform/gtk/editing/selection/fake-drag-expected.png: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
4:14 PM Changeset in webkit [81075] by Adam Roben
  • 2 edits in trunk/Tools

Show the list of recent leaky builds in reverse chronological order

Previously they were being shown in a deterministic but surprising order based on
lexicographically sorting the build offsets (-1, -10, -2, -3...).

Fixes <​http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
callback.

4:13 PM Changeset in webkit [81074] by psolanki@apple.com
  • 3 edits in trunk/WebKitLibraries

I checked in Intel-only version of these files in r80975. This fixes that by building all
the correct slices - i386/x86_64/ppc for SnowLeopard and i386/x86_64/ppc/ppc64 for Leopard.

Rubber-stamped by Mark Rowe.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:47 PM Changeset in webkit [81073] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Upstream test expectations from the chromium repository to WebKit.

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [81072] by rniwa@webkit.org
  • 15 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac pixel rebaselines for r81053.

  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/fake-drag-expected.checksum:
  • platform/mac/editing/selection/fake-drag-expected.png:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
3:31 PM Changeset in webkit [81071] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed more cases of DeprecatedPtr (exception, SmallStrings)
​https://bugs.webkit.org/show_bug.cgi?id=56332

  • runtime/Identifier.cpp: (JSC::Identifier::add): (JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because this reference is owned and managed directly by the heap.
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope):
  • runtime/JSString.h: (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsString): (JSC::jsStringWithFinalizer): (JSC::jsSubstring): (JSC::jsOwnedString): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::markChildren): (JSC::SmallStrings::clear): (JSC::SmallStrings::count): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of DeprecatedPtr because these references are owned and managed directly by the heap.


Stop using FixedArray because we only want a very limited set
of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)

  • runtime/WriteBarrier.h: (JSC::operator==): (JSC::WriteBarrier::WriteBarrier): (JSC::HeapRoot::HeapRoot): (JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set without write barrier because we assume all HeapRoots are scanned during all GC passes.
3:28 PM Changeset in webkit [81070] by levin@chromium.org
  • 17 edits in trunk/LayoutTests

Update the chromium windows baselines for r81053.

  • platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-win/editing/selection/drag-select-1-expected.png:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:25 PM Changeset in webkit [81069] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation fails with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=55964

  • WebCore.pro:
  • platform/graphics/qt/Extensions3DQt.cpp:
3:19 PM Changeset in webkit [81068] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Show a list of up to 10 recent leaky builds when Leaks Viewer loads

Fixes <​http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
analyze

Reviewed by David Kilzer and Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#url-prompt): Made this a bit taller to make room for the list of builds.

(#recent-builds-loading-indicator):
(#recent-builds-list):
Added styles for the build list and loading indicator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
it. This will unescape it.
(LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
(LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
(LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
(LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
prompt UI.
(LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
now also used when a recent build is clicked.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.

(RecentBuildsLoader): Store the callback.
(RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
builder. Find the revision number, leak count, and results URL for each one. Pass the
resulting info to our callback.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:

(range): Added this helper function to return an array containing the integers [0, n).

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added

RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.

3:17 PM Changeset in webkit [81067] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed typo in the change log entry for r81066.

3:15 PM Changeset in webkit [81066] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

GTK rebaselines or r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:15 PM Changeset in webkit [81065] by bweinstein@apple.com
  • 7 edits
    2 adds in trunk/Source

FileSystemWin.cpp needs listDirectory() implementation
​https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>

Reviewed by Adam Roben and Gavin Barraclough.

Source/JavaScriptCore:

Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.

  • wtf/text/StringConcatenate.h:

Source/WebCore:

Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.

Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FileSystemWin.cpp:

(WebCore::listDirectory): Call through to PathWalker.

  • platform/win/PathWalker.cpp: Added.

(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument

for the pattern to pass to the Windows File APIs.

(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.

  • platform/win/PathWalker.h: Added.

Source/WebKit2:

Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::pluginPathsInDirectory):

3:14 PM Changeset in webkit [81064] by levin@chromium.org
  • 13 edits
    21 adds in trunk/LayoutTests

Add rebaselines due to two changes:
For r81053, we have

editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml

For r81049, we have

fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html

  • platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.png:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [81063] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.

  • platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
2:48 PM Changeset in webkit [81062] by luiz@webkit.org
  • 2 edits
    45 adds in trunk/LayoutTests

Adjusting Snow Leopard expected results after r81035.

  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/mac/fast/html/details-open1-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt: Added.
  • platform/mac/fast/html/details-open3-expected.txt: Added.
  • platform/mac/fast/html/details-open4-expected.txt: Added.
  • platform/mac/fast/html/details-open5-expected.txt: Added.
  • platform/mac/fast/html/details-open6-expected.txt: Added.
  • platform/mac/fast/html/details-position-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
2:45 PM Changeset in webkit [81061] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Qt rebaselines for r81053.

  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:44 PM Changeset in webkit [81060] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did. (sigh)

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

2:35 PM Changeset in webkit [81059] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac rebaselines for r81053.

  • platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:25 PM Changeset in webkit [81058] by beidson@apple.com
  • 11 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"

Reviewed by Anders Carlsson.

../WebCore:

Remove HistoryItem::icon():

  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • WebCore.exp.in:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::defaultIcon):

../WebKit/efl:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get): Use IconDatabase directly.

../WebKit/mac:

  • History/WebHistoryItem.mm:

(-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.

../WebKit/qt:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon): Use IconDatabase directly.

2:22 PM Changeset in webkit [81057] by aestes@apple.com
  • 4 edits
    2 adds in trunk

2011-03-13 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
​https://bugs.webkit.org/show_bug.cgi?id=55104

  • fast/events/popup-blocking-timers-expected.txt: Added.
  • fast/events/popup-blocking-timers.html: Added.

2011-03-14 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
​https://bugs.webkit.org/show_bug.cgi?id=55104

If a timer is installed by a gesture-originated event and will fire
within one second, the timer-initiated event should behave as if it
were also initiated by a user gesture. Multi-shot timers should only
get this behavior on their first execution. Nested timers should not
get this behavior. This makes us compatible with Gecko when handling
popups and file chooser dialogs created from timer events.

Test: fast/events/popup-blocking-timers.html

  • page/DOMTimer.cpp: (WebCore::timeoutId): Create a helper function so that m_timeoutId can be initialized in the data member initialization list. (WebCore::shouldForwardUserGesture): Ditto, but for m_shouldForwardUserGesture. (WebCore::DOMTimer::DOMTimer): Move initialization of data members from the ctor body to the data member initialization list. Also rename the argument 'timeout' to 'interval'. (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its state based on the value of m_shouldForwardUserGesture. (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was renamed to m_originalInterval.
  • page/DOMTimer.h: Add m_shouldForwardUserGesture and rename m_originalTimeout to m_originalInterval.
2:19 PM Changeset in webkit [81056] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-09 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
​https://bugs.webkit.org/show_bug.cgi?id=56053

Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.

  • editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
  • editing/deleting/delete-inserts-br-after-button.html: Added.

2011-03-09 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
​https://bugs.webkit.org/show_bug.cgi?id=56053

Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
DeleteSelectionCommand treating them as blockflow.

Test: editing/deleting/delete-inserts-br-after-button.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs):
1:56 PM Changeset in webkit [81055] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45164

Reviewed by Dan Bernstein.

REGRESSION: <a><img align=top></a> Clickable area too large

Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.

Source/WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

LayoutTests:

  • fast/inline/inline-position-top-align-expected.txt: Added.
  • fast/inline/inline-position-top-align.html: Added.
1:53 PM Changeset in webkit [81054] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
​https://bugs.webkit.org/show_bug.cgi?id=52845

The lastCommitTime() value in CACFLayerTreeHost was returning as the time
the render previous to this one happened. That often made it seem like
animations started more in the past than they did, breaking many animations.
The startAnimations() call actually fires from a CACF callback after all the
WebKit content has been rendered. So sending currentTime as the start time
to the animations is close enough for proper synchronization.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
1:47 PM Changeset in webkit [81053] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
​https://bugs.webkit.org/show_bug.cgi?id=56213

Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
using the mouse coordinates of the mousedown event that started the drag.

Test: editing/selection/drag-select-rapidly.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent):

2011-03-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
​https://bugs.webkit.org/show_bug.cgi?id=56213

Added a test to ensure the selection start is computed using the mouse coordinates passed down
to the corresponding mousedown event instead of that of the first mousemove event.

The test is co-authored by Evan Martin.

  • editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
  • editing/selection/anchor-focus3-expected.txt: Ditto.
  • editing/selection/drag-select-rapidly-expected.txt: Added.
  • editing/selection/drag-select-rapidly.html: Added.
  • platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
  • platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
1:45 PM Changeset in webkit [81052] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Add a baseline for linux for this test since it matches what we have for OSX
except for the typical minor font differences.

  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 PM Changeset in webkit [81051] by mrowe@apple.com
  • 4 edits in trunk

<​http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions): Remove duplicate entries.

1:40 PM Changeset in webkit [81050] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Apply a large, blunt object directly to the skull of the Leopard build.

Reviewed by Timothy Hatcher.

  • Configurations/Base.xcconfig: Disable the generation of debugging symbols when

building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.

1:30 PM Changeset in webkit [81049] by hyatt@apple.com
  • 10 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=56246

Reviewed by Beth Dakin.

Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.

Source/WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRelPositioned):

  • rendering/RenderTableCell.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/table/relative-position-containment.html: Added.
  • fast/table/relative-position-offsets.html: Added.
  • fast/table/relative-position-stacking.html: Added.
  • platform/mac/fast/table/overflowHidden-expected.txt:
  • platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/mac/fast/table/relative-position-containment-expected.txt: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.txt: Added.
1:20 PM Changeset in webkit [81048] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Partial backout of ​https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
layer, since first layouts and printing mess up otherwise.

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

1:19 PM Changeset in webkit [81047] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Improvements for the mondo linux debug failure list changes:

+ Add more tests that belong there.
+ Sort the tests that are there.
+ Add PASS to the lines that are there since these tests are known to pass and a passing

result for them shouldn't cause a test run to go orange.

  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [81046] by alice.liu@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/PerlSupport/Makefile:

Add whitespace when joining "-arch" with the architectures passed in as arguments.

11:59 AM Changeset in webkit [81045] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.

Reviewed by Simon Fraser.

Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.

Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.

No new tests, since this is untestable on ports that invalidate on a resize.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):

  • rendering/RenderLayer.h:
11:51 AM Changeset in webkit [81044] by levin@chromium.org
  • 3 edits
    361 adds in trunk/LayoutTests

Rebaselines due to r81035.
Also, added yet more tests to the linux debug crash sweeping through the layout tests.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open1-expected.png: Added.
  • platform/chromium-win/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open2-expected.png: Added.
  • platform/chromium-win/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open3-expected.png: Added.
  • platform/chromium-win/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open4-expected.png: Added.
  • platform/chromium-win/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open5-expected.png: Added.
  • platform/chromium-win/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open6-expected.png: Added.
  • platform/chromium-win/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-position-expected.png: Added.
  • platform/chromium-win/fast/html/details-position-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [81043] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build

11:38 AM Changeset in webkit [81042] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Daniel Bates <​dbates@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=55438
Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
when landing changeset 81041 <​http://trac.webkit.org/changeset/81041>.

  • Scripts/build-webkit:
11:23 AM Changeset in webkit [81041] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
​https://bugs.webkit.org/show_bug.cgi?id=55438

Separate out the EFL- and WinCE-specific logic from the port-independent logic in
webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
CMake arguments for feature defines.

  • Scripts/build-webkit:
    • Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
    • Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
    • Sorted forward declarations.
    • Initialize $makeArgs with the empty string so as to simplify its use in string operations; Modified call sites as needed.
  • Scripts/webkitdirs.pm:
    • Added cleanCMakeGeneratedProject() to clean a CMake build.
    • Added buildCMakeGeneratedProject() to build using generated build system.
    • Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
    • Added generateBuildSystemFromCMakeProject() to generate the build system from a CMake project.
    • Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
11:16 AM Changeset in webkit [81040] by oliver@apple.com
  • 32 edits in trunk/Source

2011-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
​https://bugs.webkit.org/show_bug.cgi?id=56214

This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.

For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.

  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):

2011-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
​https://bugs.webkit.org/show_bug.cgi?id=56214

Make sure everything builds still.

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
11:02 AM Changeset in webkit [81039] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix for r81035.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::defaultEventHandler):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):

10:52 AM Changeset in webkit [81038] by jer.noble@apple.com
  • 15 edits
    4 adds in trunk

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

FullScreen: Handle entering full screen security restrictions
​https://bugs.webkit.org/show_bug.cgi?id=56264

  • fullscreen/full-screen-css.html: Use runWithKeyDown.
  • fullscreen/full-screen-remove-ancestor.html: Ditto.
  • fullscreen/full-screen-remove.html: Ditto.
  • fullscreen/full-screen-request.html: Ditto.
  • fullscreen/full-screen-twice.html: Ditto.
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-iframe-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-allowed.html: Added.
  • fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-not-allowed.html: Added. (runWithKeyDown): Added. Wraps the command in a keyDown/keyPress

listener.

  • platform/mac-wk2/Skipped: Added new tests to skipped list.
  • platform/qt-wk2/Skipped: Ditto.

2011-03-13 Jer Noble <​jer.noble@apple.com>

FullScreen: Handle entering full screen security restrictions
​https://bugs.webkit.org/show_bug.cgi?id=56264

Tests: fullscreen/full-screen-iframe-allowed.html

fullscreen/full-screen-iframe-not-allowed.html

Disable full screen documents in the following conditions:
1) requesting element is in an iframe which does not have a
webkitallowfullscreen attribute.
2) page is not processing a user gesture.

  • dom/Document.cpp: (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks

to see if elements contained in IFRAMES are allowed to
enter full screen.

(WebCore::Document::webkitRequestFullScreenForElement): Checks

if page is currently processing a user gesture.

  • dom/Document.h:
  • html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
  • html/HTMLFrameElementBase.h:
10:46 AM Changeset in webkit [81037] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
​https://bugs.webkit.org/show_bug.cgi?id=56303

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-14
Reviewed by David Levin.

Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):

10:39 AM Changeset in webkit [81036] by steveblock@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-14 Steve Block <​steveblock@google.com>

Reviewed by Oliver Hunt.

JavaMethod.cpp does not compile with V8
​https://bugs.webkit.org/show_bug.cgi?id=56306

Moved the ScopeChain.h include to JavaStringJSC.

No new tests, build fix only.

  • bridge/jni/JavaMethod.cpp:
  • bridge/jni/jsc/JavaStringJSC.h
10:35 AM Changeset in webkit [81035] by luiz@webkit.org
  • 15 edits
    92 adds in trunk

HTML5 <details> and <summary>: rendering
​https://bugs.webkit.org/show_bug.cgi?id=51071

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/html/details-add-summary-1-and-click.html

fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-mouse-click.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html

​http://www.w3.org/TR/html5/interactive-elements.html#the-details-element

The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):

  • html/HTMLDetailsElement.h:

(WebCore::HTMLDetailsElement::mainSummary):

Method createRenderer added to class HTMLSummaryElement.

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createRenderer):

  • html/HTMLSummaryElement.h:

The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):

  • rendering/RenderDetails.h:

(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):

A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):

  • rendering/RenderDetailsMarker.h:

(WebCore::toRenderDetailsMarker):

  • rendering/RenderSummary.cpp:

(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):

  • rendering/RenderSummary.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

  • fast/html/details-add-summary-1-and-click.html: Added.
  • fast/html/details-add-summary-1.html: Added.
  • fast/html/details-add-summary-10-and-click.html: Added.
  • fast/html/details-add-summary-10.html: Added.
  • fast/html/details-add-summary-2-and-click.html: Added.
  • fast/html/details-add-summary-2.html: Added.
  • fast/html/details-add-summary-3-and-click.html: Added.
  • fast/html/details-add-summary-3.html: Added.
  • fast/html/details-add-summary-4-and-click.html: Added.
  • fast/html/details-add-summary-4.html: Added.
  • fast/html/details-add-summary-5-and-click.html: Added.
  • fast/html/details-add-summary-5.html: Added.
  • fast/html/details-add-summary-6-and-click.html: Added.
  • fast/html/details-add-summary-6.html: Added.
  • fast/html/details-add-summary-7-and-click.html: Added.
  • fast/html/details-add-summary-7.html: Added.
  • fast/html/details-add-summary-8-and-click.html: Added.
  • fast/html/details-add-summary-8.html: Added.
  • fast/html/details-add-summary-9-and-click.html: Added.
  • fast/html/details-add-summary-9.html: Added.
  • fast/html/details-mouse-click-expected.txt: Added.
  • fast/html/details-mouse-click.html: Added.
  • fast/html/details-no-summary1.html: Added.
  • fast/html/details-no-summary2.html: Added.
  • fast/html/details-no-summary3.html: Added.
  • fast/html/details-no-summary4.html: Added.
  • fast/html/details-open-javascript.html: Added.
  • fast/html/details-open1.html: Added.
  • fast/html/details-open2.html: Added.
  • fast/html/details-open3.html: Added.
  • fast/html/details-open4.html: Added.
  • fast/html/details-open5.html: Added.
  • fast/html/details-open6.html: Added.
  • fast/html/details-position.html: Added.
  • fast/html/details-remove-summary-1-and-click.html: Added.
  • fast/html/details-remove-summary-1.html: Added.
  • fast/html/details-remove-summary-2-and-click.html: Added.
  • fast/html/details-remove-summary-2.html: Added.
  • fast/html/details-remove-summary-3-and-click.html: Added.
  • fast/html/details-remove-summary-3.html: Added.
  • fast/html/details-remove-summary-4-and-click.html: Added.
  • fast/html/details-remove-summary-4.html: Added.
  • fast/html/details-remove-summary-5-and-click.html: Added.
  • fast/html/details-remove-summary-5.html: Added.
  • fast/html/details-remove-summary-6-and-click.html: Added.
  • fast/html/details-remove-summary-6.html: Added.
  • fast/html/details-writing-mode.html: Added.
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary1-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary2-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary3-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary4-expected.txt: Added.
  • platform/qt/fast/html/details-open-javascript-expected.txt: Added.
  • platform/qt/fast/html/details-open1-expected.txt: Added.
  • platform/qt/fast/html/details-open2-expected.txt: Added.
  • platform/qt/fast/html/details-open3-expected.txt: Added.
  • platform/qt/fast/html/details-open4-expected.txt: Added.
  • platform/qt/fast/html/details-open5-expected.txt: Added.
  • platform/qt/fast/html/details-open6-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-writing-mode-expected.txt: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
10:20 AM Changeset in webkit [81034] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56296
Clean up IconDatabaseBase header.

Reviewed by Sam Weinig.

-Get rid of the "PlatformString.h" include and replace it with a forward declaration.
-Group methods by which are used in WebCore directly and which are used in WebKit ports.

This'll make it easier to use in external frameworks (like WebKit2).

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::open):

9:47 AM Changeset in webkit [81033] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76437 - 2011-01-22 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
​https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com
Review URL: ​http://codereview.chromium.org/6686050

9:47 AM Changeset in webkit [81032] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: No icon shown for <input type=file>
<rdar://problem/8988982>
​https://bugs.webkit.org/show_bug.cgi?id=54288

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::chooseIconForFiles):
Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles.

9:46 AM Changeset in webkit [81031] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76864 - 2011-01-27 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Tiled compositor crashes if compositing turned off mid-paint
​https://bugs.webkit.org/show_bug.cgi?id=53198

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):

TBR=​enne@google.com
Review URL: ​http://codereview.chromium.org/6686049

9:43 AM Changeset in webkit [81030] by podivilov@chromium.org
  • 14 edits
    2 deletes in trunk

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
​http://trac.webkit.org/changeset/81026
​https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/debugger/xhr-breakpoints-expected.txt: Removed.
  • inspector/debugger/xhr-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
​http://trac.webkit.org/changeset/81026
​https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._createXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.BreakpointManager.prototype._createXHRBreakpointId): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._serializeToJSON): (WebInspector.XHRBreakpointView): (WebInspector.XHRBreakpointView.prototype.compareTo): (WebInspector.XHRBreakpointView.prototype.populateEditElement): (WebInspector.XHRBreakpointView.prototype.populateLabelElement): (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.set attached):
9:08 AM Changeset in webkit [81029] by mnaganov@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
​https://bugs.webkit.org/show_bug.cgi?id=56312

Test: inspector/utilities.html

  • inspector/front-end/utilities.js:

2011-03-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
​https://bugs.webkit.org/show_bug.cgi?id=56312

  • inspector/utilities-expected.txt: Added.
  • inspector/utilities.html: Added.
8:33 AM Changeset in webkit [81028] by antonm@chromium.org
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
​https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=​antonm@chromium.org

8:32 AM Changeset in webkit [81027] by antonm@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
​https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=​antonm@chromium.org
Review URL: ​http://codereview.chromium.org/6691008

8:27 AM Changeset in webkit [81026] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
8:16 AM Changeset in webkit [81025] by podivilov@chromium.org
  • 7 edits in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56123

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56123

DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
setBreakpoint/removeBreakpoint are now called from DPM only.

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled): (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
7:21 AM Changeset in webkit [81024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81015.
​http://trac.webkit.org/changeset/81015
​https://bugs.webkit.org/show_bug.cgi?id=56308

A Similar patch landed in r76960 (Requested by philn-tp on
#webkit).

  • GNUmakefile.am:
7:00 AM Changeset in webkit [81023] by pfeldman@chromium.org
  • 10 edits in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
​https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
  • inspector/extensions/extensions-audits-expected.txt:

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
​https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.snippet):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/GoToLineDialog.js:
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/ShortcutsHelp.js: (WebInspector.ShortcutsSection.prototype.renderSection): (WebInspector.ShortcutsSection.prototype._renderHeader):
6:44 AM Changeset in webkit [81022] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Disable live-edit in favor of the text editor
​https://bugs.webkit.org/show_bug.cgi?id=56176

  • inspector/front-end/Settings.js:
6:41 AM Changeset in webkit [81021] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
​https://bugs.webkit.org/show_bug.cgi?id=56095

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer):
6:36 AM Changeset in webkit [81020] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56179

Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
5:51 AM Changeset in webkit [81019] by apavlov@chromium.org
  • 6 edits in trunk

2011-03-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=56111

  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-03-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=56111

This change reduces the getStylesForNode() payload more than twice for BODY elements.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.parsePayload):
5:26 AM Changeset in webkit [81018] by jknotten@chromium.org
  • 31 edits
    4 adds in trunk

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
generated on watch when window is closed.

  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
​https://bugs.webkit.org/show_bug.cgi?id=55577

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
​https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocation):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp: (WebCore::Navigator::resetGeolocation):
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  • platform/mock/GeolocationClientMock.h:

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

  • DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
5:11 AM Changeset in webkit [81017] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
​https://bugs.webkit.org/show_bug.cgi?id=56183

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleKeyDown): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:57 AM Changeset in webkit [81016] by alex
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <​alex@igalia.com>

Rebaseline GTK+ tests after r80996.

  • platform/gtk/fast/text/soft-hyphen-2-expected.txt:
  • platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.
4:40 AM Changeset in webkit [81015] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Rogers <​crogers@google.com>

Reviewed by Xan Lopez.

Add all web audio auto-generated files to GTK make system
​https://bugs.webkit.org/show_bug.cgi?id=50497

No new tests since these are build-system tweaks.

  • GNUmakefile.am:
4:21 AM Changeset in webkit [81014] by jknotten@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=56202

By testing for geolocation watch errors, the test tests more than
it should, which can cause a flaky result as demonstrated by
​https://bugs.webkit.org/show_bug.cgi?id=56126 .

  • fast/dom/Geolocation/resources/window-close-popup.html:
  • fast/dom/Geolocation/script-tests/window-close-crash.js:
4:19 AM Changeset in webkit [81013] by alex
  • 2 edits in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <​alex@igalia.com>

Update more expectations after r80857.

  • platform/gtk/fast/layers/video-layer-expected.txt:
3:55 AM Changeset in webkit [81012] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Move the crash result and the bug to the debug line for the test (instead of release)
since that is where the crash occurs.

  • platform/chromium/test_expectations.txt:
3:29 AM Changeset in webkit [81011] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: remove the flaky part of the new inspector test for now.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
2:45 AM Changeset in webkit [81010] by pfeldman@chromium.org
  • 9 edits in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/elements/elements-panel-search.html:
  • inspector/elements/mutate-unknown-node.html:

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::cancelSearch): (WebCore::InspectorDOMAgent::onMatchJobsTimer): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.mycallback): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._childNodeCountUpdated): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMAgent.prototype.performSearch): (WebInspector.DOMAgent.prototype.cancelSearch): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._reset): (WebInspector.ElementsPanel.prototype._documentUpdated): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._addNodesToSearchResult): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype._childNodeCountUpdated): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2:42 AM Changeset in webkit [81009] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
​https://bugs.webkit.org/show_bug.cgi?id=56248

  • inspector/elements/edit-dom-actions-expected.txt: Added.
  • inspector/elements/edit-dom-actions.html: Added.

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
​https://bugs.webkit.org/show_bug.cgi?id=56248

Test: inspector/elements/edit-dom-actions.html

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.removeAttribute):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler):
2:07 AM Changeset in webkit [81008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-03-14 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Modify my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
1:44 AM Changeset in webkit [81007] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix typo TEXT vs TEST.

  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [81006] by levin@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

Rebaseline some test due to r80996.
Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
and add a few bugs which track the other failures.

  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:44 AM Changeset in webkit [81005] by beidson@apple.com
  • 4 edits in trunk/Source

<rdar://problem/8762095> and ​https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage

Reviewed by Dan Bernstein.

../WebCore:

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread

before the StorageTracker thread can do it on the background thread.

../WebKit2:

Hookup the existing API stubs to the WebCore implementations:

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

12:11 AM Changeset in webkit [81004] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

2011-03-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move cache_directory api
​https://bugs.webkit.org/show_bug.cgi?id=52139

Move cache directory related apis from ewk_view to ewk_settings because
those are not related to ewk_view.

  • ewk/ewk_main.cpp: (_ewk_init_body):
  • ewk/ewk_settings.cpp: (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del):
  • ewk/ewk_view.h:

Mar 13, 2011:

1:30 AM Changeset in webkit [80958] by levin@chromium.org
  • 12 edits
    40 adds in trunk/LayoutTests

Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

Mar 12, 2011:

11:24 PM Changeset in webkit [81003] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=56285

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):

  • storage/StorageTracker.h:
11:20 PM Changeset in webkit [81002] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
​https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

11:02 PM Changeset in webkit [81001] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

10:47 PM Changeset in webkit [81000] by beidson@apple.com
  • 16 edits in trunk/Source/WebKit2

<rdar://problem/9127270> and ​https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI to set the path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory):

  • UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setLocalStorageDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

10:35 PM Changeset in webkit [80999] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Mark Rowe.

WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
​https://bugs.webkit.org/show_bug.cgi?id=56260

Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

  • UIProcess/mac/WKFullScreenWindowController.mm:
10:23 PM Changeset in webkit [80998] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve my hasitly added build fix and added a bug ​https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:23 PM Changeset in webkit [80997] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Clean up overlapping test_expectation which I mistakenly added in my haste.

  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80996] by mitz@apple.com
  • 13 edits in trunk

Include hyphenation information in text representation of render tree
​https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

  • fast/text/soft-hyphen-4-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphenate-first-word-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
9:56 PM Changeset in webkit [80995] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

A few Heap-related renames (sans file moves, which should come next)
​https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):

  • runtime/ConservativeSet.h:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):

  • runtime/Heap.h:

(JSC::Heap::machineThreads):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):

  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h:

(JSC::MarkStack::append):

9:53 PM Changeset in webkit [80994] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<​https://bugs.webkit.org/show_bug.cgi?id=56270>

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

9:37 PM Changeset in webkit [80993] by levin@chromium.org
  • 4 edits in trunk

Build fix adding remaining enum values to switch statement.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80992] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80991] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [80990] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

8:01 PM Changeset in webkit [80989] by mrowe@apple.com
  • 1 copy in tags/Safari-534.24

New tag.

7:36 PM Changeset in webkit [80988] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after r80982.

  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
6:35 PM Changeset in webkit [80987] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix the Mac build.

ConervativeSet.h, since it's now visible when compiling other projects.

6:27 PM Changeset in webkit [80986] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):
Add missing constructor.

6:16 PM Changeset in webkit [80985] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (ConservativeSet)
​https://bugs.webkit.org/show_bug.cgi?id=56281


The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append. (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated the size of the set based on sizeof(DeprecatedPtr<T>*) instead of sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not. (JSC::ConservativeSet::size): (JSC::ConservativeSet::set): Use direct pointers, as stated above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MarkStack.h: (JSC::MarkStack::append): Created a special case of append for ConservativeSet. I didn't want to add back a generic "append JSCell*" function, since other class might start using that wrong. (In the end, this function might go away, since the Heap will want to do something slightly more interesting with the conservative set, but this is OK for now.)
6:09 PM Changeset in webkit [80984] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Source/WebCore: REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

  • fast/text/soft-hyphen-4-expected.checksum: Added.
  • fast/text/soft-hyphen-4-expected.png: Added.
  • fast/text/soft-hyphen-4-expected.txt: Added.
  • fast/text/soft-hyphen-4.html: Added.
5:58 PM Changeset in webkit [80983] by levin@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [80982] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
​https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

5:34 PM Changeset in webkit [80981] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Add ability to create a WKErrorRef
<rdar://problem/9115768>
​https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add new exports.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

  • Shared/API/c/cf/WKErrorCF.cpp: Added.

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

  • Shared/API/c/cf/WKErrorCF.h: Added.

Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:34 PM Changeset in webkit [80980] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (PutPropertySlot)
​https://bugs.webkit.org/show_bug.cgi?id=56278

  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot, since it's a stack-allocated temporary.
5:31 PM Changeset in webkit [80979] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add one more failure which is related to change in this range:

​http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860

that I haven't been able to narrow down yet.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [80978] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [80977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-13 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher does not load the same set of fonts as the DRT
​https://bugs.webkit.org/show_bug.cgi?id=34959

This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (initWebKitTestFonts): (launcherMain): (LauncherApplication::handleUserOptions):
5:14 PM Changeset in webkit [80976] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed one case of DeprecatedPtr (ScopeChainIterator)
​https://bugs.webkit.org/show_bug.cgi?id=56277

  • runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator, since it's a stack-allocated temporary.
5:10 PM Changeset in webkit [80975] by psolanki@apple.com
  • 15 edits in trunk

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:41 PM Changeset in webkit [80974] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [80973] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [80972] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

  • marked these methods const.

(JSC::AbstractMacroAssembler::Jump::isSet):

  • add a method to check whether a Jump object has been set to reference an instruction, or is in a null, unset state.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • add non-explicit constructor, for FunctionPtr's to C/C++ functions.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):

  • add three operand forms of these instructions.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::JmpSrc::isSet):

  • add a method to check whether a JmpSrc object has been set to reference an instruction, or is in a null, unset state.

(JSC::X86Assembler::movsd_rr):

  • added FP register-register move.

(JSC::X86Assembler::linkJump):

  • Add an assert to check jumps aren't linked more than once.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadInt32ToDouble):

  • load integers to the FPU via regsiters on x86-64.
3:05 PM Changeset in webkit [80971] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [80970] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load32):

2:16 PM Changeset in webkit [80969] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

  • bytecode/SamplingTool.h:
  • interpreter/Register.h:
  • interpreter/RegisterFile.h:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:
  • wtf/RefCounted.h:
    • Change these classes to no longer friend the JIT, add accessors for member offsets.
  • jit/JIT.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
    • Change the JIT to use class accessors, rather than taking object ofsets directly.
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
    • Since the accessors for objects members return const pointers to retain encapsulation, methods generating code with absolute addresses must be able to handle const pointers (the JIT doesn't write to these values, do dies treat the pointer to value as const from within the C++ code of the JIT, if not at runtime!).
1:30 PM Changeset in webkit [80968] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

WebPageProxy cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from

here to WebPageProxyMac.mm.

  • UIProcess/WebPageProxy.h: Cleaned up #includes.
  • UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations

here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

1:28 PM Changeset in webkit [80967] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
​https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

1:24 PM Changeset in webkit [80966] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash when dragging.

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap): Retain the saved context.

12:46 PM Changeset in webkit [80965] by jeremy@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Update comment in CSSValueKeywords.in
​https://bugs.webkit.org/show_bug.cgi?id=56266

The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

No tests - just updating a comment.

  • css/CSSValueKeywords.in:
12:07 PM Changeset in webkit [80964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Anton D'Auria <​adauria@apple.com>

Reviewed by Alice Liu.

StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
​https://bugs.webkit.org/show_bug.cgi?id=56259

Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker):
11:47 AM Changeset in webkit [80963] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-13 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
​https://bugs.webkit.org/show_bug.cgi?id=53470

Prefer !important over normal properties when dealing with duplicate properties in style rules.

Test: fast/css/duplicate-property-in-rule-important.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
11:42 AM Changeset in webkit [80962] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [80961] by levin@chromium.org
  • 5 edits
    11 adds in trunk/LayoutTests

Update test expections due to the OSX specific ex size change done in r80755.

  • platform/chromium-mac/fast/lists/008-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
10:04 AM Changeset in webkit [80960] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test expectations due to bad update:

r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [80959] by levin@chromium.org
  • 2 edits
    21 adds in trunk/LayoutTests

Added the following expectations:

fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.