⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 16, 2011:

11:51 PM Changeset in webkit [81331] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Adding plugins/destroy-on-setwindow.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56165 was filed to track this issue.

Reviewed by Adam Roben.

  • platform/mac-leopard/Skipped:
11:39 PM Changeset in webkit [81330] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

The function setDraggingImageURL() is no longer called and can be deleted.

No new tests. Deleting dead code.

  • page/DragController.h:

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

Page is always nil at this point, because [self _webView] is nil,
so the conditional code is never run.

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
11:34 PM Changeset in webkit [81329] by weinig@apple.com
  • 1 edit
    16 adds in trunk/LayoutTests

Adding new results for some failing tests on the SnowLeopard WebKit2 Tester.

Reviewed by Adam Roben; Dictated, but not read, by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56528
​https://bugs.webkit.org/show_bug.cgi?id=56530
​https://bugs.webkit.org/show_bug.cgi?id=56531
​https://bugs.webkit.org/show_bug.cgi?id=56532
​https://bugs.webkit.org/show_bug.cgi?id=56533
​https://bugs.webkit.org/show_bug.cgi?id=56537
​https://bugs.webkit.org/show_bug.cgi?id=56539

  • platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Added.
  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • platform/mac-wk2/http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • platform/mac-wk2/media/controls-without-preload-expected.txt: Added.
  • platform/mac-wk2/transitions/default-timing-function-expected.txt: Added.
11:31 PM Changeset in webkit [81328] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

  • fast/forms/script-tests/textarea-maxlength.js: (createFocusedTextAreaWithMaxLength3): Added two tests to make sure consecutive insertbreaks work correctly for textarea maxlength.
  • fast/forms/textarea-maxlength-expected.txt: Added two test results.

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

When a user presses a return key, TypingCommand::insertLineBreak() is called.
So before append a new line, check if we can add the new line.

  • editing/TypingCommand.cpp: (WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line. (WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line. (WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.
11:14 PM Changeset in webkit [81327] by weinig@apple.com
  • 2 edits in trunk/Tools

2011-03-16 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56541

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Check for an empty host in addition to a null host. This bug was introduced when porting off of the KURL code and onto the WKURLRef version.
11:12 PM Changeset in webkit [81326] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build more derived sources
​https://bugs.webkit.org/show_bug.cgi?id=56529

This patch brings us down to 597 link errors.

  • gyp/WebCore.gyp:
11:09 PM Changeset in webkit [81325] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP should build (most) remaining source files
​https://bugs.webkit.org/show_bug.cgi?id=56515

We're still not building all the files and we have 1305 link errors,
but this patch is progress.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • plugins/PluginStream.cpp:
10:38 PM Changeset in webkit [81324] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/workers/storage/interrupt-database-sync.html to the win-xp skipped list
due to intermittent failure; tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56534

  • platform/win-xp/Skipped:
10:37 PM Changeset in webkit [81323] by weinig@apple.com
  • 2 edits in trunk/Tools

Add Lucas Forschler to the list of WebKit committers.

Reviewed by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
10:22 PM Changeset in webkit [81322] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Add compositing/transitions/singular-scale-transition.html to the Skipped lists.
Seems to be the same assert that ​https://bugs.webkit.org/show_bug.cgi?id=56488 was
filed for.

  • platform/mac/Skipped:
  • platform/win/Skipped:
10:13 PM Changeset in webkit [81321] by weinig@apple.com
  • 2 edits in trunk/Tools

Reviewed upon and dictated through Adam Roben.

Escape crashing function names in results.html. This fixes an issue
when a crash involves a type with templates.

  • Scripts/old-run-webkit-tests:
9:46 PM Changeset in webkit [81320] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the interpreter build.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::privateExecute):
Remove .get()s.

9:36 PM Changeset in webkit [81319] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Update the default navigator.vendor value
​https://bugs.webkit.org/show_bug.cgi?id=56449

Reviewed by Alexey Proskuryakov.

  • page/NavigatorBase.cpp: Updated the default value of

WEBCORE_NAVIGATOR_VENDOR.

9:27 PM Changeset in webkit [81318] by Joseph Pecoraro
  • 3 edits
    1 delete in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch to update GTK expected results.
It looks like the GTK platform specific results for
some viewport tests match regular results, and there
were a few viewport tests that still needed expected
results since other platforms skip them.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-58-expected.txt:
  • fast/viewport/viewport-6-expected.txt:
  • platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-92-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-93-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-94-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-95-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-96-expected.txt: Removed.
8:56 PM Changeset in webkit [81317] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

  • platform/chromium/test_expectations.txt: premultiply-alpha test now works

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

Always update the canvas contents in copiedImage, as there's no reason
to ask for an out-of-date image.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage):
8:46 PM Changeset in webkit [81316] by abarth@webkit.org
  • 7 edits in trunk/Source

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

We added this recently when we were unsure about the stability of the
built-in UTF-8 codec. However, the codec seems to be stable, so we
don't need the macro.

  • wtf/Platform.h:

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • features.gypi:
8:46 PM Changeset in webkit [81315] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Check in new results for text-combine-image-test-expected.txt.

  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
8:07 PM Changeset in webkit [81314] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix changelog.

8:04 PM Changeset in webkit [81313] by weinig@apple.com
  • 3 edits
    8 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Release Tester.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56516
​https://bugs.webkit.org/show_bug.cgi?id=56517
​https://bugs.webkit.org/show_bug.cgi?id=56518
​https://bugs.webkit.org/show_bug.cgi?id=56519
​https://bugs.webkit.org/show_bug.cgi?id=56521
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56525

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt: Added.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
  • platform/mac-leopard/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/mac-leopard/fast/text/text-combine-image-test-expected.txt: Added.
  • platform/mac-leopard/media/controls-without-preload-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility: Added.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Added.
7:48 PM Changeset in webkit [81312] by Joseph Pecoraro
  • 122 edits in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch landing updated expected results,
which now include the userScalable value in output.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-1-expected.txt:
  • fast/viewport/viewport-10-expected.txt:
  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-104-expected.txt:
  • fast/viewport/viewport-105-expected.txt:
  • fast/viewport/viewport-106-expected.txt:
  • fast/viewport/viewport-107-expected.txt:
  • fast/viewport/viewport-108-expected.txt:
  • fast/viewport/viewport-109-expected.txt:
  • fast/viewport/viewport-11-expected.txt:
  • fast/viewport/viewport-110-expected.txt:
  • fast/viewport/viewport-111-expected.txt:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-113-expected.txt:
  • fast/viewport/viewport-114-expected.txt:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-118-expected.txt:
  • fast/viewport/viewport-119-expected.txt:
  • fast/viewport/viewport-12-expected.txt:
  • fast/viewport/viewport-120-expected.txt:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-123-expected.txt:
  • fast/viewport/viewport-124-expected.txt:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-13-expected.txt:
  • fast/viewport/viewport-14-expected.txt:
  • fast/viewport/viewport-15-expected.txt:
  • fast/viewport/viewport-16-expected.txt:
  • fast/viewport/viewport-17-expected.txt:
  • fast/viewport/viewport-18-expected.txt:
  • fast/viewport/viewport-19-expected.txt:
  • fast/viewport/viewport-2-expected.txt:
  • fast/viewport/viewport-20-expected.txt:
  • fast/viewport/viewport-21-expected.txt:
  • fast/viewport/viewport-22-expected.txt:
  • fast/viewport/viewport-23-expected.txt:
  • fast/viewport/viewport-24-expected.txt:
  • fast/viewport/viewport-25-expected.txt:
  • fast/viewport/viewport-26-expected.txt:
  • fast/viewport/viewport-27-expected.txt:
  • fast/viewport/viewport-28-expected.txt:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-3-expected.txt:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-33-expected.txt:
  • fast/viewport/viewport-34-expected.txt:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-37-expected.txt:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-4-expected.txt:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-5-expected.txt:
  • fast/viewport/viewport-50-expected.txt:
  • fast/viewport/viewport-51-expected.txt:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-56-expected.txt:
  • fast/viewport/viewport-57-expected.txt:
  • fast/viewport/viewport-59-expected.txt:
  • fast/viewport/viewport-60-expected.txt:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-7-expected.txt:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-8-expected.txt:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • fast/viewport/viewport-88-expected.txt:
  • fast/viewport/viewport-9-expected.txt:
  • fast/viewport/viewport-90-expected.txt:
  • fast/viewport/viewport-91-expected.txt:
  • fast/viewport/viewport-92-expected.txt:
  • fast/viewport/viewport-93-expected.txt:
  • fast/viewport/viewport-94-expected.txt:
  • fast/viewport/viewport-95-expected.txt:
  • fast/viewport/viewport-96-expected.txt:
  • fast/viewport/viewport-warnings-1-expected.txt:
  • fast/viewport/viewport-warnings-2-expected.txt:
  • fast/viewport/viewport-warnings-3-expected.txt:
  • fast/viewport/viewport-warnings-4-expected.txt:
  • fast/viewport/viewport-warnings-5-expected.txt:
  • fast/viewport/viewport-warnings-6-expected.txt:
7:11 PM Changeset in webkit [81311] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Make JIT build for ARM Thumb-2 with RVCT
​https://bugs.webkit.org/show_bug.cgi?id=56440

Derived from a patch by Dave Tapuska.

Also, modify the RVCT stub template to indicate that it preserves 8 byte stack alignment.

  • jit/JITStubs.cpp:
7:10 PM Changeset in webkit [81310] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] include inspector gif files in the list of resources
​https://bugs.webkit.org/show_bug.cgi?id=56504

  • scripts/generate_devtools_grd.py:
6:53 PM Changeset in webkit [81309] by Joseph Pecoraro
  • 13 edits in trunk/Source

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

This restores our behavior before r67376 the default "user-scalable"
behavior can be defined by a WebKit client if a value was not
explicitly provided in web content (via the viewport <meta> tag).
Here, all WebKit ports default to "yes" after computing
viewport arguments. However, in the future they may consider
changing the default user-scalable value based on the type
of the document being viewed, a user preference, or other reasons.

Covered by existing tests. Should be no changes.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes): be explicit about 0. (WebCore::findUserScalableValue): convert to return a float, the instance variable type.
  • dom/ViewportArguments.h: (WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the WebKit client.

Source/WebKit/efl:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • ewk/ewk_view.cpp: (ewk_view_viewport_attributes_get):

Source/WebKit/gtk:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
  • webkit/webkitviewportattributes.cpp: (webkitViewportAttributesRecompute):

Source/WebKit/qt:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.

Source/WebKit2:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
6:53 PM Changeset in webkit [81308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Chao-ying Fu <​fu@mips.com>

Reviewed by Darin Adler.

Fix MIPS build with const *void
​https://bugs.webkit.org/show_bug.cgi?id=56513

  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::store32):
6:46 PM Changeset in webkit [81307] by levin@chromium.org
  • 7 edits in trunk/LayoutTests

New baselines because the play button is now a pause button due to r81300.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-win-xp/media/controls-after-reload-expected.checksum:
  • platform/chromium-win-xp/media/controls-after-reload-expected.png:
6:05 PM Changeset in webkit [81306] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-16 Adam Barth <​abarth@webkit.org>

Update the Skipped lists to reflect the new location of these tests.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:57 PM Changeset in webkit [81305] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".

Reviewed by Dmitry Titov.

Conditional jump or move depends on uninitialised value(s)

WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)

  • page/Settings.cpp:

(WebCore::Settings::Settings):

5:49 PM Changeset in webkit [81304] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
regions does not work

Reviewed by Darin Adler.

Up until now, overlay scrollbars have always been treated in the Render Tree as if
they have a thickness of 0 because they should not affect layout. However, it is
important to consider their size when hit-testing because otherwise, we have this
bug! This patch adds a boolean parameter to overflowClipRect(),
RenderLayer::verticalScrollbarWidth(), and
RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
the actual overlay scrollbar thickness. It defaults to false and is only sent is
as true from RenderBloc::nodeAtPoint().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overflowClipRect):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderLayer.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:
5:45 PM Changeset in webkit [81303] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. Exposes no new functionality.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::isDocumentThreadableLoaderClient): (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81302] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix std::swap not found issue on mobile Qt devices.
​https://bugs.webkit.org/show_bug.cgi?id=56463

Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
on some Qt mobile devices.

No new tests: No tests needed - compilation verified manually.

  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::acquireLineBreakIterator):
5:26 PM Changeset in webkit [81301] by levin@chromium.org
  • 11 edits in trunk/LayoutTests

Update test expectations due to r81280 (media/controls-without-preload.html),
and r81285 (media-document-audio-repaint-expected).

  • platform/chromium-linux/media/controls-without-preload-expected.checksum:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
5:24 PM Changeset in webkit [81300] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Improve robustness of controls-after-reload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56491

  • media/controls-after-reload.html: Added an extra step to seek to 0 before the end of the test.
5:21 PM Changeset in webkit [81299] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Update the Skipped list.

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
5:16 PM Changeset in webkit [81298] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebGL content not shown when accelerated compositing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=56339

Removed all previously implemented WebGL code from GraphicsLayerQt
because API has changed. GraphicsContext3D provides PlatformLayer
that is added as a child of GraphicsLayer and is therefore painted
through QGraphicsView pipeline.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3DInternal::boundingRect): (WebCore::GraphicsContext3D::platformLayer): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::reshape):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToCanvas):
  • platform/graphics/qt/GraphicsLayerQt.h:
5:15 PM Changeset in webkit [81297] by abarth@webkit.org
  • 1 edit
    2 copies
    3 moves
    3 adds in trunk/LayoutTests

2011-03-16 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

LayoutTests exercising filesystem: URIs should run over HTTP to avoid weirdness related to file: URLs
​https://bugs.webkit.org/show_bug.cgi?id=56328

Moves the test for resolveLocalFileSystemURI into new "filesystem"
directory under http/tests/, and adjusts file paths appropriately.

  • fast/filesystem/resolve-uri-expected.txt: Removed.
  • fast/filesystem/resolve-uri.html: Removed.
  • fast/filesystem/script-tests/resolve-uri.js: Removed.
  • http/tests/filesystem: Added.
  • http/tests/filesystem/resolve-uri-expected.txt: Copied from LayoutTests/fast/filesystem/resolve-uri-expected.txt.
  • http/tests/filesystem/resolve-uri.html: Copied from LayoutTests/fast/filesystem/resolve-uri.html.
  • http/tests/filesystem/resources: Added.
  • http/tests/filesystem/resources/fs-test-util.js: Copied from LayoutTests/fast/filesystem/resources/fs-test-util.js.
  • http/tests/filesystem/script-tests: Added.
  • http/tests/filesystem/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/filesystem/script-tests/TEMPLATE.html.
  • http/tests/filesystem/script-tests/resolve-uri.js: Copied from LayoutTests/fast/filesystem/script-tests/resolve-uri.js.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Added new http/tests/filesystem directory to skip lists since they don't suppor the filesystem API.
5:12 PM Changeset in webkit [81296] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

NPObjectProxy and NPObjectMessageReceiver objects should know their Plugin object
​https://bugs.webkit.org/show_bug.cgi?id=56506

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::windowScriptNPObject): (WebKit::PluginControllerProxy::pluginElementNPObject): (WebKit::PluginControllerProxy::evaluate): (WebKit::PluginControllerProxy::getPluginScriptableNPObject):
  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::create): (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::invoke): (WebKit::NPObjectMessageReceiver::invokeDefault): (WebKit::NPObjectMessageReceiver::getProperty): (WebKit::NPObjectMessageReceiver::setProperty): (WebKit::NPObjectMessageReceiver::construct):
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPObjectProxy.cpp: (WebKit::NPObjectProxy::create): (WebKit::NPObjectProxy::NPObjectProxy): (WebKit::NPObjectProxy::invalidate): (WebKit::NPObjectProxy::initialize): (WebKit::NPObjectProxy::invoke): (WebKit::NPObjectProxy::invokeDefault): (WebKit::NPObjectProxy::getProperty): (WebKit::NPObjectProxy::setProperty): (WebKit::NPObjectProxy::construct):
  • Shared/Plugins/NPObjectProxy.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::createNPObjectProxy): (WebKit::NPRemoteObjectMap::registerNPObject): (WebKit::NPRemoteObjectMap::npVariantToNPVariantData): (WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
  • Shared/Plugins/NPRemoteObjectMap.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::pluginScriptableNPObject): (WebKit::PluginProxy::getWindowScriptNPObject): (WebKit::PluginProxy::getPluginElementNPObject): (WebKit::PluginProxy::evaluate):
5:03 PM Changeset in webkit [81295] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Removed nearestMailBlockquote and replaced the calls to the function by calls
to enclosingNodeOfType and highestEnclosingNodeOfType.


Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
respect editing boundaries. Added a test for the former command.

Test: editing/execCommand/break-non-editable-blockquote.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary when looking for a Mail blockquote.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::hasMatchingQuoteLevel): (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Check rule upfront to improve the performance. (WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Added a null pointer check. (WebCore::lastPositionInOrAfterNode): Ditto.
  • editing/markup.cpp: (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Added a test to ensure WebKi doesn't crash when inserting newline in quoted contents,
which is enclosed by a non-editable blockquote.

  • editing/execCommand/break-non-editable-blockquote-expected.txt: Added.
  • editing/execCommand/break-non-editable-blockquote.html: Added.
5:02 PM Changeset in webkit [81294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Adam Barth <​abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
4:56 PM Changeset in webkit [81293] by jamesr@google.com
  • 4 edits
    4 copies in branches/chromium/696

Merge 80867 - 2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding a test for rotated large layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

  • platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/huge-layer-rotated.html: Added.

2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

Test: platform/chromium/compositing/huge-layer-rotated.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:

TBR=​vangelis@chromium.org
BUG=64947

4:51 PM Changeset in webkit [81292] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=54987 Crash beneath
WebPageProxy::viewWillStartLiveResize when resizing window after web process
crashed
-and corresponding-
<rdar://problem/9037685>

Reviewed by Darin Adler.

Just need simple isValid() checks here.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

4:48 PM Changeset in webkit [81291] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-16 Jer Noble <​jer.noble@apple.com>

Reviewed by Beth Dakin.

RenderFullScreen::createFullScreenStyle() leaks
​https://bugs.webkit.org/show_bug.cgi?id=53384

Two problems: a) not calling release() on the style returned in setFullScreenRenderer
causes an unnecessary ref/deref, and b) the fullscreen renderer needs to be destroyed,
not just detached, when it is no longer needed.

  • dom/Document.cpp: (WebCore::Document::setFullScreenRenderer): Destroy the current renderer when a new one is set.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::createFullScreenStyle): release() the return value.
4:46 PM Changeset in webkit [81290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

Reestablish typeface/size/encoding when drawing stroked text
​https://bugs.webkit.org/show_bug.cgi?id=56481

No new tests. LayoutTests/svg/css/composite-shadow-text.svg

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
4:37 PM Changeset in webkit [81289] by commit-queue@webkit.org
  • 14 edits in trunk

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

No new tests needed as this defaults to disabled (and is unfeasible
to be tested through property overriding at runtime).

  • page/Settings.h: (WebCore::Settings::setForceCompositingMode): (WebCore::Settings::forceCompositingMode):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  • rendering/RenderLayerCompositor.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setForceCompositingMode):
  • src/WebSettingsImpl.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setForceCompositingMode):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
4:06 PM Changeset in webkit [81288] by vangelis@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new test for transformed layer with backface
visibility set to hidden.
​https://bugs.webkit.org/show_bug.cgi?id=56237

  • platform/chromium/compositing/backface-visibility-transformed-expected.checksum: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.txt: Added.
  • platform/chromium/compositing/backface-visibility-transformed.html: Added.

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing backface visibility for transformed layers.
​https://bugs.webkit.org/show_bug.cgi?id=56237

Test: platform/chromium/compositing/backface-visibility-transformed.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
4:01 PM Changeset in webkit [81287] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-03-16 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Kevin Decker.

Add a user default that will force all plugins to opt in to non-executable data
​https://bugs.webkit.org/show_bug.cgi?id=56487
<rdar://problem/9109095>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy):
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
3:57 PM Changeset in webkit [81286] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/js/array-sort-modifying-tostring.html on Windows because it is timing out
on Windows Debug. It is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56496.

  • platform/win/Skipped:
3:20 PM Changeset in webkit [81285] by Dimitri Glazkov
  • 3 edits
    4 adds in trunk

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics

  • fast/repaint/slider-thumb-float-expected.checksum: Added.
  • fast/repaint/slider-thumb-float-expected.png: Added.
  • fast/repaint/slider-thumb-float-expected.txt: Added.
  • fast/repaint/slider-thumb-float.html: Added.

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Technically, this is not a regression, but rather uncovering of an old
problem. When the RenderSlider::layout was written, the layout state was
pushed with a wrong offset. However, since the whole slider track was
always repainted, the problem didn't manifest itself until we actually
started being more precise in our repaints.

Test: fast/repaint/slider-thumb-float.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Changed to pass actual thumb offset to the LayoutStateMaintainer, rather than thumb size.
3:18 PM Changeset in webkit [81284] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56488
transitions/scale-transition-no-start.html is crashing.

Adding to the Skipped list.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
3:15 PM Changeset in webkit [81283] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Add play state callbacks to MediaControls, kill timeUpdate timer.
​https://bugs.webkit.org/show_bug.cgi?id=56473

No change in behavior, covered by existing tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playbackProgressTimerFired): Added a call to

media controls.

(WebCore::HTMLMediaElement::updatePlayState): Ditto.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::MediaControls): Removed initialization of the timer. (WebCore::MediaControls::playbackProgressed): Added. (WebCore::MediaControls::playbackStarted): Added, for now routing to just

call playbackProgressed.

(WebCore::MediaControls::playbackStopped): Ditto.
(WebCore::MediaControls::update): Removed the code to start/stop the

timer that's now gone.

  • html/shadow/MediaControls.h: Removed timer decls.
3:06 PM Changeset in webkit [81282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

DocumentThreadableLoaderClient needs a protected default Constructor
​https://bugs.webkit.org/show_bug.cgi?id=56479

No new tests. Exposes no new functionality.

  • loader/DocumentThreadableLoaderClient.h: (WebCore::DocumentThreadableLoaderClient::DocumentThreadableLoaderClient):
2:59 PM Changeset in webkit [81281] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt #2.

Same error as before.

  • bindings/v8/V8GCController.cpp:
2:47 PM Changeset in webkit [81280] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56489

  • media/controls-without-preload.html: Added an extra step to seek to 0 before the end of the test.
2:22 PM Changeset in webkit [81279] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Dimitri Glazkov.

Revert of r80451. Decided to do this in WebCore instead.
​https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
2:16 PM Changeset in webkit [81278] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt.

The error was 'WebCore::GrouperVisitor' has a field 'WebCore::GrouperVisitor::m_grouper' whose type uses the anonymous namespace.

  • bindings/v8/V8GCController.cpp:
2:08 PM Changeset in webkit [81277] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov and Darin Adler.

Node::isContentEditable should always call parentNode() instead of parentOrHostNode()
​https://bugs.webkit.org/show_bug.cgi?id=56472

Replaced the call to parentOrHostNode() in Node::isContentEditable by a call to parentNode().
Node::isContentEditable now calls parentNode() on all nodes.

No tests are added since this behavior change is not visible to scripts at the moment.

  • dom/Node.cpp: (WebCore::Node::isContentEditable):
2:05 PM Changeset in webkit [81276] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Remove unnecessary caller tracking shenanigans from CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=56483

This removes some leftover cruft from when we made CodeBlock
mark its callees. Removing it gives us a 0.7% progression,
reducing the overall regression to ~1.3%.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
  • jit/JIT.cpp: (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
2:04 PM Changeset in webkit [81275] by levin@chromium.org
  • 2 edits
    76 adds in trunk/LayoutTests

o Cleaned up test_expectation to remove items due to new baselines

and remove some crashes that have been fixed.

o text-combine: Added baseline following r81251.
o Everything else: Add some not so timely baselines for r77485.

  • platform/chromium-linux/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.checksum: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [81274] by Chris Fleizach
  • 14 edits in trunk/Source

WK2: Need to propagate enhanced accessibility flag from UI -> web process
​https://bugs.webkit.org/show_bug.cgi?id=56379

Reviewed by Darin Adler.

Source/WebCore:

Allow the enhanced accessibility flag to be toggleable.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Source/WebKit2:

Support sending the enhanced accessibility flag between processes.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::setEnhancedAccessibility):

  • UIProcess/WebContext.h:
  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContet::platformInvalidateContext):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setEnhancedAccessibility):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:12 PM Changeset in webkit [81273] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Buildfix after r81230.

  • WebCore.pri: Missing include path added.
1:09 PM Changeset in webkit [81272] by oliver@apple.com
  • 100 edits in trunk/Source

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make Structure::create require JSGlobalData&, and
require all users to provide the globalData.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::createStructure):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/ErrorInstance.h: (JSC::ErrorInstance::createStructure):
  • runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
  • runtime/JSByteArray.h: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::createDummyStructure):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::createStructure):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.cpp: (JSC::JSObject::createInheritorID):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSNonFinalObject::createStructure): (JSC::JSFinalObject::createStructure): (JSC::createEmptyObjectStructure): (JSC::JSObject::inheritorID):
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::createStructure):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::RopeBuilder::createStructure):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure):
  • runtime/JSZombie.h: (JSC::JSZombie::createStructure):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::createStructure):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::createStructure):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.h: (JSC::StringPrototype::createStructure):
  • runtime/Structure.h: (JSC::Structure::create):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation pass a JSGlobalData&.

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): (JSRun::JSRun):
  • JSRun.h:
  • JSUtils.cpp: (getThreadGlobalObject):
  • UserObjectImp.h: (UserObjectImp::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation use GlobalData

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h: (WebCore::JSAudioConstructor::createStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure): (WebCore::getDOMStructure):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::createStructure):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::createStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::createStructure):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h: (WebCore::JSOptionConstructor::createStructure):
  • bindings/js/JSWorkerContextBase.h: (WebCore::JSWorkerContextBase::createStructure):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.h: (JSC::Bindings::CRuntimeObject::createStructure):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaRuntimeObject.h: (JSC::Bindings::JavaRuntimeObject::createStructure):
  • bridge/objc/ObjCRuntimeObject.h: (JSC::Bindings::ObjCRuntimeObject::createStructure):
  • bridge/objc/objc_instance.mm: (ObjCRuntimeMethod::createStructure):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.h: (JSC::Bindings::RuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure):
  • Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: (WebKit::JSNPMethod::JSNPMethod):
  • WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::createStructure):
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::JSNPObject):
  • WebProcess/Plugins/Netscape/JSNPObject.h: (WebKit::JSNPObject::createStructure):
12:54 PM Changeset in webkit [81271] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/refcount-leaks.html on Windows, because it is failing in release builds,
and passing in debug. This is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56478.

  • platform/win/Skipped:
12:52 PM Changeset in webkit [81270] by rniwa@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Build fix for r81266. "expected" should appear after "mac", "unix", and "win" not before them.

  • editing/style/iframe-onload-crash-expected-mac.txt: Removed.
  • editing/style/iframe-onload-crash-expected-unix.txt: Removed.
  • editing/style/iframe-onload-crash-expected-win.txt: Removed.
  • editing/style/iframe-onload-crash-mac-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-mac.txt.
  • editing/style/iframe-onload-crash-unix-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-unix.txt.
  • editing/style/iframe-onload-crash-win-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-win.txt.
12:49 PM Changeset in webkit [81269] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
​https://bugs.webkit.org/show_bug.cgi?id=56477
<rdar://problem/8806664>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Set NSApplication current event when re-dispatching a key event that returned from the web process unhandled. That way, code that looks at current event modifiers won't be confused.
12:47 PM Changeset in webkit [81268] by psolanki@apple.com
  • 2 edits in trunk/LayoutTests

Fix typo in path name. The test was just checking for onProgress was called for the content
and the error page served by Apache in this case sufficed for it to pass.

Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:
12:28 PM Changeset in webkit [81267] by psolanki@apple.com
  • 4 edits
    3 adds in trunk

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add test that verifies the we don't crash when an XHR response headers don't contain
Content-Type.

  • http/tests/xmlhttprequest/resources/.htaccess:
  • http/tests/xmlhttprequest/resources/noContentType.asis: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html: Added.

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add NULL check for Content-Type header field.

Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html

  • platform/network/mac/WebCoreURLResponse.mm: (WebCore::adjustMIMETypeIfNecessary):
12:18 PM Changeset in webkit [81266] by leviw@chromium.org
  • 7 edits
    4 copies
    2 moves in trunk

2011-03-16 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Creating three versions of the iframe-onload-crash test to cover all editing behaviors.

  • editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected.txt: Removed.
  • editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2011-03-15 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
have had children appended to them that editing wouldn't normally allow.

Tests: editing/style/iframe-onload-crash-mac.html

editing/style/iframe-onload-crash-unix.html
editing/style/iframe-onload-crash-win.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children for hr and datagrid, as you can append any node to another using javascript.
11:46 AM Changeset in webkit [81265] by mnaganov@chromium.org
  • 15 edits
    3 copies in trunk/Source/WebCore

2011-03-16 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Report object groups and single DOM-related objects
to the new heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=53659

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/RetainedDOMInfo.cpp: Added. (WebCore::RetainedDOMInfo::RetainedDOMInfo):
  • bindings/v8/RetainedDOMInfo.h: Added.
  • bindings/v8/RetainedObjectInfo.h: Added.
  • bindings/v8/ScriptProfiler.cpp: (WebCore::retainedDOMInfo): (WebCore::ScriptProfiler::initialize):
  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8GCController.cpp: (WebCore::GroupId::GrouperItem::GrouperItem): (WebCore::GroupId::GrouperItem::groupId): (WebCore::GroupId::GrouperItem::createRetainedObjectInfo): (WebCore::calculateGroupId): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping):
  • bindings/v8/WrapperTypeInfo.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot): (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
  • inspector/front-end/heapProfiler.css: (.detailed-heapshot-view .retaining-paths-view .title > span): (.detailed-heapshot-view .retaining-paths-to-windows):
11:43 AM Changeset in webkit [81264] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Skip test fast/forms/input-autofilled.html in mac-wk2 since
layoutTestController.setAutofilled is not yet supported.

  • platform/mac-wk2/Skipped:
11:37 AM Changeset in webkit [81263] by weinig@apple.com
  • 12 edits in trunk/Source

Add WebKit2 API to figure out if an input or textarea was edited
​https://bugs.webkit.org/show_bug.cgi?id=56474

Reviewed by Adam Roben.

Source/WebCore:

Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
as well as API in WebKit2.

  • WebCore.exp.in:
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::lastChangeWasUserEdit):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):

  • html/HTMLTextAreaElement.h:

Source/WebKit2:

Expose WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit and
WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit. Next time,
I will work on giving these functions longer names.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit):
(WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
11:35 AM Changeset in webkit [81262] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Some conservative root gathering cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56447


SunSpider says 0.5% - 1.8% faster.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots):
  • interpreter/RegisterFile.h: New helper function for doing the conservative gathering of the register file. It's still conservative, since the register file may contain uninitialized values, but it's moving-safe, because it only visits values tagged as pointers, so there's no risk of mistaking an integer for a pointer and accidentally changing it.
  • runtime/ConservativeSet.cpp: (JSC::ConservativeRoots::add):
  • runtime/ConservativeSet.h: Added a single-value add function, used above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Separated machine stack conservative roots from register file conservative roots because machine stack roots must be pinned, but register file roots need not be pinned.


Adopted new interface for passing the current stack extent to the machine
stack root gathering routine. This allows us to exclude marking-related
data structures on the stack, and thus avoid double-marking the set of
machine roots.

  • runtime/MachineStackMarker.cpp: (JSC::MachineThreads::gatherFromCurrentThread): (JSC::MachineThreads::gatherConservativeRoots):
  • runtime/MachineStackMarker.h: Added new interface, described above.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::firstAtom):
  • wtf/StdLibExtras.h: (WTF::roundUpToMultipleOf): Moved roundUpToMultipleOf so it could be used by MachineStacks.
11:16 AM Changeset in webkit [81261] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little bit of MarkStack cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56443


Moved MarkStack functions into MarkStack.h/.cpp.


SunSpider reports no change.

  • runtime/JSArray.h:
  • runtime/JSCell.h: Moved from here...
  • runtime/MarkStack.cpp: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain): ...to here. Also, no need to inline drain. It's a huge function, and not called many times.
  • runtime/MarkStack.h: (JSC::MarkStack::~MarkStack): Moved near constructor, per style guide. (JSC::MarkStack::append): (JSC::MarkStack::deprecatedAppend): (JSC::MarkStack::internalAppend): Moved to here.
11:07 AM Changeset in webkit [81260] by bweinstein@apple.com
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

More cleanup of expected results files for text combine tests from r81255.

  • platform/win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/win/fast/dynamic/text-combine-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:


  • platform/win/fast/international: Removed. This was the wrong directory.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Removed. This was the wrong directory.
11:01 AM Changeset in webkit [81259] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
​https://bugs.webkit.org/show_bug.cgi?id=56376

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
10:58 AM Changeset in webkit [81258] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix live-edit test broken by r81238.

  • inspector/debugger/live-edit.html:
10:58 AM Changeset in webkit [81257] by xji@chromium.org
  • 6 edits in branches/chromium/696/Source/WebCore

Merge 80757 - Regression: Content not drawn when scrolling horizontally in an RTL page
​https://bugs.webkit.org/show_bug.cgi?id=55077

Reviewed by David Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.

  • platform/ScrollView.h:
  • rendering/RenderLayer.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.

TBR=​weinig@apple.com

10:47 AM Changeset in webkit [81256] by bweinstein@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Make the files added -expected.txt instead of -actual.txt so run-webkit-tests
will actually find them.

  • platform/win/fast/dynamic/text-combine-actual.txt: Removed.
  • platform/win/fast/dynamic/text-combine-expected.txt: Copied from platform/win/fast/dynamic/text-combine-actual.txt.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Removed.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Copied from platform/win/fast/international/text-combine-image-test-actual.txt.
10:44 AM Changeset in webkit [81255] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for text combine tests.

  • platform/win/fast/dynamic/text-combine-actual.txt: Added.
  • platform/win/fast/international: Added.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Added.
10:22 AM Changeset in webkit [81254] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list because of missing test fonts.

  • platform/qt/Skipped:
9:52 AM Changeset in webkit [81253] by Csaba Osztrogonác
  • 2 edits
    27 adds in trunk/LayoutTests

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Add Qt specific expected files after r81168.

  • platform/qt/Skipped: Add new tests because of missing test fonts.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
9:38 AM Changeset in webkit [81252] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56467
IconDatabase-related crash seen in WK2 tests

Reviewed by Adam Roben.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL): The IconLoader might set a null data for an icon, so handle that case.

9:27 AM Changeset in webkit [81251] by mitz@apple.com
  • 5 edits
    4 adds in trunk

text-combine text retains compressed font after adding characters to it
​https://bugs.webkit.org/show_bug.cgi?id=56448

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/text-combine.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
only the clones on the RenderCombineText will be mutated.

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
style.
(WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
the text cannot be combined.

  • rendering/RenderCombineText.h:

(WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.

LayoutTests:

  • fast/dynamic/text-combine.html: Added.
  • platform/mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/mac/fast/dynamic/text-combine-expected.txt: Added.
9:25 AM Changeset in webkit [81250] by Adam Roben
  • 3 edits
    1 move in trunk/LayoutTests

Disable jquery/effects.html

It often times out due to its sheer size. The failure is tracked by
<​http://webkit.org/b/56080>.

  • jquery/effects.html-disabled: Renamed from LayoutTests/jquery/effects.html.
  • platform/gtk/Skipped:
  • platform/win-xp/Skipped:

Unskipped the test since we're now disabling it via other means.

9:06 AM Changeset in webkit [81249] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping one more svg test failing on 32-bits release,
likely due to bug 39022.

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [81248] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/text/soft-hyphen-4.html introduced in r80984
and fails because hyphenation isn't implemented yet.

  • platform/qt/Skipped: Add fast/text/soft-hyphen-4.html.
8:47 AM Changeset in webkit [81247] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip svg/W3C-I18N tests failing on 32-bits Debug only.

  • platform/gtk/Skipped:
8:41 AM Changeset in webkit [81246] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip editing/style/iframe-onload-crash.html on GTK.

  • platform/gtk/Skipped:
8:34 AM Changeset in webkit [81245] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Update Qt specific expected file after r81049.

  • platform/qt/fast/table/overflowHidden-expected.txt: Updated.
8:24 AM Changeset in webkit [81244] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix test broken by r81238.

  • inspector/debugger/live-edit.html:
  • platform/chromium/test_expectations.txt:
8:03 AM Changeset in webkit [81243] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:00 AM Changeset in webkit [81242] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Minor clean-up after r81156, r81172

Follow-up for:
<​http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

  • platform/graphics/GraphicsLayer.h: Removed unused @class

WebLayer declaration.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

struct CAPropertyAnimation to class declaration.

7:49 AM Changeset in webkit [81241] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations.
Fix Linux Debug expectation clash for transitions/interrupted-accelerated-transition.html.
Let svg/text/font-size-below-point-five.svg fail on Mac Release.

  • platform/chromium/test_expectations.txt:
6:13 AM Changeset in webkit [81240] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, remove duplicate expectations.

  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81239] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: inspector/elements/mutate-unknown-node.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56457

  • platform/qt/Skipped: Add inspector/elements/mutate-unknown-node.html.
4:48 AM Changeset in webkit [81238] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove live-edit code
​https://bugs.webkit.org/show_bug.cgi?id=56177

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._doubleClick):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:21 AM Changeset in webkit [81237] by benjamin.poulain@nokia.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

2011-03-16 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Loading an empty URL crashes
​https://bugs.webkit.org/show_bug.cgi?id=55501

A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code
of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is.

This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter
ensure the returned string is a valid null string.

Tested through the Qt API tests.

  • UIProcess/API/C/WKPage.cpp: (WKPageLoadURL):
  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyUrl):
  • UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added.
  • UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added. (tst_QWKPage::init): (tst_QWKPage::cleanup): (tst_QWKPage::loadEmptyUrl):
  • UIProcess/API/qt/tests/tests.pro:
4:09 AM Changeset in webkit [81236] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Typo fix after r81226.

  • platform/qt/Skipped: Remove unnecessary "#".
4:05 AM Changeset in webkit [81235] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, suppress Win builder failures from r81222.
Also, one tentatively stale suppression is removed.

  • platform/chromium/test_expectations.txt:
3:40 AM Changeset in webkit [81234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Martin Robinson.

[GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
​https://bugs.webkit.org/show_bug.cgi?id=56403

In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
i.e the pause() made when beginScrubbing is done is just internal.

No new tests: Verified manually.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
3:39 AM Changeset in webkit [81233] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56242
Flaky Test: transitions/interrupted-accelerated-transition.html

Skip this while ​https://bugs.webkit.org/show_bug.cgi?id=54151
(Animation API) is in progress.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
2:44 AM Changeset in webkit [81232] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
​https://bugs.webkit.org/show_bug.cgi?id=36467

Removing the test from skipped list since the problem seems to be solved.

  • platform/qt/Skipped:
2:00 AM Changeset in webkit [81231] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/audio-repaint.html times out again
​https://bugs.webkit.org/show_bug.cgi?id=56366

Rewrote the test to avoid a timer and attempt the seek on media
elements only after we are sure playback started to avoid an
INVALID_STATE_ERR exception.

  • media/audio-repaint.html:
1:58 AM Changeset in webkit [81230] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build platform/
​https://bugs.webkit.org/show_bug.cgi?id=56430

Adding platform/ to the GYP build required disabling
ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent
style issues. I suspect we'll end up excluding some of these files
from the build in the final analysis, but we might as well fix the
style errors while we're here.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/ScheduledAction.h:
  • css/CSSPrimitiveValueCache.cpp:
  • gyp/WebCore.gyp:
  • platform/KillRingNone.cpp: (WebCore::KillRing::append): (WebCore::KillRing::prepend):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp: (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::TessellationState::combineCallback):
  • platform/graphics/gpu/PODRedBlackTree.h: (WebCore::PODRedBlackTree::updateNode): (WebCore::PODRedBlackTree::logIfVerbose):
  • platform/graphics/opengl/TextureMapperGL.cpp:
  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::save): (WebCore::TextureMapper::paintToTarget):
  • platform/graphics/texmap/TextureMapperNode.h:
1:56 AM Changeset in webkit [81229] by Philippe Normand
  • 4 edits in trunk

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Let the mediaPlayerClient handle the stream error, in this case the HTMLMediaElement will emit a stalled event.

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/gtk/Skipped: Unskip fixed test.
1:52 AM Changeset in webkit [81228] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

2011-03-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] Frame accurate seeking isn't always accurate
​https://bugs.webkit.org/show_bug.cgi?id=55217

Attempt to build the seek GstClockTime position by converting the
float time value to a GTimeVal value rounded at microsecond
precision. Additionally perform the seek with the ACCURATE seek
flag. These modifications at least fix this manual-test:
​http://www.massive-interactive.nl/html5_video/smpte_test_universal.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
1:18 AM Changeset in webkit [81227] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Qt] Some inspector test fail intermittently
​https://bugs.webkit.org/show_bug.cgi?id=42090

Unskip a bunch of non-http inspector tests on Qt. All these tests pass locally.

  • platform/qt/Skipped:
1:14 AM Changeset in webkit [81226] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list.

  • platform/qt/Skipped:
    • Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled().
    • Add fast/workers/shared-worker-frame-lifecycle.html because it is still flakey. (bug 34281)
12:51 AM Changeset in webkit [81225] by hayato@chromium.org
  • 2 edits in trunk/Tools

2011-03-15 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

Ignore files that will be used by reftests in old-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=55936

  • Scripts/old-run-webkit-tests:

Mar 15, 2011:

11:59 PM Changeset in webkit [81224] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix bug number typo

  • platform/win/Skipped:
11:54 PM Changeset in webkit [81223] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip an asserting test on Windows

<​http://webkit.org/b/56047> tracks the failure.

  • platform/win/Skipped: Added editing/style/iframe-onload-crash.html.
11:46 PM Changeset in webkit [81222] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests
​https://bugs.webkit.org/show_bug.cgi?id=56389

Instead of sending one big request populateScriptObjects each agent requests
for initial data in its constructor.

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::getPreferredPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): (WebCore::InspectorDOMAgent::restore):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::isEnabled):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.js:
11:33 PM Changeset in webkit [81221] by levin@chromium.org
  • 3 edits
    10 deletes in trunk/LayoutTests

Fix few more baselines (which the tool didn't handle well before due to them
being in the mac-leopard directory).

svg/w3c due to r81168
svg/custom/mouse due to r81053

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
11:21 PM Changeset in webkit [81220] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Devirtualize isContentEditable and isRichlyContentEditable
​https://bugs.webkit.org/show_bug.cgi?id=56421

Rewrote Node::isContentEditable as a non-recursive non-virtual function.

  • dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable.
  • dom/Document.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::isContentEditable): Rewritten.
  • dom/Node.h: (WebCore::Node::isContentEditable): Calls isContentEditable(Editable). (WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable).
  • html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable.
  • html/HTMLElement.h: Ditto.
11:00 PM Changeset in webkit [81219] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Felipe Oliveira da Silva Netto <​f.dachshund@gmail.com>

Reviewed by Adam Roben.

Function relativeScriptsDir doesn't return the correct relative
Scripts directory.

  • Scripts/webkitdirs.pm: (relativeScriptsDir): Ensure we use the directory that contains webkitdirs.pm, not the one that contains the original script that was invoked.
10:46 PM Changeset in webkit [81218] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/
​https://bugs.webkit.org/show_bug.cgi?id=56412

Yay for smooth sailing.

  • gyp/WebCore.gyp:
10:02 PM Changeset in webkit [81217] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Fisher.

Move isReadOnly() from WebInputElement to WebFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=55760

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::isReadOnly):
  • src/WebInputElement.cpp:
9:13 PM Changeset in webkit [81216] by Dimitri Glazkov
  • 5 edits
    4 adds in trunk

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
​https://bugs.webkit.org/show_bug.cgi?id=56059

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics.

  • fast/dom/HTMLInputElement/input-slider-update-styled.html: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.checksum: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.png: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
​https://bugs.webkit.org/show_bug.cgi?id=56059

Test: fast/dom/HTMLInputElement/input-slider-update-styled.html

  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromValue): Added. (WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint. (WebCore::SliderThumbElement::setPositionFromPoint): Ditto. (WebCore::SliderThumbElement::defaultEventHandler): Ditto.
  • html/shadow/SliderThumbElement.h: Added decls.
9:04 PM Changeset in webkit [81215] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix following r81213. Same song second verse.

  • platform/image-encoders/skia/PNGImageEncoder.cpp:

(WebCore::encodePixels):

8:59 PM Changeset in webkit [81214] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix for Chromium OSX release build following r81213.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call.

8:26 PM Changeset in webkit [81213] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Add new test from webgl conformance test.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt: Added.
  • fast/canvas/webgl/premultiplyalpha-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Update to fix fillTexture (WebGLTestUtils):
  • platform/chromium/test_expectations.txt:
  • platform/mac-wk2/Skipped:

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Attempt to get an ImageData (non-premultiplied) from a WebGL canvas
instead of getting an ImageBuffer, so there's a chance the data can be
passed straight through to the consumer with no premultiplication
necessary. Fixes Chromium and Safari.

Test: fast/canvas/webgl/premultiplyalpha-test.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::getImageData):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::readRenderingResults): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): (WebCore::RGBAtoRGB): (WebCore::encodePixels): (WebCore::JPEGImageEncoder::encode):
  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA): (WebCore::encodePixels): (WebCore::PNGImageEncoder::encode):
  • platform/image-encoders/skia/PNGImageEncoder.h:

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Add support for reading a webgl context into an ImageData.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
  • src/GraphicsContext3DInternal.h:
8:10 PM Changeset in webkit [81212] by kevino@webkit.org
  • 6 edits in trunk

[wx] Build fixes after recent changes.

7:50 PM Changeset in webkit [81211] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r81208 for ​https://bugs.webkit.org/show_bug.cgi?id=56425

  • loader/icon/IconDatabaseBase.h: #include instead of forward declare.
7:31 PM Changeset in webkit [81210] by levin@chromium.org
  • 9 edits
    28 adds in trunk/LayoutTests

A little more clean-up due to r81168. Also, some adjustment of the results for Linux due to r81162.

  • platform/chromium-mac-leopard/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium/test_expectations.txt:
7:21 PM Changeset in webkit [81209] by Beth Dakin
  • 14 edits in trunk/Source/WebCore

Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
​https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas. In
turn, all of the ScrollableArea classes that add themselves to the HashSet must
keep a weak pointer to Page so that they can remove themselves without relying on
Frames or Renderers to still have references.

Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.

  • page/EventHandler.cpp:

(WebCore::layerForNode):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

(WebCore::FrameView::disconnectFromPage):

Add the new ScrollableArea set.

  • page/Page.cpp:

(WebCore::Page::~Page):
(WebCore::Page::addScrollableArea):

7:15 PM Changeset in webkit [81208] by beidson@apple.com
  • 27 edits
    7 adds in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 icon database.

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:

../WebKit2:

Project file paperwork:

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • Scripts/webkit2/messages.py: Special-case capitalization for messages that start with "URL" to be lowercased to "url" instead of "uRL".

Add messaging-related stuff:

  • Platform/CoreIPC/MessageID.h:
  • UIProcess/WebIconDatabase.messages.in: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

Prep to make WebIconDatabase an API object:

  • Shared/APIObject.h:

Add an "icon DB is enabled" flag to WebProcessCreationParameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI for client apps to set the icon database path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetIconDatabasePath):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.h:

(WebKit::WebContext::setIconDatabasePath):

Hook up initialization, clearing, and messaging for the icon database:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::iconDatabasePath):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

Add the UIProcess-side IconDatabase. It will be the "actual database" as well as the API object:

  • UIProcess/WebIconDatabase.cpp: Added.

(WebKit::WebIconDatabase::create):
(WebKit::WebIconDatabase::~WebIconDatabase):
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::invalidate):
(WebKit::WebIconDatabase::retainIconForPageURL):
(WebKit::WebIconDatabase::releaseIconForPageURL):
(WebKit::WebIconDatabase::setIconURLForPageURL):
(WebKit::WebIconDatabase::setIconDataForIconURL):
(WebKit::WebIconDatabase::iconDataForPageURL):
(WebKit::WebIconDatabase::iconURLForPageURL):
(WebKit::WebIconDatabase::iconDataKnownForIconURL):
(WebKit::WebIconDatabase::loadDecisionForIconURL):
(WebKit::WebIconDatabase::didReceiveMessage):
(WebKit::WebIconDatabase::didReceiveSyncMessage):

  • UIProcess/WebIconDatabase.h: Added.

(WebKit::WebIconDatabase::clearContext):
(WebKit::WebIconDatabase::type):

Add the WebProcess-side IconDatabaseProxy. It acts as the WebCore IconDatabase and operates via messaging:

  • WebProcess/IconDatabase: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Added.

(WebKit::WebIconDatabaseProxy::~WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::isEnabled):
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::iconForPageURL):
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::iconURLForPageURL):
(WebKit::WebIconDatabaseProxy::iconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
(WebKit::WebIconDatabaseProxy::urlImportFinished):
(WebKit::WebIconDatabaseProxy::didReceiveMessage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h: Added.

Hook up initialization and messaging for the icon database proxy:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
7:13 PM Changeset in webkit [81207] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Update Qt specific expected results after r80846.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
6:17 PM Changeset in webkit [81206] by weinig@apple.com
  • 1 edit
    1 add in trunk/Tools

Add script to convert a patch to a prettypatch and show in the default browser
​https://bugs.webkit.org/show_bug.cgi?id=56416

Reviewed by Darin Adler.

This can be used either like

$ svn-create-patch | show-pretty-diff

or

$ show-pretty-diff patch.diff

  • Scripts/show-pretty-diff: Added.
5:50 PM Changeset in webkit [81205] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-15 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: False SPOD cursor when context menu is open
<rdar://problem/9029154>
​https://bugs.webkit.org/show_bug.cgi?id=56433

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showContextMenu): Update to match showPopupMenu idiomatically, and stop the responsivenessTimer since the act of showing the context menu could spin a nested runloop.
  • UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::showContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu):
  • UIProcess/win/WebContextMenuProxyWin.cpp: (WebKit::WebContextMenuProxyWin::showContextMenu): Move isEmpty() check to implementations, since we don't want to show this in any case, not just the one where we check it.
5:48 PM Changeset in webkit [81204] by levin@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r81144.
​http://trac.webkit.org/changeset/81144
​https://bugs.webkit.org/show_bug.cgi?id=56432

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-03-15
It broke the ui test
NPAPITesterBase.GetURLRedirectNotification. (Requested by
dave_levin on #webkit).

  • public/WebURLLoader.h:
  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
(WebKit::AssociatedURLLoader::prepareRequest):
(WebKit::AssociatedURLLoader::willSendRequest):
(WebKit::AssociatedURLLoader::didSendData):
(WebKit::AssociatedURLLoader::didReceiveResponse):
(WebKit::AssociatedURLLoader::didDownloadData):
(WebKit::AssociatedURLLoader::didReceiveData):
(WebKit::AssociatedURLLoader::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoader::didFinishLoading):
(WebKit::AssociatedURLLoader::didFail):

  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81203] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build editing, fileapi, history, and html
​https://bugs.webkit.org/show_bug.cgi?id=56411

These all went smoothly.

  • gyp/WebCore.gyp:
5:31 PM Changeset in webkit [81202] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build dom/
​https://bugs.webkit.org/show_bug.cgi?id=56409

  • gyp/WebCore.gyp:
5:29 PM Changeset in webkit [81201] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build css/
​https://bugs.webkit.org/show_bug.cgi?id=56408

CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the
build yet. I've punted on that problem for now, but we'll come back to
it.

  • gyp/WebCore.gyp:
5:26 PM Changeset in webkit [81200] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build bindings/
​https://bugs.webkit.org/show_bug.cgi?id=56406

I wanted to include bindings/objc in this patch, but they were somewhat
complicated. It looks like they include headers from the output
directory (via PrivateHeaders), but we haven't wired up the
PrivateHeaders yet.

  • gyp/WebCore.gyp:
5:13 PM Changeset in webkit [81199] by levin@chromium.org
  • 6 edits
    1 move
    14 deletes in trunk/LayoutTests

Update Leopard specific baselines for tests (editing, css) changes due to r80755.
Fix the expectation for input-autofilled.

  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/input-autofilled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/input-autofilled-expected.txt.
  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [81198] by simonjam@chromium.org
  • 20 edits
    2 moves
    5 adds in trunk

2011-03-15 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
​https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added test cases for forceAsync.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Ditto.
  • http/tests/misc/script-async-load-execute-in-order-expected.txt: Added.
  • http/tests/misc/script-async-load-execute-in-order.html: Added.

2011-03-15 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
​https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

http/tests/misc/script-async-load-execute-in-order.html

  • Android.mk: Rename AsyncScriptRunner -> ScriptRunner.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Ditto. (WebCore::Document::~Document): Ditto.
  • dom/Document.h: (WebCore::Document::scriptRunner): Ditto.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder. (WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes. (WebCore::ScriptElement::prepareScript): Added support for forceAsync. (WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed.
  • dom/ScriptElement.h: (WebCore::ScriptElement::forceAsync): Added.
  • dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp. (WebCore::ScriptRunner::ScriptRunner): Added in-order script queue. (WebCore::ScriptRunner::~ScriptRunner): Ditto. (WebCore::ScriptRunner::executeScriptSoon): (WebCore::ScriptRunner::queueScriptForInOrderExecution): Added. (WebCore::ScriptRunner::suspend): (WebCore::ScriptRunner::resume): (WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready.
  • dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h. (WebCore::ScriptRunner::create): (WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes. (WebCore::HTMLScriptElement::setAsync): Ditto. (WebCore::HTMLScriptElement::async): Include forceAsync in calculation.
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto.
4:59 PM Changeset in webkit [81197] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Removed another deprecatedAppend
​https://bugs.webkit.org/show_bug.cgi?id=56429

Patch by Geoffrey Garen <​ggaren@apple.com> on 2011-03-15
Reviewed by Oliver Hunt.

  • collector/handles/HandleHeap.cpp:

(JSC::HandleHeap::markStrongHandles):

  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are

marked directly by the Heap.

  • runtime/Heap.cpp:

(JSC::Heap::markRoots): Ditto.

4:59 PM Changeset in webkit [81196] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another deprecatedAppend
​https://bugs.webkit.org/show_bug.cgi?id=56429

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles):
  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are marked directly by the Heap.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Ditto.
4:54 PM Changeset in webkit [81195] by Martin Robinson
  • 1 edit
    319 adds in trunk/LayoutTests

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Adding new test results for GTK+.

  • platform/gtk: All files omitted to prevent overflowing the BuildBot console.
4:54 PM Changeset in webkit [81194] by tony@chromium.org
  • 163 edits in trunk/Source

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
​https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

No new tests, just compressing png files.

  • inspector/front-end/Images/applicationCache.png:
  • inspector/front-end/Images/auditsIcon.png:
  • inspector/front-end/Images/back.png:
  • inspector/front-end/Images/breakpointBorder.png:
  • inspector/front-end/Images/breakpointConditionalBorder.png:
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/breakpointsActivateButtonGlyph.png:
  • inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png:
  • inspector/front-end/Images/checker.png:
  • inspector/front-end/Images/clearConsoleButtonGlyph.png:
  • inspector/front-end/Images/closeButtons.png:
  • inspector/front-end/Images/consoleButtonGlyph.png:
  • inspector/front-end/Images/consoleIcon.png:
  • inspector/front-end/Images/cookie.png:
  • inspector/front-end/Images/database.png:
  • inspector/front-end/Images/databaseTable.png:
  • inspector/front-end/Images/debuggerContinue.png:
  • inspector/front-end/Images/debuggerPause.png:
  • inspector/front-end/Images/debuggerStepInto.png:
  • inspector/front-end/Images/debuggerStepOut.png:
  • inspector/front-end/Images/debuggerStepOver.png:
  • inspector/front-end/Images/disclosureTriangleSmallDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRight.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightWhite.png:
  • inspector/front-end/Images/dockButtonGlyph.png:
  • inspector/front-end/Images/elementsIcon.png:
  • inspector/front-end/Images/enableOutlineButtonGlyph.png:
  • inspector/front-end/Images/enableSolidButtonGlyph.png:
  • inspector/front-end/Images/errorIcon.png:
  • inspector/front-end/Images/errorMediumIcon.png:
  • inspector/front-end/Images/errorRedDot.png:
  • inspector/front-end/Images/excludeButtonGlyph.png:
  • inspector/front-end/Images/focusButtonGlyph.png:
  • inspector/front-end/Images/forward.png:
  • inspector/front-end/Images/frame.png:
  • inspector/front-end/Images/garbageCollectButtonGlyph.png:
  • inspector/front-end/Images/gearButtonGlyph.png:
  • inspector/front-end/Images/glossyHeader.png:
  • inspector/front-end/Images/glossyHeaderPressed.png:
  • inspector/front-end/Images/glossyHeaderSelected.png:
  • inspector/front-end/Images/glossyHeaderSelectedPressed.png:
  • inspector/front-end/Images/goArrow.png:
  • inspector/front-end/Images/graphLabelCalloutLeft.png:
  • inspector/front-end/Images/graphLabelCalloutRight.png:
  • inspector/front-end/Images/helpButtonGlyph.png:
  • inspector/front-end/Images/largerResourcesButtonGlyph.png:
  • inspector/front-end/Images/localStorage.png:
  • inspector/front-end/Images/networkIcon.png:
  • inspector/front-end/Images/nodeSearchButtonGlyph.png:
  • inspector/front-end/Images/paneAddButtons.png:
  • inspector/front-end/Images/paneBottomGrow.png:
  • inspector/front-end/Images/paneBottomGrowActive.png:
  • inspector/front-end/Images/paneGrowHandleLine.png:
  • inspector/front-end/Images/paneSettingsButtons.png:
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png:
  • inspector/front-end/Images/percentButtonGlyph.png:
  • inspector/front-end/Images/popoverArrows.png:
  • inspector/front-end/Images/popoverBackground.png:
  • inspector/front-end/Images/profileGroupIcon.png:
  • inspector/front-end/Images/profileIcon.png:
  • inspector/front-end/Images/profileSmallIcon.png:
  • inspector/front-end/Images/profilesIcon.png:
  • inspector/front-end/Images/profilesSilhouette.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/Images/radioDot.png:
  • inspector/front-end/Images/recordButtonGlyph.png:
  • inspector/front-end/Images/recordToggledButtonGlyph.png:
  • inspector/front-end/Images/reloadButtonGlyph.png:
  • inspector/front-end/Images/resourceCSSIcon.png:
  • inspector/front-end/Images/resourceDocumentIcon.png:
  • inspector/front-end/Images/resourceDocumentIconSmall.png:
  • inspector/front-end/Images/resourceJSIcon.png:
  • inspector/front-end/Images/resourcePlainIcon.png:
  • inspector/front-end/Images/resourcePlainIconSmall.png:
  • inspector/front-end/Images/resourcesIcon.png:
  • inspector/front-end/Images/resourcesSizeGraphIcon.png:
  • inspector/front-end/Images/resourcesTimeGraphIcon.png:
  • inspector/front-end/Images/scriptsIcon.png:
  • inspector/front-end/Images/scriptsSilhouette.png:
  • inspector/front-end/Images/searchSmallBlue.png:
  • inspector/front-end/Images/searchSmallBrightBlue.png:
  • inspector/front-end/Images/searchSmallGray.png:
  • inspector/front-end/Images/searchSmallWhite.png:
  • inspector/front-end/Images/segment.png:
  • inspector/front-end/Images/segmentEnd.png:
  • inspector/front-end/Images/segmentHover.png:
  • inspector/front-end/Images/segmentHoverEnd.png:
  • inspector/front-end/Images/segmentSelected.png:
  • inspector/front-end/Images/segmentSelectedEnd.png:
  • inspector/front-end/Images/sessionStorage.png:
  • inspector/front-end/Images/splitviewDimple.png:
  • inspector/front-end/Images/splitviewDividerBackground.png:
  • inspector/front-end/Images/statusbarButtons.png:
  • inspector/front-end/Images/statusbarMenuButton.png:
  • inspector/front-end/Images/statusbarMenuButtonSelected.png:
  • inspector/front-end/Images/statusbarResizerHorizontal.png:
  • inspector/front-end/Images/statusbarResizerVertical.png:
  • inspector/front-end/Images/successGreenDot.png:
  • inspector/front-end/Images/thumbActiveHoriz.png:
  • inspector/front-end/Images/thumbActiveVert.png:
  • inspector/front-end/Images/thumbHoriz.png:
  • inspector/front-end/Images/thumbHoverHoriz.png:
  • inspector/front-end/Images/thumbHoverVert.png:
  • inspector/front-end/Images/thumbVert.png:
  • inspector/front-end/Images/timelineBarBlue.png:
  • inspector/front-end/Images/timelineBarGray.png:
  • inspector/front-end/Images/timelineBarGreen.png:
  • inspector/front-end/Images/timelineBarOrange.png:
  • inspector/front-end/Images/timelineBarPurple.png:
  • inspector/front-end/Images/timelineBarRed.png:
  • inspector/front-end/Images/timelineBarYellow.png:
  • inspector/front-end/Images/timelineCheckmarks.png:
  • inspector/front-end/Images/timelineDots.png:
  • inspector/front-end/Images/timelineHollowPillBlue.png:
  • inspector/front-end/Images/timelineHollowPillGray.png:
  • inspector/front-end/Images/timelineHollowPillGreen.png:
  • inspector/front-end/Images/timelineHollowPillOrange.png:
  • inspector/front-end/Images/timelineHollowPillPurple.png:
  • inspector/front-end/Images/timelineHollowPillRed.png:
  • inspector/front-end/Images/timelineHollowPillYellow.png:
  • inspector/front-end/Images/timelineIcon.png:
  • inspector/front-end/Images/timelinePillBlue.png:
  • inspector/front-end/Images/timelinePillGray.png:
  • inspector/front-end/Images/timelinePillGreen.png:
  • inspector/front-end/Images/timelinePillOrange.png:
  • inspector/front-end/Images/timelinePillPurple.png:
  • inspector/front-end/Images/timelinePillRed.png:
  • inspector/front-end/Images/timelinePillYellow.png:
  • inspector/front-end/Images/toolbarItemSelected.png:
  • inspector/front-end/Images/trackHoriz.png:
  • inspector/front-end/Images/trackVert.png:
  • inspector/front-end/Images/treeDownTriangleBlack.png:
  • inspector/front-end/Images/treeDownTriangleWhite.png:
  • inspector/front-end/Images/treeRightTriangleBlack.png:
  • inspector/front-end/Images/treeRightTriangleWhite.png:
  • inspector/front-end/Images/treeUpTriangleBlack.png:
  • inspector/front-end/Images/treeUpTriangleWhite.png:
  • inspector/front-end/Images/undockButtonGlyph.png:
  • inspector/front-end/Images/userInputIcon.png:
  • inspector/front-end/Images/userInputPreviousIcon.png:
  • inspector/front-end/Images/userInputResultIcon.png:
  • inspector/front-end/Images/warningIcon.png:
  • inspector/front-end/Images/warningMediumIcon.png:
  • inspector/front-end/Images/warningOrangeDot.png:
  • inspector/front-end/Images/warningsErrors.png:

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
​https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentHoverChromium.png:
  • src/js/Images/segmentHoverEndChromium.png:
  • src/js/Images/segmentSelectedChromium.png:
  • src/js/Images/segmentSelectedEndChromium.png:
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonSelectedChromium.png:
4:54 PM Changeset in webkit [81193] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some more deprecated / unsafe append
​https://bugs.webkit.org/show_bug.cgi?id=56428

  • collector/handles/HandleStack.cpp: (JSC::HandleStack::mark):
  • collector/handles/HandleStack.h: Mark the handle stack using a HeapRoot marker, since it's a heap root.


  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists): (JSC::MarkedArgumentBuffer::slowAppend):
  • runtime/ArgList.h: Ditto.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Added a mark call for marking the handle stack. It seems like Oliver forgot this in his last patch. (!)
  • runtime/MarkStack.h: Removed appendSlots, since it would allow an object to embed JSValues directly instead of using WriteBarrier.

(JSC::MarkStack::append): Added a private append for a list of values.

(JSC::HeapRootMarker::mark): Access to the above.

4:42 PM Changeset in webkit [81192] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some GTK+ tests after r81035 and r81049.

  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
4:29 PM Changeset in webkit [81191] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a few more deprecatedAppends, and removed HeapRoot<T>
​https://bugs.webkit.org/show_bug.cgi?id=56422


Added HeapRootMarker, a privileged class for marking direct heap roots
that are iterated during each garbage collection. This is easier to use
and more reliable than HeapRoot<T>, so I've removed HeapRoot<T>.

  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/Completion.cpp: (JSC::evaluate): exception is no longer a HeapRoot<T>, so no need to call .get() on it.
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/Heap.h: Updated to use HeapRootMarker.
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::append): Added private functions for HeapRootMarker to use.
  • runtime/JSGlobalData.h: exception is no longer a HeapRoot<T>.
  • runtime/MarkStack.h: (JSC::HeapRootMarker::HeapRootMarker): (JSC::HeapRootMarker::mark): Added private functions for HeapRootMarker to use.
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::markChildren): Updated to use HeapRootMarker.
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings): Updated to use HeapRootMarker.
  • runtime/WriteBarrier.h: Removed HeapRoot<T>.
4:24 PM Changeset in webkit [81190] by Adam Roben
  • 1 edit
    24 adds in trunk/LayoutTests

Update Windows XP results after r81168

They differ from Windows 7 due to different fonts being used.

  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Added.
4:24 PM Changeset in webkit [81189] by bweinstein@apple.com
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

Rubber-stamped by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
4:12 PM Changeset in webkit [81188] by oliver@apple.com
  • 16 edits
    4 adds in trunk/Source/JavaScriptCore

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Introduce Local<T> to allow us to start moving to precise marking of locals
​https://bugs.webkit.org/show_bug.cgi?id=56394

Introduce a new handle type, Local<T> and a scoping mechanism
LocalScope to allow us to start moving towards precise marking
of temporaries and local variables.

We also start to use the new Local<> type in the JSON stringifier
so that we can have some coverage of their behaviour in the initial
checkin.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • collector/handles/Handle.h: (JSC::::asObject):
  • collector/handles/HandleStack.cpp: Added. (JSC::HandleStack::HandleStack): (JSC::HandleStack::mark): (JSC::HandleStack::grow):
  • collector/handles/HandleStack.h: Added. (JSC::HandleStack::enterScope): (JSC::HandleStack::zapTo): (JSC::HandleStack::leaveScope): (JSC::HandleStack::push):
  • collector/handles/Local.h: Added. (JSC::Local::internalSet): (JSC::::Local): (JSC::::operator): (JSC::LocalStack::LocalStack): (JSC::LocalStack::peek): (JSC::LocalStack::pop): (JSC::LocalStack::push): (JSC::LocalStack::isEmpty): (JSC::LocalStack::size):
  • collector/handles/LocalScope.h: Added. (JSC::LocalScope::LocalScope): (JSC::LocalScope::~LocalScope): (JSC::LocalScope::release):
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::allocateLocalHandle): (JSC::Heap::handleStack):
  • runtime/JSCell.h: (JSC::JSCell::::getString):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateLocalHandle):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Stringifier): (JSC::Stringifier::stringify): (JSC::Stringifier::appendStringifiedValue): (JSC::Stringifier::Holder::Holder): (JSC::Walker::Walker): (JSC::Walker::walk): (JSC::JSONProtoFuncParse): (JSC::JSONProtoFuncStringify): (JSC::JSONStringify):
  • runtime/JSONObject.h:
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::appendSlots):
3:58 PM Changeset in webkit [81187] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update Windows results again after r81168

I accidentally copied the Mac results into platform/win for these two tests when I tried to
update results in r81179.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/text/small-fonts-2-expected.txt:
3:55 PM Changeset in webkit [81186] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-15 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian][WK2] Fix exporting and importing the WebProcessMainQt symbol
​https://bugs.webkit.org/show_bug.cgi?id=56417

Use the Q_DECL_EXPORT and Q_DECL_IMPORT macros directly to make sure
the symbol is always exported/imported.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
  • qt/MainQt.cpp:
3:37 PM Changeset in webkit [81185] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
​https://bugs.webkit.org/show_bug.cgi?id=56372

The bug was caused by insertNodeAfter's calling parentElement on document's child.
Fixed this by changing the node that AppendNodeCommand takes.

There was also a bug that document node always returned false for isContentEditable
and isContentRichlyEditable because they never overrode Node's default implementation.
Fixed this by overriding them in Document.

Test: editing/execCommand/append-node-under-document.html

  • dom/Document.cpp: (WebCore::Document::isContentEditable): Added. (WebCore::Document::isContentRichlyEditable): Added.
  • dom/Document.h:
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
  • editing/AppendNodeCommand.h: (WebCore::AppendNodeCommand::create): Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
  • editing/CompositeEditCommand.h:

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
​https://bugs.webkit.org/show_bug.cgi?id=56372

Added a test to ensure WebKit does not crash when appending a node to a document
that has only two nested iframes.

  • editing/execCommand/append-node-under-document-expected.txt: Added.
  • editing/execCommand/append-node-under-document.html: Added.
3:32 PM Changeset in webkit [81184] by levin@chromium.org
  • 20 edits
    1 copy
    449 adds
    1 delete in trunk/LayoutTests

Compensate for r81168 (svg) and r81155 (fast/forms/input-autofilled.html) and r81049 (fast/table).
Also, remove the linux debug crashes from test expectations due to r81162 which should clear these up.
Add update baselines for transitions/default-timing-function due to r80806.

  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png: Added.
  • platform/chromium-win/fast/forms/input-autofilled-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-win/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-linux/transitions/default-timing-function-expected.checksum:
  • platform/chromium-linux/transitions/default-timing-function-expected.png:
  • platform/chromium-mac/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-mac/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.checksum:
  • platform/chromium-win/transitions/default-timing-function-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [81183] by Michael Nordman
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

When initiating a main resource load, let the application cache
know which frame the load is being conducted for. This patch doesn't
resolve the following bug, but the additional WebFrame parameter
should provide the chromium port with enough info to pick the
"most appropiate" cached resource.
​https://bugs.webkit.org/show_bug.cgi?id=55505

Also fixup a stale comment in stopLoadingInFrame.

  • public/WebApplicationCacheHost.h: (WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource): (WebCore::ApplicationCacheHost::stopLoadingInFrame):
3:26 PM Changeset in webkit [81182] by helder@sencha.com
  • 2 edits in trunk/LayoutTests

2011-03-15 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/canvas-strokeRect-gradient-shadow.html no longer fails
​https://bugs.webkit.org/show_bug.cgi?id=56413

Rect stroking uses the same code path as path stroking, which was fixed
in r80250. Therefore, the test can be removed from the Skipped list as
it now succeeds.

  • platform/qt/Skipped:
3:17 PM Changeset in webkit [81181] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-03-15 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
3:02 PM Changeset in webkit [81180] by levin@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-03-15 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

Links from code reviews to trac are incorrect for files in Source/WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=56404

  • PrettyPatch/PrettyPatch.rb: Remove WebKit from the list of top level directories since it is now under Source.
2:48 PM Changeset in webkit [81179] by Adam Roben
  • 3 edits
    128 adds in trunk/LayoutTests

Add Windows results for tests added in r81168

The differences from the Mac results seem to be due to rounding and font differences.

  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-query-expected.png: Added.
  • platform/win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/win/svg/text/bidi-tspans-expected.png: Added.
  • platform/win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/win/svg/text/small-fonts-2-expected.checksum: Added.
  • platform/win/svg/text/small-fonts-2-expected.png: Added.
  • platform/win/svg/text/small-fonts-2-expected.txt:
2:42 PM Changeset in webkit [81178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

accessibility should build in WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56405

This patch changes our include/exclude strategy to more closely match
the strategy used by the Chromium GYP build system. Ideally, we'd find
a way to share more of these patterns. In the meantime, I'm going to
slowly increase the number of translation units in the project and
adjust the include/exclude filters appropriately.

  • gyp/WebCore.gyp:
2:42 PM Changeset in webkit [81177] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Gtk baseline.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/gtk/svg/text/text-align-02-b-expected.txt:
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt:
2:39 PM Changeset in webkit [81176] by Nikolas Zimmermann
  • 5 edits
    47 adds in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Mac Leopard baseline.

  • platform/mac-leopard/svg/W3C-I18N: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt:
2:37 PM Changeset in webkit [81175] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
​https://bugs.webkit.org/show_bug.cgi?id=56335

Reland with a fix to avoid really long command lines on Windows.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
2:20 PM Changeset in webkit [81174] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Forgot to save a modification to this file when committing.

  • WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2:15 PM Changeset in webkit [81173] by ap@apple.com
  • 25 edits
    2 moves
    2 deletes in trunk

Reviewed by Darin Adler.

REGRESSION (WebKit2): keygen element doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=56402
<rdar://problem/9006545>

Covered by existing regresison tests.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in: Removed WebCoreKeyGenerator, which no longer exists. Added _wkSignedPublicKeyAndChallengeString, so that this WKSI function could be used in WebCore.
  • platform/mac/SSLKeyGeneratorMac.mm: Removed.
  • platform/mac/WebCoreKeyGenerator.h: Removed.
  • platform/mac/WebCoreKeyGenerator.m: Removed.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • WebCore.xcodeproj/project.pbxproj: Renamed SSLKeyGeneratorMac.mm to .cpp, as it doesn't use any Objective C any more. Removed WebCoreKeyGenerator, as we no longer need an interface to WebKit.
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName):
  • platform/LocalizedStrings.h: Added strings used by keygen element, now that the code using them is in WebCore.
  • platform/mac/SSLKeyGeneratorMac.cpp: Copied from Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Moved the code from WebKit. There is never any need to provide implementation at runtime, like old code was doing.
  • platform/win/SSLKeyGeneratorWin.cpp: (WebCore::WebCore::getSupportedKeySizes): Added a FIXME about localization. Note that Safari for Windows doesn't support keygen.
2:02 PM Changeset in webkit [81172] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang build.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.h:
1:40 PM Changeset in webkit [81171] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Fix Lion build after r81161.

Pass the PlatformCALayer down into drawLayerContents()
so we can use its acceleratesDrawing() method.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (-[WebLayer drawInContext:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer drawInContext:]):
1:39 PM Changeset in webkit [81170] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Qt baseline, still waiting for gtk/leopard/win7/winxp.

  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/qt/svg/text/text-align-02-b-expected.txt:
  • platform/qt/svg/text/text-align-04-b-expected.txt:
1:17 PM Changeset in webkit [81169] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
​https://bugs.webkit.org/show_bug.cgi?id=56390

  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId):

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
​https://bugs.webkit.org/show_bug.cgi?id=56390

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId): (WebKit::WebPluginContainerImpl::platformLayer):
1:15 PM Changeset in webkit [81168] by Nikolas Zimmermann
  • 24 edits
    6 moves
    236 adds in trunk

2011-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
​https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
​https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
​https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text. The actual bidi support is working
fine, the problem is that SVG demands to reorder x/y/dx/dy/rotate value lists, in order to
main correspondance between the attributes and the potentially reordered text.

Land a new suite of SVG & i18n tests, covering unicode-bidi/direction and text-anchor support
with BiDi text (Arabic mixed with Latin) in LayoutTests/svg/W3C-I18N.

Enable long-disabled SVG BiDi tests, and international fonts support in svg/W3C-SVG-1.1
by providing a SVGFont replacment, replacing the need for MS Office Fonts to be present.
These tests have some value and we'd like to have them enabled again.

  • platform/mac/svg/W3C-I18N: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • svg/W3C-I18N: Added.
  • svg/W3C-I18N/NOTE: Added.
  • svg/W3C-I18N/g-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/resources: Added.
  • svg/W3C-I18N/resources/img1.png: Added.
  • svg/W3C-I18N/resources/img11.png: Added.
  • svg/W3C-I18N/resources/img12.png: Added.
  • svg/W3C-I18N/resources/img13.png: Added.
  • svg/W3C-I18N/resources/img14.png: Added.
  • svg/W3C-I18N/resources/img15.png: Added.
  • svg/W3C-I18N/resources/img16.png: Added.
  • svg/W3C-I18N/resources/img17.png: Added.
  • svg/W3C-I18N/resources/img18.png: Added.
  • svg/W3C-I18N/resources/img19.png: Added.
  • svg/W3C-I18N/resources/img2.png: Added.
  • svg/W3C-I18N/resources/img20.png: Added.
  • svg/W3C-I18N/resources/img21.png: Added.
  • svg/W3C-I18N/resources/img24.png: Added.
  • svg/W3C-I18N/resources/img25.png: Added.
  • svg/W3C-I18N/resources/img3.png: Added.
  • svg/W3C-I18N/resources/img4.png: Added.
  • svg/W3C-I18N/resources/img5.png: Added.
  • svg/W3C-I18N/resources/tanchor-left-right.png: Added.
  • svg/W3C-I18N/resources/tanchor-left.png: Added.
  • svg/W3C-I18N/resources/tanchor-right.png: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-no-markup.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-direction-ltr.svg: Added.
  • svg/W3C-I18N/tspan-direction-rtl.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg: Added.
  • svg/W3C-SVG-1.1/resources/SVGExotic.svg: Added.
  • svg/W3C-SVG-1.1/text-align-08-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-align-08-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-align-08-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • svg/text/bidi-reorder-value-lists.svg: Added.
  • svg/text/bidi-text-anchor-direction.svg: Added.
  • svg/text/bidi-text-query.svg: Added.
  • svg/text/bidi-tspans.svg: Added.

2011-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
​https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
​https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
​https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text.

BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in
the order the characters appear in the markup), and when laying out bidi text, we associated the current character
in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout.
The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct.

Long story:
Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics>
for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in
the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with
"abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6
width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class).
The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands
that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10").

To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all
characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to
determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the
inline box tree, in _visual order_, as it will appear on screen.

After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the
found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout
rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position
in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order,
the x/y/.. lists are all in logical order.

Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction:

the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20".

Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine,
before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now
process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order.

Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated,
which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of
shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by
dozens of new tests.

Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg

svg/W3C-I18N/g-dirLTR-ubOverride.svg
svg/W3C-I18N/g-dirRTL-ubNone.svg
svg/W3C-I18N/g-dirRTL-ubOverride.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-no-markup.svg
svg/W3C-I18N/text-dirLTR-ubNone.svg
svg/W3C-I18N/text-dirLTR-ubOverride.svg
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/text-dirRTL-ubOverride.svg
svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-direction-ltr.svg
svg/W3C-I18N/tspan-direction-rtl.svg
svg/W3C-SVG-1.1-SE/text-intro-02-b.svg
svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
svg/W3C-SVG-1.1-SE/text-intro-09-b.svg
svg/W3C-SVG-1.1/text-align-08-b.svg
svg/W3C-SVG-1.1/text-fonts-03-t.svg
svg/W3C-SVG-1.1/text-intro-01-t.svg
svg/W3C-SVG-1.1/text-intro-02-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg
svg/W3C-SVG-1.1/text-intro-04-t.svg
svg/text/bidi-reorder-value-lists.svg
svg/text/bidi-text-anchor-direction.svg
svg/text/bidi-text-query.svg
svg/text/bidi-tspans.svg

  • rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text. (WebCore::RenderBlock::determineStartPosition):
  • rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
  • rendering/svg/SVGRenderTreeAsText.cpp: Ditto. (WebCore::writeSVGInlineTextBox):
  • rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup).

This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual
order as the characters are presented on screen.

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption. (WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left. (WebCore::SVGTextChunk::calculateLength): (WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl).
  • rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield. (WebCore::SVGTextChunk::isVerticalText): (WebCore::SVGTextChunk::hasDesiredTextLength): (WebCore::SVGTextChunk::hasTextAnchor): (WebCore::SVGTextChunk::hasLengthAdjustSpacing): (WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs):
  • rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes. (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk):
  • rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text. (WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object

that we cache, refers to the _rendered_ character. For Arabic text that means, that we're
measuring the shaped width of the glyph, not the glyph in its isolated form. Without that
fix reordering boxes containing Arabic is wrong.

  • rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm

has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have
to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine,
to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog.

(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph.

The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for
Arabic until now.)

(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct. (WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange):
  • rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method. (WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed.
  • rendering/svg/SVGTextMetrics.h: (WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic).
  • rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::calculateGlyphBoundaries):
1:12 PM Changeset in webkit [81167] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Revert 81151 - Merge 80887 - 2011-03-11 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com

TBR=​enne@google.com

12:52 PM Changeset in webkit [81166] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix make distcheck for 1.3.13 release
​https://bugs.webkit.org/show_bug.cgi?id=56371

No new tests as this is a build fix.

  • GNUmakefile.am: added a couple of missing files.
12:36 PM Changeset in webkit [81165] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-03-08 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode
​https://bugs.webkit.org/show_bug.cgi?id=52642

Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous
functions that create new positions. Also fixing various parts of editing code that
incorrectly handled the new positions now being created.

No new tests as this is refactoring/cleanup.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange):
  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::Position::getInlineBoxAndOffset):
  • dom/Position.h: (WebCore::operator==):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::unlistifyParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::enclosingEmptyListItem):
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
12:22 PM Changeset in webkit [81164] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth

Make WebConsoleMessage properly respect the log level.
​https://bugs.webkit.org/show_bug.cgi?id=56386

  • public/WebConsoleMessage.h: (WebKit::WebConsoleMessage::WebConsoleMessage):
11:53 AM Changeset in webkit [81163] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::cancelAnimations):

11:45 AM Changeset in webkit [81162] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56329

Reviewed by Dave Levin.

Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's
constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of
mutating orientation.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformInit):

11:42 AM Changeset in webkit [81161] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Disable ShadowBlur shadow drawing in accelerated contexts
​https://bugs.webkit.org/show_bug.cgi?id=56392

When drawing into a graphics context that is accelerated, don't use
ShadowBlur, because it may be slower.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): (WebCore::GraphicsContext::setIsAcceleratedContext): (WebCore::GraphicsContext::isAcceleratedContext):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
11:39 AM Changeset in webkit [81160] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix the Windows build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:

(NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):

11:30 AM Changeset in webkit [81159] by Beth Dakin
  • 21 edits in trunk/Source

Source/WebCore: Fix for <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new
page.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

Scroll animations should be suspended if the FrameLoadState is anything but
complete.

  • page/FrameView.cpp:

(WebCore::FrameView::shouldSuspendScrollAnimations):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldSuspendScrollAnimations):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::shouldSuspendScrollAnimations):

  • rendering/RenderListBox.h:

New virtual function cancelAnimations() is only needed on the Mac, so the base
class is empty.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::cancelAnimations):

ScrollAnimatorMac needs to keep track of whether the page has been scrolled since
it started loading. If so, we will override optimizations that wait for the
FrameLoadState to be complete before animating scrollbars.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad):

If the scrollbar animations should be suspended, we start a timer to make sure
that we do flash the scrollbars. Animating the scrollbars is expensive, so this is
both a performance optimization and a UI enhancement since the scrollbar won't
jump around nearly as much on a page load.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

New WebCoreSystemInterface function to force the scrollbars to flash

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: WebKit2 part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

11:25 AM Changeset in webkit [81158] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Remove stale comment at RenderStyle::diff.
​https://bugs.webkit.org/show_bug.cgi?id=56387

  • rendering/style/RenderStyle.cpp: Removed comment.
11:23 AM Changeset in webkit [81157] by andersca@apple.com
  • 14 edits
    3 adds in trunk

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Make sure to always increment the load count whenever a web process connection
is opened to a plug-in process, and decrement it when the last web process connection
goes away.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection): (WebKit::PluginProcess::startShutdownTimerIfNecessary):
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): (WebKit::NetscapePlugin::~NetscapePlugin):

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Add test.

  • plugins/npruntime/np-deallocate-called-before-np-shutdown-expected.txt: Added.
  • plugins/npruntime/np-deallocate-called-before-np-shutdown.html: Added.

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391

Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::PluginTest): (PluginTest::NP_Shutdown): (PluginTest::registerNPShutdownFunction):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added. (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown): (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty): (NPDeallocateCalledBeforeNPShutdown::NPP_New): (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue): (NPDeallocateCalledBeforeNPShutdown::shutdown):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Shutdown):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:
11:22 AM Changeset in webkit [81156] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

<​http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

Reviewed by Simon Fraser.

Typedef-ing Objective-C classes as void* for pure C++ makes it
easier for bugs to creep in because compilers can't do any type
checking for void pointers.

  • platform/graphics/GraphicsContext3D.h: Changed typedef

declarations for CALayer and WebGLLayer from void* to structs.
(WebCore::GraphicsContext3D::platformLayer): Changed
static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
CALayer and WebGLLayer are not void pointers.

  • platform/graphics/GraphicsLayer.h: Changed typedef declaration

for PlatformLayer from void* to struct CALayer.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

declaration for CAPropertyAnimation from void* to a struct.
Extracted typdef for PlatformAnimationRef.

11:02 AM Changeset in webkit [81155] by commit-queue@webkit.org
  • 19 edits
    3 adds in trunk

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • fast/forms/input-autofilled-expected.txt: Added.
  • fast/forms/input-autofilled.html: Added.
  • platform/win/fast/forms/input-autofilled-expected.txt: Added.

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

Test: fast/forms/input-autofilled.html

  • css/html.css: (input:-webkit-autofill): Added foreground color: #000000
  • css/wml.css: (input:-webkit-autofill): Added foreground color: #000000

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
  • DOM/WebDOMOperationsPrivate.h:

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • DumpRenderTree/LayoutTestController.cpp: (setAutofilledCallback): Added. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAutofilled): Added. (LayoutTestController::setValueForUser): Style tweak.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAutofilled): Added (stub).
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAutofilled): Added (stub).
11:02 AM Changeset in webkit [81154] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix broken assert in new code.

Reviewed by Sam Weinig.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordPutByVal):

  • recordPutByVal is called for both PutByVal & PutByValAlias.
10:57 AM Changeset in webkit [81153] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed redundant code from BytecodeGenerator.

Rubber stamped by Sam Weinig.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
    • delete uncalled code missed when reparsing was removed.
10:56 AM Changeset in webkit [81152] by tony@chromium.org
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Revert r81147 and r81149, broke the chromium win build.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Removed.
10:52 AM Changeset in webkit [81151] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80887 - 2011-03-11 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com

10:51 AM Changeset in webkit [81150] by Adam Roben
  • 2 edits in trunk/Source/WebKit/mac

2011-03-15 Adam Roben <Adam Roben>

Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin

Fixes <​http://webkit.org/b/56385> SecurityOrigin leaks seen in
WebStorageTrackerClient::dispatchDidModifyOrigin

Reviewed by Antti Koivisto.

  • Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed to us by dispatchDidModifyOrigin. (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an unnecessary cast.
10:49 AM Changeset in webkit [81149] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Fix chromium build using python 2.5 (with statement).

  • scripts/generate_devtools_grd.py:
10:47 AM Changeset in webkit [81148] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80824 - 2011-03-10 Chris Guillory <​chris.guillory@google.com>

Reviewed by James Robinson.

Fix for Coverity discovered NO_EFFECT (self-assign) defect.
​https://bugs.webkit.org/show_bug.cgi?id=54143

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::setMaxTextureSize):

TBR=​enne@google.com

10:40 AM Changeset in webkit [81147] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
​https://bugs.webkit.org/show_bug.cgi?id=56335

This is the webkit side of the fix for
​http://code.google.com/p/chromium/issues/detail?id=35793

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
10:35 AM Changeset in webkit [81146] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update WebKit2 Skipped file for some new tests that rely on unimplemented features

  • platform/mac-wk2/Skipped:
10:32 AM Changeset in webkit [81145] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
if it's an internal pause for example.
​https://bugs.webkit.org/show_bug.cgi?id=56374

In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
change into the DOM.

No new tests: Verified manually.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
10:24 AM Changeset in webkit [81144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-15 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. No new functionality exposed.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
10:14 AM Changeset in webkit [81143] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove unnecessary function WebPlugin::getBackingTextureId
​https://bugs.webkit.org/show_bug.cgi?id=56122

It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.

  • public/WebPlugin.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::platformLayer):
9:51 AM Changeset in webkit [81142] by mitz@apple.com
  • 2 edits in trunk/Tools

Build fix after r81135.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
9:33 AM Changeset in webkit [81141] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed. Update chromium deps to pick up the latest V8.

  • DEPS:
9:30 AM Changeset in webkit [81140] by mitz@apple.com
  • 5 edits in trunk/Tools

Build fix after r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/mac/TestControllerMac.mm:
  • WebKitTestRunner/mac/TestInvocationMac.mm:
  • WebKitTestRunner/mac/main.mm:
9:01 AM Changeset in webkit [81139] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Barth.

REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
​https://bugs.webkit.org/show_bug.cgi?id=56349

  • QtTestBrowser/QtTestBrowser.pro: Link against fontconfig on platforms where we use it. Copied from DumpRenderTree.pro.
8:51 AM Changeset in webkit [81138] by mitz@apple.com
  • 3 edits in trunk/Tools

Build fix after r81135.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
8:44 AM Changeset in webkit [81137] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] [WebKit2] The UIProcess never changes the mouse cursor
​https://bugs.webkit.org/show_bug.cgi?id=56333

Add an implementation for WebView::addCursor for WebKit2 GTK+. This allows
the cursor to change as the user mouses around the page. There is currently
no test infrastructure to track cursor changes.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::setCursor): Ported implementation from WebKit1.
8:12 AM Changeset in webkit [81136] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
7:59 AM Changeset in webkit [81135] by kevino@webkit.org
  • 55 edits
    3 adds in trunk

Reviewed by Darin Adler.

Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.

​https://bugs.webkit.org/show_bug.cgi?id=27551

7:41 AM Changeset in webkit [81134] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Chromium: shared lib linux build are failing.

Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
It was webcore_remaining instead of webcore_platform.

  • WebCore.gyp/WebCore.gyp:
7:38 AM Changeset in webkit [81133] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expanding/collapsing object shouldn&apos;t affect outer console.group expansion state
​https://bugs.webkit.org/show_bug.cgi?id=56373

  • inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.toggleExpanded): (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
7:13 AM Changeset in webkit [81132] by pfeldman@chromium.org
  • 6 edits in trunk

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/InspectorDOMAgent.cpp:
  • inspector/front-end/ElementsTreeOutline.js:
7:02 AM Changeset in webkit [81131] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-15 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
6:47 AM Changeset in webkit [81130] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
​https://bugs.webkit.org/show_bug.cgi?id=56327

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionAPISchema.json:
6:08 AM Changeset in webkit [81129] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
​https://bugs.webkit.org/show_bug.cgi?id=56114

  • inspector/console/console-nested-group-expected.txt: Added.
  • inspector/console/console-nested-group.html: Added.

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
​https://bugs.webkit.org/show_bug.cgi?id=56114

Test: inspector/console/console-nested-group.html

  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::type):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
3:47 AM Changeset in webkit [81128] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-15 Chris Mumford <​chris.mumford@palm.com>

Reviewed by Adam Barth.

Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.

No new tests: No feature additions/removals.

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
3:46 AM Changeset in webkit [81127] by hayato@chromium.org
  • 9 edits in trunk/Tools

2011-03-15 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

[NRWT] Add support for reftests to new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=55457

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:33 AM Changeset in webkit [81126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=56255
Fix build on Solaris 10/Sun Studio 12 C++

No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++

  • bridge/runtime_array.h: (JSC::RuntimeArray::getConcreteArray):
3:32 AM Changeset in webkit [81125] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

  • platform/gtk/Skipped:
3:19 AM Changeset in webkit [81124] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update test expectations

  • platform/chromium/test_expectations.txt:
3:10 AM Changeset in webkit [81123] by alex
  • 2 edits in trunk/Tools

2011-03-15 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix compilation warning after r80892
​https://bugs.webkit.org/show_bug.cgi?id=56302

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::originsWithLocalStorage):
2:41 AM Changeset in webkit [81122] by robert@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

Document the qmakearg argument, and hint how to build webkit2 on Qt
​https://bugs.webkit.org/show_bug.cgi?id=56326

  • Scripts/build-webkit: add --qmakearg to build-webkit --help
2:09 AM Changeset in webkit [81121] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by David Levin.

Update Chromium test expectations for fast/forms/onchange-setvalueforuser
​https://bugs.webkit.org/show_bug.cgi?id=56365

  • platform/chromium/fast/forms/onchange-setvalueforuser-expected.txt: Added.
12:28 AM Changeset in webkit [81120] by Adam Roben
  • 3 edits in trunk/Tools

Make Windows 7 Release (Tests) a core builder

We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.

Fixes <​http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder

Reviewed by Sam Weinig.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot): Added a regexp to match Windows 7 Release (Tests).

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.

Note: See TracTimeline for information about the timeline view.