⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 17, 2011:

11:59 PM Changeset in webkit [81446] by Adam Roben
  • 3 edits in trunk/Tools

Allow values in Leaks Viewer to be shown as percentages

Double-clicking on a column will toggle between showing percentages and showing real values.

Fixes <​http://webkit.org/b/56628> Would like to view values as percentages of the total
number of leaked bytes in Leaks Viewer

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
node's totalTime, which is used in calculating percentages.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
showing them as percentages.

11:58 PM Changeset in webkit [81445] by Adam Roben
  • 3 edits in trunk/Tools

Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer

The Self and Total columns now report the number of leaked bytes. The new Calls column shows
the number of leaked allocations. And the new Average column shows the average number of
leaked bytes per call.

Fixes <​http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
just how many allocations

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
line and store it with the leak stack.
(LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
properties.
(LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
.numberOfCalls now holds the number of leaked allocations.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
appear.
(monkeyPatchInspectorObjects): Format the values as bytes.

10:39 PM Changeset in webkit [81444] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that is likely causing later tests to assert

<​http://webkit.org/b/56599> tracks the failure.

  • platform/win/Skipped: Replaced editing/deleting/5206311-1.html with

editing/deleting/5168598.html, which is likely causing the former to assert.

10:19 PM Changeset in webkit [81443] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows XP results for test added in r81404

The differences from Windows 7 seem to be due to different fonts being used.

  • platform/win-xp/fast/text/emphasis-combined-text-expected.txt: Added.
10:18 PM Changeset in webkit [81442] by Adam Roben
  • 2 edits in trunk/Tools

Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests

Fixes <​http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
regression tests

Reviewed by James Robinson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
is always populated, even when all regression tests pass.

10:09 PM Changeset in webkit [81441] by hayato@chromium.org
  • 3 edits in trunk/Tools

2011-03-10 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

Add a check logic for reftests in case that a reftest is marked AS REBASELINE.

​https://bugs.webkit.org/show_bug.cgi?id=56076

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
9:10 PM Changeset in webkit [81440] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QML WebView emits iconChanged() when the page title changes
​https://bugs.webkit.org/show_bug.cgi?id=56570

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged signal to the view's iconChanged signal.
9:03 PM Changeset in webkit [81439] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add some of the remaining platform/mac files to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56616

These files used to be hard, but are now magically easy. 76 link errors.

  • gyp/WebCore.gyp:
8:53 PM Changeset in webkit [81438] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

Leaving the file names as-is for now to avoid svn-apply's
handling of move-and-modify.

  • fast/filesystem/directory-entry-to-uri-expected.txt:
  • fast/filesystem/file-entry-to-uri-expected.txt:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
  • http/tests/filesystem/resolve-uri-expected.txt:
  • http/tests/filesystem/script-tests/resolve-uri.js:

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

  • fileapi/Entry.idl:
  • fileapi/EntryBase.cpp: (WebCore::EntryBase::toURL):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURL):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
8:40 PM Changeset in webkit [81437] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80672
BUG=75311

8:39 PM Changeset in webkit [81436] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80672
BUG=75311
Review URL: ​http://codereview.chromium.org/6711031

8:25 PM Changeset in webkit [81435] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/648

Merge 80487
BUG=74991
Review URL: ​http://codereview.chromium.org/6685081

8:20 PM Changeset in webkit [81434] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80144
BUG=74562
Review URL: ​http://codereview.chromium.org/6711030

8:10 PM Changeset in webkit [81433] by cevans@google.com
  • 2 edits in branches/chromium/648

Merge 80043
BUG=74720
Review URL: ​http://codereview.chromium.org/6711029

8:06 PM Changeset in webkit [81432] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80579
BUG=75155

8:05 PM Changeset in webkit [81431] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80579
BUG=75155
Review URL: ​http://codereview.chromium.org/6712027

7:57 PM Changeset in webkit [81430] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/648

Merge 80520
BUG=75170
Review URL: ​http://codereview.chromium.org/6714006

7:49 PM Changeset in webkit [81429] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/plugins/PluginView.cpp

Merge 79897
BUG=73216
Review URL: ​http://codereview.chromium.org/6711028

7:46 PM Changeset in webkit [81428] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 79808
BUG=73216
Review URL: ​http://codereview.chromium.org/6709019

7:43 PM Changeset in webkit [81427] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • WebKit2.xcodeproj/project.pbxproj:
7:14 PM Changeset in webkit [81426] by simonjam@chromium.org
  • 19 edits
    11 adds in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, rebaseline a bunch of chromium tests.

  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
6:58 PM Changeset in webkit [81425] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Test some error-handling cases.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing.html: Added.

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Brandon updated the CSP spec. I've updated our implementation to
match. In the process, I found a couple bugs in the spec, which I've
sent to the working group. This patch assumes that the bugs will be
fixed in the way I suggested. If they get fixed a different way, we
might need to update the parser again.

Test: http/tests/security/contentSecurityPolicy/directive-parsing.html

  • page/ContentSecurityPolicy.cpp: (WebCore::isDirectiveNameCharacter): (WebCore::isDirectiveValueCharacter): (WebCore::advanceUntil): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::parseDirective):
  • page/ContentSecurityPolicy.h:
6:36 PM Changeset in webkit [81424] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should have PrivateHeaders
​https://bugs.webkit.org/show_bug.cgi?id=56604

I've manually verified that this produces the correct set of
PrivateHeaders (modulo the ForwardingHeaders and icu issue).
Unforunately, this patch breakes compile slightly, but I'll fix that
in a followup patch.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • gyp/WebCore.gyp:
6:31 PM Changeset in webkit [81423] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
6:17 PM Changeset in webkit [81422] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

chromium: uninitialized field in WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=56620

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
6:11 PM Changeset in webkit [81421] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setFullscreenWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56618

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_fullscreenWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
if m_fullscreenWindowIsShowing is true, call exitFullscreen.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::getPluginProcessSerialNumber): Add helper function for getting a PSN for the plug-in process.

(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
Make the plug-in process the front process.

(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
Make the current process (the UI process) the front process.

(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Call enterFullscreen or exitFullscreen.

(WebKit::PluginProcessProxy::enterFullscreen):
Make the plug-in process the front process and hide the menu bar.

(WebKit::PluginProcessProxy::exitFullscreen):
Show the menu bar and if necessary make the UI process the front process.

(WebKit::PluginProcessProxy::endModal):
call makeUIProcessTheFrontProcess.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Call makePluginProcessTheFrontProcess.

6:11 PM Changeset in webkit [81420] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.

Fixed some string leaks seen on the buildbot
​https://bugs.webkit.org/show_bug.cgi?id=56619

  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::~PropertyTable): DEref!
5:52 PM Changeset in webkit [81419] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make bidi text in <select> menus in WebKit2 on Windows match WebKit1

Fixes <​http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.

5:45 PM Changeset in webkit [81418] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setModalWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56615

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_modalWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
If m_modalWindowIsShowing is true, we must call endModal.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (-[WKPlaceholderModalWindow _wantsUserAttention]): Add a WKPlaceholderModalWindow.

(WebKit::PluginProcessProxy::setModalWindowIsShowing):
Call beginModal or endModal depending on whether we're showing a modal window or not.

(WebKit::PluginProcessProxy::beginModal):
Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.

(WebKit::PluginProcessProxy::endModal):
Tear down the window and the run loop.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Make sure that the plug-in process is frontmost.

5:18 PM Changeset in webkit [81417] by levin@chromium.org
  • 10 edits in trunk/LayoutTests

Misc clean-up (see files for details).

  • platform/chromium-mac-leopard/media/controls-after-reload-expected.checksum: Due to r81300.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Due to r81285.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Ditto.
  • platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-win-xp/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Replace BUG_LEVIN with a bug number.
5:11 PM Changeset in webkit [81416] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-17 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Web page shouldn't swallow alt-key combinations on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56612


Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
sure any alt-key combinations bubble up to the client.

  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.
5:11 PM Changeset in webkit [81415] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added platform-specific expected results for fast/text/emphasis-combined-text.html

  • platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Added.
  • platform/win/fast/text/emphasis-combined-text-expected.txt: Added.
5:10 PM Changeset in webkit [81414] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-17 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Video colors have wrong brightness/contrast
​https://bugs.webkit.org/show_bug.cgi?id=56598

This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.

  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderYUVVideo::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h: (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h:
5:08 PM Changeset in webkit [81413] by Adam Roben
  • 3 edits
    1 delete in trunk

Skip a compositing-sensitive test when accelerated compositing is disabled

Reviewed by Sam Weinig.

Tools:

  • Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when

accelerated compositing is disabled.

LayoutTests:

Remove some non-compositing results for a test that is now skipped in non-compositing builds

  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Removed.
5:08 PM Changeset in webkit [81412] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=56610

  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::FullscreenWindowTracker::FullscreenWindowTracker): Add fullscreen window tracker class.

(WebKit::rectCoversAnyScreen):
Return whether the given rect covers any screen.

(WebKit::windowCoversAnyScreen):
Return whether the given window covers any screen.

(WebKit::FullscreenWindowTracker::windowShown):
If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::FullscreenWindowTracker::windowHidden):
If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
Call the window tracking functions.

(WebKit::setModal):
Call PluginProcess::setModalWindowIsShowing.

(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Send CoreIPC messages.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in: Add new messages.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::setModalWindowIsShowing): (WebKit::PluginProcessProxy::setFullscreenWindowIsShowing): Add stubs.
4:57 PM Changeset in webkit [81411] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in JSC::MarkStack::drain Under Stress
​https://bugs.webkit.org/show_bug.cgi?id=56470

We perform a number of gc allocations while when
we are setting up new globals in a piece of global
code. We do this by adding new properties to the
symbol table, and then expanding the storage to fit
at the end.

If a GC happens during this time we will report an
incorrect size for the global object's symbol table
storage.

This patch corrects this by growing the storage size
before we starting adding entries to the symbol table.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resizeRegisters):
4:46 PM Changeset in webkit [81410] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure we're using, since the Executable is not designed to own the Structure.
4:43 PM Changeset in webkit [81409] by zmo@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 81407 - 2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.

TBR=​zmo@google.com

4:27 PM Changeset in webkit [81408] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rubber Stamped by Sam Weinig.

Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::testb_rr):

4:26 PM Changeset in webkit [81407] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.
4:22 PM Changeset in webkit [81406] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/8953779>

Reviewed by Darin Adler.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

4:16 PM Changeset in webkit [81405] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:11 PM Changeset in webkit [81404] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
​https://bugs.webkit.org/show_bug.cgi?id=56480

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/text/emphasis-combined-text.html

  • rendering/InlineTextBox.cpp:

(WebCore::rotation): Added this helper.
(WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
centered vertically.

LayoutTests:

  • fast/text/emphasis-combined-text.html: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.txt: Added.
4:11 PM Changeset in webkit [81403] by barraclough@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Bug 56603 - DFG JIT related cleanup
Move node generation out to separate function, move binarySearch algorithm out
to StdLibExtras, fix Graph::dump() to print comma between non-node children,
even if there are no node children.

Reviewed by Sam Weinig.

  • bytecode/CodeBlock.h:

(JSC::getCallReturnOffset):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::bytecodeOffset):

  • Move binaryChop to binarySearch in StdLibExtras
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • Make m_noArithmetic a member, initialize m_currentIndex in the constructor.
  • dfg/DFGByteCodeParser.h:
    • Change parse() to not take a start index (always 0).
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • Fix Graph::dump() to print comma between non-node children, even if there are no node children.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • Initialize m_compileIndex in constructor.
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationConvertThis):

  • dfg/DFGOperations.h:
    • Cleanup parameter name.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):

  • Change parse() to not take a start index (always 0).
  • wtf/StdLibExtras.h:

(WTF::binarySearch):

  • Move binaryChop to binarySearch in StdLibExtras
4:10 PM Changeset in webkit [81402] by Lucas Forschler
  • 1 copy in tags/Safari-534.25

New tag.

4:07 PM Changeset in webkit [81401] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a leak seen on the buildbot.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
4:07 PM Changeset in webkit [81400] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Allow passing a certificate chain as a user message
<rdar://problem/8951709>
​https://bugs.webkit.org/show_bug.cgi?id=56605

Reviewed by Brady Eidson.

  • Shared/API/c/mac/WKCertificateInfoMac.h:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.

4:06 PM Changeset in webkit [81399] by jianli@chromium.org
  • 9 edits
    3 adds in trunk

Blob URL should not be allow to get created from the code running from data URI
​https://bugs.webkit.org/show_bug.cgi?id=56600

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/fileapi/create-blob-url-from-data-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::createBlobURL):

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURI):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

LayoutTests:

  • http/tests/fileapi/create-blob-url-from-data-url-expected.txt: Added.
  • http/tests/fileapi/create-blob-url-from-data-url.html: Added.
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:29 PM Changeset in webkit [81398] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix clang build.

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

3:21 PM Changeset in webkit [81397] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Skip an editing test that hits assertion on non-Mac platforms.
The bug is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56599.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:18 PM Changeset in webkit [81396] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80064.
​http://trac.webkit.org/changeset/80064
​https://bugs.webkit.org/show_bug.cgi?id=56588

the original test was correct (Requested by rniwa on #webkit).

  • platform/mac/editing/input/selection-change-closes-typing.html:
3:17 PM Changeset in webkit [81395] by enne@google.com
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-17 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
​https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:
3:15 PM Changeset in webkit [81394] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need to explicitly run its destructor.
3:14 PM Changeset in webkit [81393] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-03-17 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Videos look ugly when using QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=56580

We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
in addition of what could be set on the painter. In order to not break the rendering of all the items in the
scene we set back the painter to its original state when QGraphicsWebView is rendered.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::paint): (QGraphicsWebView::renderHints): (QGraphicsWebView::setRenderHints): (QGraphicsWebView::setRenderHint):
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::renderHints):
3:04 PM Changeset in webkit [81392] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginProcessShim hooks for when windows are shown and hidden
​https://bugs.webkit.org/show_bug.cgi?id=56597

  • Configurations/PluginProcessShim.xcconfig: Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::cocoaWindowShown): (WebKit::cocoaWindowHidden): (WebKit::carbonWindowShown): (WebKit::carbonWindowHidden): (WebKit::setModal): (WebKit::PluginProcess::initializeShim): Add empty stubs.
  • PluginProcess/mac/PluginProcessShim.h:
  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::beginModal): (WebKit::endModal): Keep a modal count and call setModal accordingly.

(WebKit::shim_NSApplication_RunModalForWindow):
(WebKit::shimModalDialog):
(WebKit::shimAlert):
Call beginModal/endModal.

(WebKit::shimShowWindow):
(WebKit::shimHideWindow):
Call the shim functions.


(WebKit::WebKitPluginProcessShimInitialize):
Listen for notifications and call the necessary shim functions.

  • WebKit2.xcodeproj/project.pbxproj: Link the plug-in process shim with AppKit and QuartzCore and WKSI.
3:02 PM Changeset in webkit [81391] by Adam Roben
  • 2 edits
    2 moves in trunk/LayoutTests

Disable http/tests/inspector/network tests

They are known to be flaky. <​http://webkit.org/b/56578> tracks the issue.

  • http/tests/inspector/network/network-size.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-size.html.
  • http/tests/inspector/network/network-timing.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html.
  • platform/mac/Skipped: Removed a now-disabled test.
3:00 PM Changeset in webkit [81390] by Adam Roben
  • 4 edits in trunk/Tools

Start using PlatformSpecificScheduler for the Mac builders

The current set of file/directory patterns should work for Mac builders. We may discover
that there are more files and directories we can exclude from the Mac builds, but they can
be added later.

Fixes <​http://webkit.org/b/56593> Mac builders do lots of unnecessary builds

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two

PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
cleaned up patterns a little bit.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Fixed some expected results.
(ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
platforms.

2:51 PM Changeset in webkit [81389] by jeffm@apple.com
  • 25 edits in trunk

Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:

*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2:45 PM Changeset in webkit [81388] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac build.

  • WebCore.exp.in:

Add missing symbol.

2:25 PM Changeset in webkit [81387] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
​https://bugs.webkit.org/show_bug.cgi?id=56592

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.h:

Special case encoding/decoding of ResourceErrors for the mac.

  • Shared/mac/PlatformCertificateInfo.h:
  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.

2:21 PM Changeset in webkit [81386] by Adam Roben
  • 2 edits in trunk/Tools

Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows

Fixes <​http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
mac-wk2

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
we're running in WebKit2 mode.

2:03 PM Changeset in webkit [81385] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKWindowWillOrderOffScreenNotification.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
1:49 PM Changeset in webkit [81384] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adele Peterson and Enrica Casucci.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Debug build fix.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate a position inside the node. Call firstPositionInOrBeforeNode instead.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead of just when the node is br.
  • editing/htmlediting.cpp: (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.
1:44 PM Changeset in webkit [81383] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test_expectations.txt

Mark some tests as SLOW in DEBUG since they are on a borderline of shorter timeout.

  • platform/chromium/test_expectations.txt:
1:43 PM Changeset in webkit [81382] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky test on Mac

<​http://webkit.org/b/56578> tracks the failure.

  • platform/mac/Skipped: Added http/tests/inspector/network/network-size.html.
1:30 PM Changeset in webkit [81381] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some flaky tests on the SnowLeopard WebKit2 bot

Tracked by <​http://webkit.org/b/56530> and <​http://webkit.org/b/56584>.

  • platform/mac-wk2/Skipped: Added http/tests/inspector/resource-har-conversion.html and

inspector/debugger/debug-inlined-scripts.html.

1:22 PM Changeset in webkit [81380] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Reverting r81197, breaks JIT + INTERPRETER build.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):

  • bytecode/Opcode.h:
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

1:07 PM Changeset in webkit [81379] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

Add a COMPILER(SUNCC) define for Sun Studio 12.
​https://bugs.webkit.org/show_bug.cgi?56444
derived from patch 1 of 16 originally from ​https://bugs.webkit.org/show_bug.cgi?id=24932

  • wtf/Platform.h:
12:50 PM Changeset in webkit [81378] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [81377] by jcivelli@chromium.org
  • 10 edits
    8 adds in trunk/Source

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::::operator): (WTF::::contains):

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:14 PM Changeset in webkit [81376] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [81375] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceForURL): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
12:02 PM Changeset in webkit [81374] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added a test to ensure WebKit lets users edit contents inside a button element properly.

  • editing/execCommand/button-expected.txt: Added.
  • editing/execCommand/button.html: Added.

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
places where we instantiate positions inside a node on which editingIgnoresContent returns true.

Test: editing/execCommand/button.html

  • dom/Position.cpp: (WebCore::Position::Position): Added an assertion. (WebCore::Position::moveToPosition): Ditto.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below a node whose content is ignored by editing. While this does not avoid creation of positions inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve the underlying problem. Without this change, the assertion hits in existing layout tests. cannot be tested directly.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode instead of firstPositionInNode because startNode may as well be a br element. Without this change, the assertion hits in existing layout tests.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test for this.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Added a FIXME. (WebCore::startPositionForLine): Because br can also have an inline text box, checking that startBox is an inline text box isn't an adequate to instantiate a position inside startNode. Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout tests.
11:45 AM Changeset in webkit [81373] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip three tests that fail on one Windows WebKit2 slave but not the other

The failures are tracked by <​http://webkit.org/b/56550>.

  • platform/win-wk2/Skipped: Added fast/events/tabindex-focus-blur-all.html,

fast/forms/button-align.html, and media/audio-mpeg4-supported.html.

11:41 AM Changeset in webkit [81372] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.

11:39 AM Changeset in webkit [81371] by andersca@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Rename PluginProcessShim.cpp to PluginProcessShim.mm.

Rubber-stamped by John Sullivan.

  • PluginProcess/mac/PluginProcessShim.cpp: Removed.
  • PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
  • WebKit2.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [81370] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Invalidate all NPObjects for a plug-in when that plug-in is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=56511
<rdar://problem/8993491>

Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
tried to invoke it on a already deallocated NPObject.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.

(WebKit::PluginControllerProxy::destroy):
Pass the plug-in to removePluginControllerProxy.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

(WebKit::WebProcessConnection::createPlugin):
Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
takes care of doing this.

  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
  • Shared/Plugins/NPObjectMessageReceiver.h: Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated by the time the NPObjectMessageReceiver is destroyed.

(WebKit::NPObjectMessageReceiver::plugin):
Add getter.


  • Shared/Plugins/NPObjectProxy.h: (WebKit::NPObjectProxy::plugin): Add getter.


  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::NPRemoteObjectMap): Remove m_isInvalidating.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Simplify code.

(WebKit::NPRemoteObjectMap::pluginDestroyed):
Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.

  • Shared/Plugins/NPRemoteObjectMap.h: Remove m_isInvalidating.


  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::removePluginProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.
11:14 AM Changeset in webkit [81369] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
11:10 AM Changeset in webkit [81368] by pfeldman@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-03-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add types markup to the IDL, remove Value types from the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=56562

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::makeCall): (WebCore::InjectedScript::makeObjectCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::addRule):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/ScriptCallStack.cpp: (WebCore::ScriptCallStack::buildInspectorArray):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._createResource):
11:07 AM Changeset in webkit [81367] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

changelog

11:07 AM Changeset in webkit [81366] by simonjam@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

first changes

10:53 AM Changeset in webkit [81365] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] don't concatenate devtools files when debug_devtools=1
​https://bugs.webkit.org/show_bug.cgi?id=56572

  • WebKit.gyp:
10:41 AM Changeset in webkit [81364] by jorlow@chromium.org
  • 4 edits
    2 copies in branches/chromium/696/Source/WebCore

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

Patch by David Grogan <​dgrogan@chromium.org> on 2011-03-15
Reviewed by Jeremy Orlow.

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove

its reference to IDBDatabase, which it has as type
IDBDatabaseCallbacks.

  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes

a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::open):

  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h:

(WebCore::IDBDatabaseCallbacks::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
Merge 81181 - 2011-03-15 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):

TBR=​commit-queue@webkit.org

10:35 AM Changeset in webkit [81363] by Adam Roben
  • 2 edits
    1 move in trunk/LayoutTests

Disable http/tests/inspector/resource-parameters.html

It is flaky. The flakiness is tracked by <​http://webkit.org/b/55867>.

  • http/tests/inspector/resource-parameters.html-disabled: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html.
  • platform/qt/Skipped: Removed the test from this Skipped file since it has been disabled.
10:03 AM Changeset in webkit [81362] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-17 Oleg Romashin <​oleg.romashin@nokia.com>

Reviewed by Anders Carlsson.

Teach WebKit2 messages.py generator to ifdef headers include
which are related to ifdef-ed methods/types
​https://bugs.webkit.org/show_bug.cgi?id=55658

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
9:47 AM Changeset in webkit [81361] by commit-queue@webkit.org
  • 12 edits
    4 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround):
  • platform/chromium/test_expectations.txt:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillPath): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::clipPath): (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::drawQuad):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Removed.
  • platform/graphics/gpu/BicubicShader.h: Removed.
  • platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  • platform/graphics/gpu/ConvolutionShader.h: Removed.
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate):
9:44 AM Changeset in webkit [81360] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector tests timing out on Windows after r81222
​https://bugs.webkit.org/show_bug.cgi?id=56454

Remove custom expectations for Chromium tests that consistently pass locally.

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [81359] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some tests that only fail on apple-macpro-6

<​http://webkit.org/b/56564> tracks the failures.

  • platform/mac-leopard/Skipped:
9:39 AM Changeset in webkit [81358] by mnaganov@chromium.org
  • 4 edits in trunk

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

  • English.lproj/localizedStrings.js:

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

Modify the script to deal correctly with "\xNN" escapes, and to
check strings in Chromium's DevTools.js.

  • Scripts/check-inspector-strings:
9:38 AM Changeset in webkit [81357] by Adam Roben
  • 3 edits in trunk/LayoutTests

Skip a test that is only failing on some Leopard slaves

svg/text/font-size-below-point-five.svg generates different results on apple-macpro-5 from
the other Leopard slaves. <​http://webkit.org/b/56544> tracks this issue.

  • platform/mac-leopard/Skipped: Skip svg/text/font-size-below-point-five.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt: Reverted these

results to the results that all slaves except apple-macpro-5 generate.

9:26 AM Changeset in webkit [81356] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed, bad expected results were added. This fixes
the expected results and unskips the test on GTK.

[GTK] fast/viewport/viewport-131.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56556

  • fast/viewport/viewport-131-expected.txt:
  • platform/gtk/Skipped:
8:46 AM Changeset in webkit [81355] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:42 AM Changeset in webkit [81354] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: timeline-paint.html is flaky on GTK 64-bit Debug.
​https://bugs.webkit.org/show_bug.cgi?id=56554

It is not guaranteed that we receive exactly one paint event.

  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.stopTimeline):
8:35 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:32 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:18 AM Changeset in webkit [81353] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/reflections/abs-position-in-reflection.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
8:11 AM Changeset in webkit [81352] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky svg test on GTK.

  • platform/gtk/Skipped:
7:00 AM Changeset in webkit [81351] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for fast/dynamic/text-combine.html added
in r81251.

  • platform/gtk/fast/dynamic/text-combine-expected.txt: Added.
6:57 AM Changeset in webkit [81350] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
​https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
​https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
6:32 AM Changeset in webkit [81349] by apavlov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-03-17 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations

  • platform/chromium-mac/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81348] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-17 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Benjamin Poulain.

Update autoinstall to install mechanize 0.2.4
​https://bugs.webkit.org/show_bug.cgi?id=56499

Newer versions of mechanize support HTTPS proxies, which is necessary
for people using webkit-patch behind firewalls.

  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/thirdparty/init.py:
5:00 AM Changeset in webkit [81347] by kov@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

Tiled backing store should only request repaint for updated areas
​https://bugs.webkit.org/show_bug.cgi?id=56464

Reuse updateBackBuffer's dirty rectangle calculations to only
invalidate the necessary parts of the window.

  • platform/graphics/Tile.h:
  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers):
  • platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):
4:58 AM Changeset in webkit [81346] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/profiler/window-dot-eval.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
4:39 AM Changeset in webkit [81345] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] minor cleanup of devtools_files variable in WebKit.gyp
​https://bugs.webkit.org/show_bug.cgi?id=56503

  • WebKit.gyp: Moving duplicate variables out of a condition.
4:02 AM Changeset in webkit [81344] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing viewport test on GTK.

  • platform/gtk/Skipped:
3:32 AM Changeset in webkit [81343] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
​https://bugs.webkit.org/show_bug.cgi?id=56395

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotRetainerEdge): Added (WebInspector.HeapSnapshotRetainerEdgeIterator): Added (WebInspector.HeapSnapshotNode.prototype.get retainers): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.hasId): (WebInspector.HeapSnapshot.prototype.retainers): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildIdsList): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshot.prototype._findNodePositionInIndex): (WebInspector.HeapSnapshot.prototype._findNearestNodeIndex): (WebInspector.HeapSnapshot.prototype._getRetainerIndex): (WebInspector.HeapSnapshot.prototype._markInvisibleEdges): (WebInspector.HeapSnapshot.prototype._numbersComparator): (WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge): (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter): (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath): (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
2:49 AM Changeset in webkit [81342] by podivilov@chromium.org
  • 16 edits
    2 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • inspector/debugger/event-listener-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setFrontend): (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.prototype._enable): (WebInspector.EventListenerBreakpoint.prototype._disable): (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON): (WebInspector.EventListenerBreakpointView): (WebInspector.EventListenerBreakpointView.eventNameForUI): (WebInspector.EventListenerBreakpointView.prototype.get eventName): (WebInspector.EventListenerBreakpointView.prototype.compareTo): (WebInspector.EventListenerBreakpointView.prototype.populateLabelElement): (WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpointView.prototype._uiEventName):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
2:17 AM Changeset in webkit [81341] by Joseph Pecoraro
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport test for user-scalable=yes
​https://bugs.webkit.org/show_bug.cgi?id=56527

Provide tests for user-scalable no, yes, and default values.

  • fast/viewport/viewport-130-expected.txt: Added.
  • fast/viewport/viewport-130.html: Added.
  • fast/viewport/viewport-131-expected.txt: Added.
  • fast/viewport/viewport-131.html: Added.
  • fast/viewport/viewport-132-expected.txt: Copied from LayoutTests/fast/viewport/viewport-1-expected.txt.
  • fast/viewport/viewport-132.html: Added.
1:49 AM Changeset in webkit [81340] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Patrick Gansterer <Patrick Gansterer>

Fix the interpreter build.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Added globalData to inheritorID().
1:35 AM Changeset in webkit [81339] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add more ObjC++ files to the build
​https://bugs.webkit.org/show_bug.cgi?id=56548

96 link errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
1:14 AM Changeset in webkit [81338] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add transitions/default-timing-function.html to the SnowLeopard WebKit2 Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56531

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
1:10 AM Changeset in webkit [81337] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a few Objective-C++ files to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56547

464 link errors.

  • gyp/WebCore.gyp:
1:04 AM Changeset in webkit [81336] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add java/lc3/JavaObject/JavaObjectToDouble-001.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56545

Reviewed by Adam Roben.

  • This test was getting different results on different slaves.
  • platform/mac-leopard/Skipped:
12:51 AM Changeset in webkit [81335] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Yuta Kitamura <​yutak@chromium.org>

Unreviewed build fix.

Non-ASCII characters in XMLTreeViewer.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=56549

  • xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
  • xml/XMLTreeViewer.h: Ditto.
12:42 AM Changeset in webkit [81334] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add plugins and bridge to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56546

506 link errors.

  • gyp/WebCore.gyp:
12:14 AM Changeset in webkit [81333] by weinig@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

Disable fast/workers/storage/interrupt-database-sync.html due to flakiness on
multiple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=49906

Reviewed by Adam Roben.

  • fast/workers/storage/interrupt-database-sync.html: Removed.
  • fast/workers/storage/interrupt-database-sync.html-disabled: Copied from fast/workers/storage/interrupt-database-sync.html.
  • platform/qt/Skipped: Remove from qt Skipped list since it is now disabled.
12:04 AM Changeset in webkit [81332] by weinig@apple.com
  • 2 edits
    4 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Debug/Leopard Release Tester.

Reviewed by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56544
​https://bugs.webkit.org/show_bug.cgi?id=56545

  • platform/mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

Mar 16, 2011:

11:51 PM Changeset in webkit [81331] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Adding plugins/destroy-on-setwindow.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56165 was filed to track this issue.

Reviewed by Adam Roben.

  • platform/mac-leopard/Skipped:
11:39 PM Changeset in webkit [81330] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

The function setDraggingImageURL() is no longer called and can be deleted.

No new tests. Deleting dead code.

  • page/DragController.h:

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

Page is always nil at this point, because [self _webView] is nil,
so the conditional code is never run.

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
11:34 PM Changeset in webkit [81329] by weinig@apple.com
  • 1 edit
    16 adds in trunk/LayoutTests

Adding new results for some failing tests on the SnowLeopard WebKit2 Tester.

Reviewed by Adam Roben; Dictated, but not read, by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56528
​https://bugs.webkit.org/show_bug.cgi?id=56530
​https://bugs.webkit.org/show_bug.cgi?id=56531
​https://bugs.webkit.org/show_bug.cgi?id=56532
​https://bugs.webkit.org/show_bug.cgi?id=56533
​https://bugs.webkit.org/show_bug.cgi?id=56537
​https://bugs.webkit.org/show_bug.cgi?id=56539

  • platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Added.
  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • platform/mac-wk2/http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • platform/mac-wk2/media/controls-without-preload-expected.txt: Added.
  • platform/mac-wk2/transitions/default-timing-function-expected.txt: Added.
11:31 PM Changeset in webkit [81328] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

  • fast/forms/script-tests/textarea-maxlength.js: (createFocusedTextAreaWithMaxLength3): Added two tests to make sure consecutive insertbreaks work correctly for textarea maxlength.
  • fast/forms/textarea-maxlength-expected.txt: Added two test results.

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

When a user presses a return key, TypingCommand::insertLineBreak() is called.
So before append a new line, check if we can add the new line.

  • editing/TypingCommand.cpp: (WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line. (WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line. (WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.
11:14 PM Changeset in webkit [81327] by weinig@apple.com
  • 2 edits in trunk/Tools

2011-03-16 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56541

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Check for an empty host in addition to a null host. This bug was introduced when porting off of the KURL code and onto the WKURLRef version.
11:12 PM Changeset in webkit [81326] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build more derived sources
​https://bugs.webkit.org/show_bug.cgi?id=56529

This patch brings us down to 597 link errors.

  • gyp/WebCore.gyp:
11:09 PM Changeset in webkit [81325] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP should build (most) remaining source files
​https://bugs.webkit.org/show_bug.cgi?id=56515

We're still not building all the files and we have 1305 link errors,
but this patch is progress.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • plugins/PluginStream.cpp:
10:38 PM Changeset in webkit [81324] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/workers/storage/interrupt-database-sync.html to the win-xp skipped list
due to intermittent failure; tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56534

  • platform/win-xp/Skipped:
10:37 PM Changeset in webkit [81323] by weinig@apple.com
  • 2 edits in trunk/Tools

Add Lucas Forschler to the list of WebKit committers.

Reviewed by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
10:22 PM Changeset in webkit [81322] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Add compositing/transitions/singular-scale-transition.html to the Skipped lists.
Seems to be the same assert that ​https://bugs.webkit.org/show_bug.cgi?id=56488 was
filed for.

  • platform/mac/Skipped:
  • platform/win/Skipped:
10:13 PM Changeset in webkit [81321] by weinig@apple.com
  • 2 edits in trunk/Tools

Reviewed upon and dictated through Adam Roben.

Escape crashing function names in results.html. This fixes an issue
when a crash involves a type with templates.

  • Scripts/old-run-webkit-tests:
9:46 PM Changeset in webkit [81320] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the interpreter build.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::privateExecute):
Remove .get()s.

9:36 PM Changeset in webkit [81319] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Update the default navigator.vendor value
​https://bugs.webkit.org/show_bug.cgi?id=56449

Reviewed by Alexey Proskuryakov.

  • page/NavigatorBase.cpp: Updated the default value of

WEBCORE_NAVIGATOR_VENDOR.

9:27 PM Changeset in webkit [81318] by Joseph Pecoraro
  • 3 edits
    1 delete in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch to update GTK expected results.
It looks like the GTK platform specific results for
some viewport tests match regular results, and there
were a few viewport tests that still needed expected
results since other platforms skip them.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-58-expected.txt:
  • fast/viewport/viewport-6-expected.txt:
  • platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-92-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-93-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-94-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-95-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-96-expected.txt: Removed.
8:56 PM Changeset in webkit [81317] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

  • platform/chromium/test_expectations.txt: premultiply-alpha test now works

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

Always update the canvas contents in copiedImage, as there's no reason
to ask for an out-of-date image.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage):
8:46 PM Changeset in webkit [81316] by abarth@webkit.org
  • 7 edits in trunk/Source

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

We added this recently when we were unsure about the stability of the
built-in UTF-8 codec. However, the codec seems to be stable, so we
don't need the macro.

  • wtf/Platform.h:

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • features.gypi:
8:46 PM Changeset in webkit [81315] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Check in new results for text-combine-image-test-expected.txt.

  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
8:07 PM Changeset in webkit [81314] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix changelog.

8:04 PM Changeset in webkit [81313] by weinig@apple.com
  • 3 edits
    8 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Release Tester.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56516
​https://bugs.webkit.org/show_bug.cgi?id=56517
​https://bugs.webkit.org/show_bug.cgi?id=56518
​https://bugs.webkit.org/show_bug.cgi?id=56519
​https://bugs.webkit.org/show_bug.cgi?id=56521
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56525

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt: Added.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
  • platform/mac-leopard/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/mac-leopard/fast/text/text-combine-image-test-expected.txt: Added.
  • platform/mac-leopard/media/controls-without-preload-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility: Added.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Added.
7:48 PM Changeset in webkit [81312] by Joseph Pecoraro
  • 122 edits in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch landing updated expected results,
which now include the userScalable value in output.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-1-expected.txt:
  • fast/viewport/viewport-10-expected.txt:
  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-104-expected.txt:
  • fast/viewport/viewport-105-expected.txt:
  • fast/viewport/viewport-106-expected.txt:
  • fast/viewport/viewport-107-expected.txt:
  • fast/viewport/viewport-108-expected.txt:
  • fast/viewport/viewport-109-expected.txt:
  • fast/viewport/viewport-11-expected.txt:
  • fast/viewport/viewport-110-expected.txt:
  • fast/viewport/viewport-111-expected.txt:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-113-expected.txt:
  • fast/viewport/viewport-114-expected.txt:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-118-expected.txt:
  • fast/viewport/viewport-119-expected.txt:
  • fast/viewport/viewport-12-expected.txt:
  • fast/viewport/viewport-120-expected.txt:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-123-expected.txt:
  • fast/viewport/viewport-124-expected.txt:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-13-expected.txt:
  • fast/viewport/viewport-14-expected.txt:
  • fast/viewport/viewport-15-expected.txt:
  • fast/viewport/viewport-16-expected.txt:
  • fast/viewport/viewport-17-expected.txt:
  • fast/viewport/viewport-18-expected.txt:
  • fast/viewport/viewport-19-expected.txt:
  • fast/viewport/viewport-2-expected.txt:
  • fast/viewport/viewport-20-expected.txt:
  • fast/viewport/viewport-21-expected.txt:
  • fast/viewport/viewport-22-expected.txt:
  • fast/viewport/viewport-23-expected.txt:
  • fast/viewport/viewport-24-expected.txt:
  • fast/viewport/viewport-25-expected.txt:
  • fast/viewport/viewport-26-expected.txt:
  • fast/viewport/viewport-27-expected.txt:
  • fast/viewport/viewport-28-expected.txt:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-3-expected.txt:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-33-expected.txt:
  • fast/viewport/viewport-34-expected.txt:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-37-expected.txt:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-4-expected.txt:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-5-expected.txt:
  • fast/viewport/viewport-50-expected.txt:
  • fast/viewport/viewport-51-expected.txt:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-56-expected.txt:
  • fast/viewport/viewport-57-expected.txt:
  • fast/viewport/viewport-59-expected.txt:
  • fast/viewport/viewport-60-expected.txt:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-7-expected.txt:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-8-expected.txt:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • fast/viewport/viewport-88-expected.txt:
  • fast/viewport/viewport-9-expected.txt:
  • fast/viewport/viewport-90-expected.txt:
  • fast/viewport/viewport-91-expected.txt:
  • fast/viewport/viewport-92-expected.txt:
  • fast/viewport/viewport-93-expected.txt:
  • fast/viewport/viewport-94-expected.txt:
  • fast/viewport/viewport-95-expected.txt:
  • fast/viewport/viewport-96-expected.txt:
  • fast/viewport/viewport-warnings-1-expected.txt:
  • fast/viewport/viewport-warnings-2-expected.txt:
  • fast/viewport/viewport-warnings-3-expected.txt:
  • fast/viewport/viewport-warnings-4-expected.txt:
  • fast/viewport/viewport-warnings-5-expected.txt:
  • fast/viewport/viewport-warnings-6-expected.txt:
7:11 PM Changeset in webkit [81311] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Make JIT build for ARM Thumb-2 with RVCT
​https://bugs.webkit.org/show_bug.cgi?id=56440

Derived from a patch by Dave Tapuska.

Also, modify the RVCT stub template to indicate that it preserves 8 byte stack alignment.

  • jit/JITStubs.cpp:
7:10 PM Changeset in webkit [81310] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] include inspector gif files in the list of resources
​https://bugs.webkit.org/show_bug.cgi?id=56504

  • scripts/generate_devtools_grd.py:
6:53 PM Changeset in webkit [81309] by Joseph Pecoraro
  • 13 edits in trunk/Source

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

This restores our behavior before r67376 the default "user-scalable"
behavior can be defined by a WebKit client if a value was not
explicitly provided in web content (via the viewport <meta> tag).
Here, all WebKit ports default to "yes" after computing
viewport arguments. However, in the future they may consider
changing the default user-scalable value based on the type
of the document being viewed, a user preference, or other reasons.

Covered by existing tests. Should be no changes.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes): be explicit about 0. (WebCore::findUserScalableValue): convert to return a float, the instance variable type.
  • dom/ViewportArguments.h: (WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the WebKit client.

Source/WebKit/efl:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • ewk/ewk_view.cpp: (ewk_view_viewport_attributes_get):

Source/WebKit/gtk:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
  • webkit/webkitviewportattributes.cpp: (webkitViewportAttributesRecompute):

Source/WebKit/qt:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.

Source/WebKit2:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
6:53 PM Changeset in webkit [81308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Chao-ying Fu <​fu@mips.com>

Reviewed by Darin Adler.

Fix MIPS build with const *void
​https://bugs.webkit.org/show_bug.cgi?id=56513

  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::store32):
6:46 PM Changeset in webkit [81307] by levin@chromium.org
  • 7 edits in trunk/LayoutTests

New baselines because the play button is now a pause button due to r81300.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-win-xp/media/controls-after-reload-expected.checksum:
  • platform/chromium-win-xp/media/controls-after-reload-expected.png:
6:05 PM Changeset in webkit [81306] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-16 Adam Barth <​abarth@webkit.org>

Update the Skipped lists to reflect the new location of these tests.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:57 PM Changeset in webkit [81305] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".

Reviewed by Dmitry Titov.

Conditional jump or move depends on uninitialised value(s)

WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)

  • page/Settings.cpp:

(WebCore::Settings::Settings):

5:49 PM Changeset in webkit [81304] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
regions does not work

Reviewed by Darin Adler.

Up until now, overlay scrollbars have always been treated in the Render Tree as if
they have a thickness of 0 because they should not affect layout. However, it is
important to consider their size when hit-testing because otherwise, we have this
bug! This patch adds a boolean parameter to overflowClipRect(),
RenderLayer::verticalScrollbarWidth(), and
RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
the actual overlay scrollbar thickness. It defaults to false and is only sent is
as true from RenderBloc::nodeAtPoint().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overflowClipRect):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderLayer.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:
5:45 PM Changeset in webkit [81303] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. Exposes no new functionality.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::isDocumentThreadableLoaderClient): (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81302] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix std::swap not found issue on mobile Qt devices.
​https://bugs.webkit.org/show_bug.cgi?id=56463

Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
on some Qt mobile devices.

No new tests: No tests needed - compilation verified manually.

  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::acquireLineBreakIterator):
5:26 PM Changeset in webkit [81301] by levin@chromium.org
  • 11 edits in trunk/LayoutTests

Update test expectations due to r81280 (media/controls-without-preload.html),
and r81285 (media-document-audio-repaint-expected).

  • platform/chromium-linux/media/controls-without-preload-expected.checksum:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
5:24 PM Changeset in webkit [81300] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Improve robustness of controls-after-reload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56491

  • media/controls-after-reload.html: Added an extra step to seek to 0 before the end of the test.
5:21 PM Changeset in webkit [81299] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Update the Skipped list.

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
5:16 PM Changeset in webkit [81298] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebGL content not shown when accelerated compositing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=56339

Removed all previously implemented WebGL code from GraphicsLayerQt
because API has changed. GraphicsContext3D provides PlatformLayer
that is added as a child of GraphicsLayer and is therefore painted
through QGraphicsView pipeline.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3DInternal::boundingRect): (WebCore::GraphicsContext3D::platformLayer): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::reshape):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToCanvas):
  • platform/graphics/qt/GraphicsLayerQt.h:
5:15 PM Changeset in webkit [81297] by abarth@webkit.org
  • 1 edit
    2 copies
    3 moves
    3 adds in trunk/LayoutTests

2011-03-16 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

LayoutTests exercising filesystem: URIs should run over HTTP to avoid weirdness related to file: URLs
​https://bugs.webkit.org/show_bug.cgi?id=56328

Moves the test for resolveLocalFileSystemURI into new "filesystem"
directory under http/tests/, and adjusts file paths appropriately.

  • fast/filesystem/resolve-uri-expected.txt: Removed.
  • fast/filesystem/resolve-uri.html: Removed.
  • fast/filesystem/script-tests/resolve-uri.js: Removed.
  • http/tests/filesystem: Added.
  • http/tests/filesystem/resolve-uri-expected.txt: Copied from LayoutTests/fast/filesystem/resolve-uri-expected.txt.
  • http/tests/filesystem/resolve-uri.html: Copied from LayoutTests/fast/filesystem/resolve-uri.html.
  • http/tests/filesystem/resources: Added.
  • http/tests/filesystem/resources/fs-test-util.js: Copied from LayoutTests/fast/filesystem/resources/fs-test-util.js.
  • http/tests/filesystem/script-tests: Added.
  • http/tests/filesystem/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/filesystem/script-tests/TEMPLATE.html.
  • http/tests/filesystem/script-tests/resolve-uri.js: Copied from LayoutTests/fast/filesystem/script-tests/resolve-uri.js.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Added new http/tests/filesystem directory to skip lists since they don't suppor the filesystem API.
5:12 PM Changeset in webkit [81296] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

NPObjectProxy and NPObjectMessageReceiver objects should know their Plugin object
​https://bugs.webkit.org/show_bug.cgi?id=56506

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::windowScriptNPObject): (WebKit::PluginControllerProxy::pluginElementNPObject): (WebKit::PluginControllerProxy::evaluate): (WebKit::PluginControllerProxy::getPluginScriptableNPObject):
  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::create): (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::invoke): (WebKit::NPObjectMessageReceiver::invokeDefault): (WebKit::NPObjectMessageReceiver::getProperty): (WebKit::NPObjectMessageReceiver::setProperty): (WebKit::NPObjectMessageReceiver::construct):
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPObjectProxy.cpp: (WebKit::NPObjectProxy::create): (WebKit::NPObjectProxy::NPObjectProxy): (WebKit::NPObjectProxy::invalidate): (WebKit::NPObjectProxy::initialize): (WebKit::NPObjectProxy::invoke): (WebKit::NPObjectProxy::invokeDefault): (WebKit::NPObjectProxy::getProperty): (WebKit::NPObjectProxy::setProperty): (WebKit::NPObjectProxy::construct):
  • Shared/Plugins/NPObjectProxy.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::createNPObjectProxy): (WebKit::NPRemoteObjectMap::registerNPObject): (WebKit::NPRemoteObjectMap::npVariantToNPVariantData): (WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
  • Shared/Plugins/NPRemoteObjectMap.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::pluginScriptableNPObject): (WebKit::PluginProxy::getWindowScriptNPObject): (WebKit::PluginProxy::getPluginElementNPObject): (WebKit::PluginProxy::evaluate):
5:03 PM Changeset in webkit [81295] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Removed nearestMailBlockquote and replaced the calls to the function by calls
to enclosingNodeOfType and highestEnclosingNodeOfType.


Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
respect editing boundaries. Added a test for the former command.

Test: editing/execCommand/break-non-editable-blockquote.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary when looking for a Mail blockquote.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::hasMatchingQuoteLevel): (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Check rule upfront to improve the performance. (WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Added a null pointer check. (WebCore::lastPositionInOrAfterNode): Ditto.
  • editing/markup.cpp: (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Added a test to ensure WebKi doesn't crash when inserting newline in quoted contents,
which is enclosed by a non-editable blockquote.

  • editing/execCommand/break-non-editable-blockquote-expected.txt: Added.
  • editing/execCommand/break-non-editable-blockquote.html: Added.
5:02 PM Changeset in webkit [81294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Adam Barth <​abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
4:56 PM Changeset in webkit [81293] by jamesr@google.com
  • 4 edits
    4 copies in branches/chromium/696

Merge 80867 - 2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding a test for rotated large layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

  • platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/huge-layer-rotated.html: Added.

2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

Test: platform/chromium/compositing/huge-layer-rotated.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:

TBR=​vangelis@chromium.org
BUG=64947

4:51 PM Changeset in webkit [81292] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=54987 Crash beneath
WebPageProxy::viewWillStartLiveResize when resizing window after web process
crashed
-and corresponding-
<rdar://problem/9037685>

Reviewed by Darin Adler.

Just need simple isValid() checks here.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

4:48 PM Changeset in webkit [81291] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-16 Jer Noble <​jer.noble@apple.com>

Reviewed by Beth Dakin.

RenderFullScreen::createFullScreenStyle() leaks
​https://bugs.webkit.org/show_bug.cgi?id=53384

Two problems: a) not calling release() on the style returned in setFullScreenRenderer
causes an unnecessary ref/deref, and b) the fullscreen renderer needs to be destroyed,
not just detached, when it is no longer needed.

  • dom/Document.cpp: (WebCore::Document::setFullScreenRenderer): Destroy the current renderer when a new one is set.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::createFullScreenStyle): release() the return value.
4:46 PM Changeset in webkit [81290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

Reestablish typeface/size/encoding when drawing stroked text
​https://bugs.webkit.org/show_bug.cgi?id=56481

No new tests. LayoutTests/svg/css/composite-shadow-text.svg

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
4:37 PM Changeset in webkit [81289] by commit-queue@webkit.org
  • 14 edits in trunk

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

No new tests needed as this defaults to disabled (and is unfeasible
to be tested through property overriding at runtime).

  • page/Settings.h: (WebCore::Settings::setForceCompositingMode): (WebCore::Settings::forceCompositingMode):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  • rendering/RenderLayerCompositor.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setForceCompositingMode):
  • src/WebSettingsImpl.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setForceCompositingMode):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
4:06 PM Changeset in webkit [81288] by vangelis@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new test for transformed layer with backface
visibility set to hidden.
​https://bugs.webkit.org/show_bug.cgi?id=56237

  • platform/chromium/compositing/backface-visibility-transformed-expected.checksum: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.txt: Added.
  • platform/chromium/compositing/backface-visibility-transformed.html: Added.

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing backface visibility for transformed layers.
​https://bugs.webkit.org/show_bug.cgi?id=56237

Test: platform/chromium/compositing/backface-visibility-transformed.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
4:01 PM Changeset in webkit [81287] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-03-16 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Kevin Decker.

Add a user default that will force all plugins to opt in to non-executable data
​https://bugs.webkit.org/show_bug.cgi?id=56487
<rdar://problem/9109095>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy):
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
3:57 PM Changeset in webkit [81286] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/js/array-sort-modifying-tostring.html on Windows because it is timing out
on Windows Debug. It is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56496.

  • platform/win/Skipped:
3:20 PM Changeset in webkit [81285] by Dimitri Glazkov
  • 3 edits
    4 adds in trunk

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics

  • fast/repaint/slider-thumb-float-expected.checksum: Added.
  • fast/repaint/slider-thumb-float-expected.png: Added.
  • fast/repaint/slider-thumb-float-expected.txt: Added.
  • fast/repaint/slider-thumb-float.html: Added.

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Technically, this is not a regression, but rather uncovering of an old
problem. When the RenderSlider::layout was written, the layout state was
pushed with a wrong offset. However, since the whole slider track was
always repainted, the problem didn't manifest itself until we actually
started being more precise in our repaints.

Test: fast/repaint/slider-thumb-float.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Changed to pass actual thumb offset to the LayoutStateMaintainer, rather than thumb size.
3:18 PM Changeset in webkit [81284] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56488
transitions/scale-transition-no-start.html is crashing.

Adding to the Skipped list.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
3:15 PM Changeset in webkit [81283] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Add play state callbacks to MediaControls, kill timeUpdate timer.
​https://bugs.webkit.org/show_bug.cgi?id=56473

No change in behavior, covered by existing tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playbackProgressTimerFired): Added a call to

media controls.

(WebCore::HTMLMediaElement::updatePlayState): Ditto.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::MediaControls): Removed initialization of the timer. (WebCore::MediaControls::playbackProgressed): Added. (WebCore::MediaControls::playbackStarted): Added, for now routing to just

call playbackProgressed.

(WebCore::MediaControls::playbackStopped): Ditto.
(WebCore::MediaControls::update): Removed the code to start/stop the

timer that's now gone.

  • html/shadow/MediaControls.h: Removed timer decls.
3:06 PM Changeset in webkit [81282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

DocumentThreadableLoaderClient needs a protected default Constructor
​https://bugs.webkit.org/show_bug.cgi?id=56479

No new tests. Exposes no new functionality.

  • loader/DocumentThreadableLoaderClient.h: (WebCore::DocumentThreadableLoaderClient::DocumentThreadableLoaderClient):
2:59 PM Changeset in webkit [81281] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt #2.

Same error as before.

  • bindings/v8/V8GCController.cpp:
2:47 PM Changeset in webkit [81280] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56489

  • media/controls-without-preload.html: Added an extra step to seek to 0 before the end of the test.
2:22 PM Changeset in webkit [81279] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Dimitri Glazkov.

Revert of r80451. Decided to do this in WebCore instead.
​https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
2:16 PM Changeset in webkit [81278] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt.

The error was 'WebCore::GrouperVisitor' has a field 'WebCore::GrouperVisitor::m_grouper' whose type uses the anonymous namespace.

  • bindings/v8/V8GCController.cpp:
2:08 PM Changeset in webkit [81277] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov and Darin Adler.

Node::isContentEditable should always call parentNode() instead of parentOrHostNode()
​https://bugs.webkit.org/show_bug.cgi?id=56472

Replaced the call to parentOrHostNode() in Node::isContentEditable by a call to parentNode().
Node::isContentEditable now calls parentNode() on all nodes.

No tests are added since this behavior change is not visible to scripts at the moment.

  • dom/Node.cpp: (WebCore::Node::isContentEditable):
2:05 PM Changeset in webkit [81276] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Remove unnecessary caller tracking shenanigans from CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=56483

This removes some leftover cruft from when we made CodeBlock
mark its callees. Removing it gives us a 0.7% progression,
reducing the overall regression to ~1.3%.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
  • jit/JIT.cpp: (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
2:04 PM Changeset in webkit [81275] by levin@chromium.org
  • 2 edits
    76 adds in trunk/LayoutTests

o Cleaned up test_expectation to remove items due to new baselines

and remove some crashes that have been fixed.

o text-combine: Added baseline following r81251.
o Everything else: Add some not so timely baselines for r77485.

  • platform/chromium-linux/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.checksum: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [81274] by Chris Fleizach
  • 14 edits in trunk/Source

WK2: Need to propagate enhanced accessibility flag from UI -> web process
​https://bugs.webkit.org/show_bug.cgi?id=56379

Reviewed by Darin Adler.

Source/WebCore:

Allow the enhanced accessibility flag to be toggleable.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Source/WebKit2:

Support sending the enhanced accessibility flag between processes.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::setEnhancedAccessibility):

  • UIProcess/WebContext.h:
  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContet::platformInvalidateContext):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setEnhancedAccessibility):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:12 PM Changeset in webkit [81273] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Buildfix after r81230.

  • WebCore.pri: Missing include path added.
1:09 PM Changeset in webkit [81272] by oliver@apple.com
  • 100 edits in trunk/Source

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make Structure::create require JSGlobalData&, and
require all users to provide the globalData.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::createStructure):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/ErrorInstance.h: (JSC::ErrorInstance::createStructure):
  • runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
  • runtime/JSByteArray.h: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::createDummyStructure):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::createStructure):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.cpp: (JSC::JSObject::createInheritorID):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSNonFinalObject::createStructure): (JSC::JSFinalObject::createStructure): (JSC::createEmptyObjectStructure): (JSC::JSObject::inheritorID):
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::createStructure):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::RopeBuilder::createStructure):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure):
  • runtime/JSZombie.h: (JSC::JSZombie::createStructure):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::createStructure):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::createStructure):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.h: (JSC::StringPrototype::createStructure):
  • runtime/Structure.h: (JSC::Structure::create):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation pass a JSGlobalData&.

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): (JSRun::JSRun):
  • JSRun.h:
  • JSUtils.cpp: (getThreadGlobalObject):
  • UserObjectImp.h: (UserObjectImp::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation use GlobalData

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h: (WebCore::JSAudioConstructor::createStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure): (WebCore::getDOMStructure):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::createStructure):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::createStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::createStructure):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h: (WebCore::JSOptionConstructor::createStructure):
  • bindings/js/JSWorkerContextBase.h: (WebCore::JSWorkerContextBase::createStructure):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.h: (JSC::Bindings::CRuntimeObject::createStructure):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaRuntimeObject.h: (JSC::Bindings::JavaRuntimeObject::createStructure):
  • bridge/objc/ObjCRuntimeObject.h: (JSC::Bindings::ObjCRuntimeObject::createStructure):
  • bridge/objc/objc_instance.mm: (ObjCRuntimeMethod::createStructure):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.h: (JSC::Bindings::RuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure):
  • Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: (WebKit::JSNPMethod::JSNPMethod):
  • WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::createStructure):
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::JSNPObject):
  • WebProcess/Plugins/Netscape/JSNPObject.h: (WebKit::JSNPObject::createStructure):
12:54 PM Changeset in webkit [81271] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/refcount-leaks.html on Windows, because it is failing in release builds,
and passing in debug. This is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56478.

  • platform/win/Skipped:
12:52 PM Changeset in webkit [81270] by rniwa@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Build fix for r81266. "expected" should appear after "mac", "unix", and "win" not before them.

  • editing/style/iframe-onload-crash-expected-mac.txt: Removed.
  • editing/style/iframe-onload-crash-expected-unix.txt: Removed.
  • editing/style/iframe-onload-crash-expected-win.txt: Removed.
  • editing/style/iframe-onload-crash-mac-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-mac.txt.
  • editing/style/iframe-onload-crash-unix-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-unix.txt.
  • editing/style/iframe-onload-crash-win-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-win.txt.
12:49 PM Changeset in webkit [81269] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
​https://bugs.webkit.org/show_bug.cgi?id=56477
<rdar://problem/8806664>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Set NSApplication current event when re-dispatching a key event that returned from the web process unhandled. That way, code that looks at current event modifiers won't be confused.
12:47 PM Changeset in webkit [81268] by psolanki@apple.com
  • 2 edits in trunk/LayoutTests

Fix typo in path name. The test was just checking for onProgress was called for the content
and the error page served by Apache in this case sufficed for it to pass.

Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:
12:28 PM Changeset in webkit [81267] by psolanki@apple.com
  • 4 edits
    3 adds in trunk

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add test that verifies the we don't crash when an XHR response headers don't contain
Content-Type.

  • http/tests/xmlhttprequest/resources/.htaccess:
  • http/tests/xmlhttprequest/resources/noContentType.asis: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html: Added.

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add NULL check for Content-Type header field.

Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html

  • platform/network/mac/WebCoreURLResponse.mm: (WebCore::adjustMIMETypeIfNecessary):
12:18 PM Changeset in webkit [81266] by leviw@chromium.org
  • 7 edits
    4 copies
    2 moves in trunk

2011-03-16 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Creating three versions of the iframe-onload-crash test to cover all editing behaviors.

  • editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected.txt: Removed.
  • editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2011-03-15 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
have had children appended to them that editing wouldn't normally allow.

Tests: editing/style/iframe-onload-crash-mac.html

editing/style/iframe-onload-crash-unix.html
editing/style/iframe-onload-crash-win.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children for hr and datagrid, as you can append any node to another using javascript.
11:46 AM Changeset in webkit [81265] by mnaganov@chromium.org
  • 15 edits
    3 copies in trunk/Source/WebCore

2011-03-16 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Report object groups and single DOM-related objects
to the new heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=53659

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/RetainedDOMInfo.cpp: Added. (WebCore::RetainedDOMInfo::RetainedDOMInfo):
  • bindings/v8/RetainedDOMInfo.h: Added.
  • bindings/v8/RetainedObjectInfo.h: Added.
  • bindings/v8/ScriptProfiler.cpp: (WebCore::retainedDOMInfo): (WebCore::ScriptProfiler::initialize):
  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8GCController.cpp: (WebCore::GroupId::GrouperItem::GrouperItem): (WebCore::GroupId::GrouperItem::groupId): (WebCore::GroupId::GrouperItem::createRetainedObjectInfo): (WebCore::calculateGroupId): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping):
  • bindings/v8/WrapperTypeInfo.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot): (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
  • inspector/front-end/heapProfiler.css: (.detailed-heapshot-view .retaining-paths-view .title > span): (.detailed-heapshot-view .retaining-paths-to-windows):
11:43 AM Changeset in webkit [81264] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Skip test fast/forms/input-autofilled.html in mac-wk2 since
layoutTestController.setAutofilled is not yet supported.

  • platform/mac-wk2/Skipped:
11:37 AM Changeset in webkit [81263] by weinig@apple.com
  • 12 edits in trunk/Source

Add WebKit2 API to figure out if an input or textarea was edited
​https://bugs.webkit.org/show_bug.cgi?id=56474

Reviewed by Adam Roben.

Source/WebCore:

Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
as well as API in WebKit2.

  • WebCore.exp.in:
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::lastChangeWasUserEdit):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):

  • html/HTMLTextAreaElement.h:

Source/WebKit2:

Expose WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit and
WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit. Next time,
I will work on giving these functions longer names.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit):
(WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
11:35 AM Changeset in webkit [81262] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Some conservative root gathering cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56447


SunSpider says 0.5% - 1.8% faster.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots):
  • interpreter/RegisterFile.h: New helper function for doing the conservative gathering of the register file. It's still conservative, since the register file may contain uninitialized values, but it's moving-safe, because it only visits values tagged as pointers, so there's no risk of mistaking an integer for a pointer and accidentally changing it.
  • runtime/ConservativeSet.cpp: (JSC::ConservativeRoots::add):
  • runtime/ConservativeSet.h: Added a single-value add function, used above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Separated machine stack conservative roots from register file conservative roots because machine stack roots must be pinned, but register file roots need not be pinned.


Adopted new interface for passing the current stack extent to the machine
stack root gathering routine. This allows us to exclude marking-related
data structures on the stack, and thus avoid double-marking the set of
machine roots.

  • runtime/MachineStackMarker.cpp: (JSC::MachineThreads::gatherFromCurrentThread): (JSC::MachineThreads::gatherConservativeRoots):
  • runtime/MachineStackMarker.h: Added new interface, described above.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::firstAtom):
  • wtf/StdLibExtras.h: (WTF::roundUpToMultipleOf): Moved roundUpToMultipleOf so it could be used by MachineStacks.
11:16 AM Changeset in webkit [81261] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little bit of MarkStack cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56443


Moved MarkStack functions into MarkStack.h/.cpp.


SunSpider reports no change.

  • runtime/JSArray.h:
  • runtime/JSCell.h: Moved from here...
  • runtime/MarkStack.cpp: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain): ...to here. Also, no need to inline drain. It's a huge function, and not called many times.
  • runtime/MarkStack.h: (JSC::MarkStack::~MarkStack): Moved near constructor, per style guide. (JSC::MarkStack::append): (JSC::MarkStack::deprecatedAppend): (JSC::MarkStack::internalAppend): Moved to here.
11:07 AM Changeset in webkit [81260] by bweinstein@apple.com
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

More cleanup of expected results files for text combine tests from r81255.

  • platform/win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/win/fast/dynamic/text-combine-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:


  • platform/win/fast/international: Removed. This was the wrong directory.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Removed. This was the wrong directory.
11:01 AM Changeset in webkit [81259] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
​https://bugs.webkit.org/show_bug.cgi?id=56376

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
10:58 AM Changeset in webkit [81258] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix live-edit test broken by r81238.

  • inspector/debugger/live-edit.html:
10:58 AM Changeset in webkit [81257] by xji@chromium.org
  • 6 edits in branches/chromium/696/Source/WebCore

Merge 80757 - Regression: Content not drawn when scrolling horizontally in an RTL page
​https://bugs.webkit.org/show_bug.cgi?id=55077

Reviewed by David Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.

  • platform/ScrollView.h:
  • rendering/RenderLayer.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.

TBR=​weinig@apple.com

10:47 AM Changeset in webkit [81256] by bweinstein@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Make the files added -expected.txt instead of -actual.txt so run-webkit-tests
will actually find them.

  • platform/win/fast/dynamic/text-combine-actual.txt: Removed.
  • platform/win/fast/dynamic/text-combine-expected.txt: Copied from platform/win/fast/dynamic/text-combine-actual.txt.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Removed.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Copied from platform/win/fast/international/text-combine-image-test-actual.txt.
10:44 AM Changeset in webkit [81255] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for text combine tests.

  • platform/win/fast/dynamic/text-combine-actual.txt: Added.
  • platform/win/fast/international: Added.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Added.
10:22 AM Changeset in webkit [81254] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list because of missing test fonts.

  • platform/qt/Skipped:
9:52 AM Changeset in webkit [81253] by Csaba Osztrogonác
  • 2 edits
    27 adds in trunk/LayoutTests

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Add Qt specific expected files after r81168.

  • platform/qt/Skipped: Add new tests because of missing test fonts.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
9:38 AM Changeset in webkit [81252] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56467
IconDatabase-related crash seen in WK2 tests

Reviewed by Adam Roben.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL): The IconLoader might set a null data for an icon, so handle that case.

9:27 AM Changeset in webkit [81251] by mitz@apple.com
  • 5 edits
    4 adds in trunk

text-combine text retains compressed font after adding characters to it
​https://bugs.webkit.org/show_bug.cgi?id=56448

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/text-combine.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
only the clones on the RenderCombineText will be mutated.

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
style.
(WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
the text cannot be combined.

  • rendering/RenderCombineText.h:

(WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.

LayoutTests:

  • fast/dynamic/text-combine.html: Added.
  • platform/mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/mac/fast/dynamic/text-combine-expected.txt: Added.
9:25 AM Changeset in webkit [81250] by Adam Roben
  • 3 edits
    1 move in trunk/LayoutTests

Disable jquery/effects.html

It often times out due to its sheer size. The failure is tracked by
<​http://webkit.org/b/56080>.

  • jquery/effects.html-disabled: Renamed from LayoutTests/jquery/effects.html.
  • platform/gtk/Skipped:
  • platform/win-xp/Skipped:

Unskipped the test since we're now disabling it via other means.

9:06 AM Changeset in webkit [81249] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping one more svg test failing on 32-bits release,
likely due to bug 39022.

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [81248] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/text/soft-hyphen-4.html introduced in r80984
and fails because hyphenation isn't implemented yet.

  • platform/qt/Skipped: Add fast/text/soft-hyphen-4.html.
8:47 AM Changeset in webkit [81247] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip svg/W3C-I18N tests failing on 32-bits Debug only.

  • platform/gtk/Skipped:
8:41 AM Changeset in webkit [81246] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip editing/style/iframe-onload-crash.html on GTK.

  • platform/gtk/Skipped:
8:34 AM Changeset in webkit [81245] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Update Qt specific expected file after r81049.

  • platform/qt/fast/table/overflowHidden-expected.txt: Updated.
8:24 AM Changeset in webkit [81244] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix test broken by r81238.

  • inspector/debugger/live-edit.html:
  • platform/chromium/test_expectations.txt:
8:03 AM Changeset in webkit [81243] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:00 AM Changeset in webkit [81242] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Minor clean-up after r81156, r81172

Follow-up for:
<​http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

  • platform/graphics/GraphicsLayer.h: Removed unused @class

WebLayer declaration.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

struct CAPropertyAnimation to class declaration.

7:49 AM Changeset in webkit [81241] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations.
Fix Linux Debug expectation clash for transitions/interrupted-accelerated-transition.html.
Let svg/text/font-size-below-point-five.svg fail on Mac Release.

  • platform/chromium/test_expectations.txt:
6:13 AM Changeset in webkit [81240] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, remove duplicate expectations.

  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81239] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: inspector/elements/mutate-unknown-node.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56457

  • platform/qt/Skipped: Add inspector/elements/mutate-unknown-node.html.
4:48 AM Changeset in webkit [81238] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove live-edit code
​https://bugs.webkit.org/show_bug.cgi?id=56177

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._doubleClick):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:21 AM Changeset in webkit [81237] by benjamin.poulain@nokia.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

2011-03-16 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Loading an empty URL crashes
​https://bugs.webkit.org/show_bug.cgi?id=55501

A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code
of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is.

This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter
ensure the returned string is a valid null string.

Tested through the Qt API tests.

  • UIProcess/API/C/WKPage.cpp: (WKPageLoadURL):
  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyUrl):
  • UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added.
  • UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added. (tst_QWKPage::init): (tst_QWKPage::cleanup): (tst_QWKPage::loadEmptyUrl):
  • UIProcess/API/qt/tests/tests.pro:
4:09 AM Changeset in webkit [81236] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Typo fix after r81226.

  • platform/qt/Skipped: Remove unnecessary "#".
4:05 AM Changeset in webkit [81235] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, suppress Win builder failures from r81222.
Also, one tentatively stale suppression is removed.

  • platform/chromium/test_expectations.txt:
3:40 AM Changeset in webkit [81234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Martin Robinson.

[GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
​https://bugs.webkit.org/show_bug.cgi?id=56403

In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
i.e the pause() made when beginScrubbing is done is just internal.

No new tests: Verified manually.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
3:39 AM Changeset in webkit [81233] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56242
Flaky Test: transitions/interrupted-accelerated-transition.html

Skip this while ​https://bugs.webkit.org/show_bug.cgi?id=54151
(Animation API) is in progress.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
2:44 AM Changeset in webkit [81232] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
​https://bugs.webkit.org/show_bug.cgi?id=36467

Removing the test from skipped list since the problem seems to be solved.

  • platform/qt/Skipped:
2:00 AM Changeset in webkit [81231] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/audio-repaint.html times out again
​https://bugs.webkit.org/show_bug.cgi?id=56366

Rewrote the test to avoid a timer and attempt the seek on media
elements only after we are sure playback started to avoid an
INVALID_STATE_ERR exception.

  • media/audio-repaint.html:
1:58 AM Changeset in webkit [81230] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build platform/
​https://bugs.webkit.org/show_bug.cgi?id=56430

Adding platform/ to the GYP build required disabling
ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent
style issues. I suspect we'll end up excluding some of these files
from the build in the final analysis, but we might as well fix the
style errors while we're here.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/ScheduledAction.h:
  • css/CSSPrimitiveValueCache.cpp:
  • gyp/WebCore.gyp:
  • platform/KillRingNone.cpp: (WebCore::KillRing::append): (WebCore::KillRing::prepend):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp: (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::TessellationState::combineCallback):
  • platform/graphics/gpu/PODRedBlackTree.h: (WebCore::PODRedBlackTree::updateNode): (WebCore::PODRedBlackTree::logIfVerbose):
  • platform/graphics/opengl/TextureMapperGL.cpp:
  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::save): (WebCore::TextureMapper::paintToTarget):
  • platform/graphics/texmap/TextureMapperNode.h:
1:56 AM Changeset in webkit [81229] by Philippe Normand
  • 4 edits in trunk

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Let the mediaPlayerClient handle the stream error, in this case the HTMLMediaElement will emit a stalled event.

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/gtk/Skipped: Unskip fixed test.
1:52 AM Changeset in webkit [81228] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

2011-03-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] Frame accurate seeking isn't always accurate
​https://bugs.webkit.org/show_bug.cgi?id=55217

Attempt to build the seek GstClockTime position by converting the
float time value to a GTimeVal value rounded at microsecond
precision. Additionally perform the seek with the ACCURATE seek
flag. These modifications at least fix this manual-test:
​http://www.massive-interactive.nl/html5_video/smpte_test_universal.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
1:18 AM Changeset in webkit [81227] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Qt] Some inspector test fail intermittently
​https://bugs.webkit.org/show_bug.cgi?id=42090

Unskip a bunch of non-http inspector tests on Qt. All these tests pass locally.

  • platform/qt/Skipped:
1:14 AM Changeset in webkit [81226] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list.

  • platform/qt/Skipped:
    • Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled().
    • Add fast/workers/shared-worker-frame-lifecycle.html because it is still flakey. (bug 34281)
12:51 AM Changeset in webkit [81225] by hayato@chromium.org
  • 2 edits in trunk/Tools

2011-03-15 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

Ignore files that will be used by reftests in old-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=55936

  • Scripts/old-run-webkit-tests:
Note: See TracTimeline for information about the timeline view.