⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 19, 2011:

8:39 PM Changeset in webkit [81564] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Dan Bernstein.

Add stub to LayoutTestControllerGtk.cpp to fix GTK build
​https://bugs.webkit.org/show_bug.cgi?id=56719

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
5:57 PM Changeset in webkit [81563] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove StringImpl::computeHash()
​https://bugs.webkit.org/show_bug.cgi?id=49894

Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.

  • wtf/text/AtomicString.cpp: (WTF::CStringTranslator::hash): (WTF::UCharBufferTranslator::hash): (WTF::HashAndCharactersTranslator::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::setHash): (WTF::StringImpl::hash):
3:36 PM Changeset in webkit [81562] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()

The function doesn't ignore anything, thus it shouldn't have an imperative name.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::shouldIgnoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3:18 PM Changeset in webkit [81561] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Kill layer violation FIXME in ResourceHandleQt.

We were including qwebframe_p.h from WebKit/qt for no reason.

  • platform/network/qt/ResourceHandleQt.cpp:
3:15 PM Changeset in webkit [81560] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Refactor handling of deferred loads
​https://bugs.webkit.org/show_bug.cgi?id=56715

Split QNetworkReplyHandler's "load mode" into two parameters
instead of trying to fit the deferral mechanism into it.

Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadingDeferred): (WebCore::QNetworkReplyHandler::resumeDeferredLoad): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::resetState):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::platformSetDefersLoading):
3:08 PM Changeset in webkit [81559] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

3:07 PM Changeset in webkit [81558] by mrowe@apple.com
  • 1 copy in tags/Safari-533.21.1

New tag.

2:28 PM Changeset in webkit [81557] by commit-queue@webkit.org
  • 26 edits
    4 adds in trunk

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

This test creates an Application Cache for the DRT origin, deletes it for the origin,
and verifies that the Application Cache has obsolete status.

  • http/tests/appcache/origin-delete-expected.txt: Added.
  • http/tests/appcache/origin-delete.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

To delete all Application Cache for an origin, we must obsolete all
in-memory cache groups for that origin. If a cache group isn't in memory,
then it must be deleted from disk. The previous implementation correctly
removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
when the DocumentLoader was destroyed.

Test: http/tests/appcache/origin-delete.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::clearStorageID): (WebCore::ApplicationCache::deleteCacheForOrigin):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

Use new ApplicationCache API to delete all cache for an origin.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteOrigin:]):

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin instead of ApplicationCacheStorage::deleteEntriesForOrigin. (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

  • DumpRenderTree/LayoutTestController.cpp: (clearApplicationCacheForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs. (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
1:11 PM Changeset in webkit [81556] by gyuyoung.kim@samsung.com
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-03-19 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy GeolocationServiceEfl. cpp | h
​https://bugs.webkit.org/show_bug.cgi?id=56710

Add dummy GeolocationServiceEfl.cpp | h to platform/efl.

  • CMakeListsEfl.txt:
  • platform/efl/GeolocationServiceEfl.cpp: Added. (WebCore::GeolocationServiceEfl::create): (WebCore::GeolocationServiceEfl::GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::startUpdating): (WebCore::GeolocationServiceEfl::stopUpdating): (WebCore::GeolocationServiceEfl::suspend): (WebCore::GeolocationServiceEfl::resume): (WebCore::GeolocationServiceEfl::lastPosition): (WebCore::GeolocationServiceEfl::lastError):
  • platform/efl/GeolocationServiceEfl.h: Added.
1:09 PM Changeset in webkit [81555] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Unreviewed, rolling out r81551.
​http://trac.webkit.org/changeset/81551
​https://bugs.webkit.org/show_bug.cgi?id=55336

Broke some storage tests on Win32.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
12:22 PM Changeset in webkit [81554] by simonjam@chromium.org
  • 3 edits
    6 deletes in trunk/LayoutTests

2011-03-19 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81528.

  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
12:07 PM Changeset in webkit [81553] by andreas.kling@nokia.com
  • 18 edits in trunk/Source

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
​https://bugs.webkit.org/show_bug.cgi?id=56712

  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::positionUpdated):

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
​https://bugs.webkit.org/show_bug.cgi?id=56712

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::selectionRectForSimpleText):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::paint):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::DnsPrefetchHelper): (WebCore::DnsPrefetchHelper::lookup):
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaSliderTrack):
11:35 AM Changeset in webkit [81552] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
​https://bugs.webkit.org/show_bug.cgi?id=56711

Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
ownership of the reply is transferred to the receiving slot.

  • Api/qwebpage.cpp:
10:55 AM Changeset in webkit [81551] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use Win32 API to get file information
​https://bugs.webkit.org/show_bug.cgi?id=55336

Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
and GetFileAttributesEx() so we can share the code with WinCE.

  • platform/win/FileSystemWin.cpp: (WebCore::createFileHandle): (WebCore::getFileInformation): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
7:25 AM Changeset in webkit [81550] by xan@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-19 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify GObjectEventListener
​https://bugs.webkit.org/show_bug.cgi?id=56698

Get rid of special case for DOMWindow, since it's also an
EventTarget.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): remove DOMWindow special casing. (WebCore::GObjectEventListener::~GObjectEventListener): ditto. (WebCore::GObjectEventListener::gobjectDestroyed):
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): ditto. (WebCore::GObjectEventListener::removeEventListener): ditto.
6:08 AM Changeset in webkit [81549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-19 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=56195
Fix conditional which had an int for one case and a pointer for another.
Similar fix as ​https://bugs.webkit.org/show_bug.cgi?id=56198

No new tests. Fix compilation on Solaris 10 with Sun Studio C++

  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
4:42 AM Changeset in webkit [81548] by Patrick Gansterer
  • 26 edits in trunk/Source

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
​https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
  • wtf/StringHasher.h: (WTF::StringHasher::computeHash): (WTF::StringHasher::hashMemory):
  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
​https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents):
  • dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):

Mar 18, 2011:

9:52 PM Changeset in webkit [81547] by mitz@apple.com
  • 3 edits in trunk/Tools

Revised build fix for r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
8:58 PM Changeset in webkit [81546] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/56688> Fix clang static analyzer warning in WebCoreViewFactory.m

Reviewed by Anders Carlsson.

Fixes the following static analyzer warning:

Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]'

return self;

  • page/mac/WebCoreViewFactory.m:

(-[WebCoreViewFactory init]): Assign the result of [super init]
to self.

7:18 PM Changeset in webkit [81545] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the WinCairo build.

  • win/WebKit2.vcproj:
7:17 PM Changeset in webkit [81544] by jamesr@google.com
  • 206 edits
    2 adds in trunk/LayoutTests

2011-03-18 James Robinson <​jamesr@chromium.org>

Update chromium win pixel baselines for tests with justified text for r81528

  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-win/css1/text_properties/text_align-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.checksum:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.checksum:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.checksum:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.checksum:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.checksum:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.checksum:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.checksum:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.checksum:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum:
  • platform/chromium-win/svg/text/bidi-tspans-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [81543] by cevans@google.com
  • 7 edits in branches/chromium/696

Merge 81399
BUG=74653

6:04 PM Changeset in webkit [81542] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/696

Merge 81088
BUG=75347

6:02 PM Changeset in webkit [81541] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/696

Merge 80773
BUG=75347

5:51 PM Changeset in webkit [81540] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build
​https://bugs.webkit.org/show_bug.cgi?id=56696

After this patch, the WebCore GYP build successfully compiles and
links. I haven't trying executing it yet.

  • WebCore.gypi:
    • DOMMouseEvent should be included as part of the Objective-C bindings.
  • WebCore.xcodeproj/project.pbxproj:
    • RenderSVGPath.cpp was mistakenly included directly in the project instead of being built by RenderSVGAllInOne.
  • gyp/WebCore.gyp:
    • Exclude some more files from the build. These files are absent in the normal build. I didn't see them earlier because the dead code stripping was hiding them. (They're probably unreferenced.)
    • Switch to using RenderSVGAllInOne. I'm not entirely sure if this part of the patch is necessary, but it matches the normal build more closely.
  • platform/mac/WebCoreObjCExtras.mm:
    • The normal build passes the -Wdeprecated-declarations flag when compiling this file. The GYP folks explicitly do not want to add that feature to GYP, and there does not appear to be a way to remove the deprecated call from this file.
  • rendering/svg/RenderSVGAllInOne.cpp:
    • Add RenderSVGPath.cpp, which was missing previously.
5:48 PM Changeset in webkit [81539] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should (almost!) link
​https://bugs.webkit.org/show_bug.cgi?id=56689

This patch is a grab-bag of small changes to bring the WebCore GYP
build down to two link errors or one compile error (take your pick).
We might need a GYP change to get this last file to compile, however.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
5:31 PM Changeset in webkit [81538] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-03-18 James Robinson <​jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [81537] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
​https://bugs.webkit.org/show_bug.cgi?id=56505

Added a test to edit contents of hr and datagrid and object's fallback content.

  • editing/editability/ignored-content-expected.txt: Added.
  • editing/editability/ignored-content.html: Added.

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
​https://bugs.webkit.org/show_bug.cgi?id=56505

The bug was caused by canHaveChildrenForEditing's always returning false even when
object element used fallback content. Fixed the bug by adding a check.

Test: editing/editability/ignored-content.html

  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
5:05 PM Changeset in webkit [81536] by aestes@apple.com
  • 5 edits
    2 adds in trunk

2011-03-18 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
​https://bugs.webkit.org/show_bug.cgi?id=56380

  • fast/parser/fragment-foreign-content-context-expected.txt: Added.
  • fast/parser/fragment-foreign-content-context.html: Added.

2011-03-18 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
​https://bugs.webkit.org/show_bug.cgi?id=56380


Fix two issues with parsing a fragment that has a foreign content
element as its context element. The first issue is that the parser will
initially be in the InForeignContentMode insertion mode when processing
the first tag in the fragment in this case so one call site needs to
change from currentElement() to currentNode(). The second issue is that
when we changed fragments from using a fake HTML root element to a
DocumentFragment we broke checks that assumed the root element was in
the HTML namespace. Fix this by claiming that the DocumentFragment is
also in the HTML namespace.

Test: fast/parser/fragment-foreign-content-context.html

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
  • html/parser/HTMLElementStack.h: (WebCore::isInHTMLNamespace):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag):
4:36 PM Changeset in webkit [81535] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Empty gray page after going back from a PDF
​https://bugs.webkit.org/show_bug.cgi?id=56694
<rdar://problem/8811854>

Update m_frameHasCustomRepresentation when loading a page that's in the page cache.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
4:36 PM Changeset in webkit [81534] by mrowe@apple.com
  • 2 edits in branches/safari-533.21-branch/WebCore

Merge r80787.

4:36 PM Changeset in webkit [81533] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.21-branch

Merge r79689.

4:30 PM Changeset in webkit [81532] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-18 Martin Robinson <​mrobinson@igalia.com>

[GTK] JSC crashes in 32bit Release bots after r80743
​https://bugs.webkit.org/show_bug.cgi?id=56180

  • platform/gtk/Skipped: Unskip tests which should now be passing since this bug is fixed.
4:24 PM Changeset in webkit [81531] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Windows Release Tests] media tests crashing in QuickTime on apple-windows-8.
​https://bugs.webkit.org/show_bug.cgi?id=56653

Unreviewed, skipping media/video-load-readyState.html since that has been crashing
on the last 3 runs.

  • platform/win-wk2/Skipped:
4:19 PM Changeset in webkit [81530] by jamesr@google.com
  • 4 edits in branches/chromium/696

Merge 81528 - 2011-03-18 James Robinson <​jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
​https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):

TBR=​jamesr@google.com
BUG=75169

4:15 PM Changeset in webkit [81529] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

4:14 PM Changeset in webkit [81528] by jamesr@google.com
  • 4 edits in trunk

2011-03-18 James Robinson <​jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
​https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
4:11 PM Changeset in webkit [81527] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:08 PM Changeset in webkit [81526] by Lucas Forschler
  • 1 copy in tags/Safari-534.26

New tag.

4:07 PM Changeset in webkit [81525] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-03-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

[GTK] JSC crashes in 32bit Release bots after r80743
​https://bugs.webkit.org/show_bug.cgi?id=56180


The crash was caused by referencing GC memory from a GC destructor. This
is not safe because destruction time / order is not guaranteed.

  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::create): (JSC::ProfileGenerator::ProfileGenerator): (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
  • profiler/ProfileGenerator.h: (JSC::ProfileGenerator::origin): Made ExecState* the first argument, to match the rest of this class and JSC.


Use a JSGlobalObject* instead of an ExecState* with an indirect reference
to a JSGlobalObject* to track our origin. This is simpler and more
efficient, and it removes the destruction order dependency that was causing
our crash.

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): Updated for change to JSGlobalObject*. (JSC::Profiler::stopProfiling): New function for stopping all profiles for a given global object. This is more straight-forward than multiplexing through the old function.

(JSC::dispatchFunctionToProfiles): Updated for change to JSGlobalObject*.

  • profiler/Profiler.h: Ditto.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): Ditto.
4:06 PM Changeset in webkit [81524] by mrowe@apple.com
  • 1 copy in branches/safari-533.21-branch

New branch.

4:06 PM Changeset in webkit [81523] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80668
BUG=75374

4:02 PM Changeset in webkit [81522] by dcheng@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Fix incorrect test onpaste-text-html-types.html
​https://bugs.webkit.org/show_bug.cgi?id=56621

The test was checking for the presence of "Text" in event.clipboardData.types,
but per ​http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/024956.html,
this should not be the case.

  • editing/pasteboard/onpaste-text-html-types.html:
3:53 PM Changeset in webkit [81521] by cevans@google.com
  • 3 edits in branches/chromium/696/Source/WebCore

Merge 80798
BUG=73899

3:41 PM Changeset in webkit [81520] by simonjam@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-18 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81489.

  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
3:32 PM Changeset in webkit [81519] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash when sending a sync message ends up invalidating the connection
​https://bugs.webkit.org/show_bug.cgi?id=56686
<rdar://problem/9048781>

Guard against a null client.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
3:20 PM Changeset in webkit [81518] by rniwa@webkit.org
  • 8 edits in trunk

2011-03-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=56599

Re-enabled the test on non-Mac platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=56599

Debug build fix.

  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node, then we can't necessarily instantiate a position inside the node.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e could be null. Exit early in those cases as well.
3:14 PM Changeset in webkit [81517] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC bindings to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56671

It turns out we generate a bunch of ObjC bindings files that we don't
actually build. I've manually synced the list of ObjC derived source
files to match the existing list. This brings us down to 19 link
errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
3:05 PM Changeset in webkit [81516] by cevans@google.com
  • 2 edits
    12 copies in branches/chromium/696

Merge 80682
BUG=61502

2:55 PM Changeset in webkit [81515] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-18 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=56624

No new tests, just splitting jsc related configuration.

  • CMakeLists.txt:
  • UseJSC.cmake: Added.
2:50 PM Changeset in webkit [81514] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=56685
webarchive/test-link-rel-icon.html is now flaky

Rubberstamped by Adam Roben.

  • platform/mac/Skipped:
2:48 PM Changeset in webkit [81513] by enne@google.com
  • 3 edits in branches/chromium/696/Source/WebKit/chromium

Merge 81395 - 2011-03-17 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
​https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:

TBR=​enne@google.com

2:44 PM Changeset in webkit [81512] by senorblanco@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

One last attempt at rebaselining these tests (now that I know how
the --gpu flag works).

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
2:17 PM Changeset in webkit [81511] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; more test baselines.

Update the checksums I forgot to update in r81504.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
2:15 PM Changeset in webkit [81510] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-18 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] make devtool concatenation targets conditional based on debug_devtools
​https://bugs.webkit.org/show_bug.cgi?id=56667

We don't want to run these targets when debug_devtools=1 because it
will overwrite the devtools.js and devtools.css files copied by
inspector_resources. On Linux, this triggers a warning because
there are two commands that target the same output file when
debug_devtools=1.

I also removed the 'sources' lines since I don't think they do
anything for actions.

  • WebKit.gyp:
2:03 PM Changeset in webkit [81509] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
​https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
​https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
1:59 PM Changeset in webkit [81508] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, re-enable some stable tests and add a flaky one.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [81507] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Benjamin Poulain.

[Qt][WK2] Need a way to debug the web process after the UI process dies
​https://bugs.webkit.org/show_bug.cgi?id=56116

Allow the web process to outlive it's parent process
in debug builds if the QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS
environment variable is set.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess): Used getenv since the prctl call is already in a Linux-only block and the implementation in this file is a candidate for sharing across ports in the future.
1:29 PM Changeset in webkit [81506] by cevans@google.com
  • 1 edit in branches/chromium/696/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595

1:28 PM Changeset in webkit [81505] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595
Review URL: ​http://codereview.chromium.org/6713045

1:18 PM Changeset in webkit [81504] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

New GPU baselines for shadow quality improved by ​http://trac.webkit.org/changeset/81489.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
1:04 PM Changeset in webkit [81503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Remove unused method FontFallbackList::fontDataForCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=56657

  • platform/graphics/Font.h:
  • platform/graphics/FontFallbackList.cpp:
  • platform/graphics/FontFallbackList.h:
1:04 PM Changeset in webkit [81502] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4.0

Branching for the 1.4.0 GTK+ stable release.

1:03 PM Changeset in webkit [81501] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <​kling@webkit.org>

Reverting accidental changes in r81498.

12:58 PM Changeset in webkit [81500] by Adam Roben
  • 2 edits in trunk/Tools

Windows build fix

  • WebKitTestRunner/config.h: Add a missing #endif.
12:49 PM Changeset in webkit [81499] by loislo@chromium.org
  • 7 edits in trunk

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename console agent events.
​https://bugs.webkit.org/show_bug.cgi?id=56646

addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate

WebCore:

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
12:46 PM Changeset in webkit [81498] by andreas.kling@nokia.com
  • 5 edits in trunk

2011-03-18 Andreas Kling <​kling@webkit.org>

Unbreak Qt build after r81494.

  • WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
12:38 PM Changeset in webkit [81497] by senorblanco@chromium.org
  • 166 edits
    14 adds in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

New baselines for shadow quality improved by ​http://trac.webkit.org/changeset/81489.

  • platform/chromium-linux/compositing/geometry: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-linux/compositing/iframes: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-linux/svg/css/shadow-changes-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-win/compositing/geometry: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/chromium-win/compositing/iframes: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.checksum:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.checksum:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium/test_expectations.txt:
12:36 PM Changeset in webkit [81496] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build. This was really Adam Roben's fault. I swear!

  • WebKitTestRunner/config.h:
12:28 PM Changeset in webkit [81495] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

2011-03-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
​http://trac.webkit.org/changeset/81487
​https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
  • inspector/styles/get-set-stylesheet-text.html: Removed.
  • inspector/styles/resources/get-set-stylesheet-text.css: Removed.
  • inspector/styles/styles-new-API.html:

2011-03-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
​http://trac.webkit.org/changeset/81487
​https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):
12:24 PM Changeset in webkit [81494] by weinig@apple.com
  • 9 edits
    1 move
    2 adds in trunk/Tools

2011-03-18 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Pixel tests don't work in WebKitTestRunner on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56630

Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
built-in snapshotting instead of using the window server on the Mac.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::setPixelResult): (WTR::InjectedBundle::shouldDumpPixels):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Take the snapshot in the bundle and send it to the UIProcess for dumping.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cg: Added.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm. (WTR::createCGContextFromImage): (WTR::computeMD5HashStringForContext): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/mac/TestInvocationMac.mm: Removed. Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
  • WebKitTestRunner/win/TestInvocationWin.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Keep stub for Cairo build.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added. Add CG configuration.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files.
12:15 PM Changeset in webkit [81493] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Command-period does not stop load when page has focus in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56601

  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): If called outside interpretKeyEvents, call through to super. (-[WKView insertText:]): Assert that we are inside interpretKeyEvents. (-[WKView unmarkText]): Ditto. (-[WKView setMarkedText:selectedRange:]): Ditto. (-[WKView _interceptKeyEvent:]): Set a flag to indicate we are inside interpretKeyEvents for use by the above.
12:10 PM Changeset in webkit [81492] by Adam Roben
  • 2 edits in trunk/Tools

Don't allow Leaks Viewer's vertical scrollbar to cover up long function names

Rubber-stamped by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
overflow-y:overlay so that the scrollbar doesn't overlay the content.

12:03 PM Changeset in webkit [81491] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

[chromium] Add some test expectations missing from r81489.

  • platform/chromium/test_expectations.txt:
12:00 PM Changeset in webkit [81490] by Adam Roben
  • 2 edits in trunk/Tools

Don't ellipsize long or indented function names in Leaks Viewer

Fixes <​http://webkit.org/b/56037> Leaks viewer needs horizontal
scrollbar

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container):
(.data-grid td > div, .data-grid th > div):
Allow the contents to extend to the right.

11:14 AM Changeset in webkit [81489] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/chromium/test_expectations.txt:

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
11:11 AM Changeset in webkit [81488] by jberlin@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

Web Inspector: inspector/elements/mutate-unknown-node.html is flakey.
​https://bugs.webkit.org/show_bug.cgi?id=56457

Unreviewed, disable the test and remove it from the Qt Skipped list because this test is
also being flakey on Windows.

  • inspector/elements/mutate-unknown-node.html: Removed.
  • inspector/elements/mutate-unknown-node.html-disabled: Copied from inspector/elements/mutate-unknown-node.html.
  • platform/qt/Skipped:
10:55 AM Changeset in webkit [81487] by apavlov@chromium.org
  • 10 edits
    3 adds in trunk

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
​https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt: Added.
  • inspector/styles/get-set-stylesheet-text.html: Added.
  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles/styles-new-API.html:
10:25 AM Changeset in webkit [81486] by xan@webkit.org
  • 8 edits in trunk/Source

Source/WebCore:

2011-03-18 David Keijser <​keijser@gmail.com> and Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
​https://bugs.webkit.org/show_bug.cgi?id=49649

Add explicit EventTarget API to add/remove event listeners instead
of using GSignal, which due to internal limitations in glib makes
us preemptively add listeners for all event types.

  • bindings/gobject/GObjectEventListener.cpp: add new addEventListener/removeEventListener methods, and small refactoring to store an EventTarget internally instead of a DOM node, which is more generic and can be reused in more cases.
  • bindings/gobject/GObjectEventListener.h: ditto.
  • bindings/gobject/WebKitDOMEventTarget.cpp: (webkit_dom_event_target_add_event_listener): new iface method to add an event listener. (webkit_dom_event_target_remove_event_listener): new iface method to remove an event listener.
  • bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
  • bindings/scripts/CodeGeneratorGObject.pm: change code generation accordingly.

Source/WebKit/gtk:

2011-03-18 David Keijser <​keijser@gmail.com> and Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
​https://bugs.webkit.org/show_bug.cgi?id=49649

  • tests/testdomdomwindow.c: update unit tests for new APIs. (load_event_callback): ditto. (test_dom_domview_signals): ditto. (load_status_callback): ditto.
10:07 AM Changeset in webkit [81485] by kerz@chromium.org
  • 2 edits in branches/chromium/648/Source/WebKit/chromium

Merge 76889 - 2011-01-27 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

This addresses a regression introduced by r75784, as described in:
​https://bugs.webkit.org/show_bug.cgi?id=53176

The problem is that originalEndContainer and originalEndOffset was
meant to capture the end of the document, but was being assigned after
a call to searchRange->setStart() (when scoping is restarted), which can
result in the Range being collapsed to start (thereby assigning the
wrong value to the Container/Offset pair).

This code is never triggered by layout tests, but I'm adding a regressiono
test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6708026

10:07 AM Changeset in webkit [81484] by beidson@apple.com
  • 28 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase

Reviewed by Sam Weinig.

../WebCore:

-Update the synchronous method names to be prefixed with "synchronous."
-Call asynchronous versions of the appropriate methods if the IconDatabase supports them.

Update icon database calls to be prefixed with "synchronous":

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabaseBase::synchronousIconForPageURL):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::synchronousIconURLForPageURL):

Add nascent support for an asynchronous icon database mode:

  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::create):
(WebCore::EnumCallback::~EnumCallback):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::create):
(WebCore::ObjectCallback::~ObjectCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
(WebCore::IconDatabaseBase::supportsAsynchronousMode):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::iconDataForIconURL):

Add interfaces to use the asynchronous versions of certain IconDatabase calls:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::iconLoadDecisionAvailable):
(WebCore::iconLoadDecisionCallback):
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
(WebCore::DocumentLoader::continueIconLoadWithDecision):
(WebCore::iconDataCallback):
(WebCore::DocumentLoader::getIconDataForIconURL):

  • loader/DocumentLoader.h:

Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
icon database modes:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::iconLoadDecisionReceived):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::continueIconLoadWithDecision):

  • loader/FrameLoader.h:
  • WebCore.exp.in:

../WebKit/efl:

Update already-used function names:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

../WebKit/gtk:

Update already-used function names:

  • webkit/webkiticondatabase.cpp:

(webkit_icon_database_get_icon_uri):
(webkit_icon_database_get_icon_pixbuf):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_icon_uri):

../WebKit/mac:

Update already-used function names:

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):

  • WebView/WebView.mm:

(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

../WebKit/qt:

Update already-used function names:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):

../WebKit/win:

Update already-used function names:

  • WebIconDatabase.cpp:

(WebIconDatabase::iconForURL):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::hasIconForURL):

../WebKit2:

-Update the synchronous method names to be prefixed with "synchronous."
-Add empty implementations for the asynchronous accessors.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::supportsAsynchronousMode):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
9:56 AM Changeset in webkit [81483] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::NativeExecutable::NativeExecutable): (JSC::VPtrHackExecutable::VPtrHackExecutable): (JSC::ScriptExecutable::ScriptExecutable): Use a raw pointer instead of PassRefPtr, like JSString does, since JSGlobalData owns the singleton exectuable structure.
9:50 AM Changeset in webkit [81482] by Adam Roben
  • 2 edits
    1 add in trunk/Tools

Fix some leaks in DRT seen on the leaks bot

Fixes <​http://webkit.org/b/56638> addURLToRedirectCallback and
setWillSendRequestClearHeaderCallback in DRT are leaky

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:

(addURLToRedirectCallback):
(setWillSendRequestClearHeaderCallback):
Use OwnArrayPtr to cause the strings to be deleted.

9:49 AM Changeset in webkit [81481] by Adam Roben
  • 2 edits in trunk/Tools

Fix a NSURLCredential leak seen on the leaks bot

Fixes <​http://webkit.org/b/56637> -[SynchronousLoader
connection:didReceiveAuthenticationChallenge:] is leaky

Reviewed by John Sullivan.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
cause the NSURLCredential to be released.

9:48 AM Changeset in webkit [81480] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: add missing brace to the generated Inspector.idl.

  • inspector/generate-inspector-idl:
9:42 AM Changeset in webkit [81479] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/Source/WebCore

2011-03-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
​https://bugs.webkit.org/show_bug.cgi?id=56294

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • inspector/Inspector.idl: Removed.
  • inspector/Inspector.json: Added.
  • inspector/generate-inspector-idl: Added.
9:40 AM Changeset in webkit [81478] by alex
  • 2 edits
    4 adds in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Fixed compilation after r80925.

  • GNUmakefile.am:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Added. (WebKit::WebFullScreenManagerProxy::enterFullScreen): (WebKit::WebFullScreenManagerProxy::exitFullScreen): (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::getFullScreenRect):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Added. (WebKit::WebFullScreenManagerGtk::WebFullScreenManagerGtk): (WebKit::WebFullScreenManager::create): (WebKit::WebFullScreenManagerGtk::setRootFullScreenLayer): (WebKit::WebFullScreenManagerGtk::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerGtk::beginExitFullScreenAnimation):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Added.
9:36 AM Changeset in webkit [81477] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

inspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2 Tests).
​https://bugs.webkit.org/show_bug.cgi?id=56633

Unreviewed, skip command-line-api-inspect.html instead of command-line-api.html, since the
former appears to be causing the latter (and probably console-clear.html as well) to time
out.

  • platform/win-wk2/Skipped:
  • platform/win-wk2/inspector: Removed.
  • platform/win-wk2/inspector/console: Removed.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Removed.
9:36 AM Changeset in webkit [81476] by alex
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed compilation after r81208.

  • GNUmakefile.am:
9:09 AM Changeset in webkit [81475] by sergio@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-18 Sergio Villar Senin <​svillar@igalia.com>

Added new GTK+ test expectations.

  • platform/gtk/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt: Added.
8:51 AM Changeset in webkit [81474] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-03-18 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

Remove unnecessary brackets around my email address.

  • Scripts/webkitpy/common/config/committers.py:
8:42 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
8:41 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
8:31 AM Changeset in webkit [81473] by jberlin@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Two inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release (WebKit2
Tests).
​https://bugs.webkit.org/show_bug.cgi?id=56632

Unreviewed, landing expected failing results in order to get the Windows 7 Release
WebKit2 bots green.

  • platform/win-wk2/http: Added.
  • platform/win-wk2/http/tests: Added.
  • platform/win-wk2/http/tests/inspector-enabled: Added.
  • platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Added.
  • platform/win-wk2/inspector: Added.
  • platform/win-wk2/inspector/console: Added.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Added.
8:29 AM Changeset in webkit [81472] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)

8:27 AM Changeset in webkit [81471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-18 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] console.log not being exposed to QmlViewer
​https://bugs.webkit.org/show_bug.cgi?id=56536

The documentation is bogus the feature does not exist.

  • declarative/qdeclarativewebview.cpp:
8:21 AM Changeset in webkit [81470] by podivilov@chromium.org
  • 12 edits in trunk/Source

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

We would like to enable debugger/profiler from frontend side only.
However, when user clicks "Start Debugging JavaScript" in Safari, we
need to enable debugger when frontend is opened or re-opened for the
same page. The idea is to store debugger-enabled setting in session
storage and check it on frontend load.

  • inspector/InspectorFrontendClient.h: (WebCore::InspectorFrontendClient::saveSessionSetting): (WebCore::InspectorFrontendClient::loadSessionSetting):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::saveSessionSetting): (WebCore::InspectorFrontendHost::loadSessionSetting):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting): (-[WebInspectorWindowController inspectorClient]):

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting):
  • WebCoreSupport/WebInspectorClient.h:
7:31 AM Changeset in webkit [81469] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, suppress editing/deleting/5206311-1.html crashes on Mac Debug

  • platform/chromium/test_expectations.txt:
7:28 AM Changeset in webkit [81468] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable GraphicsContext3D only when the window surface support OpenGL
​https://bugs.webkit.org/show_bug.cgi?id=56555

Allow creation of WebGLRenderingContext in the HTMLCanvasElement
only if accelerated compositing is enabled. In GraphicsContext3D,
while blitting the surface check that viewport hasn't changed from
creation and painter is associated to the viewport.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getViewportGLWidget): (WebCore::GraphicsContext3DInternal::paint):
7:11 AM Changeset in webkit [81467] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
6:48 AM Changeset in webkit [81466] by apavlov@chromium.org
  • 51 edits
    2 adds in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, rebaseline GPU tests after r81414

  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
5:08 AM Changeset in webkit [81465] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only

Rubber-stamped by Jon Honeycutt.

Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.

  • Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what

each target-specific .xcconfig file should import.

4:18 AM Changeset in webkit [81464] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, fix custom expectation after r81438

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
3:26 AM Changeset in webkit [81463] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn&apos;t scroll when multiline expression is being evaluated
​https://bugs.webkit.org/show_bug.cgi?id=56639

Always scoll in the console when command result is received.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage):
3:09 AM Changeset in webkit [81462] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed fix for chromium test_expectations.txt.

There was a duplicate for inspector/mutate-unknown-node.html

  • platform/chromium/test_expectations.txt:
2:36 AM Changeset in webkit [81461] by caseq@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-18 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

http/tests/inspector/resource-parameters.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=55867

Fixed test flakiness by not finishing test before proper resource arrives.

  • http/tests/inspector/resource-parameters.html: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html-disabled.
2:14 AM Changeset in webkit [81460] by Adam Roben
  • 1 edit
    2 deletes in trunk/Tools

Remove some files I accidentally added in r81454

  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2:12 AM Changeset in webkit [81459] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: cleanup Web Inspector expectations.
​https://bugs.webkit.org/show_bug.cgi?id=56635

Many Inspector tests are passing now but they still have expectations.
I've removed unnecessary expectations and grouped the remainings.

  • platform/chromium/test_expectations.txt:
2:08 AM Changeset in webkit [81458] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows WebKit2 expected failure results for a media test

The failure is tracked by <​http://webkit.org/b/56636>.

  • platform/win-wk2/media/controls-without-preload-expected.txt: Added.
2:07 AM Changeset in webkit [81457] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some timing out tests in WebKit2 on Windows

Tracked by <​http://webkit.org/b/56633> and <​http://webkit.org/b/56634>.

  • platform/win-wk2/Skipped: Added inspector/console/command-line-api.html and

http/tests/xmlhttprequest/cross-origin-authorization.html.

2:05 AM Changeset in webkit [81456] by Adam Roben
  • 1 edit
    12 adds in trunk/LayoutTests

Add expected failure results for WebKit2 tests failing on Windows due to font differences

<​http://webkit.org/b/56617> tracks the failures.

  • platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/text/bidi-text-query-expected.txt: Added.
2:03 AM Changeset in webkit [81455] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test in that is probably causing the next test to crash in WebKit2

<​http://webkit.org/b/55780> tracks the failure.

  • platform/win-wk2/Skipped: Skip platform/win/plugins/draws-gradient.html instead of

platform/win/plugins/get-value-netscape-window.html. The former was probably causing the
latter to crash.

2:01 AM Changeset in webkit [81454] by Adam Roben
  • 1 edit
    1 move
    3 adds in trunk

Disable a flakey inspector test

<​http://webkit.org/b/56565> tracks the failure.

  • inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Renamed from LayoutTests/inspector/elements/elements-panel-xhtml-structure.xhtml.
12:39 AM Changeset in webkit [81453] by Adam Roben
  • 2 edits in trunk/Tools

Ignore an NSNumberFormatter leak on SnowLeopard

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
getObjectValue:forString:errorDescription:].

12:37 AM Changeset in webkit [81452] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Fix a CFNumber leak seen on the leaks bot

Reviewed by Gavin Barraclough.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.

12:34 AM Changeset in webkit [81451] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/648

Merge 80797
BUG=73595
Review URL: ​http://codereview.chromium.org/6709024

12:26 AM Changeset in webkit [81450] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/696

Merge 80797
BUG=73595

12:19 AM Changeset in webkit [81449] by Adam Roben
  • 2 edits in trunk/Tools

Fix a leak beneath LayoutTestController::authenticateSession seen on the bots

Rubber-stamped by Mark Rowe.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
released.

12:09 AM Changeset in webkit [81448] by Adam Roben
  • 2 edits in trunk/Tools

Address a review comment I missed in r81445

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
leaked bytes to speed up searching on long lines.

12:01 AM Changeset in webkit [81447] by Adam Roben
  • 2 edits in trunk/Tools

Mark leaky builds orange, even if all regression tests passed

Fixes <​http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
build.webkit.org when all tests pass even though there are still leaks

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
be marked orange if this build step generates warnings.

Note: See TracTimeline for information about the timeline view.