⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 23, 2011:

11:48 PM Changeset in webkit [81854] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-23 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] WebBindings{.h,.cpp}: should use consistent argument naming
​https://bugs.webkit.org/show_bug.cgi?id=56898

Address FIXME I noted/added in r81676. Wanted to just copy/paste the checking
code from elsewhere in the file, but inconsistent argument naming made it more
difficult than it need be, so first step: use consistent naming.

  • public/WebBindings.h:
  • src/WebBindings.cpp: (WebKit::WebBindings::construct): (WebKit::WebBindings::enumerate): (WebKit::WebBindings::evaluate): (WebKit::WebBindings::evaluateHelper): (WebKit::WebBindings::getProperty): (WebKit::WebBindings::hasMethod): (WebKit::WebBindings::hasProperty): (WebKit::WebBindings::invoke): (WebKit::WebBindings::invokeDefault): (WebKit::WebBindings::releaseObject): (WebKit::WebBindings::removeProperty): (WebKit::WebBindings::retainObject): (WebKit::WebBindings::setException): (WebKit::WebBindings::setProperty): (WebKit::WebBindings::unregisterObject): (WebKit::WebBindings::extractIdentifierData): (WebKit::getRangeImpl): (WebKit::getElementImpl): (WebKit::makeIntArrayImpl): (WebKit::WebBindings::getRange): (WebKit::WebBindings::makeIntArray):
9:02 PM Changeset in webkit [81853] by Lucas Forschler
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

8:55 PM Changeset in webkit [81852] by Lucas Forschler
  • 1 copy in tags/Safari-534.26.1

New tag.

8:48 PM Changeset in webkit [81851] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

[Chromium] Force to make validation bubble DIV position:absolute
​https://bugs.webkit.org/show_bug.cgi?id=56901

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/forms/interactive-validation-crash-by-style-override.html

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree): Add position:absolute

because we need to move the validation message to a good position.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):

LayoutTests:

  • fast/forms/interactive-validation-crash-by-style-override-expected.txt: Added.
  • fast/forms/interactive-validation-crash-by-style-override.html: Added.
  • platform/gtk/Skipped: Skip the new test because the interactive validation feature is not enabled.
  • platform/mac/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
8:22 PM Changeset in webkit [81850] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-23 Ojan Vafai <​ojan@chromium.org>

Add failing result for WebKit2. All tests that require
focus fail on WebKit2. See ​https://bugs.webkit.org/show_bug.cgi?id=56988.

  • platform/mac-wk2/fast/css/pseudo-any-expected.txt: Added.
8:18 PM Changeset in webkit [81849] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk

2011-03-23 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Ojan Vafai.

flex/bison tokens and grammar for CSS calc
​https://bugs.webkit.org/show_bug.cgi?id=54412

Only the 'errors' tests pass as ultimately intended right now. As of this
patch, none of the actual calculations are expected to work, since only
the lexing/grammar stage is present.

  • css3/calc/calc-errors-expected.txt: Added.
  • css3/calc/calc-errors.html: Added.
  • css3/calc/minmax-errors-expected.txt: Added.
  • css3/calc/minmax-errors.html: Added.
  • css3/calc/simple-calcs-expected.txt: Added.
  • css3/calc/simple-calcs.html: Added.
  • css3/calc/simple-minmax-expected.txt: Added.
  • css3/calc/simple-minmax.html: Added.

2011-03-23 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Ojan Vafai.

flex/bison tokens and grammar for CSS calc
​https://bugs.webkit.org/show_bug.cgi?id=54412

Tests: css3/calc/calc-errors.html

css3/calc/minmax-errors.html
css3/calc/simple-calcs.html
css3/calc/simple-minmax.html

  • css/CSSGrammar.y:
  • css/CSSParserValues.cpp: (WebCore::CSSParserValueList::insertValueAt): (WebCore::CSSParserValueList::extend):
  • css/CSSParserValues.h:
  • css/tokenizer.flex:
8:10 PM Changeset in webkit [81848] by commit-queue@webkit.org
  • 9 edits in trunk

2011-03-23 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
​https://bugs.webkit.org/show_bug.cgi?id=56961

  • http/tests/filesystem/resolve-uri-expected.txt:
  • http/tests/filesystem/script-tests/resolve-uri.js: Added three tests to exercise SECURITY_ERR: (runWrongDomain): (runWrongPort): (runWrongScheme): And updated four tests to test error codes: (runBogusURL): (runWrongProtocol): (runNotEnoughSlashes): (runNotEnoughSlashes2):
  • http/tests/filesystem/workers/resolve-url-expected.txt:
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt:
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added three tests to exercise SECURITY_ERR: (runWrongDomain): (runWrongPort): (runWrongScheme): And updated four tests to test error codes: (runBogusURL): (runWrongProtocol): (runNotEnoughSlashes): (runNotEnoughSlashes2):

2011-03-23 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
​https://bugs.webkit.org/show_bug.cgi?id=56961

See error code listing in the Files & Directories spec:
​http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-LocalFileSystemSync-resolveLocalFileSystemSyncURL

Note that the spec currently only specifies errors for the sync
version; I've used the same codes for the async version.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURL):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::resolveLocalFileSystemURL): (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
7:53 PM Changeset in webkit [81847] by commit-queue@webkit.org
  • 30 edits
    5 adds in trunk

2011-03-23 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
​https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • platform/mac-wk2/Skipped: Enable autocorrection tests for WK2.

2011-03-23 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
​https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
major changes:

  1. All but one autocorrection related message is synchronous. Since dismissing autocorrection panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function is introduced to ensure all editing commands occur in correct order.
  1. Additional condition variable is needed to implement dismissCorrectionPanelSoon(). To improve maintainability, CorrectionPanel class is introduced to manage the internal state related to correction panel. This change is applied to both WK1 and WK2.
  1. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow editor to know when to handle ESC key event. Now this is handled internally in AppKit, so EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
  1. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can access object via WebView or WKView.
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::dismissCorrectionPanel): (WebCore::Editor::dismissCorrectionPanelSoon): (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::showCorrectionPanel): (WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
  • manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
  • page/EditorClient.h:

2011-03-23 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
​https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • WebKit.xcodeproj/project.pbxproj:

2011-03-23 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
​https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • WebCoreSupport/CorrectionPanel.h: Added. (CorrectionPanel::isShowing):
  • WebCoreSupport/CorrectionPanel.mm: Added. (correctionBubbleType): (CorrectionPanel::CorrectionPanel): (CorrectionPanel::~CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::recordAutocorrectionResponse):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::showCorrectionPanel): (WebEditorClient::dismissCorrectionPanel): (WebEditorClient::dismissCorrectionPanelSoon): (WebEditorClient::recordAutocorrectionResponse):
  • WebView/WebView.mm: (-[WebView handleCorrectionPanelResult:]):
  • WebView/WebViewPrivate.h:

2011-03-23 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
​https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

The calls to AppKit are implemented in PageClientImpl. Other changes are necessary for the
plumbing work.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::showCorrectionPanel): (WebKit::PageClientImpl::dismissCorrectionPanel): (WebKit::PageClientImpl::dismissCorrectionPanelSoon): (WebKit::PageClientImpl::recordAutocorrectionResponse):
  • UIProcess/API/mac/WKView.mm: (-[WKView spellCheckerDocumentTag]): (-[WKView handleCorrectionPanelResult:]):
  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::showCorrectionPanel): (WebKit::WebPageProxy::dismissCorrectionPanel): (WebKit::WebPageProxy::dismissCorrectionPanelSoon): (WebKit::WebPageProxy::recordAutocorrectionResponse): (WebKit::WebPageProxy::handleCorrectionPanelResult):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/CorrectionPanel.h: Added. (WebKit::CorrectionPanel::isShowing):
  • UIProcess/mac/CorrectionPanel.mm: Added. (correctionBubbleType): (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::~CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismiss): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::recordAutocorrectionResponse):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::showCorrectionPanel): (WebKit::WebEditorClient::dismissCorrectionPanel): (WebKit::WebEditorClient::dismissCorrectionPanelSoon): (WebKit::WebEditorClient::recordAutocorrectionResponse):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::handleCorrectionPanelResult):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
7:43 PM Changeset in webkit [81846] by jcivelli@chromium.org
  • 8 edits
    7 adds in trunk/Source/WebKit/chromium

2011-03-23 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Relanding:
Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
7:34 PM Changeset in webkit [81845] by ojan@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-03-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

move :not over to using selectorList instead of simpleSelector
​https://bugs.webkit.org/show_bug.cgi?id=56894

Saves memory and simplifies code.

No new tests since existing tests cover this code.

  • css/CSSGrammar.y: Also removed extranenous calls to updateLastSelectorLineAndPosition in simple_selector_list. These happened to work, but are only actually needed in selector_list.
  • css/CSSParserValues.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificityForOneSelector): Removed null-check. The parser null-checks, I don't see why we need to here. (WebCore::CSSSelector::selectorText): Ditto. (WebCore::CSSSelector::setArgument): (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
  • css/CSSSelectorList.cpp: (WebCore::forEachTagSelector):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector): (WebCore::collectFeaturesFromList):
7:25 PM Changeset in webkit [81844] by carol.szabo@nokia.com
  • 5 edits
    2 adds in trunk

2011-03-23 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

This test verifies the correct update of a second renderer that
displays the same CounterNode.

Assertion and incorrect rendering of counters.
​https://bugs.webkit.org/show_bug.cgi?id=56896

  • fast/css/counters/2displays-expected.txt: Added.
  • fast/css/counters/2displays.html: Added.

2011-03-23 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Made sure that renderers displaying counters are invalidated upon
counter destruction.

Assertion and incorrect rendering of counters.
​https://bugs.webkit.org/show_bug.cgi?id=56896

Test: fast/css/counters/2displays.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::~CounterNode): Added to make sure that its display renderers are always reset when the node is deleted. (WebCore::CounterNode::resetRenderers): Fixed bug that would prevent reset of second and subsequent display renderers.
  • rendering/CounterNode.h:
  • rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeWithoutMapRemoval): removed unnecessary calls to resetRenderers() as the CounterNode destructor takes care of that now.
7:03 PM Changeset in webkit [81843] by Lucas Forschler
  • 2 edits in branches/safari-534.26-branch/Source/WebCore

Merge r81832.

7:02 PM Changeset in webkit [81842] by Lucas Forschler
  • 2 edits in branches/safari-534.26-branch/Source/WebCore

Merge r81831.

6:59 PM Changeset in webkit [81841] by Lucas Forschler
  • 2 edits in branches/safari-534.26-branch/Source/WebCore

Merge r81745.

6:57 PM Changeset in webkit [81840] by Lucas Forschler
  • 2 edits in branches/safari-534.26-branch/Source/WebKit2

Merge r81680.

6:54 PM Changeset in webkit [81839] by Lucas Forschler
  • 4 edits in branches/safari-534.26-branch/Source/WebKit2

Merge r81622.

6:54 PM Changeset in webkit [81838] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-23 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Darin Adler.

Media Stream API: fix the order of the options in build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=56949

Fix the order of the options in build-webkit.

  • Scripts/build-webkit:
6:52 PM Changeset in webkit [81837] by Lucas Forschler
  • 18 edits in branches/safari-534.26-branch

Merge r81600.

6:44 PM Changeset in webkit [81836] by bweinstein@apple.com
  • 4 edits in trunk/Source

WebKit2: Need API to manage the Media Cache
​https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add functions that need to be exported.

  • WebCore.exp.in:

Source/WebKit2:

Call through to HTMLMediaElement functions to manage the WebCore media cache.

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):

6:33 PM Changeset in webkit [81835] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by James Robinson.

Correct use of ENABLE() Macro

In ​http://trac.webkit.org/changeset/81618, I mis-used the ENABLE()
macro. This patch corrects.

​https://bugs.webkit.org/show_bug.cgi?id=56964

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
6:13 PM Changeset in webkit [81834] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-23 Adam Klein <​adamk@chromium.org>

Reviewed by Mihai Parparita.

Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
​https://bugs.webkit.org/show_bug.cgi?id=56884

This option will be utilized by Chromium's ui_tests to allow
referencing js-test-resources from a layout test over HTTP.

  • Scripts/new-run-webkit-httpd: Added --layout_tests_dir option.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Plumbed through as layout_tests_dir param.
5:58 PM Changeset in webkit [81833] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Scrubbing <video> with HTTP Live Stream resizes element to 0x0
​https://bugs.webkit.org/show_bug.cgi?id=55702

QTKit will occasionally set the natural size of a QTMovie to 0x0 while scrubbing
an HTTP Live Stream. So we will cache the last valid value returned by QTKit
and use that as our naturalSize until a new valid value is returned.

Unfortunately, QTKit will also fail to generate a notification when the natural size
changes, so we are forced to cache the natural size from within naturalSize(), which
is a const function, necessitating a const_cast to set m_cachedNaturalSize.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Added m_cachedNaturalSize.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_cachedNaturalSize. (WebCore::MediaPlayerPrivateQTKit::naturalSize):
5:50 PM Changeset in webkit [81832] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed a stray parenthesis.
5:48 PM Changeset in webkit [81831] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Maciej Stachowiak.

REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading()
​https://bugs.webkit.org/show_bug.cgi?id=56978
<rdar://problem/9041670>

No new tests, because there is no known way to reproduce.

Removed strange code that was trying to stop a non-loading provisional document loader and
even its subframes (?!). Added assertions to catch it if we can actually be loading here in
some sense.
Rewrote a condition for clarity - starting with r43148, it was acting as an opposite of a
recursion guard (but that didn't cause immediate problems then).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
5:38 PM Changeset in webkit [81830] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build for platforms that have the icon database
disabled but still provide settings API for it...?

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::defaultDatabaseFilename):

5:21 PM Changeset in webkit [81829] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-23 Kenneth Russell <​kbr@google.com>

Rolled forward Chromium DEPS again to fix DumpRenderTree build
failure caused by r81821.

  • DEPS:
5:21 PM Changeset in webkit [81828] by Lucas Forschler
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

5:21 PM Changeset in webkit [81827] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
​https://bugs.webkit.org/show_bug.cgi?id=56974
<rdar://problem/8284642>

Reviewed by Alexey Proskuryakov.

This fixes a regression introduced by ​http://trac.webkit.org/changeset/61794
where readSelectionFromPasteboard was accidentally removed.
This method and writeSelectionToPasteboard are needed to support Mac OS X
services.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
(-[WebHTMLView readSelectionFromPasteboard:]): Added.

5:20 PM Changeset in webkit [81826] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • WebCore.exp.in: Export the new version of IconDatabase::open.
5:06 PM Changeset in webkit [81825] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/7959320> Threads that use APIs above the BSD layer must be registered with the Obj-C GC.

Reviewed by Darin Adler.

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

4:56 PM Changeset in webkit [81824] by beidson@apple.com
  • 17 edits in trunk/Source

Change IconDatabase opening to allow for arbitrary filenames
​https://bugs.webkit.org/show_bug.cgi?id=56977

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::open):

  • loader/icon/IconDatabaseBase.h:
  • loader/icon/IconDatabaseClient.h:

../WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):

../WebKit/gtk:

  • webkit/webkiticondatabase.cpp:

(webkit_icon_database_set_path):

../WebKit/mac:

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase _startUpIconDatabase]):

../WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath):

../WebKit/win:

  • WebIconDatabase.cpp:

(WebIconDatabase::startUpIconDatabase):

4:56 PM Changeset in webkit [81823] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-23 Kenneth Russell <​kbr@google.com>

Rolled forward Chromium DEPS to fix build breakage after r81821.

  • DEPS:
4:48 PM Changeset in webkit [81822] by xji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-03-23 Xiaomei Ji <​xji@chromium.org>

Rebaseline chromium-mac after r81807.

  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [81821] by kbr@google.com
  • 7 edits in trunk/Source

2011-03-23 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
​https://bugs.webkit.org/show_bug.cgi?id=56947

Removed the WebRuntimeFeatures setting for WebGL. WebGL support is
now controlled exclusively through the page's Settings.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

2011-03-23 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
​https://bugs.webkit.org/show_bug.cgi?id=56947

Removed the RuntimeEnabledFeatures setting for WebGL and the
EnabledAtRuntime extended attribute from the WebGL-related
properties on the DOMWindow. WebGL support is now controlled
exclusively through the page's Settings.

No new tests; tested manually in Chromium with --disable-webgl
command line argument and blacklist.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.idl:
4:23 PM Changeset in webkit [81820] by xji@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2011-03-23 Xiaomei Ji <​xji@chromium.org>

Rebaseline after r81807.

  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
4:19 PM Changeset in webkit [81819] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-03-23 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Add WKBundleSetHostAllowsAnyHTTPSCertificate() for Windows
​https://bugs.webkit.org/show_bug.cgi?id=56972


This is the WebKit2 equivalent to the WebKit1 API IWebMutableURLRequest::setAllowsAnyHTTPSCertificate().

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetHostAllowsAnyHTTPSCertificate): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetHostAllowsAnyHTTPSCertificate().
  • WebProcess/InjectedBundle/InjectedBundle.h: Added setHostAllowsAnyHTTPSCertificate().
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added.
4:01 PM Changeset in webkit [81818] by mihaip@chromium.org
  • 4 edits
    2 copies
    1 add in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Rebaseline transitions/default-timing-function.html for Chromium Snow
Leopard.

  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.checksum: Copied from LayoutTests/platform/chromium-mac/transitions/default-timing-function-expected.checksum.
  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Copied from LayoutTests/platform/chromium-mac/transitions/default-timing-function-expected.png.
  • platform/chromium-mac/transitions/default-timing-function-expected.checksum:
  • platform/chromium-mac/transitions/default-timing-function-expected.png:
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [81817] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-23 Martin Robinson <​mrobinson@igalia.com>

[GTK] fast/overflow/horizontal-scroll-after-back.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56966

  • platform/gtk/Skipped: Skip this test on GTK+ until the fix is in.
3:39 PM Changeset in webkit [81816] by hyatt@apple.com
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r81802.
​http://trac.webkit.org/changeset/81802
​https://bugs.webkit.org/show_bug.cgi?id=56963

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-03-23
Broke a layout test, and this fix is not trivial. (Requested
by dhyatt on #webkit).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

3:34 PM Changeset in webkit [81815] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-03-23 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: run tests in ascending alphabetical order per
dir. This is a second attempt at the fix; the first attempt, in
r81597, broke the behavior on the old-inline and old-threads
worker models.

​https://bugs.webkit.org/show_bug.cgi?id=56760

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:29 PM Changeset in webkit [81814] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Roll out r81593 Need WebKit2 API for creating a page with a specific main frame name

Reviewed by Anders Carlsson.

This API is not necessary.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createMainFrame):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

3:23 PM Changeset in webkit [81813] by mihaip@chromium.org
  • 7 edits
    2 copies in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Update expectations for one SVG and two media tests for Chromium Snow
Leopard.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png.
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
3:04 PM Changeset in webkit [81812] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-23 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

REGRESSION(81035): crash in RenderDetails::removeChild
​https://bugs.webkit.org/show_bug.cgi?id=56773

  • fast/html/details-children-merge-crash-expected.txt: Added.
  • fast/html/details-children-merge-crash.html: Added.

2011-03-23 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

REGRESSION(81035): crash in RenderDetails::removeChild
​https://bugs.webkit.org/show_bug.cgi?id=56773

Test: fast/html/details-children-merge-crash.html

Preventing merging of RenderDetails's anonymous children.

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):

Fixing RenderDetails::removeChild and cleaning m_marker in RenderDetails::destroy.

  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::destroy): (WebCore::RenderDetails::removeChild):
3:03 PM Changeset in webkit [81811] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-23 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[WK2] Handle keyboard and mouse events on X11
​https://bugs.webkit.org/show_bug.cgi?id=56103

Propagate keyboard and mouse events to the plugin
as XEvent's.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::initializeXEvent): (WebKit::xTimeStamp): (WebKit::xKeyModifiers): (WebKit::setCommonMouseEventFields): (WebKit::setXMotionEventFields): (WebKit::setXButtonEventFields): (WebKit::setXCrossingEventFields): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::setXKeyEventFields): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
3:02 PM Changeset in webkit [81810] by mario@webkit.org
  • 2 edits in trunk/Tools

2011-03-23 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
​https://bugs.webkit.org/show_bug.cgi?id=56953

Print the string for the detail of 'property-change' signal.

  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp: (axObjectEventListener): Print the detail string.
2:46 PM Changeset in webkit [81809] by mrowe@apple.com
  • 1 copy in branches/safari-534.26-branch

New branch.

2:36 PM Changeset in webkit [81808] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-23 Xiaomei Ji <​xji@chromium.org>

Add fast/css/bidi-override-in-anonymous-block.html as expected to fail after r81807.

  • platform/chromium/test_expectations.txt:
2:27 PM Changeset in webkit [81807] by xji@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Preserve unicode-bidi:bidi-override in anonymous block.
​https://bugs.webkit.org/show_bug.cgi?id=21440

unicode-bidi:bidi-override should be preserved in anonymous block
according to ​http://www.w3.org/TR/CSS21/visuren.html#propdef-unicode-bidi.

Introduce a helper function RenderStyle()::createAnonymousStyle() which
creates a default RenderStyle, inherits the inherited style from parent,
and inherit unicode-bidi:bidi-override from parent.
And replace the style creation when anonymous block is created.

Note: the TABLE releated anonymous blocks are untouched, including:
TABLE, TABLE_CELL, TABLE_ROW, TABLE_ROW_GROUP anonymous blocks created in
RenderObject, RenderTable, RenderTableRow, and RenderTableSection,
due to the expected behavior is not clear.
Please refer to ​https://bugs.webkit.org/show_bug.cgi?id=56594.


Test: fast/css/bidi-override-in-anonymous-block.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::createAnonymousBlock): (WebCore::RenderBlock::createAnonymousColumnsBlock): (WebCore::RenderBlock::createAnonymousColumnSpanBlock):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildIgnoringContinuation):
  • rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::createRubyBase): (WebCore::RenderRubyRun::staticCreateRubyRun):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::createAnonymousStyle):
  • rendering/style/RenderStyle.h:

2011-03-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Preserve unicode-bidi:bidi-override in anonymous block.
​https://bugs.webkit.org/show_bug.cgi?id=21440

  • fast/css/bidi-override-in-anonymous-block.html: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
2:24 PM Changeset in webkit [81806] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Group Snow Leopard failures for bug 56962.

  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [81805] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Stop setting OTHER_OPTIONS in JavaScriptCore's Makefile.

It's not necessary to pass "-target All" as xcodebuild always builds the
first target in the project unless otherwise specified. The presence of
that option also breaks "make clean" since that results in both the
-target and -alltargets options being passed to xcodebuild.

  • Makefile:
2:06 PM Changeset in webkit [81804] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-23 Abhishek Arya <​inferno@chromium.org>

Unreviewed. Replace shockwave plugin with test netscape in recent
timing out test plugins/change-widget-and-click-crash.html.

  • plugins/change-widget-and-click-crash.html:
2:05 PM Changeset in webkit [81803] by commit-queue@webkit.org
  • 2 edits in trunk

2011-03-23 George Guo <​George.Guo@nokia.com>

Reviewed by Darin Adler.

Webkit warning: converting to 'unsigned int' from 'double'
​https://bugs.webkit.org/show_bug.cgi?id=56865

With -Werr enabled, this cause the build failure on RedHat Linux.
Add a cast helped.

  • Source/JavaScriptCore/runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
1:39 PM Changeset in webkit [81802] by hyatt@apple.com
  • 12 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56909

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever opacity changes or
a transform changes, this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

No new tests, since existing tests covered this very well (especially the opacity
and transforms repaint tests in fast/repaint).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

1:34 PM Changeset in webkit [81801] by mihaip@chromium.org
  • 19 edits
    4 copies
    4 moves
    1 add
    4 deletes in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Fix more tests for Chromium Snow Leopard by promoting chromium-mac/
results to mac-leopard/ where possible.

  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum.
  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Removed.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Removed.
  • platform/chromium-mac/css1/units/length_units-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/mac-leopard/css1/text_properties/text_indent-expected.checksum:
  • platform/mac-leopard/css1/text_properties/text_indent-expected.png:
  • platform/mac-leopard/css1/units/length_units-expected.checksum:
  • platform/mac-leopard/css1/units/length_units-expected.png:
  • platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum.
  • platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png.
  • platform/mac-leopard/fast/multicol/scrolling-overflow-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum.
  • platform/mac-leopard/fast/multicol/scrolling-overflow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png.
  • platform/mac/css1/text_properties/text_indent-expected.checksum:
  • platform/mac/css1/text_properties/text_indent-expected.png:
  • platform/mac/css1/units/length_units-expected.checksum:
  • platform/mac/css1/units/length_units-expected.png:
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.checksum:
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.png:
1:17 PM Changeset in webkit [81800] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/change-widget-and-click-crash.html on WebKit2, because
WebKit2 doesn't have an implementation of eventSender yet.

  • platform/mac-wk2/Skipped:
1:13 PM Changeset in webkit [81799] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-03-23 Tyler Close <​tjclose@chromium.org>

Reviewed by Jeremy Orlow.

Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
​https://bugs.webkit.org/show_bug.cgi?id=56950

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::callbackWithStringList):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_string_list):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::callbackWithStringList):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithStringList:]):
  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithStringList):
  • bindings/scripts/test/V8/V8TestCallback.h:
1:10 PM Changeset in webkit [81798] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Connection::SyncMessageState::processIncomingMessage should ignore whether the message is sync or not
​https://bugs.webkit.org/show_bug.cgi?id=56954

This is so we'll eventually be able to send sync messages that aren't processed immediately if the
destination is waiting for a reply to another synchronous message.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::processIncomingMessage): Only check for the DispatchMessageWhenWaitingForSyncReply flag.

(CoreIPC::Connection::sendSyncMessage):
Add both DispatchMessageWhenWaitingForSyncReply and SyncMessage to the message ID.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::sendSync): (CoreIPC::Connection::deprecatedSendSync): No need to add SyncMessage here anymore.
1:04 PM Changeset in webkit [81797] by crogers@google.com
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-23 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add API to retrieve the audio hardware sample-rate
​https://bugs.webkit.org/show_bug.cgi?id=56882

  • public/WebAudioDevice.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::audioHardwareSampleRate):
  • src/AudioDestinationChromium.cpp: (WebCore::AudioDestination::hardwareSampleRate):
12:52 PM Changeset in webkit [81796] by mihaip@chromium.org
  • 1 edit
    8 moves in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Fix fast/table for Chromium Snow Leopard by promoting the chromium-mac/
baselines to mac-leopard/.

  • platform/mac-leopard/fast/table/dynamic-descendant-percentage-height-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum.
  • platform/mac-leopard/fast/table/dynamic-descendant-percentage-height-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png.
  • platform/mac-leopard/fast/table/relative-position-containment-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-containment-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-containment-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-containment-expected.png.
  • platform/mac-leopard/fast/table/relative-position-offsets-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-offsets-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-offsets-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-offsets-expected.png.
  • platform/mac-leopard/fast/table/relative-position-stacking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-stacking-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-stacking-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-stacking-expected.png.
12:35 PM Changeset in webkit [81795] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Eric Seidel.

Add refptr for widget. Mutations can happen within the event handler.
​https://bugs.webkit.org/show_bug.cgi?id=56774

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent):

2011-03-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Eric Seidel.

Add refptr for widget. Mutations can happen within the event handler.
​https://bugs.webkit.org/show_bug.cgi?id=56774

Test: plugins/change-widget-and-click-crash.html

  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):

2011-03-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Eric Seidel.

Add test for crash when modifying a widget object within an event handler.
​https://bugs.webkit.org/show_bug.cgi?id=56774

  • plugins/change-widget-and-click-crash-expected.txt: Added.
  • plugins/change-widget-and-click-crash.html: Added.
12:32 PM Changeset in webkit [81794] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-03-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when casting a text fragment of an input box
to combine text.
​https://bugs.webkit.org/show_bug.cgi?id=56358

  • fast/text/input-box-text-fragment-combine-text-crash-expected.txt: Added.
  • fast/text/input-box-text-fragment-combine-text-crash.html: Added.

2011-03-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Add combine text cast checks since style property is insufficient
in telling object types.
​https://bugs.webkit.org/show_bug.cgi?id=56358

Test: fast/text/input-box-text-fragment-combine-text-crash.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):
12:29 PM Changeset in webkit [81793] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-23 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] "Unwavering" HTML5 game freezes the web page.
​https://bugs.webkit.org/show_bug.cgi?id=56944

For canvas's getImageData() API, we don't want to make a deep-copy of
the pixels, which is the case on Qt's "raster" graphics system.

To work around this, we trick QPixmap::toImage() into giving us the
QPixmap's backing QImage by temporarily pointing the paint engine to
a null paint device.

  • platform/graphics/qt/ImageBufferData.h:
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::toQImage): Added, returns the ImageBufferData as a QImage, avoiding a backend deep-copy if possible. (WebCore::ImageBuffer::platformTransformColorSpace): (WebCore::getImageData):
12:13 PM Changeset in webkit [81792] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-23 Viet-Trung Luu <​viettrungluu@chromium.org>

Reviewed by Tony Chang.

[chromium] Add FormatPlainText to WebClipboard::Format enumeration.
​https://bugs.webkit.org/show_bug.cgi?id=56868

Chromium's WebClipboard::isFormatAvailable() will be correspondingly
extended.

  • platform/chromium/PasteboardPrivate.h: Add corresponding enum entry.

This part of the change is inert and should have no effect.

2011-03-23 Viet-Trung Luu <​viettrungluu@chromium.org>

Reviewed by Tony Chang.

[chromium] Add FormatPlainText to WebClipboard::Format enumeration.
​https://bugs.webkit.org/show_bug.cgi?id=56868

Chromium's WebClipboard::isFormatAvailable() will be correspondingly
extended.

  • public/WebClipboard.h:
  • src/AssertMatchingEnums.cpp:
11:39 AM Changeset in webkit [81791] by mihaip@chromium.org
  • 47 edits
    30 copies
    23 moves in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Update Chromium Snow Leopard baselines for SVG tests after r81168.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/scrollbar-expected.png.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/selectionlist-expected.png.
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/image-small-width-height-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.txt.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.txt.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.txt.
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-align-02-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-align-02-b-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-fonts-02-t-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-text-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-text-01-b-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-tspan-01-b-expected.png.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
11:31 AM Changeset in webkit [81790] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Qt Build Fix.

  • DerivedSources.pro:
11:26 AM Changeset in webkit [81789] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

2011-03-23 Tyler Close <​tjclose@chromium.org>

Reviewed by Jeremy Orlow.

run-bindings-tests reference files are out of sync with CodeGenerator*.pm
​https://bugs.webkit.org/show_bug.cgi?id=56934

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::createStructure): (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): (WebCore::JSTestInterface::createPrototype):
  • bindings/scripts/test/JS/JSTestInterface.h: (WebCore::JSTestInterface::createStructure): (WebCore::JSTestInterfacePrototype::createStructure):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListenerConstructor::createStructure): (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListener::createPrototype):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::createStructure): (WebCore::JSTestMediaQueryListListenerPrototype::createStructure):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::createStructure): (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObj::createPrototype):
  • bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObj::createStructure): (WebCore::JSTestObjPrototype::createStructure):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore::JSTestSerializedScriptValueInterface::createStructure): (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
  • bindings/scripts/test/V8/V8TestCallback.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
11:17 AM Changeset in webkit [81788] by bweinstein@apple.com
  • 20 edits
    9 adds in trunk/Source/WebKit2

WebKit2: Need API to manage the Media Cache
​https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>

Reviewed by Darin Adler.

Project File Fun:

  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:


Derived Sources and API fun:

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:


  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Add a case for MediaCache messages.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Ditto.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the WebMediaCacheManagerProxy member variable.
(WebKit::WebContext::~WebContext): Invalidate the WebMediaCacheManagerProxy.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for MediaCache messages.

  • UIProcess/WebContext.h:

(WebKit::WebContext::mediaCacheManagerProxy):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetMediaCacheManager): Returns the context's WebMediaCacheManager.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKMediaCacheManager.cpp: Added.

(WKMediaCacheManagerGetTypeID): Returns the WebMediaCacheManagerProxy type.
(WKMediaCacheManagerGetHostnamesWithMediaCache): Calls down to the WebMediaCacheManagerProxy.
(WKMediaCacheManagerClearCacheForHostname): Ditto.
(WKMediaCacheManagerClearCacheForAllHostnames): Ditto.

  • UIProcess/API/C/WKMediaCacheManager.h: Added.
  • UIProcess/WebMediaCacheManagerProxy.cpp: Added.

(WebKit::WebMediaCacheManagerProxy::create):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::~WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::invalidate):
(WebKit::WebMediaCacheManagerProxy::didReceiveMessage):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache): Process the WebProcess response,

and call the callback.

(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames): Call through to the WebProcess.

  • UIProcess/WebMediaCacheManagerProxy.h: Added.

(WebKit::WebMediaCacheManagerProxy::clearContext):
(WebKit::WebMediaCacheManagerProxy::type):

  • UIProcess/WebMediaCacheManagerProxy.messages.in: Added.
  • WebProcess/MediaCache: Added.
  • WebProcess/MediaCache/WebMediaCacheManager.cpp: Added.

(WebKit::WebMediaCacheManager::shared):
(WebKit::WebMediaCacheManager::WebMediaCacheManager):
(WebKit::WebMediaCacheManager::didReceiveMessage):
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): Added a FIXME to call through to WebCore.
(WebKit::WebMediaCacheManager::clearCacheForHostname): Ditto.
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Ditto.

  • WebProcess/MediaCache/WebMediaCacheManager.h: Added.
  • WebProcess/MediaCache/WebMediaCacheManager.messages.in: Added.
10:58 AM Changeset in webkit [81787] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Daniel Bates <​dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Rename HTMLFrameSetElement::{noresize, frameborder, and frameBorderSet}
to conform to the WebKit Code style guidelines
​https://bugs.webkit.org/show_bug.cgi?id=56871

No functionality changed. So, no new tests.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): (WebCore::HTMLFrameSetElement::defaultEventHandler):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasFrameBorder): (WebCore::HTMLFrameSetElement::noResize):
10:43 AM Changeset in webkit [81786] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when accessing entries in the percent
height descendant map.
​https://bugs.webkit.org/show_bug.cgi?id=56902

  • fast/block/percent-height-descendant-not-removed-crash-expected.txt: Added.
  • fast/block/percent-height-descendant-not-removed-crash.html: Added.

2011-03-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Replace height with logicalHeight when removing items from
gPercentHeightDescendantMap so that it is writing mode aware.
​https://bugs.webkit.org/show_bug.cgi?id=56902

Test: fast/block/percent-height-descendant-not-removed-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleDidChange):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
10:39 AM Changeset in webkit [81785] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-23 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a GTK+ result after r81684.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:36 AM Changeset in webkit [81784] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

  • inspector/DOMNodeHighlighter.cpp:

Remove an unused function.

10:32 AM Changeset in webkit [81783] by mihaip@chromium.org
  • 109 edits
    6 copies
    8 moves
    44 deletes in trunk/LayoutTests

2011-03-23 Mihai Parparita <​mihaip@chromium.org>

Update pixel results for Snow Leopard after r80755. Where possible,
chromium-mac results were promoted to mac-leopard, except for cases
where Chromium behavior due to bug 52335 or form control rendering.

  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Removed.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Removed.
  • platform/chromium-mac/fast/lists/008-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Removed.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Removed.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
  • platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
  • platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
  • platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png:
  • platform/mac-leopard/fast/css/ex-after-font-variant-expected.checksum:
  • platform/mac-leopard/fast/css/ex-after-font-variant-expected.png:
  • platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.png:
  • platform/mac-leopard/fast/lists/008-expected.checksum:
  • platform/mac-leopard/fast/lists/008-expected.png:
  • platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac-leopard/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac-leopard/fast/overflow/overflow-rtl-expected.png:
  • platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/mac-leopard/fast/replaced/width100percent-radio-expected.checksum:
  • platform/mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
  • platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
  • platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
  • platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
  • platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
  • platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.png:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
  • platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
  • platform/mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-2-expected.png:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/mac/editing/selection/caret-ltr-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-expected.png:
  • platform/mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-right-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-right-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-right-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/css/ex-after-font-variant-expected.checksum:
  • platform/mac/fast/css/ex-after-font-variant-expected.png:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.png:
  • platform/mac/fast/lists/008-expected.checksum:
  • platform/mac/fast/lists/008-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/mac/fast/replaced/width100percent-radio-expected.checksum:
  • platform/mac/fast/replaced/width100percent-radio-expected.png:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.png:
10:26 AM Changeset in webkit [81782] by beidson@apple.com
  • 11 edits in trunk/Source

2011-03-22 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Add asynchronous load decision call to WebKit2 IconDatabase
​https://bugs.webkit.org/show_bug.cgi?id=56887

Clear the callback when it's made:

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueIconLoadWithDecision):

Don't load icons when using new-style icon database if in private browsing:

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueIconLoadWithDecision):


Enhance the IconDatabase callbacks to have an ID and inherit from a common base:

  • loader/icon/IconDatabaseBase.h: (WebCore::CallbackBase::~CallbackBase): (WebCore::CallbackBase::callbackID): (WebCore::CallbackBase::CallbackBase): (WebCore::CallbackBase::context): (WebCore::CallbackBase::generateCallbackID): (WebCore::EnumCallback::performCallback): (WebCore::EnumCallback::EnumCallback): (WebCore::ObjectCallback::performCallback): (WebCore::ObjectCallback::ObjectCallback):

2011-03-22 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Add asynchronous load decision call to WebKit2 IconDatabase
​https://bugs.webkit.org/show_bug.cgi?id=56887

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): In the future, get the actual load decision from the database. For now, always message "IconLoadNo" back to the WebProcess.
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabase.messages.in:


  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: (WebKit::WebIconDatabaseProxy::loadDecisionForIconURL): Message the UIProcess for the load decision. (WebKit::WebIconDatabaseProxy::receivedIconLoadDecision): Callback into WebCore with the received load decision.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in:
10:02 AM Changeset in webkit [81781] by yurys@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: Remove DebuggerScript.js from Chromium resource bundle.
​https://bugs.webkit.org/show_bug.cgi?id=56916

  • DEPS: bump up Chromium dependency to the revision where no references to the DebuggerScript.js resource are left.
  • WebKit.grd:
9:49 AM Changeset in webkit [81780] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move scripts concatenation logic to SourceFile.
​https://bugs.webkit.org/show_bug.cgi?id=56756

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._requestContent): (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent):
9:47 AM Changeset in webkit [81779] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add a flag to RuntimeEnabledFeatures.
​https://bugs.webkit.org/show_bug.cgi?id=56921

Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.

Tests for the Media Stream API will be provided by the bug 56587.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::mediaStreamEnabled): (WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled): (WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
9:38 AM Changeset in webkit [81778] by carol.szabo@nokia.com
  • 3 edits
    2 adds in trunk

2011-03-23 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Added new test to expose failure to correctly find the
before/after container when creating a CSS counter.

CSS 2.1 failure: various before-after-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=47207

  • fast/css/counters/complex-before-expected.txt: Added.
  • fast/css/counters/complex-before.html: Added.

2011-03-23 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Modified RenderCounter::originalText() to correctly attach
the created counter to the before/after container even when
that is not the RenderCounter's direct parent.

CSS 2.1 failure: various before-after-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=47207

Test: fast/css/counters/complex-before.html

  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText):
9:21 AM Changeset in webkit [81777] by gyuyoung.kim@samsung.com
  • 5 edits
    5 adds in trunk/Source

2011-03-23 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add play / pause button to media control
​https://bugs.webkit.org/show_bug.cgi?id=55463

Add play|pause button to media control.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::edjeGroupFromFormType): (WebCore::RenderThemeEfl::emitMediaButtonSignal): Added. (WebCore::RenderThemeEfl::paintMediaPlayButton):
  • platform/efl/RenderThemeEfl.h:

2011-03-23 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add play / pause button to media control
​https://bugs.webkit.org/show_bug.cgi?id=55463

Add play|pause button to media control.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Added.
  • DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Added.
9:03 AM Changeset in webkit [81776] by yurys@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: remove inspectNode method from WebDevToolsAgent
​https://bugs.webkit.org/show_bug.cgi?id=56926

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
8:54 AM Changeset in webkit [81775] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-23 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit rendering problem when maximizing and doing a back
​https://bugs.webkit.org/show_bug.cgi?id=56669

Contents of the page are not re-sized on going back after
maximizing. ContentsResized() is not getting called. Hence old
document width and height are used. Corrected this behaviour by
calling setBoundsSize() which calls contentsSize().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open):

2011-03-23 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit rendering problem when maximizing and doing a back
​https://bugs.webkit.org/show_bug.cgi?id=56669

Added an auto test.
Patch by Alexis Menard < ​alexis.menard@nokia.com> on 2011-03-21

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::rendering):
8:04 AM Changeset in webkit [81774] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for formating source files in debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56558

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.get scripts):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._reset):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.scriptLocationToSourceLocation): (WebInspector.SourceFile.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceFile): (WebInspector.FormattedSourceFile.prototype.scriptLocationToSourceLocation): (WebInspector.FormattedSourceFile.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceFile.prototype._didRequestContent):
7:04 AM Changeset in webkit [81773] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use unsigned char instead of char when storing script source
​https://bugs.webkit.org/show_bug.cgi?id=56920

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptSource):
  • inspector/InjectedScriptSource.js: whitespace change to trigger compilation
  • inspector/xxd.pl:
  • xml/XMLViewer.xsl:
6:56 AM Changeset in webkit [81772] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-03-23 Luca Ferretti <​lferrett@gnome.org>

Rubber-stamped by Gustavo Noronha.

Italian translation update.

  • it.po: Updated.
6:22 AM Changeset in webkit [81771] by loislo@chromium.org
  • 18 edits
    2 adds in trunk/Source/WebCore

2011-03-23 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move node searching and node highlight related methods from InspectorAgent to InspectorDOMAgent.
​https://bugs.webkit.org/show_bug.cgi?id=56912

The next functions were moved:

setSearchingForNode
highlightDOMNode
hideDOMNodeHighlight
highlightFrame
hideFrameHighlight
mouseDidMoveOverElement
handleMousePress

The code which does real highlight in Graphic context was moved to new files DOMNodeHighlighter.*

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMNodeHighlighter.cpp: Added. (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  • inspector/DOMNodeHighlighter.h: Added.
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::hideHighlight):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::clearFrontend): (WebCore::InspectorDOMAgent::handleMousePress): (WebCore::InspectorDOMAgent::mouseDidMoveOverElement): (WebCore::InspectorDOMAgent::searchingForNodeInPage): (WebCore::InspectorDOMAgent::setSearchingForNode): (WebCore::InspectorDOMAgent::highlight): (WebCore::InspectorDOMAgent::highlightDOMNode): (WebCore::InspectorDOMAgent::highlightFrame): (WebCore::InspectorDOMAgent::hideHighlight): (WebCore::InspectorDOMAgent::drawNodeHighlight):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideDOMNodeHighlight): (WebCore::InspectorDOMAgent::hideFrameHighlight):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorAgent): (WebCore::InstrumentingAgents::setInspectorAgent):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.js: (WebInspector.highlightDOMNode):
6:19 AM Changeset in webkit [81770] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Rollout r81768 which broke compilation on Win.

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.xsl:
6:11 AM Changeset in webkit [81769] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Update expected files after r81684.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
5:56 AM Changeset in webkit [81768] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer
​https://bugs.webkit.org/show_bug.cgi?id=56919

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.xsl: whitespace change to trigger compilation.
5:52 AM Changeset in webkit [81767] by podivilov@chromium.org
  • 7 edits
    1 add in trunk

2011-03-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move content loading logic to a new SourceFile class.
​https://bugs.webkit.org/show_bug.cgi?id=56748

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  • inspector/front-end/SourceFile.js: Added. (WebInspector.SourceFile): (WebInspector.SourceFile.prototype.addScript): (WebInspector.SourceFile.prototype.requestContent): (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype.reload): (WebInspector.SourceFile.prototype._requestContent): (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadScriptContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent): (WebInspector.SourceFile.prototype._didRequestContent): (WebInspector.SourceFile.prototype._hasPendingResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:41 AM Changeset in webkit [81766] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-23 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix compilation broken by r81758.

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
5:35 AM Changeset in webkit [81765] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: define array types properly in the Inspector.json
​https://bugs.webkit.org/show_bug.cgi?id=56915

  • inspector/Inspector.json:
  • inspector/generate-inspector-idl:
4:34 AM Changeset in webkit [81764] by pfeldman@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-23 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: bring back Vector::contains that was removed as a part of roll back.

  • wtf/Vector.h: (WTF::::contains):
4:09 AM Changeset in webkit [81763] by pfeldman@chromium.org
  • 10 edits
    7 deletes in trunk/Source

2011-03-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81686.
​http://trac.webkit.org/changeset/81686
​https://bugs.webkit.org/show_bug.cgi?id=56914

Breaks webkit_tests in Chromium again. (Requested by pfeldman
on #webkit).

  • wtf/Vector.h:

2011-03-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81686.
​http://trac.webkit.org/changeset/81686
​https://bugs.webkit.org/show_bug.cgi?id=56914

Breaks webkit_tests in Chromium again. (Requested by pfeldman
on #webkit).

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h:
  • public/WebVector.h: (WebKit::WebVector::operator[]):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp:
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Removed.
  • tests/data/pageserialization/awesome.png: Removed.
  • tests/data/pageserialization/embed_iframe.html: Removed.
  • tests/data/pageserialization/object_iframe.html: Removed.
  • tests/data/pageserialization/simple_iframe.html: Removed.
  • tests/data/pageserialization/simple_page.html: Removed.
  • tests/data/pageserialization/top_frame.html: Removed.
4:09 AM Changeset in webkit [81762] by yurys@chromium.org
  • 7 edits in trunk

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
​https://bugs.webkit.org/show_bug.cgi?id=56843

  • inspector/front-end/WebKit.qrc:

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
​https://bugs.webkit.org/show_bug.cgi?id=56843

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:

2011-03-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
​https://bugs.webkit.org/show_bug.cgi?id=56843

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
3:53 AM BuildingQtOnLinux edited by benjamin.poulain@nokia.com
(diff)
3:33 AM Changeset in webkit [81761] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-23 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Add a star while editing a source code
​https://bugs.webkit.org/show_bug.cgi?id=56743

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing): (WebInspector.SourceFrame.prototype._registerShortcuts): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing): (WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
3:30 AM Changeset in webkit [81760] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-23 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Scrolling and navigation is not smooth on a script with many long lines
​https://bugs.webkit.org/show_bug.cgi?id=56559

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines): (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines): (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
3:17 AM Changeset in webkit [81759] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

JavaScriptCore GYP build should work on a case-sensitive file system
​https://bugs.webkit.org/show_bug.cgi?id=56911

The issue is that there are two UString.h headers, one named UString.h
and one named ustring.h. This patch excludes ustring.h from the header
map to avoid confusion. While I was editing this part of the GYP file,
I cleaned up the exclude rules to be more modern.

  • gyp/JavaScriptCore.gyp:
3:09 AM Changeset in webkit [81758] by yurys@chromium.org
  • 11 edits in trunk/Source

2011-03-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
​https://bugs.webkit.org/show_bug.cgi?id=56843

DebuggerScript.js is now translated into a char[] array before inspector compilation.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptSource):
  • inspector/InjectedScriptSource.js: whitespace change to trigger InjectedScriptSource.h generation.
  • inspector/xxd.pl:

2011-03-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
​https://bugs.webkit.org/show_bug.cgi?id=56843

  • public/WebDevToolsAgentClient.h: the script source is now compiled along with the inspector code.
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach):
2:49 AM Changeset in webkit [81757] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: remove obsolete methods from WebDevToolsAgentClient.h
​https://bugs.webkit.org/show_bug.cgi?id=56897

  • public/WebDevToolsAgentClient.h:
12:34 AM Changeset in webkit [81756] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::initializeNewContext):

12:21 AM Changeset in webkit [81755] by Chris Fleizach
  • 4 edits in trunk/Source/WebKit2

2011-03-23 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

REGRESSION: WK2: AX: PDF in Safari no longer accessible.
​https://bugs.webkit.org/show_bug.cgi?id=56849

The WKView needs to know when to return the WKPDFView and when to return
the remote web process connection.

  • UIProcess/API/mac/PDFViewController.h: (WebKit::PDFViewController::pdfView):
  • UIProcess/API/mac/WKView.mm: (-[WKView accessibilityFocusedUIElement]): (-[WKView accessibilityHitTest:]): (-[WKView accessibilityAttributeValue:]):
12:16 AM Changeset in webkit [81754] by abarth@webkit.org
  • 2 edits in trunk

2011-03-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should default to Production configuration
​https://bugs.webkit.org/show_bug.cgi?id=56899

  • Source/gyp/common.gypi:

Mar 22, 2011:

11:44 PM Changeset in webkit [81753] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] skia image encoders should use <wtf/Vector.h>
​https://bugs.webkit.org/show_bug.cgi?id=56893

No new tests. Covered by existing canvas.toDataURL tests.

  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.h:
10:42 PM Changeset in webkit [81752] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

Unskipped some tests, now that ​https://bugs.webkit.org/show_bug.cgi?id=54490
is fixed.

Rubber-stamped by Beth Dakin.

  • platform/win/Skipped:
10:21 PM Changeset in webkit [81751] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts
panel on Windows, and many inspector regression tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=54490


The bug was caused by two different classes using the same name (Recompiler).

  • debugger/Debugger.cpp:
  • runtime/JSGlobalData.cpp: (WTF::Recompiler::operator()): Put Recompiler in an anonymous namespace, so our two recompilers' inline functions don't stomp each other at link time.
10:15 PM Changeset in webkit [81750] by mihaip@chromium.org
  • 1 edit
    82 moves
    1 add
    41 deletes in trunk/LayoutTests

2011-03-22 Mihai Parparita <​mihaip@chromium.org>

Fix baselines for svg/W3C-I18N for Chromium Snow Leopard. Mac SL
baselines were added with r81168, so the Chromium ones only need to
be in chromium-mac-leopard/ (so that they don't override them). The
chromium-mac/ text baselines can be deleted, since we can now
fall back on the mac-leopard/ ones added by r81176.

  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
9:51 PM Changeset in webkit [81749] by mihaip@chromium.org
  • 1 edit
    90 moves
    90 adds in trunk/LayoutTests

2011-03-22 Mihai Parparita <​mihaip@chromium.org>

Add Snow Leopard baselines for fast/html/details* tests added by r81035
(should work for both Mac and Chromium-Mac). Promote current
chromium-mac baselines to mac-leopard, since they work for both on
Leopard.

  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.checksum.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.png.
  • platform/mac-leopard/fast/html/details-open1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.checksum.
  • platform/mac-leopard/fast/html/details-open1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.png.
  • platform/mac-leopard/fast/html/details-open2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.checksum.
  • platform/mac-leopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/mac-leopard/fast/html/details-open3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.checksum.
  • platform/mac-leopard/fast/html/details-open3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.png.
  • platform/mac-leopard/fast/html/details-open4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.checksum.
  • platform/mac-leopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/mac-leopard/fast/html/details-open5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.checksum.
  • platform/mac-leopard/fast/html/details-open5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.png.
  • platform/mac-leopard/fast/html/details-open6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.checksum.
  • platform/mac-leopard/fast/html/details-open6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.png.
  • platform/mac-leopard/fast/html/details-position-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.checksum.
  • platform/mac-leopard/fast/html/details-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.checksum.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.png.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/mac/fast/html/details-open1-expected.checksum: Added.
  • platform/mac/fast/html/details-open1-expected.png: Added.
  • platform/mac/fast/html/details-open2-expected.checksum: Added.
  • platform/mac/fast/html/details-open2-expected.png: Added.
  • platform/mac/fast/html/details-open3-expected.checksum: Added.
  • platform/mac/fast/html/details-open3-expected.png: Added.
  • platform/mac/fast/html/details-open4-expected.checksum: Added.
  • platform/mac/fast/html/details-open4-expected.png: Added.
  • platform/mac/fast/html/details-open5-expected.checksum: Added.
  • platform/mac/fast/html/details-open5-expected.png: Added.
  • platform/mac/fast/html/details-open6-expected.checksum: Added.
  • platform/mac/fast/html/details-open6-expected.png: Added.
  • platform/mac/fast/html/details-position-expected.checksum: Added.
  • platform/mac/fast/html/details-position-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/mac/fast/html/details-writing-mode-expected.png: Added.
9:28 PM Changeset in webkit [81748] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 81648
BUG=76784

8:44 PM Changeset in webkit [81747] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Move the cellWidthChanged bit out of RenderObject and back down into RenderTableCell in order to
free up a bit for another performance optimization I have planned.

Reviewed by Beth Dakin.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setHasColumns):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::cellWidthChanged):
(WebCore::RenderTableCell::setCellWidthChanged):

8:27 PM Changeset in webkit [81746] by hyatt@apple.com
  • 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56892

Reviewed by Dan Bernstein.

Adding floats to an empty block is O(n2).

If you just add floats back to back to an empty block, the addition is essentially O(n2)
once the floats move below your current line position. This is because we repeatedly ask for the
available width for the line from scratch every time we add a float, regardless of whether the
float even vertically intersected our current line position.

Change positionNewFloatOnLine to update left and right line offsets intelligently and to only
do it based off the single new float that just got added.

This fix cuts the IE MazeSolver time in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

8:15 PM Changeset in webkit [81745] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56890 It is possible to calculate a
NaN value for "value" in ScrollbarThemeMac::paint()
-and corresponding-
<rdar://problem/9160621>

Reviewed by Sam Weinig.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

8:09 PM Changeset in webkit [81744] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-22 Ojan Vafai <​ojan@chromium.org>

Add a chromium expectation for this test. V8's exception logging
is more specific than JSC's.

  • platform/chromium/fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
6:45 PM Changeset in webkit [81743] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-22 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove identity from dragTargetDragEnter() function signature
​https://bugs.webkit.org/show_bug.cgi?id=56875

First part of 3-sided patch. Add new function signature sans identity.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter):
  • src/WebViewImpl.h:
6:44 PM Changeset in webkit [81742] by ojan@chromium.org
  • 18 edits
    4 adds in trunk

2011-03-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
​https://bugs.webkit.org/show_bug.cgi?id=38095

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/pseudo-any-expected.txt: Added.
  • fast/css/pseudo-any.html: Added.
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
  • fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
  • fast/dom/SelectorAPI/unknown-pseudo.html: Added.

2011-03-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
​https://bugs.webkit.org/show_bug.cgi?id=38095

For now, match the Mozilla implementation with respect to specificity
and only allowing simple selectors. Both of these are likely to change
pending discussion on www-style@.

Tests: fast/css/pseudo-any.html

fast/dom/SelectorAPI/unknown-pseudo.html

  • css/CSSGrammar.y: Create simple_selector_list. This is exactly like selector_list except it only allows simple selectors and creates a new vector instead of a reusable one since there can be multiple in one rule.
  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::createFloatingSelectorVector): (WebCore::CSSParser::sinkFloatingSelectorVector):
  • css/CSSParser.h:
  • css/CSSParserValues.cpp: (WebCore::CSSParserSelector::adoptSelectorVector):
  • css/CSSParserValues.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::selectorText): (WebCore::CSSSelector::setSelectorList): (WebCore::CSSSelector::RareData::RareData): (WebCore::CSSSelector::RareData::~RareData): These need to be moved into the cpp file so that we can have an OwnPtr<CSSSelectorList> in CSSSelector::RareData.
  • css/CSSSelector.h: (WebCore::CSSSelector::selectorList):
  • css/CSSSelectorList.cpp: (WebCore::forEachTagSelector):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector):
  • css/tokenizer.flex:
6:27 PM Changeset in webkit [81741] by mihaip@chromium.org
  • 1 edit
    45 deletes in trunk/LayoutTests

2011-03-22 Mihai Parparita <​mihaip@chromium.org>

Remove duplicated test expectations for details tests (expectations were
added to the mac/ directory with r81062, so chromium-mac ones are no
longer necessary).

  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Removed.
6:24 PM Changeset in webkit [81740] by commit-queue@webkit.org
  • 17 edits in trunk/Source

2011-03-22 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
​https://bugs.webkit.org/show_bug.cgi?id=56431

For the accelerated compositing case, only prepare the texture if it
has been updated since the last composite. For the non-accelerated case, make sure to
grab a copy of the image buffer and paint from that if the backbuffer
would be cleared.

In both cases, make sure to clear the context's backbuffer before the
first operation that uses it.

No new tests. It seems to be difficult/impossible to trigger an early
compositing operation in DumpRenderTree, making this hard to
test automatically. However, Chromium and Safari (Mac) have been
tested manually on the webgl conformance test for this.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::makePresentationCopy): (WebCore::HTMLCanvasElement::clearPresentationCopy):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLContextAttributes.cpp: (WebCore::WebGLContextAttributes::preserveDrawingBuffer): (WebCore::WebGLContextAttributes::setPreserveDrawingBuffer):
  • html/canvas/WebGLContextAttributes.h:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::markLayerComposited): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::readPixels):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty): (WebCore::WebGLLayerChromium::textureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::layerComposited):

2011-03-22 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
​https://bugs.webkit.org/show_bug.cgi?id=56431

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::markContextChanged): (WebCore::GraphicsContext3DInternal::markLayerComposited): (WebCore::GraphicsContext3DInternal::layerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • src/GraphicsContext3DInternal.h:
6:19 PM Changeset in webkit [81739] by weinig@apple.com
  • 9 edits in trunk/Source

Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
<rdar://problem/8944718>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • DerivedSources.make:

Remove generation of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.

Source/WebCore:

  • DerivedSources.make:

Remove generation of HeaderDetection.h.

  • WebCore.xcodeproj/project.pbxproj:

Remove HeaderDetection.h.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

Replace use of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER with USE(WK_SCROLLBAR_PAINTER).

6:19 PM Changeset in webkit [81738] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-22 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56488
Some transitions/animations tests fail assertion in AnimationBase::updateStateMachine

Turning some tests back on after r81722.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • unskipping animations/suspend-resume-animation-events.html compositing/transitions/scale-transition-no-start.html compositing/transitions/singular-scale-transition.html
6:13 PM Changeset in webkit [81737] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Properly reset VideoLayerChromium textures after lost renderer context
​https://bugs.webkit.org/show_bug.cgi?id=56514

The VideoLayerChromium textures were still mapped to the old
renderer's context when LayerRendererChromium was being recreated
i.e. when GPU process is killed. This patch allows VideoLayerChromium
it recreate textures in the new context when the old renderer is lost.
Patch also does a bit of refactoring and code clean-up.

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::~VideoLayerChromium): (WebCore::VideoLayerChromium::cleanupResources): (WebCore::VideoLayerChromium::updateContentsIfDirty): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::computeVisibleSize): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA): (WebCore::VideoLayerChromium::resetFrameParameters): (WebCore::VideoLayerChromium::saveCurrentFrame):
  • platform/graphics/chromium/VideoLayerChromium.h:
6:11 PM Changeset in webkit [81736] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should export the headers needed by WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56883

  • WebCore.gypi:
  • gyp/WebCore.gyp:
    • Export a couple more headers.
    • Remove FIXME comments for things we've already fixed.
6:08 PM Changeset in webkit [81735] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach update-webkit about gyp
​https://bugs.webkit.org/show_bug.cgi?id=56881

This makes it possible for someone who builds from Xcode
to just run update-webkit --gyp and have the project files
generated after update automatically.

I also added a stand-alone "generate-project-files" script
wrapping Source/gyp/configure. This makes running gyp simpler
since most people will not have gyp or Source/gyp in their path.

  • Scripts/build-webkit:
  • Scripts/generate-project-files: Added.
  • Scripts/update-webkit:
6:05 PM Changeset in webkit [81734] by Stephanie Lewis
  • 3 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56798
Wrap autorelease pools around calls that can have pathological memory growth on Membuster.
Only wrap the main runloop because some background threads are not expected to call into
objc and an autorelease pool could mask bugs.

Reviewed by Simon Fraser.

  • Platform/mac/RunLoopMac.mm:

(RunLoop::performWork):
(RunLoop::TimerBase::timerFired):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):

5:57 PM Changeset in webkit [81733] by commit-queue@webkit.org
  • 21 edits
    4 adds in trunk

2011-03-22 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
​https://bugs.webkit.org/show_bug.cgi?id=56722

This test twice retrieves lists of origins with application cache.
First, after deleting all application cache and after adding an iframe with an
application cache.

  • http/tests/appcache/origins-with-appcache-expected.txt: Added.
  • http/tests/appcache/origins-with-appcache.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:

2011-03-22 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
​https://bugs.webkit.org/show_bug.cgi?id=56722

Added test that exercises WebCore API to get origins with application cache.

Test: http/tests/appcache/origins-with-appcache.html

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-22 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
​https://bugs.webkit.org/show_bug.cgi?id=56722

Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]):

2011-03-22 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
​https://bugs.webkit.org/show_bug.cgi?id=56722

  • DumpRenderTree/LayoutTestController.cpp: (originsWithApplicationCacheCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers. (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers. (LayoutTestController::originsWithApplicationCache): (LayoutTestController::originsWithLocalStorage):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
5:33 PM Changeset in webkit [81732] by andersca@apple.com
  • 5 edits in trunk/Source

2011-03-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
​https://bugs.webkit.org/show_bug.cgi?id=56879

  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.

2011-03-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
​https://bugs.webkit.org/show_bug.cgi?id=56879

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromPropertyLists): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.


  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::pluginSupportsExtension): Add a new helper function.

(WebKit::WebFrameLoaderClient::objectContentType):
If we can't find the MIME for an extension, explicitly check if there's a plugin that claims to
handle the given extension.

5:28 PM Changeset in webkit [81731] by simonjam@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-03-22 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium gpu tests after r81715.

  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.png: Added.
5:26 PM Changeset in webkit [81730] by cevans@google.com
  • 3 edits
    6 copies in branches/chromium/696

Merge 81611
BUG=75801

5:24 PM Changeset in webkit [81729] by jam@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-22 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Make WebTextCheckingResult&apos;s members be public in preparation for converting it to a struct
​https://bugs.webkit.org/show_bug.cgi?id=56857

  • DEPS:
  • public/WebTextCheckingResult.h:
5:23 PM Changeset in webkit [81728] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 81689
BUG=76646

5:21 PM Changeset in webkit [81727] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-22 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56242
transitions/interrupted-accelerated-transition.html was failing

Unskipping this after r81722

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
5:21 PM Changeset in webkit [81726] by loki@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-22 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add DFG module to build system (disabled by default).
​https://bugs.webkit.org/show_bug.cgi?id=56845

5:07 PM Changeset in webkit [81725] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] New resolve url tests don't pass on Chromium. Skipping them.
​https://bugs.webkit.org/show_bug.cgi?id=56800

  • platform/chromium/test_expectations.txt: Skip all tests in http/tests/filesystem/workers. They can't run in test_shell, and are instead run in Chromium's ui_tests.
5:04 PM Changeset in webkit [81724] by carol.szabo@nokia.com
  • 7 edits in trunk/Source/WebCore

2011-03-22 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Introduced double linkage between a CounterNode and its display renderer.

use of freed pointer in WebCore::RenderCounter::originalText()
​https://bugs.webkit.org/show_bug.cgi?id=56065

No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.

  • rendering/CounterNode.cpp: Introduced new member "m_owner" to store the renderer that has the style directives that produce the CounterNode. Repurposed m_renderer to reffer to the RenderCounter that shows the CounterNode. (WebCore::CounterNode::CounterNode): Updated member initialization. (WebCore::CounterNode::create): (WebCore::CounterNode::addRenderer): (WebCore::CounterNode::removeRenderer): Introduced to manage the renderer list associated wit this CounterNode. (WebCore::CounterNode::resetRenderers): This is the old resetRenderer. Renamed to take into account that there may be more than one renderer to a CounterNode. (WebCore::CounterNode::resetThisAndDescendantsRenderers): This is the old resetRenderers renamed for clarity. (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): No functional changes. (WebCore::showTreeAndMark): Added flushing to ensure that the output is complete.
  • rendering/CounterNode.h: (WebCore::CounterNode::owner): Renamed from renderer()
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed comments. No functional changes. (WebCore::RenderCounter::~RenderCounter): Made sure that the CounterNode that this renderers displays is detached from this. (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): Changed to maintain the bidirectional relationship with the displayed CounterNode. Also made "invalidate" private as it should be used only by CounterNode. (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): No change, just kept code in line with the changes above. (showCounterRendererTree): Added fflush to ensure complete display.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h: Removed unneeded invalidateCounters related functions.
5:00 PM Changeset in webkit [81723] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-22 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Rename the synchronous icon database messages to be prefixed with "synchronous"

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::synchronousIconDataForPageURL): (WebKit::WebIconDatabase::synchronousIconURLForPageURL): (WebKit::WebIconDatabase::synchronousIconDataKnownForIconURL): (WebKit::WebIconDatabase::synchronousLoadDecisionForIconURL):
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabase.messages.in:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: (WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
4:52 PM Changeset in webkit [81722] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

2011-03-22 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=56242
Interrupted accelerated animations/transitions were causing
subsequent animations to not start (because they were stuck
waiting for a response from the compositing layer). I renamed
the instance variable that indicates whether or not to
notify animations of start time, from m_waitingForStartTimeResponse
to m_waitingForAsyncStartNotification, so that it makes more sense.
The actual bug fix was changing the logic so that the flag is reset
when the list of waiting animations becomes empty. I mistakenly committed
the bad logic in r81613.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
  • Always set paused time as we enter the paused state
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
  • reset the waiting flag when the list is empty (rather than not empty) (WebCore::AnimationControllerPrivate::startTimeResponse):
  • page/animation/AnimationControllerPrivate.h:
  • rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification
4:43 PM Changeset in webkit [81721] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Loading a new tab does not dismiss Lookup
<rdar://problem/9138391>

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
Hide the dictionary popup when moving the WKView out of a window.

4:30 PM Changeset in webkit [81720] by cevans@google.com
  • 24 edits
    4 copies in branches/chromium/696

Merge 81018
BUG=75436

4:29 PM Changeset in webkit [81719] by beidson@apple.com
  • 10 edits in trunk/Source

<rdar://problem/8648311> and ​https://bugs.webkit.org/show_bug.cgi?id=56876
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread

Reviewed by Sam Weinig.

../WebCore:

  • loader/icon/IconDatabase.cpp:

Add a dummy client implementation for non-Mac, non-Win ports:
(WebCore::DefaultIconDatabaseClient::performImport):
(WebCore::DefaultIconDatabaseClient::didImportIconURLForPageURL):
(WebCore::DefaultIconDatabaseClient::didImportIconDataForPageURL):
(WebCore::DefaultIconDatabaseClient::didChangeIconForPageURL):
(WebCore::DefaultIconDatabaseClient::didRemoveAllIcons):
(WebCore::DefaultIconDatabaseClient::didFinishURLImport):
(WebCore::defaultClient):

Either call the client directly when on the main thread, or use the dispatch functions below
if on the background thread:
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::removeAllIconsOnThread):

Add a very targeted WorkItem interface for dispatching client calls on the main thread:
(WebCore::ClientWorkItem::ClientWorkItem):
(WebCore::ClientWorkItem::~ClientWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::performWork):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::performWork):
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem):
(WebCore::RemovedAllIconsWorkItem::performWork):
(WebCore::performWorkItem):

Use the client WorkItem interface to perform these callbacks on the main thread:
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseClient.h:

../WebKit/mac:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebIconDatabaseClient.mm:

(WebIconDatabaseClient::didRemoveAllIcons):
(WebIconDatabaseClient::didImportIconURLForPageURL):
(WebIconDatabaseClient::didImportIconDataForPageURL):
(WebIconDatabaseClient::didChangeIconForPageURL):
(WebIconDatabaseClient::didFinishURLImport):

../WebKit/win:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebIconDatabase.cpp:

(WebIconDatabase::performImport):
(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::didImportIconDataForPageURL):
(WebIconDatabase::didChangeIconForPageURL):
(WebIconDatabase::didFinishURLImport):

  • WebIconDatabase.h:
4:29 PM Changeset in webkit [81718] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-03-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81683.
​http://trac.webkit.org/changeset/81683
​https://bugs.webkit.org/show_bug.cgi?id=56872

Crashing in some tests (Requested by weinig on #webkit).

  • win/lib/WebKitSystemInterface.lib:
4:23 PM Changeset in webkit [81717] by eric@webkit.org
  • 4 edits in trunk

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
​https://bugs.webkit.org/show_bug.cgi?id=56877

Found a couple missing Private headers while trying to make WebCore build.

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
​https://bugs.webkit.org/show_bug.cgi?id=56877

build-webkit is a cesspool. This change just hacks in --gyp support for Mac.
Eventually we'll want to support gyp-generated projects in a more general manner.

  • Scripts/build-webkit:
4:21 PM Changeset in webkit [81716] by hyatt@apple.com
  • 10 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56869

Reviewed by Simon Fraser.

Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
a little faster than having to access the information from the RenderStyle's sub-structure.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::logicalScroll):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::styleWillChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::setHorizontalWritingMode):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::scrollbarsChanged):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::verticalPositionForBox):

4:17 PM Changeset in webkit [81715] by Simon Fraser
  • 5 edits
    8 adds in trunk

2011-03-22 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Incorrect rendering of composited element with negative z-index child
​https://bugs.webkit.org/show_bug.cgi?id=56846

When a composited element has a child with negative z-index, we make
a separate layer for that element's foreground content. This layer
was positioned incorrectly (but the content happened to paint at
the right location), resulting in right/bottom clipping.

Fix this, remove the little-used graphicsLayerToContentsCoordinates()
contentsToGraphicsLayerCoordinates() methods, and optimize incremental
repaints in the foreground and mask layers.

Tests: compositing/geometry/foreground-layer.html

compositing/geometry/repaint-foreground-layer.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints which fall outside the layer bounds, so callers don't have to, and to avoid unnecessary layer commits.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If we have a foreground layer inside a clipping layer, the foreground layer's offset is zero, since the clipping layer is its parent.

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
Also do incremental repaints of the foreground and mask layers.

(WebCore::RenderLayerBacking::paintContents): It was incorrect to always
use compositedBounds() to compute the painting offset, since that's
per-RenderLayerBacking, but a single RenderLayerBacking can have different
GraphicsLayers with different offsets (e.g. the foreground layer).
Instead, use offsetFromRenderer(), which gives has the correct offset.

  • rendering/RenderLayerBacking.h: Remove unused methods.
4:14 PM Changeset in webkit [81714] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/696

Merge 81643
BUG=76031

4:10 PM Changeset in webkit [81713] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/696

Merge 81536
BUG=76198

3:45 PM Changeset in webkit [81712] by abarth@webkit.org
  • 2 edits in trunk

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

gyp/configure shouldn&apos;t require GYP to be in your path
​https://bugs.webkit.org/show_bug.cgi?id=56873

Now that GYP is on Source/ThirdParty/gyp, we can just use that copy
instead of requiring GYP to be in the user's path.

  • Source/gyp/configure:
3:43 PM Changeset in webkit [81711] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-22 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Use default-output instead of default-input to get hardware sample-rate
​https://bugs.webkit.org/show_bug.cgi?id=56858

No new tests since audio API is not yet implemented.

  • platform/audio/mac/AudioDestinationMac.cpp: (WebCore::AudioDestination::hardwareSampleRate):
3:42 PM Changeset in webkit [81710] by psolanki@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

2011-03-22 Pratik Solanki <​psolanki@apple.com>

Reviewed by David Kilzer.

Implement -connection:didReceiveDataArray: NSURLConnection delegate method
​https://bugs.webkit.org/show_bug.cgi?id=56838

Add experimental support for the didReceiveDataArray callback on
NSURLConnection. A RessourceHandleClient indicates its ability to
handle this callback by returning true from supportsDataArray() method.
Currently only SubresourceLoader uses this so we get the benefit for
CSS, JS and image loads. For other clients we call didReceiveData with
the CFData contents as before.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::supportsDataArray):
  • loader/cf/SubresourceLoaderCF.cpp: Added. (WebCore::SubresourceLoader::didReceiveDataArray):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveDataArray):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::buffer):
  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::copyDataArrayAndClear):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::supportsDataArray): (WebCore::ResourceHandleClient::didReceiveDataArray):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
3:36 PM Changeset in webkit [81709] by abarth@webkit.org
  • 1 edit
    552 adds in trunk

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add GYP to Source/ThirdParty
​https://bugs.webkit.org/show_bug.cgi?id=56870

We probably don't need all the test files, but it seems cleaner to just
check in the whole GYP tree. GYP is BSD licensed, so it is compatible
with the WebKit license.

  • Source/ThirdParty/gyp: Added.
3:09 PM Changeset in webkit [81708] by eric@webkit.org
  • 6 edits
    4 copies
    3 moves in trunk/Source

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
​https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptCore.xcodeproj
from a JavaScriptCore directory outside of Source.

  • gyp/JavaScriptCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
​https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptGlue.xcodeproj
from a JavaScriptGlue directory outside of Source.

  • gyp/JavaScriptGlue.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
​https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated WebCore.xcodeproj
from a WebCore directory outside of Source.

  • gyp/WebCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.
2:57 PM Changeset in webkit [81707] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WebKit2 build.

  • WebCore.exp.in:

Export a symbol needed by WebKit2.

2:51 PM Changeset in webkit [81706] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the remaining steps to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56864

These steps match the normal build. After this patch, I believe the
WebCore GYP build is complete.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • gyp/copy-inspector-resources.sh: Added.
2:41 PM Changeset in webkit [81705] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Microsoft Silverlight playback shows artifacts
​https://bugs.webkit.org/show_bug.cgi?id=56863
<rdar://problem/9103136>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paint): If the plug-in is transparent, clear the dirty rect before painting.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the MakeTransparentIfBackgroundAttributeExists quirk for Silverlight plug-ins.
  • Shared/Plugins/PluginQuirks.h: Add MakeTransparentIfBackgroundAttributeExists quirk.
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_SetValue): Handle NPPVpluginTransparentBool.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isTransparent to false.

(WebKit::NetscapePlugin::setIsTransparent):
Set m_isTransparent.

(WebKit::NetscapePlugin::initialize):
If the plug-in has the MakeTransparentIfBackgroundAttributeExists quirk, make it transparent
if there's a 'background' attribute.

(WebKit::NetscapePlugin::isTransparent):
Add getter.

  • WebProcess/Plugins/Plugin.h: Add isTransparent().
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::paint): Always copy the plug-in backing store to the plug-in proxy backing store.

(WebKit::PluginProxy::isTransparent):
Add getter that should never be called.

(WebKit::PluginProxy::update):
Always copy the plug-in backing store to the plug-in proxy backing store.

2:33 PM Changeset in webkit [81704] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
added to Page::scrollableAreaSet()

Reviewed by Simon Fraser.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::disconnectFromPage):

2:33 PM Changeset in webkit [81703] by simonjam@chromium.org
  • 2 edits
    103 adds in trunk/LayoutTests

2011-03-22 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium tests after r81684.

  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:32 PM Changeset in webkit [81702] by crogers@google.com
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-03-22 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add high-quality band-limited audio resampling algorithm
​https://bugs.webkit.org/show_bug.cgi?id=56692

No new tests since audio API is not yet implemented.

  • platform/audio/SincResampler.cpp: Added. (WebCore::SincResampler::SincResampler): (WebCore::SincResampler::initializeKernel): (WebCore::SincResampler::consumeSource): (WebCore::SincResampler::process):
  • platform/audio/SincResampler.h: Added.
2:28 PM Changeset in webkit [81701] by eric@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Profiling Configuration to JavaScriptCore gyp build
​https://bugs.webkit.org/show_bug.cgi?id=56862

It appears this is identical to Release, but I suspect
there is someone/thing who uses the Profiling target
so we're adding it for completeness.

  • gyp/JavaScriptCore.gyp:
2:17 PM Changeset in webkit [81700] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt

Update computed style results.

2:13 PM Changeset in webkit [81699] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

Update computed style results.

2:12 PM Changeset in webkit [81698] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

Update computed style results.

2:10 PM Changeset in webkit [81697] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

Update computed style results.

2:10 PM Changeset in webkit [81696] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt

Update computed style results.

2:07 PM Changeset in webkit [81695] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build without help from normal WebCore build
​https://bugs.webkit.org/show_bug.cgi?id=56860

Before this patch, the WebCore GYP build wasn't generating the derived
sources quite right because the ENABLE macros were not being
communicated to the "Derived Sources" target.

This patch also adds the "Copy Forwarding and ICU Headers" as well as
the "Streamline Inspector Source" steps, which are present in the
normal build. Unlike the normal build, these steps occur in a new
target, called "WebCore Support", which is less than aesthetically
beautiful. Hopefully we'll be able to move them into the WebCore
target proper in the future, but that will likely require some GYP
changes.

This patch probably could have been broken down into a couple smaller
patches, but that doesn't seem necessary.

  • WebCore.gypi:
    • This file appears to no longer exist.
  • gyp/WebCore.gyp:
  • gyp/copy-forwarding-and-icu-headers.sh: Added.
  • gyp/streamline-inspector-source.sh: Added.
2:05 PM Changeset in webkit [81694] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove os_win32_files variable from the GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56804

Now that our understanding of GYP is sufficiently advanced, we don't
need os_win32_files any more. (Turns out Eric was right, as he always
is.)

2:02 PM Changeset in webkit [81693] by abarth@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build of JavaScriptCore should be able to link from an empty WebKitBuild directory
​https://bugs.webkit.org/show_bug.cgi?id=56803

Previously, we thought we should generate the derived source files in
the shared intermediate build products directory, but there are
assumptions built into other parts of the Mac build system that the
derived source files will be generated in a particular subdirectory of
the build products directory.

This patch is a partial revert of the change that moved the derived
source files to the shared intermediate directory. After this patch,
the GYP build can build JavaScriptCore without help from the main
normal build system.

  • JavaScriptCore.gypi:
  • gyp/JavaScriptCore.gyp:
  • gyp/generate-derived-sources.sh:
  • gyp/generate-dtrace-header.sh:
1:41 PM Changeset in webkit [81692] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-03-22 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Have WebKit push acceleratedDrawing preferences to settings
​https://bugs.webkit.org/show_bug.cgi?id=56792

  • WebView/WebView.mm:
1:18 PM Changeset in webkit [81691] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56859

Reviewed by Simon Fraser.

Floats in the floating object list occur in the order that they are positioned. This means
that for a given vertical offset, the last left object in the list that intersects that offset
will be the rightmost float. There is no need to check any previous floats, since they have to be
further left than that rightmost float. The same rules hold true for right-aligned floats.

Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
they encounter a float that intersects the vertical range.

This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

1:13 PM Changeset in webkit [81690] by ddkilzer@apple.com
  • 3 edits in trunk/Tools

<​http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode

Reviewed by Joseph Pecoraro.

  • Scripts/build-webkit: Updated usage statement to include

--dsym.

  • Scripts/webkitdirs.pm: Added $generateDsym variable.

(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added. Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added. Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.

12:21 PM Changeset in webkit [81689] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
​https://bugs.webkit.org/show_bug.cgi?id=56794

  • svg/filters/feDisplacementMap-crash-test-expected.txt: Added.
  • svg/filters/feDisplacementMap-crash-test.xhtml: Added.

2011-03-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
​https://bugs.webkit.org/show_bug.cgi?id=56794

Test: svg/filters/feDisplacementMap-crash-test.xhtml

  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
12:21 PM Changeset in webkit [81688] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/CMakeLists.txt

Fix EFL bustage.

12:18 PM Changeset in webkit [81687] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Leopard build bustage.

12:17 PM Changeset in webkit [81686] by jcivelli@chromium.org
  • 10 edits
    7 adds in trunk/Source

2011-03-22 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::Vector::contains):

2011-03-22 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Relanding:
Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:16 PM Changeset in webkit [81685] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Huahui Wu <​mediadependent@gmail.com>

Reviewed by Steve Block.

[Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
​https://bugs.webkit.org/show_bug.cgi?id=56763

No new tests as no new functionality is exposed.

  • platform/PlatformTouchEvent.h:
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
12:03 PM Changeset in webkit [81684] by hyatt@apple.com
  • 32 edits
    68 adds in trunk

Source/WebCore: Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Reviewed by Simon Fraser.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

Added new tests in fast/block/lineboxcontain

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSLineBoxContainValue.cpp: Added.

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
(WebCore::CSSLineBoxContainValue::cssText):

  • css/CSSLineBoxContainValue.h: Added.

(WebCore::CSSLineBoxContainValue::create):
(WebCore::CSSLineBoxContainValue::value):
(WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseLineBoxContain):

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.h:

(WebCore::CSSValue::isCSSLineBoxContainValue):

  • css/CSSValueKeywords.in:
  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

  • rendering/RenderInline.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::width):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
(WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineBoxContain):
(WebCore::InheritedFlags::setLineBoxContain):
(WebCore::InheritedFlags::initialLineBoxContain):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=56388

Reviewed by Simon Fraser.

Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

  • fast/block/lineboxcontain: Added.
  • fast/block/lineboxcontain/block-font.html: Added.
  • fast/block/lineboxcontain/block-glyphs-replaced.html: Added.
  • fast/block/lineboxcontain/block-glyphs.html: Added.
  • fast/block/lineboxcontain/block-replaced.html: Added.
  • fast/block/lineboxcontain/block.html: Added.
  • fast/block/lineboxcontain/font-replaced.html: Added.
  • fast/block/lineboxcontain/font.html: Added.
  • fast/block/lineboxcontain/glyphs.html: Added.
  • fast/block/lineboxcontain/inline-box-replaced.html: Added.
  • fast/block/lineboxcontain/inline-box-vertical.html: Added.
  • fast/block/lineboxcontain/inline-box.html: Added.
  • fast/block/lineboxcontain/inline-replaced.html: Added.
  • fast/block/lineboxcontain/inline.html: Added.
  • fast/block/lineboxcontain/none.html: Added.
  • fast/block/lineboxcontain/replaced.html: Added.
  • platform/mac/fast/block/lineboxcontain: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.txt: Added.
12:03 PM Changeset in webkit [81683] by weinig@apple.com
  • 2 edits in trunk/WebKitLibraries

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Adam Roben.

"Windows edition".

  • win/lib/WebKitSystemInterface.lib:
11:52 AM Changeset in webkit [81682] by loki@webkit.org
  • 15 edits in trunk/Source/JavaScriptCore

2011-03-22 Gabor Loki <​loki@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix a bunch of typos in DFG.
​https://bugs.webkit.org/show_bug.cgi?id=56813

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::parse):
  • dfg/DFGGenerationInfo.h: (JSC::DFG::GenerationInfo::setSpilled):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump):
  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::setupStubArguments):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.h:
  • dfg/DFGRegisterBank.h: (JSC::DFG::RegisterBank::allocate):
  • dfg/DFGScoreBoard.h: (JSC::DFG::ScoreBoard::~ScoreBoard): (JSC::DFG::ScoreBoard::allocate):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.h:
11:48 AM Changeset in webkit [81681] by weinig@apple.com
  • 3 edits in trunk/WebKitLibraries

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Brady Eidson.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:40 AM Changeset in webkit [81680] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash when calling PluginProxy::evaluate on a destroyed plug-in
​https://bugs.webkit.org/show_bug.cgi?id=56848
<rdar://problem/9168975>

Return early if the NPObject doesn't exist anymore.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::evaluate):
11:26 AM Changeset in webkit [81679] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
<rdar://problem/8823874>
​https://bugs.webkit.org/show_bug.cgi?id=56847

Reviewed by Adam Roben.

  • Shared/mac/WebEventFactory.mm:

(WebKit::currentMouseButton):
(WebKit::mouseButtonForEvent):
Add mouse button for mouseEnter/Exit events. [NSEvent buttonNumber] doesn't seem to give the right result
for these events, but getting the currentMouseButton does work.

10:58 AM Changeset in webkit [81678] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk

Merging r81668

10:33 AM Changeset in webkit [81677] by commit-queue@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-03-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81664.
​http://trac.webkit.org/changeset/81664
​https://bugs.webkit.org/show_bug.cgi?id=56840

Rolling out followups to 81653 with expectations. (Requested
by pfeldman on #webkit).

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Removed.
10:27 AM Changeset in webkit [81676] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-03-22 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove Gears from Chromium WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56808

Gears has been removed from Chromium 12. Remove Gears drag drop support
from WebKit. That work lead to ​http://webkit.org/b/25916, a proposal to
add native file drag drop, and its subsequent standardization in HTML5.

  • public/WebBindings.h:
  • public/WebView.h:
  • src/WebBindings.cpp: (WebKit::getRangeImpl): FIXME note added.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragLeave): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
10:09 AM Changeset in webkit [81675] by pfeldman@chromium.org
  • 3 edits
    4 deletes in trunk

2011-03-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
​http://trac.webkit.org/changeset/81653
​https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • fast/forms/listbox-bidi-align.html: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Removed.

2011-03-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
​http://trac.webkit.org/changeset/81653
​https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
9:59 AM Changeset in webkit [81674] by pfeldman@chromium.org
  • 5 edits
    3 deletes in trunk

2011-03-22 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):

2011-03-22 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/protocol/database-agent-expected.txt: Removed.
  • inspector/protocol/database-agent.html: Removed.
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Removed.
9:47 AM LayoutTestDashboards edited by mihaip@chromium.org
(diff)
9:46 AM LayoutTestDashboards edited by mihaip@chromium.org
(diff)
9:25 AM Changeset in webkit [81673] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-03-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
​https://bugs.webkit.org/show_bug.cgi?id=56747

Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::showProfilesPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showAndEnableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
9:21 AM Changeset in webkit [81672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-22 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
​https://bugs.webkit.org/show_bug.cgi?id=56824

On desktop OpenGL substitute in renderbufferStorage:

  • GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
  • GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
  • GL_RGBA for GL_RGBA4 and GL_RGBA565
  • GL_RGB for RGB5_A1.

Tests: fast/canvas/webgl/uninitialized-test.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::renderbufferStorage):
9:16 AM Changeset in webkit [81671] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Move volume slider positioning logic to a custom renderer.
​https://bugs.webkit.org/show_bug.cgi?id=56498

No functional change, covered by existing tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
  • rendering/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added. (WebCore::RenderMediaVolumeSliderContainer::layout): Added. (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates. (WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added. (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
  • rendering/MediaControlElements.h: Changed corresponding decls.
9:03 AM Changeset in webkit [81670] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-03-22 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Change return values with better one in ewk_setting's functions
​https://bugs.webkit.org/show_bug.cgi?id=56819

In ewk_settings_cache_directory_path_set_xxx, they return false value
when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get): (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
8:49 AM Changeset in webkit [81669] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-22 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
​https://bugs.webkit.org/show_bug.cgi?id=54138

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::getViewportGLWidget): Check if we actually have a QWebPageClient before dereferencing it.

2011-03-22 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
​https://bugs.webkit.org/show_bug.cgi?id=54138

  • tests/qwebpage/tst_qwebpage.cpp: (webGLScreenshotWithoutView): (tst_QWebPage::acceleratedWebGLScreenshotWithoutView): (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView): Render a QWebPage (with and without accelerated compositing) with a WebGL context that has no owning view. Shouldn't crash.
7:57 AM Changeset in webkit [81668] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-22 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Applications that include WebKit headers fail to build when using strict warnings
because the signature for webkit_application_cache_get_maximum_size is missing a
'void' to make it explicit it takes no arguments.

  • webkit/webkitapplicationcache.h:
7:37 AM Changeset in webkit [81667] by Adam Roben
  • 3 edits in trunk/Tools

Make Leopard Debug bots and Windows XP Debug (Tests) core builders

These bots are consistently green again.

Fixes <​http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
core builders

Rubber-stamped by Antti Koivisto.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Loosened the regexps for Leopard and Windows.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated expectations.

7:11 AM Changeset in webkit [81666] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows expected failure results after r81625

The failure is tracked by <​http://webkit.org/b/56829>.

  • platform/win/fast/css/percentage-non-integer-expected.checksum: Added.
  • platform/win/fast/css/percentage-non-integer-expected.png: Added.
  • platform/win/fast/css/percentage-non-integer-expected.txt: Added.
7:07 AM Changeset in webkit [81665] by Adam Roben
  • 4 edits in trunk/LayoutTests

Fix new http tests added in r81635 on Windows

  • http/tests/cache/post-redirect-get.php:
  • http/tests/cache/post-with-cached-subresources.php:
  • http/tests/cache/resources/post-image-to-verify.php:

Pull in portabilityLayer.php, which implements sys_get_temp_dir for PHP 4.

6:52 AM Changeset in webkit [81664] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for new test added in r81653

Windows differs from Mac due to a different scrollbar width within the listboxes.

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.
6:50 AM Changeset in webkit [81663] by pfeldman@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-03-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document DOM domain types and protocol methods.
​https://bugs.webkit.org/show_bug.cgi?id=56807

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapNode):
  • inspector/InjectedScript.h:
  • inspector/Inspector.json:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode):
6:49 AM Changeset in webkit [81662] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results for new test added in r81652

The checked-in results were trying to show that Windows would fail this test, but weren't
quite accurate. Even with these new results Windows still fails the test; the failure is
tracked by <​http://webkit.org/b/56828>.

  • platform/win/fast/forms/reset-autofilled-expected.txt:
6:32 AM Changeset in webkit [81661] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Update expectations.

  • platform/qt/Skipped:# Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled()
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.checksum: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.png: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt: Updated.
6:05 AM Changeset in webkit [81660] by antonm@chromium.org
  • 1 edit in branches/chromium/696/Source/WebCore/bindings/v8/V8GCController.cpp

Temporary disable object grouping for some types of objects.

BUG=crbug.com/73441

6:02 AM Changeset in webkit [81659] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new test that relies on unimplemented LayoutTestController functionality in WTR

  • platform/mac-wk2/Skipped: Added fast/forms/reset-autofilled.html.
5:21 AM Changeset in webkit [81658] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

2011-03-22 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

Add void to function without parameters
​https://bugs.webkit.org/show_bug.cgi?id=56821

  • ewk/ewk_cookies.cpp: (ewk_cookies_clear): (ewk_cookies_policy_get):
  • ewk/ewk_cookies.h:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get): (ewk_settings_web_database_path_get): (ewk_settings_proxy_uri_get): (ewk_settings_default_user_agent_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (ewk_view_dpi_get):
4:54 AM Changeset in webkit [81657] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed update of database-agent test expectations.
Empty line added at the end.

  • inspector/protocol/database-agent-expected.txt:
4:44 AM Changeset in webkit [81656] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, Skipped one test failing because of the same reason.

[GTK] Some test results are one pixel different between the x86_64 and i386 bots
​https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skip fast/css/percentage-non-integer.html.
3:49 AM Changeset in webkit [81655] by abarth@webkit.org
  • 10 edits in trunk/Source

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
​https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptCore.gyp with information mined from
JavaScriptCore.xcodeproj.

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
​https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptGlue.gyp with information mined from
JavaScriptGlue.xcodeproj.

  • gyp/JavaScriptGlue.gyp:
  • gyp/JavaScriptGlue.gypi:

2011-03-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
​https://bugs.webkit.org/show_bug.cgi?id=56786

Update WebCore.gyp with information mined from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
3:36 AM Changeset in webkit [81654] by loislo@chromium.org
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed fix for database-agent test.

  • inspector/protocol/database-agent-expected.txt:
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Copied from LayoutTests/inspector/protocol/database-agent-expected.txt.
3:14 AM Changeset in webkit [81653] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-22 Ofri Wolfus <​ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
​https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

  • fast/forms/listbox-bidi-align.html: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.

2011-03-22 Ofri Wolfus <​ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
​https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

Test: fast/forms/listbox-bidi-align.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
2:48 AM Changeset in webkit [81652] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-22 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
​https://bugs.webkit.org/show_bug.cgi?id=56802

  • fast/forms/reset-autofilled-expected.txt: Added.
  • fast/forms/reset-autofilled.html: Added.
  • platform/chromium/fast/forms/reset-autofilled-expected.txt: Added.
  • platform/win/fast/forms/reset-autofilled-expected.txt: Added.

2011-03-22 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
In service of ​https://code.google.com/p/chromium/issues/detail?id=70037
​https://bugs.webkit.org/show_bug.cgi?id=56802

Test: fast/forms/reset-autofilled.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset): Clear the autofilled flag.
2:42 AM Changeset in webkit [81651] by loislo@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
​https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

  • inspector/protocol/database-agent-expected.txt: Added.
  • inspector/protocol/database-agent.html: Added.

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
​https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

Test: inspector/protocol/database-agent.html

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):
2:21 AM Changeset in webkit [81650] by loislo@chromium.org
  • 10 edits in trunk

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
​https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
​https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::enable): (WebCore::InspectorConsoleAgent::disable):
  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated): (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
  • inspector/front-end/inspector.js:
12:43 AM Changeset in webkit [81649] by tkent@chromium.org
  • 9 edits in trunk/Source

2011-03-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
​https://bugs.webkit.org/show_bug.cgi?id=56367

Introduce clampToInteger(unsigned).

  • wtf/MathExtras.h: (clampToInteger): Added.

2011-03-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
​https://bugs.webkit.org/show_bug.cgi?id=56367

Because the default value of the maximum fractional digits of NSNumberFormatter
and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
localized representation. This bug affects only in Mac and Chromium.

To fix this bug,

  • Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
  • NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces() instead of parseToDoubleForNumberType().

No automated tests because the behavior is locale-dependent. This change
updates a manual test.

  • html/NumberInputType.cpp: (WebCore::NumberInputType::visibleValue): Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional part length to formatLocalizedNumber().
  • manual-tests/input-number-localization.html: Update the test to cover this change.
  • platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
  • platform/text/LocalizedNumberICU.cpp: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
  • platform/text/LocalizedNumberNone.cpp: (WebCore::formatLocalizedNumber):
  • platform/text/mac/LocalizedNumberMac.mm: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
Note: See TracTimeline for information about the timeline view.