Context Navigation

← Previous Period
Next Period →

Timeline

Mar 25, 2011:

11:22 PM Changeset in webkit [82023] by mrowe@apple.com

5 edits in branches/safari-534.26-branch/Source

Versioning.

11:20 PM Changeset in webkit [82022] by mrowe@apple.com

1 copy in tags/Safari-534.26.3

New tag.

8:06 PM Changeset in webkit [82021] by scheib@chromium.org

2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <scheib@chromium.org>

Chromium test_expectations: bug added for tests impacted by r81992

platform/chromium/test_expectations.txt:

6:42 PM Changeset in webkit [82020] by aestes@apple.com

2 edits
2 adds in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html only passing on SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=57137

Check in failing results for this test (except for on SnowLeopard) until
the failure can be diagnosed.

platform/mac-snowleopard/plugins: Added.
platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
plugins/embed-prefers-plugins-for-images-expected.txt:

6:22 PM Changeset in webkit [82019] by weinig@apple.com

6 edits in trunk/Source/WebKit2

2011-03-25 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

WKPageLoadAlternateHTMLString doesn't re-spawn a dead WebProcess, but should
<rdar://problem/9191493>
https://bugs.webkit.org/show_bug.cgi?id=57134

Make all load functions respawn a dead WebProcess for consistency.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadHTMLString): Respawn a dead WebProcess.

(WebKit::WebPageProxy::loadAlternateHTMLString):
Respawn a dead WebProcess.

(WebKit::WebPageProxy::loadPlainTextString):
Respawn a dead WebProcess.

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadAlternateHTMLString): Since we may no longer always have a main frame when calling WKPageLoadAlternateHTMLString, set the unreachable URL, if there is one, on provisional load.

6:21 PM Changeset in webkit [82018] by kevino@webkit.org

4 edits in trunk

[wx] Build fix, don't use the new FPD implementation yet, until we can merge ours with it.

6:17 PM Changeset in webkit [82017] by aestes@apple.com

2 edits in trunk/LayoutTests

LayoutTestController.setPluginsEnabled() isn't implemented in WebKit2,
and that is now required for fast/images/embed-image.html.

platform/mac-wk2/Skipped: Skip fast/images/embed-image.html

6:13 PM Changeset in webkit [82016] by aestes@apple.com

2 edits in trunk/LayoutTests

Skip fast/images/embed-image.html on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=57135

It would appear that the Windows XP bot is loading a plug-in despite
the test calling layoutTestController.setPluginsEnabled(false).

platform/win-xp/Skipped: Skip fast/images/embed-image.html

5:52 PM Changeset in webkit [82015] by aestes@apple.com

2 edits in trunk/LayoutTests

Re-work a test to not be flaky.

plugins/embed-prefers-plugins-for-images.html:

5:51 PM Changeset in webkit [82014] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

2011-03-25 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=57047

No new tests.

When loading a URL, checkk osee if the Appplication Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal):
platform/graphics/win/QTMovie.cpp: (QTMovie::loadPath):
platform/graphics/win/QTMovie.h:

5:46 PM Changeset in webkit [82013] by mitz@apple.com

12 edits
4 adds in trunk

<rdar://problem/9134330> Missing expansion before ideograph at the beginning or end of a text run
https://bugs.webkit.org/show_bug.cgi?id=57106

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/justify-ideograph-leading-expansion.html

platform/graphics/TextRun.h:

Replaced TrailingExpansionBehavior enum with ExpansionBehavior flags.
(WebCore::TextRun::TextRun): Constructors now take an expansionBehavior parameter.
(WebCore::TextRun::allowsLeadingExpansion): Added this accessor.
(WebCore::TextRun::allowsTrailingExpansion): Changed to use the m_expansionBehavior member.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion from the TextRun, allowing
leading expansion when appropriate.
(WebCore::WidthIterator::advance): Moved the last-glyph-in-run check to only apply to expansion
after the glyph, not expansion before the glyph, since that is not trailing expansion. Added code
to handle expansion before the first glyph.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize m_afterExpansion from the
TextRun, allowing leading expansion when appropriate. Set m_runWidthSoFar to the leading expansion.
(WebCore::ComplexTextController::offsetForPosition): Account for leading expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Similar to WidthIterator::advance()

platform/graphics/mac/ComplexTextController.h: Added m_leadingExpansion member variable.
rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasSelectedChildren to m_hasSelectedChildrenOrCanHaveLeadingExpansion
to reflect the use of this bit by InlineTextBox.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Replaced calls to trailingExpansionBehavior() with expansionBehavior().
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.

rendering/InlineTextBox.h:

(WebCore::InlineTextBox::canHaveLeadingExpansion): Added this accessor.
(WebCore::InlineTextBox::setCanHaveLeadingExpansion): Ditto.
(WebCore::InlineTextBox::expansionBehavior): Replaced trailingExpansionBehavior() with this function,
which also considers canHaveLeadingExpansion().

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Call setCanHaveLeadingExpansion() on
text boxes that can have leading expansion. Avoid negative expansion.

rendering/RootInlineBox.cpp:
rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasSelectedChildren): Updated for renaming of the flag.
(WebCore::RootInlineBox::setHasSelectedChildren): Ditto.

LayoutTests:

fast/text/justify-ideograph-leading-expansion.html: Added.
platform/mac/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.

5:45 PM Changeset in webkit [82012] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-03-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

PluginView's call to invalidateContentsAndWindow() in invalidateRect() is wrong for plug-ins which paint into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=57133
<rdar://problem/9029442>

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformInvalidate): Return true under the Core Animation drawing model, since that prevents the plug-in from calling PluginController::invalidate.

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::invalidateRect): Don't call invalidateContentsAndWindow() if the plug-in has a Core Animation layer.

5:41 PM Changeset in webkit [82011] by jer.noble@apple.com

5 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateAVFoundation should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=56997

No new tests.

When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Check to see if the media should be loaded

from the application cache.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): Added. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Split out from createAVPlayerForURL.

5:30 PM Changeset in webkit [82010] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-03-25 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=57122. Solaris 10/SunStudio 12 expect
both sides of a ?: operation to have the same types. Extracted from original
https://bugs.webkit.org/show_bug.cgi?id=24932, patch 13 of 17, and originally
created by Thiago Macieira.

fixes a compile issue on Solaris 10/SunStudio 12

loader/DocumentLoader.h: (WebCore::DocumentLoader::serverRedirectSourceForHistory):
loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction):

5:29 PM Changeset in webkit [82009] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

2011-02-03 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateQTKit should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=53818

No new tests.

When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use that data instead of the remote URL.

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): (WebCore::MediaPlayerPrivateQTKit::createQTMovie): (WebCore::MediaPlayerPrivateQTKit::loadInternal):

5:14 PM Changeset in webkit [82008] by jam@chromium.org

1 edit in trunk/Source/WebKit/chromium/public/WebSpellCheckClient.h

[chromium] add missing include from previous checkin

5:12 PM Changeset in webkit [82007] by aestes@apple.com

2 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on Windows.
https://bugs.webkit.org/show_bug.cgi?id=57132

platform/win/Skipped: Skip plugins/embed-prefers-plugins-for-images.html

5:10 PM Changeset in webkit [82006] by jamesr@google.com

22 edits
5 copies
1 add in trunk/Source/WebCore

2011-03-25 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Move draw implementations to CCLayerImpl for everything except content layers
https://bugs.webkit.org/show_bug.cgi?id=56793

Moves the implementation of the layer's draw() function from LayerChromium subclasses to CCLayerImpl subclasses for
all layer types except content layers. This gets us closer to decoupling the composite step itself from updating the layers.

The biggest change in this patch is adding a set of CCLayerImpl subclasses to implement the different drawing routines
and moving the code from each XXXLayerChromium to CCXXXLayerImpl. In order to render from the CCLayerImpl side all state
needed at draw time also has to be synchronized, which is performed in pushPropertiesTo().

On the LayerRendererChromium side there are a few changes. I've split the updateContents calls on LayerChromiums into two operations
tentatively named 'paintContentsIfNeeded' and 'updateCompositorResources'. paintContents() is used for any code that calls into WebKit in order to generate
new pixel data. It's expected that this call may take a long period of time and may involve "odd" side effects. updateCompositorResources() is used for
code that needs to update the compositor's texture data or other state. It is not expected that this callback will take long (since it's just inserting
commands into the GL command stream, ideally) and this call is expected to have access to the compositor's context, unlike paintContents().

The updateAndDrawLayers cycle now looks like this:
1.) update the root content layer
2.) update the root layer scrollbars
3.) for each LayerChromium in tree order:

a.) ensure a CCLayerImpl of the correct type exists for this layer
b.) push all draw time properties from the LayerChromium to the CCLayerImpl
c.) construct the appropriate draw transforms, render surfaces and render surface z-order sublayer lists

4.) for each LayerChromium in tree order, paint the layer's contents
5.) for each LayerChromium in tree order, update the associate compositor resources (textures, etc)
6.) draw the root layer and its scrollbars
7.) for each CCLayerImpl in render surface order, draw it

Step 3 should really happen after step 5, but right now painting a content layer requires knowledge of the render surface properties and draw transforms
in order to paint. We also currently push layer properties from LayerChromium->CCLayerImpls twice now - once at 3.b and once after 5 so we can pick
up any texture updates. This will also get fixed when the paint dependency on render surfaces is resolved.

I haven't modified the root layer or content layers in order to minimize conflicts with the other pending work in that area.

Tests: compositing/

WebCore.gypi:
platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateCompositorResources):
platform/graphics/chromium/Canvas2DLayerChromium.h:
platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::createCCLayerImpl): (WebCore::CanvasLayerChromium::pushPropertiesTo):
platform/graphics/chromium/CanvasLayerChromium.h:
platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::updateCompositorResources): (WebCore::ContentLayerChromium::bindContentsTexture):
platform/graphics/chromium/ContentLayerChromium.h:
platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty):
platform/graphics/chromium/ImageLayerChromium.h:
platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::setLayerRenderer): (WebCore::LayerChromium::setName): (WebCore::LayerChromium::pushPropertiesTo): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::createCCLayerImpl): (WebCore::LayerChromium::createCCLayerImplIfNeeded): (WebCore::LayerChromium::ccLayerImpl): (WebCore::LayerChromium::layerRenderer):
platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::paintContentsIfDirty): (WebCore::LayerChromium::updateCompositorResources):
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::paintContentsRecursive): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects):
platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::canvasLayerProgram): (WebCore::LayerRendererChromium::pluginLayerProgram): (WebCore::LayerRendererChromium::videoLayerRGBAProgram): (WebCore::LayerRendererChromium::videoLayerYUVProgram):
platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::createCCLayerImpl): (WebCore::PluginLayerChromium::setTextureId): (WebCore::PluginLayerChromium::pushPropertiesTo):
platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId):
platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createCCLayerImpl): (WebCore::VideoLayerChromium::updateCompositorResources): (WebCore::VideoLayerChromium::pushPropertiesTo):
platform/graphics/chromium/VideoLayerChromium.h:
platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateCompositorResources):
platform/graphics/chromium/WebGLLayerChromium.h:
platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp. (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::~CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::draw): (WebCore::CCCanvasLayerImpl::dumpLayerProperties):
platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCCanvasLayerImpl::create): (WebCore::CCCanvasLayerImpl::setTextureId): (WebCore::CCCanvasLayerImpl::setPremultipliedAlpha):
platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::descendantsDrawsContent): (WebCore::CCLayerImpl::updateCompositorResources): (WebCore::CCLayerImpl::writeIndent):
platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setAnchorPoint): (WebCore::CCLayerImpl::setAnchorPointZ): (WebCore::CCLayerImpl::setMasksToBounds): (WebCore::CCLayerImpl::setOpacity): (WebCore::CCLayerImpl::setPosition): (WebCore::CCLayerImpl::setPreserves3D): (WebCore::CCLayerImpl::setSublayerTransform): (WebCore::CCLayerImpl::setTransform):
platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp. (WebCore::CCPluginLayerImpl::CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::~CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::draw): (WebCore::CCPluginLayerImpl::dumpLayerProperties):
platform/graphics/chromium/cc/CCPluginLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCPluginLayerImpl::create): (WebCore::CCPluginLayerImpl::setTextureId):
platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Added. (WebCore::CCVideoLayerImpl::CCVideoLayerImpl): (WebCore::CCVideoLayerImpl::~CCVideoLayerImpl): (WebCore::CCVideoLayerImpl::setTexture): (WebCore::CCVideoLayerImpl::draw): (WebCore::CCVideoLayerImpl::drawYUV): (WebCore::CCVideoLayerImpl::drawRGBA): (WebCore::CCVideoLayerImpl::dumpLayerProperties):
platform/graphics/chromium/cc/CCVideoLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCVideoLayerImpl::create): (WebCore::CCVideoLayerImpl::setSkipsDraw): (WebCore::CCVideoLayerImpl::setFrameFormat):

5:09 PM Changeset in webkit [82005] by beidson@apple.com

7 edits
3 adds in trunk/Source/WebKit2

<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 IconDatabase and API

Reviewed by Sam Weinig.

This gets a basic, usable API in place.
Enhancements can come in other bugs as they're needed.

UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseRetainIconForURL):
(WKIconDatabaseReleaseIconForURL):
(WKIconDatabaseEnableDatabaseCleanup):

UIProcess/API/C/WKIconDatabase.h:

The first actual accessor for an "icon for a URL" is for a CGImageRef:

UIProcess/API/C/cg: Added.
UIProcess/API/C/cg/WKIconDatabaseCG.cpp: Added.

(WKIconDatabaseGetCGImageForURL):

UIProcess/API/C/cg/WKIconDatabaseCG.h: Added.

Expose relevant methods to support the above API:

UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase): New IconDatabases will have cleanup disabled from the start,

and require a single call to "enableDatabaseCleanup" to allow cleanup.

(WebKit::WebIconDatabase::setDatabasePath):
(WebKit::WebIconDatabase::enableDatabaseCleanup):
(WebKit::WebIconDatabase::imageForPageURL):

UIProcess/WebIconDatabase.h:

Project file stuff:

WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

5:04 PM Changeset in webkit [82004] by weinig@apple.com

2 edits in trunk/Source/WebKit/win

WebScrollBar not updating when calling WebScrollBar::setValue.
<rdar://problem/9143871>

Reviewed by Jon Honeycutt.

WebScrollBar.cpp:

(WebScrollBar::setValue):
Call scrollToOffsetWithoutAnimation to actually update the scroll position.

4:20 PM Changeset in webkit [82003] by oliver@apple.com

7 edits in trunk

2011-03-25 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
https://bugs.webkit.org/show_bug.cgi?id=57129

Now we disallow the cross origin accesses, rather than just disallowing
the defineOwnProperty at all.

http/tests/security/xss-DENIED-defineProperty-expected.txt:

2011-03-25 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
https://bugs.webkit.org/show_bug.cgi?id=57129

Fix a couple of places where we uses getter()/setter() rather
than [gs]etterPresent().

runtime/JSObject.cpp: (JSC::JSObject::defineOwnProperty):

2011-03-25 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
https://bugs.webkit.org/show_bug.cgi?id=57129

As other engines are allowing defineOwnProperty to be applied
to host objects there's no reason for us to retain this
restriction.

bindings/js/JSDOMWrapper.cpp:
bindings/js/JSDOMWrapper.h:

4:15 PM Changeset in webkit [82002] by jeffm@apple.com

5 edits in trunk/Source/WebKit2

2011-03-25 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms
https://bugs.webkit.org/show_bug.cgi?id=57125

Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific.
In this patch, just replicate the existing common non-Mac implementation in WebCoreArgumentCoders.h to platform-specific files.

Shared/WebCoreArgumentCoders.h: Move non-Mac implementations of encodeResourceError() and decodeResourceError() to common files.
Shared/gtk/WebCoreArgumentCodersGtk.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.
Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.
Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.

4:07 PM Changeset in webkit [82001] by aestes@apple.com

48 edits
2 adds in trunk

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

TestNetscapePlugIn needs to register support for an image MIME type so
we can test that the embed tag prefers plug-ins to render image MIME
types.

DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetMIMEDescription): Ditto.
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

fast/images/embed-image.html: Disable plug-ins to continue testing native image rendering with embed.
plugins/embed-prefers-plugins-for-images-expected.txt: Added.
plugins/embed-prefers-plugins-for-images.html: Added.
plugins/plugin-javascript-access-expected.txt: Updated to include the new MIME type registered by TestNetscapePlugIn.

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
src/FrameLoaderClientImpl.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType):
WebCoreSupport/FrameLoaderClientQt.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
WebCoreSupport/FrameLoaderClientGtk.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebFrame.cpp: (WebFrame::objectContentType):
WebFrame.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::objectContentType):
WebKitSupport/FrameLoaderClientWx.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType):

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::objectContentType):
WebCoreSupport/FrameLoaderClientHaiku.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::objectContentType):
WebCoreSupport/FrameLoaderClientWinCE.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::objectContentType):
WebCoreSupport/FrameLoaderClientEfl.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
QuickTime plug-in in web pages. r70748 removed our mapping of classids
to MIME types, which causes WebKit to fall back from the object to the
embed tag when QuickTime is embedded by this script. The script emits
the following embed tag to embed a QuickTime movie with a poster frame:

<embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">

The expectation is that a QuickTime plug-in is instantiated to display the
poster frame, since QuickTime registers for many common image MIME
types. This is how Gecko behaves for embed. However, WebKit prefers to
use its native image rendering for image embeds, in which case no movie
is played when the poster frame is clicked.

Fix this by changing embed to check for a plug-in that can handle the
image type before rendering the image natively. This matches Gecko.

Test: plugins/embed-prefers-plugins-for-images.html

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parametersForPlugin):
html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::isImageType): (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages):
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::objectContentType):
loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin): (WebCore::SubframeLoader::requestPlugin): (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::shouldUsePlugin):
loader/SubframeLoader.h:

2011-03-25 Andy Estes <aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType):
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

4:04 PM Changeset in webkit [82000] by jer.noble@apple.com

5 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Application Cache should save audio/ and video/ mime types as flat files
https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>

No new tests, as this behavior is not possible to test without changes to the MediaPlayer engines.

Store certain mime types as flat files alongside the Application Cache database.
This requires plumbing the saved file path from ApplicationCacheStorage through
to ApplicationCacheResource.

(WebCore::ApplicationCacheStorage::openDatabase): Modify the CacheResourceData schema and

add a new DeletedCacheResources table, add a new CacheResourceDataDeleted trigger.

(WebCore::ApplicationCacheStorage::store): Add the new path data when adding new rows in

CacheResourceData, and store media resources as flat files.

(WebCore::ApplicationCacheStorage::loadCache): Pull the "path" column from CacheResourceData

when loading cache items.

(WebCore::ApplicationCacheStorage::remove): Call checkForDeletedResources.
(WebCore::ApplicationCacheStorage::empty): Ditto.
(WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
(WebCore::ApplicationCacheStorage::deleteCacheGroup): Ditto.
(WebCore::ApplicationCacheStorage::checkForDeletedResources): Walk through DeletedCacheResourceData

looking for entries with non-empty "path" columns; if found, delete.

(WebCore::ApplicationCacheStorage::flatFileAreaSize): Walk through CacheResourceData rows

and sum the file size of those rows with flat file storage.

(WebCore::ApplicationCacheStorage::verifySchemaVersion): Call deleteTables() instead of

clearAllTables() directly.

(WebCore::ApplicationCacheStorage::deleteTables): Call empty() before deleting the tables,

so that flat files get deleted.

(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile): Added.
(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Added.

loader/appcache/ApplicationCacheStorage.h:
platform/win/FileSystemWin.cpp: (WebCore::openFile): Implement openFile on Windows.

4:01 PM Changeset in webkit [81999] by kinuko@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-03-25 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Data race between ~WorkerFileSystemCallbacksBridge and runTasksOnWorkerThread
https://bugs.webkit.org/show_bug.cgi?id=56138
Stopped passing the WorkerFileSystemCallbacksBridge's reference to
MainThreadFileSystemCallbacks so that in most cases (in normal cases)
its reference is only maintained by WorkerThread.

src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::MainThreadFileSystemCallbacks::createLeakedPtr): (WebKit::MainThreadFileSystemCallbacks::MainThreadFileSystemCallbacks): (WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):
src/WorkerFileSystemCallbacksBridge.h:

3:56 PM Changeset in webkit [81998] by scheib@chromium.org

2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <scheib@chromium.org>

fast/forms/input-file-directory-upload.html timing out.
http://crbug.com/77468

platform/chromium/test_expectations.txt:

3:33 PM Changeset in webkit [81997] by jberlin@webkit.org

10 edits in trunk/Source/WebKit2

Unreviewed build correction.

Patch by Brent Fulgham <bfulgham@webkit.org> on 2011-03-25
Add stubs for WK2 cookie handling with cURL.

WebProcess/Cookies/curl: Added.
WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

win/WebKit2.vcproj:

3:15 PM Changeset in webkit [81996] by scheib@chromium.org

2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <scheib@chromium.org>

Attempting SLOW to resolve fast/forms/input-file-directory-upload.html

platform/chromium/test_expectations.txt:

3:04 PM Changeset in webkit [81995] by Martin Robinson

1 edit
1 add in trunk/LayoutTests

2011-03-25 Martin Robinson <mrobinson@igalia.com>

Add a GTK+ specific baseline for a text test that seems to have whitespace difference,
probably due to font sizes resulting in newlines.

platform/gtk/fast/events/onchange-text-form-field-expected.txt: Added.

3:01 PM Changeset in webkit [81994] by ggaren@apple.com

3 edits
2 adds in trunk

2011-03-24 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

animations/dynamic-stylesheet-loading-expected.txt:
animations/keyframe-timing-functions-expected.txt:
fast/block/positioning/static-inline-position-dynamic.html: Added.
fast/block/positioning/trailing-space-test.html: Added.
fast/dynamic/ancestor-to-absolute-expected.txt:
fast/forms/input-appearance-elementFromPoint-expected.txt:
fast/forms/input-hit-test-border-expected.txt:
platform/mac/fast/block/positioning/002-expected.png:
platform/mac/fast/block/positioning/003-expected.png:
platform/mac/fast/block/positioning/004-expected.png:
platform/mac/fast/block/positioning/005-expected.png:
platform/mac/fast/block/positioning/006-expected.png:
platform/mac/fast/block/positioning/007-expected.png:
platform/mac/fast/block/positioning/008-expected.png:
platform/mac/fast/block/positioning/009-expected.png:
platform/mac/fast/block/positioning/010-expected.png:
platform/mac/fast/block/positioning/011-expected.png:
platform/mac/fast/block/positioning/012-expected.png:
platform/mac/fast/block/positioning/013-expected.png:
platform/mac/fast/block/positioning/014-expected.png:
platform/mac/fast/block/positioning/015-expected.png:
platform/mac/fast/block/positioning/016-expected.png:
platform/mac/fast/block/positioning/017-expected.png:
platform/mac/fast/block/positioning/018-expected.png:
platform/mac/fast/block/positioning/019-expected.png:
platform/mac/fast/block/positioning/020-expected.png:
platform/mac/fast/block/positioning/021-expected.png:
platform/mac/fast/block/positioning/022-expected.png:
platform/mac/fast/block/positioning/023-expected.png:
platform/mac/fast/block/positioning/024-expected.png:
platform/mac/fast/block/positioning/025-expected.png:
platform/mac/fast/block/positioning/026-expected.png:
platform/mac/fast/block/positioning/027-expected.png:
platform/mac/fast/block/positioning/028-expected.png:
platform/mac/fast/block/positioning/029-expected.png:
platform/mac/fast/block/positioning/030-expected.png:
platform/mac/fast/block/positioning/031-expected.png:
platform/mac/fast/block/positioning/032-expected.png:
platform/mac/fast/block/positioning/033-expected.png:
platform/mac/fast/block/positioning/034-expected.png:
platform/mac/fast/block/positioning/035-expected.png:
platform/mac/fast/block/positioning/036-expected.png:
platform/mac/fast/block/positioning/037-expected.png:
platform/mac/fast/block/positioning/038-expected.png:
platform/mac/fast/block/positioning/039-expected.png:
platform/mac/fast/block/positioning/040-expected.png:
platform/mac/fast/block/positioning/041-expected.png:
platform/mac/fast/block/positioning/042-expected.png:
platform/mac/fast/block/positioning/043-expected.png:
platform/mac/fast/block/positioning/044-expected.png:
platform/mac/fast/block/positioning/045-expected.png:
platform/mac/fast/block/positioning/046-expected.png:
platform/mac/fast/block/positioning/047-expected.checksum:
platform/mac/fast/block/positioning/047-expected.png:
platform/mac/fast/block/positioning/048-expected.png:
platform/mac/fast/block/positioning/049-expected.png:
platform/mac/fast/block/positioning/050-expected.png:
platform/mac/fast/block/positioning/056-expected.txt:
platform/mac/fast/block/positioning/061-expected.png:
platform/mac/fast/block/positioning/062-expected.png:
platform/mac/fast/block/positioning/auto/005-expected.txt:
platform/mac/fast/block/positioning/auto/006-expected.txt:
platform/mac/fast/block/positioning/auto/007-expected.png:
platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum:
platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum:
platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum:
platform/mac/fast/block/positioning/inline-block-relposition-expected.png:
platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
platform/mac/fast/block/positioning/move-with-auto-width-expected.png:
platform/mac/fast/block/positioning/negative-rel-position-expected.png:
platform/mac/fast/block/positioning/relative-overconstrained-expected.png:
platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added.
platform/mac/fast/clip/001-expected.txt:
platform/mac/fast/clip/004-expected.txt:
platform/mac/fast/clip/006-expected.txt:
platform/mac/fast/clip/007-expected.txt:
platform/mac/fast/clip/008-expected.txt:
platform/mac/fast/clip/009-expected.txt:
platform/mac/fast/clip/010-expected.txt:
platform/mac/fast/clip/011-expected.txt:
platform/mac/fast/clip/012-expected.txt:
platform/mac/fast/clip/013-expected.txt:
platform/mac/fast/clip/014-expected.txt:
platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
platform/mac/fast/clip/outline-overflowClip-expected.txt:
platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
platform/mac/fast/invalid/014-expected.txt:
platform/mac/fast/layers/layer-visibility-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt:
platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

2011-03-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash when paused at a breakpoint caused by inaccurate Activation records.
https://bugs.webkit.org/show_bug.cgi?id=57120

runtime/JSActivation.cpp: (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::getOwnPropertyNames): (JSC::JSActivation::symbolTablePutWithAttributes):

2:59 PM Changeset in webkit [81993] by bfulgham@webkit.org

2 edits
2 adds in trunk/Source/WebKit2

Unreviewed build correction.

Add stubs for WK2 cookie handling with cURL.

WebProcess/Cookies/curl: Added.
WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

win/WebKit2.vcproj:

2:57 PM Changeset in webkit [81992] by hyatt@apple.com

112 edits
8 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=56909

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):

rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::positionLineBox):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyleConstants.h:
rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

LayoutTests: Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Reviewed by Dan Bernstein.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

animations/dynamic-stylesheet-loading-expected.txt:
animations/keyframe-timing-functions-expected.txt:
fast/block/positioning/static-inline-position-dynamic.html: Added.
fast/block/positioning/trailing-space-test.html: Added.
fast/dynamic/ancestor-to-absolute-expected.txt:
fast/forms/input-appearance-elementFromPoint-expected.txt:
fast/forms/input-hit-test-border-expected.txt:
platform/mac/fast/block/positioning/002-expected.png:
platform/mac/fast/block/positioning/003-expected.png:
platform/mac/fast/block/positioning/004-expected.png:
platform/mac/fast/block/positioning/005-expected.png:
platform/mac/fast/block/positioning/006-expected.png:
platform/mac/fast/block/positioning/007-expected.png:
platform/mac/fast/block/positioning/008-expected.png:
platform/mac/fast/block/positioning/009-expected.png:
platform/mac/fast/block/positioning/010-expected.png:
platform/mac/fast/block/positioning/011-expected.png:
platform/mac/fast/block/positioning/012-expected.png:
platform/mac/fast/block/positioning/013-expected.png:
platform/mac/fast/block/positioning/014-expected.png:
platform/mac/fast/block/positioning/015-expected.png:
platform/mac/fast/block/positioning/016-expected.png:
platform/mac/fast/block/positioning/017-expected.png:
platform/mac/fast/block/positioning/018-expected.png:
platform/mac/fast/block/positioning/019-expected.png:
platform/mac/fast/block/positioning/020-expected.png:
platform/mac/fast/block/positioning/021-expected.png:
platform/mac/fast/block/positioning/022-expected.png:
platform/mac/fast/block/positioning/023-expected.png:
platform/mac/fast/block/positioning/024-expected.png:
platform/mac/fast/block/positioning/025-expected.png:
platform/mac/fast/block/positioning/026-expected.png:
platform/mac/fast/block/positioning/027-expected.png:
platform/mac/fast/block/positioning/028-expected.png:
platform/mac/fast/block/positioning/029-expected.png:
platform/mac/fast/block/positioning/030-expected.png:
platform/mac/fast/block/positioning/031-expected.png:
platform/mac/fast/block/positioning/032-expected.png:
platform/mac/fast/block/positioning/033-expected.png:
platform/mac/fast/block/positioning/034-expected.png:
platform/mac/fast/block/positioning/035-expected.png:
platform/mac/fast/block/positioning/036-expected.png:
platform/mac/fast/block/positioning/037-expected.png:
platform/mac/fast/block/positioning/038-expected.png:
platform/mac/fast/block/positioning/039-expected.png:
platform/mac/fast/block/positioning/040-expected.png:
platform/mac/fast/block/positioning/041-expected.png:
platform/mac/fast/block/positioning/042-expected.png:
platform/mac/fast/block/positioning/043-expected.png:
platform/mac/fast/block/positioning/044-expected.png:
platform/mac/fast/block/positioning/045-expected.png:
platform/mac/fast/block/positioning/046-expected.png:
platform/mac/fast/block/positioning/047-expected.checksum:
platform/mac/fast/block/positioning/047-expected.png:
platform/mac/fast/block/positioning/048-expected.png:
platform/mac/fast/block/positioning/049-expected.png:
platform/mac/fast/block/positioning/050-expected.png:
platform/mac/fast/block/positioning/056-expected.txt:
platform/mac/fast/block/positioning/061-expected.png:
platform/mac/fast/block/positioning/062-expected.png:
platform/mac/fast/block/positioning/auto/005-expected.txt:
platform/mac/fast/block/positioning/auto/006-expected.txt:
platform/mac/fast/block/positioning/auto/007-expected.png:
platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum:
platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt:
platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum:
platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum:
platform/mac/fast/block/positioning/inline-block-relposition-expected.png:
platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
platform/mac/fast/block/positioning/move-with-auto-width-expected.png:
platform/mac/fast/block/positioning/negative-rel-position-expected.png:
platform/mac/fast/block/positioning/relative-overconstrained-expected.png:
platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added.
platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added.
platform/mac/fast/clip/001-expected.txt:
platform/mac/fast/clip/004-expected.txt:
platform/mac/fast/clip/006-expected.txt:
platform/mac/fast/clip/007-expected.txt:
platform/mac/fast/clip/008-expected.txt:
platform/mac/fast/clip/009-expected.txt:
platform/mac/fast/clip/010-expected.txt:
platform/mac/fast/clip/011-expected.txt:
platform/mac/fast/clip/012-expected.txt:
platform/mac/fast/clip/013-expected.txt:
platform/mac/fast/clip/014-expected.txt:
platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
platform/mac/fast/clip/outline-overflowClip-expected.txt:
platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
platform/mac/fast/invalid/014-expected.txt:
platform/mac/fast/layers/layer-visibility-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt:
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt:
platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

2:21 PM Changeset in webkit [81991] by Stephanie Lewis

2 edits in trunk/Source/WebCore

Fix the GTK+ build until we can implement the new cross-platform
FontPlatformData.h bits.

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-03-25

platform/graphics/FontPlatformData.h: Include the proper old font headers.

(WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file
which reference our obsolete font implementation.
(WebCore::FontPlatformData::hash): Ditto.

2:13 PM Changeset in webkit [81990] by Martin Robinson

2 edits in trunk/Source/WebCore

2011-03-25 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build until we can implement the new cross-platform
FontPlatformData.h bits.

platform/graphics/FontPlatformData.h: Include the proper old font headers. (WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file which reference our obsolete font implementation. (WebCore::FontPlatformData::hash): Ditto.

2:04 PM Changeset in webkit [81989] by sfalken@apple.com

4 edits in trunk/Source

2011-03-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Brian Weinstein.

Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>

This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Blacklist npwpf.dll.

2011-03-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Brian Weinstein.

Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>

This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.

UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin): Blacklist npwpf.dll.

1:40 PM Changeset in webkit [81988] by tony@chromium.org

4 edits in trunk/Source/WebCore

2011-03-25 Tony Chang <tony@chromium.org>

Try to fix the chromium mac build.
We used the mac FontPlatformData on chromium mac.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/graphics/FontPlatformData.h:

1:34 PM Changeset in webkit [81987] by jam@chromium.org

6 edits
1 add in trunk/Source/WebKit/chromium

2011-03-24 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add setters for various client interfaces, and add WebSpellCheckClient
https://bugs.webkit.org/show_bug.cgi?id=57070

public/WebSpellCheckClient.h: Added. (WebKit::WebSpellCheckClient::spellCheck): (WebKit::WebSpellCheckClient::requestCheckingOfText): (WebKit::WebSpellCheckClient::autoCorrectWord): (WebKit::WebSpellCheckClient::showSpellingUI): (WebKit::WebSpellCheckClient::isShowingSpellingUI): (WebKit::WebSpellCheckClient::updateSpellingUIWithMisspelledWord): (WebKit::WebSpellCheckClient::~WebSpellCheckClient):
public/WebView.h:
public/WebViewClient.h:
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::requestCheckingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setWebDevToolsAgentClient): (WebKit::WebViewImpl::setWebAutoFillClient): (WebKit::WebViewImpl::setWebSpellCheckClient): (WebKit::WebViewImpl::WebViewImpl):
src/WebViewImpl.h: (WebKit::WebViewImpl::spellCheckClient):

1:27 PM Changeset in webkit [81986] by ggaren@apple.com

1 edit
2 adds in trunk/LayoutTests

2011-03-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash in debugger beneath MarkStack::drain @ me.com, ibm.com
https://bugs.webkit.org/show_bug.cgi?id=57080
<rdar://problem/8525907>

inspector/debugger/debugger-activation-crash-expected.txt: Added.
inspector/debugger/debugger-activation-crash.html: Added.

1:08 PM Changeset in webkit [81985] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-03-25 Dimitri Glazkov <Dimitri Glazkov>

Skip the test added in r81970 on WebKit2, because its harness doesn't
yet support printing hooks.

platform/mac-wk2/Skipped: Added printing/page-count-layout-overflow.html.

1:03 PM Changeset in webkit [81984] by bfulgham@webkit.org

2 edits in trunk/WebKitLibraries

Kick the build machines after r81977.

win/tools/vsprops/common.vsprops:

12:44 PM Changeset in webkit [81983] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash in debugger beneath MarkStack::drain @ me.com, ibm.com
https://bugs.webkit.org/show_bug.cgi?id=57080
<rdar://problem/8525907>

The crash was caused by changes in the executable after recompilation.

The fix is for the activation to copy the data it needs instead of
relying on the data in the executable.

SunSpider and v8 report no change.

runtime/Arguments.h: (JSC::JSActivation::copyRegisters): Use our own data members instead of reading data out of the executable.

runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): Initialize our data members.

(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter): Use our own data members instead of
reading data out of the executable.

runtime/JSActivation.h: Added new data members to track data previously tracked by the executable. Since I've removed the executable pointer, on a 64bit system, I've only made activations bigger by an int.

12:41 PM Changeset in webkit [81982] by tony@chromium.org

2 edits in trunk/Source/WebCore

2011-03-25 Tony Chang <tony@chromium.org>

Build fix:
have chromium and qt use the correct FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=57115

platform/graphics/FontPlatformData.h:

12:29 PM Changeset in webkit [81981] by Beth Dakin

4 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=57057 Overlay scrollbars in overflow
areas paint behind positive z-index content
-and corresponding-
<rdar://problem/9070500>

Reviewed by Dave Hyatt.

Since overlay scrollbars don't clip the scrollable content like other scrollbars do,
the only way to get them to paint on top of all possible scrollable content is to
make them paint on top of everything. To do this, this patch adds a second trip
through the layer tree if it contains overlay scrollbars that need painting.

After calling paint() on the rootLayer, call paintOverlayScrollers() if
containsDirtyOverlayScrollbars() is true.

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

RenderLayer has two new member variable. m_containsDirtyOverlayScrollbars is a bool
that is set on the root layer when it has child layers that need overlay scrollbars
to be painted. m_cachedOverlayScrollbarOffset is an IntPoint to cache the tx and ty
of the overlay scrollbars on the first (normal) pass through the layer tree. This
prevents us from having to re-enter the render tree during the second (overlay-only)
pass. Finally, there is also a new paint flag: PaintLayerPaintingOverlayScrollbars.

rendering/RenderLayer.h:

(WebCore::RenderLayer::containsDirtyOverlayScrollbars):
(WebCore::RenderLayer::setContainsDirtyOverlayScrollbars):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayer):

12:16 PM Changeset in webkit [81980] by jberlin@webkit.org

21 edits
11 adds in trunk

WebKit2: Need to be able to set and get the Cookie Storage Policy.
https://bugs.webkit.org/show_bug.cgi?id=50780

Reviewed by Sam Weinig.

Source/WebCore:

platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateCookieStorage):
Rename privateBrowsingCookieStorage to privateCookieStorage.
(WebCore::currentCookieStorage):
Ditto.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
(WebCore::defaultCookieStorage):
Return the default cookie storage.
(WebCore::privateBrowsingCookieStorage):
Return privateCookieStorage().get()

platform/network/cf/CookieStorageCFNet.h:

Source/WebKit2:

Shared/HTTPCookieAcceptPolicy.h: Added.

UIProcess/API/C/WKAPICast.h:

(WebKit::toHTTPCookieAcceptPolicy):
(WebKit::toAPI):

UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetHTTPCookieAcceptPolicy):
Call through to WebCookieManagerProxy.
(WKCookieManagerGetHTTPCookieAcceptPolicy):
Ditto.

UIProcess/API/C/WKCookieManager.h:

UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::invalidate):
Invalidate the get http cookie accept policy callbacks.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Send a message to the Web Process with the new value.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
Keep track of the callback and send a message to the Web Process.
(WebKit::WebCookieManagerProxy::didGetHTTPCookieAcceptPolicy):
Invoke the callback.

UIProcess/mac/WebCookieManagerProxyMac.mm: Added.

(WebKit::WebCookieManagerProxy::persistHTTPCookieAcceptPolicy):
On Mac, also set the policy in the UI Process because the sandboxed Web Process cannot
persist the policy.

UIProcess/WebCookieManagerProxy.h:
UIProcess/WebCookieManagerProxy.messages.in:

WebKit2.pri:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Common.vsprops:

WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
Call platformSetHTTPCookieAcceptPolicy.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Send the result of platformGetHTTPCookieAcceptPolicy to the UI Process.

WebProcess/Cookies/WebCookieManager.h:
WebProcess/Cookies/WebCookieManager.messages.in:

WebProcess/Cookies/cf: Added.
WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on both the default cookie storage and any Private Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

WebProcess/Cookies/mac: Added.
WebProcess/Cookies/mac/WebCookieManagerMac.mm: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on the default cookie storage and add a FIXME to set it on any Private
Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

WebProcess/Cookies/gtk: Added.
WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

WebProcess/Cookies/qt: Added.
WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

Tools:

Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.

The test is named "CookieManager" so that we can eventually exercise more of the
CookieManager functionality in the test.

TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.

(TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
Assert that the policy returned is equal to the policy set in
didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
(TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
Set the policy to something different than the user's policy and get the policy again.
(TestWebKitAPI::didFinishLoadForFrame):
Get the user's policy so that it can be restored at the end of the test.
(TestWebKitAPI::TEST):
Load about:blank so that the Web Process gets instatiated (needed to get the
CookieManager).

TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add CookieManager.cpp.

12:12 PM Changeset in webkit [81979] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-03-25 Cary Clark <caryclark@google.com>

Reviewed by Dimitri Glazkov.

Add CGBitmapContext.h include to WebViewImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=57097

No tests. Exposes no new functionality.

src/WebViewImpl.cpp:

12:08 PM Changeset in webkit [81978] by eae@chromium.org

6 edits
2 adds in trunk

2011-03-25 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Text field "onchange" event is triggered if actual value unchanged
https://bugs.webkit.org/show_bug.cgi?id=36314

Add tests for text field change events.

fast/events/onchange-text-form-field-expected.txt: Added.
fast/events/onchange-text-form-field.html: Added.

2011-03-25 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Text field "onchange" event is triggered if actual value unchanged
https://bugs.webkit.org/show_bug.cgi?id=36314

Change RenderTextControl::subtreeHasChanged to only return true if the
subtree has changed since the last event was triggered.

html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::setTextAsOfLastFormControlChangeEvent):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setValue):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue):

11:59 AM Changeset in webkit [81977] by bfulgham@webkit.org

7 edits
2 adds
3 deletes in trunk/Source/WebCore

Clean up FontPlatformData structure so that a single implementation
is used across all ports. This first patch works for the Windows
build (both CG and WinCairo), and Cocoa.

Reviewed by David Hyatt.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/FontPlatformData.cpp: Added.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):

platform/graphics/FontPlatformData.h: Added.

(WebCore::toCTFontRef):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::orientation):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::setOrientation):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):

platform/graphics/cg/FontPlatformData.h: Removed.
platform/graphics/cocoa/FontPlatformData.h: Removed.
platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

platform/graphics/win/cairo/FontPlatformData.h: Removed.

11:50 AM Changeset in webkit [81976] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Websockets tests sometimes time out on apple-windows-5
https://bugs.webkit.org/show_bug.cgi?id=55579

Unreviewed, skipping all the websocket tests on Windows to get the bots green.

platform/win/Skipped:

11:48 AM Changeset in webkit [81975] by bweinstein@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION(r79227): CFURLCache not initialized correctly in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57109
<rdar://problem/9184590>

Reviewed by Alexey Proskuryakov.

Check for a trailing Windows path separator, not a Unix path separator.

UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

11:47 AM Changeset in webkit [81974] by enrica@apple.com

2 edits in trunk/Source/WebCore

Pasteboard data's RTF data doesn't always include URLs via NSLinkAttributeName.
https://bugs.webkit.org/show_bug.cgi?id=57107
<rdar://problem/9084267>

Reviewed by Oliver Hunt.

If the selection is at the beginning of content inside an anchor tag
we move the selection start to include the anchor.

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Modified to change the selection
start according to the new rule.

11:44 AM Changeset in webkit [81973] by enne@google.com

2 edits in branches/chromium/696/Source/WebCore/platform/graphics/chromium

Merge 80767 - 2011-03-10 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Make tiled compositor data structure more efficient.
https://bugs.webkit.org/show_bug.cgi?id=54133

Previously, the compositor had a sparse 2D array of tiles for the
whole page, most of which were null. The tiles were implicitly
located based on their position in the array. This was inefficient
when the page grew (e.g. infinite scrolling) and caused some bugs
(e.g. width * height > MAX_INT). This change modifies tiles to have
explicit positions so they can be stored in a hash map.

Tests: LayoutTests/compositing/

platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::invalidateTiles): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileAt): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain):
platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::i): (WebCore::LayerTilerChromium::Tile::j): (WebCore::LayerTilerChromium::Tile::moveTo): (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):

TBR=enne@google.com

11:26 AM Changeset in webkit [81972] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-03-25 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[chromium] Remove deprecated overload of openFileSystem for workers
https://bugs.webkit.org/show_bug.cgi?id=57062

public/WebCommonWorkerClient.h:

10:55 AM Changeset in webkit [81971] by pfeldman@chromium.org

6 edits in trunk/Source/WebCore

2011-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor Network domain's frame tree API
https://bugs.webkit.org/show_bug.cgi?id=57103

inspector/Inspector.json:
inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForFrameResource): (WebCore::buildObjectForCachedResource): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::buildObjectForFrame): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::enable):
inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._createResource):
inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._clearResources):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame): (WebInspector.ResourcesPanel.prototype.addResourceToFrame):

10:49 AM Changeset in webkit [81970] by Dimitri Glazkov

3 edits
2 adds in trunk

2011-03-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
https://bugs.webkit.org/show_bug.cgi?id=56958

printing/page-count-layout-overflow-expected.txt: Added.
printing/page-count-layout-overflow.html: Added.

2011-03-25 Dave Hyatt <hyatt@apple.com>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
https://bugs.webkit.org/show_bug.cgi?id=56958

Test: printing/page-count-layout-overflow.html

page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow

to the right place.

10:32 AM Changeset in webkit [81969] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Remove duplicate entry from JavaScriptCore.exp

JSC::createStackOverflowError(JSC::ExecState*) was originally
exported in r60057, then duplicated in r60392.

JavaScriptCore.exp: Removed duplicate entry.

10:25 AM Changeset in webkit [81968] by benjamin.poulain@nokia.com

8 edits in trunk/Source/WebKit2

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::create):

Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::initializeGTK):

UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:

(tst_QGraphicsWKView::loadEmptyPage):
(tst_QGraphicsWKView::loadEmptyUrl):

UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:

(tst_QWKPage::loadEmptyUrl):

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
(WebKit::WebProcessMainQt):

10:21 AM Changeset in webkit [81967] by benjamin.poulain@nokia.com

6 edits in trunk/Source/WebCore

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
(JSC::Bindings::QtPixmapInstance::valueOf):

platform/qt/LanguageQt.cpp:

(WebCore::platformDefaultLanguage):

platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection):

plugins/qt/PluginPackageQt.cpp:

(WebCore::initializeGtk):

plugins/qt/PluginViewQt.cpp:

(WebCore::getPluginDisplay):

9:28 AM Changeset in webkit [81966] by bfulgham@webkit.org

2 edits in trunk/Source/WebKit2

Correct project file missing $(WebKitVSPropsRedirectionDir)s
after r81924.

win/WebKit2.vcproj: Restore lost $(WebKitVSPropsRedirectionDir)

9:21 AM Changeset in webkit [81965] by commit-queue@webkit.org

52 edits in trunk/Source

2011-03-25 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

Code refactoring. No new tests.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
dom/Document.cpp: (WebCore::acceptsEditingFocus):
dom/Node.cpp: (WebCore::Node::rendererIsEditable): (WebCore::Node::shouldUseInputMethod): (WebCore::Node::canStartSelection): (WebCore::Node::rootEditableElement):
dom/Node.h: (WebCore::Node::isContentEditable): (WebCore::Node::rendererIsEditable): (WebCore::Node::rendererIsRichlyEditable):
dom/Position.cpp: (WebCore::nextRenderedEditable): (WebCore::previousRenderedEditable): (WebCore::Position::atEditingBoundary): (WebCore::Position::parentEditingBoundary): (WebCore::Position::upstream): (WebCore::Position::downstream): (WebCore::Position::isCandidate):
dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): (WebCore::AppendNodeCommand::doApply): (WebCore::AppendNodeCommand::doUnapply):
editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement):
editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
editing/Editor.cpp: (WebCore::Editor::canDeleteRange): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
editing/FormatBlockCommand.cpp: (WebCore::enclosingBlockToSplitTreeTo):
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply):
editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply):
editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply): (WebCore::MergeIdenticalElementsCommand::doUnapply):
editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectionFromNone):
editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply): (WebCore::SplitElementCommand::doUnapply):
editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doUnapply): (WebCore::SplitTextNodeCommand::doReapply):
editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doUnapply): (WebCore::WrapContentsInDummySpanCommand::doReapply):
editing/htmlediting.cpp: (WebCore::highestEditableRoot): (WebCore::lowestEditableAncestor): (WebCore::isEditablePosition): (WebCore::isRichlyEditablePosition): (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::extendRangeToWrappingNodes): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::highestEnclosingNodeOfType): (WebCore::canMergeLists):
editing/visible_units.cpp: (WebCore::previousLeafWithSameEditability): (WebCore::previousLinePosition): (WebCore::nextLeafWithSameEditability): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::canStartSelection): (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus):
html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable):
html/HTMLElement.h:
page/DragController.cpp: (WebCore::DragController::operationForLoad): (WebCore::DragController::canProcessDrag):
page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::selectCursor):
page/FocusController.cpp: (WebCore::relinquishesEditingFocus):
rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): (WebCore::RenderBlock::hasLineIfEmpty):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::addOverflowFromInlineChildren):
rendering/RenderBox.cpp: (WebCore::RenderBox::canBeProgramaticallyScrolled):
rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf):
svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus):

2011-03-25 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition):

2011-03-25 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-03-25 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

9:11 AM Changeset in webkit [81964] by mjs@apple.com

3 edits
2 adds in trunk

2011-03-25 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Crash when a wbr element is inserted inside mroot
https://bugs.webkit.org/show_bug.cgi?id=56352

mathml/wbr-in-mroot-crash-expected.txt: Added.
mathml/wbr-in-mroot-crash.html: Added.

2011-03-25 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Crash when a wbr element is inserted inside mroot
https://bugs.webkit.org/show_bug.cgi?id=56352

Test: mathml/wbr-in-mroot-crash.html

rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first child, instead of just assuming.

8:28 AM Changeset in webkit [81963] by benjamin.poulain@nokia.com

2 edits in trunk/Source/JavaScriptCore

[Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe
https://bugs.webkit.org/show_bug.cgi?id=56098

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-03-25
Reviewed by Ariya Hidayat.

Need to link advapi32.lib for jsc.exe since wtf/OSRandomSource.cpp uses the Win32 Crypto API

jsc.pro:

8:10 AM Changeset in webkit [81962] by commit-queue@webkit.org

16 edits
5 adds in trunk

2011-03-25 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: extensions can't render original XML
https://bugs.webkit.org/show_bug.cgi?id=56263

Added source xml to transformed document, renamed onload function.

fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt:
fast/encoding/dumpAsText/utf-16-no-bom-expected.txt:
http/tests/xmlviewer/dumpAsText/wml-expected.txt:
http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt:
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt:
http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
http/tests/xmlviewer/dumpAsText/xul-expected.txt:
platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt:
platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
svg/hixie/error/dumpAsText/004-expected.txt:
svg/hixie/error/dumpAsText/005-expected.txt:
xmlviewer/extensions-api-expected.txt: Added.
xmlviewer/extensions-api.html_disabled: Added.
xmlviewer/resources/sample.xml: Added.

2011-03-25 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: extensions can't render original XML
https://bugs.webkit.org/show_bug.cgi?id=56263

Added source xml to transformed document, renamed onload function.

xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
xml/XMLViewer.xsl:

8:02 AM Changeset in webkit [81961] by benjamin.poulain@nokia.com

3 edits in trunk/Source/WebCore

2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Get rid of the invalid string conversion with ::fromAscii()
https://bugs.webkit.org/show_bug.cgi?id=57102

Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
platform/qt/CookieJarQt.cpp: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue):

7:17 AM Changeset in webkit [81960] by commit-queue@webkit.org

2 edits
1 add in trunk/PerformanceTests

2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG <use> element performance improvement
https://bugs.webkit.org/show_bug.cgi?id=57077

Add a manual test case which is from
http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg
for svg <use> element performance test.

PageLoad/svg/files/Sierpinski_carpet_6.svg: Added.
PageLoad/svg/svg.pltsuite:

7:15 AM Changeset in webkit [81959] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-03-25 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] The keyboard shortcuts during fullscreen playback do not work.
https://bugs.webkit.org/show_bug.cgi?id=57095

We need to explicitely set the focus on the widget in order to receive the keyboard events.

WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::show):

6:58 AM Changeset in webkit [81958] by Adam Roben

1 edit
3 deletes in trunk/LayoutTests

Remove no-longer-necessary Windows results

r81925 made Windows match Mac on this test. New Windows results were checked in, but they
were generated using the wrong fonts. Since we match Mac now, we don't need Windows-specific
results at all.

platform/win/fast/css/percentage-non-integer-expected.checksum: Removed.
platform/win/fast/css/percentage-non-integer-expected.png: Removed.
platform/win/fast/css/percentage-non-integer-expected.txt: Removed.

6:39 AM Changeset in webkit [81957] by commit-queue@webkit.org

10 edits
2 deletes in trunk

2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81953.
http://trac.webkit.org/changeset/81953
https://bugs.webkit.org/show_bug.cgi?id=57096

"inspector test breakage: part 2/2" (Requested by apavlov on
#webkit).

inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
inspector/styles/get-set-stylesheet-text.html: Removed.
inspector/styles/styles-new-API.html:

2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81953.
http://trac.webkit.org/changeset/81953
https://bugs.webkit.org/show_bug.cgi?id=57096

"inspector test breakage: part 2/2" (Requested by apavlov on
#webkit).

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles):
inspector/InspectorCSSAgent.h:
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
inspector/InspectorStyleSheet.h:
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

5:48 AM Changeset in webkit [81956] by commit-queue@webkit.org

1 edit
1 delete in trunk/LayoutTests

2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81954.
http://trac.webkit.org/changeset/81954
https://bugs.webkit.org/show_bug.cgi?id=57094

"inspector test breakage: part 1/2" (Requested by apavlov on
#webkit).

inspector/styles/resources/get-set-stylesheet-text.css: Removed.

5:00 AM Changeset in webkit [81955] by mnaganov@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-03-25 Mikhail Naganov <mnaganov@chromium.org>

Roll forward Chromium deps to r79379 to pick up V8 3.2.4.2.

DEPS:

4:59 AM Changeset in webkit [81954] by apavlov@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-03-25 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, build fix. Add file missing from r81953

inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):

4:11 AM Changeset in webkit [81953] by apavlov@chromium.org

10 edits
2 adds in trunk

2011-03-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310

inspector/styles/get-set-stylesheet-text-expected.txt: Added.
inspector/styles/get-set-stylesheet-text.html: Added.
inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
inspector/styles/styles-new-API.html:

2011-03-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
inspector/InspectorCSSAgent.h:
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
inspector/InspectorStyleSheet.h:
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

3:33 AM Changeset in webkit [81952] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

2011-03-25 Priit Laes <plaes@plaes.org>

Reviewed by Martin Robinson.

[GTK] [PATCH] Avoid critical warning when free-ing list of plugins
https://bugs.webkit.org/show_bug.cgi?id=57025

webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_plugins_list_free): Use regular check and return instead of g_return_if_fail.

3:05 AM Changeset in webkit [81951] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension server should not convert all resources to HAR when there are no extensions.
https://bugs.webkit.org/show_bug.cgi?id=57044

inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype._hasSubscribers):

2:19 AM Changeset in webkit [81950] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

SVG <use> element performance improvement
https://bugs.webkit.org/show_bug.cgi?id=57077

SVG <use> element was expanding nesting <use> and <symbol> elements
in an inefficient way. After it expanded an <use> or a <symbol>
element it would restart expanding from the shadow tree root.
This behavior was leading about 160 millions of calls to
expandUseElementInShadowTree or expandSymbolElementInShadowTree for
a single shadow tree which is illustrated by
http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg.
But the effective calls, which really expand <use> or <symbol>
elements, were about 5200; others were passing-by calls, which are
recursively down to the children.

This patch is altering the expanding path to reduce the passing-by
calls. It will expand elements in sibling chain where there is an
effective call, because the effective call replaces element which is
expanded and the replacement results lose of the sibling chain of
the replaced on the upper recursion stack. With this patch the
passing-by calls are reduced from about 160 millions to about 30
thousands.

No functionality change, no new tests.

svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree): (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
svg/SVGUseElement.h:

2:19 AM Changeset in webkit [81949] by sergio@webkit.org

6 edits in trunk/LayoutTests

2011-03-25 Sergio Villar Senin <svillar@igalia.com>

Rebaseline GTK+ tests results after r81887

platform/gtk/editing/pasteboard/5065605-expected.txt:
platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt:
platform/gtk/editing/pasteboard/paste-text-011-expected.txt:
platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

1:29 AM Changeset in webkit [81948] by alex

2 edits in trunk/Source/WebKit2

2011-03-25 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[WK2] Consider .c files in the generate-forwarding-headers script
https://bugs.webkit.org/show_bug.cgi?id=56680

Scripts/generate-forwarding-headers.pl:

1:18 AM Changeset in webkit [81947] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-03-25 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Adds a regression test for keygen autofocus.
https://bugs.webkit.org/show_bug.cgi?id=57091

fast/forms/autofocus-keygen-expected.txt: Added.
fast/forms/autofocus-keygen.html: Added.

2011-03-25 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Makes keygen support autofocus attribute.
https://bugs.webkit.org/show_bug.cgi?id=57091

Test: fast/forms/autofocus-keygen.html

html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::attach):

12:29 AM Changeset in webkit [81946] by mnaganov@chromium.org

1 edit
3 adds in trunk/LayoutTests

2011-03-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add tests for HeapSnapshot module.
https://bugs.webkit.org/show_bug.cgi?id=56835

http/tests/inspector/heap-snapshot-test.js: Added. (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject): (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock): (initialize_HeapSnapshotTest):
inspector/profiler/heap-snapshot-expected.txt: Added.
inspector/profiler/heap-snapshot.html: Added.

12:17 AM Changeset in webkit [81945] by mnaganov@chromium.org

1 edit
4 adds
2 deletes in trunk/LayoutTests

2011-03-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of testing framework.
https://bugs.webkit.org/show_bug.cgi?id=57006

http/tests/inspector/profiler-test.js: Added. (initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest): (initialize_ProfilerTest.InspectorTest.startProfilerTest): (initialize_ProfilerTest.InspectorTest.completeProfilerTest): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite.runner): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite): (initialize_ProfilerTest):
inspector/cpu-profiler-profiling-expected.txt: Removed.
inspector/cpu-profiler-profiling.html: Removed.
inspector/profiler/cpu-profiler-profiling-expected.txt: Added.
inspector/profiler/cpu-profiler-profiling.html: Added.

Mar 24, 2011:

11:56 PM Changeset in webkit [81944] by gyuyoung.kim@samsung.com

5 edits
4 adds in trunk/Source

2011-03-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add sound / mute button to MediaControl UI
https://bugs.webkit.org/show_bug.cgi?id=56726

Add sound / mute button to MediaControl UI.

platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::edjeGroupFromFormType): (WebCore::RenderThemeEfl::emitMediaButtonSignal): (WebCore::RenderThemeEfl::paintMediaMuteButton):
platform/efl/RenderThemeEfl.h:

2011-03-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add sound / mute button to MediaControl UI
https://bugs.webkit.org/show_bug.cgi?id=56726

Add sound / mute button to MediaControl UI.

DefaultTheme/default.edc:
DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Added.
DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Added.
DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Added.

11:35 PM Changeset in webkit [81943] by Nikolas Zimmermann

18 edits
2 adds in trunk/Source

2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

Introduce WTF HexNumber.h
https://bugs.webkit.org/show_bug.cgi?id=56099

Introduce a set of functions that ease converting from a bye or a number to a hex string,
replacing several of these conversions and String::format("%x") usages all over WebCore.

GNUmakefile.am: Add HexNumber.h to build.
JavaScriptCore.exp: Export StringBuilder::reserveCapacity.
JavaScriptCore.gypi: Add HexNumber.h to build.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export StringBuilder::reserveCapacity.
JavaScriptCore.vcproj/WTF/WTF.vcproj: Add HexNumber.h to build.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
wtf/CMakeLists.txt: Ditto.
wtf/HexNumber.h: Added. (WTF::Internal::hexDigitsForMode): Internal helper. (WTF::appendByteAsHex): Free function, that appends a byte as hex string into a destination. (WTF::placeByteAsHex): Ditto, but places the result using *foo++ = '..' or foo[index++] = '..' (WTF::appendUnsignedAsHex): Free function, that appends a number as hex string into a destination.

2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

Introduce WTF HexNumber.h
https://bugs.webkit.org/show_bug.cgi?id=56099

Introduce a set of functions that ease converting from a bye or a number to a hex string,
replacing several of these conversions and String::format("%x") usages all over WebCore.

ForwardingHeaders/wtf/HexNumber.h: Added.
css/CSSOMUtils.cpp: (WebCore::serializeCharacterAsCodePoint):
css/CSSParser.cpp: (WebCore::quoteCSSString):
inspector/InspectorResourceAgent.cpp: (WebCore::createReadableStringFromBinary):
platform/FileSystem.cpp: (WebCore::encodeForFileName):
platform/KURL.cpp: (WebCore::appendEscapedChar):
platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
platform/graphics/Color.cpp: (WebCore::Color::serialized):
platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodeStringAsFormData):
rendering/RenderTreeAsText.cpp: (WebCore::quoteAndEscapeNonPrintables):

11:31 PM Changeset in webkit [81942] by yutak@chromium.org

1 edit
4 adds in trunk/LayoutTests

2011-03-24 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rebaseline Chromium test results for Mac Leopard.

platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.checksum: Added.
platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.png: Added.

11:27 PM Changeset in webkit [81941] by jer.noble@apple.com

2 edits in trunk/Source/WebKit/mac

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81939.
http://trac.webkit.org/changeset/81939
https://bugs.webkit.org/show_bug.cgi?id=57084

Rolling out 81939, as it's causing a number of app cache test
failures. (Requested by jernoble on #webkit).

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

11:05 PM Changeset in webkit [81940] by kevino@webkit.org

4 edits in trunk

[wx] A couple build fixes after recent changes.

10:33 PM Changeset in webkit [81939] by jer.noble@apple.com

2 edits in trunk/Source/WebKit/mac

2011-03-23 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Application Cache should save audio/ and video/ mime types as flat files
https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>

No new tests.

Initialize the AppCache Total size quotas with the values for WebKitPreferences
upon startup.

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

10:06 PM Changeset in webkit [81938] by commit-queue@webkit.org

3 edits
4 deletes in trunk

2011-03-24 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Roben.

Implement layoutTestController.setAutoFilled in DRT on Windows
https://bugs.webkit.org/show_bug.cgi?id=56828

platform/chromium/fast/forms/input-autofilled-expected.txt: Removed.
platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed.
platform/win/fast/forms/input-autofilled-expected.txt: Removed.
platform/win/fast/forms/reset-autofilled-expected.txt: Removed.

2011-03-24 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Roben.

Implement layoutTestController.setAutoFilled in DRT on Windows
https://bugs.webkit.org/show_bug.cgi?id=56828

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAutofilled): Implemented.

9:10 PM Changeset in webkit [81937] by Stephanie Lewis

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57073
Rework the AtomicHTMLConstructor to reserve space for attributes based on the size of the attribute list.
Saves 1.5 MB on Membuster.

Reviewed by Geoff Garen.

No new tests because there was no change in behavior. Current tests pass.

html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

8:58 PM Changeset in webkit [81936] by Lucas Forschler

8 edits in branches/safari-534.26-branch

Versioning and Merge 81681, 34859, 81683, 34860, 81718.

8:50 PM Changeset in webkit [81935] by Lucas Forschler

1 copy in tags/Safari-534.26.2

New Tag.

8:23 PM Changeset in webkit [81934] by yutak@chromium.org

4 edits in trunk/LayoutTests

2011-03-24 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Rebaseline Chromium test results for fast/css/percentage-non-integer.html.

platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
platform/chromium-win/fast/css/percentage-non-integer-expected.png:
platform/chromium-win/fast/css/percentage-non-integer-expected.txt:

7:54 PM Changeset in webkit [81933] by commit-queue@webkit.org

45 edits
4 deletes in trunk

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

fast/images/embed-image-plugins-disabled.html: Removed.
platform/mac/fast/images/embed-image-expected.checksum:
platform/mac/fast/images/embed-image-expected.png:
platform/mac/fast/images/embed-image-expected.txt:
platform/mac/fast/images/embed-image-plugins-disabled-expected.checksum: Removed.
platform/mac/fast/images/embed-image-plugins-disabled-expected.png: Removed.
platform/mac/fast/images/embed-image-plugins-disabled-expected.txt: Removed.

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parametersForPlugin):
html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::isImageType): (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
html/HTMLPlugInImageElement.h:
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::objectContentType):
loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin): (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::shouldUsePlugin):
loader/SubframeLoader.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
src/FrameLoaderClientImpl.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::objectContentType):
WebCoreSupport/FrameLoaderClientEfl.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
WebCoreSupport/FrameLoaderClientGtk.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::objectContentType):
WebCoreSupport/FrameLoaderClientHaiku.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType):

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType):
WebCoreSupport/FrameLoaderClientQt.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebFrame.cpp: (WebFrame::objectContentType):
WebFrame.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::objectContentType):
WebCoreSupport/FrameLoaderClientWinCE.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::objectContentType):
WebKitSupport/FrameLoaderClientWx.h:

2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071

broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType):
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

7:34 PM Changeset in webkit [81932] by Dimitri Glazkov

6 edits in trunk/Source/WebCore

2011-03-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Eliminate Node::dispatchGenericEvent.
https://bugs.webkit.org/show_bug.cgi?id=57045

No functional change, covered by existing tests.

dom/Node.cpp: (WebCore::Node::dispatchEvent): Combined with the body of dispatchGenericEvent,

removed unnecessary extra refs and a stale comment.

dom/Node.h:
page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Changed to use dispatchEvent.
svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::dispatchEvent): Ditto. The code here still

works thanks to SVG-aware retargeting in Node.

7:13 PM Changeset in webkit [81931] by crogers@google.com

7 edits in trunk/Source/WebCore

2011-03-24 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

web audio: Properly sample-rate convert audio assets in chromium port
https://bugs.webkit.org/show_bug.cgi?id=56980

No new tests since audio API is not yet implemented.

WebCore.gypi:
platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
platform/audio/AudioBus.h:
platform/audio/HRTFKernel.cpp: (WebCore::extractAverageGroupDelay): (WebCore::HRTFKernel::HRTFKernel):
platform/audio/SincResampler.cpp:
platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource): (WebCore::createBusFromInMemoryAudioFile):

7:09 PM Changeset in webkit [81930] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-24 Min Qin <qinmin@google.com>

Reviewed by James Robinson.

Allow WebMediaPlayerClient to notify MediaPlayer that the playback state has changed

https://bugs.webkit.org/show_bug.cgi?id=56837

public/WebMediaPlayerClient.h:
src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::playbackStateChanged):
src/WebMediaPlayerClientImpl.h:

6:57 PM Changeset in webkit [81929] by scheib@chromium.org

6 edits in trunk/LayoutTests

2011-03-24 Vincent Scheib <scheib@chromium.org>

Update Chromium baselines for 81887

platform/chromium-win/editing/pasteboard/5065605-expected.txt:
platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

6:34 PM Changeset in webkit [81928] by beidson@apple.com

9 edits
2 adds in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=57069
Add WKIconDatabase api to the project files, and expose accessor on WKContext.

Reviewed by Darin Adler.

Project file stuffs:

GNUmakefile.am:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

Shared/API/c/WKBase.h:
UIProcess/API/C/WKAPICast.h:

UIProcess/API/C/WKContext.cpp:

(WKContextGetIconDatabase):

UIProcess/API/C/WKContext.h:

UIProcess/API/C/WKIconDatabase.cpp: Added.

(WKIconDatabaseGetTypeID):

UIProcess/API/C/WKIconDatabase.h: Added.

UIProcess/WebContext.h:

(WebKit::WebContext::iconDatabase):

6:29 PM Changeset in webkit [81927] by jam@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-03-23 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Get rid of WEB_TEXT_CHECKING_RESULT_IS_A_STRUCT since it's not needed anymore
https://bugs.webkit.org/show_bug.cgi?id=56955

DEPS:
public/WebTextCheckingResult.h:

6:10 PM Changeset in webkit [81926] by dimich@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-03-24 Bill Budge <bbudge@chromium.org>

Reviewed by Eric Seidel.

Change a forward declaration of WebURLLoaderOptions to struct to prevent a build break in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=57064

No tests. Exposes no new functionality.

public/WebFrame.h:

6:09 PM Changeset in webkit [81925] by commit-queue@webkit.org

6 edits in trunk

2011-03-24 Rik Cabanier <cabanier@adobe.com>

Reviewed by David Hyatt.

REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=56829

platform/win/fast/css/percentage-non-integer-expected.checksum:
platform/win/fast/css/percentage-non-integer-expected.png:
platform/win/fast/css/percentage-non-integer-expected.txt:

2011-03-24 Rik Cabanier <cabanier@adobe.com>

Reviewed by David Hyatt.

REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=56829

Test: fast/css/percentage-non-integer.html

platform/Length.h: (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::calcFloatValue):

6:08 PM Changeset in webkit [81924] by bfulgham@webkit.org

2 edits in trunk/Source/WebKit2

Build correction.

Disable the CA Layer stuff when building with Cairo.

win/WebKit2.vcproj:

5:22 PM Changeset in webkit [81923] by mihaip@chromium.org

3 edits
2 copies in trunk/LayoutTests

2011-03-24 Mihai Parparita <mihaip@chromium.org>

Add Chromium Snow Leopard baselines for fast/css/bidi-override-in-anonymous-block.html.

platform/chromium-mac-leopard/fast/css/bidi-override-in-anonymous-block-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum.
platform/chromium-mac-leopard/fast/css/bidi-override-in-anonymous-block-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png.
platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum:
platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:

5:18 PM Changeset in webkit [81922] by bfulgham@webkit.org

3 edits in trunk/Tools

Unreviewed build correction.

Correct vsprops file for Debug variant of the CFLite build.
Disable a CFNETWORK-specific test when building for CFLite.

TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
TestWebKitAPI/win/TestWebKitAPI.vcproj:

5:17 PM Changeset in webkit [81921] by mihaip@chromium.org

63 edits
1 copy
7 adds
4 deletes in trunk

2011-03-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] Vertical Japanese text is not displayed on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=56962

Pixel rebaselines after r80582 (vertical text was shifted by one pixel
vertical).

Make Snow Leopard check added by r80740 into a runtime check for
Chromium, since it uses the same binary on both Leopard and Snow Leopard.

platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png:
platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Removed.
platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Removed.
platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
platform/chromium-mac/fast/dynamic/text-combine-expected.checksum:
platform/chromium-mac/fast/dynamic/text-combine-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium/test_expectations.txt:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/border-vertical-lr-expected.png:
platform/mac/fast/blockflow/broken-ideographic-font-expected.checksum:
platform/mac/fast/blockflow/broken-ideographic-font-expected.png:
platform/mac/fast/blockflow/japanese-lr-selection-expected.checksum:
platform/mac/fast/blockflow/japanese-lr-selection-expected.png:
platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
platform/mac/fast/blockflow/japanese-lr-text-expected.png:
platform/mac/fast/blockflow/japanese-rl-selection-expected.checksum:
platform/mac/fast/blockflow/japanese-rl-selection-expected.png:
platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
platform/mac/fast/blockflow/japanese-rl-text-expected.png:
platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
platform/mac/fast/blockflow/vertical-align-table-baseline-expected.png:
platform/mac/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/mac/fast/blockflow/vertical-baseline-alignment-expected.png:
platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
platform/mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
platform/mac/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
platform/mac/fast/ruby/base-shorter-than-text-expected.checksum:
platform/mac/fast/ruby/base-shorter-than-text-expected.png:
platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
platform/mac/fast/text/justify-ideograph-vertical-expected.png:

2011-03-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] Vertical Japanese text is not displayed on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=56962

Make Snow Leopard check added by r80740 into a runtime check for
Chromium, since it uses the same binary on both Leopard and Snow Leopard.

platform/graphics/mac/FontMac.mm: (WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs): (WebCore::showGlyphsWithAdvances):

4:58 PM Changeset in webkit [81920] by beidson@apple.com

11 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=57058
Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation

Reviewed by Sam Weinig.

../WebCore:

loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousLoadDecisionForIconURL): Only add the DocumentLoader to the set if it's non-zero.
(WebCore::IconDatabase::IconDatabase): Add more logging.
(WebCore::IconDatabase::performURLImport): Dispatch the "didFinishURLImport" client callback using the following 3 methods.
(WebCore::FinishedURLImport::FinishedURLImport):
(WebCore::FinishedURLImport::performWork):
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):

loader/icon/IconDatabase.h:

(WebCore::IconDatabase::create): Expose a PassOwnPtr<> creator.

WebCore.exp.in:

../WebKit2:

UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::setDatabasePath): Create a new WebCore::IconDatabase and open it to this path.
(WebKit::WebIconDatabase::retainIconForPageURL): Actually retain the url, using the impl.
(WebKit::WebIconDatabase::releaseIconForPageURL): Actually release the url, using the impl.
(WebKit::WebIconDatabase::setIconURLForPageURL): Actually set the url, using the impl.
(WebKit::WebIconDatabase::setIconDataForIconURL): Actually set the data, using the impl.
(WebKit::WebIconDatabase::getLoadDecisionForIconURL): Actually ask for a load decision to call back with.
(WebKit::WebIconDatabase::performImport):
(WebKit::WebIconDatabase::didImportIconURLForPageURL):
(WebKit::WebIconDatabase::didImportIconDataForPageURL):
(WebKit::WebIconDatabase::didChangeIconForPageURL):
(WebKit::WebIconDatabase::didRemoveAllIcons):
(WebKit::WebIconDatabase::didFinishURLImport): Notify all the pending callbacks what their load decisions

are now that they're available.

UIProcess/WebIconDatabase.h:

Add an IconDatabase logging channel:

Platform/Logging.cpp:

(WebKit::initializeLogChannelsIfNecessary):

Platform/Logging.h:

UIProcess/WebContext.cpp:

(WebKit::WebContext::setIconDatabasePath): Pass the new path on to the WebIconDatabase, possibly

opening it.

UIProcess/WebContext.h:

4:57 PM Changeset in webkit [81919] by jer.noble@apple.com

5 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Application Cache should save audio/ and video/ mime types as flat files
https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>

No new tests.

ApplicationCacheResource::create() now takes an additional "path" parameter. To facilitate
extracting this path information, two functions in ApplicationCacheHost have been made public.

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Pass along new "path" parameter. (WebCore::ApplicationCacheGroup::didFail): Ditto.
loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Made public. (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource): Made public.
loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::ApplicationCacheResource): Add new "path" parameter.
loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create): Ditto. (WebCore::ApplicationCacheResource::path): New accessor.

4:44 PM Changeset in webkit [81918] by dpranke@chromium.org

5 edits in trunk/Tools

2011-03-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

fix regressions introduced in 81908 - there were a couple of
code paths that only fired under python 2.5 that I missed.

Also change a couple of 'python' references to sys.executable
in order to handle runing test-webkitpy with a binary other than
something called 'python'.

https://bugs.webkit.org/show_bug.cgi?id=57063

Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/test/cat.py:
Scripts/webkitpy/test/echo.py:

4:37 PM Changeset in webkit [81917] by aestes@apple.com

2 edits in trunk/Source/WebKit/chromium

Fix the chromium build.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::objectContentType):

4:34 PM Changeset in webkit [81916] by aestes@apple.com

45 edits
4 adds in trunk

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

fast/images/embed-image-plugins-disabled.html: Added.
platform/mac/fast/images/embed-image-expected.checksum:
platform/mac/fast/images/embed-image-expected.png:
platform/mac/fast/images/embed-image-expected.txt:
platform/mac/fast/images/embed-image-plugins-disabled-expected.checksum: Added.
platform/mac/fast/images/embed-image-plugins-disabled-expected.png: Added.
platform/mac/fast/images/embed-image-plugins-disabled-expected.txt: Added.

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
src/FrameLoaderClientImpl.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType):
WebCoreSupport/FrameLoaderClientQt.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
WebCoreSupport/FrameLoaderClientGtk.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebFrame.cpp: (WebFrame::objectContentType):
WebFrame.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::objectContentType):
WebKitSupport/FrameLoaderClientWx.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType):

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::objectContentType):
WebCoreSupport/FrameLoaderClientHaiku.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::objectContentType):
WebCoreSupport/FrameLoaderClientWinCE.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::objectContentType):
WebCoreSupport/FrameLoaderClientEfl.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
QuickTime plug-in in web pages. r70748 removed our mapping of classids
to MIME types, which causes WebKit to fall back from the object to the
embed tag when QuickTime is embedded by this script. The script emits
the following embed tag to embed a QuickTime movie with a poster frame:

<embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">

The expectation is that a QuickTime plug-in is instantiated to display the
poster frame, since QuickTime registers for many common image MIME
types. This is how Gecko behaves for embed. However, WebKit prefers to
use its native image rendering for image embeds, in which case no movie
is played when the poster frame is clicked.

Fix this by changing embed to check for a plug-in that can handle the
image type before rendering the image natively. This matches Gecko.

Test: fast/images/embed-image-plugins-disabled.html

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin):
html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::isImageType): (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::preferPluginsForImages):
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::objectContentType):
loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin): (WebCore::SubframeLoader::requestPlugin): (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::shouldUsePlugin):
loader/SubframeLoader.h:

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType):
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

4:12 PM Changeset in webkit [81915] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

2011-03-24 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Move lifetime management of grContext from a global to being
per-SharedGraphicsContext3D, which correctly is 1:1 with the
underlying opengl context.
https://bugs.webkit.org/show_bug.cgi?id=54330

No new tests. Existing <canvas> tests exercise this:

platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::setGrContext):
platform/graphics/gpu/DrawingBuffer.h:
platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::getGrContext):
platform/graphics/gpu/SharedGraphicsContext3D.h:
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

3:59 PM Changeset in webkit [81914] by bfulgham@webkit.org

2 edits
2 adds in trunk/Tools

Unreviewed build correction.

Add a stub implementation of the TestInvocation dumping logic.
Update project files to reflect new file.

WebKitTestRunner/cairo: Added.
WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

WebKitTestRunner/win/WebKitTestRunner.vcproj:

3:54 PM Changeset in webkit [81913] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-24 Bill Budge <bbudge@chromium.org>

Reviewed by Dmitry Titov.

Add an overloaded WebFrame::createAssociatedURLLoader method that takes WebURLLoaderOptions, so clients can specify CORS options to allow cross-origin requests.
https://bugs.webkit.org/show_bug.cgi?id=56885

No new tests. Exposes no new functionality.

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createAssociatedURLLoader):
src/WebFrameImpl.h:

3:51 PM Changeset in webkit [81912] by Adam Roben

3 edits
2 adds in trunk/Source/WebKit2

Start compiling LayerTreeHostCA on Windows

Fixes <http://webkit.org/b/57060> WebKit2.vcproj should compile LayerTreeHostCA

Reviewed by Anders Carlsson.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: Added.

(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Stubbed out.

win/WebKit2.vcproj: Added new files. Let VS reorder existing files.

win/WebKit2Apple.vsprops: Added WebProcess\WebPage\ca to the include path.

3:42 PM Changeset in webkit [81911] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

Remove reference to LayerTreeHostMac.h from WebFullScreenManagerMac.mm.

WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

3:24 PM Changeset in webkit [81910] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 2: Add new symobl.

(I should have used the EWS bots for this!)

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:20 PM Changeset in webkit [81909] by Dimitri Glazkov

4 edits in trunk/Source/WebCore

2011-03-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Untangle dependency between event ancestor chain computation and InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=57050

Inspector's list of event listeners does not need to invoke Node::getEventListeners,
because it simply wants to collect all ancestors and never uses EventContext bits.

No functional change, covered by existing tests.

dom/Node.cpp: (WebCore::getEventAncestors): Converted into a static function. (WebCore::Node::dispatchGenericEvent): Changed to pass node to getEventAncestors.
dom/Node.h: Removed decl, moved EventDispatchBehavior enum inside.
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Replaced the call

to getEventAncestors with a simple ancestor traversal loop.

3:14 PM Changeset in webkit [81908] by dpranke@chromium.org

7 edits in trunk/Tools

2011-03-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: clean up worker model defaults. This
changes the default behavior to 'threads' instead of
'old-threads', and clarifies that chromium-win-* and
chromium-mac-leopard are exceptions.

https://bugs.webkit.org/show_bug.cgi?id=56971

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

3:13 PM Changeset in webkit [81907] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 1: Removed old symobl.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:13 PM Changeset in webkit [81906] by commit-queue@webkit.org

4 edits in trunk

2011-03-24 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Make FileError and FileException accessible from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=57041

Fixed some test expectations related to FileError/FileExcetion and
exposed while testing this change under Chromium.

http/tests/filesystem/workers/resolve-url-sync-expected.txt:

2011-03-24 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Make FileError and FileException accessible from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=57041

workers/WorkerContext.idl:

3:11 PM Changeset in webkit [81905] by weinig@apple.com

5 edits in trunk/Source

2011-03-24 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove legacy version of findPlainText.
https://bugs.webkit.org/show_bug.cgi?id=57056

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches): Replace use of legacy findPlainText with a version that takes an options parameter.

2011-03-24 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove legacy version of findPlainText.
https://bugs.webkit.org/show_bug.cgi?id=57056

editing/TextIterator.cpp:
editing/TextIterator.h: Remove legacy overload of findPlainText that doesn't take an options parameter.

3:02 PM Changeset in webkit [81904] by ggaren@apple.com

15 edits in trunk/Source

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Ensure that all compilation takes place within a dynamic global object scope
https://bugs.webkit.org/show_bug.cgi?id=57054
<rdar://problem/9083011>

Otherwise, entry to the global object scope might throw away the code
we just compiled, causing a crash.

JavaScriptCore.exp: Updated for signature change.

debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Removed explicit compilation calls here because (a) they took place outside a dynamic global object scope and (b) they were redundant.

interpreter/CachedCall.h: (JSC::CachedCall::CachedCall): Updated for signature change.

interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): Declare our dynamic global object scope earlier, to ensure that compilation takes place within it.

runtime/Completion.cpp: (JSC::evaluate): Removed explicit compilation calls here because (a) they took place outside a dynamic global object scope and (b) they were redundant.

runtime/Executable.h: (JSC::EvalExecutable::compile): (JSC::ProgramExecutable::compile): (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): Added an ASSERT to verify our new invariant that all compilation takes place within a dynamic global object scope.

runtime/JSGlobalObject.cpp: (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
runtime/JSGlobalObject.h: Changed the signature of DynamicGlobalObjectScope to require a JSGlobalData instead of an ExecState* since it is often easier to provide the former, and the latter was not necessary.

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Ensure that all compilation takes place within a dynamic global object scope
https://bugs.webkit.org/show_bug.cgi?id=57054

WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.

2011-03-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Ensure that all compilation takes place within a dynamic global object scope
https://bugs.webkit.org/show_bug.cgi?id=57054

bindings/js/JSErrorHandler.cpp: (WebCore::JSErrorHandler::handleEvent):
bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): Updated for signature change.

2:50 PM Changeset in webkit [81903] by Adam Roben

3 edits
1 move
2 adds in trunk/Source/WebKit2

Split Mac-specific parts of LayerTreeHostCA into LayerTreeHostCAMac.mm

Fixes <http://webkit.org/b/57046> LayerTreeHostMac's code should be shareable with Windows

Reviewed by Anders Carlsson.

WebKit2.xcodeproj/project.pbxproj:

WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.mm.

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some Mac-specific code to
LayerTreeHostCAMac.mm.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Wrapped some Mac-specific code in
PLATFORM(MAC).

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
Moved some Mac-specific code to LayerTreeHostCAMac.mm.

(WebKit::LayerTreeHostCA::performScheduledLayerFlush): Renamed from
flushPendingLayerChangesRunLoopObserverCallback. Moved some code from here...
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush): ...to here. Moved some
Mac-specific code to LayerTreeHostCAMac.mm.

WebProcess/WebPage/ca/LayerTreeHostCA.h: Added new functions, wrapped some Mac-specific

declarations in PLATFORM(MAC).

WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: Added.

(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::flushPendingLayerChangesRunLoopObserverCallback):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Code was extracted from LayerTreeHostCA.cpp.

2:49 PM Changeset in webkit [81902] by Adam Roben

3 edits
2 moves
1 add in trunk/Source/WebKit2

Rename LayerTreeHostMac to LayerTreeHostCA

This is the first step toward sharing code with Windows.

Fixes <http://webkit.org/b/57051>.

Reviewed by Anders Carlsson.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):
Updated for rename.

WebProcess/WebPage/ca/LayerTreeHostCA.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h.
WebProcess/WebPage/ca/LayerTreeHostCA.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm.

2:45 PM Changeset in webkit [81901] by jer.noble@apple.com

3 edits in trunk/Source/WebKit2

2011-03-17 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Cancelling full screen early leaves full screen window up.
https://bugs.webkit.org/show_bug.cgi?id=56589

No new tests, as WebKitTestRunner does not currently support the new Full Screen API.

Notify the UIProcess when it needs to tear down its layer hosting view, turn off
the background layer when not in accelerated rendering mode and don't swap out
the web view unnecessarily

UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Check before swapping _webView. (-[WKFullScreenWindowController enterAcceleratedCompositingMode:]): Add the _layerHostingView

to the full screen window's animationView, not its contentsView.

(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Hide the background layer.

WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): If given a null rootLayer, tell

the client to exit accelerated mode.

2:44 PM Changeset in webkit [81900] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

2011-03-24 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

REGRESSION (r79987-r80210): Crash in JSWeakObjectMapClear
https://bugs.webkit.org/show_bug.cgi?id=55671

This is no longer necessary, and it seems that with the new weakmap
model it's simply unsafe, so this reduces it to a no-op.

API/JSWeakObjectMapRefPrivate.cpp:

2:40 PM Changeset in webkit [81899] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-03-24 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

preserveDrawingBuffer=true is ignored
https://bugs.webkit.org/show_bug.cgi?id=56987

Add code to the V8 and JSC bindings to support grabbing the value of
preserveDrawingBuffer from the input context attributes. Also, in
WebGLRenderingContext use the WebGLContextAttributes that were input
directly, not those from the GraphicsContext3D which could have been
changed.

No new tests, as this can't be tested with DRT. However, this works
when tested manually.

bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

2:22 PM Changeset in webkit [81898] by enrica@apple.com

11 edits in trunk/Source

WebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
https://bugs.webkit.org/show_bug.cgi?id=56975
<rdar://problem/8915066>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Adding support in WebCore to implement readSelectionFromPasteboard
to support Mac OS X services from WebKit2.

WebCore.exp.in:
editing/Editor.h:
editing/mac/EditorMac.mm:

(WebCore::Editor::readSelectionFromPasteboard): Added entry point
to call the paste functions with the specified pasteboard.

Source/WebKit2:

Adding missing entry point to support Mac OS X services in WebKit2.

UIProcess/API/mac/WKView.mm:

(-[WKView readSelectionFromPasteboard:]): Added.

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::readSelectionFromPasteboard): Added.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Added synchronous

message.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::readSelectionFromPasteboard): Added.

2:17 PM Changeset in webkit [81897] by commit-queue@webkit.org

10 edits
2 adds in trunk

2011-03-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not show correct transfer size for synchronous requests
https://bugs.webkit.org/show_bug.cgi?id=56951

Fixed transfer size for synchronous load.

http/tests/inspector/network/network-size-sync-expected.txt: Added.
http/tests/inspector/network/network-size-sync.html: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-03-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not show correct transfer size for synchronous requests
https://bugs.webkit.org/show_bug.cgi?id=56951

Fixed transfer size for synchronous load.

Test: http/tests/inspector/network/network-size-sync.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
loader/ResourceLoadNotifier.h:

2:14 PM Changeset in webkit [81896] by commit-queue@webkit.org

4 edits in trunk/Source

2011-03-24 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Dismissed reversion suggestion is incorrectly learned.
https://bugs.webkit.org/show_bug.cgi?id=57039

CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
[NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
incorrect automatic learning.

WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::dismissInternal):

2011-03-24 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Dismissed reversion suggestion is incorrectly learned.
https://bugs.webkit.org/show_bug.cgi?id=57039

CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
[NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
incorrect automatic learning.

UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::dismissInternal):

1:47 PM Changeset in webkit [81895] by bweinstein@apple.com

10 edits in trunk/Source/WebKit2

WebKit2: Add Trackpoint driver hack to support IBM trackpads
https://bugs.webkit.org/show_bug.cgi?id=49830
<rdar://problem/8705951>

Reviewed by Adam Roben.

Copy code from WebKit1 to WebKit2 to handle initializing fake scrollbars so
IBM machines with a trackpad send us WM_VSCROLL and WM_HSCROLL messages.

Listen for the WM_VSCROLL and WM_HSCROLL messages, and turn the values into
ScrollDirection and ScrollGranularity, and send a scroll command to the
WebProcess.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::scrollBy): Send a message to the WebProcess.

UIProcess/WebPageProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Add WM_VSCROLL and WM_HSCROLL message handling.
(WebKit::WebView::initialize): Call shouldInitializeTrackPointHack.
(WebKit::WebView::onHorizontalScroll): Turn wParam into a ScrollDirection and ScrollGranularity.
(WebKit::WebView::onVerticalScroll): Ditto.
(WebKit::WebView::shouldInitializeTrackPointHack): Check the registry for keys that indicate

the machine has a IBM Trackpoint driver.

UIProcess/win/WebView.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scrollBy): Call scroll method.
(WebKit::WebPage::scroll): Moved from WebPageMac and WebPageWin.
(WebKit::WebPage::logicalScroll): Ditto.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add a new scrollBy message.
WebProcess/WebPage/mac/WebPageMac.mm: Remove scroll and logicalScroll, they are now in WebPage.cpp.
WebProcess/WebPage/win/WebPageWin.cpp: Ditto.

1:38 PM Changeset in webkit [81894] by cevans@google.com

4 edits
2 copies in branches/chromium/696

Merge 81794
BUG=76195

1:26 PM Changeset in webkit [81893] by enrica@apple.com

5 edits in trunk/LayoutTests

Updating tests results for QT after changeset 81887.

platform/qt/editing/pasteboard/5065605-expected.txt:
platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
platform/qt/editing/pasteboard/paste-text-011-expected.txt:
platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

1:22 PM Changeset in webkit [81892] by beidson@apple.com

4 edits in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=57030
REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's
web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message

Reviewed by Adam Roben.

The callback objects had some bogus ASSERTs and missed a relevant null check. If a callback was waiting on
a message back from the UIProcess, but was invalidated from within the WebProcess in the meantime, it's
perfectly valid to attempt to performCallback() after the callback function pointer has been cleared.

loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):

LayoutTests: Resolving https://bugs.webkit.org/show_bug.cgi?id=57030, unskip the busted test.

Reviewed by Adam Roben.

platform/mac-wk2/Skipped:

1:14 PM Changeset in webkit [81891] by cevans@google.com

2 edits
2 copies in branches/chromium/696

Merge 81795
BUG=76474

1:06 PM Changeset in webkit [81890] by weinig@apple.com

9 edits in trunk/Source

Dictionary text extraction is not correctly detecting word boundaries on bing.com
<rdar://problem/9078569>
https://bugs.webkit.org/show_bug.cgi?id=56995

Reviewed by Darin Adler.

../WebCore:

WebCore.exp.in:

Add some editing related exports needed by WebKit2.

../WebKit2:

Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

Shared/DictionaryPopupInfo.h:

Add options dictionary.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):
Add path that can pass options through.

WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

(WebKit::WebContextMenuClient::lookUpInDictionary):
Use the new performDictionaryLookupForSelection which can extract context
if supported.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::characterRangeAtPositionForPoint):
(WebKit::characterRangeAtPoint):
Split functionality out of characterRangeAtPoint and into
characterRangeAtPositionForPoint to avoid doing duplicate work
if you already have the position.

(WebKit::isPositionInRange):
(WebKit::shouldUseSelection):
Add predicate to determine if we should use the selection instead
of expanding to find the word we are over.

(WebKit::WebPage::performDictionaryLookupAtLocation):
If available, use the surrounding paragraph as context to get better extraction
and to get lexicographical information about the word. Also, clean up and use
editing APIs to make the code more concise and understandable.

(WebKit::WebPage::performDictionaryLookupForSelection):
Use similar logic as in performDictionaryLookupAtLocation to extract additional
details from a selection for use in the dictionary popup.

(WebKit::WebPage::performDictionaryLookupForRange):
Pass options to WebProcess if available.

12:58 PM Changeset in webkit [81889] by aestes@apple.com

3 edits
2 adds in trunk

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
https://bugs.webkit.org/show_bug.cgi?id=56836

During fragment parsing, HTMLConstructionSite holds a reference to the
fragment context's closest form ancestor. If a misnested form end tag is
then encountered as the first node of the fragment, we will check to see
if a corresponding form start tag is in scope even though no such tag
exists. This led to isScope() walking the HTMLElementStack all the way
to the root DocumentFragment and attempting to cast it to Element*.

Fix this by ensuring that the inScope() family of functions operate in
terms of ContainerNodes to account for the fragment case.

Test: fast/parser/fragment-closest-form-ancestor.html

html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isRootNode): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope): (WebCore::HTMLElementStack::inScope):

2011-03-24 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
https://bugs.webkit.org/show_bug.cgi?id=56836

fast/parser/fragment-closest-form-ancestor-expected.txt: Added.
fast/parser/fragment-closest-form-ancestor.html: Added.

12:58 PM Changeset in webkit [81888] by cevans@google.com

6 edits
2 copies in branches/chromium/696

Merge 81851
BUG=76966

12:46 PM Changeset in webkit [81887] by enrica@apple.com

8 edits
2 adds in trunk

Source/WebCore: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874

Reviewed by Darin Adler.

When we calculate the style to apply at the insertion point we compare the initial
style at the insertion point against the style calculated at the span we wrap the
copied markup fragment with. We could end up with a series of unnecessary spans
to remove the initial style that simply grow our markup.
The consists in moving the insertion point outside any inline element that could
affect the fragment being inserted when we are not pasting and matching the style.

Test: editing/pasteboard/paste-text-with-style.html

editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Added.
(WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
point according to the new rules.

LayoutTests: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874

Reviewed by Darin Adler.

editing/pasteboard/paste-text-with-style-expected.txt: Added.
editing/pasteboard/paste-text-with-style.html: Added.

The following are new results for existing tests that now produce
a different markup.

platform/mac/editing/pasteboard/5065605-expected.txt:
platform/mac/editing/pasteboard/display-block-on-spans-expected.txt:
platform/mac/editing/pasteboard/paste-text-011-expected.txt:
platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

12:34 PM Changeset in webkit [81886] by benjamin.poulain@nokia.com

7 edits
7 adds in trunk/Source

2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884

The software fallback is now only needed for corner cases like a manual rendering
of the page to QImage.

Keeping the image with the last pixel values is no longer needed. Removing it reduce the
performance for real-time rendering on software surface, but this case should no longer be
supported.

The conversion from OpenGL color space and coordinates is done manually for performance. This
also fix the bug of the inverted X axis due to the transformation.

The tests and benchmarks are done through Qt API tests.

platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::swapBgrToRgb): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3D::reshape):

2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884

Add tests and benchmarks for the software fallback of WebGL.

tests/benchmarks/webgl/10000_triangles.html: Added.
tests/benchmarks/webgl/tst_webgl.cpp: Added. (GraphicsView::GraphicsView): (GraphicsView::resizeEvent): (tst_WebGlPerformance::init): (tst_WebGlPerformance::cleanup): (tst_WebGlPerformance::benchSoftwareFallbackRgb16): (tst_WebGlPerformance::benchSoftwareFallbackRgb32): (tst_WebGlPerformance::benchSoftwareFallbackArgb32): (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied): (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
tests/benchmarks/webgl/tst_webgl.qrc: Added.
tests/benchmarks/webgl/webgl.pro: Added.
tests/qgraphicswebview/qgraphicswebview.pro:
tests/qgraphicswebview/resources/pointing_right.html: Added.
tests/qgraphicswebview/resources/pointing_up.html: Added.
tests/qgraphicswebview/tst_qgraphicswebview.cpp: (compareImagesFuzzyPixelCount): (GraphicsView::GraphicsView): (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation): (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation): (tst_QGraphicsWebView::compareCanvasToImage):
tests/qgraphicswebview/tst_qgraphicswebview.qrc:
tests/tests.pro:

12:30 PM Changeset in webkit [81885] by cevans@google.com

2 edits
2 copies in branches/chromium/696

Merge 81786
BUG=77130

12:17 PM Changeset in webkit [81884] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-24 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Remove bool that forces compositor HUD to always be enabled
https://bugs.webkit.org/show_bug.cgi?id=57034

platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::enabled):

12:14 PM Changeset in webkit [81883] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit/mac

<http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X

Reviewed by Joseph Pecoraro.

Plugins/WebPluginContainerPrivate.h: Changed value of

ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.

12:14 PM Changeset in webkit [81882] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20302
Correct implementation of signbit on Solaris

wtf/MathExtras.h: (signbit):

12:02 PM Changeset in webkit [81881] by commit-queue@webkit.org

6 edits
1 add in trunk/Source

2011-03-24 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add traceEvents to compositor
https://bugs.webkit.org/show_bug.cgi?id=56965

WebCore.gypi:
platform/chromium/TraceEvent.h: Added. (WebCore::internal::ScopeTracer::ScopeTracer): (WebCore::internal::ScopeTracer::~ScopeTracer):
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::updateRootLayerScrollbars): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::finish): (WebCore::LayerRendererChromium::present):
platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update):

2011-03-24 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add traceEvents to compositor
https://bugs.webkit.org/show_bug.cgi?id=56965

src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

11:57 AM Changeset in webkit [81880] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

2011-03-24 Jon Lee <jonlee@apple.com>

Reviewed by Darin Adler.

WebKit2: Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state
<rdar://problem/8553962>

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setFocused): When the page loses focus, clear out any selection in the frame

11:11 AM Changeset in webkit [81879] by bweinstein@apple.com

2 edits in trunk/Source/WebKit2

Fix a typo in the VK_LEFT case of performDefaultBehaviorForKeyEvent.

Rubber-stamped by Sam Weinig.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent): It should be a logical or,

not a bitwise or.

11:11 AM Changeset in webkit [81878] by pfeldman@chromium.org

10 edits
1 add in trunk

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: render XHRs matching JSON regex as JSON.
https://bugs.webkit.org/show_bug.cgi?id=57035

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
inspector/front-end/RemoteObject.js: (WebInspector.LocalJSONObject.prototype.get description.switch.case): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype._concatenate): (WebInspector.LocalJSONObject.prototype.getProperties): (WebInspector.LocalJSONObject.prototype._children):
inspector/front-end/ResourceJSONView.js: Added. (WebInspector.ResourceJSONView): (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.hasContent): (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.show): (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (.resource-view.json):
inspector/front-end/inspector.html:

10:51 AM Changeset in webkit [81877] by jeffm@apple.com

2 edits in trunk/Source/WebKit2

Fix typo - USE(CF_NETWORK) should be USE(CFNETWORK).

WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:

(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): USE(CF_NETWORK) should be USE(CFNETWORK)

10:47 AM Changeset in webkit [81876] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Benjamin Poulain.

Avoided ASCII-cast warnings for WebKit.

Normally they won't be enabled anyway, but if you build webkit from
within the Qt mother repository it will pick up Qt's default build
settings, which do enable it. We need to disable them because
warnings are treated as errors and there are way too many of them in
the WebKit code.

[Qt] Avoid ASCII-cast warnings for WebKit.
https://bugs.webkit.org/show_bug.cgi?id=57016

QtWebKit.pro:

10:21 AM Changeset in webkit [81875] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

2011-03-24 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add accessibilityObject accessor to WebDocument (needed for
building an accessibility tree that includes iframes).
https://bugs.webkit.org/show_bug.cgi?id=56984

public/WebDocument.h:
src/WebDocument.cpp: (WebKit::WebDocument::accessibilityObject):

10:03 AM Changeset in webkit [81874] by Adam Roben

3 edits in trunk/LayoutTests

Add some flaky tests to the mac-wk2 and win-wk2 Skipped files

The failures are tracked by <http://webkit.org/b/57027> and <http://webkit.org/b/57030>.

platform/mac-wk2/Skipped: Added http/tests/inspector/extensions-resources-redirect.html.
platform/win-wk2/Skipped: Added inspector/debugger/source-frame.html.

10:03 AM Changeset in webkit [81873] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

2011-03-24 Ilya Sherman <isherman@chromium.org>

Reviewed by Dimitri Glazkov.

Expose Node::isFocusable() in the Chromium WebKit API
In service of https://code.google.com/p/chromium/issues/detail?id=72918
https://bugs.webkit.org/show_bug.cgi?id=56809

public/WebNode.h:
src/WebNode.cpp: (WebKit::WebNode::isFocusable):

9:58 AM Changeset in webkit [81872] by Dimitri Glazkov

4 edits in trunk/Source/WebCore

2011-03-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move media controls subtree creation into one method.
https://bugs.webkit.org/show_bug.cgi?id=56969

Mechanical move, no changes in functionality.

The purpose of this patch is to align existing code closer with its
future version, when MediaControls is an element whose tree is created
at the instantiation.

html/shadow/MediaControls.cpp: (WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place. (WebCore::MediaControls::update): Replaced methods with one call.
html/shadow/MediaControls.h: Updated decls.
rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::create): Moved setting of attributes here. (WebCore::MediaControlVolumeSliderElement::create): Ditto.

9:53 AM Changeset in webkit [81871] by sfalken@apple.com

2 edits in trunk/Source/WebCore

Use proper string method to generate webloc string.
https://bugs.webkit.org/show_bug.cgi?id=57028
<rdar://problem/9181955>

Reviewed by Darin Adler.

platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getWebLocData):

9:27 AM Changeset in webkit [81870] by Adam Roben

1 edit
3 adds in trunk/LayoutTests

Add Windows WebKit2 results for fast/css/pseudo-any.html

This test passes on Windows but fails on Mac. <http://webkit.org/b/56988> tracks the Mac
failure.

platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.

9:08 AM Changeset in webkit [81869] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=32821
Fix conditionals which had an int for one case and a pointer for another.
Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198

No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::valueForShadow):

8:30 AM Changeset in webkit [81868] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/qt

2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
https://bugs.webkit.org/show_bug.cgi?id=29595

Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
prepending the current directory.

By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
will end up loading "about:blank", but keeping it as a requested URL.

This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
is filled for the loaded URLs as well, we can use it in every case.

Three new autotests were added, to better cover the expected behavior of setting
the QUrl() in a QWebFrame.

Api/qwebframe.cpp: (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative. (QWebFrame::requestedUrl): always use m_lastRequestedUrl.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl anymore, since we always rely on it even for loaded frames.

tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes the reduction of the bug report. (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs. (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.

7:57 AM Changeset in webkit [81867] by podivilov@chromium.org

6 edits in trunk

2011-03-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide live edit callback to source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=57003

inspector/debugger/live-edit.html:

2011-03-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide live edit callback to source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=57003

inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource):
inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):

7:23 AM Changeset in webkit [81866] by Csaba Osztrogonác

2 edits
8 adds in trunk/LayoutTests

[Qt] Some Unicode tests fail with Qt version >= 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=46251

Patch by Joe Wild <joseph.wild@nokia.com> on 2011-03-24
Reviewed by Csaba Osztrogonác.

Updated tests the print out character 0xFFFF for Qt Platform.
QString.toUtf8() converts non-defined Unicode char values, like
0xFFFF to a replacement character ('?') as documented. Other
platforms leave the character as 0xFFFF (but utf8 encoded).
Converting to a real printable char seems reasonable and may
be more reliable.

platform/qt/Skipped:
platform/qt/fast/js/regexp-range-bound-ffff-expected.txt: Added.
platform/qt/fast/js/switch-behaviour-expected.txt: Added.
platform/qt/fast/url: Added.
platform/qt/fast/url/anchor-expected.txt: Added.
platform/qt/fast/url/path-expected.txt: Added.
platform/qt/http/tests/websocket: Added.
platform/qt/http/tests/websocket/tests: Added.
platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.

7:07 AM Changeset in webkit [81865] by pfeldman@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: removing newly added inspector test that fails on release bots.

http/tests/inspector/network/network-redirect-expected.txt: Removed.
http/tests/inspector/network/network-redirect.html: Removed.
platform/chromium/test_expectations.txt:

6:59 AM Changeset in webkit [81864] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updated chromium expectations.

platform/chromium/test_expectations.txt:

6:48 AM Changeset in webkit [81863] by benjamin.poulain@nokia.com

2 edits in trunk/Source/WebCore

2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

Regression: WebKit does not build with Python 3 following 56807
https://bugs.webkit.org/show_bug.cgi?id=56923

The module string does not have the function replace in Python 3. The str.replace function
can do the same operation in this case and works with the versions 2 and 3.

inspector/generate-inspector-idl:

6:38 AM Changeset in webkit [81862] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix chromium compilation.

public/WebDevToolsAgent.h:

6:27 AM Changeset in webkit [81861] by pfeldman@chromium.org

20 edits
2 adds in trunk

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up Network agent API.
https://bugs.webkit.org/show_bug.cgi?id=57001

http/tests/inspector/network/network-redirect-expected.txt: Added.
http/tests/inspector/network/network-redirect.html: Added.
inspector/timeline/timeline-network-resource-expected.txt:
platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up Network agent API.
https://bugs.webkit.org/show_bug.cgi?id=57001

inspector/Inspector.json:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willSendRequestImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willSendRequest):
inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForCachedResource): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::setExtraHeaders):
inspector/InspectorResourceAgent.h:
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest): (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
inspector/front-end/Resource.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):

2011-03-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up Network agent API.
https://bugs.webkit.org/show_bug.cgi?id=57001

public/WebDevToolsAgent.h:
src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest):
src/WebDevToolsAgentImpl.h:

4:19 AM Changeset in webkit [81860] by steveblock@google.com

23 edits
1 copy in trunk/Source/WebCore

2011-03-11 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JNIType is not specific to JNI so should be renamed
https://bugs.webkit.org/show_bug.cgi?id=56197

This patch renames JNIType to JavaType, renames the values of
the enum, and moves it out of JNIUtility.h to its own file.
Also renames the corresponding JavaField and JavaMethod getters.

No new tests, refactoring only.

GNUmakefile.am:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bridge/jni/JNIUtility.cpp: (JSC::Bindings::javaTypeFromClassName): (JSC::Bindings::signatureFromJavaType): (JSC::Bindings::javaTypeFromPrimitiveType): (JSC::Bindings::getJNIField): (JSC::Bindings::callJNIMethod):
bridge/jni/JNIUtility.h:
bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod): (JavaMethod::signature):
bridge/jni/JavaMethod.h: (JSC::Bindings::JavaMethod::returnTypeClassName): (JSC::Bindings::JavaMethod::returnType):
bridge/jni/JavaType.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
bridge/jni/jni_jsobject.mm: (JavaJSObject::toString):
bridge/jni/jni_objc.mm: (JSC::Bindings::dispatchJNICall):
bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
bridge/jni/jsc/JNIUtilityPrivate.h:
bridge/jni/jsc/JavaArrayJSC.cpp: (JavaArray::setValueAt): (JavaArray::valueAt):
bridge/jni/jsc/JavaClassJSC.cpp:
bridge/jni/jsc/JavaFieldJSC.cpp: (JavaField::JavaField): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance):
bridge/jni/jsc/JavaFieldJSC.h: (JSC::Bindings::JavaField::typeClassName): (JSC::Bindings::JavaField::type):
bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue): (JSC::Bindings::convertJValueToNPVariant):
bridge/jni/v8/JNIUtilityPrivate.h:
bridge/jni/v8/JavaFieldV8.cpp: (JavaField::JavaField):
bridge/jni/v8/JavaFieldV8.h: (JSC::Bindings::JavaField::typeClassName): (JSC::Bindings::JavaField::type):
bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod): (JavaInstance::getField):
bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectGetProperty):

3:55 AM Changeset in webkit [81859] by Philippe Normand

2 edits in trunk/LayoutTests

2011-03-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 3 xmlhttprequest tests timing out on GTK, see
also bug 33026.

platform/gtk/Skipped:

3:23 AM Changeset in webkit [81858] by Philippe Normand

1 edit
50 adds in trunk/LayoutTests

2011-03-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK fast/block/lineboxcontain baselines after
r81684 and r81608.

editing/selection/fake-drag-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/block-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/block-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/block-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/block-font-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/block-font-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/block-font-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/block-replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/font-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/font-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/font-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/font-replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/glyphs-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/glyphs-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/inline-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/inline-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/inline-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/none-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/none-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/none-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
platform/gtk/fast/block/lineboxcontain/replaced-expected.checksum: Added.
platform/gtk/fast/block/lineboxcontain/replaced-expected.png: Added.
platform/gtk/fast/block/lineboxcontain/replaced-expected.txt: Added.

12:55 AM Changeset in webkit [81857] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-03-24 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] WebBindings::getRangeImpl() should NULL check its NPObject argument
https://bugs.webkit.org/show_bug.cgi?id=56996

src/WebBindings.cpp: (WebKit::getRangeImpl):

12:31 AM Changeset in webkit [81856] by ojan@chromium.org

2 edits in trunk/Source/WebCore

2011-03-24 Ojan Vafai <ojan@chromium.org>

Was being a little braindead when I committed this.
Only simple selectors are allowed, but sibling selectors
are sibling selectors.

css/CSSStyleSelector.cpp: (WebCore::collectFeaturesFromList):

12:00 AM Changeset in webkit [81855] by morrita@google.com

10 edits
1 add in trunk/Source/WebCore

2011-03-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck feature specific symbols should be defined.
https://bugs.webkit.org/show_bug.cgi?id=56818

Introduced USE(UNIFIED_TEXT_CHECKING), USE(GRAMMAR_CHECKING) and USE(AUTOMATIC_TEXT_REPLACEMENT)
Replaced a part of of BUILDING_ON_* conditionals with them.

Note that small amount of code path on Editor.cpp is now compiled under USE(GRAMMAR_CHECKING)
because these code path is already built under non-Mac ports and
Keeping them buildable for such platforms reduces the build breakage risk.
These path is guarded by Settings thus should never get reached.

No new tests. No behavioral change.

WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::markMisspellingsAndBadGrammar):
editing/Editor.h:
editing/TextCheckingHelper.cpp: (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllBadGrammar):
loader/EmptyClients.h:
platform/text/TextCheckerClient.h:
platform/text/TextChecking.h: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed