⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 27, 2011:

11:46 PM Changeset in webkit [82088] by ukai@chromium.org
  • 3 edits
    3 adds in trunk

2011-03-27 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
​https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
  • http/tests/websocket/tests/close-unref-websocket.html: Added.
  • http/tests/websocket/tests/hanging-handshake_wsh.py: Added.

2011-03-27 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
​https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
WebSocketChannel suppress the second didClose().

Test: http/tests/websocket/tests/close-unref-websocket.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::didClose):
11:41 PM Changeset in webkit [82087] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-27 Andy Estes <​aestes@apple.com>

Reviewed by Maciej Stachowiak.

Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
​https://bugs.webkit.org/show_bug.cgi?id=57205


If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
plug-in MIME types, WebKit has to check for a property list file in
~/Library/Preferences for the MIME type dictionary.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary has the key WebPluginMIMETypesFilename, open the property list specified by that key's value and return the MIME type dictionary from there. Otherwise, return the MIME type dictionary specified by the key WebPluginMIMETypes. (WebKit::getPluginInfoFromPropertyLists): Call getMIMETypesFromPluginBundle().
11:09 PM Changeset in webkit [82086] by yutak@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.

  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.
10:15 PM Changeset in webkit [82085] by abarth@webkit.org
  • 11 edits in trunk

2011-03-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
​https://bugs.webkit.org/show_bug.cgi?id=57196

Test both allow => disallow and disallow => allow redirect cases.
Previously, we had incorrect expectations for one of the redirect
cases. Also, I've updated the policy syntax to match the default-src
syntax.

  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:

2011-03-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
​https://bugs.webkit.org/show_bug.cgi?id=57196

Resource-loading requirements in CSP apply to each hop in the redirect
chain. To make that work properly, we need to move enforcement into
the loader. Fortunately, we already have a choke-point in the loader
for enforcing this kind of policy.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunnerHost.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  • page/ContentSecurityPolicy.h:
9:27 PM Changeset in webkit [82084] by jer.noble@apple.com
  • 18 edits in trunk

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Pass whether keyboard access was requested up to ChromeClient when asking
if fullscreen mode is supported.

  • dom/Document.cpp: (WebCore::Document::webkitRequestFullScreenForElement):
  • page/ChromeClient.h: (WebCore::ChromeClient::supportsFullscreenForElement):

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullScreenForElement):
  • WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
  • WebView/WebViewInternal.h:

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::supportsFullScreen):
  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::supportsFullScreenForElement):
  • WebProcess/WebCoreSupport/WebChromeClient.h:

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Accept the withKeyboard parameter to supportsFullScreenForElement.

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
7:33 PM Changeset in webkit [82083] by Patrick Gansterer
  • 3 edits
    2 adds in trunk/Tools

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Levin.

check-webkit-style should check ChangeLog for a valid bug number
​https://bugs.webkit.org/show_bug.cgi?id=57184

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py: Added.
  • Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3:54 PM Changeset in webkit [82082] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

2011-03-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts):
2:22 PM Changeset in webkit [82081] by mrowe@apple.com
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

2:21 PM Changeset in webkit [82080] by mrowe@apple.com
  • 1 copy in tags/Safari-534.26.4

New tag.

2:21 PM Changeset in webkit [82079] by mrowe@apple.com
  • 3 edits in branches/safari-534.26-branch/Source/WebKit2

Merge r82078.

12:56 PM Changeset in webkit [82078] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Dock doesn't come back after leaving fullscreen on Hulu
​https://bugs.webkit.org/show_bug.cgi?id=57189
<rdar://problem/9192413>

Port some code over from the old WebKit1 plug-in host.

  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::shimShowMenuBar): (WebKit::shimHideMenuBar): (WebKit::shimIsMenuBarVisible):
12:26 PM Changeset in webkit [82077] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Keep a strong reference to the connection to avoid crashes.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:
12:15 PM Changeset in webkit [82076] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Fix build warning about IconDatabaseClient.h (wrong path.)

12:12 PM Changeset in webkit [82075] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support for CSS color and background-color properties on select element's dropdown list
​https://bugs.webkit.org/show_bug.cgi?id=51627

Extend the QWebSelectData interface with background and foreground colors
for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
getters in RenderMenuList.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/PopupMenuQt.cpp: (SelectData::backgroundColor): (SelectData::foregroundColor): (SelectData::itemBackgroundColor): (SelectData::itemForegroundColor):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
11:26 AM Changeset in webkit [82074] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-03-27 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] Fix Api test failure -- microFocusCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=57108

Since the canvas is not self-closing tag, we need to add '</canvas>'.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
10:52 AM Changeset in webkit [82073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
​https://bugs.webkit.org/show_bug.cgi?id=57143

Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
define WTF_USE_TEXTURE_MAPPER=1.

10:42 AM Changeset in webkit [82072] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Fix agentOS() in FrameLoaderClientEfl
​https://bugs.webkit.org/show_bug.cgi?id=57177

Replace old PLATFORM macro with OS and CPU.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
10:38 AM Changeset in webkit [82071] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[EFL] Use an appropriate user agent string
​https://bugs.webkit.org/show_bug.cgi?id=57176

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
10:28 AM Changeset in webkit [82070] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Use a appropriate user agent string
​https://bugs.webkit.org/show_bug.cgi?id=57175

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::userAgent):
10:24 AM Changeset in webkit [82069] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Generate WebKitVersion.h
​https://bugs.webkit.org/show_bug.cgi?id=57128

This file will be used for the user agent string by the CMake based ports.

  • CMakeLists.txt:
10:20 AM BuildingQtOnLinux edited by srikumar.b@gmail.com
(diff)
9:36 AM Changeset in webkit [82068] by yutak@chromium.org
  • 7 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add new Chromium test result and expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/chromium/test_expectations.txt:
9:36 AM Changeset in webkit [82067] by commit-queue@webkit.org
  • 14 edits in trunk/Source

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • wtf/MessageQueue.h:

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • dom/ExceptionCode.h:
  • editing/EditorInsertAction.h:
  • loader/FrameLoaderTypes.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/ScrollTypes.h:
  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/text/TextCodec.h:
7:50 AM Changeset in webkit [82066] by rwlbuis@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-27 Rob Buis <​rwlbuis@gmail.com>

Unreviewed, update improve test result.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
7:23 AM Changeset in webkit [82065] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
​https://bugs.webkit.org/show_bug.cgi?id=57183

The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
which was due to the outputting code previously being wrapped in eval().

  • Api/DerivedSources.pro:
6:26 AM Changeset in webkit [82064] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:38 AM Changeset in webkit [82063] by yutak@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add new Chromium test results.

  • platform/chromium-linux/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.txt: Added.
5:25 AM Changeset in webkit [82062] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, fix Chromium text expectation.

  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [82061] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-27 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Text on path positioning at zero startOffset
​https://bugs.webkit.org/show_bug.cgi?id=56245

Since for length 0 no previous point is set, choose epsilon
length to get normal at starting point of the path.

Test: svg/text/text-path-middle-align.svg

  • platform/graphics/Path.cpp: (WebCore::Path::normalAngleAtLength):
2:53 AM Changeset in webkit [82060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
created by Thiago Macieria in bug ​https://bugs.webkit.org/show_bug.cgi?id=24932

Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions

  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::thisObject):
12:18 AM Changeset in webkit [82059] by benjamin.poulain@nokia.com
  • 8 edits in trunk/Source/WebKit/qt

2011-03-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • Api/qwebkitversion.cpp: (qWebKitVersion):
  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::javaScriptConsoleMessage):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::setEditingBehavior): (DumpRenderTreeSupportQt::plainText):
  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
  • WebCoreSupport/InspectorServerQt.cpp: (WebCore::parseWebSocketChallengeNumber): (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

Mar 26, 2011:

10:19 PM Changeset in webkit [82058] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Jeff Miller <​jeffm@apple.com>

Reviewed by Sam Weinig.

WKErrorCopyCFError() doesn&apos;t actually return a copy of the CFErrorRef
​https://bugs.webkit.org/show_bug.cgi?id=57172

  • Shared/API/c/cf/WKErrorCF.cpp: (WKErrorCopyCFError): Use RetainPtr<> and leakRef() to return a real copy.
8:12 PM Changeset in webkit [82057] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix a bug which was causing the "skip back" button to be missing, causing
the media layout tests to fail.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

6:38 PM Changeset in webkit [82056] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
​https://bugs.webkit.org/show_bug.cgi?id=57169

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/blockflow/fallback-orientation.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.

LayoutTests:

  • fast/blockflow/fallback-orientation.html: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.
6:10 PM Changeset in webkit [82055] by mjs@apple.com
  • 5 edits in trunk

Source/WebKit2: Revert inadvertantly commited changes.

  • WebProcess/com.apple.WebProcess.sb:

Tools: Revert inadvertantly committed changes.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:58 PM Changeset in webkit [82054] by mjs@apple.com
  • 6 edits
    2 adds in trunk

2011-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
​https://bugs.webkit.org/show_bug.cgi?id=56150

Test: fast/css/giant-stylesheet-crash.html

  • dom/StyleElement.cpp: (WebCore::StyleElement::process):

2011-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
​https://bugs.webkit.org/show_bug.cgi?id=56150

  • fast/css/giant-stylesheet-crash-expected.txt: Added.
  • fast/css/giant-stylesheet-crash.html: Added.
5:15 PM Changeset in webkit [82053] by jer.noble@apple.com
  • 14 edits
    1 add in trunk/Source/WebCore

2011-03-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Media controls must use full screen style when in new full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=56851

Add new full screen styles for the full screen media elements.

  • DerivedSources.make: Add fullScreenQuickTime.css.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded(). (WebCore::CSSStyleSelector::CSSStyleSelector): Ditto. (WebCore::CSSStyleSelector::styleForElement): Load full screen rules

if needed.

  • css/fullscreenQuickTime.css: Added.
  • css/mediaControls.css:
  • html/shadow/MediaControls.cpp: (WebCore::isFullScreen): Added. (WebCore::MediaControls::create): Add new full screen volume controls. (WebCore::MediaControls::updateStyle): Ditto. (WebCore::MediaControls::update): Ditto. (WebCore::MediaControls::updateVolumeSliderContainer): Ditto. (WebCore::MediaControls::forwardEvent): Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::create): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet (WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
  • rendering/MediaControlElements.h:

Added m_overridePosition.

(WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added. (WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward

buttons.

5:03 PM Changeset in webkit [82052] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56956

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56956

  • Shared/WebPreferencesStore.h: Default the fullScreenEnabled preference to true.
4:46 PM Changeset in webkit [82051] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

RenderMedia should obey the view's flattening bit.
​https://bugs.webkit.org/show_bug.cgi?id=57156

Paint the current frame in software when the associated FrameView
has its flattening bit set.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
4:05 PM Changeset in webkit [82050] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for !ENABLE(DOM_STORAGE).

  • storage/StorageTracker.cpp:

Added #if ENABLE(DOM_STORAGE) like in the other storage files.

3:53 PM Changeset in webkit [82049] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57152

Reviewed by Steve Falkenburg.

We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.
Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor. Use return value from CertDuplicateCertificateContext().
(WebKit::PlatformCertificateInfo::operator=): Use return value from CertDuplicateCertificateContext().

  • Shared/win/PlatformCertificateInfo.h: Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor.
2:36 PM Changeset in webkit [82048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Graphic corruption appeared with Silverlight contents while resizing window
​https://bugs.webkit.org/show_bug.cgi?id=57167
<rdar://problem/9094052>

Pass DispatchMessageEvenWhenWaitingForSyncReply when sending GeometryDidChange messages since that will guarantee
that those messages will be handled before PaintEntirePlugin messages which prevents the PaintEntirePlugin handler from
painting into the wrong backing store.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
2:18 PM Changeset in webkit [82047] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Web process considered unresponsive (SPOD shown) when displaying a JavaScript alert() as a result of a click
<rdar://problem/9067557>
​https://bugs.webkit.org/show_bug.cgi?id=57166

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): Invalidate the responsiveness timer before calling out to the client.
2:17 PM Changeset in webkit [82046] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

2011-03-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Show page icons (favicons) in QtTestBrowser location bar.
​https://bugs.webkit.org/show_bug.cgi?id=57162

  • QtTestBrowser/QtTestBrowser.qrc:
  • QtTestBrowser/favicon.png: Added.
  • QtTestBrowser/locationedit.cpp: (defaultPageIcon): (LocationEdit::LocationEdit): (LocationEdit::setPageIcon): (LocationEdit::resizeEvent): (LocationEdit::updateInternalGeometry):
  • QtTestBrowser/locationedit.h:
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::onIconChanged): (MainWindow::onLoadStarted):
  • QtTestBrowser/mainwindow.h:
2:15 PM Changeset in webkit [82045] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

ASSERTION FAILED: m_operationInProgress == NoOperation loading nytimes.com
​https://bugs.webkit.org/show_bug.cgi?id=57165
<rdar://problem/9024311>

The assertion fired because during GC, the web process sends a synchronous NPObjectMessageReceiver::Deallocate
message to the plug-in process. Since this is a synchronous message, the web process needs to process incoming synchronous
messages. While waiting, we get an incoming PluginProxy::Evaluate message from the plug-in. This causes JavaScript to run
during GC which is very bad.

The fix for this is to add a flag on the connection that will cause synchronous messages sent by the connection (in this case the
plug-in process) to not be processed while the other side (the web process) is waiting for a synchronous reply _unless_ the connection
is actually processing a synchronous message. (The last part is to avoid deadlocks).

Since the call to NPN_Evaluate by the plug-in (that ends up sending the PluginProxy::Evaluate message) comes from a run loop timer firing,
it's OK to wait for it to be processed by the web process when it returns to the run loop.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage and m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount.

(CoreIPC::Connection::setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage):
Set m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage.

(CoreIPC::Connection::sendMessage):
Don't add the MessageID::DispatchMessageWhenWaitingForSyncReply flag when the right flags has been set on the connection, and it's not processing a synchronous message.

(CoreIPC::Connection::dispatchMessage):
Increment and decrement m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount accordingly.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::WebProcessConnection): Call setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the connection.
1:50 PM Changeset in webkit [82044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-26 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Benjamin Poulain.

[Qt] Remove GraphicsLayerTextureMapper::nativeLayer
​https://bugs.webkit.org/show_bug.cgi?id=57141

GraphicsLayer::nativeLayer was removed in r73380.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
1:48 PM Changeset in webkit [82043] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Rollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations))

-[NSString stringByResolvingSymlinksInPath] does not do what we needed for paths within /private.
This caused all SSL sites to stop working.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):

1:32 PM Changeset in webkit [82042] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
<rdar://problem/9127411>
​https://bugs.webkit.org/show_bug.cgi?id=57164

  • WebProcess/mac/WebProcessMac.mm: (WebKit::appendSandboxParameterPath): (WebKit::initializeSandbox): Use -[NSString stringByResolvingSymlinksInPath] instead of realpath to ensure we can resolve symlinks even if the file/directory doesn't exist yet.
1:20 PM Changeset in webkit [82041] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Factor processing of incoming sync replies out into processIncomingSyncReply
​https://bugs.webkit.org/show_bug.cgi?id=57161

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): Pass DispatchMessageEvenWhenWaitingForSyncReply to sendMessage.

(CoreIPC::Connection::processIncomingSyncReply):
Move code from processIncomingMessage to here.

(CoreIPC::Connection::processIncomingMessage):
Call processIncomingSyncReply.

1:14 PM Changeset in webkit [82040] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] layoutTestController.overridePreference("WebKitDefaultFontSize"...) does not take into account screen DPI
​https://bugs.webkit.org/show_bug.cgi?id=57160

Skip failing test. This bug was uncovered by r82033.

  • platform/gtk/Skipped:
1:07 PM Changeset in webkit [82039] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Remove a test from the GTK+ skipped list that no longer exists.

  • platform/gtk/Skipped: Update the skipped list.
1:04 PM Changeset in webkit [82038] by Martin Robinson
  • 10 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few more GTK+ tests after r82033.

  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
12:55 PM Changeset in webkit [82037] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Source/JavaScriptGlue

2011-03-26 Adam Barth <​abarth@webkit.org>

Remove the JavaScriptGlue GYP build. We're not going to use GYP for
JavaScriptGlue because JavaScriptGlue is used only by one port.

  • gyp: Removed.
  • gyp/JavaScriptGlue.gyp: Removed.
  • gyp/JavaScriptGlue.gypi: Removed.
  • gyp/remove-headers-if-needed.sh: Removed.
  • gyp/run-if-exists.sh: Removed.
  • gyp/update-info-plist.sh: Removed.
12:37 PM Changeset in webkit [82036] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate
<rdar://problem/9188041>
​https://bugs.webkit.org/show_bug.cgi?id=57159

  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::typeFromCFTypeRef): (CoreIPC::encode): (CoreIPC::decode):
  • Shared/cf/ArgumentCodersCF.h: Add encoding/decoding for SecCertificateRef type.
  • Shared/mac/PlatformCertificateInfo.mm: (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): Use ArgumentCodersCF now that it knows how to encode/decode SecCertificateRefs.
12:34 PM Changeset in webkit [82035] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Handle synchronous replies coming in out of order
​https://bugs.webkit.org/show_bug.cgi?id=57158

When processing an incoming reply, don't assume that it belongs to the last sent synchronous request.
Instead, iterate over the m_pendingSyncReplies vector backwards looking for the corresponding request.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage):
12:28 PM Changeset in webkit [82034] by andreas.kling@nokia.com
  • 5 edits
    2 adds in trunk/Source/WebKit/qt

2011-03-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
​https://bugs.webkit.org/show_bug.cgi?id=57157

Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
is always emitted when appropriate.

  • WebCoreSupport/IconDatabaseClientQt.h: Added.
  • WebCoreSupport/IconDatabaseClientQt.cpp: Added. (WebCore::IconDatabaseClientQt::instance): (WebCore::IconDatabaseClientQt::IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::performImport): (WebCore::IconDatabaseClientQt::didRemoveAllIcons): (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL): (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL): (WebCore::IconDatabaseClientQt::didChangeIconForPageURL): (WebCore::IconDatabaseClientQt::didFinishURLImport):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::registerForIconNotification): (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the QWebFrame::iconChanged() signal when the IconDatabases finishes loading a cached favicon for the frame's URL.
  • Api/qwebsettings.cpp: (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is instantiated. An IconDatabaseClient has to be registered before the IconDatabase spawns its reader thread.
11:52 AM Changeset in webkit [82033] by Martin Robinson
  • 196 edits in trunk

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
​https://bugs.webkit.org/show_bug.cgi?id=56866

Update GTK+ test results which now have differ.

  • platform/gtk/editing/pasteboard/4641033-expected.checksum:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.checksum:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.checksum:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.checksum:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.checksum:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/forms/001-expected.checksum:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.checksum:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.checksum:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.checksum:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.checksum:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.checksum:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/select-align-expected.checksum:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.checksum:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.checksum:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.checksum:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.checksum:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.checksum:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/html/keygen-expected.checksum:
  • platform/gtk/fast/html/keygen-expected.png:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/invalid/014-expected.checksum:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.checksum:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.checksum:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.checksum:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.checksum:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.checksum:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:

2011-03-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
​https://bugs.webkit.org/show_bug.cgi?id=56866

Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
broader compatibility with WebKit2 and makes setting font sizes more straightforward.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI. (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution. (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
11:23 AM Changeset in webkit [82032] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix a possible deadlock when two synchronous messages are sent at the same time
​https://bugs.webkit.org/show_bug.cgi?id=57155

Simplify code and fix a possible (although highly improbable) dead lock.

  • Platform/CoreIPC/Connection.cpp: Make SyncMessageState atomically ref counted since it can be ref()'ed from the connection queue. Get rid of m_waitForSyncReplyCount and add m_didScheduleDispatchMessagesWork.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_didScheduleDispatchMessagesWork to false.

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
if m_didScheduleDispatchMessagesWork is false, schedule a call to dispatchMessageAndResetDidScheduleDispatchMessagesWork
on the client run loop.

(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork):
Dispatch messages and set m_didScheduleDispatchMessagesWork back to false.

(CoreIPC::Connection::sendSyncMessage):
Remove calls to beginWaitForSyncReply and endWaitForSyncReply.

11:15 AM Changeset in webkit [82031] by Martin Robinson
  • 45 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Rebaseline many GTK+ tests after r81994.

  • platform/gtk/fast/block/positioning/056-expected.txt:
  • platform/gtk/fast/block/positioning/auto/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/gtk/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/gtk/fast/clip/001-expected.txt:
  • platform/gtk/fast/clip/004-expected.txt:
  • platform/gtk/fast/clip/006-expected.txt:
  • platform/gtk/fast/clip/007-expected.txt:
  • platform/gtk/fast/clip/008-expected.txt:
  • platform/gtk/fast/clip/009-expected.txt:
  • platform/gtk/fast/clip/010-expected.txt:
  • platform/gtk/fast/clip/011-expected.txt:
  • platform/gtk/fast/clip/012-expected.txt:
  • platform/gtk/fast/clip/013-expected.txt:
  • platform/gtk/fast/clip/014-expected.txt:
  • platform/gtk/fast/clip/nestedTransparencyClip-expected.txt:
  • platform/gtk/fast/clip/outline-overflowClip-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/layers/layer-visibility-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
7:38 AM Changeset in webkit [82030] by abarth@webkit.org
  • 2 edits in trunk

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We shouldn't bother running GYP if the generated files are newer than the GYP files
​https://bugs.webkit.org/show_bug.cgi?id=57146

In the common case, this check will avoid any overhead from processing
the GYP files. Another approach to doing this is to add the feature to
GYP directly, but GYP's approach to this problem is to compute the
output in its entirety and compare it byte-for-byte against the output
file. In the future, it might make sense to add this approach as an
alternative approach for GYP itself.

I also removed JavaScriptGlue from the script because we're not really
going to change JavaScriptGlue over to GYP. We were using
JavaScriptGlue as a learning experience.

  • Source/gyp/configure:
7:25 AM Changeset in webkit [82029] by Csaba Osztrogonác
  • 11 edits in trunk/LayoutTests

Update Qt specific expected results after r81992.

  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
4:59 AM Changeset in webkit [82028] by abarth@webkit.org
  • 10 edits
    2 adds in trunk

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
​https://bugs.webkit.org/show_bug.cgi?id=54799

Test a variety of source-list parsing cases. There's a bunch more
cases we could be testing. We'll add more over time.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing.html: Added.

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
​https://bugs.webkit.org/show_bug.cgi?id=54799

This patch is larger than I would like, but I wasn't sure how to make
it any smaller while still being reasonably testable. I've left out
some features (such as host wildcarding and 'self') so I can add them
in later patches with tests.

Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html

  • bindings/ScriptControllerBase.cpp:
  • dom/ScriptElement.cpp:
  • html/parser/HTMLDocumentParser.cpp:
  • loader/FrameLoader.cpp:
    • Add include explicitly now that we're not spamming the include everywhere.
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
    • We need to pass the SecurityOrigin object to ContentSecurityPolicy so that it can resolve implicit parts of source patterns, such as the scheme.
  • dom/Document.h:
    • Forward declare ContentSecurityPolicy rather than including the header. Technically this could be a separate change, but I was getting annoyed at the world re-builds.
  • page/ContentSecurityPolicy.cpp: (WebCore::skipExactly): (WebCore::skipUtil): (WebCore::skipWhile):
    • Clean up these parser helper functions. We might consider moving them to a more general location. They're very helpful for writing secure HTTP header parsers.

(WebCore::CSPSource::CSPSource):

  • New class to represent one source in a source-list.

(WebCore::CSPSource::matches):
(WebCore::CSPSource::schemeMatches):
(WebCore::CSPSource::hostMatches):
(WebCore::CSPSource::portMatches):
(WebCore::CSPSource::isSchemeOnly):

  • Currently we represent scheme-only sources using with an empty m_host. Another approach I considered was using another bool, but that seemed slighly messier.

(WebCore::CSPSourceList::CSPSourceList):

  • CSPSourceList doesn't need to ref SecurityOrigin because CSPSourceList is owned by ContentSecurityPolicy, which holds a ref.

(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::parseScheme):
(WebCore::CSPSourceList::parseHost):
(WebCore::CSPSourceList::parsePort):

  • A basic "segment and recurse" parser. This parser causes us to take more branches than we need, but I don't think we need to squeeze every last ouch of performance out of this parser. This approach is more simple than some of the other approaches I tried.

(WebCore::CSPSourceList::addSourceSelf):
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::parseDirective):
(WebCore::ContentSecurityPolicy::addDirective):

  • I couldn't resist re-writing this parser to use the helper functions and to match the style of the source-list parser.
  • page/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::create):
    • Accept a SecurityOrigin context object.
3:03 AM Changeset in webkit [82027] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL and WinCE build fix for r81977.

  • platform/graphics/FontPlatformData.h:
12:49 AM Changeset in webkit [82026] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added platform-specific expected results for a new test.

  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
12:22 AM Changeset in webkit [82025] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r82000.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::openFile): Added missing function.
12:07 AM Changeset in webkit [82024] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix.

  • CMakeListsWinCE.txt: Added missing include directory.
Note: See TracTimeline for information about the timeline view.