⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 1, 2011:

11:52 PM Changeset in webkit [82768] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=57693
Skipped the windowless_plugin_paint_test.html layout test on Webkit Windows.

  • platform/win/Skipped:
11:02 PM Changeset in webkit [82767] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-01 Ilya Tikhonovsky <​loislo@chromium.org>

Not reviewed trivial change.

Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
Followup change for r82281.
​https://bugs.webkit.org/show_bug.cgi?id=57327

  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
10:20 PM Changeset in webkit [82766] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

apos entities shouldn't show up in ChangeLogs when using webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=57692

Previously, we were using BeautifulSoup to process XML from
bugs.webkit.org, but that's incorrect. We should be using
BeautifulStoneSoup to process the XML. We were getting the &apos;
entity wrong because &apos; is an XML entity but not an HTML entity.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
8:44 PM Changeset in webkit [82765] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-04-01 Dimitri Glazkov <Dimitri Glazkov>

Skip the test landed in r82758, since WebKitTestRunner doesn't implement
displayInvalidatedRegion.

  • platform/mac-wk2/Skipped: Skipped the test.
8:32 PM Changeset in webkit [82764] by msaboff@apple.com
  • 7 edits in trunk/Source/WebCore

2011-04-01 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Cached Resource Overhead Space Usage and Accounting Inaccurate
​https://bugs.webkit.org/show_bug.cgi?id=57488

Fixed windows test failures.
Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.

No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::hasCacheValidatorFields): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
7:43 PM Changeset in webkit [82763] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

2011-04-01 Jon Lee <​jonlee@apple.com>

Reviewed by Darin Adler.

WebKit2: Type-to-select doesn't work in open <select> menu (53023)
​https://bugs.webkit.org/show_bug.cgi?id=53023
<rdar://problem/8907678>

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: adding new setPopupMenuSelectedIndex message for windows platform
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::setPopupMenuSelectedIndex):
  • UIProcess/win/WebPopupMenuProxyWin.h: moving setFocusedIndex() into public method
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp: (WebKit::WebPopupMenu::updateFromElement): send message back to UIProcess to update the selected element
7:43 PM Changeset in webkit [82762] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Skipping fast/workers/dedicated-worker-lifecycle instead of
treating it as SLOW. It appears to be downright flaky.

​https://bugs.webkit.org/show_bug.cgi?id=57678

  • platform/mac/test_expectations.txt:
7:42 PM Changeset in webkit [82761] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <​abarth@webkit.org>

This test fails by timing out.

  • platform/chromium/test_expectations.txt:
7:23 PM Changeset in webkit [82760] by dpranke@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

fix bug number

7:18 PM Changeset in webkit [82759] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Suppress some flaky bidi- and editing-related test failures on
SL Mac NRWT runs. See:

​https://bugs.webkit.org/show_bug.cgi?id=57662

  • platform/mac/test_expectations.txt:
7:03 PM Changeset in webkit [82758] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-04-01 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added. Added a layout test which verifies that a dynamically added plugin
receives a paint event. This test has to be skipped on chromium mac/linux and
on gtk and qt as it relies on support for the displayInvalidatedRegion function
in the LayoutTestController

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • plugins/windowless_plugin_paint_test-expected.txt: Added.
  • plugins/windowless_plugin_paint_test.html: Added.

2011-04-01 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

Test: plugins/windowless_plugin_paint_test.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):
6:45 PM Changeset in webkit [82757] by commit-queue@webkit.org
  • 7 edits in trunk

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
​http://trac.webkit.org/changeset/82721
​https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • platform/gtk/Skipped:

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
​http://trac.webkit.org/changeset/82721
​https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
​http://trac.webkit.org/changeset/82721
​https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):
6:43 PM Changeset in webkit [82756] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed buildfix.

[Qt][WK2] Build Webkit2 using "-2" option on Qt
​https://bugs.webkit.org/show_bug.cgi?id=55074

  • Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.

(The isWK2() function removes it from @ARGV, but not from @options.)

6:40 PM Changeset in webkit [82755] by commit-queue@webkit.org
  • 1 edit
    1 move in trunk/Tools

2011-04-01 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
​https://bugs.webkit.org/show_bug.cgi?id=57666

  • MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
6:23 PM Changeset in webkit [82754] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-01 Adam Barth <​abarth@webkit.org>

Attempt to fix the Chromium build using the great and powerful git.
This patch should be the remaining part of reverting Jeremy's ill-fated
refactoring.

  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStoreNames): (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::deleteObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::create): (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::name): (WebCore::IDBObjectStoreProxy::keyPath): (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::clear): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::deleteIndex): (WebCore::IDBObjectStoreProxy::openCursor):
5:55 PM Changeset in webkit [82753] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: fix feature detection, skipped platform lists on mac

We apparently never implemented the code to skip tests based on
what was compiled into DRT. Also, change the logic used to skip
platform directories to match what old-run-webkit-tests does:
skip every test not in a directory in the baseline search path.

​https://bugs.webkit.org/show_bug.cgi?id=57662

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:40 PM Changeset in webkit [82752] by mrowe@apple.com
  • 5 edits in trunk/Tools

<​http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed

Reviewed by Jon Honeycutt.

Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5:36 PM Changeset in webkit [82751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

always use native font rendering on skia_gpu
fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
​https://bugs.webkit.org/show_bug.cgi?id=57663

No new tests. existing rendering tests will exercise this

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
5:35 PM Changeset in webkit [82750] by abarth@webkit.org
  • 1 edit
    3 moves in trunk/Source/WebKit/chromium

2011-04-01 Adam Barth <​abarth@webkit.org>

Move these files back to their old locations. I'm not sure why the
rollout didn't move them properly.

  • src/IDBDatabaseBackendProxy.cpp: Removed.
  • src/IDBDatabaseBackendProxy.h: Removed.
  • src/IDBDatabaseProxy.cpp: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp.
  • src/IDBDatabaseProxy.h: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
  • src/IDBObjectStoreBackendProxy.cpp: Removed.
  • src/IDBObjectStoreProxy.cpp: Copied from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp.
5:27 PM Changeset in webkit [82749] by ap@apple.com
  • 4 edits in trunk/Source

Reviewed by Darin Adler.

REGRESSION: Assertion failure when executing a complex custom key binding
​https://bugs.webkit.org/show_bug.cgi?id=57681

Also completes the fix for
<rdar://problem/9063782> WebKit2: Text fields in Safari don't honor custom key bindings

  • UIProcess/API/mac/WKView.mm: (-[WKView hasMarkedText]): There is no need to execute saved commands when they can't possibly change the result.
5:09 PM Changeset in webkit [82748] by abarth@webkit.org
  • 38 edits
    1 add
    1 delete in trunk/Source/WebKit/chromium

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82738.
​http://trac.webkit.org/changeset/82738
​https://bugs.webkit.org/show_bug.cgi?id=57684

Broke storage/indexeddb/objectstore-autoincrement.html and
InjectIDBKey (Requested by abarth|gardening on #webkit).

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::create): (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::create): (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseCallbacksProxy.cpp: (WebCore::IDBDatabaseCallbacksProxy::create): (WebCore::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
  • src/IDBDatabaseCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStoreNames): (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::deleteObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
  • src/IDBDatabaseProxy.h: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::create): (WebCore::IDBIndexBackendProxy::IDBIndexBackendProxy):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.h: Removed.
  • src/IDBObjectStoreProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp. (WebCore::IDBObjectStoreProxy::create): (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::name): (WebCore::IDBObjectStoreProxy::keyPath): (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::clear): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::deleteIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h: Added.
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::create): (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebCore::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h: (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/IDBTransactionCallbacksProxy.cpp: (WebCore::IDBTransactionCallbacksProxy::create): (WebCore::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onError): (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: (WebCore::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
  • src/WebIDBKeyRange.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
4:59 PM Changeset in webkit [82747] by abarth@webkit.org
  • 9 edits
    9 deletes in trunk

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82712, r82729, and r82746.
​http://trac.webkit.org/changeset/82712
​http://trac.webkit.org/changeset/82729
​http://trac.webkit.org/changeset/82746
​https://bugs.webkit.org/show_bug.cgi?id=57682

fast/frames/frame-programmatic-noresize.html is failing on
Windows bots. Will look into this offline. (Requested by dydx
on #webkit).

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::noResize):
  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h:

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82712, r82729, and r82746.
​http://trac.webkit.org/changeset/82712
​http://trac.webkit.org/changeset/82729
​http://trac.webkit.org/changeset/82746
​https://bugs.webkit.org/show_bug.cgi?id=57682

fast/frames/frame-programmatic-noresize.html is failing on
Windows bots. Will look into this offline. (Requested by dydx
on #webkit).

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Removed.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Removed.
  • fast/frames/frame-programmatic-noresize-expected.txt: Removed.
  • fast/frames/frame-programmatic-noresize.html: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Removed.
  • fast/frames/resources/frame-programmatic-resize.js: Removed.
  • platform/chromium/test_expectations.txt:
4:40 PM Changeset in webkit [82746] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <​abarth@webkit.org>

Mark failing test as failing.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [82745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-01 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Build Webkit2 using "-2" option on Qt
​https://bugs.webkit.org/show_bug.cgi?id=55074

  • Scripts/build-webkit:
4:33 PM Changeset in webkit [82744] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling WebPageProxy::setMemoryCacheClientCallsEnabled with an invalid Web Process
​https://bugs.webkit.org/show_bug.cgi?id=57680
<rdar://problem/9202909>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Add an isValid check before sending

the message.

4:33 PM Changeset in webkit [82743] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-04-01 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r82708.
​http://trac.webkit.org/changeset/82708
​https://bugs.webkit.org/show_bug.cgi?id=53644

This tests fails consistently when run along with other tests

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/5408255-expected.checksum:
  • platform/gtk/editing/deleting/5408255-expected.png:
  • platform/gtk/editing/deleting/5408255-expected.txt:
4:19 PM Changeset in webkit [82742] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

4:19 PM Changeset in webkit [82741] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Chang.

Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
​https://bugs.webkit.org/show_bug.cgi?id=57656

We should initialize memory when constructing objects.

  • platform/text/StringWithDirection.h: (WebCore::StringWithDirection::StringWithDirection):
4:16 PM Changeset in webkit [82740] by mrowe@apple.com
  • 1 copy in tags/Safari-534.27

New tag.

4:12 PM Changeset in webkit [82739] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Update mac new-run-webkit-tests expectations with SLOW tests.

  • platform/mac/test_expectations.txt:
4:12 PM Changeset in webkit [82738] by jorlow@chromium.org
  • 38 edits
    3 moves
    1 add
    1 delete in trunk/Source/WebKit/chromium

2011-03-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Clean up IndexedDB WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=57507

Rename the backend proxy files that didn't have Backend in their name.
Everything in WebKit should be in the WebKit namespace.
Put everything behind the feature flag so we're consistient.
Put the feature flag #if above includes.

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebKit::IDBCallbacksProxy::create): (WebKit::IDBCallbacksProxy::IDBCallbacksProxy): (WebKit::IDBCallbacksProxy::onError): (WebKit::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: (WebKit::IDBCursorBackendProxy::create): (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::create): (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::name): (WebKit::IDBDatabaseBackendProxy::version): (WebKit::IDBDatabaseBackendProxy::objectStoreNames): (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit::IDBDatabaseBackendProxy::setVersion): (WebKit::IDBDatabaseBackendProxy::transaction): (WebKit::IDBDatabaseBackendProxy::close): (WebKit::IDBDatabaseBackendProxy::open):
  • src/IDBDatabaseCallbacksProxy.cpp: (WebKit::IDBDatabaseCallbacksProxy::create): (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
  • src/IDBDatabaseCallbacksProxy.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebKit::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebKit::IDBIndexBackendProxy::create): (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::create): (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::name): (WebKit::IDBObjectStoreBackendProxy::keyPath): (WebKit::IDBObjectStoreBackendProxy::indexNames): (WebKit::IDBObjectStoreBackendProxy::get): (WebKit::IDBObjectStoreBackendProxy::put): (WebKit::IDBObjectStoreBackendProxy::deleteFunction): (WebKit::IDBObjectStoreBackendProxy::clear): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): (WebKit::IDBObjectStoreBackendProxy::openCursor):
  • src/IDBObjectStoreBackendProxy.h: Added.
  • src/IDBObjectStoreProxy.h: Removed.
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::create): (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h: (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::create): (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onError): (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
  • src/WebIDBKeyRange.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
4:07 PM Changeset in webkit [82737] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-31 Jer Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Save as PDF in Safari provides Untitled as default file name
​https://bugs.webkit.org/show_bug.cgi?id=57529

Set the NSPrintOperation's jobTitle to the printing frame's title.

  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]):
4:05 PM Changeset in webkit [82736] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: remove spurious port version override in webkit.py
base.py provides a default implementation so this is just
breaking things.

​https://bugs.webkit.org/show_bug.cgi?id=57667

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4:02 PM Changeset in webkit [82735] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <​abarth@webkit.org>

Skip platform/mac/plugins/convert-point.html because it relies on code
that only exists in the test plugin for Apple's Mac port. We generally
ignore most of the tests in platform/mac, although we do run them to
detect crashes. In this case, however, the test does crash, but it
crashes in the test plug-in, which doesn't matter to us.

  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [82734] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

2011-04-01 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Roben.

Make view results on waterfall direct link to results.html
​https://bugs.webkit.org/show_bug.cgi?id=57671

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
  • Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
3:53 PM Changeset in webkit [82733] by jer.noble@apple.com
  • 13 edits in trunk/Source

2011-04-01 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Link from PDF opens in a new tab instead of in the same tab
​https://bugs.webkit.org/show_bug.cgi?id=57528

  • WebCore.exp.in: Export MouseEvent::create().

2011-04-01 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Link from PDF opens in a new tab instead of in the same tab
​https://bugs.webkit.org/show_bug.cgi?id=57528

Notify the WebProcess that a link has been clicked so that the normal policy
lookup can occur.

  • Shared/WebEvent.cpp: (WebKit::WebEvent::WebEvent): Initialize ivars in the default constructor.
  • Shared/WebEvent.h: Add WebEvent::NoType to Type enum.
  • Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent): Ditto.
  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView PDFViewWillClickOnLink:withURL:]): Handle the delegate

function and override the PDFView default behavior.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Handle the new WebEvent::NoType enum. (WebKit::WebPageProxy::linkClicked): Added. Send event through to WebPage.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::linkClicked): Added. Call loadFrameRequest().
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added LinkClicked.
3:50 PM Changeset in webkit [82732] by weinig@apple.com
  • 3 edits in trunk/Tools

Fix windows build.

  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:

(TestWebKitAPI::flushMessages):

3:39 PM Changeset in webkit [82731] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary static keyword.

Reviewed by Adam "Keyword Slasher" Roben.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::adoptWK):

3:35 PM Changeset in webkit [82730] by weinig@apple.com
  • 13 edits in trunk

2011-04-01 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add adoptWK to WKRetainPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=57670

  • UIProcess/API/cpp/WKRetainPtr.h: (WebKit::adoptWK): Add shared implementation of adoptWK. Previously both WebKitTestRunner and TestWebKitAPI had separate versions of it.

2011-04-01 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add adoptWK to WKRetainPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=57670

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: (TestWebKitAPI::createSessionStateContainingFormData):
  • WebKitTestRunner/StringFunctions.h: Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
3:29 PM Changeset in webkit [82729] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Test assigning false to noResize instead of undefined
​https://bugs.webkit.org/show_bug.cgi?id=57668

Apparently the V8 bindings have a bug when assigning undefined to a
boolean attribute. I've filed
​https://bugs.webkit.org/show_bug.cgi?id=57669 about that issue, which
I'll address in another patch (obviously with a test). In the
meantime, this patch changes this test to test "false" instead of
"undefined".

  • fast/frames/frame-programmatic-noresize-expected.txt:
  • fast/frames/frame-programmatic-noresize.html:
3:28 PM Changeset in webkit [82728] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-01 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Avoid decoding images twice in texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=51498

Make sure to redecode the image only if it's not opaque and texImage2D
wouldn't premultiply it anyway.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
3:19 PM Changeset in webkit [82727] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.

Reviewed by Adam Roben.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::shadowRoot):
Make judicious use of adoptWK().

3:12 PM Changeset in webkit [82726] by andersca@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Remove bogus ChangeLog entry.

3:11 PM Changeset in webkit [82725] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.

Reviewed by Timothy Hatcher.

  • Scripts/extract-localizable-strings:
3:02 PM Changeset in webkit [82724] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 82596
BUG=77690

2:55 PM Changeset in webkit [82723] by andersca@apple.com
  • 10 edits
    4 adds in trunk

2011-04-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
​https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Fix an unrelated bug found by the added test.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]): Make sure to always set destX and destY.

2011-04-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
​https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Add a missing break.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::convertPoint):

2011-04-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
​https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Add test.

  • platform/mac/plugins/convert-point-expected.txt: Added.
  • platform/mac/plugins/convert-point.html: Added.

2011-02-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
​https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2:42 PM Changeset in webkit [82722] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build fix.

Define DEBUG_ALL for WinCairo debug builds so that the correct
labeled DLLs ("*_debug.dll") are linked for testing runs.

  • win/tools/vsprops/debug_wincairo.vsprops:
2:36 PM Changeset in webkit [82721] by commit-queue@webkit.org
  • 7 edits in trunk

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

  • platform/gtk/Skipped: unskip test that accesses shadowRoot

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):
2:26 PM Changeset in webkit [82720] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit Mac build fix.

  • dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String to avoid ambiguity.
2:26 PM Changeset in webkit [82719] by weinig@apple.com
  • 10 edits in trunk

2011-04-01 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKitTestRunner needs layoutTestController.shadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=57661

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Implement layoutTestController.shadowRoot for WebKit2.

2011-04-01 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKitTestRunner needs layoutTestController.shadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=57661

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleGetRenderRect): (WKBundleNodeHandleGetElementBounds): (WKBundleNodeHandleCopyElementShadowRoot):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementShadowRoot):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Add accessor for the shadowRoot of an element in the bundle.
2:24 PM Changeset in webkit [82718] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some complexity from HandleHeap
​https://bugs.webkit.org/show_bug.cgi?id=57650


Eliminated pointer-tagging flags.


Tied being weak to having a finalizer (or at least a finalizer sentinel).

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Removed the special self-destroying flag. It was unused. If we bring it back, we'll probably use a shared autodeallocating finalizer instead.
  • collector/handles/HandleHeap.h: (JSC::HandleHeap::makeWeak): makeWeak and adding a finalizer are now a single, atomic operation -- this makes the relationship between finalizers and weak pointers clearer, and impossible to get wrong.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::handleHeap): No more flags.

(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak): Ditto above. We use a special sentienl
value in the finalizer slot to indicate that a handle is weak but doesn't
require an external function call for finalization.

2:11 PM Changeset in webkit [82717] by ap@apple.com
  • 23 edits
    1 add in trunk/Source

Reviewed by Darin Adler.

Make WebKit2 text input handling more like WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=57649

2:08 PM Changeset in webkit [82716] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82711.
​http://trac.webkit.org/changeset/82711
​https://bugs.webkit.org/show_bug.cgi?id=57657

Made every test crash on XP and Win7 (Requested by
abarth|gardening on #webkit).

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
1:59 PM Changeset in webkit [82715] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

2011-04-01 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=57651

No new tests. This patch does not affect outward behavior.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isAccelerated):
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::isAccelerated):
1:32 PM Changeset in webkit [82714] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm

Fix the Mac build on Lion.

1:31 PM Changeset in webkit [82713] by Darin Adler
  • 388 edits in trunk/LayoutTests

Removed some more executable bits from files that don't need them.
These often creep in when someone is working on Windows, which uses
executable bits differently from Unix systems.

  • editing/execCommand/align-in-span.html: Removed property svn:executable.
  • editing/selection/extend-byline-withfloat.html: Removed property svn:executable.
  • fast/canvas/webgl/data-view-test.html: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/zero-alpha.png: Removed property svn:executable.
  • fast/css/inline-element-line-break.html: Removed property svn:executable.
  • fast/css/pseudo-element-line-break.html: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-inline-script-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-onbeforeload-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-write-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed property svn:executable.
  • fast/events/before-unload-remove-and-add-subframe.html: Removed property svn:executable.
  • fast/events/change-frame-focus.html: Removed property svn:executable.
  • fast/files/resources/binary-file: Removed property svn:executable.
  • fast/frames/iframe-reparenting.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-frame1.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-frame2.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-iframe-content.html: Removed property svn:executable.
  • fast/harness/resources/cached-page-1.html: Removed property svn:executable.
  • fast/harness/resources/cached-page-2.html: Removed property svn:executable.
  • fast/harness/use-page-cache.html: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-fragment-expected.txt: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-fragment.html: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-pushstate-expected.txt: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-pushstate.html: Removed property svn:executable.
  • fast/images/resources/cmyk-jpeg.jpg: Removed property svn:executable.
  • fast/inline/inline-position-top-align.html: Removed property svn:executable.
  • fast/inline/resources/gradient.png: Removed property svn:executable.
  • fast/js/script-tests/toInt32UInt32.js: Removed property svn:executable.
  • fast/lists/resources/dump-list.js: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-alphabetic.html: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-numeric.html: Removed property svn:executable.
  • fast/parser/remove-misnested-iframe-in-beforeload-expected.txt: Removed property svn:executable.
  • fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt: Removed property svn:executable.
  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Removed property svn:executable.
  • fast/regex/script-tests/ecma-regex-examples.js: Removed property svn:executable.
  • fast/repaint/canvas-putImageData-expected.txt: Removed property svn:executable.
  • fast/repaint/canvas-putImageData.html: Removed property svn:executable.
  • http/tests/history/redirect-302.html: Removed property svn:executable.
  • http/tests/history/redirect-303.html: Removed property svn:executable.
  • http/tests/history/redirect-307.html: Removed property svn:executable.
  • http/tests/inspector/console-test.js: Removed property svn:executable.
  • http/tests/inspector/console-xhr-logging.html: Removed property svn:executable.
  • http/tests/inspector/elements-test.js: Removed property svn:executable.
  • http/tests/inspector/extensions-resources-redirect.html: Removed property svn:executable.
  • http/tests/inspector/extensions-resources-test.js: Removed property svn:executable.
  • http/tests/inspector/network-preflight-options.html: Removed property svn:executable.
  • http/tests/inspector/network/network-size-chunked.html: Removed property svn:executable.
  • http/tests/inspector/resource-parameters.html: Removed property svn:executable.
  • http/tests/inspector/resources-test.js: Removed property svn:executable.
  • http/tests/inspector/resources/iframe-from-different-domain-data.html: Removed property svn:executable.
  • http/tests/inspector/resources/resource-form-data-receiver-iframe.html: Removed property svn:executable.
  • http/tests/misc/async-and-defer-script-expected.txt: Removed property svn:executable.
  • http/tests/misc/script-async-expected.txt: Removed property svn:executable.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Removed property svn:executable.
  • http/tests/security/cross-origin-script-window-onerror.html: Removed property svn:executable.
  • http/tests/security/resources/cross-origin-script.txt: Removed property svn:executable.
  • inspector/audits/audits-test.js: Removed property svn:executable.
  • inspector/audits/resources/abe.png: Removed property svn:executable.
  • inspector/audits/resources/audits-script1.js: Removed property svn:executable.
  • inspector/audits/resources/audits-script2.js: Removed property svn:executable.
  • inspector/audits/resources/audits-style1.css: Removed property svn:executable.
  • inspector/console/console-assert.html: Removed property svn:executable.
  • inspector/console/console-dir.html: Removed property svn:executable.
  • inspector/console/console-dirxml.html: Removed property svn:executable.
  • inspector/console/console-format.html: Removed property svn:executable.
  • inspector/console/console-log-syntax-error.html: Removed property svn:executable.
  • inspector/console/console-nested-group.html: Removed property svn:executable.
  • inspector/console/console-substituted.html: Removed property svn:executable.
  • inspector/console/console-tests.html: Removed property svn:executable.
  • inspector/console/console-trace-in-eval.html: Removed property svn:executable.
  • inspector/console/console-trace.html: Removed property svn:executable.
  • inspector/console/console-uncaught-exception-in-eval.html: Removed property svn:executable.
  • inspector/console/console-uncaught-exception.html: Removed property svn:executable.
  • inspector/cookie-parser.html: Removed property svn:executable.
  • inspector/debugger/debugger-cyclic-ref.html: Removed property svn:executable.
  • inspector/debugger/debugger-expand-scope.html: Removed property svn:executable.
  • inspector/elements/elements-delete-inline-style-expected.txt: Removed property svn:executable.
  • inspector/elements/elements-delete-inline-style.html: Removed property svn:executable.
  • inspector/elements/elements-panel-search.html: Removed property svn:executable.
  • inspector/elements/elements-panel-structure.html: Removed property svn:executable.
  • inspector/evaluate-in-page.html: Removed property svn:executable.
  • inspector/extensions/extensions-audits-api.html: Removed property svn:executable.
  • inspector/extensions/extensions-audits.html: Removed property svn:executable.
  • inspector/extensions/extensions-eval.html: Removed property svn:executable.
  • inspector/extensions/extensions-events.html: Removed property svn:executable.
  • inspector/extensions/extensions-resources.html: Removed property svn:executable.
  • inspector/extensions/resources/abe.png: Removed property svn:executable.
  • inspector/extensions/resources/audits-style1.css: Removed property svn:executable.
  • inspector/styles/resources/styles-iframe-data.html: Removed property svn:executable.
  • inspector/styles/resources/styles-new-API-1.css: Removed property svn:executable.
  • inspector/styles/resources/styles-url-linkify-iframe.html: Removed property svn:executable.
  • inspector/styles/resources/styles-url-linkify.css: Removed property svn:executable.
  • inspector/styles/styles-disable-then-change-expected.txt: Removed property svn:executable.
  • inspector/styles/styles-disable-then-change.html: Removed property svn:executable.
  • inspector/styles/styles-iframe.html: Removed property svn:executable.
  • inspector/styles/styles-source-lines.html: Removed property svn:executable.
  • inspector/styles/styles-update-from-js-expected.txt: Removed property svn:executable.
  • inspector/styles/styles-update-from-js.html: Removed property svn:executable.
  • inspector/styles/styles-url-linkify.html: Removed property svn:executable.
  • inspector/utilities.html: Removed property svn:executable.
  • platform/chromium-linux/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Removed property svn:executable.
  • platform/chromium-linux/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-security-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-security-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Removed property svn:executable.
  • platform/chromium-win/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/block-no-inflow-children-expected.txt: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Removed property svn:executable.
  • platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/platform/qt/fast/events/event-sender-keydown-frame-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed property svn:executable.
  • platform/chromium/compositing/layout-width-change.html: Removed property svn:executable.
  • platform/chromium/html5lib/runner-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-eval-global-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Removed property svn:executable.
  • platform/chromium/test_expectations.txt: Removed property svn:executable.
  • platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/forms/text-style-color-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.txt: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.txt: Removed property svn:executable.
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.png: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.txt: Removed property svn:executable.
  • platform/win/accessibility/text-role-expected.txt: Removed property svn:executable.
  • platform/win/accessibility/text-role.html: Removed property svn:executable.
  • platform/win/fast/events/panScroll-nested-divs.html: Removed property svn:executable.
  • svg/custom/animate-use-crash.xhtml: Removed property svn:executable.
  • svg/filters/feColorMatrix-offset.svg: Removed property svn:executable.
  • transforms/2d/hindi-rotated.html: Removed property svn:executable.
1:07 PM Changeset in webkit [82712] by dbates@webkit.org
  • 8 edits
    9 adds in trunk

2011-04-01 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Frame's noResize attribute can not be set by JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=14845

Tests: fast/frames/frame-inherit-noresize-from-frameset.html

fast/frames/frame-programmatic-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html

Implements support to programmatically allow and disallow frame resizing.

Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
attribute.

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this code path isn't performance critical. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo(). (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::updateFromElement): Added.
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  • rendering/RenderFrameSet.h:

2011-04-01 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Frame's noResize attribute can not be set by JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=14845

Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.

Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
removing and adding the noresize attribute, respectively.

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <​https://bugs.webkit.org/show_bug.cgi?id=57604>.
  • fast/frames/frame-programmatic-noresize-expected.txt: Added.
  • fast/frames/frame-programmatic-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
  • fast/frames/resources/frame-programmatic-resize.js: Added. (setTestFrameById): (deltaWidth): (shouldAllowFrameResize): (shouldDisallowFrameResize): (shouldDisallowFrameResizeAfterProcessingFrame): (shouldAllowFrameResizeAfterProcessingFrame): (checkTestFrameWidthEquals): (resizeTestFrameBy): (log): (description):
1:00 PM Changeset in webkit [82711] by msaboff@apple.com
  • 7 edits in trunk/Source/WebCore

2011-04-01 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Cached Resource Overhead Space Usage and Accounting Inaccurate
​https://bugs.webkit.org/show_bug.cgi?id=57488

Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.

No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::hasCacheValidatorFields): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
12:59 PM Changeset in webkit [82710] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-01 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
​https://bugs.webkit.org/show_bug.cgi?id=57568

Update tests.

  • platform/mac-wk2/Skipped:

2011-04-01 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
​https://bugs.webkit.org/show_bug.cgi?id=57568

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetDatabaseQuota):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setDatabaseQuota):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

2011-04-01 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
​https://bugs.webkit.org/show_bug.cgi?id=57568

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setDatabaseQuota):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
12:57 PM Changeset in webkit [82709] by timothy@apple.com
  • 17 edits in trunk

Make momentum scroll event latching work in WebKit2 on Mac.

<rdar://problem/8751861>

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Remove _wkIsLatchingWheelEvent, add _wkGetNSEventMomentumPhase.
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Set m_useLatchedWheelEventNode based on the
event's momentumPhase.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent): Remove the setting of m_useLatchedWheelEventNode.
It is now done in EventHandler::handleWheelEvent.

  • platform/mac/WebCoreSystemInterface.h: Remove wkIsLatchingWheelEvent, add wkGetNSEventMomentumPhase.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/mac/WheelEventMac.mm:

(WebCore::momentumPhaseForEvent): Return a phase on older Mac system by using wkGetNSEventMomentumPhase.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.

Source/WebKit2:

  • Shared/mac/WebEventFactory.mm:

(WebKit::momentumPhaseForEvent): Return a phase on older Mac system by using WKGetNSEventMomentumPhase.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a: Updated to remove WKIsLatchingWheelEvent and add WKGetNSEventMomentumPhase.
  • libWebKitSystemInterfaceSnowLeopard.a: Ditto.
12:50 PM Changeset in webkit [82708] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-04-01 Martin Robinson <​mrobinson@igalia.com>

[GTK] editing/deleting/5408255.html results are incorrect
​https://bugs.webkit.org/show_bug.cgi?id=53644

Unskip this test and update the results, it appears to be passing now without any issue.

  • platform/gtk/Skipped: Unskip a test.
  • platform/gtk/editing/deleting/5408255-expected.checksum:
  • platform/gtk/editing/deleting/5408255-expected.png:
  • platform/gtk/editing/deleting/5408255-expected.txt:
12:50 PM Changeset in webkit [82707] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/696

Merge 82690
BUG=77940

12:36 PM Changeset in webkit [82706] by cevans@google.com
  • 5 edits in branches/chromium/696/Source/WebCore/platform/graphics/chromium

Merge 82624
BUG=76001

12:22 PM Changeset in webkit [82705] by dpranke@chromium.org
  • 18 edits in trunk/Tools

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

This patch completes the cleanup of
rebaseline-chromium-webkit-tests to work with all of the
variants of a platform (we can now rebaseline gpu- and non-gpu
files at the same time).

When the rebaselining is complete, any lines declared as
REBASELINE in the expectations file that matches a test that was
actually rebaselined will be deleted, even if only one of the
variants was actually rebaselined. This may cause odd problems,
but is better than where we're at today.

This change removes the -g flag and deprecates -w. The -g flag is gone
because GPU baselines are handled just like any other variant.
The -w flag is deprecated because this tool now only works
against the canaries, since that's the only place we have a full
set of bots. It will be trivial to change this to
build.webkit.org if we decide that's where we want them to be.

Also, this patch deletes a lot of cruft that is no longer needed
in the test_expectations code and the port-specific code.

​https://bugs.webkit.org/show_bug.cgi?id=55191

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
12:18 PM Changeset in webkit [82704] by dpranke@chromium.org
  • 8 edits in trunk/Tools

2011-04-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

rebaseline-chromium-webkit-tests does not work correctly with
version-specific baselines. This patch updates the tool to use
all of the version-specific bots on the canaries, and will now
attempt to rebaseline all of the versions by default, although
it will not update both GPU and CPU versions.

Also, it will no longer modify the test_expectations.txt file
*at all*. You will have to manually delete the REBASELINE lines
after running the tool and determining that it did what you
wanted it to do. This should be fixed in a separate bug - see
webkit bug #55191.

​https://bugs.webkit.org/show_bug.cgi?id=55608

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
12:08 PM Changeset in webkit [82703] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed WeakGCMap::deprecatedRemove because it was deprecated and unused
​https://bugs.webkit.org/show_bug.cgi?id=57648

  • runtime/WeakGCMap.h:
12:04 PM Changeset in webkit [82702] by steveblock@google.com
  • 5 edits
    1 copy
    1 move in trunk/Source/WebCore

2011-04-01 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaClass should be an interface and free of JNI types
​https://bugs.webkit.org/show_bug.cgi?id=57533

This patch fixes JavaClass for V8 only.

It factors out a JavaClass interface which does not use JNI types.
This will allow the Java bridge to be used with objects that
don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaClassJobject class which
implements the interface.

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/v8/JavaClassJobjectV8.cpp: (JavaClassJobject::JavaClassJobject): (JavaClassJobject::~JavaClassJobject): (JavaClassJobject::methodsNamed): (JavaClassJobject::fieldNamed):
  • bridge/jni/v8/JavaClassJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaClassV8.h.
  • bridge/jni/v8/JavaClassV8.h: (JSC::Bindings::JavaClass::~JavaClass):
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::getClass):
12:02 PM Changeset in webkit [82701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Jaehun Lim <​ljaehun.lim@samsung.com>

Unreviewed build fix.

Fix build break when font backend is Pango.
Pango is missed in changeset 80589.

​https://bugs.webkit.org/show_bug.cgi?id=57609

  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::setOrientation):
11:45 AM Changeset in webkit [82700] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <​abarth@webkit.org>

Update expected results to document more passes.

  • platform/chromium/test_expectations.txt:
11:38 AM Changeset in webkit [82699] by morrita@google.com
  • 6 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <​morrita@google.com>

Unreviewed expectations update which follows r82693.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
11:05 AM Changeset in webkit [82698] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82687.
​http://trac.webkit.org/changeset/82687
​https://bugs.webkit.org/show_bug.cgi?id=57643

This patch broke accessibility aria-treegrid test in Mac
(Requested by msanchez on #webkit).

  • accessibility/AccessibilityARIAGrid.cpp:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
10:49 AM Changeset in webkit [82697] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt: Removed property svn:executable.
  • http/tests/local/formdata/form-data-with-unknown-file-extension.html: Removed property svn:executable.
10:36 AM Changeset in webkit [82696] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Maintain the invariant that Lexer::m_current is set to -1 when at the end of the code buffer

Covered by existing tests.

Fixes <​http://webkit.org/b/56699>.

Reviewed by Oliver Hunt.

  • parser/Lexer.h:

(JSC::Lexer::setOffset): Copied code from Lexer::shift to update m_current, because
supposedly the idiom that function uses is fast.

10:35 AM Changeset in webkit [82695] by Adam Roben
  • 3 edits in trunk/Source/WebKit/win

Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received

This will ensure we don't try to process any window messages after the window has been
destroyed.

Covered by existing tests.

Fixes <​http://webkit.org/b/55054>.

Reviewed by Steve Falkenburg and John Sullivan.

  • WebView.cpp:

(WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
out the this pointer from the HWND.
(WebView::WebViewWndProc): Changed a runtime check into an assertion.

  • WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
10:33 AM Changeset in webkit [82694] by podivilov@chromium.org
  • 17 edits
    1 add in trunk/LayoutTests

2011-04-01 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium expectations for HTMLMeterElement tests updated in r82686.

  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
10:28 AM Changeset in webkit [82693] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <​morrita@google.com>

Unreviewed unskipping. This will make some tests fail on GTK port, whoese
results should be updated using layout-test-results.zip compiled by the buildbot.

  • platform/gtk/Skipped:
10:25 AM Changeset in webkit [82692] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

Assertion failure (type == event.type()) after a web process crash
​https://bugs.webkit.org/show_bug.cgi?id=56228
<rdar://problem/8806106>

This partially un-confuses the UI process about key processing state after a web process
crash. It may not be pefect yet - sending a KeyUp to a new process that never saw a KeyDown
seems weird.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processDidCrash):
10:15 AM Changeset in webkit [82691] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <​morrita@google.com>

Unreviewed expectation/skip update that follows r82686.

  • Updated expectataions for gtk port.
  • Skipped some win tests whose expectations are need to be updated but the result isn't available from build.webit.org.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/win/Skipped:
10:12 AM Changeset in webkit [82690] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Andreas Kling.

Whenever a relayout is trigger for SVGPath, make sure
to clear its previous marker layout info. This helps
to prevent removed markers from being used.
​https://bugs.webkit.org/show_bug.cgi?id=57492

Test: svg/dom/path-marker-removed-crash.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout):
  • rendering/svg/SVGMarkerLayoutInfo.cpp: (WebCore::SVGMarkerLayoutInfo::clear):
  • rendering/svg/SVGMarkerLayoutInfo.h:

2011-03-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Andreas Kling.

Tests that we do not crash when trying to paint a removed
svg marker element.
​https://bugs.webkit.org/show_bug.cgi?id=57492

  • svg/dom/path-marker-removed-crash-expected.txt: Added.
  • svg/dom/path-marker-removed-crash.svg: Added.
9:48 AM Changeset in webkit [82689] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-01 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=55750
SVG <image> referenced by <use> is displayed incorrectly

Reintroduce old behaviour for valid base URI, for invalid
keep using document base URI.
Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.

Test: svg/custom/image-base-uri.svg

  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
9:37 AM Changeset in webkit [82688] by tony@chromium.org
  • 4 edits in trunk/Tools

2011-03-31 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] update the rebaseline tool to know about pngs with checksums
​https://bugs.webkit.org/show_bug.cgi?id=57481

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
9:15 AM Changeset in webkit [82687] by mario@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

ARIA Grid tables should return GridRole in roleValue() method
​https://bugs.webkit.org/show_bug.cgi?id=57614

This change does not need any test since it doesn't change anything
from the point of view of the consumers (Assistive Technoglogies).
It's just an internal change to simplify identifying HTML and ARIA
tables by calling to the AccessibilityObject::roleValue method.

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole): Removed unneeded comment.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to NSAccessibilityTableRole, to keep the same behaviour.
8:59 AM Changeset in webkit [82686] by morrita@google.com
  • 33 edits in trunk

2011-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
​https://bugs.webkit.org/show_bug.cgi?id=56001

  • Simpflied some test cases which had vertical indicators.
  • Updated expectations due to shadow structure change
  • Skipped tetsts which need expectations update.
  • fast/dom/HTMLMeterElement/meter-element.html:
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
​https://bugs.webkit.org/show_bug.cgi?id=56001

  • Removed code which deals with the direction and left the horizontal path.
  • Removed "horizontal" from related names which is now redundant.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsMeter):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::supportsMeter):
  • rendering/style/RenderStyleConstants.h:
8:26 AM Changeset in webkit [82685] by podivilov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-03-23 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix reveal line in formatted script.
​https://bugs.webkit.org/show_bug.cgi?id=56941

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.canShowAnchorLocation): (WebInspector.NetworkPanel.prototype.showAnchorLocation):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.canShowAnchorLocation): (WebInspector.Panel.prototype.showAnchorLocation):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowAnchorLocation): (WebInspector.ResourcesPanel.prototype.showAnchorLocation): (WebInspector.ResourcesPanel.prototype.showResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.canShowAnchorLocation): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._showSourceLine):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._createTextViewer):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._showAnchorLocation):
8:22 AM Changeset in webkit [82684] by Adam Roben
  • 2 edits
    1 move in trunk/LayoutTests

Disable inspector/debugger/debug-inlined-scripts.html

It is flaky. The flakiness is tracked by <​http://webkit.org/b/56584>.

  • inspector/debugger/debug-inlined-scripts.html-disabled: Renamed from LayoutTests/inspector/debugger/debug-inlined-scripts.html.
  • platform/mac-wk2/Skipped: Removed the now-disabled test.
8:19 AM Changeset in webkit [82683] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-01 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make editScriptSource a Script's method.
​https://bugs.webkit.org/show_bug.cgi?id=57615

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
8:17 AM Changeset in webkit [82682] by Adam Roben
  • 3 edits in trunk/Tools

Retrieve revision numbers from the build's got_revision property in Leaks Viewer

Previously, we were getting the revision of the first revision that triggered a build.
Choosing the last revision would have been more accurate. But got_revision is what is used
everywhere else on build.webkit.org, and should work even when there were no changes that
triggered a build (e.g., if someone clicked the Force Build button).

Fixes <​http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
recent builds list

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
property, rather than out of the first (i.e., earliest) change in the sourceStamp object.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:

(Array.prototype.first): Added this helper function to return the first element in an array
that matches the given predicate, or null if no such element exists.

8:13 AM Changeset in webkit [82681] by Adam Roben
  • 3 edits in trunk/Tools

Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs

Fixes <​http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
URL on its own line.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
progression, and added a new test that uses a short bug URL while I was at it.

7:10 AM Changeset in webkit [82680] by pfeldman@chromium.org
  • 4 edits in trunk

2011-04-01 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: event should have "data" attribute, not "body"
​https://bugs.webkit.org/show_bug.cgi?id=57628

  • inspector/protocol/console-agent-expected.txt:

2011-04-01 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: event should have "data" attribute, not "body"
​https://bugs.webkit.org/show_bug.cgi?id=57628

  • inspector/CodeGeneratorInspector.pm:
7:10 AM Changeset in webkit [82679] by Adam Roben
  • 3 edits in trunk/Tools

Mark .vcproj/.vsprops/.sln files as being Windows-only

Fixes <​http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
directories as Windows-only.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShoulBuildTest): Added test cases for the above.

6:58 AM Changeset in webkit [82678] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-01 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
​https://bugs.webkit.org/show_bug.cgi?id=57610

  • inspector/debugger/xhr-breakpoints-expected.txt:
  • inspector/debugger/xhr-breakpoints.html:

2011-04-01 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
​https://bugs.webkit.org/show_bug.cgi?id=57610

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
6:44 AM Changeset in webkit [82677] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Cairo build fix

  • WebProcess/WebPage/LayerTreeHost.cpp: Only pull in the LayerTreeHostCA derived classes for

PLATFORM(CA) ports.

6:38 AM Changeset in webkit [82676] by carol.szabo@nokia.com
  • 5 edits
    1 add in trunk/Source/WebKit/qt

2011-04-01 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Benjamin Poulain.

Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.

Tiled painting still causes synchronous layout when
accelerated compositing and texture mapper are enabled
​https://bugs.webkit.org/show_bug.cgi?id=56929

  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderRelativeCoords): (QWebFramePrivate::renderFrameWidgets):
  • Api/qwebframe_p.h:
6:26 AM Changeset in webkit [82675] by Adam Roben
  • 9 edits
    2 copies in trunk/Source/WebKit2

Split LayerTreeHostCA into a base class and derived Mac and Win classes

This will make it easier to customize the Mac and Windows implementations without adding too
many #ifdefs.

Fixes <​http://webkit.org/b/57606> Windows and Mac should use separate LayerTreeHost classes

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Added LayerTreeHostCAMac.h.
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create): Create a LayerTreeHostCAMac on Mac, and LayerTreeHostCAWin
on Windows.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some code from here...
(WebKit::LayerTreeHostCA::initialize): ...to here. This function will be called after the
constructor returns, and thus can safely call functions that are pure virtual in this class
and its base class. We now pass our LayerTreeContext to platformInitialize so that our
derived classes can initialize it.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Removed Mac-specific code.

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush):
Removed platform* calls. Derived classes can just override these functions to do what they
need.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed Mac-specific pieces. Made some functions

virtual so that derived classes can override them.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Added.
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::create): Create and initialize a host.
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Simple constructor.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac): Moved code here from LayerTreeHostCA
destructor.
(WebKit::LayerTreeHostCAMac::platformInitialize): Removed direct uses of LayerTreeHostCA
data members.

(WebKit::LayerTreeHostCAMac::invalidate):
(WebKit::LayerTreeHostCAMac::sizeDidChange):
(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):
Renamed from platform*. Now call up to the base class.

(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Updated type.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::create): Create and initialize a host.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::~LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::platformInitialize):
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush):
Stubbed out.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added.
  • win/WebKit2.vcproj: Added LayerTreeHostCAWin.h
  • win/WebKit2Apple.vsprops: Added WebProcess/WebPage/ca/win to the include path.
6:14 AM Changeset in webkit [82674] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
​https://bugs.webkit.org/show_bug.cgi?id=40522

Drive-by: fix inc/dec for numbers like ".5"

Test: inspector/styles/up-down-numerics-and-colors.html

WebCore:

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.createKeyEvent): Added arguments for key modifiers.
  • inspector/styles/up-down-numerics-and-colors-expected.txt: Added.
  • inspector/styles/up-down-numerics-and-colors.html: Added.
5:32 AM Changeset in webkit [82673] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-01 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] DragClientQt.h has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40425

  • WebCoreSupport/DragClientQt.h:
5:22 AM Changeset in webkit [82672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-04-01 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Synchronization between WebCore's ContextMenuItem.h and ewk_contextmenu.h
​https://bugs.webkit.org/show_bug.cgi?id=57000

  • ewk/ewk_contextmenu.h:
4:12 AM Changeset in webkit [82671] by commit-queue@webkit.org
  • 4 edits
    1 add
    1 delete in trunk/Tools

2011-04-01 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Build MiniBrowser for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=56319

Have MiniBrowser reference it's own copy of useragentlist.txt instead
of copying QtTestBrowser's.
Remove Tools/MiniBrowser/DerivedSources.pro
This reduces complexity in the Tools scripts due to Symbian limitations.

  • DerivedSources.pro:
  • MiniBrowser/DerivedSources.pro: Removed.
  • MiniBrowser/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowser.pro:
  • Scripts/webkitdirs.pm:
3:51 AM Changeset in webkit [82670] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove dead code from Script.js.
​https://bugs.webkit.org/show_bug.cgi?id=57454

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource):
3:45 AM Changeset in webkit [82669] by podivilov@chromium.org
  • 5 edits
    2 deletes in trunk

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82667.
​http://trac.webkit.org/changeset/82667
​https://bugs.webkit.org/show_bug.cgi?id=57612

Breaks Leopard layout tests (Requested by podivilov on
#webkit).

  • inspector/debugger/script-formatter-expected.txt: Removed.
  • inspector/debugger/script-formatter.html: Removed.
  • platform/chromium/test_expectations.txt:

2011-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82667.
​http://trac.webkit.org/changeset/82667
​https://bugs.webkit.org/show_bug.cgi?id=57612

Breaks Leopard layout tests (Requested by podivilov on
#webkit).

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
3:26 AM Changeset in webkit [82668] by podivilov@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unused SourceFrameContent class.
​https://bugs.webkit.org/show_bug.cgi?id=57453

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ResourceView.js: (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer):
  • inspector/front-end/SourceFrameContent.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:17 AM Changeset in webkit [82667] by podivilov@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2:53 AM Changeset in webkit [82666] by podivilov@chromium.org
  • 4 edits
    1 add in trunk/Source

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
​https://bugs.webkit.org/show_bug.cgi?id=57446

  • inspector/front-end/ScriptFormatterWorker.js:

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
​https://bugs.webkit.org/show_bug.cgi?id=57446

  • WebKit.gyp:
  • scripts/inline_js_imports.py: Added.
2:32 AM Changeset in webkit [82665] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow file access from inspector page so inspector can use workers.
​https://bugs.webkit.org/show_bug.cgi?id=57339

  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
1:59 AM Changeset in webkit [82664] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes on attempt to log object with broken .toString
​https://bugs.webkit.org/show_bug.cgi?id=57557

  • inspector/console/console-log-toString-object-expected.txt: Added.
  • inspector/console/console-log-toString-object.html: Added.

2011-03-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes on attempt to log object with broken .toString
​https://bugs.webkit.org/show_bug.cgi?id=57557

If ScriptValue.toString causes a JavaScript exception, the exception is cleared
before returning from the toString method.

Test: inspector/console/console-log-toString-object.html

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::toString):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::toString):
1:56 AM Changeset in webkit [82663] by caseq@chromium.org
  • 9 edits in trunk

2011-03-31 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
​https://bugs.webkit.org/show_bug.cgi?id=57466

  • removed documentWide parameter to querySelector[All]() (user document node id instead)
  • factor out document request logic within DOMAgent into separate method
  • add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
  • use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
  • minor style fixes in Inspector.json
  • more error logging
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable): (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable): (WebInspector.DOMAgent.prototype.cancelSearch): (WebInspector.DOMAgent.prototype.querySelector): (WebInspector.DOMAgent.prototype.querySelectorAll):

2011-03-31 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
​https://bugs.webkit.org/show_bug.cgi?id=57466

  • inspector/elements/dom-agent-query-selector.html: removed documentWide parameter to querySelectorAll
12:55 AM Changeset in webkit [82662] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Kent Tamura <​tkent@chromium.org>

Apply sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:

Mar 31, 2011:

10:46 PM Changeset in webkit [82661] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Add two more preloader tests to the WebKit2 Skipped list.

  • platform/mac-wk2/Skipped:
10:12 PM Changeset in webkit [82660] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build fix after r82632.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::visibilityDidChange):

9:30 PM Changeset in webkit [82659] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Rebaseline my own test on Linux! The great JavaScript MIME type war
claims another victim.

  • platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt: Added.
8:45 PM Changeset in webkit [82658] by abarth@webkit.org
  • 1 edit
    2 copies
    2 moves in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Gentilcore.

fast/preloader/scan-body-from-head.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=57594

This test was flaky because the script and the import load would race.
By breaking down this test into two pieces, we can still see that the
parse-blocking loads happen before the non-blocking load (the img) but
we don't suffer flakiness.

  • fast/preloader/scan-body-from-head-expected.txt: Removed.
  • fast/preloader/scan-body-from-head-import-expected.txt: Added.
  • fast/preloader/scan-body-from-head-import.html: Added.
  • fast/preloader/scan-body-from-head-script-expected.txt: Added.
  • fast/preloader/scan-body-from-head-script.html: Added.
  • fast/preloader/scan-body-from-head.html-disabled: Removed.
7:52 PM Changeset in webkit [82657] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82652.
​http://trac.webkit.org/changeset/82652
​https://bugs.webkit.org/show_bug.cgi?id=57603

Test still fails (Requested by abarth|gardener on #webkit).

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82652.
​http://trac.webkit.org/changeset/82652
​https://bugs.webkit.org/show_bug.cgi?id=57603

Test still fails (Requested by abarth|gardener on #webkit).

  • plugins/windowless_plugin_paint_test-expected.txt: Removed.
  • plugins/windowless_plugin_paint_test.html: Removed.
7:32 PM Changeset in webkit [82656] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-31 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

REGRESSION (r64712): Safari removes the first blank line in a textarea
​https://bugs.webkit.org/show_bug.cgi?id=56434

  • fast/forms/textarea-newline-expected.txt: Added.
  • fast/forms/textarea-newline.html: Added to check the only first blank line in a textarea is correctly removed.

2011-03-31 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

REGRESSION (r64712): Safari removes the first blank line in a textarea
​https://bugs.webkit.org/show_bug.cgi?id=56434

Test: fast/forms/textarea-newline.html

A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
And devalutValue() removal is not needed anymore.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setDefaultValue): Remove an extra linefeed insertion at the beginning. (WebCore::HTMLTextAreaElement::defaultValue): Remove linefeed removal check in default value creation function.
7:07 PM Changeset in webkit [82655] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Not reviewed.

Skipping

fast/preloader/document-write.html
fast/preloader/document-write-2.html

due to Javascript MIME type mismatch.

  • platform/mac-leopard/Skipped:
6:39 PM Changeset in webkit [82654] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Remove refcounting of CSSStyleApplyProperty singleton
​https://bugs.webkit.org/show_bug.cgi?id=57592

No new tests required as no functionality changes.

  • css/CSSStyleApplyProperty.h:
6:31 PM Changeset in webkit [82653] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Attempt to fix the chromium-mac-leopard baselines for these tests. For
some reason, the automatic tools were unable to fix these, so I created
them manually.

  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/list-marker-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/list-marker-expected.png:
6:14 PM Changeset in webkit [82652] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-31 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

  • plugins/windowless_plugin_paint_test-expected.txt: Added.
  • plugins/windowless_plugin_paint_test.html: Added.

2011-03-31 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

Test: plugins/windowless_plugin_paint_test.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):
6:05 PM Changeset in webkit [82651] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Add SharedMemory::adopt, which can take ownership of an existing file mapping object

Fixes <​http://webkit.org/b/57599> Need a way to wrap an existing file mapping object in a
SharedMemory

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h: Added adopt.
  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::create): Moved code to adopt the HANDLE from here...
(WebKit::SharedMemory::adopt): ...to here.

6:05 PM Changeset in webkit [82650] by Adam Roben
  • 6 edits
    1 copy in trunk/Source/WebCore

Add a new AbstractCACFLayerTreeHost base class

This class exposes the interface that LayerChangesFlusher and PlatformCALayer rely on.
CACFLayerTreeHost now derives from AbstractCACFLayerTreeHost. In the future, WebKit2's
LayerTreeHostCA will also derive from it (on Windows).

This should cause no change in behavior.

Fixes <​http://webkit.org/b/57598> Coupling between CACFLayerTreeHost and other CACF-related
code is too high

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Added AbstractCACFLayerTreeHost, and let VS reorder files.
  • platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Added.
  • platform/graphics/ca/win/CACFLayerTreeHost.h: Changed to derive from

AbstractCACFLayerTreeHost, and annotated the overrides of its functions.
AbstractCACFLayerTreeHost also allows us to get rid of the friend relationship with
PlatformCALayer.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookFired):

  • platform/graphics/ca/win/LayerChangesFlusher.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(layerTreeHostForLayer):
(PlatformCALayer::rootLayer):
(PlatformCALayer::setNeedsCommit):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
Changed to use AbstractCACFLayerTreeHost instead of using CACFLayerTreeHost directly.

6:01 PM Changeset in webkit [82649] by commit-queue@webkit.org
  • 13 edits in trunk

2011-03-31 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.clearAllDatabases
​https://bugs.webkit.org/show_bug.cgi?id=42540

Remove passed tests.

  • platform/mac-wk2/Skipped:

2011-03-31 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.clearAllDatabases
​https://bugs.webkit.org/show_bug.cgi?id=42540

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleClearAllDatabases):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::clearAllDatabases):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

2011-03-31 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.clearAllDatabases
​https://bugs.webkit.org/show_bug.cgi?id=42540

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::clearAllDatabases):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
5:50 PM Changeset in webkit [82648] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Note another flaky test.

  • platform/chromium/test_expectations.txt:
5:32 PM Changeset in webkit [82647] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/696

Merge 82595
BUG=77917

5:12 PM Changeset in webkit [82646] by aestes@apple.com
  • 4 edits
    2 adds in trunk

2011-03-31 Andy Estes <​aestes@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Java applet fails to load when <object> has a classid attribute.
​https://bugs.webkit.org/show_bug.cgi?id=52703


Java applets embedded with the object element sometimes use classid to
specify their main resource. When this is done, the classid is prefixed
with "java:". Treat these as supported classids in WebKit.

Test: java/embedding-java-with-object.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): If the MIME type is a Java Applet type and the classid starts with "java:", the classid should be considered valid.

2011-03-31 Andy Estes <​aestes@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Java applet fails to load when <object> has a classid attribute
​https://bugs.webkit.org/show_bug.cgi?id=52703

Test various ways that a Java applet can be embedded using the object element.

  • java/embedding-java-with-object-expected.txt: Added.
  • java/embedding-java-with-object.html: Added.
  • platform/mac-wk2/Skipped: WK2 doesn't implement layoutTestController.overridePreference.
5:04 PM Changeset in webkit [82645] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Fix name of test.

  • platform/chromium/test_expectations.txt:
4:58 PM Changeset in webkit [82644] by abarth@webkit.org
  • 13 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Update chromium-win expectations for these baseline changes from
Mr. Hyatt.

  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
4:51 PM Changeset in webkit [82643] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/696

Merge 82503
BUG=77765

4:50 PM Changeset in webkit [82642] by abarth@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Disable this test because it's very flaky on all platforms. See
​https://bugs.webkit.org/show_bug.cgi?id=57594 for making the test
non-flaky.

  • fast/preloader/scan-body-from-head.html: Removed.
  • fast/preloader/scan-body-from-head.html-disabled: Copied from LayoutTests/fast/preloader/scan-body-from-head.html.
4:43 PM Changeset in webkit [82641] by scherkus@chromium.org
  • 7 edits in trunk

2011-03-31 Victoria Kirst <​vrk@google.com>

Reviewed by Eric Carlson.

[chromium] Implement preload=none, setPreload hooks to media player
​https://bugs.webkit.org/show_bug.cgi?id=56983

This patch implements preload=none in Chromium. It also replaces
the now-deprecated setAutobuffer method with setPreload.

  • public/WebMediaPlayer.h: (WebKit::WebMediaPlayer::setPreload):
  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::preload): (WebKit::WebMediaPlayerClientImpl::load): (WebKit::WebMediaPlayerClientImpl::loadInternal): (WebKit::WebMediaPlayerClientImpl::prepareToPlay): (WebKit::WebMediaPlayerClientImpl::setPreload): (WebKit::WebMediaPlayerClientImpl::startDelayedLoad): (WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
  • src/WebMediaPlayerClientImpl.h:

2011-03-31 Victoria Kirst <​vrk@google.com>

Reviewed by Eric Carlson.

[chromium] Implement preload=none, setPreload hooks to media player
​https://bugs.webkit.org/show_bug.cgi?id=56983

Reenabling video-preload.html layout test for chromium.

  • platform/chromium/test_expectations.txt:
4:42 PM Changeset in webkit [82640] by bfulgham@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

Reviewed Adam Roben.

[WinCairo] Implement Missing drawWindowsBitmap method.
​https://bugs.webkit.org/show_bug.cgi?id=57409

  • WebCore.vcproj/WebCore.vcproj: Add new DIBPixelData files.
  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::WindowsBitmap::buffer):
(WebCore::GraphicsContext::WindowsBitmap::bufferLength):
(WebCore::GraphicsContext::WindowsBitmap::size):
(WebCore::GraphicsContext::WindowsBitmap::bytesPerRow):
(WebCore::GraphicsContext::WindowsBitmap::bitsPerPixel):
(WebCore::GraphicsContext::WindowsBitmap::windowsDIB):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::CGContextWithHDC):
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.

  • platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::drawBitmapToContext): New common drawing implementation.
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.
(WebCore::GraphicsContext::drawWindowsBitmap):

  • platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): Modified
to use new DIBPixelData data type.

  • platform/graphics/win/DIBPixelData.cpp: Added.

(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::initialize):

  • platform/graphics/win/DIBPixelData.h: Added.

(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::buffer):
(WebCore::DIBPixelData::bufferLength):
(WebCore::DIBPixelData::size):
(WebCore::DIBPixelData::bytesPerRow):
(WebCore::DIBPixelData::bitsPerPixel):

4:36 PM Changeset in webkit [82639] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 82529
BUG=77703

4:36 PM Changeset in webkit [82638] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Add setSerializeHTTPLoads supressions.

  • platform/chromium/test_expectations.txt:
4:32 PM Changeset in webkit [82637] by Antti Koivisto
  • 9 edits in trunk/LayoutTests

Not reviewed.

  • Skip on platforms that don't have setSerializeHTTPLoads, make it a requirement.
  • Update results after typo fix.
  • fast/preloader/document-write-2-expected.txt:
  • fast/preloader/document-write-2.html:
  • fast/preloader/document-write-expected.txt:
  • fast/preloader/document-write.html:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:29 PM Changeset in webkit [82636] by inferno@chromium.org
  • 6 edits
    1 delete in trunk

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81849.
​http://trac.webkit.org/changeset/81849
​https://bugs.webkit.org/show_bug.cgi?id=57588

CSS Parsing broke with -webkit-calc and introduced crashes
(Requested by inferno-sec on #webkit).

  • css/CSSGrammar.y:
  • css/CSSParserValues.cpp:
  • css/CSSParserValues.h:
  • css/tokenizer.flex:

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81849.
​http://trac.webkit.org/changeset/81849
​https://bugs.webkit.org/show_bug.cgi?id=57588

CSS Parsing broke with -webkit-calc and introduced crashes
(Requested by inferno-sec on #webkit).

  • css3/calc/calc-errors-expected.txt: Removed.
  • css3/calc/calc-errors.html: Removed.
  • css3/calc/minmax-errors-expected.txt: Removed.
  • css3/calc/minmax-errors.html: Removed.
  • css3/calc/simple-calcs-expected.txt: Removed.
  • css3/calc/simple-calcs.html: Removed.
  • css3/calc/simple-minmax-expected.txt: Removed.
  • css3/calc/simple-minmax.html: Removed.
4:26 PM Changeset in webkit [82635] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 82421
BUG=77669

4:21 PM Changeset in webkit [82634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Add some more media related things to the sandbox profile.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb:
4:15 PM Changeset in webkit [82633] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Don't ref CACFLayerTreeHosts when telling them to flush layer changes

LayerChangesFlusher was reffing CACFLayerTreeHosts before calling out to them. This would
have protected us if calling out to one CACFLayerTreeHost could cause a different
CACFLayerTreeHost to be destroyed. But that isn't possible; each CACFLayerTreeHost is
associated with its own page, and flushing layer changes doesn't touch any other page. So it
isn't possible for a CACFLayerTreeHost to be deleted while another one is flushing layer
changes.

One benefit of this change is that it will make it easier to make LayerChangesFlusher
interact with a forthcoming abstract base class, rather than with CACFLayerTreeHost itself.

This should cause no change in behavior.

Fixes <​http://webkit.org/b/57590> LayerChangesFlusher unnecessarily refs CACFLayerTreeHost
before calling out to it

Reviewed by Darin Adler.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::hookFired): Just store bare pointers to the
CACFLayerTreeHosts.

4:05 PM Changeset in webkit [82632] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Tabbed pages redraw unnecessarily when activated
​https://bugs.webkit.org/show_bug.cgi?id=57589
<rdar://problem/9218258>

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::visibilityDidChange): If we become visible and have no backing store, make sure to call backingStoreStateDidChange so that the next time we're asked to paint we'll wait for something to paint.

(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Remove now redundant call to backingStoreStateDidChange.

3:50 PM Changeset in webkit [82631] by Antti Koivisto
  • 6 edits
    5 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57574
Preload scanner fails to pick up resources from document.write() output

Reviewed by Oliver Hunt.

Source/WebCore:

  • Scan script inserted source using a separate preload scanner.
  • Make the main preload scanner correctly process the remaining source if script execution blocked the parser.

Tests: fast/preloader/document-write-2.html

fast/preloader/document-write.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):

  • html/parser/HTMLDocumentParser.h:

(WebCore::HTMLDocumentParser::hasPreloadScanner):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::execute):

  • html/parser/HTMLScriptRunnerHost.h:

LayoutTests:

  • fast/preloader/document-write-2-expected.txt: Added.
  • fast/preloader/document-write-2.html: Added.
  • fast/preloader/document-write-expected.txt: Added.
  • fast/preloader/document-write.html: Added.
  • fast/preloader/resources/document-write-plaintext.js: Added.
3:43 PM Changeset in webkit [82630] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Tony Gentilcore <​tonyg@chromium.org>

Build fix: Add missing include
​https://bugs.webkit.org/show_bug.cgi?id=57587

  • loader/cache/CachedResourceLoader.cpp:
3:19 PM Changeset in webkit [82629] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-31 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
​https://bugs.webkit.org/show_bug.cgi?id=42692

Unskip passed tests.

  • platform/mac-wk2/Skipped:

2011-03-31 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
​https://bugs.webkit.org/show_bug.cgi?id=42692

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3:14 PM Changeset in webkit [82628] by tonyg@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-31 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Antti Koivisto.

PreloadScanner doesn&apos;t find image while executing script in head
​https://bugs.webkit.org/show_bug.cgi?id=45072

  • fast/loader/willSendRequest-null-for-preload.html: Need to call setWilSendRequestReturnsNull() prior to invoking the preload scanner while blocked on empty-script.js.
  • fast/preloader/scan-body-from-head-expected.txt: Added.
  • fast/preloader/scan-body-from-head.html: Added. Notice that in the loaded resource output, the script and style are requested before the image even though the image is first in the DOM. This means it was queued up to wait for renderering rather than loaded immediately.

2011-03-31 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Antti Koivisto.

PreloadScanner doesn&apos;t find image while executing script in head
​https://bugs.webkit.org/show_bug.cgi?id=45072

Previously, while parsing the head, no resources in the body would be
preloaded. After this patch, we will preload scripts and styles in the
body, although we continue to hold off on all images until the page is
first rendered.

To evaluate this change, I've recorded a sampling of 45 of alexa's top
sites and replayed them under simulated bandwidth conditions, loading
each 5-15 times until stddev is small enough.

Time to the load event improved at the overall average by 3%.
Most sites are unchanged, but sites with certain blocking patterns had
big wins -- ebay 19% (331ms), microsoft 15% (226ms), conduit 15% (277ms)
nytimes 7% (182ms).

Time to DOM content loaded event improved by 6% with some even bigger
individual wins.

First paint time held steady.

Note that I originally wanted to allow preloading of images while in the
head, but that regressed first paint time (even though it was better for
overall load time).

Test: fast/preloader/scan-body-from-head.html

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::preload):
3:12 PM Changeset in webkit [82627] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82616.
​http://trac.webkit.org/changeset/82616
​https://bugs.webkit.org/show_bug.cgi?id=57585

New test does not pass on Gtk, chromium-mac, chromium-linux
and possibly elsewhere (Requested by abarth|gardener on
#webkit).

  • plugins/windowless_plugin_paint_test-expected.txt: Removed.
  • plugins/windowless_plugin_paint_test.html: Removed.

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82616.
​http://trac.webkit.org/changeset/82616
​https://bugs.webkit.org/show_bug.cgi?id=57585

New test does not pass on Gtk, chromium-mac, chromium-linux
and possibly elsewhere (Requested by abarth|gardener on
#webkit).

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):
3:10 PM Changeset in webkit [82626] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations when playing back HTML5 video on YouTube
<rdar://problem/8950692>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
3:09 PM Changeset in webkit [82625] by Darin Adler
  • 11 edits in trunk

2011-03-31 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57573

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSimulateMouseDown): Added. (WKBundlePageSimulateMouseUp): Added. (WKBundlePageSimulateMouseMotion): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added above functions.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::simulateMouseDown): Added. (WebKit::WebPage::simulateMouseUp): Added. (WebKit::WebPage::simulateMouseMotion): Added.
  • WebProcess/WebPage/WebPage.h: Added above functions.

2011-03-31 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57573

  • platform/mac-wk2/Skipped: Removed now-passing tests. Resorted the section under eventSender, and expanded directories to list the individual tests in that section.

2011-03-31 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57573

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward. Removed fake definitions of keyDown and contextClick.
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::operator==): Added. So we can compare two WKPoint structs. (WTR::parseModifier): Added. (WTR::parseModifierArray): Added. (WTR::EventSendingController::EventSendingController): Initialize the new data members. (WTR::EventSendingController::mouseDown): Added. Calls WKBundlePageSimulateMouseDown. (WTR::EventSendingController::mouseUp): Added. Calls WKBundlePageSimulateMouseUp. (WTR::EventSendingController::mouseMoveTo): Added. Calls WKBundlePageSimulateMouseMotion. (WTR::EventSendingController::leapForward): Added. (WTR::EventSendingController::updateClickCount): Added. Used by the mouseDown/Up functions to create a click count.
  • WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated for the changes above.
3:07 PM Changeset in webkit [82624] by enne@google.com
  • 6 edits in trunk/Source/WebCore

2011-03-31 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=57577

LayerRendererChromium now uses a RefPtr to preserve ownership of all
of the CCLayerImpl layers that it is using during the update/draw
pass. Addtionally, when a LayerChromium is destroyed, the weak
owner pointer from its CCLayerImpl is correctly unset.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::cleanupResources):
3:01 PM Changeset in webkit [82623] by abarth@webkit.org
  • 11 edits
    15 adds in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Update Chromium expected results for Hyatt's change. I haven't
verified these with Hyatt, but they seem reasonable.

  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png: Added.
2:58 PM Changeset in webkit [82622] by weinig@apple.com
  • 8 edits in trunk/Source

2011-03-31 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=57582

  • platform/DefaultLocalizationStrategy.cpp:
  • platform/LocalizedStrings.h:

2011-03-31 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=57582

  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitialize):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformInspectedURLChanged):
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
2:47 PM Changeset in webkit [82621] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

One more results update. This change is just 1px off from the result
Hyatt landed.

  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
2:40 PM Changeset in webkit [82620] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Hyatt says these are also progressions.

  • platform/gtk/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
2:35 PM Changeset in webkit [82619] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Hyatt says this is a progression.

  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
2:33 PM Changeset in webkit [82618] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
​https://bugs.webkit.org/show_bug.cgi?id=57550

  • platform/text/BidiResolver.h: (WebCore::::createBidiRunsForLine):
2:25 PM Changeset in webkit [82617] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source/JavaScriptCore

2011-03-31 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Oliver Hunt.

SH4 JIT SUPPORT.
​https://bugs.webkit.org/show_bug.cgi?id=44329

Add YARR support for SH4 platforms (disabled by default).

  • GNUmakefile.am:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerSH4.cpp: Added.
  • assembler/MacroAssemblerSH4.h: Added.
  • assembler/SH4Assembler.h: Added.
  • yarr/YarrJIT.cpp:
2:25 PM Changeset in webkit [82616] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-31 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by James Robinson.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

  • plugins/windowless_plugin_paint_test-expected.txt: Added.
  • plugins/windowless_plugin_paint_test.html: Added.

2011-03-31 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by James Robinson.

​https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

Test: plugins/windowless_plugin_paint_test.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):
2:09 PM Changeset in webkit [82615] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Specify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory object

When passed to ::MapViewOfFile, FILE_MAP_WRITE implies FILE_MAP_READ, but other file mapping
APIs don't work that way. This bug wasn't causing any problems in practice, but it would
have prevented us from creating a DIB that wraps a SharedMemory object (which I noticed
while working on another bug).

Fixes <​http://webkit.org/b/57576> File mappings used by read-write SharedMemory objects
aren't correctly marked as read-write after being sent over a CoreIPC::Connection

Reviewed by Brian Weinstein.

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::accessRights): Specify FILE_MAP_READ in addition to FILE_MAP_WRITE for read-write
SharedMemory.

1:53 PM Changeset in webkit [82614] by senorblanco@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-03-31 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Speed up accelerated path drawing.
​https://bugs.webkit.org/show_bug.cgi?id=57371
This CL does three things: re-uses the same vertex and index buffer
for all path draws, converts all vertex layouts from vec3 to vec2, and
does a convexity check for polygons before passing them to the
tesselator.

Covered by canvas/philip/tests/2d.path.bezierCurveTo.*, and others.

  • platform/graphics/chromium/GLES2Canvas.cpp: Replace the Vector<double> for interpolated curves with a Vector<FloatPoint>. (WebCore::Cubic::evaluate): Inline the evaluation function (as Quadratic does). (WebCore::GLES2Canvas::GLES2Canvas): Initialize the m_pathIndexBuffer. (WebCore::GLES2Canvas::~GLES2Canvas): Delete the path vertex and index buffers on destruction. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Interpolate directly to a Vector<FloatPoint>, rather than Vector<double>. (WebCore::PolygonData::PolygonData): (WebCore::combineData): Replace the DoubleVector with a FloatPointVector. (WebCore::GLES2Canvas::tesselateAndFillPath): Move curve drawing into this function, and rename it to reflect the new behaviour. Re-use the common vertex and index buffers. If the curve consists of a single convex polygon, draw the curve as a single triangle fan. Otherwise, convert it to doubles and pass it to the tesselator. (WebCore::GLES2Canvas::fillPathInternal):
  • platform/graphics/chromium/GLES2Canvas.h: Rename createVertexBufferFromPath() -> tesselateAndFillPath(). Add a persistent index buffer for all path draws.
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use): Use vec2s instead of vec3s for all vertex data.
  • platform/graphics/gpu/LoopBlinnMathUtils.cpp: (WebCore::LoopBlinnMathUtils::convexCompare): (WebCore::LoopBlinnMathUtils::convexCross): (WebCore::LoopBlinnMathUtils::convexCheckTriple): (WebCore::LoopBlinnMathUtils::isConvex):
  • platform/graphics/gpu/LoopBlinnMathUtils.h: Implement a convexity check, based on the code in Graphics Gems IV.
  • platform/graphics/gpu/Shader.cpp: (WebCore::Shader::generateVertex):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::useQuadVertices):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::use):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::use): Use vec2s instead of vec3s for all vertex data.
1:42 PM Changeset in webkit [82613] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Adam Barth <​abarth@webkit.org>

Copy expectation from downstream.

  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [82612] by Darin Adler
  • 2 edits in trunk/Source/WebKit/mac

2011-03-31 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
​https://bugs.webkit.org/show_bug.cgi?id=26667

  • WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is nil rather than asserting that it is non-nil. One case where WebView will be nil is when the frame is closed, but in any case where it is nil, the correct thing to do is to not try to handle the style key.
1:40 PM Changeset in webkit [82611] by hyatt@apple.com
  • 33 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57565

Reviewed by Simon Fraser.

Source/WebCore:

Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
to check the line for overflow in the first place.

For the purposes of overflow computation, an inline object's default containment box for overflow is now assumed to extend
all the way from lineTop to lineBottom instead of snugly fitting the inline object's own block dimensions. This allows
replaced objects to be inside spans without triggering overflow allocation.

The overflow accessors on InlineFlowBox have been changed to require passing in the lineTop and lineBottom so that the block
dimensions can be forced to those values. Because these values are checked during painting and hit testing of lines, the
lineTop and lineBottom are now passed as arguments to the painting and hit testing functions to avoid repeatedly crawling
back up to the root box to fetch them.

Added a new boolean flag to all InlineBoxes, knownToHaveNoOverflow(), and optimized for common cases where no overflow can
possibly be present. When the bit is set, computeOverflow will just immediately return.

This change speeds up line layout by ~10%.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):
(WebCore::InlineBox::nodeAtPoint):
(WebCore::InlineBox::clearKnownToHaveNoOverflow):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::knownToHaveNoOverflow):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalTopVisualOverflow):
(WebCore::InlineFlowBox::logicalBottomVisualOverflow):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
(WebCore::InlineFlowBox::frameRectIncludingLineHeight):
(WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasRenderOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::nodeAtPoint):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::logicalTopVisualOverflow):
(WebCore::RootInlineBox::logicalBottomVisualOverflow):
(WebCore::RootInlineBox::logicalTopLayoutOverflow):
(WebCore::RootInlineBox::logicalBottomLayoutOverflow):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):

  • rendering/svg/SVGRootInlineBox.h:

LayoutTests:

Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
to check the line for overflow in the first place.

Updated results for tests that progressed.

  • fast/text/emphasis-avoid-ruby-expected.txt:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
1:21 PM Changeset in webkit [82610] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Quote the executable path we pass to ::CreateProcessW

This will ensure that spaces in the path will be interpreted correctly.

Fixes <​http://webkit.org/b/57569> Web process sometimes fails to launch when there are
spaces in its path

Reviewed by Steve Falkenburg.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess): Surround the executable path in quotes.

1:12 PM Changeset in webkit [82609] by pfeldman@chromium.org
  • 16 edits in trunk

2011-03-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable properties abbreviation.
​https://bugs.webkit.org/show_bug.cgi?id=57525

  • inspector/console/console-dir-global.html:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable properties abbreviation.
​https://bugs.webkit.org/show_bug.cgi?id=57525

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::getProperties):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.): ():
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::getProperties):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype._formatarray):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getAllProperties): (WebInspector.RemoteObject.prototype._getProperties): (WebInspector.LocalJSONObject.prototype.getOwnProperties): (WebInspector.LocalJSONObject.prototype.getAllProperties):
  • inspector/front-end/inspector.css: (.console-formatted-string, .console-formatted-regexp):
1:05 PM Changeset in webkit [82608] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Update WKCACFViewLayerTreeHost for changes to WKCACFView API

This should not result in any change in behavior.

Fixes <​http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to
render

Reviewed by Darin Adler.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Updated API declarations.

(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Tell WKCACFView it should
render into the window we give it.

12:54 PM Changeset in webkit [82607] by scherkus@chromium.org
  • 5 edits in branches/chromium/696/Source/WebCore

Merge 81414 - 2011-03-17 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Video colors have wrong brightness/contrast
​https://bugs.webkit.org/show_bug.cgi?id=56598

This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.

  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderYUVVideo::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h: (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h:

TBR=​commit-queue@webkit.org

12:48 PM Changeset in webkit [82606] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Activate 10 tests for media elements.
​https://bugs.webkit.org/show_bug.cgi?id=57553

Skip that one for now. The bots need to be updated.

  • platform/qt/Skipped:
12:30 PM Changeset in webkit [82605] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-31 Marius Storm-Olsen <​marius.storm-olsen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
​https://bugs.webkit.org/show_bug.cgi?id=57017

Build fix. No new tests.

  • WebCore.pri:

2011-03-31 Marius Storm-Olsen <​marius.storm-olsen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
​https://bugs.webkit.org/show_bug.cgi?id=57017

Build fix. No new tests.

12:27 PM Changeset in webkit [82604] by commit-queue@webkit.org
  • 5 edits
    4 adds
    2 deletes in trunk

2011-03-31 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML viewer is not shown when frame has non-null opener
​https://bugs.webkit.org/show_bug.cgi?id=56384

Enabled test for extensions hooks in xml viewer.

  • http/tests/xmlviewer/extensions-api-expected.txt: Added.
  • http/tests/xmlviewer/extensions-api.html: Added.
  • http/tests/xmlviewer/resources/sample.xml: Added.
  • platform/qt/Skipped:
  • xmlviewer/extensions-api-expected.txt: Removed.
  • xmlviewer/extensions-api.html_disabled: Removed.

2011-03-31 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML viewer is not shown when frame has non-null opener
​https://bugs.webkit.org/show_bug.cgi?id=56384

Removed opener check in XML viewer

Test: http/tests/xmlviewer/extensions-api.html

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::hasNoStyleInformation):
  • xml/XMLViewer.js:
11:55 AM Changeset in webkit [82603] by ap@apple.com
  • 4 edits in trunk/Source

Patch by John Harvey, reviewed and tweaked by me.

<rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.

  • Plugins/Hosted/WebTextInputWindowController.m: (-[WebTextInputPanel _interpretKeyEvent:string:]):
11:17 AM Changeset in webkit [82602] by abarth@webkit.org
  • 30 edits in trunk

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82589.
​http://trac.webkit.org/changeset/82589
​https://bugs.webkit.org/show_bug.cgi?id=57564

This patch requires many more updated results than it contains
(Requested by abarth|gardener on #webkit).

  • fast/dom/HTMLMeterElement/meter-element.html:
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82589.
​http://trac.webkit.org/changeset/82589
​https://bugs.webkit.org/show_bug.cgi?id=57564

This patch requires many more updated results than it contains
(Requested by abarth|gardener on #webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter::-webkit-meter-horizontal-bar): (meter::-webkit-meter-vertical-bar): (meter::-webkit-meter-horizontal-optimum-value): (meter::-webkit-meter-horizontal-suboptimal-value): (meter::-webkit-meter-horizontal-even-less-good-value): (meter::-webkit-meter-vertical-optimum-value): (meter::-webkit-meter-vertical-suboptimal-value): (meter::-webkit-meter-vertical-even-less-good-value):
  • rendering/RenderMeter.cpp: (WebCore::MeterPartElement::MeterPartElement): (WebCore::MeterPartElement::createForPart): (WebCore::MeterPartElement::hide): (WebCore::MeterPartElement::restoreVisibility): (WebCore::MeterPartElement::updateStyleForPart): (WebCore::MeterPartElement::saveVisibility): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::orientation): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsMeter):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::supportsMeter):
  • rendering/style/RenderStyleConstants.h:
11:14 AM Changeset in webkit [82601] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Activate 10 tests for media elements.
​https://bugs.webkit.org/show_bug.cgi?id=57553

Reactivate some media tests for Qt so we improve our coverage.

  • platform/qt/Skipped:
11:04 AM Changeset in webkit [82600] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-31 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan, Darin Adler, Dan Bernstein and Sam Weinig.

If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
​https://bugs.webkit.org/show_bug.cgi?id=57561
<rdar://problem/9127411>

Ensure that any readwrite sandbox directories actually exist before entering the sandbox.

  • WebProcess/mac/WebProcessMac.mm: (WebKit::appendReadwriteSandboxDirectory):
10:37 AM Changeset in webkit [82599] by xan@webkit.org
  • 6 edits in trunk

2011-03-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Link explicitly with XRender on Linux/Unix
​https://bugs.webkit.org/show_bug.cgi?id=57558

Some linkers, like GNU Gold, require explicit linkage of all the
libraries used instead of relying on our dependencies to bring
them in. In this case, the build fails because we use XRender in
the plugin code but don't link directly to it.

  • configure.ac: check for XRender on UNIX.

2011-03-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Link explicitly with XRender on Linux/Unix
​https://bugs.webkit.org/show_bug.cgi?id=57558

  • GNUmakefile.am: add XRender CFLAGS.

2011-03-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Link explicitly with XRender on Linux/Unix
​https://bugs.webkit.org/show_bug.cgi?id=57558

  • GNUmakefile.am: add XRender LIBS.
10:35 AM Changeset in webkit [82598] by timothy@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

Remove XMLViewer.css and XMLViewer.js from the WebCore Sources to fix a warning.

10:25 AM Changeset in webkit [82597] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Rename BidiResolver::emptyRun to m_emtpyRun to match modern style
​https://bugs.webkit.org/show_bug.cgi?id=57549

  • platform/text/BidiResolver.h: (WebCore::BidiResolver::BidiResolver): (WebCore::::appendRun): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::deleteRuns): (WebCore::::createBidiRunsForLine):
  • rendering/InlineIterator.h: (WebCore::InlineBidiResolver::appendRun):
10:20 AM Changeset in webkit [82596] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-31 Tom Sepez <​tsepez@chromium.org>

Reviewed by Eric Seidel.

Make ContainerNode::insertIntoDocument() collect all nodes before
operating on any of them. Add small helper function and use it
througout the file where this action is already taking place.
​https://bugs.webkit.org/show_bug.cgi?id=57265


Test: svg/dom/range-delete.html

  • dom/ContainerNode.cpp: (WebCore::collectNodes): (WebCore::collectTargetNodes): (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::willRemoveChildren): (WebCore::ContainerNode::insertedIntoDocument):

2011-03-31 Tom Sepez <​tsepez@chromium.org>

Reviewed by Eric Seidel.

Test that script inside an SVG can delete a range containing
itself when invoked on top of script manipulating it.
​https://bugs.webkit.org/show_bug.cgi?id=57265

  • svg/dom/range-delete-expected.txt: Added.
  • svg/dom/range-delete.html: Added.
10:18 AM Changeset in webkit [82595] by satish@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-31 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

While drawing a speech input button, validate that the node is really a speech input button.
​https://bugs.webkit.org/show_bug.cgi?id=57469

  • fast/speech/speech-style-on-non-speech-elements-expected.txt: Added.
  • fast/speech/speech-style-on-non-speech-elements.html: Added.

2011-03-31 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

While drawing a speech input button, validate that the node is really a speech input button.
​https://bugs.webkit.org/show_bug.cgi?id=57469

Test: fast/speech/speech-style-on-non-speech-elements.html

  • dom/Element.h: (WebCore::Element::isInputFieldSpeechButtonElement):
  • html/shadow/TextControlInnerElements.h: (WebCore::InputFieldSpeechButtonElement::isInputFieldSpeechButtonElement): (WebCore::toInputFieldSpeechButtonElement):
  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
10:09 AM Changeset in webkit [82594] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9214824> Find client not told when WKPageCountStringMatches exceeds maximum
​https://bugs.webkit.org/show_bug.cgi?id=57552

Reviewed by Darin Adler and Adam Roben.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
Use the same technique as findString() to report kWKMoreThanMaximumMatchCount when appropriate.
(WebKit::FindController::findString):
Convert numeric_limits::max() to max() - 1 to avoid overflow case.

9:59 AM Changeset in webkit [82593] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Ryosuke Niwa <​rniwa@webkit.org>

Build fix after r82588. Reverted unintentional change.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingLeft):
9:57 AM Changeset in webkit [82592] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Warnings happening because of unhandled switch cases in AccessibilityObjectWrapperAtk
​https://bugs.webkit.org/show_bug.cgi?id=57534

Fix compilation warnings.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getAttributeSetForAccessibilityObject): Add unhandled cases.
9:53 AM Changeset in webkit [82591] by sergio@webkit.org
  • 4 edits in trunk

2011-03-31 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] implement LayoutTestController::setWillSendRequestReturnsNull
​https://bugs.webkit.org/show_bug.cgi?id=57362

  • platform/gtk/Skipped: unskipped fast/loader/onload-willSendRequest-null-for-frame.html.

2011-03-31 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] implement LayoutTestController::setWillSendRequestReturnsNull
​https://bugs.webkit.org/show_bug.cgi?id=57362

Do not generate DRT output if willSendRequestReturnsNull is set.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback):
9:34 AM Changeset in webkit [82590] by podivilov@chromium.org
  • 15 edits
    1 add in trunk

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
​https://bugs.webkit.org/show_bug.cgi?id=57444

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/live-edit.html:
  • inspector/debugger/resources/edit-me-when-paused.js: Added. (f2): (f1):

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
​https://bugs.webkit.org/show_bug.cgi?id=57444

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::editScriptSource):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::editScriptSource):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource): (WebInspector.SourceFrame.prototype._handleSave):
9:32 AM Changeset in webkit [82589] by morrita@google.com
  • 30 edits in trunk

2011-03-30 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
​https://bugs.webkit.org/show_bug.cgi?id=56001

  • Simpflied some test cases which had vertical indicators.
  • Updated expectations due to shadow structure change
  • fast/dom/HTMLMeterElement/meter-element.html:
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-03-30 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
​https://bugs.webkit.org/show_bug.cgi?id=56001

  • Removed code which deals with the direction and left the horizontal path.
  • Removed "horizontal" from related names which is now redundant.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsMeter):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::supportsMeter):
  • rendering/style/RenderStyleConstants.h:
9:17 AM Changeset in webkit [82588] by xji@chromium.org
  • 8 edits
    2 adds in trunk

2011-03-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=57336

  • editing/selection/move-by-word-visually-expected.txt: Added.
  • editing/selection/move-by-word-visually.html: Added.

2011-03-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=57336

Follow Firefox's convention in Windows,
In LTR block, word break visually moves cursor to the left boundary of words,
In RTL block, word break visually moves cursor to the right boundary of words.

This is the 1st version of implementing "move caret by word in visual order".
It only works in the following situation:

  1. For a LTR box in a LTR block or a RTL box in RTL block, when caret is at the left boundary of the box and we are looking for the word boundary in right.
  2. For a LTR or RTL box in a LTR block, when caret is at the left boundary of the box and we are looking for the word boundary in left and previous box is a LTR box.
  3. For a LTR or RTL box in a RTL block, when the caret is at the right boundary of the box and we are looking for the word boundary in right and next box is RTL box.

An experimental granularity is introduced, as a side effect, functions having switch statements
to handle those granularities have to add more one case to handle this new granularity.
The experimental granularity is exposed though JS by '-webkit-visual-word".

The overall algorithm is looping through inline boxes visually and looking
for the visually nearest word break position.

Test: editing/selection/move-by-word-visually.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingLeft): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingLeft): (WebCore::SelectionController::modifyMovingBackward):
  • editing/TextGranularity.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  • editing/visible_units.cpp: (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): (WebCore::wordBoundaryInBox): (WebCore::wordBoundaryInAdjacentBoxes): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):
  • editing/visible_units.h:
  • page/DOMSelection.cpp: (WebCore::DOMSelection::modify):
9:15 AM Changeset in webkit [82587] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-31 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r82580.

  • WebCoreSupport/FrameLoaderClientWinCE.h: StringWithDirection is in WebCore

and not in WTF namespace.

9:13 AM Changeset in webkit [82586] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-31 Evan Martin <​evan@chromium.org>

Another build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory):
9:07 AM Changeset in webkit [82585] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-31 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] ChromeClientQt.h has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40239

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::scrollbarsModeDidChange): (WebCore::ChromeClientQt::needTouchEvents): (WebCore::ChromeClientQt::formStateDidChange): (WebCore::ChromeClientQt::scrollRectIntoView): (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame): (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
9:01 AM Changeset in webkit [82584] by Dimitri Glazkov
  • 6 edits in trunk/Source/WebCore

2011-03-31 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move coordinate-computing logic into MouseRelatedEvent.
​https://bugs.webkit.org/show_bug.cgi?id=57521

Refactoring, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchWheelEvent): Yank calculation of

coordinates out.

(WebCore::EventDispatcher::dispatchMouseEvent): Ditto.

  • dom/MouseEvent.cpp: (WebCore::MouseEvent::create): Add coordinate-computing logic.
  • dom/MouseEvent.h: Adjust decl to reflect new meaning of params.
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): Ditto.
8:58 AM Changeset in webkit [82583] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: document CSS agent.
​https://bugs.webkit.org/show_bug.cgi?id=57435

  • inspector/Inspector.json:
8:34 AM Changeset in webkit [82582] by evan@chromium.org
  • 4 edits in trunk/Source/WebKit

2011-03-31 Evan Martin <​evan@chromium.org>

Build fix from previous change.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):

2011-03-31 Evan Martin <​evan@chromium.org>

Build fix from previous change.

  • Api/qwebframe.cpp: (QWebFrame::title):
8:21 AM Changeset in webkit [82581] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-03-31 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove periods at the end of error messages
​https://bugs.webkit.org/show_bug.cgi?id=57544

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::makeObjectCall):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::elementForId): (WebCore::InspectorCSSAgent::styleSheetForId):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeValue):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::setPropertyValue):
8:17 AM Changeset in webkit [82580] by evan@chromium.org
  • 52 edits
    1 add in trunk/Source

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Introduce a new StringWithDirection object that carries a String along
with the TextDirection associated with the String. Use this object for
document titles used within WebCore, because in HTML the direction of
a title can be set with the 'dir' attribute.

Put FIXMEs at the WebKit level to expose the new direction information
to clients.

No behavioral change intended, so no new tests. A follow-up will expose
the title direction and hopefully can be accompanied by tests that
verify it is correct.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateTitle): (WebCore::Document::setTitle): (WebCore::Document::removeTitle):
  • dom/Document.h: (WebCore::Document::title):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::HTMLTitleElement): (WebCore::HTMLTitleElement::childrenChanged): (WebCore::HTMLTitleElement::text): (WebCore::HTMLTitleElement::textWithDirection):
  • html/HTMLTitleElement.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::title):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidReceiveTitle): (WebCore::EmptyFrameLoaderClient::setTitle):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::setTitle):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::HistoryController::initializeItem):
  • loader/HistoryController.h:
  • platform/text/StringWithDirection.h: Added. (WebCore::StringWithDirection::StringWithDirection): (WebCore::StringWithDirection::operator==): (WebCore::StringWithDirection::operator!=):
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::insertedIntoDocument): (WebCore::SVGTitleElement::childrenChanged):

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle): (WebKit::FrameLoaderClientImpl::setTitle):
  • src/FrameLoaderClientImpl.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::pageTitle):

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientEfl::setTitle):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::setTitle):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::setTitle):

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::setTitle):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidReceiveTitle):
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::dispatchDidReceiveTitle): (WebKit::FrameLoaderClientWinCE::setTitle):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWx::setTitle):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-03-31 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

<title> should support dir attribute
​https://bugs.webkit.org/show_bug.cgi?id=50961

Update to new FrameLoaderClient interface.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle): (WebKit::WebFrameLoaderClient::setTitle):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
8:12 AM Changeset in webkit [82579] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:03 AM Changeset in webkit [82578] by apavlov@chromium.org
  • 9 edits in trunk

2011-03-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
​https://bugs.webkit.org/show_bug.cgi?id=57538

WebCore:

  • inspector/InspectorStyleSheet.cpp: (WebCore::buildSourceRangeObject): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleDeclaration):

LayoutTests:

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.rangeText): (initialize_ElementTest):
  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
7:54 AM Changeset in webkit [82577] by kbalazs@webkit.org
  • 7 edits
    2 adds in trunk/Source/WebKit2

2011-03-31 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[WK2] Introduce an option for no NPAPI support
​https://bugs.webkit.org/show_bug.cgi?id=55828

Stub out NPAPI support for platform and OS combinations that are
not supported yet. Ancestor patch was made by Laszlo Gombos.

  • GNUmakefile.am: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp to the build system.
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: Remove the sanity check because from now all combinations that don't have an explicitly set plugin architecture fall into the PLUGIN_ARCHITECTURE(UNSUPPORTED) category and has a stubbed implementation.
  • Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp: Added. Stubbed implementation. (WebKit::NetscapePluginModule::getPluginInfo): (WebKit::NetscapePluginModule::determineQuirks):
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: Guard with PLUGIN_ARCHITECTURE(X11).
  • WebKit2.pro: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp to the build system.
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: Added. Stubbed implementation (WebKit::NetscapePlugin::platformPostInitialize): (WebKit::NetscapePlugin::platformDestroy): (WebKit::NetscapePlugin::platformInvalidate): (WebKit::NetscapePlugin::platformGeometryDidChange): (WebKit::NetscapePlugin::platformPaint): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Guard with PLUGIN_ARCHITECTURE(X11)
  • config.h: Introduce PLUGIN_ARCHITECTURE(UNSUPPORTED) as another option. Make platform and OS combinations that are not supported yet fall into this. Don't use Q_WS_X11 to test the window system for Qt because it is not defined without including <QtGlobal>. No clue about how could it work so far.
7:40 AM Changeset in webkit [82576] by podivilov@chromium.org
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix expectation files names after r82573.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.png.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.png.
7:29 AM Changeset in webkit [82575] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark two canvas tests as TIMEOUT on chromium-gpu

  • platform/chromium/test_expectations.txt:
7:25 AM Changeset in webkit [82574] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-31 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of a bidi svg test.

  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
7:11 AM Changeset in webkit [82573] by podivilov@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, update chromium-gpu-linux compositing expectations.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.png: Added.
  • platform/chromium/test_expectations.txt:
6:53 AM Changeset in webkit [82572] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-03-31 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of 2 tests.

  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/borders/rtl-border-05-expected.txt:
6:24 AM Changeset in webkit [82571] by commit-queue@webkit.org
  • 13 edits
    20 deletes in trunk

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82565.
​http://trac.webkit.org/changeset/82565
​https://bugs.webkit.org/show_bug.cgi?id=57541

Caused assertion failures. (Requested by bbandix on #webkit).

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Removed.
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Removed.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Removed.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Removed.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Removed.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Removed.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Removed.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Removed.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Removed.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Removed.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Removed.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Removed.
  • svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Removed.
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Removed.
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Removed.
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Removed.

2011-03-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82565.
​http://trac.webkit.org/changeset/82565
​https://bugs.webkit.org/show_bug.cgi?id=57541

Caused assertion failures. (Requested by bbandix on #webkit).

  • platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::setFloodColor): (WebCore::FEFlood::setFloodOpacity):
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setLightingColor):
  • platform/graphics/filters/FESpecularLighting.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
5:53 AM Changeset in webkit [82570] by alex
  • 5 edits
    3 adds in trunk

2011-03-31 Vamshikrishna.Yellenki <​vamshi@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Implement MiniBrowser for Gtk port.
​https://bugs.webkit.org/show_bug.cgi?id=48512

Initial implementation of the Gtk MiniBrowser.

  • GNUmakefile.am:

2011-03-31 Vamshikrishna.Yellenki <​vamshi@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Implement MiniBrowser for Gtk port.
​https://bugs.webkit.org/show_bug.cgi?id=48512

Initial implementation of the Gtk MiniBrowser.

  • MiniBrowser/gtk/GNUmakefile.am: Added.
  • MiniBrowser/gtk/main.c: Added. (activateUriEntryCallback): (destroyCallback): (goBackCallback): (goForwardCallback): (createToolbar): (createWebView): (createWindow): (argumentToURL): (main):

2011-03-31 Vamshikrishna.Yellenki <​vamshi@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Implement MiniBrowser for Gtk port.
​https://bugs.webkit.org/show_bug.cgi?id=48512

  • Shared/API/c/gtk/WKBaseGtk.h: Add the stdbool.h include.
5:40 AM Changeset in webkit [82569] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix error in chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:37 AM Changeset in webkit [82568] by Philippe Normand
  • 1 edit
    26 adds in trunk/LayoutTests

2011-03-31 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for tests added in r82303, r82419,
r82400 and r82411.

  • platform/gtk/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
  • platform/gtk/fast/block/float/float-forced-below-other-floats-expected.png: Added.
  • platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-01-expected.checksum: Added.
  • platform/gtk/fast/borders/rtl-border-01-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-01-expected.txt: Added.
  • platform/gtk/fast/borders/rtl-border-02-expected.checksum: Added.
  • platform/gtk/fast/borders/rtl-border-02-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-02-expected.txt: Added.
  • platform/gtk/fast/borders/rtl-border-03-expected.checksum: Added.
  • platform/gtk/fast/borders/rtl-border-03-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-03-expected.txt: Added.
  • platform/gtk/fast/borders/rtl-border-04-expected.checksum: Added.
  • platform/gtk/fast/borders/rtl-border-04-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-04-expected.txt: Added.
  • platform/gtk/fast/borders/rtl-border-05-expected.checksum: Added.
  • platform/gtk/fast/borders/rtl-border-05-expected.png: Added.
  • platform/gtk/fast/borders/rtl-border-05-expected.txt: Added.
  • platform/gtk/fast/css/h1-in-section-elements-expected.checksum: Added.
  • platform/gtk/fast/css/h1-in-section-elements-expected.png: Added.
  • platform/gtk/fast/css/h1-in-section-elements-expected.txt: Added.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Added.
5:36 AM Changeset in webkit [82567] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-31 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to XMLViewer change with expectations update.

  • fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt:
  • svg/hixie/error/dumpAsText/005-expected.txt:
5:34 AM Changeset in webkit [82566] by podivilov@chromium.org
  • 2 edits in branches/chromium/696

Merge 82453 - 2011-03-30 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: audit run never completes, fails in DOMAgent.js
​https://bugs.webkit.org/show_bug.cgi?id=57349

  • assure document is present before calling DOMAgent.querySelectAll()
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

2011-03-30 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: audit run never completes, fails in DOMAgent.js
​https://bugs.webkit.org/show_bug.cgi?id=57349

  • inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349

BUG=77001
TBR=​caseq@chromium.org
Review URL: ​http://codereview.chromium.org/6756040

5:33 AM Changeset in webkit [82565] by reni@webkit.org
  • 13 edits
    20 adds in trunk

CSS related SVG*Element changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=56906

Reviewed by Dirk Schulze.

Source/WebCore:

The changes of some CSS related SVGFilter properties e.g. lighting-color, flood-color, flood-opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.

Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html

svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):

  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::setLightingColor):

  • platform/graphics/filters/FESpecularLighting.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):

  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientStyleChanged):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):

  • svg/SVGFEFloodElement.cpp:

(WebCore::SVGFEFloodElement::setFilterEffectAttribute):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):

LayoutTests:

Testing inherited CSS related SVG property changes by FEFlood, FESpecularLighting and FEDiffuseLighing filters.
Adding a missing test to check the dynamic update of lighting-color property of FESpecularLighting.
All the other modifications are covered by the existing dyanmic-update tests.

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Added.

(executeTest):

5:08 AM Changeset in webkit [82564] by podivilov@chromium.org
  • 1 edit
    5 deletes in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove stale chromium-gpu canvas expectations (see r82521).

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Removed.
5:03 AM Changeset in webkit [82563] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark send-sliced-dragged-file.html as crash pass in chromium.

  • platform/chromium/test_expectations.txt:
4:58 AM Changeset in webkit [82562] by pfeldman@chromium.org
  • 17 edits
    2 adds
    2 deletes in trunk

2011-03-29 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: declared namespaces are not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=56262

XML viewer rewritten on javascript.

  • http/tests/xmlviewer/dumpAsText/wml-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xul-expected.txt:
  • platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: Removed.
  • platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:

2011-03-29 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: declared namespaces are not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=56262

XML viewer rewritten on javascript.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doEnd):
  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.css: Added.
  • xml/XMLViewer.js: Added.
  • xml/XMLViewer.xsl: Removed.
  • xml/XSLStyleSheet.h:
4:36 AM Changeset in webkit [82561] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Jaehun Lim <​ljaehun.lim@samsung.com>

Unreviewed build fix.

Fix build break after rolling out r82496
​https://bugs.webkit.org/show_bug.cgi?id=57536

  • platform/efl/RenderThemeEfl.cpp:
4:31 AM Changeset in webkit [82560] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-31 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: execution line is displayed incorrectly after source editing.
​https://bugs.webkit.org/show_bug.cgi?id=57229

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._saveViewerState): (WebInspector.SourceFrame.prototype._restoreViewerState): (WebInspector.SourceFrame.prototype._startEditing): (WebInspector.SourceFrame.prototype._endEditing): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype.addDecoration): (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration): (WebInspector.TextEditorMainPanel.prototype.makeLineAChunk): (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
4:28 AM Changeset in webkit [82559] by podivilov@chromium.org
  • 1 edit
    55 deletes in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove stale chromium-gpu canvas expectations (see r82521).

  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.txt: Removed.
4:20 AM Changeset in webkit [82558] by Philippe Normand
  • 1 edit
    29 deletes in trunk/LayoutTests

2011-03-31 Philippe Normand <​pnormand@igalia.com>

Unreviewed, remove GTK-specific fast/canvas baselines after r82521.

  • platform/gtk/fast/canvas/arc360-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-before-css-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-composite-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-text-alignment-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
  • platform/gtk/fast/canvas/drawImage-expected.txt: Removed.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.txt: Removed.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Removed.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.txt: Removed.
  • platform/gtk/fast/canvas/image-pattern-rotate-expected.txt: Removed.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.txt: Removed.
  • platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt: Removed.
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt: Removed.
  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.txt: Removed.
3:43 AM Changeset in webkit [82557] by podivilov@chromium.org
  • 17 edits
    10 adds in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium box-shadow tests after r82520.

  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
3:30 AM Changeset in webkit [82556] by podivilov@chromium.org
  • 1 edit
    32 deletes in trunk/LayoutTests

2011-03-31 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, update chromium expectations after r82521.

  • platform/chromium-win/fast/canvas/arc360-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-before-css-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-composite-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-resize-reset-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-identity-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-infinity-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-multiply-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-nan-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-non-invertible-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-skewed-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/drawImage-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/image-object-in-canvas-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/image-pattern-rotate-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/patternfill-repeat-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/quadraticCurveTo-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-1-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-2-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-3-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/zero-size-fill-rect-expected.txt: Removed.
3:26 AM Changeset in webkit [82555] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Make the CSStyle "shorthandValues" name-value map an array
​https://bugs.webkit.org/show_bug.cgi?id=57452

No new tests, as this is a refactoring.

  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.buildShorthandValueMap):
3:04 AM Changeset in webkit [82554] by steveblock@google.com
  • 8 edits
    1 copy
    1 move in trunk/Source/WebCore

2011-03-30 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaField should not expose JavaString in its API
​https://bugs.webkit.org/show_bug.cgi?id=55766

This patch fixes JavaField for V8 only.

  • Factors out a JavaField interface which does not use JNI types. This will allow the Java bridge to be used with objects that don't use JNI directly. The existing jobject-backed implementation is moved to a new JavaFieldJobject class which implements the interface.
  • Use WTF::String in place of JavaString in the API, as JavaString exposes JNI types in its interface.

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/JavaMethod.h: (JSC::Bindings::JavaMethod::~JavaMethod):
  • bridge/jni/JobjectWrapper.h:
  • bridge/jni/v8/JavaClassV8.cpp: (JavaClass::JavaClass):
  • bridge/jni/v8/JavaFieldJobjectV8.cpp: (JavaFieldJobject::JavaFieldJobject):
  • bridge/jni/v8/JavaFieldJobjectV8.h: (JSC::Bindings::JavaFieldJobject::name): (JSC::Bindings::JavaFieldJobject::typeClassName): (JSC::Bindings::JavaFieldJobject::type):
  • bridge/jni/v8/JavaFieldV8.h: (JSC::Bindings::JavaField::~JavaField):
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::getField):
2:55 AM Changeset in webkit [82553] by Philippe Normand
  • 30 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r82496 and its 8 follow-up build fixes:
r82504, r82513, r82541, r82544, r82548, r82549, r82526, r82551

​https://bugs.webkit.org/show_bug.cgi?id=55150

2:48 AM Changeset in webkit [82552] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-31 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Clean up from r82447.
​https://bugs.webkit.org/attachment.cgi?bugid=57532

No new tests since this doesn't change behavior.

  • rendering/RenderBlock.cpp: Removing unnecessary visible_units.h include.
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Making const. (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
  • rendering/RootInlineBox.h:
1:49 AM Changeset in webkit [82551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-31 Jaehun Lim <​ljaehun.lim@samsung.com>

Unreviewed build fix for EFL

After r55150, EFL build has failed.
PlatformContextCairo.cpp is added into CMakeListsEfl.txt
​https://bugs.webkit.org/show_bug.cgi?id=57526

No need to test

  • CMakeListsEfl.txt: Add PlatformContextCairo.cpp
1:06 AM BuildingGtk edited by dominicc@google.com
Remove spurious list of test packages. (diff)
12:38 AM Changeset in webkit [82550] by kalman@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-31 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ojan Vafai.

DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
​https://bugs.webkit.org/show_bug.cgi?id=57079

Add regression test.

  • editing/execCommand/delete-table-with-empty-contents-expected.txt: Added.
  • editing/execCommand/delete-table-with-empty-contents.html: Added.

2011-03-31 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ojan Vafai.

DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
​https://bugs.webkit.org/show_bug.cgi?id=57079

Test: editing/execCommand/delete-table-with-empty-contents.html

This bug results in an ASSERT fail in CompositeEditCommand::insertNodeAt, so is only observable in debug builds
of WebKit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::firstEditablePositionInNode): (WebCore::DeleteSelectionCommand::removeNode): Use firstEditablePositionInNode rather than firstPositionInNode to find anchor node for the placeholder's position, if any.
Note: See TracTimeline for information about the timeline view.