Context Navigation

← Previous Period
Next Period →

Timeline

Apr 3, 2011:

11:41 PM Changeset in webkit [82801] by tkent@chromium.org

3 edits in trunk/LayoutTests

2011-04-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Adding a test of value sanitization for <input type=text>
https://bugs.webkit.org/show_bug.cgi?id=57737

fast/forms/input-value-sanitization-expected.txt:
fast/forms/script-tests/input-value-sanitization.js: Add tests for type=text.

10:40 PM Changeset in webkit [82800] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Clean duplicated files in WebCore_Sources
https://bugs.webkit.org/show_bug.cgi?id=57741

No new tests, Only duplicated files were removed.

CMakeLists.txt:

9:13 PM Changeset in webkit [82799] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Fix 2-space indentation introduced in bug 54706.
https://bugs.webkit.org/show_bug.cgi?id=57740

No new tests - whitespace changes only.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Convert 2-space indentation to 4-space indentation.

8:09 PM Changeset in webkit [82798] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Make CSSStyleApplyProperty non-copyable
https://bugs.webkit.org/show_bug.cgi?id=57738

No new functionality added so no new tests required.

css/CSSStyleApplyProperty.h: Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.

7:21 PM Changeset in webkit [82797] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Build fix.

Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

Shared/DictionaryPopupInfo.h:

7:13 PM Changeset in webkit [82796] by mitz@apple.com

5 edits in trunk/Source/WebKit2

<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
https://bugs.webkit.org/show_bug.cgi?id=57739

Reviewed by Maciej Stachowiak.

Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.

Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
Shared/Plugins/PluginQuirks.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.

4:22 PM Changeset in webkit [82795] by mitz@apple.com

2 edits in trunk/Source/WebCore

fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
https://bugs.webkit.org/show_bug.cgi?id=57733

Reviewed by Maciej Stachowiak.

The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn't expect to be called between
tests, and it references the layout test controller, which is null.

page/Frame.cpp:

(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn't changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.

12:17 PM Changeset in webkit [82794] by mitz@apple.com

2 edits in trunk/LayoutTests

Try to make this test more robust.

fast/blockflow/broken-ideographic-font.html: Ensure that the font has been loaded before

letting the test finish.

5:37 AM Changeset in webkit [82793] by eric@webkit.org

3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Teach InlineIterator how to work from any root, not just a RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=57726

For implementing bidi-unicode: isolate, we need to be able to run the
bidi algorithm over a subtree of inlines, not just from a block root.
This is the first step in making this possible.

rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::root): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::appendRun):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

1:29 AM Changeset in webkit [82792] by eric@webkit.org

3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <eric@webkit.org>

Reviewed by Dan Bernstein.

Split out handling of trailing spaces from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=57432

There is much more we could split out from this function, but this is a start.

I suspect this is very hot code. Hopefully the compiler will do the right thing.
If it doesn't the Chromium PLT bots will tell us.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren):

12:54 AM Changeset in webkit [82791] by rniwa@webkit.org

4 edits
8 adds in trunk

2011-03-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771

The bug was caused by WebKit's not checking the existence of root editable element
in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
we should not run editing commands in a document without a body element editable because
doing so results in appending a non-body element to the document node.

Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
when there are no body element. Since StyleWithCSS is a document's state or property, we allow
execCommand('StyleWithCSS') even in a document without a body element.

WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
the selection when document.write("x") is ran and successfully inserts image.

Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.

Since Internet Explorer does not allow execCommand to run under design mode properly, we could
not test its behavior.

Tests: editing/editability/empty-document-delete.html

editing/editability/empty-document-justify-right.html
editing/editability/empty-document-stylewithcss.html
editing/execCommand/insert-image-with-selecting-document.html

editing/Editor.cpp: (WebCore::Editor::canEdit): Verify that the root editable element exists instead of just checking that selection endpoints are editable because selection endpoints could be document node without a body element in design mode and we don't want to consider such a document editable. (WebCore::Editor::canDelete): Ditto.
editing/EditorCommand.cpp: (WebCore::enabledInEditableText): Ditto. (WebCore::enabledInRichlyEditableText): Ditto. (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead of duplicating the code in order to fix the same bug.

2011-03-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771

Added tests to ensure WebKit does not crash when attempted to execute editing commands
in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
is executed with selection endpoints being document. WebKit should ignore such attempts
and should not crash.

editing/editability/empty-document-delete-expected.txt: Added.
editing/editability/empty-document-delete.html: Added.
editing/editability/empty-document-justify-right-expected.txt: Added.
editing/editability/empty-document-justify-right.html: Added.
editing/editability/empty-document-stylewithcss-expected.txt: Added.
editing/editability/empty-document-stylewithcss.html: Added.
editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
editing/execCommand/insert-image-with-selecting-document.html: Added.

Apr 2, 2011:

11:30 PM Changeset in webkit [82790] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated results showing a progression after r82787. The current time display
is now correctly collapsed because the timeline container is not wide enough.

platform/gtk/media/video-zoom-controls-expected.txt:

11:22 PM Changeset in webkit [82789] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated platform-specific results after r82787.

platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:

10:40 PM Changeset in webkit [82788] by mitz@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
https://bugs.webkit.org/show_bug.cgi?id=57719

Reviewed by Maciej Stachowiak.

r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
that the timeline container is the parent of the time display. This is not true
with the GTK media style, where the current time display is an inline box, and
thus wrapped in an anonymous flexible box. The code was incorrectly considering
the width of the anonymous box and deciding to hide the time display. Prior to
r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.

rendering/MediaControlElements.cpp:

(WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.

9:55 PM Changeset in webkit [82787] by thakis@chromium.org

2 edits in trunk/Source/WebCore

2011-04-02 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0

By default, ICU includes |using namespace icu;| in its header files
for backwards compatibility. Clients can define
U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
classes with |icu::| makes this file compile no matter what
U_USING_ICU_NAMESPACE is set to.

https://bugs.webkit.org/show_bug.cgi?id=57715

platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): (WebCore::numberFormatter): (WebCore::parseLocalizedNumber): (WebCore::formatLocalizedNumber):

6:47 PM Changeset in webkit [82786] by mitz@apple.com

15 edits in trunk

Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
platform/mac/mathml/presentation/fractions-expected.checksum:
platform/mac/mathml/presentation/fractions-expected.png:
platform/mac/mathml/presentation/fractions-expected.txt:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/mac/mathml/presentation/roots-expected.checksum:
platform/mac/mathml/presentation/roots-expected.png:
platform/mac/mathml/presentation/roots-expected.txt:
platform/mac/mathml/presentation/row-alignment-expected.checksum:
platform/mac/mathml/presentation/row-alignment-expected.png:
platform/mac/mathml/presentation/row-alignment-expected.txt:
platform/mac/mathml/presentation/subsup-expected.checksum:
platform/mac/mathml/presentation/subsup-expected.png:
platform/mac/mathml/presentation/subsup-expected.txt:

6:43 PM Changeset in webkit [82785] by mitz@apple.com

91 edits in trunk/LayoutTests

Updated platform-specific results after r82873.

platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-1-expected.txt:
platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-10-expected.txt:
platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-2-expected.txt:
platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-3-expected.txt:
platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-4-expected.txt:
platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-5-expected.txt:
platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-6-expected.txt:
platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-7-expected.txt:
platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-8-expected.txt:
platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
platform/gtk/fast/html/details-add-summary-9-expected.txt:
platform/gtk/fast/html/details-no-summary1-expected.txt:
platform/gtk/fast/html/details-no-summary2-expected.txt:
platform/gtk/fast/html/details-no-summary3-expected.txt:
platform/gtk/fast/html/details-no-summary4-expected.txt:
platform/gtk/fast/html/details-open-javascript-expected.txt:
platform/gtk/fast/html/details-open1-expected.txt:
platform/gtk/fast/html/details-open2-expected.txt:
platform/gtk/fast/html/details-open3-expected.txt:
platform/gtk/fast/html/details-open4-expected.txt:
platform/gtk/fast/html/details-open5-expected.txt:
platform/gtk/fast/html/details-open6-expected.txt:
platform/gtk/fast/html/details-position-expected.txt:
platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-1-expected.txt:
platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-2-expected.txt:
platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-3-expected.txt:
platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-4-expected.txt:
platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-5-expected.txt:
platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
platform/gtk/fast/html/details-remove-summary-6-expected.txt:
platform/gtk/fast/html/details-writing-mode-expected.txt:
platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-1-expected.txt:
platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-10-expected.txt:
platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-2-expected.txt:
platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-3-expected.txt:
platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-4-expected.txt:
platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-5-expected.txt:
platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-6-expected.txt:
platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-7-expected.txt:
platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-8-expected.txt:
platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
platform/qt/fast/html/details-add-summary-9-expected.txt:
platform/qt/fast/html/details-no-summary1-expected.txt:
platform/qt/fast/html/details-no-summary2-expected.txt:
platform/qt/fast/html/details-no-summary3-expected.txt:
platform/qt/fast/html/details-no-summary4-expected.txt:
platform/qt/fast/html/details-open-javascript-expected.txt:
platform/qt/fast/html/details-open1-expected.txt:
platform/qt/fast/html/details-open2-expected.txt:
platform/qt/fast/html/details-open3-expected.txt:
platform/qt/fast/html/details-open4-expected.txt:
platform/qt/fast/html/details-open5-expected.txt:
platform/qt/fast/html/details-open6-expected.txt:
platform/qt/fast/html/details-position-expected.txt:
platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-1-expected.txt:
platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-2-expected.txt:
platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-3-expected.txt:
platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-4-expected.txt:
platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-5-expected.txt:
platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
platform/qt/fast/html/details-remove-summary-6-expected.txt:
platform/qt/fast/html/details-writing-mode-expected.txt:

5:47 PM Changeset in webkit [82784] by Beth Dakin

2 edits in trunk/Tools

For Dan!

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

5:34 PM Changeset in webkit [82783] by mitz@apple.com

140 edits in trunk

<details> marker loses its margin
https://bugs.webkit.org/show_bug.cgi?id=57713

Reviewed by Beth Dakin.

Source/WebCore:

rendering/RenderDetails.cpp:

(WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
the marker location.

rendering/RenderDetails.h:

(WebCore::RenderDetails::renderName): Made private.
(WebCore::RenderDetails::isDetails): Ditto.

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
in the style, like RenderListMarker does.
(WebCore::RenderDetailsMarker::layout): Set the margins from the style.

LayoutTests:

platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-1-expected.checksum:
platform/mac/fast/html/details-add-summary-1-expected.png:
platform/mac/fast/html/details-add-summary-1-expected.txt:
platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-10-expected.checksum:
platform/mac/fast/html/details-add-summary-10-expected.png:
platform/mac/fast/html/details-add-summary-10-expected.txt:
platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-2-expected.checksum:
platform/mac/fast/html/details-add-summary-2-expected.png:
platform/mac/fast/html/details-add-summary-2-expected.txt:
platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-3-expected.checksum:
platform/mac/fast/html/details-add-summary-3-expected.png:
platform/mac/fast/html/details-add-summary-3-expected.txt:
platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-4-expected.checksum:
platform/mac/fast/html/details-add-summary-4-expected.png:
platform/mac/fast/html/details-add-summary-4-expected.txt:
platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-5-expected.checksum:
platform/mac/fast/html/details-add-summary-5-expected.png:
platform/mac/fast/html/details-add-summary-5-expected.txt:
platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-6-expected.checksum:
platform/mac/fast/html/details-add-summary-6-expected.png:
platform/mac/fast/html/details-add-summary-6-expected.txt:
platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-7-expected.checksum:
platform/mac/fast/html/details-add-summary-7-expected.png:
platform/mac/fast/html/details-add-summary-7-expected.txt:
platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-8-expected.checksum:
platform/mac/fast/html/details-add-summary-8-expected.png:
platform/mac/fast/html/details-add-summary-8-expected.txt:
platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
platform/mac/fast/html/details-add-summary-9-expected.checksum:
platform/mac/fast/html/details-add-summary-9-expected.png:
platform/mac/fast/html/details-add-summary-9-expected.txt:
platform/mac/fast/html/details-no-summary1-expected.checksum:
platform/mac/fast/html/details-no-summary1-expected.png:
platform/mac/fast/html/details-no-summary1-expected.txt:
platform/mac/fast/html/details-no-summary2-expected.checksum:
platform/mac/fast/html/details-no-summary2-expected.png:
platform/mac/fast/html/details-no-summary2-expected.txt:
platform/mac/fast/html/details-no-summary3-expected.checksum:
platform/mac/fast/html/details-no-summary3-expected.png:
platform/mac/fast/html/details-no-summary3-expected.txt:
platform/mac/fast/html/details-no-summary4-expected.checksum:
platform/mac/fast/html/details-no-summary4-expected.png:
platform/mac/fast/html/details-no-summary4-expected.txt:
platform/mac/fast/html/details-open-javascript-expected.checksum:
platform/mac/fast/html/details-open-javascript-expected.png:
platform/mac/fast/html/details-open-javascript-expected.txt:
platform/mac/fast/html/details-open1-expected.checksum:
platform/mac/fast/html/details-open1-expected.png:
platform/mac/fast/html/details-open1-expected.txt:
platform/mac/fast/html/details-open2-expected.checksum:
platform/mac/fast/html/details-open2-expected.png:
platform/mac/fast/html/details-open2-expected.txt:
platform/mac/fast/html/details-open3-expected.checksum:
platform/mac/fast/html/details-open3-expected.png:
platform/mac/fast/html/details-open3-expected.txt:
platform/mac/fast/html/details-open4-expected.checksum:
platform/mac/fast/html/details-open4-expected.png:
platform/mac/fast/html/details-open4-expected.txt:
platform/mac/fast/html/details-open5-expected.checksum:
platform/mac/fast/html/details-open5-expected.png:
platform/mac/fast/html/details-open5-expected.txt:
platform/mac/fast/html/details-open6-expected.checksum:
platform/mac/fast/html/details-open6-expected.png:
platform/mac/fast/html/details-open6-expected.txt:
platform/mac/fast/html/details-position-expected.checksum:
platform/mac/fast/html/details-position-expected.png:
platform/mac/fast/html/details-position-expected.txt:
platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-1-expected.checksum:
platform/mac/fast/html/details-remove-summary-1-expected.png:
platform/mac/fast/html/details-remove-summary-1-expected.txt:
platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-2-expected.checksum:
platform/mac/fast/html/details-remove-summary-2-expected.png:
platform/mac/fast/html/details-remove-summary-2-expected.txt:
platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-3-expected.checksum:
platform/mac/fast/html/details-remove-summary-3-expected.png:
platform/mac/fast/html/details-remove-summary-3-expected.txt:
platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-4-expected.checksum:
platform/mac/fast/html/details-remove-summary-4-expected.png:
platform/mac/fast/html/details-remove-summary-4-expected.txt:
platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-5-expected.checksum:
platform/mac/fast/html/details-remove-summary-5-expected.png:
platform/mac/fast/html/details-remove-summary-5-expected.txt:
platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
platform/mac/fast/html/details-remove-summary-6-expected.checksum:
platform/mac/fast/html/details-remove-summary-6-expected.png:
platform/mac/fast/html/details-remove-summary-6-expected.txt:
platform/mac/fast/html/details-writing-mode-expected.checksum:
platform/mac/fast/html/details-writing-mode-expected.png:
platform/mac/fast/html/details-writing-mode-expected.txt:

5:19 PM Changeset in webkit [82782] by Beth Dakin

2 edits in trunk/Tools

Need to reset the scale, much like zoom.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

5:01 PM Changeset in webkit [82781] by aestes@apple.com

3 edits
4 adds in trunk

2011-04-02 Andy Estes <aestes@apple.com>

Reviewed by Oliver Hunt.

REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518

Test: fast/images/imagemap-focus-ring-zero-outline-width.html

rendering/RenderImage.cpp: (WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.

2011-04-02 Andy Estes <aestes@apple.com>

Reviewed by Oliver Hunt.

REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518

fast/images/imagemap-focus-ring-zero-outline-width.html: Added.
platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.

4:46 PM Changeset in webkit [82780] by Beth Dakin

13 edits
8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Source/WebKit2:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetScaleAtOrigin):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.

DumpRenderTree/mac/EventSendingController.mm:

(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController scalePageBy:atX:andY:]):

WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::scalePageBy):

WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset):

LayoutTests:

Reviewed by Sam Weinig.

fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
fast/dom/Element/scale-page-bounding-client-rect.html: Added.
fast/dom/Element/scale-page-client-rects-expected.txt: Added.
fast/dom/Element/scale-page-client-rects.html: Added.
fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
fast/dom/Range/scale-page-bounding-client-rect.html: Added.
fast/dom/Range/scale-page-client-rects-expected.txt: Added.
fast/dom/Range/scale-page-client-rects.html: Added.
platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

4:19 PM Changeset in webkit [82779] by weinig@apple.com

5 edits in trunk/Source/WebKit2

2011-04-02 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

"Search in Spotlight" broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57712

Proxy spotlight searching to the UIProcess.

UIProcess/WebPageProxy.messages.in: Add new message. Re-organize messages to put all mac specific ones together.

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::speak): (WebKit::WebPageProxy::searchWithSpotlight): Moved code to trigger spotlight here. Use WTF::String -> NSString conversion function instead of relying on the built in conversion since it doesn't always work in the UIProcess.

WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: (WebKit::WebContextMenuClient::searchWithSpotlight): Post message to the UIProcess to do the searching.

3:36 PM Changeset in webkit [82778] by Beth Dakin

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Reviewed by Sam Weinig.

New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().

dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

dom/Range.cpp:

(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
(WebCore::Range::getBorderAndTextQuads):

rendering/RenderObject.h:

(WebCore::adjustFloatPointForPageScale):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):

3:21 PM Changeset in webkit [82777] by mitz@apple.com

15 edits in trunk

Reverted r82775 due to changes in <details> test results, which are
likely progressions.

Source/WebCore:

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a

LayoutTests:

platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
platform/mac/mathml/presentation/fractions-expected.checksum:
platform/mac/mathml/presentation/fractions-expected.png:
platform/mac/mathml/presentation/fractions-expected.txt:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/mac/mathml/presentation/roots-expected.checksum:
platform/mac/mathml/presentation/roots-expected.png:
platform/mac/mathml/presentation/roots-expected.txt:
platform/mac/mathml/presentation/row-alignment-expected.checksum:
platform/mac/mathml/presentation/row-alignment-expected.png:
platform/mac/mathml/presentation/row-alignment-expected.txt:
platform/mac/mathml/presentation/subsup-expected.checksum:
platform/mac/mathml/presentation/subsup-expected.png:
platform/mac/mathml/presentation/subsup-expected.txt:

3:00 PM Changeset in webkit [82776] by jeffm@apple.com

5 edits in trunk/Source/WebKit2

2011-04-02 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Specify the certificate store in WKBundleSetClientCertificate()
https://bugs.webkit.org/show_bug.cgi?id=57707

Include the name of the system certificate store that the client certificate came from in WKBundleSetClientCertificate().

The PCCERT_CONTEXT for the client certificate we create from the message from the UI process doesn't contain enough information to actually use it in a request, we need to get the real certificate from the certificate store (which is typically the "MY" store).

WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: (WKBundleSetClientCertificate): Add certificateSystemStoreName to parameters.
WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Add certificateSystemStoreName to WKBundleSetClientCertificate() parameters.
WebProcess/InjectedBundle/InjectedBundle.h: Add certificateSystemStoreName to setClientCertificate() parameters.
WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: (WebKit::InjectedBundle::setClientCertificate): Read the real certificate from the certificate store.

2:37 PM Changeset in webkit [82775] by mitz@apple.com

21 edits in trunk

Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

rendering/RenderBlockLineLayout.cpp:

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
platform/mac/mathml/presentation/fractions-expected.checksum:
platform/mac/mathml/presentation/fractions-expected.png:
platform/mac/mathml/presentation/fractions-expected.txt:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/mac/mathml/presentation/roots-expected.checksum:
platform/mac/mathml/presentation/roots-expected.png:
platform/mac/mathml/presentation/roots-expected.txt:
platform/mac/mathml/presentation/row-alignment-expected.checksum:
platform/mac/mathml/presentation/row-alignment-expected.png:
platform/mac/mathml/presentation/row-alignment-expected.txt:
platform/mac/mathml/presentation/subsup-expected.checksum:
platform/mac/mathml/presentation/subsup-expected.png:
platform/mac/mathml/presentation/subsup-expected.txt:

1:56 PM Changeset in webkit [82774] by commit-queue@webkit.org

7 edits in trunk

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

platform/gtk/Skipped: unskip test that accesses shadowRoot

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):

1:30 PM Changeset in webkit [82773] by weinig@apple.com

5 edits in trunk/Source/WebKit2

2011-04-02 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Implement WKBundleFrameHasHorizontalScrollbar/WKBundleFrameHasVerticalScrollbar
<rdar://problem/9225772>
https://bugs.webkit.org/show_bug.cgi?id=57709

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameHasHorizontalScrollbar): (WKBundleFrameHasVerticalScrollbar):
WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::hasHorizontalScrollbar): (WebKit::WebFrame::hasVerticalScrollbar):
WebProcess/WebPage/WebFrame.h:

12:22 PM Changeset in webkit [82772] by commit-queue@webkit.org