⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 4, 2011:

10:38 PM Changeset in webkit [82906] by weinig@apple.com
  • 22 edits
    1 delete in trunk

Remove duplicate API from WKContext
<rdar://problem/8727879>
​https://bugs.webkit.org/show_bug.cgi?id=57815

Reviewed by Brian Weinstein.

Source/WebKit2:

  • Remove WKContextClearResourceCaches and WKContextClearApplicationCache in favor of their more modern counterparts WKResourceCacheManagerClearCacheForAllOrigins and WKApplicationCacheManagerDeleteAllEntries.
  • Expand clearing functionality of WKResourceCacheManager by adding type of resources to clear.
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Remove clearing bools.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toResourceCachesToClear):
Update for new name of enum.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:

Remove WKContextClearResourceCaches and WKContextClearApplicationCache.

  • UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):

  • UIProcess/API/C/WKResourceCacheManager.h:

Add WKResourceCachesToClear enum and use it in the clearing functions.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.messages.in:

Remove clearing functions and setting of bools for clear on launch.

  • UIProcess/WebFullScreenManagerProxy.cpp:

Remove unnecessary #include.

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.messages.in:

Add enum parameter describing what type of caches to clear.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearResourceCaches):

  • WebProcess/WebProcess.h:

No longer need to use opaque type now that it is not a message receiver.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.

10:33 PM Changeset in webkit [82905] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

2011-04-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82876.
​http://trac.webkit.org/changeset/82876
​https://bugs.webkit.org/show_bug.cgi?id=57816

Caused a lot of test crashes (Requested by tkent on #webkit).

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::fastMallocMatchValidationValue): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree):
  • wtf/Platform.h:
10:26 PM Changeset in webkit [82904] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Kent Tamura <​tkent@chromium.org>

Add a case label which was unexpectedly removed in r82899.
​https://bugs.webkit.org/show_bug.cgi?id=50661

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
10:21 PM Changeset in webkit [82903] by mitz@apple.com
  • 50 edits
    8 adds in trunk

<rdar://problem/7709452> Implement Default Ruby Overhang Behavior
​https://bugs.webkit.org/show_bug.cgi?id=49334

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal.html

fast/ruby/overhang-vertical.html

This is a first cut at ruby overhang. It allows ruby text to hang over other
text of equal or smaller size. Two notable omissions are that max preferred
width computation was not patched, so it will overshoot, and that overhang
ignores the width of the adjoining text runs.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
of ruby runs for overhang.
(WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
compensate for overhang.
(WebCore::RenderBlock::findNextLineBreak): When encountering
a ruby run, increase the line width to account for the fact that overhang will be
collapsed.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
the adjoining renderer is text with equal or smaller font size.

  • rendering/RenderRubyRun.h:

(WebCore::toRenderRubyRun):

LayoutTests:

  • fast/ruby/overhang-horizontal-expected.checksum: Added.
  • fast/ruby/overhang-horizontal-expected.png: Added.
  • fast/ruby/overhang-horizontal-expected.txt: Added.
  • fast/ruby/overhang-horizontal.html: Added.
  • fast/ruby/overhang-vertical-expected.checksum: Added.
  • fast/ruby/overhang-vertical-expected.png: Added.
  • fast/ruby/overhang-vertical-expected.txt: Added.
  • fast/ruby/overhang-vertical.html: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/english-lr-text-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/mac/fast/ruby/ruby-length-expected.checksum:
  • platform/mac/fast/ruby/ruby-length-expected.png:
  • platform/mac/fast/ruby/ruby-length-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac/fast/ruby/ruby-run-break-expected.png:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-expected.png:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac/fast/ruby/ruby-trailing-expected.png:
  • platform/mac/fast/ruby/ruby-trailing-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
9:58 PM Changeset in webkit [82902] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, Chromium expectations update for tests broken after r82899.

  • platform/chromium/test_expectations.txt:
9:41 PM Changeset in webkit [82901] by morrita@google.com
  • 8 edits in trunk/LayoutTests

2011-04-04 MORITA Hajime <​morrita@google.com>

Unreviewed expectations update following r82899.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
9:37 PM Changeset in webkit [82900] by ddkilzer@apple.com
  • 15 edits in trunk

<​http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
  • platform/mac/WebCoreSystemInterface.h:

(wkSetHTTPPipeliningMaximumPriority): Added function pointer
declaration.

  • platform/mac/WebCoreSystemInterface.mm:

(wkSetHTTPPipeliningMaximumPriority): Added function pointer.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
pipelining priority.

  • platform/network/cf/ResourceRequestCFNet.h:

(WebCore::toResourceLoadPriority): Renamed from
mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to
to handle Unresolved case.
(WebCore::toHTTPPipeliningPriority): Renamed from
mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to
handle Unresolved case.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use toResourceLoadPriority().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
use toHTTPPipeliningPriority(). Moved
shouldForceHTTPPipeliningPriorityHigh() check into the argument
of toHTTPPipeliningPriority() instead of hard-coding a
now-incorrect value.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().

WebKitLibraries:

  • WebKitSystemInterface.h:

(WKSetHTTPPipeliningMaximumPriority): Added declaration.
(WKExtractWordDefinitionTokenRangeFromContextualString): Added
missing declaration from r81890.
(WKShowWordDefinitionWindow): Ditto.
(WKHideWordDefinitionWindow): Ditto.

  • libWebKitSystemInterfaceLeopard.a: Updated.
  • libWebKitSystemInterfaceSnowLeopard.a: Updated.
7:01 PM Changeset in webkit [82899] by morrita@google.com
  • 23 edits
    2 adds in trunk

2011-04-04 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Convert <meter> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50661

Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Convert <meter> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50661

Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage):
  • html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren):
6:33 PM Changeset in webkit [82898] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-04-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti Koivisto.

Stop JSCell.h from including Structure.h
​https://bugs.webkit.org/show_bug.cgi?id=57809

  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject):
  • runtime/JSString.h:
  • runtime/ScopeChain.h:
  • runtime/Structure.h: (JSC::JSCell::isObject): (JSC::JSCell::isString): (JSC::JSCell::classInfo): (JSC::JSCell::createDummyStructure): (JSC::JSValue::needsThisConversion): (JSC::MarkStack::internalAppend):
  • runtime/StructureChain.h:
6:01 PM Changeset in webkit [82897] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Move to using FrameView::resize to handle changes in view size.

​https://bugs.webkit.org/show_bug.cgi?id=57805

5:58 PM Changeset in webkit [82896] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Send NPCocoaEventFlagsChanged events
​https://bugs.webkit.org/show_bug.cgi?id=57811
<rdar://problem/9215600>

  • Shared/WebEvent.h: (WebKit::WebEvent::capsLockKey): Add CapsLock modifier and getter.
  • Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent): Check for NSAlphaShiftKeyMask and set the CapsLockKey modifier.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::modifierFlags): Check for CapsLockKey and set NSAlphaShiftKeyMask.

(WebKit::isFlagsChangedEvent):
Return whether a given event is a Cocoa flags changed event.

(WebKit::initializeKeyboardEvent):
If this is a flags changed event, set the event type to NPCocoaEventFlagsChanged.

5:09 PM Changeset in webkit [82895] by Martin Robinson
  • 2 edits in trunk

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+ after r82876.

  • Source/autotools/symbols.filter: Update the symbol filter to include new symbols from WTF that DRT uses.
5:09 PM Changeset in webkit [82894] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Don't discard the backing stores of WKViews in the key window
​https://bugs.webkit.org/show_bug.cgi?id=57808
<rdar://problem/9110793>
<rdar://problem/9194284>
<rdar://problem/9222216>

  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setBackingStoreIsDiscardable): Add empty stub.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isBackingStoreDiscardable to true.

(WebKit::DrawingAreaProxyImpl::setBackingStoreIsDiscardable):
Set m_isBackingStoreDiscardable and schedule or stop the discard backing store timer.

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
Don't start the timer if m_isBackingStoreDiscardable is false.

  • UIProcess/DrawingAreaProxyImpl.h: Add m_isBackingStoreDiscardable.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): Mark the backing store as discardable if the view is hidden or if the containing window is not active.
4:40 PM Changeset in webkit [82893] by enne@google.com
  • 3 edits
    53 adds
    1 delete in trunk/LayoutTests

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, rolling out r82879.
​http://trac.webkit.org/changeset/82879

Trying to fix 10.6 layout test expectations broke 10.5

  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
4:31 PM Changeset in webkit [82892] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-04-04 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] don't write .checksum files if a fallback platform has an embedded checksum
​https://bugs.webkit.org/show_bug.cgi?id=57783

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
4:23 PM Changeset in webkit [82891] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-04-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Introduce EventDispatchMediator abstraction, which encapsulate all
non-trivial logic around firing a specific type of an event.
​https://bugs.webkit.org/show_bug.cgi?id=57562

Refactoring, covered by existing tests.

  • dom/Event.cpp: (WebCore::EventDispatchMediator::EventDispatchMediator): Added. (WebCore::EventDispatchMediator::~EventDispatchMediator): Added. (WebCore::EventDispatchMediator::dispatchEvent): Added. (WebCore::EventDispatchMediator::event): Added.
  • dom/Event.h: Added decl.
  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
  • dom/EventDispatcher.h: Updated decls.
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added. (WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
  • dom/KeyboardEvent.h: Updated decls
  • dom/Node.cpp: (WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator. (WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
4:19 PM Changeset in webkit [82890] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Cairo] Memory leak in RefPtrCairo
​https://bugs.webkit.org/show_bug.cgi?id=57758

No new tests. This just fixes a memory leak.

  • platform/graphics/cairo/RefPtrCairo.cpp: (WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
4:17 PM Changeset in webkit [82889] by enne@google.com
  • 23 edits
    2 deletes in trunk

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, rolling out r82880.
​http://trac.webkit.org/changeset/82880
​https://bugs.webkit.org/show_bug.cgi?id=50661

Meter elements not rendered in Chromium Linux layout tests.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, rolling out r82880.
​http://trac.webkit.org/changeset/82880
​https://bugs.webkit.org/show_bug.cgi?id=50661

Meter elements not rendered in Chromium Linux layout tests

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::create): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Removed.
  • html/shadow/MeterShadowElement.h: Removed.
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valueRatio): (WebCore::RenderMeter::barPartRect): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::shadowAttached):
4:11 PM Changeset in webkit [82888] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix clang build.

4:08 PM Changeset in webkit [82887] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Adjust the list of flaky tests based on NRWT on webkit mac using
a 35 second timeout by default.

  • platform/mac/test_expectations.txt:
3:49 PM Changeset in webkit [82886] by commit-queue@webkit.org
  • 20 edits in trunk

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=52058

Updated expected results after this patch fixes the set contenteditable issue.

  • fast/dom/HTMLElement/set-false-expected.txt:
  • fast/dom/HTMLElement/set-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
  • fast/dom/HTMLElement/set-true-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
which does NOT trigger layout and only checks the render style of usermodify. The latter
updates the layout first to make sure the render style syncs with DOM contenteditable
attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
are also updated in the patch. But a complete fix will follow up in bug 57244.

This patch fixes all the failed layout tests related to set contenteditable.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
  • dom/Node.cpp: (WebCore::Node::isContentEditable): (WebCore::Node::shouldUseInputMethod):
  • dom/Node.h:
  • html/HTMLElement.cpp:
  • html/HTMLElement.h:

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition):

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
3:37 PM Changeset in webkit [82885] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, run uninstall when cleaning to remove built files from WebKitBuild.

3:36 PM Changeset in webkit [82884] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove accidental change to Platform.h

3:33 PM Changeset in webkit [82883] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

2011-04-04 Jade Han <​jade.han@nokia.com>

Reviewed by Csaba Osztrogonác.

Symbian build fix.
​https://bugs.webkit.org/show_bug.cgi?id=54977

  • config.h:
3:25 PM Changeset in webkit [82882] by rolandsteiner@chromium.org
  • 15 edits
    2 adds in trunk/Source/WebCore

2011-04-04 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by NOBODY (OOPS!).

Bug 57689 - Extract scoping functionality from Document
​https://bugs.webkit.org/show_bug.cgi?id=57689

Moved selfOnlyRef (renamed to guardRef), element ID, image map
and accesss key functionalities from Document to a new base
class TreeScope.

TreeShared: made removedLastRef protected

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::destroyScope): (WebCore::Document::getElementById): (WebCore::Document::childrenChanged): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::attach): (WebCore::Document::detach):
  • dom/Document.h: (WebCore::Node::Node):
  • dom/DocumentOrderedMap.cpp: (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h:
  • dom/DOMAllInOne.cpp:
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument):
  • dom/Node.h:
  • dom/TreeScope.cpp: Added.
  • dom/TreeScope.h: Added.
  • platform/TreeShared.h: (WebCore::TreeShared::removedLastRef): made protected
3:20 PM Changeset in webkit [82881] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Add WKIconDatabase* headers to the WebKit2 export for Windows:

  • win/WebKit2Generated.make:

Rubberstamped by Adam Roben.

3:15 PM Changeset in webkit [82880] by morrita@google.com
  • 23 edits
    2 adds in trunk

2011-04-04 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <meter> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50661

Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <meter> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50661

Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage):
  • html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren):
3:08 PM Changeset in webkit [82879] by enne@google.com
  • 3 edits
    1 add
    53 deletes in trunk/LayoutTests

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, update Chromium Snow Leopard image baselines.

These were all minor font-related image differences.

  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
3:07 PM Changeset in webkit [82878] by Martin Robinson
  • 16 edits
    7 adds in trunk

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
​https://bugs.webkit.org/show_bug.cgi?id=31517

  • configure.ac: Update configure.ac to ensure that GL/GLX headers exist.

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
​https://bugs.webkit.org/show_bug.cgi?id=31517

Add WebGL support for the GTK+ bits of WebCore.

No new tests. This will be covered by the existing WebGL tests once
the bots are capable of running WebGL tests.

  • GNUmakefile.am: Added new files required for WebGL support.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not yet support accelerated compositing.
  • platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as a framework for GTK+.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo. (WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added. (WebCore::GraphicsContext3D::getImageData): Added. (WebCore::GraphicsContext3D::paintToCanvas): Added.
  • platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension functions dynamically. They have different names across the different vendors' GL implementations. (WebCore::lookupOpenGLFunctionAddress): Added (WebCore::openGLFunctionTable): Added (WebCore::initializeOpenGLShims): Added
  • platform/graphics/cairo/OpenGLShims.h: Added.
  • platform/graphics/gtk/DrawingBufferGtk.cpp: Added. (WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo. (WebCore::DrawingBuffer::~DrawingBuffer): Ditto. (WebCore::DrawingBuffer::didReset): Ditto. (WebCore::DrawingBuffer::platformColorBuffer): Ditto.
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added. (WebCore::GraphicsContext3D::create): Initial implementation. (WebCore::GraphicsContext3D::GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::makeContextCurrent): Ditto. (WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
  • platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added. (sharedDisplay): Added this shared display which is required by some display drivers. (WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers. (WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto. (WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL context given the current environment. (WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer. (WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation. (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto. (WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
  • platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation. (WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than the private bits that are specific to the Apple port.

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
​https://bugs.webkit.org/show_bug.cgi?id=31517

Add support for toggling WebGL at runtime when it's enabled.

  • webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL is not enabled, it's a no-op. (webkit_web_settings_class_init): Update to support enable-webgl. (webkit_web_settings_set_property): Ditto. (webkit_web_settings_get_property): Ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Ditto.

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
​https://bugs.webkit.org/show_bug.cgi?id=31517

Add support to the DRT for turning on WebGL when a layout tests requests it.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
3:02 PM Changeset in webkit [82877] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a weak-handle-related leak in RegisterFile
​https://bugs.webkit.org/show_bug.cgi?id=57793

  • interpreter/RegisterFile.cpp: Nixed leaky GlobalObjectNotifier.
  • interpreter/RegisterFile.h: (JSC::RegisterFile::GlobalObjectOwner::finalize): (JSC::RegisterFile::RegisterFile): Replaced GlobalObjectNotifier with a per-RegisterFile weak handle owner, which does not leak.
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::set): Allow set() to take a context argument, since RegisterFile now needs this. (Seems like it was an accidental omission all along.)
2:59 PM Changeset in webkit [82876] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-04-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make malloc validation useful
​https://bugs.webkit.org/show_bug.cgi?id=57502

This patch changes FAST_MALLOC_MATCH_VALIDATION with a general
corruption check that tags the beginning and end of all allocations
to check for write overflows and overwrites the contents of
memory on free in order to (hopefully) show up use-after-free issues
sooner.

We also turn it on by default for debug builds.

  • JavaScriptCore.exp:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate):
  • wtf/Platform.h:
2:40 PM Changeset in webkit [82875] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
​https://bugs.webkit.org/show_bug.cgi?id=57790

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::updateWeakHandles): Updated for rename.
  • collector/handles/HandleHeap.h: Removed comment claiming that this function should only be called during teardown, because it's actually called after every GC pass.
  • runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): Updated for rename.
2:29 PM Changeset in webkit [82874] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Standardized handling of handles for immediate values
​https://bugs.webkit.org/show_bug.cgi?id=57788

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Don't check for null or non-cell values here, because our write barrier guarantees that such values are not in the weak list.

(JSC::HandleHeap::writeBarrier): Standardized on checking for null before
checking for cell, and on using early return instead of if/else.

  • collector/handles/HandleHeap.h: (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): Ditto.
2:17 PM Changeset in webkit [82873] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of WebContext::process() in more places
​https://bugs.webkit.org/show_bug.cgi?id=57787

Migrate calls to WebContext::process() over to sendToAllProcesses and
sendToAllProcessesRelaunchingThemIfNecessary.

Add FIXMEs for things that need to be fixed in order to support multiple web processes.


  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel):
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
  • UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
  • UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
  • UIProcess/WebGeolocationManagerProxy.cpp: (WebKit::WebGeolocationManagerProxy::providerDidChangePosition): (WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport):
  • UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
  • UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): (WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
2:09 PM Changeset in webkit [82872] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.

Removed a redundant variable from HandleHeap
​https://bugs.webkit.org/show_bug.cgi?id=57786


Forgot to commit the file that actually removes the data member!


  • collector/handles/HandleHeap.h:
2:04 PM Changeset in webkit [82871] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a redundant variable from HandleHeap
​https://bugs.webkit.org/show_bug.cgi?id=57786


We don't need a specific variable to indicate that we're in the middle
of the finalization phase, since m_nextToFinalize already does this.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier):
1:56 PM Changeset in webkit [82870] by ap@apple.com
  • 16 edits in trunk/Source

Reviewed by Dan Bernstein.

REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>

<rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys

  • UIProcess/API/mac/WKView.mm: (-[WKView flagsChanged:]): Ported from WebHTMLView. (-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]): AppKit isn't happy about attempts to interpret NSFlagsChanged, but WK2 lacked the check.
1:48 PM Changeset in webkit [82869] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build warning.

  • WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
1:45 PM Changeset in webkit [82868] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix, part III

  • WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
1:42 PM Changeset in webkit [82867] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build.

  • WebCore.exp.in:
1:40 PM Changeset in webkit [82866] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed Finalizer => WeakHandleOwner (in preparation for adding a reachability callback)
​https://bugs.webkit.org/show_bug.cgi?id=57775


Also renamed noFinalizer => emptyWeakOwner, since this is really an
optimization for a weak owner with empty callbacks.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Updated for renames. Removed redundant initialization of m_nextToFinalize. Moved deletion check inside weak owner check, since the weak owner can't delete the node if there is no weak owner!
  • collector/handles/HandleHeap.h: (JSC::WeakHandleOwner::~WeakHandleOwner): (JSC::HandleHeap::makeWeak): Updated for renames.

(JSC::HandleHeap::hasWeakOwner): Changed getFinalizer to hasWeakOwner,
to clarify this function's role in assertions.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::weakOwner):
(JSC::HandleHeap::Node::weakOwnerContext):
(JSC::HandleHeap::Node::emptyWeakOwner):

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollectedNotifier):
  • interpreter/RegisterFile.h:
  • runtime/WeakGCMap.h:
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set): Updated for renames.
1:39 PM Changeset in webkit [82865] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-04 Adrienne Walker <​enne@google.com>

Unreviewed, mark revoke-blob-url.html as CRASH for Chromium on Win.

  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [82864] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/696

Merge 82222 - 2011-03-29 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
​https://bugs.webkit.org/show_bug.cgi?id=57266

Add test for getComputedStyle(...).counterIncrement without a counter.

  • fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt: Added.
  • fast/css/getComputedStyle/counterIncrement-without-counter.html: Added.

2011-03-29 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
​https://bugs.webkit.org/show_bug.cgi?id=57266

Add null check to counterToCSSValue.

Test: fast/css/getComputedStyle/counterIncrement-without-counter.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::counterToCSSValue):

TBR=​eae@chromium.org

1:35 PM Changeset in webkit [82863] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-04 David Dorwin <​ddorwin@chromium.org>

Reviewed by David Levin.

Chromium Mac crashes when entering fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=57483

Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.

  • WebCore.gyp/WebCore.gyp:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
1:32 PM Changeset in webkit [82862] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix, part II

  • WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and

PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).

1:27 PM Changeset in webkit [82861] by sfalken@apple.com
  • 9 edits in trunk

Remove unused AnalyzeWithLargeStack code from Windows build files
​https://bugs.webkit.org/show_bug.cgi?id=57771

Reviewed by Adam Roben.

This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCorePreBuild.cmd:

Source/WebKit/win:

  • WebKit.vcproj/WebKitLibPreBuild.cmd:

Source/WebKit2:

  • win/WebKitPreBuild.cmd:

WebKitLibraries:

  • win/tools/vsprops/common.vsprops:
1:26 PM Changeset in webkit [82860] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

2011-04-01 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

[CG] Do not accelerate small canvases
​https://bugs.webkit.org/show_bug.cgi?id=57596

No new tests. No outward behavior changes.

  • platform/graphics/cg/ImageBufferCG.cpp:
1:21 PM Changeset in webkit [82859] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private

so that WebKit can #include them.

1:14 PM Changeset in webkit [82858] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix WinCE build.

1:12 PM Changeset in webkit [82857] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the Windows build.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::setShouldPaintNativeControls):

12:40 PM Changeset in webkit [82856] by andersca@apple.com
  • 5 edits in trunk/Source

2011-04-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Make it easier to send a message to all processes in a context
​https://bugs.webkit.org/show_bug.cgi?id=57776

Add WebContext::sendToAllProcesses and WebContext::sendToAllProcessesRelaunchingThemIfNecessary
as a first step towards getting rid of WebContext::process() and getting rid of a class of crashers
where WebContext::process() is null.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::initializeHistoryClient): (WebKit::WebContext::languageChanged): (WebKit::WebContext::setAlwaysUsesComplexTextCodePath): (WebKit::WebContext::registerURLSchemeAsEmptyDocument): (WebKit::WebContext::registerURLSchemeAsSecure): (WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme): (WebKit::WebContext::setCacheModel): (WebKit::WebContext::setDefaultRequestTimeoutInterval): (WebKit::WebContext::clearResourceCaches): (WebKit::WebContext::clearApplicationCache): (WebKit::WebContext::setEnhancedAccessibility): (WebKit::WebContext::startMemorySampler): Use sendToAllProcesses.

(WebKit::WebContext::stopMemorySampler):
Use sendToAllProcesses. This is a slight policy change where we now create a sandbox extension even
if there's no process around. Since this is a debugging tool it seems OK to do this.

  • UIProcess/WebContext.h: Get rid of hasValidProcess.

(WebKit::WebContext::sendToAllProcesses):
If we have a process and we can send messages to it, then do so.

(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
Relaunch the web process and send the message.

  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::deleteCookiesForHostname): (WebKit::WebCookieManagerProxy::deleteAllCookies): (WebKit::WebCookieManagerProxy::startObservingCookieChanges): (WebKit::WebCookieManagerProxy::stopObservingCookieChanges): (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Use sendToAllProcesses and sendToAllProcessesRelaunchingThemIfNecessary.
12:33 PM Changeset in webkit [82855] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Delete mt.dep files when doing a clean build due to .vsprops file changes

Apparently this is yet another file that Visual Studio can't figure out it needs to rebuild.

Fixes <​http://webkit.org/b/57777> r82850 failed to build on Windows Debug (Build)

Reviewed by Brian Weinstein.

(main): Added dep to the list of extensions we look for when choosing files to delete.

12:33 PM Changeset in webkit [82854] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Move a teensy bit of non-Mac-specific code up to LayerTreeHostCA

Fixes <​http://webkit.org/b/57774> LayerTreeHostCA should know how to flip the root layer

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): Cross-platformized and moved some code here...

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize): ...from here.

12:30 PM Changeset in webkit [82853] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

WK2: Reproducible crash when dragging out of or over Safari window.
​https://bugs.webkit.org/show_bug.cgi?id=57654
<rdar://problem/9139755>

Reviewed by Darin Adler.

AppKit does not retain the owner given to the pasteboard, therefore we
need to give the ownership of the retained pointer to NSPasteboard.
Also, dragImage will release the NSFilePromiseDragSource object, therefore
we retain it before calling dragImage to be able to control its lifetime.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Passing ownership
of the pointer to AppKit when providing the owner pointer to the NSPasteboard
object.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformDragEnded): Retaining the NSFilePromiseDragSource
since dragImage will release it.

12:19 PM Changeset in webkit [82852] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Jer Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

WebKit2: No "open in preview" contextual menu item for PDFs
​https://bugs.webkit.org/show_bug.cgi?id=57527

Add support for opening a PDF in the associated application from the
context menu.

  • UIProcess/API/mac/PDFViewController.mm: (_applicationInfoForMIMEType): Added, copied from WebKit/WebPDFView.mm (-[WKPDFView _openWithFinder:]): Added. (-[WKPDFView hitTest:]): Added, copied from WebKit/WebPDFView.mm. (-[WKPDFView menuForEvent:]): Added, adapted from WebKit/WebPDFVie.mm. (-[WKPDFView validateUserInterfaceItem:]): Added.
12:14 PM Changeset in webkit [82851] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement support for temporary files.

​https://bugs.webkit.org/show_bug.cgi?id=57772

11:54 AM Changeset in webkit [82850] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix Windows build warning.
​https://bugs.webkit.org/show_bug.cgi?id=57767

Reviewed by Brian Weinstein.

  • win/tools/vsprops/common.vsprops:
11:41 AM Changeset in webkit [82849] by oliver@apple.com
  • 34 edits in trunk/Source

2011-04-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make StructureChain GC allocated
​https://bugs.webkit.org/show_bug.cgi?id=56695

Make StructureChain GC allocated, and make the various owners
mark it correctly.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures): (JSC::PolymorphicAccessStructureList::markAggregate): (JSC::Instruction::Instruction):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::markAggregate):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initPutByIdTransition):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
  • collector/handles/Handle.h: (JSC::HandleConverter::operator->): (JSC::HandleConverter::operator*):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::getPolymorphicAccessStructureListSlot): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeChain):
  • runtime/JSObject.h: (JSC::JSObject::putDirectInternal): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::get): (JSC::JSPropertyNameIterator::markChildren):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):
  • runtime/JSZombie.h:
  • runtime/MarkStack.h: (JSC::MarkStack::append):
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::sweep):
  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition):
  • runtime/Structure.h: (JSC::Structure::markAggregate):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): (JSC::StructureChain::~StructureChain): (JSC::StructureChain::markChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::create): (JSC::StructureChain::createStructure):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->):

2011-04-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make StructureChain GC allocated
​https://bugs.webkit.org/show_bug.cgi?id=56695

Update for new Structure marking function

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren):
11:29 AM Changeset in webkit [82848] by commit-queue@webkit.org
  • 13 edits in trunk

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
​https://bugs.webkit.org/show_bug.cgi?id=57572

Unskip passed tests.

  • platform/mac-wk2/Skipped:

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
​https://bugs.webkit.org/show_bug.cgi?id=57572

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode): (WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
  • Shared/WebPreferencesStore.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAllowFileAccessFromFileURLs):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-04 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
​https://bugs.webkit.org/show_bug.cgi?id=57572

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
11:00 AM Changeset in webkit [82847] by pfeldman@chromium.org
  • 13 edits in trunk

2011-04-04 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for the enumerated types in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=57761

  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-pause-on-exception.html:

2011-04-04 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for the enumerated types in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=57761

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::setInitialScriptContent): (WebCore::InspectorResourceAgent::setInitialXHRContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/generate-inspector-idl:
10:47 AM Changeset in webkit [82846] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-04 Jon Lee <​jonlee@apple.com>

Reviewed by Eric Seidel.

add some directories to .gitignore (and svn:ignore) when opening projects in xcode4
​https://bugs.webkit.org/show_bug.cgi?id=57646

  • .gitignore: added xcode 4 related project and workspace directories that are not needed for checkin
10:32 AM Changeset in webkit [82845] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorRuntimeAgent should not depend on Page
​https://bugs.webkit.org/show_bug.cgi?id=57759

Descendants of InspectorRuntimeAgent should implement a method providing access to the default
inspected state used for console evaluations.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents. (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h: (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
10:29 AM Changeset in webkit [82844] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-04 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] DumpRenderTree breaks compilation in some uClibc environments
​https://bugs.webkit.org/show_bug.cgi?id=57602

  • DumpRenderTree/qt/main.cpp: (get_backtrace):
10:05 AM Changeset in webkit [82843] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-04-04 Yong Li <​yoli@rim.com>

Reviewed by Antonio Gomes.

​https://bugs.webkit.org/show_bug.cgi?id=55969
Add a test that verifies history scroll position is restored
when WebKit goes forward from an unreachable URL error page.
(Error page handling is only supported by Qt DRT.)

  • platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt: Added.
  • platform/qt/fast/history/back-to-unreachable-url-then-forward.html: Added.
  • platform/qt/fast/history/resources/check-scroll-position.html: Added.

2011-04-04 Yong Li <​yoli@rim.com>

Reviewed by Antonio Gomes.

​https://bugs.webkit.org/show_bug.cgi?id=55969
Fix the issue that document state is not saved when
going backward and ending up with error page.

Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html

(For manual test, load a non-existent html first, then load
fast/history/resources/check-scroll-position.html, then go
back and go forward. If it doesn't show "SUCCESS" at the bottom
of the page, your browser has failed the test)

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
9:51 AM Changeset in webkit [82842] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, add new LayoutTestController method stub to wx.

9:36 AM Changeset in webkit [82841] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test from the win-wk2 skipped list that does not exist.

fast/js/navigator-mimeTypes-length.html was changed and moved to plugins in r71651.

  • platform/win-wk2/Skipped:
9:20 AM Changeset in webkit [82840] by jberlin@webkit.org
  • 1 edit
    13 adds in trunk/LayoutTests

[Windows 7 WebKit2 Release Tests] 6 tests failing since being removed from the mac-wk2
skipped list in r82625.
​https://bugs.webkit.org/show_bug.cgi?id=57705

Unreviewed, addd win-wk2 expected results for the tests in order to get the bots green.

  • platform/win-wk2/editing: Added.
  • platform/win-wk2/editing/selection: Added.
  • platform/win-wk2/editing/selection/after-line-break-expected.txt: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/win-wk2/fast/repaint: Added.
  • platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

Apparently the pixel results are similar enough to the win expected pixel results that no
special pixel results need to be added for win-wk2.

  • platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
8:56 AM Changeset in webkit [82839] by beidson@apple.com
  • 11 edits
    2 adds in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=57683
Flesh out WK2 Icon Database API

Reviewed by Darin Adler.

For now the new API will add a client interface where the WK1 version used NSNotifications.

If we decide we'd like the granularity of specific callback functions later,
they can easily be added on.

Project file nonsense:

  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add a WKIconDatabaseClient and some new API:

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):

  • UIProcess/API/C/WKIconDatabase.h:
  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryGetCGImageForURL): Renamed to "try" for subtle clarification.

  • UIProcess/API/C/cg/WKIconDatabaseCG.h:

Implementations for the new APIs:

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::retainIconForPageURL): Remove excessive logging.
(WebKit::WebIconDatabase::releaseIconForPageURL): Ditto.
(WebKit::WebIconDatabase::imageForPageURL):
(WebKit::WebIconDatabase::removeAllIcons):
(WebKit::WebIconDatabase::checkIntegrityBeforeOpening):
(WebKit::WebIconDatabase::initializeIconDatabaseClient):
(WebKit::WebIconDatabase::didImportIconURLForPageURL): Dispatch a client callback,

much like the WK1 API uses notifications.

(WebKit::WebIconDatabase::didImportIconDataForPageURL): Ditto.
(WebKit::WebIconDatabase::didChangeIconForPageURL): Ditto.
(WebKit::WebIconDatabase::didRemoveAllIcons): Ditto.

  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabaseClient.cpp: Added.

(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):

  • UIProcess/WebIconDatabaseClient.h: Added.
8:47 AM Changeset in webkit [82838] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark filesystem-reference.html as CRASH PASS on chromium.

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [82837] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix make distcheck for 1.4.0
​https://bugs.webkit.org/show_bug.cgi?id=57750

Added a missing header file to the Makefile

  • GNUmakefile.am:
8:09 AM Changeset in webkit [82836] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove gradientLimit.svg and 2d.text.draw.align.end.ltr.html from test expectations.

  • platform/chromium/test_expectations.txt:
8:01 AM Changeset in webkit [82835] by Martin Robinson
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81812

7:52 AM Changeset in webkit [82834] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk/po

Merging r81772

7:34 AM Changeset in webkit [82833] by Martin Robinson
  • 5 edits in trunk

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=55826

  • http/tests/plugins/resources/dump-post.pl: Instead of just printing out the "keywords" parameter, print out the POSTDATA parameter as well. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA for more recent versions of the module.
  • platform/gtk/Skipped: Unskip the test which is now passing.

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.
7:27 AM Changeset in webkit [82832] by caseq@chromium.org
  • 11 edits in trunk

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] add notifications on panels shown/hidden
​https://bugs.webkit.org/show_bug.cgi?id=57752

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.showPanel):
  • http/tests/inspector/resources/extension-main.js: (showPanel):
  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] add notifications on panels shown/hidden
​https://bugs.webkit.org/show_bug.cgi?id=57752

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelImpl):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyPanelShown): (WebInspector.ExtensionServer.prototype.notifyPanelHidden):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide):
7:23 AM Changeset in webkit [82831] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
​https://bugs.webkit.org/show_bug.cgi?id=54633

Remove use of legacy editing positions when positioning keyboard-driven context
menus. Simplify the code greatly.

  • webkit/webkitwebview.cpp: (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates the context menu position. (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
7:17 AM Changeset in webkit [82830] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: search in resources panel is broken.
​https://bugs.webkit.org/show_bug.cgi?id=57631

Search in resources panel should trigger source frame content load.

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/SearchController.js: (WebInspector.SearchController.prototype.handleShortcut): (WebInspector.SearchController.prototype.focusSearchField):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype._ensureContentLoaded): (WebInspector.SourceFrame.prototype.performSearch):
7:15 AM Changeset in webkit [82829] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark xhr-breakpoints as CRASH PASS on chromium win debug.

  • platform/chromium/test_expectations.txt:
7:01 AM WebKitGTK edited by plaes@plaes.org
Updated outdated Gentoo information. (diff)
6:53 AM Changeset in webkit [82828] by eric@webkit.org
  • 9 edits
    1 add in trunk/Source/WebCore

2011-04-03 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split out UnicodeBidi enum into its own header (to allow use in platform)
​https://bugs.webkit.org/show_bug.cgi?id=57722

unicode-bidi is a CSS concept. However the same concept is really needed throughout
the bidi code in platform as well. So I'm moving the enum to platform.
The only part of the enum which doesn't make much sense to platform/ is "normal".

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:
  • platform/text/UnicodeBidi.h: Added.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
6:40 AM Changeset in webkit [82827] by podivilov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, udpate chromium-linux test expectations after r82786.

  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
6:28 AM Changeset in webkit [82826] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add chromium-linux expectation for the new test added in r82781.

  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
6:00 AM Changeset in webkit [82825] by podivilov@chromium.org
  • 1 edit
    45 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium-linux test expectations after r82783.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
5:40 AM Changeset in webkit [82824] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
​https://bugs.webkit.org/show_bug.cgi?id=57749

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): (WebInspector.TextEditorMainPanel.prototype._paintLine):
5:04 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
4:52 AM Changeset in webkit [82823] by podivilov@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add chromium expectations for the new test added in r82781.

  • platform/chromium-mac-leopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
4:33 AM Changeset in webkit [82822] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
​https://bugs.webkit.org/show_bug.cgi?id=48525

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
4:25 AM Changeset in webkit [82821] by mario@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-04 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed. Unskipped test and added GTK-specific new baseline.

  • platform/gtk/Skipped: Skipped passing test.
  • platform/gtk/accessibility/aria-roles-expected.txt: Added.
4:08 AM Changeset in webkit [82820] by podivilov@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove chromium expectations added by mistake in r82815.

  • platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
4:01 AM Changeset in webkit [82819] by podivilov@chromium.org
  • 1 edit
    90 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, delete duplicate baselines added in r82812.

3:59 AM Changeset in webkit [82818] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
​https://bugs.webkit.org/show_bug.cgi?id=57632

Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.appropriateSelectorFor):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.addBlankSection):
  • inspector/front-end/utilities.js:
3:56 AM Changeset in webkit [82817] by podivilov@chromium.org
  • 46 edits
    45 moves
    90 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix bad rebaseline in r82812.

3:27 AM Changeset in webkit [82816] by podivilov@chromium.org
  • 2 edits in trunk/Tools

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix exception in rebaseline tool.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3:18 AM Changeset in webkit [82815] by podivilov@chromium.org
  • 3 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, udpate chromium test expectations after r82786.

  • platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
3:10 AM Changeset in webkit [82814] by caseq@chromium.org
  • 6 edits in trunk

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Followup to an incomplete commit in r82806.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane): (WebInspector.ExtensionSidebarPane.prototype.setPage): (WebInspector.ExtensionSidebarPane.prototype._setObject):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onCreateSidebarPane): (WebInspector.ExtensionServer.prototype.createClientIframe): (WebInspector.ExtensionServer.prototype._onSetSidebarContent):

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Followup to an incomplete commit in r82806.

  • inspector/extensions/extensions.html:
3:06 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
3:04 AM Changeset in webkit [82813] by podivilov@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add chromium test expectations for tests added in r82780.

  • platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
2:54 AM Changeset in webkit [82812] by podivilov@chromium.org
  • 91 edits
    34 copies
    103 adds
    45 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium tests after r82783.

2:44 AM Changeset in webkit [82811] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Qt minimal build.

  • inspector/InspectorFrontendChannel.h:
2:38 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
2:38 AM Changeset in webkit [82810] by yurys@chromium.org
  • 7 edits
    1 copy in trunk/Source/WebCore

2011-04-01 Sergey Vorobyev <​sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Separate sendMessageToFrontend function
from InspectorClient to individual interface.
​https://bugs.webkit.org/show_bug.cgi?id=57548

Refactoring - covered with existing inspector tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendChannel.h: Added. (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
2:20 AM Changeset in webkit [82809] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Nico Weber <​thakis@chromium.org>

Reviewed by Eric Seidel.

Prefer a using directive over qualified names in LocalizedNumberICU.cpp
​https://bugs.webkit.org/show_bug.cgi?id=57742

Requested by ap in ​https://bugs.webkit.org/show_bug.cgi?id=57715

  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): (WebCore::numberFormatter): (WebCore::parseLocalizedNumber): (WebCore::formatLocalizedNumber):
2:14 AM Changeset in webkit [82808] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-04 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Breakpoints in the gutter stay static while editing the text
​https://bugs.webkit.org/show_bug.cgi?id=57616

2:03 AM Changeset in webkit [82807] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove obsolete doc generating code from CodeGenerator.
​https://bugs.webkit.org/show_bug.cgi?id=57748

  • inspector/CodeGeneratorInspector.pm:
1:56 AM Changeset in webkit [82806] by caseq@chromium.org
  • 8 edits in trunk

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
​https://bugs.webkit.org/show_bug.cgi?id=57622

Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionAPISchema.json:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onSetSidebarPage):

2011-04-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
​https://bugs.webkit.org/show_bug.cgi?id=57622

Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
1:50 AM Changeset in webkit [82805] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-04 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Main loop sources are leaked in RunLoopGtk
​https://bugs.webkit.org/show_bug.cgi?id=57618

  • Platform/RunLoop.h: (RunLoop::TimerBase::isRepeating):
  • Platform/gtk/RunLoopGtk.cpp: (RunLoop::~RunLoop): Make sure main loop is currently running before calling g_main_loop_quit(), RunLoop::stop() might have been called. (RunLoop::wakeUp): Use an idle source with default priority instead of a timeout one with a 0 interval. (RunLoop::TimerBase::clearTimerSource): New method to clear the timer. (RunLoop::TimerBase::destroyNotifyCallback): Destroy notify callback called when the source is destroyed to clear the timer. (RunLoop::TimerBase::timerFiredCallback): Use the same callback for repeating and no repeating timers. (RunLoop::TimerBase::start): g_source_attach() increments the source reference counter, so use GRefPtr to make sure the source is freed. (RunLoop::TimerBase::stop): Use clearTimerSource().
1:33 AM Changeset in webkit [82804] by loislo@chromium.org
  • 19 edits in trunk

2011-04-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce support of 'optional' flag for command arguments.
​https://bugs.webkit.org/show_bug.cgi?id=57698

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:

2011-04-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce support of 'optional' flag for command arguments.
​https://bugs.webkit.org/show_bug.cgi?id=57698

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::reloadPage):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/generate-inspector-idl:
1:08 AM Changeset in webkit [82803] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
​https://bugs.webkit.org/show_bug.cgi?id=57637

  • bindings/js/JSInjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptFor):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::createForPage): (WebCore::InjectedScriptManager::createForWorker): (WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor and it depends on which type of context we're inspecting(worker or page). (WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
  • inspector/InjectedScriptManager.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
12:16 AM Changeset in webkit [82802] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

V8StringCallback.cpp requires V8Binding.h
​https://bugs.webkit.org/show_bug.cgi?id=57699

No new tests required because of just adding header file.

  • bindings/scripts/CodeGeneratorV8.pm:

Apr 3, 2011:

11:41 PM Changeset in webkit [82801] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Adding a test of value sanitization for <input type=text>
​https://bugs.webkit.org/show_bug.cgi?id=57737

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/script-tests/input-value-sanitization.js: Add tests for type=text.
10:40 PM Changeset in webkit [82800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Clean duplicated files in WebCore_Sources
​https://bugs.webkit.org/show_bug.cgi?id=57741

No new tests, Only duplicated files were removed.

  • CMakeLists.txt:
9:13 PM Changeset in webkit [82799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Darin Adler.

Fix 2-space indentation introduced in bug 54706.
​https://bugs.webkit.org/show_bug.cgi?id=57740

No new tests - whitespace changes only.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Convert 2-space indentation to 4-space indentation.
8:09 PM Changeset in webkit [82798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Make CSSStyleApplyProperty non-copyable
​https://bugs.webkit.org/show_bug.cgi?id=57738

No new functionality added so no new tests required.

  • css/CSSStyleApplyProperty.h: Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
7:21 PM Changeset in webkit [82797] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

  • Shared/DictionaryPopupInfo.h:
7:13 PM Changeset in webkit [82796] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
​https://bugs.webkit.org/show_bug.cgi?id=57739

Reviewed by Maciej Stachowiak.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.

  • Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.

4:22 PM Changeset in webkit [82795] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
​https://bugs.webkit.org/show_bug.cgi?id=57733

Reviewed by Maciej Stachowiak.

The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn't expect to be called between
tests, and it references the layout test controller, which is null.

  • page/Frame.cpp:

(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn't changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.

12:17 PM Changeset in webkit [82794] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Try to make this test more robust.

  • fast/blockflow/broken-ideographic-font.html: Ensure that the font has been loaded before

letting the test finish.

5:37 AM Changeset in webkit [82793] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Teach InlineIterator how to work from any root, not just a RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=57726

For implementing bidi-unicode: isolate, we need to be able to run the
bidi algorithm over a subtree of inlines, not just from a block root.
This is the first step in making this possible.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::root): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
1:29 AM Changeset in webkit [82792] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <​eric@webkit.org>

Reviewed by Dan Bernstein.

Split out handling of trailing spaces from layoutInlineChildren
​https://bugs.webkit.org/show_bug.cgi?id=57432

There is much more we could split out from this function, but this is a start.

I suspect this is very hot code. Hopefully the compiler will do the right thing.
If it doesn't the Chromium PLT bots will tell us.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren):
12:54 AM Changeset in webkit [82791] by rniwa@webkit.org
  • 4 edits
    8 adds in trunk

2011-03-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
​https://bugs.webkit.org/show_bug.cgi?id=56771

The bug was caused by WebKit's not checking the existence of root editable element
in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
we should not run editing commands in a document without a body element editable because
doing so results in appending a non-body element to the document node.

Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
when there are no body element. Since StyleWithCSS is a document's state or property, we allow
execCommand('StyleWithCSS') even in a document without a body element.

WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
the selection when document.write("x") is ran and successfully inserts image.

Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.

Since Internet Explorer does not allow execCommand to run under design mode properly, we could
not test its behavior.

Tests: editing/editability/empty-document-delete.html

editing/editability/empty-document-justify-right.html
editing/editability/empty-document-stylewithcss.html
editing/execCommand/insert-image-with-selecting-document.html

  • editing/Editor.cpp: (WebCore::Editor::canEdit): Verify that the root editable element exists instead of just checking that selection endpoints are editable because selection endpoints could be document node without a body element in design mode and we don't want to consider such a document editable. (WebCore::Editor::canDelete): Ditto.
  • editing/EditorCommand.cpp: (WebCore::enabledInEditableText): Ditto. (WebCore::enabledInRichlyEditableText): Ditto. (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead of duplicating the code in order to fix the same bug.

2011-03-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
​https://bugs.webkit.org/show_bug.cgi?id=56771

Added tests to ensure WebKit does not crash when attempted to execute editing commands
in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
is executed with selection endpoints being document. WebKit should ignore such attempts
and should not crash.

  • editing/editability/empty-document-delete-expected.txt: Added.
  • editing/editability/empty-document-delete.html: Added.
  • editing/editability/empty-document-justify-right-expected.txt: Added.
  • editing/editability/empty-document-justify-right.html: Added.
  • editing/editability/empty-document-stylewithcss-expected.txt: Added.
  • editing/editability/empty-document-stylewithcss.html: Added.
  • editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
  • editing/execCommand/insert-image-with-selecting-document.html: Added.
Note: See TracTimeline for information about the timeline view.