Context Navigation

This change is pretty straight-forward. It's slighly unclear to me
whether this patch is correct w.r.t. the code in DocumentWriter. I've
added a FIXME comment, and I'll investigate that case more in the future.

Test: http/tests/security/contentSecurityPolicy/object-src-none.html

loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestPlugin):
page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::addDirective):
page/ContentSecurityPolicy.h:

2011-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP object-src should block plugin loads
https://bugs.webkit.org/show_bug.cgi?id=57283

http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.

9:39 PM Changeset in webkit [83140] by Beth Dakin

6 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=58009
Frame::scalePage() results in visual artifacts with scale factors less than 1
-and corresponding-
<rdar://problem/8683230>

Reviewed by Dan Bernstein.

Source/WebCore:

Fall into the case where we fill with a background base color when there is a page
scale factor that is less than 1.

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

fast/repaint/scale-page-shrink.html: Added.
platform/gtk/Skipped:
platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
platform/qt/Skipped:
platform/win/Skipped:

8:59 PM Changeset in webkit [83139] by commit-queue@webkit.org

11 edits in trunk

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984

Unskip passed tests.

platform/mac-wk2/Skipped:

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984

WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePageSizeAndMarginsInPixels):
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
WebKitTestRunner/InjectedBundle/LayoutTestController.h:

8:55 PM Changeset in webkit [83138] by crogers@google.com

4 edits in trunk/Tools

2011-04-06 Chris Rogers <crogers@google.com>

Reviewed by Tony Chang.

Add web audio support to DumpRenderTree (mac port)
https://bugs.webkit.org/show_bug.cgi?id=57969

DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setEncodedAudioDataCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsAudio): (LayoutTestController::setDumpAsAudio): (LayoutTestController::encodedAudioData): (LayoutTestController::setEncodedAudioData):
DumpRenderTree/mac/DumpRenderTree.mm: (dumpAudio): (dump):

8:49 PM Changeset in webkit [83137] by benjamin.poulain@nokia.com

9 edits in trunk

2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086

platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.

2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086

Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
from the LayoutTestController.

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086

Add the missing method.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

8:43 PM Changeset in webkit [83136] by tkent@chromium.org

2 edits in trunk/LayoutTests

2011-04-06 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectations for Geeza Pro and so on.

platform/chromium/test_expectations.txt:

8:34 PM Changeset in webkit [83135] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

2011-04-06 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
https://bugs.webkit.org/show_bug.cgi?id=57982

Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):

8:31 PM Changeset in webkit [83134] by jer.noble@apple.com

6 edits
2 adds in trunk

2011-04-06 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation does not change rate due to setRate().
https://bugs.webkit.org/show_bug.cgi?id=57919

media/video-set-rate-from-pause-expected.txt: Added.
media/video-set-rate-from-pause.html: Added.

2011-04-06 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation does not change rate due to setRate().
https://bugs.webkit.org/show_bug.cgi?id=57919

Test: media/video-set-rate-from-pause.html

The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
of the media; instead a subclass must do that work. So when setRate() is called,
inform a subclass through a new pure virtual updateRate() function that there's
work to be done.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added. Set the requested rate.

8:24 PM Changeset in webkit [83133] by kinuko@chromium.org

15 edits in trunk

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

configure.ac: Added QUOTA build flag

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

Configurations/FeatureDefines.xcconfig: Added QUOTA build flag

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

Configurations/FeatureDefines.xcconfig: Added QUOTA build flag

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
GNUmakefile.am: Added QUOTA build flag
WebCore.pri: Added QUOTA build flag

2011-04-06 Dai Mikurube <dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918

Scripts/build-webkit: Added QUOTA build flag

8:06 PM Changeset in webkit [83132] by mitz@apple.com

25 edits in trunk/LayoutTests

Correct results for the Geeza Pro metrics change.

platform/mac/fast/dom/52776-expected.checksum:
platform/mac/fast/dom/52776-expected.png:
platform/mac/fast/dom/52776-expected.txt:
platform/mac/fast/text/complex-text-opacity-expected.checksum:
platform/mac/fast/text/complex-text-opacity-expected.png:
platform/mac/fast/text/complex-text-opacity-expected.txt:
platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
platform/mac/fast/text/international/bidi-neutral-run-expected.png:
platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:

7:21 PM Changeset in webkit [83131] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, update Chromium expectations for failing test from r83075.

platform/chromium/test_expectations.txt:

6:47 PM Changeset in webkit [83130] by dpranke@chromium.org

2 edits in trunk/Tools

2011-04-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Adjust the apple webkit port's default timeout to match
old-run-webkit-tests at 35 seconds.

https://bugs.webkit.org/show_bug.cgi?id=37738

Scripts/webkitpy/layout_tests/port/mac.py:

6:37 PM Changeset in webkit [83129] by commit-queue@webkit.org

3 edits in trunk/Tools

2011-04-06 Scott Cameron <sccameron@rim.com>

Reviewed by Eric Seidel.

Remove global variable $httpdPath and replace with the return value of
getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
https://bugs.webkit.org/show_bug.cgi?id=53499

Scripts/run-iexploder-tests:
Scripts/webkitperl/httpd.pm:

6:13 PM Changeset in webkit [83128] by Stephanie Lewis

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57997
<rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
Cancel all enqueued events when detaching the Document the events cannot keep the Document
alive.

Reviewed by Darin Adler.

No change in functionality so no new tests.

dom/Document.cpp:

(WebCore::Document::detach):

dom/EventQueue.cpp:

(WebCore::EventQueue::cancelQueuedEvents):

dom/EventQueue.h:

6:04 PM Changeset in webkit [83127] by levin@chromium.org

2 edits in trunk/Websites/webkit.org

2011-04-06 David Levin <levin@chromium.org>

Reviewed by Ojan Vafai.

Augment style guidelines about meaningless parameters from text the unwritten rules email.
https://bugs.webkit.org/show_bug.cgi?id=55275

coding/coding-style.html:

6:02 PM Changeset in webkit [83126] by mitz@apple.com

21 edits in trunk

<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
https://bugs.webkit.org/show_bug.cgi?id=58002

Reviewed by Darin Adler.

Source/WebCore:

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
does not require the vertical metrics tweaks that were needed in Leopard. That the
tweaks were being applied went mostly unnoticed until r73993, because until then it
only affected cases where Geeza Pro was specified, not when it occurred as a fallback
font.

LayoutTests:

platform/mac/fast/dom/52776-expected.checksum:
platform/mac/fast/dom/52776-expected.png:
platform/mac/fast/dom/52776-expected.txt:
platform/mac/fast/text/complex-text-opacity-expected.txt:
platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
platform/mac/fast/text/international/bidi-neutral-run-expected.png:
platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:

5:20 PM Changeset in webkit [83125] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-04-06 Anders Bakken <agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] FrameLoaderClientQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40254

WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::postProgressStartedNotification): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem): (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::createFrame): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

5:07 PM Changeset in webkit [83124] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, update expectations for Chromium visited link test.
https://bugs.webkit.org/show_bug.cgi?id=58000

Apparently, this just hasn't been working for a while.

platform/chromium/test_expectations.txt:

4:52 PM Changeset in webkit [83123] by rolandsteiner@chromium.org

5 edits in trunk/Source/WebCore

2011-04-06 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 57994 - Move guardRef functionality back to Document
https://bugs.webkit.org/show_bug.cgi?id=57994

Move the relevant code parts from TreeScope back into Document.

No new tests. (no new functionality)

dom/Document.cpp: (WebCore::Document::removedLastRef):
dom/Document.h:
dom/TreeScope.cpp: (WebCore::TreeScope::destroyTreeScopeData):
dom/TreeScope.h:

4:41 PM Changeset in webkit [83122] by Simon Fraser

5 edits in trunk/Source/WebCore

2011-04-06 Ian Henderson <ianh@apple.com>

Reviewed by Simon Fraser, Antti Koivisto.

Fast path for parsing simple CSS values
https://bugs.webkit.org/show_bug.cgi?id=57964

Add functions to parse simple color or dimension values, skipping the
overhead of full CSS parsing.

Change parseValue to a static method to avoid unnecessary allocation
of a CSSParser in the fast case.

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Changed to use the new, static parseValue method.
css/CSSParser.cpp: (WebCore::isColorPropertyID): (WebCore::parseColorValue): Parses any color accepted by the existing parseColor() static method. We must handle color identifiers separately, since parseColor() will change 'red' into 'rgb(255, 0, 0)'. (WebCore::isSimpleLengthPropertyID): (WebCore::parseSimpleLengthValue): Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is false, or 'NN' is '0'). Returns false to fall back to the slow path. (WebCore::CSSParser::parseValue):
css/CSSParser.h:
css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue): Changed to use the new, static parseValue method.

4:38 PM Changeset in webkit [83121] by kevino@webkit.org

8 edits in trunk

Reviewed by Darin Adler.

Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.

https://bugs.webkit.org/show_bug.cgi?id=27551

4:27 PM Changeset in webkit [83120] by tony@chromium.org

2 edits in trunk/Tools

2011-04-06 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

teach run-webkit-tests to read checksums from png files
https://bugs.webkit.org/show_bug.cgi?id=57993

Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's no .checksum and look for the checksum in there.

4:20 PM Changeset in webkit [83119] by Simon Fraser

3 edits in trunk/Source/WebCore

2011-04-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto.

Some minor style resolution optimizations
https://bugs.webkit.org/show_bug.cgi?id=57996

A couple of minor optimizations to style-related code.

bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::putDelegate): Avoid calling cssPropertyName() twice when setting style on an element.

css/CSSStyleSelector.cpp: (WebCore::useSVGZoomRules): (WebCore::CSSStyleSelector::applyProperty): Avoid calling isSVGElement() for every property, since only a two properties care about it.

4:19 PM Changeset in webkit [83118] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-04-06 Ian Henderson <ianh@apple.com>

Reviewed by Antti Koivisto.

Unnecessary string allocation in CSSStyleDeclaration::setProperty
https://bugs.webkit.org/show_bug.cgi?id=57995

Pass the bool representing the property's importance directly instead
of constructing a string.

css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty):

4:08 PM Changeset in webkit [83117] by enne@google.com

1 edit
2 adds in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, rebaseline more Chromium mac tests after r83075.

platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.

4:06 PM Changeset in webkit [83116] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt][WK2][Symbian] Remove use of stack arrays with variable size
https://bugs.webkit.org/show_bug.cgi?id=57877

For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integers.

Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):

4:01 PM Changeset in webkit [83115] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
https://bugs.webkit.org/show_bug.cgi?id=57963

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

bindings/v8/V8Utilities.h: (WebCore::createFunctionOnlyCallback):
bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):

3:57 PM Rebaseline edited by scheib@chromium.org

Removed out of date switches for canaries / gpu bots / deps source (diff)

3:56 PM Changeset in webkit [83114] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.

platform/chromium/test_expectations.txt:

3:38 PM Changeset in webkit [83113] by bweinstein@apple.com

13 edits
1 move in trunk/Source

WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>

Reviewed by Adam Roben.

Source/WebCore:

Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.

WebCore.vcproj/WebCore.vcproj:
platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.

Source/WebKit/win:

Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
used in both WebKit and WebKit2.

WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
WindowsTouch.h: Removed.

Source/WebKit2:

Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.

The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
isn't over a scrollbar.

The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
X and Y are reversed because panning up -> moving the page down, and vice versa.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess

to initialize the gesture. The WebProcess returns whether or not we can start a pan
gesture from where we are.

(WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by

pan gesture.

(WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.

UIProcess/WebPageProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
(WebKit::WebView::WebView): Initialize two new variables.
(WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where

the gesture is beginning.

(WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.

UIProcess/win/WebView.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we

know which layer to scroll if the user pans), and determine whether or not we should allow
panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.

(WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture

started on.

(WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.

3:37 PM Changeset in webkit [83112] by commit-queue@webkit.org

4 edits in trunk

2011-04-06 David Dorwin <ddorwin@chromium.org>

Reviewed by David Levin.

Enable fullscreen layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=55726

Remove test_expectations override for fullscreen tests.

platform/chromium/test_expectations.txt:

2011-04-06 David Dorwin <ddorwin@chromium.org>

Reviewed by David Levin.

Enable fullscreen layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=55726

Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).

DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo):

3:27 PM Changeset in webkit [83111] by enne@google.com

2 edits
6 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, rebaseline Chromium Mac tests after r83075.

platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/nested-columns-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.

3:24 PM Changeset in webkit [83110] by jeffm@apple.com

4 edits in trunk/Source/WebKit2

2011-04-06 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=57989

Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.

Shared/API/c/WKString.cpp: (WKStringGetLength): Added. (WKStringGetCharactersPtr): Added.
Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
Shared/WebString.h: (WebKit::WebString::length): Added. (WebKit::WebString::characters): Added.

3:21 PM Changeset in webkit [83109] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-04-06 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Dock stays in front of Hulu.com full screen video output
https://bugs.webkit.org/show_bug.cgi?id=57988
<rdar://problem/9216260>

Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
-[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
setting the presentation options when exiting full screen, otherwise the dock won't
be restored correctly.

PluginProcess/mac/PluginProcessShim.mm: Remove some shim functions that aren't needed.

UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_preFullscreenAppPresentationOptions.

UIProcess/Plugins/PluginProcessProxy.h: Add m_preFullscreenAppPresentationOptions.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::enterFullscreen): Change the presentation options for the app.

(WebKit::PluginProcessProxy::exitFullscreen):
Restore the presentation options.

3:17 PM Changeset in webkit [83108] by alexis.menard@openbossa.org

16 edits in trunk/Source

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974

We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

No new tests needed, just a config flag rename.

features.pri:

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974

We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

No new tests needed, just a config flag rename.

Api/qwebkitplatformplugin.h:
WebCoreSupport/ChromeClientQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
WebCoreSupport/FullScreenVideoQt.h:
WebCoreSupport/QtPlatformPlugin.cpp:
WebCoreSupport/QtPlatformPlugin.h:
examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): (WebPlugin::createExtension):
examples/platformplugin/WebPlugin.h:
examples/platformplugin/platformplugin.pro:
examples/platformplugin/qwebkitplatformplugin.h:
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadHtml5Video):
tests/tests.pri:

3:15 PM Changeset in webkit [83107] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-04-06 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Stop JSObject::isUsingInlineStorage() from using the structure
https://bugs.webkit.org/show_bug.cgi?id=57986

Make the isUsingInlineStorage() implementation just look at
whether the property storage is inside the object.

runtime/JSObject.h: (JSC::JSObject::isUsingInlineStorage): (JSC::JSObject::JSObject):

3:10 PM Changeset in webkit [83106] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.

Rubber stamped by Geoff Garen.

runtime/JSImmediate.h:
runtime/JSValue.h:

3:02 PM Changeset in webkit [83105] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Tyler Close <tjclose@chromium.org>

Reviewed by Nate Chapin.

run-bindings-tests reference files out of sync with CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=57967

bindings/scripts/test/V8/V8TestCallback.cpp:

2:57 PM Changeset in webkit [83104] by mrowe@apple.com

3 edits in trunk/Source/WebKit2

Expose the original URL of a WKBackForwardListItem.

Reviewed by Darin Adler.

Needed for <rdar://problem/9074651>.

UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemCopyOriginalURL):

UIProcess/API/C/WKBackForwardListItem.h:

2:53 PM Changeset in webkit [83103] by scheib@chromium.org

2 edits
2 adds in trunk/LayoutTests

2011-04-06 Vincent Scheib <scheib@chromium.org>

Fixed GPU expectations for r80867

platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
platform/chromium/test_expectations.txt:

2:49 PM Changeset in webkit [83102] by commit-queue@webkit.org

4 edits in trunk/Source

2011-04-06 Asanka Herath <asanka@chromium.org>

Reviewed by Darin Fisher.

Add new TargetType: TargetIsFavicon

https://bugs.webkit.org/show_bug.cgi?id=57659

No new functionality added, so no additional tests.

platform/network/ResourceRequestBase.h:

2011-04-06 Asanka Herath <asanka@chromium.org>

Reviewed by Darin Fisher.

Add new TargetType: TargetIsFavicon

https://bugs.webkit.org/show_bug.cgi?id=57659

public/WebURLRequest.h:

2:47 PM Changeset in webkit [83101] by Adam Roben

2 edits in trunk/Tools

Add a "view leaks" link to builds on SnowLeopard Intel Leaks

Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page

Reviewed by David Kilzer.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
build's results directory here...
(ExtractTestResults.finished): ...from here.
(ExtractTestResultsAndLeaks): New class that's used by the leaks builder
(ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
leaks" link to point to Leaks Viewer for this build.
(TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
but it seemed good to add for consistency with BuildAndTestFactory.
(BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
(BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
that we'll get a "view leaks" link.

2:31 PM Changeset in webkit [83100] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] media tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=57983

platform/qt/Skipped: Disable all media tests until fix.

2:22 PM Changeset in webkit [83099] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57981

Reviewed by Simon Fraser.

Update the column count and width computation algorithm for CSS3 multi-column layout
to match the revised pseudo-algorithm in the latest draft of the spec.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):

2:08 PM Changeset in webkit [83098] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
https://bugs.webkit.org/show_bug.cgi?id=57965

Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
instead of marginStartForChild and marginEndForChild respectively.

Calling these two functions on RenderInline is okay because writing-mode cannot differ
from that of the containing block.

rendering/RenderBlockLineLayout.cpp: (WebCore::borderPaddingMarginStart): (WebCore::borderPaddingMarginEnd): (WebCore::inlineLogicalWidth):

1:55 PM Changeset in webkit [83097] by commit-queue@webkit.org

4 edits
2 deletes in trunk

2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83039.
http://trac.webkit.org/changeset/83039
https://bugs.webkit.org/show_bug.cgi?id=57978

introduced a new regression in conjunction to
ReplaceSelectionCommand (Requested by rniwa on #webkit).

editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
editing/inserting/insert-paragraph-separator-tab-span.html: Removed.

2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83039.
http://trac.webkit.org/changeset/83039
https://bugs.webkit.org/show_bug.cgi?id=57978

introduced a new regression in conjunction to
ReplaceSelectionCommand (Requested by rniwa on #webkit).

editing/EditingStyle.cpp: (WebCore::EditingStyle::init):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

1:52 PM Changeset in webkit [83096] by commit-queue@webkit.org

5 edits
2 adds in trunk

2011-04-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by David Levin.

Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
https://bugs.webkit.org/show_bug.cgi?id=27658

fast/events/select-element-expected.txt: Added to check PgUp/PgDown/Home/End keys are working correctly in SELECT tag.
fast/events/select-element.html: Added for expectation.

2011-04-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by David Levin.

Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
https://bugs.webkit.org/show_bug.cgi?id=27658

Test: fast/events/select-element.html

dom/SelectElement.cpp: (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines. (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index. (WebCore::nextSelectableListIndex): Implemented with nextValidIndex. And converted to a normal static function from a private function of SelectElement. (WebCore::previousSelectableListIndex): Implemented with nextValidIndex. And converted to a normal static function from a private function of SelectElement. (WebCore::firstSelectableListIndex): Returns the first selectable index. (WebCore::lastSelectableListIndex): Returns the last selectable index. (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast. (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.

dom/SelectElement.h: (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().

rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML. They can differ due to the minimum size imposed by RenderListBox.

1:47 PM Changeset in webkit [83095] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57975

Reviewed by Dan Bernstein.

The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
to just look at the style, so that it can find the InlineTextBox and not care that it's a child
of the link element and not the line box for the link element itself (since that line box got
culled).

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

1:44 PM Changeset in webkit [83094] by enne@google.com

5 edits
3 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, rebaseline Chromium Win tests after r83075.

platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
platform/chromium-win/fast/multicol/nested-columns-expected.png:
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:

1:37 PM Changeset in webkit [83093] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/win/fast/blockflow/text-orientation-basic-expected.txt

Rebaseline text orientation layout test on Windows.

1:35 PM Changeset in webkit [83092] by Csaba Osztrogonác

27 edits in trunk/LayoutTests

[Qt] Update platform specific expected results after r83075.

platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
platform/qt/editing/pasteboard/paste-text-011-expected.png:
platform/qt/editing/pasteboard/paste-text-011-expected.txt:
platform/qt/fast/css-generated-content/014-expected.checksum:
platform/qt/fast/css-generated-content/014-expected.png:
platform/qt/fast/css-generated-content/014-expected.txt:
platform/qt/fast/css/word-space-extra-expected.checksum:
platform/qt/fast/css/word-space-extra-expected.png:
platform/qt/fast/css/word-space-extra-expected.txt:
platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
platform/qt/tables/mozilla/bugs/bug2123-expected.png:
platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
platform/qt/tables/mozilla/bugs/bug4523-expected.png:
platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
platform/qt/tables/mozilla/core/bloomberg-expected.png:
platform/qt/tables/mozilla/core/bloomberg-expected.txt:
platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:

1:31 PM Changeset in webkit [83091] by beidson@apple.com

7 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size

Reviewed by Anders Carlsson.

../WebCore:

platform/graphics/BitmapImage.h:
platform/graphics/Image.h:

(WebCore::Image::getFirstCGImageRefOfSize):

platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the

first frame of the requested size.

../WebKit2:

UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching

CGImage in the icon.

UIProcess/API/C/cg/WKIconDatabaseCG.h:

1:29 PM Changeset in webkit [83090] by kevino@webkit.org

4 edits in trunk/Source

Reviewed by Kevin Ollivier.

[wx] Fix cursor handling so that we always call the chrome to set it.

https://bugs.webkit.org/show_bug.cgi?id=57972

1:17 PM Changeset in webkit [83089] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
https://bugs.webkit.org/show_bug.cgi?id=57975

platform/chromium/test_expectations.txt:

1:14 PM Changeset in webkit [83088] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-04-06 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Eric Seidel.

[chromium] Add settings API to enable accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=57863

If accelerated drawing is enabled we try to render content and
root layers using GPU. Please note that this setting is ignored if
accelerated compositing is disabled.

public/WebSettings.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
src/WebSettingsImpl.h:

1:06 PM Changeset in webkit [83087] by hyatt@apple.com

3 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=41445

Reviewed by Dan Bernstein.

Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.

Source/WebCore:

Added fast/history/visited-link-background-color.html

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::visitedDependentColor):

LayoutTests:

Added fast/history/visited-link-background-color.html

fast/history/visited-link-background-color.html: Added.
platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
platform/mac/fast/history/visited-link-background-color-expected.png: Added.
platform/mac/fast/history/visited-link-background-color-expected.txt: Added.

12:56 PM Changeset in webkit [83086] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Unreviewed Qt buildfix after r83079.

WebCore.pro:

12:56 PM Changeset in webkit [83085] by jberlin@webkit.org

5 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.

UIProcess/API/C/win/WKTextChecker.h:
UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):

UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):

UIProcess/win/WebTextCheckerClient.h:

12:46 PM Changeset in webkit [83084] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.

platform/chromium/test_expectations.txt:

12:31 PM Changeset in webkit [83083] by enne@google.com

4 edits
1 add
3 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, rebaseline Chromium linux tests after r83075.

platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
platform/chromium-linux/fast/multicol/nested-columns-expected.png:
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.

12:26 PM Changeset in webkit [83082] by dino@apple.com

2 edits in trunk/Source/WebCore

2011-04-06 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin.

https://bugs.webkit.org/show_bug.cgi?id=56936
Crash in ImplicitAnimation::~ImplicitAnimation

Make sure the style and start time waiting lists
are cleared in the CompositeAnimation destructor. This
way, no running transitions can be left in a state
where they are destroyed as the AnimationControllerPrivate
cleans up.

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation):

12:24 PM Changeset in webkit [83081] by commit-queue@webkit.org

13 edits in trunk/Source

2011-04-06 Robert Sesek <rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
https://bugs.webkit.org/show_bug.cgi?id=54969

No change in behavior; no new tests.

editing/TextIterator.cpp: (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
editing/TextIterator.h:
page/Frame.cpp: (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits

2011-04-06 Robert Sesek <rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
https://bugs.webkit.org/show_bug.cgi?id=54969

WebView/WebFrame.mm: (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore

2011-04-06 Robert Sesek <rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
https://bugs.webkit.org/show_bug.cgi?id=54969

WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore (WebKit::WebPage::getMarkedRange): (WebKit::WebPage::getSelectedRange): (WebKit::WebPage::characterIndexForPoint): (WebKit::WebPage::performDictionaryLookupAtLocation):

11:50 AM Changeset in webkit [83080] by alexis.menard@openbossa.org

2 edits in trunk/LayoutTests

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Skip tests not passing in the Qt bot.

platform/qt/Skipped:

11:46 AM Changeset in webkit [83079] by steveblock@google.com

10 edits
2 adds in trunk/Source/WebCore

2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=57770

Create a template from an existing functionality in JSGeolocationCustom.cpp
to be used by the custom bindings of both Geolocation and the Media Stream API.
V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/CallbackFunction.cpp: Added. (WebCore::checkFunctionOnlyCallback):
bindings/js/CallbackFunction.h: Added. (WebCore::createFunctionOnlyCallback):
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):

11:43 AM Changeset in webkit [83078] by alexis.menard@openbossa.org

9 edits in trunk/Source

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826

Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.

No new tests because layout tests cover it. They are not yet activated
but will be any time soon.

platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::FullScreenVideoWindow): (FullScreenVideoWindow::setVideoElement): (FullScreenVideoWindow::closeEvent): (FullScreenVideoWindow::keyPressEvent): (FullScreenVideoWindow::event): (FullScreenVideoWindow::showFullScreen): (FullScreenVideoWindow::hideCursor): (FullScreenVideoWindow::showCursor):

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826

Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.

No new tests because layout tests cover it. They are not yet activated
but will be any time soon.

QtWebKit.pro:
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler): (WebCore::GStreamerFullScreenVideoHandler::setVideoElement): (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen): (WebCore::GStreamerFullScreenVideoHandler::windowClosed): (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen): (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
WebCoreSupport/FullScreenVideoQt.h: (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):

11:40 AM Changeset in webkit [83077] by commit-queue@webkit.org

4 edits in trunk

2011-04-06 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Eric Seidel.

[Gtk] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=57844

Unskip a newly-passing test.

platform/gtk/Skipped:

2011-04-06 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Eric Seidel.

[Gtk] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=57844

Allow an empty status text to be dumped.

DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged):

11:34 AM Changeset in webkit [83076] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Bundle lineLeftOffset and lineRightOffset as a class
https://bugs.webkit.org/show_bug.cgi?id=57851

Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
and only the difference is used to compute the width.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers. (WebCore::LineOffsets::LineOffsets): Added. (WebCore::LineOffsets::width): Added. (WebCore::LineOffsets::setLeft): Added. (WebCore::LineOffsets::setRight): Added. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.

11:20 AM Changeset in webkit [83075] by hyatt@apple.com

26 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=57916

Reviewed by Dan Bernstein.

Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).

Source/WebCore:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.

page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.

platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::uniteIfNonZero):

platform/graphics/FloatRect.h:
platform/graphics/IntRect.cpp:

(WebCore::IntRect::uniteIfNonZero):

platform/graphics/IntRect.h:

Add a new unite function that is useful for the render tree to FloatRect and IntRect. This
version allows rect unites to happen if either width or height is nonzero.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.

rendering/InlineBox.h:

(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):

rendering/InlineFlowBox.h:

Rewritten to add the text box overflow to the text box itself.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.

(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.

rendering/InlineTextBox.h:

(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here. Only if the RenderInline says that boxes are allowed will they
be created.

(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.

rendering/RenderInline.cpp:

(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.

(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds). Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).

(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.

(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.

(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.

rendering/RenderInline.h:

(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.

(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.

rendering/RenderText.cpp:

(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.

(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.

(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.

(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc. Used by RenderInline::culledInlineVisualOverflowBoundingBox.

rendering/RenderText.h:
rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.

rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).

LayoutTests:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:

11:17 AM Changeset in webkit [83074] by morrita@google.com

3 edits in trunk/LayoutTests

2011-04-06 MORITA Hajime <morrita@google.com>

Unreviewed expectations udpate for gtk port that follows r83065.

platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:

11:15 AM Changeset in webkit [83073] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, modify Chromium test expectations from r83065. They need
rebaselines, but in the meantime they should fail more generally so as
not to trip the bots.

platform/chromium/test_expectations.txt:

11:13 AM Changeset in webkit [83072] by alexis.menard@openbossa.org

2 edits in trunk/LayoutTests

2011-04-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Unskip some media LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=57855

Unskip some media tests for Qt.

platform/qt/Skipped:

11:12 AM Changeset in webkit [83071] by commit-queue@webkit.org

12 edits in trunk

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=42329

Unskip passed tests.

platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=42329

WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePageNumberForElementById):
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::pageNumberForElementById):
WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-06 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=42329

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::pageNumberForElementById):
WebKitTestRunner/InjectedBundle/LayoutTestController.h:

11:03 AM Changeset in webkit [83070] by enrica@apple.com

6 edits in trunk/Source

REGRESSION: Drag & Drop Gmail Attachments doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>

Reviewed by Darin Adler.

Source/WebCore:

In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).

platform/DragData.h:

(WebCore::DragData::pasteboard): Added.

platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().

platform/mac/DragDataMac.mm:

(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.

Source/WebKit2:

Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).

UIProcess/API/mac/WKView.mm:

(-[WKView _hitTest:dragTypes:]): Added.

10:56 AM Changeset in webkit [83069] by commit-queue@webkit.org

3 edits
1 delete in trunk/LayoutTests

2011-04-06 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

fast/layer/video_layer.html has the same text output for all chromium mac platforms.

[chromium] Fix fast/layers/video_layer.html expectations
https://bugs.webkit.org/show_bug.cgi?id=57386

platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
platform/chromium-mac/fast/layers/video-layer-expected.txt:
platform/chromium/test_expectations.txt:

10:32 AM Changeset in webkit [83068] by sergio@webkit.org

2 edits in trunk/Tools

2011-04-06 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] DumpRenderTree: do not try to free NULL SoupURIs
https://bugs.webkit.org/show_bug.cgi?id=57932

Some Layout tests have invalid URIs that do not generate valid
SoupURI instances. Do not try to free those NULL SoupURIs.

DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback):

10:19 AM Changeset in webkit [83067] by benjamin.poulain@nokia.com

2 edits in trunk/Source/WebCore

2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

ClipboardWin has unused variables "ExceptionCode ec"
https://bugs.webkit.org/show_bug.cgi?id=57952

Remove the unused variable.

platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writePlainText):

10:06 AM Changeset in webkit [83066] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Split getBorderPaddingMargin into two functions
https://bugs.webkit.org/show_bug.cgi?id=57947

rendering/RenderBlockLineLayout.cpp: (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin. (WebCore::borderPaddingMarginEnd): Ditto. (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd. (WebCore::RenderBlock::findNextLineBreak): Ditto.

10:03 AM Changeset in webkit [83065] by morrita@google.com

19 edits
1 copy
1 move in trunk

2011-04-06 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] <progress> should not have manual layout code.
https://bugs.webkit.org/show_bug.cgi?id=57801

Updated progress-bar-value-pseudo-element.html to have wider coverage and
follow pseudo class change.

fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
platform/chromium/test_expectations.txt:
platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:

2011-04-06 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] <progress> should not have manual layout code.
https://bugs.webkit.org/show_bug.cgi?id=57801

Simplified RenderProgress, removing its custom layout code
Introducing ProgressValueElement and ProgressBarElement, replacing ProgressBarValueElement.

Now the structure is almost identical to <meter>,
other than:

RenderProgress has animated painting, thus manages its own timer.
Both ProgressValueElement and ProgressBarElement has pseudo classes which don't changes during its lifetime.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/html.css: (progress): (progress::-webkit-progress-bar): (progress::-webkit-progress-value):
html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::~HTMLProgressElement): (WebCore::HTMLProgressElement::create): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtree):
html/HTMLProgressElement.h:
html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressShadowElement::ProgressShadowElement): (WebCore::ProgressShadowElement::progressElement): (WebCore::ProgressShadowElement::rendererIsNeeded): (WebCore::ProgressBarElement::shadowPseudoId): (WebCore::ProgressValueElement::shadowPseudoId): (WebCore::ProgressValueElement::setWidthPercentage):
html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressBarElement::ProgressBarElement): (WebCore::ProgressBarElement::create): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::ProgressValueElement::create):
rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::animationTimerFired):
rendering/RenderProgress.h: (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation): (WebCore::RenderProgress::canHaveChildren):

9:50 AM Changeset in webkit [83064] by mario@webkit.org

8 edits in trunk/Source/WebCore

2011-04-06 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Do not reference AccessibilityRenderObject from platform dependent code
https://bugs.webkit.org/show_bug.cgi?id=57955

Do not reference AccessibilityRenderObject from platform specific code

Added new virtual functions to AccessibilityObject.h and removed
explicit references to AccessibilityRenderObject from GTK code.

accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::renderer): New virtual method, returning 0 by default. Overriden by AccessibilityRenderObject. (WebCore::AccessibilityObject::correspondingLabelForControlElement): New virtual method, returning 0 by default. It complements the already present method correspondingControlForLabelElement().

accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::renderer): Made virtual.

accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::emitTextChanged): Reference AccessibilityObject, instead of AccessibilityRenderObject. (WebCore::AXObjectCache::nodeTextChangePlatformNotification): Ditto.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Do not reference AccessibilityRenderObject. (webkit_accessible_get_description): Ditto. (setAtkRelationSetFromCoreObject): Ditto. (optionFromList): Ditto. (optionFromSelection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_select_all_selection): Ditto. (textForObject): Ditto. (webkit_accessible_text_get_text): Ditto. (getPangoLayoutForAtk): Ditto. (webkit_accessible_text_get_caret_offset): Ditto. (baselinePositionForRenderObject): Ditto. (getAttributeSetForAccessibilityObject): Ditto. (accessibilityObjectLength): Ditto. (getSelectionOffsetsForObject): Ditto. (webkit_accessible_text_set_selection): Ditto. (webkit_accessible_text_set_caret_offset): Ditto. (webkit_accessible_table_get_caption): Ditto. (getInterfaceMaskFromObject): Ditto.

accessibility/gtk/WebKitAccessibleHyperlink.cpp: (getRangeLengthForObject): Ditto.

Removed unused renderer() method from AccessibilityMenuList.

accessibility/AccessibilityMenuList.h: Removed unused method.
accessibility/AccessibilityMenuList.cpp: Removed unused method.

9:39 AM Changeset in webkit [83063] by demarchi@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-04-06 Lucas De Marchi <lucas.demarchi@profusion.mobi>

cmake: Fix build for ARMv7

CMakeLists.txt: add missing file.

9:19 AM Changeset in webkit [83062] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

2011-04-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Javascipt warning link expand and overlap with icons in js console
https://bugs.webkit.org/show_bug.cgi?id=57939

inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):

9:12 AM Changeset in webkit [83061] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

2011-04-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
https://bugs.webkit.org/show_bug.cgi?id=57931

inspector/Inspector.json:

9:09 AM Changeset in webkit [83060] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

2011-04-06 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

[Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
https://bugs.webkit.org/show_bug.cgi?id=57665
<rdar://problem/7350477>

We need to track how user modified an autocorrected word. If he changed it back to original
text, we want to record AutocorrectionReverted response. And if he changed it to something
else, we want to record AutocorrectionEdited response.

To achieve this, we need to distringuish between text replacement caused by autocorrection
from that due to other causes, such as reversion, text substitution, etc. So we added a new
marker type "Autocorrected". We also need to be able to check for correction, even when we
don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
value, "CheckForCorrection".

We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
specified range, and of specified type.

dom/DocumentMarker.h:
dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
dom/DocumentMarkerController.h:
editing/Editor.cpp: (WebCore::markerTypesForAutocorrection): (WebCore::markersHaveIdenticalDescription): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::applyCorrectionPanelInfo): (WebCore::Editor::unappliedSpellCorrection): (WebCore::Editor::textCheckingTypeMaskFor):
editing/Editor.h:
editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):

9:09 AM Changeset in webkit [83059] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-04-06 Liang Qi <liang.qi@nokia.com>

Reviewed by Benjamin Poulain.

Correct a include file name.
https://bugs.webkit.org/show_bug.cgi?id=57839

wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix builds on Unix hosts.

8:58 AM Changeset in webkit [83058] by Adam Roben

2 edits in trunk/Source/JavaScriptCore

Build fix after r83056

JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.

8:54 AM Changeset in webkit [83057] by enne@google.com

1 edit
1 add in trunk/LayoutTests

2011-04-06 Adrienne Walker <enne@google.com>

Unreviewed, add Chromium snow leopard baseline for meter-boundary-values

platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.

8:47 AM Changeset in webkit [83056] by Adam Roben

3 edits
1 add in trunk/Source/JavaScriptCore

Move JavaScriptCoreGenerated's file-copying logic out to a new script

Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.

If we like this new style, we could copy it for our other projects.

Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy

Reviewed by Steve Falkenburg.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy

files from here...

JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd

for convenience.

8:45 AM Changeset in webkit [83055] by Csaba Osztrogonác

2 edits in trunk/Tools

ORWT shouldn't generate diff files for tests without expected files
https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

Scripts/old-run-webkit-tests:

8:44 AM Changeset in webkit [83054] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Fix using UNUSED_PARAM introduced in r82907
https://bugs.webkit.org/show_bug.cgi?id=57940

Reviewed by Darin Adler.

WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

8:41 AM Changeset in webkit [83053] by podivilov@chromium.org

5 edits
2 deletes in trunk

2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
http://trac.webkit.org/changeset/83045
https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

inspector/debugger/script-formatter-expected.txt: Removed.
inspector/debugger/script-formatter.html: Removed.
platform/chromium/test_expectations.txt:

2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
http://trac.webkit.org/changeset/83045
https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

GNUmakefile.am:
inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

8:19 AM Changeset in webkit [83052] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.

rendering/RenderBlock.h:

8:16 AM Changeset in webkit [83051] by diegohcg@webkit.org

5 edits
1 delete in trunk/Source/WebCore

2011-03-27 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
https://bugs.webkit.org/show_bug.cgi?id=57007

Reviewed by Kenneth Rohde Christiansen.

CodeGenerators.pri:
css/themeQtMobile.css: Removed.
platform/qt/QtMobileWebStyle.cpp: (drawRectangularControlBackground): (QtMobileWebStyle::drawPrimitive): (QtMobileWebStyle::drawComplexControl):
platform/qt/QtMobileWebStyle.h:
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::paintTextField):

8:15 AM Changeset in webkit [83050] by jberlin@webkit.org

8 edits
6 adds in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 1: Get and set the state.

Shared/API/c/win/WKBaseWin.h:
Shared/APIObject.h:
UIProcess/API/C/win/WKAPICastWin.h:

UIProcess/API/C/win/WKTextChecker.cpp: Added.

(WKTextCheckerSetClient):
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
(WKTextCheckerGrammarCheckingEnabledStateChanged):

UIProcess/API/C/win/WKTextChecker.h: Added.

UIProcess/TextChecker.h:
UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::state):
Do the initalization for the state only once so that it is not necessary to call the client
every time the state is requested.
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
Call the client.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
Update the state and tell the client.
(WebKit::TextChecker::setGrammarCheckingEnabled):
Ditto.
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Update the state.
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
Update the state.

UIProcess/win/WebTextChecker.cpp: Added.

(WebKit::WebTextChecker::shared):
Make the WebTextChecker available globally.
(WebKit::WebTextChecker::WebTextChecker):
(WebKit::WebTextChecker::setClient):
(WebKit::updateStateForAllWebProcesses):
(WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
Tell the TextChecker that the state has changed, and then tell the
WebProcessProxies to send the new state to the WebProcesses.
(WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
Ditto.

UIProcess/win/WebTextChecker.h: Added.

(WebKit::WebTextChecker::client):
(WebKit::WebTextChecker::type):

UIProcess/win/WebTextCheckerClient.cpp: Added.

(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):

UIProcess/win/WebTextCheckerClient.h: Added.

win/WebKit2.vcproj:

Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp.

win/WebKit2Generated.make:

Copy over WKTextChecker.h.

7:57 AM Changeset in webkit [83049] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

2011-04-06 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

[Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=57800
<rdar://problem/9218223>

Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.

accessibility/AXObjectCache.h:
accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postPlatformNotification):
editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

7:42 AM Changeset in webkit [83048] by Martin Robinson

2 edits in trunk/Source/WebCore

2011-04-06 Martin Robinson <mrobinson@igalia.com>

Build fix for debug Cairo builds.

platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.

7:38 AM Changeset in webkit [83047] by diegohcg@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Style fix for QtMobileWebStyle.h
https://bugs.webkit.org/show_bug.cgi?id=57708

Reviewed by Antonio Gomes.

platform/qt/QtMobileWebStyle.h:

7:35 AM Changeset in webkit [83046] by abecsi@webkit.org

5 edits
3 adds in trunk

2011-04-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

Invalid color #{predefined colorName} is accepted by the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=15360

editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid.
fast/css/invalid-predefined-color-expected.txt: Added.
fast/css/invalid-predefined-color.html: Added.
fast/css/script-tests/invalid-predefined-color.js: Added.

2011-04-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

Invalid color #{predefined colorName} is accepted by the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=15360

Test: fast/css/invalid-predefined-color.html

css/CSSGrammar.y: Remove superfluous hexcolor production.
css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).

7:29 AM Changeset in webkit [83045] by podivilov@chromium.org

5 edits
2 adds in trunk

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447

inspector/debugger/script-formatter-expected.txt: Added.
inspector/debugger/script-formatter.html: Added.
platform/chromium/test_expectations.txt:

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

GNUmakefile.am:
inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

7:16 AM Changeset in webkit [83044] by Martin Robinson

7 edits in trunk/Source/WebCore

2011-04-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Cairo] Hide the details of image masking in PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=57878

No new tests. This is just a refactor.

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to do the actual cairo_save. Remove information about image masking. (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to do the actual cairo_restore. Remove information about image masking.
platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::restore): Added. (WebCore::PlatformContextCairo::save): Added. (WebCore::PlatformContextCairo::pushImageMask): Added.
platform/graphics/cairo/PlatformContextCairo.h: (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h. (WebCore::ImageMaskInformation::isValid): Ditto. (WebCore::ImageMaskInformation::maskSurface): Ditto. (WebCore::ImageMaskInformation::maskRect): Ditto.

7:12 AM Changeset in webkit [83043] by diegohcg@webkit.org

2 edits in trunk/Source/WebCore

2011-04-02 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Radio buttons are showing wrong with mobile theme
https://bugs.webkit.org/show_bug.cgi?id=57706

Reviewed by Csaba Osztrogonác.

platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawRadio):

7:10 AM Changeset in webkit [83042] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=57943

rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp

6:50 AM Changeset in webkit [83041] by diegohcg@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Diego Gonzalez <diegohcg@webkit.org>

Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::findChecker): (QtMobileWebStyle::findRadio): (QtMobileWebStyle::findComboButton):

6:18 AM Changeset in webkit [83040] by podivilov@chromium.org

3 edits
1 move
1 add in trunk/Source/WebCore

2011-04-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
https://bugs.webkit.org/show_bug.cgi?id=57641

WebCore.xcodeproj/project.pbxproj:
gyp/streamline-inspector-source.sh:
inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
inspector/inline-javascript-imports.py: Added.

5:59 AM Changeset in webkit [83039] by rniwa@webkit.org

4 edits
2 adds in trunk

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872

r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.

Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.

Test: editing/inserting/insert-paragraph-separator-tab-span.html

editing/EditingStyle.cpp: (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph separator into a paragraph separator.

2011-04-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872

Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
style to the paragraph separator or the text.

editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
editing/inserting/insert-paragraph-separator-tab-span.html: Added.

5:12 AM Changeset in webkit [83038] by leviw@chromium.org

4 edits in trunk/Source/WebCore

2011-04-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Add member functions for determining line/paragraph separation to InlineIterator
https://bugs.webkit.org/show_bug.cgi?id=57938

Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
InlineIterator, where it makes far more sense for them to be. Also moving
shouldPreserveNewline to RenderObject and renaming it preservesNewline.

No new tests as this provides no new functionality.

rendering/InlineIterator.h: (WebCore::InlineIterator::atTextParagraphSeparator): (WebCore::InlineIterator::atParagraphSeparator):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
rendering/RenderObject.h: (WebCore::RenderObject::preservesNewline):

2:57 AM Changeset in webkit [83037] by apavlov@chromium.org

5 edits in trunk

2011-04-05 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Range insertNode function does not update content in the inspector
https://bugs.webkit.org/show_bug.cgi?id=57829

inspector/elements/modify-chardata-expected.txt:
inspector/elements/modify-chardata.html:

2011-04-05 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Range insertNode function does not update content in the inspector
https://bugs.webkit.org/show_bug.cgi?id=57829

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):

2:37 AM Changeset in webkit [83036] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve tests for QWebFrame::url() and related methods
https://bugs.webkit.org/show_bug.cgi?id=57865

tests/qwebframe/tst_qwebframe.cpp: (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test. (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl() that fails and a load() that fails (for a different URL).

(tst_QWebFrame::setUrlWithFragment_data):
(tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
the URL in the frame before the test starts.

(tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
the same URL as argument.

(extractBaseUrl):
(tst_QWebFrame::setUrlThenLoads_data):
(tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
sequence of set and loads. Those tests are interesting because the properties
react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
is used or after the load() is committed and baseUrl() is similar to url() but also depends
on the contents of the page when it loads.

2:24 AM Changeset in webkit [83035] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

2011-04-06 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

getComputedTextLength always returns 0 with tspan elements
https://bugs.webkit.org/show_bug.cgi?id=19814

Add a testcase showing that getComputedTextLength for <tspan> works fine.

svg/text/tspan-getComputedTextLength-expected.txt: Added.
svg/text/tspan-getComputedTextLength.svg: Added.

2:03 AM Changeset in webkit [83034] by alex

3 edits in trunk/Source/WebCore

2011-04-06 Alejandro G. Castro <alex@igalia.com>

Fix GTK3 compilation after r82962.

platform/gtk/RenderThemeGtk3.cpp: (WebCore::paintToggle): (WebCore::renderButton): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::paintProgressBar): (WebCore::paintSpinArrowButton):
platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):

1:24 AM Changeset in webkit [83033] by caseq@chromium.org

11 edits in trunk

2011-04-06 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] remove inspectedPage.* events
https://bugs.webkit.org/show_bug.cgi?id=57763

Removed webInspector.inspectedPage.* events
moved onNavigated to webInspector.resources

inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.InspectedWindow):
inspector/front-end/ExtensionAPISchema.json:
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.inspectedURLChanged):

2011-04-06 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] remove inspectedPage.* events
https://bugs.webkit.org/show_bug.cgi?id=57763

Removed webInspector.inspectedPage.* events
moved onNavigated to webInspector.resources

http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.runWhenPageLoads):
http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runWhenPageLoads.chainedCallback): (initialize_InspectorTest.InspectorTest.runWhenPageLoads):
inspector/extensions/extensions-api-expected.txt:
inspector/extensions/extensions-events-expected.txt:
inspector/extensions/extensions-events.html:

1:10 AM Changeset in webkit [83032] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

2011-04-06 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Antti Koivisto.

Add <head> to the simpleUserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=57915

css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): add head to the simple stylesheet, display:none.

1:03 AM Changeset in webkit [83031] by mnaganov@chromium.org

7 edits
5 adds in trunk

2011-04-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57856

Test: inspector/profiler/detailed-heapshots-summary.html

inspector/front-end/DataGrid.js: (WebInspector.DataGrid):
inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):

2011-04-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57856

http/tests/inspector/inspector-test.js: (initialize_InspectorTest.): (initialize_InspectorTest):
inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
inspector/profiler/detailed-heapshots-summary.html: Added.
inspector/profiler/detailed-heapshots-test.js: Added.
platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.

12:50 AM Changeset in webkit [83030] by ojan@chromium.org

1 edit
61 adds in trunk/LayoutTests

2011-04-06 Ojan Vafai <ojan@chromium.org>

http://trac.webkit.org/changeset/83024 incorrectly removed the mac-leopard results.
Instead, it should have moved the results from chromium-mac to chromium-mac-leopard.

platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open1-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open2-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open3-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open4-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open5-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-open6-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-position-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png: Added.
platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png: Added.
platform/chromium-mac-leopard/fast/inline-block/inline-block-vertical-align-expected.png: Added.
platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-length-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-runs-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-runs-spans-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/ruby-trailing-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png: Added.

12:46 AM Changeset in webkit [83029] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-06 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

[Qt] SmartReplaceQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40261

This patch does not require new test cases.

editing/qt/SmartReplaceQt.cpp: (WebCore::isCharacterSmartReplaceExempt):

12:40 AM Changeset in webkit [83028] by Nikolas Zimmermann

1 edit
2 adds in trunk/LayoutTests

2011-04-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Add missing pixel test result.

platform/mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
platform/mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.

12:38 AM Changeset in webkit [83027] by koz@chromium.org

2 edits in trunk/LayoutTests

2011-04-06 James Kozianski <koz@chromium.org>

[chromium] Add expectations for failing GPU tests.
https://bugs.webkit.org/show_bug.cgi?id=57926

platform/chromium/test_expectations.txt:

12:22 AM Changeset in webkit [83026] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-04-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
https://bugs.webkit.org/show_bug.cgi?id=57755

editing/execCommand/insert-line-break-onload-expected.txt: Added.
editing/execCommand/insert-line-break-onload.html: Added to check calling InsertLineBreak without any crash.

2011-04-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
https://bugs.webkit.org/show_bug.cgi?id=57755

Test: editing/execCommand/insert-line-break-onload.html

editing/TypingCommand.cpp: (WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().

Apr 5, 2011:

11:50 PM Changeset in webkit [83025] by koz@chromium.org

2 edits
1 delete in trunk/LayoutTests

2011-04-05 James Kozianski <koz@chromium.org>

[chromium] Rebaseline images after r82969

Rebaseline for missed linux test in r83019.

platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed.
platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:

11:39 PM Changeset in webkit [83024] by ojan@chromium.org

4 edits
66 deletes in trunk/LayoutTests

2011-04-05 Shane Stephens <shanestephens@google.com>

Reviewed by Ojan Vafai.

[Chromium] Greening the Mac 10.5 and 10.6 trees.
https://bugs.webkit.org/show_bug.cgi?id=57924

Rebaselines a bunch of tests with differences due to text anti-aliasing.
(Prepared using rebaseline script)

platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
platform/chromium-mac/fast/html/details-position-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
platform/chromium-mac/fast/multicol/nested-columns-expected.png:
platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
platform/chromium-mac/fast/repaint/list-marker-expected.png:
platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Removed.
platform/chromium-mac/fast/ruby/ruby-length-expected.png: Removed.
platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Removed.
platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Removed.
platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Removed.
platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
platform/chromium/test_expectations.txt:
platform/mac/fast/css/background-clip-values-expected.checksum: Added.
platform/mac/fast/css/background-clip-values-expected.png: Added.
platform/mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
platform/mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
platform/mac/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
platform/mac/fast/gradients/gradient-after-transparent-border-expected.png: Added.
platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
platform/mac/media/controls-without-preload-expected.checksum: Added.
platform/mac/media/controls-without-preload-expected.png: Added.

11:29 PM Changeset in webkit [83023] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566

public/WebContextMenuData.h:

11:27 PM Changeset in webkit [83022] by Antti Koivisto

2 edits in trunk/Source/WebCore

Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
https://bugs.webkit.org/show_bug.cgi?id=57914

Reviewed by Cameron Zwarich.

Don't call adjustedDeferredRepaintDelay unnecessarily.

page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::adjustedDeferredRepaintDelay):

11:01 PM Changeset in webkit [83021] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/chromium

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83007.
http://trac.webkit.org/changeset/83007
https://bugs.webkit.org/show_bug.cgi?id=57920

Broke WebFrameTest.FrameForEnteredContext on Chromium-win and
Chromium-mac (Requested by tkent on #webkit).

WebKit.gyp:
WebKit.gypi:
public/WebFrame.h:
src/WebFrameImpl.cpp:
tests/WebFrameTest.cpp: (WebKit::WebFrameTest::WebFrameTest): (WebKit::WebFrameTest::registerMockedURLLoad): (WebKit::WebFrameTest::serveRequests): (WebKit::TEST_F):

10:57 PM Changeset in webkit [83020] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Update call to SkAdvancedTypefaceMetrics to new API.
https://bugs.webkit.org/show_bug.cgi?id=57887

platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::emSizeInFontUnits):

10:57 PM Changeset in webkit [83019] by koz@chromium.org

29 edits
1 add
40 deletes in trunk/LayoutTests

2011-04-05 James Kozianski <koz@chromium.org>

Rebaseline images after r82969
https://bugs.webkit.org/show_bug.cgi?id=57917

Rebaseline for r82969, which causes slight changes in rounded corner rendering.

platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-expected.png:
platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
platform/chromium-linux/fast/forms/basic-selects-expected.png:
platform/chromium-linux/fast/layers/video-layer-expected.checksum: Removed.
platform/chromium-linux/fast/layers/video-layer-expected.png:
platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
platform/chromium-linux/fast/transforms/shadows-expected.png:
platform/chromium-linux/media/audio-controls-rendering-expected.checksum: Removed.
platform/chromium-linux/media/audio-controls-rendering-expected.png:
platform/chromium-linux/media/controls-after-reload-expected.checksum: Removed.
platform/chromium-linux/media/controls-after-reload-expected.png:
platform/chromium-linux/media/controls-strict-expected.checksum: Removed.
platform/chromium-linux/media/controls-strict-expected.png:
platform/chromium-linux/media/controls-styling-expected.checksum: Removed.
platform/chromium-linux/media/controls-styling-expected.png:
platform/chromium-linux/media/controls-without-preload-expected.checksum: Removed.
platform/chromium-linux/media/controls-without-preload-expected.png:
platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Removed.
platform/chromium-linux/media/media-document-audio-repaint-expected.png:
platform/chromium-linux/media/video-controls-rendering-expected.checksum: Removed.
platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-linux/media/video-display-toggle-expected.checksum: Removed.
platform/chromium-linux/media/video-display-toggle-expected.png:
platform/chromium-linux/media/video-empty-source-expected.checksum: Removed.
platform/chromium-linux/media/video-empty-source-expected.png:
platform/chromium-linux/media/video-no-audio-expected.checksum: Removed.
platform/chromium-linux/media/video-no-audio-expected.png:
platform/chromium-linux/media/video-volume-slider-expected.checksum: Removed.
platform/chromium-linux/media/video-volume-slider-expected.png:
platform/chromium-linux/media/video-zoom-controls-expected.checksum: Removed.
platform/chromium-linux/media/video-zoom-controls-expected.png:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win-xp/media/controls-after-reload-expected.checksum: Removed.
platform/chromium-win-xp/media/controls-after-reload-expected.png: Removed.
platform/chromium-win-xp/media/controls-strict-expected.checksum: Removed.
platform/chromium-win-xp/media/controls-strict-expected.png: Removed.
platform/chromium-win-xp/media/controls-styling-expected.checksum: Removed.
platform/chromium-win-xp/media/controls-styling-expected.png: Removed.
platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Removed.
platform/chromium-win-xp/media/controls-without-preload-expected.png: Removed.
platform/chromium-win-xp/media/video-controls-rendering-expected.checksum: Removed.
platform/chromium-win-xp/media/video-controls-rendering-expected.png: Removed.
platform/chromium-win-xp/media/video-zoom-controls-expected.checksum: Removed.
platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/inset-expected.png:
platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-expected.png:
platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
platform/chromium-win/fast/forms/basic-selects-expected.png:
platform/chromium-win/fast/layers/video-layer-expected.checksum: Removed.
platform/chromium-win/fast/layers/video-layer-expected.png:
platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
platform/chromium-win/fast/transforms/shadows-expected.png:
platform/chromium-win/media/audio-controls-rendering-expected.checksum: Removed.
platform/chromium-win/media/audio-controls-rendering-expected.png:
platform/chromium-win/media/controls-after-reload-expected.checksum: Removed.
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-strict-expected.checksum: Removed.
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/controls-styling-expected.checksum: Removed.
platform/chromium-win/media/controls-styling-expected.png:
platform/chromium-win/media/controls-without-preload-expected.checksum: Removed.
platform/chromium-win/media/controls-without-preload-expected.png:
platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Removed.
platform/chromium-win/media/media-document-audio-repaint-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.checksum: Removed.
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-display-toggle-expected.checksum: Removed.
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-empty-source-expected.checksum: Removed.
platform/chromium-win/media/video-empty-source-expected.png:
platform/chromium-win/media/video-no-audio-expected.checksum: Removed.
platform/chromium-win/media/video-no-audio-expected.png:
platform/chromium-win/media/video-volume-slider-expected.checksum: Removed.
platform/chromium-win/media/video-volume-slider-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.checksum: Removed.
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:

10:21 PM Changeset in webkit [83018] by kevino@webkit.org

2 edits in trunk/Tools

[wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch to deps.

10:11 PM Changeset in webkit [83017] by tkent@chromium.org

75 edits
74 deletes in trunk/LayoutTests

2011-04-05 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectation images for a Skia rounded rectangle change (r83002).
https://bugs.webkit.org/show_bug.cgi?id=57907

platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-expected.png:
platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
platform/chromium-linux/fast/forms/basic-selects-expected.png:
platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
platform/chromium-linux/fast/transforms/shadows-expected.png:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/inset-expected.png:
platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-expected.png:
platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
platform/chromium-win/fast/forms/basic-selects-expected.png:
platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
platform/chromium-win/fast/transforms/shadows-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:

9:35 PM Changeset in webkit [83016] by ap@apple.com

5 edits in trunk/Source/WebCore

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Rename event dispatching functions after form event removal
https://bugs.webkit.org/show_bug.cgi?id=57908

dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer):
dom/Node.cpp: (WebCore::Node::dispatchChangeEvent): (WebCore::Node::dispatchInputEvent): (WebCore::Node::defaultEventHandler):
dom/Node.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent): Renamed "events" to "event", since there is only one event to dispatch now.

8:58 PM Changeset in webkit [83015] by commit-queue@webkit.org

3 edits in trunk/Tools

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82978, r82999, and r83001.
http://trac.webkit.org/changeset/82978
http://trac.webkit.org/changeset/82999
http://trac.webkit.org/changeset/83001
https://bugs.webkit.org/show_bug.cgi?id=57913

Does not work in Python 2.5 (Requested by abarth on #webkit).

Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/common/system/executive_unittest.py:

8:56 PM Changeset in webkit [83014] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

[Qt] DragControllerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40258

This patch does not require new test cases.

page/qt/DragControllerQt.cpp: (WebCore::DragController::dragOperation):

8:53 PM Changeset in webkit [83013] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Update deprecated include: platform_canvas_win.h to platform_canvas.h.
https://bugs.webkit.org/show_bug.cgi?id=57896

platform/graphics/chromium/FontChromiumWin.cpp:

8:49 PM Changeset in webkit [83012] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Who likes export files? I do!

8:44 PM Changeset in webkit [83011] by ggaren@apple.com

8 edits in trunk/Source/JavaScriptCore

2011-04-05 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Introduced the concept of opaque roots, in preparation for marking the DOM with them
https://bugs.webkit.org/show_bug.cgi?id=57903

JavaScriptCore.exp: Who likes export files? I do!

collector/handles/HandleHeap.cpp: (JSC::isValidWeakHandle): Factored out a helper function for ASSERTs.

(JSC::WeakHandleOwner::~WeakHandleOwner): Moved from header to avoid
weak linkage problems.

(JSC::WeakHandleOwner::isReachableFromOpaqueRoots): New callback.
Currently unused.

(JSC::WeakHandleOwner::finalize): Switched from pure virtual to a
default empty implementation, since not all clients necessarily want
or need non-trivial finalizers.

(JSC::HandleHeap::markWeakHandles): Split updateWeakHandles into two
passes. The first pass marks all reachable weak handles. The second pass
finalizes all unreachable weak handles. This must be two passes because
we don't know the set of finalizable weak handles until we're done
marking all weak handles.

(JSC::HandleHeap::finalizeWeakHandles): Use new helper function.

collector/handles/HandleHeap.h: Ditto.

runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): (JSC::Heap::reset): Split out handle marking from handle finalization.

runtime/MarkStack.cpp: (JSC::MarkStack::reset):
runtime/MarkStack.h: (JSC::MarkStack::addOpaqueRoot): (JSC::MarkStack::containsOpaqueRoot): (JSC::MarkStack::opaqueRootCount): (JSC::HeapRootMarker::markStack): New helper functions for managing the set of opaque roots.

runtime/WeakGCMap.h: (JSC::WeakGCMap::finalize): Renamed to match parent class declaration.

8:05 PM Changeset in webkit [83010] by commit-queue@webkit.org

12 edits in trunk

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

Unskip passed tests.

platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleNumberOfPages):
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::numberOfPages):
WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::numberOfPages):
WebKitTestRunner/InjectedBundle/LayoutTestController.h:

7:20 PM Changeset in webkit [83009] by tony@chromium.org

4 edits in trunk/Tools

2011-04-05 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
https://bugs.webkit.org/show_bug.cgi?id=57889

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

7:06 PM Changeset in webkit [83008] by koz@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 James Kozianski <koz@chromium.org>

Unreviewed, rolling out r82976.
http://trac.webkit.org/changeset/82976
https://bugs.webkit.org/show_bug.cgi?id=57566

Breaks chromium canary build

public/WebContextMenuData.h:

6:55 PM Changeset in webkit [83007] by aa@chromium.org

6 edits in trunk/Source/WebKit/chromium

2011-04-05 Aaron Boodman <aa@chromium.org>

Reviewed by Adam Barth.

Add ability to get frame from v8 context to chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57516

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrame::frameForV8Context):

6:28 PM Changeset in webkit [83006] by Darin Adler

2 edits in trunk/Source/WebCore

Try to fix Leopard bots.

platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems

to have intended it.

6:00 PM Changeset in webkit [83005] by Darin Adler

2 edits in trunk/Source/WebCore

Try to fix Leopard bots.

platform/mac/HTMLConverter.mm: Move declarations of new functions

inside the appropriate #if.

5:55 PM Changeset in webkit [83004] by Darin Adler

11 edits in trunk/Source/WebKit2

2011-04-05 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

[Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
https://bugs.webkit.org/show_bug.cgi?id=57893
<rdar://problem/9130486>

UIProcess/API/mac/PageClientImpl.h: Added executeSavedCommandBySelector.
UIProcess/API/mac/PageClientImpl.mm: Renamed internal Objective-C classes to use the WebKit2 Objective-C class prefix, WK, rather than the WebKit1 Objective-C class prefix, Web. Removed some unneeded explicit WebKit namespace prefixes. (-[WKEditCommandObjC initWithWebEditCommandProxy:]): Removed unneeded WebKit namespace prefix. (-[WKEditCommandObjC command]): Ditto. (-[WKEditorUndoTargetObjC undoEditing:]): Updated for new class name. (-[WKEditorUndoTargetObjC redoEditing:]): Ditto. (WebKit::PageClientImpl::PageClientImpl): Ditto. (WebKit::PageClientImpl::registerEditCommand): Ditto. (WebKit::PageClientImpl::executeSavedCommandBySelector): Added.

UIProcess/API/mac/WKView.mm: Renamed internal Objective-C categories to use the WebKit2 Objective-C prefix, WK, rather than the WebKit1 Objective-C prefix, Web, or no prefix at all. Tweaked use of extern "C" a little. (-[WKView doCommandBySelector:]): Tweaked the comment. (-[WKView _executeSavedCommandBySelector:]): Added. For use when command is not handled by WebCore. (-[WKResponderChainSink initWithResponderChain:]): Added. Based on the WebResponderChainSink class in WebKit1. (-[WKResponderChainSink detach]): Added. (-[WKResponderChainSink didReceiveUnhandledCommand]): Added. (-[WKResponderChainSink noResponderFor:]): Added. (-[WKResponderChainSink doCommandBySelector:]): Added. (-[WKResponderChainSink tryToPerform:with:]): Added.

UIProcess/API/mac/WKViewInternal.h: Added declaration of _executeSavedCommandBySelector: method. Also removed unneeded includes.

UIProcess/PageClient.h: Added executeSavedCommandBySelector.
UIProcess/WebPageProxy.h: Added executeSavedCommandBySelector.
UIProcess/WebPageProxy.messages.in: Added ExecuteSavedCommandBySelector.

UIProcess/mac/WebFullScreenManagerProxyMac.mm: Updated includes.

UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::executeSavedCommandBySelector): Added.

WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): Send the synchronous ExecuteSavedCommandBySelector message when a command is not handled by WebCore.

5:31 PM Changeset in webkit [83003] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, temporarily mark two tests as more generally failing.

platform/chromium/test_expectations.txt:

5:28 PM Changeset in webkit [83002] by enne@google.com

2 edits in trunk/Source/WebCore

2011-04-05 Adrienne Walker <enne@google.com>

Reviewed by Tony Chang.

Correctly set color when using skia's fillRoundedRect.
https://bugs.webkit.org/show_bug.cgi?id=57907

platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRoundedRect):

5:28 PM Changeset in webkit [83001] by abarth@webkit.org

2 edits in trunk/Tools

2011-04-05 Adam Barth <abarth@webkit.org>

Silly with statement, from the future!

Scripts/webkitpy/common/system/executive.py:

5:22 PM Changeset in webkit [83000] by ap@apple.com

12 edits
2 moves in trunk/Source

Reviewed by Darin Adler.

Move attributedStringFromRange down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=57905

4:54 PM Changeset in webkit [82999] by abarth@webkit.org

2 edits in trunk/Tools

2011-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Don't use Exception.message because it's deprecated
https://bugs.webkit.org/show_bug.cgi?id=57892

Suppress the warning for now. When we move to Python 3, we might need
to something more dramatic.

Scripts/webkitpy/common/system/executive.py:

4:17 PM Changeset in webkit [82998] by mihaip@chromium.org

2 edits in trunk/Tools

2011-04-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Add builders.js to dashboard file list
https://bugs.webkit.org/show_bug.cgi?id=57899

Add file added by http://crrev.com/80538 to dashboard file list.

TestResultServer/handlers/dashboardhandler.py:

4:03 PM Changeset in webkit [82997] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Alexey Proskuryakov.

Some plug-in content is displayed upside down in Unity plug-in
https://bugs.webkit.org/show_bug.cgi?id=57895
<rdar://problem/9212003>

Create the flipped geometry layer in the web process instead of the plug-in process,
which matches what we do in WebKit1.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: (WebKit::PluginProxy::pluginLayer):

3:59 PM Changeset in webkit [82996] by thakis@chromium.org

7 edits in trunk/Source/WebKit/chromium

2011-04-05 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Don't have 'using namespace' declarations in header files
https://bugs.webkit.org/show_bug.cgi?id=57882

src/EventListenerWrapper.cpp:
src/EventListenerWrapper.h:
src/VideoFrameChromiumImpl.h:
src/WebDOMEventListener.cpp:
src/WebDOMEventListenerPrivate.cpp:
src/WebDOMEventListenerPrivate.h: (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):

3:50 PM Changeset in webkit [82995] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-04-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Rename variables in border drawing code for readability
https://bugs.webkit.org/show_bug.cgi?id=57894

rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::drawBoxSideFromPath): (WebCore::RenderObject::drawArcForBoxSide):

3:48 PM Changeset in webkit [82994] by sfalken@apple.com

3 edits in tags/Safari-534.27.1/Source/JavaScriptCore

Merge r82987.

3:43 PM Changeset in webkit [82993] by sfalken@apple.com

5 edits in tags/Safari-534.27.1/Source

Versioning.

3:29 PM Changeset in webkit [82992] by Antti Koivisto

2 edits in trunk/Source/WebCore

Defer repaints during style recalc
https://bugs.webkit.org/show_bug.cgi?id=57886

Reviewed by Darin Adler.

This reduces the need to do (often expensive) platform surface invalidation.
We already do this during layout but style recalculation may trigger
invalidation as well.

dom/Document.cpp:

(WebCore::Document::recalcStyle):

3:23 PM Changeset in webkit [82991] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

2011-04-05 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

HTML5 Player Has no Fullscreen Mode
https://bugs.webkit.org/show_bug.cgi?id=57795

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API

supportsFullScreenForElement() before the old supportsFullScreenForNode() API.

3:10 PM Changeset in webkit [82990] by jberlin@webkit.org

2 edits in trunk/LayoutTests

3 tests fail on apple-macpro-6 (due to different JS MIME type) but not any other Leopard
slaves.
https://bugs.webkit.org/show_bug.cgi?id=56564

Skip fast/preloader/scan-body-from-head-script.html on Leopard to get the bots green.

platform/mac-leopard/Skipped:

3:07 PM Changeset in webkit [82989] by wjmaclean@chromium.org

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added wjmaclean@chromium.org to WebKit committers.

3:04 PM Changeset in webkit [82988] by kbalazs@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-04-05 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Darin Adler.

Build fix for YarrParser.h
https://bugs.webkit.org/show_bug.cgi?id=57822

yarr/YarrParser.h: (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):

3:03 PM Changeset in webkit [82987] by sfalken@apple.com

3 edits in trunk/Source/JavaScriptCore

Follow-up Windows build fix.
Don't skip react-to-vsprops-changes.py for all production builds,
only those initiated via JavaScriptCore.make.

JavaScriptCore.vcproj/JavaScriptCore.make:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

3:01 PM Changeset in webkit [82986] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r82849): 85,000+ JSC-related leaks seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=57857

Whoops, accidentally removed a deref().

bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):

2:59 PM Changeset in webkit [82985] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-04-05 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix data url's status and timing the network panel.
https://bugs.webkit.org/show_bug.cgi?id=53066

Added data url support for status of network resources.

English.lproj/localizedStrings.js:
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isDataURL):

2:58 PM Changeset in webkit [82984] by sfalken@apple.com

1 copy in tags/Safari-534.27.1

New tag.

2:53 PM Changeset in webkit [82983] by sfalken@apple.com

3 edits
7 adds in trunk/Source/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add per-configuration vsprops files.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Removed inheritance from common.vsprops.

Set production environment variable before calling make.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops: Added.

2:25 PM Changeset in webkit [82982] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion failure when navigating quickly between file URLs
https://bugs.webkit.org/show_bug.cgi?id=57884
<rdar://problem/9080559>

Remove bogus assertion. The pending provisional sandbox extension can be
non-null if the current provisional load fails because we're about to load a new
page that also has a sandbox extension.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):

2:20 PM Changeset in webkit [82981] by vitalyr@chromium.org

4 edits in trunk

2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810

bindings/v8/V8GCController.cpp: (WebCore::GrouperVisitor::visitDOMWrapper):

2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810

platform/chromium/test_expectations.txt: Mark fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.

2:11 PM Changeset in webkit [82980] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Grant the web process access to ~/Library/Preferences/com.apple.universalaccess.plist
https://bugs.webkit.org/show_bug.cgi?id=57879

The web process needs access to the unviersal access preferences to determine if full keyboard
access is enabled. I've filed <rdar://problem/9237619> which tracks reading this preference in the UI
process and sending it over to the web process whenever it changes.

WebProcess/com.apple.WebProcess.sb:

2:07 PM Changeset in webkit [82979] by bweinstein@apple.com

4 edits in trunk/LayoutTests

[Windows] fast/blockflow/Kusa-Makura-background-canvas.html failing since introduction in r82903
https://bugs.webkit.org/show_bug.cgi?id=57880

Update Windows expected results (with pixel tests) to greenify the bots.

platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:

2:04 PM Changeset in webkit [82978] by morrita@google.com

3 edits in trunk/Tools

2011-04-05 MORITA Hajime <morrita@google.com>

Reviewed by Adam Barth.

webkit-patch should print git's stderr when git svn dcommit fail
http://webkit.org/b/57861

Scripts/webkitpy/common/checkout/scm.py:

1:59 PM Changeset in webkit [82977] by jberlin@webkit.org

2 edits in trunk/LayoutTests

[Windows Tests] fast/dom/Window/window-property-descriptors.html failing since r82925.
https://bugs.webkit.org/show_bug.cgi?id=57881

Update the Windows-specific results to get the bots green.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

onformchange and onforminput were removed in r82925.

1:44 PM Changeset in webkit [82976] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566

public/WebContextMenuData.h:

1:37 PM Changeset in webkit [82975] by tony@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2011-04-05 Tony Chang <tony@chromium.org>

Unreviewed, removing the chromium-win results causes this test to
start passing on chromium win and linux.

platform/chromium-win/fast/images/svg-as-tiled-background-expected.checksum: Removed.
platform/chromium-win/fast/images/svg-as-tiled-background-expected.png: Removed.
platform/chromium/test_expectations.txt:

1:34 PM Changeset in webkit [82974] by dino@apple.com

2 edits in trunk/Source/WebKit2

2011-04-05 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Add parentheses around && within

to avoid clang warning.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):

1:26 PM Changeset in webkit [82973] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add two more entries to the sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=57875

Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition
ends up calling into ICU which accesses the dictionary.

Allow Mach access to com.apple.networkd since it's used by CFNetwork.

WebProcess/com.apple.WebProcess.sb:

1:03 PM Changeset in webkit [82972] by mihaip@chromium.org

6 edits in trunk/Tools

2011-04-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Add --baseline-search-path to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56233

Add NRWT option to specify additional directories to look for baselines
(will be used by hardware GPU bots which will have local per-bot
expectations for some tests)

Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

1:03 PM Changeset in webkit [82971] by oliver@apple.com

10 edits in trunk/Source/JavaScriptCore

2011-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make caches window show more info about non-jsobject GC values
https://bugs.webkit.org/show_bug.cgi?id=57874

Add ClassInfo to the various internal JS types that currently
don't have any, and make the text for caches window show the
classname for non-JSObject instances.

runtime/Executable.cpp:
runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure): (JSC::NativeExecutable::NativeExecutable): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
runtime/Heap.cpp: (JSC::TypeCounter::typeName):
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
runtime/JSGlobalData.h:
runtime/ScopeChain.cpp:
runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure):
runtime/StructureChain.cpp:
runtime/StructureChain.h: (JSC::StructureChain::createStructure):

1:02 PM Changeset in webkit [82970] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Invalidate callbacks if the WebPageProxy is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=57873
<rdar://problem/9059717>

Audit all function calls that take callbacks and make sure to invalidate the callbacks
if the web page is no longer valid.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): (WebKit::WebPageProxy::getSourceForFrame): (WebKit::WebPageProxy::getContentsAsString): (WebKit::WebPageProxy::getSelectionOrContentsAsString): (WebKit::WebPageProxy::getMainResourceDataOfFrame): (WebKit::WebPageProxy::getResourceDataFromFrame): (WebKit::WebPageProxy::getWebArchiveOfFrame): (WebKit::WebPageProxy::forceRepaint): (WebKit::WebPageProxy::computePagesForPrinting): (WebKit::WebPageProxy::drawRectToPDF): (WebKit::WebPageProxy::drawPagesToPDF):

1:01 PM Changeset in webkit [82969] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-04-04 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Add a fast path for simple color backgrounds
https://bugs.webkit.org/show_bug.cgi?id=57773

Add a fast path for drawing simple color backgrounds. It's
faster to fill a path or rect than it is to set up a clip,
and then paint the rect.

No visible behavior change so no new tests.

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):

12:59 PM Changeset in webkit [82968] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-04-05 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r82962.

CMakeListsEfl.txt:

12:39 PM Changeset in webkit [82967] by Adam Roben

2 edits in trunk/Tools

Strip off /results.html from results URLs before trying to load leaks files from them

r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
files, rather than pointing to the directory that contains them. This is more convenient for
people browsing build.webkit.org, but confused Leaks Viewer.

Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
list don't work

Reviewed by Joseph Pecoraro.

BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.

12:33 PM Changeset in webkit [82966] by Adam Roben

6 edits
1 add in trunk/Source/WebKit2

Disable accelerated compositing on Windows machines that don't support it

This includes machines without the necessary graphics hardware, and machines without
WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots).

Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in
DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests)

Reviewed by Anders Carlsson.

WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than
Windows, this always returns true.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related
preferences if the machine supports accelerated compositing.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it
if it can draw, and returns the result.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing.

WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added.

(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to
LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false.

win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files.

12:18 PM Changeset in webkit [82965] by levin@chromium.org

2 edits in trunk/LayoutTests

2011-04-05 David Levin <levin@chromium.org>

Reviewed by Jian Li.

[chromium] send-sliced-dragged-file.html started to crash on chromium bots
https://bugs.webkit.org/show_bug.cgi?id=57539

platform/chromium/test_expectations.txt: Removed passing test as it has been fixed in the chromium network stack as of chromium r80114 and it was introduced in r79905 so no need to change the chromium deps since it is before the regression.

12:17 PM Changeset in webkit [82964] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, mark unexpectedly passing Linux Chromium tests as such.

platform/chromium/test_expectations.txt:

11:59 AM Changeset in webkit [82963] by crogers@google.com

22 edits
7 adds in trunk/Source/WebCore

2011-04-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add support for offline audio rendering to AudioContext API
https://bugs.webkit.org/show_bug.cgi?id=57676

No new tests since audio API is not yet implemented.

DerivedSources.make:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):
bindings/js/JSEventCustom.cpp: (WebCore::toJS):
bindings/js/JSEventTarget.cpp: (WebCore::toJS):
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::constructorCallback):
bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
dom/Event.cpp: (WebCore::Event::isOfflineAudioCompletionEvent):
dom/Event.h:
dom/EventTarget.cpp: (WebCore::EventTarget::toAudioContext):
dom/EventTarget.h:
platform/audio/HRTFDatabaseLoader.cpp: (WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
platform/audio/HRTFDatabaseLoader.h: (WebCore::HRTFDatabaseLoader::loader):
webaudio/AudioContext.cpp: (WebCore::AudioContext::createOfflineContext): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::constructCommon): (WebCore::AudioContext::document): (WebCore::AudioContext::scriptExecutionContext): (WebCore::AudioContext::toAudioContext): (WebCore::AudioContext::startRendering): (WebCore::AudioContext::fireCompletionEvent):
webaudio/AudioContext.h: (WebCore::AudioContext::isOfflineContext): (WebCore::AudioContext::eventTargetData): (WebCore::AudioContext::ensureEventTargetData): (WebCore::AudioContext::refEventTarget): (WebCore::AudioContext::derefEventTarget):
webaudio/AudioContext.idl:
webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::AudioDestinationNode):
webaudio/AudioDestinationNode.h: (WebCore::AudioDestinationNode::reset): (WebCore::AudioDestinationNode::numberOfChannels):
webaudio/ConvolverNode.cpp: (WebCore::ConvolverNode::setBuffer):
webaudio/DefaultAudioDestinationNode.cpp: Added. (WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::initialize): (WebCore::DefaultAudioDestinationNode::uninitialize): (WebCore::DefaultAudioDestinationNode::startRendering):
webaudio/DefaultAudioDestinationNode.h: Added. (WebCore::DefaultAudioDestinationNode::create): (WebCore::DefaultAudioDestinationNode::sampleRate):
webaudio/OfflineAudioCompletionEvent.cpp: Added. (WebCore::OfflineAudioCompletionEvent::create): (WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent):
webaudio/OfflineAudioCompletionEvent.h: Added. (WebCore::OfflineAudioCompletionEvent::renderedBuffer):
webaudio/OfflineAudioCompletionEvent.idl: Added.
webaudio/OfflineAudioDestinationNode.cpp: Added. (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::initialize): (WebCore::OfflineAudioDestinationNode::uninitialize): (WebCore::OfflineAudioDestinationNode::startRendering): (WebCore::OfflineAudioDestinationNode::renderEntry): (WebCore::OfflineAudioDestinationNode::render): (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch): (WebCore::OfflineAudioDestinationNode::notifyComplete):
webaudio/OfflineAudioDestinationNode.h: Added. (WebCore::OfflineAudioDestinationNode::create): (WebCore::OfflineAudioDestinationNode::sampleRate):

11:40 AM Changeset in webkit [82962] by Martin Robinson

28 edits
2 copies in trunk/Source

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

No new tests. This patch is only a code cleanup.

GNUmakefile.am:
platform/graphics/GraphicsContext.h: The platform context is no longer a cairo_t, but our new class the PlatformContextCairo.
platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
platform/graphics/cairo/FontCairo.cpp: Ditto.
platform/graphics/cairo/GradientCairo.cpp: Ditto.
platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical changes which now reference platformContext()->cr() to get the cairo_t.
platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the PlatformContextCairo instead of the cairo_t.
platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
platform/graphics/cairo/ImageCairo.cpp: Ditto.
platform/graphics/cairo/PathCairo.cpp: Ditto.
platform/graphics/cairo/PlatformContextCairo.cpp: Added.
platform/graphics/cairo/PlatformContextCairo.h: Added.
platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
platform/graphics/gtk/IconGtk.cpp: Ditto.
platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out m_data with a private section containing the platform context instead of just a cairo_t.
platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
plugins/gtk/PluginViewGtk.cpp: Ditto.

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

webkit/webkitwebframe.cpp: (draw_page_callback):
webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw):

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

WebFrame.cpp: (hdcFromContext): Modify this method to take PlatformContextCairo instead of a cairo_t. (WebFrame::spoolPage): Update to reflect new platform context. (WebFrame::spoolPages): Ditto.
WebFrame.h: Ditto.

11:36 AM Changeset in webkit [82961] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, mark some unexpectedly passing Chromium tests as such.

platform/chromium/test_expectations.txt:

11:01 AM Changeset in webkit [82960] by Adam Roben

8 edits in trunk/Source/WebKit2

Make accelerated compositing work in WebKit2 on Windows

LayerTreeHostCAWin uses WKCACFView to render each frame to an image, then has
DrawingAreaImpl send that image over to the UI process (just like it does for
non-accelerated rendering). It's unfortunate that this requires reading every frame back
from the GPU into system memory. More efficient solutions can be explored in the future.

Fixes <http://webkit.org/b/45567>.

Reviewed by Anders Carlsson.

DerivedSources.make: Added $(WebKit2) to the VPATH so that DerivedSources.make can be

found when used as a target dependency. Added rules to generate a HeaderDetection.h file on
Windows. If we can find WebKitQuartzCoreAdditions headers, we define HAVE_WKQCA in
HeaderDetection.h.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostNeedsDisplay):

WebProcess/WebPage/DrawingAreaImpl.h:

Added setLayerHostNeedsDisplay. Lets the layer host tell the DrawingAreaImpl that it has a
new frame to render. This should only be called by layer hosts that participate in
DrawingAreaImpl's display mechanism.

WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create): Only try to instantiate LayerTreeHostCAWin if we have
WebKitQuartzCoreAdditions, since it depends on that library.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Removed code that forced accelerated compositing to be
disabled on Windows.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::registerDummyWindowClass): Registers the window class we use for the dummy window.
(WebKit::createDummyWindow): Creates the dummy window we pass to WKCACFView so that D3D can
determine the display mode, etc. (The window is never shown on screen.)
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Initialize new members.
(WebKit::LayerTreeHostCAWin::platformInitialize): Create our dummy window and view and
associate the two. We set ourselves as the view's context's user data so that
PlatformCALayer can get our AbstractCACFLayerTreeHost pointer as needed.
(WebKit::LayerTreeHostCAWin::invalidate): Cancel any pending flushes, tear down our view,
and destroy the dummy window if no other layer host is using it.
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Ask LayerChangesFlusher to call us back
soon to perform the flush.
(WebKit::LayerTreeHostCAWin::participatesInDisplay): Added. Returns true, since we render
each frame to an image.
(WebKit::LayerTreeHostCAWin::needsDisplay): Added. Returns true if it's now time to
displayReturns true if it's now time to display.
(WebKit::LayerTreeHostCAWin::timeUntilNextDisplay): Added. Returns how many seconds remain
before we need to display again.
(WebKit::size): Added. Helper function to get the size of a WKCACFImage.
(WebKit::toShareableBitmap): Added. Helper function to convert a WKCACFImage to a
ShareableBitmap.
(WebKit::LayerTreeHostCAWin::display): Added. Renders the next frame to an image and stuffs
the image into the UpdateInfo struct.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Added. Tells the view about the new size.
(WebKit::LayerTreeHostCAWin::forceRepaint): Added. Flushes any pending changes to the view.
(WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Added. WKCACFView calls this
whenever any changes made to the view or its layer tree have been flushed. Just calls
through to contextDidChange.
(WebKit::LayerTreeHostCAWin::contextDidChange): Added. Tells layers that they've started
animating, and tells the DrawingAreaImpl that we need to display again.
(WebKit::LayerTreeHostCAWin::rootLayer): Added. Gets the root layer's PlatformCALayer.
(WebKit::LayerTreeHostCAWin::addPendingAnimatedLayer): Added. Stores the layer so that we
can tell it animations have started the next time we get a contextDidChange callback.
(WebKit::LayerTreeHostCAWin::layerTreeDidChange): Added. Schedules a flush, unless we're
already in the process of flushing. This code came from WebCore::WKCACFViewLayerTreeHost.
(WebKit::LayerTreeHostCAWin::flushPendingLayerChangesNow): Added. Performs the flush. This
code was adapted from WebCore::WKCACFViewLayerTreeHost.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Wrapped this whole header in HAVE(WKQCA),

since this class only works when WebKitQuartzCoreAdditions is available. Added a bunch of
new members.

11:01 AM Changeset in webkit [82959] by Adam Roben

3 edits in trunk/Source/WebKit2

Add a way for LayerTreeHost to participate in DrawingAreaImpl's normal display mechanism

When LayerTreeHost participates in display, it renders each frame into a bitmap.
DrawingAreaImpl sends the bitmap to the UI process in an Update message, just like in
non-accelerated compositing mode. The UI process never knows that accelerated compositing is
going on. (When LayerTreeHost does not participate in display, as on Mac, it is responsible
for getting bits from the web process to the UI process.)

No LayerTreeHost uses this mechanism (yet). This patch should cause no change in behavior.

Fixes <http://webkit.org/b/57792> LayerTreeHost needs a way to render frames to a bitmap

Reviewed by Anders Carlsson.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): If the layer tree host participates in display,
perform a display (like in the non-accelerated case).
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): Don't send an
EnterAcceleratedCompositing message to the UI process if the layer tree host participates in
display. In that case, the UI process doesn't even need to know we're using accelerated
compositing in the web process.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Go through the normal display
mechanism if we have a layer tree host that participates in display.
(WebKit::DrawingAreaImpl::didUpdate): Don't ignore DidUpdate messages when we have a layer
tree host that participates in display.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): If the new layer tree host
participates in display, let the display timer continue to run and continue to expect
DidUpdate messages so that we don't interrupt the normal display mechanism. We still clear
out m_dirtyRegion, m_scrollRect, and m_scrollOffset, though, because the layer tree host is
still responsible for keeping track of those things even when it participates in display.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): If the outgoing layer tree host
was participating in display, just send another Update message instead of an
ExitAcceleratedCompositing message, since the UI process never even knew we were using
accelerated compositing.
(WebKit::DrawingAreaImpl::displayTimerFired): If we have a layer tree host that's
participating in display, ask it when it next needs to display when scheduling our timer.

(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
If we have a layer tree host that's participating in display, it will keep track of its own
dirty region, so ask it if it needs display rather than checking our own dirty region.

(WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in
display, don't bail out. Instead, tell it to display rather than asking the page to paint.
Moved the setting of updateInfo.viewSize earlier so that it will be set even when the layer
tree host is displaying. Other changes are just due to indentation.

WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::participatesInDisplay):
(WebKit::LayerTreeHost::needsDisplay):
(WebKit::LayerTreeHost::timeUntilNextDisplay):
(WebKit::LayerTreeHost::display):
Stubbed out these functions. Derived classes can override them to participate in display.

10:49 AM Changeset in webkit [82958] by carol@webkit.org

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed.

Updated my info in committers.py

Scripts\webkitpy\common\config\committers.py

10:47 AM Changeset in webkit [82957] by carol@webkit.org

2 edits in trunk/Tools

Unreviewed.

Updated my info in committers.py

Scripts\webkitpy\common\config\committers.py

10:40 AM Changeset in webkit [82956] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 David Dorwin <ddorwin@chromium.org>

Reviewed by David Levin.

Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=57400

Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid.
Accelerated compositing may be compiled in but disabled at runtime or for some elements.

Tests: Fullscreen layout tests on Chromium.

dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): (WebCore::Document::webkitDidEnterFullScreenForElement): (WebCore::Document::webkitWillExitFullScreenForElement):

10:34 AM Changeset in webkit [82955] by enne@google.com

2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, temporarily suppress Chromium failures for tests in r82947.

platform/chromium/test_expectations.txt:

10:32 AM Changeset in webkit [82954] by yurys@chromium.org

1 edit
8 adds in trunk/Websites/webkit.org

2011-04-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add Web Inspector stack trace, pause on exception and window.onerror
screenshots.

blog-files/inspector/stack-traces-img/1.png: Added.
blog-files/inspector/stack-traces-img/2.png: Added.
blog-files/inspector/stack-traces-img/3.png: Added.
blog-files/inspector/stack-traces-img/4.png: Added.
blog-files/inspector/stack-traces-img/5.png: Added.
blog-files/inspector/stack-traces-img/6.png: Added.
blog-files/inspector/stack-traces-img/button.png: Added.

10:28 AM Changeset in webkit [82953] by Nikolas Zimmermann

3 edits
2 adds in trunk

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721

svg/text/font-size-null-assertion-expected.txt: Added.
svg/text/font-size-null-assertion.svg: Added.

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721

Properly stop layout if all metrics object refer to zero-width/height characters,
which can happen for instance when using <text font-size="0">.

Test: svg/text/font-size-null-assertion.svg

rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):

10:23 AM Changeset in webkit [82952] by morrita@google.com

35 edits in trunk/Source

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
This change also added TextCheckerClient::requestCheckingOfString() should have
TextCheckingTypeMask as a parameter to control text checking type.

WebCore.exp.in:
editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
editing/SpellChecker.cpp: (WebCore::SpellChecker::requestCheckingFor): Added a parameter. (WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object. (WebCore::SpellChecker::didCheck):
editing/SpellChecker.h:
loader/EmptyClients.h: (WebCore::EmptyTextCheckerClient::checkTextOfParagraph): (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
platform/text/TextCheckerClient.h:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Followed the signature change.

src/EditorClientImpl.h:
src/EditorClientImpl.cpp:
src/WebTextCheckingCompletionImpl.cpp

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/TextCheckerClientEnchant.h: (WebKit::TextCheckerClientEnchant::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
for requestCheckingOfString method.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (toCoreTextCheckingResults): (WebEditorClient::checkTextOfParagraph): (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]): (-[WebEditorSpellCheckResponder perform]): (WebEditorClient::requestCheckingOfString):
WebView/WebFrame.mm: (-[WebFrame markersForSelectionStartAsText]):
WebView/WebFramePrivate.h:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClientWinCE::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::requestCheckingOfString):
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::checkTextOfParagraph):

10:20 AM Changeset in webkit [82951] by Antti Koivisto

3 edits in trunk/Source/WebCore

Print stylesheet on nytimes.com loads too early
https://bugs.webkit.org/show_bug.cgi?id=57814

Reviewed by Sam Weinig.

Don't load resources with Very Low priority until there are no other resources to
load for the host (or until document is complete enough that we stop limiting requests).

No tests, this is difficult to observe reliably with our current testing infrastructure.
Verified working with Wireshark.

loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):

loader/ResourceLoadScheduler.h:

10:11 AM Changeset in webkit [82950] by steveblock@google.com

6 edits
1 copy
1 move in trunk/Source/WebCore

2011-04-04 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

JavaInstance should be a pure interface
https://bugs.webkit.org/show_bug.cgi?id=55383

This patch fixes JavaInstance for V8 only.

It factors out a JavaInstance interface which does not use JNI
types. This will allow the Java bridge to be used with objects
that don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaInstanceJobject class which
implements the interface.

No new tests, refactoring only.

Android.v8bindings.mk:
WebCore.gypi:
bridge/jni/JobjectWrapper.h:
bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::jvalueToJavaValue): (JSC::Bindings::javaValueToJvalue):
bridge/jni/v8/JavaInstanceJobjectV8.cpp: (JavaInstanceJobject::JavaInstanceJobject): (JavaInstanceJobject::~JavaInstanceJobject): (JavaInstanceJobject::begin): (JavaInstanceJobject::end): (JavaInstanceJobject::getClass): (JavaInstanceJobject::invokeMethod): (JavaInstanceJobject::getField):
bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h. (JSC::Bindings::JavaInstanceJobject::javaInstance):
bridge/jni/v8/JavaInstanceV8.h: (JSC::Bindings::JavaInstance::~JavaInstance):

10:10 AM Changeset in webkit [82949] by podivilov@chromium.org

1 edit in branches/chromium/696/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 80710 - 2011-03-09 Alexander Pavlov <apavlov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren https://bugs.webkit.org/show_bug.cgi?id=56002 * inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6793043

10:01 AM Changeset in webkit [82948] by Dimitri Glazkov

6 edits in trunk/Source/WebCore

2011-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57639

Refactoring, covered by existing tests.

dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here

from dispatchMouseEvent.

(WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method.

dom/EventDispatcher.h: Adjusted decls. (WebCore::EventDispatcher::node): Added.
dom/MouseEvent.cpp: (WebCore::MouseEvent::create): Moved useful assertion here from

dispatchMouseEvent.

(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added.
(WebCore::MouseEventDispatchMediator::event): Added.
(WebCore::MouseEventDispatchMediator::dispatchEvent): Added.

dom/MouseEvent.h: (WebCore::MouseEvent::setRelatedTarget): Added.
dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator.

9:38 AM Changeset in webkit [82947] by Nikolas Zimmermann

7 edits
8 adds in trunk

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831

Add text-tspan-02-b.svg from SVG 1.1 2nd edition, which was buggy.
Add reduced testcase, which exposes a bug with midpoint splitting, which is now fixed.

platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
platform/mac/svg/text/text-midpoint-split-bug-expected.checksum: Added.
platform/mac/svg/text/text-midpoint-split-bug-expected.png: Added.
platform/mac/svg/text/text-midpoint-split-bug-expected.txt: Added.
svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg: Added.
svg/text/text-midpoint-split-bug.svg: Added.

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831

We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering.
While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and
should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler
to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the
required memory.

Example:
<text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text>

text: A B C D E F G H
rotate="10 20 30 30 30 50 50 50"

Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg

svg/text/text-midpoint-split-bug.svg

rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an (WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase.
rendering/svg/SVGTextLayoutAttributes.cpp: (WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization). (WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder. (WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto. (WebCore::safeValueAtPosition): Ditto. (Inline helper) (WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto.
rendering/svg/SVGTextLayoutAttributes.h: Ditto.
rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): (WebCore::processRenderSVGInlineText): (WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements): (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters): (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): (WebCore::fillListAtPosition): (WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition):
rendering/svg/SVGTextLayoutAttributesBuilder.h: (WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition):

9:34 AM Changeset in webkit [82946] by leviw@chromium.org

2 edits in trunk/Source/WebCore

2011-04-05 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

DeleteButtonController is given invalid style
https://bugs.webkit.org/show_bug.cgi?id=57853

DeleteButtonController was assigned an invalid style that can lead to assertions
in debug builds. This matches up the code with its intent.

No new tests as this changes nothing on release builds.

editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):

9:22 AM Changeset in webkit [82945] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Didn't mean to land this.

Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:value:]):

9:18 AM Changeset in webkit [82944] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] EditorQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40260

This patch does not require new test cases.

editing/qt/EditorQt.cpp:

8:55 AM Changeset in webkit [82943] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: go to line dialog highlights wrong line.
https://bugs.webkit.org/show_bug.cgi?id=57845

inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):

8:36 AM Changeset in webkit [82942] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-04-05 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement CSSPropertyDirection in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=57608

No new tests required as no new functionality introduced.

css/CSSStyleApplyProperty.cpp: Add implementation class for CSSPropertyDirection
css/CSSStyleSelector.cpp: Remove existing implementation for CSSPropertyDirection
css/CSSStyleSelector.h: Add getter for element

8:21 AM Changeset in webkit [82941] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

Unreviewed. Update Qt specific expected results after r82925.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

8:10 AM Changeset in webkit [82940] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Factoring the creation of 'FunctionOnly' callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=57760

This method creates a template from an existing functionality in V8GeolocationCustom.cpp
to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

bindings/v8/V8Utilities.cpp: (WebCore::throwTypeMismatchException):
bindings/v8/V8Utilities.h: (WebCore::createFunctionOnlyCallback):
bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):

8:07 AM Changeset in webkit [82939] by Csaba Osztrogonác

2 edits in trunk/Tools

2011-04-05 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Laszlo Gombos.

[Qt] Make WebKitLibraries optional for building QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=57542

Scripts/build-webkit:

7:48 AM Changeset in webkit [82938] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MiniBrowser defaultUrl does not work
https://bugs.webkit.org/show_bug.cgi?id=57021

Match the behavior and coding of MiniBrowser to QtTestBrowser.

MiniBrowser/qt/main.cpp: (main):

7:23 AM Changeset in webkit [82937] by chang.shu@nokia.com

2 edits in trunk/LayoutTests

2011-04-05 Chang Shu <cshu@webkit.org>

Unreviewed.

Unskip passed tests after bugs 57572, 57568, 42540, 42692 have been resolved.

platform/qt-wk2/Skipped:

6:40 AM Changeset in webkit [82936] by alex

2 edits in trunk/Source/WebKit2

2011-04-05 Alejandro G. Castro <alex@igalia.com>

Another compilation fix after r82929 horrible patch merge.

UIProcess/WebPageProxy.messages.in:

6:39 AM Changeset in webkit [82935] by Nikolas Zimmermann

3 edits in trunk/Source/WebCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Switch from Vector<UChar> to StringBuilder in bindings/
https://bugs.webkit.org/show_bug.cgi?id=57838

bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyInfo):

6:38 AM Changeset in webkit [82934] by Nikolas Zimmermann

3 edits in trunk/Source/WebCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Switch from Vector<UChar> to StringBuilder in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=57837

accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition): (WebCore::AccessibilityObject::stringForVisiblePositionRange):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):

6:26 AM Changeset in webkit [82933] by alex

2 edits in trunk/Source/WebKit2

2011-04-05 Alejandro G. Castro <alex@igalia.com>

Fix compilation error after r82929.

WebProcess/WebPage/WebPage.h:

6:24 AM Changeset in webkit [82932] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-04-05 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Scripts with syntax errors are cropped in the UI
https://bugs.webkit.org/show_bug.cgi?id=57828

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessageToSource):

6:08 AM Changeset in webkit [82931] by Nikolas Zimmermann

2 edits in trunk/Source/JavaScriptCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Cleanup StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=57836

Don't use PassRefPtr in local variables, properly store in RefPtrs and release on return.
Add a makeString() variant taking 9 arguments, needed by a follow-up patch.

wtf/text/StringConcatenate.h: (WTF::tryMakeString): (WTF::makeString):

6:07 AM Changeset in webkit [82930] by Laszlo Gombos

2 edits in trunk/Tools

2011-04-05 Jade Han <jade.han@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Disable WebKitTestRunner for Symbian
https://bugs.webkit.org/show_bug.cgi?id=54977

This change is a preparation to enable building webkit2 for Symbian.
Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.

Tools.pro:

5:54 AM Changeset in webkit [82929] by alex

13 edits
2 adds in trunk/Source/WebKit2

2011-04-05 Amruth Raj <amruthraj@motorola.com>, Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230

Added functions to handle the generation of commands from the
keycodes.

GNUmakefile.am:
Scripts/webkit2/messages.py:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
UIProcess/gtk/WebView.cpp: (WebKit::backspaceCallback): (WebKit::selectAllCallback): (WebKit::cutClipboardCallback): (WebKit::copyClipboardCallback): (WebKit::pasteClipboardCallback): (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::deleteFromCursorCallback): (WebKit::moveCursorCallback): (WebKit::WebView::WebView): (WebKit::WebView::getEditorCommandsForKeyEvent):
UIProcess/gtk/WebView.h: (WebKit::WebView::addPendingEditorCommand):
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Added. (WebKit::WebEditorClient::getEditorCommandsForKeyEvent): (WebKit::WebEditorClient::executePendingEditorCommands): (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/gtk/WebPageGtk.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest):

5:52 AM Changeset in webkit [82928] by podivilov@chromium.org

2 edits
1 add in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add chromium-linux expectation for fast/ruby/overhang-vertical.html (the test changed in r82903).

platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Added.

5:43 AM Changeset in webkit [82927] by zoltan@webkit.org

2 edits in trunk/Tools

[Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
https://bugs.webkit.org/show_bug.cgi?id=57832

Reviewed by Andreas Kling.

Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.

MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

5:04 AM Changeset in webkit [82926] by podivilov@chromium.org

2 edits
2 adds in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, revert bad rebaseline of english-lr-text-expected.html in r82918.

platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
platform/chromium-win/fast/blockflow/english-lr-text-expected.png:

4:45 AM Changeset in webkit [82925] by ap@apple.com

26 edits
6 deletes in trunk

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/forms/formchange-event-expected.txt: Removed.
fast/forms/formchange-event.html: Removed.
fast/forms/forminput-event-expected.txt: Removed.
fast/forms/forminput-event.html: Removed.
fast/forms/script-tests/formchange-event.js: Removed.
fast/forms/script-tests/forminput-event.js: Removed.

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

Covered by existing tests.

dom/Document.h:
dom/Document.idl:
dom/Element.h:
dom/Element.idl:
dom/Event.cpp: (WebCore::Event::fromUserGesture):
dom/EventNames.h:
html/FormAssociatedElement.h:
html/HTMLAttributeNames.in:
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
html/HTMLElement.h:
html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::isEnumeratable):
html/HTMLFormElement.cpp:
html/HTMLFormElement.h:
html/HTMLFormElement.idl:
html/HTMLInputElement.h:
html/HTMLKeygenElement.h:
html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::isEnumeratable):
html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::isEnumeratable):
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isEnumeratable):
html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::isEnumeratable):
page/DOMWindow.h:
page/DOMWindow.idl:

4:28 AM Changeset in webkit [82924] by podivilov@chromium.org

3 edits
2 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline Kusa-Makura-background-canvas.html on chromium-mac after r82903.

platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:

4:08 AM Changeset in webkit [82923] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82915.
http://trac.webkit.org/changeset/82915
https://bugs.webkit.org/show_bug.cgi?id=57825

Broke 270 chromium tests on win and linux (Requested by
podivilov on #webkit).

rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):

4:07 AM Changeset in webkit [82922] by zoltan@webkit.org

3 edits in trunk/Tools

2011-04-05 Zoltan Horvath <zoltan@webkit.org>

[Qt] Linux Release minimal build fix after r82919.

MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::loadURLListFromFile):
QtTestBrowser/launcherwindow.cpp: (LauncherWindow::loadURLListFromFile):

3:58 AM Changeset in webkit [82921] by podivilov@chromium.org

2 edits
14 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove unnecessary checksum files for fast/ruby tests.

platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-length-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-runs-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/ruby-trailing-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
platform/chromium/test_expectations.txt:

3:35 AM Changeset in webkit [82920] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] fast/ruby/overhang* tests fail
https://bugs.webkit.org/show_bug.cgi?id=57824

platform/qt/Skipped:Add fast/ruby/overhang-horizontal.html and fast/ruby/overhang-vertical.html.

3:35 AM Changeset in webkit [82919] by zoltan@webkit.org

5 edits in trunk/Tools

2011-04-05 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Andreas Kling.

[Qt] Make URL loader accessible from testbrowser's menus
https://bugs.webkit.org/show_bug.cgi?id=57823

Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.

MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadURLListFromFile): (BrowserWindow::~BrowserWindow):
MiniBrowser/qt/BrowserWindow.h:
QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::loadURLListFromFile):
QtTestBrowser/launcherwindow.h:

3:26 AM Changeset in webkit [82918] by podivilov@chromium.org

41 edits
15 adds
14 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update fast/ruby/* chromium expectations after r82903.

platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png:
platform/chromium-linux/fast/ruby/ruby-length-expected.png:
platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
platform/chromium-linux/fast/ruby/ruby-runs-expected.png:
platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.png:
platform/chromium-linux/fast/ruby/ruby-trailing-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
platform/chromium-mac/fast/ruby/ruby-length-expected.png: Added.
platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Added.
platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Added.
platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Added.
platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Removed.
platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png:
platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt:
platform/chromium-win/fast/ruby/ruby-length-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-length-expected.png:
platform/chromium-win/fast/ruby/ruby-length-expected.txt:
platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
platform/chromium-win/fast/ruby/ruby-runs-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-runs-expected.png:
platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
platform/chromium-win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-runs-spans-expected.png:
platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
platform/chromium-win/fast/ruby/ruby-trailing-expected.checksum: Removed.
platform/chromium-win/fast/ruby/ruby-trailing-expected.png:
platform/chromium-win/fast/ruby/ruby-trailing-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.txt:

2:38 AM Changeset in webkit [82917] by hans@chromium.org

36 edits
3 moves
1 add
1 delete in trunk/Source/WebKit/chromium

2011-04-05 Hans Wennborg <hans@chromium.org>

Reviewed by Adam Barth

Clean up IndexedDB WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57507

Rename the backend proxy files that didn't have Backend in their name.
Everything in WebKit should be in the WebKit namespace.
Put everything behind the feature flag so we're consistient.
Put the feature flag #if above includes.

WebKit.gyp:
src/IDBCallbacksProxy.cpp: (WebKit::IDBCallbacksProxy::create): (WebKit::IDBCallbacksProxy::IDBCallbacksProxy): (WebKit::IDBCallbacksProxy::onError): (WebKit::IDBCallbacksProxy::onSuccess):
src/IDBCallbacksProxy.h:
src/IDBCursorBackendProxy.cpp: (WebKit::IDBCursorBackendProxy::create): (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
src/IDBCursorBackendProxy.h:
src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::create): (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::name): (WebKit::IDBDatabaseBackendProxy::version): (WebKit::IDBDatabaseBackendProxy::objectStoreNames): (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit::IDBDatabaseBackendProxy::setVersion): (WebKit::IDBDatabaseBackendProxy::transaction): (WebKit::IDBDatabaseBackendProxy::close): (WebKit::IDBDatabaseBackendProxy::open):
src/IDBDatabaseCallbacksProxy.cpp: (WebKit::IDBDatabaseCallbacksProxy::create): (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
src/IDBDatabaseCallbacksProxy.h:
src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebKit::IDBFactoryBackendProxy::open):
src/IDBFactoryBackendProxy.h:
src/IDBIndexBackendProxy.cpp: (WebKit::IDBIndexBackendProxy::create): (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
src/IDBIndexBackendProxy.h:
src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::create): (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::name): (WebKit::IDBObjectStoreBackendProxy::keyPath): (WebKit::IDBObjectStoreBackendProxy::indexNames): (WebKit::IDBObjectStoreBackendProxy::get): (WebKit::IDBObjectStoreBackendProxy::put): (WebKit::IDBObjectStoreBackendProxy::deleteFunction): (WebKit::IDBObjectStoreBackendProxy::clear): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): (WebKit::IDBObjectStoreBackendProxy::openCursor):
src/IDBObjectStoreBackendProxy.h: Added.
src/IDBObjectStoreProxy.h: Removed.
src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::create): (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebKit::IDBTransactionBackendProxy::objectStore):
src/IDBTransactionBackendProxy.h: (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::create): (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
src/IDBTransactionCallbacksProxy.h:
src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onError): (WebKit::WebIDBCallbacksImpl::onSuccess):
src/WebIDBCallbacksImpl.h:
src/WebIDBCursorImpl.cpp:
src/WebIDBCursorImpl.h:
src/WebIDBDatabaseCallbacksImpl.cpp: (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
src/WebIDBDatabaseCallbacksImpl.h:
src/WebIDBDatabaseError.cpp:
src/WebIDBDatabaseImpl.cpp:
src/WebIDBDatabaseImpl.h:
src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
src/WebIDBFactoryImpl.h:
src/WebIDBIndexImpl.cpp:
src/WebIDBIndexImpl.h:
src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
src/WebIDBKeyRange.cpp:
src/WebIDBObjectStoreImpl.cpp:
src/WebIDBObjectStoreImpl.h:
src/WebIDBTransactionCallbacksImpl.cpp:
src/WebIDBTransactionCallbacksImpl.h:
src/WebIDBTransactionImpl.cpp:
src/WebIDBTransactionImpl.h:

2:27 AM Changeset in webkit [82916] by simonjam@chromium.org

6 edits in trunk

2011-04-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Stop preload scanning CSS when it's impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664

fast/preloader/style-expected.txt:
fast/preloader/style.html: Updated to test invalid @import statements.

2011-04-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Stop preload scanning CSS when it's impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664

@import statements are only allowed at the beginning of a CSS file.
Only comments or @charset can precede them. After seeing anything else,
abort early so that we:

don't have to parse the rest of the CSS.
don't preload something that the regular parser won't load.

html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports. (WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule. (WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.

2:17 AM Changeset in webkit [82915] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-04-05 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Specify 'sans-serif' as a fallback to the default UI font
'Arial' for non-latin UI scripts (e.g. CJK).
https://bugs.webkit.org/show_bug.cgi?id=55035

No new tests, because it may still fail if the system is not configured
properly to resolve 'sans-serif' to existing real font file, thus even
manual test is hard to systematically tell it is working properly.

rendering/RenderThemeChromiumSkia.cpp

2:06 AM Changeset in webkit [82914] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 Sailesh Agrawal <sail@chromium.org>

Reviewed by Darin Fisher.

Don't clear existing files if the user cancels the file chooser dialog.
https://bugs.webkit.org/show_bug.cgi?id=55200

src/WebFileChooserCompletionImpl.cpp: (WebKit::WebFileChooserCompletionImpl::didChooseFile):

1:41 AM Changeset in webkit [82913] by tkent@chromium.org

3 edits in trunk/LayoutTests

2011-04-05 Kent Tamura <tkent@chromium.org>

Update a test affected by the behavior change of r82908.
https://bugs.webkit.org/show_bug.cgi?id=57636

fast/forms/ValidityState-tooLong-textarea-expected.txt:
fast/forms/script-tests/ValidityState-tooLong-textarea.js:

1:12 AM Changeset in webkit [82912] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 John Mellor <johnme@chromium.org>

Reviewed by Darin Fisher.

[chromium] Minor cleanup: simplify WebFrameImpl by using contentsToWindow instead of convertToContainingWindow.
https://bugs.webkit.org/show_bug.cgi?id=55681

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::scopeStringMatches):

1:07 AM Changeset in webkit [82911] by Philippe Normand

15 edits in trunk/LayoutTests

2011-04-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r82903.

platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/gtk/fast/ruby/ruby-beforeafter-expected.txt:
platform/gtk/fast/ruby/ruby-length-expected.txt:
platform/gtk/fast/ruby/ruby-run-break-expected.txt:
platform/gtk/fast/ruby/ruby-runs-expected.txt:
platform/gtk/fast/ruby/ruby-runs-spans-expected.txt:
platform/gtk/fast/ruby/ruby-trailing-expected.txt:
platform/gtk/fast/ruby/rubyDOM-insert-rt-expected.txt:
platform/gtk/fast/ruby/rubyDOM-insert-text1-expected.txt:
platform/gtk/fast/ruby/rubyDOM-insert-text2-expected.txt:
platform/gtk/fast/ruby/rubyDOM-insert-text3-expected.txt:
platform/gtk/fast/ruby/rubyDOM-remove-rt1-expected.txt:
platform/gtk/fast/ruby/rubyDOM-remove-rt2-expected.txt:
platform/gtk/fast/ruby/rubyDOM-remove-text1-expected.txt:

12:53 AM Changeset in webkit [82910] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-04-05 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

DEPS: Rolled!

12:30 AM Changeset in webkit [82909] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2011-04-05 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Alexey Proskuryakov.

Improper use of &quot in video-can-play-type layout test
https://bugs.webkit.org/show_bug.cgi?id=57728

media/video-can-play-type.html:

12:27 AM Changeset in webkit [82908] by tkent@chromium.org

3 edits
2 adds in trunk

2011-04-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636

fast/forms/textarea-set-defaultvalue-after-value-expected.txt: Added.
fast/forms/textarea-set-defaultvalue-after-value.html: Added.

2011-04-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636

If the dirty flag is true, we shouldn't update the value when the
defaultValue is updated

Test: fast/forms/textarea-set-defaultvalue-after-value.html

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged): (WebCore::HTMLTextAreaElement::setDefaultValue):

12:25 AM Changeset in webkit [82907] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815

Unreviewed buildfix after r82906.

Add UNUSED_PARAM to resourceCachesToClear, because
it is only used within #if USE(CFURLCACHE) guard.

Context Navigation

Timeline

Apr 6, 2011:

Apr 5, 2011:

Download in other formats: