⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 7, 2011:

11:49 PM Changeset in webkit [83262] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaseline after r83246.

  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:46 PM Changeset in webkit [83261] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

Not reviewed.

Rolled out some accidentally-committed changes in my last commit.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):

  • dom/EventTarget.h:
11:45 PM Changeset in webkit [83260] by commit-queue@webkit.org
  • 8 edits
    3 deletes in trunk

2011-04-07 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

EventSource should only accept UTF-8 charset
​https://bugs.webkit.org/show_bug.cgi?id=56942

  • ChangeLog-2011-02-16: Corrected previous commit message. Pointed out by Alexey.
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Updated with the new console message.
  • http/tests/eventsource/eventsource-content-type-charset-expected.txt:
  • http/tests/eventsource/eventsource-content-type-charset.html: Beefed up this test and merged the following test into it. The new tests check that we dispatch a console error if the charset is wrong.
  • http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Removed.
  • http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Removed.
  • http/tests/eventsource/resources/response-content-type-charset.php: Return the charset passed in the URL. Also added PHP's magic quotes handling as this would make the test fail on Mac.
  • http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Removed.

2011-04-07 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

EventSource should only accept UTF-8 charset
​https://bugs.webkit.org/show_bug.cgi?id=56942

Following the discussion on bug 45372, this change implements the recommended
way of handling "charset". We only accept UTF-8 but no other encoding. This matches
the encoding of the EventSource and also may fix TomCat that automatically send this
charset.

  • page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
11:34 PM Changeset in webkit [83259] by ggaren@apple.com
  • 22 edits in trunk/Source

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • bytecode/SamplingTool.h: Sorted alphabetically because that's the WebKit style. Added a Global.h #include that was previously missing but harmless.
  • collector/handles/Global.h: (JSC::Global::Global): Added a null constructor. No need for a special tag, and the tag is incompatible with some data structures.


(JSC::Global::isHashTableDeletedValue):
(JSC::Global::~Global):
(JSC::Global::set):
(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::hashTableDeletedValue): Reordered constructors to be near
each other.

(JSC::Global::setWithWriteBarrier): Renamed internalSet to
setWithWriteBarrier for clarity, and funneled more code into using set
and setWithWriteBarrier to reduce duplication.

  • collector/handles/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have boolean and ! operators.

(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle): Added general support for null Handles. This was
previously outlawed by ASSERTs, but our code has grown to support and
rely on null Handles.


  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle, and beefed this up a bit.
  • collector/handles/HandleHeap.h: (JSC::HandleHeap::globalData): Added accessor, used by some new set functions.
  • collector/handles/Local.h: Moved hash traits to the bottom of the file, since this file is about the Local class, not the traits.

(JSC::::Local): Updated for removal of invalidate().

(JSC::::operator): Deployed "using" to avoid a lot of this->
template funny business.

(JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): Updated to use null constructor.
  • jit/JITStubs.cpp: (JSC::JITThunks::hostFunctionStub):
  • runtime/JSPropertyNameIterator.h: (JSC::Structure::setEnumerationCache):
  • runtime/Structure.h: Removed clearEnumerationCache because it was an unused holdover from when the enumeration cache was not a handle.
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::set): Finish initializing our handle before putting it in the table. This seemed more logical, and at one point was required to avoid triggering an ASSERT.
  • runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own handle-like behavior, to avoid duplication.

(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::~WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::set):
(JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
standardized on Handle idioms.

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • JSRun.h:
  • JSValueWrapper.h: #include a file that was missing before, but was harmlessly so until now.

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): Updated for new null constructor. (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::NPJSObject): Updated for new null constructor.
11:34 PM Changeset in webkit [83258] by kinuko@chromium.org
  • 4 edits
    3 adds in trunk/Source/WebKit/chromium

2011-04-07 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add WebKit API to query and request unified offline-storage quota
​https://bugs.webkit.org/show_bug.cgi?id=57849
Just adding the API, this does not do anything yet.

The API is based on the public discussion for unified quota API:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
(The detail is not yet fully specified and might be subject to change.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added. (WebKit::WebFrameClient::requestStorageQuota): Added.
  • public/WebStorageQuotaCallbacks.h: Added. (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
  • public/WebStorageQuotaType.h: Added.
11:28 PM Changeset in webkit [83257] by tkent@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for xsl-blocked.php and pate-text-011.html.

  • platform/chromium/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:03 PM Changeset in webkit [83256] by tkent@chromium.org
  • 37 edits
    2 adds in trunk

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

  • fast/dom/HTMLKeygenElement/keygen-expected.txt: shadow DOM changed
  • fast/dom/HTMLKeygenElement/keygen.html: added assertion on shadow

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

Adds ShadowRoot, a list of nodes, to be a parent for top-level
shadow children. Forwards rendering through the root and into the
host's renderer.

Covered by existing tests of elements that use this style of shadow.

  • Android.mk: add ShadowRoot.h/cpp
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
  • dom/ContainerNode.cpp: parent nodes that are shadow roots are alive (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild):
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::DocumentFragment):
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): look through ShadowRoots for host's style (WebCore::Element::shadowRoot): should be const (WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
  • dom/Element.h:
  • dom/ElementRareData.h:
  • dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): indirection so ShadowRoot can forward to the host's renderer (WebCore::Node::createRendererAndStyle): (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h: (WebCore::Node::isShadowBoundary): temporary, to differentiate old- and new-style, until all roots are ShadowRoot instances
  • dom/ShadowRoot.cpp: Added. (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::recalcStyle): forward recalc to children
  • dom/ShadowRoot.h: Added. (WebCore::ShadowRoot::isShadowBoundary): (WebCore::ShadowRoot::create):
  • html/HTMLKeygenElement.cpp: use ensureShadowRoot (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::shadowSelect):
  • html/HTMLKeygenElement.h:
  • html/HTMLMeterElement.cpp: use ensureShadowRoot (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLProgressElement.cpp: use ensureShadowRoot (WebCore::HTMLProgressElement::createShadowSubtree):
  • html/InputType.cpp: use ensureShadowRoot (WebCore::InputType::destroyShadowSubtree):
  • html/RangeInputType.cpp: use ensureShadowRoot (WebCore::RangeInputType::handleMouseDownEvent): (WebCore::RangeInputType::createShadowSubtree): (WebCore::RangeInputType::valueChanged): (WebCore::RangeInputType::shadowSliderThumb):
  • html/RangeInputType.h:
  • html/ValidationMessage.cpp: use ensureShadowRoot (WebCore::ValidationMessage::buildBubbleTree): (WebCore::ValidationMessage::deleteBubbleTree):
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromPoint): (WebCore::SliderThumbElement::hostInput):
  • html/shadow/SliderThumbElement.h:
  • rendering/MediaControlElements.cpp: use ensureShadowRoot (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle):
  • rendering/RenderSlider.cpp: use ensureShadowRoot (WebCore::RenderSlider::thumbRect): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::shadowSliderThumb): (WebCore::RenderSlider::inDragMode):
  • rendering/RenderSlider.h:

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

  • src/WebElement.cpp: (WebKit::WebElement::shadowRoot): shadow roots are ContainerNodes now
11:01 PM Changeset in webkit [83255] by mjs@apple.com
  • 5 edits
    2 adds in trunk

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r80871): Crash when visiting ​http://broadband.biglobe.ne.jp/
​https://bugs.webkit.org/show_bug.cgi?id=56297
<rdar://problem/9131597>

Test: fast/css-generated-content/table-row-after-no-crash.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after content, and only do it if the row already has a parent. For construction of anonymous cells to work correctly, the row needs to already have a parent, so in that case wait a bit. (WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): When adding a row, update its before/after content, in case it had any.

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r80871): Crash when visiting ​http://broadband.biglobe.ne.jp/
​https://bugs.webkit.org/show_bug.cgi?id=56297
<rdar://problem/9131597>

  • fast/css-generated-content/table-row-after-no-crash-expected.txt: Added.
  • fast/css-generated-content/table-row-after-no-crash.html: Added.
10:52 PM Changeset in webkit [83254] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Probable fix for <rdar://problem/9251443> Crashing on exception: -
[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized
selector sent to instance ADDRESS.

Reviewed by Simon Fraser.

Need to implement new delegate method.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):

10:38 PM Changeset in webkit [83253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 Ian Henderson <​ianh@apple.com>

Reviewed by Simon Fraser.

Optimize filling rounded rects that are actually ellipses
​https://bugs.webkit.org/show_bug.cgi?id=58098

In CG, drawing an ellipse directly is faster than constructing and
filling a rounded rect path. Detect when the given rounded rect is
actually an ellipse and draw it directly in this case.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
9:59 PM Changeset in webkit [83252] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-07 Magnus Danielsson <​public@fuzzac.com>

Reviewed by Darin Fisher.

[chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly
​https://bugs.webkit.org/show_bug.cgi?id=53897

When serializing a web page using 'save page as', sub-frames and resources gets
saved in a sub-directory. However, frame elements didn't get updated to reference
these saved sub-frames, but were still referencing the original url. So when opening
a saved web page, any sub-frames would get pulled in from the original url rather than
what was saved.

In addition to this, sub-frames in the sub-directory erroneously had the name of the
sub-directory prepended to the path of resources located in the same sub-directory.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToStrne: Fixed resource paths in sub-frames. Also made sure sub-frames are referenced correctly from parent frame. (WebKit::WebPageSerializerImpl::endTagToString): Removed constness from argument. (WebKit::WebPageSerializerImpl::buildContentForNode): Ditto.
  • src/WebPageSerializerImpl.h:
9:38 PM Changeset in webkit [83251] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-07 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

CTLine objects should outlive their CTRuns
​https://bugs.webkit.org/show_bug.cgi?id=58063

  • platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.
9:32 PM Changeset in webkit [83250] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-07 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Change reference port for Mac GPU baselines from
Leopard to SnowLeopard, XP to Win7, and Linux-x86
to Linux x86-64.

​https://bugs.webkit.org/show_bug.cgi?id=58099

  • Scripts/webkitpy/layout_tests/port/chromium.py:
9:32 PM Changeset in webkit [83249] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk/Source

2011-04-07 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Compositor thread infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=56131

Introduce chrome compositor thread and related
infrastructure.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCMainThread.cpp: Added. (WebCore::CCMainThread::performTask): (WebCore::CCMainThread::postTask):
  • platform/graphics/chromium/cc/CCMainThread.h: Added. (WebCore::CCMainThread::Task::~Task): (WebCore::CCMainThread::Task::instance): (WebCore::CCMainThread::Task::Task):
  • platform/graphics/chromium/cc/CCMainThreadTask.h: Added. (WebCore::MainThreadTask0::create): (WebCore::MainThreadTask0::MainThreadTask0): (WebCore::MainThreadTask0::performTask): (WebCore::MainThreadTask1::create): (WebCore::MainThreadTask1::MainThreadTask1): (WebCore::MainThreadTask1::performTask): (WebCore::MainThreadTask2::create): (WebCore::MainThreadTask2::MainThreadTask2): (WebCore::MainThreadTask2::performTask): (WebCore::MainThreadTask3::create): (WebCore::MainThreadTask3::MainThreadTask3): (WebCore::MainThreadTask3::performTask): (WebCore::createMainThreadTask):
  • platform/graphics/chromium/cc/CCThread.cpp: Added. (WebCore::CCThread::create): (WebCore::CCThread::CCThread): (WebCore::CCThread::~CCThread): (WebCore::CCThread::postTask): (WebCore::CCThread::compositorThreadStart): (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThread.h: Added. (WebCore::CCThread::Task::~Task): (WebCore::CCThread::Task::instance): (WebCore::CCThread::Task::Task): (WebCore::CCThread::threadID): (WebCore::CCCompletionEvent::CCCompletionEvent): (WebCore::CCCompletionEvent::~CCCompletionEvent): (WebCore::CCCompletionEvent::wait): (WebCore::CCCompletionEvent::signal):
  • platform/graphics/chromium/cc/CCThreadTask.h: Added. (WebCore::CCThreadTask0::create): (WebCore::CCThreadTask0::CCThreadTask0): (WebCore::CCThreadTask0::performTask): (WebCore::CCThreadTask1::create): (WebCore::CCThreadTask1::CCThreadTask1): (WebCore::CCThreadTask1::performTask): (WebCore::CCThreadTask2::create): (WebCore::CCThreadTask2::CCThreadTask2): (WebCore::CCThreadTask2::performTask): (WebCore::CCThreadTask3::create): (WebCore::CCThreadTask3::CCThreadTask3): (WebCore::CCThreadTask3::performTask): (WebCore::createCCThreadTask):

2011-04-07 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Compositor thread infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=56131

Tests for chrome compositor thread and related infrastructure.

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/CCThreadTaskTest.cpp: Added. (WebCore::TEST):
  • tests/CCThreadTest.cpp: Added. (WebCore::TEST): (WebCore::PingPongUsingCondition::ping): (WebCore::PingPongTestUsingTasks::ping): (WebCore::PingPongTestUsingTasks::pong):
  • tests/RunAllTests.cpp: (main):
9:30 PM Changeset in webkit [83248] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Martin Robinson.

Refactor Gtk build system to separate list of files
​https://bugs.webkit.org/show_bug.cgi?id=58090

This is the first step towards generating part of the GTK build system
using GYP. In the first iteration, our plan is to just generate the
list of files. This patch is the first step, which is to separate out
the part of JavaScriptCore build system that we intend to generate from
the rest of the build system.

  • GNUmakefile.am:
  • GNUmakefile.list.am: Added.
9:11 PM Changeset in webkit [83247] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

Added tests to ensure WebKit inserts a paragraph separator properly around tab span.

  • editing/inserting/insert-div-021-expected.txt: No longer duplicates span[id="test"] incorrectly.
  • editing/inserting/insert-paragraph-after-tab-span-and-text-expected.txt: Added.
  • editing/inserting/insert-paragraph-after-tab-span-and-text.html: Added.
  • editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
  • editing/inserting/insert-paragraph-separator-tab-span.html: Added.
  • editing/inserting/insert-paragraph-at-end-of-line-expected.txt: No longer duplicates a[id="anchor"] incorrectly.

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.

Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
before moving the nodes.

Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html

editing/inserting/insert-paragraph-separator-tab-span.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span, no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph separator into a paragraph separator.
  • editing/htmlediting.cpp: (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent node after the tab span if the position was at the end of the tab span.
  • editing/htmlediting.h:
9:02 PM Changeset in webkit [83246] by rniwa@webkit.org
  • 3 edits
    1 move
    1 add
    24 deletes in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
​https://bugs.webkit.org/show_bug.cgi?id=58078

Converted the tests.

  • editing/pasteboard/paste-text-001-expected.txt: Added.
  • editing/pasteboard/paste-text-001.html:
  • editing/pasteboard/paste-text-011-expected.txt: Added.
  • editing/pasteboard/paste-text-011.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.
8:59 PM Changeset in webkit [83245] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-07 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

[Mac] Editor::setComposition() should not trigger correction panel timer.
​https://bugs.webkit.org/show_bug.cgi?id=58049

<rdar://problem/9226305>

On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().

No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
autocorrection panel timer, which can not be easily done in automated fashion.

  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition):
  • editing/EditorCommand.cpp: (WebCore::executeDelete):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::typingAddedToOpenCommand):
  • editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::setShouldPreventSpellChecking):
8:51 PM Changeset in webkit [83244] by tkent@chromium.org
  • 7 edits
    2 copies
    1 add
    4 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for r83216 and r83235.

  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/foreign-object-skew-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium/test_expectations.txt:
8:21 PM Changeset in webkit [83243] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

Forgot to add them to the original patch.

  • fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
  • fast/css/webkit-empty-transform-preserve3d-crash.html: Added.
8:09 PM Changeset in webkit [83242] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

clearIfComposited call is really slow
​https://bugs.webkit.org/show_bug.cgi?id=57999

Move getContextAttributes call after the if, so it isn't called nearly as often.

No new tests.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clearIfComposited):
7:33 PM Changeset in webkit [83241] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-07 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement Backgroun and Mask properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=57922

No tests added as no behavioral changes.

  • css/CSSStyleApplyProperty.cpp: Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added constructor calls to set up: CSSPropertyBackgroundAttachment CSSPropertyBackgroundClip CSSPropertyWebkitBackgroundClip CSSPropertyWebkitBackgroundComposite CSSPropertyBackgroundOrigin CSSPropertyWebkitBackgroundOrigin CSSPropertyBackgroundSize CSSPropertyWebkitBackgroundSize CSSPropertyWebkitMaskAttachment CSSPropertyWebkitMaskClip CSSPropertyWebkitMaskComposite CSSPropertyWebkitMaskOrigin CSSPropertyWebkitMaskSize
  • css/CSSStyleApplyProperty.h: (WebCore::CSSStyleApplyProperty::setPropertyValue): Add function to specify an equivalent property value in the lookup table.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove sections now implemented by CSSStyleApplyProperty.
  • css/CSSStyleSelector.h: Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.
7:12 PM Changeset in webkit [83240] by eric@webkit.org
  • 11 edits
    1 add in trunk/Source/WebCore

2011-04-04 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split run storage out from BidiResolver into a new BidiRunList class
​https://bugs.webkit.org/show_bug.cgi?id=57764

Part of what makes BidiResolver and InlineIterator so difficult to understand
(and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
BidiRuns from the algorithm. This patch breaks the storage aspect off
into its own class BidiRunList.

This patch is only a start. It does not actually fix the problematic ownership
relationship, but it does make it possible to fix such in a second patch.

The run pointers and addRun/prependRun, etc. were already a tightly coupled
logical subset of the BidiResolver class, so moving them into their own class
was both obvious and easy. The only piece of logic I had to move was that
deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.

I believe this deleteRuns side-effect was only ever used for one place
(right after findNextLineBreak) and that it's only needed because
findNextLineBreak can sometimes create bidi runs. Run creation appears to be
an unintentional side-effect of how InlineIterator calls through to BidiResolver
as part of bidiNext and not a desired effect of the code. I have added the call
to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
could get re-used) as a safety precaution. We could replace both with ASSERTs
in a later patch.

I suspect there may be a small performance win from further refactoring so that
findNextLineBreak does not need to create BidiRuns.

As I commented in the code, callers should own their own BidiRunList which they
pass to BidiResolver::createBidiRunsForLine. I attempted to implement that in
an earlier version of this patch, but it was too complicated with the current
twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
raise/lowerExplicitEmbeddingLevel are called unconditionally
from commitExplicitEmbedding (which is called by bidiNext) and expect to have
access to a runs list even in cases where we don't want any runs (findNextLineBreak).

I also cleaned up some of the callers to pass around BidiRunList objects instead
of InlineBidiResolvers now that they're separate objects.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText):
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::BidiResolver): (WebCore::BidiResolver::runs): (WebCore::BidiResolver::markCurrentRunEmpty): (WebCore::::appendRun): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::reorderRunsFromLevels): (WebCore::::createBidiRunsForLine):
  • rendering/InlineIterator.h: (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::createRun): (WebCore::RenderBlock::appendRunsForObject): (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren):
7:05 PM Changeset in webkit [83239] by enne@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, add baseline pixel images for decorations-transformed.

  • platform/chromium-mac/fast/text/decorations-transformed-expected.png: Added.
  • platform/chromium-win/fast/text/decorations-transformed-expected.png: Added.
6:50 PM Changeset in webkit [83238] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Max build fix.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Do not risk an overflow.
(WebKit::WebEditorClient::checkGrammarOfString):
Ditto.

6:18 PM Changeset in webkit [83237] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-07 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Adam Barth.

[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
​https://bugs.webkit.org/show_bug.cgi?id=57911
​http://code.google.com/p/chromium/issues/detail?id=78073

Manual test added: manual-tests/autofill-popup-location.html

Originally only height is checked so that it introduces the bug.
So I changed it to check both width and height as size.

  • manual-tests/autofill-popup-location.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
6:09 PM Changeset in webkit [83236] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

6:08 PM Changeset in webkit [83235] by abarth@webkit.org
  • 5 edits
    14 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement img-src style-src and font-src
​https://bugs.webkit.org/show_bug.cgi?id=58018

Test a bunch of allow/block tests for these new directives.

  • http/tests/security/contentSecurityPolicy/image-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/blue.css: Added.
  • http/tests/security/contentSecurityPolicy/resources/style.xsl: Added.
  • http/tests/security/contentSecurityPolicy/style-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/style-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/style-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/xsl-allowed.php: Added.
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/xsl-blocked.php: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement img-src style-src and font-src
​https://bugs.webkit.org/show_bug.cgi?id=58018

These are pretty straight forward given the rest of the infrastructure
we've built so far.

Tests: http/tests/security/contentSecurityPolicy/image-allowed.html

http/tests/security/contentSecurityPolicy/image-blocked.html
http/tests/security/contentSecurityPolicy/style-allowed.html
http/tests/security/contentSecurityPolicy/style-blocked.html
http/tests/security/contentSecurityPolicy/xsl-allowed.php
http/tests/security/contentSecurityPolicy/xsl-blocked.php

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
5:55 PM Changeset in webkit [83234] by levin@chromium.org
  • 4 edits in trunk/Source/WebCore

Make IconSnapshot and PageURLRecord member variables private.
​https://bugs.webkit.org/show_bug.cgi?id=58080

Reviewed by Darin Adler.

No change in functionality so no new tests.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.

  • loader/icon/IconRecord.h:

(WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
(WebCore::IconSnapshot::iconURL): Expose the property.
(WebCore::IconSnapshot::timestamp): Ditto.
(WebCore::IconSnapshot::data): Ditto.

  • loader/icon/PageURLRecord.h:

(WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
(WebCore::PageURLSnapshot::pageURL): Expose the property.
(WebCore::PageURLSnapshot::iconURL): Ditto.

5:48 PM Changeset in webkit [83233] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated comment in skipped list to
include the bug that tracks the changes required
in WebKitTestRunner.

  • platform/win-wk2/Skipped:
5:38 PM Changeset in webkit [83232] by jberlin@webkit.org
  • 19 edits
    4 adds in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Brian Weinstein.

Part 4: Implement checkGrammarOfString.

  • Scripts/webkit2/messages.py:

The generated files should include TextCheckerClient.h for WebCore::GrammarDetail.

  • Shared/API/c/win/WKBaseWin.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/win/WKAPICastWin.h:
  • UIProcess/API/C/win/WKGrammarDetail.cpp: Added.

(WKGrammarDetailGetTypeID):
(WKGrammarDetailCreate):

  • UIProcess/API/C/win/WKGrammarDetail.h: Added.
  • UIProcess/API/C/win/WKTextChecker.h:

Add the checkGrammarOfString WKTextCheckerClient function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkGrammarOfString):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Call the TextCheckerClient.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkSpellingOfString):
Add a comment about this not being used on Mac.
(WebKit::TextChecker::checkGrammarOfString):
Ditto, and call notImplemented.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Call notImplemented.

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Ditto.

  • UIProcess/win/WebGrammarDetail.cpp: Added.

(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
Initialize the underlying WebCore::GrammarDetail.

  • UIProcess/win/WebGrammarDetail.h: Added.

(WebKit::WebGrammarDetail::grammarDetail):
(WebKit::WebGrammarDetail::type):

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::checkGrammarOfString):
Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails.

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Use WTF::notFound as the initial value for resultLocation.
(WebKit::WebEditorClient::checkGrammarOfString):
Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph).

  • win/WebKit2.vcproj:

Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp.

  • win/WebKit2Generated.make:

Copy over WKGrammarDetail.h.

5:22 PM Changeset in webkit [83231] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/696

Merge 83209
BUG=77463

4:47 PM Changeset in webkit [83230] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Mapping booleans the same way as integers
​https://bugs.webkit.org/show_bug.cgi?id=56913

Patch by Zoltan Herczeg <​zherczeg@webkit.org> on 2011-04-07
Reviewed by Gavin Barraclough.

Instead of having a seperate tag field for booleans,
the logical values are stored in the payload field
(for JSValue32_64 representation).

1.007x speedup on SunSpider.

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitStoreBool):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JSInterfaceJIT.h:
  • runtime/JSValue.h:

(JSC::JSValue::JSValue):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::getBoolean):

4:46 PM Changeset in webkit [83229] by enrica@apple.com
  • 5 edits in trunk/Source/WebKit2

REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows).
​https://bugs.webkit.org/show_bug.cgi?id=58056
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Windows.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebUndoClient.cpp:

(WebKit::WebUndoClient::canUndoRedo):
(WebKit::WebUndoClient::executeUndoRedo):

  • UIProcess/win/WebUndoClient.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

4:38 PM Changeset in webkit [83228] by dbates@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-07 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Add a layout test to ensure that mousemove is fired from a subframe
​https://bugs.webkit.org/show_bug.cgi?id=58094

  • fast/events/iframe-onmousemove-expected.txt: Added.
  • fast/events/iframe-onmousemove.html: Added.
  • fast/events/resources/iframe-onmousemove.html: Added.
4:30 PM Changeset in webkit [83227] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Decrease flakiness of test results.

  • platform/qt-wk2/Skipped:
    • Add canvas tests not to break css2.1 tests.
    • Remove passing css2.1 tests.
4:07 PM Changeset in webkit [83226] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

4:03 PM Changeset in webkit [83225] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This adds support for a new --port argument and plumbs through
the necessary paths to allow generating for a port other than Mac.

  • Source/gyp/configure:

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable JavaScriptCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

  • gyp/gtk.gyp: Added.

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable WebCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

  • gyp/gtk.gyp: Added.
3:52 PM Changeset in webkit [83224] by Lucas Forschler
  • 1 copy in tags/Safari-534.28

New tag.

3:51 PM Changeset in webkit [83223] by scherkus@chromium.org
  • 27 edits
    3 deletes in trunk

2011-04-07 Andrew Scherkus <​scherkus@chromium.org>

Revert ENABLE_TRACK patch due to compile failures.

3:38 PM Changeset in webkit [83222] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Add failing legacy full screen tests to the gtk/Skipped list.

  • platform/gtk/Skipped:
3:33 PM Changeset in webkit [83221] by hyatt@apple.com
  • 6 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57736

Reviewed by Dan Bernstein.

Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
layout finished. This would eventually lead to an inability to properly determine the correct layout root and
would cause a deleted root to be used later on.

Added fast/block/positioning/complex-positioned-movement.html.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):
Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):
Change simplified layout so that the positioned movement optimization no longer clears the other layout
flags. This will ensure that we still lay out our descendants if they need it.

(WebCore::RenderBlock::layoutPositionedObjects):
Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
no longer does the clear.

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure. On success it no longer
does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
the other flags in case other kinds of layout are still needed.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.

LayoutTests:

  • fast/block/positioning/complex-positioned-movement.html: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.png: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
3:23 PM Changeset in webkit [83220] by scherkus@chromium.org
  • 27 edits
    3 adds in trunk

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • configure.ac:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

No new tests. No real functionality added just yet.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Added. (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::create): (WebCore::HTMLTrackElement::insertedIntoTree): (WebCore::HTMLTrackElement::willRemove): (WebCore::HTMLTrackElement::src): (WebCore::HTMLTrackElement::setSrc): (WebCore::HTMLTrackElement::kind): (WebCore::HTMLTrackElement::setKind): (WebCore::HTMLTrackElement::srclang): (WebCore::HTMLTrackElement::setSrclang): (WebCore::HTMLTrackElement::label): (WebCore::HTMLTrackElement::setLabel): (WebCore::HTMLTrackElement::isDefault): (WebCore::HTMLTrackElement::setIsDefault): (WebCore::HTMLTrackElement::isURLAttribute):
  • html/HTMLTrackElement.h: Added.
  • html/HTMLTrackElement.idl: Added.

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • features.gypi:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Scripts/build-webkit:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
3:21 PM Changeset in webkit [83219] by tony@chromium.org
  • 8 edits
    2 adds in trunk/Tools

2011-04-07 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

update DRT to embed checksums in png files
​https://bugs.webkit.org/show_bug.cgi?id=57871

We insert the bytes for the comment in printPNG rather than at encode
time because each platform does its own PNG encoding (either using CG
or cairo). Putting this in pringPNG avoids having to duplicate this
code, although it's not as clean as doing it at encoding time.

We insert the comment right after the IHDR chunk of the PNG.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/CyclicRedundancyCheck.cpp: Added. (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
  • DumpRenderTree/CyclicRedundancyCheck.h: Added.
  • DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): (convertChecksumToPNGComment): Generate the bytes to insert. (printPNG): Insert the png comment before the first IDAT section.
  • DumpRenderTree/PixelDumpSupport.h:
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: (printPNG): (dumpBitmap):
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): (dumpBitmap):
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • GNUmakefile.am:
3:17 PM Changeset in webkit [83218] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Martin Robinson <​mrobinson@igalia.com>

Fix the WebKit2 GTK+ build for older versions of GTK+.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header.
3:16 PM Changeset in webkit [83217] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Fix whitespace in GNUmakefile.am.

  • GNUmakefile.am:
3:15 PM Changeset in webkit [83216] by mitz@apple.com
  • 9 edits
    4 adds in trunk

<rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor
​https://bugs.webkit.org/show_bug.cgi?id=58083

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/text/decorations-transformed.html

  • platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides

is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
the width and the height. In this new mode, translating a rectangle in user space never changes
its dimensions in device pixels.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
(WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
all underlines have the same thickness in device pixels.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

  • fast/text/decorations-transformed.html: Added.
  • platform/mac/fast/text/decorations-transformed-expected.checksum: Added.
  • platform/mac/fast/text/decorations-transformed-expected.png: Added.
  • platform/mac/fast/text/decorations-transformed-expected.txt: Added.
3:11 PM Changeset in webkit [83215] by Martin Robinson
  • 9 edits
    3 moves
    2 adds
    1 delete in trunk/Source/WebKit2

2011-04-07 Amruth Raj <​amruthraj@motorola.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[GTK] Implement SharedMemory for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=49791

Share the SharedMemory, Attachment and Connection implementations with the Qt port.
Both implementation are, in fact, general Unix implementations using standard Unix
domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code
greatly and lay the groundwork for GTK+/Qt implementations for other operating systems.

  • GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones.
  • Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK. (CoreIPC::ArgumentDecoder::~ArgumentDecoder):
  • Platform/CoreIPC/ArgumentEncoder.cpp: Ditto. (CoreIPC::ArgumentEncoder::~ArgumentEncoder):
  • Platform/CoreIPC/Attachment.h: Ditto.
  • Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections.
  • Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp.
  • Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt.
  • WebKit2.pro: Updated source list to reflect file renaming.
2:52 PM Changeset in webkit [83214] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Add the media/media-fullscreen-inline.html test to the mac-snowleopard Skipped list.

The legacy full screen API now redirects to the new full screen API, breaking the media-fullscreen-inline.html
test.

  • platform/mac-snowleopard/Skipped:
2:51 PM Changeset in webkit [83213] by vitalyr@chromium.org
  • 5 edits
    2 adds in trunk

2011-04-06 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Remove custom DOMImplementation getter on Document.
​https://bugs.webkit.org/show_bug.cgi?id=57991

The custom getter is no longer required because DOMImplementation
objects are now created per document.

Test: fast/dom/DOMImplementation/implementation-identity.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • dom/Document.idl:

2011-04-06 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Remove custom DOMImplementation getter on Document.
​https://bugs.webkit.org/show_bug.cgi?id=57991

  • fast/dom/DOMImplementation/implementation-identity-expected.txt: Added.
  • fast/dom/DOMImplementation/implementation-identity.html: Added.
2:44 PM Changeset in webkit [83212] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix a couple of typos in comments that Darin spotted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_not):

  • runtime/JSImmediate.h:
2:43 PM Changeset in webkit [83211] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Brian Weinstein.

REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection()
​https://bugs.webkit.org/show_bug.cgi?id=58082

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection): Now that the Range is used outside the full expression where it's created, it needs to be protected with RefPtr.
2:19 PM Changeset in webkit [83210] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

2011-04-07 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Make various video layout tests platform independent by selecting an appropriate media file.

Various layout tests depend on mp4 files.
​https://bugs.webkit.org/show_bug.cgi?id=57804

  • http/tests/media/remove-while-loading.html:
  • http/tests/media/video-load-and-stall.cgi:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-seekable-stall.html:
  • media/media-file.js: (mimeTypeForFile): (stripExtension):
  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [83209] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-04-07 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

setHasID() is only called for styled elements
​https://bugs.webkit.org/show_bug.cgi?id=57267

Test: fast/dom/non-styled-element-id-crash.html

  • dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::idAttributeChanged):
  • dom/Element.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):

2011-04-07 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

setHasID() is only called for styled elements
​https://bugs.webkit.org/show_bug.cgi?id=57267

  • fast/dom/non-styled-element-id-crash-expected.txt: Added.
  • fast/dom/non-styled-element-id-crash.html: Added.
  • svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix the failing test.
2:11 PM Changeset in webkit [83208] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
​https://bugs.webkit.org/show_bug.cgi?id=58070

Make the HTMLMediaElement full screen functions call into the new Full Screen API when
FULLSCREEN_API is enabled.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::exitFullscreen):
2:10 PM Changeset in webkit [83207] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Fix a typo in the Skipped list from r83203.

  • platform/win-wk2/Skipped:
1:58 PM Changeset in webkit [83206] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's current item index
doesn't account for items removed by filter callback.

Reviewed by Dan Bernstein.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index
when we omit an item due to the filter callback.

1:51 PM Changeset in webkit [83205] by abarth@webkit.org
  • 4 edits
    4 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CSP's options directive
​https://bugs.webkit.org/show_bug.cgi?id=58014

  • http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CSP's options directive
​https://bugs.webkit.org/show_bug.cgi?id=58014

This patch contains the full options parser, but we only have enough of
CSP implemented to see the effects of disable-xss-protection. Will
need to do some more work before we can see eval-script in action.

Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html

http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPOptions::CSPOptions): (WebCore::CSPOptions::disableXSSProtection): (WebCore::CSPOptions::evalScript): (WebCore::CSPOptions::parse): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:48 PM Changeset in webkit [83204] by ap@apple.com
  • 15 edits
    4 adds in trunk/Source

Reviewed by Anders Carlsson.

REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
​https://bugs.webkit.org/show_bug.cgi?id=58066
<rdar://problem/8965302>

  • Scripts/webkit2/messages.py:
  • Shared/mac/AttributedString.h: Added.
  • Shared/mac/AttributedString.mm: Added. (WebKit::AttributedString::encode): (WebKit::AttributedString::decode): Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF or NS object to another process without wrapping it in a C++ one.


  • Shared/mac/ArgumentCodersMac.h: Added.
  • Shared/mac/ArgumentCodersMac.mm: Added. Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why these are needed: 1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't work properly for them (I've been just getting 1). 2) NSColor isn't toll free bridged to CF. This adds just the types necessary for editing NSAttributedString (and I don't yet know what happens with attachments).
  • UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::getAttributedSubstringFromRange):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Boilerplate code for making a sync call to web process.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange): Ported from WebHTMLView.
1:40 PM Changeset in webkit [83203] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.
Adding to skipped list for Windows (WK2) the
tests relative to undo removed from the skipped list
for Mac where execCommand('undo') is now supported.

  • platform/win-wk2/Skipped:
1:36 PM Changeset in webkit [83202] by enne@google.com
  • 6 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline progress element tests.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium/test_expectations.txt:
1:23 PM Changeset in webkit [83201] by aestes@apple.com
  • 12 edits
    1 add in trunk/Source

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794


Outlook populates a reply message by creating an empty WebView and
using DOM API to populate the WebView's empty document with content
from the original message. It expects the initial empty document to
simply be "<html></html>", and it proceeds to dynamically create and
append a BODY node and add the original message content as a child of
that node. Outlook then takes the innerHTML of the frame's first body
element and copies it into a *new* document that is displayed and
edited in the reply message window.


Due to implementing the HTML5 tree building algorithm in r64712,
initial empty documents went from being "<html></html>" to being
"<html><head></head><body></body></html>". Outlook still dynamically
creates a BODY node to parent the original message content, but this
BODY node duplicates the one created by the tree builder. When Outlook
then takes the innerHTML of the first body element to populate the
reply message window it gets the empty body element created by the
parser, not the one it created with the original message content.


Fix this by injecting a user script into the initial empty document
that removes the HEAD and BODY nodes created by the parser. This
ensures that the BODY created by Outlook is the only BODY in the
document.

  • Misc/OutlookQuirksUserScript.js: Added.
  • WebView/WebView.mm: (leakMailQuirksUserScriptContents): (-[WebView _injectMailQuirksScript]): (needsOutlookQuirksScript): (leakOutlookQuirksUserScriptContents): (-[WebView _injectOutlookQuirksScript]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794


  • WebCore.exp.in:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts() before checking if the FrameLoader is parsing the initial empty document. This allows user scripts to be injected at the end of document parsing (if the setting is enabled).
  • page/Frame.cpp: (WebCore::Frame::injectUserScripts): Do not inject scripts if this feature is disabled on the initial empty document.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Add a setting for injecting user scripts into the initial empty document (defaults to false). (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument): (WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsMicrosoftOutlook): Check if the embedding application is Microsoft Outlook.
1:18 PM Changeset in webkit [83200] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix.

  • Shared/WebString.h:

(WebKit::WebString::getCharacters): Add explict cast when using std::min().

1:09 PM Changeset in webkit [83199] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; rebaseline expected results in platform/mac-wk2.

  • platform/mac-wk2/media/controls-without-preload-expected.txt:
12:49 PM Changeset in webkit [83198] by jeffm@apple.com
  • 6 edits in trunk

2011-04-07 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=58058

  • TestWebKitAPI/Tests/WebKit2/WKString.cpp: (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().

2011-04-07 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=58058


WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.

  • Shared/API/c/WKString.cpp: (WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
  • Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
  • Shared/WebString.h: (WebKit::WebString::getCharacters): Added.
12:42 PM Changeset in webkit [83197] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: Support window bounce when panning.
​https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>

Reviewed by Adam Roben.

Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.

If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to

an end of the document, and if we have, bounce the window.

  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical

scrollbar and if we are at the beginning or the end of the scrollable document.

12:30 PM Changeset in webkit [83196] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

2011-04-06 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
​https://bugs.webkit.org/show_bug.cgi?id=57962

Add support for a new AVPlayerItem API which will notify clients when their
seek completes. This requires a new Notification type to be passed to the main
thread in MediaPlayerPrivateAVFoundation.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added. (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new

overloaded functions which take a Notification; and a Notification::Type and boolean.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted

Notification type.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor. (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API. (-[WebCoreAVFMovieObserver seekCompleted:]): Added.
12:17 PM Changeset in webkit [83195] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleIsPageBoxVisible):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isPageBoxVisible):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::isPageBoxVisible):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
11:56 AM Changeset in webkit [83194] by enrica@apple.com
  • 17 edits in trunk

Source/WebKit2: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
​https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Mac.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
(WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.

Added new empty PageClient methods for other platforms.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::canUndoRedo):
(QWKPagePrivate::executeUndoRedo):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/gtk/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

  • UIProcess/gtk/WebView.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

  • UIProcess/win/WebView.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
of asychronous messages while waiting for a sync message reply.
(WebKit::WebEditCommandProxy::reapply): Same as above.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.

(WebKit::WebEditorClient::canUndo):
(WebKit::WebEditorClient::canRedo):
(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):

LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
​https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

  • platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo.
11:54 AM Changeset in webkit [83193] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/9250368> and ​https://bugs.webkit.org/show_bug.cgi?id=58062

Reviewed by Maciej Stachowiak.

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseClose):

  • UIProcess/API/C/WKIconDatabase.h:


  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::close):

  • UIProcess/WebIconDatabase.h:
11:51 AM Changeset in webkit [83192] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 58057 - Store boolean payload in low bit of JSImmediate

Reviewed by Geoff Garen.

And remove some uncalled functions from JSImmediate.h

  • jit/JITInlineMethods.h:

(JSC::JIT::emitTagAsBoolImmediate):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_not):

  • runtime/JSImmediate.h:

(JSC::JSImmediate::makeInt):
(JSC::JSImmediate::makeBool):
(JSC::JSImmediate::intValue):
(JSC::JSImmediate::boolValue):
(JSC::JSImmediate::asInt32):
(JSC::JSImmediate::toDouble):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):

11:46 AM Changeset in webkit [83191] by commit-queue@webkit.org
  • 5 edits in trunk

2011-04-07 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Eric Carlson.

Add tests for parsing codecs parameter in video-can-play-type.html
​https://bugs.webkit.org/show_bug.cgi?id=53275

  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:

2011-04-07 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Eric Carlson.

Parse quotes from content type parameters
​https://bugs.webkit.org/show_bug.cgi?id=53275

This functionality is tested in video-can-play-type.html layout test
where I've added codecs parameter with good and bad formatting.

  • platform/ContentType.cpp: (WebCore::ContentType::parameter):
11:24 AM Changeset in webkit [83190] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-04-07 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: remove "enabled" from the setBreakpoint protocol.
​https://bugs.webkit.org/show_bug.cgi?id=58047

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::hasBreakpoint):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint):
11:08 AM Changeset in webkit [83189] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Tests] fast/events/select-element.html failing since introduction in r83096
​https://bugs.webkit.org/show_bug.cgi?id=58059

Adding this test to the mac-wk2 skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
11:01 AM Changeset in webkit [83188] by jberlin@webkit.org
  • 13 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Adam Roben.

Part 3: Implement checkSpellingOfString

In WebCore, checkTextOfParagraph is only defined and used on platforms where
WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
Mac builds).

On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
patch in an attempt to keep things easier to review) are used.

  • UIProcess/API/C/win/WKTextChecker.h:
  • UIProcess/TextChecker.h:

Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING).
(WebKit::WebPageProxy::checkSpellingOfString):
Call through to the client.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Call through to the WebTextCheckerClient.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
(WebKit::TextChecker::checkSpellingOfString):
Add a call to notImplemented.

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Ditto, and remove the implementation for checkTextOfParagraph.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Ditto.

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::checkSpellingOfString):

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Send a sync message to the UI Process (similar to the sync message used for
checkTextOfParagraph).

11:00 AM Changeset in webkit [83187] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing.

  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [83186] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Update Leopard expected results after r83075 to greenify the bots.

  • platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt:
10:44 AM Changeset in webkit [83185] by kov@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

2011-04-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] Need a way to get the path to a WebKitWebPlugin
​https://bugs.webkit.org/show_bug.cgi?id=57968

Expose the path of the plugin through the WebKitWebPlugin object.

  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_path):
  • webkit/webkitwebplugin.h:
  • webkit/webkitwebpluginprivate.h:
10:41 AM Changeset in webkit [83184] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/qt

2011-04-07 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] QWebFrame::setUrl works only from second time if url fragment is present
​https://bugs.webkit.org/show_bug.cgi?id=32723

When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
use an invalid URL (the begin() without arguments). Clearing the document
with the same URL was causing problems when we had a fragment because it assume that
only scrolling was enough and did not loaded the document again.

When setUrl() is called but fails, url() is expected to return the requested value. The
begin(url) guaranteed that before. This patch adds a member to track the URL, which is
updated when the URL changes and also when setUrl() is called.

KURL was used for the member so that when setUrl() is called, and then url() is checked
before the page gets loaded, we perform the same conversion that will be performed by a
successful load, e.g. add trailing '/' to an address. This behavior is checked by
tst_QWebFrame::requestedUrl() test.

For the record: the second QWebPage::setUrl() worked because the load was considered a
FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.

  • Api/qwebframe.cpp: (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal. (clearCoreFrame): (isCoreFrameClear): (QWebFrame::setUrl): (QWebFrame::url): (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change the baseURL, e.g. by using the <base> tag.
  • Api/qwebframe_p.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlWithFragment): unskip test.
10:32 AM Changeset in webkit [83183] by enne@google.com
  • 2 edits
    8 adds in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline tests changed in r82947.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-linux/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/chromium-win/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/chromium-win/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [83182] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Vincent Scheib <​scheib@chromium.org>

Flagging platform/chromium/compositing/huge-layer-rotated.html a bug.

  • platform/chromium/test_expectations.txt:
10:03 AM Changeset in webkit [83181] by rniwa@webkit.org
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=58037

Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test.

  • editing/inserting/6633727-expected.txt: Removed.
  • editing/inserting/6633727.html: Removed.
  • editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added.
  • editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html.
  • editing/inserting/script-tests/6633727.js: Removed.
9:48 AM Changeset in webkit [83180] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Removed a redundant line of code.

Reviewed by Adam Roben.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.

9:41 AM Changeset in webkit [83179] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-04-07 Liang Qi <​liang.qi@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Enable webkit build with GCCE on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=57841

  • wtf/MathExtras.h: GCCE compiler doesn't support those std static functions.

2011-04-07 Liang Qi <​liang.qi@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Enable webkit build with GCCE on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=57841

  • WebCore.pri: Thanks for Norbert Leser <​norbert.leser@nokia.com> who checked RVCT part. --rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated to 0x1000000 together. They need to be updated in the future when WebKit grows.
9:37 AM Changeset in webkit [83178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available.
​https://bugs.webkit.org/show_bug.cgi?id=57877

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::socketpair): socketpair() which returns -1
9:08 AM Changeset in webkit [83177] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Michael Saboff <​msaboff@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Memory leak in decodeResourceError
​https://bugs.webkit.org/show_bug.cgi?id=58004

Release the local NSError after it is used to create a ResourceError
object assigned to the reference argument.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::decodeResourceError):
8:47 AM Changeset in webkit [83176] by pfeldman@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

2011-04-06 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: get rid of Breakpoint.js.
​https://bugs.webkit.org/show_bug.cgi?id=57949

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js: Removed.
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint): (WebInspector.PresentationBreakpoint.prototype.get sourceFile): (WebInspector.PresentationBreakpoint.prototype.get url): (WebInspector.PresentationBreakpoint.prototype.get resolved): (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._onResourceStarted): (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointUpdated): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:42 AM Changeset in webkit [83175] by yurys@chromium.org
  • 7 edits in trunk

2011-04-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
​https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/protocol/console-agent-expected.txt:

2011-04-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
​https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
8:19 AM Changeset in webkit [83174] by Adam Roben
  • 2 edits in trunk/Tools

Build fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
7:52 AM BuildingOnWindows edited by pere.martir4@gmail.com
(diff)
7:21 AM Changeset in webkit [83173] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip a fast/xmlhttprequest test passing on GTK.

  • platform/gtk/Skipped:
7:20 AM Changeset in webkit [83172] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Add always failing tets to the Skipped list.

  • platform/qt-wk2/Skipped:
7:16 AM Changeset in webkit [83171] by loislo@chromium.org
  • 9 edits in trunk

2011-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
​https://bugs.webkit.org/show_bug.cgi?id=57957

There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.

the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method for events
3) domain + '.' + command => method for requests
4) requestId => id for responses
5) arguments => params for requests
6) data => params for events
7) body => result for responses

protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
​https://bugs.webkit.org/show_bug.cgi?id=57957

There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.

the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method for events
3) domain + '.' + command => method for requests
4) requestId => id for responses
5) arguments => params for requests
6) data => params for events
7) body => result for responses

protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.

  • inspector/CodeGeneratorInspector.pm:
7:16 AM Changeset in webkit [83170] by Adam Roben
  • 2 edits in trunk/Tools

Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()

commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
(Unfortunately the buildbot documentation does not make this clear.) finished() is the only
hook we have, so we have to do our work there. I added a new addCustomURLs method which can
be overridden by subclasses to provide extra URLs before we call up to the base class (after
which adding more URLs is no longer possible).

Really hopefully fixes <​http://webkit.org/b/56032> Leaks viewer should be linked from leaks
bot results page

Reviewed by John Sullivan.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
(ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
method is never called for MasterShellCommands.
(ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
with this method (which is).

6:36 AM Changeset in webkit [83169] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-07 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rolling chromium DEPS 80421:80767.

  • DEPS:
6:36 AM Changeset in webkit [83168] by Adam Roben
  • 2 edits in trunk/Tools

Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()

This matches how most of our other build steps work, so is good just for improving
consistency between build steps. It should also make it possible for
ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
trying to do this in finished() after we had called up to the base class, but that was
apparently too late to add more URLs.)

Hopefully fixes <​http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
results page

Reviewed by John Sullivan.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults): Added a descriptionDone property so that we don't have to manually
call setText to get the right text to show up for this step. This matches how most of our
other build steps work.
(ExtractTestResults.commandComplete): Replaced our override of finished with this function.
This is how most of our other build steps work.
(ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
function, to match the base class.

6:25 AM Changeset in webkit [83167] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-07 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support.
​https://bugs.webkit.org/show_bug.cgi?id=58036

Renamed didReceiveData2 to didReceiveData.

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
6:11 AM Changeset in webkit [83166] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-07 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support.
​https://bugs.webkit.org/show_bug.cgi?id=58034

Migrated didReceiveData to support new lengthReceived parameter.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
6:05 AM Changeset in webkit [83165] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Add functions to update left and right offsets to LineOffsets
​https://bugs.webkit.org/show_bug.cgi?id=58028

Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
which are used to update m_left and m_right. Also added m_block and m_isFirstLine
member variables to LineOffsets so that users of LineOffsets don't have to pass them around.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine. (WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets. (WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine. (WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and no longer passes firstLine around.
5:50 AM Changeset in webkit [83164] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-06 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate debugger domain to the unified breakpoint location notion.
​https://bugs.webkit.org/show_bug.cgi?id=57928

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype._breakpointResolved):
5:44 AM Changeset in webkit [83163] by tkent@chromium.org
  • 2 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Move Leopard-specific images to chromium-mac-leopard, and
unify text results common in chromium-mac.

  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
5:37 AM Changeset in webkit [83162] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-04-07 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Build fix when using Phonon as a backend for the multimedia support.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt):
  • WebCoreSupport/ChromeClientQt.h:
4:07 AM Changeset in webkit [83161] by rniwa@webkit.org
  • 2 edits
    1 add
    12 deletes in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Convert insert-div-021.html to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=58019

Converted the test.

  • editing/inserting/insert-div-021-expected.txt: Added.
  • editing/inserting/insert-div-021.html:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.
4:06 AM Changeset in webkit [83160] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.

When initializing a QStyleOptionSlider from a widget, the State_Horizontal
hint may get set depending on how that widget is laid out in its parent.
If this happens when drawing a vertical scrollbar, the hint is never
cleared and we end up painting a vertical scrollbar with horizontal arrows.

Covered by pixel tests which should no longer paint silly scrollbars.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
3:04 AM Changeset in webkit [83159] by abarth@webkit.org
  • 6 edits
    4 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline script
​https://bugs.webkit.org/show_bug.cgi?id=58012

Test that script-src blocks inline script. This test uses a different
approach than the existing tests for variety.

  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/document-write-alert-fail.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/dump-as-text.js: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline script
​https://bugs.webkit.org/show_bug.cgi?id=58012

Block inline scripts at the ScriptElement layer. This should catch
exactly the scripts we want to catch.

Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
    • This patch also adds the ability to supply a CSP policy via a <meta> tag. We'll update the name of the header once we've finished implementing the spec.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::executeScript):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineScript):
  • page/ContentSecurityPolicy.h:
2:56 AM Changeset in webkit [83158] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

webkit-patch shouldn't state the whole working copy when calling check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=58022

Previously, we were ignoring the args variable! This patch fixes the
regression introduced in ​http://trac.webkit.org/changeset/82771.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
2:53 AM Changeset in webkit [83157] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Remove temporary WebProcess sandbox rules that are unnecessary now that plugins are in their own process
​https://bugs.webkit.org/show_bug.cgi?id=58023

  • WebProcess/com.apple.WebProcess.sb:
2:50 AM Changeset in webkit [83156] by tkent@chromium.org
  • 4 edits
    3 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update Linux x86-64 results for the Skia rounding rect change.

  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png:
2:42 AM Changeset in webkit [83155] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

Skip platform/mac/fast/forms/input-appearance-spinbutton-up.html on Mac WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=56298

  • platform/mac-wk2/Skipped:
2:24 AM Changeset in webkit [83154] by tkent@chromium.org
  • 8 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

Update spinbutton test results for r83145.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
2:04 AM Changeset in webkit [83153] by commit-queue@webkit.org
  • 15 edits in trunk/Source

2011-04-07 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=57921

Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
that the same logic can be used for a HitTestResult.

No visible changes, just cleanup, so no tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::subframeForHitTestResult): Made public static member, so that it can access targetNode(), and be accessed by webkitwebview in gtk. (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::targetNode): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h:
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):

2011-04-07 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=57921

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event): Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode() method has moved on to EventHandler.
1:40 AM Changeset in webkit [83152] by mjs@apple.com
  • 3 edits in trunk/Tools

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
​https://bugs.webkit.org/show_bug.cgi?id=58017

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
1:39 AM Changeset in webkit [83151] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: build mapping for formatted scripts based on keywords positions.
​https://bugs.webkit.org/show_bug.cgi?id=57936

Mapping based on [\$\.\w]+ was not accurate because string literals representation
may be different in original and formatted scripts.

  • inspector/front-end/ScriptFormatterWorker.js: (buildMapping.regexp.b): (buildMapping):
1:30 AM Changeset in webkit [83150] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline after r83145. Also skip
fast/forms/input-number-large-padding.html which fails. See bug
58020.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
1:00 AM Changeset in webkit [83149] by Philippe Normand
  • 1 edit
    12 adds in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for 4 new tests.

  • platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
  • platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
  • platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.
12:39 AM Changeset in webkit [83148] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Remove some no longer needed WebProcess sandbox allowances
​https://bugs.webkit.org/show_bug.cgi?id=58015
<rdar://problem/9232592>

  • WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network and launching privileges, since the bugs that required them are fixed.
12:25 AM Changeset in webkit [83147] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline after r83075.

  • platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
  • platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
12:13 AM Changeset in webkit [83146] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Fix a duplicated entry.

  • platform/chromium/test_expectations.txt:
12:03 AM Changeset in webkit [83145] by tkent@chromium.org
  • 12 edits
    2 adds in trunk

Spinbuttons become unclickable if right padding is large.
​https://bugs.webkit.org/show_bug.cgi?id=56298

Reviewed by NOBODY (OOPS!).

Source/WebCore:

An inner-spin-button is put on the right border and ignores right
padding in RenderTextControlSingleLine::layout(), but forwardEvent()
checks if a point is in an area just right of an internal text block.
This inconsistency caused a bug that an inner-spin-button with large
padding didn't receive mouse events.

To fix this bug, we render spin buttons as layers, and remove manual
event forwarding code.

Test: fast/forms/input-number-large-padding.html

  • css/html.css: Add "position:relative" to make a spin-button a layer.

(input::-webkit-inner-spin-button):
(input::-webkit-outer-spin-button):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

Remove manual event forwarding code.

LayoutTests:

Add a test, and skip on platforms which has no inner-spin-button implementation.

  • fast/forms/input-number-large-padding-expected.txt: Added.
  • fast/forms/input-number-large-padding.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/qt/Skipped:

Apr 6, 2011:

10:58 PM Changeset in webkit [83144] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Kent Tamura <​tkent@chromium.org>

Fixed an error in the previous commit.

  • platform/chromium/test_expectations.txt:
10:46 PM Changeset in webkit [83143] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Kent Tamura <​tkent@chromium.org>

[Chromium] Update text expectation.
fast/repaint/scale-page-shrink.html is expected to fail because of no
eventSender.scalePageBy().

  • platform/chromium/test_expectations.txt:
9:58 PM Changeset in webkit [83142] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Kent Tamura <​tkent@chromium.org>

[Chromium] Update test expectation.
xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.

  • platform/chromium/test_expectations.txt:
9:43 PM Changeset in webkit [83141] by abarth@webkit.org
  • 6 edits
    3 adds in trunk

2011-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP object-src should block plugin loads
​https://bugs.webkit.org/show_bug.cgi?id=57283

This change is pretty straight-forward. It's slighly unclear to me
whether this patch is correct w.r.t. the code in DocumentWriter. I've
added a FIXME comment, and I'll investigate that case more in the future.

Test: http/tests/security/contentSecurityPolicy/object-src-none.html

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestPlugin):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:

2011-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP object-src should block plugin loads
​https://bugs.webkit.org/show_bug.cgi?id=57283

  • http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.
9:39 PM Changeset in webkit [83140] by Beth Dakin
  • 6 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=58009
Frame::scalePage() results in visual artifacts with scale factors less than 1
-and corresponding-
<rdar://problem/8683230>

Reviewed by Dan Bernstein.

Source/WebCore:

Fall into the case where we fill with a background base color when there is a page
scale factor that is less than 1.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

  • fast/repaint/scale-page-shrink.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
  • platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
8:59 PM Changeset in webkit [83139] by commit-queue@webkit.org
  • 11 edits in trunk

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
​https://bugs.webkit.org/show_bug.cgi?id=57984

Unskip passed tests.

  • platform/mac-wk2/Skipped:

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
​https://bugs.webkit.org/show_bug.cgi?id=57984

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePageSizeAndMarginsInPixels):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
​https://bugs.webkit.org/show_bug.cgi?id=57984

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
8:55 PM Changeset in webkit [83138] by crogers@google.com
  • 4 edits in trunk/Tools

2011-04-06 Chris Rogers <​crogers@google.com>

Reviewed by Tony Chang.

Add web audio support to DumpRenderTree (mac port)
​https://bugs.webkit.org/show_bug.cgi?id=57969

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setEncodedAudioDataCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsAudio): (LayoutTestController::setDumpAsAudio): (LayoutTestController::encodedAudioData): (LayoutTestController::setEncodedAudioData):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpAudio): (dump):
8:49 PM Changeset in webkit [83137] by benjamin.poulain@nokia.com
  • 9 edits in trunk

2011-04-06 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
​https://bugs.webkit.org/show_bug.cgi?id=56086

  • platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.

2011-04-06 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
​https://bugs.webkit.org/show_bug.cgi?id=56086

Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
from the LayoutTestController.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-04-06 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
​https://bugs.webkit.org/show_bug.cgi?id=56086

Add the missing method.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
8:43 PM Changeset in webkit [83136] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for Geeza Pro and so on.

  • platform/chromium/test_expectations.txt:
8:34 PM Changeset in webkit [83135] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-06 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
​https://bugs.webkit.org/show_bug.cgi?id=57982

Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
8:31 PM Changeset in webkit [83134] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

2011-04-06 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation does not change rate due to setRate().
​https://bugs.webkit.org/show_bug.cgi?id=57919

  • media/video-set-rate-from-pause-expected.txt: Added.
  • media/video-set-rate-from-pause.html: Added.

2011-04-06 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation does not change rate due to setRate().
​https://bugs.webkit.org/show_bug.cgi?id=57919

Test: media/video-set-rate-from-pause.html

The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
of the media; instead a subclass must do that work. So when setRate() is called,
inform a subclass through a new pure virtual updateRate() function that there's
work to be done.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added. Set the requested rate.
8:24 PM Changeset in webkit [83133] by kinuko@chromium.org
  • 15 edits in trunk

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • configure.ac: Added QUOTA build flag

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • Configurations/FeatureDefines.xcconfig: Added QUOTA build flag

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • Configurations/FeatureDefines.xcconfig: Added QUOTA build flag

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
  • GNUmakefile.am: Added QUOTA build flag
  • WebCore.pri: Added QUOTA build flag

2011-04-06 Dai Mikurube <​dmikurube@chromium.org>

Reviewed by David Levin.

Add QUOTA build flag for unified quota API
​https://bugs.webkit.org/show_bug.cgi?id=57918

  • Scripts/build-webkit: Added QUOTA build flag
8:06 PM Changeset in webkit [83132] by mitz@apple.com
  • 25 edits in trunk/LayoutTests

Correct results for the Geeza Pro metrics change.

  • platform/mac/fast/dom/52776-expected.checksum:
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
7:21 PM Changeset in webkit [83131] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, update Chromium expectations for failing test from r83075.

  • platform/chromium/test_expectations.txt:
6:47 PM Changeset in webkit [83130] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Adjust the apple webkit port's default timeout to match
old-run-webkit-tests at 35 seconds.

​https://bugs.webkit.org/show_bug.cgi?id=37738

  • Scripts/webkitpy/layout_tests/port/mac.py:
6:37 PM Changeset in webkit [83129] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-04-06 Scott Cameron <​sccameron@rim.com>

Reviewed by Eric Seidel.

Remove global variable $httpdPath and replace with the return value of
getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
​https://bugs.webkit.org/show_bug.cgi?id=53499

  • Scripts/run-iexploder-tests:
  • Scripts/webkitperl/httpd.pm:
6:13 PM Changeset in webkit [83128] by Stephanie Lewis
  • 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=57997
<rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
Cancel all enqueued events when detaching the Document the events cannot keep the Document
alive.

Reviewed by Darin Adler.

No change in functionality so no new tests.

  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/EventQueue.cpp:

(WebCore::EventQueue::cancelQueuedEvents):

  • dom/EventQueue.h:
6:04 PM Changeset in webkit [83127] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-04-06 David Levin <​levin@chromium.org>

Reviewed by Ojan Vafai.

Augment style guidelines about meaningless parameters from text the unwritten rules email.
​https://bugs.webkit.org/show_bug.cgi?id=55275

  • coding/coding-style.html:
6:02 PM Changeset in webkit [83126] by mitz@apple.com
  • 21 edits in trunk

<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
​https://bugs.webkit.org/show_bug.cgi?id=58002

Reviewed by Darin Adler.

Source/WebCore:

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
does not require the vertical metrics tweaks that were needed in Leopard. That the
tweaks were being applied went mostly unnoticed until r73993, because until then it
only affected cases where Geeza Pro was specified, not when it occurred as a fallback
font.

LayoutTests:

  • platform/mac/fast/dom/52776-expected.checksum:
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
5:20 PM Changeset in webkit [83125] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-06 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] FrameLoaderClientQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40254

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::postProgressStartedNotification): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem): (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::createFrame): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):
5:07 PM Changeset in webkit [83124] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, update expectations for Chromium visited link test.
​https://bugs.webkit.org/show_bug.cgi?id=58000

Apparently, this just hasn't been working for a while.

  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [83123] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-06 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 57994 - Move guardRef functionality back to Document
​https://bugs.webkit.org/show_bug.cgi?id=57994

Move the relevant code parts from TreeScope back into Document.

No new tests. (no new functionality)

  • dom/Document.cpp: (WebCore::Document::removedLastRef):
  • dom/Document.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::destroyTreeScopeData):
  • dom/TreeScope.h:
4:41 PM Changeset in webkit [83122] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-04-06 Ian Henderson <​ianh@apple.com>

Reviewed by Simon Fraser, Antti Koivisto.

Fast path for parsing simple CSS values
​https://bugs.webkit.org/show_bug.cgi?id=57964

Add functions to parse simple color or dimension values, skipping the
overhead of full CSS parsing.

Change parseValue to a static method to avoid unnecessary allocation
of a CSSParser in the fast case.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Changed to use the new, static parseValue method.
  • css/CSSParser.cpp: (WebCore::isColorPropertyID): (WebCore::parseColorValue): Parses any color accepted by the existing parseColor() static method. We must handle color identifiers separately, since parseColor() will change 'red' into 'rgb(255, 0, 0)'. (WebCore::isSimpleLengthPropertyID): (WebCore::parseSimpleLengthValue): Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is false, or 'NN' is '0'). Returns false to fall back to the slow path. (WebCore::CSSParser::parseValue):
  • css/CSSParser.h:
  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue): Changed to use the new, static parseValue method.
4:38 PM Changeset in webkit [83121] by kevino@webkit.org
  • 8 edits in trunk

Reviewed by Darin Adler.

Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.

​https://bugs.webkit.org/show_bug.cgi?id=27551

4:27 PM Changeset in webkit [83120] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-04-06 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

teach run-webkit-tests to read checksums from png files
​https://bugs.webkit.org/show_bug.cgi?id=57993

  • Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's no .checksum and look for the checksum in there.
4:20 PM Changeset in webkit [83119] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-04-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto.

Some minor style resolution optimizations
​https://bugs.webkit.org/show_bug.cgi?id=57996

A couple of minor optimizations to style-related code.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::putDelegate): Avoid calling cssPropertyName() twice when setting style on an element.
  • css/CSSStyleSelector.cpp: (WebCore::useSVGZoomRules): (WebCore::CSSStyleSelector::applyProperty): Avoid calling isSVGElement() for every property, since only a two properties care about it.
4:19 PM Changeset in webkit [83118] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-06 Ian Henderson <​ianh@apple.com>

Reviewed by Antti Koivisto.

Unnecessary string allocation in CSSStyleDeclaration::setProperty
​https://bugs.webkit.org/show_bug.cgi?id=57995

Pass the bool representing the property's importance directly instead
of constructing a string.

  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty):
4:08 PM Changeset in webkit [83117] by enne@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, rebaseline more Chromium mac tests after r83075.

  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
4:06 PM Changeset in webkit [83116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-06 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt][WK2][Symbian] Remove use of stack arrays with variable size
​https://bugs.webkit.org/show_bug.cgi?id=57877

For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integers.

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
4:01 PM Changeset in webkit [83115] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-06 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
​https://bugs.webkit.org/show_bug.cgi?id=57963

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

  • bindings/v8/V8Utilities.h: (WebCore::createFunctionOnlyCallback):
  • bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):
3:57 PM Rebaseline edited by scheib@chromium.org
Removed out of date switches for canaries / gpu bots / deps source (diff)
3:56 PM Changeset in webkit [83114] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [83113] by bweinstein@apple.com
  • 13 edits
    1 move in trunk/Source

WebKit2: Support Windows 7 Gestures
​https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>

Reviewed by Adam Roben.

Source/WebCore:

Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.

Source/WebKit/win:

Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
used in both WebKit and WebKit2.

  • WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
  • WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
  • WindowsTouch.h: Removed.

Source/WebKit2:

Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.

The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
isn't over a scrollbar.

The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
X and Y are reversed because panning up -> moving the page down, and vice versa.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess

to initialize the gesture. The WebProcess returns whether or not we can start a pan
gesture from where we are.

(WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by

pan gesture.

(WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
(WebKit::WebView::WebView): Initialize two new variables.
(WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where

the gesture is beginning.

(WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.

  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we

know which layer to scroll if the user pans), and determine whether or not we should allow
panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.

(WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture

started on.

(WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.

3:37 PM Changeset in webkit [83112] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-06 David Dorwin <​ddorwin@chromium.org>

Reviewed by David Levin.

Enable fullscreen layout tests for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=55726

Remove test_expectations override for fullscreen tests.

  • platform/chromium/test_expectations.txt:

2011-04-06 David Dorwin <​ddorwin@chromium.org>

Reviewed by David Levin.

Enable fullscreen layout tests for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=55726

Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo):
3:27 PM Changeset in webkit [83111] by enne@google.com
  • 2 edits
    6 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, rebaseline Chromium Mac tests after r83075.

  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
3:24 PM Changeset in webkit [83110] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-04-06 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
​https://bugs.webkit.org/show_bug.cgi?id=57989


Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.

  • Shared/API/c/WKString.cpp: (WKStringGetLength): Added. (WKStringGetCharactersPtr): Added.
  • Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
  • Shared/WebString.h: (WebKit::WebString::length): Added. (WebKit::WebString::characters): Added.
3:21 PM Changeset in webkit [83109] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Dock stays in front of Hulu.com full screen video output
​https://bugs.webkit.org/show_bug.cgi?id=57988
<rdar://problem/9216260>

Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
-[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
setting the presentation options when exiting full screen, otherwise the dock won't
be restored correctly.

  • PluginProcess/mac/PluginProcessShim.mm: Remove some shim functions that aren't needed.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_preFullscreenAppPresentationOptions.
  • UIProcess/Plugins/PluginProcessProxy.h: Add m_preFullscreenAppPresentationOptions.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::enterFullscreen): Change the presentation options for the app.

(WebKit::PluginProcessProxy::exitFullscreen):
Restore the presentation options.

3:17 PM Changeset in webkit [83108] by alexis.menard@openbossa.org
  • 16 edits in trunk/Source

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
​https://bugs.webkit.org/show_bug.cgi?id=57974

We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

No new tests needed, just a config flag rename.

  • features.pri:

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
​https://bugs.webkit.org/show_bug.cgi?id=57974

We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

No new tests needed, just a config flag rename.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h:
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadHtml5Video):
  • tests/tests.pri:
3:15 PM Changeset in webkit [83107] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Stop JSObject::isUsingInlineStorage() from using the structure
​https://bugs.webkit.org/show_bug.cgi?id=57986

Make the isUsingInlineStorage() implementation just look at
whether the property storage is inside the object.

  • runtime/JSObject.h: (JSC::JSObject::isUsingInlineStorage): (JSC::JSObject::JSObject):
3:10 PM Changeset in webkit [83106] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.

Rubber stamped by Geoff Garen.

  • runtime/JSImmediate.h:
  • runtime/JSValue.h:
3:02 PM Changeset in webkit [83105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Tyler Close <​tjclose@chromium.org>

Reviewed by Nate Chapin.

run-bindings-tests reference files out of sync with CodeGenerator*.pm
​https://bugs.webkit.org/show_bug.cgi?id=57967

  • bindings/scripts/test/V8/V8TestCallback.cpp:
2:57 PM Changeset in webkit [83104] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit2

Expose the original URL of a WKBackForwardListItem.

Reviewed by Darin Adler.

Needed for <rdar://problem/9074651>.

  • UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemCopyOriginalURL):

  • UIProcess/API/C/WKBackForwardListItem.h:
2:53 PM Changeset in webkit [83103] by scheib@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-06 Vincent Scheib <​scheib@chromium.org>

Fixed GPU expectations for r80867

  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:49 PM Changeset in webkit [83102] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-04-06 Asanka Herath <​asanka@chromium.org>

Reviewed by Darin Fisher.

Add new TargetType: TargetIsFavicon

​https://bugs.webkit.org/show_bug.cgi?id=57659

No new functionality added, so no additional tests.

  • platform/network/ResourceRequestBase.h:

2011-04-06 Asanka Herath <​asanka@chromium.org>

Reviewed by Darin Fisher.

Add new TargetType: TargetIsFavicon

​https://bugs.webkit.org/show_bug.cgi?id=57659

  • public/WebURLRequest.h:
2:47 PM Changeset in webkit [83101] by Adam Roben
  • 2 edits in trunk/Tools

Add a "view leaks" link to builds on SnowLeopard Intel Leaks

Fixes <​http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
build's results directory here...
(ExtractTestResults.finished): ...from here.
(ExtractTestResultsAndLeaks): New class that's used by the leaks builder
(ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
leaks" link to point to Leaks Viewer for this build.
(TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
but it seemed good to add for consistency with BuildAndTestFactory.
(BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
(BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
that we'll get a "view leaks" link.

2:31 PM Changeset in webkit [83100] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] media tests are flakey
​https://bugs.webkit.org/show_bug.cgi?id=57983

  • platform/qt/Skipped: Disable all media tests until fix.
2:22 PM Changeset in webkit [83099] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=57981

Reviewed by Simon Fraser.

Update the column count and width computation algorithm for CSS3 multi-column layout
to match the revised pseudo-algorithm in the latest draft of the spec.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):

2:08 PM Changeset in webkit [83098] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
​https://bugs.webkit.org/show_bug.cgi?id=57965

Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
instead of marginStartForChild and marginEndForChild respectively.

Calling these two functions on RenderInline is okay because writing-mode cannot differ
from that of the containing block.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::borderPaddingMarginStart): (WebCore::borderPaddingMarginEnd): (WebCore::inlineLogicalWidth):
1:55 PM Changeset in webkit [83097] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83039.
​http://trac.webkit.org/changeset/83039
​https://bugs.webkit.org/show_bug.cgi?id=57978

introduced a new regression in conjunction to
ReplaceSelectionCommand (Requested by rniwa on #webkit).

  • editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
  • editing/inserting/insert-paragraph-separator-tab-span.html: Removed.

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83039.
​http://trac.webkit.org/changeset/83039
​https://bugs.webkit.org/show_bug.cgi?id=57978

introduced a new regression in conjunction to
ReplaceSelectionCommand (Requested by rniwa on #webkit).

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::init):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
1:52 PM Changeset in webkit [83096] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by David Levin.

Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
​https://bugs.webkit.org/show_bug.cgi?id=27658

  • fast/events/select-element-expected.txt: Added to check PgUp/PgDown/Home/End keys are working correctly in SELECT tag.
  • fast/events/select-element.html: Added for expectation.

2011-04-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by David Levin.

Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
​https://bugs.webkit.org/show_bug.cgi?id=27658

Test: fast/events/select-element.html

  • dom/SelectElement.cpp: (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines. (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index. (WebCore::nextSelectableListIndex): Implemented with nextValidIndex. And converted to a normal static function from a private function of SelectElement. (WebCore::previousSelectableListIndex): Implemented with nextValidIndex. And converted to a normal static function from a private function of SelectElement. (WebCore::firstSelectableListIndex): Returns the first selectable index. (WebCore::lastSelectableListIndex): Returns the last selectable index. (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast. (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.
  • dom/SelectElement.h: (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().
  • rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML. They can differ due to the minimum size imposed by RenderListBox.
1:47 PM Changeset in webkit [83095] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=57975

Reviewed by Dan Bernstein.

The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
to just look at the style, so that it can find the InlineTextBox and not care that it's a child
of the link element and not the line box for the link element itself (since that line box got
culled).

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

1:44 PM Changeset in webkit [83094] by enne@google.com
  • 5 edits
    3 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, rebaseline Chromium Win tests after r83075.

  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
1:37 PM Changeset in webkit [83093] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/fast/blockflow/text-orientation-basic-expected.txt

Rebaseline text orientation layout test on Windows.

1:35 PM Changeset in webkit [83092] by Csaba Osztrogonác
  • 27 edits in trunk/LayoutTests

[Qt] Update platform specific expected results after r83075.

  • platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
  • platform/qt/editing/pasteboard/paste-text-011-expected.png:
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/fast/css-generated-content/014-expected.checksum:
  • platform/qt/fast/css-generated-content/014-expected.png:
  • platform/qt/fast/css-generated-content/014-expected.txt:
  • platform/qt/fast/css/word-space-extra-expected.checksum:
  • platform/qt/fast/css/word-space-extra-expected.png:
  • platform/qt/fast/css/word-space-extra-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
1:31 PM Changeset in webkit [83091] by beidson@apple.com
  • 7 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=57973 and ​https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size

Reviewed by Anders Carlsson.

../WebCore:

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:

(WebCore::Image::getFirstCGImageRefOfSize):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the

first frame of the requested size.

../WebKit2:

  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching

CGImage in the icon.

  • UIProcess/API/C/cg/WKIconDatabaseCG.h:
1:29 PM Changeset in webkit [83090] by kevino@webkit.org
  • 4 edits in trunk/Source

Reviewed by Kevin Ollivier.

[wx] Fix cursor handling so that we always call the chrome to set it.

​https://bugs.webkit.org/show_bug.cgi?id=57972

1:17 PM Changeset in webkit [83089] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
​https://bugs.webkit.org/show_bug.cgi?id=57975

  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [83088] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-06 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by Eric Seidel.

[chromium] Add settings API to enable accelerated drawing
​https://bugs.webkit.org/show_bug.cgi?id=57863

If accelerated drawing is enabled we try to render content and
root layers using GPU. Please note that this setting is ignored if
accelerated compositing is disabled.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
  • src/WebSettingsImpl.h:
1:06 PM Changeset in webkit [83087] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=41445

Reviewed by Dan Bernstein.

Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.

Source/WebCore:

Added fast/history/visited-link-background-color.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::visitedDependentColor):

LayoutTests:

Added fast/history/visited-link-background-color.html

  • fast/history/visited-link-background-color.html: Added.
  • platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
  • platform/mac/fast/history/visited-link-background-color-expected.png: Added.
  • platform/mac/fast/history/visited-link-background-color-expected.txt: Added.
12:56 PM Changeset in webkit [83086] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed Qt buildfix after r83079.

  • WebCore.pro:
12:56 PM Changeset in webkit [83085] by jberlin@webkit.org
  • 5 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.

  • UIProcess/API/C/win/WKTextChecker.h:
  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):

  • UIProcess/win/WebTextCheckerClient.h:
12:46 PM Changeset in webkit [83084] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.

  • platform/chromium/test_expectations.txt:
12:31 PM Changeset in webkit [83083] by enne@google.com
  • 4 edits
    1 add
    3 deletes in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, rebaseline Chromium linux tests after r83075.

  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.
12:26 PM Changeset in webkit [83082] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-06 Dean Jackson <​dino@apple.com>

Reviewed by Chris Marrin.

​https://bugs.webkit.org/show_bug.cgi?id=56936
Crash in ImplicitAnimation::~ImplicitAnimation

Make sure the style and start time waiting lists
are cleared in the CompositeAnimation destructor. This
way, no running transitions can be left in a state
where they are destroyed as the AnimationControllerPrivate
cleans up.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation):
12:24 PM Changeset in webkit [83081] by commit-queue@webkit.org
  • 13 edits in trunk/Source

2011-04-06 Robert Sesek <​rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
​https://bugs.webkit.org/show_bug.cgi?id=54969

No change in behavior; no new tests.

  • editing/TextIterator.cpp: (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
  • editing/TextIterator.h:
  • page/Frame.cpp: (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits

2011-04-06 Robert Sesek <​rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
​https://bugs.webkit.org/show_bug.cgi?id=54969

  • WebView/WebFrame.mm: (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore

2011-04-06 Robert Sesek <​rsesek@chromium.org>

Reviewed by Alexey Proskuryakov.

Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
​https://bugs.webkit.org/show_bug.cgi?id=54969

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
  • WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore (WebKit::WebPage::getMarkedRange): (WebKit::WebPage::getSelectedRange): (WebKit::WebPage::characterIndexForPoint): (WebKit::WebPage::performDictionaryLookupAtLocation):
11:50 AM Changeset in webkit [83080] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Skip tests not passing in the Qt bot.

  • platform/qt/Skipped:
11:46 AM Changeset in webkit [83079] by steveblock@google.com
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-04-06 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
​https://bugs.webkit.org/show_bug.cgi?id=57770

Create a template from an existing functionality in JSGeolocationCustom.cpp
to be used by the custom bindings of both Geolocation and the Media Stream API.
V8 version of this bug: ​https://bugs.webkit.org/show_bug.cgi?id=57760

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CallbackFunction.cpp: Added. (WebCore::checkFunctionOnlyCallback):
  • bindings/js/CallbackFunction.h: Added. (WebCore::createFunctionOnlyCallback):
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
11:43 AM Changeset in webkit [83078] by alexis.menard@openbossa.org
  • 9 edits in trunk/Source

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Implement fullscreen playback for the GStreamer backend.
​https://bugs.webkit.org/show_bug.cgi?id=56826

Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.

No new tests because layout tests cover it. They are not yet activated
but will be any time soon.

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::FullScreenVideoWindow): (FullScreenVideoWindow::setVideoElement): (FullScreenVideoWindow::closeEvent): (FullScreenVideoWindow::keyPressEvent): (FullScreenVideoWindow::event): (FullScreenVideoWindow::showFullScreen): (FullScreenVideoWindow::hideCursor): (FullScreenVideoWindow::showCursor):

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Implement fullscreen playback for the GStreamer backend.
​https://bugs.webkit.org/show_bug.cgi?id=56826

Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.

No new tests because layout tests cover it. They are not yet activated
but will be any time soon.

  • QtWebKit.pro:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler): (WebCore::GStreamerFullScreenVideoHandler::setVideoElement): (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen): (WebCore::GStreamerFullScreenVideoHandler::windowClosed): (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen): (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/FullScreenVideoQt.h: (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
11:40 AM Changeset in webkit [83077] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-06 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Eric Seidel.

[Gtk] plugins/set-status.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57844

Unskip a newly-passing test.

  • platform/gtk/Skipped:

2011-04-06 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Eric Seidel.

[Gtk] plugins/set-status.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57844

Allow an empty status text to be dumped.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged):
11:34 AM Changeset in webkit [83076] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Bundle lineLeftOffset and lineRightOffset as a class
​https://bugs.webkit.org/show_bug.cgi?id=57851

Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
and only the difference is used to compute the width.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers. (WebCore::LineOffsets::LineOffsets): Added. (WebCore::LineOffsets::width): Added. (WebCore::LineOffsets::setLeft): Added. (WebCore::LineOffsets::setRight): Added. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.
11:20 AM Changeset in webkit [83075] by hyatt@apple.com
  • 26 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57916

Reviewed by Dan Bernstein.

Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).

Source/WebCore:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.

  • page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::uniteIfNonZero):

  • platform/graphics/FloatRect.h:
  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::uniteIfNonZero):

  • platform/graphics/IntRect.h:

Add a new unite function that is useful for the render tree to FloatRect and IntRect. This
version allows rect unites to happen if either width or height is nonzero.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):

  • rendering/InlineFlowBox.h:

Rewritten to add the text box overflow to the text box itself.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.

(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here. Only if the RenderInline says that boxes are allowed will they
be created.

(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.

(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds). Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).

(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.

(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.

(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.

  • rendering/RenderInline.h:

(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.

(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.

  • rendering/RenderText.cpp:

(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.

(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.

(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.

(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc. Used by RenderInline::culledInlineVisualOverflowBoundingBox.

  • rendering/RenderText.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).

LayoutTests:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

  • platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
  • platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
11:17 AM Changeset in webkit [83074] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2011-04-06 MORITA Hajime <​morrita@google.com>

Unreviewed expectations udpate for gtk port that follows r83065.

  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
11:15 AM Changeset in webkit [83073] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, modify Chromium test expectations from r83065. They need
rebaselines, but in the meantime they should fail more generally so as
not to trip the bots.

  • platform/chromium/test_expectations.txt:
11:13 AM Changeset in webkit [83072] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

2011-04-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Unskip some media LayoutTests.
​https://bugs.webkit.org/show_bug.cgi?id=57855

Unskip some media tests for Qt.

  • platform/qt/Skipped:
11:12 AM Changeset in webkit [83071] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=42329

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=42329

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePageNumberForElementById):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::pageNumberForElementById):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-06 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=42329

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::pageNumberForElementById):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
11:03 AM Changeset in webkit [83070] by enrica@apple.com
  • 6 edits in trunk/Source

REGRESSION: Drag & Drop Gmail Attachments doesn't work.
​https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>

Reviewed by Darin Adler.

Source/WebCore:

In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).

  • platform/DragData.h:

(WebCore::DragData::pasteboard): Added.

  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.

Source/WebKit2:

Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).

  • UIProcess/API/mac/WKView.mm:

(-[WKView _hitTest:dragTypes:]): Added.

10:56 AM Changeset in webkit [83069] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2011-04-06 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

fast/layer/video_layer.html has the same text output for all chromium mac platforms.

[chromium] Fix fast/layers/video_layer.html expectations
​https://bugs.webkit.org/show_bug.cgi?id=57386

  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium/test_expectations.txt:
10:32 AM Changeset in webkit [83068] by sergio@webkit.org
  • 2 edits in trunk/Tools

2011-04-06 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] DumpRenderTree: do not try to free NULL SoupURIs
​https://bugs.webkit.org/show_bug.cgi?id=57932

Some Layout tests have invalid URIs that do not generate valid
SoupURI instances. Do not try to free those NULL SoupURIs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback):
10:19 AM Changeset in webkit [83067] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-06 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

ClipboardWin has unused variables "ExceptionCode ec"
​https://bugs.webkit.org/show_bug.cgi?id=57952

Remove the unused variable.

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writePlainText):
10:06 AM Changeset in webkit [83066] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Split getBorderPaddingMargin into two functions
​https://bugs.webkit.org/show_bug.cgi?id=57947

  • rendering/RenderBlockLineLayout.cpp: (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin. (WebCore::borderPaddingMarginEnd): Ditto. (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd. (WebCore::RenderBlock::findNextLineBreak): Ditto.
10:03 AM Changeset in webkit [83065] by morrita@google.com
  • 19 edits
    1 copy
    1 move in trunk

2011-04-06 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] <progress> should not have manual layout code.
​https://bugs.webkit.org/show_bug.cgi?id=57801

Updated progress-bar-value-pseudo-element.html to have wider coverage and
follow pseudo class change.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:

2011-04-06 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] <progress> should not have manual layout code.
​https://bugs.webkit.org/show_bug.cgi?id=57801

  • Simplified RenderProgress, removing its custom layout code
  • Introducing ProgressValueElement and ProgressBarElement, replacing ProgressBarValueElement.

Now the structure is almost identical to <meter>,
other than:

  • RenderProgress has animated painting, thus manages its own timer.
  • Both ProgressValueElement and ProgressBarElement has pseudo classes which don't changes during its lifetime.
  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/html.css: (progress): (progress::-webkit-progress-bar): (progress::-webkit-progress-value):
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::~HTMLProgressElement): (WebCore::HTMLProgressElement::create): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtree):
  • html/HTMLProgressElement.h:
  • html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressShadowElement::ProgressShadowElement): (WebCore::ProgressShadowElement::progressElement): (WebCore::ProgressShadowElement::rendererIsNeeded): (WebCore::ProgressBarElement::shadowPseudoId): (WebCore::ProgressValueElement::shadowPseudoId): (WebCore::ProgressValueElement::setWidthPercentage):
  • html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressBarElement::ProgressBarElement): (WebCore::ProgressBarElement::create): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::ProgressValueElement::create):
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::animationTimerFired):
  • rendering/RenderProgress.h: (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation): (WebCore::RenderProgress::canHaveChildren):
9:50 AM Changeset in webkit [83064] by mario@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-04-06 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Do not reference AccessibilityRenderObject from platform dependent code
​https://bugs.webkit.org/show_bug.cgi?id=57955

Do not reference AccessibilityRenderObject from platform specific code

Added new virtual functions to AccessibilityObject.h and removed
explicit references to AccessibilityRenderObject from GTK code.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::renderer): New virtual method, returning 0 by default. Overriden by AccessibilityRenderObject. (WebCore::AccessibilityObject::correspondingLabelForControlElement): New virtual method, returning 0 by default. It complements the already present method correspondingControlForLabelElement().
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::renderer): Made virtual.
  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::emitTextChanged): Reference AccessibilityObject, instead of AccessibilityRenderObject. (WebCore::AXObjectCache::nodeTextChangePlatformNotification): Ditto.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Do not reference AccessibilityRenderObject. (webkit_accessible_get_description): Ditto. (setAtkRelationSetFromCoreObject): Ditto. (optionFromList): Ditto. (optionFromSelection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_select_all_selection): Ditto. (textForObject): Ditto. (webkit_accessible_text_get_text): Ditto. (getPangoLayoutForAtk): Ditto. (webkit_accessible_text_get_caret_offset): Ditto. (baselinePositionForRenderObject): Ditto. (getAttributeSetForAccessibilityObject): Ditto. (accessibilityObjectLength): Ditto. (getSelectionOffsetsForObject): Ditto. (webkit_accessible_text_set_selection): Ditto. (webkit_accessible_text_set_caret_offset): Ditto. (webkit_accessible_table_get_caption): Ditto. (getInterfaceMaskFromObject): Ditto.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: (getRangeLengthForObject): Ditto.

Removed unused renderer() method from AccessibilityMenuList.

  • accessibility/AccessibilityMenuList.h: Removed unused method.
  • accessibility/AccessibilityMenuList.cpp: Removed unused method.
9:39 AM Changeset in webkit [83063] by demarchi@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-06 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

cmake: Fix build for ARMv7

  • CMakeLists.txt: add missing file.
9:19 AM Changeset in webkit [83062] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Javascipt warning link expand and overlap with icons in js console
​https://bugs.webkit.org/show_bug.cgi?id=57939

  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
9:12 AM Changeset in webkit [83061] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
​https://bugs.webkit.org/show_bug.cgi?id=57931

  • inspector/Inspector.json:
9:09 AM Changeset in webkit [83060] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-06 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

[Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
​https://bugs.webkit.org/show_bug.cgi?id=57665
<rdar://problem/7350477>

We need to track how user modified an autocorrected word. If he changed it back to original
text, we want to record AutocorrectionReverted response. And if he changed it to something
else, we want to record AutocorrectionEdited response.

To achieve this, we need to distringuish between text replacement caused by autocorrection
from that due to other causes, such as reversion, text substitution, etc. So we added a new
marker type "Autocorrected". We also need to be able to check for correction, even when we
don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
value, "CheckForCorrection".

We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
specified range, and of specified type.

  • dom/DocumentMarker.h:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
  • dom/DocumentMarkerController.h:
  • editing/Editor.cpp: (WebCore::markerTypesForAutocorrection): (WebCore::markersHaveIdenticalDescription): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::applyCorrectionPanelInfo): (WebCore::Editor::unappliedSpellCorrection): (WebCore::Editor::textCheckingTypeMaskFor):
  • editing/Editor.h:
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
9:09 AM Changeset in webkit [83059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-06 Liang Qi <​liang.qi@nokia.com>

Reviewed by Benjamin Poulain.

Correct a include file name.
​https://bugs.webkit.org/show_bug.cgi?id=57839

  • wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix builds on Unix hosts.
8:58 AM Changeset in webkit [83058] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Build fix after r83056

  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.
8:54 AM Changeset in webkit [83057] by enne@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-06 Adrienne Walker <​enne@google.com>

Unreviewed, add Chromium snow leopard baseline for meter-boundary-values

  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
8:47 AM Changeset in webkit [83056] by Adam Roben
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Move JavaScriptCoreGenerated's file-copying logic out to a new script

Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.

If we like this new style, we could copy it for our other projects.

Fixes <​http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy

files from here...

  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd

for convenience.

8:45 AM Changeset in webkit [83055] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

ORWT shouldn't generate diff files for tests without expected files
​https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

  • Scripts/old-run-webkit-tests:
8:44 AM Changeset in webkit [83054] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix using UNUSED_PARAM introduced in r82907
​https://bugs.webkit.org/show_bug.cgi?id=57940

Reviewed by Darin Adler.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

8:41 AM Changeset in webkit [83053] by podivilov@chromium.org
  • 5 edits
    2 deletes in trunk

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
​http://trac.webkit.org/changeset/83045
​https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

  • inspector/debugger/script-formatter-expected.txt: Removed.
  • inspector/debugger/script-formatter.html: Removed.
  • platform/chromium/test_expectations.txt:

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
​http://trac.webkit.org/changeset/83045
​https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
8:19 AM Changeset in webkit [83052] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.

  • rendering/RenderBlock.h:
8:16 AM Changeset in webkit [83051] by diegohcg@webkit.org
  • 5 edits
    1 delete in trunk/Source/WebCore

2011-03-27 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
​https://bugs.webkit.org/show_bug.cgi?id=57007

Reviewed by Kenneth Rohde Christiansen.

  • CodeGenerators.pri:
  • css/themeQtMobile.css: Removed.
  • platform/qt/QtMobileWebStyle.cpp: (drawRectangularControlBackground): (QtMobileWebStyle::drawPrimitive): (QtMobileWebStyle::drawComplexControl):
  • platform/qt/QtMobileWebStyle.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::paintTextField):
8:15 AM Changeset in webkit [83050] by jberlin@webkit.org
  • 8 edits
    6 adds in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 1: Get and set the state.

  • Shared/API/c/win/WKBaseWin.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/win/WKAPICastWin.h:


  • UIProcess/API/C/win/WKTextChecker.cpp: Added.

(WKTextCheckerSetClient):
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
(WKTextCheckerGrammarCheckingEnabledStateChanged):

  • UIProcess/API/C/win/WKTextChecker.h: Added.


  • UIProcess/TextChecker.h:
  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::state):
Do the initalization for the state only once so that it is not necessary to call the client
every time the state is requested.
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
Call the client.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
Update the state and tell the client.
(WebKit::TextChecker::setGrammarCheckingEnabled):
Ditto.
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Update the state.
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
Update the state.

  • UIProcess/win/WebTextChecker.cpp: Added.

(WebKit::WebTextChecker::shared):
Make the WebTextChecker available globally.
(WebKit::WebTextChecker::WebTextChecker):
(WebKit::WebTextChecker::setClient):
(WebKit::updateStateForAllWebProcesses):
(WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
Tell the TextChecker that the state has changed, and then tell the
WebProcessProxies to send the new state to the WebProcesses.
(WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
Ditto.

  • UIProcess/win/WebTextChecker.h: Added.

(WebKit::WebTextChecker::client):
(WebKit::WebTextChecker::type):

  • UIProcess/win/WebTextCheckerClient.cpp: Added.

(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):

  • UIProcess/win/WebTextCheckerClient.h: Added.


  • win/WebKit2.vcproj:

Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp.

  • win/WebKit2Generated.make:

Copy over WKTextChecker.h.

7:57 AM Changeset in webkit [83049] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-06 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

[Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
​https://bugs.webkit.org/show_bug.cgi?id=57800
<rdar://problem/9218223>

Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.

  • accessibility/AXObjectCache.h:
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postPlatformNotification):
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
7:42 AM Changeset in webkit [83048] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-04-06 Martin Robinson <​mrobinson@igalia.com>

Build fix for debug Cairo builds.

  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.
7:38 AM Changeset in webkit [83047] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Style fix for QtMobileWebStyle.h
​https://bugs.webkit.org/show_bug.cgi?id=57708

Reviewed by Antonio Gomes.

  • platform/qt/QtMobileWebStyle.h:
7:35 AM Changeset in webkit [83046] by abecsi@webkit.org
  • 5 edits
    3 adds in trunk

2011-04-06 Andras Becsi <​abecsi@webkit.org>

Reviewed by Darin Adler.

Invalid color #{predefined colorName} is accepted by the CSS parser.
​https://bugs.webkit.org/show_bug.cgi?id=15360

  • editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid.
  • fast/css/invalid-predefined-color-expected.txt: Added.
  • fast/css/invalid-predefined-color.html: Added.
  • fast/css/script-tests/invalid-predefined-color.js: Added.

2011-04-06 Andras Becsi <​abecsi@webkit.org>

Reviewed by Darin Adler.

Invalid color #{predefined colorName} is accepted by the CSS parser.
​https://bugs.webkit.org/show_bug.cgi?id=15360

Test: fast/css/invalid-predefined-color.html

  • css/CSSGrammar.y: Remove superfluous hexcolor production.
  • css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).
7:29 AM Changeset in webkit [83045] by podivilov@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
7:16 AM Changeset in webkit [83044] by Martin Robinson
  • 7 edits in trunk/Source/WebCore

2011-04-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Cairo] Hide the details of image masking in PlatformContextCairo
​https://bugs.webkit.org/show_bug.cgi?id=57878

No new tests. This is just a refactor.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to do the actual cairo_save. Remove information about image masking. (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to do the actual cairo_restore. Remove information about image masking.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::restore): Added. (WebCore::PlatformContextCairo::save): Added. (WebCore::PlatformContextCairo::pushImageMask): Added.
  • platform/graphics/cairo/PlatformContextCairo.h: (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h. (WebCore::ImageMaskInformation::isValid): Ditto. (WebCore::ImageMaskInformation::maskSurface): Ditto. (WebCore::ImageMaskInformation::maskRect): Ditto.
7:12 AM Changeset in webkit [83043] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-02 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Radio buttons are showing wrong with mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=57706

Reviewed by Csaba Osztrogonác.

  • platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawRadio):
7:10 AM Changeset in webkit [83042] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
​https://bugs.webkit.org/show_bug.cgi?id=57943

  • rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp
6:50 AM Changeset in webkit [83041] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Diego Gonzalez <​diegohcg@webkit.org>

Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

  • platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::findChecker): (QtMobileWebStyle::findRadio): (QtMobileWebStyle::findComboButton):
6:18 AM Changeset in webkit [83040] by podivilov@chromium.org
  • 3 edits
    1 move
    1 add in trunk/Source/WebCore

2011-04-06 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
​https://bugs.webkit.org/show_bug.cgi?id=57641

  • WebCore.xcodeproj/project.pbxproj:
  • gyp/streamline-inspector-source.sh:
  • inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
  • inspector/inline-javascript-imports.py: Added.
5:59 AM Changeset in webkit [83039] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.

Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.

Test: editing/inserting/insert-paragraph-separator-tab-span.html

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph separator into a paragraph separator.

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
style to the paragraph separator or the text.

  • editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
  • editing/inserting/insert-paragraph-separator-tab-span.html: Added.
5:12 AM Changeset in webkit [83038] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-06 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Add member functions for determining line/paragraph separation to InlineIterator
​https://bugs.webkit.org/show_bug.cgi?id=57938

Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
InlineIterator, where it makes far more sense for them to be. Also moving
shouldPreserveNewline to RenderObject and renaming it preservesNewline.

No new tests as this provides no new functionality.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::atTextParagraphSeparator): (WebCore::InlineIterator::atParagraphSeparator):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderObject.h: (WebCore::RenderObject::preservesNewline):
2:57 AM Changeset in webkit [83037] by apavlov@chromium.org
  • 5 edits in trunk

2011-04-05 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Range insertNode function does not update content in the inspector
​https://bugs.webkit.org/show_bug.cgi?id=57829

  • inspector/elements/modify-chardata-expected.txt:
  • inspector/elements/modify-chardata.html:

2011-04-05 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Range insertNode function does not update content in the inspector
​https://bugs.webkit.org/show_bug.cgi?id=57829

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
2:37 AM Changeset in webkit [83036] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-06 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve tests for QWebFrame::url() and related methods
​https://bugs.webkit.org/show_bug.cgi?id=57865

  • tests/qwebframe/tst_qwebframe.cpp: (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test. (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl() that fails and a load() that fails (for a different URL).

(tst_QWebFrame::setUrlWithFragment_data):
(tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
the URL in the frame before the test starts.

(tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
the same URL as argument.

(extractBaseUrl):
(tst_QWebFrame::setUrlThenLoads_data):
(tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
sequence of set and loads. Those tests are interesting because the properties
react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
is used or after the load() is committed and baseUrl() is similar to url() but also depends
on the contents of the page when it loads.

2:24 AM Changeset in webkit [83035] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

getComputedTextLength always returns 0 with tspan elements
​https://bugs.webkit.org/show_bug.cgi?id=19814

Add a testcase showing that getComputedTextLength for <tspan> works fine.

  • svg/text/tspan-getComputedTextLength-expected.txt: Added.
  • svg/text/tspan-getComputedTextLength.svg: Added.
2:03 AM Changeset in webkit [83034] by alex
  • 3 edits in trunk/Source/WebCore

2011-04-06 Alejandro G. Castro <​alex@igalia.com>

Fix GTK3 compilation after r82962.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::paintToggle): (WebCore::renderButton): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::paintProgressBar): (WebCore::paintSpinArrowButton):
  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
1:24 AM Changeset in webkit [83033] by caseq@chromium.org
  • 11 edits in trunk

2011-04-06 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] remove inspectedPage.* events
​https://bugs.webkit.org/show_bug.cgi?id=57763

  • Removed webInspector.inspectedPage.* events
  • moved onNavigated to webInspector.resources
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.InspectedWindow):
  • inspector/front-end/ExtensionAPISchema.json:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
  • inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.inspectedURLChanged):

2011-04-06 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] remove inspectedPage.* events
​https://bugs.webkit.org/show_bug.cgi?id=57763

  • Removed webInspector.inspectedPage.* events
  • moved onNavigated to webInspector.resources
  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.runWhenPageLoads):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runWhenPageLoads.chainedCallback): (initialize_InspectorTest.InspectorTest.runWhenPageLoads):
  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
1:10 AM Changeset in webkit [83032] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-04-06 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Antti Koivisto.

Add <head> to the simpleUserAgentStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=57915

  • css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): add head to the simple stylesheet, display:none.
1:03 AM Changeset in webkit [83031] by mnaganov@chromium.org
  • 7 edits
    5 adds in trunk

2011-04-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
​https://bugs.webkit.org/show_bug.cgi?id=57856

Test: inspector/profiler/detailed-heapshots-summary.html

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid):
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):

2011-04-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
​https://bugs.webkit.org/show_bug.cgi?id=57856

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.): (initialize_InspectorTest):
  • inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary.html: Added.
  • inspector/profiler/detailed-heapshots-test.js: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
12:50 AM Changeset in webkit [83030] by ojan@chromium.org
  • 1 edit
    61 adds in trunk/LayoutTests

2011-04-06 Ojan Vafai <​ojan@chromium.org>

​http://trac.webkit.org/changeset/83024 incorrectly removed the mac-leopard results.
Instead, it should have moved the results from chromium-mac to chromium-mac-leopard.

  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-length-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-runs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
12:46 AM Changeset in webkit [83029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-06 Anders Bakken <​agbakken@gmail.com>

Reviewed by David Levin.

[Qt] SmartReplaceQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40261

This patch does not require new test cases.

  • editing/qt/SmartReplaceQt.cpp: (WebCore::isCharacterSmartReplaceExempt):
12:40 AM Changeset in webkit [83028] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Add missing pixel test result.

  • platform/mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
  • platform/mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.
12:38 AM Changeset in webkit [83027] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-06 James Kozianski <​koz@chromium.org>

[chromium] Add expectations for failing GPU tests.
​https://bugs.webkit.org/show_bug.cgi?id=57926

  • platform/chromium/test_expectations.txt:
12:22 AM Changeset in webkit [83026] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
​https://bugs.webkit.org/show_bug.cgi?id=57755

  • editing/execCommand/insert-line-break-onload-expected.txt: Added.
  • editing/execCommand/insert-line-break-onload.html: Added to check calling InsertLineBreak without any crash.

2011-04-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
​https://bugs.webkit.org/show_bug.cgi?id=57755

Test: editing/execCommand/insert-line-break-onload.html

  • editing/TypingCommand.cpp: (WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().
Note: See TracTimeline for information about the timeline view.