⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 8, 2011:

9:41 PM Changeset in webkit [83374] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

No need to compile .js files, that is what the JIT is for.

  • WebKit.xcodeproj/project.pbxproj:
8:05 PM Changeset in webkit [83373] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-08 David Humphrey <​david.humphrey@senecac.on.ca>

Reviewed by Eric Carlson.

Fix call order of media element muted and play(), such that setting muted before play() works.
​https://bugs.webkit.org/show_bug.cgi?id=57673
​https://code.google.com/p/chromium/issues/detail?id=70777

Manual test added: manual-tests/media-muted.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
  • manual-tests/media-muted.html: Added.
6:59 PM Changeset in webkit [83372] by ap@apple.com
  • 5 edits in trunk/Source

2011-04-08 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
​https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/9060555>

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this should be changed to match WebKit2.

2011-04-08 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
​https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/9060555>

The problem is that command handling should be different for events that come as keyDown:
and those that come as performKeyEquivalent:. WebKit1 only tries custom "key bindings"
when handling a keyDown:, letting a performKeyEquivalent: run through the whole responder
chain first.

This would be very difficult to implement in WebKit2 because of how it re-sends the same
event after web process handling. Luckily, we can both fix the bug and make the behavior
more robust by not hardcoding key combinations.

  • WebProcess/WebPage/WebPage.h: Edit performNonEditingBehaviorForSelector.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): When executing commands, also try executing editor commands in their non-editing meaning, which is usually scrolling. (WebKit::WebPage::performNonEditingBehaviorForSelector): Naive implementation with a chain of ifs, which is hopefully ok performance-wise for a dozen check. (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Only kept two commands here that I couldn't easily move.
6:39 PM Changeset in webkit [83371] by jhoneycutt@apple.com
  • 2 edits in trunk/Tools

http/tests/loading/preload-append-scan.php is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=58178

Reviewed by Brian Weinstein.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(lastPathComponent):
Use CFURL API to find the last path component, rather than
PathFindFileName(), because the latter will include the query string.

6:36 PM Changeset in webkit [83370] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Fix windows assertion on ~CCThread
​https://bugs.webkit.org/show_bug.cgi?id=58153

Because ~CCThread uses waitForThreadCompletion,
calling detachThread is not necessary.

  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
6:31 PM Changeset in webkit [83369] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
updated correctly.
​https://bugs.webkit.org/show_bug.cgi?id=58179

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide" Substitutions item is selected, call toggleSubstitutionsPanelIsShowing.
(WebKit::WebPageProxy::substitutionsPanelIsShowing):
Ask the TextChecker.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::substitutionsPanelIsShowing):
As the shared NSSpellChecker if the substitutionsPanel is visible.
(WebKit::TextChecker::toggleSubstitutionsPanelIsShowing):
Order the substitutionsPanel out or front (copied from WKView.mm).

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::substitutionsPanelIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the editor code relies on the value returned.

5:57 PM Changeset in webkit [83368] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a bug where right-to-left frames incorrectly reported that they were pinned to the left
when they were actually not.

Reviewed by Adele Peterson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeScrollOffsetForMainFrame): Do not assume that the minimum scroll offset
is zero, because it is not.

5:55 PM Changeset in webkit [83367] by jianli@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix broken sentence in WebCore/Change of my rollout r83365.

5:54 PM Changeset in webkit [83366] by aa@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

Reviewed by Dmitry Titov.

Re-land ​http://trac.webkit.org/changeset/83007. This works
without changes after ​https://bugs.webkit.org/show_bug.cgi?id=58110.

​https://bugs.webkit.org/show_bug.cgi?id=58096

5:52 PM Changeset in webkit [83365] by jianli@chromium.org
  • 3 edits
    2 deletes in trunk

2011-04-08 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83348.
​http://trac.webkit.org/changeset/83348
​https://bugs.webkit.org/show_bug.cgi?id=49508

Breaks layout tests in QT, Win7 and Chromium.

  • fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • fast/forms/cursor-at-editable-content-boundary.html: Removed.

2011-04-08 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83348.
​http://trac.webkit.org/changeset/83348
​https://bugs.webkit.org/show_bug.cgi?id=49508

Breaks

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
5:28 PM Changeset in webkit [83364] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::Drop):

5:18 PM Changeset in webkit [83363] by jberlin@webkit.org
  • 14 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 5: Implement the code show and hide the Spelling UI via the context menu item (both
Windows and Mac).

  • UIProcess/API/C/win/WKTextChecker.h:

Add the new WKTextCheckerClient funtions.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide Spelling and Grammar" item is selected, call toggleSpellingUIIsShowing.
(WebKit::WebPageProxy::spellingUIIsShowing):
Call through to TextChecker.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
    • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Call the TextCheckerClient.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::spellingUIIsShowing):
Ask the shared NSSpellChecker if the spellingPanel is visible.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Order the spellingPanel out or front (copied from WKView.mm).

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Call notImplemented.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Ditto.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::spellingUIIsShowing):
Call the client.
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::spellingUIIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the Editor code relies on the value returned.

5:04 PM Changeset in webkit [83362] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Sandboxing doesn't work if a local file is dropped on the content area
​https://bugs.webkit.org/show_bug.cgi?id=58177
<rdar://problem/9019253>

When performing a drag and the dragging pasteboard contains a local file, create a
sandbox extension and pass it along. If we end up loading the file, the sandbox extension
tracker will consume the extension.

  • UIProcess/API/mac/WKView.mm: (maybeCreateSandboxExtensionFromPasteboard): Add helper function.

(-[WKView performDragOperation:]):
Create a sandbox extension handle and pass it to performDrag.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered): (WebKit::WebPageProxy::dragUpdated): (WebKit::WebPageProxy::dragExited): Pass an empty sandbox extension handle to performDragControllerAction.

(WebKit::WebPageProxy::performDrag):
Pass the sandbox extension handle along to performDragControllerAction.

(WebKit::WebPageProxy::performDragControllerAction):
Send along the sandbox extension handle.

  • WebProcess/WebCoreSupport/WebDragClient.cpp: (WebKit::WebDragClient::willPerformDragDestinationAction): If the destination action is a load action, call WebPage::willPerformLoadDragDestinationAction.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): Create a sandbox extension.

(WebKit::WebPage::willPerformLoadDragDestinationAction):
If we have a sandbox extension, pass it along to the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::willPerformLoadDragDestinationAction):
Call setPendingProvisionalSandboxExtension.

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Call setPendingProvisionalSandboxExtension.

(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
Factor code from beginLoad out into a separate function.

  • WebProcess/WebPage/WebPage.messages.in: PerformDragControllerAction now takes a sandbox extension handle.
5:02 PM Changeset in webkit [83361] by jianli@chromium.org
  • 13 edits in trunk/Tools

Revert "2011-04-08 Dirk Pranke <​dpranke@chromium.org>"

This reverts commit 78a47b96232b89bedf2e2c98794bbac8e19b905a.

5:00 PM Changeset in webkit [83360] by morrita@google.com
  • 5 edits in trunk

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Updated the result. This new result matches other browsers behavior.

  • platform/mac/fast/box-shadow/inset-expected.checksum:
  • platform/mac/fast/box-shadow/inset-expected.png:

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Handled inset shadow path for rounded and non-rounded rect
differently as normal shadow path is doing.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
4:58 PM Changeset in webkit [83359] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 83351
BUG=78106

4:54 PM Changeset in webkit [83358] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-07 Simon Fraser <Simon Fraser>

Reviewed by Martin Robinson.

REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
​https://bugs.webkit.org/show_bug.cgi?id=55180

The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
data we get back from ImageBuffer::getImageData() do not vary in
endianness.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage):
4:51 PM Changeset in webkit [83357] by alice.liu@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=58151
Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::close):
Resolve a difference between old WebKit WebView and WebKit2 WebView by destroying and clearing
out WebKit2 WebView's HWND when closing. Not doing so was causing the WebView to remain in the
list of WindowMessageBroadcaster listeners, and after closing the WebView, WindowMessageBroadcaster
would message a dead WebView and crash.

4:37 PM Changeset in webkit [83356] by arv@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-08 Erik Arvidsson <​arv@chromium.org>

Reviewed by Dimitri Glazkov.

IFrame is getting the focus even though it is hidden
​https://bugs.webkit.org/show_bug.cgi?id=55861

  • fast/dom/hidden-iframe-no-focus-expected.txt: Added.
  • fast/dom/hidden-iframe-no-focus.html: Added.

2011-04-08 Erik Arvidsson <​arv@chromium.org>

Reviewed by Dimitri Glazkov.

IFrame is getting the focus even though it is hidden
​https://bugs.webkit.org/show_bug.cgi?id=55861

Test: fast/dom/hidden-iframe-no-focus.html

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
  • html/HTMLFrameOwnerElement.h:
4:01 PM Changeset in webkit [83355] by commit-queue@webkit.org
  • 6 edits in trunk

2011-04-08 Jeff Timanus <​twiz@chromium.org>

Reviewed by Kenneth Russell.

Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
​https://bugs.webkit.org/show_bug.cgi?id=57768

  • platform/chromium/test_expectations.txt:

2011-04-08 Jeff Timanus <​twiz@chromium.org>

Reviewed by Kenneth Russell.

Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
​https://bugs.webkit.org/show_bug.cgi?id=57768

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h:
4:00 PM Changeset in webkit [83354] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Make the drag operations be different functions
​https://bugs.webkit.org/show_bug.cgi?id=58169

Since we want performDrag to take a sandbox extension, separate the four
drag operations out into different functions. No functionality change.

  • UIProcess/API/mac/WKView.mm: (-[WKView draggingEntered:]): (-[WKView draggingUpdated:]): (-[WKView draggingExited:]): (-[WKView performDragOperation:]):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered): (WebKit::WebPageProxy::dragUpdated): (WebKit::WebPageProxy::dragExited): (WebKit::WebPageProxy::performDrag):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::DragEnter): (WebKit::WebView::DragOver): (WebKit::WebView::DragLeave): (WebKit::WebView::Drop):
3:59 PM Changeset in webkit [83353] by dcheng@chromium.org
  • 12 edits
    2 adds in trunk

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

Add a reftest to verify that the various bits in the pipeline work as expected.

  • editing/pasteboard/data-transfer-items-image-png-expected.html: Added.
  • editing/pasteboard/data-transfer-items-image-png.html: Added.

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

This patch implements DataTransferItem::getAsFile() using Blobs. In
addition, plumbing for image/png has been added so image paste will be
supported as long as the renderer makes that data available.

Tests: editing/pasteboard/data-transfer-items-image-png.html

  • dom/DataTransferItem.h:
  • dom/DataTransferItem.idl:
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
  • platform/chromium/DataTransferItemChromium.h:
  • platform/chromium/PlatformBridge.h:

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

Add glue for reading image data from clipboard.

  • DEPS:
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardReadImage):
3:42 PM Changeset in webkit [83352] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 MORITA Hajime <​morrita@google.com>

Unreviewed windows build fix.

  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
3:39 PM Changeset in webkit [83351] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
​https://bugs.webkit.org/show_bug.cgi?id=57595
<rdar://problem/9222122>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: editing/style/bold-with-dom-changes.html

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

  • editing/style/bold-with-dom-changes-expected.txt: Added.
  • editing/style/bold-with-dom-changes.html: Added.
3:39 PM Changeset in webkit [83350] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Parse 'DispatchOnConnectionQueue' in messages.in files
​https://bugs.webkit.org/show_bug.cgi?id=58168

Handle parsing multiple, space-separated attributes in .messages.in files. Keep track of
'DispatchOnConnectionQueue' and rename 'delayed' to 'Delayed'.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
3:37 PM Changeset in webkit [83349] by rolandsteiner@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-04-07 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58060 - Prepare access to TreeScope from Node, using NodeRareData
​https://bugs.webkit.org/show_bug.cgi?id=58060

Add a TreeScope pointer to NodeRareData to allow direct access to the containing tree scope.
However, in case the containing scope is the document, this is not set, and the
document pointer within Node is used instead.

In an object derived from TreeScope (currently Document), the tree scope pointer
points to itself. Such objects also contain a parent tree scope pointer that
points to the containing scope. For Document, this is 0.

Add new functions setTreeScope[Recursively] that replace setDocument[Recursively]
in public usage. setDocument[Recursively] are now only used internally and are
thererfore protected.

No new tests. (no new functionality)

  • dom/ContainerNode.cpp: change DOM manipulation methods to update scope of inserted nodes (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::setDocType): Ditto (WebCore::Document::adoptNode): Ditto
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::treeScope): use NodeRareData to check if a non-Document scope is set (WebCore::Node::setTreeScope): update NodeRareData depending on whether scope is a document (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::setDocumentRecursively):
  • dom/Node.h:
  • dom/NodeRareData.h: add scope pointer (WebCore::NodeRareData::NodeRareData): (WebCore::NodeRareData::treeScope): (WebCore::NodeRareData::setTreeScope):
  • dom/TreeScope.cpp: add parentTreeScope pointer (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
  • dom/TreeScope.h: (WebCore::TreeScope::parentTreeScope):
3:34 PM Changeset in webkit [83348] by xji@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

  • fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • fast/forms/cursor-at-editable-content-boundary.html: Added.

2011-04-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.

Test: fast/forms/cursor-at-editable-content-boundary.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
3:23 PM Changeset in webkit [83347] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToWord):
3:15 PM Changeset in webkit [83346] by scheib@chromium.org
  • 2 edits in trunk/Tools

2011-04-08 Vincent Scheib <​scheib@chromium.org>

Reviewed by Eric Seidel.

add chromium-gpu-linux-x86_64 to the recognized list of ports
​https://bugs.webkit.org/show_bug.cgi?id=58099

Add chromium-gpu-linux-x86_64 to fix assert.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2:57 PM Changeset in webkit [83345] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57971

Reviewed by Simon Fraser.

Rework visited/unvisited links for before/after content. Propagate the bits earlier so that we don't lose
them when we throw away the visited style. Don't throw away the visited link style for pseudo elements
either, so that the styles are consistent.

Source/WebCore:

Added fast/history/visited-generated-content-test.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

LayoutTests:

  • fast/history/visited-generated-content-test-expected.txt: Added.
  • fast/history/visited-generated-content-test.html: Added.
2:21 PM Changeset in webkit [83344] by morrita@google.com
  • 17 edits
    2 adds
    1 delete in trunk/Source

2011-04-06 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

[Refactoring] Auto correction panel should be handled by its own class.
​https://bugs.webkit.org/show_bug.cgi?id=55571

Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
SpellingCorrectionController class.
This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
code paths inside the never reached without autocorrection support.
Removing guards reduces unintentional build breakage.

No new tests, no behavior chagne.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CorrectionPanelInfo.h: Removed.
  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): (WebCore::Editor::respondToChangedContents): (WebCore::Editor::appliedEditing): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::cut): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::isAutomaticSpellingCorrectionEnabled): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::unappliedSpellCorrection): (WebCore::Editor::updateMarkersForWordsAffectedByEditing): (WebCore::Editor::startCorrectionPanelTimer): (WebCore::Editor::handleCorrectionPanelResult): (WebCore::Editor::dismissCorrectionPanelAsIgnored):
  • editing/Editor.h:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SpellingCorrectionController.cpp: Added. (WebCore::markerTypesForAutocorrection): (WebCore::markerTypesForReplacement): (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::SpellingCorrectionController): (WebCore::SpellingCorrectionController::~SpellingCorrectionController): (WebCore::SpellingCorrectionController::startCorrectionPanelTimer): (WebCore::SpellingCorrectionController::stopCorrectionPanelTimer): (WebCore::SpellingCorrectionController::stopPendingCorrection): (WebCore::SpellingCorrectionController::applyPendingCorrection): (WebCore::SpellingCorrectionController::hasPendingCorrection): (WebCore::SpellingCorrectionController::isSpellingMarkerAllowed): (WebCore::SpellingCorrectionController::show): (WebCore::SpellingCorrectionController::handleCancelOperation): (WebCore::SpellingCorrectionController::dismiss): (WebCore::SpellingCorrectionController::dismissSoon): (WebCore::SpellingCorrectionController::applyCorrectionPanelInfo): (WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate): (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection): (WebCore::SpellingCorrectionController::correctionPanelTimerFired): (WebCore::SpellingCorrectionController::handleCorrectionPanelResult): (WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled): (WebCore::SpellingCorrectionController::windowRectForRange): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::client): (WebCore::SpellingCorrectionController::textChecker): (WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed): (WebCore::SpellingCorrectionController::markReversed): (WebCore::SpellingCorrectionController::markCorrection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  • editing/SpellingCorrectionController.h: Added. (WebCore::SpellingCorrectionController::UNLESS_ENABLED): (WebCore::SpellingCorrectionController::shouldStartTimeFor): (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::markMisspellingsAfterTyping): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/htmlediting.h: (WebCore::isAmbiguousBoundaryCharacter):
  • page/EditorClient.h:
  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors):
2:06 PM Changeset in webkit [83343] by rniwa@webkit.org
  • 3 edits
    2 moves
    24 deletes in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dump-as-markup conversion: editing/pasteboard/paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html
​https://bugs.webkit.org/show_bug.cgi?id=58081

Converted paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html to dump-as-markup tests.
Also explained what to expect in each test.

  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Added.
  • editing/pasteboard/paste-text-at-tabspan-001.html:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Added.
  • editing/pasteboard/paste-text-at-tabspan-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
1:58 PM Changeset in webkit [83342] by hclam@chromium.org
  • 27 edits
    3 deletes in trunk

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken.

  • configure.ac:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Removed.
  • html/HTMLTrackElement.h: Removed.
  • html/HTMLTrackElement.idl: Removed.

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • WebKit.xcodeproj/project.pbxproj:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • features.gypi:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Scripts/build-webkit:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:46 PM Changeset in webkit [83341] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Ooops, typo, build fix.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

1:40 PM Changeset in webkit [83340] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-08 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove modular references after support for the flag was removed.
​https://bugs.webkit.org/show_bug.cgi?id=57018

Removed modular references after support for the flag was removed.

Support was removed because the Qt Modularization project decided we
don't need it. It's better to base decisions on the available
information, as demonstrated in the patch by checking
QT.phonon.includes.

  • Source/WebKit.pri:
1:38 PM Changeset in webkit [83339] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=58155 and part of <rdar://problem/9251767>
BitmapImage::getFirstCGImageRefOfSize fails if the frameCount hasn't been initialized from the image source.

Reviewed by Adam Roben.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getFirstCGImageRefOfSize): Call frameCount() instead of accessing m_frames.size() to

make sure the frames are properly tallied first.

1:36 PM Changeset in webkit [83338] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Dragging and dropping an image in edit mode does not work
​https://bugs.webkit.org/show_bug.cgi?id=19385

When adding an image to the clipboard, we should also include the HTML code of that image so
it can be used for internal drag and drop.

This HTML is expected by all clients of drop events so a fragment can be moved from one browser to
another, or inside the same browser.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
1:33 PM Changeset in webkit [83337] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Bug 58154 - Add support for comparison operators to the DFG JIT.

Reviewed by Oliver Hunt.

Add support for <, <=, ==, ===, and also !. Add support for all corresponding
bytecode ops, including the not- and -null forms. Initially add functionally
correct support, we'll revisit the performance.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::parse):

  • Add support for parsing of bytecode opcodes,
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • Add new operation call types, return bool values.
  • dfg/DFGNode.h:
    • Add new node types.
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Add code generation for new nodes.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationCompareLess):
(JSC::DFG::operationCompareLessEq):
(JSC::DFG::operationCompareEq):
(JSC::DFG::operationCompareStrictEq):
(JSC::DFG::dfgConvertJSValueToBoolean):

  • dfg/DFGOperations.h:
    • Add operation callbacks to implement new ops.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Add code generation for new nodes.
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePatchGetArrayLength):

  • Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
  • runtime/JSImmediate.h:
    • Make tag values public, rather than relying on a friend - this matches JSVALUE32_64.
1:28 PM Changeset in webkit [83336] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Rebaselines and text expectation updates after r83322.
The bug is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=58158

  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
1:28 PM Changeset in webkit [83335] by hclam@chromium.org
  • 27 edits
    3 adds in trunk

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • configure.ac:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

No new tests. No real functionality added just yet.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Added. (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::create): (WebCore::HTMLTrackElement::insertedIntoTree): (WebCore::HTMLTrackElement::willRemove): (WebCore::HTMLTrackElement::src): (WebCore::HTMLTrackElement::setSrc): (WebCore::HTMLTrackElement::kind): (WebCore::HTMLTrackElement::setKind): (WebCore::HTMLTrackElement::srclang): (WebCore::HTMLTrackElement::setSrclang): (WebCore::HTMLTrackElement::label): (WebCore::HTMLTrackElement::setLabel): (WebCore::HTMLTrackElement::isDefault): (WebCore::HTMLTrackElement::setIsDefault): (WebCore::HTMLTrackElement::isURLAttribute):
  • html/HTMLTrackElement.h: Added.
  • html/HTMLTrackElement.idl: Added.

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • features.gypi:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Scripts/build-webkit:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:21 PM Changeset in webkit [83334] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

new-run-webkit-tests: configure a NRWT test bot for Mac SL
​https://bugs.webkit.org/show_bug.cgi?id=58114

This change removes the old new-run-webkit-tests entry and
updates it for a new test-only bot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:14 PM Changeset in webkit [83333] by Dimitri Glazkov
  • 9 edits in trunk

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

layoutTestController.shadowRoot returns null, not undefined, when
its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

Update the test to expect null and not undefined.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • platform/chromium/test_expectations.txt: unskip keygen.html

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowRoot):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
1:11 PM Changeset in webkit [83332] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Logic error in HTMLMediaElement::exitFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=58085

The new full screen API case could fall through to the legacy API case
unintentionally if a script calls exitFullscreen on an element which is
not the current full screen element.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::exitFullscreen):
1:10 PM Changeset in webkit [83331] by dimich@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
​https://bugs.webkit.org/show_bug.cgi?id=58110
Since they are simple one-thread tests.
This code parallels the code in Chromium's idb bindings that uses v8 Lockers in utility process,
which is equally not needed since there is only one thread running v8 in that process.

Reviewed by Adam Barth.

  • tests/IDBBindingUtilitiesTest.cpp:
1:08 PM Changeset in webkit [83330] by dpranke@chromium.org
  • 13 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: implement support for audio tests.

​https://bugs.webkit.org/show_bug.cgi?id=57987

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:08 PM Changeset in webkit [83329] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Mike Reed <​reed@google.com>

Reviewed by Eric Seidel.

Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work
​https://bugs.webkit.org/show_bug.cgi?id=57782

No new tests. This change only affects print-preview and build option SKIA_GPU

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
12:58 PM Changeset in webkit [83328] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaselines after r83291.

  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt:
12:48 PM Changeset in webkit [83327] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: clean up the way we handle missing files,
to be consistent. With this change, the Port.expected_X() and
Driver.run_test() routines should return None if there is no
output, not .

​https://bugs.webkit.org/show_bug.cgi?id=58101

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:39 PM Changeset in webkit [83326] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Darin Alder.

REGRESSION (WebKit2): AppKit thinks that web views don't support DocumentAccess
​https://bugs.webkit.org/show_bug.cgi?id=58102
<rdar://problem/9223246>

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): (-[WKView insertText:replacementRange:]): (-[WKView validAttributesForMarkedText]): (-[WKView setMarkedText:selectedRange:replacementRange:]): (-[WKView attributedSubstringForProposedRange:actualRange:]): (-[WKView firstRectForCharacterRange:actualRange:]): Switch to NSTextInputClient, opting out of optimizations and optional features for now.
12:37 PM Changeset in webkit [83325] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Not reviewed.

Skip for DRT differences.

  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
12:33 PM Changeset in webkit [83324] by mjs@apple.com
  • 7 edits in trunk/Source/WebKit/mac

2011-04-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

-[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
​https://bugs.webkit.org/show_bug.cgi?id=58128
<rdar://problem/9244553>


The root of the problem here was an O(N2) issue - each WebView,
upon having its preferences initialized, would broadcast a
notification that was listened to by all other WebViews sharing
its preferences.


To maintain the API contract, I split the notification into two,
one that is for public API consumption, and the other which is for
internal use only. Changes that don't need to be picked up by
other WebViews broadcast the public notification only. And we
avoid WebView broadcasting a notification just to get itself to
update.

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase _startUpIconDatabase]): (-[WebIconDatabase _shutDownIconDatabase]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
  • WebView/WebPreferences.mm: (-[WebPreferences initWithIdentifier:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _setFloatValue:forKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences _setLongLongValue:forKey:]): (-[WebPreferences _setUnsignedLongLongValue:forKey:]): (-[WebPreferences _postPreferencesChangedNotification]): (-[WebPreferences _postPreferencesChangedAPINotification]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]): (-[WebView _preferencesChanged:]): (-[WebView setUsesPageCache:]): (+[WebView initialize]): (-[WebView setPreferences:]): (-[WebView _keyboardUIMode]):
  • WebView/WebViewInternal.h:
12:30 PM Changeset in webkit [83323] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-08 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Martin Robinson.

[Qt][WK2][Symbian] Remove use of stack arrays with variable size
​https://bugs.webkit.org/show_bug.cgi?id=57877

For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integer

  • Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
12:29 PM Changeset in webkit [83322] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.

REGRESSION(r81887): Crash in SplitElement
​https://bugs.webkit.org/show_bug.cgi?id=57743

The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
even when the position was after the last node in it container. Since all we are doing here is to splitting tree
up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
and highestEnclosingNodeOfType.

Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
it incorrectly called deprecatedNode instead of containerNode.

Test: editing/inserting/insert-images-in-pre-x-crash.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::highestEnclosingNodeOfType):

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.

REGRESSION(r81887): Crash in SplitElement
​https://bugs.webkit.org/show_bug.cgi?id=57743

Added a regression test for a crash in ReplaceSelectionCommand.

  • editing/inserting/insert-images-in-pre-x-crash-expected.txt: Added.
  • editing/inserting/insert-images-in-pre-x-crash.html: Added.
11:55 AM Changeset in webkit [83321] by Antti Koivisto
  • 3 edits
    3 adds in trunk

Incoming source should be preload scanned when the parser is blocked
​https://bugs.webkit.org/show_bug.cgi?id=58117

Reviewed by Tony Gentilcore.

Source/WebCore:

Scan the appended source if parser is blocked.

Test: http/tests/loading/preload-append-scan.php

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

LayoutTests:

  • http/tests/loading/preload-append-scan-expected.txt: Added.
  • http/tests/loading/preload-append-scan.php: Added.
  • http/tests/resources/slow-script.pl: Added.
11:53 AM Changeset in webkit [83320] by commit-queue@webkit.org
  • 9 edits in trunk

2011-04-08 Varun Jain <​varunjain@chromium.org>

Reviewed by Darin Fisher.

Need to extend WebKit chromium API to access text selection
​https://bugs.webkit.org/show_bug.cgi?id=57888

  • Source/WebKit/chromium/public/WebFrame.h:
  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebFrameImpl.cpp:
  • Source/WebKit/chromium/src/WebFrameImpl.h:
  • Source/WebKit/chromium/src/WebPopupMenuImpl.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
  • Source/WebKit/chromium/src/WebViewImpl.h:
  • Source/WebKit/chromium/tests/PopupMenuTest.cpp:
11:47 AM Changeset in webkit [83319] by Martin Robinson
  • 5 edits in trunk/Source

2011-04-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the WebKit2 build for older versions of GTK+
​https://bugs.webkit.org/show_bug.cgi?id=58095

No new tests. This is just a build fix.

  • platform/gtk/GtkVersioning.c: (gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
  • platform/gtk/GtkVersioning.h: Add the new method to the header.

2011-04-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the WebKit2 build for older versions of GTK+
​https://bugs.webkit.org/show_bug.cgi?id=58095

  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Include the GtkVersioning.h header.
11:40 AM Changeset in webkit [83318] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixed a typo in chromium test expectation list.

  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [83317] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, added one more failed test to test expectation list in chromium.

  • platform/chromium/test_expectations.txt:
11:17 AM CommitQueue edited by nholbrook@apple.com
Update committers.py link. (diff)
10:58 AM Changeset in webkit [83316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Misha Tyutyunik <​michael.tyutyunik@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Plugin is not scrolled together with page content or jumping
when content is rendered using cache (backing store).
​https://bugs.webkit.org/show_bug.cgi?id=56130

This is a Symbian portion of the fix. For Linux it looks like
it's enough to call set geometry which should be addressed in
​https://bugs.webkit.org/show_bug.cgi?id=57179

No new tests required. This can be tested with manual tests from
WebCore/manual-tests/qt and WebCore/manual-tests/plugins

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget):
10:50 AM Changeset in webkit [83315] by Lucas Forschler
  • 2 edits in tags/Safari-534.28.1/Source/JavaScriptCore

Merge 83299.

10:50 AM Changeset in webkit [83314] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, added failed tests to test expectation list in chromium.

  • platform/chromium/test_expectations.txt:
10:46 AM Changeset in webkit [83313] by Lucas Forschler
  • 5 edits in tags/Safari-534.28.1/Source

Versioning.

10:44 AM Changeset in webkit [83312] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Abhishek Arya <​inferno@chromium.org>

Unreviewed. Remove accidental printf added in r83306.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
10:43 AM Changeset in webkit [83311] by Lucas Forschler
  • 1 copy in tags/Safari-534.28.1

New Tag.

10:43 AM Changeset in webkit [83310] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-08 Pere Martir <​pere.martir4@gmail.com>

Reviewed by Adam Roben.

Locate NSTD.EXE in 64-bit Windows
​https://bugs.webkit.org/show_bug.cgi?id=57847

  • Scripts/old-run-webkit-tests:
10:41 AM Changeset in webkit [83309] by Lucas Forschler
  • 2 edits in tags/Safari-534.28/Source/JavaScriptCore

Rollout 83299 from Tag.

10:36 AM Changeset in webkit [83308] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Dragging text in a WebKit2 window results in a copy instead of a move.
​https://bugs.webkit.org/show_bug.cgi?id=56772
<rdar://problem/9165140>

Reviewed by Darin Adler.

cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
the call to startDrag is asynchronous.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::cleanupAfterSystemDrag):

10:05 AM Changeset in webkit [83307] by kbalazs@webkit.org
  • 6 edits in trunk/Source

2011-04-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
​https://bugs.webkit.org/show_bug.cgi?id=58030

  • wtf/Platform.h: Introduce USE(UNIX_DOMAIN_SOCKETS) for WebKit2.

2011-04-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
​https://bugs.webkit.org/show_bug.cgi?id=58030

Replace "PLATFORM(QT)
PLATFORM(GTK)" conditions in IPC code with

USE(UNIX_DOMAIN_SOCKETS).

  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/SharedMemory.h:
9:59 AM Changeset in webkit [83306] by andersca@apple.com
  • 3 edits in trunk/Source

2011-04-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Clicks not recognized on ​http://www.nibblestutorials.net/ which uses Silverlight
​https://bugs.webkit.org/show_bug.cgi?id=58108
<rdar://problem/9167611>

Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
event has been handled. In this case it lead to a very subtle bug where the plug-in element would
lose focus right after a mouse down even had been sent.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleMouseEvent):
9:49 AM Changeset in webkit [83305] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83295.
​http://trac.webkit.org/changeset/83295
​https://bugs.webkit.org/show_bug.cgi?id=58144

Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-04-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83295.
​http://trac.webkit.org/changeset/83295
​https://bugs.webkit.org/show_bug.cgi?id=58144

Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
9:34 AM Changeset in webkit [83304] by Lucas Forschler
  • 2 edits in tags/Safari-534.28/Source/JavaScriptCore

Merge 83299.

9:10 AM Changeset in webkit [83303] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-08 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, looks like the test is working fine now.

[GTK] websocket/tests/bad-sub-protocol-control-chars.html fails on 32-bit Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=46942

  • platform/gtk/Skipped:
9:06 AM Changeset in webkit [83302] by Adam Roben
  • 2 edits in trunk/Tools

Qt build fix

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
9:03 AM Changeset in webkit [83301] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-08 Jon Lee <​jonlee@apple.com>

Reviewed by David Levin.

adding *.vcproj.*.user to .gitignore for Visual Studio development
​https://bugs.webkit.org/show_bug.cgi?id=58097

  • .gitignore:
9:00 AM Changeset in webkit [83300] by Adam Roben
  • 14 edits
    5 adds in trunk

Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms

This matches WebKit1.

Fixes <​http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
plugin

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroy): Null out our NPWindow's window handle and pass it to
NPP_SetWindow (unless we're on Mac).

Tools:

Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginLogWithArguments): Moved code to format and log the message here...
(pluginLog): ...from here.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::log): Added. Calls through to pluginLogWithArguments.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.

(NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
to begin.
(NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
constructor.
(NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
can be used to invoke our setWillBeDestroyed function.
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
anything unexpected happens).
(NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
NPP_SetWindow was *not* called during destruction.
(NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
method, setWillBeDestroyed.
(NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
object.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added new test.

  • Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with

WebKit1 on Mac, since it can't work properly due to <​http://webkit.org/b/58077>.

LayoutTests:

Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms

  • platform/win-wk2/Skipped: Removed a test that no longer crashes thanks to this fix.
  • plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • plugins/npp-set-window-called-during-destruction.html: Added.
  • platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is

different from the cross-platform results because we don't expect NPP_SetWindow to be called
during destruction.

  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is

a copy of the cross-platform results, needed to override the Mac-specific results.

8:56 AM Changeset in webkit [83299] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Clean build fix

  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Don't try to delete directories that

don't exist. Also switched from del /s to rmdir /s, which has the benefit of deleting the
directory itself in addition to the files it contains.

8:48 AM Changeset in webkit [83298] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move WheelEvent-dispatching logic into WheelEventDispatchMediator.
​https://bugs.webkit.org/show_bug.cgi?id=57642

Covered by existing tests, no functional change.

  • dom/Event.cpp:
  • dom/Event.h: (WebCore::EventDispatchMediator::EventDispatchMediator): Added default

constructor.

(WebCore::EventDispatchMediator::event): Inlined.
(WebCore::EventDispatchMediator::setEvent): Added.

  • dom/EventDispatcher.cpp: Removed dispatchWheelEvent.
  • dom/EventDispatcher.h: Updated decls.
  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent): Changed to use the mediator and

return a bool, like other dispatch event functions.

  • dom/Node.h: Changed decl.
  • dom/WheelEvent.cpp: (WebCore::granularity): Moved from EventDispatcher. (WebCore::WheelEventDispatchMediator::WheelEventDisatchMediator): Added. (WebCore::WheelEventDispatchMediator::event): Added. (WebCore::WheelEventDispatchMediator::dispatchEvent): Added.
  • dom/WheelEvent.h: Updated decls.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Changed to receive and react

to the return value.

8:38 AM Changeset in webkit [83297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Jamie Cooley <​james.cooley@nokia.com>

Reviewed by Benjamin Poulain.

[Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=57945

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qwkhistory.h:
8:30 AM Changeset in webkit [83296] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build warning fix.

  • WebCore.vcproj/WebCore.vcproj:

Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
the build.

8:24 AM Changeset in webkit [83295] by yi.4.shen@nokia.com
  • 4 edits in trunk

2011-04-08 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57472

Unskips the fast/events/onsearch-enter.html test.

  • platform/qt/Skipped:

2011-04-08 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57472

Avoid to insert new line for both keydown event & keypress event.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
8:10 AM Changeset in webkit [83294] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: update breakpoints according to source frame decorations after live edit.
​https://bugs.webkit.org/show_bug.cgi?id=58029

  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/live-edit.html:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: update breakpoints according to source frame decorations after live edit.
​https://bugs.webkit.org/show_bug.cgi?id=58029

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.set content):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource): (WebInspector.SourceFrame.prototype._handleSave):
8:03 AM Changeset in webkit [83293] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix scripts concatenation in scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=58138

When there is just one script starting at 0:0 it should not be surrounded by <script> framing.

  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
7:22 AM Changeset in webkit [83292] by steveblock@google.com
  • 5 edits in trunk/LayoutTests

2011-04-08 Steve Block <​steveblock@google.com>

Unreviewed build fix.

Media Stream API: add the getUserMedia method and the Javascript bindings
​https://bugs.webkit.org/show_bug.cgi?id=56586

Add new tests to skipped lists for platforms where the feature is not
enabled.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
7:07 AM Changeset in webkit [83291] by yurys@chromium.org
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2011-04-08 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations to match results after rolling
v8 revision that reports stack overflow exception to the console.

  • platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/recursion-limit-equal-expected.txt: Removed.
  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt.
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt.
5:36 AM Changeset in webkit [83290] by pfeldman@chromium.org
  • 14 edits in trunk

2011-04-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
​https://bugs.webkit.org/show_bug.cgi?id=58118

This change reuses location for call frames in the protocol + structures script
location <-> source lines interaction better. When we need UI columns, we will add
them, but we should distinguish between script and UI terms on the type level, not naming.

  • English.lproj/localizedStrings.js:
  • bindings/v8/DebuggerScript.js:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine): (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.PresenationCallFrame): (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping): (WebInspector.PresenationCallFrame.prototype.sourceLine):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.lineToPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
5:34 AM Changeset in webkit [83289] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
​https://bugs.webkit.org/show_bug.cgi?id=58133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._reset):
5:31 AM Changeset in webkit [83288] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
​https://bugs.webkit.org/show_bug.cgi?id=58026

This is the first step of decoupling TextViewer from SourceFrame.

5:09 AM Changeset in webkit [83287] by steveblock@google.com
  • 18 edits
    18 adds in trunk

2011-04-08 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add the getUserMedia method and the Javascript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=56586

Test the Javascript behaviour of the getUserMedia method with different types of arguments.
Current specification: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

  • fast/dom/MediaStream/argument-types-expected.txt: Added.
  • fast/dom/MediaStream/argument-types.html: Added.
  • fast/dom/MediaStream/enabled-expected.txt: Added.
  • fast/dom/MediaStream/enabled.html: Added.
  • fast/dom/MediaStream/no-interface-object-expected.txt: Added.
  • fast/dom/MediaStream/no-interface-object.html: Added.
  • fast/dom/MediaStream/script-tests/argument-types.js: Added. (shouldNotThrow): (test): (emptyFunction): (): (ObjectThrowingException.prototype.valueOf): (ObjectThrowingException.prototype.toString):
  • fast/dom/MediaStream/script-tests/enabled.js: Added. (hasGetUserMediaProperty):
  • fast/dom/MediaStream/script-tests/no-interface-object.js: Added. (test):

2011-04-08 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add the getUserMedia method and the Javascript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=56586

Add the getUserMedia method to the navigator and its new Javascript types.
Current specification: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

Tests: fast/dom/MediaStream/argument-types.html

fast/dom/MediaStream/enabled.html
fast/dom/MediaStream/no-interface-object.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::V8Navigator::webkitGetUserMediaCallback):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/NavigatorUserMediaError.h: Added. (WebCore::NavigatorUserMediaError::NavigatorUserMediaError): (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError): (WebCore::NavigatorUserMediaError::code):
  • page/NavigatorUserMediaError.idl: Added.
  • page/NavigatorUserMediaErrorCallback.h: Added. (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
  • page/NavigatorUserMediaErrorCallback.idl: Added.
  • page/NavigatorUserMediaSuccessCallback.h: Added. (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
  • page/NavigatorUserMediaSuccessCallback.idl: Added.
4:40 AM Changeset in webkit [83286] by mnaganov@chromium.org
  • 6 edits
    1 copy
    1 move
    22 adds
    2 deletes in trunk

2011-04-08 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58010
​https://bugs.webkit.org/show_bug.cgi?id=58011

Added tests for "Containment" view. Minor refactorings, bugs fixed.
Split one large tests into smaller ones to avoid timing out in debug mode.

Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html

inspector/profiler/detailed-heapshots-containment-show-all.html
inspector/profiler/detailed-heapshots-containment-show-next.html
inspector/profiler/detailed-heapshots-containment-sorting.html
inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-summary-show-all.html
inspector/profiler/detailed-heapshots-summary-show-next.html
inspector/profiler/detailed-heapshots-summary-sorting.html

2011-04-08 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58010
​https://bugs.webkit.org/show_bug.cgi?id=58011

Added tests for "Containment" view. Minor refactorings, bugs fixed.
Split one large tests into smaller ones to avoid timing out in debug mode.

  • inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
  • inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary.html: Removed.
  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled): (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest): (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest):
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:22 AM Changeset in webkit [83285] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Bugs in some corner cases in the text editor
​https://bugs.webkit.org/show_bug.cgi?id=58025

This solves the following bugs:
1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
4:20 AM Changeset in webkit [83284] by podivilov@chromium.org
  • 10 edits
    2 adds in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • gyp/streamline-inspector-source.sh:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._formatter):
  • inspector/front-end/ScriptFormatterWorker.js:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • WebKit.gyp:
4:13 AM Changeset in webkit [83283] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Note some flaky tests.

  • platform/chromium/test_expectations.txt:
3:52 AM Changeset in webkit [83282] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] The second attempt of fixing for Windows (dbg)(shared) build.

  • WebKit.gyp: webkit should not depend on webkit_support.
3:35 AM Changeset in webkit [83281] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Do not destroy WorkQueue event sources unless they have been cancelled
​https://bugs.webkit.org/show_bug.cgi?id=57611

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::EventSource): Remove unused member m_dispatchSource. (WorkQueue::EventSource::executeEventSource): Make it return void instead of boolean since we are always ignoring the return value. (WorkQueue::EventSource::performWork): Return FALSE from the callback only when the source has been cancelled (condition = 0) to make sure it's destroyed when the even source handler is unregistered. (WorkQueue::registerEventSourceHandler): Use GRefPtr for the source, to avoid leaking it. (WorkQueue::scheduleWorkOnSource): Receive the source callback as parameter so that it can be used by scheduleWorkOnTermination() too. (WorkQueue::scheduleWork): (WorkQueue::scheduleWorkAfterDelay): (WorkQueue::scheduleWorkOnTermination): Use scheduleWorkOnSource().
3:28 AM Changeset in webkit [83280] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Close connection when web process finishes
​https://bugs.webkit.org/show_bug.cgi?id=57540

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp:
  • Platform/PlatformProcessIdentifier.h: Use GPid as process identifier.
  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::EventSource): Add cancellable parameter. (WorkQueue::EventSource::cancel): New method to cancel the source. (WorkQueue::EventSource::performWorkOnTermination): New method to execute a work item called when child process has finished. (WorkQueue::registerEventSourceHandler): Create a GCancellable for the socket source. (WorkQueue::unregisterEventSourceHandler): Cancel the source instead of destroying it, this will cause the source to trigger with condition = 0, which makes the callback return FALSE and the source is destroyed. (WorkQueue::scheduleWorkOnSource): Pass NULL as cancellable for idle and timeout sources. (WorkQueue::scheduleWorkOnTermination): Create a child watch source to monitor the child process.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use GPid instead of int as process identifier.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching): Call WorkQueue::scheduleWorkOnTermination() for GTK platform too when web process has been launched.
3:28 AM Changeset in webkit [83279] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted test expectations following r83275.

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
3:17 AM Changeset in webkit [83278] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
​https://bugs.webkit.org/show_bug.cgi?id=57434

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::executeEventSource): This new method contains the common code to execute a work item. (WorkQueue::EventSource::performWorkOnce): Use executeEventSource() to execute the work item. (WorkQueue::EventSource::performWork): Use executeEventSource() to execute the work item. (WorkQueue::registerEventSourceHandler): Use a GSocket instead of a GIOChannel since the API is newer and allows us to pass a cancellable object to be able to cancel the source. (WorkQueue::scheduleWorkOnSource): This new method contains the common code to attach a source to a context. It doesn't use a lock anymore, since g_source_attach() uses its own mutex internally. (WorkQueue::scheduleWork): Use an idle source instead of a timeout one, changing the priority to G_PRIORITY_DEFAULT. (WorkQueue::scheduleWorkAfterDelay): Implement it using a timeout source with the given delay.
3:06 AM Changeset in webkit [83277] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
​https://bugs.webkit.org/show_bug.cgi?id=57234

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::childSetupFunction): close the socket and use prctl() when platform is Linux to kill the child process when the parent finishes. (WebKit::ProcessLauncher::launchProcess): Use g_spawn_async() to launch the web process.
2:55 AM Changeset in webkit [83276] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Tweak dynamically constants for the async highlighting in text editor
​https://bugs.webkit.org/show_bug.cgi?id=58035

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines): (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines): (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit): (WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):
2:48 AM Changeset in webkit [83275] by caseq@chromium.org
  • 6 edits
    1 delete in trunk

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR compliance fixes
​https://bugs.webkit.org/show_bug.cgi?id=58124

  • Always provide some values for queryString and cookies, even though arrays may be empty
  • Always provide an empty cache object
  • Added entire HARLog to test
  • Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR compliance fixes
​https://bugs.webkit.org/show_bug.cgi?id=58124

  • Added entire HARLog to test
  • Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resources-test.js:
  • platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
2:28 AM Changeset in webkit [83274] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Build fix for Windows (dbg)(shared).

  • WebKit.gyp: Add webkit_support dependency, which is required for webkit_unittest_files.
2:26 AM Changeset in webkit [83273] by sergio@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-04-08 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, added new GTK+ test expectations.

  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png: Added.
  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.checksum: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.png: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.txt: Added.
2:26 AM Changeset in webkit [83272] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

layoutTestController.shadowRoot should return undefined if its
argument is not an element.
​https://bugs.webkit.org/show_bug.cgi?id=58119

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
2:15 AM Changeset in webkit [83271] by mario@webkit.org
  • 5 edits in trunk

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implemented missing functions in GTK's DRT.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (modifyAccessibilityValue): Helper function to increment or decrement the current value for an object through the AccessibilityObject's API. (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function, to be used from GTK's DRT. (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implement missing functions in GTK's DRT.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::increment): Implemented. (AccessibilityUIElement::decrement): Implemented.
2:04 AM Changeset in webkit [83270] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

Make WK2 layoutTestController.shadowRoot return undefined, not
null, when its argument is not an element.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
1:47 AM Changeset in webkit [83269] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
​https://bugs.webkit.org/show_bug.cgi?id=54681

This a patch which should be landed when fix for exception handling in v8 is landed
(see ​http://codereview.chromium.org/6397011/)

  • platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
  • platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
12:53 AM Changeset in webkit [83268] by rniwa@webkit.org
  • 3 edits
    2 adds
    28 deletes in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
​https://bugs.webkit.org/show_bug.cgi?id=58074

Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.

  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html:
  • editing/pasteboard/display-block-on-spans-expected.txt: Added.
  • editing/pasteboard/display-block-on-spans.html:
  • platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.png: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
12:46 AM Changeset in webkit [83267] by Csaba Osztrogonác
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

[Qt] Add platform specific expected file after r83235.

  • platform/qt/http/tests/security/contentSecurityPolicy: Added.
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
12:38 AM Changeset in webkit [83266] by tkent@chromium.org
  • 9 edits
    8 adds
    1 delete in trunk/LayoutTests

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for r82899 and r83253.

  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium/test_expectations.txt:
12:21 AM Changeset in webkit [83265] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Flaky Test: fast/events/tabindex-focus-blur-all.html
​https://bugs.webkit.org/show_bug.cgi?id=52115

  • platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.
12:05 AM Changeset in webkit [83264] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build.

  • css/CSSStyleApplyProperty.cpp:
12:00 AM Changeset in webkit [83263] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor WebCore/GNUMakefile.am to separate list of files
​https://bugs.webkit.org/show_bug.cgi?id=58116

This change is similar to the cooresponding to change to
JavaScriptCore. We hope to generate GNUmakefile.list.am automatically
using GYP.

  • GNUmakefile.am:
  • GNUmakefile.list.am: Added.

Apr 7, 2011:

11:49 PM Changeset in webkit [83262] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaseline after r83246.

  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:46 PM Changeset in webkit [83261] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

Not reviewed.

Rolled out some accidentally-committed changes in my last commit.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):

  • dom/EventTarget.h:
11:45 PM Changeset in webkit [83260] by commit-queue@webkit.org
  • 8 edits
    3 deletes in trunk

2011-04-07 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

EventSource should only accept UTF-8 charset
​https://bugs.webkit.org/show_bug.cgi?id=56942

  • ChangeLog-2011-02-16: Corrected previous commit message. Pointed out by Alexey.
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Updated with the new console message.
  • http/tests/eventsource/eventsource-content-type-charset-expected.txt:
  • http/tests/eventsource/eventsource-content-type-charset.html: Beefed up this test and merged the following test into it. The new tests check that we dispatch a console error if the charset is wrong.
  • http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Removed.
  • http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Removed.
  • http/tests/eventsource/resources/response-content-type-charset.php: Return the charset passed in the URL. Also added PHP's magic quotes handling as this would make the test fail on Mac.
  • http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Removed.

2011-04-07 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

EventSource should only accept UTF-8 charset
​https://bugs.webkit.org/show_bug.cgi?id=56942

Following the discussion on bug 45372, this change implements the recommended
way of handling "charset". We only accept UTF-8 but no other encoding. This matches
the encoding of the EventSource and also may fix TomCat that automatically send this
charset.

  • page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
11:34 PM Changeset in webkit [83259] by ggaren@apple.com
  • 22 edits in trunk/Source

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • bytecode/SamplingTool.h: Sorted alphabetically because that's the WebKit style. Added a Global.h #include that was previously missing but harmless.
  • collector/handles/Global.h: (JSC::Global::Global): Added a null constructor. No need for a special tag, and the tag is incompatible with some data structures.


(JSC::Global::isHashTableDeletedValue):
(JSC::Global::~Global):
(JSC::Global::set):
(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::hashTableDeletedValue): Reordered constructors to be near
each other.

(JSC::Global::setWithWriteBarrier): Renamed internalSet to
setWithWriteBarrier for clarity, and funneled more code into using set
and setWithWriteBarrier to reduce duplication.

  • collector/handles/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have boolean and ! operators.

(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle): Added general support for null Handles. This was
previously outlawed by ASSERTs, but our code has grown to support and
rely on null Handles.


  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle, and beefed this up a bit.
  • collector/handles/HandleHeap.h: (JSC::HandleHeap::globalData): Added accessor, used by some new set functions.
  • collector/handles/Local.h: Moved hash traits to the bottom of the file, since this file is about the Local class, not the traits.

(JSC::::Local): Updated for removal of invalidate().

(JSC::::operator): Deployed "using" to avoid a lot of this->
template funny business.

(JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): Updated to use null constructor.
  • jit/JITStubs.cpp: (JSC::JITThunks::hostFunctionStub):
  • runtime/JSPropertyNameIterator.h: (JSC::Structure::setEnumerationCache):
  • runtime/Structure.h: Removed clearEnumerationCache because it was an unused holdover from when the enumeration cache was not a handle.
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::set): Finish initializing our handle before putting it in the table. This seemed more logical, and at one point was required to avoid triggering an ASSERT.
  • runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own handle-like behavior, to avoid duplication.

(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::~WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::set):
(JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
standardized on Handle idioms.

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • JSRun.h:
  • JSValueWrapper.h: #include a file that was missing before, but was harmlessly so until now.

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): Updated for new null constructor. (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().

2011-04-07 Geoffrey Garen <​ggaren@apple.com>

Some Handle<T> cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58109

  • WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::NPJSObject): Updated for new null constructor.
11:34 PM Changeset in webkit [83258] by kinuko@chromium.org
  • 4 edits
    3 adds in trunk/Source/WebKit/chromium

2011-04-07 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add WebKit API to query and request unified offline-storage quota
​https://bugs.webkit.org/show_bug.cgi?id=57849
Just adding the API, this does not do anything yet.

The API is based on the public discussion for unified quota API:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
(The detail is not yet fully specified and might be subject to change.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added. (WebKit::WebFrameClient::requestStorageQuota): Added.
  • public/WebStorageQuotaCallbacks.h: Added. (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
  • public/WebStorageQuotaType.h: Added.
11:28 PM Changeset in webkit [83257] by tkent@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for xsl-blocked.php and pate-text-011.html.

  • platform/chromium/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:03 PM Changeset in webkit [83256] by tkent@chromium.org
  • 37 edits
    2 adds in trunk

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

  • fast/dom/HTMLKeygenElement/keygen-expected.txt: shadow DOM changed
  • fast/dom/HTMLKeygenElement/keygen.html: added assertion on shadow

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

Adds ShadowRoot, a list of nodes, to be a parent for top-level
shadow children. Forwards rendering through the root and into the
host's renderer.

Covered by existing tests of elements that use this style of shadow.

  • Android.mk: add ShadowRoot.h/cpp
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
  • dom/ContainerNode.cpp: parent nodes that are shadow roots are alive (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild):
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::DocumentFragment):
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): look through ShadowRoots for host's style (WebCore::Element::shadowRoot): should be const (WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
  • dom/Element.h:
  • dom/ElementRareData.h:
  • dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): indirection so ShadowRoot can forward to the host's renderer (WebCore::Node::createRendererAndStyle): (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h: (WebCore::Node::isShadowBoundary): temporary, to differentiate old- and new-style, until all roots are ShadowRoot instances
  • dom/ShadowRoot.cpp: Added. (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::recalcStyle): forward recalc to children
  • dom/ShadowRoot.h: Added. (WebCore::ShadowRoot::isShadowBoundary): (WebCore::ShadowRoot::create):
  • html/HTMLKeygenElement.cpp: use ensureShadowRoot (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::shadowSelect):
  • html/HTMLKeygenElement.h:
  • html/HTMLMeterElement.cpp: use ensureShadowRoot (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLProgressElement.cpp: use ensureShadowRoot (WebCore::HTMLProgressElement::createShadowSubtree):
  • html/InputType.cpp: use ensureShadowRoot (WebCore::InputType::destroyShadowSubtree):
  • html/RangeInputType.cpp: use ensureShadowRoot (WebCore::RangeInputType::handleMouseDownEvent): (WebCore::RangeInputType::createShadowSubtree): (WebCore::RangeInputType::valueChanged): (WebCore::RangeInputType::shadowSliderThumb):
  • html/RangeInputType.h:
  • html/ValidationMessage.cpp: use ensureShadowRoot (WebCore::ValidationMessage::buildBubbleTree): (WebCore::ValidationMessage::deleteBubbleTree):
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromPoint): (WebCore::SliderThumbElement::hostInput):
  • html/shadow/SliderThumbElement.h:
  • rendering/MediaControlElements.cpp: use ensureShadowRoot (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle):
  • rendering/RenderSlider.cpp: use ensureShadowRoot (WebCore::RenderSlider::thumbRect): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::shadowSliderThumb): (WebCore::RenderSlider::inDragMode):
  • rendering/RenderSlider.h:

2011-04-07 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Let shadow DOM have a list of nodes at the top level of a shadow.
​https://bugs.webkit.org/show_bug.cgi?id=57813

  • src/WebElement.cpp: (WebKit::WebElement::shadowRoot): shadow roots are ContainerNodes now
11:01 PM Changeset in webkit [83255] by mjs@apple.com
  • 5 edits
    2 adds in trunk

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r80871): Crash when visiting ​http://broadband.biglobe.ne.jp/
​https://bugs.webkit.org/show_bug.cgi?id=56297
<rdar://problem/9131597>

Test: fast/css-generated-content/table-row-after-no-crash.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after content, and only do it if the row already has a parent. For construction of anonymous cells to work correctly, the row needs to already have a parent, so in that case wait a bit. (WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): When adding a row, update its before/after content, in case it had any.

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r80871): Crash when visiting ​http://broadband.biglobe.ne.jp/
​https://bugs.webkit.org/show_bug.cgi?id=56297
<rdar://problem/9131597>

  • fast/css-generated-content/table-row-after-no-crash-expected.txt: Added.
  • fast/css-generated-content/table-row-after-no-crash.html: Added.
10:52 PM Changeset in webkit [83254] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Probable fix for <rdar://problem/9251443> Crashing on exception: -
[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized
selector sent to instance ADDRESS.

Reviewed by Simon Fraser.

Need to implement new delegate method.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):

10:38 PM Changeset in webkit [83253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 Ian Henderson <​ianh@apple.com>

Reviewed by Simon Fraser.

Optimize filling rounded rects that are actually ellipses
​https://bugs.webkit.org/show_bug.cgi?id=58098

In CG, drawing an ellipse directly is faster than constructing and
filling a rounded rect path. Detect when the given rounded rect is
actually an ellipse and draw it directly in this case.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
9:59 PM Changeset in webkit [83252] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-07 Magnus Danielsson <​public@fuzzac.com>

Reviewed by Darin Fisher.

[chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly
​https://bugs.webkit.org/show_bug.cgi?id=53897

When serializing a web page using 'save page as', sub-frames and resources gets
saved in a sub-directory. However, frame elements didn't get updated to reference
these saved sub-frames, but were still referencing the original url. So when opening
a saved web page, any sub-frames would get pulled in from the original url rather than
what was saved.

In addition to this, sub-frames in the sub-directory erroneously had the name of the
sub-directory prepended to the path of resources located in the same sub-directory.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToStrne: Fixed resource paths in sub-frames. Also made sure sub-frames are referenced correctly from parent frame. (WebKit::WebPageSerializerImpl::endTagToString): Removed constness from argument. (WebKit::WebPageSerializerImpl::buildContentForNode): Ditto.
  • src/WebPageSerializerImpl.h:
9:38 PM Changeset in webkit [83251] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-07 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

CTLine objects should outlive their CTRuns
​https://bugs.webkit.org/show_bug.cgi?id=58063

  • platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.
9:32 PM Changeset in webkit [83250] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-07 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Change reference port for Mac GPU baselines from
Leopard to SnowLeopard, XP to Win7, and Linux-x86
to Linux x86-64.

​https://bugs.webkit.org/show_bug.cgi?id=58099

  • Scripts/webkitpy/layout_tests/port/chromium.py:
9:32 PM Changeset in webkit [83249] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk/Source

2011-04-07 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Compositor thread infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=56131

Introduce chrome compositor thread and related
infrastructure.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCMainThread.cpp: Added. (WebCore::CCMainThread::performTask): (WebCore::CCMainThread::postTask):
  • platform/graphics/chromium/cc/CCMainThread.h: Added. (WebCore::CCMainThread::Task::~Task): (WebCore::CCMainThread::Task::instance): (WebCore::CCMainThread::Task::Task):
  • platform/graphics/chromium/cc/CCMainThreadTask.h: Added. (WebCore::MainThreadTask0::create): (WebCore::MainThreadTask0::MainThreadTask0): (WebCore::MainThreadTask0::performTask): (WebCore::MainThreadTask1::create): (WebCore::MainThreadTask1::MainThreadTask1): (WebCore::MainThreadTask1::performTask): (WebCore::MainThreadTask2::create): (WebCore::MainThreadTask2::MainThreadTask2): (WebCore::MainThreadTask2::performTask): (WebCore::MainThreadTask3::create): (WebCore::MainThreadTask3::MainThreadTask3): (WebCore::MainThreadTask3::performTask): (WebCore::createMainThreadTask):
  • platform/graphics/chromium/cc/CCThread.cpp: Added. (WebCore::CCThread::create): (WebCore::CCThread::CCThread): (WebCore::CCThread::~CCThread): (WebCore::CCThread::postTask): (WebCore::CCThread::compositorThreadStart): (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThread.h: Added. (WebCore::CCThread::Task::~Task): (WebCore::CCThread::Task::instance): (WebCore::CCThread::Task::Task): (WebCore::CCThread::threadID): (WebCore::CCCompletionEvent::CCCompletionEvent): (WebCore::CCCompletionEvent::~CCCompletionEvent): (WebCore::CCCompletionEvent::wait): (WebCore::CCCompletionEvent::signal):
  • platform/graphics/chromium/cc/CCThreadTask.h: Added. (WebCore::CCThreadTask0::create): (WebCore::CCThreadTask0::CCThreadTask0): (WebCore::CCThreadTask0::performTask): (WebCore::CCThreadTask1::create): (WebCore::CCThreadTask1::CCThreadTask1): (WebCore::CCThreadTask1::performTask): (WebCore::CCThreadTask2::create): (WebCore::CCThreadTask2::CCThreadTask2): (WebCore::CCThreadTask2::performTask): (WebCore::CCThreadTask3::create): (WebCore::CCThreadTask3::CCThreadTask3): (WebCore::CCThreadTask3::performTask): (WebCore::createCCThreadTask):

2011-04-07 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Compositor thread infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=56131

Tests for chrome compositor thread and related infrastructure.

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/CCThreadTaskTest.cpp: Added. (WebCore::TEST):
  • tests/CCThreadTest.cpp: Added. (WebCore::TEST): (WebCore::PingPongUsingCondition::ping): (WebCore::PingPongTestUsingTasks::ping): (WebCore::PingPongTestUsingTasks::pong):
  • tests/RunAllTests.cpp: (main):
9:30 PM Changeset in webkit [83248] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Martin Robinson.

Refactor Gtk build system to separate list of files
​https://bugs.webkit.org/show_bug.cgi?id=58090

This is the first step towards generating part of the GTK build system
using GYP. In the first iteration, our plan is to just generate the
list of files. This patch is the first step, which is to separate out
the part of JavaScriptCore build system that we intend to generate from
the rest of the build system.

  • GNUmakefile.am:
  • GNUmakefile.list.am: Added.
9:11 PM Changeset in webkit [83247] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

Added tests to ensure WebKit inserts a paragraph separator properly around tab span.

  • editing/inserting/insert-div-021-expected.txt: No longer duplicates span[id="test"] incorrectly.
  • editing/inserting/insert-paragraph-after-tab-span-and-text-expected.txt: Added.
  • editing/inserting/insert-paragraph-after-tab-span-and-text.html: Added.
  • editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
  • editing/inserting/insert-paragraph-separator-tab-span.html: Added.
  • editing/inserting/insert-paragraph-at-end-of-line-expected.txt: No longer duplicates a[id="anchor"] incorrectly.

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
​https://bugs.webkit.org/show_bug.cgi?id=57872

r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.

Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
before moving the nodes.

Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html

editing/inserting/insert-paragraph-separator-tab-span.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span, no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph separator into a paragraph separator.
  • editing/htmlediting.cpp: (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent node after the tab span if the position was at the end of the tab span.
  • editing/htmlediting.h:
9:02 PM Changeset in webkit [83246] by rniwa@webkit.org
  • 3 edits
    1 move
    1 add
    24 deletes in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
​https://bugs.webkit.org/show_bug.cgi?id=58078

Converted the tests.

  • editing/pasteboard/paste-text-001-expected.txt: Added.
  • editing/pasteboard/paste-text-001.html:
  • editing/pasteboard/paste-text-011-expected.txt: Added.
  • editing/pasteboard/paste-text-011.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.
8:59 PM Changeset in webkit [83245] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-07 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

[Mac] Editor::setComposition() should not trigger correction panel timer.
​https://bugs.webkit.org/show_bug.cgi?id=58049

<rdar://problem/9226305>

On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().

No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
autocorrection panel timer, which can not be easily done in automated fashion.

  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition):
  • editing/EditorCommand.cpp: (WebCore::executeDelete):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::typingAddedToOpenCommand):
  • editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::setShouldPreventSpellChecking):
8:51 PM Changeset in webkit [83244] by tkent@chromium.org
  • 7 edits
    2 copies
    1 add
    4 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for r83216 and r83235.

  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/foreign-object-skew-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium/test_expectations.txt:
8:21 PM Changeset in webkit [83243] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

Forgot to add them to the original patch.

  • fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
  • fast/css/webkit-empty-transform-preserve3d-crash.html: Added.
8:09 PM Changeset in webkit [83242] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

clearIfComposited call is really slow
​https://bugs.webkit.org/show_bug.cgi?id=57999

Move getContextAttributes call after the if, so it isn't called nearly as often.

No new tests.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clearIfComposited):
7:33 PM Changeset in webkit [83241] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-07 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement Backgroun and Mask properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=57922

No tests added as no behavioral changes.

  • css/CSSStyleApplyProperty.cpp: Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added constructor calls to set up: CSSPropertyBackgroundAttachment CSSPropertyBackgroundClip CSSPropertyWebkitBackgroundClip CSSPropertyWebkitBackgroundComposite CSSPropertyBackgroundOrigin CSSPropertyWebkitBackgroundOrigin CSSPropertyBackgroundSize CSSPropertyWebkitBackgroundSize CSSPropertyWebkitMaskAttachment CSSPropertyWebkitMaskClip CSSPropertyWebkitMaskComposite CSSPropertyWebkitMaskOrigin CSSPropertyWebkitMaskSize
  • css/CSSStyleApplyProperty.h: (WebCore::CSSStyleApplyProperty::setPropertyValue): Add function to specify an equivalent property value in the lookup table.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove sections now implemented by CSSStyleApplyProperty.
  • css/CSSStyleSelector.h: Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.
7:12 PM Changeset in webkit [83240] by eric@webkit.org
  • 11 edits
    1 add in trunk/Source/WebCore

2011-04-04 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split run storage out from BidiResolver into a new BidiRunList class
​https://bugs.webkit.org/show_bug.cgi?id=57764

Part of what makes BidiResolver and InlineIterator so difficult to understand
(and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
BidiRuns from the algorithm. This patch breaks the storage aspect off
into its own class BidiRunList.

This patch is only a start. It does not actually fix the problematic ownership
relationship, but it does make it possible to fix such in a second patch.

The run pointers and addRun/prependRun, etc. were already a tightly coupled
logical subset of the BidiResolver class, so moving them into their own class
was both obvious and easy. The only piece of logic I had to move was that
deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.

I believe this deleteRuns side-effect was only ever used for one place
(right after findNextLineBreak) and that it's only needed because
findNextLineBreak can sometimes create bidi runs. Run creation appears to be
an unintentional side-effect of how InlineIterator calls through to BidiResolver
as part of bidiNext and not a desired effect of the code. I have added the call
to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
could get re-used) as a safety precaution. We could replace both with ASSERTs
in a later patch.

I suspect there may be a small performance win from further refactoring so that
findNextLineBreak does not need to create BidiRuns.

As I commented in the code, callers should own their own BidiRunList which they
pass to BidiResolver::createBidiRunsForLine. I attempted to implement that in
an earlier version of this patch, but it was too complicated with the current
twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
raise/lowerExplicitEmbeddingLevel are called unconditionally
from commitExplicitEmbedding (which is called by bidiNext) and expect to have
access to a runs list even in cases where we don't want any runs (findNextLineBreak).

I also cleaned up some of the callers to pass around BidiRunList objects instead
of InlineBidiResolvers now that they're separate objects.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText):
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::BidiResolver): (WebCore::BidiResolver::runs): (WebCore::BidiResolver::markCurrentRunEmpty): (WebCore::::appendRun): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::reorderRunsFromLevels): (WebCore::::createBidiRunsForLine):
  • rendering/InlineIterator.h: (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::createRun): (WebCore::RenderBlock::appendRunsForObject): (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren):
7:05 PM Changeset in webkit [83239] by enne@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, add baseline pixel images for decorations-transformed.

  • platform/chromium-mac/fast/text/decorations-transformed-expected.png: Added.
  • platform/chromium-win/fast/text/decorations-transformed-expected.png: Added.
6:50 PM Changeset in webkit [83238] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Max build fix.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Do not risk an overflow.
(WebKit::WebEditorClient::checkGrammarOfString):
Ditto.

6:18 PM Changeset in webkit [83237] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-07 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Adam Barth.

[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
​https://bugs.webkit.org/show_bug.cgi?id=57911
​http://code.google.com/p/chromium/issues/detail?id=78073

Manual test added: manual-tests/autofill-popup-location.html

Originally only height is checked so that it introduces the bug.
So I changed it to check both width and height as size.

  • manual-tests/autofill-popup-location.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
6:09 PM Changeset in webkit [83236] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

6:08 PM Changeset in webkit [83235] by abarth@webkit.org
  • 5 edits
    14 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement img-src style-src and font-src
​https://bugs.webkit.org/show_bug.cgi?id=58018

Test a bunch of allow/block tests for these new directives.

  • http/tests/security/contentSecurityPolicy/image-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/blue.css: Added.
  • http/tests/security/contentSecurityPolicy/resources/style.xsl: Added.
  • http/tests/security/contentSecurityPolicy/style-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/style-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/style-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/xsl-allowed.php: Added.
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/xsl-blocked.php: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement img-src style-src and font-src
​https://bugs.webkit.org/show_bug.cgi?id=58018

These are pretty straight forward given the rest of the infrastructure
we've built so far.

Tests: http/tests/security/contentSecurityPolicy/image-allowed.html

http/tests/security/contentSecurityPolicy/image-blocked.html
http/tests/security/contentSecurityPolicy/style-allowed.html
http/tests/security/contentSecurityPolicy/style-blocked.html
http/tests/security/contentSecurityPolicy/xsl-allowed.php
http/tests/security/contentSecurityPolicy/xsl-blocked.php

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
5:55 PM Changeset in webkit [83234] by levin@chromium.org
  • 4 edits in trunk/Source/WebCore

Make IconSnapshot and PageURLRecord member variables private.
​https://bugs.webkit.org/show_bug.cgi?id=58080

Reviewed by Darin Adler.

No change in functionality so no new tests.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.

  • loader/icon/IconRecord.h:

(WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
(WebCore::IconSnapshot::iconURL): Expose the property.
(WebCore::IconSnapshot::timestamp): Ditto.
(WebCore::IconSnapshot::data): Ditto.

  • loader/icon/PageURLRecord.h:

(WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
(WebCore::PageURLSnapshot::pageURL): Expose the property.
(WebCore::PageURLSnapshot::iconURL): Ditto.

5:48 PM Changeset in webkit [83233] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated comment in skipped list to
include the bug that tracks the changes required
in WebKitTestRunner.

  • platform/win-wk2/Skipped:
5:38 PM Changeset in webkit [83232] by jberlin@webkit.org
  • 19 edits
    4 adds in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Brian Weinstein.

Part 4: Implement checkGrammarOfString.

  • Scripts/webkit2/messages.py:

The generated files should include TextCheckerClient.h for WebCore::GrammarDetail.

  • Shared/API/c/win/WKBaseWin.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/win/WKAPICastWin.h:
  • UIProcess/API/C/win/WKGrammarDetail.cpp: Added.

(WKGrammarDetailGetTypeID):
(WKGrammarDetailCreate):

  • UIProcess/API/C/win/WKGrammarDetail.h: Added.
  • UIProcess/API/C/win/WKTextChecker.h:

Add the checkGrammarOfString WKTextCheckerClient function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkGrammarOfString):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Call the TextCheckerClient.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkSpellingOfString):
Add a comment about this not being used on Mac.
(WebKit::TextChecker::checkGrammarOfString):
Ditto, and call notImplemented.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Call notImplemented.

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::checkGrammarOfString):
Ditto.

  • UIProcess/win/WebGrammarDetail.cpp: Added.

(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
Initialize the underlying WebCore::GrammarDetail.

  • UIProcess/win/WebGrammarDetail.h: Added.

(WebKit::WebGrammarDetail::grammarDetail):
(WebKit::WebGrammarDetail::type):

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::checkGrammarOfString):
Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails.

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Use WTF::notFound as the initial value for resultLocation.
(WebKit::WebEditorClient::checkGrammarOfString):
Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph).

  • win/WebKit2.vcproj:

Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp.

  • win/WebKit2Generated.make:

Copy over WKGrammarDetail.h.

5:22 PM Changeset in webkit [83231] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/696

Merge 83209
BUG=77463

4:47 PM Changeset in webkit [83230] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Mapping booleans the same way as integers
​https://bugs.webkit.org/show_bug.cgi?id=56913

Patch by Zoltan Herczeg <​zherczeg@webkit.org> on 2011-04-07
Reviewed by Gavin Barraclough.

Instead of having a seperate tag field for booleans,
the logical values are stored in the payload field
(for JSValue32_64 representation).

1.007x speedup on SunSpider.

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitStoreBool):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JSInterfaceJIT.h:
  • runtime/JSValue.h:

(JSC::JSValue::JSValue):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::getBoolean):

4:46 PM Changeset in webkit [83229] by enrica@apple.com
  • 5 edits in trunk/Source/WebKit2

REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows).
​https://bugs.webkit.org/show_bug.cgi?id=58056
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Windows.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebUndoClient.cpp:

(WebKit::WebUndoClient::canUndoRedo):
(WebKit::WebUndoClient::executeUndoRedo):

  • UIProcess/win/WebUndoClient.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

4:38 PM Changeset in webkit [83228] by dbates@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-07 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Add a layout test to ensure that mousemove is fired from a subframe
​https://bugs.webkit.org/show_bug.cgi?id=58094

  • fast/events/iframe-onmousemove-expected.txt: Added.
  • fast/events/iframe-onmousemove.html: Added.
  • fast/events/resources/iframe-onmousemove.html: Added.
4:30 PM Changeset in webkit [83227] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Decrease flakiness of test results.

  • platform/qt-wk2/Skipped:
    • Add canvas tests not to break css2.1 tests.
    • Remove passing css2.1 tests.
4:07 PM Changeset in webkit [83226] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

4:03 PM Changeset in webkit [83225] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This adds support for a new --port argument and plumbs through
the necessary paths to allow generating for a port other than Mac.

  • Source/gyp/configure:

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable JavaScriptCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

  • gyp/gtk.gyp: Added.

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable WebCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

  • gyp/gtk.gyp: Added.
3:52 PM Changeset in webkit [83224] by Lucas Forschler
  • 1 copy in tags/Safari-534.28

New tag.

3:51 PM Changeset in webkit [83223] by scherkus@chromium.org
  • 27 edits
    3 deletes in trunk

2011-04-07 Andrew Scherkus <​scherkus@chromium.org>

Revert ENABLE_TRACK patch due to compile failures.

3:38 PM Changeset in webkit [83222] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Add failing legacy full screen tests to the gtk/Skipped list.

  • platform/gtk/Skipped:
3:33 PM Changeset in webkit [83221] by hyatt@apple.com
  • 6 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57736

Reviewed by Dan Bernstein.

Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
layout finished. This would eventually lead to an inability to properly determine the correct layout root and
would cause a deleted root to be used later on.

Added fast/block/positioning/complex-positioned-movement.html.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):
Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):
Change simplified layout so that the positioned movement optimization no longer clears the other layout
flags. This will ensure that we still lay out our descendants if they need it.

(WebCore::RenderBlock::layoutPositionedObjects):
Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
no longer does the clear.

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure. On success it no longer
does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
the other flags in case other kinds of layout are still needed.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.

LayoutTests:

  • fast/block/positioning/complex-positioned-movement.html: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.png: Added.
  • platform/mac/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
3:23 PM Changeset in webkit [83220] by scherkus@chromium.org
  • 27 edits
    3 adds in trunk

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • configure.ac:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

No new tests. No real functionality added just yet.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Added. (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::create): (WebCore::HTMLTrackElement::insertedIntoTree): (WebCore::HTMLTrackElement::willRemove): (WebCore::HTMLTrackElement::src): (WebCore::HTMLTrackElement::setSrc): (WebCore::HTMLTrackElement::kind): (WebCore::HTMLTrackElement::setKind): (WebCore::HTMLTrackElement::srclang): (WebCore::HTMLTrackElement::setSrclang): (WebCore::HTMLTrackElement::label): (WebCore::HTMLTrackElement::setLabel): (WebCore::HTMLTrackElement::isDefault): (WebCore::HTMLTrackElement::setIsDefault): (WebCore::HTMLTrackElement::isURLAttribute):
  • html/HTMLTrackElement.h: Added.
  • html/HTMLTrackElement.idl: Added.

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • features.gypi:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Scripts/build-webkit:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
3:21 PM Changeset in webkit [83219] by tony@chromium.org
  • 8 edits
    2 adds in trunk/Tools

2011-04-07 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

update DRT to embed checksums in png files
​https://bugs.webkit.org/show_bug.cgi?id=57871

We insert the bytes for the comment in printPNG rather than at encode
time because each platform does its own PNG encoding (either using CG
or cairo). Putting this in pringPNG avoids having to duplicate this
code, although it's not as clean as doing it at encoding time.

We insert the comment right after the IHDR chunk of the PNG.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/CyclicRedundancyCheck.cpp: Added. (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
  • DumpRenderTree/CyclicRedundancyCheck.h: Added.
  • DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): (convertChecksumToPNGComment): Generate the bytes to insert. (printPNG): Insert the png comment before the first IDAT section.
  • DumpRenderTree/PixelDumpSupport.h:
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: (printPNG): (dumpBitmap):
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): (dumpBitmap):
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • GNUmakefile.am:
3:17 PM Changeset in webkit [83218] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Martin Robinson <​mrobinson@igalia.com>

Fix the WebKit2 GTK+ build for older versions of GTK+.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header.
3:16 PM Changeset in webkit [83217] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Fix whitespace in GNUmakefile.am.

  • GNUmakefile.am:
3:15 PM Changeset in webkit [83216] by mitz@apple.com
  • 9 edits
    4 adds in trunk

<rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor
​https://bugs.webkit.org/show_bug.cgi?id=58083

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/text/decorations-transformed.html

  • platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides

is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
the width and the height. In this new mode, translating a rectangle in user space never changes
its dimensions in device pixels.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
(WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
all underlines have the same thickness in device pixels.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::roundToDevicePixels): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

  • fast/text/decorations-transformed.html: Added.
  • platform/mac/fast/text/decorations-transformed-expected.checksum: Added.
  • platform/mac/fast/text/decorations-transformed-expected.png: Added.
  • platform/mac/fast/text/decorations-transformed-expected.txt: Added.
3:11 PM Changeset in webkit [83215] by Martin Robinson
  • 9 edits
    3 moves
    2 adds
    1 delete in trunk/Source/WebKit2

2011-04-07 Amruth Raj <​amruthraj@motorola.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[GTK] Implement SharedMemory for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=49791

Share the SharedMemory, Attachment and Connection implementations with the Qt port.
Both implementation are, in fact, general Unix implementations using standard Unix
domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code
greatly and lay the groundwork for GTK+/Qt implementations for other operating systems.

  • GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones.
  • Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK. (CoreIPC::ArgumentDecoder::~ArgumentDecoder):
  • Platform/CoreIPC/ArgumentEncoder.cpp: Ditto. (CoreIPC::ArgumentEncoder::~ArgumentEncoder):
  • Platform/CoreIPC/Attachment.h: Ditto.
  • Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections.
  • Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp.
  • Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt.
  • WebKit2.pro: Updated source list to reflect file renaming.
2:52 PM Changeset in webkit [83214] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Add the media/media-fullscreen-inline.html test to the mac-snowleopard Skipped list.

The legacy full screen API now redirects to the new full screen API, breaking the media-fullscreen-inline.html
test.

  • platform/mac-snowleopard/Skipped:
2:51 PM Changeset in webkit [83213] by vitalyr@chromium.org
  • 5 edits
    2 adds in trunk

2011-04-06 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Remove custom DOMImplementation getter on Document.
​https://bugs.webkit.org/show_bug.cgi?id=57991

The custom getter is no longer required because DOMImplementation
objects are now created per document.

Test: fast/dom/DOMImplementation/implementation-identity.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • dom/Document.idl:

2011-04-06 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Remove custom DOMImplementation getter on Document.
​https://bugs.webkit.org/show_bug.cgi?id=57991

  • fast/dom/DOMImplementation/implementation-identity-expected.txt: Added.
  • fast/dom/DOMImplementation/implementation-identity.html: Added.
2:44 PM Changeset in webkit [83212] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix a couple of typos in comments that Darin spotted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_not):

  • runtime/JSImmediate.h:
2:43 PM Changeset in webkit [83211] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Brian Weinstein.

REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection()
​https://bugs.webkit.org/show_bug.cgi?id=58082

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection): Now that the Range is used outside the full expression where it's created, it needs to be protected with RefPtr.
2:19 PM Changeset in webkit [83210] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

2011-04-07 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Make various video layout tests platform independent by selecting an appropriate media file.

Various layout tests depend on mp4 files.
​https://bugs.webkit.org/show_bug.cgi?id=57804

  • http/tests/media/remove-while-loading.html:
  • http/tests/media/video-load-and-stall.cgi:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-seekable-stall.html:
  • media/media-file.js: (mimeTypeForFile): (stripExtension):
  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [83209] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-04-07 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

setHasID() is only called for styled elements
​https://bugs.webkit.org/show_bug.cgi?id=57267

Test: fast/dom/non-styled-element-id-crash.html

  • dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::idAttributeChanged):
  • dom/Element.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):

2011-04-07 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

setHasID() is only called for styled elements
​https://bugs.webkit.org/show_bug.cgi?id=57267

  • fast/dom/non-styled-element-id-crash-expected.txt: Added.
  • fast/dom/non-styled-element-id-crash.html: Added.
  • svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix the failing test.
2:11 PM Changeset in webkit [83208] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
​https://bugs.webkit.org/show_bug.cgi?id=58070

Make the HTMLMediaElement full screen functions call into the new Full Screen API when
FULLSCREEN_API is enabled.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::exitFullscreen):
2:10 PM Changeset in webkit [83207] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Fix a typo in the Skipped list from r83203.

  • platform/win-wk2/Skipped:
1:58 PM Changeset in webkit [83206] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's current item index
doesn't account for items removed by filter callback.

Reviewed by Dan Bernstein.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index
when we omit an item due to the filter callback.

1:51 PM Changeset in webkit [83205] by abarth@webkit.org
  • 4 edits
    4 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CSP's options directive
​https://bugs.webkit.org/show_bug.cgi?id=58014

  • http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CSP's options directive
​https://bugs.webkit.org/show_bug.cgi?id=58014

This patch contains the full options parser, but we only have enough of
CSP implemented to see the effects of disable-xss-protection. Will
need to do some more work before we can see eval-script in action.

Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html

http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPOptions::CSPOptions): (WebCore::CSPOptions::disableXSSProtection): (WebCore::CSPOptions::evalScript): (WebCore::CSPOptions::parse): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:48 PM Changeset in webkit [83204] by ap@apple.com
  • 15 edits
    4 adds in trunk/Source

Reviewed by Anders Carlsson.

REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
​https://bugs.webkit.org/show_bug.cgi?id=58066
<rdar://problem/8965302>

  • Scripts/webkit2/messages.py:
  • Shared/mac/AttributedString.h: Added.
  • Shared/mac/AttributedString.mm: Added. (WebKit::AttributedString::encode): (WebKit::AttributedString::decode): Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF or NS object to another process without wrapping it in a C++ one.


  • Shared/mac/ArgumentCodersMac.h: Added.
  • Shared/mac/ArgumentCodersMac.mm: Added. Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why these are needed: 1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't work properly for them (I've been just getting 1). 2) NSColor isn't toll free bridged to CF. This adds just the types necessary for editing NSAttributedString (and I don't yet know what happens with attachments).
  • UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::getAttributedSubstringFromRange):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Boilerplate code for making a sync call to web process.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange): Ported from WebHTMLView.
1:40 PM Changeset in webkit [83203] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.
Adding to skipped list for Windows (WK2) the
tests relative to undo removed from the skipped list
for Mac where execCommand('undo') is now supported.

  • platform/win-wk2/Skipped:
1:36 PM Changeset in webkit [83202] by enne@google.com
  • 6 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline progress element tests.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium/test_expectations.txt:
1:23 PM Changeset in webkit [83201] by aestes@apple.com
  • 12 edits
    1 add in trunk/Source

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794


Outlook populates a reply message by creating an empty WebView and
using DOM API to populate the WebView's empty document with content
from the original message. It expects the initial empty document to
simply be "<html></html>", and it proceeds to dynamically create and
append a BODY node and add the original message content as a child of
that node. Outlook then takes the innerHTML of the frame's first body
element and copies it into a *new* document that is displayed and
edited in the reply message window.


Due to implementing the HTML5 tree building algorithm in r64712,
initial empty documents went from being "<html></html>" to being
"<html><head></head><body></body></html>". Outlook still dynamically
creates a BODY node to parent the original message content, but this
BODY node duplicates the one created by the tree builder. When Outlook
then takes the innerHTML of the first body element to populate the
reply message window it gets the empty body element created by the
parser, not the one it created with the original message content.


Fix this by injecting a user script into the initial empty document
that removes the HEAD and BODY nodes created by the parser. This
ensures that the BODY created by Outlook is the only BODY in the
document.

  • Misc/OutlookQuirksUserScript.js: Added.
  • WebView/WebView.mm: (leakMailQuirksUserScriptContents): (-[WebView _injectMailQuirksScript]): (needsOutlookQuirksScript): (leakOutlookQuirksUserScriptContents): (-[WebView _injectOutlookQuirksScript]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2011-04-07 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
​https://bugs.webkit.org/show_bug.cgi?id=57794


  • WebCore.exp.in:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts() before checking if the FrameLoader is parsing the initial empty document. This allows user scripts to be injected at the end of document parsing (if the setting is enabled).
  • page/Frame.cpp: (WebCore::Frame::injectUserScripts): Do not inject scripts if this feature is disabled on the initial empty document.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Add a setting for injecting user scripts into the initial empty document (defaults to false). (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument): (WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsMicrosoftOutlook): Check if the embedding application is Microsoft Outlook.
1:18 PM Changeset in webkit [83200] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix.

  • Shared/WebString.h:

(WebKit::WebString::getCharacters): Add explict cast when using std::min().

1:09 PM Changeset in webkit [83199] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; rebaseline expected results in platform/mac-wk2.

  • platform/mac-wk2/media/controls-without-preload-expected.txt:
12:49 PM Changeset in webkit [83198] by jeffm@apple.com
  • 6 edits in trunk

2011-04-07 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=58058

  • TestWebKitAPI/Tests/WebKit2/WKString.cpp: (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().

2011-04-07 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=58058


WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.

  • Shared/API/c/WKString.cpp: (WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
  • Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
  • Shared/WebString.h: (WebKit::WebString::getCharacters): Added.
12:42 PM Changeset in webkit [83197] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: Support window bounce when panning.
​https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>

Reviewed by Adam Roben.

Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.

If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to

an end of the document, and if we have, bounce the window.

  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical

scrollbar and if we are at the beginning or the end of the scrollable document.

12:30 PM Changeset in webkit [83196] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

2011-04-06 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
​https://bugs.webkit.org/show_bug.cgi?id=57962

Add support for a new AVPlayerItem API which will notify clients when their
seek completes. This requires a new Notification type to be passed to the main
thread in MediaPlayerPrivateAVFoundation.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added. (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new

overloaded functions which take a Notification; and a Notification::Type and boolean.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted

Notification type.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor. (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API. (-[WebCoreAVFMovieObserver seekCompleted:]): Added.
12:17 PM Changeset in webkit [83195] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleIsPageBoxVisible):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isPageBoxVisible):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-07 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=42695

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::isPageBoxVisible):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
11:56 AM Changeset in webkit [83194] by enrica@apple.com
  • 17 edits in trunk

Source/WebKit2: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
​https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Mac.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
(WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.

Added new empty PageClient methods for other platforms.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::canUndoRedo):
(QWKPagePrivate::executeUndoRedo):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/gtk/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

  • UIProcess/gtk/WebView.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

  • UIProcess/win/WebView.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
of asychronous messages while waiting for a sync message reply.
(WebKit::WebEditCommandProxy::reapply): Same as above.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.

(WebKit::WebEditorClient::canUndo):
(WebKit::WebEditorClient::canRedo):
(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):

LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
​https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

  • platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo.
11:54 AM Changeset in webkit [83193] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/9250368> and ​https://bugs.webkit.org/show_bug.cgi?id=58062

Reviewed by Maciej Stachowiak.

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseClose):

  • UIProcess/API/C/WKIconDatabase.h:


  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::close):

  • UIProcess/WebIconDatabase.h:
11:51 AM Changeset in webkit [83192] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 58057 - Store boolean payload in low bit of JSImmediate

Reviewed by Geoff Garen.

And remove some uncalled functions from JSImmediate.h

  • jit/JITInlineMethods.h:

(JSC::JIT::emitTagAsBoolImmediate):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_not):

  • runtime/JSImmediate.h:

(JSC::JSImmediate::makeInt):
(JSC::JSImmediate::makeBool):
(JSC::JSImmediate::intValue):
(JSC::JSImmediate::boolValue):
(JSC::JSImmediate::asInt32):
(JSC::JSImmediate::toDouble):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):

11:46 AM Changeset in webkit [83191] by commit-queue@webkit.org
  • 5 edits in trunk

2011-04-07 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Eric Carlson.

Add tests for parsing codecs parameter in video-can-play-type.html
​https://bugs.webkit.org/show_bug.cgi?id=53275

  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:

2011-04-07 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Eric Carlson.

Parse quotes from content type parameters
​https://bugs.webkit.org/show_bug.cgi?id=53275

This functionality is tested in video-can-play-type.html layout test
where I've added codecs parameter with good and bad formatting.

  • platform/ContentType.cpp: (WebCore::ContentType::parameter):
11:24 AM Changeset in webkit [83190] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-04-07 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: remove "enabled" from the setBreakpoint protocol.
​https://bugs.webkit.org/show_bug.cgi?id=58047

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::hasBreakpoint):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint):
11:08 AM Changeset in webkit [83189] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Tests] fast/events/select-element.html failing since introduction in r83096
​https://bugs.webkit.org/show_bug.cgi?id=58059

Adding this test to the mac-wk2 skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
11:01 AM Changeset in webkit [83188] by jberlin@webkit.org
  • 13 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Adam Roben.

Part 3: Implement checkSpellingOfString

In WebCore, checkTextOfParagraph is only defined and used on platforms where
WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
Mac builds).

On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
patch in an attempt to keep things easier to review) are used.

  • UIProcess/API/C/win/WKTextChecker.h:
  • UIProcess/TextChecker.h:

Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING).
(WebKit::WebPageProxy::checkSpellingOfString):
Call through to the client.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

  • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Call through to the WebTextCheckerClient.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
(WebKit::TextChecker::checkSpellingOfString):
Add a call to notImplemented.

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Ditto, and remove the implementation for checkTextOfParagraph.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::checkSpellingOfString):
Ditto.

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::checkSpellingOfString):

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString):
Send a sync message to the UI Process (similar to the sync message used for
checkTextOfParagraph).

11:00 AM Changeset in webkit [83187] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing.

  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [83186] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Update Leopard expected results after r83075 to greenify the bots.

  • platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt:
10:44 AM Changeset in webkit [83185] by kov@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

2011-04-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] Need a way to get the path to a WebKitWebPlugin
​https://bugs.webkit.org/show_bug.cgi?id=57968

Expose the path of the plugin through the WebKitWebPlugin object.

  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_path):
  • webkit/webkitwebplugin.h:
  • webkit/webkitwebpluginprivate.h:
10:41 AM Changeset in webkit [83184] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/qt

2011-04-07 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] QWebFrame::setUrl works only from second time if url fragment is present
​https://bugs.webkit.org/show_bug.cgi?id=32723

When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
use an invalid URL (the begin() without arguments). Clearing the document
with the same URL was causing problems when we had a fragment because it assume that
only scrolling was enough and did not loaded the document again.

When setUrl() is called but fails, url() is expected to return the requested value. The
begin(url) guaranteed that before. This patch adds a member to track the URL, which is
updated when the URL changes and also when setUrl() is called.

KURL was used for the member so that when setUrl() is called, and then url() is checked
before the page gets loaded, we perform the same conversion that will be performed by a
successful load, e.g. add trailing '/' to an address. This behavior is checked by
tst_QWebFrame::requestedUrl() test.

For the record: the second QWebPage::setUrl() worked because the load was considered a
FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.

  • Api/qwebframe.cpp: (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal. (clearCoreFrame): (isCoreFrameClear): (QWebFrame::setUrl): (QWebFrame::url): (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change the baseURL, e.g. by using the <base> tag.
  • Api/qwebframe_p.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlWithFragment): unskip test.
10:32 AM Changeset in webkit [83183] by enne@google.com
  • 2 edits
    8 adds in trunk/LayoutTests

2011-04-07 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline tests changed in r82947.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-linux/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/chromium-win/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/chromium-win/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [83182] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Vincent Scheib <​scheib@chromium.org>

Flagging platform/chromium/compositing/huge-layer-rotated.html a bug.

  • platform/chromium/test_expectations.txt:
10:03 AM Changeset in webkit [83181] by rniwa@webkit.org
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=58037

Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test.

  • editing/inserting/6633727-expected.txt: Removed.
  • editing/inserting/6633727.html: Removed.
  • editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added.
  • editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html.
  • editing/inserting/script-tests/6633727.js: Removed.
9:48 AM Changeset in webkit [83180] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Removed a redundant line of code.

Reviewed by Adam Roben.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.

9:41 AM Changeset in webkit [83179] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-04-07 Liang Qi <​liang.qi@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Enable webkit build with GCCE on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=57841

  • wtf/MathExtras.h: GCCE compiler doesn't support those std static functions.

2011-04-07 Liang Qi <​liang.qi@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Enable webkit build with GCCE on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=57841

  • WebCore.pri: Thanks for Norbert Leser <​norbert.leser@nokia.com> who checked RVCT part. --rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated to 0x1000000 together. They need to be updated in the future when WebKit grows.
9:37 AM Changeset in webkit [83178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available.
​https://bugs.webkit.org/show_bug.cgi?id=57877

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::socketpair): socketpair() which returns -1
9:08 AM Changeset in webkit [83177] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Michael Saboff <​msaboff@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Memory leak in decodeResourceError
​https://bugs.webkit.org/show_bug.cgi?id=58004

Release the local NSError after it is used to create a ResourceError
object assigned to the reference argument.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::decodeResourceError):
8:47 AM Changeset in webkit [83176] by pfeldman@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

2011-04-06 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: get rid of Breakpoint.js.
​https://bugs.webkit.org/show_bug.cgi?id=57949

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js: Removed.
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint): (WebInspector.PresentationBreakpoint.prototype.get sourceFile): (WebInspector.PresentationBreakpoint.prototype.get url): (WebInspector.PresentationBreakpoint.prototype.get resolved): (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._onResourceStarted): (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointUpdated): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:42 AM Changeset in webkit [83175] by yurys@chromium.org
  • 7 edits in trunk

2011-04-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
​https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/protocol/console-agent-expected.txt:

2011-04-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
​https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
8:19 AM Changeset in webkit [83174] by Adam Roben
  • 2 edits in trunk/Tools

Build fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
7:52 AM BuildingOnWindows edited by pere.martir4@gmail.com
(diff)
7:21 AM Changeset in webkit [83173] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip a fast/xmlhttprequest test passing on GTK.

  • platform/gtk/Skipped:
7:20 AM Changeset in webkit [83172] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Add always failing tets to the Skipped list.

  • platform/qt-wk2/Skipped:
7:16 AM Changeset in webkit [83171] by loislo@chromium.org
  • 9 edits in trunk

2011-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
​https://bugs.webkit.org/show_bug.cgi?id=57957

There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.

the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method for events
3) domain + '.' + command => method for requests
4) requestId => id for responses
5) arguments => params for requests
6) data => params for events
7) body => result for responses

protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
​https://bugs.webkit.org/show_bug.cgi?id=57957

There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.

the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method for events
3) domain + '.' + command => method for requests
4) requestId => id for responses
5) arguments => params for requests
6) data => params for events
7) body => result for responses

protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.

  • inspector/CodeGeneratorInspector.pm:
7:16 AM Changeset in webkit [83170] by Adam Roben
  • 2 edits in trunk/Tools

Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()

commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
(Unfortunately the buildbot documentation does not make this clear.) finished() is the only
hook we have, so we have to do our work there. I added a new addCustomURLs method which can
be overridden by subclasses to provide extra URLs before we call up to the base class (after
which adding more URLs is no longer possible).

Really hopefully fixes <​http://webkit.org/b/56032> Leaks viewer should be linked from leaks
bot results page

Reviewed by John Sullivan.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
(ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
method is never called for MasterShellCommands.
(ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
with this method (which is).

6:36 AM Changeset in webkit [83169] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-07 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rolling chromium DEPS 80421:80767.

  • DEPS:
6:36 AM Changeset in webkit [83168] by Adam Roben
  • 2 edits in trunk/Tools

Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()

This matches how most of our other build steps work, so is good just for improving
consistency between build steps. It should also make it possible for
ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
trying to do this in finished() after we had called up to the base class, but that was
apparently too late to add more URLs.)

Hopefully fixes <​http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
results page

Reviewed by John Sullivan.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults): Added a descriptionDone property so that we don't have to manually
call setText to get the right text to show up for this step. This matches how most of our
other build steps work.
(ExtractTestResults.commandComplete): Replaced our override of finished with this function.
This is how most of our other build steps work.
(ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
function, to match the base class.

6:25 AM Changeset in webkit [83167] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-07 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support.
​https://bugs.webkit.org/show_bug.cgi?id=58036

Renamed didReceiveData2 to didReceiveData.

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
6:11 AM Changeset in webkit [83166] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-07 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support.
​https://bugs.webkit.org/show_bug.cgi?id=58034

Migrated didReceiveData to support new lengthReceived parameter.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
6:05 AM Changeset in webkit [83165] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Add functions to update left and right offsets to LineOffsets
​https://bugs.webkit.org/show_bug.cgi?id=58028

Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
which are used to update m_left and m_right. Also added m_block and m_isFirstLine
member variables to LineOffsets so that users of LineOffsets don't have to pass them around.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine. (WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets. (WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine. (WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and no longer passes firstLine around.
5:50 AM Changeset in webkit [83164] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-06 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate debugger domain to the unified breakpoint location notion.
​https://bugs.webkit.org/show_bug.cgi?id=57928

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype._breakpointResolved):
5:44 AM Changeset in webkit [83163] by tkent@chromium.org
  • 2 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Move Leopard-specific images to chromium-mac-leopard, and
unify text results common in chromium-mac.

  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
5:37 AM Changeset in webkit [83162] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-04-07 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Build fix when using Phonon as a backend for the multimedia support.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt):
  • WebCoreSupport/ChromeClientQt.h:
4:07 AM Changeset in webkit [83161] by rniwa@webkit.org
  • 2 edits
    1 add
    12 deletes in trunk/LayoutTests

2011-04-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Convert insert-div-021.html to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=58019

Converted the test.

  • editing/inserting/insert-div-021-expected.txt: Added.
  • editing/inserting/insert-div-021.html:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
  • platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.
4:06 AM Changeset in webkit [83160] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.

When initializing a QStyleOptionSlider from a widget, the State_Horizontal
hint may get set depending on how that widget is laid out in its parent.
If this happens when drawing a vertical scrollbar, the hint is never
cleared and we end up painting a vertical scrollbar with horizontal arrows.

Covered by pixel tests which should no longer paint silly scrollbars.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
3:04 AM Changeset in webkit [83159] by abarth@webkit.org
  • 6 edits
    4 adds in trunk

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline script
​https://bugs.webkit.org/show_bug.cgi?id=58012

Test that script-src blocks inline script. This test uses a different
approach than the existing tests for variety.

  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/document-write-alert-fail.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/dump-as-text.js: Added.

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline script
​https://bugs.webkit.org/show_bug.cgi?id=58012

Block inline scripts at the ScriptElement layer. This should catch
exactly the scripts we want to catch.

Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
    • This patch also adds the ability to supply a CSP policy via a <meta> tag. We'll update the name of the header once we've finished implementing the spec.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::executeScript):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineScript):
  • page/ContentSecurityPolicy.h:
2:56 AM Changeset in webkit [83158] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

webkit-patch shouldn't state the whole working copy when calling check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=58022

Previously, we were ignoring the args variable! This patch fixes the
regression introduced in ​http://trac.webkit.org/changeset/82771.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
2:53 AM Changeset in webkit [83157] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Remove temporary WebProcess sandbox rules that are unnecessary now that plugins are in their own process
​https://bugs.webkit.org/show_bug.cgi?id=58023

  • WebProcess/com.apple.WebProcess.sb:
2:50 AM Changeset in webkit [83156] by tkent@chromium.org
  • 4 edits
    3 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Update Linux x86-64 results for the Skia rounding rect change.

  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png:
2:42 AM Changeset in webkit [83155] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

Skip platform/mac/fast/forms/input-appearance-spinbutton-up.html on Mac WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=56298

  • platform/mac-wk2/Skipped:
2:24 AM Changeset in webkit [83154] by tkent@chromium.org
  • 8 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

Update spinbutton test results for r83145.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
2:04 AM Changeset in webkit [83153] by commit-queue@webkit.org
  • 15 edits in trunk/Source

2011-04-07 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=57921

Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
that the same logic can be used for a HitTestResult.

No visible changes, just cleanup, so no tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::subframeForHitTestResult): Made public static member, so that it can access targetNode(), and be accessed by webkitwebview in gtk. (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::targetNode): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h:
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):

2011-04-07 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=57921

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event): Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode() method has moved on to EventHandler.
1:40 AM Changeset in webkit [83152] by mjs@apple.com
  • 3 edits in trunk/Tools

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
​https://bugs.webkit.org/show_bug.cgi?id=58017

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
1:39 AM Changeset in webkit [83151] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: build mapping for formatted scripts based on keywords positions.
​https://bugs.webkit.org/show_bug.cgi?id=57936

Mapping based on [\$\.\w]+ was not accurate because string literals representation
may be different in original and formatted scripts.

  • inspector/front-end/ScriptFormatterWorker.js: (buildMapping.regexp.b): (buildMapping):
1:30 AM Changeset in webkit [83150] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline after r83145. Also skip
fast/forms/input-number-large-padding.html which fails. See bug
58020.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
1:00 AM Changeset in webkit [83149] by Philippe Normand
  • 1 edit
    12 adds in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for 4 new tests.

  • platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
  • platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
  • platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.
12:39 AM Changeset in webkit [83148] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Remove some no longer needed WebProcess sandbox allowances
​https://bugs.webkit.org/show_bug.cgi?id=58015
<rdar://problem/9232592>

  • WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network and launching privileges, since the bugs that required them are fixed.
12:25 AM Changeset in webkit [83147] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline after r83075.

  • platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
  • platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
12:13 AM Changeset in webkit [83146] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-07 Kent Tamura <​tkent@chromium.org>

[Chromium] Fix a duplicated entry.

  • platform/chromium/test_expectations.txt:
12:03 AM Changeset in webkit [83145] by tkent@chromium.org
  • 12 edits
    2 adds in trunk

Spinbuttons become unclickable if right padding is large.
​https://bugs.webkit.org/show_bug.cgi?id=56298

Reviewed by NOBODY (OOPS!).

Source/WebCore:

An inner-spin-button is put on the right border and ignores right
padding in RenderTextControlSingleLine::layout(), but forwardEvent()
checks if a point is in an area just right of an internal text block.
This inconsistency caused a bug that an inner-spin-button with large
padding didn't receive mouse events.

To fix this bug, we render spin buttons as layers, and remove manual
event forwarding code.

Test: fast/forms/input-number-large-padding.html

  • css/html.css: Add "position:relative" to make a spin-button a layer.

(input::-webkit-inner-spin-button):
(input::-webkit-outer-spin-button):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

Remove manual event forwarding code.

LayoutTests:

Add a test, and skip on platforms which has no inner-spin-button implementation.

  • fast/forms/input-number-large-padding-expected.txt: Added.
  • fast/forms/input-number-large-padding.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/qt/Skipped:
Note: See TracTimeline for information about the timeline view.