⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 9, 2011:

11:29 PM Changeset in webkit [83396] by mitz@apple.com
  • 9 edits
    4 adds in trunk

<rdar://problem/9215280> Detached canvas draws with incorrect font

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/canvas/font-update.html

The existing mechanism for updating the font in a canvas 2D context was lacking in at least
two ways: it neglected to update fonts in all but the topmost state in the stack, and since it
was based on HTMLCanvasElemen's attach() and recalcStyle(), it did not work when the element
was not attached.

This change takes the responsibility for font updates away from the canvas element and gives it
to the canvas context and its graphics state.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::registerForInvalidationCallbacks): Added. Adds to the set of registered
font selector clients.
(WebCore::CSSFontSelector::unregisterForInvalidationCallbacks): Added. Removes from the set of
registered font selector clients.
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks): Calls fontsNeedUpdate() on all registered
clients and forces a style recalc on the document.
(WebCore::CSSFontSelector::fontLoaded): Changed to call dispatchInvalidationCallbacks().
(WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.

  • css/CSSFontSelector.h:
  • html/HTMLCanvasElement.cpp: Removed overrides of attach() and recalcStyle().
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::~State): Added. Unregisters with the font selector.
(WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Added. Called by the font selector
when its fonts need to be updated. Updates the font.
(WebCore::CanvasRenderingContext2D::setFont): Registers the state with the font selector.

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/FontSelector.h:

(WebCore::FontSelectorClient::~FontSelectorClient):

LayoutTests:

  • fast/canvas/font-update-expected.checksum: Added.
  • fast/canvas/font-update-expected.png: Added.
  • fast/canvas/font-update-expected.txt: Added.
  • fast/canvas/font-update.html: Added.
11:17 PM Changeset in webkit [83395] by levin@chromium.org
  • 2 edits in trunk/Tools

2011-04-09 David Levin <​levin@chromium.org>

Unreviewed, rolling out r83394.
​http://trac.webkit.org/changeset/83394
​https://bugs.webkit.org/show_bug.cgi?id=53625

Patch was incorrect as noted in the bug.

  • Scripts/svn-apply:
10:57 PM Changeset in webkit [83394] by levin@chromium.org
  • 2 edits in trunk/Tools

svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
​https://bugs.webkit.org/show_bug.cgi?id=53625

Reviewed by Adam Barth.

  • Scripts/svn-apply: Ensure that the portions of patches

which are for vcproj/vsprops files has DOS line endings.

9:18 PM Changeset in webkit [83393] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-09 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.
​https://bugs.webkit.org/show_bug.cgi?id=58193

Suppress a whole bunch of Win Vista failures until they can be
triaged and/or rebaselined.

  • platform/chromium/test_expectations.txt:
8:55 PM Changeset in webkit [83392] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Try recommitting some things svn left out of my last commit.

  • bridge/qt/qt_runtime.h:
8:53 PM Changeset in webkit [83391] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

Not reviewed.

Try recommitting some things svn left out of my last commit.

  • WebProcess/Plugins/Netscape/NPJSObject.h:
8:50 PM Changeset in webkit [83390] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

Not reviewed.

Try recommitting some things svn left out of my last commit.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

8:47 PM Changeset in webkit [83389] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/Source/WebCore

Not reviewed.

Try recommitting some things svn left out of my last commit.

  • ForwardingHeaders/collector: Removed.
  • ForwardingHeaders/collector/handles: Removed.
  • ForwardingHeaders/collector/handles/Global.h: Removed.
8:41 PM Changeset in webkit [83388] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try recommitting some things svn left out of its last commit.

  • heap/Handle.h:

(JSC::HandleBase::operator!):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle):

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::isValidWeakNode):

  • heap/HandleHeap.h:

(JSC::HandleHeap::globalData):

8:01 PM Changeset in webkit [83387] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-09 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.
​https://bugs.webkit.org/show_bug.cgi?id=58193

Suppress a whole bunch of Win 7 failures until they can be
triaged and/or rebaselined.

  • platform/chromium/test_expectations.txt:
7:33 PM Changeset in webkit [83386] by Dimitri Glazkov
  • 7 edits in trunk

2011-04-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=55515

  • fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.
  • fast/events/shadow-boundary-crossing.html: Added new test for mouseover/mouseout handling.

2011-04-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=55515

This implements XBL 2.0's specified handling of mouseover/mouseout events:
​http://dev.w3.org/2006/xbl2/Overview.html#the-mouseover-and-mouseout-events

To do this, we:
1) calculate lowest common ancestor between relatedTarget and target, and

the nearest boundaries around them: the outer (common) boundary, and the
inner (specific to relatedTarget) boundary. Then, we

2) ensure that events only propagate up to the common boundary (or

all the way if boundary is not found), while

3) updating relatedTarget be the inner boundary.

We also detect the most common case when no common boundary could exist
and provide a fast path to short-circuit most of the boundary detection
logic.

Test: fast/events/shadow-boundary-crossing.html

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a helper to determine lowest

common ancestor, the boundaries around it, and compute adjustments
to relatedTarget and event target ancestor chain.

(WebCore::ancestorsCrossShadowBoundaries): Added.
(WebCore::EventDispatcher::adjustRelatedTarget): Changed to calculate

inner/outer shadow DOM boundaries and adjust ancestors chain accordingly.

(WebCore::EventDispatcher::EventDispatcher): Added flag initializer
(WebCore::EventDispatcher::ensureEventAncestors): Renamed from getEventAncestors,

converted to use initialization flag, rather than testing for empty.

  • dom/EventDispatcher.h: Adjusted decls.
  • dom/MouseEvent.cpp: (WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to send event

to adjustRelatedTarget.

7:32 PM Changeset in webkit [83385] by ggaren@apple.com
  • 55 edits
    10 copies
    3 moves
    2 deletes in trunk/Source

2011-04-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A few heap-related renames and file moves.


WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h


(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)

  • API/JSClassRef.h:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pri:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/SamplingTool.h:
  • bytecompiler/BytecodeGenerator.h:
  • collector: Removed.
  • collector/handles: Removed.
  • collector/handles/Global.h: Removed.
  • collector/handles/Handle.h: Removed.
  • collector/handles/HandleHeap.cpp: Removed.
  • collector/handles/HandleHeap.h: Removed.
  • collector/handles/HandleStack.cpp: Removed.
  • collector/handles/HandleStack.h: Removed.
  • collector/handles/Local.h: Removed.
  • collector/handles/LocalScope.h: Removed.
  • heap: Copied from collector.
  • heap/Handle.h: Copied from collector/handles/Handle.h.
  • heap/HandleHeap.cpp: Copied from collector/handles/HandleHeap.cpp.
  • heap/HandleHeap.h: Copied from collector/handles/HandleHeap.h.
  • heap/HandleStack.cpp: Copied from collector/handles/HandleStack.cpp.
  • heap/HandleStack.h: Copied from collector/handles/HandleStack.h.
  • heap/Local.h: Copied from collector/handles/Local.h.
  • heap/LocalScope.h: Copied from collector/handles/LocalScope.h.
  • heap/Strong.h: Copied from collector/handles/Global.h. (JSC::Strong::Strong): (JSC::Strong::~Strong): (JSC::Strong::operator=):
  • heap/Weak.h: Copied from runtime/WeakGCPtr.h. (JSC::Weak::Weak): (JSC::Weak::~Weak):
  • heap/handles: Removed.
  • interpreter/RegisterFile.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::hostFunctionStub):
  • jit/JITStubs.h:
  • runtime/Structure.h:
  • runtime/WeakGCPtr.h: Removed.

2011-04-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A few heap-related renames and file moves.


WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h


(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)

  • JSRun.h:
  • JSValueWrapper.h:

2011-04-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A few heap-related renames and file moves.


WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h


(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)

  • CMakeLists.txt:

2011-04-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A few heap-related renames and file moves.


WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h


(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::evaluate):
  • WebView/WebScriptDebugger.h:

2011-04-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A few heap-related renames and file moves.


WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h


(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)

  • CMakeLists.txt:
  • ForwardingHeaders/collector: Removed.
  • ForwardingHeaders/heap: Copied from ForwardingHeaders/collector.
  • ForwardingHeaders/heap/Strong.h: Copied from ForwardingHeaders/collector/handles/Global.h.
  • ForwardingHeaders/heap/Weak.h: Copied from ForwardingHeaders/runtime/WeakGCPtr.h.
  • ForwardingHeaders/runtime/WeakGCPtr.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • bindings/js/JSCallbackData.h:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSEventListener.h:
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWindowShell):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptState.h:
  • bindings/js/ScriptValue.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/js/ScriptWrappable.h:
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/js/WorkerScriptController.h:
  • bridge/jsc/BridgeJSC.h:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.h:
  • xml/XMLHttpRequest.cpp:
5:30 PM Changeset in webkit [83384] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-09 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

It looks like NRWT has not been stopping DRT/TestShell
instances properly on windows, probably for a long time.
This would go a long way to explaining why we often have
processes lying around :)

​https://bugs.webkit.org/show_bug.cgi?id=57807

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4:07 PM Changeset in webkit [83383] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-09 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

new-run-webkit-tests: Mac SL tests failing on the bot
​https://bugs.webkit.org/show_bug.cgi?id=58192

Mark tests as needing triage/investigation for failing
on NRWT bot.

  • platform/mac/test_expectations.txt:
3:24 PM Changeset in webkit [83382] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/Websites/webkit.org

2011-04-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by James Robinson.

Add a diagram, explaning how an event's relatedTarget interact with shadow DOM boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=58190

  • misc/related-target-and-shadow-dom.svg: Added.
11:30 AM Changeset in webkit [83381] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] One more attempt to make Qt-WK2 bot happy.

  • platform/qt-wk2/Skipped:
10:58 AM Changeset in webkit [83380] by kbalazs@webkit.org
  • 9 edits in trunk

2011-04-09 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Don't link against fontconfig or X11 if embedded
​https://bugs.webkit.org/show_bug.cgi?id=58104

  • Source/WebKit.pri: Add qpa=>embedded as it should be across all builds.

2011-04-09 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Don't link against fontconfig or X11 if embedded
​https://bugs.webkit.org/show_bug.cgi?id=58104

No functional change so no new tests.

  • WebCore.pri: qpa=>embedded should be done very early so all cases of embedded are uniform.

2011-04-09 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Don't link against fontconfig or X11 if embedded
​https://bugs.webkit.org/show_bug.cgi?id=58104

  • DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
  • QtTestBrowser/QtTestBrowser.pro: ditto
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
  • WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
10:24 AM Changeset in webkit [83379] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Make Qt bots happier. :)

  • platform/qt-wk2/Skipped: Remove non-existent tests.
  • platform/qt/Skipped: Add new tests without Qt specific expected files.
10:14 AM Changeset in webkit [83378] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial fix after r83344.

  • WebCore.pro: Update HEADERS list.
10:04 AM Changeset in webkit [83377] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Make Qt-WK2 buildbot green on ​http://webkit.sed.hu

  • platform/qt-wk2/Skipped: Add failing tests.
1:31 AM Changeset in webkit [83376] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-09 Jon Lee <​jonlee@apple.com>

Reviewed by Beth Dakin.

Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
​https://bugs.webkit.org/show_bug.cgi?id=58180
<rdar://problem/9047984>

  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
1:01 AM Changeset in webkit [83375] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-04-09 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Ryosuke Niwa.

Gather data on modal dialogs shown during unload events
​https://bugs.webkit.org/show_bug.cgi?id=58115

Add a new method to the ChromeClient API to allow clients to receive
notifications of modal dialogs dispatched during page dismissal events.
The new method has a default empty definition; only chromium overrides
it to keep track of histograms.

No tests because this is a no-op for all ports except chromium (and it's
not clear how to test chromium histograms from webkit).

  • page/Chrome.cpp: (WebCore::isDuringPageDismissal): (WebCore::willRunModalDialog): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::willRunModalHTMLDialog):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::willRunModalDialogDuringPageDismissal):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::showModalDialog):

2011-04-09 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Ryosuke Niwa.

Gather data on modal dialogs shown during unload events
​https://bugs.webkit.org/show_bug.cgi?id=58115

Implementation of the new API to receive notifications of modal dialogs
dispatched during unload events. Count the notifications through a histogram.

No tests because it's not clear how to test chromium histograms from webkit.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::willRunModalDialogDuringPageDismissal):
  • src/ChromeClientImpl.h:

Apr 8, 2011:

9:41 PM Changeset in webkit [83374] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

No need to compile .js files, that is what the JIT is for.

  • WebKit.xcodeproj/project.pbxproj:
8:05 PM Changeset in webkit [83373] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-08 David Humphrey <​david.humphrey@senecac.on.ca>

Reviewed by Eric Carlson.

Fix call order of media element muted and play(), such that setting muted before play() works.
​https://bugs.webkit.org/show_bug.cgi?id=57673
​https://code.google.com/p/chromium/issues/detail?id=70777

Manual test added: manual-tests/media-muted.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
  • manual-tests/media-muted.html: Added.
6:59 PM Changeset in webkit [83372] by ap@apple.com
  • 5 edits in trunk/Source

2011-04-08 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
​https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/9060555>

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this should be changed to match WebKit2.

2011-04-08 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
​https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/9060555>

The problem is that command handling should be different for events that come as keyDown:
and those that come as performKeyEquivalent:. WebKit1 only tries custom "key bindings"
when handling a keyDown:, letting a performKeyEquivalent: run through the whole responder
chain first.

This would be very difficult to implement in WebKit2 because of how it re-sends the same
event after web process handling. Luckily, we can both fix the bug and make the behavior
more robust by not hardcoding key combinations.

  • WebProcess/WebPage/WebPage.h: Edit performNonEditingBehaviorForSelector.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): When executing commands, also try executing editor commands in their non-editing meaning, which is usually scrolling. (WebKit::WebPage::performNonEditingBehaviorForSelector): Naive implementation with a chain of ifs, which is hopefully ok performance-wise for a dozen check. (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Only kept two commands here that I couldn't easily move.
6:39 PM Changeset in webkit [83371] by jhoneycutt@apple.com
  • 2 edits in trunk/Tools

http/tests/loading/preload-append-scan.php is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=58178

Reviewed by Brian Weinstein.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(lastPathComponent):
Use CFURL API to find the last path component, rather than
PathFindFileName(), because the latter will include the query string.

6:36 PM Changeset in webkit [83370] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Nat Duca <​nduca@chromium.org>

Reviewed by David Levin.

[chromium] Fix windows assertion on ~CCThread
​https://bugs.webkit.org/show_bug.cgi?id=58153

Because ~CCThread uses waitForThreadCompletion,
calling detachThread is not necessary.

  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
6:31 PM Changeset in webkit [83369] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
updated correctly.
​https://bugs.webkit.org/show_bug.cgi?id=58179

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide" Substitutions item is selected, call toggleSubstitutionsPanelIsShowing.
(WebKit::WebPageProxy::substitutionsPanelIsShowing):
Ask the TextChecker.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::substitutionsPanelIsShowing):
As the shared NSSpellChecker if the substitutionsPanel is visible.
(WebKit::TextChecker::toggleSubstitutionsPanelIsShowing):
Order the substitutionsPanel out or front (copied from WKView.mm).

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::substitutionsPanelIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the editor code relies on the value returned.

5:57 PM Changeset in webkit [83368] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a bug where right-to-left frames incorrectly reported that they were pinned to the left
when they were actually not.

Reviewed by Adele Peterson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeScrollOffsetForMainFrame): Do not assume that the minimum scroll offset
is zero, because it is not.

5:55 PM Changeset in webkit [83367] by jianli@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix broken sentence in WebCore/Change of my rollout r83365.

5:54 PM Changeset in webkit [83366] by aa@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

Reviewed by Dmitry Titov.

Re-land ​http://trac.webkit.org/changeset/83007. This works
without changes after ​https://bugs.webkit.org/show_bug.cgi?id=58110.

​https://bugs.webkit.org/show_bug.cgi?id=58096

5:52 PM Changeset in webkit [83365] by jianli@chromium.org
  • 3 edits
    2 deletes in trunk

2011-04-08 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83348.
​http://trac.webkit.org/changeset/83348
​https://bugs.webkit.org/show_bug.cgi?id=49508

Breaks layout tests in QT, Win7 and Chromium.

  • fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • fast/forms/cursor-at-editable-content-boundary.html: Removed.

2011-04-08 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83348.
​http://trac.webkit.org/changeset/83348
​https://bugs.webkit.org/show_bug.cgi?id=49508

Breaks

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
5:28 PM Changeset in webkit [83364] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::Drop):

5:18 PM Changeset in webkit [83363] by jberlin@webkit.org
  • 14 edits in trunk/Source/WebKit2

WebKit2: Implement TextChecker on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 5: Implement the code show and hide the Spelling UI via the context menu item (both
Windows and Mac).

  • UIProcess/API/C/win/WKTextChecker.h:

Add the new WKTextCheckerClient funtions.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide Spelling and Grammar" item is selected, call toggleSpellingUIIsShowing.
(WebKit::WebPageProxy::spellingUIIsShowing):
Call through to TextChecker.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/TextChecker.h:
    • UIProcess/win/TextCheckerWin.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Call the TextCheckerClient.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::spellingUIIsShowing):
Ask the shared NSSpellChecker if the spellingPanel is visible.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Order the spellingPanel out or front (copied from WKView.mm).

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Call notImplemented.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::spellingUIIsShowing):
Ditto.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/win/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::spellingUIIsShowing):
Call the client.
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
Ditto.

  • UIProcess/win/WebTextCheckerClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::spellingUIIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the Editor code relies on the value returned.

5:04 PM Changeset in webkit [83362] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Sandboxing doesn't work if a local file is dropped on the content area
​https://bugs.webkit.org/show_bug.cgi?id=58177
<rdar://problem/9019253>

When performing a drag and the dragging pasteboard contains a local file, create a
sandbox extension and pass it along. If we end up loading the file, the sandbox extension
tracker will consume the extension.

  • UIProcess/API/mac/WKView.mm: (maybeCreateSandboxExtensionFromPasteboard): Add helper function.

(-[WKView performDragOperation:]):
Create a sandbox extension handle and pass it to performDrag.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered): (WebKit::WebPageProxy::dragUpdated): (WebKit::WebPageProxy::dragExited): Pass an empty sandbox extension handle to performDragControllerAction.

(WebKit::WebPageProxy::performDrag):
Pass the sandbox extension handle along to performDragControllerAction.

(WebKit::WebPageProxy::performDragControllerAction):
Send along the sandbox extension handle.

  • WebProcess/WebCoreSupport/WebDragClient.cpp: (WebKit::WebDragClient::willPerformDragDestinationAction): If the destination action is a load action, call WebPage::willPerformLoadDragDestinationAction.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): Create a sandbox extension.

(WebKit::WebPage::willPerformLoadDragDestinationAction):
If we have a sandbox extension, pass it along to the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::willPerformLoadDragDestinationAction):
Call setPendingProvisionalSandboxExtension.

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Call setPendingProvisionalSandboxExtension.

(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
Factor code from beginLoad out into a separate function.

  • WebProcess/WebPage/WebPage.messages.in: PerformDragControllerAction now takes a sandbox extension handle.
5:02 PM Changeset in webkit [83361] by jianli@chromium.org
  • 13 edits in trunk/Tools

Revert "2011-04-08 Dirk Pranke <​dpranke@chromium.org>"

This reverts commit 78a47b96232b89bedf2e2c98794bbac8e19b905a.

5:00 PM Changeset in webkit [83360] by morrita@google.com
  • 5 edits in trunk

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Updated the result. This new result matches other browsers behavior.

  • platform/mac/fast/box-shadow/inset-expected.checksum:
  • platform/mac/fast/box-shadow/inset-expected.png:

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Handled inset shadow path for rounded and non-rounded rect
differently as normal shadow path is doing.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
4:58 PM Changeset in webkit [83359] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 83351
BUG=78106

4:54 PM Changeset in webkit [83358] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-07 Simon Fraser <Simon Fraser>

Reviewed by Martin Robinson.

REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
​https://bugs.webkit.org/show_bug.cgi?id=55180

The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
data we get back from ImageBuffer::getImageData() do not vary in
endianness.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage):
4:51 PM Changeset in webkit [83357] by alice.liu@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=58151
Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::close):
Resolve a difference between old WebKit WebView and WebKit2 WebView by destroying and clearing
out WebKit2 WebView's HWND when closing. Not doing so was causing the WebView to remain in the
list of WindowMessageBroadcaster listeners, and after closing the WebView, WindowMessageBroadcaster
would message a dead WebView and crash.

4:37 PM Changeset in webkit [83356] by arv@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-08 Erik Arvidsson <​arv@chromium.org>

Reviewed by Dimitri Glazkov.

IFrame is getting the focus even though it is hidden
​https://bugs.webkit.org/show_bug.cgi?id=55861

  • fast/dom/hidden-iframe-no-focus-expected.txt: Added.
  • fast/dom/hidden-iframe-no-focus.html: Added.

2011-04-08 Erik Arvidsson <​arv@chromium.org>

Reviewed by Dimitri Glazkov.

IFrame is getting the focus even though it is hidden
​https://bugs.webkit.org/show_bug.cgi?id=55861

Test: fast/dom/hidden-iframe-no-focus.html

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
  • html/HTMLFrameOwnerElement.h:
4:01 PM Changeset in webkit [83355] by commit-queue@webkit.org
  • 6 edits in trunk

2011-04-08 Jeff Timanus <​twiz@chromium.org>

Reviewed by Kenneth Russell.

Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
​https://bugs.webkit.org/show_bug.cgi?id=57768

  • platform/chromium/test_expectations.txt:

2011-04-08 Jeff Timanus <​twiz@chromium.org>

Reviewed by Kenneth Russell.

Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
​https://bugs.webkit.org/show_bug.cgi?id=57768

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h:
4:00 PM Changeset in webkit [83354] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Make the drag operations be different functions
​https://bugs.webkit.org/show_bug.cgi?id=58169

Since we want performDrag to take a sandbox extension, separate the four
drag operations out into different functions. No functionality change.

  • UIProcess/API/mac/WKView.mm: (-[WKView draggingEntered:]): (-[WKView draggingUpdated:]): (-[WKView draggingExited:]): (-[WKView performDragOperation:]):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered): (WebKit::WebPageProxy::dragUpdated): (WebKit::WebPageProxy::dragExited): (WebKit::WebPageProxy::performDrag):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::DragEnter): (WebKit::WebView::DragOver): (WebKit::WebView::DragLeave): (WebKit::WebView::Drop):
3:59 PM Changeset in webkit [83353] by dcheng@chromium.org
  • 12 edits
    2 adds in trunk

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

Add a reftest to verify that the various bits in the pipeline work as expected.

  • editing/pasteboard/data-transfer-items-image-png-expected.html: Added.
  • editing/pasteboard/data-transfer-items-image-png.html: Added.

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

This patch implements DataTransferItem::getAsFile() using Blobs. In
addition, plumbing for image/png has been added so image paste will be
supported as long as the renderer makes that data available.

Tests: editing/pasteboard/data-transfer-items-image-png.html

  • dom/DataTransferItem.h:
  • dom/DataTransferItem.idl:
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
  • platform/chromium/DataTransferItemChromium.h:
  • platform/chromium/PlatformBridge.h:

2011-04-08 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Implement image/png support in DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58106

Add glue for reading image data from clipboard.

  • DEPS:
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardReadImage):
3:42 PM Changeset in webkit [83352] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 MORITA Hajime <​morrita@google.com>

Unreviewed windows build fix.

  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
3:39 PM Changeset in webkit [83351] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
​https://bugs.webkit.org/show_bug.cgi?id=57595
<rdar://problem/9222122>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: editing/style/bold-with-dom-changes.html

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

  • editing/style/bold-with-dom-changes-expected.txt: Added.
  • editing/style/bold-with-dom-changes.html: Added.
3:39 PM Changeset in webkit [83350] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Parse 'DispatchOnConnectionQueue' in messages.in files
​https://bugs.webkit.org/show_bug.cgi?id=58168

Handle parsing multiple, space-separated attributes in .messages.in files. Keep track of
'DispatchOnConnectionQueue' and rename 'delayed' to 'Delayed'.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
3:37 PM Changeset in webkit [83349] by rolandsteiner@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-04-07 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58060 - Prepare access to TreeScope from Node, using NodeRareData
​https://bugs.webkit.org/show_bug.cgi?id=58060

Add a TreeScope pointer to NodeRareData to allow direct access to the containing tree scope.
However, in case the containing scope is the document, this is not set, and the
document pointer within Node is used instead.

In an object derived from TreeScope (currently Document), the tree scope pointer
points to itself. Such objects also contain a parent tree scope pointer that
points to the containing scope. For Document, this is 0.

Add new functions setTreeScope[Recursively] that replace setDocument[Recursively]
in public usage. setDocument[Recursively] are now only used internally and are
thererfore protected.

No new tests. (no new functionality)

  • dom/ContainerNode.cpp: change DOM manipulation methods to update scope of inserted nodes (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::setDocType): Ditto (WebCore::Document::adoptNode): Ditto
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::treeScope): use NodeRareData to check if a non-Document scope is set (WebCore::Node::setTreeScope): update NodeRareData depending on whether scope is a document (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::setDocumentRecursively):
  • dom/Node.h:
  • dom/NodeRareData.h: add scope pointer (WebCore::NodeRareData::NodeRareData): (WebCore::NodeRareData::treeScope): (WebCore::NodeRareData::setTreeScope):
  • dom/TreeScope.cpp: add parentTreeScope pointer (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
  • dom/TreeScope.h: (WebCore::TreeScope::parentTreeScope):
3:34 PM Changeset in webkit [83348] by xji@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

  • fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • fast/forms/cursor-at-editable-content-boundary.html: Added.

2011-04-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.

Test: fast/forms/cursor-at-editable-content-boundary.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
3:23 PM Changeset in webkit [83347] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToWord):
3:15 PM Changeset in webkit [83346] by scheib@chromium.org
  • 2 edits in trunk/Tools

2011-04-08 Vincent Scheib <​scheib@chromium.org>

Reviewed by Eric Seidel.

add chromium-gpu-linux-x86_64 to the recognized list of ports
​https://bugs.webkit.org/show_bug.cgi?id=58099

Add chromium-gpu-linux-x86_64 to fix assert.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2:57 PM Changeset in webkit [83345] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57971

Reviewed by Simon Fraser.

Rework visited/unvisited links for before/after content. Propagate the bits earlier so that we don't lose
them when we throw away the visited style. Don't throw away the visited link style for pseudo elements
either, so that the styles are consistent.

Source/WebCore:

Added fast/history/visited-generated-content-test.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

LayoutTests:

  • fast/history/visited-generated-content-test-expected.txt: Added.
  • fast/history/visited-generated-content-test.html: Added.
2:21 PM Changeset in webkit [83344] by morrita@google.com
  • 17 edits
    2 adds
    1 delete in trunk/Source

2011-04-06 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

[Refactoring] Auto correction panel should be handled by its own class.
​https://bugs.webkit.org/show_bug.cgi?id=55571

Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
SpellingCorrectionController class.
This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
code paths inside the never reached without autocorrection support.
Removing guards reduces unintentional build breakage.

No new tests, no behavior chagne.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CorrectionPanelInfo.h: Removed.
  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): (WebCore::Editor::respondToChangedContents): (WebCore::Editor::appliedEditing): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::cut): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::isAutomaticSpellingCorrectionEnabled): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::unappliedSpellCorrection): (WebCore::Editor::updateMarkersForWordsAffectedByEditing): (WebCore::Editor::startCorrectionPanelTimer): (WebCore::Editor::handleCorrectionPanelResult): (WebCore::Editor::dismissCorrectionPanelAsIgnored):
  • editing/Editor.h:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SpellingCorrectionController.cpp: Added. (WebCore::markerTypesForAutocorrection): (WebCore::markerTypesForReplacement): (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::SpellingCorrectionController): (WebCore::SpellingCorrectionController::~SpellingCorrectionController): (WebCore::SpellingCorrectionController::startCorrectionPanelTimer): (WebCore::SpellingCorrectionController::stopCorrectionPanelTimer): (WebCore::SpellingCorrectionController::stopPendingCorrection): (WebCore::SpellingCorrectionController::applyPendingCorrection): (WebCore::SpellingCorrectionController::hasPendingCorrection): (WebCore::SpellingCorrectionController::isSpellingMarkerAllowed): (WebCore::SpellingCorrectionController::show): (WebCore::SpellingCorrectionController::handleCancelOperation): (WebCore::SpellingCorrectionController::dismiss): (WebCore::SpellingCorrectionController::dismissSoon): (WebCore::SpellingCorrectionController::applyCorrectionPanelInfo): (WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate): (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection): (WebCore::SpellingCorrectionController::correctionPanelTimerFired): (WebCore::SpellingCorrectionController::handleCorrectionPanelResult): (WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled): (WebCore::SpellingCorrectionController::windowRectForRange): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::client): (WebCore::SpellingCorrectionController::textChecker): (WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed): (WebCore::SpellingCorrectionController::markReversed): (WebCore::SpellingCorrectionController::markCorrection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  • editing/SpellingCorrectionController.h: Added. (WebCore::SpellingCorrectionController::UNLESS_ENABLED): (WebCore::SpellingCorrectionController::shouldStartTimeFor): (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::markMisspellingsAfterTyping): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/htmlediting.h: (WebCore::isAmbiguousBoundaryCharacter):
  • page/EditorClient.h:
  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors):
2:06 PM Changeset in webkit [83343] by rniwa@webkit.org
  • 3 edits
    2 moves
    24 deletes in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dump-as-markup conversion: editing/pasteboard/paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html
​https://bugs.webkit.org/show_bug.cgi?id=58081

Converted paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html to dump-as-markup tests.
Also explained what to expect in each test.

  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Added.
  • editing/pasteboard/paste-text-at-tabspan-001.html:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Added.
  • editing/pasteboard/paste-text-at-tabspan-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
1:58 PM Changeset in webkit [83342] by hclam@chromium.org
  • 27 edits
    3 deletes in trunk

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken.

  • configure.ac:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Removed.
  • html/HTMLTrackElement.h: Removed.
  • html/HTMLTrackElement.idl: Removed.

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • WebKit.xcodeproj/project.pbxproj:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • features.gypi:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Configurations/FeatureDefines.xcconfig:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • Scripts/build-webkit:

2011-04-08 Alpha Lam <​hclam@chromium.org>

Unreviewed, rolling out r83335.
​http://trac.webkit.org/changeset/83335
​https://bugs.webkit.org/show_bug.cgi?id=53556

GTK and QT bots are broken

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:46 PM Changeset in webkit [83341] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Ooops, typo, build fix.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

1:40 PM Changeset in webkit [83340] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-08 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove modular references after support for the flag was removed.
​https://bugs.webkit.org/show_bug.cgi?id=57018

Removed modular references after support for the flag was removed.

Support was removed because the Qt Modularization project decided we
don't need it. It's better to base decisions on the available
information, as demonstrated in the patch by checking
QT.phonon.includes.

  • Source/WebKit.pri:
1:38 PM Changeset in webkit [83339] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=58155 and part of <rdar://problem/9251767>
BitmapImage::getFirstCGImageRefOfSize fails if the frameCount hasn't been initialized from the image source.

Reviewed by Adam Roben.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getFirstCGImageRefOfSize): Call frameCount() instead of accessing m_frames.size() to

make sure the frames are properly tallied first.

1:36 PM Changeset in webkit [83338] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-08 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Dragging and dropping an image in edit mode does not work
​https://bugs.webkit.org/show_bug.cgi?id=19385

When adding an image to the clipboard, we should also include the HTML code of that image so
it can be used for internal drag and drop.

This HTML is expected by all clients of drop events so a fragment can be moved from one browser to
another, or inside the same browser.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
1:33 PM Changeset in webkit [83337] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Bug 58154 - Add support for comparison operators to the DFG JIT.

Reviewed by Oliver Hunt.

Add support for <, <=, ==, ===, and also !. Add support for all corresponding
bytecode ops, including the not- and -null forms. Initially add functionally
correct support, we'll revisit the performance.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::parse):

  • Add support for parsing of bytecode opcodes,
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • Add new operation call types, return bool values.
  • dfg/DFGNode.h:
    • Add new node types.
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Add code generation for new nodes.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationCompareLess):
(JSC::DFG::operationCompareLessEq):
(JSC::DFG::operationCompareEq):
(JSC::DFG::operationCompareStrictEq):
(JSC::DFG::dfgConvertJSValueToBoolean):

  • dfg/DFGOperations.h:
    • Add operation callbacks to implement new ops.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Add code generation for new nodes.
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePatchGetArrayLength):

  • Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
  • runtime/JSImmediate.h:
    • Make tag values public, rather than relying on a friend - this matches JSVALUE32_64.
1:28 PM Changeset in webkit [83336] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Rebaselines and text expectation updates after r83322.
The bug is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=58158

  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
1:28 PM Changeset in webkit [83335] by hclam@chromium.org
  • 27 edits
    3 adds in trunk

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • configure.ac:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

No new tests. No real functionality added just yet.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp: Added. (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::create): (WebCore::HTMLTrackElement::insertedIntoTree): (WebCore::HTMLTrackElement::willRemove): (WebCore::HTMLTrackElement::src): (WebCore::HTMLTrackElement::setSrc): (WebCore::HTMLTrackElement::kind): (WebCore::HTMLTrackElement::setKind): (WebCore::HTMLTrackElement::srclang): (WebCore::HTMLTrackElement::setSrclang): (WebCore::HTMLTrackElement::label): (WebCore::HTMLTrackElement::setLabel): (WebCore::HTMLTrackElement::isDefault): (WebCore::HTMLTrackElement::setIsDefault): (WebCore::HTMLTrackElement::isURLAttribute):
  • html/HTMLTrackElement.h: Added.
  • html/HTMLTrackElement.idl: Added.

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • WebKit.xcodeproj/project.pbxproj:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • features.gypi:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Scripts/build-webkit:

2011-04-07 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Setup ENABLE(TRACK) feature define
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:21 PM Changeset in webkit [83334] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

new-run-webkit-tests: configure a NRWT test bot for Mac SL
​https://bugs.webkit.org/show_bug.cgi?id=58114

This change removes the old new-run-webkit-tests entry and
updates it for a new test-only bot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:14 PM Changeset in webkit [83333] by Dimitri Glazkov
  • 9 edits in trunk

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

layoutTestController.shadowRoot returns null, not undefined, when
its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

Update the test to expect null and not undefined.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • platform/chromium/test_expectations.txt: unskip keygen.html

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Roben.

Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowRoot):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
1:11 PM Changeset in webkit [83332] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-07 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Logic error in HTMLMediaElement::exitFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=58085

The new full screen API case could fall through to the legacy API case
unintentionally if a script calls exitFullscreen on an element which is
not the current full screen element.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::exitFullscreen):
1:10 PM Changeset in webkit [83331] by dimich@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
​https://bugs.webkit.org/show_bug.cgi?id=58110
Since they are simple one-thread tests.
This code parallels the code in Chromium's idb bindings that uses v8 Lockers in utility process,
which is equally not needed since there is only one thread running v8 in that process.

Reviewed by Adam Barth.

  • tests/IDBBindingUtilitiesTest.cpp:
1:08 PM Changeset in webkit [83330] by dpranke@chromium.org
  • 13 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: implement support for audio tests.

​https://bugs.webkit.org/show_bug.cgi?id=57987

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:08 PM Changeset in webkit [83329] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Mike Reed <​reed@google.com>

Reviewed by Eric Seidel.

Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work
​https://bugs.webkit.org/show_bug.cgi?id=57782

No new tests. This change only affects print-preview and build option SKIA_GPU

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
12:58 PM Changeset in webkit [83328] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaselines after r83291.

  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt:
12:48 PM Changeset in webkit [83327] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-04-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: clean up the way we handle missing files,
to be consistent. With this change, the Port.expected_X() and
Driver.run_test() routines should return None if there is no
output, not .

​https://bugs.webkit.org/show_bug.cgi?id=58101

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:39 PM Changeset in webkit [83326] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Darin Alder.

REGRESSION (WebKit2): AppKit thinks that web views don't support DocumentAccess
​https://bugs.webkit.org/show_bug.cgi?id=58102
<rdar://problem/9223246>

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): (-[WKView insertText:replacementRange:]): (-[WKView validAttributesForMarkedText]): (-[WKView setMarkedText:selectedRange:replacementRange:]): (-[WKView attributedSubstringForProposedRange:actualRange:]): (-[WKView firstRectForCharacterRange:actualRange:]): Switch to NSTextInputClient, opting out of optimizations and optional features for now.
12:37 PM Changeset in webkit [83325] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Not reviewed.

Skip for DRT differences.

  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
12:33 PM Changeset in webkit [83324] by mjs@apple.com
  • 7 edits in trunk/Source/WebKit/mac

2011-04-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

-[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
​https://bugs.webkit.org/show_bug.cgi?id=58128
<rdar://problem/9244553>


The root of the problem here was an O(N2) issue - each WebView,
upon having its preferences initialized, would broadcast a
notification that was listened to by all other WebViews sharing
its preferences.


To maintain the API contract, I split the notification into two,
one that is for public API consumption, and the other which is for
internal use only. Changes that don't need to be picked up by
other WebViews broadcast the public notification only. And we
avoid WebView broadcasting a notification just to get itself to
update.

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase _startUpIconDatabase]): (-[WebIconDatabase _shutDownIconDatabase]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
  • WebView/WebPreferences.mm: (-[WebPreferences initWithIdentifier:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _setFloatValue:forKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences _setLongLongValue:forKey:]): (-[WebPreferences _setUnsignedLongLongValue:forKey:]): (-[WebPreferences _postPreferencesChangedNotification]): (-[WebPreferences _postPreferencesChangedAPINotification]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]): (-[WebView _preferencesChanged:]): (-[WebView setUsesPageCache:]): (+[WebView initialize]): (-[WebView setPreferences:]): (-[WebView _keyboardUIMode]):
  • WebView/WebViewInternal.h:
12:30 PM Changeset in webkit [83323] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-08 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Martin Robinson.

[Qt][WK2][Symbian] Remove use of stack arrays with variable size
​https://bugs.webkit.org/show_bug.cgi?id=57877

For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integer

  • Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
12:29 PM Changeset in webkit [83322] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.

REGRESSION(r81887): Crash in SplitElement
​https://bugs.webkit.org/show_bug.cgi?id=57743

The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
even when the position was after the last node in it container. Since all we are doing here is to splitting tree
up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
and highestEnclosingNodeOfType.

Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
it incorrectly called deprecatedNode instead of containerNode.

Test: editing/inserting/insert-images-in-pre-x-crash.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::highestEnclosingNodeOfType):

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.

REGRESSION(r81887): Crash in SplitElement
​https://bugs.webkit.org/show_bug.cgi?id=57743

Added a regression test for a crash in ReplaceSelectionCommand.

  • editing/inserting/insert-images-in-pre-x-crash-expected.txt: Added.
  • editing/inserting/insert-images-in-pre-x-crash.html: Added.
11:55 AM Changeset in webkit [83321] by Antti Koivisto
  • 3 edits
    3 adds in trunk

Incoming source should be preload scanned when the parser is blocked
​https://bugs.webkit.org/show_bug.cgi?id=58117

Reviewed by Tony Gentilcore.

Source/WebCore:

Scan the appended source if parser is blocked.

Test: http/tests/loading/preload-append-scan.php

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

LayoutTests:

  • http/tests/loading/preload-append-scan-expected.txt: Added.
  • http/tests/loading/preload-append-scan.php: Added.
  • http/tests/resources/slow-script.pl: Added.
11:53 AM Changeset in webkit [83320] by commit-queue@webkit.org
  • 9 edits in trunk

2011-04-08 Varun Jain <​varunjain@chromium.org>

Reviewed by Darin Fisher.

Need to extend WebKit chromium API to access text selection
​https://bugs.webkit.org/show_bug.cgi?id=57888

  • Source/WebKit/chromium/public/WebFrame.h:
  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebFrameImpl.cpp:
  • Source/WebKit/chromium/src/WebFrameImpl.h:
  • Source/WebKit/chromium/src/WebPopupMenuImpl.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
  • Source/WebKit/chromium/src/WebViewImpl.h:
  • Source/WebKit/chromium/tests/PopupMenuTest.cpp:
11:47 AM Changeset in webkit [83319] by Martin Robinson
  • 5 edits in trunk/Source

2011-04-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the WebKit2 build for older versions of GTK+
​https://bugs.webkit.org/show_bug.cgi?id=58095

No new tests. This is just a build fix.

  • platform/gtk/GtkVersioning.c: (gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
  • platform/gtk/GtkVersioning.h: Add the new method to the header.

2011-04-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the WebKit2 build for older versions of GTK+
​https://bugs.webkit.org/show_bug.cgi?id=58095

  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Include the GtkVersioning.h header.
11:40 AM Changeset in webkit [83318] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixed a typo in chromium test expectation list.

  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [83317] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, added one more failed test to test expectation list in chromium.

  • platform/chromium/test_expectations.txt:
11:17 AM CommitQueue edited by nholbrook@apple.com
Update committers.py link. (diff)
10:58 AM Changeset in webkit [83316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Misha Tyutyunik <​michael.tyutyunik@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Plugin is not scrolled together with page content or jumping
when content is rendered using cache (backing store).
​https://bugs.webkit.org/show_bug.cgi?id=56130

This is a Symbian portion of the fix. For Linux it looks like
it's enough to call set geometry which should be addressed in
​https://bugs.webkit.org/show_bug.cgi?id=57179

No new tests required. This can be tested with manual tests from
WebCore/manual-tests/qt and WebCore/manual-tests/plugins

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget):
10:50 AM Changeset in webkit [83315] by Lucas Forschler
  • 2 edits in tags/Safari-534.28.1/Source/JavaScriptCore

Merge 83299.

10:50 AM Changeset in webkit [83314] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, added failed tests to test expectation list in chromium.

  • platform/chromium/test_expectations.txt:
10:46 AM Changeset in webkit [83313] by Lucas Forschler
  • 5 edits in tags/Safari-534.28.1/Source

Versioning.

10:44 AM Changeset in webkit [83312] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Abhishek Arya <​inferno@chromium.org>

Unreviewed. Remove accidental printf added in r83306.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
10:43 AM Changeset in webkit [83311] by Lucas Forschler
  • 1 copy in tags/Safari-534.28.1

New Tag.

10:43 AM Changeset in webkit [83310] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-08 Pere Martir <​pere.martir4@gmail.com>

Reviewed by Adam Roben.

Locate NSTD.EXE in 64-bit Windows
​https://bugs.webkit.org/show_bug.cgi?id=57847

  • Scripts/old-run-webkit-tests:
10:41 AM Changeset in webkit [83309] by Lucas Forschler
  • 2 edits in tags/Safari-534.28/Source/JavaScriptCore

Rollout 83299 from Tag.

10:36 AM Changeset in webkit [83308] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Dragging text in a WebKit2 window results in a copy instead of a move.
​https://bugs.webkit.org/show_bug.cgi?id=56772
<rdar://problem/9165140>

Reviewed by Darin Adler.

cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
the call to startDrag is asynchronous.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::cleanupAfterSystemDrag):

10:05 AM Changeset in webkit [83307] by kbalazs@webkit.org
  • 6 edits in trunk/Source

2011-04-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
​https://bugs.webkit.org/show_bug.cgi?id=58030

  • wtf/Platform.h: Introduce USE(UNIX_DOMAIN_SOCKETS) for WebKit2.

2011-04-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
​https://bugs.webkit.org/show_bug.cgi?id=58030

Replace "PLATFORM(QT)
PLATFORM(GTK)" conditions in IPC code with

USE(UNIX_DOMAIN_SOCKETS).

  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/SharedMemory.h:
9:59 AM Changeset in webkit [83306] by andersca@apple.com
  • 3 edits in trunk/Source

2011-04-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Clicks not recognized on ​http://www.nibblestutorials.net/ which uses Silverlight
​https://bugs.webkit.org/show_bug.cgi?id=58108
<rdar://problem/9167611>

Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
event has been handled. In this case it lead to a very subtle bug where the plug-in element would
lose focus right after a mouse down even had been sent.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleMouseEvent):
9:49 AM Changeset in webkit [83305] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83295.
​http://trac.webkit.org/changeset/83295
​https://bugs.webkit.org/show_bug.cgi?id=58144

Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-04-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83295.
​http://trac.webkit.org/changeset/83295
​https://bugs.webkit.org/show_bug.cgi?id=58144

Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
9:34 AM Changeset in webkit [83304] by Lucas Forschler
  • 2 edits in tags/Safari-534.28/Source/JavaScriptCore

Merge 83299.

9:10 AM Changeset in webkit [83303] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-08 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, looks like the test is working fine now.

[GTK] websocket/tests/bad-sub-protocol-control-chars.html fails on 32-bit Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=46942

  • platform/gtk/Skipped:
9:06 AM Changeset in webkit [83302] by Adam Roben
  • 2 edits in trunk/Tools

Qt build fix

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
9:03 AM Changeset in webkit [83301] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-08 Jon Lee <​jonlee@apple.com>

Reviewed by David Levin.

adding *.vcproj.*.user to .gitignore for Visual Studio development
​https://bugs.webkit.org/show_bug.cgi?id=58097

  • .gitignore:
9:00 AM Changeset in webkit [83300] by Adam Roben
  • 14 edits
    5 adds in trunk

Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms

This matches WebKit1.

Fixes <​http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
plugin

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroy): Null out our NPWindow's window handle and pass it to
NPP_SetWindow (unless we're on Mac).

Tools:

Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginLogWithArguments): Moved code to format and log the message here...
(pluginLog): ...from here.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::log): Added. Calls through to pluginLogWithArguments.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.

(NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
to begin.
(NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
constructor.
(NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
can be used to invoke our setWillBeDestroyed function.
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
anything unexpected happens).
(NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
NPP_SetWindow was *not* called during destruction.
(NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
method, setWillBeDestroyed.
(NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
object.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added new test.

  • Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with

WebKit1 on Mac, since it can't work properly due to <​http://webkit.org/b/58077>.

LayoutTests:

Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms

  • platform/win-wk2/Skipped: Removed a test that no longer crashes thanks to this fix.
  • plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • plugins/npp-set-window-called-during-destruction.html: Added.
  • platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is

different from the cross-platform results because we don't expect NPP_SetWindow to be called
during destruction.

  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is

a copy of the cross-platform results, needed to override the Mac-specific results.

8:56 AM Changeset in webkit [83299] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Clean build fix

  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Don't try to delete directories that

don't exist. Also switched from del /s to rmdir /s, which has the benefit of deleting the
directory itself in addition to the files it contains.

8:48 AM Changeset in webkit [83298] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move WheelEvent-dispatching logic into WheelEventDispatchMediator.
​https://bugs.webkit.org/show_bug.cgi?id=57642

Covered by existing tests, no functional change.

  • dom/Event.cpp:
  • dom/Event.h: (WebCore::EventDispatchMediator::EventDispatchMediator): Added default

constructor.

(WebCore::EventDispatchMediator::event): Inlined.
(WebCore::EventDispatchMediator::setEvent): Added.

  • dom/EventDispatcher.cpp: Removed dispatchWheelEvent.
  • dom/EventDispatcher.h: Updated decls.
  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent): Changed to use the mediator and

return a bool, like other dispatch event functions.

  • dom/Node.h: Changed decl.
  • dom/WheelEvent.cpp: (WebCore::granularity): Moved from EventDispatcher. (WebCore::WheelEventDispatchMediator::WheelEventDisatchMediator): Added. (WebCore::WheelEventDispatchMediator::event): Added. (WebCore::WheelEventDispatchMediator::dispatchEvent): Added.
  • dom/WheelEvent.h: Updated decls.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Changed to receive and react

to the return value.

8:38 AM Changeset in webkit [83297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Jamie Cooley <​james.cooley@nokia.com>

Reviewed by Benjamin Poulain.

[Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=57945

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qwkhistory.h:
8:30 AM Changeset in webkit [83296] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build warning fix.

  • WebCore.vcproj/WebCore.vcproj:

Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
the build.

8:24 AM Changeset in webkit [83295] by yi.4.shen@nokia.com
  • 4 edits in trunk

2011-04-08 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57472

Unskips the fast/events/onsearch-enter.html test.

  • platform/qt/Skipped:

2011-04-08 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
​https://bugs.webkit.org/show_bug.cgi?id=57472

Avoid to insert new line for both keydown event & keypress event.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
8:10 AM Changeset in webkit [83294] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: update breakpoints according to source frame decorations after live edit.
​https://bugs.webkit.org/show_bug.cgi?id=58029

  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/live-edit.html:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: update breakpoints according to source frame decorations after live edit.
​https://bugs.webkit.org/show_bug.cgi?id=58029

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.set content):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource): (WebInspector.SourceFrame.prototype._handleSave):
8:03 AM Changeset in webkit [83293] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix scripts concatenation in scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=58138

When there is just one script starting at 0:0 it should not be surrounded by <script> framing.

  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
7:22 AM Changeset in webkit [83292] by steveblock@google.com
  • 5 edits in trunk/LayoutTests

2011-04-08 Steve Block <​steveblock@google.com>

Unreviewed build fix.

Media Stream API: add the getUserMedia method and the Javascript bindings
​https://bugs.webkit.org/show_bug.cgi?id=56586

Add new tests to skipped lists for platforms where the feature is not
enabled.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
7:07 AM Changeset in webkit [83291] by yurys@chromium.org
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2011-04-08 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations to match results after rolling
v8 revision that reports stack overflow exception to the console.

  • platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/recursion-limit-equal-expected.txt: Removed.
  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt.
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt.
5:36 AM Changeset in webkit [83290] by pfeldman@chromium.org
  • 14 edits in trunk

2011-04-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
​https://bugs.webkit.org/show_bug.cgi?id=58118

This change reuses location for call frames in the protocol + structures script
location <-> source lines interaction better. When we need UI columns, we will add
them, but we should distinguish between script and UI terms on the type level, not naming.

  • English.lproj/localizedStrings.js:
  • bindings/v8/DebuggerScript.js:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine): (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.PresenationCallFrame): (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping): (WebInspector.PresenationCallFrame.prototype.sourceLine):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.lineToPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
5:34 AM Changeset in webkit [83289] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
​https://bugs.webkit.org/show_bug.cgi?id=58133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._reset):
5:31 AM Changeset in webkit [83288] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
​https://bugs.webkit.org/show_bug.cgi?id=58026

This is the first step of decoupling TextViewer from SourceFrame.

5:09 AM Changeset in webkit [83287] by steveblock@google.com
  • 18 edits
    18 adds in trunk

2011-04-08 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add the getUserMedia method and the Javascript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=56586

Test the Javascript behaviour of the getUserMedia method with different types of arguments.
Current specification: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

  • fast/dom/MediaStream/argument-types-expected.txt: Added.
  • fast/dom/MediaStream/argument-types.html: Added.
  • fast/dom/MediaStream/enabled-expected.txt: Added.
  • fast/dom/MediaStream/enabled.html: Added.
  • fast/dom/MediaStream/no-interface-object-expected.txt: Added.
  • fast/dom/MediaStream/no-interface-object.html: Added.
  • fast/dom/MediaStream/script-tests/argument-types.js: Added. (shouldNotThrow): (test): (emptyFunction): (): (ObjectThrowingException.prototype.valueOf): (ObjectThrowingException.prototype.toString):
  • fast/dom/MediaStream/script-tests/enabled.js: Added. (hasGetUserMediaProperty):
  • fast/dom/MediaStream/script-tests/no-interface-object.js: Added. (test):

2011-04-08 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add the getUserMedia method and the Javascript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=56586

Add the getUserMedia method to the navigator and its new Javascript types.
Current specification: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

Tests: fast/dom/MediaStream/argument-types.html

fast/dom/MediaStream/enabled.html
fast/dom/MediaStream/no-interface-object.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::V8Navigator::webkitGetUserMediaCallback):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/NavigatorUserMediaError.h: Added. (WebCore::NavigatorUserMediaError::NavigatorUserMediaError): (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError): (WebCore::NavigatorUserMediaError::code):
  • page/NavigatorUserMediaError.idl: Added.
  • page/NavigatorUserMediaErrorCallback.h: Added. (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
  • page/NavigatorUserMediaErrorCallback.idl: Added.
  • page/NavigatorUserMediaSuccessCallback.h: Added. (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
  • page/NavigatorUserMediaSuccessCallback.idl: Added.
4:40 AM Changeset in webkit [83286] by mnaganov@chromium.org
  • 6 edits
    1 copy
    1 move
    22 adds
    2 deletes in trunk

2011-04-08 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58010
​https://bugs.webkit.org/show_bug.cgi?id=58011

Added tests for "Containment" view. Minor refactorings, bugs fixed.
Split one large tests into smaller ones to avoid timing out in debug mode.

Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html

inspector/profiler/detailed-heapshots-containment-show-all.html
inspector/profiler/detailed-heapshots-containment-show-next.html
inspector/profiler/detailed-heapshots-containment-sorting.html
inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-summary-show-all.html
inspector/profiler/detailed-heapshots-summary-show-next.html
inspector/profiler/detailed-heapshots-summary-sorting.html

2011-04-08 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58010
​https://bugs.webkit.org/show_bug.cgi?id=58011

Added tests for "Containment" view. Minor refactorings, bugs fixed.
Split one large tests into smaller ones to avoid timing out in debug mode.

  • inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
  • inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary.html: Removed.
  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled): (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest): (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest):
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:22 AM Changeset in webkit [83285] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Bugs in some corner cases in the text editor
​https://bugs.webkit.org/show_bug.cgi?id=58025

This solves the following bugs:
1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
4:20 AM Changeset in webkit [83284] by podivilov@chromium.org
  • 10 edits
    2 adds in trunk

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • gyp/streamline-inspector-source.sh:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._formatter):
  • inspector/front-end/ScriptFormatterWorker.js:

2011-04-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • WebKit.gyp:
4:13 AM Changeset in webkit [83283] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Note some flaky tests.

  • platform/chromium/test_expectations.txt:
3:52 AM Changeset in webkit [83282] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] The second attempt of fixing for Windows (dbg)(shared) build.

  • WebKit.gyp: webkit should not depend on webkit_support.
3:35 AM Changeset in webkit [83281] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Do not destroy WorkQueue event sources unless they have been cancelled
​https://bugs.webkit.org/show_bug.cgi?id=57611

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::EventSource): Remove unused member m_dispatchSource. (WorkQueue::EventSource::executeEventSource): Make it return void instead of boolean since we are always ignoring the return value. (WorkQueue::EventSource::performWork): Return FALSE from the callback only when the source has been cancelled (condition = 0) to make sure it's destroyed when the even source handler is unregistered. (WorkQueue::registerEventSourceHandler): Use GRefPtr for the source, to avoid leaking it. (WorkQueue::scheduleWorkOnSource): Receive the source callback as parameter so that it can be used by scheduleWorkOnTermination() too. (WorkQueue::scheduleWork): (WorkQueue::scheduleWorkAfterDelay): (WorkQueue::scheduleWorkOnTermination): Use scheduleWorkOnSource().
3:28 AM Changeset in webkit [83280] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Close connection when web process finishes
​https://bugs.webkit.org/show_bug.cgi?id=57540

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp:
  • Platform/PlatformProcessIdentifier.h: Use GPid as process identifier.
  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::EventSource): Add cancellable parameter. (WorkQueue::EventSource::cancel): New method to cancel the source. (WorkQueue::EventSource::performWorkOnTermination): New method to execute a work item called when child process has finished. (WorkQueue::registerEventSourceHandler): Create a GCancellable for the socket source. (WorkQueue::unregisterEventSourceHandler): Cancel the source instead of destroying it, this will cause the source to trigger with condition = 0, which makes the callback return FALSE and the source is destroyed. (WorkQueue::scheduleWorkOnSource): Pass NULL as cancellable for idle and timeout sources. (WorkQueue::scheduleWorkOnTermination): Create a child watch source to monitor the child process.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use GPid instead of int as process identifier.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching): Call WorkQueue::scheduleWorkOnTermination() for GTK platform too when web process has been launched.
3:28 AM Changeset in webkit [83279] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted test expectations following r83275.

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
3:17 AM Changeset in webkit [83278] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
​https://bugs.webkit.org/show_bug.cgi?id=57434

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::EventSource::executeEventSource): This new method contains the common code to execute a work item. (WorkQueue::EventSource::performWorkOnce): Use executeEventSource() to execute the work item. (WorkQueue::EventSource::performWork): Use executeEventSource() to execute the work item. (WorkQueue::registerEventSourceHandler): Use a GSocket instead of a GIOChannel since the API is newer and allows us to pass a cancellable object to be able to cancel the source. (WorkQueue::scheduleWorkOnSource): This new method contains the common code to attach a source to a context. It doesn't use a lock anymore, since g_source_attach() uses its own mutex internally. (WorkQueue::scheduleWork): Use an idle source instead of a timeout one, changing the priority to G_PRIORITY_DEFAULT. (WorkQueue::scheduleWorkAfterDelay): Implement it using a timeout source with the given delay.
3:06 AM Changeset in webkit [83277] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
​https://bugs.webkit.org/show_bug.cgi?id=57234

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::childSetupFunction): close the socket and use prctl() when platform is Linux to kill the child process when the parent finishes. (WebKit::ProcessLauncher::launchProcess): Use g_spawn_async() to launch the web process.
2:55 AM Changeset in webkit [83276] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Tweak dynamically constants for the async highlighting in text editor
​https://bugs.webkit.org/show_bug.cgi?id=58035

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines): (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines): (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit): (WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):
2:48 AM Changeset in webkit [83275] by caseq@chromium.org
  • 6 edits
    1 delete in trunk

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR compliance fixes
​https://bugs.webkit.org/show_bug.cgi?id=58124

  • Always provide some values for queryString and cookies, even though arrays may be empty
  • Always provide an empty cache object
  • Added entire HARLog to test
  • Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)

2011-04-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR compliance fixes
​https://bugs.webkit.org/show_bug.cgi?id=58124

  • Added entire HARLog to test
  • Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resources-test.js:
  • platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
2:28 AM Changeset in webkit [83274] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Build fix for Windows (dbg)(shared).

  • WebKit.gyp: Add webkit_support dependency, which is required for webkit_unittest_files.
2:26 AM Changeset in webkit [83273] by sergio@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-04-08 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, added new GTK+ test expectations.

  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png: Added.
  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.checksum: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.png: Added.
  • platform/gtk/fast/text/decorations-transformed-expected.txt: Added.
2:26 AM Changeset in webkit [83272] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

layoutTestController.shadowRoot should return undefined if its
argument is not an element.
​https://bugs.webkit.org/show_bug.cgi?id=58119

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
2:15 AM Changeset in webkit [83271] by mario@webkit.org
  • 5 edits in trunk

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implemented missing functions in GTK's DRT.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (modifyAccessibilityValue): Helper function to increment or decrement the current value for an object through the AccessibilityObject's API. (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function, to be used from GTK's DRT. (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implement missing functions in GTK's DRT.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::increment): Implemented. (AccessibilityUIElement::decrement): Implemented.
2:04 AM Changeset in webkit [83270] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

Make WK2 layoutTestController.shadowRoot return undefined, not
null, when its argument is not an element.
​https://bugs.webkit.org/show_bug.cgi?id=58121

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
1:47 AM Changeset in webkit [83269] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
​https://bugs.webkit.org/show_bug.cgi?id=54681

This a patch which should be landed when fix for exception handling in v8 is landed
(see ​http://codereview.chromium.org/6397011/)

  • platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
  • platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
12:53 AM Changeset in webkit [83268] by rniwa@webkit.org
  • 3 edits
    2 adds
    28 deletes in trunk/LayoutTests

2011-04-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
​https://bugs.webkit.org/show_bug.cgi?id=58074

Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.

  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html:
  • editing/pasteboard/display-block-on-spans-expected.txt: Added.
  • editing/pasteboard/display-block-on-spans.html:
  • platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.png: Removed.
  • platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
12:46 AM Changeset in webkit [83267] by Csaba Osztrogonác
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

[Qt] Add platform specific expected file after r83235.

  • platform/qt/http/tests/security/contentSecurityPolicy: Added.
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
12:38 AM Changeset in webkit [83266] by tkent@chromium.org
  • 9 edits
    8 adds
    1 delete in trunk/LayoutTests

2011-04-08 Kent Tamura <​tkent@chromium.org>

[Chromium] Update expectations for r82899 and r83253.

  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium/test_expectations.txt:
12:21 AM Changeset in webkit [83265] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Flaky Test: fast/events/tabindex-focus-blur-all.html
​https://bugs.webkit.org/show_bug.cgi?id=52115

  • platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.
12:05 AM Changeset in webkit [83264] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-08 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build.

  • css/CSSStyleApplyProperty.cpp:
12:00 AM Changeset in webkit [83263] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor WebCore/GNUMakefile.am to separate list of files
​https://bugs.webkit.org/show_bug.cgi?id=58116

This change is similar to the cooresponding to change to
JavaScriptCore. We hope to generate GNUmakefile.list.am automatically
using GYP.

  • GNUmakefile.am:
  • GNUmakefile.list.am: Added.
Note: See TracTimeline for information about the timeline view.