Timeline
May 1, 2011:
- 11:29 PM Changeset in webkit [85461] by
-
- 2 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Remove unadvertantly added file.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 11:18 PM Changeset in webkit [85460] by
-
- 3 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
expectedfailures.py should report the unexpected failures when asked
https://bugs.webkit.org/show_bug.cgi?id=59916
This information is useful when the EWS runs tests.
- Scripts/webkitpy/tool/bot/expectedfailures.py:
- Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
- 11:14 PM Changeset in webkit [85459] by
-
- 3 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JSONTestResult needs to handle multiple results
https://bugs.webkit.org/show_bug.cgi?id=59269
This case occurs when a test is flaky because NRWT will run the test
twice and report both results as "actual."
- Scripts/webkitpy/common/net/resultsjsonparser.py:
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
- 10:59 PM Changeset in webkit [85458] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Regression(r74787): Media document mouse click and double-click
events should be checked on target node only and not its descendants.
https://bugs.webkit.org/show_bug.cgi?id=59886
- html/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- 10:44 PM Changeset in webkit [85457] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2: Crash closing tab with docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>
Reviewed by Dan Bernstein.
When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.
This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.
- UIProcess/WebInspectorProxy.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- 10:21 PM Changeset in webkit [85456] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Strict-mode only reserved words not reserved
https://bugs.webkit.org/show_bug.cgi?id=55342
Fix line number tracking when we rollback the lexer.
- parser/JSParser.cpp: (JSC::JSParser::parseSourceElements):
- 9:51 PM Changeset in webkit [85455] by
-
- 4 edits in trunk
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295
Update for correct results
- fast/js/mozilla/strict/11.1.5-expected.txt:
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295
Simplify and correct the logic for strict mode object literals.
- parser/JSParser.cpp: (JSC::JSParser::parseStrictObjectLiteral):
- 7:57 PM Changeset in webkit [85454] by
-
- 6 edits in trunk
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289
Add test case for correct behaviour, and update mozilla test results to reflect
the correct result.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/mozilla/strict/assign-to-callee-name-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289
Add logic to StaticScopeObject to ensure we don't silently consume
writes to constant properties.
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put):
- 6:55 PM Changeset in webkit [85453] by
-
- 3 edits4 adds in trunk
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899
Test two host wildcard cases.
- http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html: Added.
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899
Finish last two details of host and port matching. I don't think the
default port handling is testable with our current testing
infrastructure.
Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSource::hostMatches): (WebCore::CSPSource::portMatches):
- 6:46 PM Changeset in webkit [85452] by
-
- 7 edits2 moves in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move checkout/api.py to checkout/checkout.py
https://bugs.webkit.org/show_bug.cgi?id=59906
This is more consistent with Python style.
- Scripts/webkitpy/common/checkout/init.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/tool/main.py:
- 6:44 PM Changeset in webkit [85451] by
-
- 4 edits6 adds in trunk
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641
Test that default-src controls some scripting policy and that
script-src, if present, overrides default-src. In principle, we could
test the interaction of default-src with every other directive, but
that seems like overkill.
- http/tests/security/contentSecurityPolicy/default-src-inline-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-overrides-default-src-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html: Added.
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641
Add support for default-src. The default-src provides a default policy
for every directive that sends in "-src". If the more-specific
directive is present, it takes precedence. I also took this
opportunity to refactor the internals of ContentSecurityPolicy a bit to
reduce duplicate code.
Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::checkEval): (WebCore::ContentSecurityPolicy::operativeDirective): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowInlineStyle): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 6:34 PM Changeset in webkit [85450] by
-
- 3 edits in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
scm.py should be split into many pieces
https://bugs.webkit.org/show_bug.cgi?id=59908
Forgot an AuthenticationError import.
- Scripts/webkitpy/common/checkout/scm/git.py:
- Scripts/webkitpy/common/checkout/scm/svn.py:
- 6:27 PM Changeset in webkit [85449] by
-
- 4 edits4 adds in trunk/Tools
2011-05-01 Arno Renevier <arno@renevier.net>
Reviewed by Eric Seidel.
wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283
raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 6:04 PM Changeset in webkit [85448] by
-
- 9 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer
Reviewed by Sam Weinig.
Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::label):
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):
- assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):
- 6:03 PM Changeset in webkit [85447] by
-
- 2 edits in trunk/Tools
2011-05-01 Arno Renevier <arno@renevier.net>
Reviewed by Eric Seidel.
wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283
raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 5:58 PM Changeset in webkit [85446] by
-
- 2 edits in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make most scm.py tests pass in preparation for splitting them up
https://bugs.webkit.org/show_bug.cgi?id=59904
There is one remaining failure:
webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
which identifies a difference between the SVN and Git versions of the
SCM api. I'm not going to bother fixing that until we split out all
the tests.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- 5:33 PM Changeset in webkit [85445] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
- wtf/OwnPtr.h:
- 5:19 PM Changeset in webkit [85444] by
-
- 2 edits in trunk/Source/WebKit/win
Fix windows build.
- WebFrame.cpp:
- 5:15 PM Changeset in webkit [85443] by
-
- 2 edits in trunk/Tools
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85440.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
- 4:56 PM Changeset in webkit [85442] by
-
- 20 edits in trunk/Source
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.h:
- bindings/js/ScheduledAction.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptDebugServer.cpp:
- editing/Editor.h:
- inspector/InspectorClient.cpp:
- loader/FrameLoader.h:
- loader/NavigationScheduler.h:
- page/Console.cpp:
- xml/XMLTreeViewer.cpp:
- xml/XMLTreeViewer.h:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 4:53 PM Changeset in webkit [85441] by
-
- 3 edits in trunk/Tools
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
- DumpRenderTree/win/UIDelegate.cpp: Ditto.
- 4:44 PM Changeset in webkit [85440] by
-
- 5 edits in trunk
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- WebView.cpp: (WebView::paint):
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
- DumpRenderTree/win/UIDelegate.cpp: (DRTUndoManager::DRTUndoManager): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager):
- 4:29 PM Changeset in webkit [85439] by
-
- 5 edits in trunk/Source/WebKit2
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::startDragDrop):
- UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: (WebKit::WebDragClient::startDrag):
- WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
- 4:09 PM Changeset in webkit [85438] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie):
- 3:53 PM Changeset in webkit [85437] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
- 3:45 PM Changeset in webkit [85436] by
-
- 3 edits5 moves2 adds in trunk
2011-05-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840
- fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt: Added.
- fast/loader/stateobjects/pushstate-in-data-url-denied.html: Added.
- fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Removed.
- fast/loader/stateobjects/replacestate-base-illegal.html: Removed.
- fast/loader/stateobjects/replacestate-base-legal-expected.txt: Removed.
- fast/loader/stateobjects/replacestate-base-legal.html: Removed.
- fast/loader/stateobjects/resources/replacestate-base-pass.html: Removed.
- http/tests/navigation/replacestate-base-illegal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal-expected.txt.
- http/tests/navigation/replacestate-base-illegal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal.html.
- http/tests/navigation/replacestate-base-legal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal-expected.txt.
- http/tests/navigation/replacestate-base-legal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal.html.
- http/tests/navigation/resources/replacestate-base-pass.html: Copied from LayoutTests/fast/loader/stateobjects/resources/replacestate-base-pass.html.
2011-05-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840
Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
http/tests/navigation/replacestate-base-illegal.html
http/tests/navigation/replacestate-base-legal.html
- page/History.cpp: (WebCore::History::stateObjectAdded):
- 3:42 PM Changeset in webkit [85435] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext):
- 3:30 PM Changeset in webkit [85434] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Enable strict OwnPtr for PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=59881
- wtf/OwnPtr.h:
- 3:28 PM Changeset in webkit [85433] by
-
- 7 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
[WINCE] Fix OwnPtr strict issues
https://bugs.webkit.org/show_bug.cgi?id=59898
- page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
- platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontData::create): (WebCore::FontPlatformPrivateData::FontPlatformData::hfont): (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle): (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner): (WebCore::GraphicsContext::drawText):
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
- platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::SharedBitmap):
- 3:20 PM Changeset in webkit [85432] by
-
- 15 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.
Reviewed by Sam Weinig.
The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).
Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::patch):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):
- assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):
- 2:15 PM Changeset in webkit [85431] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Can't open document from skydrive.com in Microsoft Word
https://bugs.webkit.org/show_bug.cgi?id=59891
<rdar://problem/9354285>
Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks):
- 1:47 PM Changeset in webkit [85430] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't try to create a backing store for a 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=59887
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
- 1:26 PM Changeset in webkit [85429] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-05-01 Chao-ying Fu <fu@mips.com>
Reviewed by Eric Seidel.
Fix MIPS build due to the split of "Condition" enum
https://bugs.webkit.org/show_bug.cgi?id=59407
- assembler/MIPSAssembler.h: (JSC::MIPSAssembler::debugOffset):
- assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::compare32):
- 12:46 PM Changeset in webkit [85428] by
-
- 6 edits in trunk/Source
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
- WebCore.exp.in:
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
- WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
- 12:20 PM Changeset in webkit [85427] by
-
- 2 edits2 moves2 adds in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move scm.py into its own module in preparation for splitting it up
https://bugs.webkit.org/show_bug.cgi?id=59884
- Scripts/webkitpy/common/checkout/scm/init.py: Added.
- Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
- Scripts/webkitpy/test/main.py:
- 12:15 PM Changeset in webkit [85426] by
-
- 2 edits in trunk
2011-05-01 ojab <ojab@ojab.ru>
Reviewed by Eric Seidel.
--disable-video-track if --disable-video
https://bugs.webkit.org/show_bug.cgi?id=59605
- configure.ac:
- 12:10 PM Changeset in webkit [85425] by
-
- 6 edits in trunk/Source
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835
Moved currentKeyboardEvent.
- WebCore.exp.in:
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835
Moved currentKeyboardEvent.
- WebView/WebHTMLView.mm: (currentKeyboardEvent): (-[WebHTMLView becomeFirstResponder]):
- 11:58 AM Changeset in webkit [85424] by
-
- 2 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch fails when not run from root
https://bugs.webkit.org/show_bug.cgi?id=59882
We need to set the CWD when running svn so that svn interprets file
paths relative to the root of the working copy.
- Scripts/webkitpy/common/checkout/scm.py:
- 11:42 AM Changeset in webkit [85423] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 ojab <ojab@ojab.ru>
Reviewed by Eric Seidel.
Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=59698
- rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet):
- 11:35 AM Changeset in webkit [85422] by
-
- 3 edits in trunk/Source/WebCore
2011-05-01 Jeff Timanus <twiz@chromium.org>
Reviewed by Eric Seidel.
Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
https://bugs.webkit.org/show_bug.cgi?id=59041
Test:css2.1/t140201-c533-bgimage-00-a.html
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
- 11:02 AM Changeset in webkit [85421] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Sandbox violation by WebProcess for DownloadAssessment.plist
https://bugs.webkit.org/show_bug.cgi?id=59879
<rdar://problem/9326041>
- WebProcess/com.apple.WebProcess.sb: Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist
- 10:47 AM Changeset in webkit [85420] by
-
- 13 edits in trunk/Source
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
- platform/graphics/win/WKCAImageQueue.cpp: (WebCore::WKCAImageQueue::WKCAImageQueue):
- platform/win/CursorWin.cpp: (WebCore::createSharedCursor):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
- FullscreenVideoController.cpp: (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::createHUDWindow):
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight):
- WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag):
- WebNodeHighlight.cpp: (WebNodeHighlight::update):
- WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter):
- WebView.cpp: (WebView::close): (WebView::paint): (WebView::handleMouseEvent): (WebView::registerEmbeddedViewMIMEType):
- 10:43 AM Changeset in webkit [85419] by
-
- 5 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
https://bugs.webkit.org/show_bug.cgi?id=59876
Also pass the size "as reference" instead of "as value".
- platform/graphics/GraphicsContext.h:
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::paint):
- 10:30 AM Changeset in webkit [85418] by
-
- 3 edits2 adds in trunk
2011-05-01 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111
Add test to verify that getComputedStyle returns length properties with a unit.
- fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-length-unit.html: Added.
2011-05-01 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111
Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 10:25 AM Changeset in webkit [85417] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Young Han Lee <joybro@company100.net>
Reviewed by Eric Seidel.
Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
https://bugs.webkit.org/show_bug.cgi?id=59608
TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
No new functionality, no new tests.
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::TextureMapperGL):
- 10:08 AM Changeset in webkit [85416] by
-
- 3 edits2 adds in trunk
2011-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943
- fast/css/nth-child-n-expected.txt: Added.
- fast/css/nth-child-n.html: Added.
2011-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943
Regression from r75158.
"n" is a valid parameter to nth() and should be allowed.
Test: fast/css/nth-child-n.html
- css/CSSParser.cpp: (WebCore::isValidNthToken):
- 9:09 AM Changeset in webkit [85415] by
-
- 3 edits in trunk/Source/WebCore
2011-05-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: address stack frame scriptName -> url rename in timeline panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- 9:07 AM Changeset in webkit [85414] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Chris Fleizach <Chris Fleizach>
Reviewed by Maciej Stachowiak.
Crash in AccessibilityRenderObject while viewing PDFs in iframes
https://bugs.webkit.org/show_bug.cgi?id=59629
Could not reproduce this crash, but it's quite clear how it could happen.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityHitTest):
- 7:38 AM Changeset in webkit [85413] by
-
- 14 edits6 adds in trunk
2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072
Add testcase that used to leak, the leaks bot will assure they won't in future.
- svg/custom/pending-resource-leak-2-expected.txt: Added.
- svg/custom/pending-resource-leak-2.svg: Added.
- svg/custom/pending-resource-leak-3-expected.txt: Added.
- svg/custom/pending-resource-leak-3.svg: Added.
- svg/custom/pending-resource-leak-expected.txt: Added.
- svg/custom/pending-resource-leak.svg: Added.
2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072
Make the pending resources set non-refcounted again. We made it refcounted a while ago
to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
Fix the underlying problem, by removing all pending resources referencing to a particular
SVGElement, upon its destruction or upon removing it from the document.
Example: <rect fill="url(#foo)" id="rect">
When we try to render the rect, the foo paint server can't be found and thus "foo" will be
added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
itself from the pending resource set, and a ref count to the "rect" would be released.
If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
it and the associated document alive.
Tests: svg/custom/pending-resource-leak-2.svg
svg/custom/pending-resource-leak-3.svg
svg/custom/pending-resource-leak.svg
These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
- rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
- rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
- rendering/svg/SVGResources.cpp: (WebCore::registerPendingResource):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::hasPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
- svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::hasPendingResources): (WebCore::SVGElementRareData::setHasPendingResources):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::removedFromDocument): (WebCore::SVGStyledElement::hasPendingResources): (WebCore::SVGStyledElement::setHasPendingResources):
- svg/SVGStyledElement.h: (WebCore::SVGStyledElement::needsPendingResourceHandling): (WebCore::SVGStyledElement::buildPendingResource):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildPendingResource):
- svg/SVGUseElement.h:
- 7:12 AM Changeset in webkit [85412] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] build-webkit warning Inspector.idl is missing
https://bugs.webkit.org/show_bug.cgi?id=59047
Added variable_out to pipe output from one compiler to another,
and then forced the output to be added to the sources.
- CodeGenerators.pri:
- 2:19 AM Changeset in webkit [85411] by
-
- 5 edits3 adds in trunk
<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
https://bugs.webkit.org/show_bug.cgi?id=56658
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/text/selection-rect-rounding.html
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText): Ditto.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.
LayoutTests:
- fast/text/selection-rect-rounding.html: Added.
- platform/mac/fast/text/selection-rect-rounding-expected.png: Added.
- platform/mac/fast/text/selection-rect-rounding-expected.txt: Added.
- 1:09 AM Changeset in webkit [85410] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=59873
These rules have been obsoleted by <rdar://problem/9301520> and
<rdar://problem/9181468>.
- WebProcess/com.apple.WebProcess.sb:
- 12:45 AM Changeset in webkit [85409] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Simplify WebProcess sandbox with homedir-relative path filters.
https://bugs.webkit.org/show_bug.cgi?id=59872
- WebProcess/com.apple.WebProcess.sb:
- 12:28 AM Changeset in webkit [85408] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
On-demand VPN support for sandboxed WebProcess.
<rdar://problem/8994181>
- WebProcess/com.apple.WebProcess.sb:
- 12:10 AM Changeset in webkit [85407] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-30 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Reindent WebProcess sandbox to standard scheme style
https://bugs.webkit.org/show_bug.cgi?id=59870
- WebProcess/com.apple.WebProcess.sb:
Apr 30, 2011:
- 9:17 PM Changeset in webkit [85406] by
-
- 4 edits2 adds in trunk
2011-04-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Make RenderSVGResourceFilter take ownership of filter data when painting
https://bugs.webkit.org/show_bug.cgi?id=51524
- svg/custom/filter-on-svgimage-expected.txt: Added.
- svg/custom/filter-on-svgimage.svg: Added.
2011-04-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Make RenderSVGResourceFilter take ownership of filter data when painting
https://bugs.webkit.org/show_bug.cgi?id=51524
Test: svg/custom/filter-on-svgimage.svg
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/svg/RenderSVGResourceFilter.h: (WebCore::FilterData::FilterData):
- 9:16 PM Changeset in webkit [85405] by
-
- 18 edits in trunk/Source
2011-04-30 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for GTK
https://bugs.webkit.org/show_bug.cgi?id=59861
- wtf/OwnPtr.h:
2011-04-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
factory methods return a PassOwnPtr.
No new tests. This should not change functionality.
- platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull): (WebCore::GeolocationService::create):
- platform/GeolocationService.h:
- platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::create):
- platform/android/GeolocationServiceAndroid.h:
- platform/efl/GeolocationServiceEfl.cpp: (WebCore::GeolocationServiceEfl::create):
- platform/efl/GeolocationServiceEfl.h:
- platform/graphics/cairo/CairoUtilities.cpp: (WebCore::appendPathToCairoContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): (WebCore::GraphicsContext::clip):
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cairo/OwnPtrCairo.h:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::apply):
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
- platform/gtk/GeolocationServiceGtk.h:
- platform/mock/GeolocationServiceMock.cpp: (WebCore::GeolocationServiceMock::create):
- platform/mock/GeolocationServiceMock.h:
- 6:05 PM Changeset in webkit [85404] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARMv7 build fix.
- assembler/AssemblerBufferWithConstantPool.h:
- 4:59 PM Changeset in webkit [85403] by
-
- 16 edits in trunk/Source/JavaScriptCore
Bug 59869 - AssemblerBuffer cleanup - disambiguate size()
Reviewed by Oliver Hunt.
The method size() is called on the AssemblerBuffer both to acquire
the complete size of the code, and to get a position to use as a
label into the code. Instead, add an explicit 'label' method.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::codeSize):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::data):
- assembler/AbstractMacroAssembler.h:
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::codeSize):
(JSC::MIPSAssembler::relocateJumps):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::executableCopy):
(JSC::SH4Assembler::oneShortOp):
(JSC::SH4Assembler::codeSize):
- assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::codeSize):
(JSC::X86Assembler::X86InstructionFormatter::label):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
- 1:05 PM Component Model edited by
- (diff)
- 10:34 AM BuildingGtk edited by
- (diff)
- 8:29 AM Changeset in webkit [85402] by
-
- 2 edits in trunk/Source/WebCore
2011-04-30 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector toolbar titles were 2px off.
- inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):
- 5:18 AM Changeset in webkit [85401] by
-
- 2 edits in trunk/LayoutTests
Skip another test that requires layoutTestController.setAlwaysAcceptCookies on mac-wk2
<http://webkit.org/b/42778> tracks implementing this feature.
- platform/mac-wk2/Skipped: Added
http/tests/xmlhttprequest/cross-origin-cookie-storage.html.
- 5:16 AM Changeset in webkit [85400] by
-
- 2 edits in trunk/LayoutTests
Skip another test that requires eventSender.keyDown on mac-wk2
<http://webkit.org/b/42194> tracks implementing this feature.
- platform/mac-wk2/Skipped: Added plugins/keyboard-events.html.
- 5:14 AM Changeset in webkit [85399] by
-
- 2 edits in trunk/LayoutTests
Skip another test that requires layoutTestController.overridePreference on mac-wk2
<http://webkit.org/b/42197> tracks implementing this feature.
- platform/mac-wk2/Skipped: Added fast/canvas/webgl/framebuffer-object-attachment.html.
- 5:01 AM Changeset in webkit [85398] by
-
- 2 edits in trunk/LayoutTests
Skip a failing test on mac-wk2
I can't check in expected failure results because the results are slightly different each
time.
<http://webkit.org/b/59865> tracks the failure.
- platform/mac-wk2/Skipped: Added transitions/transition-timing-function.html.
- 5:01 AM Changeset in webkit [85397] by
-
- 2 edits in trunk/LayoutTests
Skip a flaky test on mac-wk2
<http://webkit.org/b/58990> tracks the failure.
- platform/mac-wk2/Skipped: Added editing/undo/undo-iframe-location-change.html.
- 5:01 AM Changeset in webkit [85396] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove mac-wk2 expected failure results for an animation test
Looks like this started passing in r85340. (I hope it wasn't because animation-api-1.html,
which is now skipped, was causing this one to fail!)
Fixes <http://webkit.org/b/56528> <rdar://problem/9147568> REGRESSION (r80846):
animations/animation-controller-drt-api.html failing in WebKit2
- platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Removed.
- 2:24 AM Changeset in webkit [85395] by
-
- 15 edits in trunk/Source
2011-04-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
V8Proxy.h shouldn't include SecurityOrigin.h
https://bugs.webkit.org/show_bug.cgi?id=59859
Remove SecurityOrigin.h #include from V8Proxy.h. Touching
SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
chromium's DumpRenderTree).
- bindings/v8/NPV8Object.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- css/CSSStyleSelector.cpp:
- dom/XMLDocumentParserLibxml2.cpp:
- html/HTMLLinkElement.cpp:
- loader/SubframeLoader.cpp:
- page/History.cpp:
- storage/IDBFactory.cpp:
- storage/StorageAreaImpl.cpp:
2011-04-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
V8Proxy.h shouldn't include SecurityOrigin.h
https://bugs.webkit.org/show_bug.cgi?id=59859
Add SecurityOrigin.h includes to places that were relying on transitive
includes.
- src/ApplicationCacheHost.cpp:
- src/WebGeolocationPermissionRequest.cpp:
- 1:13 AM Changeset in webkit [85394] by
-
- 2 edits in trunk/LayoutTests
[Qt] Add one more flakey test to the Skipped list.
- platform/qt-mac/Skipped:
- 1:11 AM Changeset in webkit [85393] by
-
- 5 edits2 adds in trunk/Source/WebKit/win
2011-04-29 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Implement FULLSCREEN_API on Windows, Part 2: WebKit
https://bugs.webkit.org/show_bug.cgi?id=59785
Initial implementation of full screen API on windows. No animation
occurs when entering or exiting full screen. Re-use existing window
classes (MediaPlayerPrivateFullscreenWindow) to host the webView.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::supportsFullScreenForElement): Call into WebView. (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController. (WebChromeClient::exitFullScreenForElement): Ditto.
- WebFullScreenController.cpp: Added. (WebFullScreenController::Private::Private): Private data storage class. (WebFullScreenController::Private::~Private): (WebFullScreenController::Private::fullscreenClientWndProc): Handle window
message for full screen window.
(WebFullScreenController::WebFullScreenController):
(WebFullScreenController::~WebFullScreenController):
(WebFullScreenController::setElement): Added.
(WebFullScreenController::element): Added.
(WebFullScreenController::isFullScreen): Added.
(WebFullScreenController::enterFullScreen): Create and display full screen
window, moving webView as child window.
(WebFullScreenController::exitFullScreen): Destroy full screen window and
move webView back where we found it.
- WebFullScreenController.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- WebView.cpp: (WebView::keyDown): Handle the ESC key. (WebView::notifyPreferencesChanged): (WebView::supportsFullScreenForElement): Do not support full screen if
full screen preference is disabled, or if keyboard access is requested.
(WebView::isFullScreen): Added.
(WebView::fullScreenController): Added.
- WebView.h:
