Timeline
May 2, 2011:
- 11:04 PM Changeset in webkit [85586] by
-
- 3 edits2 adds in trunk
2011-05-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Possible crash when removing elements with reflections
https://bugs.webkit.org/show_bug.cgi?id=60009
RenderLayer's destructor deleted its z-order list Vector pointers
before removing the reflection layer. However, the reflection cleanup
code could call back into the RenderLayer to dirty z-order lists,
so move reflection cleanup to before z-order vector deletion.
The test crashes when run manually a few times with MallocScribble enabled,
but I was not able to create a test that crashed reliably.
Test: fast/reflections/remove-reflection-crash.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
- 10:07 PM Changeset in webkit [85585] by
-
- 3 edits2 adds in trunk
2011-05-02 Ian Henderson <ianh@apple.com>
Reviewed by Dan Bernstein.
CSS !important not respected by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=60007
- fast/css/important-js-override-expected.txt: Added.
- fast/css/important-js-override.html: Added.
2011-05-02 Ian Henderson <ianh@apple.com>
Reviewed by Dan Bernstein.
CSS !important not respected by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=60007
The addParsedProperty and addParsedProperties methods were subtly
different. The former did not check for !important before setting the
given property.
Change addParsedProperties to call addParsedProperty and move the
relevant code. The one other caller of this method, in
editing/markup.cpp, probably wanted this behavior anyway.
Test: fast/css/important-js-override.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
- 10:02 PM Changeset in webkit [85584] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] White screen displays when using MiniBrowser with DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=60003
When using DrawingAreaImpl, we need to properly pass the viewSize to the WebPage.
Otherwise, the dirty rect will always be empty and we will not draw.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::viewSize):
- 9:45 PM Changeset in webkit [85583] by
-
- 2 edits in trunk/Tools
2011-05-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Compiler warning in Tools/MiniBrowser/main.c
https://bugs.webkit.org/show_bug.cgi?id=59986
Remove a compiler warning.
- MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers from complaining.
- 9:03 PM Changeset in webkit [85582] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Fix Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 9:03 PM Changeset in webkit [85581] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-05-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Style error fix.
- WebCoreSupport/ChromeClientEfl.cpp:
- 8:57 PM Changeset in webkit [85580] by
-
- 1 edit28 adds in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
New baselines for SVG tests for Chromium Leopard build.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
- 8:54 PM Changeset in webkit [85579] by
-
- 1 edit2 deletes in trunk/LayoutTests
2011-05-02 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r85578.
http://trac.webkit.org/changeset/85578
https://bugs.webkit.org/show_bug.cgi?id=59976
The test needs more lovin'. Voluntary rollout.
- media/video-document-click-expected.txt: Removed.
- media/video-document-click.html: Removed.
- 7:28 PM Changeset in webkit [85578] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-05-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Add layout tests for clicking in media documents.
https://bugs.webkit.org/show_bug.cgi?id=59976
- media/video-document-click-expected.txt: Added.
- media/video-document-click.html: Added.
- 7:22 PM Changeset in webkit [85577] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Ben Wells <benwells@chromium.org>
Reviewed by Simon Fraser.
Cleanup variable usage in RenderObject.cpp paintOutline()
https://bugs.webkit.org/show_bug.cgi?id=59911
No new tests for this, there should be no change in behaviour.
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
- 7:03 PM Changeset in webkit [85576] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash that was introduced in r85515.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
If didReceiveSyncMessage returns ManualReply, the client took ownership of the reply
encoder so we must leak it to avoid a double-free.
- 7:00 PM Changeset in webkit [85575] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove an assertion that Windows was hitting on launch.
Rubber-stamped by Oliver Hunt.
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
- runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):
- 6:51 PM Changeset in webkit [85574] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: adding and removing values
https://bugs.webkit.org/show_bug.cgi?id=59953
- storage/indexeddb/mozilla/object-store-remove-values-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-remove-values.html: Added.
- 6:48 PM Changeset in webkit [85573] by
-
- 6 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
The web process locks up when the plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=59999
<rdar://problem/8889303>
Add a hash map from plug-in paths to CoreIPC connections to PluginProcessConnectionManager.
Add PluginProcessConnectionManager::pluginProcessCrashed and make it look up the corresponding
CoreIPC connection and call postConnectionDidCloseOnConnectionWorkQueue on it.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
- Platform/CoreIPC/Connection.h:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): (WebKit::PluginProcessConnectionManager::removePluginProcessConnection): (WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed):
- 6:46 PM Changeset in webkit [85572] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by James Robinson.
REGRESSION(r84672): showTree doesn't work for input/textarea elements
https://bugs.webkit.org/show_bug.cgi?id=60001
When shadow is null, try retrieving the inner element of a render text control.
- dom/Node.cpp: (WebCore::traverseTreeAndMark):
- 6:34 PM Changeset in webkit [85571] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix Windows build.
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
- 6:19 PM Changeset in webkit [85570] by
-
- 4 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Dispatch the PluginProcessCrashed on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59996
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Add the web process as a queue client.
(WebKit::WebProcess::terminate):
Remove the web process as a queue client.
(WebKit::WebProcess::willProcessMessageOnClientRunLoop):
Try calling willProcessWebProcessMessageOnClientRunLoop.
- WebProcess/WebProcess.messages.in: Add the DispatchOnConnectionQueue attribute to PluginProcessCrashed.
- 6:12 PM Changeset in webkit [85569] by
-
- 5 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Send a PluginProcessCrashed message to all web processes when a plug-in crashes
https://bugs.webkit.org/show_bug.cgi?id=59994
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose): Iterate over all contexts and send PluginProcessCrashed to all web processes in each context.
(WebKit::PluginProcessProxy::didFinishLaunching):
Call setShouldCloseConnectionOnMachExceptions on the CoreIPC connection.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed): Add empty stub.
- WebProcess/WebProcess.messages.in: Add message.
- 6:04 PM Changeset in webkit [85568] by
-
- 2 edits in trunk/Source/JavaScriptCore
<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2
Reviewed by Geoff Garen.
- Configurations/CompilerVersion.xcconfig:
- 6:02 PM Changeset in webkit [85567] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Plug-in not completely repainted after a crash
https://bugs.webkit.org/show_bug.cgi?id=59991
Call Widget::invalidate().
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginProcessCrashed):
- 5:53 PM Changeset in webkit [85566] by
-
- 5 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make PluginProcessConnectionManager a member of WebProcess
https://bugs.webkit.org/show_bug.cgi?id=59989
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):
- WebProcess/WebProcess.h: (WebKit::WebProcess::pluginProcessConnectionManager):
- 5:43 PM Changeset in webkit [85565] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Expectation for new test.
- platform/chromium/test_expectations.txt:
- 5:36 PM Changeset in webkit [85564] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item index when URLs are filtered from back/forward list
Reviewed by Brady Eidson.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): We need to update the current index to account for filtered items
for all items before the current item in the array.
- 5:28 PM Changeset in webkit [85563] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 5:26 PM Changeset in webkit [85562] by
-
- 2 edits2 copies in branches/chromium/742
Merge 85335
BUG=80255
Review URL: http://codereview.chromium.org/6913012
- 5:24 PM Changeset in webkit [85561] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARMv7 build fix.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
- 5:20 PM Changeset in webkit [85560] by
-
- 3 edits3 adds in trunk
2011-05-02 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825
Placeholder text does not appear in the render tree
dumps, so this is a pixel test for the position of
the placeholder affected by text-indent.
- fast/forms/input-placeholder-text-indent.html: Added.
- platform/mac/fast/forms/input-placeholder-text-indent-expected.png: Added.
- platform/mac/fast/forms/input-placeholder-text-indent-expected.txt: Added.
2011-05-02 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825
Test: fast/forms/input-placeholder-text-indent.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): indent by a fixed text-indent size specified on the placeholder style.
- 5:17 PM Changeset in webkit [85559] by
-
- 2 edits2 copies in branches/chromium/696
Merge 84085
BUG=79595
- 5:14 PM Changeset in webkit [85558] by
-
- 4 edits16 copies in branches/chromium/742
Merge 85355
BUG=79075
Review URL: http://codereview.chromium.org/6913011
- 5:12 PM Changeset in webkit [85557] by
-
- 4 edits16 copies in branches/chromium/696
Merge 85355
BUG=79075
- 5:10 PM Changeset in webkit [85556] by
-
- 6 edits in trunk
2011-05-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by Eric Seidel.
Some FileWriter progress events should be queued
https://bugs.webkit.org/show_bug.cgi?id=50846
- fileapi/FileWriter.cpp:
- fileapi/FileWriter.h: Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
2011-05-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by Eric Seidel.
Some FileWriter progress events should be queued
https://bugs.webkit.org/show_bug.cgi?id=50846
- fast/filesystem/resources/file-writer-events.js: (onWrite): Expect readyState at onwrite to be DONE now, not WRITING.
- fast/filesystem/resources/file-writer-utils.js: Switch to using onwrite, now that it works.
- 4:57 PM Changeset in webkit [85555] by
-
- 1 edit2 copies in branches/chromium/696
Merge 84300
BUG=79055
- 4:51 PM Changeset in webkit [85554] by
-
- 1 edit4 copies in branches/chromium/696
Merge 83690
BUG=78948
- 4:51 PM Changeset in webkit [85553] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: cursor mutation in object store
https://bugs.webkit.org/show_bug.cgi?id=59933
This is a test case *adapted* from a test in Mozilla's IndexedDB
test suite. The original test checked cursor mutation while iterating
an index cursor (tracked as bug 59822). This test checks whether the
cursor mutation is successfully recognized while iterating a straight
objectstore cursor. Specifically, it deletes a record that's already
been iterated, then adds a record to the objectstore during iteration,
then checks that no records were skipped and that the added record is
eventually found during iteration.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html: Added.
- 4:44 PM Changeset in webkit [85552] by
-
- 4 edits in branches/chromium/742
Merge 84919 - 2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111
Added a test to move left and right within Arabic numerals and Arabic letters.
We still fail to set the position offset properly when we moving to the left from before B
to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
and numerals respectively. This bug is to be fixed in the followup bugs.
- editing/selection/move-left-right-expected.txt:
- editing/selection/move-left-right.html:
2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111
Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.
The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.
Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 123 CBA abc to 123 CBA abc (there is no offset between 3 and C).
Test cases are added to editing/selection/move-left-right.html
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
Review URL: http://codereview.chromium.org/6911017
- 4:43 PM Changeset in webkit [85551] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Jia Pu <jpu@apple.com>
Reviewed by Alexey Proskuryakov.
[Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
https://bugs.webkit.org/show_bug.cgi?id=59836
<rdar://problem/9275983>
- platform/DefaultLocalizationStrategy.cpp: (WebCore::truncatedStringForLookupMenuItem): (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
- 4:42 PM Changeset in webkit [85550] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- 4:41 PM Changeset in webkit [85549] by
-
- 6 edits in trunk/Source
<rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
In Aperture, a WebView might be dealloc'ed before it finishes loading.
Reviewed by Anders Carlsson.
../WebCore:
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
- platform/RuntimeApplicationChecks.h:
../WebKit/mac:
- WebView/WebView.mm:
(needsSelfRetainWhileLoadingQuirk):
(-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
(-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
(-[WebView _didFailLoadWithError:forFrame:]): Ditto.
(-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
- 4:40 PM Changeset in webkit [85548] by
-
- 1 edit1 add in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add runtests_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=59955
I forgot to add this file in a previous patch.
- Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
- 4:38 PM Changeset in webkit [85547] by
-
- 1 edit2 copies in branches/chromium/742
Merge 84422
BUG=78327
Review URL: http://codereview.chromium.org/6909014
- 4:36 PM Changeset in webkit [85546] by
-
- 1 edit2 copies in branches/chromium/696
Merge 84422
BUG=78327
- 4:28 PM Changeset in webkit [85545] by
-
- 3 edits in trunk/LayoutTests
Update Qt specific expected result after r85499.
- platform/qt/fast/replaced/table-percent-height-expected.png:
- platform/qt/fast/replaced/table-percent-height-expected.txt:
- 4:25 PM Changeset in webkit [85544] by
-
- 2 edits2 copies in branches/chromium/742
Merge 85406
BUG=67923
Review URL: http://codereview.chromium.org/6907011
- 4:23 PM Changeset in webkit [85543] by
-
- 2 edits2 copies in branches/chromium/696
Merge 85406
BUG=67923
- 4:22 PM Changeset in webkit [85542] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Test expectation for new test.
- platform/chromium/test_expectations.txt:
- 4:19 PM Changeset in webkit [85541] by
-
- 5 edits in trunk
2011-05-02 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
crash in JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=58922
New tests to check for proper clearing and chaining of backtrack
data labels.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
2011-05-02 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
crash in JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=58922
Cleared chained backtrack data label when linking label even if that
label doesn't chain itself. This is needed so that subsequent
backtrack data labels point to the next outer paren and not within
the current paren.
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
- 4:18 PM Changeset in webkit [85540] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Avoid wasted cycles updating paths when popping the context stack
https://bugs.webkit.org/show_bug.cgi?id=59967
CanvasRenderingContext2D has to map the current path through
transforms whenever the context stack is popped, which creates
a lot of platform path objects. Avoid extra work here when the
path is empty, or when the transform is identity.
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
- 4:13 PM Changeset in webkit [85539] by
-
- 8 edits in trunk/LayoutTests
2011-05-02 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline small scrollbar image differences after r85527
https://bugs.webkit.org/show_bug.cgi?id=58907
This could be tickling the same bug that is showing up in bug 58587.
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 4:12 PM Changeset in webkit [85538] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Fix Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 4:05 PM Changeset in webkit [85537] by
-
- 2 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Change the testing EWS to log failures explicitly to avoid an infinite loop.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- 4:04 PM Changeset in webkit [85536] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Fix Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 3:46 PM Changeset in webkit [85535] by
-
- 3 edits2 adds in trunk
Text does not split on white space when typing to the edge of window.
https://bugs.webkit.org/show_bug.cgi?id=59968
<rdar://problem/9112683>
Reviewed by Dan Bernstein.
Source/WebCore:
Test: editing/inserting/typing-at-end-of-line.html
This is a regression introduced when we converted the line box tree to
floating point in r78846. In findNextLineBreak, there was still one place where
the character width was treated as int and truncated and we were inconsistent
in the way we treated a character that did not fit entirely in the line.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
LayoutTests:
- editing/inserting/typing-at-end-of-line.html: Added.
- platform/mac/editing/inserting/typing-at-end-of-line-expected.txt: Added.
- 3:40 PM Changeset in webkit [85534] by
-
- 2 edits1 add in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Test expectations for Chromium Mac port.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:38 PM Changeset in webkit [85533] by
-
- 3 edits in trunk/Source/JavaScriptCore
Tiny bit of heap cleanup.
Reviewed by Oliver Hunt.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::contains): Tightened up an assertion and a comment.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Moved inlines out of the class
definition, for better clarity.
- 3:37 PM Changeset in webkit [85532] by
-
- 1 edit4 deletes in trunk/LayoutTests
2011-05-02 Tony Chang <tony@chromium.org>
Remove unused files.
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed. This file differs from
the value in the png file, but I assume that the png is correct (more recently generated).
- platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Removed.
- platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Removed.
- platform/mac/fast/table/multiple-captions-display-expected.checksum: Removed.
- 3:30 PM Changeset in webkit [85531] by
-
- 2 edits in trunk/Tools
2011-05-02 Adrienne Walker <enne@google.com>
Unreviewed, fix misspelled contributor name.
- Scripts/webkitpy/common/config/committers.py:
- 3:28 PM Changeset in webkit [85530] by
-
- 1 edit7 copies5 deletes in branches/chromium/742
Merge 85436
BUG=75696
Review URL: http://codereview.chromium.org/6911011
- 3:23 PM Changeset in webkit [85529] by
-
- 3 edits in trunk/LayoutTests
Update Qt specific expected result after r85499.
- platform/qt/fast/replaced/table-percent-height-expected.png:
- platform/qt/fast/replaced/table-percent-height-expected.txt:
- 3:20 PM Changeset in webkit [85528] by
-
- 4 edits in trunk/LayoutTests
2011-05-02 Chang Shu <cshu@webkit.org>
Reviewed by Martin Robinson.
[GTK][Qt] fast/events/keydown-1.html fails
https://bugs.webkit.org/show_bug.cgi?id=59586
Replace mac-specific keys with cross-platform keys to make the test
pass on GTK and Qt platforms.
- fast/events/keydown-1.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:13 PM Changeset in webkit [85527] by
-
- 5 edits4 adds in trunk
2011-04-27 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add test for multiple invalidations of the same size.
https://bugs.webkit.org/show_bug.cgi?id=58907
This tests a bug in Chromium where canvas state was not being properly
reset between draw calls and a cached canvas of the same size was
being used to paint into that retained incorrect state.
- compositing/repaint/same-size-invalidation-expected.txt: Added.
- compositing/repaint/same-size-invalidation.html: Added.
- platform/chromium-gpu/compositing/repaint/same-size-invalidation-expected.png: Added.
2011-04-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
https://bugs.webkit.org/show_bug.cgi?id=58907
Additionally, move the context save/restore logic to a place where it
will reset the translation added in LayerTilerChromium.
Test: compositing/repaint/same-size-invalidation.html
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):
- platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
- platform/graphics/chromium/PlatformCanvas.h:
- 3:04 PM Changeset in webkit [85526] by
-
- 2 edits in trunk/Source/WebCore
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
Unreviewed buildfix after r85343.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 2:55 PM Changeset in webkit [85525] by
-
- 21 edits41 adds1 delete in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Add test expectations for SVG changes.
- platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
- platform/chromium-mac-leopard/editing/style/5046875-1-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png: Added.
- platform/chromium-mac/editing/selection/3690703-expected.png: Added.
- platform/chromium-mac/editing/selection/3690719-expected.png: Added.
- platform/chromium-mac/editing/selection/4975120-expected.png: Added.
- platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
- platform/chromium-mac/editing/style/5046875-1-expected.png: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Added.
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
- platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
- platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
- platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
- platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
- platform/chromium/test_expectations.txt:
- 2:43 PM Changeset in webkit [85524] by
-
- 6 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
cr-linux-ews should run tests
https://bugs.webkit.org/show_bug.cgi?id=59272
This patch turns on testing for the cr-linux-ews. Yay!
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 2:36 PM Changeset in webkit [85523] by
-
- 8 edits in trunk/Source/JavaScriptCore
2011-05-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Correct marking of interpreter data in mixed mode builds
https://bugs.webkit.org/show_bug.cgi?id=59962
We had a few places in mixed mode builds where we would not
track data used by the interpreter for marking. This patch
corrects the problem and adds a number of assertions to catch
live Structures being collected.
- JavaScriptCore.exp:
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::addStructureStubInfo): (JSC::CodeBlock::addGlobalResolveInfo):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitDirectPutById):
- runtime/Structure.cpp: (JSC::Structure::materializePropertyMap):
- runtime/Structure.h: (JSC::Structure::typeInfo): (JSC::Structure::previousID): (JSC::Structure::propertyStorageCapacity): (JSC::Structure::propertyStorageSize): (JSC::Structure::get): (JSC::Structure::materializePropertyMapIfNecessary):
- 2:18 PM Changeset in webkit [85522] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Add test expectations to accomodate new tests.
- platform/chromium/test_expectations.txt:
- 2:13 PM Changeset in webkit [85521] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-05-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Alexey Proskuryakov.
Use native NullPtr when using GCC 4.6.0 and C++0x
https://bugs.webkit.org/show_bug.cgi?id=59252
GCC 4.6.0 has nullptr support, use it when possible.
- wtf/NullPtr.cpp: include config.h to pull in Platform.h before NullPtr.h, since we need the GCC_VERSION_AT_LEAST definition.
- wtf/NullPtr.h: check for GCC >= 4.6.0 and C++0x in order to use native nullptr.
- 2:05 PM Changeset in webkit [85520] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Adjust test expectations.
- platform/chromium/test_expectations.txt:
- 2:04 PM Changeset in webkit [85519] by
-
- 3 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Handle DispatchOnConnectionQueue for asynchronous messages
https://bugs.webkit.org/show_bug.cgi?id=59959
If any asynchronous messages have the DispatchOnConnectionQueue attribute,
create a new willProcess{Receiver}MessageOnClientRunLoop.
- Scripts/webkit2/messages.py:
- Fix a regex bug where we would only parse attributes on synchronous messages.
- Collect messages with the dispatch_on_connection_queue flag set. We only handle asynchronous messages currently; sync message support will be added when/if the need arises.
- Scripts/webkit2/messages_unittest.py: Update test.
- 2:04 PM Changeset in webkit [85518] by
-
- 7 edits in trunk/Source/WebCore
2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85483.
http://trac.webkit.org/changeset/85483
https://bugs.webkit.org/show_bug.cgi?id=59958
Causes media test failures. (Requested by eric_carlson on
#webkit).
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::updatePlayState):
- html/HTMLMediaElement.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): (WebCore::MediaPlayerPrivateAVFoundation::load): (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): (WebCore::MediaPlayerPrivateAVFoundation::paint): (WebCore::MediaPlayerPrivateAVFoundation::duration): (WebCore::MediaPlayerPrivateAVFoundation::seeking): (WebCore::MediaPlayerPrivateAVFoundation::updateStates): (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): (WebCore::MediaPlayerPrivateAVFoundation::repaint): (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
- 1:49 PM Changeset in webkit [85517] by
-
- 6 edits2 adds in trunk/LayoutTests
2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: inline autoincrement key added on put
https://bugs.webkit.org/show_bug.cgi?id=59936
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
- 1:45 PM Changeset in webkit [85516] by
-
- 2 edits in trunk/Tools
2011-05-02 Martin Robinson <mrobinson@igalia.com>
Incorporate a review comment that I mistakenly omitted from my last commit.
- DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
- 1:37 PM Changeset in webkit [85515] by
-
- 18 edits in trunk/Source
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924
- css/CSSGrammar.y:
- platform/graphics/mac/SimpleFontDataMac.mm:
- Memory management for the font cache is somewhat... complext. This will require some careful thought to sort out.
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedFrame):
- WebView/WebView.mm: (-[WebView _injectMailQuirksScript]): (-[WebView _injectOutlookQuirksScript]): (toStringVector):
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Message::releaseArguments):
- The memory management for this class is very strange. I wrote a large comment. Hopefully a kind soul will come by and fix it.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::unload):
- UIProcess/API/mac/WKView.mm: (-[WKView _setFindIndicator:fadeOut:]):
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::toStringVector):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
- 1:32 PM Changeset in webkit [85514] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: inline autoincrement key added on put
https://bugs.webkit.org/show_bug.cgi?id=59936
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
- 1:28 PM Changeset in webkit [85513] by
-
- 5 edits in branches/chromium/742
Merge 85264 - 2011-04-28 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
fix shadw behavior for both CSS and Canvas
https://bugs.webkit.org/show_bug.cgi?id=59700
- platform/chromium/test_expectations.txt:
2011-04-28 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
fix shadw behavior for both CSS and Canvas -- skia only
https://bugs.webkit.org/show_bug.cgi?id=59700
Test:
canvas/philip/tests/2d.shadow.alpha.3.html
canvas/philip/tests/2d.shadow.alpha.4.html
canvas/philip/tests/2d.shadow.alpha.5.html
fast/canvas/canvas-fillPath-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/css/text-input-with-webkit-border-radius.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/canvas/canvas-getImageData.html
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6913001
- 1:23 PM Changeset in webkit [85512] by
-
- 13 edits in trunk/Source/WebCore
2011-05-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
showLineTree/showLineTreeForThis would make working with the line box tree easier
https://bugs.webkit.org/show_bug.cgi?id=59662
Adding a showLineTree/showLineTreeForThis method to help visualize and debug
the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
No new tests since this is a debugging feature only and not compiled in release.
- rendering/InlineBox.cpp: (WebCore::InlineBox::showLineTreeForThis): (WebCore::InlineBox::showLineTreeAndMark): (WebCore::InlineBox::showBox): (showLineTree):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::showLineTreeAndMark):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::showBox):
- rendering/InlineTextBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::showLineTreeAndMark):
- rendering/RenderBlock.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderTreeForThis): (WebCore::RenderObject::showLineTreeForThis): (showTree): (showLineTree):
- rendering/RenderObject.h:
- 1:20 PM Changeset in webkit [85511] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewd. Build fix.
Adjust test expectations to make build bots happy.
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [85510] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Carlson.
REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
https://bugs.webkit.org/show_bug.cgi?id=59917
Since default event handlers are not retargeted, we should always attempt ancestor
traversal to find out whether the event.
- html/MediaDocument.cpp: (WebCore::ancestorVideoElement): Added ancestor-traversing helper. (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
- 1:02 PM Changeset in webkit [85509] by
-
- 3 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
EWS should report the list of unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=59923
We cache the results of the first layout test results run on the task
so the EWS can grab them later. Another option is to include them in
the exception that's thrown, but this approach seemed slightly more
aesthetic.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
- 12:55 PM Changeset in webkit [85508] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Pages with accelerated compositing do not redraw unless scrolled
https://bugs.webkit.org/show_bug.cgi?id=59851
Added a setNeedDisplay on the non-composited content layer after
the size is changed so it paints the full size of the layer. Called
only for the areas newly exposed, if any.
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::sizeDidChange):
- 12:50 PM Changeset in webkit [85507] by
-
- 5 edits in trunk/Source/WebCore
Attempt to fix the Leopard build.
- platform/graphics/FontPlatformData.h:
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
- platform/mac/WebCoreSystemInterface.h:
- 12:49 PM Changeset in webkit [85506] by
-
- 108 edits1 copy14 adds1 delete in trunk/LayoutTests
2011-05-02 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Rebaseline SVG layout tests for chromium port.
- platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png:
- platform/chromium-linux/editing/style/block-style-003-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-005-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-010-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
- platform/chromium-linux/editing/style/table-selection-expected.png:
- platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
- platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
- platform/chromium-linux/svg/text/text-align-01-b-expected.png:
- platform/chromium-linux/svg/text/text-align-02-b-expected.png:
- platform/chromium-linux/svg/text/text-align-03-b-expected.png:
- platform/chromium-linux/svg/text/text-align-04-b-expected.png:
- platform/chromium-linux/svg/text/text-align-05-b-expected.png:
- platform/chromium-linux/svg/text/text-align-06-b-expected.png:
- platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
- platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
- platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
- platform/chromium-linux/svg/text/text-path-01-b-expected.png:
- platform/chromium-linux/svg/text/text-text-01-b-expected.png:
- platform/chromium-linux/svg/text/text-text-03-b-expected.png:
- platform/chromium-linux/svg/text/text-text-05-t-expected.png:
- platform/chromium-linux/svg/text/text-text-06-t-expected.png:
- platform/chromium-linux/svg/text/text-text-07-t-expected.png:
- platform/chromium-linux/svg/text/text-text-08-b-expected.png:
- platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
- platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
- platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
- platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
- platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
- platform/chromium-linux/svg/text/textPathBoundsBug-expected.png:
- platform/chromium-mac-leopard/editing/style/table-selection-expected.png:
- platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png:
- platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png:
- platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png:
- platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Removed.
- platform/chromium-mac/editing/style/block-style-003-expected.png: Added.
- platform/chromium-mac/editing/style/create-block-for-style-005-expected.png: Added.
- platform/chromium-mac/editing/style/create-block-for-style-006-expected.png: Added.
- platform/chromium-mac/editing/style/create-block-for-style-010-expected.png: Added.
- platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Added.
- platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Added.
- platform/chromium-mac/editing/style/table-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/textPathBoundsBug-expected.png.
- platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
- platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png: Added.
- platform/chromium-mac/svg/text/text-align-01-b-expected.png:
- platform/chromium-mac/svg/text/text-align-02-b-expected.png:
- platform/chromium-mac/svg/text/text-align-03-b-expected.png:
- platform/chromium-mac/svg/text/text-align-04-b-expected.png:
- platform/chromium-mac/svg/text/text-align-05-b-expected.png:
- platform/chromium-mac/svg/text/text-align-06-b-expected.png:
- platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png:
- platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
- platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
- platform/chromium-mac/svg/text/text-path-01-b-expected.png:
- platform/chromium-mac/svg/text/text-text-01-b-expected.png:
- platform/chromium-mac/svg/text/text-text-03-b-expected.png:
- platform/chromium-mac/svg/text/text-text-05-t-expected.png:
- platform/chromium-mac/svg/text/text-text-06-t-expected.png:
- platform/chromium-mac/svg/text/text-text-07-t-expected.png:
- platform/chromium-mac/svg/text/text-text-08-b-expected.png:
- platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
- platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
- platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
- platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
- platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
- platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
- platform/chromium-mac/svg/text/textPathBoundsBug-expected.png:
- platform/chromium-win/editing/style/block-style-003-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-005-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-010-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
- platform/chromium-win/editing/style/table-selection-expected.png:
- platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.png:
- platform/chromium-win/svg/text/text-align-01-b-expected.png:
- platform/chromium-win/svg/text/text-align-02-b-expected.png:
- platform/chromium-win/svg/text/text-align-03-b-expected.png:
- platform/chromium-win/svg/text/text-align-04-b-expected.png:
- platform/chromium-win/svg/text/text-align-05-b-expected.png:
- platform/chromium-win/svg/text/text-align-06-b-expected.png:
- platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
- platform/chromium-win/svg/text/text-deco-01-b-expected.png:
- platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
- platform/chromium-win/svg/text/text-path-01-b-expected.png:
- platform/chromium-win/svg/text/text-text-01-b-expected.png:
- platform/chromium-win/svg/text/text-text-03-b-expected.png:
- platform/chromium-win/svg/text/text-text-05-t-expected.png:
- platform/chromium-win/svg/text/text-text-06-t-expected.png:
- platform/chromium-win/svg/text/text-text-07-t-expected.png:
- platform/chromium-win/svg/text/text-text-08-b-expected.png:
- platform/chromium-win/svg/text/text-tref-01-b-expected.png:
- platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
- platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
- platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
- platform/chromium-win/svg/text/text-ws-01-t-expected.png:
- platform/chromium-win/svg/text/text-ws-02-t-expected.png:
- platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
- 12:43 PM Changeset in webkit [85505] by
-
- 2 edits2 adds1 delete in trunk
2011-05-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
convert manual-tests/bugzilla-6821.html to a layout test
https://bugs.webkit.org/show_bug.cgi?id=59404
- fast/css/hover-update-expected.txt: Added.
- fast/css/hover-update.html: Added.
2011-05-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
convert manual-tests/bugzilla-6821.html to a layout test
https://bugs.webkit.org/show_bug.cgi?id=59404
Test: fast/css/hover-update.html
- manual-tests/bugzilla-6821.html: Removed.
- 12:42 PM Changeset in webkit [85504] by
-
- 3 edits1 add in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add base case for a test-running EWS
https://bugs.webkit.org/show_bug.cgi?id=59920
Later I will subclass this to run the Chromium Linux EWS.
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 12:41 PM Changeset in webkit [85503] by
-
- 3 edits in trunk/Source/WebKit2
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Need a way to handle CoreIPC messages on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59954
Add a Connection::QueueClient abstract class. This class has a single pure virtual
member function, willProcessMessageOnClientRunLoop which should return true if the message
should be forwarded to the next Connection::QueueClient in the list or Connection::Client's
run loop for processing and false otherwise. Users of Connection can use addQueueClient to
add clients and all messages will be dispatched to the queue clients first.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::processIncomingMessage):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::QueueClient::~QueueClient):
- 12:24 PM Changeset in webkit [85502] by
-
- 10 edits in trunk/Source/WebKit2
2011-05-02 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WebKit2 thinks the web process is unresponsive when a plugin displays a context menu
https://bugs.webkit.org/show_bug.cgi?id=59124
<rdar://problem/9318600>
This is the Windows version of <https://bugs.webkit.org/show_bug.cgi?id=58943>.
Since we have no control over how long a plugin will take to handle an event, we need
to tell the UI process to stop its responsive timer when we're about to send an event
to the plugin. The downside of doing this is that if the plugin does become unresponsive,
the user won't know this immediately until they click on the web page again. At that point,
if the web process is unresponsive because of a hung plugin, the responsiveness timer will fire.
We're only doing this on Windows currently when running plugins in the web process (Anders fixed
bug 58943 in a different way when running plugins in a separate plugin process on the Mac).
- PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::willSendEventToPlugin): Added, not used when running plugins in a separate process.
- PluginProcess/PluginControllerProxy.h: Added willSendEventToPlugin().
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::stopResponsivenessTimer): Added.
- UIProcess/WebPageProxy.h: Added stopResponsivenessTimer().
- UIProcess/WebPageProxy.messages.in: Added StopResponsivenessTimer message.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: (WebKit::NetscapePlugin::platformPaint): Tell our controller when we're about to send an event to the plugin. (WebKit::NetscapePlugin::platformHandleMouseEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Ditto.
- WebProcess/Plugins/PluginController.h: Added willSendEventToPlugin().
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::willSendEventToPlugin): Added, tell the UI process to stop its responsiveness timer.
- WebProcess/Plugins/PluginView.h: Added willSendEventToPlugin().
- 12:11 PM Changeset in webkit [85501] by
-
- 16 edits in trunk/Source/WebCore
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune ApplicationServices.h out of the headers
https://bugs.webkit.org/show_bug.cgi?id=59952
More forward declares are better.
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/GlyphBuffer.h:
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/cg/PDFDocumentImage.cpp:
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
- platform/mac/WebCoreNSStringExtras.h:
- platform/mac/WebCoreSystemInterface.h:
- 12:09 PM Changeset in webkit [85500] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Remove passing tests after rebaselines from r85365.
- platform/chromium/test_expectations.txt:
- 11:50 AM Changeset in webkit [85499] by
-
- 5 edits in trunk
<rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
https://bugs.webkit.org/show_bug.cgi?id=58006
Reviewed by Simon Fraser.
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
<http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
table cell as the immediate containing block, but any case where all containing block ancestors
up to and including a table cell are auto-or-percent height.
LayoutTests:
- fast/replaced/table-percent-height-expected.txt: Updated.
- fast/replaced/table-percent-height.html: Added a test case with a replaced object nested in an
auto-height block inside a table cell.
- 11:38 AM Changeset in webkit [85498] by
-
- 3 edits in trunk/Tools
Build fix.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
- 11:30 AM Changeset in webkit [85497] by
-
- 6 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59950
Clean up AssemblerBuffer to use a Vector internally.
Reviewed by Oliver Hunt.
AssemblerBuffer handles reallocing a byte array itself - stop that.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::~AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::isAligned):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::putByteUnchecked):
(JSC::AssemblerBuffer::putByte):
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putShort):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::putInt64):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::executableCopy):
(JSC::AssemblerBuffer::rewindToLabel):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
- assembler/X86Assembler.h:
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
- 11:20 AM Changeset in webkit [85496] by
-
- 2 edits in trunk/Source/JavaScriptCore
Avoid potential buffer overflow in WTFLog() and WTFLogVerbose()
https://bugs.webkit.org/show_bug.cgi?id=59949
Reviewed by Alexy Proskuryakov.
- wtf/Assertions.cpp: Check for 0 or empty format string in WTFLog() and WTFLogVerbose().
- 11:14 AM Changeset in webkit [85495] by
-
- 2 edits1 move1 add in trunk
2011-05-02 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
https://bugs.webkit.org/show_bug.cgi?id=59379
Make onblur-remove.html a DRT test. As of 04/25/2011 this test fails. See bug #59379
for more details.
- fast/events/onblur-remove-expected.txt: Added; expected failure results.
- fast/events/onblur-remove.html: Copied from Source/WebCore/manual-tests/onblur-remove.html.
2011-05-02 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
https://bugs.webkit.org/show_bug.cgi?id=59379
Move manual test onblur-remove.html to LayoutTests/fast/events.
Test: fast/events/onblur-remove.html
- manual-tests/onblur-remove.html: Removed.
- 11:09 AM Changeset in webkit [85494] by
-
- 3 edits2 copies in branches/chromium/742
MERGE 85090 - 2011-04-27 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>
- editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
- editing/pasteboard/do-not-copy-body-color.html: Added.
2011-04-27 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>
- editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
- editing/pasteboard/do-not-copy-body-color.html: Added.
- 11:04 AM Changeset in webkit [85493] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
Plug-in failed to initialize message should be called when Java fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59856
To match the WebKit1 behavior, WebKit2 should dispatch the plug-in failed
to initialize message when we can't instantiate the Java plug-in.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
- 10:55 AM Changeset in webkit [85492] by
-
- 2 edits2 adds in trunk/Source/WebCore
2011-05-02 Sailesh Agrawal <sail@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Mac: Add scrollbar overlay drawing functions
https://bugs.webkit.org/show_bug.cgi?id=59741
These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
No new tests, since this code is only enabled on future versions of Mac OS X.
- WebCore.gypi:
- platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
- platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added. (LookUpNSScrollerImpClass): (LookUpNSScrollerImpPairClass): (ScrollbarControlSizeToNSControlSize): (wkScrollbarPainterUsesOverlayScrollers): (wkScrollbarPainterIsHorizontal): (wkScrollbarPainterKnobAlpha): (wkScrollbarPainterSetOverlayState): (wkScrollbarPainterPaint): (wkScrollbarMinimumThumbLength): (wkScrollbarPainterSetDelegate): (wkScrollbarPainterTrackAlpha): (wkMakeScrollbarPainter): (wkScrollbarThickness): (wkScrollbarMinimumTotalLengthNeededForThumb): (wkVerticalScrollbarPainterForController): (wkHorizontalScrollbarPainterForController): (wkMakeScrollbarReplacementPainter): (wkSetPainterForPainterController): (wkSetScrollbarPainterControllerStyle): (wkScrollbarPainterKnobRect): (wkSetScrollbarPainterKnobAlpha): (wkSetScrollbarPainterTrackAlpha): (wkSetScrollbarPainterKnobStyle): (wkMakeScrollbarPainterController): (wkContentAreaScrolled): (wkContentAreaWillPaint): (wkMouseEnteredContentArea): (wkMouseExitedContentArea): (wkMouseMovedInContentArea): (wkWillStartLiveResize): (wkContentAreaResized): (wkWillEndLiveResize): (wkContentAreaDidShow): (wkContentAreaDidHide): (wkDidBeginScrollGesture): (wkDidEndScrollGesture): (wkScrollbarPainterForceFlashScrollers): (IsScrollbarOverlayAPIAvailable):
- 10:55 AM Changeset in webkit [85491] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-05-02 Alok Priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium windows build is broken due to r85395
https://bugs.webkit.org/show_bug.cgi?id=59945
Include SecurityOrigin.h in IDBFactoryBackendProxy.cpp
- src/IDBFactoryBackendProxy.cpp:
- 10:54 AM Changeset in webkit [85490] by
-
- 2 edits in trunk/Tools
2011-05-02 Nico Weber <thakis@chromium.org>
Reviewed by Mihai Parparita.
Add --no-webkit2 to the output of "build-webkit -h"
https://bugs.webkit.org/show_bug.cgi?id=59942
- Scripts/build-webkit:
- 10:53 AM Changeset in webkit [85489] by
-
- 3 edits in trunk/Source/WebCore
2011-05-02 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement Length based CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=59314
No new tests as no functionality changed.
- css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyLength::ApplyPropertyLength): Added this class to handle all length types. Property specific behavior is handled through set of boolean parameters. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added calls to set up entries for the newly added length properties.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property implementations mow implemented in CSSStyleApplyProperty.
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::rootElementStyle): Expose m_rootElementStyle via getter.
- 10:52 AM Changeset in webkit [85488] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=59828
No new tests required, no functional change because seeking to time zero before playback
begins has no effect.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
HAVE_METADATA.
- 10:43 AM Changeset in webkit [85487] by
-
- 2 edits in trunk/Tools
2011-05-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
https://bugs.webkit.org/show_bug.cgi?id=59943
Disable the Ubuntu overlay scrollbar while testing, by injecting the
LIBOVERLAY_SCROLLBAR=0 environment variable.
- Scripts/old-run-webkit-tests:
- 10:42 AM Changeset in webkit [85486] by
-
- 4 edits in branches/chromium/742
Merge 85290 - 2011-04-28 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732
- platform/chromium/test_expectations.txt: Add expectations for affected tests.
2011-04-28 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732
- css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6880352
- 10:39 AM Changeset in webkit [85485] by
-
- 2 edits in trunk/Source/WebCore
Fix extra whitespace in license in FocusDirection.h.
Reviewed by Gavin Barraclough.
- page/FocusDirection.h:
- 10:35 AM Changeset in webkit [85484] by
-
- 25 edits in trunk/Source
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907
- Plugins/WebBaseNetscapePluginView.mm:
- WebView/WebFrame.mm: Add now missing SecurityOrigin.h #includes.
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907
- page/DOMWindow.cpp: (WebCore::DOMWindow::setSecurityOrigin):
- page/DOMWindow.h: Remove #includes of SecurityOrigin and MessagePort by forward declaring and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget #include that was getting added by MessagePort.h.
- bindings/js/JSCustomVoidCallback.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMWindowCustom.h:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/ScriptController.h:
- html/HTMLAnchorElement.cpp:
- html/HTMLMediaElement.cpp:
- html/parser/XSSFilter.cpp:
- inspector/InspectorDOMStorageResource.cpp:
- loader/MainResourceLoader.cpp:
- page/DragController.cpp:
- page/EventSource.cpp:
- page/Location.cpp:
- websockets/WebSocket.cpp:
- xml/XSLTProcessorLibxslt.cpp: Add now missing SecurityOrigin.h #includes.
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907
- WebProcess/WebPage/WebFrame.cpp: Add now missing SecurityOrigin.h #include.
- 10:21 AM Changeset in webkit [85483] by
-
- 7 edits in trunk/Source/WebCore
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Tested manually with manual-tests/media-elements/video-preload.html.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
because we need to have media data loaded to seek.
(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
- html/HTMLMediaElement.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove
m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
Move all preload logic to setPreload, call it from here.
(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
setPreload, call it.
(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
unlikely to be correct and isn't worth caching.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
width, height, hasVideo, etc.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
in derived classes.
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
AVAsset and AVPlayerItem here.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
if necessary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
the buffer is full.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
we have allocated the AVPlayerItem.
- 9:52 AM Changeset in webkit [85482] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
StringImpl::endsWith has some insane code
https://bugs.webkit.org/show_bug.cgi?id=59900
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::endsWith):
- m_data shadows a member variable of the same name.
- 9:23 AM Changeset in webkit [85481] by
-
- 4 edits in trunk
2011-05-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] editing/selection/select-out-of-editable.html failing after r83967
https://bugs.webkit.org/show_bug.cgi?id=58667
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-05-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] editing/selection/select-out-of-editable.html failing after r83967
https://bugs.webkit.org/show_bug.cgi?id=58667
Do not trigger mouse down events when the EventSender knows that a mouse button is
already down. These type of situations can confuse Xvfb and cause dragging failures.
- DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not trigger another mouse button down event if the mouse button is already down. This can interfere with drags in Xvfb.
- 9:19 AM WebKitGtkLayoutTests edited by
- Made the package list more readable and remove DejaVu fonts. (diff)
- 9:13 AM Changeset in webkit [85480] by
-
- 2 edits in trunk/Source/WebCore
2011-05-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
https://bugs.webkit.org/show_bug.cgi?id=59932
Use gdk_window_get_width() and gdk_window_get_height() if
available, instead of the deprecated gdk_drawable_get_size().
No new tests, build fix only.
- platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext):
- 9:09 AM Changeset in webkit [85479] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
https://bugs.webkit.org/show_bug.cgi?id=58657
Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.
- platform/win-xp/Skipped:
- 9:04 AM Changeset in webkit [85478] by
-
- 3 edits in trunk/Source/WebCore
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Test manually with manual-tests/media-elements/video-preload.html.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
attribute when preload is not "auto".
(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
(WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
(WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
a QTMovie.
- 8:59 AM Changeset in webkit [85477] by
-
- 3 edits in trunk/LayoutTests
[Qt] Update an exptected file after r85474.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
- 8:55 AM Changeset in webkit [85476] by
-
- 1 edit1 add in trunk/Source/WebCore
2011-04-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Manual test manual-tests/media-elements/video-preload.html added.
- manual-tests/media-elements/video-preload.html: Added. New manual test for media element
'preload' attribute because it is not possible to detect if a media engine supports
"preload=metadata" in a way that lets us have per-platform layout test results.
- 7:29 AM Changeset in webkit [85475] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] Media tests relying on video-paint-test.js are still flaky
https://bugs.webkit.org/show_bug.cgi?id=59934
Dump the render tree after the video completed the seek. This is
to avoid flake happening in the control slider not always being at
beginning of the timeline.
- media/video-paint-test.js: (init.document.addEventListener.): (init):
- 7:27 AM Changeset in webkit [85474] by
-
- 4 edits in trunk
2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958
- platform/qt/Skipped: Unskip svg/custom/text-zoom.xhtml
2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
DRT sideeffect revealed by r71268.
https://bugs.webkit.org/show_bug.cgi?id=48958
Reset QWebSettings::ZoomTextOnly attribute before all tests.
Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
PageZoomFactor too. It should be done before resetsettings()
to guarantee resetting QWebSettings::ZoomTextOnly correctly.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 7:24 AM Changeset in webkit [85473] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip flaky test on GTK.
- platform/gtk/Skipped: Skip tables/mozilla_expected_failures/bugs/bug85016.html
- 5:13 AM Changeset in webkit [85472] by
-
- 3 edits1 delete in trunk/Tools
2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85469.
http://trac.webkit.org/changeset/85469
https://bugs.webkit.org/show_bug.cgi?id=59928
Broke webkitpy-tests on Windows 7, GTK and Qt. (Requested by
bbandix on #webkit).
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 4:03 AM Changeset in webkit [85471] by
-
- 2 edits in trunk/Tools
2011-05-02 Tomasz Morawski <t.morawski@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
Cleanup EFL initialization/shutdown in the EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=59922
Removed ecore_evas_init and edje_init form main function due to they
are also called in the ewk_init. Moved ewk_shutdown to quit function.
- EWebLauncher/main.c: (quit): (main):
- 3:54 AM Changeset in webkit [85470] by
-
- 2 edits in trunk/LayoutTests
2011-05-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, re-enable websocket tests on GTK. they moved over to a
real http server and most of the flakiness went away.
- platform/gtk/Skipped:
- 3:51 AM Changeset in webkit [85469] by
-
- 3 edits1 add in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add base case for a test-running EWS
https://bugs.webkit.org/show_bug.cgi?id=59920
Later I will subclass this to run the Chromium Linux EWS.
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 3:02 AM Changeset in webkit [85468] by
-
- 1 edit46 adds in trunk/LayoutTests
2011-05-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for new tests.
- platform/gtk/fast/backgrounds/gradient-background-leakage-expected.png: Added.
- platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
- platform/gtk/fast/block/float/float-overhangs-root-expected.png: Added.
- platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Added.
- platform/gtk/fast/block/float/overhanging-tall-block-expected.png: Added.
- platform/gtk/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Added.
- platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
- platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
- platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
- platform/gtk/fast/forms/date-input-visible-strings-expected.png: Added.
- platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Added.
- platform/gtk/fast/html/details-add-child-1-expected.png: Added.
- platform/gtk/fast/html/details-add-child-1-expected.txt: Added.
- platform/gtk/fast/html/details-add-child-2-expected.png: Added.
- platform/gtk/fast/html/details-add-child-2-expected.txt: Added.
- platform/gtk/fast/html/details-add-summary-child-1-expected.png: Added.
- platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Added.
- platform/gtk/fast/html/details-add-summary-child-2-expected.png: Added.
- platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Added.
- platform/gtk/fast/html/details-remove-child-1-expected.png: Added.
- platform/gtk/fast/html/details-remove-child-1-expected.txt: Added.
- platform/gtk/fast/html/details-remove-child-2-expected.png: Added.
- platform/gtk/fast/html/details-remove-child-2-expected.txt: Added.
- platform/gtk/fast/html/details-remove-summary-child-1-expected.png: Added.
- platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Added.
- platform/gtk/fast/html/details-remove-summary-child-2-expected.png: Added.
- platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Added.
- platform/gtk/fast/table/auto-100-percent-width-expected.png: Added.
- platform/gtk/fast/table/auto-100-percent-width-expected.txt: Added.
- platform/gtk/fast/table/dynamic-caption-add-before-child-expected.png: Added.
- platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
- platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
- platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
- platform/gtk/fast/table/multiple-captions-display-expected.png: Added.
- platform/gtk/fast/table/multiple-captions-display-expected.txt: Added.
- platform/gtk/fast/text/selection-rect-rounding-expected.png: Added.
- platform/gtk/fast/text/selection-rect-rounding-expected.txt: Added.
- platform/gtk/svg/filters/feDropShadow-expected.png: Added.
- platform/gtk/svg/filters/feDropShadow-expected.txt: Added.
- 2:37 AM Changeset in webkit [85467] by
-
- 2 edits in trunk/Source/JavaScriptCore
Buildfix for ARM after r85448
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::loadBranchTarget):
- 2:09 AM Changeset in webkit [85466] by
-
- 3 edits in trunk/LayoutTests
2011-05-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline after r85355.
- platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
- 1:11 AM Changeset in webkit [85465] by
-
- 5 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add the ability to skip python and perl unit tests on EC2
https://bugs.webkit.org/show_bug.cgi?id=59918
- Scripts/webkitpy/common/config/ports.py:
- This is slightly ugly, but it's useful...
- Scripts/webkitpy/common/config/ports_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- 12:56 AM Changeset in webkit [85464] by
-
- 3 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch --non-interactive is incompatible with new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59919
new-run-webkit-tests doesn't support --wait-for-httpd (because it
always waits for HTTPD, as I understand things). It turns out we're
not really using this flag for anything, so we should just remove it.
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 12:53 AM Changeset in webkit [85463] by
-
- 5 edits in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
The bots should learn from expected failures without having to retry
https://bugs.webkit.org/show_bug.cgi?id=59279
Rather than re-trying the whole patch, we can just check whether we now
expect the failures we see with the patch applied, saving a lot of time.
This patch also teaches the CommitQueue how to reject patches even
when the tree is red using the new unexpected_failures() method on
ExpectedFailures.
Finally in testing we found a bug in ExpectedFailures where it would
"trust" results which had many many failures, due to using an
equal sign instead of a less-than sign.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
- Scripts/webkitpy/tool/bot/expectedfailures.py
- Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
- Scripts/webkitpy/tool/bot/patchanalysistask.py
- 12:17 AM Changeset in webkit [85462] by
-
- 4 edits in trunk/Tools
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
workspace.py fails to import ScriptError
https://bugs.webkit.org/show_bug.cgi?id=59915
If the workspace fails to create a zip, webkitpy crashes instead of
handling the error as expected.
- Scripts/webkitpy/common/system/workspace.py:
- Scripts/webkitpy/common/system/workspace_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
May 1, 2011:
- 11:29 PM Changeset in webkit [85461] by
-
- 2 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Remove unadvertantly added file.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 11:18 PM Changeset in webkit [85460] by
-
- 3 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
expectedfailures.py should report the unexpected failures when asked
https://bugs.webkit.org/show_bug.cgi?id=59916
This information is useful when the EWS runs tests.
- Scripts/webkitpy/tool/bot/expectedfailures.py:
- Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
- 11:14 PM Changeset in webkit [85459] by
-
- 3 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JSONTestResult needs to handle multiple results
https://bugs.webkit.org/show_bug.cgi?id=59269
This case occurs when a test is flaky because NRWT will run the test
twice and report both results as "actual."
- Scripts/webkitpy/common/net/resultsjsonparser.py:
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
- 10:59 PM Changeset in webkit [85458] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Regression(r74787): Media document mouse click and double-click
events should be checked on target node only and not its descendants.
https://bugs.webkit.org/show_bug.cgi?id=59886
- html/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- 10:44 PM Changeset in webkit [85457] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2: Crash closing tab with docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>
Reviewed by Dan Bernstein.
When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.
This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.
- UIProcess/WebInspectorProxy.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
- 10:21 PM Changeset in webkit [85456] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Strict-mode only reserved words not reserved
https://bugs.webkit.org/show_bug.cgi?id=55342
Fix line number tracking when we rollback the lexer.
- parser/JSParser.cpp: (JSC::JSParser::parseSourceElements):
- 9:51 PM Changeset in webkit [85455] by
-
- 4 edits in trunk
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295
Update for correct results
- fast/js/mozilla/strict/11.1.5-expected.txt:
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295
Simplify and correct the logic for strict mode object literals.
- parser/JSParser.cpp: (JSC::JSParser::parseStrictObjectLiteral):
- 7:57 PM Changeset in webkit [85454] by
-
- 6 edits in trunk
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289
Add test case for correct behaviour, and update mozilla test results to reflect
the correct result.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/mozilla/strict/assign-to-callee-name-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289
Add logic to StaticScopeObject to ensure we don't silently consume
writes to constant properties.
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put):
- 6:55 PM Changeset in webkit [85453] by
-
- 3 edits4 adds in trunk
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899
Test two host wildcard cases.
- http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html: Added.
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899
Finish last two details of host and port matching. I don't think the
default port handling is testable with our current testing
infrastructure.
Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSource::hostMatches): (WebCore::CSPSource::portMatches):
- 6:46 PM Changeset in webkit [85452] by
-
- 7 edits2 moves in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move checkout/api.py to checkout/checkout.py
https://bugs.webkit.org/show_bug.cgi?id=59906
This is more consistent with Python style.
- Scripts/webkitpy/common/checkout/init.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/tool/main.py:
- 6:44 PM Changeset in webkit [85451] by
-
- 4 edits6 adds in trunk
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641
Test that default-src controls some scripting policy and that
script-src, if present, overrides default-src. In principle, we could
test the interaction of default-src with every other directive, but
that seems like overkill.
- http/tests/security/contentSecurityPolicy/default-src-inline-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-overrides-default-src-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html: Added.
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641
Add support for default-src. The default-src provides a default policy
for every directive that sends in "-src". If the more-specific
directive is present, it takes precedence. I also took this
opportunity to refactor the internals of ContentSecurityPolicy a bit to
reduce duplicate code.
Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::checkEval): (WebCore::ContentSecurityPolicy::operativeDirective): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowInlineStyle): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 6:34 PM Changeset in webkit [85450] by
-
- 3 edits in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
scm.py should be split into many pieces
https://bugs.webkit.org/show_bug.cgi?id=59908
Forgot an AuthenticationError import.
- Scripts/webkitpy/common/checkout/scm/git.py:
- Scripts/webkitpy/common/checkout/scm/svn.py:
- 6:27 PM Changeset in webkit [85449] by
-
- 4 edits4 adds in trunk/Tools
2011-05-01 Arno Renevier <arno@renevier.net>
Reviewed by Eric Seidel.
wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283
raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 6:04 PM Changeset in webkit [85448] by
-
- 9 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer
Reviewed by Sam Weinig.
Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::label):
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):
- assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):
- 6:03 PM Changeset in webkit [85447] by
-
- 2 edits in trunk/Tools
2011-05-01 Arno Renevier <arno@renevier.net>
Reviewed by Eric Seidel.
wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283
raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 5:58 PM Changeset in webkit [85446] by
-
- 2 edits in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make most scm.py tests pass in preparation for splitting them up
https://bugs.webkit.org/show_bug.cgi?id=59904
There is one remaining failure:
webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
which identifies a difference between the SVN and Git versions of the
SCM api. I'm not going to bother fixing that until we split out all
the tests.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- 5:33 PM Changeset in webkit [85445] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
- wtf/OwnPtr.h:
- 5:19 PM Changeset in webkit [85444] by
-
- 2 edits in trunk/Source/WebKit/win
Fix windows build.
- WebFrame.cpp:
- 5:15 PM Changeset in webkit [85443] by
-
- 2 edits in trunk/Tools
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85440.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
- 4:56 PM Changeset in webkit [85442] by
-
- 20 edits in trunk/Source
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.h:
- bindings/js/ScheduledAction.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptDebugServer.cpp:
- editing/Editor.h:
- inspector/InspectorClient.cpp:
- loader/FrameLoader.h:
- loader/NavigationScheduler.h:
- page/Console.cpp:
- xml/XMLTreeViewer.cpp:
- xml/XMLTreeViewer.h:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 4:53 PM Changeset in webkit [85441] by
-
- 3 edits in trunk/Tools
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
- DumpRenderTree/win/UIDelegate.cpp: Ditto.
- 4:44 PM Changeset in webkit [85440] by
-
- 5 edits in trunk
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- WebView.cpp: (WebView::paint):
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
- DumpRenderTree/win/UIDelegate.cpp: (DRTUndoManager::DRTUndoManager): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager):
- 4:29 PM Changeset in webkit [85439] by
-
- 5 edits in trunk/Source/WebKit2
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::startDragDrop):
- UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: (WebKit::WebDragClient::startDrag):
- WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
- 4:09 PM Changeset in webkit [85438] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie):
- 3:53 PM Changeset in webkit [85437] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
- 3:45 PM Changeset in webkit [85436] by
-
- 3 edits5 moves2 adds in trunk
2011-05-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840
- fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt: Added.
- fast/loader/stateobjects/pushstate-in-data-url-denied.html: Added.
- fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Removed.
- fast/loader/stateobjects/replacestate-base-illegal.html: Removed.
- fast/loader/stateobjects/replacestate-base-legal-expected.txt: Removed.
- fast/loader/stateobjects/replacestate-base-legal.html: Removed.
- fast/loader/stateobjects/resources/replacestate-base-pass.html: Removed.
- http/tests/navigation/replacestate-base-illegal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal-expected.txt.
- http/tests/navigation/replacestate-base-illegal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal.html.
- http/tests/navigation/replacestate-base-legal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal-expected.txt.
- http/tests/navigation/replacestate-base-legal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal.html.
- http/tests/navigation/resources/replacestate-base-pass.html: Copied from LayoutTests/fast/loader/stateobjects/resources/replacestate-base-pass.html.
2011-05-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840
Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
http/tests/navigation/replacestate-base-illegal.html
http/tests/navigation/replacestate-base-legal.html
- page/History.cpp: (WebCore::History::stateObjectAdded):
- 3:42 PM Changeset in webkit [85435] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
[WIN] Unreviewed buildfix after r85434.
- platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext):
- 3:30 PM Changeset in webkit [85434] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Enable strict OwnPtr for PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=59881
- wtf/OwnPtr.h:
- 3:28 PM Changeset in webkit [85433] by
-
- 7 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
[WINCE] Fix OwnPtr strict issues
https://bugs.webkit.org/show_bug.cgi?id=59898
- page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
- platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontData::create): (WebCore::FontPlatformPrivateData::FontPlatformData::hfont): (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle): (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner): (WebCore::GraphicsContext::drawText):
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
- platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::SharedBitmap):
- 3:20 PM Changeset in webkit [85432] by
-
- 15 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.
Reviewed by Sam Weinig.
The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).
Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::patch):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):
- assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):
- 2:15 PM Changeset in webkit [85431] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Can't open document from skydrive.com in Microsoft Word
https://bugs.webkit.org/show_bug.cgi?id=59891
<rdar://problem/9354285>
Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks):
- 1:47 PM Changeset in webkit [85430] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't try to create a backing store for a 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=59887
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
- 1:26 PM Changeset in webkit [85429] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-05-01 Chao-ying Fu <fu@mips.com>
Reviewed by Eric Seidel.
Fix MIPS build due to the split of "Condition" enum
https://bugs.webkit.org/show_bug.cgi?id=59407
- assembler/MIPSAssembler.h: (JSC::MIPSAssembler::debugOffset):
- assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::compare32):
- 12:46 PM Changeset in webkit [85428] by
-
- 6 edits in trunk/Source
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
- WebCore.exp.in:
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
- WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
- 12:20 PM Changeset in webkit [85427] by
-
- 2 edits2 moves2 adds in trunk/Tools
2011-05-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move scm.py into its own module in preparation for splitting it up
https://bugs.webkit.org/show_bug.cgi?id=59884
- Scripts/webkitpy/common/checkout/scm/init.py: Added.
- Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
- Scripts/webkitpy/test/main.py:
- 12:15 PM Changeset in webkit [85426] by
-
- 2 edits in trunk
2011-05-01 ojab <ojab@ojab.ru>
Reviewed by Eric Seidel.
--disable-video-track if --disable-video
https://bugs.webkit.org/show_bug.cgi?id=59605
- configure.ac:
- 12:10 PM Changeset in webkit [85425] by
-
- 6 edits in trunk/Source
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835
Moved currentKeyboardEvent.
- WebCore.exp.in:
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835
Moved currentKeyboardEvent.
- WebView/WebHTMLView.mm: (currentKeyboardEvent): (-[WebHTMLView becomeFirstResponder]):
- 11:58 AM Changeset in webkit [85424] by
-
- 2 edits in trunk/Tools
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch fails when not run from root
https://bugs.webkit.org/show_bug.cgi?id=59882
We need to set the CWD when running svn so that svn interprets file
paths relative to the root of the working copy.
- Scripts/webkitpy/common/checkout/scm.py:
- 11:42 AM Changeset in webkit [85423] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 ojab <ojab@ojab.ru>
Reviewed by Eric Seidel.
Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=59698
- rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet):
- 11:35 AM Changeset in webkit [85422] by
-
- 3 edits in trunk/Source/WebCore
2011-05-01 Jeff Timanus <twiz@chromium.org>
Reviewed by Eric Seidel.
Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
https://bugs.webkit.org/show_bug.cgi?id=59041
Test:css2.1/t140201-c533-bgimage-00-a.html
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
- 11:02 AM Changeset in webkit [85421] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Sandbox violation by WebProcess for DownloadAssessment.plist
https://bugs.webkit.org/show_bug.cgi?id=59879
<rdar://problem/9326041>
- WebProcess/com.apple.WebProcess.sb: Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist
- 10:47 AM Changeset in webkit [85420] by
-
- 13 edits in trunk/Source
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
- platform/graphics/win/WKCAImageQueue.cpp: (WebCore::WKCAImageQueue::WKCAImageQueue):
- platform/win/CursorWin.cpp: (WebCore::createSharedCursor):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
- FullscreenVideoController.cpp: (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::createHUDWindow):
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight):
- WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag):
- WebNodeHighlight.cpp: (WebNodeHighlight::update):
- WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter):
- WebView.cpp: (WebView::close): (WebView::paint): (WebView::handleMouseEvent): (WebView::registerEmbeddedViewMIMEType):
- 10:43 AM Changeset in webkit [85419] by
-
- 5 edits in trunk/Source/WebCore
2011-05-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
https://bugs.webkit.org/show_bug.cgi?id=59876
Also pass the size "as reference" instead of "as value".
- platform/graphics/GraphicsContext.h:
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::paint):
- 10:30 AM Changeset in webkit [85418] by
-
- 3 edits2 adds in trunk
2011-05-01 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111
Add test to verify that getComputedStyle returns length properties with a unit.
- fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-length-unit.html: Added.
2011-05-01 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111
Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 10:25 AM Changeset in webkit [85417] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Young Han Lee <joybro@company100.net>
Reviewed by Eric Seidel.
Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
https://bugs.webkit.org/show_bug.cgi?id=59608
TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
No new functionality, no new tests.
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::TextureMapperGL):
- 10:08 AM Changeset in webkit [85416] by
-
- 3 edits2 adds in trunk
2011-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943
- fast/css/nth-child-n-expected.txt: Added.
- fast/css/nth-child-n.html: Added.
2011-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943
Regression from r75158.
"n" is a valid parameter to nth() and should be allowed.
Test: fast/css/nth-child-n.html
- css/CSSParser.cpp: (WebCore::isValidNthToken):
- 9:09 AM Changeset in webkit [85415] by
-
- 3 edits in trunk/Source/WebCore
2011-05-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: address stack frame scriptName -> url rename in timeline panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- 9:07 AM Changeset in webkit [85414] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Chris Fleizach <Chris Fleizach>
Reviewed by Maciej Stachowiak.
Crash in AccessibilityRenderObject while viewing PDFs in iframes
https://bugs.webkit.org/show_bug.cgi?id=59629
Could not reproduce this crash, but it's quite clear how it could happen.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityHitTest):
- 7:38 AM Changeset in webkit [85413] by
-
- 14 edits6 adds in trunk
2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072
Add testcase that used to leak, the leaks bot will assure they won't in future.
- svg/custom/pending-resource-leak-2-expected.txt: Added.
- svg/custom/pending-resource-leak-2.svg: Added.
- svg/custom/pending-resource-leak-3-expected.txt: Added.
- svg/custom/pending-resource-leak-3.svg: Added.
- svg/custom/pending-resource-leak-expected.txt: Added.
- svg/custom/pending-resource-leak.svg: Added.
2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072
Make the pending resources set non-refcounted again. We made it refcounted a while ago
to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
Fix the underlying problem, by removing all pending resources referencing to a particular
SVGElement, upon its destruction or upon removing it from the document.
Example: <rect fill="url(#foo)" id="rect">
When we try to render the rect, the foo paint server can't be found and thus "foo" will be
added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
itself from the pending resource set, and a ref count to the "rect" would be released.
If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
it and the associated document alive.
Tests: svg/custom/pending-resource-leak-2.svg
svg/custom/pending-resource-leak-3.svg
svg/custom/pending-resource-leak.svg
These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
- rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
- rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
- rendering/svg/SVGResources.cpp: (WebCore::registerPendingResource):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::hasPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
- svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::hasPendingResources): (WebCore::SVGElementRareData::setHasPendingResources):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::removedFromDocument): (WebCore::SVGStyledElement::hasPendingResources): (WebCore::SVGStyledElement::setHasPendingResources):
- svg/SVGStyledElement.h: (WebCore::SVGStyledElement::needsPendingResourceHandling): (WebCore::SVGStyledElement::buildPendingResource):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildPendingResource):
- svg/SVGUseElement.h:
- 7:12 AM Changeset in webkit [85412] by
-
- 2 edits in trunk/Source/WebCore
2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] build-webkit warning Inspector.idl is missing
https://bugs.webkit.org/show_bug.cgi?id=59047
Added variable_out to pipe output from one compiler to another,
and then forced the output to be added to the sources.
- CodeGenerators.pri:
- 2:19 AM Changeset in webkit [85411] by
-
- 5 edits3 adds in trunk
<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
https://bugs.webkit.org/show_bug.cgi?id=56658
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/text/selection-rect-rounding.html
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText): Ditto.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.
LayoutTests:
- fast/text/selection-rect-rounding.html: Added.
- platform/mac/fast/text/selection-rect-rounding-expected.png: Added.
- platform/mac/fast/text/selection-rect-rounding-expected.txt: Added.
- 1:09 AM Changeset in webkit [85410] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=59873
These rules have been obsoleted by <rdar://problem/9301520> and
<rdar://problem/9181468>.
- WebProcess/com.apple.WebProcess.sb:
- 12:45 AM Changeset in webkit [85409] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Simplify WebProcess sandbox with homedir-relative path filters.
https://bugs.webkit.org/show_bug.cgi?id=59872
- WebProcess/com.apple.WebProcess.sb:
- 12:28 AM Changeset in webkit [85408] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
On-demand VPN support for sandboxed WebProcess.
<rdar://problem/8994181>
- WebProcess/com.apple.WebProcess.sb:
- 12:10 AM Changeset in webkit [85407] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-30 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Reindent WebProcess sandbox to standard scheme style
https://bugs.webkit.org/show_bug.cgi?id=59870
- WebProcess/com.apple.WebProcess.sb:
