⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 6, 2011:

11:12 PM Changeset in webkit [86001] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/742

Merge 85964
BUG=72832
Review URL: ​http://codereview.chromium.org/6949014

10:49 PM Changeset in webkit [86000] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Forgot it since my last svg rebaseline r85981.

  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
10:02 PM Changeset in webkit [85999] by inferno@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium rebaselines for r85990

  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
9:24 PM Changeset in webkit [85998] by tkent@chromium.org
  • 32 edits
    2 deletes in trunk/Source

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement and TextFieldInputType.
  • Change the return type of Node::toInputElement(): InputElement* -> HTMLInputElement*

No new tests. This change should not change the existing behaviour.

  • CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
  • GNUmakefile.list.am: ditto.
  • WebCore.exp.in: Add symbols of functions exposed to WebKit.
  • WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): Follow the return type change of Node::toInputElement().
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): ditto. (WebCore::AccessibilityRenderObject::isIndeterminate): ditto. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto. (WebCore::AccessibilityRenderObject::isChecked): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  • dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton): ditto.
  • dom/DOMAllInOne.cpp: Remove InputElement.h.
  • dom/InputElement.cpp: Removed.
  • dom/InputElement.h: Removed.
  • dom/Node.cpp: (WebCore::Node::toInputElement): Change the return type from InputElement* to HTMLInputElement*.
  • dom/Node.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::formControlName): (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::size): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): (WebCore::HTMLInputElement::setDefaultName): (WebCore::HTMLInputElement::maxLength): (WebCore::HTMLInputElement::cacheSelection): (WebCore::formatCodes): Moved from InputElement. (WebCore::cursorPositionToMaskIndex): ditto. (WebCore::HTMLInputElement::isConformToInputMask): ditto. (WebCore::HTMLInputElement::validateInputMask): ditto. (WebCore::HTMLInputElement::setWapInputFormat): ditto. (WebCore::HTMLInputElement::notifyFormStateChanged): ditto. (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto. (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
  • html/HTMLInputElement.h:
    • Add data members which were defined in InputElementData.
    • Make some functions public because the public interface InputElement is removed.
    • Make some functions non-virtual because they don't override corresponding virtual functions of InputElement anymore.

(WebCore::HTMLInputElement::toInputElement):

Follow the return type change of Node::toInputElement().

(WebCore::HTMLInputElement::isIndeterminate):
(WebCore::HTMLInputElement::isAutofilled):
(WebCore::HTMLInputElement::supportsMaxLength):
(WebCore::HTMLInputElement::cachedSelectionStart):
(WebCore::HTMLInputElement::cachedSelectionEnd):

  • html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
  • html/InputType.cpp: (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
  • html/InputType.h: Update for the above.
  • html/TextFieldInputType.cpp: (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp. (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength(). (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Move the code from InputElement::handleBeforeTextInsertedEvent().
  • html/TextFieldInputType.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp:
    • Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
    • Follow the return type change of inputElement().

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):

Make sure node() is an HTMLInputElement instance.

(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
(WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
(WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::startSearchEventTimer):
(WebCore::RenderTextControlSingleLine::searchEventTimerFired):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTextControlSingleLine.h: Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): Follow the return type change of Node::toInputElement(). (WebCore::RenderTheme::isIndeterminate): ditto. (WebCore::RenderTheme::shouldHaveSpinButton): Change the parameter type: InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.h: ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength. (WebKit::toWebInputElement): Follow the return type change of Node::toInputElement().

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Follow the return type change of Node::toInputElement(). (DumpRenderTreeSupportGtk::setValueForUser): ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAutofilled): Follow the return type change of Node::toInputElement().
8:51 PM Changeset in webkit [85997] by cevans@google.com
  • 14 edits
    2 copies in branches/chromium/742

Merge 85823
BUG=64046
Review URL: ​http://codereview.chromium.org/6955016

8:45 PM Changeset in webkit [85996] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/742

Merge 85926
BUG=80608
Review URL: ​http://codereview.chromium.org/6949013

8:26 PM Changeset in webkit [85995] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/696

Merge 85926
BUG=80608

8:19 PM Changeset in webkit [85994] by cevans@google.com
  • 12 edits
    2 copies in branches/chromium/696

Merge 85823
BUG=64046

7:13 PM Changeset in webkit [85993] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

  • http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

This mode lets web sites try out CSP by getting violation reports (and
console spam) without actually changing the behavior of their web sites.

Test: http/tests/security/contentSecurityPolicy/report-only.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h:
6:18 PM Changeset in webkit [85992] by imasaki@chromium.org
  • 8 edits in trunk/LayoutTests

2011-05-06 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline to chromium for video-layer.
​https://bugs.webkit.org/show_bug.cgi?id=60423

These expected files are produced by the rebaseline tool.
​http://code.google.com/p/chromium/issues/detail?id=81833

  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [85991] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by David Levin.

[chromium] Rebaseline needed for media/audio-repaint
​https://bugs.webkit.org/show_bug.cgi?id=60416

  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [85990] by Beth Dakin
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60421
Custom scrollbars nested inside an overlay scrollbar overflow region end up
painting twice
-and corresponding-
<rdar://problem/9389072>

Reviewed by Darin Adler.

Source/WebCore:

Be sure not to paint custom css scrollbars during the special overlay-scrollbar
painting pass.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):

LayoutTests:

  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • scrollbars/scrollbars-on-positioned-content.html: Added.
5:50 PM WebKit Team edited by rniwa@webkit.org
Adding "Core DOM" and "Event Handling" to my area of knowledge (diff)
5:47 PM Changeset in webkit [85989] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-05-06 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Add utility for converting SkCanvas to CGContext
​https://bugs.webkit.org/show_bug.cgi?id=59808

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The BitLockerSkia utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

Each time the CGContext is retrieved, it is rebuilt.
This permits the caller to modify the same canvas
between calls.

This change adds utilities but does not modify any
existing code. For now, there are no callers to these
utilities, so there is no functional change.

No new tests.

  • platform/graphics/skia/BitLockerSkia.cpp: Added. (WebCore::SkMatrixToCGAffineTransform): Conversion utility. (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas. (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up. (WebCore::BitLockerSkia::release): Internal private helper. (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
  • platform/graphics/skia/BitLockerSkia.h: Added.
5:11 PM Changeset in webkit [85988] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-06 David Grogan <​dgrogan@chromium.org>

Reviewed by Eric Seidel.

update link to message about mac 64bit git binaries
​https://bugs.webkit.org/show_bug.cgi?id=60411

The original message implied (correctly, at-the-time) that
​http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
binaries. The new message notes that they do. This might prevent someone
else from spending a few minutes confused.

  • Scripts/webkitpy/common/checkout/scm/git.py:
4:29 PM Changeset in webkit [85987] by Martin Robinson
  • 6 edits
    2 adds in trunk/Source

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract coordinate system translation code from WebKit into WebCore.
This will allow the code to be shared between WebKit and WebKit2. The code
now lives in a new GtkUtilities.cpp helper file.

  • GNUmakefile.list.am: Added GtkUtilities to the source list.
  • platform/gtk/GtkUtilities.cpp: Added. (WebCore::convertWidgetRectToScreenRect):
  • platform/gtk/GtkUtilities.h: Added.

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract the code to translate from widget space to screen space into
a helper method in WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities. (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Add an implementation of PageClient::windowToScreen for GTK+ WebKit2 using
the newly abstracted widget to screen coordinate translation code in WebCore.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::windowToScreen): Added implementation.
4:12 PM Changeset in webkit [85986] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Disable platform/win/plugins/visibility-hidden.html.

  • platform/chromium/test_expectations.txt:
4:07 PM Changeset in webkit [85985] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove some unnecessary static methods in ResourceHandleSoup.

No new tests. This is only a small cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly. (WebCore::gotHeadersCallback):Ditto. (WebCore::contentSniffedCallback):Ditto. (WebCore::sendRequestCallback):Ditto. (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
4:06 PM Changeset in webkit [85984] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] ResourceHandles are leaked on 304 responses
​https://bugs.webkit.org/show_bug.cgi?id=60413

Always call cleanupSoupRequestOperation, even when the request was not
canceled. Before the code would call didFinishLoading and then never clean up
the request.

No new tests. This simply fixes a memory leak.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
3:50 PM Changeset in webkit [85983] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Simplify the PluginInfoStore interface
​https://bugs.webkit.org/show_bug.cgi?id=60406

Just expose a single API for getting a list of plug-ins from the info store,
PluginInfoStore::plugins and remove PluginInfoStore::getPlugins and PluginInfoStore::getPluginPaths.

Also, change the WebContext::pluginInfoStore() getter to return a reference.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): (WebKit::WebContext::getPluginPath):
  • UIProcess/WebContext.h: (WebKit::WebContext::pluginInfoStore):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType):
3:38 PM Changeset in webkit [85982] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-05-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: crashes in race with crashing DRT
​https://bugs.webkit.org/show_bug.cgi?id=60238

This fixes a race where if we wrote the URL to DRT and
DRT crashed immediately, we could get a broken pipe
error back during the write() and not handle it correctly,
causing NRWT to also crash.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:16 PM Changeset in webkit [85981] by inferno@chromium.org
  • 61 edits
    28 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Rebaselines for r85926.
​https://bugs.webkit.org/show_bug.cgi?id=60356

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
  • platform/chromium-mac/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
3:08 PM Changeset in webkit [85980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:52 PM Changeset in webkit [85979] by inferno@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r85964, r85971 and r85967.

  • platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [85978] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make more PluginInfoStore member functions static
​https://bugs.webkit.org/show_bug.cgi?id=60401

This is a first step towards making PluginInfoStore thread safe.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
2:12 PM Changeset in webkit [85977] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • fast/events/popup-blocked-from-mousemove-expected.txt: Added.
  • fast/events/popup-blocked-from-mousemove.html: Added.

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
2:06 PM Changeset in webkit [85976] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Fix error due to duplicate entry.

  • platform/chromium/test_expectations.txt:
2:03 PM Changeset in webkit [85975] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

This CSP directive is not in the CSP spec. This patch is somewhat of
an experiment to see whether this feature is useful. Based on our
implementation experience, we will coordinate with folks via the W3C to
see if this makes sense to add to the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:52 PM Changeset in webkit [85974] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
​https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
1:29 PM Changeset in webkit [85973] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Fix two warnings of unused variables.
​https://bugs.webkit.org/show_bug.cgi?id=60370

Remove two unused local variable from the code.

No new tests, the existing ones should cover.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateNextProgressTime):
1:13 PM Changeset in webkit [85972] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
    • Boo different error messages.
  • platform/chromium/test_expectations.txt:
    • Test progression.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
1:07 PM Changeset in webkit [85971] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.
12:22 PM Changeset in webkit [85970] by enne@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline changes after r85959
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [85969] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a --skip-integrationtests mode to test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=60354

These two test suites account for 2/3 of test-webkitpy's running time
because they're not actually unit tests. They're integration tests.
This patch adds the ability to skip integration tests by passing a
command line argument to test-webkitpy. The buildbots will continue to
run these integration tests to make sure they don't regress. This
option is for use by developers when working on parts of the code that
are well-covered by unit tests.

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
  • Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
12:14 PM Changeset in webkit [85968] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[results.html] label the zoomed pixel containers (expected, actual, diff)
​https://bugs.webkit.org/show_bug.cgi?id=60383

  • fast/harness/results.html:
12:10 PM Changeset in webkit [85967] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Add pixel results for mac.

  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.
12:09 PM Changeset in webkit [85966] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 John Abd-El-Malek <​jam@chromium.org>

Reviewed by James Robinson.

[chromium]: Reland using WebPermissionClient for checking indexed db usage
​https://bugs.webkit.org/show_bug.cgi?id=60386

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
12:05 PM Changeset in webkit [85965] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Add baselines to chromium for video-source-error that reflect the fact that
chromium does not support mp4.

[chromium] Rebaseline needed for video-source-error
​https://bugs.webkit.org/show_bug.cgi?id=60292

  • platform/chromium/media/video-source-error-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [85964] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank

Reviewed by Dan Bernstein.

Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.

Source/WebCore:

Added fast/block/positioning/hiding-inside-relpositioned-inline.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

  • fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
11:49 AM Changeset in webkit [85963] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: move selection test into the text area branch.

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
11:48 AM Changeset in webkit [85962] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a

missing #import.

11:41 AM Changeset in webkit [85961] by Adam Roben
  • 18 edits
    3 adds in trunk

Show/hide windowed plugins according to the plugin element's visibility CSS property

Fixes <​http://webkit.org/b/60285> <rdar://problem/9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed

Reviewed by Anders Carlsson.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::isPluginVisible):

  • PluginProcess/PluginControllerProxy.h:

Stubbed out.

  • Shared/win/WindowGeometry.cpp:

(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):

  • Shared/win/WindowGeometry.h:

Added visible member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::visibilityDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Added. Calls through to platform-specific code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformVisibilityDidChange):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.

  • WebProcess/Plugins/Plugin.h: Added visibilityDidChange.
  • WebProcess/Plugins/PluginController.h: Added isPluginVisible.
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::visibilityDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Stubbed out.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.

(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.

  • WebProcess/Plugins/PluginView.h: Updated for PluginController changes.

LayoutTests:

Add a test that shows that windowed plugins with visibility:hidden do not appear on screen

I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <​http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.

  • platform/win/plugins/visibility-hidden-expected.png: Added.
  • platform/win/plugins/visibility-hidden-expected.txt: Added.
  • platform/win/plugins/visibility-hidden.html: Added.
11:35 AM Changeset in webkit [85960] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The results.zip generated by the Chromium EWS are too big
​https://bugs.webkit.org/show_bug.cgi?id=60352

Currently results.zip created by the Chromium EWS bot contain roughly
1000 tests that we expect to fail. These test results are not helpful
to contributors.

There are several approaches to solving this problem:

1) We could be more selective about which files to include in the zip.
2) We could ask new-run-webkit-tests not to generate results for

expected failures.

3) We could ask new-run-webkit-tests not to run tests that we expect to

fail.

This patch takes approach (3). Currently, we're ignoring the outcome
of failing tests anyway, so there's not much point in actually running
them. As a side benefit, this will speed up the test run by about 6%.
In the future, we might revisit this decision and choose another
approach.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
10:41 AM Changeset in webkit [85959] by enne@google.com
  • 4 edits
    4 adds in trunk

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Added.
  • compositing/flat-with-transformed-child.html: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

Allow for empty scissor rects, which implies scissoring to the render
surface. The previous code and previous patch on this bug both didn't
take into account that the scissor rect should be the render surface
and not the projection of the layer itself, because child layers
aren't necessarily contained within the bounds of their superlayer.

Test: compositing/flat-with-transformed-child.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
10:30 AM Changeset in webkit [85958] by Adam Roben
  • 15 edits
    2 adds in trunk/Source/WebKit2

Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message

This will make it easier to add more info to this message in the future (like whether the
window is visible).

Fixes <​http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious

Reviewed by Anders Carlsson.

  • Scripts/webkit2/messages.py:

(struct_or_class): Added WindowGeometry to the list of structs.

  • Shared/win/WindowGeometry.cpp: Added.
  • Shared/win/WindowGeometry.h: Added.
  • win/WebKit2.vcproj: Added new files.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.

10:22 AM Changeset in webkit [85957] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Mihai Parparita.

[results.html] zoomed pixel results should not be antialiased
​https://bugs.webkit.org/show_bug.cgi?id=60330

-Use canvas instead of CSS zoom.
-Only zoom the part of the image we need to show.
-Make pixel zooming mostly work in Firefox.
-Increase the zoom from 3x to 6x.

  • fast/harness/results.html:
10:22 AM Changeset in webkit [85956] by ddkilzer@apple.com
  • 4 edits in trunk/Source

Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings

Reviewed by Jon Honeycutt.

This fixes an Xcode 4 warning about using obsolete settings.

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

10:12 AM Changeset in webkit [85955] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-05-06 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Lazily allocate ScrollAnimator in ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=60327

Avoid allocating the ScrollAnimator up-front, because we
create lots of ScrollableAreas via RenderLayer, and we should
only need the animator when scrolling.

  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::ScrollableArea): (WebCore::ScrollableArea::scrollAnimator): (WebCore::ScrollableArea::scroll): (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation): (WebCore::ScrollableArea::handleWheelEvent): (WebCore::ScrollableArea::handleGestureEvent):
  • platform/ScrollableArea.h:
10:04 AM Changeset in webkit [85954] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85919.
​http://trac.webkit.org/changeset/85919
​https://bugs.webkit.org/show_bug.cgi?id=60378

broke chromium database tests (Requested by inferno-sec on
#webkit).

  • public/WebPermissionClient.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
9:55 AM Changeset in webkit [85953] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement NetscapePlugin::platformPaint for GTK platform
​https://bugs.webkit.org/show_bug.cgi?id=60368

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformPaint):
9:37 AM Changeset in webkit [85952] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4

Create the 1.4 stable branch

9:03 AM Changeset in webkit [85951] by Carlos Garcia Campos
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

Share PluginInfoStore implementation between Qt and GTK ports
​https://bugs.webkit.org/show_bug.cgi?id=60366

  • GNUmakefile.am:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Removed.
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.pro:
8:51 AM Changeset in webkit [85950] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, fix parse errors in test_expectations.

I will annotate bug 60356 so that this case gets looked at.

  • platform/chromium/test_expectations.txt:
8:23 AM Changeset in webkit [85949] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
​https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/9392609>

Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.

Tested manually because we don't have any live streams to test in DRT.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay. (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay. (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::reset): Ditto. (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:
8:06 AM Changeset in webkit [85948] by Adam Roben
  • 3 deletes in trunk/LayoutTests/platform/win/plugins

Roll out r85946

I didn't mean to commit it!

8:04 AM Changeset in webkit [85947] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Touch WebKit.idl to fix the build

I needed this on my own machine. Maybe others will need it, too.

  • Interfaces/WebKit.idl:
8:02 AM Changeset in webkit [85946] by Adam Roben
  • 3 adds in trunk/LayoutTests/platform/win/plugins

Add a test for visibility:hidden for plugins

7:46 AM Changeset in webkit [85945] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.

std::tr1::has_trivial_constructor is in <tr1/memory>.

  • wtf/TypeTraits.h:
7:35 AM Changeset in webkit [85944] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed Qt 4.8 build fix.

  • WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can enable it after the 4.8 bots are updated with the full QRawFont APIs.
6:48 AM Changeset in webkit [85943] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
​https://bugs.webkit.org/show_bug.cgi?id=60319

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
6:24 AM Changeset in webkit [85942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use qt-arm platform instead of qt-linux on ARM platform.

Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
3:51 AM Changeset in webkit [85941] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

[Qt]fast/events/backspace-navigates-back.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60349

  • platform/mac-wk2/Skipped: Add fast/events/backspace-navigates-back.html because of missing layoutTestController.setEditingBehavior().
  • platform/qt-arm/Skipped: Add fast/events/backspace-navigates-back.html.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-mac/Skipped: Add fast/events/backspace-navigates-back.html.
2:17 AM Changeset in webkit [85940] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <​pnormand@igalia.com>

Windows DRT needs an implementation of shadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=59081

Skip media/video-controls-visible-audio-only.html that now
requires shadowRoot support.

  • platform/win/Skipped:
1:58 AM Changeset in webkit [85939] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8. Relative urls should not be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=57138

  • http/tests/websocket/tests/url-with-nonascii-query-expected.txt: Added.
  • http/tests/websocket/tests/url-with-nonascii-query.html: Added.
  • http/tests/websocket/tests/url-parsing-expected.txt: Failure message for relative url has changed since it is no longer expanded.

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8.
​https://bugs.webkit.org/show_bug.cgi?id=57138

Change WebSocket::connect to take the raw URL string and parse it
internally using the simple KURL constructor, which expects an absolute
UTF-8 encoded URL. This ensures that all code that creates a WebSocket
goes through this method instead of completeURL.

Test: http/tests/websocket/tests/url-with-nonascii-query.html

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
  • websockets/WebSocket.h:
1:42 AM Changeset in webkit [85938] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
​https://bugs.webkit.org/show_bug.cgi?id=60339

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialColorSpace): Add initialColorSpace() static method.
1:33 AM Changeset in webkit [85937] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed, marking tests whose expectations became obsolete since r85926.

  • platform/chromium/test_expectations.txt:
1:27 AM Changeset in webkit [85936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setPageBreakInside() reject unsupported enum values.
​https://bugs.webkit.org/show_bug.cgi?id=60235

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setPageBreakInside): Assert that only supported values are used.
1:17 AM Changeset in webkit [85935] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Move burden of checking for BJustify box alignment into RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=60246

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case logic checking for BJUSTIFY and use existing macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBoxAlign): Assert valid values are used.
1:00 AM Changeset in webkit [85934] by Philippe Normand
  • 7 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Layout tests shouldn't have to hard code media controller element locations
​https://bugs.webkit.org/show_bug.cgi?id=28220

New mediaControlsButtonCoordinates() function to get the middle
coordinates of a media controls button. This avoids hardcoding
positions in the tests.

Also unskipped the affected GTK media tests now passing.

  • media/audio-delete-while-step-button-clicked.html:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (mediaControlsButtonCoordinates):
  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [85933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
​https://bugs.webkit.org/show_bug.cgi?id=60338

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
12:47 AM Changeset in webkit [85932] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (send-form-data-with-sliced-file.html)

  • platform/chromium/test_expectations.txt:
12:45 AM Changeset in webkit [85931] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85860.

  • UIProcess/API/gtk/PageClientImpl.h: Fix typo.
12:43 AM Changeset in webkit [85930] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (resource-tree-frame-navigate.html)

  • platform/chromium/test_expectations.txt:
12:39 AM Changeset in webkit [85929] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/mac-wk2/Skipped:
    • Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
  • platform/qt-arm/Skipped:
    • Add fast/css/hover-update.html, because it fails intermittently.
    • Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-wk2/Skipped:
    • Add new but failing test: editing/pasteboard/paste-placeholder-input.html
12:35 AM Changeset in webkit [85928] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix with gcc 4.6 and c++0x support.
​https://bugs.webkit.org/show_bug.cgi?id=60284

When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.

No new tests, build fix.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::create):
12:33 AM Changeset in webkit [85927] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

Add an option to NRWT to skip failing tests
​https://bugs.webkit.org/show_bug.cgi?id=60295

This option is similar to the way old-run-webkit-tests works. We're
planning to use this option on the testing EWS bots because they don't
use information from failing tests yet.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:33 AM Changeset in webkit [85926] by cdn@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Change maxEffectRect to a FloatRect.
​https://bugs.webkit.org/show_bug.cgi?id=59551

  • svg/filters/filter-after-transform-crash-expected.txt: Added.
  • svg/filters/filter-after-transform-crash.svg: Added.

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Tests for crash when a transform is applied to certain filters.
​https://bugs.webkit.org/show_bug.cgi?id=59551

Test: svg/filters/filter-after-transform-crash.svg

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::determineAbsolutePaintRect):
  • platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  • platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  • platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
  • platform/graphics/filters/FELighting.h: (WebCore::FELighting::determineAbsolutePaintRect):
  • platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
  • platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::isFilterSizeValid): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::maxEffectRect): (WebCore::FilterEffect::setMaxEffectRect):
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
12:27 AM Changeset in webkit [85925] by Philippe Normand
  • 38 edits in trunk

Tools:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

shadowPseudoId support in the various LayoutTestController
implementations.

  • DumpRenderTree/LayoutTestController.cpp: (shadowPseudoIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

WebKit2:

2011-05-05 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleShadowPseudoId):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot): (WebKit::InjectedBundleNodeHandle::elementShadowPseudoId):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

WebKit/win:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOMCoreClasses.cpp: (DOMElement::shadowPseudoId):
  • DOMCoreClasses.h:

WebKit/qt:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKit/mac:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowPseudoId]):
  • DOM/WebDOMOperationsPrivate.h:

WebKit/gtk:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

WebKit/chromium:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::shadowPseudoId):

LayoutTests:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • media/video-controls-transformed.html: Refactored to use the pseudoShadowId() LayoutTestController method.
12:19 AM Changeset in webkit [85924] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (test_boolean_expr.html)

  • platform/chromium/test_expectations.txt:
12:11 AM Changeset in webkit [85923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Use cast to convert primitive value to FontSmoothingMode.
​https://bugs.webkit.org/show_bug.cgi?id=60242

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to convert primitive value to FontSmoothingMode.
12:06 AM Changeset in webkit [85922] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

EWS can't reject patches
​https://bugs.webkit.org/show_bug.cgi?id=60345

We're supposed to use patch.id() for the attachment ID, silly.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

May 5, 2011:

11:46 PM Changeset in webkit [85921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSPropertySpeak use the correct macro.
​https://bugs.webkit.org/show_bug.cgi?id=60335

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
11:44 PM Changeset in webkit [85920] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking.

  • platform/chromium/test_expectations.txt:
11:25 PM Changeset in webkit [85919] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-05 John Abd-El-Malek <​jam@chromium.org>

Reviewed by James Robinson.

[chromium] Make IndexedDB code use WebPermissionClient API
​https://bugs.webkit.org/show_bug.cgi?id=60340

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
11:22 PM Changeset in webkit [85918] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

<rdar://problem/9390864>
​https://bugs.webkit.org/show_bug.cgi?id=60343
Crash on Recovery System when trying to load page that includes media element

Automated test not possible, tested manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if

AVFoundation and CoreMedia are installed.

  • platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to

SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.

11:06 PM Changeset in webkit [85917] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed attempt to error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
10:38 PM Changeset in webkit [85916] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [85915] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:36 PM Changeset in webkit [85914] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed addding skip line for full-screen-stacking-context.html.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [85913] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Live streams sometimes won't play with AVFoundation backend
​https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748

Tested manually because we don't have any live streams to test in DRT.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume

AVFoundation will notify us when internal states change.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver

a RetainPtr

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
7:18 PM Changeset in webkit [85912] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Ojan Vafai <​ojan@chromium.org>

Now that win has a failing result, chromium-win needs to
have the passing result. ​http://trac.webkit.org/changeset/85911

  • platform/chromium/fast/harness/results-expected.txt: Added.
7:04 PM Changeset in webkit [85911] by ojan@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2011-05-05 Ojan Vafai <​ojan@chromium.org>

Move failing result as it appears to be failing on all Apple Win platforms.

  • platform/win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/win-7sp0/fast/harness/results-expected.txt.
6:43 PM Changeset in webkit [85910] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Evan Martin <​evan@chromium.org>

Unreviewed, just skipping a test.

New test fast/events/backspace-nagivates-back fails on Qt
​https://bugs.webkit.org/show_bug.cgi?id=60311

Skip this test until Antonoi has time to look at it.

  • platform/qt-linux/Skipped:
6:37 PM Changeset in webkit [85909] by jcivelli@chromium.org
  • 9 edits
    2 adds in trunk/Source

2011-05-05 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Adam Barth.

Added convenience methods to convert from a byte to hex ASCII digit
characters and vice-versa.
​https://bugs.webkit.org/show_bug.cgi?id=59834

  • wtf/ASCIICType.h: (WTF::toASCIIHexValue): (WTF::lowerNibbleToASCIIHexDigit): (WTF::upperNibbleToASCIIHexDigit):

2011-05-05 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding quoted-printable encoding/decoding capabilities.
This is needed for MHTML support.
​https://bugs.webkit.org/show_bug.cgi?id=59834

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/QuotedPrintable.cpp: Added.
  • platform/text/QuotedPrintable.h: Added.
6:00 PM Changeset in webkit [85908] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

REGRESSION (r85689): Unresponsive timer firing when closing background tabs
<rdar://problem/9385988>
​https://bugs.webkit.org/show_bug.cgi?id=60325

When calling WKPageTryClose(), if the page close succeeded, the notification to stop
the responsiveness timer would be dropped because the page was closed by the time it
got to the UIProcess.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::closePage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add parameter to closePage stipulating whether or not to stop the responsiveness timer.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): (WebKit::WebPage::sendClose): Instead of sending a StopResponsivenessTimer message after sending the ClosePage message, add a bit to the ClosePage message.
5:52 PM Changeset in webkit [85907] by jer.noble@apple.com
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, partial rollout of r85843 and r85824. r85897 made these expected results unnecessary.

  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Removed.
5:48 PM Changeset in webkit [85906] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

Fixed typos in a comment

5:28 PM Changeset in webkit [85905] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-05 Steve Lacey <​sjl@chromium.org>

Reviewed by Ojan Vafai.

Fix generation of results html file by passing relative path to scm
methods.
Generate diff images for results html file.

​https://bugs.webkit.org/show_bug.cgi?id=60086

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
5:19 PM Changeset in webkit [85904] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Jian Li.

[Chromium] Remove non-flaky tests (BUGCR81682, BUGCR80067)
and skip one unsupported test in test expectation file (BUGCR59399).
​https://bugs.webkit.org/show_bug.cgi?id=60282

The skipped test is a cliking test that is specific to Mac and we
(Chrome Video Stack team) decided not to support it.

  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [85903] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

Implement document.innerHTML
​https://bugs.webkit.org/show_bug.cgi?id=60316

ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
for fragment parsing. This assertion will become invalid when
document.innerHTML is implemented, which is the only case where HTML5
specifies that a fragment will not have a context element.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
5:12 PM Changeset in webkit [85902] by kevino@webkit.org
  • 5 edits in trunk

[wx] Unreviewed build fixes after recent trunk changes.

5:09 PM Changeset in webkit [85901] by mitz@apple.com
  • 11 edits in trunk

Source/WebCore: WebCore part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
check in Core Animation.

  • platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac: WebKit part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

Source/WebKit2: WebKit2 part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

WebKitLibraries: WebKitSystemInterface part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebKitSystemInterface.h: Added WKExecutableWasLinkedOnOrBeforeSnowLeopard().
4:56 PM Changeset in webkit [85900] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 (Mac): Background tabs/windows can force themselves to the front
<rdar://problem/9386346>
​https://bugs.webkit.org/show_bug.cgi?id=60315

  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): It is incorrect for us to call Chrome::focus() here, which could bring a window/tab to the front. Calling focusNSView() was only necessary because in WebKit we must inform the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
4:54 PM Changeset in webkit [85899] by commit-queue@webkit.org
  • 58 edits
    7 deletes in trunk/LayoutTests

2011-05-05 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Seidel.

Rebaseline various media tests after absolute positioning change. This rebaseline also
fixes outstanding minor pixel diffs.

[chromium] Rebaseline various media tests after controls absolute positioning changes
​https://bugs.webkit.org/show_bug.cgi?id=60230

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-strict-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-styling-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.txt: Removed.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [85898] by aestes@apple.com
  • 2 edits in trunk/Tools

2011-05-05 Andy Estes <​aestes@apple.com>

Reviewed by Daniel Bates.

update-webkit should handle Internal using a different VCS than OpenSource.
​https://bugs.webkit.org/show_bug.cgi?id=60310

isGit() and isSVN() cache their results, so Internal will always be
updated using the VCS commands used for OpenSource. If Internal uses a
different VCS, this will fail. Fix this by calling isGitDirectory() and
isSVNDirectory() instead, which do not cache their results.

  • Scripts/update-webkit:
4:07 PM Changeset in webkit [85897] by jer.noble@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

2011-05-05 Jer Noble <​jer.noble@apple.com>

Reviewed by Tony Chang.

full-screen-stacking-context-expected.txt should be under platform/mac
​https://bugs.webkit.org/show_bug.cgi?id=60236

Make the text output of full screen pixel tests platform agnostic.

  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-zIndex-expected.txt:
  • platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Removed.
3:42 PM Changeset in webkit [85896] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-05-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: revamp integration tests incl. tests for servers
​https://bugs.webkit.org/show_bug.cgi?id=59985

This change adds the ability to run "integration tests" that
depend on (and affect) the local environment on your machine.
These tests can be run manually by invoking python on the
test file in question and passing the '-i' flag, but are
not run automatically as part of test-webkitpy.

Integration tests are identified by being methods named as
"integration_test_*" instead of "test_*", and we use a
custom TestLoader instead of the default one provided by
unittest.

This change also adds a protected "_default_to_apache" method
to the port object so we can do the right thing when starting
and stopping web servers with less mechanism.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
3:39 PM Changeset in webkit [85895] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
​https://bugs.webkit.org/show_bug.cgi?id=60173

  • platform/chromium/test_expectations.txt: Adding expected failures for the the switch to Ganesh

2011-05-05 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
​https://bugs.webkit.org/show_bug.cgi?id=60173

  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Flipping the switch to make Skia the default for the accelerated 2d canvas
3:38 PM Changeset in webkit [85894] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
​https://bugs.webkit.org/show_bug.cgi?id=60101

  • fast/parser/close-while-stopping-expected.txt: Added.
  • fast/parser/close-while-stopping.html: Added.

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
​https://bugs.webkit.org/show_bug.cgi?id=60101

Test: fast/parser/close-while-stopping.html

3:23 PM Changeset in webkit [85893] by evan@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-03 Evan Martin <​evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
​https://bugs.webkit.org/show_bug.cgi?id=59731

Add a test that verifies that pressing backspace goes back on Mac
and Windows but does not go back on Linux.

  • fast/events/backspace-navigates-back-expected.txt: Added.
  • fast/events/backspace-navigates-back.html: Added.

2011-04-28 Evan Martin <​evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
​https://bugs.webkit.org/show_bug.cgi?id=59731

Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
Linux, and test for it in the default backspace handler.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultBackspaceEventHandler):
3:14 PM Changeset in webkit [85892] by hclam@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-05-05 Alpha Lam <​hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations.

  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
3:10 PM Changeset in webkit [85891] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-05 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Kenneth Russell.

Framebuffer object is being created twice
​https://bugs.webkit.org/show_bug.cgi?id=60207

Does not create more than one opengl framebuffer

  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gtk/DrawingBufferGtk.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
3:09 PM Changeset in webkit [85890] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-05-05 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Every RenderLayer registers itself as a ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=59650

Rather than registering every RenderLayer as a ScrollableArea
on layer creation, only register RenderLayers which are overflow-
scrollable. Use the m_scrollableAreaPage pointer to keep track
of whether we've registered to avoid excess work.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollsOverflow): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
3:06 PM Changeset in webkit [85889] by Adam Roben
  • 4 edits in trunk

Update pixel results for draws-gradient.html to have an alpha channel

These pixel results were generated in r71418, when DRT was changed not to use an alpha
channel for pixel results. DRT was changed back to using an alpha channel in r71516, but
these pixel results were never updated. Now that DRT ensures that the alpha channel is
filled with constant opacity, we can safely update these pixel results without negatively
affecting their appearance. (The draws-gradient plugin uses ::GradientFill, which fills the
alpha channel with 0, so the plugin would have shown up as fully transparent in the pixel
results if DRT didn't modify the alpha channel.)

Fixes <​http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
generated due to alpha channel weirdness

Reviewed by Sam Weinig.

LayoutTests:

  • platform/win/platform/win/plugins/draws-gradient-expected.png: Regenerated. Looks the same

as before, but with an alpha channel.

Tools:

Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows

DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
alpha channel will even get filled with zeros (like when ::GradientFill is used). To
safeguard against this, we fill the alpha channel with constant full opacity after the
WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
results need an alpha channel, too.)

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
constant full opacity.
(createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
in a CGContext or cairo_surface.

3:05 PM Changeset in webkit [85888] by Adam Roben
  • 6 edits in trunk/Tools

Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner

Passing true tells the test harness to dump pixels even though we're not dumping a render
tree.

Fixes <​http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
WebKitTestRunner doesn't result in pixel results being generated

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels

argument to dumpAsText.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for dumpAsText change.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows

developers.

3:04 PM Changeset in webkit [85887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] Add method to disable plugins under WK2
​https://bugs.webkit.org/show_bug.cgi?id=57796

  • config.h: Allow PLUGIN_ARCHITECTURE_UNSUPPORTED to be defined on build command line
2:59 PM Changeset in webkit [85886] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Jer Noble <​jer.noble@apple.com>

Reviewed by Steve Falkenburg.

Workaround iTunes' incorrect registry entry for .m4a extensions.
​https://bugs.webkit.org/show_bug.cgi?id=60229

No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
The test failed to catch this regression because the build bots haven't installed iTunes.

Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.

  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2:57 PM Changeset in webkit [85885] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Minor rebaselines for gtk after my r85876.

  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
2:49 PM Changeset in webkit [85884] by tony@chromium.org
  • 1 edit
    10 deletes in trunk/LayoutTests

2011-05-05 Tony Chang <​tony@chromium.org>

Remove google-chrome-linux results. We're switching the official
builders from hardy to lucid and want to clear the old hardy based
results.

  • platform/google-chrome-linux32/css1: Removed.
  • platform/google-chrome-linux32/css2.1: Removed.
  • platform/google-chrome-linux32/editing: Removed.
  • platform/google-chrome-linux32/fast: Removed.
  • platform/google-chrome-linux32/plugins: Removed.
  • platform/google-chrome-linux32/svg: Removed.
  • platform/google-chrome-linux32/tables: Removed.
  • platform/google-chrome-linux32/transforms: Removed.
  • platform/google-chrome-linux64/fast: Removed.
  • platform/google-chrome-linux64/svg: Removed.
2:49 PM Changeset in webkit [85883] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:42 PM Changeset in webkit [85882] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Minor rebaselines for qt after my r85876.

  • platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
2:42 PM Changeset in webkit [85881] by Lucas Forschler
  • 1 copy in tags/Safari-534.34

New tag.

2:41 PM Changeset in webkit [85880] by dpranke@chromium.org
  • 6 edits in trunk

2011-05-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

Modify the chromium expectations so that you no longer need to
specify both the operating system and the version. I.e., you
don't need "MAC LEOPARD", just "LEOPARD".

  • platform/chromium/test_expectations.txt:

2011-05-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge os, version fields in test config
​https://bugs.webkit.org/show_bug.cgi?id=60004

This change removes the 'o/s' field from the TestConfiguration
object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
the expectations file to macros that expand to the version names
for each platform.

This means that you can once again put any subset of the
operating system versions on a single line, e.g.:

BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL

This change will break any existing test_expectations.txt
file that uses the "OS-VERSION" macros, which are no longer
needed. It turns out they were never needed, as just VERSION
by itself was sufficient. The test_expectations.txt file should
be updated accordingly prior to landing this change.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
2:26 PM Changeset in webkit [85879] by tony@chromium.org
  • 17 edits
    6 copies
    13 adds in trunk

2011-05-05 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
​https://bugs.webkit.org/show_bug.cgi?id=60287

Rebase tests that have Thai or Hindi glyphs. We have different
results for x86_64 (lucid) and x86 (hardy) because the fonts have
changed. Since it's only a handful of tests, seems ok to have
separate baselines (also, hardy is going away real soon now).

  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png.
  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/complex-text-opacity-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/danda-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.txt: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.png:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux/fast/text/international/danda-space-expected.txt:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:

2011-05-05 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
​https://bugs.webkit.org/show_bug.cgi?id=60287

The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
packages on Lucid. There are actually multiple Thai fonts in the
package, so I just picked one.

  • DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig):
2:14 PM Changeset in webkit [85878] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

When an underlay surface is active, paint normal web contents in a transparency layer
​https://bugs.webkit.org/show_bug.cgi?id=60296

In order for the page contents to correctly blend with the underlay, the page contents
needs to be painted in a transparency layer.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
2:13 PM Changeset in webkit [85877] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-05-05 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
​https://bugs.webkit.org/show_bug.cgi?id=60290

It used to be that google-chrome-32 was hardy32, google-chrome-64 was
hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
lucid64. Because of that, google-chrome-64 used to skip the
chromium-linux-x86_64 results since they were more incorrect.

Now that we're switching to lucid for google-chrome, we want
google-chrome-64 to fall back to chromium-linux-x86_64.

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
2:07 PM Changeset in webkit [85876] by inferno@chromium.org
  • 4 edits
    14 adds in trunk

2011-05-05 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

When style changes for a RenderBlock and we lose our ability to intrude into
floats in the next siblings block (e.g a position change), make sure to mark
our childs with floats for layout and iterate through our next sibling block
chain to see which ones contain the float that also exists in our floating
objects list and clear those using markAllDescendantsWithFloatsForLayout.
​https://bugs.webkit.org/show_bug.cgi?id=56299

Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html

fast/block/float/float-not-removed-from-next-sibling.html
fast/block/float/float-not-removed-from-next-sibling2.html
fast/block/float/float-not-removed-from-next-sibling3.html
fast/block/float/float-not-removed-from-next-sibling4.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
  • rendering/RenderBlock.h:

2011-05-04 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to add overflow from a float not in the
descendant list and whose renderer is already removed.
​https://bugs.webkit.org/show_bug.cgi?id=56299

  • fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
  • fast/block/float/float-not-removed-from-next-sibling.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
1:55 PM Changeset in webkit [85875] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-05-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
​https://bugs.webkit.org/show_bug.cgi?id=60002

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
1:31 PM Changeset in webkit [85874] by bweinstein@apple.com
  • 6 edits in trunk/Source

Source/WebCore: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
​https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Make a needed function public and export it.

  • WebCore.exp.in: Export constrainedAttaechedWindowHeight.
  • inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.

Source/WebKit2: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
​https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Before we place the inspector and the inspected views, make sure that we have constrained the height
of the docked inspector. Putting the code here covers both when the inspector is initially attached
and when a window with the docked inspector is resized.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Constrain the height before laying out the views.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Ditto.

1:30 PM Changeset in webkit [85873] by tonyg@chromium.org
  • 6 edits in trunk

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
​https://bugs.webkit.org/show_bug.cgi?id=59448

  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/webtiming-origins-expected.txt:

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
​https://bugs.webkit.org/show_bug.cgi?id=59448

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart):
1:21 PM Changeset in webkit [85872] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

Block callbacks delivered during destruction
​https://bugs.webkit.org/show_bug.cgi?id=60291
<rdar://problem/9382942>

No new tests, tested by existing tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call

setIgnoreLoadStateChanges(true) to cancel all callbacks.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if

m_ignoreLoadStateChanges is true.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.

Don't call updateStates after calling loadedTimeRangesChanged, it already does it.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1:18 PM Changeset in webkit [85871] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should reject patches which fail ewses
​https://bugs.webkit.org/show_bug.cgi?id=47534

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1:13 PM Changeset in webkit [85870] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Prasanth Ullattil <​prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=57621

  • Source/sync.profile:

2011-05-05 Prasanth Ullattil <​prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=57621

1:04 PM Changeset in webkit [85869] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Darin Adler.

Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).

Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

12:21 PM Changeset in webkit [85868] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-05 Bharathwaaj Srinivasan <​bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
​https://bugs.webkit.org/show_bug.cgi?id=60257

No new tests. This is just a build fix.

  • bindings/js/JSDOMBinding.cpp:

2011-05-05 Bharathwaaj Srinivasan <​bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
​https://bugs.webkit.org/show_bug.cgi?id=60257

  • webkit/webkitglobals.cpp: (webkitInit):
12:05 PM Changeset in webkit [85867] by commit-queue@webkit.org
  • 11 edits in trunk

2011-05-05 Chang Shu <​cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
​https://bugs.webkit.org/show_bug.cgi?id=59638

Unskip passed tests.

  • platform/qt-wk2/Skipped:

2011-05-05 Chang Shu <​cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
​https://bugs.webkit.org/show_bug.cgi?id=59638

Added private constructors for class QGraphicsWKView and QWKPage to support
WKPageGroupRef.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::~QGraphicsWKView): (QGraphicsWKView::init):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::QWKPage): (QWKPage::~QWKPage): (QWKPage::init):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

2011-05-05 Chang Shu <​cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
​https://bugs.webkit.org/show_bug.cgi?id=59638

  1. Call QGraphicsWKView constructor with pageGroupRef.
  2. Disable setFontFamily calls as it breaks Qt test fonts.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView):
11:22 AM Changeset in webkit [85866] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-05 Adam Barth <​abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
11:17 AM Changeset in webkit [85865] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

The preload attribute of the video tag is not completely implemented
​https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/9369746>

This change implements "preload=metadata" for the AVFoundation backend.
Tested manually with manual-tests/media-elements/video-preload.html.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'

because we need to have media data loaded to seek.

(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.

  • html/HTMLMediaElement.h:
  • manual-tests/media-elements/video-preload.html: Make changing urls work.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove

m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.

(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.

Move all preload logic to setPreload, call it from here.

(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to

setPreload, call it.

(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is

unlikely to be correct and isn't worth caching. Use invalidTime() function.

(WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus

to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
without one. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache

width, height, hasVideo, etc.

(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done

in derived classes.

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create

AVAsset and AVPlayerItem here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_videoFrameHasDrawn.

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from

videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset

if necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when

the buffer is full.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the

AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset

when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before

we have allocated the AVPlayerItem.

11:14 AM Changeset in webkit [85864] by rniwa@webkit.org
  • 88 edits
    5 moves in trunk/Source

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds): (WebKit::WebViewImpl::caretOrSelectionRange): (WebKit::WebViewImpl::clearFocusedNode):

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • Api/qwebframe.cpp:

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • webkit/webkitwebview.cpp: (getLocationForKeyboardGeneratedContextMenu):

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView.cpp:

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebDOMSelection.cpp:
  • WebDOMSelection.h:
  • WebKitSupport/EditorClientWx.cpp:
  • WebView.cpp:

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
  • WebView/WebView.mm:

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60234

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • bindings/objc/ExceptionHandlers.h:
  • css/CSSStyleSelector.cpp:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
  • dom/Document.cpp:
  • dom/InputElement.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:
  • editing/EditingAllInOne.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::Editor::canCopy): (WebCore::Editor::canDelete): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeSelectionAfterCommand): (WebCore::Editor::respondToChangedSelection):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeDeleteToMark): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  • editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp. (WebCore::FrameSelection::FrameSelection): (WebCore::FrameSelection::moveTo): (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::nodeWillBeRemoved): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWillBeReplaced): (WebCore::FrameSelection::setIsDirectional): (WebCore::FrameSelection::directionOfEnclosingBlock): (WebCore::FrameSelection::willBeModified): (WebCore::FrameSelection::positionForPlatform): (WebCore::FrameSelection::startForPlatform): (WebCore::FrameSelection::endForPlatform): (WebCore::FrameSelection::modifyExtendingRight): (WebCore::FrameSelection::modifyExtendingForward): (WebCore::FrameSelection::modifyMovingRight): (WebCore::FrameSelection::modifyMovingForward): (WebCore::FrameSelection::modifyExtendingLeft): (WebCore::FrameSelection::modifyExtendingBackward): (WebCore::FrameSelection::modifyMovingLeft): (WebCore::FrameSelection::modifyMovingBackward): (WebCore::FrameSelection::modify): (WebCore::FrameSelection::xPosForVerticalArrowNavigation): (WebCore::FrameSelection::clear): (WebCore::FrameSelection::setStart): (WebCore::FrameSelection::setEnd): (WebCore::FrameSelection::setBase): (WebCore::FrameSelection::setExtent): (WebCore::FrameSelection::setCaretRectNeedsUpdate): (WebCore::FrameSelection::updateCaretRect): (WebCore::FrameSelection::caretRenderer): (WebCore::FrameSelection::localCaretRect): (WebCore::FrameSelection::absoluteBoundsForLocalRect): (WebCore::FrameSelection::absoluteCaretBounds): (WebCore::FrameSelection::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::shouldRepaintCaret): (WebCore::FrameSelection::invalidateCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::FrameSelection::debugRenderer): (WebCore::FrameSelection::contains): (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): (WebCore::FrameSelection::selectAll): (WebCore::FrameSelection::setSelectedRange): (WebCore::FrameSelection::isInPasswordField): (WebCore::FrameSelection::caretRendersInsideNode): (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::pageActivationChanged): (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive): (WebCore::FrameSelection::setUseSecureKeyboardEntry): (WebCore::FrameSelection::setFocused): (WebCore::FrameSelection::isFocusedAndActive): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisible): (WebCore::FrameSelection::clearCaretRectIfNeeded): (WebCore::FrameSelection::caretBlinkTimerFired): (WebCore::FrameSelection::notifyRendererOfSelectionChange): (WebCore::FrameSelection::setFocusedNodeIfNeeded): (WebCore::FrameSelection::paintDragCaret): (WebCore::FrameSelection::copyTypingStyle): (WebCore::FrameSelection::shouldDeleteSelection): (WebCore::FrameSelection::bounds): (WebCore::FrameSelection::getClippedVisibleTextRectangles): (WebCore::FrameSelection::currentForm): (WebCore::FrameSelection::revealSelection): (WebCore::FrameSelection::setSelectionFromNone): (WebCore::FrameSelection::shouldChangeSelection): (WebCore::FrameSelection::formatForDebugger): (WebCore::FrameSelection::showTreeForThis): (showTree):
  • editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h. (WebCore::FrameSelection::typingStyle): (WebCore::FrameSelection::clearTypingStyle): (WebCore::FrameSelection::setTypingStyle): (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/ModifySelectionListLevel.cpp:
  • editing/RemoveFormatCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SelectionController.cpp: Removed.
  • editing/SelectionController.h: Removed.
  • editing/SetSelectionCommand.cpp: (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
  • editing/SetSelectionCommand.h: (WebCore::SetSelectionCommand::create):
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/chromium/SelectionControllerChromium.cpp: Removed.
  • editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/gtk/SelectionControllerGtk.cpp: Removed.
  • editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages):
  • editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/mac/SelectionControllerMac.mm: Removed.
  • editing/qt/EditorQt.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::type): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode):
  • page/DragController.cpp: (WebCore::DragController::dragIsMove):
  • page/DragController.h:
  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): (WebCore::setNonDirectionalSelectionIfNeeded): (WebCore::EventHandler::sendContextMenuEventForKey): (WebCore::EventHandler::handleKeyboardSelectionMovement):
  • page/EventHandler.h:
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::selection):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::dragCaretController):
  • page/chromium/DragControllerChromium.cpp:
  • page/chromium/EventHandlerChromium.cpp:
  • page/win/DragControllerWin.cpp:
  • page/win/EventHandlerWin.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::paintCaret):
  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderLayer.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTreeAsText.cpp:
  • svg/SVGSVGElement.cpp:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
11:01 AM Changeset in webkit [85863] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::cachedResponseDataForURL): Stub out
implementation for cURL networking case.

10:54 AM Changeset in webkit [85862] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] unreviewed build correction.

  • platform/network/curl/ResourceRequest.h:

Stub out the new pipelined http logic for cURL.

10:49 AM Changeset in webkit [85861] by Joseph Pecoraro
  • 2 edits in trunk/Tools

2011-05-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Add --only-webkit option to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=60245

  • Scripts/build-webkit: If --only-webkit was specified just build the WebKit project, and not its dependencies.
9:57 AM Changeset in webkit [85860] by jeffm@apple.com
  • 15 edits in trunk

2011-05-05 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=60203

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Stub out didNotHandleWheelEvent callback.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback. (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.

2011-05-05 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=60203


Remove Windows-specific WebPageProxy::wheelEventNotHandled() member function and use
didNotHandleWheelEvent callback in WKPageUIClient instead. It turns out that just
resending the wheel event to the parent window doesn't provide the client with enough context
to know that WebKit has already attempted to handle the event.

  • UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleWheelEventCallback typedef and didNotHandleWheelEvent to WKPageUIClient.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::didNotHandleWheelEvent): Added, but not implemented.
  • UIProcess/API/gtk/PageClientImpl.h: Added didNotHandleWheelEvent().
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):Stubbed out didNotHandleWheelEvent callback.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Call didNotHandleWheelEvent in WKPageUIClient if wheel event is not handled.
  • UIProcess/WebPageProxy.h: Removed wheelEventNotHandled().


  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::implementsDidNotHandleWheelEvent): Added. (WebKit::WebUIClient::didNotHandleWheelEvent): Added.
  • UIProcess/WebUIClient.h: Added implementsDidNotHandleWheelEvent() and didNotHandleWheelEvent().
  • UIProcess/win/WebPageProxyWin.cpp: Removed wheelEventNotHandled().
9:40 AM Changeset in webkit [85859] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Return correct GTK version for NPNVToolkit
​https://bugs.webkit.org/show_bug.cgi?id=60275

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Return always 2 for NPNVToolkit in GTK platform.
9:38 AM Changeset in webkit [85858] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: searching for node does not result in bringToFront call.
​https://bugs.webkit.org/show_bug.cgi?id=60222

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateFocusedNode):
9:07 AM Changeset in webkit [85857] by abarth@webkit.org
  • 2 edits in trunk

2011-05-05 Adam Barth <​abarth@webkit.org>

Remove a couple stray mentions of WML that I missed before.

  • configure.ac:
9:01 AM Changeset in webkit [85856] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make native events code more consistent
​https://bugs.webkit.org/show_bug.cgi?id=60258

Make all other native events code follow the current keyboard
events approach: use a GOwnPtr for the native event, and use
const GdkEvent* in the API. We need to implement the copy
constructors for native events to copy the gdk events with
gdk_event_copy().

  • Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
  • Shared/NativeWebWheelEvent.h: (WebKit::NativeWebWheelEvent::nativeEvent):
  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
  • Shared/gtk/NativeWebMouseEventGtk.cpp: (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • Shared/gtk/NativeWebWheelEventGtk.cpp: (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
  • Shared/gtk/WebEventFactory.cpp: (WebKit::buttonForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
8:44 AM Changeset in webkit [85855] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-05 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 and the build is not done
with c++0x support we need to deactivate warnings about compatibility.
Some WebKit types have names which conflicts with upcoming c++0x
types. If QtWebKit is built with c++0x support, WebKit has code to
fallback to the standard type rather than the WebKit implementation.
For example nullptr will be the one of the std if build options turns on
c++0x support.

  • Source/WebKit.pri:

2011-05-05 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 or later we don't want to deactivate
the c++0x support because it works.

8:40 AM Changeset in webkit [85854] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Module::load() should return true when g_module_open() returns a valid pointer
​https://bugs.webkit.org/show_bug.cgi?id=60261

  • Platform/gtk/ModuleGtk.cpp: (WebKit::Module::load):
8:39 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:20 AM Changeset in webkit [85853] by andreas.kling@nokia.com
  • 12 edits in trunk/Source/WebCore

2011-05-05 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Implement the fast font path for Qt.
​https://bugs.webkit.org/show_bug.cgi?id=51106

Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
rendering and measurement of simple text.

Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
classes are fully integrated into the Qt 4.8 release branch.

  • WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
  • platform/graphics/Font.cpp: (WebCore::Font::drawText): Disable fast font path for stroked text, and when painting text with a shadow. (Qt-only) (WebCore::Font::codePath): Try to use fast font path in more cases.
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont to use for rendering a given string. Goes through QTextLayout to find the best font based on the original QFont query. (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::rawFont):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
  • platform/graphics/qt/FontQt.cpp: (WebCore::fillPenForContext): (WebCore::strokePenForContext): (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon to share code between complex and simple font rendering paths. (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
  • platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we have no way of knowing the pitch. (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter(). (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes(). (WebCore::SimpleFontData::scaledFontData): Added, based on other ports. (WebCore::SimpleFontData::smallCapsFontData): Ditto. (WebCore::SimpleFontData::emphasisMarkFontData): Ditto. (WebCore::SimpleFontData::platformBoundsForGlyph): Stub. (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics. (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
8:11 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:11 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:09 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:15 AM Changeset in webkit [85852] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Skip inspector/console/console-shadow-dom-access.html (crashes in debug)
​https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped:
7:14 AM Changeset in webkit [85851] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

2011-05-05 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
​https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addUserStyleSheet):

2011-05-05 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
​https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustProgressBarStyle): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::adjustSliderThumbStyle):
6:36 AM QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
6:35 AM QtWebKitPlatformSupport created by alexis.menard@openbossa.org
6:31 AM QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
6:20 AM Changeset in webkit [85850] by loislo@chromium.org
  • 14 edits
    2 moves in trunk/Source/WebCore

2011-05-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger to DOMDebugger.

​https://bugs.webkit.org/show_bug.cgi?id=60256
InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
browserDebugger => domDebugger

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::DOMDebuggerAgent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp. (WebCore::InspectorDOMDebuggerAgent::create): (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled): (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled): (WebCore::InspectorDOMDebuggerAgent::disable): (WebCore::InspectorDOMDebuggerAgent::clearFrontend): (WebCore::InspectorDOMDebuggerAgent::discardBindings): (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint): (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorDOMDebuggerAgent::clear):
  • inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
6:06 AM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
6:05 AM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
5:14 AM Changeset in webkit [85849] by caseq@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for shadow DOM access in the console API
​https://bugs.webkit.org/show_bug.cgi?id=60192

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNode):
  • inspector/console/console-shadow-dom-access-expected.txt: Added.
  • inspector/console/console-shadow-dom-access.html: Added.
3:58 AM Changeset in webkit [85848] by Philippe Normand
  • 1 edit
    14 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt: Added.
3:41 AM Changeset in webkit [85847] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show only Console and Scripts panels in worker inspector front-end
​https://bugs.webkit.org/show_bug.cgi?id=60159

  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.isWorkerFrontend):
  • inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
2:17 AM Changeset in webkit [85846] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed, marking flaky tests.

  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [85845] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r85817.
​http://trac.webkit.org/changeset/85817

It looks these lines are mis-skipped.

  • platform/chromium/test_expectations.txt:
1:36 AM Changeset in webkit [85844] by hans@chromium.org
  • 4 edits
    1 add in trunk/Source

2011-05-03 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
​https://bugs.webkit.org/show_bug.cgi?id=59692

Fix some embarrassing bugs uncovered by unit tests.

No new functionality, but this is now covered by unit tests in the Chromium WebKit port.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::decodeInt): (WebCore::IDBLevelDBCoding::decodeVarInt):

2011-05-03 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
​https://bugs.webkit.org/show_bug.cgi?id=59692

Add unit tests for the basic key coding functions used by the LevelDB back-end.

  • WebKit.gypi:
  • tests/IDBLevelDBCodingTest.cpp: Added. (IDBLevelDBCoding::TEST):
1:25 AM Changeset in webkit [85843] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for new fullscreen test.

  • platform/gtk/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Added.
1:12 AM Changeset in webkit [85842] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed, fixed a syntax error on expectations file.

  • platform/chromium/test_expectations.txt:
12:57 AM Changeset in webkit [85841] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85808.

  • Shared/NativeWebWheelEvent.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
12:25 AM Changeset in webkit [85840] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <​morrita@google.com>

Unreviewed expectations update for MAC GPU flakiness.

  • video-zoom-controls.html: Added IMAGE
  • media/controls-without-preload.html, media/controls-styling.html, media/controls-strict.html, media/controls-after-reload.html Added TEXT
  • platform/chromium/test_expectations.txt:
12:00 AM Changeset in webkit [85839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Young Han Lee <​joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
​https://bugs.webkit.org/show_bug.cgi?id=60251

No new tests. Build fix.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
Note: See TracTimeline for information about the timeline view.