⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 7, 2011:

11:47 PM Changeset in webkit [86025] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Reverted unintended changes in r86024

11:42 PM Changeset in webkit [86024] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
​https://bugs.webkit.org/show_bug.cgi?id=60443

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/replaced/table-percent-height-positioned.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
doesn’t affect the table cell’s height).

LayoutTests:

  • fast/replaced/table-percent-height-positioned-expected.png: Added.
  • fast/replaced/table-percent-height-positioned-expected.txt: Added.
  • fast/replaced/table-percent-height-positioned.html: Added.
10:20 PM Changeset in webkit [86023] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-07 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Cleanup unexpected test passes in the gpu webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=60393

  • platform/chromium/test_expectations.txt:
9:42 PM Changeset in webkit [86022] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overlay fades out instead of disappearing immediately

Reviewed by Timothy Hatcher.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::hideFindUI): Do not fade out the overlay.

9:42 PM Changeset in webkit [86021] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Avoid copying a header file into the WebKit2 framework wrapper.

  • WebKit2.xcodeproj/project.pbxproj: Corrected the target membership of HTTPCookieAcceptPolicy.h.
7:50 PM Changeset in webkit [86020] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Testing EWS spins on patches with a large number of failures
​https://bugs.webkit.org/show_bug.cgi?id=60441

In cases where the tree has a small number of persistent failures but a
patch has a large number of failures, we weren't believing any results.
That lead to us retrying the patch forever while we waited for
trustworthy results that would never come.

This patch loosens the semantics of unexpected_failures to return a
subset (rather than the exact set) of unexpected failures. In the case
where the tree has a bounded number of failures and the patch has an
unbounded number of failures, we can accurately compute such a subset
and reject the patch.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
6:25 PM Changeset in webkit [86019] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows WebKit2 Release Tests]
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing since r85795.
​https://bugs.webkit.org/show_bug.cgi?id=60442

Add win-wk2 failing expected results to get the bots green.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
6:09 PM Changeset in webkit [86018] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
5:58 PM Changeset in webkit [86017] by inferno@chromium.org
  • 5 edits in trunk/Source

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
​http://trac.webkit.org/changeset/85974
​https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
​http://trac.webkit.org/changeset/85974
​https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
5:49 PM Changeset in webkit [86016] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
4:46 PM Changeset in webkit [86015] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled

Add another test (fast/events/popup-blocked-from-mousemove.html) to the mac-wk2 Skipped list
to get the bots green.

  • platform/mac-wk2/Skipped:
4:39 PM Changeset in webkit [86014] by dbates@webkit.org
  • 1 edit in trunk/Source/WebKit/efl/ChangeLog

2011-05-07 Daniel Bates <​dbates@webkit.org>

Update title of bug in change log entry for changeset <​http://trac.webkit.org/changeset/86012>
so as to be consistent with the name of the bug in <​https://bugs.webkit.org/show_bug.cgi?id=60151>.

4:37 PM Changeset in webkit [86013] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Add willPerformClientRedirect to the user-gesture tests.

  • fast/frames/location-redirect-user-gesture-expected.txt:
  • fast/frames/meta-refresh-user-gesture-expected.txt:

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Create a UserGestureIndicator when calling the clientRedirected callback.

  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer):

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
(For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willPerformClientRedirect): (WebViewHost::didStartProvisionalLoad):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
4:34 PM Changeset in webkit [86012] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-07 Tomasz Morawski <​t.morawski@samsung.com>

Reviewed by Daniel Bates.

[EFL] Remove ewk_tile_unused_cache_free function form public api
​https://bugs.webkit.org/show_bug.cgi?id=60151

The ewk_tile_unused_cache_free function should be only called by
ewk_tile_unused_cache_unref function. Calling this function without
considering reference counting may lead to fatal results.

  • ewk/ewk_tiled_model.c: (_ewk_tile_unused_cache_free): (ewk_tile_unused_cache_unref):
  • ewk/ewk_tiled_model.h:
4:34 PM Changeset in webkit [86011] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
introduction in r85669.
​https://bugs.webkit.org/show_bug.cgi?id=60272

Add expected failing text results to get the bots green.

Note: these tests still need pixel results to be generated both for mac-wk2 and win-wk2.

  • platform/mac-wk2/editing/selection: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt: Added.
4:15 PM Changeset in webkit [86010] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

2011-05-07 Daniel Bates <​dbates@webkit.org>

Update change log entry for changeset <​http://trac.webkit.org/changeset/86009> to
explain that this was an attempt to fix the build after changeset 86007
<​http://trac.webkit.org/changeset/86007> (bug #60438).

4:08 PM Changeset in webkit [86009] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-05-07 Daniel Bates <​dbates@webkit.org>

Remove some more references to isTiger(), which was removed in changeset 86007
<​http://trac.webkit.org/changeset/86007> (bug #60438).

  • Scripts/old-run-webkit-tests:
    • Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and file local variable.
3:59 PM Changeset in webkit [86008] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-07 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Daniel Bates.

Fix compile with GCC 4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=60380

Remove unused local variable from code.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch):
12:56 PM Changeset in webkit [86007] by psolanki@apple.com
  • 5 edits in trunk/Tools

Remove references to Tiger in scripts
​https://bugs.webkit.org/show_bug.cgi?id=60438

Reviewed by Darin Adler.

Remove isTiger() and all of the code that depends on it.

  • Scripts/build-webkit:
  • Scripts/ensure-valid-python:
  • Scripts/gdb-safari:
  • Scripts/webkitdirs.pm:
7:36 AM Changeset in webkit [86006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-07 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Adam Roben.

[Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961
​https://bugs.webkit.org/show_bug.cgi?id=60420

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: (WebKit::NetscapePlugin::platformVisibilityDidChange):
12:52 AM Changeset in webkit [86005] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 85586
BUG=81348
Review URL: ​http://codereview.chromium.org/6953015

12:32 AM Changeset in webkit [86004] by cevans@google.com
  • 2 edits
    14 copies in branches/chromium/742

Merge 85876
BUG=72832
Review URL: ​http://codereview.chromium.org/6952018

12:17 AM Changeset in webkit [86003] by cevans@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/rendering

Merge 85705
BUG=79746
Review URL: ​http://codereview.chromium.org/6948015

12:08 AM Changeset in webkit [86002] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when sending a wheel event to a node with no shadow ancestor node
​https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>

Reviewed by Alice Liu.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.

May 6, 2011:

11:12 PM Changeset in webkit [86001] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/742

Merge 85964
BUG=72832
Review URL: ​http://codereview.chromium.org/6949014

10:49 PM Changeset in webkit [86000] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Forgot it since my last svg rebaseline r85981.

  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
10:02 PM Changeset in webkit [85999] by inferno@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium rebaselines for r85990

  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
9:24 PM Changeset in webkit [85998] by tkent@chromium.org
  • 32 edits
    2 deletes in trunk/Source

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement and TextFieldInputType.
  • Change the return type of Node::toInputElement(): InputElement* -> HTMLInputElement*

No new tests. This change should not change the existing behaviour.

  • CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
  • GNUmakefile.list.am: ditto.
  • WebCore.exp.in: Add symbols of functions exposed to WebKit.
  • WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): Follow the return type change of Node::toInputElement().
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): ditto. (WebCore::AccessibilityRenderObject::isIndeterminate): ditto. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto. (WebCore::AccessibilityRenderObject::isChecked): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  • dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton): ditto.
  • dom/DOMAllInOne.cpp: Remove InputElement.h.
  • dom/InputElement.cpp: Removed.
  • dom/InputElement.h: Removed.
  • dom/Node.cpp: (WebCore::Node::toInputElement): Change the return type from InputElement* to HTMLInputElement*.
  • dom/Node.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::formControlName): (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::size): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): (WebCore::HTMLInputElement::setDefaultName): (WebCore::HTMLInputElement::maxLength): (WebCore::HTMLInputElement::cacheSelection): (WebCore::formatCodes): Moved from InputElement. (WebCore::cursorPositionToMaskIndex): ditto. (WebCore::HTMLInputElement::isConformToInputMask): ditto. (WebCore::HTMLInputElement::validateInputMask): ditto. (WebCore::HTMLInputElement::setWapInputFormat): ditto. (WebCore::HTMLInputElement::notifyFormStateChanged): ditto. (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto. (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
  • html/HTMLInputElement.h:
    • Add data members which were defined in InputElementData.
    • Make some functions public because the public interface InputElement is removed.
    • Make some functions non-virtual because they don't override corresponding virtual functions of InputElement anymore.

(WebCore::HTMLInputElement::toInputElement):

Follow the return type change of Node::toInputElement().

(WebCore::HTMLInputElement::isIndeterminate):
(WebCore::HTMLInputElement::isAutofilled):
(WebCore::HTMLInputElement::supportsMaxLength):
(WebCore::HTMLInputElement::cachedSelectionStart):
(WebCore::HTMLInputElement::cachedSelectionEnd):

  • html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
  • html/InputType.cpp: (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
  • html/InputType.h: Update for the above.
  • html/TextFieldInputType.cpp: (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp. (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength(). (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Move the code from InputElement::handleBeforeTextInsertedEvent().
  • html/TextFieldInputType.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp:
    • Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
    • Follow the return type change of inputElement().

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):

Make sure node() is an HTMLInputElement instance.

(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
(WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
(WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::startSearchEventTimer):
(WebCore::RenderTextControlSingleLine::searchEventTimerFired):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTextControlSingleLine.h: Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): Follow the return type change of Node::toInputElement(). (WebCore::RenderTheme::isIndeterminate): ditto. (WebCore::RenderTheme::shouldHaveSpinButton): Change the parameter type: InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.h: ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength. (WebKit::toWebInputElement): Follow the return type change of Node::toInputElement().

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Follow the return type change of Node::toInputElement(). (DumpRenderTreeSupportGtk::setValueForUser): ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAutofilled): Follow the return type change of Node::toInputElement().
8:51 PM Changeset in webkit [85997] by cevans@google.com
  • 14 edits
    2 copies in branches/chromium/742

Merge 85823
BUG=64046
Review URL: ​http://codereview.chromium.org/6955016

8:45 PM Changeset in webkit [85996] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/742

Merge 85926
BUG=80608
Review URL: ​http://codereview.chromium.org/6949013

8:26 PM Changeset in webkit [85995] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/696

Merge 85926
BUG=80608

8:19 PM Changeset in webkit [85994] by cevans@google.com
  • 12 edits
    2 copies in branches/chromium/696

Merge 85823
BUG=64046

7:13 PM Changeset in webkit [85993] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

  • http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

This mode lets web sites try out CSP by getting violation reports (and
console spam) without actually changing the behavior of their web sites.

Test: http/tests/security/contentSecurityPolicy/report-only.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h:
6:18 PM Changeset in webkit [85992] by imasaki@chromium.org
  • 8 edits in trunk/LayoutTests

2011-05-06 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline to chromium for video-layer.
​https://bugs.webkit.org/show_bug.cgi?id=60423

These expected files are produced by the rebaseline tool.
​http://code.google.com/p/chromium/issues/detail?id=81833

  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [85991] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by David Levin.

[chromium] Rebaseline needed for media/audio-repaint
​https://bugs.webkit.org/show_bug.cgi?id=60416

  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [85990] by Beth Dakin
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60421
Custom scrollbars nested inside an overlay scrollbar overflow region end up
painting twice
-and corresponding-
<rdar://problem/9389072>

Reviewed by Darin Adler.

Source/WebCore:

Be sure not to paint custom css scrollbars during the special overlay-scrollbar
painting pass.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):

LayoutTests:

  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • scrollbars/scrollbars-on-positioned-content.html: Added.
5:50 PM WebKit Team edited by rniwa@webkit.org
Adding "Core DOM" and "Event Handling" to my area of knowledge (diff)
5:47 PM Changeset in webkit [85989] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-05-06 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Add utility for converting SkCanvas to CGContext
​https://bugs.webkit.org/show_bug.cgi?id=59808

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The BitLockerSkia utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

Each time the CGContext is retrieved, it is rebuilt.
This permits the caller to modify the same canvas
between calls.

This change adds utilities but does not modify any
existing code. For now, there are no callers to these
utilities, so there is no functional change.

No new tests.

  • platform/graphics/skia/BitLockerSkia.cpp: Added. (WebCore::SkMatrixToCGAffineTransform): Conversion utility. (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas. (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up. (WebCore::BitLockerSkia::release): Internal private helper. (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
  • platform/graphics/skia/BitLockerSkia.h: Added.
5:11 PM Changeset in webkit [85988] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-06 David Grogan <​dgrogan@chromium.org>

Reviewed by Eric Seidel.

update link to message about mac 64bit git binaries
​https://bugs.webkit.org/show_bug.cgi?id=60411

The original message implied (correctly, at-the-time) that
​http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
binaries. The new message notes that they do. This might prevent someone
else from spending a few minutes confused.

  • Scripts/webkitpy/common/checkout/scm/git.py:
4:29 PM Changeset in webkit [85987] by Martin Robinson
  • 6 edits
    2 adds in trunk/Source

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract coordinate system translation code from WebKit into WebCore.
This will allow the code to be shared between WebKit and WebKit2. The code
now lives in a new GtkUtilities.cpp helper file.

  • GNUmakefile.list.am: Added GtkUtilities to the source list.
  • platform/gtk/GtkUtilities.cpp: Added. (WebCore::convertWidgetRectToScreenRect):
  • platform/gtk/GtkUtilities.h: Added.

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract the code to translate from widget space to screen space into
a helper method in WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities. (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Add an implementation of PageClient::windowToScreen for GTK+ WebKit2 using
the newly abstracted widget to screen coordinate translation code in WebCore.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::windowToScreen): Added implementation.
4:12 PM Changeset in webkit [85986] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Disable platform/win/plugins/visibility-hidden.html.

  • platform/chromium/test_expectations.txt:
4:07 PM Changeset in webkit [85985] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove some unnecessary static methods in ResourceHandleSoup.

No new tests. This is only a small cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly. (WebCore::gotHeadersCallback):Ditto. (WebCore::contentSniffedCallback):Ditto. (WebCore::sendRequestCallback):Ditto. (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
4:06 PM Changeset in webkit [85984] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] ResourceHandles are leaked on 304 responses
​https://bugs.webkit.org/show_bug.cgi?id=60413

Always call cleanupSoupRequestOperation, even when the request was not
canceled. Before the code would call didFinishLoading and then never clean up
the request.

No new tests. This simply fixes a memory leak.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
3:50 PM Changeset in webkit [85983] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Simplify the PluginInfoStore interface
​https://bugs.webkit.org/show_bug.cgi?id=60406

Just expose a single API for getting a list of plug-ins from the info store,
PluginInfoStore::plugins and remove PluginInfoStore::getPlugins and PluginInfoStore::getPluginPaths.

Also, change the WebContext::pluginInfoStore() getter to return a reference.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): (WebKit::WebContext::getPluginPath):
  • UIProcess/WebContext.h: (WebKit::WebContext::pluginInfoStore):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType):
3:38 PM Changeset in webkit [85982] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-05-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: crashes in race with crashing DRT
​https://bugs.webkit.org/show_bug.cgi?id=60238

This fixes a race where if we wrote the URL to DRT and
DRT crashed immediately, we could get a broken pipe
error back during the write() and not handle it correctly,
causing NRWT to also crash.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:16 PM Changeset in webkit [85981] by inferno@chromium.org
  • 61 edits
    28 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Rebaselines for r85926.
​https://bugs.webkit.org/show_bug.cgi?id=60356

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
  • platform/chromium-mac/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
3:08 PM Changeset in webkit [85980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:52 PM Changeset in webkit [85979] by inferno@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r85964, r85971 and r85967.

  • platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [85978] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make more PluginInfoStore member functions static
​https://bugs.webkit.org/show_bug.cgi?id=60401

This is a first step towards making PluginInfoStore thread safe.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
2:12 PM Changeset in webkit [85977] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • fast/events/popup-blocked-from-mousemove-expected.txt: Added.
  • fast/events/popup-blocked-from-mousemove.html: Added.

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
2:06 PM Changeset in webkit [85976] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Fix error due to duplicate entry.

  • platform/chromium/test_expectations.txt:
2:03 PM Changeset in webkit [85975] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

This CSP directive is not in the CSP spec. This patch is somewhat of
an experiment to see whether this feature is useful. Based on our
implementation experience, we will coordinate with folks via the W3C to
see if this makes sense to add to the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:52 PM Changeset in webkit [85974] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
​https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
1:29 PM Changeset in webkit [85973] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Fix two warnings of unused variables.
​https://bugs.webkit.org/show_bug.cgi?id=60370

Remove two unused local variable from the code.

No new tests, the existing ones should cover.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateNextProgressTime):
1:13 PM Changeset in webkit [85972] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
    • Boo different error messages.
  • platform/chromium/test_expectations.txt:
    • Test progression.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
1:07 PM Changeset in webkit [85971] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.
12:22 PM Changeset in webkit [85970] by enne@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline changes after r85959
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [85969] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a --skip-integrationtests mode to test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=60354

These two test suites account for 2/3 of test-webkitpy's running time
because they're not actually unit tests. They're integration tests.
This patch adds the ability to skip integration tests by passing a
command line argument to test-webkitpy. The buildbots will continue to
run these integration tests to make sure they don't regress. This
option is for use by developers when working on parts of the code that
are well-covered by unit tests.

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
  • Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
12:14 PM Changeset in webkit [85968] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[results.html] label the zoomed pixel containers (expected, actual, diff)
​https://bugs.webkit.org/show_bug.cgi?id=60383

  • fast/harness/results.html:
12:10 PM Changeset in webkit [85967] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Add pixel results for mac.

  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.
12:09 PM Changeset in webkit [85966] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 John Abd-El-Malek <​jam@chromium.org>

Reviewed by James Robinson.

[chromium]: Reland using WebPermissionClient for checking indexed db usage
​https://bugs.webkit.org/show_bug.cgi?id=60386

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
12:05 PM Changeset in webkit [85965] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Add baselines to chromium for video-source-error that reflect the fact that
chromium does not support mp4.

[chromium] Rebaseline needed for video-source-error
​https://bugs.webkit.org/show_bug.cgi?id=60292

  • platform/chromium/media/video-source-error-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [85964] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank

Reviewed by Dan Bernstein.

Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.

Source/WebCore:

Added fast/block/positioning/hiding-inside-relpositioned-inline.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

  • fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
11:49 AM Changeset in webkit [85963] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: move selection test into the text area branch.

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
11:48 AM Changeset in webkit [85962] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a

missing #import.

11:41 AM Changeset in webkit [85961] by Adam Roben
  • 18 edits
    3 adds in trunk

Show/hide windowed plugins according to the plugin element's visibility CSS property

Fixes <​http://webkit.org/b/60285> <rdar://problem/9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed

Reviewed by Anders Carlsson.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::isPluginVisible):

  • PluginProcess/PluginControllerProxy.h:

Stubbed out.

  • Shared/win/WindowGeometry.cpp:

(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):

  • Shared/win/WindowGeometry.h:

Added visible member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::visibilityDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Added. Calls through to platform-specific code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformVisibilityDidChange):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.

  • WebProcess/Plugins/Plugin.h: Added visibilityDidChange.
  • WebProcess/Plugins/PluginController.h: Added isPluginVisible.
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::visibilityDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Stubbed out.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.

(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.

  • WebProcess/Plugins/PluginView.h: Updated for PluginController changes.

LayoutTests:

Add a test that shows that windowed plugins with visibility:hidden do not appear on screen

I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <​http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.

  • platform/win/plugins/visibility-hidden-expected.png: Added.
  • platform/win/plugins/visibility-hidden-expected.txt: Added.
  • platform/win/plugins/visibility-hidden.html: Added.
11:35 AM Changeset in webkit [85960] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The results.zip generated by the Chromium EWS are too big
​https://bugs.webkit.org/show_bug.cgi?id=60352

Currently results.zip created by the Chromium EWS bot contain roughly
1000 tests that we expect to fail. These test results are not helpful
to contributors.

There are several approaches to solving this problem:

1) We could be more selective about which files to include in the zip.
2) We could ask new-run-webkit-tests not to generate results for

expected failures.

3) We could ask new-run-webkit-tests not to run tests that we expect to

fail.

This patch takes approach (3). Currently, we're ignoring the outcome
of failing tests anyway, so there's not much point in actually running
them. As a side benefit, this will speed up the test run by about 6%.
In the future, we might revisit this decision and choose another
approach.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
10:41 AM Changeset in webkit [85959] by enne@google.com
  • 4 edits
    4 adds in trunk

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Added.
  • compositing/flat-with-transformed-child.html: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

Allow for empty scissor rects, which implies scissoring to the render
surface. The previous code and previous patch on this bug both didn't
take into account that the scissor rect should be the render surface
and not the projection of the layer itself, because child layers
aren't necessarily contained within the bounds of their superlayer.

Test: compositing/flat-with-transformed-child.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
10:30 AM Changeset in webkit [85958] by Adam Roben
  • 15 edits
    2 adds in trunk/Source/WebKit2

Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message

This will make it easier to add more info to this message in the future (like whether the
window is visible).

Fixes <​http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious

Reviewed by Anders Carlsson.

  • Scripts/webkit2/messages.py:

(struct_or_class): Added WindowGeometry to the list of structs.

  • Shared/win/WindowGeometry.cpp: Added.
  • Shared/win/WindowGeometry.h: Added.
  • win/WebKit2.vcproj: Added new files.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.

10:22 AM Changeset in webkit [85957] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Mihai Parparita.

[results.html] zoomed pixel results should not be antialiased
​https://bugs.webkit.org/show_bug.cgi?id=60330

-Use canvas instead of CSS zoom.
-Only zoom the part of the image we need to show.
-Make pixel zooming mostly work in Firefox.
-Increase the zoom from 3x to 6x.

  • fast/harness/results.html:
10:22 AM Changeset in webkit [85956] by ddkilzer@apple.com
  • 4 edits in trunk/Source

Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings

Reviewed by Jon Honeycutt.

This fixes an Xcode 4 warning about using obsolete settings.

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

10:12 AM Changeset in webkit [85955] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-05-06 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Lazily allocate ScrollAnimator in ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=60327

Avoid allocating the ScrollAnimator up-front, because we
create lots of ScrollableAreas via RenderLayer, and we should
only need the animator when scrolling.

  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::ScrollableArea): (WebCore::ScrollableArea::scrollAnimator): (WebCore::ScrollableArea::scroll): (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation): (WebCore::ScrollableArea::handleWheelEvent): (WebCore::ScrollableArea::handleGestureEvent):
  • platform/ScrollableArea.h:
10:04 AM Changeset in webkit [85954] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85919.
​http://trac.webkit.org/changeset/85919
​https://bugs.webkit.org/show_bug.cgi?id=60378

broke chromium database tests (Requested by inferno-sec on
#webkit).

  • public/WebPermissionClient.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
9:55 AM Changeset in webkit [85953] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement NetscapePlugin::platformPaint for GTK platform
​https://bugs.webkit.org/show_bug.cgi?id=60368

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformPaint):
9:37 AM Changeset in webkit [85952] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4

Create the 1.4 stable branch

9:03 AM Changeset in webkit [85951] by Carlos Garcia Campos
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

Share PluginInfoStore implementation between Qt and GTK ports
​https://bugs.webkit.org/show_bug.cgi?id=60366

  • GNUmakefile.am:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Removed.
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.pro:
8:51 AM Changeset in webkit [85950] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, fix parse errors in test_expectations.

I will annotate bug 60356 so that this case gets looked at.

  • platform/chromium/test_expectations.txt:
8:23 AM Changeset in webkit [85949] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
​https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/9392609>

Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.

Tested manually because we don't have any live streams to test in DRT.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay. (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay. (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::reset): Ditto. (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:
8:06 AM Changeset in webkit [85948] by Adam Roben
  • 3 deletes in trunk/LayoutTests/platform/win/plugins

Roll out r85946

I didn't mean to commit it!

8:04 AM Changeset in webkit [85947] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Touch WebKit.idl to fix the build

I needed this on my own machine. Maybe others will need it, too.

  • Interfaces/WebKit.idl:
8:02 AM Changeset in webkit [85946] by Adam Roben
  • 3 adds in trunk/LayoutTests/platform/win/plugins

Add a test for visibility:hidden for plugins

7:46 AM Changeset in webkit [85945] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.

std::tr1::has_trivial_constructor is in <tr1/memory>.

  • wtf/TypeTraits.h:
7:35 AM Changeset in webkit [85944] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed Qt 4.8 build fix.

  • WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can enable it after the 4.8 bots are updated with the full QRawFont APIs.
6:48 AM Changeset in webkit [85943] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
​https://bugs.webkit.org/show_bug.cgi?id=60319

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
6:24 AM Changeset in webkit [85942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use qt-arm platform instead of qt-linux on ARM platform.

Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
3:51 AM Changeset in webkit [85941] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

[Qt]fast/events/backspace-navigates-back.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60349

  • platform/mac-wk2/Skipped: Add fast/events/backspace-navigates-back.html because of missing layoutTestController.setEditingBehavior().
  • platform/qt-arm/Skipped: Add fast/events/backspace-navigates-back.html.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-mac/Skipped: Add fast/events/backspace-navigates-back.html.
2:17 AM Changeset in webkit [85940] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <​pnormand@igalia.com>

Windows DRT needs an implementation of shadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=59081

Skip media/video-controls-visible-audio-only.html that now
requires shadowRoot support.

  • platform/win/Skipped:
1:58 AM Changeset in webkit [85939] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8. Relative urls should not be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=57138

  • http/tests/websocket/tests/url-with-nonascii-query-expected.txt: Added.
  • http/tests/websocket/tests/url-with-nonascii-query.html: Added.
  • http/tests/websocket/tests/url-parsing-expected.txt: Failure message for relative url has changed since it is no longer expanded.

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8.
​https://bugs.webkit.org/show_bug.cgi?id=57138

Change WebSocket::connect to take the raw URL string and parse it
internally using the simple KURL constructor, which expects an absolute
UTF-8 encoded URL. This ensures that all code that creates a WebSocket
goes through this method instead of completeURL.

Test: http/tests/websocket/tests/url-with-nonascii-query.html

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
  • websockets/WebSocket.h:
1:42 AM Changeset in webkit [85938] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
​https://bugs.webkit.org/show_bug.cgi?id=60339

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialColorSpace): Add initialColorSpace() static method.
1:33 AM Changeset in webkit [85937] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed, marking tests whose expectations became obsolete since r85926.

  • platform/chromium/test_expectations.txt:
1:27 AM Changeset in webkit [85936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setPageBreakInside() reject unsupported enum values.
​https://bugs.webkit.org/show_bug.cgi?id=60235

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setPageBreakInside): Assert that only supported values are used.
1:17 AM Changeset in webkit [85935] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Move burden of checking for BJustify box alignment into RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=60246

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case logic checking for BJUSTIFY and use existing macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBoxAlign): Assert valid values are used.
1:00 AM Changeset in webkit [85934] by Philippe Normand
  • 7 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Layout tests shouldn't have to hard code media controller element locations
​https://bugs.webkit.org/show_bug.cgi?id=28220

New mediaControlsButtonCoordinates() function to get the middle
coordinates of a media controls button. This avoids hardcoding
positions in the tests.

Also unskipped the affected GTK media tests now passing.

  • media/audio-delete-while-step-button-clicked.html:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (mediaControlsButtonCoordinates):
  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [85933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
​https://bugs.webkit.org/show_bug.cgi?id=60338

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
12:47 AM Changeset in webkit [85932] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (send-form-data-with-sliced-file.html)

  • platform/chromium/test_expectations.txt:
12:45 AM Changeset in webkit [85931] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85860.

  • UIProcess/API/gtk/PageClientImpl.h: Fix typo.
12:43 AM Changeset in webkit [85930] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (resource-tree-frame-navigate.html)

  • platform/chromium/test_expectations.txt:
12:39 AM Changeset in webkit [85929] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/mac-wk2/Skipped:
    • Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
  • platform/qt-arm/Skipped:
    • Add fast/css/hover-update.html, because it fails intermittently.
    • Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-wk2/Skipped:
    • Add new but failing test: editing/pasteboard/paste-placeholder-input.html
12:35 AM Changeset in webkit [85928] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix with gcc 4.6 and c++0x support.
​https://bugs.webkit.org/show_bug.cgi?id=60284

When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.

No new tests, build fix.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::create):
12:33 AM Changeset in webkit [85927] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

Add an option to NRWT to skip failing tests
​https://bugs.webkit.org/show_bug.cgi?id=60295

This option is similar to the way old-run-webkit-tests works. We're
planning to use this option on the testing EWS bots because they don't
use information from failing tests yet.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:33 AM Changeset in webkit [85926] by cdn@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Change maxEffectRect to a FloatRect.
​https://bugs.webkit.org/show_bug.cgi?id=59551

  • svg/filters/filter-after-transform-crash-expected.txt: Added.
  • svg/filters/filter-after-transform-crash.svg: Added.

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Tests for crash when a transform is applied to certain filters.
​https://bugs.webkit.org/show_bug.cgi?id=59551

Test: svg/filters/filter-after-transform-crash.svg

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::determineAbsolutePaintRect):
  • platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  • platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  • platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
  • platform/graphics/filters/FELighting.h: (WebCore::FELighting::determineAbsolutePaintRect):
  • platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
  • platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::isFilterSizeValid): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::maxEffectRect): (WebCore::FilterEffect::setMaxEffectRect):
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
12:27 AM Changeset in webkit [85925] by Philippe Normand
  • 38 edits in trunk

Tools:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

shadowPseudoId support in the various LayoutTestController
implementations.

  • DumpRenderTree/LayoutTestController.cpp: (shadowPseudoIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

WebKit2:

2011-05-05 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleShadowPseudoId):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot): (WebKit::InjectedBundleNodeHandle::elementShadowPseudoId):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

WebKit/win:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOMCoreClasses.cpp: (DOMElement::shadowPseudoId):
  • DOMCoreClasses.h:

WebKit/qt:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKit/mac:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowPseudoId]):
  • DOM/WebDOMOperationsPrivate.h:

WebKit/gtk:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

WebKit/chromium:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::shadowPseudoId):

LayoutTests:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • media/video-controls-transformed.html: Refactored to use the pseudoShadowId() LayoutTestController method.
12:19 AM Changeset in webkit [85924] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (test_boolean_expr.html)

  • platform/chromium/test_expectations.txt:
12:11 AM Changeset in webkit [85923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Use cast to convert primitive value to FontSmoothingMode.
​https://bugs.webkit.org/show_bug.cgi?id=60242

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to convert primitive value to FontSmoothingMode.
12:06 AM Changeset in webkit [85922] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

EWS can't reject patches
​https://bugs.webkit.org/show_bug.cgi?id=60345

We're supposed to use patch.id() for the attachment ID, silly.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Note: See TracTimeline for information about the timeline view.