Context Navigation

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::release): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::start):

11:30 PM Changeset in webkit [86529] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doEnd):

11:21 PM Changeset in webkit [86528] by abarth@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-05-15 Adam Barth <abarth@webkit.org>

Enable strict PassOwnPtr on Qt. (Build fixes to follow.)

wtf/PassOwnPtr.h:

11:15 PM Changeset in webkit [86527] by morrita@google.com

2 edits in trunk/LayoutTests

2011-05-15 MORITA Hajime <morrita@google.com>

Unreviewed an expectation update.

platform/gtk/fast/html/details-add-child-2-expected.txt:

10:59 PM Changeset in webkit [86526] by commit-queue@webkit.org

10 edits
2 adds in trunk

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

Add a test that ensures <output>, <meter> and <progress> are not focused.
Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

fast/forms/focus-with-display-block-expected.txt: Added.
fast/forms/focus-with-display-block.html: Added.
platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

HTMLFormControlElement::isFocusable() returns true when the element is
visible as a block element. However, for output, meter, and progress
elements, the function should not return true unless they have
tabindex attributes. Override supportsFocus() of these elements to
apply the result of Node::supportsFocus() because it takes care of
whether the element has tabindex or not.

Test: fast/forms/focus-with-display-block.html

html/HTMLFormControlElement.h: Made supportsFocus() protected.
html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::supportsFocus): Added.
html/HTMLMeterElement.h:
html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::supportsFocus): Added.
html/HTMLOutputElement.h:
html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::supportsFocus): Added.
html/HTMLProgressElement.h:

10:44 PM Changeset in webkit [86525] by jonlee@apple.com

2 edits in trunk/Source/WebCore

Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

10:31 PM Changeset in webkit [86524] by msaboff@apple.com

2 edits in trunk/Source/WebKit2

2011-05-15 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
https://bugs.webkit.org/show_bug.cgi?id=60864

Implemented reuse of BackingStore's in
DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
matches the size of the existing BackingStore.
Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
These changes reduces memory usage up to 10MB on memory tests.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):

10:10 PM Changeset in webkit [86523] by ggaren@apple.com

2 edits in trunk/Source/WebCore

2011-05-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason

(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))

I'm basically rolling out http://trac.webkit.org/changeset/49786 because

(a) it created this performance problem

and

(b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
was committed in http://trac.webkit.org/changeset/53439.

Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.

page/Frame.cpp: (WebCore::Frame::~Frame): Don't create a new window every time we destroy a frame.

8:29 PM Changeset in webkit [86522] by andersca@apple.com

9 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Pass the window NPObject identifier in the plug-in creation parameters
https://bugs.webkit.org/show_bug.cgi?id=60865

This avoids a synchronous call when the plug-in wants to get the NPObject that
corresponds to the window.

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): Change this to take the PluginCreationParameters. Initialize the window NPObject.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Just return the window NPObject; it's already been initialized.

PluginProcess/PluginControllerProxy.h:
PluginProcess/PluginCreationParameters.cpp: (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
PluginProcess/PluginCreationParameters.h: Add the window NPObject ID.

PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin): Pass the creation parameters to PluginControllerProxy::initialize.

WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Initialize the window NPObject ID.

WebProcess/Plugins/PluginProxy.messages.in: Remove the GetWindowScriptNPObject message.

7:55 PM Changeset in webkit [86521] by morrita@google.com

15 edits
2 copies
12 adds in trunk

2011-05-12 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

fast/html/details-add-details-child-1.html: Added.
fast/html/details-add-details-child-2.html: Added.
fast/html/details-nested-1.html: Added.
fast/html/details-nested-2.html: Added.
platform/chromium/test_expectations.txt:
platform/gtk/fast/html/details-open2-expected.txt:
platform/mac/fast/html/details-add-child-2-expected.txt:
platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
platform/mac/fast/html/details-add-summary-10-expected.png: Added.
platform/mac/fast/html/details-nested-1-expected.png: Added.
platform/mac/fast/html/details-nested-1-expected.txt: Added.
platform/mac/fast/html/details-nested-2-expected.png: Added.
platform/mac/fast/html/details-nested-2-expected.txt: Added.
platform/mac/fast/html/details-open2-expected.txt:
platform/qt/fast/html/details-add-child-2-expected.txt:
platform/qt/fast/html/details-open2-expected.txt:

2011-05-12 MORITA Hajime <morrita@google.com>

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

Introduced ShadowContentSelector to collect and forward content
children for each ShadowContentElement. ShadowRoot collects child
nodes of its host (we call these children "content children"), and
the descendant ShadowContentElement pulls that these content
children and put it under its child during
ShadowContentElement::attach().

Content children no longer create its renderer during its normal
attach() phase (called "light" phase). And they create it during
attach() as a content children instead (called "forwarded phase").
These phases are detected by NodeRendererFactory and represented
as NodeRendererFactory::AttachPhase value AttachContentLight and
AttachContentForwarded.

Tests: fast/html/details-add-details-child-1.html

fast/html/details-add-details-child-2.html
fast/html/details-nested-1.html
fast/html/details-nested-2.html

dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::childrenChanged):
dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::createRendererIfNeeded):
dom/ShadowRoot.cpp: (WebCore::forceReattach): (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance): (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor): (WebCore::ShadowContentElement::attach): (WebCore::ShadowRoot::recalcStyle): (WebCore::ShadowRoot::activeContentContainer): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::attach):
dom/ShadowRoot.h:
html/shadow/ShadowContentElement.h: (WebCore::ShadowContentElement::rendererIsNeeded):
rendering/RenderDetails.cpp:
rendering/RenderDetails.h:

7:46 PM Changeset in webkit [86520] by morrita@google.com

4 edits in trunk/Source/WebCore

2011-05-13 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
https://bugs.webkit.org/show_bug.cgi?id=57088

Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
No new tests, no behavior change.

editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::resolveTextCheckingTypeMask):
editing/Editor.h:
platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel

6:44 PM Changeset in webkit [86519] by yuzo@google.com

1 edit
2 adds in trunk/LayoutTests

2011-05-15 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.

6:35 PM Changeset in webkit [86518] by dominicc@chromium.org

2 edits in trunk/LayoutTests

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed. Remove expectation of gc-shadow.html flakiness.

platform/chromium/test_expectations.txt:

6:21 PM Changeset in webkit [86517] by dominicc@chromium.org

2 edits in trunk/Tools

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed: adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

5:53 PM Changeset in webkit [86516] by andersca@apple.com

4 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Pass the document URL and toplevel document URL when creating a plug-in
https://bugs.webkit.org/show_bug.cgi?id=60863

This is the first of a series of patches intended to reduce the IPC traffic
during plug-in instantiation.

WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Parameters::encode): Encode the URLs.

(WebKit::Plugin::Parameters::decode):
Decode the URLs.

WebProcess/Plugins/Plugin.h: Add the document and toplevel document URLs.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Initialize the document and toplevel document URLs.

4:54 PM Changeset in webkit [86515] by dbates@webkit.org

6 edits in trunk/Tools

2011-05-15 Daniel Bates <dbates@webkit.org>

Reviewed by Chris Jerdonek.

svn-apply can't handle Git diff that only changes executable bit
https://bugs.webkit.org/show_bug.cgi?id=60848

Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
that only has an executable bit change.

Scripts/VCSUtils.pm:
- Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().

(parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.

Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
Scripts/svn-unapply: (patch): Ditto.
Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated expected results for test cases to account for numTextChunks.
- Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
- Added test case "Git: file that only has an executable bit change".
Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
- Updated expected results for test cases to account for numTextChunks.

4:20 PM Changeset in webkit [86514] by rwlbuis@webkit.org

1 edit
3 adds in trunk/LayoutTests

2011-05-15 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
https://bugs.webkit.org/show_bug.cgi?id=16614

Include testcase from the bug to prevent future regression (right now we pass both full testcase
and this reduction).

platform/mac/svg/custom/small-rect-scale-expected.png: Added.
platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
svg/custom/small-rect-scale.svg: Added.

4:02 PM Changeset in webkit [86513] by weinig@apple.com

2 edits in trunk/Tools

Fix windows build.

TestWebKitAPI/win/main.cpp:

(main):

3:49 PM Changeset in webkit [86512] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed typo fix after r86509.

platform/qt/Skipped:

3:41 PM Changeset in webkit [86511] by weinig@apple.com

6 edits in trunk/Tools

2011-05-15 Sam Weinig <sam@webkit.org>

Reviewed by David Levin.

Make API tester more gtest friendly
https://bugs.webkit.org/show_bug.cgi?id=60859

Scripts/run-api-tests: Numerous changes:
Remove logic to run tests one at a time.
Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us.
Forward stdout from the test tool to stdout, even in non-verbose runs.
Run test tool from the current working directory instead of the root webkit directory.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources.

TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run):
TestWebKitAPI/TestsController.h:
TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point.

3:31 PM Changeset in webkit [86510] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

jit/JITStubs.h:
runtime/JSFunction.cpp: Made the host function stub cache weak --

otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

11:43 AM Changeset in webkit [86509] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just skipping a test.

platform/qt/Skipped: inspector/console/console-long-eval-crash.html

10:34 AM Changeset in webkit [86508] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Unreviewed, just skipping a test.

New test fails on some of the SnowLeopard bots.

platform/mac-snowleopard/Skipped:

9:57 AM Changeset in webkit [86507] by loislo@chromium.org

10 edits
2 adds in trunk

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

inspector/CodeGeneratorInspector.pm:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

inspector/console/console-long-eval-crash-expected.txt: Added.
inspector/console/console-long-eval-crash.html: Added.
platform/gtk/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/win/Skipped:

9:18 AM Changeset in webkit [86506] by eric.carlson@apple.com

5 edits
3 adds in trunk

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Test: http/tests/media/video-cross-site.html

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction

to prevent cross-domain references from being followed.

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Add test for cross-domain QuickTime reference movie and test.

http/tests/media/resources/cross-site-reference.mov: Added.
http/tests/media/video-cross-site-expected.txt: Added.
http/tests/media/video-cross-site.html: Added.
platform/chromium/test_expectations.txt: Skipped, QuickTime reference movies not supported.
platform/gtk/Skipped: Ditto.

7:07 AM Changeset in webkit [86505] by commit-queue@webkit.org

9 edits
1 delete in trunk

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

platform/qt/Skipped:
platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects):
DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):

6:49 AM Changeset in webkit [86504] by robert@webkit.org

9 edits
1 add in trunk

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

https://bugs.webkit.org/show_bug.cgi?id=60722

platform/qt/Skipped:
platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

https://bugs.webkit.org/show_bug.cgi?id=60722

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):

4:40 AM Changeset in webkit [86503] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-15 Arno Renevier <arno@renevier.net>

Reviewed by Darin Adler.

remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=60775

No new tests. This change only impacts compilation.

html/HTMLFrameElementBase.cpp:

May 14, 2011:

11:41 PM Changeset in webkit [86502] by kevino@webkit.org

2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Fix strokeArc and fillRoundedRect drawing, and add clipPath support.

https://bugs.webkit.org/show_bug.cgi?id=60847

10:39 PM Changeset in webkit [86501] by eric.carlson@apple.com

8 edits in trunk/Source/WebCore

2011-05-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTTP video-on-demand streams frequently have live stream UI
https://bugs.webkit.org/show_bug.cgi?id=60849
<rdar://problem/9440502>

No new tests, we don't currently have tests for http live streams. Changes verified manually.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Reset the media controls so

a duration change which identifies a format will be picked up.

(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): New, reset media controls

so they can be reconfigured for the media file characteristics.

html/HTMLMediaElement.h:

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::characteristicChanged): New, pass through to the element.
platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerCharacteristicChanged):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setHasVideo): Call characteristicChanged when

setting changes.

(WebCore::MediaPlayerPrivateAVFoundation::setHasAudio): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::setHasClosedCaptions): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Move the duration

change notification logic to invalidateCachedDuration.

(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration): New, invalidate

the cached duration and notify the element when it changes.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call invalidateCachedDuration

for the DurationChanged notification.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Define DurationChanged.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't check asset or

item duration until they have been loaded.

(WebCore::itemKVOProperties): Listen for duration change.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with

duration change notification.

6:51 PM Changeset in webkit [86500] by inferno@chromium.org

3 edits
2 adds in trunk

2011-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when trying to parse an invalid font family
value of 'inherit' or 'initial' in a font face rule.
https://bugs.webkit.org/show_bug.cgi?id=60837

fast/css/invalid-font-family-in-font-face-crash-expected.txt: Added.
fast/css/invalid-font-family-in-font-face-crash.html: Added.

2011-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

As per spec, only allow one font family name in a font face rule.
Other things like initial value, inherited value or multiple names
are discarded.
https://bugs.webkit.org/show_bug.cgi?id=60837

Test: fast/css/invalid-font-family-in-font-face-crash.html

css/CSSParser.cpp: (WebCore::CSSParser::createFontFaceRule):

3:10 PM Changeset in webkit [86499] by oliver@apple.com

66 edits in trunk/Source

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
heap/MarkedSpace.cpp:
runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
runtime/Executable.h:
runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
runtime/GetterSetter.h:
runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
runtime/JSCell.cpp: (JSC::slowValidateCell):
runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
runtime/JSONObject.h:
runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
runtime/JSPropertyNameIterator.h:
runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
runtime/JSString.h: (JSC::RopeBuilder::JSString):
runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
runtime/Structure.h: (JSC::JSCell::classInfo):
runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
runtime/StructureChain.h:
runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
wtf/Assertions.h:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):

2:44 PM Changeset in webkit [86498] by oliver@apple.com

3 edits in trunk/Source/WebCore

2011-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Anders Carlsson.

Make Qt bindings GC safe
https://bugs.webkit.org/show_bug.cgi?id=60841

Trying to do cache management by using "this" as a key from a GC
object's destructor leads to a violation of GC semantics. Make
the qt bindings use a Weak<> handle for finalization.

bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethodData::finalize):

2:23 PM Changeset in webkit [86497] by ap@apple.com

2 edits in trunk/Source/WebKit2

2011-05-14 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

WebKit2: Smart cut&paste is broken
https://bugs.webkit.org/show_bug.cgi?id=60840
<rdar://problem/9439927>

UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): Match WK1 - this default defaults to YES if not present.

1:48 PM Changeset in webkit [86496] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

platform/chromium/test_expectations.txt:

1:41 PM Changeset in webkit [86495] by mitz@apple.com

5 edits in trunk/Source/WebKit2

WKView does not draw after forced repaint before the first update
https://bugs.webkit.org/show_bug.cgi?id=60845

Reviewed by Alice Liu.

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint): Added.

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint): Set m_hasReceivedFirstUpdate
to true, ensuring that paint() will wait for an update if needed.

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint): Call DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint().

1:00 PM Changeset in webkit [86494] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Document the WantsMozillaUserAgent quirk and make it Windows specific
https://bugs.webkit.org/show_bug.cgi?id=60843

Shared/Plugins/PluginQuirks.h:
WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::userAgent):

11:40 AM Changeset in webkit [86493] by abarth@webkit.org

2 edits in trunk/Tools

2011-05-14 Arno Renevier <arno@renevier.net>

Reviewed by Martin Robinson.

make run-gtk-tests executable
https://bugs.webkit.org/show_bug.cgi?id=59278

Scripts/run-gtk-tests:

11:15 AM Changeset in webkit [86492] by dcheng@chromium.org

1 edit
3 copies in branches/chromium/742

Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

fast/inline/nested-top-alignment.html: Added.
platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7018002

11:10 AM Changeset in webkit [86491] by rniwa@webkit.org

18 edits in trunk/Source/WebCore

2011-05-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564

Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.

As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:

HTML: applet, br, embed, frame, frameset, hr (unless has children), img, input, keygen,

meter, object (unless uses fallback content), output, progress, select, and textarea.

No new tests are added since this change cannot be tested directly.

dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
html/HTMLButtonElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Added; returns true iff it has children.
html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::canContainRangeEndPoint): Added; returns true iff it uses fallback content.

11:10 AM Changeset in webkit [86490] by andersca@apple.com

2 edits in trunk/LayoutTests

platform/qt/Skipped:

Add plugins/get-url-notify-with-url-that-fails-to-load.html to the skipped list.

11:06 AM Changeset in webkit [86489] by andersca@apple.com

9 edits
2 adds in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Consolidate plug-in creation parameters to a single struct
https://bugs.webkit.org/show_bug.cgi?id=60839

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::create): (WebKit::PluginControllerProxy::PluginControllerProxy):
PluginProcess/PluginControllerProxy.h:
PluginProcess/PluginCreationParameters.cpp: Added. (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
PluginProcess/PluginCreationParameters.h: Added.
PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin):
PluginProcess/WebProcessConnection.h:
PluginProcess/WebProcessConnection.messages.in:
Scripts/webkit2/messages.py:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):

10:29 AM Changeset in webkit [86488] by jer.noble@apple.com

4 edits
2 adds in trunk

2011-05-14 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
https://bugs.webkit.org/show_bug.cgi?id=60142

fullscreen/video-controls-override-expected.txt: Added.
fullscreen/video-controls-override.html: Added.

2011-05-14 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
https://bugs.webkit.org/show_bug.cgi?id=60142

Create a queue of elements who must be targeted with webkitfullscreenchange events. Instead of dispatching
a single event with whatever the current value of m_fullScreenElement is (which may have been cleared, or
changed since the timer was asked to fire), dispatch one event for each entry in the queue.

Test: fullscreen/video-controls-override.html

dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Push current full screen element onto the

webkitfullscreenchange event delay queue.

(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::fullScreenElementRemoved): Ditto.
(WebCore::Document::fullScreenChangeDelayTimerFired): Empty the queue, dispatching a

webkitfullscreenchange event for each entry.

dom/Document.h:

9:31 AM Changeset in webkit [86487] by andersca@apple.com

10 edits
3 adds in trunk

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
GNUmakefile.am:

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

platform/gtk/Skipped: Add test to Skipped list since it apparently crashes.

plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

9:17 AM Changeset in webkit [86486] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

2011-05-14 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flashing window frame and graphical glitches after exiting full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60825

A layer-backed WebView throws an exception when moved from a layer-backed parent view
to a non-layer-backed one, so make the WebView a child of the content view, instead of
the animation view. There is an unrelated fix in beganExitFullScreen, which was calling
finishedExitFullScreenAnimation: instead of finishedEnterFullScreenAnimation: when
notifications come out of order.

UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Add the _webView

to the full screen window's content view, instead of the _animationView.

(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Call

finishedEnterFullScreenAnimation: instead of finishedExitFullScreenAnimation:.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): Add the

_layerHostingView to the contentView, instead of the animationView.

7:56 AM Changeset in webkit [86485] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Buildfix for SharedTimerWx.cpp
https://bugs.webkit.org/show_bug.cgi?id=60829

platform/wx/SharedTimerWx.cpp: (WebCore::WebKitTimer::WebKitTimer): We can't call the constructor of a base class in the body of the constructor.

2:39 AM Changeset in webkit [86484] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r86477.

Remove the global namespace prefix from GlobalLock/GlobalUnlock.

platform/win/ClipboardUtilitiesWin.cpp:

1:48 AM Changeset in webkit [86483] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt]fast/events/remove-target-in-mouseup* tests fail
https://bugs.webkit.org/show_bug.cgi?id=60833

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834

platform/qt/Skipped: Add failing tests.

1:02 AM Changeset in webkit [86482] by Csaba Osztrogonác

66 edits in trunk/Source

Unreviewed, rolling out r86469 and r86471, because they made hundreds tests crash on Qt.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Source/JavaScriptCore:

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildren):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

heap/MarkedSpace.cpp:
runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):

runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

runtime/Executable.h:

(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

runtime/JSCell.cpp:
runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):

runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

runtime/JSPropertyNameIterator.h:
runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):

runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):

runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):

runtime/Structure.h:

(JSC::Structure::createStructure):
(JSC::JSCell::classInfo):

runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

runtime/StructureChain.h:
runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrier::WriteBarrier):

wtf/Assertions.h:

Source/WebCore:

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildren):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

bindings/scripts/CodeGeneratorJS.pm:

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::invalidate):
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

12:24 AM Changeset in webkit [86481] by Csaba Osztrogonác

9 edits
3 deletes in trunk

Unreviewed, rolling out r86476.
http://trac.webkit.org/changeset/86476
https://bugs.webkit.org/show_bug.cgi?id=60832

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-05-14
It made plugins/get-url-notify-with-url-that-fails-to-
load.html crash on GTK (Requested by Ossy on #webkit).

Source/WebKit2:

WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::stop):
(WebKit::NetscapePluginStream::notifyAndDestroyStream):

Tools:

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
GNUmakefile.am:

Context Navigation

Timeline

May 15, 2011:

May 14, 2011:

Download in other formats: