⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 16, 2011:

11:59 PM Changeset in webkit [86658] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

http/tests/appcache/interrupted-update.html is flaky on win, mac, and linux.

  • platform/chromium/test_expectations.txt:
11:12 PM Changeset in webkit [86657] by commit-queue@webkit.org
  • 37 edits in trunk/Source/JavaScriptCore

2011-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86653.
​http://trac.webkit.org/changeset/86653
​https://bugs.webkit.org/show_bug.cgi?id=60944

"Caused regressions on Windows, OSX and EFL" (Requested by
yutak on #webkit).

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • create_hash_table:
  • heap/Heap.cpp: (JSC::TypeCounter::operator()):
  • interpreter/CallFrame.h: (JSC::ExecState::arrayTable): (JSC::ExecState::numberTable):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncJSCPrint):
  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot):
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
10:55 PM Changeset in webkit [86656] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 MORITA Hajime <​morrita@google.com>

Unreviewed build fix for r86647, which broke SUPPORT_AUTOCORRECTION_PANEL.

  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
10:11 PM Changeset in webkit [86655] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/hixie/perf/00{1,2}.xml now pass on Linux.

  • platform/chromium/test_expectations.txt:
9:26 PM Changeset in webkit [86654] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Kent Tamura <​tkent@chromium.org>

Fix Leopard build.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Use double instead of int.
9:08 PM Changeset in webkit [86653] by ggaren@apple.com
  • 37 edits in trunk/Source/JavaScriptCore

2011-05-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Geoffrey Garen.

Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933


Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.


This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

  • create_hash_table: Added a special case for fromCharCode, since it uses a custom "thunk generator".
  • heap/Heap.cpp: (JSC::TypeCounter::operator()): Fixed a bug where the type counter would overcount objects that were owned through more than one mechanism because it was getting in the way of counting the results for this patch.
  • interpreter/CallFrame.h: (JSC::ExecState::arrayConstructorTable): (JSC::ExecState::arrayPrototypeTable): (JSC::ExecState::booleanPrototypeTable): (JSC::ExecState::dateConstructorTable): (JSC::ExecState::errorPrototypeTable): (JSC::ExecState::globalObjectTable): (JSC::ExecState::numberConstructorTable): (JSC::ExecState::numberPrototypeTable): (JSC::ExecState::objectPrototypeTable): (JSC::ExecState::regExpPrototypeTable): (JSC::ExecState::stringConstructorTable): Added new tables.
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::ArrayConstructor::getOwnPropertySlot): (JSC::ArrayConstructor::getOwnPropertyDescriptor):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::createStructure):
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype): (JSC::BooleanPrototype::getOwnPropertySlot): (JSC::BooleanPrototype::getOwnPropertyDescriptor):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::createStructure):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): (JSC::DateConstructor::getOwnPropertySlot): (JSC::DateConstructor::getOwnPropertyDescriptor):
  • runtime/DateConstructor.h: (JSC::DateConstructor::createStructure):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype): (JSC::ErrorPrototype::getOwnPropertySlot): (JSC::ErrorPrototype::getOwnPropertyDescriptor):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::createStructure): Standardized these objects to use static tables for function properties.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h: Added new tables.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a static table for its global functions. This required uninlining some things to avoid a circular header dependency. However, those things probably shouldn't have been inlined in the first place.


Even more global object properties can be made lazy, but that requires
more in-depth changes.

  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype): (JSC::NumberPrototype::getOwnPropertySlot): (JSC::NumberPrototype::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::createStructure):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot): (JSC::ObjectPrototype::getOwnPropertyDescriptor):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::createStructure):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::RegExpPrototype::getOwnPropertySlot): (JSC::RegExpPrototype::getOwnPropertyDescriptor):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::createStructure):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): (JSC::StringConstructor::getOwnPropertySlot): (JSC::StringConstructor::getOwnPropertyDescriptor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::createStructure): Standardized these objects to use static tables for function properties.
7:51 PM Changeset in webkit [86652] by jamesr@google.com
  • 20 edits
    1 copy
    2 adds in trunk/Source

2011-05-16 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Decouple LayerChromium/CCLayerImpl trees
​https://bugs.webkit.org/show_bug.cgi?id=58830

Makes the CCLayerImpl tree self-hosting and provides an explicit step
to synchronize the LayerChromium tree to the CCLayerImpl tree.
Tested by compositing/ layout tests and by unit tests in WebKit/chromium.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::dumpLayerProperties): (WebCore::LayerChromium::createCCLayerImpl): (WebCore::LayerChromium::ccLayerImpl):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::id): (WebCore::LayerChromium::setCCLayerImpl):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/TreeSynchronizer.cpp: Added. (WebCore::TreeSynchronizer::addCCLayerImplsToMapRecursive): (WebCore::TreeSynchronizer::synchronizeTreeRecursive): (WebCore::TreeSynchronizer::synchronizeTrees):
  • platform/graphics/chromium/TreeSynchronizer.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::addChild): (WebCore::CCLayerImpl::removeFromParent): (WebCore::CCLayerImpl::removeAllChildren): (WebCore::CCLayerImpl::clearChildList): (WebCore::CCLayerImpl::descendantsDrawsContent): (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::updateCompositorResources):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::create): (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::children): (WebCore::CCLayerImpl::setMaskLayer): (WebCore::CCLayerImpl::maskLayer): (WebCore::CCLayerImpl::setReplicaLayer): (WebCore::CCLayerImpl::replicaLayer): (WebCore::CCLayerImpl::id): (WebCore::CCLayerImpl::owner): (WebCore::CCLayerImpl::setParent):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h: (WebCore::CCPluginLayerImpl::create):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h: (WebCore::CCVideoLayerImpl::create):

2011-05-16 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.
​https://bugs.webkit.org/show_bug.cgi?id=58830

Add unit tests for the compositor's TreeSynchronizer.

  • WebKit.gypi:
  • tests/TreeSynchronizerTest.cpp: Added. (WebCore::MockCCLayerImpl::create): (WebCore::MockCCLayerImpl::~MockCCLayerImpl): (WebCore::MockCCLayerImpl::setCCLayerDestructionList): (WebCore::MockCCLayerImpl::MockCCLayerImpl): (WebCore::MockLayerChromium::create): (WebCore::MockLayerChromium::~MockLayerChromium): (WebCore::MockLayerChromium::createCCLayerImpl): (WebCore::MockLayerChromium::pushPropertiesTo): (WebCore::MockLayerChromium::MockLayerChromium): (WebCore::expectTreesAreIdentical): (WebCore::TEST):
7:49 PM Changeset in webkit [86651] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86648.
​http://trac.webkit.org/changeset/86648
​https://bugs.webkit.org/show_bug.cgi?id=60941

media/controls-css-overload.html still failing on non-GPU
tests (Requested by scherkus on #webkit).

  • platform/chromium/test_expectations.txt:
7:34 PM Changeset in webkit [86650] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
​https://bugs.webkit.org/show_bug.cgi?id=60871

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added expected results.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added test patterns when initial values are empty.

2011-05-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
​https://bugs.webkit.org/show_bug.cgi?id=60871

Test: fast/forms/input-stepup-stepdown-from-renderer.html

In number input type, if the value is not a number, including empty, the currect valued is assumed 0.
But we have to handle it separately from the case when the value is actuall "0".

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Added cliping for default value.
6:42 PM Changeset in webkit [86649] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

This test case triggers the ASSERT.

  • fast/parser/append-child-followed-by-document-write-expected.txt: Added.
  • fast/parser/append-child-followed-by-document-write.html: Added.

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

The ASSERT is invalid when the parser is in the initial state and the
document is non-empty, which is strange but not impossible.

Test: fast/parser/append-child-followed-by-document-write.html

  • dom/Document.cpp: (WebCore::Document::setCompatibilityMode):
6:14 PM Changeset in webkit [86648] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, updating expectation for media/controls-css-overload.html.

  • platform/chromium/test_expectations.txt:
6:11 PM Changeset in webkit [86647] by morrita@google.com
  • 14 edits in trunk/Source

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

  • Moved DocumentMarker's member variables to private and added getters for them.
  • Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
  • Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController because it accesses DocumentMarker internals.
  • Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
6:01 PM Changeset in webkit [86646] by Martin Robinson
  • 4 edits in trunk/Source

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Fix the Cairo build for older versions of GTK+.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Include GtkVersioning.h to satisfy older versions of GTK+ 2.x.

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Take another shot at fixing the WinCairo build.

  • Shared/cairo/LayerTreeContextCairo.cpp: Include NotImplemented.h using a framework include.
5:53 PM Changeset in webkit [86645] by weinig@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by Jon Honeycutt.

Add access to process pid in WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=60938

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp: Added. (WKPageGetProcessIdentifier):
  • UIProcess/API/C/mac/WKPagePrivateMac.h: Added.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processIdentifier):
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Add WKPageGetProcessIdentifier as SPI for the mac.
5:50 PM Changeset in webkit [86644] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

  • loader/navigation-while-deferring-loads-expected.txt: Added.
  • loader/navigation-while-deferring-loads.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

If goToItem is called while loading is deferred, save the arguments
and try again later instead of doing nothing.

Test: loader/navigation-while-deferring-loads.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Pipe the "defersLoading" state into HistoryController.
  • loader/HistoryController.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::goToItem): Save the HistoryItem and FrameLoadType if loading is deferred. (WebCore::HistoryController::setDefersLoading): If we have a saved HistoryItem after resuming, try going to it.
  • loader/HistoryController.h:
  • page/Page.cpp: (WebCore::Page::goToItem): No longer bail early if loading is deferred, since HistoryController now handles this case.

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

Add setDefersLoading and goBack methods to LayoutTestController. We
need to use goBack() instead of history.back() because the latter goes
through NavigationScheduler, hence doesn't exhibit the bug.

  • DumpRenderTree/LayoutTestController.cpp: (goBackCallback): (setDefersLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
5:31 PM Changeset in webkit [86643] by scherkus@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in new baselines for media/video-canvas-alpha.html for chromium-gpu-{linux,win}.

  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [86642] by Martin Robinson
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Add file missing from my previous commit.

  • Shared/cairo/LayerTreeContextCairo.cpp: Added.
5:22 PM Changeset in webkit [86641] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, un-skipping a few Chromium layout test expectations.

  • platform/chromium/test_expectations.txt:
5:21 PM Changeset in webkit [86640] by atwilson@chromium.org
  • 14 edits
    6 deletes in trunk/Source

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86625.
​http://trac.webkit.org/changeset/86625
​https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Removed.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
  • platform/graphics/chromium/LayerTextureSubImage.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setLayerRenderer): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86625.
​http://trac.webkit.org/changeset/86625
​https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • src/WebViewImpl.cpp:
4:50 PM Changeset in webkit [86639] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

No need to compile .js files, that is what the JIT is for.

  • WebKit.xcodeproj/project.pbxproj:
4:48 PM Changeset in webkit [86638] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, marking media/video-transformed.html as passing on all platforms.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [86637] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move
    3 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix baselines for xss-DENIED-set-opener.html. This is too hard.

  • platform/chromium-linux/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-win-vista/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
4:40 PM Changeset in webkit [86636] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix baselines for set-href-attribute-hash.html. This is too hard.

  • platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
  • platform/chromium-win-vista/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
4:39 PM Changeset in webkit [86635] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=60927
fastCheckSelector() does not inline correctly in all cases

Reviewed by Dave Kilzer.

Use anonymous namespace instead of static qualifier to get internal linkage.
Use functions as template arguments instead of classes.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

4:36 PM Changeset in webkit [86634] by Martin Robinson
  • 3 edits
    1 delete in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​martin.james.robinson@gmail.com>

Try to fix the WinCairo build after r86612.

Move the LayerTreeContextGtk.cpp stub to LayerTreeContextCairo.cpp and add
it to the WinCairo build.

  • GNUmakefile.am: Update the source list.
  • Shared/cairo/LayerTreeContextCairo.cpp: Renamed from Source/WebKit2/Shared/gtk/LayerTreeContextGtk.cpp.
  • win/WebKit2.vcproj: Update the source list.
4:36 PM Changeset in webkit [86633] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Just return "nullptr" to fix compile errors
​https://bugs.webkit.org/show_bug.cgi?id=60932

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
4:33 PM Changeset in webkit [86632] by eae@chromium.org
  • 10 edits in trunk/Source

2011-05-16 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
​https://bugs.webkit.org/show_bug.cgi?id=60743

Change RenderView::documentRect to compute rect once rather than four times.
Replace all uses of docTop/Right/Bottom/Left/Width/Height with documentRect to
simplify the code and reduce complexity.

Covered by existing tests.

  • WebCore.exp.in:
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::forceLayoutForPagination):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  • rendering/RenderView.cpp: (WebCore::RenderView::documentRect):
  • rendering/RenderView.h:

2011-05-16 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
​https://bugs.webkit.org/show_bug.cgi?id=60743

Replace uses of docWidth/Height with documentRect.

  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
4:32 PM Changeset in webkit [86631] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-16 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] shard V8DerivedSources into 19 files
​https://bugs.webkit.org/show_bug.cgi?id=60926

This reduces the clobber build time by 4s on my machine. It helps
by making the slowest to compile V8DerivedSources faster (and thus
more parallelizable). With 8 files, the 3 slowest are 23s, 18s and
10s. With 19 files, the 3 slowest are 16s, 10s, and 10s.

  • WebCore.gyp/WebCore.gyp:
  • storage/IDBObjectStore.h: Fix a missing include that was working because a different .cpp file before it was including the header.
4:13 PM Changeset in webkit [86630] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Fix web audio enabled mac port compile errors
​https://bugs.webkit.org/show_bug.cgi?id=60930

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
4:12 PM Changeset in webkit [86629] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations changes to disable crashing tests.

​https://bugs.webkit.org/show_bug.cgi?id=60931

  • platform/chromium/test_expectations.txt:
4:10 PM Changeset in webkit [86628] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
​https://bugs.webkit.org/show_bug.cgi?id=60925

I suspect this difference is really just papering over other bugs
but now that I finally understand the difference, I should at least
document it for others.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::determineStartPosition):
4:02 PM Changeset in webkit [86627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Scrolling in Twitter is broken after r86102
​https://bugs.webkit.org/show_bug.cgi?id=60922

Fix adjustment handling for pages that trigger the slow scrolling path.
The slow scrolling path is triggered by WebCore when it determines that
doing a simple invalidation is quicker than doing a normal scroll. This
typically happens when there are large elements with fixed positions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment watcher to update its adjustments when a page triggers the slow scrolling path.
4:02 PM Changeset in webkit [86626] by scherkus@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, rebaselining media/video-aspect-ratio.html for chromium-gpu-{linux,mac,win}.

  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:58 PM Changeset in webkit [86625] by alokp@chromium.org
  • 14 edits
    2 copies
    4 adds in trunk/Source

2011-05-16 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Added.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h: Added.
  • platform/graphics/chromium/LayerTextureUpdater.h: Added. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

  • src/WebViewImpl.cpp:
3:57 PM Changeset in webkit [86624] by weinig@apple.com
  • 5 edits in trunk/Tools

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

TestWebKitAPI should build with clang if it can
​https://bugs.webkit.org/show_bug.cgi?id=60918

  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Update CompilerVersion.xcconfig to match others.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add CompilerVersion.xcconfig to the project.
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: (TestWebKitAPI::didSameDocumentNavigationForFrame): Add some casts to quiet warnings from clang.
3:56 PM Changeset in webkit [86623] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed prospective build fix/workaround for chromium ARM compiler error.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::animationNameForTransition):

3:53 PM Changeset in webkit [86622] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Layout test file-URL-with-port-number.html fails on Mac and Linux
​http://code.google.com/p/chromium/issues/detail?id=10342

The consensus is to not support this behavior unless there is a
compelling compatibility reason.

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [86621] by scherkus@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, rebaselining media/video-zoom.html for chromium-gpu-{linux,mac}.

  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
3:48 PM Changeset in webkit [86620] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
​https://bugs.webkit.org/show_bug.cgi?id=60912

No new tests. This will be covered by WebKit2 pixel tests.

  • GNUmakefile.list.am: Added new GtkWidgetBackingStore source and header files.
  • platform/gtk/GtkWidgetBackingStore.h: Added.
  • platform/gtk/GtkWidgetBackingStoreCairo.cpp: Added this implementation of the backing store that uses Cairo and has the same performance characteristics as the WebKit2 implementaiton.
  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Added this implementation of the backing store that uses X11 directly and has better performance than the Cairo version.

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
​https://bugs.webkit.org/show_bug.cgi?id=60912

Instead of allocating the backing store surface directly in WebKit2,
instantiate the GtkWidgetBackingStore class which abstracts away the
platform-specific details of maintaining the backing store.

  • UIProcess/BackingStore.h:
  • UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::paint): Call into GtkWidgetBackingStore to get the Cairo surface now. (WebKit::BackingStore::incorporateUpdate): Ditto. (WebKit::BackingStore::scroll): Call into GtkWidgetBackingStore to do the actual backing store scroll.
3:46 PM Changeset in webkit [86619] by rniwa@webkit.org
  • 3 edits
    2 moves
    2 adds
    17 deletes in trunk/LayoutTests

2011-05-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and converted to dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=60923

Renamed pasteboard/5075944-2.html to pasteboard/preserve-underline-color.html and pasteboard/5075944-3.html to
deleting/deleting-line-break-preserves-underline-color.html. Also converted them to dump-as-markup tests.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: Added.
  • editing/deleting/deleting-line-break-preserves-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-3.html.
  • editing/pasteboard/5075944-2.html: Removed.
  • editing/pasteboard/5075944-3.html: Removed.
  • editing/pasteboard/preserve-underline-color-expected.txt: Added.
  • editing/pasteboard/preserve-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-2.html.
  • platform/chromium-linux/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5075944-3-expected.txt: Removed.
3:45 PM Changeset in webkit [86618] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Layout Test fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing
​http://code.google.com/p/chromium/issues/detail?id=72428

This test is passing, not failing.

  • platform/chromium/fast/dom/HTMLAnchorElement: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [86617] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

cross-frame-access-call.html fails after WebKit r74449
​http://code.google.com/p/chromium/issues/detail?id=67767

These tests aren't really failing. They just have different results
because of interactions with the popup blocker.

  • platform/chromium/http/tests/security/aboutBlank: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
3:39 PM Changeset in webkit [86616] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-16 Dirk Pranke <​dpranke@chromium.org>

Reviewed by David Levin.

add dpranke as a reviewer
​https://bugs.webkit.org/show_bug.cgi?id=60919

  • Scripts/webkitpy/common/config/committers.py:
3:32 PM Changeset in webkit [86615] by cmarrin@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-16 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Plug-in hit testing is broken after zooming
​https://bugs.webkit.org/show_bug.cgi?id=60916

Construct a WebMouseEvent to send to plugin, adjusting values to take pageScaleFactor
into account. Also adjusted bounds sent to viewGeometryDidChange to take pageScaleFactor
into account. Both are needed or the plugin will think the mouse positions are outside
its bounds.

  • Shared/WebEvent.h:
  • Shared/WebMouseEvent.cpp:Add ctor to clone a WebMouseEvent and add a scaleFactor to values (WebKit::WebMouseEvent::WebMouseEvent):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::handleEvent):Adjust mouse coords to take pageScaleFactor into account (WebKit::PluginView::viewGeometryDidChange):Adjust bounds to take pageScaleFactor into account
3:25 PM Changeset in webkit [86614] by scherkus@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, removing baselines for media/media-document-audio-repaint.html as they're incorrect.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [86613] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Csaba Osztrogonác.

​https://bugs.webkit.org/show_bug.cgi?id=59930

Add plugins/object-embed-plugin-scripting.html to qt-mac Skipped list

Note that nearly all plugin tests are currently skipped by qt-mac,
so something may be missng from the buildbot.

  • platform/qt-mac/Skipped:
3:07 PM Changeset in webkit [86612] by Martin Robinson
  • 16 edits
    1 copy
    1 add in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

GTK port of WebKit2 should switch to new DrawingAreaImpl model
​https://bugs.webkit.org/show_bug.cgi?id=59655

  • GNUmakefile.am: Add the files necessary to use the DrawingAreaProxyImpl to the source list. The source list also needs the LayerContextTree stubs.
  • Shared/LayerTreeContext.h: This file should not be guarded by USE(ACCELERATED_COMPOSITING) as it's needed for the DrawingAreaProxyImpl IPC messaging.
  • Shared/gtk/LayerTreeContextGtk.cpp: Added this stub.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createDrawingAreaProxy): Instead of creating the deprecated chunked drawing area, create a DrawingAreaProxyImpl. (WebKit::PageClientImpl::setViewNeedsDisplay): Here we must now queue a redraw. Previously the chunked drawing area was doing this manually. This is the appropriate place though. (WebKit::PageClientImpl::scrollView): Add an implementation that just calls into setViewNeedsDisplay.
  • UIProcess/API/gtk/PageClientImpl.h: Added a getter for m_viewWidget. (WebKit::PageClientImpl::viewWidget):
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): Added this helper which reduces code duplication between GTK+ 2.x and 3.x (webkitWebViewBaseExpose): Call the new helper now. (webkitWebViewBaseDraw): Ditto.
  • UIProcess/BackingStore.h: Updated to include GTK+ specific types.
  • UIProcess/DrawingAreaProxy.h: Ditto.
  • UIProcess/DrawingAreaProxy.messages.in: Do not the DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING).
  • UIProcess/WebPageProxy.cpp: Removed these guards, as DrawingAreProxyImpl is used on all platforms now. (WebKit::WebPageProxy::didReceiveMessage): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/gtk/BackingStoreGtk.cpp: Added. This implementation heavily uses Cairo, but depends on GTK+/GDK in a few places. (WebKit::BackingStore::paint): (WebKit::BackingStore::incorporateUpdate): (WebKit::BackingStore::scroll):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added a getting for the viewWidget, which is required by BackingStoreGtk. A similar getter exists for Windows and Mac. (WebKit::WebPageProxy::viewWidget): Ditto.
  • WebProcess/WebPage/DrawingArea.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::DrawingArea::create): Ditto.
  • WebProcess/WebPage/DrawingArea.h: Ditto.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Do not guard this DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING)
  • WebProcess/WebPage/WebPage.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::WebPage::didReceiveMessage): Ditto.
3:05 PM Changeset in webkit [86611] by robert@webkit.org
  • 5 edits in trunk

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

The unix test plugin needs to call the test's NPP_URLNotify
rather than the browsers.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_url_notify):
2:46 PM WebKit Team edited by bfulgham@webkit.org
(diff)
2:44 PM Changeset in webkit [86610] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, correcting bug number for a test expectation.

  • platform/chromium/test_expectations.txt:
2:42 PM Changeset in webkit [86609] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:

Rubber-stamped by Adam Roben.

2:37 PM Changeset in webkit [86608] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Sandbox denies Kerberos authentication
​https://bugs.webkit.org/show_bug.cgi?id=60921
<rdar://problem/9133872>


  • WebProcess/com.apple.WebProcess.sb:
2:34 PM Changeset in webkit [86607] by crogers@google.com
  • 8 edits
    9 adds in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Reviewed by ​senorblanco@chromium.org.

Add DynamicsCompressorNode implementation
​https://bugs.webkit.org/show_bug.cgi?id=60682

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DynamicsCompressor.cpp: Added. (WebCore::DynamicsCompressor::DynamicsCompressor): (WebCore::DynamicsCompressor::initializeParameters): (WebCore::DynamicsCompressor::parameterValue): (WebCore::DynamicsCompressor::setEmphasisStageParameters): (WebCore::DynamicsCompressor::setEmphasisParameters): (WebCore::DynamicsCompressor::process): (WebCore::DynamicsCompressor::reset):
  • platform/audio/DynamicsCompressor.h: Added. (WebCore::DynamicsCompressor::isStereo): (WebCore::DynamicsCompressor::sampleRate): (WebCore::DynamicsCompressor::nyquist):
  • platform/audio/DynamicsCompressorKernel.cpp: Added. (WebCore::saturate): (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel): (WebCore::DynamicsCompressorKernel::setPreDelayTime): (WebCore::DynamicsCompressorKernel::process): (WebCore::DynamicsCompressorKernel::reset):
  • platform/audio/DynamicsCompressorKernel.h: Added. (WebCore::DynamicsCompressorKernel::latencyFrames): (WebCore::DynamicsCompressorKernel::sampleRate):
  • platform/audio/ZeroPole.cpp: Added. (WebCore::ZeroPole::process):
  • platform/audio/ZeroPole.h: Added. (WebCore::ZeroPole::ZeroPole): (WebCore::ZeroPole::reset): (WebCore::ZeroPole::setZero): (WebCore::ZeroPole::setPole): (WebCore::ZeroPole::zero): (WebCore::ZeroPole::pole):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createDynamicsCompressor):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/DynamicsCompressorNode.cpp: Added. (WebCore::DynamicsCompressorNode::DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::~DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::process): (WebCore::DynamicsCompressorNode::reset): (WebCore::DynamicsCompressorNode::initialize): (WebCore::DynamicsCompressorNode::uninitialize):
  • webaudio/DynamicsCompressorNode.h: Added. (WebCore::DynamicsCompressorNode::create):
  • webaudio/DynamicsCompressorNode.idl: Added.
2:26 PM Changeset in webkit [86606] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Re-added platform-specific result after r86599.

  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from platform/mac-leopard/editing/text-iterator/findString-expected.txt.
2:17 PM Nice Bugzilla queries edited by ddkilzer@webkit.org
Updated 5-year-old links to work with current Bugzilla. (diff)
2:17 PM Changeset in webkit [86605] by rniwa@webkit.org
  • 3 edits
    1 move
    1 add
    11 deletes in trunk/LayoutTests

2011-05-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=60920

Renamed 5091898.html to delete-line-break-before-underlined-content.html and converted it
to a dump-as-markup test.

  • editing/deleting/5091898.html: Removed.
  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: Added.
  • editing/deleting/delete-line-break-before-underlined-content.html: Copied from LayoutTests/editing/deleting/5091898.html.
  • platform/chromium-linux/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.txt: Removed.
  • platform/gtk/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac/editing/style/5091898-expected.png: Removed.
  • platform/mac/editing/style/5091898-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/deleting/5091898-expected.png: Removed.
  • platform/qt/editing/deleting/5091898-expected.txt: Removed.
1:45 PM Changeset in webkit [86604] by tony@chromium.org
  • 57 edits
    1 delete in trunk/LayoutTests

2011-05-16 Tony Chang <​tony@chromium.org>

Move chromium-linux-x86_64 results into chromium-linux. We're making
x86_64 the default configuration for chromium-linux because that's
what the devs build and use.

1:35 PM Changeset in webkit [86603] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix typo pointed out by Dave Levin.

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::assertWKStringEqual):
Strig -> String.

1:28 PM Changeset in webkit [86602] by weinig@apple.com
  • 30 edits in trunk/Tools

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by David Levin.

Convert api tester over to using gtest expectations directly
​https://bugs.webkit.org/show_bug.cgi?id=60862

  • TestWebKitAPI/PlatformUtilities.cpp: (TestWebKitAPI::Util::toSTD):
  • TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::assertWKStrigEqual): Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make the implementation of the macro simpler.
  • TestWebKitAPI/Test.h: Remove TEST_ASSERT forwarder.

[Test changes elided]

1:24 PM Changeset in webkit [86601] by yuzo@google.com
  • 7 edits in trunk/Source

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
​https://bugs.webkit.org/show_bug.cgi?id=43704

In setting printing, we should not validate resources already cached
for the document. If we do, web fonts used for screen are revalidated
and possiby reloaded. Then the fonts can be shown as blank on print.
This patch won't save the case where screen and print use different web
fonts. Nonetheless, this is an improvement.

No new tests because there seems to be no good way to test print images.

  • editing/Editor.cpp: (WebCore::Editor::paste): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • loader/cache/CachedResourceLoader.h: (WebCore::ResourceCacheValidationSuppressor::ResourceCacheValidationSuppressor): RAII class for allowing/disallowing stale resources. (WebCore::ResourceCacheValidationSuppressor::~ResourceCacheValidationSuppressor):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • page/Frame.cpp: (WebCore::Frame::setPrinting): Use ResourceCacheValidationSuppressor to allow stale resources in printing.

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
​https://bugs.webkit.org/show_bug.cgi?id=43704

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
1:18 PM Changeset in webkit [86600] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, de-duplicating media/video-zoom-controls.html expectations.

  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [86599] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe mid-word
​https://bugs.webkit.org/show_bug.cgi?id=60915

Reviewed by Darin Adler.

Source/WebCore:

CFStringTokenizer’s kCFStringTokenizerUnitWord considers “Here’s” as two separate tokens.
Switching to CFStringTokenizer in r84750 was an attempt to address an issue with Japanese word
boundaries for searches with WebFindOptionsAtWordStarts, but it turned out to be insufficient,
and in r86387 the Japanese word issue was addressed independently of text boundaries, so just
revert r84750.

  • platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

LayoutTests:

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
12:59 PM Changeset in webkit [86598] by ddkilzer@apple.com
  • 16 edits in trunk

<​http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
<rdar://problem/9446430>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig: Fixed typo.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit/mac:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit2:

  • Configurations/Base.xcconfig: Fixed typo.

Tools:

  • MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
  • TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  • WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
12:25 PM Changeset in webkit [86597] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for broken regression tests. Adding null pointer check

  • page/FrameView.cpp:

(WebCore::FrameView::didAddHorizontalScrollbar):
(WebCore::FrameView::willRemoveHorizontalScrollbar):

12:04 PM Changeset in webkit [86596] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Remove unused member variables from LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=60899

These should have been removed when tiling was enabled for root
layers.

  • platform/graphics/chromium/LayerRendererChromium.h:
11:58 AM Changeset in webkit [86595] by atwilson@chromium.org
  • 19 edits in trunk

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86589.
​http://trac.webkit.org/changeset/86589
​https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86589.
​http://trac.webkit.org/changeset/86589
​https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
11:54 AM Changeset in webkit [86594] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

JSWeakObjectMap finalisation may occur while gc is in inconsistent state
​https://bugs.webkit.org/show_bug.cgi?id=60908
<rdar://problem/9409491>

We need to ensure that we have called all the weak map finalizers while
the global object (and hence global context) is still in a consistent
state. The best way to achieve this is to simply use a weak handle and
finalizer on the global object.

  • JavaScriptCore.exp:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::WeakMapFinalizer::finalize):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap):
11:08 AM Changeset in webkit [86593] by bweinstein@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix a revision number in the ChangeLog

11:07 AM Changeset in webkit [86592] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r86555): Dropping URL onto Desktop creates broken Internet Shortcut file.

Reviewed by Enrica Casucci.

r86477 fixed this bug by using latin1 as the CString's encoding instead of ascii, but r86555
undid this change.

Change it back to latin1 to fix the bug.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeURL):

11:03 AM Changeset in webkit [86591] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; build fix for non-SnowLeopard builds.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition

of layerIsDescendentOf in a #if check.

10:55 AM Changeset in webkit [86590] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

If the root compositing layer changes while we're about to exit compositing mode, make sure to enter compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=60905
<rdar://problem/9365574>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): If we have a layer tree host, but haven't yet sent a EnterAcceleratedCompositingMode message (this can happen when quickly going in and out of compositing mode), make sure to schedule a notification when the layer tree host does it next flush. This will end up sending the EnterAcceleratedCompositingMode message.
10:54 AM Changeset in webkit [86589] by podivilov@chromium.org
  • 19 edits in trunk

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
10:50 AM Changeset in webkit [86588] by jer.noble@apple.com
  • 7 edits in trunk/Source

2011-05-13 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
​https://bugs.webkit.org/show_bug.cgi?id=60826

Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
next time setVisible(true) is called.

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Call setFullScreenRootLayer(0)

before disabling animation on the full screen renderer.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new

WebKitLayerHostChanged notification.

(WebCore::layerIsDescendentOf): Added.
(WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added. If the changed

layer is an ancestor of the movie layer, tear down rendering and re-
create the next time setVisible(true) is called.

(-[WebCoreMovieObserver layerHostChanged:]): Added ObjC listener wrapper.

2011-05-13 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
​https://bugs.webkit.org/show_bug.cgi?id=60826

Emit a notification when moving a CALayer from the WebProcess's main
layer host to a new context. This allows listeners to invalidate their
layers which may not support moving between different CAContexts (as is
the case with QTMovieLayer). In order to allow listeners to determine if they
are affected, the notification will pass the root CALayer in a userInfo
dictionary.

In WebFullScreenManagerMac, move from storing a pointer to a non-refcounted
class (GraphicsLayer) to a retainable class (PlatformLayer).

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): No need to initialize

m_fullScreenRootLayer now that it is a RetainPtr<>.

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Emit a notification

after either creating or destroying the full screen layer host.

(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

10:48 AM Changeset in webkit [86587] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[WK2] Remove some passing tests from the mac-wk2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=60889

  • platform/mac-wk2/Skipped:
10:32 AM Changeset in webkit [86586] by abarth@webkit.org
  • 4 edits
    2 deletes in trunk

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60874

No need to test a feature that doesn't exist.

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Removed.

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60874

After talking this out with various folks in the CSP working group, we
decided that this syntax isn't the right way to approach this issue.
If we want to address the use case of enabling JavaScript URLs
separately from inline script, we'll probably just make

script-src javascript:

work that way.

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
10:27 AM Changeset in webkit [86585] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebKit2

[Qt][Wk2][Symbian] Fix build after r86560
​https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <​siddharth.mathur@nokia.com> on 2011-05-16
Rubber-stamped by Csaba Osztrogonác.

Temporarily fix Symbian build by re-enabling compilation
of Qt/Gtk common code (as was the case for Symbian before r55875).
This is a stop gap until the pure Symbian Core IPC and process launching bits land in Bug 55875
As of this revision, only the native SharedMemory implementation is in trunk.

  • Platform/CoreIPC/Attachment.h: Compile Qt/Gtk common code for Qt-Symbian too
  • Platform/CoreIPC/Connection.h: ditto
  • Platform/SharedMemory.h: ditto
  • Platform/qt/SharedMemorySymbian.cpp: stub implementations of attachment handling

(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):

10:25 AM Changeset in webkit [86584] by jonlee@apple.com
  • 47 edits in trunk

Source/WebCore: Reviewed by Simon Fraser.

Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

  • dom/Document.cpp: (WebCore::Document::Document): Initialize wheel event handler count (WebCore::Document::didAddWheelEventHandler): Increment count, and tell the main frame to recalculate the total number of wheel event handlers in all of its frames' documents (WebCore::Document::didRemoveWheelEventHandler): Reverse of previous method
  • dom/Document.h: (WebCore::Document::wheelEventHandlerCount): Access the count
  • dom/Node.cpp: (WebCore::tryAddEventListener): If the event listener is a mouse wheel event, then tell the document to increment its count (WebCore::tryRemoveEventListener): Reverse of previous method
  • page/ChromeClient.h: Two new methods:

numWheelEventHandlersChanged: WebProcess tells UIProcess to update its cached

count of total wheel event handlers, which in this case only include horizontal
scrollbars and mouse wheel JS handlers

shouldRubberBandInDirection: allow the UIProcess to provide some control over

whether rubber banding is allowed when scrolling in a particular direction

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::numWheelEventHandlersChanged): Default empty impl (WebCore::EmptyChromeClient::shouldRubberBandInDirection): Default empty impl
  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Remove a redundant pointer check
  • page/Frame.cpp: (WebCore::Frame::setDocument): When the frame's document changes, calculate that document's total wheel event handlers, and notify the UIProcess (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged): Performs a crawl of the frame tree to aggregate the count
  • page/Frame.h:
  • platform/ScrollableArea.h: Virtualize didAddHorizontalScrollbar and willRemoveHorizontalScrollbar for overriding in RenderLayer and FrameView (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition): Returns true if there is no scrollbar or the scroller position is in the minimum scroll position. (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition): Converse of the above. (WebCore::ScrollableArea::shouldRubberBandInDirection): Default impl
  • page/FrameView.cpp: (WebCore::FrameView::didAddHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::willRemoveHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::shouldRubberBandInDirection): Connective glue
  • page/FrameView.h: Adding overriding methods from ScrollableArea
  • rendering/RenderLayer.cpp: Similar functionality to FrameView (WebCore::RenderLayer::didAddHorizontalScrollbar): (WebCore::RenderLayer::willRemoveHorizontalScrollbar):
  • rendering/RenderLayer.h:
  • platform/mac/ScrollAnimatorMac.h: Fix typo of "momentum"
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Fix typo of "momentum" (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::beginScrollGesture): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::snapRubberBand): Fix typo of "momentum"

(WebCore::ScrollAnimatorMac::handleWheelEvent): New logic for determining whether
to allow rubber-banding based on the area's scroll position and the wheel event.
Could prevent accepting the wheel event. Also, fix typo of "momentum"
(WebCore::isScrollingLeftAndShouldNotRubberBand): Inline helper function for logic
(WebCore::isScrollingRightAndShouldNotRubberBand): Inline helper function for logic

Source/WebKit/chromium: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/efl: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientEfl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/gtk: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/haiku: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientHaiku.h:

(WebCore::ChromeClientHaiku::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientHaiku::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/mac: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method

Source/WebKit/qt: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/win: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wince: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientWinCE.h:

(WebKit::ChromeClientWinCE::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientWinCE::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wx: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientWx::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit2: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

We keep track of the number of horizontal scrollbars and mouse wheel event handlers in the
UI process as a means of determining whether horizontal scroll events will be handled
by the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willHandleHorizontalScrollEvents): Return true if there is at least
one wheel event handler

  • UIProcess/WebPageProxy.h: Add new variable to cache the count

(WebKit::WebPageProxy::numWheelEventHandlersChanged): Sets the count

The rest just provides all the connections.

  • UIProcess/API/C/WKPage.cpp:

(WKPageWillHandleHorizontalScrollEvents):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldRubberBandInDirection): Forward to injected bundle UI client
(WebKit::WebChromeClient::updateCountWheelEventHandlers): Updates the web page proxy

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.

10:16 AM Changeset in webkit [86583] by commit-queue@webkit.org
  • 15 edits
    1 copy in trunk

2011-05-16 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
​https://bugs.webkit.org/show_bug.cgi?id=60177

Re-enable the argument-types test as the navigator.getUserMedia options
are now being parsed and raise the appropriate exceptions.

  • platform/chromium/test_expectations.txt:

2011-05-16 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
​https://bugs.webkit.org/show_bug.cgi?id=60177

Add the code and messages for requesting the generation of local streams and getting the reply back.

Tests for the Media Stream API will be provided by the bug 56587.
One test is re-enabled with this patch.

Test: fast/dom/MediaStream/argument-types.html

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/CallbackTask.h: Added. (WebCore::CallbackTask1::create): (WebCore::CallbackTask1::performTask): (WebCore::CallbackTask1::Scheduler::scheduleCallback): (WebCore::CallbackTask1::CallbackTask1):
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::isClientAvailable): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest): (WebCore::MediaStreamController::registerStream): (WebCore::MediaStreamController::generateStream): (WebCore::MediaStreamController::streamGenerated): (WebCore::MediaStreamController::streamGenerationFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback): (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback): (WebCore::::unregisterAll): (WebCore::::detachEmbedder): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::isClientAvailable): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::parseGenerateStreamOptions): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::ClientBase): (WebCore::MediaStreamFrameController::ClientBase::~ClientBase): (WebCore::MediaStreamFrameController::ClientBase::mediaStreamFrameController): (WebCore::MediaStreamFrameController::ClientBase::clientId): (WebCore::MediaStreamFrameController::ClientBase::isStream): (WebCore::MediaStreamFrameController::ClientBase::isGeneratedStream): (WebCore::MediaStreamFrameController::ClientBase::detachEmbedder): (WebCore::MediaStreamFrameController::ClientBase::associateFrameController): (WebCore::MediaStreamFrameController::ClientBase::unregisterClient): (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::~StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isStream): (WebCore::MediaStreamFrameController::StreamClient::unregister): (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator): (WebCore::MediaStreamFrameController::IdGenerator::getNextId): (WebCore::MediaStreamFrameController::ClientMapBase::ClientMapBase):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/NavigatorUserMediaErrorCallback.h:
10:09 AM Changeset in webkit [86582] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=60892

Don't set the ItemClipsChildrenToShape flag for the root platform layer,
since that is now the overflow controls layer. The clip layer, which was
previously the root platform layer, already gets the flag by way of
the GraphicsLayer mask-to-bounds flag.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
9:58 AM Changeset in webkit [86581] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: debuggerWasEnabled notification should not be send to front-end on navigation.
​https://bugs.webkit.org/show_bug.cgi?id=60888

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::restore): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
9:54 AM Changeset in webkit [86580] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
​https://bugs.webkit.org/show_bug.cgi?id=60898
<rdar://problem/9309903>

Special-case Command-A and always return true, indicating that the plug-in handled the event.
This matches WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
9:52 AM Changeset in webkit [86579] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-16 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursors
​https://bugs.webkit.org/show_bug.cgi?id=60804

This test creates an object store with a few records and exercises
a variety of cursors going forward, backward, and over key ranges.
It also updates records from the cursor and checks that the update
stuck.

  • storage/indexeddb/mozilla/cursors-expected.txt: Added.
  • storage/indexeddb/mozilla/cursors.html: Added.
9:34 AM Changeset in webkit [86578] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Short-circuit NPRuntime calls made by Flash during plug-in instantiation
​https://bugs.webkit.org/show_bug.cgi?id=60894
<rdar://problem/8804681>

During plug-in instantiation, Flash makes a couple of NPRuntime calls to get the
URL of the current document as well as the URL of the toplevel document. This leads to
a bunch of IPC traffic that slows down instantiation.

Since we know what calls Flash is making and what results are expected, we can handle the
NPRuntime calls directly in the plug-in process and avoid extra IPC overhead.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): Initialize m_pluginCreationParameters.

(WebKit::PluginControllerProxy::initialize):
Set m_pluginCreationParameters to point to the creation parameters right before
calling Plugin::initialize and restore it back afterwards.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
If the plug-in calling NPN_Invoke has the CanShortCircuitSomeNPRuntimeCallsDuringInitialization
quirk, and we're being initialized, check for the flash_getWindowLocation and
flash_getTopLocation function calls and return the correct values.

(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Check if the script string has the definitions of flash_getWindowLocation or flash_getTopLocation
and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
which could in theory be a backwards compatibility problem if web pages were to assume that these
functions existed on a page with plug-ins. In practice this is probably not a problem, especially since
these functions are only used on Mac WebKit.

  • PluginProcess/PluginControllerProxy.h: (WebKit::PluginControllerProxy::inInitialize): Add helper function.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk for Flash on Mac.
  • Shared/Plugins/PluginQuirks.h: Add Mac specific CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk.
9:06 AM Changeset in webkit [86577] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add a returnValue parameter to tryToShortCircuitInvoke
​https://bugs.webkit.org/show_bug.cgi?id=60891

tryToShortCircuitInvoke needs to be able to indicate that an invoke
call failed. Add a returnValue parameter and have the real return value
indicate whether tryToShortCircuitInvoke did short-circuit the invoke or not.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke):
  • WebProcess/Plugins/PluginView.h:
9:05 AM Changeset in webkit [86576] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-16 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove EAPI macro from functions definition
​https://bugs.webkit.org/show_bug.cgi?id=60754

This macro should be used in header files only.
It's not necessary to have it in definitions.

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_window_features.cpp: (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get):
8:58 AM Changeset in webkit [86575] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the failing mac-wk2 expected results for online-fallback-layering.html, since it now
appears to be passing on the SL WK2 bots:
​http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r86545%20(11698)/http/tests/appcache/online-fallback-layering-pretty-diff.html

  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Removed.
8:23 AM Changeset in webkit [86574] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[Qt][Wk2][Symbian] Fix build after r86560
​https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <​siddharth.mathur@nokia.com> on 2011-05-16
Reviewed by Csaba Osztrogonác.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with USE(UNIX_DOMAIN_SOCKETS)

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder): ditto

8:11 AM Changeset in webkit [86573] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
​https://bugs.webkit.org/show_bug.cgi?id=60886

Make it possible for a plug-in controller to intercept calls to NPN_Invoke, which
will be useful for avoiding sync IPC messages during instantiation.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::evaluate): Call tryToShortCircuitEvaluate. If it returns true, we don't need to call back to the web process to ask it to evaluate the script string.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Always return false for now.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke): Get the plug-in and call tryToShortCircuitInvoke.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke): Call the plug-in controller.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke): Always return false here, since there's no need to short-circuit calls for plug-ins that live in the web process.
7:49 AM Changeset in webkit [86572] by Ademar Reis
  • 2 edits in trunk/Tools

2011-05-16 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] Tools.pro misses include(common.pri)
​https://bugs.webkit.org/show_bug.cgi?id=60883

It includes features.pri, which depends on common.pri (the build is
not broken today with the default options, but this is the right
thing to do).

  • Tools.pro:
7:41 AM Changeset in webkit [86571] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed, skip failing tests.

  • platform/mac-wk2/Skipped: Add fast/forms/focus-with-display-block.html because of missing eventSender.keyDown implementation
  • platform/qt-wk2/Skipped: Add fast/js/array-sort-modifying-tostring.html to make WK2 bot green to be able to catch new regressions
7:38 AM Changeset in webkit [86570] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-16 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix inspector dom action test flake.

  • inspector/elements/edit-dom-actions.html:
7:26 AM Changeset in webkit [86569] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Added fast/forms/focus-with-display-block.html.
7:23 AM Changeset in webkit [86568] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Addd

platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html.

7:23 AM Changeset in webkit [86567] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update results for a new Mac dragging test

This test has been failing since it was added in r86472. I don't know whether the old
results are wrong or the test is actually showing a bug. <​http://webkit.org/b/60882> tracks
the failure.

  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt:
6:44 AM Changeset in webkit [86566] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Windows build fix.

  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::consoleMarkTimeline):
6:36 AM Changeset in webkit [86565] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext):
6:27 AM Changeset in webkit [86564] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
​https://bugs.webkit.org/show_bug.cgi?id=60624

InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
about changes in WebCore.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed):
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::inspectedPage):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros is used for early return in common case when inspector is not opened. In this case inspector instrumentation costs one additional check of a static field. (WebCore::InspectorInstrumentation::didOpenDatabase):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl): (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willCallFunctionImpl): (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willEvaluateScriptImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::willLayoutImpl): (WebCore::InspectorInstrumentation::willLoadXHRImpl): (WebCore::InspectorInstrumentation::willPaintImpl): (WebCore::InspectorInstrumentation::willRecalculateStyleImpl): (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl): (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::willWriteHTMLImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::bindInstrumentingAgents): (WebCore::InspectorInstrumentation::unbindInstrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::didInvalidateStyleAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::applyUserAgentOverride): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::continueAfterPingLoader): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied): (WebCore::InspectorInstrumentation::continueWithPolicyDownload): (WebCore::InspectorInstrumentation::continueWithPolicyIgnore): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::instrumentingAgentsForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):
6:18 AM Changeset in webkit [86563] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Pavel Feldman <​pfeldman@google.com>

Not reviewed: simplify inspector dom actions test.

  • inspector/elements/edit-dom-actions.html:
5:56 AM Changeset in webkit [86562] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-16 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Move Resources Panel search to backend
​https://bugs.webkit.org/show_bug.cgi?id=59596

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::decodeMainResource): (WebCore::InspectorPageAgent::resourceContent): (WebCore::cachedResourcesForFrame): (WebCore::InspectorPageAgent::getCookies): (WebCore::InspectorPageAgent::deleteCookie): (WebCore::createSearchRegexSource): (WebCore::countRegularExpressionMatches): (WebCore::buildObjectForSearchMatch): (WebCore::InspectorPageAgent::searchInResources): (WebCore::InspectorPageAgent::domContentEventFired): (WebCore::InspectorPageAgent::loadEventFired): (WebCore::InspectorPageAgent::frameNavigated): (WebCore::InspectorPageAgent::frameDetached): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype.performSearch.searchInEditedResource): (WebInspector.ResourcesPanel.prototype.performSearch.callback): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype._ensureViewSearchPerformed): (WebInspector.ResourcesPanel.prototype._showSearchResult.callback): (WebInspector.ResourcesPanel.prototype._showSearchResult): (WebInspector.ResourcesPanel.prototype._resetSearchResults): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult): (WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult): (WebInspector.FrameTreeElement.prototype.resourceByURL): (WebInspector.FrameResourceTreeElement.prototype._resetSearchResults): (WebInspector.FrameResourceTreeElement.prototype.get searchMatchesCount): (WebInspector.FrameResourceTreeElement.prototype.searchMatchesFound): (WebInspector.ResourcesSearchController): (WebInspector.ResourcesSearchController.prototype.nextSearchResult): (WebInspector.ResourcesSearchController.prototype.previousSearchResult): (WebInspector.ResourcesSearchController.prototype._searchResult): (WebInspector.SearchResultsTreeElementsTraverser): (WebInspector.SearchResultsTreeElementsTraverser.prototype.first): (WebInspector.SearchResultsTreeElementsTraverser.prototype.last): (WebInspector.SearchResultsTreeElementsTraverser.prototype.next): (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext): (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementHasSearchResults): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.createSearchRegex): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.hasSearchResults): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.jumpToSearchResult): (WebInspector.SourceFrame.prototype._collectRegexMatches):
  • inspector/front-end/utilities.js: ():
5:42 AM Changeset in webkit [86561] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

CSS: Fast path for 'px' lengths should be case-insensitive.
​https://bugs.webkit.org/show_bug.cgi?id=60703

No new tests, this is an optimization that avoids creating
a full CSSParser to parse the value.

  • css/CSSParser.cpp: (WebCore::parseSimpleLengthValue):
5:40 AM Changeset in webkit [86560] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

2011-05-16 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=55875

  • wtf/Platform.h: Exclude Symbian OS from USE(UNIX_DOMAIN_SOCKETS) users

2011-05-16 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=55875

Use global chunks for sharing data between processes.
This is an initial implementation. An outstanding issue
is the correct way to close() the chunk in the SharedMemory d'tor
without triggering a delete by the kernel when the ref-count
temporarily goes to zero.

  • Platform/SharedMemory.h: platform specific handle and chunk name
  • Platform/qt/SharedMemorySymbian.cpp: Added. Native Symbian OS implementation using RChunk.CreateGlobal() for named chunks. The chunk name is serialized and sent over the IPC channel and opened by the remote process using RChunk.OpenGlobal().

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
(WebKit::SharedMemory::systemPageSize):

  • Platform/unix/SharedMemoryUnix.cpp: Exclude Qt-Symbian using HAVE(UNIX_DOMAIN_SOCKETS)
  • WebKit2.pro: Add SharedMemorySymbian.cpp
5:28 AM Changeset in webkit [86559] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/inspector.css

Merge 85402 - 2011-04-30 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector toolbar titles were 2px off.

  • inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7032004

5:24 AM Changeset in webkit [86558] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/NetworkManager.js

Merge 86027 - 2011-05-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7030014

5:05 AM Changeset in webkit [86557] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-16 Naiem Shaik <​naiem.shaik@gmail.com>

Reviewed by Adam Barth.

This is for fixing build break in webgl due to ​https://bugs.webkit.org/show_bug.cgi?id=59861
The bug raised for fixing this is ​https://bugs.webkit.org/show_bug.cgi?id=60867

No new tests. This does not change any functionality.

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.cpp: (WebCore::GraphicsContext3DInternal::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.h:
5:00 AM Changeset in webkit [86556] by pfeldman@chromium.org
  • 5 edits in trunk

2011-05-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: parse edited attributes by means of InspectorDOMAgent.
​https://bugs.webkit.org/show_bug.cgi?id=60807

This change moves attribute parsing from the front-end to the backend.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttribute):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
3:58 AM Changeset in webkit [86555] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Switch from Vector<UChar> to StringBuilder in dom/
​https://bugs.webkit.org/show_bug.cgi?id=57843

Incorporate comment from Darin/Andreas.

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i]. (WebCore::convertPropertyNameToAttributeName): Ditto.
3:51 AM Changeset in webkit [86554] by apavlov@chromium.org
  • 6 edits in trunk

2011-05-16 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
​https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:

2011-05-16 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
​https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
3:20 AM Changeset in webkit [86553] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Darin Adler.

Switch from Vector<UChar> to StringBuilder in dom/
​https://bugs.webkit.org/show_bug.cgi?id=57843

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): (WebCore::convertPropertyNameToAttributeName):
  • dom/Range.cpp: (WebCore::Range::toString):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptContent):
2:53 AM Changeset in webkit [86552] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-05 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move double click handling from TextEditor to SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=60271

It is SourceFrame's responsibility to check if content is editable and
to configure TextEditor component (e.g. set editable range) when user
tries to initiate editing.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.doubleClick): (WebInspector.RevisionSourceFrame.prototype.doubleClick):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.beforeTextChanged): (WebInspector.SourceFrame.prototype.afterTextChanged): (WebInspector.SourceFrame.prototype.doubleClick): (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.cancelEditing): (WebInspector.SourceFrame.prototype._setReadOnly):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._doubleClick): (WebInspector.TextViewer.prototype._commitEditing): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewerDelegate.prototype.doubleClick): (WebInspector.TextViewerDelegate.prototype.beforeTextChanged): (WebInspector.TextViewerDelegate.prototype.afterTextChanged):
2:50 AM Changeset in webkit [86551] by loislo@chromium.org
  • 4 edits in trunk

2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:
2:30 AM Changeset in webkit [86550] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Partial revert of r86537. FullScreenVideoQt.h can't depend on OwnPtr.h
because moc_FullScreenVideoQt.cpp fails to include config.h.
Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
is hard, so we're going back to manual new and delete for this class.
Bad times.

  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
2:27 AM Changeset in webkit [86549] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r86489.

  • GNUmakefile.am: Add PluginProcess/PluginCreationParameters.cpp and PluginProcess/PluginCreationParameters.h to compilation.
2:17 AM Changeset in webkit [86548] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-16 Huzaifa Sidhpurwala <​huzaifas@redhat.com>

Reviewed by Adam Barth.

Add Huzaifa Sidhpurwala to the WebKit Security Group site.
​https://bugs.webkit.org/show_bug.cgi?id=60686

  • security/security-group-members.html:
2:08 AM Changeset in webkit [86547] by barraclough@apple.com
  • 7 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60866
Evaluation order broken for empty alternatives in subpatterns

Rubber stamped by Geoff Garen.

Source/JavaScriptCore:

Reverting ​https://bugs.webkit.org/show_bug.cgi?id=51395

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

LayoutTests:

Reverted ​https://bugs.webkit.org/show_bug.cgi?id=51395, and added
test cases for /(|a)/ and /(a|)/, to test the evaluation order of
subpattern matches with empty alternatives.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
  • fast/regex/script-tests/slow.js:
  • fast/regex/slow-expected.txt:
1:25 AM Changeset in webkit [86546] by alex
  • 2 edits in trunk/LayoutTests

2011-05-16 Alejandro G. Castro <​alex@igalia.com>

Skipped failing test, the fail already has a bug:

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60834

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [86545] by Carlos Garcia Campos
  • 4 edits
    5 adds in trunk

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
​https://bugs.webkit.org/show_bug.cgi?id=58223

  • configure.ac: Add configure option to enable/disable plugin process.

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
​https://bugs.webkit.org/show_bug.cgi?id=58223

  • GNUmakefile.am: Add new files to compilation.
  • PluginProcess/gtk/PluginControllerProxyGtk.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/gtk/PluginProcessGtk.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebProcess/Plugins/Netscape/gtk/PluginProxyGtk.cpp: Added. (WebKit::PluginProxy::needsBackingStore):
1:02 AM Changeset in webkit [86544] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createGraphicsContext):
12:59 AM Changeset in webkit [86543] by Nikolas Zimmermann
  • 1 edit in trunk/Source/WebCore/plugins/PluginStream.cpp

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
​https://bugs.webkit.org/show_bug.cgi?id=60700

Oops, forgot to include plugins/ in my previous commit.

Remove makeString() usage everywhere, instead directly use operator+.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
12:56 AM Changeset in webkit [86542] by Nikolas Zimmermann
  • 52 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
​https://bugs.webkit.org/show_bug.cgi?id=60700

Remove makeString() usage everywhere, instead directly use operator+.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::borderSpacingValue):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
  • html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::didReceiveResponse):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::crossDomainAccessErrorMessage):
  • page/PageSerializer.cpp: (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator): (WebCore::SerializerMarkupAccumulator::appendElement): (WebCore::PageSerializer::urlForBlankFrame):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
  • platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationIdentifier):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL):
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL):
  • platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::reportErrorToClient):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeURL):
  • platform/win/FileSystemWin.cpp: (WebCore::listDirectory):
  • platform/win/LanguageWin.cpp: (WebCore::platformDefaultLanguage):
  • platform/win/PathWalker.cpp: (WebCore::PathWalker::PathWalker):
  • platform/win/SystemInfo.cpp: (WebCore::osVersionForUAString): (WebCore::windowsVersionForUAString):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::valueAsString):
  • svg/SVGLength.cpp: (WebCore::SVGLength::valueAsString):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::cssText):
  • svg/SVGPointList.cpp: (WebCore::SVGPointList::valueAsString):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::valueAsString):
  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString):
  • svg/SVGTransformList.cpp:
  • svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
12:51 AM Changeset in webkit [86541] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Sigh. This code is somewhat crazy.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
12:43 AM Changeset in webkit [86540] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

This patch requires some slightly fancy footwork.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
12:30 AM Changeset in webkit [86539] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-05-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector console should be searchable
​https://bugs.webkit.org/show_bug.cgi?id=60711

Search now works for Console panel. It shows number of matching console entries
and allows to jump to the next matching console entry. Also the matches count
is dynamically updated when new messages are added to the console.

ResourceTreeModel and DebuggerPresentationModel now listen to console events instead
of being called directly from ConsoleView.

  • inspector/front-end/ConsolePanel.js: (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.searchCanceled): (WebInspector.ConsolePanel.prototype.performSearch): (WebInspector.ConsolePanel.prototype.jumpToNextSearchResult): (WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult): (WebInspector.ConsolePanel.prototype._clearCurrentSearchResultHighlight): (WebInspector.ConsolePanel.prototype._jumpToSearchResult): (WebInspector.ConsolePanel.prototype._consoleMessageAdded): (WebInspector.ConsolePanel.prototype._consoleCleared):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage.prototype.clearHighlight): (WebInspector.ConsoleMessage.prototype.highlightSearchResults): (WebInspector.ConsoleMessage.prototype.matchesRegex): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype.clearHighlight): (WebInspector.ConsoleCommand.prototype.highlightSearchResults): (WebInspector.ConsoleCommand.prototype.matchesRegex): (WebInspector.ConsoleCommand.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype._formatCommand):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded): (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
  • inspector/front-end/utilities.js: ():
12:27 AM Changeset in webkit [86538] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Missing include.

  • WebCoreSupport/PopupMenuQt.h:
12:24 AM Changeset in webkit [86537] by abarth@webkit.org
  • 13 edits in trunk/Source

2011-05-16 Adam Barth <​abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60873

This change is slightly more than a build fix because the patch kind of
spidered a bit while I was trying to fix the build the "right way."
Hopefully nothing here is controversial.

  • Api/qwebpage.cpp: (QWebPagePrivate::adjustPointForClicking):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationWrapper::NotificationWrapper): (WebCore::NotificationPresenterClientQt::displayNotification):
  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::show):
  • WebCoreSupport/PopupMenuQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createSelectInputMethod): (WebCore::QtPlatformPlugin::createNotificationPresenter): (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer): (WebCore::QtPlatformPlugin::createTouchModifier): (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h: (WebCore::QtPlatformPlugin::QtPlatformPlugin):

2011-05-16 Adam Barth <​abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60873

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
12:21 AM Changeset in webkit [86536] by barraclough@apple.com
  • 5 edits in trunk

Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=60860
Simplify backtracking in YARR JIT

Reviewed by Geoff Garen & Michael Saboff.

YARR JIT currently performs a single pass of code generation over the pattern,
with special handling to allow the code generation for some backtracking code
out of line. We can simplify things by moving to a common mechanism whereby all
forwards matching code is generated in one pass, and all backtracking code is
generated in another. Backtracking code can be generated in reverse order, to
optimized the common fall-through case.

To make it easier to walk over the pattern, we can first convert to a more
byte-code like format before JIT generating. In time we should unify this with
the YARR interpreter to more closely unify the two.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):
(JSC::Yarr::YarrGenerator::BacktrackingState::BacktrackingState):
(JSC::Yarr::YarrGenerator::BacktrackingState::append):
(JSC::Yarr::YarrGenerator::BacktrackingState::fallthrough):
(JSC::Yarr::YarrGenerator::BacktrackingState::link):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkTo):
(JSC::Yarr::YarrGenerator::BacktrackingState::takeBacktracksToJumpList):
(JSC::Yarr::YarrGenerator::BacktrackingState::isEmpty):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkDataLabels):
(JSC::Yarr::YarrGenerator::BacktrackingState::ReturnAddressRecord::ReturnAddressRecord):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::backtrackAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileAlternative):
(JSC::Yarr::YarrGenerator::opCompileBody):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=60860
Add layout tests for some regular expressions that used to crash the compiler.

Reviewed by Geoff Garen & Michael Saboff.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
12:07 AM Changeset in webkit [86535] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

media/video-volume-slider.html causes GTK 64 bit debug bot to time out
​https://bugs.webkit.org/show_bug.cgi?id=60055

  • media/video-volume-slider.html: Use the shadow DOM tree to locate the mute button and get its coordinates. This test is now more port-agnostic.
12:01 AM Changeset in webkit [86534] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

2011-05-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Darin Adler.

Move mediaControlsButtonCoordinates() out of video-test.js
​https://bugs.webkit.org/show_bug.cgi?id=60693

Moved the function to a new js file called media-controls.js. Also
made the function throw an exception if the button is not found
and handle the exception in the various tests using the function.

  • media/audio-delete-while-step-button-clicked.html:
  • media/media-controls.js: Added. (mediaControlsButtonCoordinates):
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (isInTimeRanges):

May 15, 2011:

11:52 PM Changeset in webkit [86533] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachCurrentPage): (QGraphicsWebView::setPage):
  • Api/qwebpage.cpp: (QWebPage::setView):
11:46 PM Changeset in webkit [86532] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::GraphicsLayerQt): (WebCore::GraphicsLayer::create):
11:41 PM Changeset in webkit [86531] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/text/qt/TextCodecQt.cpp: (WebCore::newTextCodecQt):
11:36 PM Changeset in webkit [86530] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::release): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::start):
11:30 PM Changeset in webkit [86529] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doEnd):
11:21 PM Changeset in webkit [86528] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Enable strict PassOwnPtr on Qt. (Build fixes to follow.)

  • wtf/PassOwnPtr.h:
11:15 PM Changeset in webkit [86527] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-15 MORITA Hajime <​morrita@google.com>

Unreviewed an expectation update.

  • platform/gtk/fast/html/details-add-child-2-expected.txt:
10:59 PM Changeset in webkit [86526] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

2011-05-15 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
​https://bugs.webkit.org/show_bug.cgi?id=60602

Add a test that ensures <output>, <meter> and <progress> are not focused.
Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

  • fast/forms/focus-with-display-block-expected.txt: Added.
  • fast/forms/focus-with-display-block.html: Added.
  • platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.

2011-05-15 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
​https://bugs.webkit.org/show_bug.cgi?id=60602

HTMLFormControlElement::isFocusable() returns true when the element is
visible as a block element. However, for output, meter, and progress
elements, the function should not return true unless they have
tabindex attributes. Override supportsFocus() of these elements to
apply the result of Node::supportsFocus() because it takes care of
whether the element has tabindex or not.

Test: fast/forms/focus-with-display-block.html

  • html/HTMLFormControlElement.h: Made supportsFocus() protected.
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::supportsFocus): Added.
  • html/HTMLMeterElement.h:
  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::supportsFocus): Added.
  • html/HTMLOutputElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::supportsFocus): Added.
  • html/HTMLProgressElement.h:
10:44 PM Changeset in webkit [86525] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

10:31 PM Changeset in webkit [86524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-15 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
​https://bugs.webkit.org/show_bug.cgi?id=60864

Implemented reuse of BackingStore's in
DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
matches the size of the existing BackingStore.
Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
These changes reduces memory usage up to 10MB on memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
10:10 PM Changeset in webkit [86523] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.

​https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason


(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))


I'm basically rolling out ​http://trac.webkit.org/changeset/49786 because

(a) it created this performance problem


and


(b) a more complete fix, which obsoletes ​http://trac.webkit.org/changeset/49786,
was committed in ​http://trac.webkit.org/changeset/53439.


Tested with the file attached to ​https://bugs.webkit.org/show_bug.cgi?id=29832.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't create a new window every time we destroy a frame.
8:29 PM Changeset in webkit [86522] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Pass the window NPObject identifier in the plug-in creation parameters
​https://bugs.webkit.org/show_bug.cgi?id=60865

This avoids a synchronous call when the plug-in wants to get the NPObject that
corresponds to the window.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): Change this to take the PluginCreationParameters. Initialize the window NPObject.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Just return the window NPObject; it's already been initialized.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Add the window NPObject ID.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin): Pass the creation parameters to PluginControllerProxy::initialize.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Initialize the window NPObject ID.
  • WebProcess/Plugins/PluginProxy.messages.in: Remove the GetWindowScriptNPObject message.
7:55 PM Changeset in webkit [86521] by morrita@google.com
  • 15 edits
    2 copies
    12 adds in trunk

2011-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should affect the order of renderer children
​https://bugs.webkit.org/show_bug.cgi?id=59157

  • fast/html/details-add-details-child-1.html: Added.
  • fast/html/details-add-details-child-2.html: Added.
  • fast/html/details-nested-1.html: Added.
  • fast/html/details-nested-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.txt: Added.
  • platform/mac/fast/html/details-nested-2-expected.png: Added.
  • platform/mac/fast/html/details-nested-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:

2011-05-12 MORITA Hajime <​morrita@google.com>

ShadowContentElement should affect the order of renderer children
​https://bugs.webkit.org/show_bug.cgi?id=59157

Introduced ShadowContentSelector to collect and forward content
children for each ShadowContentElement. ShadowRoot collects child
nodes of its host (we call these children "content children"), and
the descendant ShadowContentElement pulls that these content
children and put it under its child during
ShadowContentElement::attach().

Content children no longer create its renderer during its normal
attach() phase (called "light" phase). And they create it during
attach() as a content children instead (called "forwarded phase").
These phases are detected by NodeRendererFactory and represented
as NodeRendererFactory::AttachPhase value AttachContentLight and
AttachContentForwarded.

Tests: fast/html/details-add-details-child-1.html

fast/html/details-add-details-child-2.html
fast/html/details-nested-1.html
fast/html/details-nested-2.html

  • dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/ShadowRoot.cpp: (WebCore::forceReattach): (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance): (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor): (WebCore::ShadowContentElement::attach): (WebCore::ShadowRoot::recalcStyle): (WebCore::ShadowRoot::activeContentContainer): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::attach):
  • dom/ShadowRoot.h:
  • html/shadow/ShadowContentElement.h: (WebCore::ShadowContentElement::rendererIsNeeded):
  • rendering/RenderDetails.cpp:
  • rendering/RenderDetails.h:
7:46 PM Changeset in webkit [86520] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-13 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
​https://bugs.webkit.org/show_bug.cgi?id=57088

Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::resolveTextCheckingTypeMask):
  • editing/Editor.h:
  • platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel
6:44 PM Changeset in webkit [86519] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-15 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.
6:35 PM Changeset in webkit [86518] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Dominic Cooney <​dominicc@chromium.org>

Unreviewed. Remove expectation of gc-shadow.html flakiness.

  • platform/chromium/test_expectations.txt:
6:21 PM Changeset in webkit [86517] by dominicc@chromium.org
  • 2 edits in trunk/Tools

2011-05-15 Dominic Cooney <​dominicc@chromium.org>

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
5:53 PM Changeset in webkit [86516] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen.

Pass the document URL and toplevel document URL when creating a plug-in
​https://bugs.webkit.org/show_bug.cgi?id=60863

This is the first of a series of patches intended to reduce the IPC traffic
during plug-in instantiation.

  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Parameters::encode): Encode the URLs.

(WebKit::Plugin::Parameters::decode):
Decode the URLs.

  • WebProcess/Plugins/Plugin.h: Add the document and toplevel document URLs.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Initialize the document and toplevel document URLs.
4:54 PM Changeset in webkit [86515] by dbates@webkit.org
  • 6 edits in trunk/Tools

2011-05-15 Daniel Bates <​dbates@webkit.org>

Reviewed by Chris Jerdonek.

svn-apply can't handle Git diff that only changes executable bit
​https://bugs.webkit.org/show_bug.cgi?id=60848

Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
that only has an executable bit change.

  • Scripts/VCSUtils.pm:
    • Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().

(parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
fixing <​https://bugs.webkit.org/show_bug.cgi?id=29684>.

  • Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
  • Scripts/svn-unapply: (patch): Ditto.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated expected results for test cases to account for numTextChunks.
    • Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
    • Added test case "Git: file that only has an executable bit change".
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
    • Updated expected results for test cases to account for numTextChunks.
4:20 PM Changeset in webkit [86514] by rwlbuis@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-15 Rob Buis <​rbuis@rim.com>

Reviewed by Eric Seidel.

REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
​https://bugs.webkit.org/show_bug.cgi?id=16614

Include testcase from the bug to prevent future regression (right now we pass both full testcase
and this reduction).

  • platform/mac/svg/custom/small-rect-scale-expected.png: Added.
  • platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
  • svg/custom/small-rect-scale.svg: Added.
4:02 PM Changeset in webkit [86513] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build.

  • TestWebKitAPI/win/main.cpp:

(main):

3:49 PM Changeset in webkit [86512] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86509.

  • platform/qt/Skipped:
3:41 PM Changeset in webkit [86511] by weinig@apple.com
  • 6 edits in trunk/Tools

2011-05-15 Sam Weinig <​sam@webkit.org>

Reviewed by David Levin.

Make API tester more gtest friendly
​https://bugs.webkit.org/show_bug.cgi?id=60859

  • Scripts/run-api-tests: Numerous changes:
  • Remove logic to run tests one at a time.
  • Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us.
  • Forward stdout from the test tool to stdout, even in non-verbose runs.
  • Run test tool from the current working directory instead of the root webkit directory.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources.
  • TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run):
  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point.
3:31 PM Changeset in webkit [86510] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/JSFunction.cpp: Made the host function stub cache weak --

otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

11:43 AM Changeset in webkit [86509] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Just skipping a test.

  • platform/qt/Skipped: inspector/console/console-long-eval-crash.html
10:34 AM Changeset in webkit [86508] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, just skipping a test.

New test fails on some of the SnowLeopard bots.

  • platform/mac-snowleopard/Skipped:
9:57 AM Changeset in webkit [86507] by loislo@chromium.org
  • 10 edits
    2 adds in trunk

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
9:18 AM Changeset in webkit [86506] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
​https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Test: http/tests/media/video-cross-site.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction

to prevent cross-domain references from being followed.

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
​https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Add test for cross-domain QuickTime reference movie and test.

  • http/tests/media/resources/cross-site-reference.mov: Added.
  • http/tests/media/video-cross-site-expected.txt: Added.
  • http/tests/media/video-cross-site.html: Added.
  • platform/chromium/test_expectations.txt: Skipped, QuickTime reference movies not supported.
  • platform/gtk/Skipped: Ditto.
7:07 AM Changeset in webkit [86505] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
6:49 AM Changeset in webkit [86504] by robert@webkit.org
  • 9 edits
    1 add in trunk

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
​https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
4:40 AM Changeset in webkit [86503] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Arno Renevier <​arno@renevier.net>

Reviewed by Darin Adler.

remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60775

No new tests. This change only impacts compilation.

  • html/HTMLFrameElementBase.cpp:
Note: See TracTimeline for information about the timeline view.