Timeline

May 18, 2011:

11:40 PM Changeset in webkit [86822] by ukai@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-18 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=57048

• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): use loaderRunLoop to schedule streams on platform WIN

11:17 PM Changeset in webkit [86821] by loki@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] Skip flaky timed out tests on ARM

Rubber-stamped by Csaba Osztrogonác.

• platform/qt-arm/Skipped:

11:16 PM Changeset in webkit [86820] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

As originally reviewed by Anders Carlsson.

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Restore r86797 to how it was supposed to be using the appropriate #ifdef,
reverting the temporary r86814 in the process.

The #ifdef is BUILDING_ON_SNOW_LEOPARD, not BUILDING_ON_SNOWLEOPARD!

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

11:08 PM Changeset in webkit [86819] by morrita@google.com

• 2 edits in trunk/Source/WebCore

2011-05-18 MORITA Hajime <​morrita@google.com>

Unreviewed attempt to fix clang build.

• rendering/InlineTextBox.h:

9:08 PM Changeset in webkit [86818] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

2011-05-18 Ryosuke Niwa <​rniwa@webkit.org>

Yet another rebaseline after r81176.

• platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:

9:02 PM Changeset in webkit [86817] by rniwa@webkit.org

• 2 edits
  1 add
  8 deletes in trunk/LayoutTests

2011-05-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

editing/pasteboard/paste-blockquote-into-blockquote-3.html should be a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=61102

Converted the test.

• editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
• editing/pasteboard/paste-blockquote-into-blockquote-3.html:
• platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
• platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
• platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.

8:21 PM Changeset in webkit [86816] by commit-queue@webkit.org

• 4 edits in trunk/Source

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

• platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImplContentPainter::paint):

7:41 PM Changeset in webkit [86815] by enne@google.com

• 2 edits in trunk/Source/WebCore

2011-05-18 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect size when clipping image layer upload rects
​https://bugs.webkit.org/show_bug.cgi?id=61105

The clipped destination and source rects should have the same size.

• platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::updateTextureRect):

7:28 PM Changeset in webkit [86814] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Fix the WK2 SnowLeopard layouttests (again) until I can explore on a SnowLeopard machine tomorrow.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

6:38 PM Changeset in webkit [86813] by morrita@google.com

• 14 edits in trunk/Source

2011-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

• Moved DocumentMarker's member variables to private and added getters for them.
• Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
• Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController::addTextMatchMarker() because it accesses DocumentMarker internals.
• Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)

• dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
• dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
• dom/DocumentMarkerController.h:
• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
• editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
• editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
• editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
• rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):

6:36 PM Changeset in webkit [86812] by Darin Adler

• 32 edits in trunk/Source/WebKit2

2011-05-18 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
​https://bugs.webkit.org/show_bug.cgi?id=60872

Eliminate the concept of SyncReplyMode and instead hand around ownership
of the reply decoder using an OwnPtr.

• Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchSyncMessage): Eliminated comments that say the same things the code itself does. Removed code that handles the reply mode. Instead, pass the OwnPtr to the message handling function and make the call to sendSyncReply conditional on whether the reply encoder is still non-null.

• Platform/CoreIPC/Connection.h: Removed SyncReplyMode. Made didReceiveSyncMessage return void, and take OwnPtr<ArgumentEncoder>& for the reply encoder.

• Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Take an OwnPtr&. Replaced the call to adoptPtr with a call to release.

• PluginProcess/PluginControllerProxy.h: Updated to take an OwnPtr& and not return SyncReplyMode.
• PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::didReceiveSyncMessage): Ditto.
• PluginProcess/WebProcessConnection.h: Ditto.

• Scripts/webkit2/messages.py: Updated for changes to sync messages. Eliminated unneeded return types and use get() when apporopriate to call the handleMessage functions.

• Scripts/webkit2/messages_unittest.py: Tried to update this too. I don't know how to run the test, though.

• Shared/Plugins/NPObjectMessageReceiver.h: Updated to take an OwnPtr& and not return SyncReplyMode.
• Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::didReceiveSyncMessage): Ditto.
• Shared/Plugins/NPRemoteObjectMap.h: Ditto.
• UIProcess/Downloads/DownloadProxy.h: Ditto.
• UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveSyncMessage): Ditto.
• UIProcess/WebContext.h: Ditto.
• UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage): Ditto.
• UIProcess/WebFullScreenManagerProxy.h: Ditto.
• UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::didReceiveSyncMessage): Ditto.
• UIProcess/WebIconDatabase.h: Ditto.
• UIProcess/WebInspectorProxy.h: Ditto.
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
• UIProcess/WebPageProxy.h: Ditto.
• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveSyncMessage): Ditto.
• UIProcess/WebProcessProxy.h: Ditto.

• WebProcess/Plugins/Netscape/JSNPObject.cpp: Added a missing include.

• WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveSyncMessage): Updated to take an OwnPtr& and not return SyncReplyMode.
• WebProcess/Plugins/PluginProcessConnection.h: Ditto.
• WebProcess/Plugins/PluginProxy.h: Ditto.
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveSyncMessage): Ditto.
• WebProcess/WebPage/WebPage.h: Ditto.
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveSyncMessage): Ditto.
• WebProcess/WebProcess.h: Ditto.

6:31 PM Changeset in webkit [86811] by jschuh@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium test expectations update.

• platform/chromium/test_expectations.txt:

6:15 PM Changeset in webkit [86810] by oliver@apple.com

• 3 edits in trunk/Source/WebCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

+[WebScriptObject throwException:] doesn't work when invoked from obj-c field access
​https://bugs.webkit.org/show_bug.cgi?id=61100

The objc bindings were written to assume exceptions would
come from obj-c style exceptions, rather than throwException:
This code simply calls the global ObjcInstance mechanism for
transferring the reported exception.

• bridge/objc/objc_instance.h:
• bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::ObjcField::setValueToInstance):

5:45 PM Changeset in webkit [86809] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
​https://bugs.webkit.org/show_bug.cgi?id=61064

Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.

• runtime/JSObject.h:

5:38 PM Changeset in webkit [86808] by enne@google.com

• 2 edits in trunk/Source/WebCore

2011-05-16 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Robustly handle mapTexSubImage2D returning NULL
​https://bugs.webkit.org/show_bug.cgi?id=60934

Also, lazily create the temp buffer so that both the map and non-map
cases can use it.

• platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

5:16 PM Changeset in webkit [86807] by eae@chromium.org

• 5 edits in trunk/Source/WebCore

2011-05-18 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Change RenderTextControl::hitInnerTextElement to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61003

Covered by existing tests.

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
• rendering/RenderTextControl.h:
• rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):

5:10 PM Changeset in webkit [86806] by Chris Fleizach

• 13 edits in trunk/Source

WK2: VoiceOver cannot move focus into a web area programmatically
​https://bugs.webkit.org/show_bug.cgi?id=60661

Reviewed by Maciej Stachowiak.

Source/WebCore:

Accessibility code relies on the ability to bring focus to the containing widget view.
In WK2, that message needs to be propagated to the UI process.

• page/ChromeClient.h:

(WebCore::ChromeClient::makeFirstResponder):

• page/mac/ChromeMac.mm:

(WebCore::Chrome::focusNSView):

• platform/mac/WidgetMac.mm:

(WebCore::Widget::setFocus):

Source/WebKit2:

Add a makeFirstResponder method that will bring focus to the widget view within the UI
process.

• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::makeFirstResponder):

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::makeFirstResponder):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::makeFirstResponder):

• WebProcess/WebCoreSupport/WebChromeClient.h:

4:53 PM Changeset in webkit [86805] by enne@google.com

• 14 edits
  2 copies
  4 adds in trunk/Source

2011-05-18 Alok Priyadarshi <​alokp@chromium.org> and Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

• WebCore.gypi:
• platform/chromium/TraceEvent.h:
• platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
• platform/graphics/chromium/ContentLayerChromium.h:
• platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
• platform/graphics/chromium/ImageLayerChromium.h:
• platform/graphics/chromium/LayerPainterChromium.h: Added.
• platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
• platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
• platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
• platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
• platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
• platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-18 Alok Priyadarshi <​alokp@chromium.org> and Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

• src/WebViewImpl.cpp:

4:43 PM Changeset in webkit [86804] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

2011-05-18 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
​https://bugs.webkit.org/show_bug.cgi?id=58609

One new test and one fix to an existing test that relied on the old
broken behavior.

• storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Added.
• storage/indexeddb/mozilla/key-requirements-put-no-key.html: Added.
• storage/indexeddb/objectstore-autoincrement-expected.txt:
• storage/indexeddb/objectstore-autoincrement.html:

2011-05-18 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
​https://bugs.webkit.org/show_bug.cgi?id=58609

Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
no key generator means that objectStore->autoIncrement() is false, and
key parameter was not provided means that prpKey will be a null pointer.
The combination of these 3 should throw a DATA_ERR.

Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html

• storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put):

4:34 PM Changeset in webkit [86803] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

2011-05-18 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Oliver Hunt.

[Qt] fast/encoding/yentest.html and yentest2.html fail
​https://bugs.webkit.org/show_bug.cgi?id=39852

• platform/qt/Skipped: Unskip passing tests.

4:28 PM Changeset in webkit [86802] by jschuh@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium test expectations update for details element (Windows).

• platform/chromium/test_expectations.txt:

4:14 PM Changeset in webkit [86801] by crogers@google.com

• 2 edits in trunk/Source/WebCore

2011-05-18 Chris Rogers <​crogers@google.com>

Reviewed by James Robinson.

EqualPowerPanner is not using the correct azimuth range for stereo panning
​https://bugs.webkit.org/show_bug.cgi?id=61085

No new tests since audio API is not yet implemented.

• platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):

4:14 PM Changeset in webkit [86800] by jschuh@chromium.org

• 4 edits
  21 adds in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update for SVG tests.

• platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
• platform/chromium-linux-x86/svg/dynamic-updates: Added.
• platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
• platform/chromium-linux-x86/svg/filters: Added.
• platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
• platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
• platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Added.
• platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
• platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
• platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt: Added.
• platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Added.
• platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
• platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
• platform/chromium-win-vista/svg/dynamic-updates: Added.
• platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
• platform/chromium-win-vista/svg/filters: Added.
• platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Added.

3:17 PM Changeset in webkit [86799] by brettw@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

2011-05-18 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Don't create empty file objects if no download file path is specified.
​https://bugs.webkit.org/show_bug.cgi?id=60798

• src/WebURLResponse.cpp: (WebKit::WebURLResponse::setDownloadFilePath):

3:10 PM Changeset in webkit [86798] by yi.4.shen@nokia.com

• 7 edits in trunk

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Unskip the fast/events/onsearch-enter.html test.

• platform/qt/Skipped:

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Fill the missing key text for the EnterKey event.

Tests: fast/events/onsearch-enter.html

• platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent):

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Remove the implementation of the handleInputMethodKeydown, which introduces
a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.

• WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
• tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Add more tests.

3:04 PM Changeset in webkit [86797] by beidson@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

• Platform/unix/EnvironmentUtilities.cpp: Remove an unnecessary #include, as reviewed.

3:03 PM Changeset in webkit [86796] by Lucas Forschler

• 21 edits
  1 delete in tags/Safari-534.36/Source

rollout r86699.

2:58 PM Changeset in webkit [86795] by Lucas Forschler

• 5 edits in trunk/Source

Versioning.

2:54 PM Changeset in webkit [86794] by Lucas Forschler

• 1 copy in tags/Safari-534.36

New tag.

2:47 PM Changeset in webkit [86793] by timothy@apple.com

• 12 edits in trunk/Source

Update the the context menu to reflect the system search provider on Mac.

<rdar://problem/9198419>

Reviewed by Sam Weinig.

Source/WebCore:

• English.lproj/Localizable.strings: Updated.
• Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
• platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
create the string.

• platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
• platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

• DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
create the web search context menu title.

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

Source/WebKit2:

• WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle): Add a FIXME about using NSPerformService on Mac.

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

2:46 PM Changeset in webkit [86792] by beidson@apple.com

• 5 edits
  2 adds in trunk/Source/WebKit2

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

If the WebProcess or PluginProcess forks, it shouldn't pass WebKit2 shims along to the new process
in the DYLD_INSERT_LIBRARIES environment variable.

Add Environment Utilities helper to strip unwanted values from an environment variable:

• Platform/unix/EnvironmentUtilities.cpp: Added.

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):

• Platform/unix/EnvironmentUtilities.h: Added.
• WebKit2.xcodeproj/project.pbxproj:

Strip PluginProcessShim.dylib from DYLD_INSERT_LIBRARIES:

• PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

Strip WebProcessShim.dylib from DYLD_INSERT_LIBRARIES:

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Unprotect SnowLeopard now that it will behave and not spawn processes trying to use WebKit2 shims:

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

2:40 PM Changeset in webkit [86791] by rwlbuis@webkit.org

• 4 edits
  6 adds in trunk

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Change <marker> renderer creation behaviour to always create the renderer. This fixes
the problem that no marker is rendered when display=none is set on the <marker>. The
specification states that display=none should have no influence on <marker> usage:
"The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
elements are available for referencing even when the ‘display’ property on the ‘marker’
element or any of its ancestors is set to none."

Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg

svg/custom/painting-marker-07-f-inherit.svg

• svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::rendererIsNeeded):

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

• platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
• platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
• platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
• svg/custom/painting-marker-07-f-inherit.svg: Added.

2:26 PM Changeset in webkit [86790] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

2011-05-18 Alexis Menard <​alexis.menard@openbossa.org>, Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=60760

This test creates an hidden video element and make sure the loading works.

• http/tests/media/media-can-load-when-hidden-expected.txt: Added.
• http/tests/media/media-can-load-when-hidden.html: Added.

2011-05-18 Alexis Menard <​alexis.menard@openbossa.org>, Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=60760

WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
that uses the ResourceHandle API to request data and pass it down. For
our builds it is absolutely essential that we have a NetworkingContext
available there, in order to get access to the QNetworkAccessManager.
No access means we basically cannot load the video. The WebSource gains
access to the NetworkingContext through a WebCore::Frame pointer it has.

MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
the WebCore::Frame to the WebKitWebSource in
mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
frameView() accessor to access the frame. However the frameView() member
is only set through the render tree's RenderVideo, which is rather unreliable
given that some sites create "fake" video tags initially that only become
visible later (or never).

A more reliable way is to simply use the document of the MediaPlayerClient,
which is provided at constructor time.

Test: http/tests/media/media-can-load-when-hidden.html

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

2:23 PM Changeset in webkit [86789] by jschuh@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Fixing previous Chromium tests expectations update for details element.

• platform/chromium/test_expectations.txt:

2:16 PM Changeset in webkit [86788] by enne@google.com

• 2 edits in trunk/Source/WebCore

2011-05-18 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Check HUD texture reserve status before using texture
​https://bugs.webkit.org/show_bug.cgi?id=61082

This only changes behavior behind a flag, so shouldn't impact any tests.

• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2:04 PM Changeset in webkit [86787] by abarth@webkit.org

• 2 edits
  15 deletes in trunk/Source/JavaScriptCore

2011-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Delete WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=61084

It's been a year and we've failed to complete this project. It's time
to throw in the towel.

• JavaScriptCore.xcodeproj/project.pbxproj:
• wtf/url: Removed.
• wtf/url/api: Removed.
• wtf/url/api/ParsedURL.cpp: Removed.
• wtf/url/api/ParsedURL.h: Removed.
• wtf/url/api/URLString.h: Removed.
• wtf/url/src: Removed.
• wtf/url/src/RawURLBuffer.h: Removed.
• wtf/url/src/URLBuffer.h: Removed.
• wtf/url/src/URLCharacterTypes.cpp: Removed.
• wtf/url/src/URLCharacterTypes.h: Removed.
• wtf/url/src/URLComponent.h: Removed.
• wtf/url/src/URLEscape.cpp: Removed.
• wtf/url/src/URLEscape.h: Removed.
• wtf/url/src/URLParser.h: Removed.
• wtf/url/src/URLQueryCanonicalizer.h: Removed.
• wtf/url/src/URLSegments.cpp: Removed.
• wtf/url/src/URLSegments.h: Removed.
• wtf/url/wtfurl.gyp: Removed.

1:51 PM Changeset in webkit [86786] by jschuh@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Another Chromium tests expectations update for details element.

• platform/chromium/test_expectations.txt:

1:41 PM Changeset in webkit [86785] by oliver@apple.com

• 16 edits in trunk/Source

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=61090

Remove the Structure-free JSGlobalObject constructor and instead always
pass the structure into the JSGlobalObject constructor.
Stop DebuggerActivation creating a new structure every time, and simply
use a single shared structure held by the GlobalData.

• API/JSContextRef.cpp:
• debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
• jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures):
• runtime/JSGlobalData.h:
• runtime/JSGlobalObject.h:

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=61090

Rather than having Constructor objects create their structure
as part of initialisation, we now pass their expected structure
in as an argument. This required fixing the few custom Constructors
and the code generator.

• bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
• bindings/js/JSAudioConstructor.h:
• bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Pass the Constructor objects structure in as an argument
• bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
• bindings/js/JSImageConstructor.h:
• bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
• bindings/js/JSOptionConstructor.h:
• bindings/scripts/CodeGeneratorJS.pm:

1:09 PM Changeset in webkit [86784] by jschuh@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium tests expectations update for details element.

• platform/chromium/test_expectations.txt:

12:54 PM Changeset in webkit [86783] by jonlee@apple.com

• 2 edits in trunk/Source/WebKit2

2011-05-18 Jon Lee <​jonlee@apple.com>

Reviewed by Simon Fraser.

Crash in injected bundle client
​https://bugs.webkit.org/show_bug.cgi?id=61086

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection): Check for existence of method in client prior to calling.

12:35 PM Changeset in webkit [86782] by arv@chromium.org

• 3 edits in trunk/LayoutTests

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Expand layout test for testing the coords of a click on a label element
​https://bugs.webkit.org/show_bug.cgi?id=61080

This expands the existing test to click on a label inside a scrolled element.

• fast/events/simulated-click-coords-expected.txt:
• fast/events/simulated-click-coords.html:

12:30 PM Changeset in webkit [86781] by inferno@chromium.org

• 3 edits
  2 adds in trunk

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Beth Dakin.

Tests that we do not crash when prematurely calling removeChild,
followed by destroy call on table caption.
​https://bugs.webkit.org/show_bug.cgi?id=61083

• fast/table/table-captions-child-visible-crash-expected.txt: Added.
• fast/table/table-captions-child-visible-crash.html: Added.

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Beth Dakin.

Remove removeChild on table caption since destroy call
already does that.
​https://bugs.webkit.org/show_bug.cgi?id=61083

Test: fast/table/table-captions-child-visible-crash.html

• rendering/RenderTable.cpp: (WebCore::RenderTable::recalcCaption):

11:42 AM Changeset in webkit [86780] by evan@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-18 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make action_derivedsourcesallinone.py quiet
​https://bugs.webkit.org/show_bug.cgi?id=61081

In gyp, it's the responsibility of the build system to print what actions are doing;
for example, the compile command is generally silent, while the build system prints
"compiling".

Make this program behave like a compiler: silent on success.

• WebCore.gyp/scripts/action_derivedsourcesallinone.py: delete a print statement.

11:28 AM Changeset in webkit [86779] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam Roben.

Disable gc validation in release builds
​https://bugs.webkit.org/show_bug.cgi?id=60680

Add back the NDEBUG check

• wtf/Platform.h:

11:20 AM Changeset in webkit [86778] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()

Reviewed by Joseph Pecoraro.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Use
toHTTPPipeliningPriority() to convert arguments passed to
wkSetHTTPPipeliningMaximumPriority() and
wkSetHTTPPipeliningMinimumFastLanePriority().

11:15 AM Changeset in webkit [86777] by commit-queue@webkit.org

• 3 edits
  6 deletes in trunk/LayoutTests

2011-05-18 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

editing/style/apply-through-end-of-document.html is supposed to be dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=61077

• editing/style/apply-through-end-of-document-expected.txt:
• editing/style/apply-through-end-of-document.html:
• platform/chromium-linux/editing/style/apply-through-end-of-document-expected.png: Removed.
• platform/chromium-win/editing/style/apply-through-end-of-document-expected.png: Removed.
• platform/chromium-win/editing/style/apply-through-end-of-document-expected.txt: Removed.
• platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Removed.
• platform/mac-leopard/editing/style/apply-through-end-of-document-expected.png: Removed.
• platform/mac/editing/style/apply-through-end-of-document-expected.png: Removed.

11:00 AM How to not mess up GC created by oliver@apple.com

work in progress

10:47 AM Changeset in webkit [86776] by arv@chromium.org

• 3 edits
  2 adds in trunk

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This tests that clicking on a label for an input generates a click event on the input
with the same coordinates as the original click.

• fast/events/simulated-click-coords-expected.txt: Added.
• fast/events/simulated-click-coords.html: Added.

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
is a mouse event.

This makes us match Firefox and IE.

Test: fast/events/simulated-click-coords.html

• dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

10:33 AM Changeset in webkit [86775] by Nikolas Zimmermann

• 2 edits in trunk/Source/WebCore

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Sorted XCode project file.

• WebCore.xcodeproj/project.pbxproj:

10:19 AM WikiStart edited by oliver@apple.com

(diff)

10:19 AM WikiStart edited by oliver@apple.com

(diff)

10:15 AM Changeset in webkit [86774] by apavlov@chromium.org

• 3 edits in trunk/Source/WebCore

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Non-color CSS property values can get a color-picker
​https://bugs.webkit.org/show_bug.cgi?id=61056

• inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty): (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

10:01 AM Changeset in webkit [86773] by apavlov@chromium.org

• 3 edits
  2 copies in branches/chromium/742

Merge 86768 - 2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

• inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
• inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

• inspector/InjectedScriptSource.js:
• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7034027

9:58 AM WikiStart edited by oliver@apple.com

(diff)

9:43 AM QtWebKit edited by Ademar Reis

(diff)

9:43 AM QtWebKit edited by Ademar Reis

(diff)

9:42 AM QtWebKit edited by Ademar Reis

(diff)

9:40 AM QtWebKitFeaturePlanning edited by Ademar Reis

(diff)

9:12 AM Changeset in webkit [86772] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

2011-05-18 Pratik Solanki <​psolanki@apple.com>

Reviewed by Dan Bernstein.

Don't use DEFINE_STATIC_LOCAL with an unsigned
​https://bugs.webkit.org/show_bug.cgi?id=61026

• storage/StorageTracker.cpp: (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here.

9:08 AM Changeset in webkit [86771] by rwlbuis@webkit.org

• 3 edits
  8 adds in trunk

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
​https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

• css/CSSStyleSelector.cpp: (WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard): (WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard): (WebCore::isAcceptableForSVGElement): (WebCore::CSSStyleSelector::applyProperty):

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
​https://bugs.webkit.org/show_bug.cgi?id=45561

• svg/custom/display-table-caption-foreignObject-expected.txt: Added.
• svg/custom/display-table-caption-foreignObject.svg: Added.
• svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Added.
• svg/custom/display-table-caption-inherit-foreignObject.xhtml: Added.
• svg/custom/display-table-caption-inherit-text-expected.txt: Added.
• svg/custom/display-table-caption-inherit-text.xhtml: Added.
• svg/custom/display-table-caption-text-expected.txt: Added.
• svg/custom/display-table-caption-text.svg: Added.

9:02 AM Changeset in webkit [86770] by Adam Roben

• 2 edits in trunk/LayoutTests

Skip a new test that fails due to unimplemented WTR features

• platform/mac-wk2/Skipped: Added http/tests/loading/nested_bad_objects.php.

8:58 AM Changeset in webkit [86769] by Adam Roben

• 1 edit
  2 deletes in trunk/LayoutTests

Remove mac-wk2 expected failure results for a plugins test that I fixed in r86456

Fixes <​http://webkit.org/b/57456> <rdar://problem/9209331>
plugins/embed-prefers-plugins-for-images.html failing on SnowLeopard Intel Release (WebKit2
Tests)

• platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
• platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed. We don't

need this extra passing result now that mac-wk2's failing result is gone.

8:52 AM Changeset in webkit [86768] by pfeldman@chromium.org

• 5 edits
  2 adds in trunk

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

• inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
• inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

• inspector/InjectedScriptSource.js:
• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):

8:47 AM Changeset in webkit [86767] by andreas.kling@nokia.com

• 4 edits in trunk/Source/WebKit2

2011-05-18 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
​https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

• UIProcess/API/qt/qgraphicswkview.cpp:
• UIProcess/API/qt/qgraphicswkview.h:
• UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):

8:38 AM Changeset in webkit [86766] by Adam Roben

• 2 edits
  8 adds in trunk/Tools

Add a new page to build.webkit.org to help find when tests started failing

The page is accessible at <​http://build.webkit.org/TestFailures/>. It is pretty minimalist
right now, but already shows some useful information. It's somewhat similar to webkit-patch
failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
little more convenient than either of them, though, because it's all done in the browser
(and thus it's easy to go directly to the relevant test results).

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.

(Buildbot): This class represents a Buildbot server.
(Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Buildbot.prototype.builderNamed): Returns a Builder with the given name.
(Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
callback.
(Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
be implemented by a derived class that understands this server's build naming scheme.
(Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.

(Builder): This class represents one builder on the buildbot.
(Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
information about a particular test failure.
(Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
information about when tests started failing.
(Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
(Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
callback.
(Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
extracts all the failing tests listed in it, passing them to the callback.
(Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
build, merges them into the build history, and calls the callback telling it whether the
next build should be fetched to provide more information.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Added. Just some simple styles.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.

(createDefinitionList): Takes an array of pairs and turns them into a DL element.
(getResource): Wrapper around XMLHttpRequest.
(Array.prototype.findFirst): Finds the first element matching the given predicate and
returns it.
(Array.prototype.last): Returns the last element of the array.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.

(ViewController): This class contains the main logic for displaying the page.
(ViewController.loaded): Just calls through to parseHash.
(ViewController.parseHash): Either starts analyzing failures on a particular builder, or
shows the list of all testers so one can be chosen. This function is called when the page
loads and whenever we get a hashchange event.
(ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
as it is fetched. The display ends up grouping tests by when they started failing.
(ViewController._displayTesters): Gets the list of testers and displays it.

(ViewController._domForBuildName):
(ViewController._domForFailedTest):
Helper functions to create descriptions and links for a particular build or failed test.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.

(WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
(WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just

loads all the files and sets up a ViewController, which does the rest.

• BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new

page.

8:35 AM Changeset in webkit [86765] by Nikolas Zimmermann

• 75 edits
  49 adds in trunk

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
​https://bugs.webkit.org/show_bug.cgi?id=10749

Add tests for all elements using SVGAnimatedEnumeration in the SVG DOM API.

• platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Update result, progression.
• svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt: Added.
• svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html: Added.
• svg/dom/SVGAnimatedEnumeration-expected.txt:
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGClipPathElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEColorMatrixElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js: Added.
• svg/dom/script-tests/SVGAnimatedEnumeration.js:
• svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt:
• svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: (executeTest):
• svg/filters/feBlend-invalid-mode-expected.txt:
• svg/filters/feComponentTransfer-style-crash-expected.txt:
• svg/filters/feComponentTransfer-style-crash.xhtml:
• svg/filters/feDisplacementMap-crash-test-expected.txt:
• svg/filters/feDisplacementMap-crash-test.xhtml:

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
​https://bugs.webkit.org/show_bug.cgi?id=10749

DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
(Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)

Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
Use the new SVGPropertyTraits everywhere in svg/.

This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
Example: <clipPath clipPathUnits="objectBoundingBox">
myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
We're now properly converting the enum values to strings.

Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:

• SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
• SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.

Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html

svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html

Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.

• GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
• platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
• platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
• platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Ditto.
• rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now. (WebCore::RenderSVGResourceClipper::clipPathUnits):
• rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now. (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits):
• rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform). (WebCore::RenderSVGResourceGradient::applyResource):
• rendering/svg/RenderSVGResourceGradient.h: Ditto.
• rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
• rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now. (WebCore::RenderSVGResourceMarker::markerUnits):
• rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now. (WebCore::RenderSVGResourceMasker::maskUnits): (WebCore::RenderSVGResourceMasker::maskContentUnits):
• rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
• rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication. (WebCore::writeCommonGradientProperties):
• rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto. (WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
• svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType. (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
• svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
• svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
• svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.

Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.

• svg/SVGAnimatedInteger.idl: Ditto.
• svg/SVGAnimatedNumber.idl: Ditto.
• svg/SVGAnimatedString.idl: Ditto.
• svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
• svg/SVGClipPathElement.h:
• svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec. (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.

It's not possible anymore for these values to go out of range.

• svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()). (WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEBlendElement::build): Ditto.
• svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
• svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()). (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.. (WebCore::SVGFEColorMatrixElement::build): Ditto.
• svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
• svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()). (WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFECompositeElement::build): Ditto.
• svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
• svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()). (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync. (WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
• svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()). (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now. (WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
• svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()). (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEMorphologyElement::build): Ditto.
• svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
• svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()). (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFETurbulenceElement::build): Ditto.
• svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
• svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
• svg/SVGFilterElement.h:
• svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec. (WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
• svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
• svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special

as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.

(WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.

• svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations. (WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'. (WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto. (WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
• svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
• svg/SVGMaskElement.h:
• svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
• svg/SVGPatternElement.h:
• svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
• svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
• svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
• svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
• svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
• svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
• svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.

SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
the enums go out of range anymore (which lead to security bugs in the past).

(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

• svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param. (WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):

8:31 AM Changeset in webkit [86764] by kinuko@chromium.org

• 17 edits
  4 adds in trunk

2011-05-18 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59681

• platform/chromium/test_expectations.txt:
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• storage/script-tests/storageinfo-request-quota.js: Added.
• storage/storageinfo-request-quota-expected.txt: Added.
• storage/storageinfo-request-quota.html: Added.

2011-05-18 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59681

Test: storage/storageinfo-request-quota.html

• CMakeLists.txt:
• CodeGenerators.pri:
• DerivedSources.cpp:
• DerivedSources.make:
• GNUmakefile.am:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• storage/StorageInfo.idl: Added requestQuota().
• storage/StorageInfoQuotaCallback.idl: Added.

8:20 AM Changeset in webkit [86763] by reni@webkit.org

• 3 edits in trunk/Source/WebCore

2011-05-18 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FEGaussianBlur
​https://bugs.webkit.org/show_bug.cgi?id=61049

The Gaussian blur filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is about 15% on dual-core machines.

Developed in cooperation with Gabor Loki and Zoltan Herczeg.

• platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply):
• platform/graphics/filters/FEGaussianBlur.h:

8:06 AM Changeset in webkit [86762] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt][WK2] Skip two failing tests.

• platform/qt-wk2/Skipped:

8:04 AM Changeset in webkit [86761] by andreas.kling@nokia.com

• 3 edits
  1 add in trunk/Source/WebKit2

2011-05-18 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Don't lie about supporting accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=61054

Until we have an implementation of LayerTreeHost, we shouldn't lie about it.

• WebKit2.pro:
• WebProcess/WebPage/LayerTreeHost.h:
• WebProcess/WebPage/qt/LayerTreeHostQt.cpp: Added. (WebKit::LayerTreeHost::supportsAcceleratedCompositing):

7:31 AM Changeset in webkit [86760] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make parentId for frame optional.
​https://bugs.webkit.org/show_bug.cgi?id=61032

• inspector/Inspector.json:
• inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame):
• inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFrame):

7:27 AM Changeset in webkit [86759] by loki@webkit.org

• 5 edits in trunk/Source/WebCore

2011-05-18 Gabor Loki <​loki@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FELighting
​https://bugs.webkit.org/show_bug.cgi?id=61048

The lighting filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 10-20% on dual-core machines.

Developed in cooperation with Zoltan Herczeg.

• platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericPaint): (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric):
• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker):
• platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):

7:12 AM Changeset in webkit [86758] by caio.oliveira@openbossa.org

• 2 edits in trunk/Source/WebCore

2011-05-18 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
​https://bugs.webkit.org/show_bug.cgi?id=60984

The code for converting objects to QVariantMap was causing exception,
that was "leaking" to the next evaluation. One situation was reading
the property 'localStorage' when we do not have a proper security
origin, which throws a SECURITY_ERR.

Now, we will simply not include on the QVariantMap those properties,
and make sure that we clean the exception if necessary.

• bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariantMap): Extracted function that performs conversion from JSObject to a QVariantMap. This functions makes sure that exception is clean after its execution.

(JSC::Bindings::convertValueToQVariant):
Use the previous function. Add a comment explaining the choice of distance value.

7:11 AM Changeset in webkit [86757] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: scripts panel file selector element doesn't track keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=61047

• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

7:01 AM QtWebKitRelease22 edited by Ademar Reis

(diff)

6:50 AM Changeset in webkit [86756] by podivilov@chromium.org

• 6 edits in trunk/Source/WebCore

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
​https://bugs.webkit.org/show_bug.cgi?id=60900

• bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
• bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
• inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
• inspector/InspectorDebuggerAgent.h:
• inspector/ScriptDebugListener.h: (WebCore::ScriptDebugListener::Script::Script):

6:42 AM Changeset in webkit [86755] by zoltan@webkit.org

• 2 edits in trunk/LayoutTests

Remove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html

• platform/mac-wk2/Skipped:

6:32 AM Changeset in webkit [86754] by apavlov@chromium.org

• 6 edits
  1 copy in trunk

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
​https://bugs.webkit.org/show_bug.cgi?id=60966

• inspector/styles/resources/styles-new-API-1.css:
• inspector/styles/resources/styles-new-API-2.css: Copied from LayoutTests/inspector/styles/resources/styles-new-API-1.css. (@page): (@page :first): (#absent-id): (@font-face): (body):
• inspector/styles/styles-new-API-expected.txt:

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
​https://bugs.webkit.org/show_bug.cgi?id=60966

Imported stylesheets didn't use to be returned by InspectorCSSAgent.

• inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets): (WebCore::InspectorCSSAgent::collectStyleSheets):
• inspector/InspectorCSSAgent.h:

5:56 AM Changeset in webkit [86753] by zoltan@webkit.org

• 2 edits in trunk/LayoutTests

Add fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
eventSender.keyDown is unimplemented.

Reviewed by Csaba Osztrogonác.

• platform/mac-wk2/Skipped:

5:04 AM Changeset in webkit [86752] by pfeldman@chromium.org

• 18 edits in trunk

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
​https://bugs.webkit.org/show_bug.cgi?id=61028

• inspector/InjectedScriptSource.js:
• inspector/Inspector.json:
• inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
• inspector/InspectorConsoleAgent.h:
• inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
• inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
• inspector/InspectorInstrumentation.h:
• inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
• inspector/ScriptDebugListener.h:
• inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
• inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
• inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
• inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):

4:33 AM Changeset in webkit [86751] by commit-queue@webkit.org

• 17 edits in trunk/Source/WebCore

2011-05-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86747.
​http://trac.webkit.org/changeset/86747
​https://bugs.webkit.org/show_bug.cgi?id=61039

Breaks JSC debugger tests. (Requested by pfeldman on #webkit).

• inspector/InjectedScriptSource.js: ():
• inspector/Inspector.json:
• inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
• inspector/InspectorConsoleAgent.h:
• inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
• inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
• inspector/InspectorInstrumentation.h:
• inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
• inspector/ScriptDebugListener.h:
• inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
• inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
• inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
• inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):

4:03 AM Changeset in webkit [86750] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-18 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Removed duplcate entries added by r86749

• platform/chromium/test_expectations.txt:

3:49 AM Changeset in webkit [86749] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-18 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Since Chromium r85744, tests for <details> element pass on Mac and TEXT mismatch on Linux.

• platform/chromium/test_expectations.txt:

3:45 AM Changeset in webkit [86748] by inferno@chromium.org

• 3 edits
  2 adds in trunk

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

Tests that we do not crash when trying to access a removed
smil element in animated elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

• svg/animations/smil-element-not-removed-crash-expected.txt: Added.
• svg/animations/smil-element-not-removed-crash.html: Added.

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

Test: svg/animations/smil-element-not-removed-crash.html

• svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::~SVGSMILElement):

2:48 AM Changeset in webkit [86747] by pfeldman@chromium.org

• 17 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
​https://bugs.webkit.org/show_bug.cgi?id=61028

• inspector/InjectedScriptSource.js:
• inspector/Inspector.json:
• inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
• inspector/InspectorConsoleAgent.h:
• inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
• inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
• inspector/InspectorInstrumentation.h:
• inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
• inspector/ScriptDebugListener.h:
• inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
• inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
• inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
• inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):

2:46 AM Changeset in webkit [86746] by mnaganov@chromium.org

• 4 edits in trunk/Source

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
​https://bugs.webkit.org/show_bug.cgi?id=60286

• inspector/front-end/ProfilesPanel.js:

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
​https://bugs.webkit.org/show_bug.cgi?id=60286

• src/js/DevTools.js: ():

2:45 AM Changeset in webkit [86745] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
​https://bugs.webkit.org/show_bug.cgi?id=60971

• inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showAnchorLocation.): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
• inspector/front-end/inspector.js: (WebInspector._showAnchorLocation):

2:33 AM Changeset in webkit [86744] by tkent@chromium.org

• 6 edits in trunk

2011-05-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
​https://bugs.webkit.org/show_bug.cgi?id=61021

Add test cases for the bug.

• fast/forms/ValidityState-valueMissing-002-expected.txt:
• fast/forms/ValidityState-valueMissing-002.html:

2011-05-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
​https://bugs.webkit.org/show_bug.cgi?id=61021

We missed updating validity in case that SelectElement::defaultEventHandler
update selections. So, SelectElement::setSelectedIndex() updates validity.

• dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Remove unnecessary setNeedsValidityCheck() call. SelectElement::setSlectedIndex() calls it. (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.

2:31 AM Changeset in webkit [86743] by mnaganov@chromium.org

• 3 edits in trunk/Source/WebCore

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Make retaining paths list of the Detailed
heap snapshots view resizable.
​https://bugs.webkit.org/show_bug.cgi?id=60960

• inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.resize): (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
• inspector/front-end/heapProfiler.css:

2:10 AM Changeset in webkit [86742] by commit-queue@webkit.org

• 8 edits in trunk

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

• platform/qt/Skipped: Unskip fast/forms/onchange-setvalueforuser.html

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

• WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setValueForUser):
• WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

• DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser):
• DumpRenderTree/qt/LayoutTestControllerQt.h:

12:38 AM Changeset in webkit [86741] by jer.noble@apple.com

• 5 edits
  4 adds in trunk

2011-05-16 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60943

• fullscreen/full-screen-keyboard-disabled-expected.txt: Added.
• fullscreen/full-screen-keyboard-disabled.html: Added.
• fullscreen/full-screen-keyboard-enabled-expected.txt: Added.
• fullscreen/full-screen-keyboard-enabled.html: Added.

2011-05-16 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60943

Tests: fullscreen/full-screen-keyboard-disabled.html

fullscreen/full-screen-keyboard-enabled.html

• page/EventHandler.cpp: (WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added. Implements the

list of allowed keyboard events in the proposed API.

(WebCore::EventHandler::keyEvent): Discard events which are not allowed in

full-screen mode.

• page/EventHandler.h:

12:34 AM Changeset in webkit [86740] by gyuyoung.kim@samsung.com

• 2 edits in trunk

2011-05-18 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix build break.

• Source/cmake/WebKitMacros.cmake: Add -i option in order to include Lookup.h

12:19 AM Changeset in webkit [86739] by Nikolas Zimmermann

• 11 edits in trunk/Source/WebCore

-2011-05-17 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor TextRun creation
​https://bugs.webkit.org/show_bug.cgi?id=60255

Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
the catch-it-all constructor, these helper functions are introduced, which hide the details of
creating a TextRun.

Furthermore it will be used to remove the platform layering violation, that TextRun stores
RenderObject pointers for the sake of SVG Fonts support, see bug 60254.

No change in functionaliy, no new tests.

• rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
• rendering/InlineTextBox.h:
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
• rendering/RenderBlock.h:
• rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
• rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):

May 17, 2011:

11:16 PM Changeset in webkit [86738] by jer.noble@apple.com

• 4 edits in trunk/Source/WebKit2

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
​https://bugs.webkit.org/show_bug.cgi?id=60982

The GraphicsLayer tree has unparented m_fullScreenRootLayer behind our backs, replacing the
tiled layer with a normal one. Instead of holding on to a specific layer, assume that the
w_rootLayer will only have 0 or 1 children, and if a child is present, then that is our full-
screen layer.

Additionally, check to see if the animating layer's presentationLayer is nil
before calling it; asking a nil object for a CATransform3D will give back a struct full of
garbage.

In WKFullScreenWindowController, when the exit animation completes, ignore the "completed"
parameter. This eliminates the possibility that the full screen window will end up left
on top of the screen if the animation is cancelled and a enter full screen animation isn't
forthcoming.

• UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
• WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
• WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

11:12 PM Changeset in webkit [86737] by jer.noble@apple.com

• 9 edits in trunk

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60997

Updated the following tests with the new expectation that removing an element from the DOM will trigger
full screen mode to exit.

• fullscreen/full-screen-remove-ancestor-expected.txt:
• fullscreen/full-screen-remove-ancestor.html:
• fullscreen/full-screen-remove-children-expected.txt:
• fullscreen/full-screen-remove-children.html:
• fullscreen/full-screen-remove-expected.txt:
• fullscreen/full-screen-remove.html:

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60997

Tests: fullscreen/full-screen-remove-ancestor.html

fullscreen/full-screen-remove-children.html
fullscreen/full-screen-remove.html

• dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document

make sure to message the documentElement() as well.

(WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.

10:50 PM Changeset in webkit [86736] by Csaba Osztrogonác

• 4 edits in trunk/LayoutTests

[Qt] Skip failing tests on minor Qt platforms.

• platform/qt-arm/Skipped:
• platform/qt-mac/Skipped:
• platform/qt-wk2/Skipped:

10:22 PM Changeset in webkit [86735] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests now pass:
fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html

• platform/chromium/test_expectations.txt:

9:43 PM Changeset in webkit [86734] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=61022

Reviewed by Alice Liu.

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.

8:56 PM Changeset in webkit [86733] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.

• platform/chromium/test_expectations.txt:

8:50 PM Changeset in webkit [86732] by yutak@chromium.org

• 16 edits in trunk

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
​https://bugs.webkit.org/show_bug.cgi?id=60878

The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
expected results of tests that dump WebSocket.readyState.

• fast/dom/Window/window-properties-expected.txt:
• http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
• http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
• http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
• http/tests/websocket/tests/handshake-error-expected.txt:
• http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js: (ws.onclose):
• http/tests/websocket/tests/script-tests/handshake-error.js: (ws.onclose):
• http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
• http/tests/websocket/tests/send-after-close-on-unload.html:
• http/tests/websocket/tests/simple-expected.txt:
• platform/qt/fast/dom/Window/window-properties-expected.txt:

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
​https://bugs.webkit.org/show_bug.cgi?id=60878

No new tests are added because there is no change in functionality.

• platform/network/SocketStreamHandleBase.h:
• websockets/WebSocket.h:
• websockets/WebSocket.idl:

8:47 PM Changeset in webkit [86731] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/invalidate_rect.html now passes on Linux.

• platform/chromium/test_expectations.txt:

8:23 PM Changeset in webkit [86730] by ggaren@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.

• runtime/BooleanPrototype.cpp:
• runtime/DateConstructor.cpp:
• runtime/ErrorPrototype.cpp:

8:07 PM Changeset in webkit [86729] by ggaren@apple.com

• 3 edits in trunk/Source/JavaScriptCore

More attempts to work around the EFL build system being borken.

• runtime/DateConstructor.cpp:
• runtime/ErrorPrototype.cpp:

8:03 PM Changeset in webkit [86728] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Try to fix the EFL build.

• runtime/BooleanPrototype.cpp:

7:39 PM Changeset in webkit [86727] by ggaren@apple.com

• 47 edits in trunk

Source/JavaScriptCore: Rolling back in r86653 with build fixed.

Reviewed by Gavin Barraclough and Oliver Hunt.

Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933

Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.

This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

• DerivedSources.make:
• JavaScriptCore.exp: Build!

• create_hash_table: Added a special case for fromCharCode, since it uses

a custom "thunk generator".

• heap/Heap.cpp:

(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.

• interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.

• runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

• runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

• runtime/ArrayPrototype.h:
• runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

• runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

• runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

• runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

• runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

• runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

• runtime/JSGlobalData.h: Added new tables.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

• runtime/JSGlobalObject.h:
• runtime/JSGlobalObjectFunctions.cpp:
• runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a

static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.

Even more global object properties can be made lazy, but that requires
more in-depth changes.

• runtime/MathObject.cpp:
• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

• runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

• runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

• runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

• runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

• runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

• runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

• runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

• runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.

LayoutTests: Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933

Reviewed by Gavin Barraclough.

Added a few more expected failures, now that more code uses static hash
tables.

The fact that built-ins are not deletable, but should be, is covered by
​https://bugs.webkit.org/show_bug.cgi?id=61014

• sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:

6:48 PM Changeset in webkit [86726] by morrita@google.com

• 12 edits
  3 copies
  1 move in trunk/Source/WebCore

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] ShadowContentElement should be part of dom/
​https://bugs.webkit.org/show_bug.cgi?id=59117

• Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
• Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
• Added ShadowContentElement.cpp
• Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}

No new tests, no behavior change.

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
• dom/Node.h: (WebCore::Node::forceReattach): Moved from static local function to share between classes.
• dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::attach):
• dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::isShadowBoundary): (WebCore::ShadowContentElement::rendererIsNeeded): (WebCore::ShadowContentElement::createRenderer):
• dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor):
• dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance):
• dom/ShadowRoot.cpp: (WebCore::ShadowRoot::recalcStyle):
• html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsSummaryElement::DetailsSummaryElement):
• html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement):

5:53 PM Changeset in webkit [86725] by cdn@chromium.org

• 3 edits
  2 adds in trunk

2011-05-17 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
​https://bugs.webkit.org/show_bug.cgi?id=61005

Test: http/tests/loading/nested_bad_objects.php

• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2011-05-17 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when two nested image objects with invalid data are loaded.
​https://bugs.webkit.org/show_bug.cgi?id=61005

• http/tests/loading/nested_bad_objects-expected.txt: Added.
• http/tests/loading/nested_bad_objects.php: Added.

5:29 PM Changeset in webkit [86724] by beidson@apple.com

• 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.

Rubberstamped by Sam Weinig.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put

SnowLeopard build guards around the shim install path.

5:21 PM Changeset in webkit [86723] by abarth@webkit.org

• 1 edit
  1 delete in trunk/LayoutTests

2011-05-17 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Simon Fraser.

Remove empty directory.

• fast/inspector: Removed.

5:12 PM Changeset in webkit [86722] by crogers@google.com

• 2 edits in trunk/Source/WebCore

2011-05-17 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
​https://bugs.webkit.org/show_bug.cgi?id=60995

No new tests since audio API is not yet implemented.

• webaudio/AudioNode.cpp: (WebCore::AudioNode::ref):

5:08 PM Changeset in webkit [86721] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit/chromium

2011-05-17 Tao Bai <​michaelbai@chromium.org>

Reviewed by Darin Fisher.

Clear deprecated icon APIs from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=60989

• public/WebFrame.h: Removed faviconURL()
• public/WebFrameClient.h: Removed didChangeIcons()
• src/FrameLoaderClientImpl.cpp:

Removed the code to support deprecated API

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

• src/WebFrameImpl.cpp: Removed faviconURL()
• src/WebFrameImpl.h: Removed faviconURL()

4:42 PM Changeset in webkit [86720] by beidson@apple.com

• 9 edits in trunk/Source/WebCore

2011-05-17 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/9366728> and ​https://webkit.org/b/60796
Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]

Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
This change has the following benefits:

• Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect themselves, check these variables as often, or ASSERT them.
• ResourceLoader subclasses no longer have to call the base class ::didCancel
• ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the cancellation is completed inside the last call.

No new tests - No change in behavior for previous tests, and new test would require API usage outside
the scope of DumpRenderTree.

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
• loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().

Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:

• loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willCancel): (WebCore::MainResourceLoader::didCancel):
• loader/MainResourceLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

• loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel() (WebCore::NetscapePlugInStreamLoader::willCancel): (WebCore::NetscapePlugInStreamLoader::didCancel):
• loader/NetscapePlugInStreamLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willCancel): (WebCore::SubresourceLoader::didCancel):
• loader/SubresourceLoader.h:

4:39 PM Changeset in webkit [86719] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86668.
​http://trac.webkit.org/changeset/86668
​https://bugs.webkit.org/show_bug.cgi?id=61001

It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
#webkit).

• UIProcess/API/qt/qgraphicswkview.cpp:
• UIProcess/API/qt/qgraphicswkview.h:
• UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):

4:21 PM Changeset in webkit [86718] by bweinstein@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix after r86717.

• UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget

4:15 PM Changeset in webkit [86717] by bweinstein@apple.com

• 5 edits in trunk/Source/WebKit2

WebKit2: Needs API to set a custom drop target
​https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/9090868>

Reviewed by Adam Roben.

Add API to set a custom drop target on a WKView.

• UIProcess/API/C/win/WKView.cpp:

(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.

• UIProcess/API/C/win/WKView.h:
• UIProcess/win/WebView.cpp:

(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the

custom one.

• UIProcess/win/WebView.h:

4:10 PM Changeset in webkit [86716] by rniwa@webkit.org

• 3 edits
  2 adds
  19 deletes in trunk/LayoutTests

2011-05-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=60998

Converted the tests.

• editing/pasteboard/paste-blockquote-2-expected.txt: Added.
• editing/pasteboard/paste-blockquote-2.html:
• editing/pasteboard/paste-blockquote-3-expected.txt: Added.
• editing/pasteboard/paste-blockquote-3.html:
• platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
• platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
• platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
• platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
• platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
• platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
• platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
• platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.

4:03 PM Changeset in webkit [86715] by rniwa@webkit.org

• 3 edits
  1 add
  9 deletes in trunk/LayoutTests

2011-05-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-text-012.html should be a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=60996

Converted the test.

• editing/pasteboard/paste-text-012-expected.txt: Added.
• editing/pasteboard/paste-text-012.html:
• platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
• platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
• platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
• platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.

3:49 PM Changeset in webkit [86714] by weinig@apple.com

• 5 edits in trunk/Source/WebKit2

2011-05-17 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Add API to determine if a frame has any form elements without going to javascript
​https://bugs.webkit.org/show_bug.cgi?id=60999

• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameContainsAnyFormElements):
• WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
• WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::containsAnyFormElements):
• WebProcess/WebPage/WebFrame.h: Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine if there are any form elements.

3:34 PM Changeset in webkit [86713] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Always set layerRenderer, even on non-drawn-layers
​https://bugs.webkit.org/show_bug.cgi?id=60977

This is a defensive fixe for crbug.com/82799, in which
a RenderLayer could not prepare itself because its owning layerImpl
had no associated layerRenderer. The underlying issue is that we
sometimes put renderSurfaces onto the list that won't actually render.
For now, the priority is to reduce fragility so that invisible layers
dont lead to crashers. We do this by being more agressive about
binding CCLayerImpls to the LayerRenderer, doing it all the time rather
than only when we think it will get rendered.

• platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents):

3:32 PM Changeset in webkit [86712] by weinig@apple.com

• 2 edits in trunk/Source/JavaScriptCore

2011-05-17 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

JSGlobalContextRelease should not trigger a synchronous garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=60990

• API/JSContextRef.cpp: Change synchronous call to collectAllGarbage to a call to trigger the activityCallback.

3:31 PM Changeset in webkit [86711] by cdn@chromium.org

• 1 edit in branches/chromium/742/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 86219 - 2011-05-10 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
​https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().

BUG=82154
Review URL: ​http://codereview.chromium.org/7039019

3:07 PM Changeset in webkit [86710] by dcheng@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

2011-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Clipboard policy callbacks from EditorClientImpl are reversed
​https://bugs.webkit.org/show_bug.cgi?id=60994

• src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):

3:00 PM Changeset in webkit [86709] by robert@webkit.org

• 2 edits in trunk/LayoutTests

2011-05-17 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

Skip on qt-mac

​http://bugs.webkit.org/show_bug.cgi?id=60838

• platform/qt-mac/Skipped:

2:45 PM Changeset in webkit [86708] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Fix the clang build.

• rendering/RenderText.h:

(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.

2:33 PM Changeset in webkit [86707] by arv@chromium.org

• 3 edits
  2 adds in trunk

2011-05-17 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
​https://bugs.webkit.org/show_bug.cgi?id=49509

This tests that an iframe is the activeElement when focus is inside that frame.

• fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
• fast/dom/HTMLDocument/active-element-frames.html: Added.

2011-05-17 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
​https://bugs.webkit.org/show_bug.cgi?id=49509

This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.

Test: fast/dom/HTMLDocument/active-element-frames.html

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.

1:57 PM Changeset in webkit [86706] by robert@webkit.org

• 11 edits in trunk

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

​https://bugs.webkit.org/show_bug.cgi?id=54051

• platform/qt/Skipped: Unskip plugins/invalidate_rect.html
• platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

Add ChromeClientQt::allowsAcceleratedCompositing().

​https://bugs.webkit.org/show_bug.cgi?id=54051

• WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
• WebCoreSupport/ChromeClientQt.h:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

• Make the unix test netscape plugin recognize the onPaintEvent and windowedPlugin parameters.

​https://bugs.webkit.org/show_bug.cgi?id=54051

• DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11):
• DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::displayInvalidatedRegion):
• DumpRenderTree/qt/LayoutTestControllerQt.h:
• DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event):

1:57 PM Changeset in webkit [86705] by eae@chromium.org

• 48 edits in trunk/Source/WebCore

2011-05-17 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Change nodeAtPoint to take IntPoint instead of int x, int y
​https://bugs.webkit.org/show_bug.cgi?id=60663

Change nodeAtPoint to take a single const IntPoint& instead of a pair of
ints for the location.

Covered by existing tests.

• platform/graphics/FloatPoint.h: (WebCore::flooredIntPoint):
• rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
• rendering/EllipsisBox.h:
• rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
• rendering/InlineBox.h:
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
• rendering/InlineTextBox.h:
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
• rendering/RenderBlock.h:
• rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
• rendering/RenderBox.h:
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
• rendering/RenderFrameSet.h:
• rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
• rendering/RenderImage.h:
• rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
• rendering/RenderInline.h:
• rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
• rendering/RenderListBox.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): (WebCore::RenderObject::nodeAtPoint):
• rendering/RenderObject.h:
• rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
• rendering/RenderTable.h:
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
• rendering/RenderTableRow.h:
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
• rendering/RenderTableSection.h:
• rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
• rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
• rendering/RenderTextControlMultiLine.h:
• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
• rendering/RenderTextControlSingleLine.h:
• rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
• rendering/RenderWidget.h:
• rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
• rendering/RootInlineBox.h:
• rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
• rendering/svg/RenderSVGForeignObject.h:
• rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
• rendering/svg/RenderSVGModelObject.h:
• rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): (WebCore::RenderSVGText::nodeAtPoint):
• rendering/svg/RenderSVGText.h:

1:39 PM Changeset in webkit [86704] by atwilson@chromium.org

• 14 edits in trunk/Source

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86647.
​http://trac.webkit.org/changeset/86647
​https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

• dom/DocumentMarker.h: (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
• dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
• dom/DocumentMarkerController.h:
• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
• editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
• editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
• editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
• rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86647.
​http://trac.webkit.org/changeset/86647
​https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):

1:38 PM Changeset in webkit [86703] by atwilson@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86656.
​http://trac.webkit.org/changeset/86656

Broke tests downstream in Chromium

• editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

1:30 PM Changeset in webkit [86702] by tony@chromium.org

• 2 edits
  25 adds in trunk/LayoutTests

2011-05-17 Tony Chang <​tony@chromium.org>

Land linux 32 bit results.

• platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
• platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
• platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt: Added.
• platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt: Added.
• platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Added.
• platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
• platform/chromium-linux-x86/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
• platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
• platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Added.
• platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt: Added.
• platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Added.
• platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt: Added.
• platform/chromium/test_expectations.txt:

1:26 PM Changeset in webkit [86701] by atwilson@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/test_expectations.txt:

1:20 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:04 PM Changeset in webkit [86700] by commit-queue@webkit.org

• 15 edits in trunk

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

• fast/events/touch/document-create-touch-expected.txt:
• fast/events/touch/script-tests/document-create-touch.js:

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

• dom/Document.cpp: (WebCore::Document::createTouch):
• dom/Document.h:
• dom/Document.idl:
• dom/Touch.cpp: (WebCore::Touch::Touch):
• dom/Touch.h: (WebCore::Touch::create): (WebCore::Touch::webkitRadiusX): (WebCore::Touch::webkitRadiusY): (WebCore::Touch::webkitRotationAngle):
• dom/Touch.idl:
• page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
• platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::radiusX): (WebCore::PlatformTouchPoint::radiusY): (WebCore::PlatformTouchPoint::rotationAngle):

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

• public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
• src/WebInputEventConversion.cpp: (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):

1:02 PM Changeset in webkit [86699] by oliver@apple.com

• 21 edits
  2 adds in trunk/Source

2011-05-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Reduce code size for inline cache
​https://bugs.webkit.org/show_bug.cgi?id=60942

This patch introduces the concept of a "compact" address that
allows individual architectures to control the maximum offset
used for the inline path of get_by_id. This reduces the code
size of get_by_id by 3 bytes on x86 and x86_64 and slightly
improves performance on v8 tests.

• assembler/ARMAssembler.h: (JSC::ARMAssembler::repatchCompact):
• assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::repatchCompact):
• assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::AbstractMacroAssembler::repatchCompact):
• assembler/CodeLocation.h: (JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact): (JSC::CodeLocationCommon::dataLabelCompactAtOffset):
• assembler/LinkBuffer.h: (JSC::LinkBuffer::locationOf):
• assembler/MIPSAssembler.h: (JSC::MIPSAssembler::repatchCompact):
• assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
• assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
• assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
• assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
• assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
• assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::repatchCompact):
• assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
• assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
• assembler/RepatchBuffer.h: (JSC::RepatchBuffer::repatch):
• assembler/SH4Assembler.h: (JSC::SH4Assembler::repatchCompact):
• assembler/X86Assembler.h: (JSC::X86Assembler::movl_mr_disp8): (JSC::X86Assembler::movq_mr_disp8): (JSC::X86Assembler::repatchCompact): (JSC::X86Assembler::setInt8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
• jit/JIT.h:
• jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
• jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
• jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID):

12:45 PM Changeset in webkit [86698] by eric@webkit.org

• 4 edits in trunk/Source/WebCore

2011-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add a LineLayoutState object to hold global state during line layout
​https://bugs.webkit.org/show_bug.cgi?id=60113

Like LayoutState for layout(), LineLayoutState keeps track of global information
during an entire linebox tree layout pass (aka layoutInlineChildren).

For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
It's possible we should hold the useRepaintBounds bool as well as
the startLine and endLine RootInlineBox pointers.

No change in behavior, thus no tests.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
• rendering/RenderBlock.h:
• rendering/RenderBlockLineLayout.cpp: (WebCore::LineLayoutState::LineLayoutState): (WebCore::LineLayoutState::markForFullLayout): (WebCore::LineLayoutState::isFullLayout): (WebCore::LineLayoutState::setRepaintRange): (WebCore::LineLayoutState::updateRepaintRangeFromBox): (WebCore::LineLayoutState::startLine): (WebCore::LineLayoutState::endLine): (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkFloatsInCleanLine): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine):

12:35 PM Changeset in webkit [86697] by caio.oliveira@openbossa.org

• 2 edits in trunk/Source/WebKit/qt

2011-05-17 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
​https://bugs.webkit.org/show_bug.cgi?id=60978

Backslash to escape newlines was confusing both prepare-ChangeLog and the
QtCreator highlight system.

• tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::evalJSV): Remove usage of backslash to escape newlines in string literal.

12:29 PM Changeset in webkit [86696] by tony@chromium.org

• 10 edits in trunk/Tools

2011-05-17 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=60895

Update the tools to handle the move. Lucid 32 results now go in
chromium-linux-x86 and the default platform on Linux is now x86_64.

• Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
• Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
• Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
• Scripts/webkitpy/layout_tests/port/base.py: ditto
• Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
• Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
• Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
• Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
• Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.

12:26 PM Changeset in webkit [86695] by andreas.kling@nokia.com

• 4 edits
  3 adds in trunk

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
​https://bugs.webkit.org/show_bug.cgi?id=54636

• fast/images/imagemap-dynamic-area-updates-expected.txt: Added.
• fast/images/imagemap-dynamic-area-updates.html: Added.
• fast/images/script-tests/imagemap-dynamic-area-updates.js: Added. (setArea): (checkForArea):

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
​https://bugs.webkit.org/show_bug.cgi?id=54636

Recompute the clickable region after the "shape" or "coords" attribute
of an area element is changed.

Test: fast/images/imagemap-dynamic-area-updates.html

• html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): (WebCore::HTMLAreaElement::invalidateCachedRegion):
• html/HTMLAreaElement.h:

12:00 PM Changeset in webkit [86694] by andreas.kling@nokia.com

• 7 edits in trunk/Source/WebKit2

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Initial support for favicons.
​https://bugs.webkit.org/show_bug.cgi?id=58937

Add the following API to QWKContext:

• void setIconDatabasePath(QString)
• void iconChangedForPageURL(QUrl) [signal]
• QIcon iconForPageURL(QUrl)

This is mostly analogous to the QWebSettings/QWebFrame icon API we had in WebKit1.

• UIProcess/API/qt/ClientImpl.h: Added WKIconDatabaseClient methods.

• UIProcess/API/qt/ClientImpl.cpp: (toQWKContext): Helper to cast from "void* clientInfo" to a QWKContext*. (qt_wk_didChangeIconForPageURL): Emits QWKContext::iconChangedForPageURL(QUrl). (qt_wk_didRemoveAllIcons): Stub.

• UIProcess/API/qt/qwkcontext.h:
• UIProcess/API/qt/qwkcontext_p.h:
• UIProcess/API/qt/qwkcontext.cpp: (QWKContextPrivate::QWKContextPrivate): Set up and register a WKIconDatabaseClient. (QWKContext::QWKContext): Minor refactor to avoid code duplication in constructors. (QWKContext::setIconDatabasePath): Exactly what it sounds like. (QWKContext::iconForPageURL): Retrieves the favicon for a given page URL as a QIcon.

• WebKit2API.pri: Add WKIconDatabase.cpp and WKIconDatabase.h to build.

12:00 PM Changeset in webkit [86693] by luiz@webkit.org

• 3 edits
  10 adds in trunk

[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
​https://bugs.webkit.org/show_bug.cgi?id=60440

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.

Tests: http/tests/navigation/post-301-response.html

http/tests/navigation/post-302-response.html
http/tests/navigation/post-303-response.html
http/tests/navigation/post-307-response.html

• platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendNetworkRequest):

LayoutTests:

These new tests check that no POST content is sent to the new URL after receiving http
status codes 301, 302 and 303, and checks that the POST content is sent to the new URL
after receiving a 307 http status code.

• http/tests/navigation/post-301-response-expected.txt: Added.
• http/tests/navigation/post-301-response.html: Added.
• http/tests/navigation/post-302-response-expected.txt: Added.
• http/tests/navigation/post-302-response.html: Added.
• http/tests/navigation/post-303-response-expected.txt: Added.
• http/tests/navigation/post-303-response.html: Added.
• http/tests/navigation/post-307-response-expected.txt: Added.
• http/tests/navigation/post-307-response.html: Added.
• http/tests/navigation/resources/redirected-post-request-contents.php: Added.
• http/tests/navigation/resources/redirection-response.php: Added.

11:57 AM Changeset in webkit [86692] by beidson@apple.com

• 8 edits
  1 add in trunk/Source/WebKit2

Part 4 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

This patch actually hooks up the shim to the WebProcess shim callbacks, which messages these
4 calls up to the UIProcess and returns the result.

Note that this patch uncovered the fact that CoreIPC can't sync message out from a secondary thread,
so I filed ​https://bugs.webkit.org/show_bug.cgi?id=60975 as a followup to allow that.

• Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::SecItemResponseData): Reorder the constructor arguments to be

a little cleaner.

• Shared/mac/SecItemResponseData.h:

Call the shim callbacks for each method:

• WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):

Implement the shim callbacks, which each marshall to the main thread, which then calls out to CoreIPC:

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatchingMainThread):
(WebKit::WebSecItemCopyMatching):
(WebKit::WebSecItemAddOnMainThread):
(WebKit::WebSecItemAdd):
(WebKit::WebSecItemUpdateOnMainThread):
(WebKit::WebSecItemUpdate):
(WebKit::WebSecItemDeleteOnMainThread):
(WebKit::WebSecItemDelete):

Add the 4 messages and their implementations in the UIProcess:

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• UIProcess/mac/WebProcessProxyMac.mm: Added.

(WebKit::WebProcessProxy::secItemCopyMatching):
(WebKit::WebProcessProxy::secItemAdd):
(WebKit::WebProcessProxy::secItemUpdate):
(WebKit::WebProcessProxy::secItemDelete):

• WebKit2.xcodeproj/project.pbxproj:

11:37 AM Changeset in webkit [86691] by andreas.kling@nokia.com

• 2 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] GraphicsLayerQtImpl: Remove an unused variable.

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::paint):

11:16 AM Changeset in webkit [86690] by kerz@chromium.org

• 9 edits in branches/chromium/742/Source

Merge 86290 - 2011-05-11 Antoine Labour <​piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
​https://bugs.webkit.org/show_bug.cgi?id=60656

• loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
• loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
• loader/ResourceLoadScheduler.h:

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader

• loader/SubresourceLoader.h:

• loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <​piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
​https://bugs.webkit.org/show_bug.cgi?id=60656

• src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7019016

11:08 AM Changeset in webkit [86689] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

2011-05-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Incomplete page painting at dropbox.com
​https://bugs.webkit.org/show_bug.cgi?id=60974
<rdar://problem/9448213>

When we're exiting compositing mode and haven't sent an EnterAcceleratedCompositingMode
message to the UI process, we still need to send the updated bits to the ui process.

• WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):

11:06 AM Changeset in webkit [86688] by beidson@apple.com

• 4 edits
  4 adds in trunk/Source/WebKit2

Part 3 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add CoreIPC stuff we'll need to marshall the SecItem calls to the UIProcess and back.

Teach ArgumentCodersCF about CFDateRef, SecKeychainItemRef, and generic CFTypeRefs:

• Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):

• Shared/cf/ArgumentCodersCF.h:

Serializable object that contains the query CFDictionaryRef and optionally the
"attributesToMatch" CFDictionaryRef:

• Shared/mac/SecItemRequestData.cpp: Added.

(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):

• Shared/mac/SecItemRequestData.h: Added.

(WebKit::SecItemRequestData::query):
(WebKit::SecItemRequestData::attributesToMatch):

Serializable object that returns an OSStatus and optionally a "result object" CFTypeRef:

• Shared/mac/SecItemResponseData.cpp: Added.

(WebKit::SecItemResponseData::SecItemResponseData):
(WebKit::SecItemResponseData::encode):
(WebKit::SecItemResponseData::decode):

• Shared/mac/SecItemResponseData.h: Added.

(WebKit::SecItemResponseData::resultObject):
(WebKit::SecItemResponseData::resultCode):

• WebKit2.xcodeproj/project.pbxproj:

10:49 AM Changeset in webkit [86687] by apavlov@chromium.org

• 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js

Merge 86683 - 2011-05-17 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
​https://bugs.webkit.org/show_bug.cgi?id=60970

• inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7037012

10:39 AM Changeset in webkit [86686] by beidson@apple.com

• 5 edits in trunk/Source/WebKit2

Part 2 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Hookup some of the methods we plan to shim in the patch, but just have them call through
to the actual implementations for now.

Also stub-out the future shimmed versions of the methods.

• WebProcess/mac/WebProcessShim.h: Add the methods to the shim callbacks.
• WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching): Call through to the actual function for now.
(WebKit::shimSecItemAdd): Ditto.
(WebKit::shimSecItemUpdate): Ditto.
(WebKit::shimSecItemDelete): Ditto.
(WebKit::WebKitWebProcessShimInitialize): Copy over the shim callbacks.

• WebKit2.xcodeproj/project.pbxproj: Link the shim to required frameworks.

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatching): Add placeholders for the future to-be-shimmed functions.
(WebKit::WebSecItemAdd): Ditto.
(WebKit::WebSecItemUpdate): Ditto.
(WebKit::WebSecItemDelete): Ditto.
(WebKit::WebProcess::initializeShim): Pass along those placeholders to the shim initializer.

10:38 AM Changeset in webkit [86685] by kerz@chromium.org

• 5 edits
  2 deletes in branches/chromium/742

Revert 84311 - REGRESSION(r55762): Highlight color can't be copied in gmail.
​https://bugs.webkit.org/show_bug.cgi?id=58925
<rdar://problem/9253057>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/pasteboard/copy-text-with-backgroundcolor.html

The changes of r55762 uncovered the underlying issue here. The markup fragment
placed in the pasteboard does not contain the background color style.
This occurs only if the selection is limited to a single text node, whereas if the
selection spans across multiple nodes, the style is preserved correctly.
The fix consists in changing the logic that decides whether we should include the wrapping
node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
on isElementPresentational to choose candidates to be the wrapping node.
I've extended it to accept nodes that have non fully transparent background colors.

• editing/Editor.cpp:

(WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.

• editing/Editor.h:
• editing/markup.cpp:

(WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.

LayoutTests:

The following test checks that when we copy a text node surrounded by an element that
has non transparent background color we preserve the background color as well.

• editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Added.
• editing/pasteboard/copy-text-with-backgroundcolor.html: Added.

TBR=​enrica@apple.com
Review URL: ​http://codereview.chromium.org/7031026

10:36 AM Changeset in webkit [86684] by kerz@chromium.org

• 3 edits
  2 deletes in branches/chromium/742

Revert 85494 - MERGE 85090 - 2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

• editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
• editing/pasteboard/do-not-copy-body-color.html: Added.

2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

• editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
• editing/pasteboard/do-not-copy-body-color.html: Added.

​http://crbug.com/80498

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/6975019

10:27 AM Changeset in webkit [86683] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
​https://bugs.webkit.org/show_bug.cgi?id=60970

• inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

10:25 AM Changeset in webkit [86682] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

2011-05-17 Sakamuri Ramakrishna <​ramakrishna.sakamuri@nokia.com>

Reviewed by Andreas Kling.

[Qt] 4 of the skipped storage layout tests pass on Qt Linux- skip list to be modified
​https://bugs.webkit.org/show_bug.cgi?id=60715

• platform/qt/Skipped:

10:23 AM Changeset in webkit [86681] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

2011-05-17 Anton Muhin <​antonm@chromium.org>

Unreviewed.

Improving test expectations.

• platform/chromium/test_expectations.txt:

10:16 AM Changeset in webkit [86680] by andreas.kling@nokia.com

• 3 edits
  4 adds in trunk

2011-05-17 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
​https://bugs.webkit.org/show_bug.cgi?id=40841

Test: compositing/animation/busy-indicator.html

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::TransformAnimationQt::getAnimatedProperty): (WebCore::OpacityAnimationQt::getAnimatedProperty): (WebCore::GraphicsLayerQt::addAnimation):

2011-05-17 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
​https://bugs.webkit.org/show_bug.cgi?id=40841

• compositing/animation/busy-indicator-no.png: Added.
• compositing/animation/busy-indicator.html: Added.
• compositing/animation/busy-indicator.png: Added.
• compositing/animation/busy-indicator-expected.txt: Added.

10:13 AM Changeset in webkit [86679] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Grace Kloba <​klobag@chromium.org>

Reviewed by Kenneth Russell.

GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
​https://bugs.webkit.org/show_bug.cgi?id=60965

• platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

10:12 AM Changeset in webkit [86678] by beidson@apple.com

• 6 edits
  1 move
  2 adds in trunk/Source/WebKit2

Part one of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add am empty shim for a new WebProcess shim and install it at launch.

Use the same Shim.xcconfig for both the web and plugin processes:

• Configurations/PluginProcessShim.xcconfig: Removed.
• Configurations/Shim.xcconfig: Copied from Configurations/PluginProcessShim.xcconfig.
• WebKit2.xcodeproj/project.pbxproj:

• WebProcess/WebProcess.h: Add initializeShim() for Mac-only
• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim): Initialize the (empty) shim callbacks.

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Call initializeShim()

• WebProcess/mac/WebProcessShim.h: Added.
• WebProcess/mac/WebProcessShim.mm: Added.

(WebKit::WebKitWebProcessShimInitialize): Empty for now.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Install the Plugin Process shim for plugin processes

and the WebProcess shim for the web content process.

10:05 AM Changeset in webkit [86677] by andreas.kling@nokia.com

• 2 edits in trunk/LayoutTests

2011-05-17 Andreas Kling <​kling@webkit.org>

Bot-matching rebaseline after r86675.

• platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:

9:57 AM Changeset in webkit [86676] by sullivan@apple.com

• 2 edits in trunk/Source/WebKit2

Loose end from fix for ​https://bugs.webkit.org/show_bug.cgi?id=60938

Reviewed by Adam Roben.

• WebKit2.xcodeproj/project.pbxproj:

Made new header file "private" instead of "project" so clients can access it.

9:34 AM Changeset in webkit [86675] by commit-queue@webkit.org

• 18 edits in trunk/LayoutTests

2011-05-17 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] rebaseline skipped tests after r83871
​https://bugs.webkit.org/show_bug.cgi?id=60961

Rebaseline tests after r83871 and remove them from Qt Skipped file.

• platform/qt/Skipped:
• platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
• platform/qt/http/tests/misc/error404-expected.txt:
• platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
• platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
• platform/qt/http/tests/misc/iframe404-expected.txt:
• platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
• platform/qt/http/tests/uri/css-href-expected.txt:
• platform/qt/tables/layering/paint-test-layering-1-expected.txt:
• platform/qt/tables/layering/paint-test-layering-2-expected.txt:
• platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
• platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
• platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
• platform/qt/tables/mozilla/other/slashlogo-expected.txt:
• platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
• platform/qt/transforms/2d/transform-fixed-container-expected.txt:
• platform/qt/transitions/svg-text-shadow-transition-expected.txt:

9:24 AM Changeset in webkit [86674] by apavlov@chromium.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
​https://bugs.webkit.org/show_bug.cgi?id=60962

• inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):

9:03 AM Changeset in webkit [86673] by jberlin@webkit.org

• 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference.
​https://bugs.webkit.org/show_bug.cgi?id=42197

Add fast/images/animated-gif-restored-from-bfcache.html to the mac-wk2 Skipped list to get
the bots green.

• platform/mac-wk2/Skipped:

7:39 AM Changeset in webkit [86672] by podivilov@chromium.org

• 27 edits in trunk

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
​http://trac.webkit.org/changeset/86660
​https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

• http/tests/inspector/change-iframe-src.html:
• http/tests/inspector/console-resource-errors.html:
• http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
• http/tests/inspector/network/network-size-chunked.html:
• http/tests/inspector/network/network-size-sync.html:
• http/tests/inspector/network/network-size.html:
• http/tests/inspector/network/network-timing.html:
• http/tests/inspector/resource-tree/resource-tree-frame-add.html:
• http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
• inspector/console/console-assert.html:
• inspector/console/console-trace-in-eval.html:
• inspector/console/console-trace.html:
• inspector/console/console-uncaught-exception.html:
• inspector/debugger/debugger-autocontinue-on-syntax-error.html:
• inspector/styles/styles-iframe.html:
• inspector/timeline/timeline-network-resource.html:
• inspector/timeline/timeline-script-tag-1.html:
• inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
​http://trac.webkit.org/changeset/86660
​https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
• inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
• inspector/front-end/Panel.js: (WebInspector.Panel):
• inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js: (WebInspector._createPanels):

6:29 AM Changeset in webkit [86671] by Adam Roben

• 2 edits in trunk/Tools

Make run-api-tests work on Windows when there are spaces in the path

Fixes <​http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe

Reviewed by David Levin.

• Scripts/run-api-tests:

(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.

6:06 AM Changeset in webkit [86670] by alexis.menard@openbossa.org

• 2 edits in trunk/Source/WebCore

2011-05-17 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed warning fix introduced by r86377.

• rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):

4:51 AM Changeset in webkit [86669] by yutak@chromium.org

• 8 edits
  1 add in trunk/Source/WebCore

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
​https://bugs.webkit.org/show_bug.cgi?id=60945

Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
move these definitions into .cpp in order to allow further modifications in this class.

No new tests, as this is just refactoring.

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::create): (WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::sent): (WebCore::ThreadableWebSocketChannelClientWrapper::setSent): (WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::clearClient): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
• websockets/ThreadableWebSocketChannelClientWrapper.h:

4:39 AM Changeset in webkit [86668] by andreas.kling@nokia.com

• 4 edits in trunk/Source/WebKit2

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
​https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

• UIProcess/API/qt/qgraphicswkview.cpp:
• UIProcess/API/qt/qgraphicswkview.h:
• UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):

4:36 AM Changeset in webkit [86667] by andreas.kling@nokia.com

• 3 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support shadowed text in fast font path.
​https://bugs.webkit.org/show_bug.cgi?id=60462

• platform/graphics/Font.cpp: (WebCore::Font::drawText): Remove complex path shortcut for shadowed text.

• platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawGlyphs): Paint shadows for simple text.

4:34 AM Changeset in webkit [86666] by andreas.kling@nokia.com

• 2 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Construct GraphicsLayerQtImpl::State with correct values.
​https://bugs.webkit.org/show_bug.cgi?id=60902

The GraphicsLayerQtImpl initial state should match the initial values
of the corresponding GraphicsLayer flags.

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::State::State):

3:12 AM Changeset in webkit [86665] by hans@chromium.org

• 5 edits in trunk

2011-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
​https://bugs.webkit.org/show_bug.cgi?id=60697

Test that we can create a new index for which not all current records
have a key.

• storage/indexeddb/index-basics-expected.txt:
• storage/indexeddb/index-basics.html:

2011-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
​https://bugs.webkit.org/show_bug.cgi?id=60697

When populating a new index, records which do not have a key on the
index's key path should be ignored.

• storage/IDBObjectStoreBackendImpl.cpp:

2:46 AM Changeset in webkit [86664] by commit-queue@webkit.org

• 6 edits in trunk/Source

2011-05-17 Young Han Lee <​joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
​https://bugs.webkit.org/show_bug.cgi?id=60947

No new tests. Build fix.

• platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapper::create):
• platform/graphics/qt/TextureMapperQt.h: (WebCore::TextureMapperQt::create):
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):

2011-05-17 Young Han Lee <​joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
​https://bugs.webkit.org/show_bug.cgi?id=60947

• WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQWidget::setRootGraphicsLayer):

2:34 AM Changeset in webkit [86663] by apavlov@chromium.org

• 6 edits in trunk

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
​https://bugs.webkit.org/show_bug.cgi?id=60890

• inspector/styles/up-down-numerics-and-colors-expected.txt:
• inspector/styles/up-down-numerics-and-colors.html:

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
​https://bugs.webkit.org/show_bug.cgi?id=60890

• inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.alteredFloatNumber): (WebInspector.StylePropertyTreeElement.prototype):

2:31 AM Changeset in webkit [86662] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests are flaky on Linux.
fast/speech/input-appearance-numberandspeech.html
fast/speech/input-appearance-searchandspeech.html
fast/speech/input-appearance-speechbutton.html

• platform/chromium/test_expectations.txt:

2:11 AM Changeset in webkit [86661] by yuzo@google.com

• 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/js/mozilla/strict/eval-variable-environment.html now passes.

• platform/chromium/test_expectations.txt:

1:59 AM Changeset in webkit [86660] by podivilov@chromium.org

• 27 edits in trunk

2011-05-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

• http/tests/inspector/change-iframe-src.html:
• http/tests/inspector/console-resource-errors.html:
• http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
• http/tests/inspector/network/network-size-chunked.html:
• http/tests/inspector/network/network-size-sync.html:
• http/tests/inspector/network/network-size.html:
• http/tests/inspector/network/network-timing.html:
• http/tests/inspector/resource-tree/resource-tree-frame-add.html:
• http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
• inspector/console/console-assert.html:
• inspector/console/console-trace-in-eval.html:
• inspector/console/console-trace.html:
• inspector/console/console-uncaught-exception.html:
• inspector/debugger/debugger-autocontinue-on-syntax-error.html:
• inspector/styles/styles-iframe.html:
• inspector/timeline/timeline-network-resource.html:
• inspector/timeline/timeline-script-tag-1.html:
• inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

• inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
• inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
• inspector/front-end/Panel.js: (WebInspector.Panel):
• inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js: (WebInspector._createPanels):

12:37 AM Changeset in webkit [86659] by yutak@chromium.org

• 4 edits in trunk

2011-05-16 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
​https://bugs.webkit.org/show_bug.cgi?id=60880

• http/tests/websocket/tests/handshake-error-expected.txt: Remove a carriage return in the first line.

2011-05-16 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
​https://bugs.webkit.org/show_bug.cgi?id=60880

• websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine): WebSocketHandshake should not print a carriage return to console. To fix this, we first check whether the status line ends with CRLF. After that, we can print the first (lineLength - 2) characters of the status line which do not contain a carriage return.