⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 19, 2011:

11:37 PM Changeset in webkit [86926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-19 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=61163

Manual test input-number-localization.html.
Because we can't assume any number formats in various WebKit ports.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
  • manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.
11:25 PM Changeset in webkit [86925] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt: add BUGWK61169
10:31 PM Changeset in webkit [86924] by jer.noble@apple.com
  • 5 edits in trunk/Source

2011-05-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=56957

Guard against the parameter of setAnimating() matching the ivar value it's
setting, thus avoiding tearing down the renderer's layer backing.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating):

2011-05-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=56957

In the WKFullscreenWindowController, when exiting accelerated compositing mode,
force a repaint, and don't actually remove the animation layer until the repaint
completes. Also, move back to parenting the WebView in a layer-backed view, and
work around the SnowLeopard bug which causes a crash in those situations. We no
longer need to do a bunch of work in finishedEnterFullScreenAnimation, because
the animation layer is "hiding" all the drawing happening in the webView underneath.

In the WebFullScreenManagerMac, when asked to tear down the root layer, instead
remove all its children, and set its contents to a flattened image of the full
screen element and its children. This helps patch over the time where everything
is re-rendering and helps give the appearance of continuousness in the animation.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]): (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): (exitCompositedModeRepaintCompleted): (-[WKFullScreenWindowController _page]): (-[WKFullScreenWindowController _manager]): (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
10:27 PM Changeset in webkit [86923] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix ARM build after r86919

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::nop):

9:10 PM Changeset in webkit [86922] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-19 Dmitry Lomov <​dslomov@google.com>

Reviewed by Adam Roben.

Detect hangs in run-api-tests
​https://bugs.webkit.org/show_bug.cgi?id=48043

  • Scripts/run-api-tests: Added test timeouts
7:39 PM Changeset in webkit [86921] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-19 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Adam Barth.

Remove Node::deprecatedParserAddChild
​https://bugs.webkit.org/show_bug.cgi?id=60818

Refactoring only so no new tests.

This patch fails short of one instance of deprecatedParserAddChild which will
require a refactoring of <input> shadow DOM to be removed.

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode. (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear up m_leafTextNode too.

(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::exitText):
Those methods were updated to use m_leafTextNode instead of m_currentNode.

  • dom/XMLDocumentParser.h: Changed the currentNode logic to use ContainerNode. Also fixed the style of the forward declarations.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): Removed the calls to deprecatedParserAddChild, changed the code to use m_leafTextNode when it made sense and used ContainerNode instead of Node for m_currentNode.
7:01 PM Changeset in webkit [86920] by commit-queue@webkit.org
  • 31 edits
    8 adds in trunk

2011-05-19 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
​https://bugs.webkit.org/show_bug.cgi?id=56627

  • css3/images/optimize-contrast-canvas-expected.checksum: Added.
  • css3/images/optimize-contrast-canvas-expected.png: Added.
  • css3/images/optimize-contrast-canvas-expected.txt: Added.
  • css3/images/optimize-contrast-canvas.html: Added.
  • css3/images/optimize-contrast-image-expected.checksum: Added.
  • css3/images/optimize-contrast-image-expected.png: Added.
  • css3/images/optimize-contrast-image-expected.txt: Added.
  • css3/images/optimize-contrast-image.html: Added.

2011-05-19 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
​https://bugs.webkit.org/show_bug.cgi?id=56627

Tests: css3/images/optimize-contrast-canvas.html

css3/images/optimize-contrast-image.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Added.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
6:33 PM Changeset in webkit [86919] by oliver@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2011-05-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Randomise code starting location a little
​https://bugs.webkit.org/show_bug.cgi?id=61161

Add a nop() function to the Assemblers so that we
can randomise code offsets slightly at no real cost.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::nop):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::nop):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::nop):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nop):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::nop):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::nop):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::nop):
  • assembler/X86Assembler.h: (JSC::X86Assembler::nop):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • runtime/WeakRandom.h: (JSC::WeakRandom::getUint32):
6:25 PM Changeset in webkit [86918] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.36-branch

Merge r86852.

6:18 PM Changeset in webkit [86917] by Lucas Forschler
  • 3 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86851.

6:16 PM Changeset in webkit [86916] by Lucas Forschler
  • 2 edits in branches/safari-534.36-branch/Source/JavaScriptCore

Merge r86850.

6:13 PM Changeset in webkit [86915] by Lucas Forschler
  • 5 edits in branches/safari-534.36-branch

Merge r86827.

6:13 PM Changeset in webkit [86914] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:11 PM Changeset in webkit [86913] by Lucas Forschler
  • 2 edits in branches/safari-534.36-branch/Source/JavaScriptCore

Merge r86809.

6:04 PM Changeset in webkit [86912] by Lucas Forschler
  • 16 edits in branches/safari-534.36-branch/Source

Merge r86785.

6:03 PM Changeset in webkit [86911] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; added new test to gtk Skipped list.

  • platform/gtk/Skipped:
6:01 PM Changeset in webkit [86910] by jamesr@google.com
  • 2 edits in branches/chromium/742/Source/WebCore

2011-05-19 James Robinson <​jamesr@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=61159

Add a speculative null check to see if it reduces the crashrate.

​http://code.google.com/p/chromium-os/issues/detail?id=15377

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
5:56 PM Changeset in webkit [86909] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.36-branch

Merge r86748.

5:20 PM Changeset in webkit [86908] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

5:12 PM Changeset in webkit [86907] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-19 Dmitry Lomov <​dslomov@google.com>

Reviewed by Adam Roben.

run-api-tests should run one test per process
​https://bugs.webkit.org/show_bug.cgi?id=61088

  • Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, return code, and parsing GTest output format.
4:46 PM Changeset in webkit [86906] by oliver@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-05-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Add guard pages to each end of the memory region used by the fixedvm allocator
​https://bugs.webkit.org/show_bug.cgi?id=61150

Add mechanism to notify the OSAllocator that pages at either end of an
allocation should be considered guard pages. Update PageReservation,
PageAllocation, etc to handle this.

  • JavaScriptCore.exp:
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
  • wtf/OSAllocator.h:
  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::reserveAndCommit):
  • wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
  • wtf/PageAllocationAligned.h: (WTF::PageAllocationAligned::PageAllocationAligned):
  • wtf/PageBlock.h: (WTF::PageBlock::PageBlock):
  • wtf/PageReservation.h: (WTF::PageReservation::reserve): (WTF::PageReservation::reserveWithGuardPages):

Add a new function to make a reservation that will add guard
pages to the ends of an allocation.

(WTF::PageReservation::PageReservation):

4:43 PM Changeset in webkit [86905] by kbr@google.com
  • 8 edits
    5 adds in trunk

2011-05-18 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
​https://bugs.webkit.org/show_bug.cgi?id=61091

  • compositing/webgl/webgl-no-alpha.html: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.txt: Added.

2011-05-18 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
​https://bugs.webkit.org/show_bug.cgi?id=61091

Test: compositing/webgl/webgl-no-alpha.html

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::setHasAlpha):
4:17 PM Changeset in webkit [86904] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

2011-05-18 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
​https://bugs.webkit.org/show_bug.cgi?id=61109

  • media/video-src-invalid-poster-expected.txt: Added.
  • media/video-src-invalid-poster.html: Added.

2011-05-18 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
​https://bugs.webkit.org/show_bug.cgi?id=61109

Test: media/video-src-invalid-poster.html

In the case where no video sources are playable, update the display state and
renderer, allowing the poster image to display.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::waitForSourceChange):
3:53 PM Changeset in webkit [86903] by Lucas Forschler
  • 3 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86820.

3:51 PM Changeset in webkit [86902] by Lucas Forschler
  • 3 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86814.

3:46 PM Changeset in webkit [86901] by Lucas Forschler
  • 13 edits in branches/safari-534.36-branch/Source

Merge r86806.

3:39 PM Changeset in webkit [86900] by Lucas Forschler
  • 12 edits in branches/safari-534.36-branch/Source

Merge r86793.

3:29 PM Changeset in webkit [86899] by atwilson@chromium.org
  • 6 edits in trunk

2011-05-19 Andrew Wilson <​atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying
​https://bugs.webkit.org/show_bug.cgi?id=61130

  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js: Added test for "passing an array with an item at a really large index" to postMessage().

2011-05-19 Andrew Wilson <​atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying.
​https://bugs.webkit.org/show_bug.cgi?id=61130

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::fillMessagePortArray): Changed code to not pre-allocate the destination array.
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray): Changed code to not pre-allocate the destination array.
3:13 PM Changeset in webkit [86898] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Address a review comment by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didUpdateHistoryTitle):

3:13 PM Changeset in webkit [86897] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.36-branch/Source/WebKit2

Merge r86792.

3:10 PM Changeset in webkit [86896] by Lucas Forschler
  • 2 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86783.

3:10 PM Changeset in webkit [86895] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Hang UI appears when WebProcess isn't running
​https://bugs.webkit.org/show_bug.cgi?id=61147
<rdar://problem/9413683>

This fixes two bugs:

  1. The HistoryClient related message handlers in WebContext could get invoked for pages that have been closed, and thus didn't have any subframes. Since we have a MESSAGE_CHECK that checks that the frame exists, we'd mark the currently dispatched message as invalid, which would end up calling Connection::Client::didReceiveInvalidMessage. Fix this by checking that the page exists first.
  1. In the call to WebProcessProxy::didReceiveInvalidMessage we'd first invalidate the CoreIPC connection to make sure that we won't get any further messages from this connection. We'd then go ahead and terminate the web process, but because we've already invalidated the CoreIPC connection we would never get the Connection::Client::didClose callback that would call WebPageProxy::processDidCrash. Fix this by explicitly calling WebProcessProxy::didClose. Also, add logging when we receive an invalid message
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveInvalidMessage):
3:08 PM Changeset in webkit [86894] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.36-branch

Merge r86781.

3:06 PM Changeset in webkit [86893] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when detaching Web Inspector when parent is in process of closing.
​https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>

Reviewed by Adam Roben.

We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.

3:06 PM Changeset in webkit [86892] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86781
BUG=79075
Review URL: ​http://codereview.chromium.org/7048016

3:05 PM Changeset in webkit [86891] by Lucas Forschler
  • 5 edits
    4 copies in branches/safari-534.36-branch

Merge r86741.

3:00 PM Changeset in webkit [86890] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:41 PM Changeset in webkit [86889] by Lucas Forschler
  • 5 edits
    4 deletes in branches/safari-534.36-branch

rollout last change... merged the wrong changeset.

2:18 PM Changeset in webkit [86888] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
1:39 PM Changeset in webkit [86887] by robert@webkit.org
  • 4 edits in trunk

2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • platform/qt/Skipped:

2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_stream): (webkit_test_plugin_write_ready): (webkit_test_plugin_write):
1:36 PM Changeset in webkit [86886] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update.


  • platform/chromium/test_expectations.txt:
1:26 PM Changeset in webkit [86885] by mrowe@apple.com
  • 4 moves in branches/old

Move aside some old branches.

1:19 PM Changeset in webkit [86884] by Lucas Forschler
  • 5 edits
    4 copies in branches/safari-534.36-branch

Merge r86741.

1:18 PM Changeset in webkit [86883] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-05-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Executables release their JIT code as soon as they become dead
​https://bugs.webkit.org/show_bug.cgi?id=61134

Add an ability to clear an Executable's jit code without requiring
it to be destroyed, and then call that from a finalizer.

  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::leak):
  • jit/JITCode.h: (JSC::JITCode::clear):
  • runtime/Executable.cpp: (JSC::ExecutableFinalizer::finalize): (JSC::ExecutableBase::executableFinalizer):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::clearExecutableCode):
1:18 PM Changeset in webkit [86882] by jschuh@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium gradient expectations update.

  • platform/chromium-linux-x86/fast/gradients: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
1:13 PM Changeset in webkit [86881] by Lucas Forschler
  • 4 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86738.

1:11 PM Changeset in webkit [86880] by Lucas Forschler
  • 9 edits in branches/safari-534.36-branch

Merge r86737.

1:10 PM Changeset in webkit [86879] by Dimitri Glazkov
  • 21 edits
    11 deletes in trunk

2011-05-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
​http://trac.webkit.org/changeset/86869
​http://trac.webkit.org/changeset/86873
​http://trac.webkit.org/changeset/86875
​http://trac.webkit.org/changeset/86877
​https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/harness/internals-object-expected.txt: Removed.
  • fast/harness/internals-object.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
​http://trac.webkit.org/changeset/86869
​http://trac.webkit.org/changeset/86873
​http://trac.webkit.org/changeset/86875
​http://trac.webkit.org/changeset/86877
​https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/Internals.cpp: Removed.
  • testing/Internals.h: Removed.
  • testing/Internals.idl: Removed.
  • testing/js/WebCoreTestSupport.cpp: Removed.
  • testing/js/WebCoreTestSupport.h: Removed.
  • testing/v8/WebCoreTestSupport.cpp: Removed.
  • testing/v8/WebCoreTestSupport.h: Removed.

2011-05-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
​http://trac.webkit.org/changeset/86869
​http://trac.webkit.org/changeset/86873
​http://trac.webkit.org/changeset/86875
​http://trac.webkit.org/changeset/86877
​https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • WebKit.gyp:
  • public/WebTestingSupport.h: Removed.
  • src/WebTestingSupport.cpp: Removed.

2011-05-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
​http://trac.webkit.org/changeset/86869
​http://trac.webkit.org/changeset/86873
​http://trac.webkit.org/changeset/86875
​http://trac.webkit.org/changeset/86877
​https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1:05 PM Changeset in webkit [86878] by Lucas Forschler
  • 2 edits in branches/safari-534.36-branch/Source/WebKit2

Merge r86734.

1:01 PM Changeset in webkit [86877] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-19 Dimitri Glazkov <Dimitri Glazkov>

One more fix after r86869.

  • WebCore.exp.in: Made ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.
12:55 PM Changeset in webkit [86876] by Lucas Forschler
  • 47 edits in branches/safari-534.36-branch

Merge r86727.

12:45 PM Changeset in webkit [86875] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add two more symbols needed by the window.internals library.

  • WebCore.exp.in:
12:44 PM Changeset in webkit [86874] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.36-branch

Merge r86725.

12:26 PM Changeset in webkit [86873] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-19 Dimitri Glazkov <Dimitri Glazkov>

Fix Leopard build after r86869.

  • WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.
12:24 PM Changeset in webkit [86872] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [86871] by Lucas Forschler
  • 5 edits in branches/safari-534.36-branch/Source

Versioning.

11:59 AM Changeset in webkit [86870] by robert@webkit.org
  • 6 edits in trunk

2011-05-19 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
​https://bugs.webkit.org/show_bug.cgi?id=60992

  • platform/qt/Skipped:

2011-05-19 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
​https://bugs.webkit.org/show_bug.cgi?id=60992

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • plugins/qt/PluginViewQt.cpp: (WebCore::getPluginDisplay):

2011-05-19 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::getPluginDisplay):
11:54 AM Changeset in webkit [86869] by Dimitri Glazkov
  • 20 edits
    14 adds in trunk

2011-05-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
​https://bugs.webkit.org/show_bug.cgi?id=60313

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/harness/internals-object-expected.txt: Added.
  • fast/harness/internals-object.html: Added.
  • platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-05-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
​https://bugs.webkit.org/show_bug.cgi?id=60313

Test: fast/harness/internals-object.html

  • DerivedSources.make: Added support for generating from Internals.idl.
  • WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  • testing/Internals.cpp: Added.
  • testing/Internals.h: Added.
  • testing/Internals.idl: Added.
  • testing/js/WebCoreTestSupport.cpp: Added.
  • testing/js/WebCoreTestSupport.h: Added.
  • testing/v8/WebCoreTestSupport.cpp: Added.
  • testing/v8/WebCoreTestSupport.h: Added.

2011-05-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
​https://bugs.webkit.org/show_bug.cgi?id=60313

  • WebKit.gyp: Added linking new webkit_test_support library.
  • public/WebTestingSupport.h: Added.
  • src/WebTestingSupport.cpp: Added.

2011-05-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
​https://bugs.webkit.org/show_bug.cgi?id=60313

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
11:51 AM Changeset in webkit [86868] by rniwa@webkit.org
  • 7 edits in branches/chromium/696/Source/WebCore

Merge 84265 - 2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=57061

The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
a significant performance regression.

Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
and prevents respondToNodeModification from clearing selection.

No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
isn't exposed to JavaScript.

  • dom/Range.cpp: (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of start and end nodes are same, we should never get an exception from compareBoundaryPoints. (WebCore::Range::setEnd): Ditto. (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints throws an exception. (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by compareBoundaryPoints. (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor. (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
  • dom/Range.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::respondToNodeModification):
  • editing/htmlediting.cpp: (WebCore::comparePositions): Calls compareBoundaryPoints.
  • editing/markup.cpp: (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document and neither are in a shadow DOM, it should never throw an exception.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception was thrown.

ISSUE=83197
TBR=​rniwa@webkit.org

11:45 AM Changeset in webkit [86867] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/696

Merge 86748
BUG=82516

11:43 AM Changeset in webkit [86866] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86748
BUG=82516
Review URL: ​http://codereview.chromium.org/7048008

11:43 AM Changeset in webkit [86865] by cdn@chromium.org
  • 4 edits
    2 copies in branches/chromium/742

Merge 86358 - 2011-05-12 Carol Szabo <​carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
​https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572
Review URL: ​http://codereview.chromium.org/7049017

11:40 AM Changeset in webkit [86864] by cdn@chromium.org
  • 4 edits
    2 copies in branches/chromium/696

Merge 86358 - 2011-05-12 Carol Szabo <​carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
​https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572

11:40 AM Changeset in webkit [86863] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-19 Dimitri Glazkov <Dimitri Glazkov>

Accept XCode's decisions to keep modifying WebCore.xcodeproj.

  • WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.
11:39 AM Changeset in webkit [86862] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86448
BUG=82546
Review URL: ​http://codereview.chromium.org/7050016

11:39 AM Changeset in webkit [86861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-19 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Darin Adler.

Fix GraphicsContext3DQt.cpp compile error
​https://bugs.webkit.org/show_bug.cgi?id=61128

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): clear() m_internal OwnPtr.
11:38 AM Changeset in webkit [86860] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/696

Merge 86448
BUG=82546

11:35 AM Changeset in webkit [86859] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86500
BUG=82633
Review URL: ​http://codereview.chromium.org/7033030

11:33 AM Changeset in webkit [86858] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/696

Merge 86500
BUG=82633

11:31 AM Changeset in webkit [86857] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/742

Merge 85977 - 2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189
Review URL: ​http://codereview.chromium.org/7051008

11:27 AM Changeset in webkit [86856] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/696

Merge 85977 - 2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189

11:14 AM Changeset in webkit [86855] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-19 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Resizing columns in the network panel is weird
​https://bugs.webkit.org/show_bug.cgi?id=55238

Makes network panel column resizing more usable by adding "first only" and "last only"
resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
remains default. Network panels datagrid is set to use method "last".

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get resizeMethod): (WebInspector.DataGrid.prototype.set resizeMethod): (WebInspector.DataGrid.prototype._resizerDragging):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable):
10:46 AM Changeset in webkit [86854] by rniwa@webkit.org
  • 10 edits
    2 deletes in trunk/Source/WebCore

2011-05-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

JoinTextNodesCommand is never used
​https://bugs.webkit.org/show_bug.cgi?id=61089

Deleted JoinTextNodesCommand because it's never used.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditingAllInOne.cpp:
  • editing/JoinTextNodesCommand.cpp: Removed.
  • editing/JoinTextNodesCommand.h: Removed.
10:27 AM Changeset in webkit [86853] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-19 Ryosuke Niwa <​rniwa@webkit.org>

Make Mac Leopard bot happy after r81176.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
10:22 AM Changeset in webkit [86852] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

2011-05-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
​https://bugs.webkit.org/show_bug.cgi?id=61012

Added a test to ensure WebKit does not crash when inserting a content immediately after
a styled element inside a Mail blockquote. Regrettably the expected result is incorrect,
but it matches the behavior of WebKit before r83322.

  • editing/pasteboard/5065605-expected.txt: Reintroduced redundant style spans.
  • editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • editing/pasteboard/paste-after-inline-style-element-expected.txt: Added.
  • editing/pasteboard/paste-after-inline-style-element.html: Added.

2011-05-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
​https://bugs.webkit.org/show_bug.cgi?id=61012

The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
being moved when the insertion position's container node is the node to split to. Fixed the crash
by not changing the insertion position in such a case.

Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
it's much better than crashing.

Test: editing/pasteboard/paste-after-inline-style-element.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
10:17 AM Changeset in webkit [86851] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-18 Chris Marrin <​cmarrin@apple.com>

Reviewed by Anders Carlsson.

Plug-ins at YouTube, cnn.com, nytimes vanish when their top/left is scrolled out of view when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=61101

Scale both bounding boxes sent to m_plugin->geometryDidChange(), not just the frameRect. This fools
the plugin into thinking it is drawing into an unscaled box with an unscaled view even when scaled.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::frame):Made this const so it can be used in clipRectInWindowCoordinates() (WebKit::PluginView::viewGeometryDidChange):Used IntRect::scale() rather than scaling by hand (WebKit::PluginView::clipRectInWindowCoordinates):Added scale of clipRect.
  • WebProcess/Plugins/PluginView.h:
10:15 AM Changeset in webkit [86850] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Remove a redundant and broken data export

Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.
10:15 AM Changeset in webkit [86849] by Lucas Forschler
  • 1 copy in branches/safari-534.36-branch

New Branch.

9:51 AM Changeset in webkit [86848] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-19 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
​https://bugs.webkit.org/show_bug.cgi?id=61113

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke): (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
9:33 AM Changeset in webkit [86847] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

9:28 AM Changeset in webkit [86846] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing test after r86841.

  • platform/qt-arm/Skipped:
9:22 AM Changeset in webkit [86845] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::markersHaveIdenticalDescription): Call description() function.

8:12 AM Changeset in webkit [86844] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing tests after r86834.

  • platform/qt-arm/Skipped:
6:08 AM Changeset in webkit [86843] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-19 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip 2 failing tests on GTK.

  • platform/gtk/Skipped: Skip http/tests/appcache/interrupted-update.html and http/tests/navigation/post-307-response.html
5:44 AM Changeset in webkit [86842] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-19 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: switch to Scripts panel is too slow
​https://bugs.webkit.org/show_bug.cgi?id=61030

  • It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
  • Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates): (WebInspector.TextEditorMainPanel.prototype.endDomUpdates): (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype._createRow):
5:39 AM Changeset in webkit [86841] by Csaba Osztrogonác
  • 9 edits in trunk

[Qt] Implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=60015

Patch by Zsolt Fehér <​h490267@stud.u-szeged.hu> on 2011-05-19
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::scalePageBy):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped: Unskip fast/transforms/selection-bounds-in-transformed-view.html.
5:35 AM Changeset in webkit [86840] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Skip failing tests after r86834.

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
5:13 AM Changeset in webkit [86839] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-19 Pavel Feldman <​pfeldman@google.com>

Not reviewed: inspector protocol tests fixed.

  • inspector/InjectedScriptSource.js:
5:03 AM Changeset in webkit [86838] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-19 David Grogan <​dgrogan@chromium.org>

Reviewed by David Levin.

Make EventQueue post a Task to the task queue for each asynchronous event
​https://bugs.webkit.org/show_bug.cgi?id=60790

Currently EventQueue queues up events to be fired asynchronously and
fires each of them when a single DOMTimer goes off. In the words of
dimich, "Having 2 queues will sooner or later cause problems with
ordering of tasks, termination, suspension and other things that all
require some control on how queues operate."

No new tests; this is just a refactoring to avoid potential future
problems.

  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::EventDispatcherTask::create): (WebCore::EventQueue::EventDispatcherTask::dispatchEvent): (WebCore::EventQueue::EventDispatcherTask::performTask): (WebCore::EventQueue::EventDispatcherTask::cancel): (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask): (WebCore::EventQueue::removeEvent): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::enqueueOrDispatchScrollEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents):
  • dom/EventQueue.h:
4:47 AM Changeset in webkit [86837] by yurys@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
​https://bugs.webkit.org/show_bug.cgi?id=60800

  • inspector/console/console-eval-blocked-expected.txt: Added.
  • inspector/console/console-eval-blocked.html: Added.

2011-05-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
​https://bugs.webkit.org/show_bug.cgi?id=60800

Thanks to Adam Barth for providing JSC implementation!

InjectedScriptHost.evaluate is used to perform script evaluations for
inspector needs. This method is not affected by CSP and should fix inspector
on pages with CSP restrictions.

Test: inspector/console/console-eval-blocked.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::evaluate):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
4:10 AM Changeset in webkit [86836] by pfeldman@chromium.org
  • 5 edits in trunk

2011-05-19 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object class name as a part of RemoteObject mirror.
​https://bugs.webkit.org/show_bug.cgi?id=61067

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
4:09 AM Changeset in webkit [86835] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-19 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "this" a part of callFrame, not scope in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=61057

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
4:04 AM Changeset in webkit [86834] by commit-queue@webkit.org
  • 32 edits
    35 adds in trunk/LayoutTests

2011-05-19 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/style tests that are working
​https://bugs.webkit.org/show_bug.cgi?id=61075

Also based on digging of Zsolt Fehér.

  • platform/qt/Skipped:
  • platform/qt/editing/style/5046875-1-expected.png: Added.
  • platform/qt/editing/style/5046875-1-expected.txt:
  • platform/qt/editing/style/5046875-2-expected.png: Added.
  • platform/qt/editing/style/5046875-2-expected.txt:
  • platform/qt/editing/style/5065910-expected.png: Added.
  • platform/qt/editing/style/5065910-expected.txt:
  • platform/qt/editing/style/5084241-expected.png: Added.
  • platform/qt/editing/style/5084241-expected.txt:
  • platform/qt/editing/style/5279521-expected.png: Added.
  • platform/qt/editing/style/5279521-expected.txt:
  • platform/qt/editing/style/block-style-004-expected.png: Added.
  • platform/qt/editing/style/block-style-005-expected.png: Added.
  • platform/qt/editing/style/block-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.txt:
  • platform/qt/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-002-expected.txt:
  • platform/qt/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-003-expected.txt:
  • platform/qt/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-004-expected.txt:
  • platform/qt/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-005-expected.txt:
  • platform/qt/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-006-expected.txt:
  • platform/qt/editing/style/create-block-for-style-007-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-007-expected.txt:
  • platform/qt/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-008-expected.txt:
  • platform/qt/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-009-expected.txt:
  • platform/qt/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-010-expected.txt:
  • platform/qt/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-011-expected.txt:
  • platform/qt/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-012-expected.txt:
  • platform/qt/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-013-expected.txt:
  • platform/qt/editing/style/font-family-with-space-expected.png: Added.
  • platform/qt/editing/style/font-family-with-space-expected.txt:
  • platform/qt/editing/style/fontsize-1-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-001-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-001-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-002-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-002-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-003-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-003-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-004-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-004-expected.txt:
  • platform/qt/editing/style/smoosh-styles-001-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-001-expected.txt:
  • platform/qt/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-003-expected.txt:
  • platform/qt/editing/style/style-3690704-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.txt:
  • platform/qt/editing/style/style-boundary-001-expected.png: Added.
  • platform/qt/editing/style/style-boundary-001-expected.txt:
  • platform/qt/editing/style/style-boundary-004-expected.png: Added.
  • platform/qt/editing/style/style-boundary-004-expected.txt:
  • platform/qt/editing/style/table-selection-expected.png: Added.
  • platform/qt/editing/style/table-selection-expected.txt:
3:23 AM Changeset in webkit [86833] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-19 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing GTK fullscreen test

​https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped: Skip fullscreen/full-screen-keyboard-enabled.html
2:50 AM Changeset in webkit [86832] by tkent@chromium.org
  • 11 edits in trunk

2011-05-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
​https://bugs.webkit.org/show_bug.cgi?id=60948

Update existing tests for the new behavior.

  • fast/forms/ValidityState-tooLong-input-expected.txt:
  • fast/forms/ValidityState-tooLong-textarea-expected.txt:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/ValidityState-tooLong-input.js:
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js:

2011-05-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
​https://bugs.webkit.org/show_bug.cgi?id=60948

The specification has been updated so that tooLong should be true only
for user-edit values.

Introduce m_wasModifiedByUser flag to HTMLInputElement and
HTMLTextAreaElemnt. It is set to true when a renderer updates the
value, and is cleared when the value is updated by others.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Initialize m_wasModifiedByUser. (WebCore::HTMLInputElement::tooLong): Skip the check if m_wasModifiedByUser is false. (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser. (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::setValue): If sendChange is true, m_wasModifiedByUser should be true because sendChange is set in a case of form auto-fill. We assume a value set by form auto-fill is a kind of user-edit. (WebCore::HTMLInputElement::setValueFromRenderer): m_wasModifiedByUser should be true for the update by a renderer.
  • html/HTMLInputElement.h: Declare m_wasModifiedByUser.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initialize m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::updateValue): m_wasModifiedByUser should be true for the update by a renderer. (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::tooLong): Skip the check if m_wasModifiedByUser is false.
  • html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.
2:47 AM Changeset in webkit [86831] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-19 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Leopard.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
2:45 AM Changeset in webkit [86830] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2011-05-19 David Barr <​davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
​https://bugs.webkit.org/show_bug.cgi?id=38788

  • fast/css/border-radius-non-negative-expected.txt: Added.
  • fast/css/border-radius-non-negative.html: Added.
  • platform/mac/fast/css/border-radius-non-negative-expected.png: Added.

2011-05-19 David Barr <​davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
​https://bugs.webkit.org/show_bug.cgi?id=38788

Ignore border-radius properties with negative values.

Test: fast/css/border-radius-non-negative.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderRadius):
2:33 AM Changeset in webkit [86829] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-19 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
​https://bugs.webkit.org/show_bug.cgi?id=61034

Refactoring only. No new tests.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task to hold these pending events.
2:22 AM Changeset in webkit [86828] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Added a test which ensures the IME candidate position is located
at suitable position.

  • platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
  • platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
  • platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Always adjusts the range to window relative coordinates.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition which excludes editable selectionRoot from adjusting.

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Call the focused frame's firstRectForCharacterRange() instead of the
main frame so that DRT behaves as the same as Chromium.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange):
2:21 AM Changeset in webkit [86827] by eae@chromium.org
  • 5 edits in trunk

2011-05-19 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
​https://bugs.webkit.org/show_bug.cgi?id=60986

  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt:
  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html:

2011-05-19 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
​https://bugs.webkit.org/show_bug.cgi?id=60986

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple): Don't restore selection if the multiple attribute hasn't changed.
2:19 AM Changeset in webkit [86826] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk

2011-05-19 Mihnea Ovidenie <​mihnea@adobe.com>

Reviewed by Simon Fraser.

Gradients not horizontal using 270deg with odd div width
​https://bugs.webkit.org/show_bug.cgi?id=60157

When the angle of the linear gradient is 270, the endpoint should
be computed in the same way as for 0, 90, 180 cases since tan(270)
is undefined.

  • fast/gradients/css3-linear-right-angle-gradients-expected.txt: Added.
  • fast/gradients/css3-linear-right-angle-gradients.html: Added.
  • platform/mac/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
1:55 AM Changeset in webkit [86825] by Philippe Normand
  • 2 edits in trunk/Source/WebKit2

2011-05-19 Philippe Normand <​pnormand@igalia.com>

Unreviewed, follow-up fix of the messages python unittests after r86812.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
​https://bugs.webkit.org/show_bug.cgi?id=60872

  • Scripts/webkit2/messages_unittest.py:
1:16 AM Changeset in webkit [86824] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-19 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Snow Leopard.

  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
12:28 AM Changeset in webkit [86823] by Nikolas Zimmermann
  • 59 edits in trunk/LayoutTests

2011-05-19 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update mac pixel test baseline, had marginal differences in the filter results and the text selection rectangles since a while.
The baseline passes again on my 32bit and 64bit machine, using run-webkit-tests --tolerance 0.011 -p svg

  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-fonts-02-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.png:
  • platform/mac/svg/text/text-tref-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/text/text-ws-01-t-expected.png:
  • platform/mac/svg/text/text-ws-02-t-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
12:12 AM BuildingQtOnOSX edited by dominicc@chromium.org
Added note about installing the debug variant of the qt4-mac port, … (diff)

May 18, 2011:

11:40 PM Changeset in webkit [86822] by ukai@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-18 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=57048

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): use loaderRunLoop to schedule streams on platform WIN
11:17 PM Changeset in webkit [86821] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip flaky timed out tests on ARM

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
11:16 PM Changeset in webkit [86820] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

As originally reviewed by Anders Carlsson.

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Restore r86797 to how it was supposed to be using the appropriate #ifdef,
reverting the temporary r86814 in the process.

The #ifdef is BUILDING_ON_SNOW_LEOPARD, not BUILDING_ON_SNOWLEOPARD!

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

11:08 PM Changeset in webkit [86819] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-18 MORITA Hajime <​morrita@google.com>

Unreviewed attempt to fix clang build.

  • rendering/InlineTextBox.h:
9:08 PM Changeset in webkit [86818] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Ryosuke Niwa <​rniwa@webkit.org>

Yet another rebaseline after r81176.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
9:02 PM Changeset in webkit [86817] by rniwa@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-05-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

editing/pasteboard/paste-blockquote-into-blockquote-3.html should be a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=61102

Converted the test.

  • editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote-3.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
8:21 PM Changeset in webkit [86816] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImplContentPainter::paint):
7:41 PM Changeset in webkit [86815] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-18 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect size when clipping image layer upload rects
​https://bugs.webkit.org/show_bug.cgi?id=61105

The clipped destination and source rects should have the same size.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::updateTextureRect):
7:28 PM Changeset in webkit [86814] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the WK2 SnowLeopard layouttests (again) until I can explore on a SnowLeopard machine tomorrow.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

6:38 PM Changeset in webkit [86813] by morrita@google.com
  • 14 edits in trunk/Source

2011-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

  • Moved DocumentMarker's member variables to private and added getters for them.
  • Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
  • Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController::addTextMatchMarker() because it accesses DocumentMarker internals.
  • Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
6:36 PM Changeset in webkit [86812] by Darin Adler
  • 32 edits in trunk/Source/WebKit2

2011-05-18 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
​https://bugs.webkit.org/show_bug.cgi?id=60872

Eliminate the concept of SyncReplyMode and instead hand around ownership
of the reply decoder using an OwnPtr.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchSyncMessage): Eliminated comments that say the same things the code itself does. Removed code that handles the reply mode. Instead, pass the OwnPtr to the message handling function and make the call to sendSyncReply conditional on whether the reply encoder is still non-null.
  • Platform/CoreIPC/Connection.h: Removed SyncReplyMode. Made didReceiveSyncMessage return void, and take OwnPtr<ArgumentEncoder>& for the reply encoder.
  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Take an OwnPtr&. Replaced the call to adoptPtr with a call to release.
  • PluginProcess/PluginControllerProxy.h: Updated to take an OwnPtr& and not return SyncReplyMode.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::didReceiveSyncMessage): Ditto.
  • PluginProcess/WebProcessConnection.h: Ditto.
  • Scripts/webkit2/messages.py: Updated for changes to sync messages. Eliminated unneeded return types and use get() when apporopriate to call the handleMessage functions.
  • Scripts/webkit2/messages_unittest.py: Tried to update this too. I don't know how to run the test, though.
  • Shared/Plugins/NPObjectMessageReceiver.h: Updated to take an OwnPtr& and not return SyncReplyMode.
  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::didReceiveSyncMessage): Ditto.
  • Shared/Plugins/NPRemoteObjectMap.h: Ditto.
  • UIProcess/Downloads/DownloadProxy.h: Ditto.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveSyncMessage): Ditto.
  • UIProcess/WebContext.h: Ditto.
  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebFullScreenManagerProxy.h: Ditto.
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::didReceiveSyncMessage): Ditto.
  • UIProcess/WebIconDatabase.h: Ditto.
  • UIProcess/WebInspectorProxy.h: Ditto.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebProcessProxy.h: Ditto.
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: Added a missing include.
  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveSyncMessage): Updated to take an OwnPtr& and not return SyncReplyMode.
  • WebProcess/Plugins/PluginProcessConnection.h: Ditto.
  • WebProcess/Plugins/PluginProxy.h: Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveSyncMessage): Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveSyncMessage): Ditto.
  • WebProcess/WebProcess.h: Ditto.
6:31 PM Changeset in webkit [86811] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
6:15 PM Changeset in webkit [86810] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

+[WebScriptObject throwException:] doesn't work when invoked from obj-c field access
​https://bugs.webkit.org/show_bug.cgi?id=61100

The objc bindings were written to assume exceptions would
come from obj-c style exceptions, rather than throwException:
This code simply calls the global ObjcInstance mechanism for
transferring the reported exception.

  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::ObjcField::setValueToInstance):
5:45 PM Changeset in webkit [86809] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
​https://bugs.webkit.org/show_bug.cgi?id=61064

Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.

  • runtime/JSObject.h:
5:38 PM Changeset in webkit [86808] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Robustly handle mapTexSubImage2D returning NULL
​https://bugs.webkit.org/show_bug.cgi?id=60934

Also, lazily create the temp buffer so that both the map and non-map
cases can use it.

  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
5:16 PM Changeset in webkit [86807] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-18 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Change RenderTextControl::hitInnerTextElement to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61003

Covered by existing tests.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
5:10 PM Changeset in webkit [86806] by Chris Fleizach
  • 13 edits in trunk/Source

WK2: VoiceOver cannot move focus into a web area programmatically
​https://bugs.webkit.org/show_bug.cgi?id=60661

Reviewed by Maciej Stachowiak.

Source/WebCore:

Accessibility code relies on the ability to bring focus to the containing widget view.
In WK2, that message needs to be propagated to the UI process.

  • page/ChromeClient.h:

(WebCore::ChromeClient::makeFirstResponder):

  • page/mac/ChromeMac.mm:

(WebCore::Chrome::focusNSView):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::setFocus):

Source/WebKit2:

Add a makeFirstResponder method that will bring focus to the widget view within the UI
process.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::makeFirstResponder):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::makeFirstResponder):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::makeFirstResponder):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
4:53 PM Changeset in webkit [86805] by enne@google.com
  • 14 edits
    2 copies
    4 adds in trunk/Source

2011-05-18 Alok Priyadarshi <​alokp@chromium.org> and Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Added.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
  • platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-18 Alok Priyadarshi <​alokp@chromium.org> and Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

  • src/WebViewImpl.cpp:
4:43 PM Changeset in webkit [86804] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-05-18 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
​https://bugs.webkit.org/show_bug.cgi?id=58609

One new test and one fix to an existing test that relied on the old
broken behavior.

  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html: Added.
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:

2011-05-18 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
​https://bugs.webkit.org/show_bug.cgi?id=58609

Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
no key generator means that objectStore->autoIncrement() is false, and
key parameter was not provided means that prpKey will be a null pointer.
The combination of these 3 should throw a DATA_ERR.

Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put):
4:34 PM Changeset in webkit [86803] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Oliver Hunt.

[Qt] fast/encoding/yentest.html and yentest2.html fail
​https://bugs.webkit.org/show_bug.cgi?id=39852

  • platform/qt/Skipped: Unskip passing tests.
4:28 PM Changeset in webkit [86802] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium test expectations update for details element (Windows).

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [86801] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-18 Chris Rogers <​crogers@google.com>

Reviewed by James Robinson.

EqualPowerPanner is not using the correct azimuth range for stereo panning
​https://bugs.webkit.org/show_bug.cgi?id=61085

No new tests since audio API is not yet implemented.

  • platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):
4:14 PM Changeset in webkit [86800] by jschuh@chromium.org
  • 4 edits
    21 adds in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium expectations update for SVG tests.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters: Added.
  • platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/dynamic-updates: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Added.
  • platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Added.
3:17 PM Changeset in webkit [86799] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-18 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Don't create empty file objects if no download file path is specified.
​https://bugs.webkit.org/show_bug.cgi?id=60798

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::setDownloadFilePath):
3:10 PM Changeset in webkit [86798] by yi.4.shen@nokia.com
  • 7 edits in trunk

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Unskip the fast/events/onsearch-enter.html test.

  • platform/qt/Skipped:

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Fill the missing key text for the EnterKey event.

Tests: fast/events/onsearch-enter.html

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent):

2011-05-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
​https://bugs.webkit.org/show_bug.cgi?id=33179

Remove the implementation of the handleInputMethodKeydown, which introduces
a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Add more tests.
3:04 PM Changeset in webkit [86797] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

  • Platform/unix/EnvironmentUtilities.cpp: Remove an unnecessary #include, as reviewed.
3:03 PM Changeset in webkit [86796] by Lucas Forschler
  • 21 edits
    1 delete in tags/Safari-534.36/Source

rollout r86699.

2:58 PM Changeset in webkit [86795] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:54 PM Changeset in webkit [86794] by Lucas Forschler
  • 1 copy in tags/Safari-534.36

New tag.

2:47 PM Changeset in webkit [86793] by timothy@apple.com
  • 12 edits in trunk/Source

Update the the context menu to reflect the system search provider on Mac.

<rdar://problem/9198419>

Reviewed by Sam Weinig.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
create the string.

  • platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
create the web search context menu title.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle): Add a FIXME about using NSPerformService on Mac.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

2:46 PM Changeset in webkit [86792] by beidson@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

<rdar://problem/9457633> and ​https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

If the WebProcess or PluginProcess forks, it shouldn't pass WebKit2 shims along to the new process
in the DYLD_INSERT_LIBRARIES environment variable.

Add Environment Utilities helper to strip unwanted values from an environment variable:

  • Platform/unix/EnvironmentUtilities.cpp: Added.

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):

  • Platform/unix/EnvironmentUtilities.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Strip PluginProcessShim.dylib from DYLD_INSERT_LIBRARIES:

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

Strip WebProcessShim.dylib from DYLD_INSERT_LIBRARIES:

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Unprotect SnowLeopard now that it will behave and not spawn processes trying to use WebKit2 shims:

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

2:40 PM Changeset in webkit [86791] by rwlbuis@webkit.org
  • 4 edits
    6 adds in trunk

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Change <marker> renderer creation behaviour to always create the renderer. This fixes
the problem that no marker is rendered when display=none is set on the <marker>. The
specification states that display=none should have no influence on <marker> usage:
"The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
elements are available for referencing even when the ‘display’ property on the ‘marker’
element or any of its ancestors is set to none."

Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg

svg/custom/painting-marker-07-f-inherit.svg

  • svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::rendererIsNeeded):

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
  • svg/custom/painting-marker-07-f-inherit.svg: Added.
2:26 PM Changeset in webkit [86790] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-18 Alexis Menard <​alexis.menard@openbossa.org>, Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=60760

This test creates an hidden video element and make sure the loading works.

  • http/tests/media/media-can-load-when-hidden-expected.txt: Added.
  • http/tests/media/media-can-load-when-hidden.html: Added.

2011-05-18 Alexis Menard <​alexis.menard@openbossa.org>, Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=60760

WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
that uses the ResourceHandle API to request data and pass it down. For
our builds it is absolutely essential that we have a NetworkingContext
available there, in order to get access to the QNetworkAccessManager.
No access means we basically cannot load the video. The WebSource gains
access to the NetworkingContext through a WebCore::Frame pointer it has.

MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
the WebCore::Frame to the WebKitWebSource in
mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
frameView() accessor to access the frame. However the frameView() member
is only set through the render tree's RenderVideo, which is rather unreliable
given that some sites create "fake" video tags initially that only become
visible later (or never).

A more reliable way is to simply use the document of the MediaPlayerClient,
which is provided at constructor time.

Test: http/tests/media/media-can-load-when-hidden.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
2:23 PM Changeset in webkit [86789] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Fixing previous Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [86788] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-18 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Check HUD texture reserve status before using texture
​https://bugs.webkit.org/show_bug.cgi?id=61082

This only changes behavior behind a flag, so shouldn't impact any tests.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
2:04 PM Changeset in webkit [86787] by abarth@webkit.org
  • 2 edits
    15 deletes in trunk/Source/JavaScriptCore

2011-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Delete WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=61084

It's been a year and we've failed to complete this project. It's time
to throw in the towel.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/url: Removed.
  • wtf/url/api: Removed.
  • wtf/url/api/ParsedURL.cpp: Removed.
  • wtf/url/api/ParsedURL.h: Removed.
  • wtf/url/api/URLString.h: Removed.
  • wtf/url/src: Removed.
  • wtf/url/src/RawURLBuffer.h: Removed.
  • wtf/url/src/URLBuffer.h: Removed.
  • wtf/url/src/URLCharacterTypes.cpp: Removed.
  • wtf/url/src/URLCharacterTypes.h: Removed.
  • wtf/url/src/URLComponent.h: Removed.
  • wtf/url/src/URLEscape.cpp: Removed.
  • wtf/url/src/URLEscape.h: Removed.
  • wtf/url/src/URLParser.h: Removed.
  • wtf/url/src/URLQueryCanonicalizer.h: Removed.
  • wtf/url/src/URLSegments.cpp: Removed.
  • wtf/url/src/URLSegments.h: Removed.
  • wtf/url/wtfurl.gyp: Removed.
1:51 PM Changeset in webkit [86786] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Another Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [86785] by oliver@apple.com
  • 16 edits in trunk/Source

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=61090

Remove the Structure-free JSGlobalObject constructor and instead always
pass the structure into the JSGlobalObject constructor.
Stop DebuggerActivation creating a new structure every time, and simply
use a single shared structure held by the GlobalData.

  • API/JSContextRef.cpp:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=61090

Rather than having Constructor objects create their structure
as part of initialisation, we now pass their expected structure
in as an argument. This required fixing the few custom Constructors
and the code generator.

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Pass the Constructor objects structure in as an argument
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:
1:09 PM Changeset in webkit [86784] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-18 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
12:54 PM Changeset in webkit [86783] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-18 Jon Lee <​jonlee@apple.com>

Reviewed by Simon Fraser.

Crash in injected bundle client
​https://bugs.webkit.org/show_bug.cgi?id=61086

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection): Check for existence of method in client prior to calling.
12:35 PM Changeset in webkit [86782] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Expand layout test for testing the coords of a click on a label element
​https://bugs.webkit.org/show_bug.cgi?id=61080

This expands the existing test to click on a label inside a scrolled element.

  • fast/events/simulated-click-coords-expected.txt:
  • fast/events/simulated-click-coords.html:
12:30 PM Changeset in webkit [86781] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Beth Dakin.

Tests that we do not crash when prematurely calling removeChild,
followed by destroy call on table caption.
​https://bugs.webkit.org/show_bug.cgi?id=61083

  • fast/table/table-captions-child-visible-crash-expected.txt: Added.
  • fast/table/table-captions-child-visible-crash.html: Added.

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Beth Dakin.

Remove removeChild on table caption since destroy call
already does that.
​https://bugs.webkit.org/show_bug.cgi?id=61083

Test: fast/table/table-captions-child-visible-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcCaption):
11:42 AM Changeset in webkit [86780] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-18 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make action_derivedsourcesallinone.py quiet
​https://bugs.webkit.org/show_bug.cgi?id=61081

In gyp, it's the responsibility of the build system to print what actions are doing;
for example, the compile command is generally silent, while the build system prints
"compiling".

Make this program behave like a compiler: silent on success.

  • WebCore.gyp/scripts/action_derivedsourcesallinone.py: delete a print statement.
11:28 AM Changeset in webkit [86779] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam Roben.

Disable gc validation in release builds
​https://bugs.webkit.org/show_bug.cgi?id=60680

Add back the NDEBUG check

  • wtf/Platform.h:
11:20 AM Changeset in webkit [86778] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()

Reviewed by Joseph Pecoraro.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Use
toHTTPPipeliningPriority() to convert arguments passed to
wkSetHTTPPipeliningMaximumPriority() and
wkSetHTTPPipeliningMinimumFastLanePriority().

11:15 AM Changeset in webkit [86777] by commit-queue@webkit.org
  • 3 edits
    6 deletes in trunk/LayoutTests

2011-05-18 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

editing/style/apply-through-end-of-document.html is supposed to be dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=61077

  • editing/style/apply-through-end-of-document-expected.txt:
  • editing/style/apply-through-end-of-document.html:
  • platform/chromium-linux/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/chromium-win/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/chromium-win/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/mac-leopard/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/mac/editing/style/apply-through-end-of-document-expected.png: Removed.
11:00 AM How to not mess up GC created by oliver@apple.com
work in progress
10:47 AM Changeset in webkit [86776] by arv@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This tests that clicking on a label for an input generates a click event on the input
with the same coordinates as the original click.

  • fast/events/simulated-click-coords-expected.txt: Added.
  • fast/events/simulated-click-coords.html: Added.

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
is a mouse event.

This makes us match Firefox and IE.

Test: fast/events/simulated-click-coords.html

  • dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
10:33 AM Changeset in webkit [86775] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Sorted XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
10:19 AM WikiStart edited by oliver@apple.com
(diff)
10:19 AM WikiStart edited by oliver@apple.com
(diff)
10:15 AM Changeset in webkit [86774] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Non-color CSS property values can get a color-picker
​https://bugs.webkit.org/show_bug.cgi?id=61056

  • inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty): (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
10:01 AM Changeset in webkit [86773] by apavlov@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 86768 - 2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
  • inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7034027

9:58 AM WikiStart edited by oliver@apple.com
(diff)
9:43 AM QtWebKit edited by Ademar Reis
(diff)
9:43 AM QtWebKit edited by Ademar Reis
(diff)
9:42 AM QtWebKit edited by Ademar Reis
(diff)
9:40 AM QtWebKitFeaturePlanning edited by Ademar Reis
(diff)
9:12 AM Changeset in webkit [86772] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-18 Pratik Solanki <​psolanki@apple.com>

Reviewed by Dan Bernstein.

Don't use DEFINE_STATIC_LOCAL with an unsigned
​https://bugs.webkit.org/show_bug.cgi?id=61026

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here.
9:08 AM Changeset in webkit [86771] by rwlbuis@webkit.org
  • 3 edits
    8 adds in trunk

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
​https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

  • css/CSSStyleSelector.cpp: (WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard): (WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard): (WebCore::isAcceptableForSVGElement): (WebCore::CSSStyleSelector::applyProperty):

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
​https://bugs.webkit.org/show_bug.cgi?id=45561

  • svg/custom/display-table-caption-foreignObject-expected.txt: Added.
  • svg/custom/display-table-caption-foreignObject.svg: Added.
  • svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Added.
  • svg/custom/display-table-caption-inherit-foreignObject.xhtml: Added.
  • svg/custom/display-table-caption-inherit-text-expected.txt: Added.
  • svg/custom/display-table-caption-inherit-text.xhtml: Added.
  • svg/custom/display-table-caption-text-expected.txt: Added.
  • svg/custom/display-table-caption-text.svg: Added.
9:02 AM Changeset in webkit [86770] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new test that fails due to unimplemented WTR features

  • platform/mac-wk2/Skipped: Added http/tests/loading/nested_bad_objects.php.
8:58 AM Changeset in webkit [86769] by Adam Roben
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove mac-wk2 expected failure results for a plugins test that I fixed in r86456

Fixes <​http://webkit.org/b/57456> <rdar://problem/9209331>
plugins/embed-prefers-plugins-for-images.html failing on SnowLeopard Intel Release (WebKit2
Tests)

  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed. We don't

need this extra passing result now that mac-wk2's failing result is gone.

8:52 AM Changeset in webkit [86768] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
  • inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
​https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):
8:47 AM Changeset in webkit [86767] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-05-18 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
​https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
8:38 AM Changeset in webkit [86766] by Adam Roben
  • 2 edits
    8 adds in trunk/Tools

Add a new page to build.webkit.org to help find when tests started failing

The page is accessible at <​http://build.webkit.org/TestFailures/>. It is pretty minimalist
right now, but already shows some useful information. It's somewhat similar to webkit-patch
failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
little more convenient than either of them, though, because it's all done in the browser
(and thus it's easy to go directly to the relevant test results).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.

(Buildbot): This class represents a Buildbot server.
(Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Buildbot.prototype.builderNamed): Returns a Builder with the given name.
(Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
callback.
(Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
be implemented by a derived class that understands this server's build naming scheme.
(Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.

(Builder): This class represents one builder on the buildbot.
(Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
information about a particular test failure.
(Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
information about when tests started failing.
(Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
(Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
callback.
(Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
extracts all the failing tests listed in it, passing them to the callback.
(Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
build, merges them into the build history, and calls the callback telling it whether the
next build should be fetched to provide more information.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Added. Just some simple styles.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.

(createDefinitionList): Takes an array of pairs and turns them into a DL element.
(getResource): Wrapper around XMLHttpRequest.
(Array.prototype.findFirst): Finds the first element matching the given predicate and
returns it.
(Array.prototype.last): Returns the last element of the array.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.

(ViewController): This class contains the main logic for displaying the page.
(ViewController.loaded): Just calls through to parseHash.
(ViewController.parseHash): Either starts analyzing failures on a particular builder, or
shows the list of all testers so one can be chosen. This function is called when the page
loads and whenever we get a hashchange event.
(ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
as it is fetched. The display ends up grouping tests by when they started failing.
(ViewController._displayTesters): Gets the list of testers and displays it.

(ViewController._domForBuildName):
(ViewController._domForFailedTest):
Helper functions to create descriptions and links for a particular build or failed test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.

(WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
(WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just

loads all the files and sets up a ViewController, which does the rest.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new

page.

8:35 AM Changeset in webkit [86765] by Nikolas Zimmermann
  • 75 edits
    49 adds in trunk

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
​https://bugs.webkit.org/show_bug.cgi?id=10749

Add tests for all elements using SVGAnimatedEnumeration in the SVG DOM API.

  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Update result, progression.
  • svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-expected.txt:
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGClipPathElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEColorMatrixElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration.js:
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: (executeTest):
  • svg/filters/feBlend-invalid-mode-expected.txt:
  • svg/filters/feComponentTransfer-style-crash-expected.txt:
  • svg/filters/feComponentTransfer-style-crash.xhtml:
  • svg/filters/feDisplacementMap-crash-test-expected.txt:
  • svg/filters/feDisplacementMap-crash-test.xhtml:

2011-05-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
​https://bugs.webkit.org/show_bug.cgi?id=10749

DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
(Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)

Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
Use the new SVGPropertyTraits everywhere in svg/.

This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
Example: <clipPath clipPathUnits="objectBoundingBox">
myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
We're now properly converting the enum values to strings.

Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:

  • SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
  • SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.

Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html

svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html

Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.

  • GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
  • platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
  • platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Ditto.
  • rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now. (WebCore::RenderSVGResourceClipper::clipPathUnits):
  • rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now. (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits):
  • rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform). (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h: Ditto.
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  • rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now. (WebCore::RenderSVGResourceMarker::markerUnits):
  • rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now. (WebCore::RenderSVGResourceMasker::maskUnits): (WebCore::RenderSVGResourceMasker::maskContentUnits):
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication. (WebCore::writeCommonGradientProperties):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto. (WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
  • svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType. (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
  • svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
  • svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
  • svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.

Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.

  • svg/SVGAnimatedInteger.idl: Ditto.
  • svg/SVGAnimatedNumber.idl: Ditto.
  • svg/SVGAnimatedString.idl: Ditto.
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec. (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.

It's not possible anymore for these values to go out of range.

  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()). (WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEBlendElement::build): Ditto.
  • svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()). (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.. (WebCore::SVGFEColorMatrixElement::build): Ditto.
  • svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()). (WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFECompositeElement::build): Ditto.
  • svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
  • svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()). (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync. (WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()). (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now. (WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()). (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEMorphologyElement::build): Ditto.
  • svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()). (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFETurbulenceElement::build): Ditto.
  • svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
  • svg/SVGFilterElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec. (WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
  • svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special

as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.

(WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.

  • svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations. (WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'. (WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto. (WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGPatternElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
  • svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
  • svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
  • svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.

SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
the enums go out of range anymore (which lead to security bugs in the past).

(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param. (WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):
8:31 AM Changeset in webkit [86764] by kinuko@chromium.org
  • 17 edits
    4 adds in trunk

2011-05-18 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59681

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/script-tests/storageinfo-request-quota.js: Added.
  • storage/storageinfo-request-quota-expected.txt: Added.
  • storage/storageinfo-request-quota.html: Added.

2011-05-18 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59681

Test: storage/storageinfo-request-quota.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/StorageInfo.idl: Added requestQuota().
  • storage/StorageInfoQuotaCallback.idl: Added.
8:20 AM Changeset in webkit [86763] by reni@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-18 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FEGaussianBlur
​https://bugs.webkit.org/show_bug.cgi?id=61049

The Gaussian blur filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is about 15% on dual-core machines.

Developed in cooperation with Gabor Loki and Zoltan Herczeg.

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply):
  • platform/graphics/filters/FEGaussianBlur.h:
8:06 AM Changeset in webkit [86762] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip two failing tests.

  • platform/qt-wk2/Skipped:
8:04 AM Changeset in webkit [86761] by andreas.kling@nokia.com
  • 3 edits
    1 add in trunk/Source/WebKit2

2011-05-18 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Don't lie about supporting accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=61054

Until we have an implementation of LayerTreeHost, we shouldn't lie about it.

  • WebKit2.pro:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp: Added. (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
7:31 AM Changeset in webkit [86760] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make parentId for frame optional.
​https://bugs.webkit.org/show_bug.cgi?id=61032

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFrame):
7:27 AM Changeset in webkit [86759] by loki@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-18 Gabor Loki <​loki@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FELighting
​https://bugs.webkit.org/show_bug.cgi?id=61048

The lighting filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 10-20% on dual-core machines.

Developed in cooperation with Zoltan Herczeg.

  • platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericPaint): (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric):
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker):
  • platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):
7:12 AM Changeset in webkit [86758] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-18 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
​https://bugs.webkit.org/show_bug.cgi?id=60984

The code for converting objects to QVariantMap was causing exception,
that was "leaking" to the next evaluation. One situation was reading
the property 'localStorage' when we do not have a proper security
origin, which throws a SECURITY_ERR.

Now, we will simply not include on the QVariantMap those properties,
and make sure that we clean the exception if necessary.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariantMap): Extracted function that performs conversion from JSObject to a QVariantMap. This functions makes sure that exception is clean after its execution.

(JSC::Bindings::convertValueToQVariant):
Use the previous function. Add a comment explaining the choice of distance value.

7:11 AM Changeset in webkit [86757] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: scripts panel file selector element doesn't track keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=61047

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
7:01 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
6:50 AM Changeset in webkit [86756] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
​https://bugs.webkit.org/show_bug.cgi?id=60900

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h: (WebCore::ScriptDebugListener::Script::Script):
6:42 AM Changeset in webkit [86755] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

Remove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html

  • platform/mac-wk2/Skipped:
6:32 AM Changeset in webkit [86754] by apavlov@chromium.org
  • 6 edits
    1 copy in trunk

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
​https://bugs.webkit.org/show_bug.cgi?id=60966

  • inspector/styles/resources/styles-new-API-1.css:
  • inspector/styles/resources/styles-new-API-2.css: Copied from LayoutTests/inspector/styles/resources/styles-new-API-1.css. (@page): (@page :first): (#absent-id): (@font-face): (body):
  • inspector/styles/styles-new-API-expected.txt:

2011-05-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
​https://bugs.webkit.org/show_bug.cgi?id=60966

Imported stylesheets didn't use to be returned by InspectorCSSAgent.

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets): (WebCore::InspectorCSSAgent::collectStyleSheets):
  • inspector/InspectorCSSAgent.h:
5:56 AM Changeset in webkit [86753] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

Add fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
eventSender.keyDown is unimplemented.

Reviewed by Csaba Osztrogonác.

  • platform/mac-wk2/Skipped:
5:04 AM Changeset in webkit [86752] by pfeldman@chromium.org
  • 18 edits in trunk

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
​https://bugs.webkit.org/show_bug.cgi?id=61028

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
4:33 AM Changeset in webkit [86751] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

2011-05-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86747.
​http://trac.webkit.org/changeset/86747
​https://bugs.webkit.org/show_bug.cgi?id=61039

Breaks JSC debugger tests. (Requested by pfeldman on #webkit).

  • inspector/InjectedScriptSource.js: ():
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
4:03 AM Changeset in webkit [86750] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-18 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Removed duplcate entries added by r86749

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [86749] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-18 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Since Chromium r85744, tests for <details> element pass on Mac and TEXT mismatch on Linux.

  • platform/chromium/test_expectations.txt:
3:45 AM Changeset in webkit [86748] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

Tests that we do not crash when trying to access a removed
smil element in animated elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

  • svg/animations/smil-element-not-removed-crash-expected.txt: Added.
  • svg/animations/smil-element-not-removed-crash.html: Added.

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

Test: svg/animations/smil-element-not-removed-crash.html

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::~SVGSMILElement):
2:48 AM Changeset in webkit [86747] by pfeldman@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
​https://bugs.webkit.org/show_bug.cgi?id=61028

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
2:46 AM Changeset in webkit [86746] by mnaganov@chromium.org
  • 4 edits in trunk/Source

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
​https://bugs.webkit.org/show_bug.cgi?id=60286

  • inspector/front-end/ProfilesPanel.js:

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
​https://bugs.webkit.org/show_bug.cgi?id=60286

  • src/js/DevTools.js: ():
2:45 AM Changeset in webkit [86745] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-18 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
​https://bugs.webkit.org/show_bug.cgi?id=60971

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showAnchorLocation.): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  • inspector/front-end/inspector.js: (WebInspector._showAnchorLocation):
2:33 AM Changeset in webkit [86744] by tkent@chromium.org
  • 6 edits in trunk

2011-05-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
​https://bugs.webkit.org/show_bug.cgi?id=61021

Add test cases for the bug.

  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:

2011-05-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
​https://bugs.webkit.org/show_bug.cgi?id=61021

We missed updating validity in case that SelectElement::defaultEventHandler
update selections. So, SelectElement::setSelectedIndex() updates validity.

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Remove unnecessary setNeedsValidityCheck() call. SelectElement::setSlectedIndex() calls it. (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
2:31 AM Changeset in webkit [86743] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Make retaining paths list of the Detailed
heap snapshots view resizable.
​https://bugs.webkit.org/show_bug.cgi?id=60960

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.resize): (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
  • inspector/front-end/heapProfiler.css:
2:10 AM Changeset in webkit [86742] by commit-queue@webkit.org
  • 8 edits in trunk

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

  • platform/qt/Skipped: Unskip fast/forms/onchange-setvalueforuser.html

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setValueForUser):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-18 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
​https://bugs.webkit.org/show_bug.cgi?id=60956

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:38 AM Changeset in webkit [86741] by jer.noble@apple.com
  • 5 edits
    4 adds in trunk

2011-05-16 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60943

  • fullscreen/full-screen-keyboard-disabled-expected.txt: Added.
  • fullscreen/full-screen-keyboard-disabled.html: Added.
  • fullscreen/full-screen-keyboard-enabled-expected.txt: Added.
  • fullscreen/full-screen-keyboard-enabled.html: Added.

2011-05-16 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60943

Tests: fullscreen/full-screen-keyboard-disabled.html

fullscreen/full-screen-keyboard-enabled.html

  • page/EventHandler.cpp: (WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added. Implements the

list of allowed keyboard events in the proposed API.

(WebCore::EventHandler::keyEvent): Discard events which are not allowed in

full-screen mode.

  • page/EventHandler.h:
12:34 AM Changeset in webkit [86740] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

2011-05-18 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix build break.

  • Source/cmake/WebKitMacros.cmake: Add -i option in order to include Lookup.h
12:19 AM Changeset in webkit [86739] by Nikolas Zimmermann
  • 11 edits in trunk/Source/WebCore

-2011-05-17 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor TextRun creation
​https://bugs.webkit.org/show_bug.cgi?id=60255

Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
the catch-it-all constructor, these helper functions are introduced, which hide the details of
creating a TextRun.

Furthermore it will be used to remove the platform layering violation, that TextRun stores
RenderObject pointers for the sake of SVG Fonts support, see bug 60254.

No change in functionaliy, no new tests.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
  • rendering/RenderBlock.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
Note: See TracTimeline for information about the timeline view.