Context Navigation

(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).

3:29 PM Changeset in webkit [87045] by sullivan@apple.com

2 edits in branches/safari-534-branch/Source/WebKit2

Rolled out <http://trac.webkit.org/changeset/87030>, which I accidentally checked into
the branch instead of trunk.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):

3:18 PM Changeset in webkit [87044] by yi.4.shen@nokia.com

3 edits
24 adds in trunk/Source/WebKit/qt

2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin with html5 video player.

symbian/platformplugin/HTML5VideoPlugin.cpp: Added. (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler): (HTML5FullScreenVideoHandler::enterFullScreen): (HTML5FullScreenVideoHandler::exitFullScreen): (HTML5FullScreenVideoHandler::onPlayerError): (HTML5FullScreenVideoHandler::onPlayerStateChanged): (HTML5FullScreenVideoHandler::onMediaStatusChanged): (HTML5VideoPlugin::supportsExtension): (HTML5VideoPlugin::createExtension):
symbian/platformplugin/HTML5VideoPlugin.h: Added. (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (HTML5FullScreenVideoHandler::isFullScreen): (HTML5FullScreenVideoHandler::updateScreenRect):
symbian/platformplugin/HTML5VideoWidget.cpp: Added. (HTML5VideoWidget::HTML5VideoWidget): (HTML5VideoWidget::setDuration): (HTML5VideoWidget::mousePressEvent): (HTML5VideoWidget::onPlayerStopped): (HTML5VideoWidget::onPlayerError): (HTML5VideoWidget::onEndOfMedia): (HTML5VideoWidget::onBufferingMedia): (HTML5VideoWidget::onBufferedMedia): (HTML5VideoWidget::onControlClicked): (HTML5VideoWidget::onPositionChanged): (HTML5VideoWidget::onSliderMoved): (HTML5VideoWidget::onCloseClicked): (HTML5VideoWidget::showFullScreen): (HTML5VideoWidget::setVolume):
symbian/platformplugin/HTML5VideoWidget.h: Added.
symbian/platformplugin/OverlayWidget.cpp: Added. (OverlayWidget::OverlayWidget): (OverlayWidget::~OverlayWidget): (OverlayWidget::setDuration): (OverlayWidget::setPosition): (OverlayWidget::setVolume): (OverlayWidget::mousePressEvent): (OverlayWidget::onPlayerStopped): (OverlayWidget::onPlayerError): (OverlayWidget::onEndOfMedia): (OverlayWidget::onBufferingMedia): (OverlayWidget::onBufferedMedia): (OverlayWidget::timeToString): (OverlayWidget::applyStyleSheet): (OverlayWidget::onControlClicked): (OverlayWidget::onSliderMoved): (OverlayWidget::onSoundClicked): (OverlayWidget::onCloseClicked): (OverlayWidget::onVolumeSliderReleased): (OverlayWidget::onVolumeSliderMoved): (OverlayWidget::onTimerTimeout): (OverlayWidget::showFullScreen):
symbian/platformplugin/OverlayWidget.h: Added.
symbian/platformplugin/PlayerButton.cpp: Added. (PlayerButton::PlayerButton): (PlayerButton::event):
symbian/platformplugin/PlayerButton.h: Added.
symbian/platformplugin/PlayerLabel.cpp: Added. (PlayerLabel::PlayerLabel): (PlayerLabel::onPlayerError): (PlayerLabel::startBufferingAnimation): (PlayerLabel::stopBufferingAnimation): (PlayerLabel::onAnimationTimeout):
symbian/platformplugin/PlayerLabel.h: Added.
symbian/platformplugin/WebPlugin.cpp: (WebPlugin::createExtension):
symbian/platformplugin/images: Added.
symbian/platformplugin/images/button_cannotplay.png: Added.
symbian/platformplugin/images/button_close.png: Added.
symbian/platformplugin/images/button_pause.png: Added.
symbian/platformplugin/images/button_play.png: Added.
symbian/platformplugin/images/button_sound_off.png: Added.
symbian/platformplugin/images/button_sound_on.png: Added.
symbian/platformplugin/images/loading_buffering_1.png: Added.
symbian/platformplugin/images/loading_buffering_2.png: Added.
symbian/platformplugin/images/loading_buffering_3.png: Added.
symbian/platformplugin/images/loading_buffering_4.png: Added.
symbian/platformplugin/platformplugin.pro:
symbian/platformplugin/platformplugin.qrc: Added.
symbian/platformplugin/qss: Added.
symbian/platformplugin/qss/OverlayWidget.qss: Added.

12:33 PM Changeset in webkit [87043] by robert@webkit.org

7 edits
2 deletes in trunk

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

platform/qt/Skipped: Unskip fast/encoding/mailto-always-utf-8.html
platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Removed.
platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Removed.

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT

https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant, so remove it.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate):

11:52 AM Changeset in webkit [87042] by Lucas Forschler

5 edits in branches/safari-534-branch/Source

Versioning.

11:51 AM Changeset in webkit [87041] by Lucas Forschler

1 copy in tags/Safari-534.38

New tag.

11:08 AM Changeset in webkit [87040] by Patrick Gansterer

2 edits in trunk/Tools

2011-05-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use double quotes for filename arguments
https://bugs.webkit.org/show_bug.cgi?id=61250

Windows does not support single quotes on the command line,
so replace them with double quotes.

Scripts/prepare-ChangeLog:

10:35 AM Changeset in webkit [87039] by Lucas Forschler

2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r86972.

10:33 AM Changeset in webkit [87038] by Lucas Forschler

7 edits in branches/safari-534-branch/Source/WebKit2

Merge r86967.

10:31 AM Changeset in webkit [87037] by Lucas Forschler

10 edits in branches/safari-534-branch/Source

Merge r86956.

10:28 AM Changeset in webkit [87036] by Lucas Forschler

5 edits in branches/safari-534-branch/Source

Merge r86924.

10:26 AM Changeset in webkit [87035] by Lucas Forschler

3 edits
2 copies in branches/safari-534-branch

Merge r86904.

10:23 AM Changeset in webkit [87034] by Lucas Forschler

3 edits in branches/safari-534-branch/Source/WebKit2

Merge r86895.

10:16 AM Changeset in webkit [87033] by Lucas Forschler

2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r86779.

9:56 AM Changeset in webkit [87032] by commit-queue@webkit.org

8 edits in trunk/Source

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Tests are in WebKit/qt/tests/hybridPixmap

bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToImageDataMethod::name): (JSC::Bindings::QtPixmapToImageDataMethod::invoke): (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels): (JSC::Bindings::QtPixmapClass::methodsNamed): (JSC::Bindings::QtPixmapInstance::getPropertyNames): Add toImageData() to Qt Bridge, alternative to assignToHTMLImageElement().

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

docs/qtwebkit-bridge.qdoc:
docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): Document Qt bridge toImageData() feature.
tests/hybridPixmap/test.html:
tests/hybridPixmap/widget.cpp: (Widget::Widget): (Widget::abcImage):
tests/hybridPixmap/widget.h: Add tests for Qt bridge toImageData() feature.

9:48 AM Changeset in webkit [87031] by jeffm@apple.com

2 edits in trunk/Source/WebKit2

2011-05-22 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249

UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().

9:27 AM Changeset in webkit [87030] by sullivan@apple.com

2 edits in branches/safari-534-branch/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed

Reviewed by Darin Adler.

UIProcess/WebPageProxy.cpp:

8:56 AM Changeset in webkit [87029] by dominicc@chromium.org

4 edits in trunk

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

platform/mac/Skipped: Unskip shadow tests.

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

dom/Element.cpp: (WebCore::Element::removeShadowRoot): Call detach if attached.

3:13 AM Changeset in webkit [87028] by krit@webkit.org

6 edits in trunk/Source/WebCore

2011-05-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176

General clean-up.

Don't resolve style manually, instead ask the RenderObject for its style.

Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.

No new tests needed. No change of behavior.

svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::build):
svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
svg/svgattrs.in:

May 21, 2011:

11:58 PM Changeset in webkit [87027] by krit@webkit.org

3 edits
4 adds in trunk

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
if none of its childs caught the event. This is the case for all pointer-events other than 'none'.

Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml

svg/custom/pointer-events-on-svg-without-pointer.xhtml

rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

Check that an embedded SVG element doesn't have a pointer, if pointer-events is set to 'none'.

svg/custom/pointer-events-on-svg-with-pointer-expected.txt: Added.
svg/custom/pointer-events-on-svg-with-pointer.xhtml: Added.
svg/custom/pointer-events-on-svg-without-pointer-expected.txt: Added.
svg/custom/pointer-events-on-svg-without-pointer.xhtml: Added.

9:44 PM Changeset in webkit [87026] by mitz@apple.com

3 edits
3 adds in trunk

<rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/block/positioning/start-ignoring-before.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
whether to merge the first trailing space with the line break.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
character, account for trailing positioned objects that occurred after the midpoint by calling
updateMidpointsForTrailingBoxes(), which adds midpoints for them.

LayoutTests:

fast/block/positioning/start-ignoring-before-expected.png: Added.
fast/block/positioning/start-ignoring-before-expected.txt: Added.
fast/block/positioning/start-ignoring-before.html: Added.

8:08 PM Changeset in webkit [87025] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations exception for:
fast/css/custom-font-xheight.html

platform/chromium/test_expectations.txt:

5:43 PM Changeset in webkit [87024] by jschuh@chromium.org

3 edits
6 adds in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed

Chromium expectations updates.

platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:52 PM Changeset in webkit [87023] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

2011-05-21 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] WKStringCopyQString function is not exported
https://bugs.webkit.org/show_bug.cgi?id=59285

A few functions were declared twice but without the export macro.
On Symbian, the linking failed when trying to reference these functions.

UIProcess/API/qt/qgraphicswkview.h:

3:30 PM Changeset in webkit [87022] by jer.noble@apple.com

6 edits in trunk

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be

synchronous, so make sure to check whether the current element is
in the DOM before dispatching.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the

exit functions (was calling the enter functions).

1:15 PM Changeset in webkit [87021] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium SVG expectations update.

platform/chromium/test_expectations.txt:

12:24 PM Changeset in webkit [87020] by commit-queue@webkit.org

14 edits
2 adds in trunk

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

fast/dom/HTMLLinkElement/prerender-expected.txt: Added.
fast/dom/HTMLLinkElement/prerender.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

Test: fast/dom/HTMLLinkElement/prerender.html

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest):
loader/cache/CachedResourceLoader.h:
loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
platform/network/ResourceRequestBase.h:

8:30 AM Changeset in webkit [87019] by eae@chromium.org

5 edits in trunk/Source/WebCore

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderLineBoxList::hitTest to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61156

Change the RenderLineBoxList hit testing to use IntPoint and clean up the rect calculation.

Covered by existing tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestContents):
rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
rendering/RenderLineBoxList.h:

6:54 AM Changeset in webkit [87018] by eae@chromium.org

10 edits in trunk/Source/WebCore

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change HitTestResult to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61230

Covered by existing tests.

rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult):
rendering/HitTestResult.h: (WebCore::HitTestResult::isRectBasedTest):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

5:41 AM Changeset in webkit [87017] by tkent@chromium.org

4 edits in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[GTK] [Chromium] Update test results for r87014.
https://bugs.webkit.org/show_bug.cgi?id=54179

platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
platform/gtk/fast/forms/input-text-click-outside-expected.txt:
platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:

4:23 AM Changeset in webkit [87016] by tkent@chromium.org

4 edits in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[Qt] Update test results for r87014.

platform/qt/fast/events/context-no-deselect-expected.txt:
platform/qt/fast/forms/input-text-double-click-expected.txt:
platform/qt/fast/forms/textfield-outline-expected.txt:

4:04 AM Changeset in webkit [87015] by jochen@chromium.org

6 edits
1 add in trunk/Source

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ExtraData::~ExtraData): (WebCore::ResourceRequest::extraData): (WebCore::ResourceRequest::setExtraData):

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

WebKit.gypi:
public/WebURLRequest.h: (WebKit::WebURLRequest::ExtraData::~ExtraData):
src/WebURLRequest.cpp: (WebKit::WebURLRequest::extraData): (WebKit::WebURLRequest::setExtraData):
tests/WebURLRequestTest.cpp: Added. (WebKit::TestExtraData::TestExtraData): (WebKit::TestExtraData::~TestExtraData): (WebKit::TEST):

3:47 AM Changeset in webkit [87014] by tkent@chromium.org

206 edits in trunk

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Update test results because the shadow tree structure of <input> and
<textarea> is changed.

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-ligature-001-expected.txt:
editing/pasteboard/copy-in-password-field-expected.txt:
editing/selection/select-all-textarea-expected.txt:
fast/events/5056619-expected.txt:
fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:
platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
platform/chromium-win/editing/inserting/4960120-1-expected.txt:
platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
platform/chromium-win/editing/selection/4895428-3-expected.txt:
platform/chromium-win/editing/selection/4975120-expected.txt:
platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
platform/chromium-win/fast/events/autoscroll-expected.txt:
platform/chromium-win/fast/events/context-no-deselect-expected.txt:
platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
platform/chromium-win/fast/forms/search-rtl-expected.txt:
platform/chromium-win/fast/forms/search-zoomed-expected.txt:
platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
platform/chromium-win/fast/forms/textfield-outline-expected.txt:
platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
platform/chromium/test_expectations.txt:
platform/gtk/editing/inserting/4960120-1-expected.txt:
platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
platform/gtk/editing/selection/4895428-3-expected.txt:
platform/gtk/editing/selection/4975120-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
platform/gtk/fast/events/autoscroll-expected.txt:
platform/gtk/fast/events/context-no-deselect-expected.txt:
platform/gtk/fast/forms/input-appearance-focus-expected.txt:
platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
platform/gtk/fast/forms/input-appearance-selection-expected.txt:
platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/gtk/fast/forms/input-paste-undo-expected.txt:
platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
platform/gtk/fast/forms/input-text-click-inside-expected.txt:
platform/gtk/fast/forms/input-text-double-click-expected.txt:
platform/gtk/fast/forms/input-text-drag-down-expected.txt:
platform/gtk/fast/forms/input-text-option-delete-expected.txt:
platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
platform/gtk/fast/forms/search-rtl-expected.txt:
platform/gtk/fast/forms/search-transformed-expected.txt:
platform/gtk/fast/forms/search-zoomed-expected.txt:
platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
platform/gtk/fast/forms/textfield-outline-expected.txt:
platform/gtk/fast/forms/textfield-overflow-expected.txt:
platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
platform/mac/editing/inserting/4960120-1-expected.txt:
platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
platform/mac/editing/selection/4895428-3-expected.txt:
platform/mac/editing/selection/4975120-expected.txt:
platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
platform/mac/fast/events/autoscroll-expected.txt:
platform/mac/fast/events/context-no-deselect-expected.txt:
platform/mac/fast/forms/input-appearance-focus-expected.txt:
platform/mac/fast/forms/input-appearance-readonly-expected.txt:
platform/mac/fast/forms/input-appearance-selection-expected.txt:
platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/mac/fast/forms/input-paste-undo-expected.txt:
platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
platform/mac/fast/forms/input-text-click-inside-expected.txt:
platform/mac/fast/forms/input-text-double-click-expected.txt:
platform/mac/fast/forms/input-text-drag-down-expected.txt:
platform/mac/fast/forms/input-text-option-delete-expected.txt:
platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
platform/mac/fast/forms/plaintext-mode-2-expected.txt:
platform/mac/fast/forms/search-rtl-expected.txt:
platform/mac/fast/forms/search-transformed-expected.txt:
platform/mac/fast/forms/search-zoomed-expected.txt:
platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
platform/mac/fast/forms/textarea-scrollbar-expected.txt:
platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
platform/mac/fast/forms/textfield-focus-ring-expected.txt:
platform/mac/fast/forms/textfield-outline-expected.txt:
platform/mac/fast/forms/textfield-overflow-expected.txt:
platform/mac/fast/forms/validation-message-appearance-expected.txt:
platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
platform/qt/editing/inserting/4960120-1-expected.txt:
platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
platform/qt/editing/selection/4895428-3-expected.txt:
platform/qt/editing/selection/4975120-expected.txt:
platform/qt/fast/forms/input-appearance-focus-expected.txt:
platform/qt/fast/forms/input-appearance-readonly-expected.txt:
platform/qt/fast/forms/input-appearance-selection-expected.txt:
platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/qt/fast/forms/input-paste-undo-expected.txt:
platform/qt/fast/forms/input-text-click-inside-expected.txt:
platform/qt/fast/forms/input-text-option-delete-expected.txt:
platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
platform/qt/fast/forms/plaintext-mode-2-expected.txt:
platform/qt/fast/forms/search-rtl-expected.txt:
platform/qt/fast/forms/search-transformed-expected.txt:
platform/qt/fast/forms/search-zoomed-expected.txt:
platform/qt/fast/forms/textfield-overflow-expected.txt:
platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
platform/win/editing/inserting/4960120-1-expected.txt:
platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
platform/win/fast/forms/input-text-drag-down-expected.txt:
platform/win/fast/forms/textarea-scrollbar-expected.txt:
platform/win/fast/forms/textarea-scrolled-type-expected.txt:

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:

<textarea> --(shadow-connection)-- <div> -- ...

After the change:

<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...

The goals of this change are

Change to the new shadow DOM model, and
Minimize the patch size.

We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.

css/html.css: (input::-webkit-inner-spin-button): Add vertical-align in order to avoid the button affect the baseline. (input::-webkit-outer-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
dom/Element.cpp: (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a subclass of Element can override it. (WebCore::Element::isSpellCheckingEnabled): Handle ShadowRoot, which is not an Element.
dom/Node.cpp: Add utility functions for editing code. (WebCore::Node::nonBoundaryShadowTreeRootNode): (WebCore::Node::nonShadowBoundaryParentNode):
dom/Node.h: Declare them.
dom/Position.cpp:
- Add some assertions about ShadowRoot
- Replace parentNode() with nonShadowBoundaryParentNode()

Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

dom/Position.h: ditto. (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
editing/CompositeEditCommand.cpp: ditto. (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
editing/Editor.cpp: (WebCore::Editor::findString): ditto.
editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): ditto. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot. (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
editing/VisibleSelection.h: ditto.
editing/htmlediting.cpp: Add assertions. (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): Calls createShadowSubtree(). (WebCore::HTMLInputElement::createShadowSubtree): Calls InputType::createShadowSubTree(). (WebCore::HTMLInputElement::innerTextElement): Accessor of a shadow node. This is used by RenderTextControlSingleLine. (WebCore::HTMLInputElement::innerBlockElement): ditto. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto. (WebCore::HTMLInputElement::resultsButtonElement): ditto. (WebCore::HTMLInputElement::cancelButtonElement): ditto. (WebCore::HTMLInputElement::speechButtonElement): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Rebuild shadow trees because x-webkit-speech attribute affects it.
html/HTMLInputElement.h: Add declarations.
html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree(). (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
html/HTMLTextAreaElement.h: Declare createShadowSubtree().
html/InputType.h: Add default implementations of accessors. (WebCore::InputType::innerBlockElement): (WebCore::InputType::innerTextElement): (WebCore::InputType::innerSpinButtonElement): (WebCore::InputType::outerSpinButtonElement): (WebCore::InputType::resultsButtonElement): (WebCore::InputType::cancelButtonElement): (WebCore::InputType::speechButtonElement):
html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): Initializes new data members. (WebCore::SearchInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
html/SearchInputType.h: Add declarations. (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initializes new data members. (WebCore::TextFieldInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
html/TextFieldInputType.h: Add declarations. (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::outerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Remove shadowParent parameter. It is unnecessary because we switch to new shadow model. (WebCore::TextControlInnerElement::create): Change the parameter type to Document. (WebCore::TextControlInnerElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerBlockStyle(). (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): Remove shadowParent parameter. Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter. (WebCore::TextControlInnerTextElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerTextStyle(). (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldResultsButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createResultButtonStyle(). (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldCancelButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createCancelButtonStyle(). (WebCore::SearchFieldCancelButtonElement::detach): Update for the parent class change. (WebCore::SpinButtonElement::SpinButtonElement):
- Change the parameter type: shadowParent -> Document
- Add the inner flag
- Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SpinButtonElement::createInner): Introduce a new factory

method to hide a bool parameter of the constructor.

(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().

(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):

Change the parameter type: shadowParent -> Document
Inherit HTMLDivElement, not TextControlInnerElement.
Do not register this as a speech input listener here.

(WebCore::InputFieldSpeechButtonElement::create):

Update for the parameter change.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Do not handle click event if listener registration is not done.

(WebCore::InputFieldSpeechButtonElement::attach):

Register this as a speech input listener.

(WebCore::InputFieldSpeechButtonElement::detach):

Update for the parent class change.

(WebCore::InputFieldSpeechButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().

html/shadow/TextControlInnerElements.h: (WebCore::TextControlInnerTextElement::isMouseFocusable): Add this because the class is not a subclass of TextControllInnerElement. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto. (WebCore::SpinButtonElement::isMouseFocusable): ditto. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code. (WebCore::RenderTextControl::styleDidChange): innerTextElement can have no renderer. Explicitly call setNeedsStyleRecals() for innerTextElement. It is needed for LayoutTests/editing/selection/select-across-readonly-input-*.html. (WebCore::RenderTextControl::textBlockWidth): Member data -> function (WebCore::RenderTextControl::updateFromElement): ditto. (WebCore::RenderTextControl::setInnerTextValue): ditto. (WebCore::RenderTextControl::hasVisibleTextArea): ditto. (WebCore::RenderTextControl::isSelectableElement): ditto. (WebCore::RenderTextControl::selection): ditto. (WebCore::RenderTextControl::visiblePositionForIndex): ditto. (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::text): ditto. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::computeLogicalHeight): ditto. (WebCore::RenderTextControl::hitInnerTextElement): ditto. (WebCore::RenderTextControl::forwardEvent): ditto. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
rendering/RenderTextControl.h:
- Make m_innerText virtual function.
- Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::innerTextElement): Added. (WebCore::RenderTextControlMultiLine::updateFromElement): Remove unnecessary createSubtreeIfNeeded() call.
rendering/RenderTextControlMultiLine.h: Add a declaration.
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): Remove unnecessary code. (WebCore::RenderTextControlSingleLine::innerTextElement): Added. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto. (WebCore::RenderTextControlSingleLine::layout): ditto. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto. (WebCore::RenderTextControlSingleLine::updateFromElement): ditto, and remove unnecessary createSubtreeIfNeeded() call. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Data member -> function (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.

2:42 AM Changeset in webkit [87013] by crogers@google.com

3 edits in trunk/Source/WebCore

2011-05-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

AudioBufferSourceNode noteOff() method must respect scheduling time
https://bugs.webkit.org/show_bug.cgi?id=61226

No new tests since audio API is not yet implemented.

webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::finish): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff):
webaudio/AudioBufferSourceNode.h:

1:47 AM Changeset in webkit [87012] by tkent@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[Mac] Add expectation files for box-shadow-and-border-radius.html.

platform/mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed