Timeline
May 23, 2011:
- 11:39 PM Changeset in webkit [87130] by
-
- 5 edits2 deletes in trunk/Source/WebCore
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87118.
http://trac.webkit.org/changeset/87118
https://bugs.webkit.org/show_bug.cgi?id=61347
patch breaks layout tests
(https://bugs.webkit.org/show_bug.cgi?id=61342), and chromium
tests (browser_test MacTestCmdUp and ui_test Scrollbar)
(Requested by ukai_ on #webkit).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/ScrollAnimator.cpp:
- platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
- platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
- platform/graphics/IntPoint.h:
- 11:09 PM Changeset in webkit [87129] by
-
- 2 edits in branches/chromium/742/Source/WebCore/dom
Merge 87098 Build Fix
BUG=83012
Review URL: http://codereview.chromium.org/6992020
- 11:07 PM Changeset in webkit [87128] by
-
- 5 edits in trunk/Source/WebCore
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Adam Barth.
Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818
No new tests as this is just a removal.
- dom/ContainerNode.cpp:
- dom/ContainerNode.h:
- dom/Node.cpp:
- dom/Node.h: Removed the method now that the last instance got removed as part of the <input> shadow DOM refactoring.
- 10:28 PM Changeset in webkit [87127] by
-
- 2 edits in trunk/Source/WebCore
2011-05-23 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVGTextPositioning attributes are marked as NumberList instead of LengthList
https://bugs.webkit.org/show_bug.cgi?id=61301
SVGTextPositioningElement attributes x, y, dx and dy were marked as AnimatedNumberList
instead of AnimatedLengthList.
See specification http://www.w3.org/TR/SVG/text.html#InterfaceSVGTextPositioningElement
This does not affect the behavior, since we do not respect SVG units in SMIL animation yet.
No new tests added.
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
- 9:53 PM Changeset in webkit [87126] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61342
- platform/chromium/test_expectations.txt:
- 9:11 PM Changeset in webkit [87125] by
-
- 72 edits2 adds in trunk/Source/WebCore
2011-05-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] Pass NodeRenderingContext to Node::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=61114
- Extracted NodeRenderingContext from NodeRendererFactory, giving separate files to it.
- Changed signature rendererIsNeeded(RenderStyle*) to rendererIsNeeded(const NodeRenderingContext&). The style object is retrieved from NodeRendererFactory::style() This will allow rendererIsNeeded() to access contextual information like attaching phase and rendering-parent.
No new tests. No behaviour change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer): Pass unresolved NodeRenderingContext& to rendererIsNeeded() (WebCore::CharacterData::rendererIsNeeded):
- dom/CharacterData.h:
- dom/DOMAllInOne.cpp:
- dom/EditingText.cpp: (WebCore::EditingText::rendererIsNeeded):
- dom/EditingText.h:
- dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::rendererIsNeeded):
- dom/Node.h:
- dom/NodeRenderingContext.cpp: Added. (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::~NodeRenderingContext): (WebCore::NodeRenderingContext::setStyle): (WebCore::NodeRenderingContext::releaseStyle): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::hostChildrenChanged): (WebCore::NodeRenderingContext::shouldCreateRenderer): (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::NodeRendererFactory::createRendererIfNeeded):
- dom/NodeRenderingContext.h: Added. (WebCore::NodeRenderingContext::node): (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle): (WebCore::NodeRenderingContext::style): (WebCore::NodeRendererFactory::context):
- dom/ShadowContentElement.h:
- dom/Text.cpp:
- dom/Text.h:
- html/HTMLAppletElement.cpp:
- html/HTMLAppletElement.h:
- html/HTMLElement.cpp:
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
- html/HTMLEmbedElement.h:
- html/HTMLFormElement.cpp:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.cpp:
- html/HTMLFrameElement.h:
- html/HTMLFrameSetElement.cpp:
- html/HTMLFrameSetElement.h:
- html/HTMLIFrameElement.cpp:
- html/HTMLIFrameElement.h:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLNoScriptElement.h:
- html/HTMLObjectElement.cpp:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- html/shadow/DetailsMarkerControl.cpp:
- html/shadow/DetailsMarkerControl.h:
- html/shadow/MeterShadowElement.cpp:
- html/shadow/MeterShadowElement.h:
- html/shadow/ProgressShadowElement.cpp:
- html/shadow/ProgressShadowElement.h:
- svg/SVGDescElement.h:
- svg/SVGElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.h:
- svg/SVGGElement.cpp:
- svg/SVGGElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGHKernElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMissingGlyphElement.h:
- svg/SVGSVGElement.h:
- svg/SVGStyledElement.cpp:
- svg/SVGStyledElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp:
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp:
- svg/SVGTSpanElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
- 8:41 PM Changeset in webkit [87124] by
-
- 2 edits in trunk/Tools
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[nrwt] don't use NetworkTranslation when uploading results
https://bugs.webkit.org/show_bug.cgi?id=61315
This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).
- Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
- 8:31 PM Changeset in webkit [87123] by
-
- 12 edits in trunk/Source/WebCore
2011-05-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] attach() following detach() should be replaced with Node::reattach()
https://bugs.webkit.org/show_bug.cgi?id=61011
- Renamed forceReattach() to reattach()
- Introduced reattachIfAttached() as a variant.
No new tests. No behavior change.
- dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer):
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- dom/Node.h: (WebCore::Node::reattach): (WebCore::Node::reattachIfAttached):
- dom/Text.cpp: (WebCore::Text::recalcStyle):
- html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
- html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::recalcStyle):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- 8:26 PM Changeset in webkit [87122] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r87117.
When moving #defines out in to separate files I find that code is more likely to compile
when the new header file is actually #included.
- editing/SpellingCorrectionController.h:
- 7:25 PM Changeset in webkit [87121] by
-
- 31 edits7 adds in trunk
2011-05-23 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627
- css3/images/optimize-contrast-canvas-expected.checksum: Added.
- css3/images/optimize-contrast-canvas-expected.png: Added.
- css3/images/optimize-contrast-canvas-expected.txt: Added.
- css3/images/optimize-contrast-canvas.html: Added.
- css3/images/optimize-contrast-image-expected.checksum: Added.
- css3/images/optimize-contrast-image-expected.png: Added.
- css3/images/optimize-contrast-image-expected.txt: Added.
- css3/images/optimize-contrast-image.html: Added.
2011-05-23 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627
Tests: css3/images/optimize-contrast-canvas.html
css3/images/optimize-contrast-image.html
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- css/SVGCSSValueKeywords.in:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- platform/graphics/ImageRenderingMode.h: Added.
- rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
- rendering/style/RenderStyleConstants.h:
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
- rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
- 7:15 PM Changeset in webkit [87120] by
-
- 2 edits in trunk/LayoutTests
2011-05-23 Justin Schuh <jschuh@chromium.org>
Unreviewed.
Chromium multiple expectations update.
- platform/chromium/test_expectations.txt:
- 7:08 PM Changeset in webkit [87119] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Cap painting to 30fps on Windows
https://bugs.webkit.org/show_bug.cgi?id=61337
<rdar://problem/9213388>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::displayTimerFired):
- 7:04 PM Changeset in webkit [87118] by
-
- 5 edits2 adds in trunk/Source/WebCore
2011-05-23 Sailesh Agrawal <sail@chromium.org>
Reviewed by James Robinson.
Chromium Mac: Use ScrollAnimatorMac.mm for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753
No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/ScrollAnimator.cpp:
- platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
- platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
- platform/graphics/IntPoint.h:
- 6:58 PM Changeset in webkit [87117] by
-
- 8 edits in trunk/Source/WebCore
2011-05-22 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
https://bugs.webkit.org/show_bug.cgi?id=61181
- Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
- Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h
No new tests. Just renaming a compilation conditional.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
- editing/SpellingCorrectionController.cpp:
- editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
- loader/EmptyClients.h:
- page/EditorClient.h:
- platform/text/TextChecking.h:
- 6:56 PM Changeset in webkit [87116] by
-
- 2 edits in trunk/Tools
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by Dirk Pranke.
[chromium] fix the rebaseline tool to work with Linux GPU failures
https://bugs.webkit.org/show_bug.cgi?id=61312
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 6:52 PM Changeset in webkit [87115] by
-
- 5 edits in trunk
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329
patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329
patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId):
- 6:17 PM Changeset in webkit [87114] by
-
- 4 edits3 adds in trunk
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
<rdar://problem/9191214>
- fast/storage/storage-detached-iframe-expected.txt: Added.
- fast/storage/storage-detached-iframe.html: Added.
- platform/chromium/test_expectations.txt: Marked the test as CRASH on Chromium - Linux.
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
Test: fast/storage/storage-detached-iframe.html
Access of localStorage on a detached iframe was causing a crash because a detached
iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.
- storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): check that child->page() is non-null before accessing it.
- 6:02 PM Changeset in webkit [87113] by
-
- 5 edits in trunk/Source/WebKit2
2011-05-23 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION (r86990:86992): World leak when all windows closed
https://bugs.webkit.org/show_bug.cgi?id=61311
Three interlocking problems:
1) Calling [WKView fullScreenController] will create the controller if it doesn't all ready
exist, so move the closing code into WKView, where we can bail early if there isn't a
controller.
2) A retain-cycle exists between WKView and WKFullScreenWindowController. Make sure to break
the cycle explicitly by clearing the _fullScreenWindowController ivar when closing the
controller.
3) [NSWindowController close] was overridden without calling [super close]. Do that.
- UIProcess/API/mac/WKView.mm: (-[WKView closeFullScreenWindowController]): Moved here from WebFullScreenManagerProxyMac.mm.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Call [super close].
- UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate):
- 5:54 PM Changeset in webkit [87112] by
-
- 2 edits in trunk/Tools
Ignore generated .pyc files in a directory full of python code.
- Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
- 5:31 PM Changeset in webkit [87111] by
-
- 5 edits2 adds in trunk
VO doesn't work with HTML5 range (slider) input @step attribute
https://bugs.webkit.org/show_bug.cgi?id=61298
Reviewed by David Kilzer.
Source/WebCore:
Test: platform/mac/accessibility/range-alter-by-step.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::stepValueForRange):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::alterSliderValue):
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::stepValueForRange):
(WebCore::AccessibilityRenderObject::changeValueByStep):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- platform/mac/accessibility/range-alter-by-step-expected.txt: Added.
- platform/mac/accessibility/range-alter-by-step.html: Added.
- 5:29 PM Changeset in webkit [87110] by
-
- 7 edits in trunk/LayoutTests
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Rebaselines work better if we had the new lines at the end of each file.
- platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt:
- platform/gtk/fast/events/selectstart-by-drag-expected.txt:
- platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt:
- platform/qt/fast/events/selectstart-by-drag-expected.txt:
- platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt:
- platform/win/fast/events/selectstart-by-drag-expected.txt:
- 5:09 PM Changeset in webkit [87109] by
-
- 5 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=61306
Reviewed by Geoff Garen.
The begin characters optimization currently has issues (#61129),
and does not appear to still be a performance win. The prudent
next step seems to be to disable while we ascertain whether this
is still a useful performance optimization.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
- yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
- 4:53 PM Changeset in webkit [87108] by
-
- 4 edits in trunk/Source/ThirdParty/ANGLE
Part 1 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE
Merge ANGLE upstream commit r653 for Issue 154.
- src/compiler/PoolAlloc.h: Added newline to end of file.
- src/compiler/ShHandle.h: Ditto.
- src/libEGL/Display.cpp: Ditto.
- 4:52 PM Changeset in webkit [87107] by
-
- 7 edits in trunk/Tools
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sheriffbot should give more details about the failures in IRC
https://bugs.webkit.org/show_bug.cgi?id=61233
With this patch, sheriffbot will annonce the set of failing tests,
which might help folks triage the problem.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 4:50 PM Changeset in webkit [87106] by
-
- 4 edits in trunk/Source
2011-05-23 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297
The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.
No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.
- loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):
2011-05-23 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297
The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.
No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.
- public/WebURLRequest.h:
- 4:43 PM Changeset in webkit [87105] by
-
- 1 edit6 adds in trunk/LayoutTests
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Check in failing test expectations after r87096.
They are tracked by the bugs 61319, 61320, and 61322.
- platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- platform/gtk/fast/events/selectstart-by-drag-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-drag-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
- platform/win/fast/events/selectstart-by-drag-expected.txt: Added.
- 4:14 PM Changeset in webkit [87104] by
-
- 2 edits in trunk/LayoutTests
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Chromium test fix. On Chromium Windows, a space after a word is selected when you double click on the word.
- fast/events/selectstart-by-double-triple-clicks.html:
- 3:33 PM Changeset in webkit [87103] by
-
- 4 edits in trunk/Source
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
- wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.
- platform/graphics/FloatRect.cpp: (WebCore::enclosingIntRect):
- 3:22 PM Changeset in webkit [87102] by
-
- 16 edits in trunk/Source
2011-05-20 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220
No new tests, because DumpRenderTree does not currently "animate" the full-screen transition.
There are three issues animating video content to full screen which this patch is meant to
address:
1) The animation scales between the client sizes of the element before and after full-screen.
Because these sizes have different aspect ratios, the video appears "squished" for part of
the animation. Instead, we will animate between the content box sizes before and after full
screen which, in the case of video now and object-fit content in the future, will have the
same aspect ratio before and after full screen.
2) Now that we are animating the full-screen video element's content box, the black letterbox
bars appear above and below the video (depending on the video's aspect ratio) as soon as the
animation begins. This is extremely jarring, so set the background color to clear. The
full-screen renderer's background color will serve the same purpose (providing the letterbox
background) once the animation completes.
3) Now that the letterbox color is gone, the full screen controls can appear to float in thin
air beneath the video (again, depending on aspect ratio) during the animation, so to avoid
that effect and to make the animation consistent with the old webkitenterfullscreen()
animation, we will hide the controls during the animation by adding a new CSS pseudo class
-webkit-animating-full-screen-transition.
Added a new css pseudo-class: -webkit-animating-full-screen. During the transition animation, this
pseudo-class will be applied to the current full-screen element. Styles have been added to
fullscreenQuickTime.css to hide the video element's built-in controller during the full-screen
animation.
To accomplish this, the ivar tracking whether the full-screen animation is taking place has been moved
from the RenderFullScreen renderer, to the current full-screen Document. Because changing
isAnimatingFullScreen causes style changes, make sure to call recalcStyle on the full-screen element
after changing.
This extra transition caused assertions in HTMLFormControlElement::updateFromElementCallback. A
full-screen media control's renderer is disabled during the style recalculation when exiting full
screen. This assertion was exposed by the extra recalcStyle() issued during the exit transition, and
has been removed.
- WebCore.exp.in:
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Add support for new pseudo class -webkit-animate-full-screen-transition. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- css/fullscreen.css: (video:-webkit-full-screen): Set full screen video background color to clear.
- css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-panel): Set a default opacity transition. (video:-webkit-animating-full-screen::-webkit-media-controls-panel): Set the opacity to 0 and
disable the transition.
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitWillEnterFullScreenForElement): Call our new setAnimatingFullScreen function. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::isAnimatingFullScreen): Moved here from RenderFullScreen. (WebCore::Document::setAnimatingFullScreen): Ditto.
- dom/Document.h:
- html/HTMLFormControlElement.cpp: (WebCore::updateFromElementCallback): Use the Document's isAnimatingFullScreen function.
- page/FrameView.cpp: (WebCore::isDocumentRunningFullScreenAnimation): Ditto.
- rendering/RenderFullScreen.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
- rendering/style/RenderStyleConstants.h:
2011-05-20 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220
Instead of scaling between the client sizes of the full-screen element before and after
entering full-screen, scale between their content boxes. The difference is that the client
sizes can have different aspect ratios, and thus the animation can end up "squishing" the
content at one end of the animation. When animating between the two content box sizes, their
aspect ratios (for the case of video) are equal, so the animation will appear to scale
smoothly between the two states without "squishing" the content.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Set the destination frame
to be the content box of the current full screen element.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
- 3:15 PM Changeset in webkit [87101] by
-
- 6 edits in trunk/Source/WebCore
2011-05-23 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change RenderBlock hit testing to use IntPoint instead x,y pair
https://bugs.webkit.org/show_bug.cgi?id=61146
Covered by existing tests.
- platform/graphics/IntPoint.h: (WebCore::toSize): Add toSize function for converting from point to size.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
- rendering/RenderBlock.h: Change hit testing code in RenderBlock to use IntPoint.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderListBox.h: Change overridden method to use IntPoint.
- 3:11 PM Changeset in webkit [87100] by
-
- 2 edits in branches/chromium/742/Source/WebCore/dom
Merge 87098 - 2011-05-23 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
BUG=83012
Review URL: http://codereview.chromium.org/7064010
- 2:50 PM Changeset in webkit [87099] by
-
- 2 edits in trunk/Source/WebCore
2011-05-23 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311
No new tests.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
- 2:29 PM Changeset in webkit [87098] by
-
- 3 edits in trunk/Source/WebCore
2011-05-23 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
- 2:06 PM Changeset in webkit [87097] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] Link tcmalloc to DRT so we can use the heap checker
https://bugs.webkit.org/show_bug.cgi?id=61292
- WebKit.gyp:
- 1:49 PM Changeset in webkit [87096] by
-
- 5 edits6 adds in trunk
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Alexey Proskuryakov.
selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489
Added tests to ensure selectstart is dispatches exactly once when selecting text by a mouse drag,
a mouse click, a double click, or a triple click. Also rebaselined a test that previously logged
extra selectstart dispatches.
- fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- fast/events/selectstart-by-double-triple-clicks.html: Added.
- fast/events/selectstart-by-drag.html:
- fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
- fast/events/selectstart-by-single-click-with-shift.html: Added.
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Alexey Proskuryakov.
selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489
Fixed the bug by dispatching selectstart event immediately before modifying selection in
handleMousePressEventSingleClick and updateSelectionForMouseDrag.
Also replaced a boolean EventHandler::m_beganSelectingText by an enum-valued m_selectionInitiationState
to retain 3 states:
- HaveNotStartedSelection - Selection has not been set by a mouse drag or a mouse click
- PlacedCaret - A caret was placed by a mouse click, double click, or triple click, and is about to replace selection if a mouse drag never occurs.
- ExtendedSelection - A range selection was set by a mouse click, a double click, a triple click, or a mouse drag; otherwise a caret selection was set by a mouse drag.
State 1 corresponds to m_beganSelectingText being false and state 3 corresponds to m_beganSelectingText
being true. State 2 is used in updateSelectionForMouseDrag to avoid dispatching selectstart twice.
States 1 and 2 are set by updateSelectionForMouseDownDispatchingSelectStart and state 3 is set by
updateSelectionForMouseDrag.
Test: fast/events/selectstart-by-double-triple-clicks.html
fast/events/selectstart-by-drag.html
fast/events/selectstart-by-single-click-with-shift.html
- page/EventHandler.cpp: Removed canMouseDragExtendSelect. (WebCore::EventHandler::EventHandler): Initializes m_selectionInitiationState. (WebCore::dispatchSelectStart): Returns true only if selectstart was successfully fired and default action was not prevented. (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Updates m_selectionInitiationState and modifies the selection if dispatchSelectStart returns true. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls updateSelectionForMouseDownDispatchingSelectStart. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::canMouseDownStartSelect): No longer dispatches startselect; also renamed from EventHandler::canMouseDownStartSelect. (WebCore::EventHandler::handleMousePressEvent): No longer calls canMouseDragExtendSelect. (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): Exit early if m_selectionInitiationState is HaveNotStartedSelection and dispatchSelectStart returns false. Since setSelectionIfPossible dispatches selectstart event before assigning PlacedCaret or ExtendedSelection to m_selectionInitiationState, there is no need to dispatch event for those two cases. (WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h: Removed canMouseDownStartSelect and canMouseDragExtendSelect from EventHandler and added setSelectionIfPossible.
- 1:47 PM Changeset in webkit [87095] by
-
- 6 edits in trunk/Source/WebCore
2011-05-23 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155
Covered by existing tests: fast/filesystem/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry-sync.html
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Updated to call createWithName().
- fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
- fileapi/File.cpp: (WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup. (WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method. (WebCore::File::File):
- fileapi/File.h: (WebCore::File::createWithName):
- html/FileInputType.cpp: (WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
- 1:40 PM Changeset in webkit [87094] by
-
- 4 edits in trunk/Source
2011-05-23 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164
- platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord):
2011-05-23 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164
Add additional tests for small max texture sizes.
- tests/TilingDataTest.cpp: (WebCore::TEST):
- 1:21 PM Changeset in webkit [87093] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
https://bugs.webkit.org/show_bug.cgi?id=61299
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess): Change validity check to only check for process validity, since terminating the process of a page that is closed or is closing is acceptable behavior.
- 12:59 PM Changeset in webkit [87092] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Unskip passing transitions tests
https://bugs.webkit.org/show_bug.cgi?id=61246
- platform/qt/Skipped:
- platform/qt/transitions/move-after-transition-expected.txt: Added.
- platform/qt/transitions/transition-end-event-rendering-expected.txt: Added.
- 12:54 PM Changeset in webkit [87091] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-1.4
- 12:47 PM Changeset in webkit [87090] by
-
- 3 edits3 adds in trunk
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683
This test actually passes before this patch anyway. I don't think this
patch is actually observable in any meaningful way.
- fast/images/busted-oval-does-not-render-expected.txt: Added.
- fast/images/busted-oval-does-not-render.html: Added.
- fast/images/resources/busted-oval.png: Added.
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683
This change is difficult to test. We're making this change to comply
with standards even if the change is difficult to observe. (This patch
also causes us to match Firefox.)
Test: fast/images/busted-oval-does-not-render.html
- platform/image-decoders/ImageDecoder.cpp:
- 12:05 PM Changeset in webkit [87089] by
-
- 7 edits in trunk/Source
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
- JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
No new tests, just changing gyp defines.
- WebCore.gyp/WebCore.gyp:
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
- WebKit.gyp:
- WebKit.gypi:
- 11:52 AM Changeset in webkit [87088] by
-
- 1 edit2 copies in branches/chromium/742
Merge 86725
BUG=81949
Review URL: http://codereview.chromium.org/7067001
- 11:51 AM Changeset in webkit [87087] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288
Reviewed by Andreas Kling.
Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.
The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
- 11:47 AM Changeset in webkit [87086] by
-
- 3 edits in branches/chromium/742
Merge 86665
BUG=82416
Review URL: http://codereview.chromium.org/7065004
- 11:44 AM Changeset in webkit [87085] by
-
- 3 edits2 copies in branches/chromium/742
Merge 86976
BUG=83235
Review URL: http://codereview.chromium.org/7065003
- 11:41 AM Changeset in webkit [87084] by
-
- 1 edit2 copies in branches/chromium/742
Merge 87083
BUG=83598
Review URL: http://codereview.chromium.org/6966014
- 11:27 AM Changeset in webkit [87083] by
-
- 3 edits2 adds in trunk
2011-05-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that we do not crash when parsing css color for integer or
percentage values.
https://bugs.webkit.org/show_bug.cgi?id=61293
- fast/css/parse-color-int-or-percent-crash-expected.txt: Added.
- fast/css/parse-color-int-or-percent-crash.html: Added.
2011-05-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Terminate css color parsing on integers which are not followed
by a terminator.
https://bugs.webkit.org/show_bug.cgi?id=61293
Test: fast/css/parse-color-int-or-percent-crash.html
- css/CSSParser.cpp: (WebCore::parseColorIntOrPercentage):
- 11:07 AM Changeset in webkit [87082] by
-
- 8 edits2 moves2 adds in trunk
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914
Added a test to ensure WebKit does not clone hierarchy to preserve background color.
Also renamed editing/pasteboard/do-not-copy-body-color.html to do-no-clone-unnecessary-styles.html
and updated the description to match new behavior. While this test ensures WebKit does not copy
body's background color when it's not fully selected, this isn't a necessary requirement for us
not to duplicate borders so new expected result is correct.
- editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Some spans became style spans.
- editing/pasteboard/do-no-clone-unnecessary-styles-2-expected.txt: Added.
- editing/pasteboard/do-no-clone-unnecessary-styles-2.html: Added.
- editing/pasteboard/do-no-clone-unnecessary-styles-expected.txt: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color-expected.txt.
- editing/pasteboard/do-no-clone-unnecessary-styles.html: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color.html.
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914
The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
Fixed the bug by not cloning background color and adding the effective background color to the wrapping
style span.
Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html
editing/pasteboard/do-no-clone-unnecessary-styles.html
- editing/EditingStyle.cpp: (WebCore::cssValueToRGBA): Extracted from getRGBAFontColor. (WebCore::getRGBAFontColor): Moved. (WebCore::rgbaBackgroundColorInEffect): Added. (WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect. (WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position. Also remove the background color property when the effective background color is equal to the background color property (in terms of RGBA value) of the editing style. (WebCore::hasTransparentBackgroundColor): Moved from Editor class. (WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
- editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
- editing/Editor.h: Removed hasTransparentBackgroundColor.
- editing/markup.cpp: (WebCore::isElementPresentational): Reverted r85090 and r84311. (WebCore::createMarkup): Include the background color in effect when computing the editing style.
- 11:07 AM QtWebKitRelease21 edited by
- (diff)
- 11:06 AM QtWebKitRelease21 edited by
- (diff)
- 11:04 AM QtWebKit edited by
- (diff)
- 11:00 AM QtWebKitRelease21 edited by
- (diff)
- 10:59 AM Changeset in webkit [87081] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content
https://bugs.webkit.org/show_bug.cgi?id=45889
Add a regression test now that the bug has been fixed by r87067.
- fast/forms/delete-text-with-invisible-br-expected.txt: Added.
- fast/forms/delete-text-with-invisible-br.html: Added.
- 10:59 AM QtWebKitFeatures21 edited by
- (diff)
- 10:56 AM Changeset in webkit [87080] by
-
- 4 edits in trunk/Tools
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87078.
http://trac.webkit.org/changeset/87078
https://bugs.webkit.org/show_bug.cgi?id=61294
Patch contains errors and seems likely to break a bunch of
bots (Requested by abarth on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- 10:47 AM Changeset in webkit [87079] by
-
- 5 edits in trunk/Source/WebCore
2011-05-23 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983
Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.
No new tests. (refactoring)
- dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
- dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
- dom/Node.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
- 10:28 AM Changeset in webkit [87078] by
-
- 4 edits in trunk/Tools
2011-05-23 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- 10:15 AM Changeset in webkit [87077] by
-
- 2 edits in trunk/Source/WebKit2
[Windows] Initial Cookie Accept Policy not set on Deserialized Storage Session.
https://bugs.webkit.org/show_bug.cgi?id=61255
Reviewed by Darin Adler.
- WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Move the code to set the cookie policy before the early return that is taken when using the
default storage session from the UI Process.
Also, remove unnecessary #ifdefs (USE(CFURLSTORAGESESSIONS) is true if USE(CFNETWORK) is
true) and add a comment explaining the early return.
- 9:40 AM Changeset in webkit [87076] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
[SH4] AssemblerLabel does not name a type
https://bugs.webkit.org/show_bug.cgi?id=59927
SH4Assembler.h file shoold be included before AbstractMacroAssembler.h.
- assembler/MacroAssemblerSH4.h:
- 9:05 AM Changeset in webkit [87075] by
-
- 3 edits in trunk/Tools
2011-05-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Move generation of shell_command from port to executive
https://bugs.webkit.org/show_bug.cgi?id=61251
After move it's possible to use the code in other places too.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/system/executive.py:
- 8:07 AM Changeset in webkit [87074] by
-
- 23 edits1 delete in trunk/Source
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267
All methods of WorkerContextInspectorProxy are inlined in WorkerContextProxy and
the class itself is removed. Messages from worker inspector to page inspector
are sent by means of WorkerReportingProxy.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker): (WebCore::InspectorWorkerAgent::sendMessageToWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h:
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postMessageToPageInspector):
- workers/WorkerContextInspectorProxy.h: Removed.
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::PageInspector::~PageInspector): (WebCore::WorkerContextProxy::connectToInspector): (WebCore::WorkerContextProxy::disconnectFromInspector): (WebCore::WorkerContextProxy::sendMessageToInspector):
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267
WebWorker and WebWorkerClient are extended with methods for passing
DevTools messages between worker context inspector and page inspector.
- public/WebWorker.h: (WebKit::WebWorker::attachDevTools): (WebKit::WebWorker::detachDevTools): (WebKit::WebWorker::dispatchDevToolsMessage):
- public/WebWorkerClient.h: (WebKit::WebWorkerClient::dispatchDevToolsMessage):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspector): (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
- src/WebWorkerBase.h:
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::connectToInspector): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::sendMessageToInspector): (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
- src/WebWorkerClientImpl.h:
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
- src/WebWorkerImpl.h:
- 7:30 AM Changeset in webkit [87073] by
-
- 9 edits2 deletes in trunk
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285
broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-har-headers-expected.txt: Removed.
- http/tests/inspector/resource-har-headers.html: Removed.
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resources-test.js:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285
broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildContent): (WebInspector.HAREntry.prototype._buildCookie): (WebInspector.HAREntry.prototype._interval): (WebInspector.HARLog.prototype.build):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
- 7:20 AM Changeset in webkit [87072] by
-
- 12 edits in trunk
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Unskip test case due to the implementation setJavaScriptCanAccessClipboard in WebKitTestRunner.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setJavaScriptCanAccessClipboard):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 6:41 AM Changeset in webkit [87071] by
-
- 6 edits in trunk
2011-05-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
- inspector/debugger/resources/obfuscated.js: (withComments):
- inspector/debugger/script-formatter.html:
2011-05-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037
- inspector/front-end/JavaScriptFormatter.js: (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype._addComment): (FormattedContentBuilder.prototype._addText): (FormattedContentBuilder.prototype._addMappingIfNeeded):
- 6:29 AM Changeset in webkit [87070] by
-
- 9 edits2 adds in trunk
2011-05-23 Mike West <mkwst@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127
Setting correct expectations for the following fields newly added to
the HAR implementation:
- entry.request.httpVersion
- entry.request.headersSize
- entry.request.bodySize
- entry.response.httpVersion
- entry.response.headersSize
- entry.response.bodySize
- entry.response.content.compression
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-har-headers-expected.txt: Added.
- http/tests/inspector/resource-har-headers.html: Added.
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resources-test.js:
2011-05-23 Mike West <mkwst@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127
Specifically, this patch adds:
- entry.request.httpVersion
- entry.request.headersSize
- entry.request.bodySize
- entry.response.httpVersion
- entry.response.headersSize
- entry.response.bodySize
- entry.response.content.compression
Tests: http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildContent): (WebInspector.HAREntry.prototype._buildCookie): (WebInspector.HAREntry.prototype._interval): (WebInspector.HAREntry.prototype.get requestBodySize): (WebInspector.HAREntry.prototype.get responseBodySize): (WebInspector.HAREntry.prototype.get responseCompression): (WebInspector.HARLog.prototype.build):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.get requestHttpVersion): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype.get responseHttpVersion):
- 6:26 AM Changeset in webkit [87069] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK] Skip a failing test.
- platform/qt-wk2/Skipped:
- 5:05 AM Changeset in webkit [87068] by
-
- 2 edits in trunk/Source/WebCore
2011-05-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: keyboard shortcut panel is 1px too short
https://bugs.webkit.org/show_bug.cgi?id=61242
Fixed bottom margin of attached helpscreen so it's glued to status bar.
- inspector/front-end/helpScreen.css: (body.attached .help-window-outer):
- 3:10 AM Changeset in webkit [87067] by
-
- 212 edits in trunk
Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179
Reviewed by Dimitri Glazkov.
Source/WebCore:
By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:
<textarea> --(shadow-connection)-- <div> -- ...
After the change:
<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...
The goals of this change are
- Change to the new shadow DOM model, and
- Minimize the patch size.
We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.
Note: This is a re-landing for r87014 with a small fix of
Element::removeShadowRoot().
- css/html.css:
(input::-webkit-inner-spin-button):
Add vertical-align in order to avoid the button affect the baseline.
(input::-webkit-outer-spin-button): ditto.
(input::-webkit-input-speech-button): ditto.
- dom/Element.cpp:
(WebCore::Element::recalcStyle): Calls styleForRenderer() so that a
subclass of Element can override it.
(WebCore::Element::remvoeShadowRoot):
Fix a wrong parameter for willRemoveDOMNode().
(WebCore::Element::isSpellCheckingEnabled):
Handle ShadowRoot, which is not an Element.
- dom/Node.cpp: Add utility functions for editing code.
(WebCore::Node::nonBoundaryShadowTreeRootNode):
(WebCore::Node::nonShadowBoundaryParentNode):
- dom/Node.h: Declare them.
- dom/Position.cpp:
- Add some assertions about ShadowRoot
- Replace parentNode() with nonShadowBoundaryParentNode()
Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
- dom/Position.h: ditto.
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):
- editing/CompositeEditCommand.cpp: ditto.
(WebCore::CompositeEditCommand::insertNodeAfter):
(WebCore::CompositeEditCommand::removeNode):
- editing/Editor.cpp:
(WebCore::Editor::findString): ditto.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
- editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeNode): ditto.
(WebCore::ReplacementFragment::insertNodeBefore): ditto.
- editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot.
(WebCore::VisibleSelection::isAll):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
- editing/VisibleSelection.h: ditto.
- editing/htmlediting.cpp: Add assertions.
(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::create): Calls createShadowSubtree().
(WebCore::HTMLInputElement::createShadowSubtree):
Calls InputType::createShadowSubTree().
(WebCore::HTMLInputElement::innerTextElement):
Accessor of a shadow node. This is used by RenderTextControlSingleLine.
(WebCore::HTMLInputElement::innerBlockElement): ditto.
(WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::resultsButtonElement): ditto.
(WebCore::HTMLInputElement::cancelButtonElement): ditto.
(WebCore::HTMLInputElement::speechButtonElement): ditto.
(WebCore::HTMLInputElement::parseMappedAttribute):
Rebuild shadow trees because x-webkit-speech attribute affects it.
- html/HTMLInputElement.h: Add declarations.
- html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
(WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
- html/HTMLTextAreaElement.h: Declare createShadowSubtree().
- html/InputType.h: Add default implementations of accessors.
(WebCore::InputType::innerBlockElement):
(WebCore::InputType::innerTextElement):
(WebCore::InputType::innerSpinButtonElement):
(WebCore::InputType::outerSpinButtonElement):
(WebCore::InputType::resultsButtonElement):
(WebCore::InputType::cancelButtonElement):
(WebCore::InputType::speechButtonElement):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType): Initializes new data members.
(WebCore::SearchInputType::createShadowSubtree):
Moved from RenderTextControlSingleLine.
(WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
- html/SearchInputType.h: Add declarations.
(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::TextFieldInputType):
Initializes new data members.
(WebCore::TextFieldInputType::createShadowSubtree):
Moved from RenderTextControlSingleLine.
(WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
- html/TextFieldInputType.h: Add declarations.
(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::outerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
Remove shadowParent parameter. It is unnecessary because we switch to
new shadow model.
(WebCore::TextControlInnerElement::create):
Change the parameter type to Document.
(WebCore::TextControlInnerElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerBlockStyle().
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
Remove shadowParent parameter.
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
(WebCore::TextControlInnerTextElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerTextStyle().
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldResultsButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createResultButtonStyle().
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldCancelButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createCancelButtonStyle().
(WebCore::SearchFieldCancelButtonElement::detach):
Update for the parent class change.
(WebCore::SpinButtonElement::SpinButtonElement):
- Change the parameter type: shadowParent -> Document
- Add the inner flag
- Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SpinButtonElement::createInner): Introduce a new factory
method to hide a bool parameter of the constructor.
(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().
(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
- Change the parameter type: shadowParent -> Document
- Inherit HTMLDivElement, not TextControlInnerElement.
- Do not register this as a speech input listener here.
(WebCore::InputFieldSpeechButtonElement::create):
Update for the parameter change.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
Do not handle click event if listener registration is not done.
(WebCore::InputFieldSpeechButtonElement::attach):
Register this as a speech input listener.
(WebCore::InputFieldSpeechButtonElement::detach):
Update for the parent class change.
(WebCore::InputFieldSpeechButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().
- html/shadow/TextControlInnerElements.h:
(WebCore::TextControlInnerTextElement::isMouseFocusable):
Add this because the class is not a subclass of TextControllInnerElement.
(WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
(WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
(WebCore::SpinButtonElement::isMouseFocusable): ditto.
(WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
(WebCore::RenderTextControl::styleDidChange):
innerTextElement can have no renderer.
Explicitly call setNeedsStyleRecals() for innerTextElement. It is
needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.
(WebCore::RenderTextControl::textBlockWidth): Member data -> function
(WebCore::RenderTextControl::updateFromElement): ditto.
(WebCore::RenderTextControl::setInnerTextValue): ditto.
(WebCore::RenderTextControl::hasVisibleTextArea): ditto.
(WebCore::RenderTextControl::isSelectableElement): ditto.
(WebCore::RenderTextControl::selection): ditto.
(WebCore::RenderTextControl::visiblePositionForIndex): ditto.
(WebCore::RenderTextControl::indexForVisiblePosition): ditto.
(WebCore::RenderTextControl::text): ditto.
(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
(WebCore::RenderTextControl::computeLogicalHeight): ditto.
(WebCore::RenderTextControl::hitInnerTextElement): ditto.
(WebCore::RenderTextControl::forwardEvent): ditto.
(WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
- rendering/RenderTextControl.h:
- Make m_innerText virtual function.
- Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::innerTextElement): Added.
(WebCore::RenderTextControlMultiLine::updateFromElement):
Remove unnecessary createSubtreeIfNeeded() call.
- rendering/RenderTextControlMultiLine.h: Add a declaration.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
Remove unnecessary code.
(WebCore::RenderTextControlSingleLine::innerTextElement): Added.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
(WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
(WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
(WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
(WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
(WebCore::RenderTextControlSingleLine::layout): ditto.
(WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
(WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
(WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
(WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
(WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
(WebCore::RenderTextControlSingleLine::updateFromElement):
ditto, and remove unnecessary createSubtreeIfNeeded() call.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
Data member -> function
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
(WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
- rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.
LayoutTests:
Update test results because the shadow tree structure of <input> and
<textarea> is changed.
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/search-zoomed-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-outline-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
- platform/gtk/editing/selection/4895428-3-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/context-no-deselect-expected.txt:
- platform/gtk/fast/forms/input-appearance-focus-expected.txt:
- platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-selection-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-paste-undo-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/gtk/fast/forms/input-text-click-inside-expected.txt:
- platform/gtk/fast/forms/input-text-click-outside-expected.txt:
- platform/gtk/fast/forms/input-text-double-click-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/input-text-option-delete-expected.txt:
- platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/fast/forms/textfield-outline-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/fast/events/context-no-deselect-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-paste-undo-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/plaintext-mode-2-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt:
- 2:41 AM Changeset in webkit [87066] by
-
- 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Merge 86963 - 2011-05-20 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/7051034
- 2:07 AM Changeset in webkit [87065] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed trivial fix after r86990.
- WebKit2.pro: Remove UIProcess/ChunkedUpdateDrawingAreaProxy.h.
- 2:01 AM Changeset in webkit [87064] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed, skip new failing tests.
- platform/qt-arm/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- 1:48 AM Changeset in webkit [87063] by
-
- 18 edits in trunk/Source/WebCore
2011-05-19 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Explicitly mark objects with complex GC rules.
https://bugs.webkit.org/show_bug.cgi?id=61131
From the GC point view there are two kinds of objects: the ones
that may participate in object grouping (i.e. their lifetime
depends on other objects) and the ones that never participate in
grouping (independent). V8 added support for marking persistent
handles as independent so that the GC can process the objects they
hold faster. The motivating use case here is typed arrays.
This patch adds V8-specific inherited IDL attribute
V8DependentLifetime to types used in V8GCController, which is
exactly the set of types with object lifetimes depending on other
objects. The handles for the types that are not marked with the
new attribute can be marked as independent and GC-ed faster.
- bindings/scripts/CodeGeneratorV8.pm: Added proccessing of the new attribute.
Updated test output:
- bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.h:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
Added the new attribute:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/Node.idl:
- 1:46 AM Changeset in webkit [87062] by
-
- 212 edits in trunk
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266
It made more tests assert (Requested by Ossy on #webkit).
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/search-zoomed-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-outline-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
- platform/gtk/editing/selection/4895428-3-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/context-no-deselect-expected.txt:
- platform/gtk/fast/forms/input-appearance-focus-expected.txt:
- platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-selection-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-paste-undo-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/gtk/fast/forms/input-text-click-inside-expected.txt:
- platform/gtk/fast/forms/input-text-click-outside-expected.txt:
- platform/gtk/fast/forms/input-text-double-click-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/input-text-option-delete-expected.txt:
- platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/fast/forms/textfield-outline-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/fast/events/context-no-deselect-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-paste-undo-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/plaintext-mode-2-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266
It made more tests assert (Requested by Ossy on #webkit).
- css/html.css: (input::-webkit-inner-spin-button): (input::-webkit-outer-spin-button): (input::-webkit-input-speech-button):
- dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::Element::isSpellCheckingEnabled):
- dom/Node.cpp:
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::containerNode): (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::parentEditingBoundary): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree):
- dom/Position.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::findString):
- editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll):
- editing/FrameSelection.h: (WebCore::FrameSelection::shadowTreeRootNode):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): (WebCore::ReplacementFragment::insertNodeBefore):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::shadowTreeRootNode):
- editing/VisibleSelection.h:
- editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h:
- html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
- html/HTMLTextAreaElement.h:
- html/InputType.h:
- html/SearchInputType.cpp:
- html/SearchInputType.h: (WebCore::SearchInputType::SearchInputType):
- html/TextFieldInputType.cpp:
- html/TextFieldInputType.h: (WebCore::TextFieldInputType::TextFieldInputType):
- html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::TextControlInnerElement::detach): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::detach): (WebCore::SpinButtonElement::setHovered): (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
- html/shadow/TextControlInnerElements.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::hasVisibleTextArea): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition): (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::computeLogicalHeight): (WebCore::RenderTextControl::hitInnerTextElement): (WebCore::RenderTextControl::forwardEvent): (WebCore::RenderTextControl::computePreferredLogicalWidths): (WebCore::RenderTextControl::innerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::decorationWidthRight): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
- rendering/RenderTextControlSingleLine.h:
- 1:27 AM Changeset in webkit [87061] by
-
- 8 edits in trunk
2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>
Rubber stamped by Eric Seidel.
[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146
Move WTF_INCLUDE_DIRECTORIES to Source/JavaScriptCore/wtf/CMakeLists.txt.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>
Rubber stamped by Eric Seidel.
[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146
Move wtf-files to Source/JavaScriptCore/wtf/CMakeLists.txt.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- wtf/CMakeLists.txt:
- wtf/CMakeListsEfl.txt:
- 1:14 AM Changeset in webkit [87060] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-05-23 Joe Wild <joseph.wild@nokia.com>
Reviewed by Andreas Kling.
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200
- symbian/eabi/QtWebKitu.def:
- 1:07 AM Changeset in webkit [87059] by
-
- 2 edits in trunk/Source/WebCore
2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61202
LayoutTests/fast/canvas/webgl/gl-object-get-calls.html
getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
- 1:02 AM Changeset in webkit [87058] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r86990.
- GNUmakefile.am: Remove UpdateChunk.cpp and UpdateChunk.h.
- 12:58 AM Changeset in webkit [87057] by
-
- 2 edits in trunk/Source/WebCore
2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Strict PassOwnPtr build fix.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::newTextCodecGtk):
- 12:50 AM Changeset in webkit [87056] by
-
- 3 edits in trunk/Source/WebCore
2011-05-23 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Show "Please wait" message during initial
heap snapshot processing.
https://bugs.webkit.org/show_bug.cgi?id=61040
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView.setDataSource): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeView):
- inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
- 12:11 AM Changeset in webkit [87055] by
-
- 3 edits in trunk/Source/WebCore
2011-05-23 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fixes.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderTrackStyle): (WebCore::RenderThemeGtk::adjustSliderThumbStyle): (WebCore::RenderThemeGtk::adjustProgressBarStyle):
May 22, 2011:
- 11:56 PM Changeset in webkit [87054] by
-
- 2 edits in trunk/Source/WebCore
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustProgressBarStyle):
- 11:27 PM Changeset in webkit [87053] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-05-22 Adam Barth <abarth@webkit.org>
Build fix. More public destructors needed to play nice with OwnPtr.
- WebCoreSupport/InspectorClientGtk.cpp:
- 11:22 PM Changeset in webkit [87052] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-05-22 Adam Barth <abarth@webkit.org>
Build fix. InspectorFrontendClient needs a public destructor so that
we can properly track ownership using OwnPtr.
- WebCoreSupport/InspectorClientGtk.h:
- 11:11 PM Changeset in webkit [87051] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::InspectorFrontendClient):
- 11:07 PM Changeset in webkit [87050] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-05-22 Greg Simon <gregsimon@chromium.org>
Reviewed by Darin Fisher.
[chromium] Updating chromium DEPS
- DEPS:
- 11:04 PM Changeset in webkit [87049] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::addUserStyleSheet):
- 10:54 PM Changeset in webkit [87048] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-05-22 Adam Barth <abarth@webkit.org>
Enable strict PassOwnPtr for everyone. I expect this patch will need
some followups to make the GTK and EFL bots green again.
- wtf/PassOwnPtr.h:
- 10:48 PM BuildingQtOnOSX edited by
- Added note about the dangers of MacPorts flex (diff)
- 6:00 PM WebKit Team edited by
- (diff)
- 5:48 PM Changeset in webkit [87047] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Chromium expectations update.
- platform/chromium/test_expectations.txt: add fast/block/positioning/058.html
- 3:35 PM Changeset in webkit [87046] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).
- 3:29 PM Changeset in webkit [87045] by
-
- 2 edits in branches/safari-534-branch/Source/WebKit2
Rolled out <http://trac.webkit.org/changeset/87030>, which I accidentally checked into
the branch instead of trunk.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
- 3:18 PM Changeset in webkit [87044] by
-
- 3 edits24 adds in trunk/Source/WebKit/qt
2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin with html5 video player.
- symbian/platformplugin/HTML5VideoPlugin.cpp: Added. (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler): (HTML5FullScreenVideoHandler::enterFullScreen): (HTML5FullScreenVideoHandler::exitFullScreen): (HTML5FullScreenVideoHandler::onPlayerError): (HTML5FullScreenVideoHandler::onPlayerStateChanged): (HTML5FullScreenVideoHandler::onMediaStatusChanged): (HTML5VideoPlugin::supportsExtension): (HTML5VideoPlugin::createExtension):
- symbian/platformplugin/HTML5VideoPlugin.h: Added. (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (HTML5FullScreenVideoHandler::isFullScreen): (HTML5FullScreenVideoHandler::updateScreenRect):
- symbian/platformplugin/HTML5VideoWidget.cpp: Added. (HTML5VideoWidget::HTML5VideoWidget): (HTML5VideoWidget::setDuration): (HTML5VideoWidget::mousePressEvent): (HTML5VideoWidget::onPlayerStopped): (HTML5VideoWidget::onPlayerError): (HTML5VideoWidget::onEndOfMedia): (HTML5VideoWidget::onBufferingMedia): (HTML5VideoWidget::onBufferedMedia): (HTML5VideoWidget::onControlClicked): (HTML5VideoWidget::onPositionChanged): (HTML5VideoWidget::onSliderMoved): (HTML5VideoWidget::onCloseClicked): (HTML5VideoWidget::showFullScreen): (HTML5VideoWidget::setVolume):
- symbian/platformplugin/HTML5VideoWidget.h: Added.
- symbian/platformplugin/OverlayWidget.cpp: Added. (OverlayWidget::OverlayWidget): (OverlayWidget::~OverlayWidget): (OverlayWidget::setDuration): (OverlayWidget::setPosition): (OverlayWidget::setVolume): (OverlayWidget::mousePressEvent): (OverlayWidget::onPlayerStopped): (OverlayWidget::onPlayerError): (OverlayWidget::onEndOfMedia): (OverlayWidget::onBufferingMedia): (OverlayWidget::onBufferedMedia): (OverlayWidget::timeToString): (OverlayWidget::applyStyleSheet): (OverlayWidget::onControlClicked): (OverlayWidget::onSliderMoved): (OverlayWidget::onSoundClicked): (OverlayWidget::onCloseClicked): (OverlayWidget::onVolumeSliderReleased): (OverlayWidget::onVolumeSliderMoved): (OverlayWidget::onTimerTimeout): (OverlayWidget::showFullScreen):
- symbian/platformplugin/OverlayWidget.h: Added.
- symbian/platformplugin/PlayerButton.cpp: Added. (PlayerButton::PlayerButton): (PlayerButton::event):
- symbian/platformplugin/PlayerButton.h: Added.
- symbian/platformplugin/PlayerLabel.cpp: Added. (PlayerLabel::PlayerLabel): (PlayerLabel::onPlayerError): (PlayerLabel::startBufferingAnimation): (PlayerLabel::stopBufferingAnimation): (PlayerLabel::onAnimationTimeout):
- symbian/platformplugin/PlayerLabel.h: Added.
- symbian/platformplugin/WebPlugin.cpp: (WebPlugin::createExtension):
- symbian/platformplugin/images: Added.
- symbian/platformplugin/images/button_cannotplay.png: Added.
- symbian/platformplugin/images/button_close.png: Added.
- symbian/platformplugin/images/button_pause.png: Added.
- symbian/platformplugin/images/button_play.png: Added.
- symbian/platformplugin/images/button_sound_off.png: Added.
- symbian/platformplugin/images/button_sound_on.png: Added.
- symbian/platformplugin/images/loading_buffering_1.png: Added.
- symbian/platformplugin/images/loading_buffering_2.png: Added.
- symbian/platformplugin/images/loading_buffering_3.png: Added.
- symbian/platformplugin/images/loading_buffering_4.png: Added.
- symbian/platformplugin/platformplugin.pro:
- symbian/platformplugin/platformplugin.qrc: Added.
- symbian/platformplugin/qss: Added.
- symbian/platformplugin/qss/OverlayWidget.qss: Added.
- 12:33 PM Changeset in webkit [87043] by
-
- 7 edits2 deletes in trunk
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247
- platform/qt/Skipped: Unskip fast/encoding/mailto-always-utf-8.html
- platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Removed.
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247
Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant, so remove it.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate):
- 11:52 AM Changeset in webkit [87042] by
-
- 5 edits in branches/safari-534-branch/Source
Versioning.
- 11:51 AM Changeset in webkit [87041] by
-
- 1 copy in tags/Safari-534.38
New tag.
- 11:08 AM Changeset in webkit [87040] by
-
- 2 edits in trunk/Tools
2011-05-22 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Use double quotes for filename arguments
https://bugs.webkit.org/show_bug.cgi?id=61250
Windows does not support single quotes on the command line,
so replace them with double quotes.
- Scripts/prepare-ChangeLog:
- 10:35 AM Changeset in webkit [87039] by
-
- 2 edits in branches/safari-534-branch/Source/JavaScriptCore
Merge r86972.
- 10:33 AM Changeset in webkit [87038] by
-
- 7 edits in branches/safari-534-branch/Source/WebKit2
Merge r86967.
- 10:31 AM Changeset in webkit [87037] by
-
- 10 edits in branches/safari-534-branch/Source
Merge r86956.
- 10:28 AM Changeset in webkit [87036] by
-
- 5 edits in branches/safari-534-branch/Source
Merge r86924.
- 10:26 AM Changeset in webkit [87035] by
-
- 3 edits2 copies in branches/safari-534-branch
Merge r86904.
- 10:23 AM Changeset in webkit [87034] by
-
- 3 edits in branches/safari-534-branch/Source/WebKit2
Merge r86895.
- 10:16 AM Changeset in webkit [87033] by
-
- 2 edits in branches/safari-534-branch/Source/JavaScriptCore
Merge r86779.
- 9:56 AM Changeset in webkit [87032] by
-
- 8 edits in trunk/Source
2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897
Tests are in WebKit/qt/tests/hybridPixmap
- bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToImageDataMethod::name): (JSC::Bindings::QtPixmapToImageDataMethod::invoke): (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels): (JSC::Bindings::QtPixmapClass::methodsNamed): (JSC::Bindings::QtPixmapInstance::getPropertyNames): Add toImageData() to Qt Bridge, alternative to assignToHTMLImageElement().
2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897
- docs/qtwebkit-bridge.qdoc:
- docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): Document Qt bridge toImageData() feature.
- tests/hybridPixmap/test.html:
- tests/hybridPixmap/widget.cpp: (Widget::Widget): (Widget::abcImage):
- tests/hybridPixmap/widget.h: Add tests for Qt bridge toImageData() feature.
- 9:48 AM Changeset in webkit [87031] by
-
- 2 edits in trunk/Source/WebKit2
2011-05-22 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249
- UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().
- 9:27 AM Changeset in webkit [87030] by
-
- 2 edits in branches/safari-534-branch/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).
- 8:56 AM Changeset in webkit [87029] by
-
- 4 edits in trunk
2011-05-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
- platform/mac/Skipped: Unskip shadow tests.
2011-05-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
- dom/Element.cpp: (WebCore::Element::removeShadowRoot): Call detach if attached.
- 3:13 AM Changeset in webkit [87028] by
-
- 6 edits in trunk/Source/WebCore
2011-05-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176
General clean-up.
Don't resolve style manually, instead ask the RenderObject for its style.
Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.
No new tests needed. No change of behavior.
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::build):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/svgattrs.in:
