⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 28, 2011:

9:42 PM Changeset in webkit [87633] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Suggested by Simon Fraser.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
​https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use ASSERT_UNUSED here.
7:46 PM Changeset in webkit [87632] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87624.

7:44 PM Changeset in webkit [87631] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87622.

7:42 PM Changeset in webkit [87630] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebKit2

Merge r87627.

7:41 PM Changeset in webkit [87629] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87598.

6:37 PM Changeset in webkit [87628] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Geoff Garen.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
​https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

Test: fast/dom/gc-image-element-2.html

Manually verified that tests from bug 59604 and from bug 40926 still pass.

The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::wasCanceled): (WebCore::CachedResource::errorOccurred): Track whether the load was canceled. We want to always notify clients of load outcome, as that's the only way they could make intelligent decisions.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now get a notifyFinished call on cancellation. Handle this case, where we don't need the execute the script, but also don't need to fire an error event.
  • html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single function call now.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large window between when CachedResource::isLoading() becomes false and events are queued. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting an event to fire.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do anything on cancellation.
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to give an accurate result while looping over the list of events to dispatch. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to switch to a broken image icon, or to dispatch events. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching list, as the event is no longer pending when it's being dispatched.
  • loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one is already pending, we only care if one is expected at some time in the future, and !haveFiredLoadEvent() is our best idea of that.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to handle cancellation.
4:45 PM Changeset in webkit [87627] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

2011-05-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Maciej Stachowiak.

Denying access to your keychain on login crashes WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=61695
<rdar://problem/9520570>

Fix two sources of crashes if you hit the Deny button when WebKit2 is
doing HTTP authentication.

First, SecKeychainItemRequestData::attributeList() failed to initialize the
length and data members of SecKeychainAttributes in the list if there was no data.
This caused invalid memory reads later.

Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
would cause a later crash in a system framework, which is not set up to handle
errors. Instead, we always return noErr, and allow the authentication to fail.

Finally, paranoically initialize the SecKeychainItemContext in two places
to avoid uninitialized data members, and initialize length and outData
to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
fails to set them on error.

  • Shared/mac/SecKeychainItemRequestData.cpp: (WebKit::SecKeychainItemRequestData::attributeList):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::secKeychainItemCopyContent):
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCopyContent): (WebKit::webSecKeychainItemCreateFromContent):
3:26 PM Changeset in webkit [87626] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS builds patches that fail to build twice, which seems useless and slows down the bots
​https://bugs.webkit.org/show_bug.cgi?id=55585

This patch switches all the early warning system bots over to the new
PatchAnalysisTask-based infrastructure. This patch makes these bots
more efficient (in the case where patches fail to build) and paves the
way for running tests on these bots!

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
2:45 PM Changeset in webkit [87625] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-05-28 Martin Robinson <​mrobinson@igalia.com>

Skip a failing test and better classify some existing skipped tests.

  • platform/gtk/Skipped: Update the skipped list.
1:39 PM Changeset in webkit [87624] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r86578): Flash content missing from mercurynews.com
​https://bugs.webkit.org/show_bug.cgi?id=61691
<rdar://problem/9519893>

If the plug-in doesn't have access to the toplevel URL, make sure to
return *something* to the plug-in.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
12:59 PM Changeset in webkit [87623] by abarth@webkit.org
  • 23 edits in trunk/Source

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::cancelledError): (WebCore::FrameLoaderClientQt::blockedError): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest): (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::cancelledError): (WebCore::FrameLoaderClientEfl::blockedError):
  • ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): (ewk_frame_uri_changed):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_frame_create): (ewk_view_plugin_create):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

As far as I can tell, all the callers of this API are confused. There
seems to be a cargo cult of using the "pretty" version of a URL, but in
reality folks just want the URL itself. The only case I'm unsure about
is location.href, which could have some compatibility constraints.
I've renamed prettyURL to deprecatedString to discourage folks from
further cargo-culting.

  • WebCore.exp.in:
  • page/Location.cpp: (WebCore::Location::href): (WebCore::Location::toString):
  • platform/KURL.cpp: (WebCore::KURL::deprecatedString):
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURL::deprecatedString):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::href): (WebCore::WorkerLocation::toString):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::cancelledError): (WebKit::blockedError):
12:41 PM Changeset in webkit [87622] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-28 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Mouse clicks propagate outside full-screen media controls.
​https://bugs.webkit.org/show_bug.cgi?id=61689

Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block

propagation of all mouse click events.

(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):

Renamed from setDefaultHandled.

(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

  • html/shadow/MediaControlElements.h:
11:49 AM Changeset in webkit [87621] by mrowe@apple.com
  • 5 edits in tags/Safari-534.40.1/Source

Versioning.

11:37 AM Changeset in webkit [87620] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40.1

New tag.

11:37 AM Changeset in webkit [87619] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87331.

11:18 AM Changeset in webkit [87618] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-28 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-28 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
10:55 AM Changeset in webkit [87617] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
10:02 AM Changeset in webkit [87616] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial lyAligned
​https://bugs.webkit.org/show_bug.cgi?id=61606

Removed duplicated statement within if condition.

No new tests. Obvious clean up patch.

  • page/SpatialNavigation.cpp: (WebCore::areRectsPartiallyAligned):
9:16 AM Changeset in webkit [87615] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, clean up GPU tests expectations

8:43 AM Changeset in webkit [87614] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX when building only the interpreter

Fixes the following compiler warning:

JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]

void releaseExecutableMemory(JSGlobalData& globalData)


  • jit/ExecutableAllocator.h: Moved declaration of

JSC::releaseExecutableMemory().

8:27 AM Changeset in webkit [87613] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

8:24 AM Changeset in webkit [87612] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode): Added missing argument.

5:15 AM Changeset in webkit [87611] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-28 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=60311

If there is no editable text Qt interprets backspace as a navigation
command, regardless of platform.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.
5:06 AM Changeset in webkit [87610] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

3:32 AM Changeset in webkit [87609] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

1:50 AM Changeset in webkit [87608] by mnaganov@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed. Test expectations update after r87605

  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.
1:27 AM Changeset in webkit [87607] by bashi@chromium.org
  • 2 edits in trunk/Tools

2011-05-28 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

Add bashi as a committer.

​https://bugs.webkit.org/show_bug.cgi?id=61685

  • Scripts/webkitpy/common/config/committers.py:
12:17 AM Changeset in webkit [87606] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-05-28 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/style/non-inheritable-styles should be dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=61681

Converts the test to dump-as-markup and cleans up the HTML a bit.

  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html:
  • platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

May 27, 2011:

11:52 PM Changeset in webkit [87605] by Nikolas Zimmermann
  • 1 edit
    10 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed, this just adds a new test.

WebKit fails WICD SVG background image tests
​https://bugs.webkit.org/show_bug.cgi?id=16481

Add two WICD SVG background image tests, which pass just fine.

  • svg/wicd/resources/test-scalable-background-image1.css: Added. (html): (body): (p):
  • svg/wicd/resources/test-scalable-background-image1.svg: Added.
  • svg/wicd/resources/test-scalable-background-image2.css: Added. (html):
  • svg/wicd/resources/test-scalable-background-image2.svg: Added.
  • svg/wicd/test-scalable-background-image1.xhtml: Added.
  • svg/wicd/test-scalable-background-image2.xhtml: Added.
11:19 PM Changeset in webkit [87604] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/inserting/insert-3907422 should be dumpAsText test
​https://bugs.webkit.org/show_bug.cgi?id=61680

Converted to dumpAsMarkup and cleaned up markup.

  • editing/inserting/insert-3907422-fix-expected.txt: Added.
  • editing/inserting/insert-3907422-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.
10:13 PM Changeset in webkit [87603] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

10:13 PM Changeset in webkit [87602] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40

New tag.

9:48 PM Changeset in webkit [87601] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

When checking whether the tree is red, the EWS posts a link to the wrong log
​https://bugs.webkit.org/show_bug.cgi?id=61072

We need to cache the original script error because that contains the
failure log we want to upload. If we don't cache that script error,
self._script_error will get overwritten when we sanity check the clean
tree (and it also has test failures).

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • This testing approach is slightly goofy. We'd like to use assertRaisesRegexp, but that's not available until Python 2.7.
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
9:42 PM Changeset in webkit [87600] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87599.

9:39 PM Changeset in webkit [87599] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Roll out r87544 since it is bogus.

9:18 PM Changeset in webkit [87598] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CG BitmapImage needs to check for valid CGImage in a couple of places
​https://bugs.webkit.org/show_bug.cgi?id=61684
<rdar://problem/9519348>

BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
returns null, which it may do if the image is corrupted or still
loading. Protect against that here and in getFirstCGImageRefOfSize().

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::getFirstCGImageRefOfSize): (WebCore::BitmapImage::getCGImageArray):
8:27 PM Changeset in webkit [87597] by jochen@chromium.org
  • 15 edits
    4 adds in trunk

2011-05-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
​https://bugs.webkit.org/show_bug.cgi?id=61581

  • platform/chromium/permissionclient/storage-permission-expected.txt: Added.
  • platform/chromium/permissionclient/storage-permission.html: Added.

2011-05-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Add Frame parameter to all StorageArea methods. The chromium
embedder uses the Frame as context to decide whether or not
to allow usage of the storage API.
​https://bugs.webkit.org/show_bug.cgi?id=61581

Test: platform/chromium/permissionclient/storage-permission.html

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::contains):
  • storage/StorageAreaImpl.h:

2011-05-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
​https://bugs.webkit.org/show_bug.cgi?id=61581

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains): (WebCore::StorageAreaProxy::canAccessStorage):
  • src/StorageAreaProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem):

2011-05-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Add layoutTestController.setStorageAllowed() to control whether access
to the localStorage API is enabled via the WebPermissionClient
​https://bugs.webkit.org/show_bug.cgi?id=61581

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.h: Added. (WebPermissions::WebPermissions): (WebPermissions::allowStorage): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
7:28 PM Changeset in webkit [87596] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
​https://bugs.webkit.org/show_bug.cgi?id=60326

This patch removes a lot of the complexity from the
metered_stream implementation that was unnecessary since there
was only one caller and the logic could be coordinated better.

There should be no functional changes in this patch, just code
getting deleted and cleaned up.

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
7:24 PM Changeset in webkit [87595] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

2011-05-27 Nate Chapin <Nate Chapin>

Reviewed by Jian Li.

Keep a reference to BlobResourceHandle before calling doNotifyFinish()
asynchronously to ensure it's still safe in the main thread.

​https://bugs.webkit.org/show_bug.cgi?id=61669

I triggered this crash in fast/files/file-reader-abort.html during a
refactor that changed timings slightly.

  • platform/network/BlobResourceHandle.cpp: (WebCore::doNotifyFinish): (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/BlobResourceHandle.h: (WebCore::BlobResourceHandle::aborted):
7:16 PM Changeset in webkit [87594] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: minor cleanup in printing module
​https://bugs.webkit.org/show_bug.cgi?id=60329

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
7:11 PM Changeset in webkit [87593] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

NRWT: remove --print detailed-progress
​https://bugs.webkit.org/show_bug.cgi?id=60324

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:00 PM Changeset in webkit [87592] by sjl@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Steve Lacey <​sjl@chromium.org>

Reviewed by David Levin.

Add ​sjl@chromium.org as a committer.

​https://bugs.webkit.org/show_bug.cgi?id=61672

  • Scripts/webkitpy/common/config/committers.py:
6:56 PM Changeset in webkit [87591] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

NRWT: debug messages from the workers are being logged twice
​https://bugs.webkit.org/show_bug.cgi?id=60428

It looks like when the workers are run in separate processes
we end up getting two copies of every log message they print.
This has to do with the multiprocessing module on UNIX cloning
the log configuration in a way I wasn't expecting, and so two
log handlers end up getting registered.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6:24 PM Changeset in webkit [87590] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-27 Adam Klein <​adamk@chromium.org>

Unreviewed. Hopefully last rebaseline from r87526.

  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
5:30 PM Changeset in webkit [87589] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: Vista flakiness.

5:28 PM Changeset in webkit [87588] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

JS API is too aggressive about throwing exceptions for NULL get or set operations
​https://bugs.webkit.org/show_bug.cgi?id=61678

  • API/JSCallbackObject.h: Changed our staticValueGetter to a regular function that returns a JSValue, so it can fail and still forward to normal property lookup.
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): Don't throw an exception when failing to access a static property -- just forward the access. This allows objects to observe get/set operations but still let the JS object manage lifetime.

(JSC::::put): Ditto.

(JSC::::getStaticValue): Same as JSCallbackObject.h.

  • API/tests/testapi.c: (MyObject_set_nullGetForwardSet):
  • API/tests/testapi.js: Updated tests to reflect slightly less strict behavior, which matches headerdoc claims.
5:26 PM Changeset in webkit [87587] by adamk@chromium.org
  • 2 edits
    11 adds
    2 deletes in trunk/LayoutTests

2011-05-27 Adam Klein <​adamk@chromium.org>

Unreviewed. Even more rebaselines after r87526.

  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [87586] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Property caching is too aggressive for API objects
​https://bugs.webkit.org/show_bug.cgi?id=61677

  • API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our callback APIs allow the client to change its mind about our propertis at any time.
  • API/tests/testapi.c: (PropertyCatchalls_getProperty): (PropertyCatchalls_setProperty): (PropertyCatchalls_getPropertyNames): (PropertyCatchalls_class): (main):
  • API/tests/testapi.js: Some tests for dynamic API objects.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client requires it.
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::isFinal): (JSC::TypeInfo::prohibitsPropertyCaching): (JSC::TypeInfo::flags): Added a flag to track opting out of property caching. Fixed an "&&" vs "&" typo that was previously harmless, but is now harmful since m_flags2 can have more than one bit set.
4:34 PM Changeset in webkit [87585] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87578.

4:21 PM Changeset in webkit [87584] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: widen flakiness to include Linux.

4:18 PM Changeset in webkit [87583] by sjl@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-27 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

The behaviour of controls-after-reload was causing
layoutTestController in DumpRenderTree to misbehave causing a reported
failure in the test run after it (controls-css-overload).

Effectively, notifyDone() ended up getting called again after the test
was being torn down.

This change removes the unneeded seek at the end of the test (as we
should have already seeked to 0.

​https://bugs.webkit.org/show_bug.cgi?id=60132

  • media/controls-after-reload.html:
  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [87582] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source

Merge r87580.

4:09 PM Changeset in webkit [87581] by mrowe@apple.com
  • 11 edits
    1 add in branches/safari-534-branch/Source

Merge r87520.

3:57 PM Changeset in webkit [87580] by Stephanie Lewis
  • 8 edits in trunk/Source

Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
3:49 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:48 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:48 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:32 PM Changeset in webkit [87579] by adamk@chromium.org
  • 3 edits
    2 copies
    3 adds in trunk/LayoutTests

2011-05-27 Adam Klein <​adamk@chromium.org>

Unreviewed. More rebaselines after r87526.

  • platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-linux/svg/in-html/by-reference-expected.txt:
  • platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:14 PM Changeset in webkit [87578] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Always use the default localization strategy
​https://bugs.webkit.org/show_bug.cgi?id=61670
<rdar://problem/9516130>

Always use the default localization strategy when there's no platform strategy.

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::shared):
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultDetailsSummaryText): (WebCore::copyImageUnknownFileLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagCopyImageUrlToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagSelectAll): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchInSpotlight): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagShowFonts): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagStyles): (WebCore::contextMenuItemTagShowColors): (WebCore::contextMenuItemTagSpeechMenu): (WebCore::contextMenuItemTagStartSpeaking): (WebCore::contextMenuItemTagStopSpeaking): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagCorrectSpellingAutomatically): (WebCore::contextMenuItemTagSubstitutionsMenu): (WebCore::contextMenuItemTagShowSubstitutions): (WebCore::contextMenuItemTagSmartCopyPaste): (WebCore::contextMenuItemTagSmartQuotes): (WebCore::contextMenuItemTagSmartDashes): (WebCore::contextMenuItemTagSmartLinks): (WebCore::contextMenuItemTagTextReplacement): (WebCore::contextMenuItemTagTransformationsMenu): (WebCore::contextMenuItemTagMakeUpperCase): (WebCore::contextMenuItemTagMakeLowerCase): (WebCore::contextMenuItemTagCapitalize): (WebCore::contextMenuItemTagChangeBack): (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXARIAContentGroupText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::missingPluginText): (WebCore::crashedPluginText): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::uploadFileText): (WebCore::allFilesText): (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName): (WebCore::imageTitle): (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
2:55 PM Changeset in webkit [87577] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source/WebCore

Merge r87566.

2:50 PM Changeset in webkit [87576] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r87330.

2:50 PM Changeset in webkit [87575] by mrowe@apple.com
  • 13 edits
    3 adds in branches/safari-534-branch/Source

Merge r87228.

2:43 PM Changeset in webkit [87574] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87460.

2:37 PM Changeset in webkit [87573] by mrowe@apple.com
  • 11 edits in branches/safari-534-branch/Source

Merge r87329.

2:36 PM Changeset in webkit [87572] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

2:33 PM Changeset in webkit [87571] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87557.

2:25 PM Changeset in webkit [87570] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87414.

2:20 PM Changeset in webkit [87569] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87456.

2:18 PM Changeset in webkit [87568] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-534-branch

Merge r87322.

2:16 PM Changeset in webkit [87567] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87363.

2:15 PM Changeset in webkit [87566] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

First swipe at resolving <rdar://problem/9125145> and ​https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
2:15 PM Changeset in webkit [87565] by mrowe@apple.com
  • 16 edits in branches/safari-534-branch

Merge r87328.

2:12 PM Changeset in webkit [87564] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87442.

2:10 PM Changeset in webkit [87563] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87544.

2:08 PM Changeset in webkit [87562] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87421.

2:05 PM Changeset in webkit [87561] by enne@google.com
  • 3 edits in trunk/LayoutTests

2011-05-27 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
​https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
2:02 PM Changeset in webkit [87560] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source

Merge r87335.

1:59 PM Changeset in webkit [87559] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87397.

1:56 PM Changeset in webkit [87558] by adamk@chromium.org
  • 5 edits
    3 copies
    77 adds in trunk/LayoutTests

2011-05-27 Adam Klein <​adamk@chromium.org>

Unreviewed. Rebaselines and test expectations updates after r87526.

  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [87557] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

30 second rewind button obscured in fullscreen controller
​https://bugs.webkit.org/show_bug.cgi?id=61663

If reset() is called while in full-screen mode, make sure to show and hide
the correct controls for that mode.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
1:53 PM Changeset in webkit [87556] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87305.

1:51 PM Changeset in webkit [87555] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87272.

1:50 PM Changeset in webkit [87554] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87237.

1:48 PM Changeset in webkit [87553] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-534-branch

Merge r87387.

1:45 PM Changeset in webkit [87552] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87458.

1:43 PM Changeset in webkit [87551] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87524.

1:39 PM Changeset in webkit [87550] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.

  • runtime/JSGlobalData.cpp: (JSGlobalData::JSGlobalData):
1:37 PM Changeset in webkit [87549] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87361.

1:35 PM Changeset in webkit [87548] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-534-branch

Merge r87324.

1:29 PM Changeset in webkit [87547] by jamesr@google.com
  • 3 edits
    3 adds in trunk

2011-05-27 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
​https://bugs.webkit.org/show_bug.cgi?id=61590

  • compositing/iframes/resizer-expected.txt: Added.
  • compositing/iframes/resizer.html: Added.

2011-05-27 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
​https://bugs.webkit.org/show_bug.cgi?id=61590

Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
graphics layer tree consistent.

Test: compositing/iframes/resizer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
1:28 PM Changeset in webkit [87546] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87253.

1:25 PM Changeset in webkit [87545] by Nikolas Zimmermann
  • 1 edit
    1 move in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
​https://bugs.webkit.org/show_bug.cgi?id=10526

Fix last failing win/svg test, put result in correct directory.

  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.
1:22 PM Changeset in webkit [87544] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

  • WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
1:21 PM Changeset in webkit [87543] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.

1:18 PM Changeset in webkit [87542] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
The feature is tracked by the bug 61630.

  • platform/gtk/Skipped:
1:10 PM Changeset in webkit [87541] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87244.

1:10 PM Changeset in webkit [87540] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87275.

12:53 PM Changeset in webkit [87539] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLVideoElement::currentSrc() should return a KURL
​https://bugs.webkit.org/show_bug.cgi?id=61578

I suspect we got into this mess because the author of this code didn't
know about the URL attribute in WebKit IDL, which is super useful!

Bad news: The line of code in question seems to have another bug, which
I've documented in a FIXME. Let the yak shaving continue!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::currentURL):
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
    • This complete URL call was unnecessary because currentSrc is already absolute.
12:52 PM Changeset in webkit [87538] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
​https://bugs.webkit.org/show_bug.cgi?id=61177

  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className):
12:50 PM Changeset in webkit [87537] by Adam Roben
  • 2 edits in trunk/Tools

Always decode tester names from location.hash

When navigating directly to a tester-specific URL (e.g.,
<​http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.

12:48 PM Changeset in webkit [87536] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Add a few validity assertions to JSCallbackObject
​https://bugs.webkit.org/show_bug.cgi?id=61659

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::visitChildren):
12:44 PM Changeset in webkit [87535] by Nikolas Zimmermann
  • 4 edits
    8 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
​https://bugs.webkit.org/show_bug.cgi?id=10526

Rebaseline some qt/win/leopard results.

  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
12:32 PM Changeset in webkit [87534] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Rob Buis.

embedded SVG object doesn't scale right
​https://bugs.webkit.org/show_bug.cgi?id=10526

Fixes crash in svg/custom/immutable-properties.html, seen on the bots.

  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
12:32 PM Changeset in webkit [87533] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-27 Nat Duca <​nduca@chromium.org>

Unreviewed, landed by ​enne@google.com.

[chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
​https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium/test_expectations.txt:
11:56 AM Changeset in webkit [87532] by rniwa@webkit.org
  • 2 adds in trunk/LayoutTests/platform/chromium-win/editing/pasteboard

Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.

11:52 AM Changeset in webkit [87531] by rniwa@webkit.org
  • 3 edits
    2 adds
    19 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=61610

Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.

  • editing/pasteboard/paste-pre-001-expected.txt: Added.
  • editing/pasteboard/paste-pre-001.html:
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.
11:49 AM Changeset in webkit [87530] by Adam Roben
  • 2 edits in trunk/Tools

Remove testing code that snuck into r87528

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.

11:47 AM Changeset in webkit [87529] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

11:41 AM Changeset in webkit [87528] by Adam Roben
  • 3 edits in trunk/Tools

Add links to TestFailures to easily file bugs about failing tests

Fixes <​http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!

11:30 AM Changeset in webkit [87527] by oliver@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Try to release unused executable memory when the FixedVMPool allocator is under pressure
​https://bugs.webkit.org/show_bug.cgi?id=61651

Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h:
  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::linkCode):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::executableCopy):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::executableCopy):
  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy): (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::create): (JSC::ExecutablePool::alloc): (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutableAllocator::poolForSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::alloc):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator): (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::releaseExecutableMemory): (JSC::releaseExecutableMemory):
  • runtime/JSGlobalData.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::invalidateCode):
  • runtime/RegExpCache.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::compile):
11:27 AM Changeset in webkit [87526] by Nikolas Zimmermann
  • 18 edits
    92 adds in trunk

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
​https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
​https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
​https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
​https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
​https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
​https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
​https://bugs.webkit.org/show_bug.cgi?id=37086

  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
  • http/tests/misc/resources/embedded.svg: Added.
  • http/tests/misc/resources/svg-slow.pl: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • svg/custom/object-no-size-attributes.xhtml: Added.
  • svg/custom/object-sizing-explicit-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width.xhtml: Added.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
  • svg/custom/object-sizing-no-width-height.xhtml: Added.
  • svg/custom/object-sizing.xhtml: Added.
  • svg/custom/resources/embedded.svg: Added.
  • svg/custom/resources/red-circle.svg: Added.
  • svg/in-html/by-reference-expected.png:
  • svg/wicd: Added.
  • svg/wicd/resources: Added.
  • svg/wicd/resources/a.svg: Added.
  • svg/wicd/resources/bcde.svg: Added.
  • svg/wicd/resources/empty1.svg: Added.
  • svg/wicd/resources/empty2.svg: Added.
  • svg/wicd/resources/empty3.svg: Added.
  • svg/wicd/resources/f.svg: Added.
  • svg/wicd/resources/g.svg: Added.
  • svg/wicd/resources/h.svg: Added.
  • svg/wicd/resources/i.svg: Added.
  • svg/wicd/resources/j.svg: Added.
  • svg/wicd/resources/k.svg: Added.
  • svg/wicd/resources/l.svg: Added.
  • svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
  • svg/wicd/resources/mnop.svg: Added.
  • svg/wicd/resources/q.svg: Added.
  • svg/wicd/resources/r.svg: Added.
  • svg/wicd/resources/s.svg: Added.
  • svg/wicd/resources/t.svg: Added.
  • svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
  • svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
  • svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
  • svg/wicd/rightsizing-grid.xhtml: Added.
  • svg/wicd/test-rightsizing-a.xhtml: Added.
  • svg/wicd/test-rightsizing-b.xhtml: Added.
  • svg/zoom/page/resources: Added.
  • svg/zoom/page/resources/absolute-sized-svg.png: Added.
  • svg/zoom/page/resources/absolute-sized-svg.svg: Added.
  • svg/zoom/page/resources/huge-rect.svg: Added.
  • svg/zoom/page/resources/percentage-sized-svg.png: Added.
  • svg/zoom/page/resources/percentage-sized-svg.svg: Added.
  • svg/zoom/page/resources/text.svg: Added.
  • svg/zoom/page/resources/tux.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
​https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
​https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
​https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
​https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
​https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
​https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
​https://bugs.webkit.org/show_bug.cgi?id=37086

Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (​http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.

If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml

svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/Length.h: (WebCore::Length::isSpecified):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h:
11:11 AM Changeset in webkit [87525] by jochen@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-05-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] drop unused WebFrame parameter to WebStorageArea::setItem
​https://bugs.webkit.org/show_bug.cgi?id=61583

  • public/WebStorageArea.h:
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
  • src/WebStorageAreaImpl.h:
10:52 AM Changeset in webkit [87524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Michael Saboff <​msaboff@apple.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=61646
Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font

Change the platformIsEqual to just compare the m_font members if
either is not null.

No tests added - functionality unchanged, fixing memory abandonment.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::platformIsEqual):
10:39 AM Changeset in webkit [87523] by Martin Robinson
  • 7 edits
    3 adds in trunk

2011-05-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
​https://bugs.webkit.org/show_bug.cgi?id=60917

Added a GTK+ specific test that verifies that zero pixel sized
fonts do not corrupt the Cairo context.

  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.

2011-05-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
​https://bugs.webkit.org/show_bug.cgi?id=60917

When instantiating a cairo_scaled_font_t font would put the font in an error state,
leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
in the error state can later lead to corrupted rendering.

Due to this change, we must always null check cairo_scaled_font_t and the platform
data now carries the cairo_font_face_t object with it, so that it can be accessed later
if there is no cairo_scaled_font_t.

Test: platform/gtk/fonts/zero-pixel-sized-fonts.html

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
  • platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Initialize the new member. (WebCore::FontPlatformData::operator=): Carry over the new member. (WebCore::FontPlatformData::operator==): Check equality with the new member. (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont put the font into an error state, then just free it and return. (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap when the scaled font is null, because rendering is always a no-op and the font data never needs to be read.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font. (WebCore::SimpleFontData::scaledFontData): Use the new m_font member. (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
10:39 AM Changeset in webkit [87522] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized ConservativeSet to avoid double-visiting objects
​https://bugs.webkit.org/show_bug.cgi?id=61592


SunSpider thinks this might be a 1% speedup

  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting an object.
  • heap/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type to void*, since clients want to ask questions about arbitrary pointers into the heap, even when they aren't known to be JSCells.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::testAndClearMarked):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::testAndClearMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Ditto.
  • wtf/Bitmap.h: (WTF::::testAndClear): New function for ConservativeRoots's inverted marking pass.
10:25 AM Changeset in webkit [87521] by levin@chromium.org
  • 9 edits in trunk/Source

Need a callback for when the preferred rendered size may have changed.
​https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::layoutUpdated): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h:

(WebCore::ChromeClient::layoutUpdated): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Added a callback for whem a layout has finished.

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didUpdateLayout): Added stub.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.

  • src/ChromeClientImpl.h: Added declaration.
9:59 AM Changeset in webkit [87520] by Stephanie Lewis
  • 11 edits
    1 add in trunk/Source

Rubber Stamped by Adam Roben.

Source/JavaScriptCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

Source/WebCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebCore.order:

Source/WebKit/mac:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebKit.order:

Source/WebKit2:

Add Order File. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • mac/WebKit2.order: Added.
9:34 AM Changeset in webkit [87519] by commit-queue@webkit.org
  • 21 edits
    6 deletes in trunk

2011-05-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
​http://trac.webkit.org/changeset/87464
​https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • http/tests/websocket/tests/client-close-expected.txt: Removed.
  • http/tests/websocket/tests/client-close.html: Removed.
  • http/tests/websocket/tests/client-close_wsh.py: Removed.
  • http/tests/websocket/tests/close-before-open-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html:
  • http/tests/websocket/tests/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/server-close-expected.txt: Removed.
  • http/tests/websocket/tests/server-close.html: Removed.
  • http/tests/websocket/tests/server-close_wsh.py: Removed.
  • http/tests/websocket/tests/websocket-event-target-expected.txt:

2011-05-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
​http://trac.webkit.org/changeset/87464
​https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): (WebCore::SocketStreamHandleBase::close): (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
​http://trac.webkit.org/changeset/87464
​https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • Scripts/webkitpy/thirdparty/init.py:
9:19 AM Changeset in webkit [87518] by rwlbuis@webkit.org
  • 3 edits
    2 adds
    3 deletes in trunk

2011-05-27 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Remove 003-broken.xml and replace it with a 003.xml that is text-only.

  • platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
  • svg/hixie/links/003-broken.xml: Removed.
  • svg/hixie/links/003-expected.txt: Added.
  • svg/hixie/links/003.xml: Added.

2011-05-27 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Only allow links to animation elements within the document.

Test: svg/hixie/links/003.xml

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
9:14 AM Changeset in webkit [87517] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-27 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
​https://bugs.webkit.org/show_bug.cgi?id=60757

cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint):
9:10 AM Changeset in webkit [87516] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

8:41 AM Changeset in webkit [87515] by ap@apple.com
  • 2 edits in trunk/Tools

Added Douglas Davidson to contributors list for easier CC'ing.

  • Scripts/webkitpy/common/config/committers.py:
8:34 AM Changeset in webkit [87514] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
​https://bugs.webkit.org/show_bug.cgi?id=61044

Make sure to set the active window on the application too.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette):
8:19 AM Changeset in webkit [87513] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

WebKit2 does not support eventSender.

  • platform/mac-wk2/Skipped:
8:03 AM Changeset in webkit [87512] by andreas.kling@nokia.com
  • 16 edits in trunk

2011-05-27 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
​https://bugs.webkit.org/show_bug.cgi?id=61449

HTML5 now specifies that fully transparent colors should have their alpha value
serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)

The number of decimals for alpha values between 0 and 1 is not specified,
so match Gecko and Presto by returning the lowest number of decimals needed
to represent the number. (No more trailing zeroes.)

  • platform/graphics/Color.cpp: (WebCore::Color::serialized):

2011-05-27 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
​https://bugs.webkit.org/show_bug.cgi?id=61449

Update tests to reflect the new behavior.

  • canvas/philip/tests/2d.fillStyle.get.transparent.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
  • editing/style/inline-style-container-expected.txt
  • editing/style/script-tests/inline-style-container.js:
  • fast/canvas/canvas-color-clamping-expected.txt:
  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/canvas-currentColor-expected.txt:
  • fast/canvas/script-tests/canvas-color-clamping.js:
  • fast/canvas/script-tests/canvas-color-serialization.js:
  • fast/canvas/script-tests/canvas-currentColor.js:
  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
  • fast/dom/canvasContext2d-element-attribute-js-null.html:
7:35 AM Changeset in webkit [87511] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that requires eventSender.beginDragWithFiles.

  • platform/win/Skipped:
7:23 AM Changeset in webkit [87510] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that is failing until investigated.

  • platform/gtk/Skipped:
7:19 AM Changeset in webkit [87509] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-26 Jeff Miller <​jeffm@apple.com>

Reviewed by Alexey Proskuryakov.

Add a key handling logging channel for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=61588


Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

  • Platform/Logging.cpp: (WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
  • Platform/Logging.h: Added LogKeyHandling channel.
  • UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment. (WebKit::webKeyboardEventTypeString): Added to support logging. (WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event. (WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
7:02 AM Changeset in webkit [87508] by hans@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-27 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
​https://bugs.webkit.org/show_bug.cgi?id=61615

New test for adding new entries to an objecet store while running a
cursor over it.

  • storage/indexeddb/mutating-cursor-expected.txt: Added.
  • storage/indexeddb/mutating-cursor.html: Added.

2011-05-27 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
​https://bugs.webkit.org/show_bug.cgi?id=61615

We need to support the case where a new node is added to the tree in a
transaction after the TreeIterator has covered the whole tree.

Since this is done lazily, i.e. we set a flag that the tree might have
changed, and act upon it later, some members need to be mutable,
because we might need to re-seek the tree iterator in a const function.

Test: storage/indexeddb/mutating-cursor.html

storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)

  • platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::treeChanged): (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
  • platform/leveldb/LevelDBTransaction.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::open):
6:51 AM Changeset in webkit [87507] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Sujin Park <​sujjin.park@gmail.com>

Unreviewed, buildfix if --no-javascript-debugger.

Regression(R84125): Broke GTK build
​https://bugs.webkit.org/show_bug.cgi?id=60698

No new tests since this doesn't change any behavior.

  • inspector/WorkerInspectorController.h:
6:48 AM Changeset in webkit [87506] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Daily gardening.

Typo fix, and remove non-existent files from Skipped list.

  • platform/qt-mac/Skipped:
6:12 AM Changeset in webkit [87505] by Csaba Osztrogonác
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt][Mac] Daily gardening.

  • platform/qt-mac/Skipped:
    • plugins/embed-attributes-setting.html was unskipped by r87306, but fails on Qt-Mac.
    • plugins/plugin-initiate-popup-window.html unskipped by r87429, but fails on Qt-Mac.
    • fast/css/disabled-author-styles unskipped by r87311, but fails on Qt-Mac.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Added after r87468.
5:59 AM Changeset in webkit [87504] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip test that is failing on the bot, until investigated.

  • platform/chromium/test_expectations.txt:
5:48 AM Changeset in webkit [87503] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip new dropzone tests. Qt's DRT does not support drag 'n drop.

  • platform/qt/Skipped:
5:46 AM Changeset in webkit [87502] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress editing/pasteboard/smart-paste-004.html on Win after r87496

5:43 AM Changeset in webkit [87501] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreveiwed, suppress editing/pasteboard/smart-paste-003.html on Win after r87495

5:42 AM Changeset in webkit [87500] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[WK2] Skip new failing tests because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped: Add failing tests.
  • platform/qt-wk2/Skipped: Remove tests, because they fail because of WK2 specific bug, not Qt-WK2 specific.
5:37 AM Changeset in webkit [87499] by yael.aharon@nokia.com
  • 7 edits
    9 adds in trunk

webkit should implement the dropzone attribute
​https://bugs.webkit.org/show_bug.cgi?id=58210

Reviewed by Tony Chang.

Source/WebCore:

Add support for dropzone attribute.
​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
If there is such an element, and it matches the drag data store, set the action defined by that
element and continue processing the drag and drop operation.

Tests: fast/events/dropzone-001.html

fast/events/dropzone-002.html
fast/events/dropzone-003.html
fast/events/dropzone-004.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::Clipboard::processDropZoneKeyword):

  • dom/Clipboard.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.idl:
  • page/EventHandler.cpp:

(WebCore::EventHandler::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):

  • page/EventHandler.h:

LayoutTests:

  • fast/events/dropzone-001-expected.txt: Added.
  • fast/events/dropzone-001.html: Added.
  • fast/events/dropzone-002-expected.txt: Added.
  • fast/events/dropzone-002.html: Added.
  • fast/events/dropzone-003-expected.txt: Added.
  • fast/events/dropzone-003.html: Added.
  • fast/events/dropzone-004-expected.txt: Added.
  • fast/events/dropzone-004.html: Added.
  • fast/events/resources/dropzone.js: Added.
5:20 AM Changeset in webkit [87498] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=60175

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped: The bug is in Qt 4.8, add Qt bug tracker URL's.
4:57 AM Changeset in webkit [87497] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Make the bot environmentally friendly.

  • platform/qt-wk2/Skipped:
4:44 AM Changeset in webkit [87496] by rniwa@webkit.org
  • 4 edits
    1 move
    2 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-004.html through smart-paste-006.html to dumpAsText tests
​https://bugs.webkit.org/show_bug.cgi?id=61618

Converted smart-paste-004.html, smart-paste-005.html, and smart-paste-005.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-004-expected.txt: Added.
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005-expected.txt: Added.
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-006-expected.txt: Added.
  • editing/pasteboard/smart-paste-006.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt: Removed.
4:38 AM Changeset in webkit [87495] by rniwa@webkit.org
  • 4 edits
    3 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
​https://bugs.webkit.org/show_bug.cgi?id=61617

Converted smart-paste-001.html, smart-paste-002.html, and smart-paste-003.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-001-expected.txt: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002-expected.txt: Added.
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003-expected.txt: Added.
  • editing/pasteboard/smart-paste-003.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Removed.
4:36 AM Changeset in webkit [87494] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r87467.

  • page/wince/FrameWinCE.cpp:
4:22 AM Changeset in webkit [87493] by rniwa@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-unrendered-select.html to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=61616

Converted paste-unrendered-select.html to a dump-as-markup test.

  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html:
  • platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
4:16 AM Changeset in webkit [87492] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-27 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=61397

  • platform/chromium/test_expectations.txt:

2011-05-27 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=61397

  • features.gypi:
3:54 AM Changeset in webkit [87491] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
​https://bugs.webkit.org/show_bug.cgi?id=61517

Support cursors where the direction is set to NEXT_NO_DUPLICATE,
or PREV_NO_DUPLICATE, as specified here:
​http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE

This is tested by storage/indexeddb/mozilla/indexes.html

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
3:37 AM Changeset in webkit [87490] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

LevelDB: turn on paranoid checks and verify checksums, log errors
​https://bugs.webkit.org/show_bug.cgi?id=61516

This allows for detection of corrupted databases.
Even if we can't recover from a corrupted database, discovering the
problem is a step in the right direction.

No new functionality, no new tests.

  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::checkStatus): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::LevelDBDatabase::createIterator):
3:16 AM Changeset in webkit [87489] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark fast/canvas/webgl/uniform-location.html as timing out

2:36 AM Changeset in webkit [87488] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/InspectorFrontendHost.cpp

Merge 86551 - 2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:

TBR=​loislo@chromium.org
Review URL: ​http://codereview.chromium.org/7062045

2:30 AM Changeset in webkit [87487] by apavlov@chromium.org
  • 7 edits
    2 copies in branches/chromium/742

Merge 86507 - 2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:

TBR=​loislo@chromium.org
Review URL: ​http://codereview.chromium.org/7062044

2:11 AM Changeset in webkit [87486] by rniwa@webkit.org
  • 3 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=61614

Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.

  • editing/pasteboard/paste-text-002-expected.txt: Added.
  • editing/pasteboard/paste-text-002.html:
  • editing/pasteboard/paste-text-003-expected.txt: Added.
  • editing/pasteboard/paste-text-003.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
1:26 AM Changeset in webkit [87485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

CachedResourceLoader stores data: urls in validated URL set
​https://bugs.webkit.org/show_bug.cgi?id=61604

CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource):
1:01 AM Changeset in webkit [87484] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(

12:56 AM Changeset in webkit [87483] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

2011-05-23 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] DocumentMarker should be carried around as a pointer, not value.
​https://bugs.webkit.org/show_bug.cgi?id=61262

  • Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
  • Introduced markersFor() that returns Vector<DocumentMarker*>
  • Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by RenderedDocumentMarker::setRenderedRect().
  • This change didn't remove markersForNode() beucase there is patches on review which depends markersForNode(). I'll remove its call after these patches are landed.

No new tests. No behavior change.

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::markersFor): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
  • dom/DocumentMarkerController.h:
  • dom/RenderedDocumentMarker.h: (WebCore::toRenderedDocumentMarker):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
12:54 AM Changeset in webkit [87482] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460

12:45 AM Changeset in webkit [87481] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux

12:26 AM Changeset in webkit [87480] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-05-26 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary crashes
​https://bugs.webkit.org/show_bug.cgi?id=61511

  • fast/html/details-summary-document-child-expected.txt: Added.
  • fast/html/details-summary-document-child.html: Added.

2011-05-26 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
​https://bugs.webkit.org/show_bug.cgi?id=61511

Removed Unnecessary wrong cast to Elmement, which can be non-Element.

Test: fast/html/details-summary-document-child.html

  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::detailsElement):
Note: See TracTimeline for information about the timeline view.