⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 29, 2011:

11:25 PM Changeset in webkit [87677] by mrowe@apple.com
  • 5 edits in tags/Safari-534.41.1/Source

Versioning.

11:23 PM Changeset in webkit [87676] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41.1

New tag.

11:22 PM Changeset in webkit [87675] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87657.

11:22 PM Changeset in webkit [87674] by yutak@chromium.org
  • 21 edits
    4 copies
    2 adds in trunk

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
11:17 PM Changeset in webkit [87673] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

More IMAGE results.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
11:07 PM Changeset in webkit [87672] by abarth@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Add image baselines for all these beautiful platforms.

  • platform/chromium-linux-x86/fullscreen: Added.
  • platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac/fullscreen: Added.
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-win-vista/fullscreen: Added.
  • platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
10:54 PM Changeset in webkit [87671] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-29 Adam Barth <​abarth@webkit.org>

Attempt to fix build by implementing pure virtual function.

  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::shouldHideControls):
  • html/shadow/MediaControlRootElementChromium.h:
10:20 PM Changeset in webkit [87670] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

10:19 PM Changeset in webkit [87669] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41

New tag.

9:41 PM Changeset in webkit [87668] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87654.

9:40 PM Changeset in webkit [87667] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87642.

9:34 PM Changeset in webkit [87666] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87643.

9:32 PM Changeset in webkit [87665] by mrowe@apple.com
  • 14 edits
    3 adds in branches/safari-534-branch

Merge r87660.

9:20 PM Changeset in webkit [87664] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87655.

9:18 PM Changeset in webkit [87663] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87661.

9:14 PM Changeset in webkit [87662] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87652.

8:37 PM Changeset in webkit [87661] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-29 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Darin Adler.

Controls never hide in full screen after user stops moving mouse
​https://bugs.webkit.org/show_bug.cgi?id=61715
<rdar://problem/9522182>

When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
show the media controls, and then start a timer.

The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
move), and hides the controls.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer. (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen

controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
to play.

(WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future

if we are in full screen.

(WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and

we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.

(WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
(WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the

controls and start a timer to hide them.

(WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't

have the move the mouse once they enter full screen to hide the controls.

(WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls. (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that

the caller should hide the controls if the panel is not hovered.

  • html/shadow/MediaControlRootElement.h:
7:05 PM Changeset in webkit [87660] by jer.noble@apple.com
  • 14 edits
    3 adds in trunk

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
​https://bugs.webkit.org/show_bug.cgi?id=61712

  • fullscreen/full-screen-iframe-zIndex-expected.txt: Added.
  • fullscreen/full-screen-iframe-zIndex.html: Added.
  • platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
​https://bugs.webkit.org/show_bug.cgi?id=61712

Tests: fullscreen/full-screen-iframe-zIndex.html

Walk up the ancestor chain for the full-screen element, marking them as full-screen
ancestors. Then, we apply a pseudo-class to those elements, which disable all their
stacking-context-creating styles. Set the z-index of all full-screen elements (and
the iframes which contain them) to a large value, ensuring they appear above other
sibling elements.

This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
and pesudo-class, so remove it and replace it with the new pseudo-class.

  • css/CSSSelector.cpp: (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove

-webkit-full-screen-media-document.

(WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove

PseudoFullScreenMediaDocument

(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the

PseudoFullScreenMediaDocument implementation and replace it with
PseudoFullScreenAncestor.

  • css/fullscreen.css: (:-webkit-full-screen): Add a z-index property. (:-webkit-full-screen-ancestor:not(iframe)): Added. Reset the z-index to

auto, and reset other stacking-context creating properties.

  • dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element

instead of just the iframe elements.

(WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.

  • dom/Element.cpp: (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property. (WebCore::Element::insertedIntoTree): Ditto. (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase. (WebCore::Element::setContainsFullScreenElement): Ditto.
  • dom/Element.h:
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for

m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
  • html/HTMLFrameElementBase.h:
  • rendering/style/RenderStyleConstants.h:
5:49 PM Changeset in webkit [87659] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Add expected result.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
5:42 PM Changeset in webkit [87658] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Slightly adjust the type of the expected failure.

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [87657] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
​https://bugs.webkit.org/show_bug.cgi?id=61714

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
new full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
the full screen element.

  • dom/Element.h:

(WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
(WebCore::Element::willStopBeingFullscreenElement): Ditto.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
MediaControls::enteredFullscreen().
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
MediaControls::exitedFullscreen().

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
changes to the fullscreen-ness of the element.

5:19 PM Changeset in webkit [87656] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=61707

Second try at this. First try could lead to a WKView leak.

  • UIProcess/mac/WKFullScreenWindowController.h: Added _isExitingAcceleratedCompositingMode. Needed to track whether we have retained so we don't leak if the page goes away before we get the callback.
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Added code to set the new variable to YES. (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Added code to deal with the new boolean and to release. (exitCompositedModeRepaintCompleted): Removed the release that was here. (-[WKFullScreenWindowController close]): Added a call to exitCompositedModeRepaintCompleted here. We're as complete as we'll ever be when we're closed; we can't get the callback after that point.
5:00 PM Changeset in webkit [87655] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
​https://bugs.webkit.org/show_bug.cgi?id=61713

We need to come up with a way to regression-test these changes. Nothing at the moment.

The bug is that we removed calls to preventDefault, but we still do need to prevent
default handling of this event.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault that was in here before r87622 as well as the stopPropagation that was added in r87622. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
3:14 PM Changeset in webkit [87654] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r87637): nytimes.com freezes after going back to it
<rdar://problem/9521928>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
Add call to setShouldNotifyAfterNextScheduledLayerFlush(false) to prevent a
redundant call to layerHostDidFlushLayers which would cause the layer state
to get out of sync with the UIProcess.

2:56 PM Changeset in webkit [87653] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-05-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Some heap refactoring
​https://bugs.webkit.org/show_bug.cgi?id=61704


SunSpider says no change.

  • heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

(JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

(JSC::Heap::allocate): Changed inline allocation code to only select the
size class, since this can be optimized out at compile time -- everything
else is now inlined into this out-of-line function.


No need to duplicate ASSERTs made in our caller.

  • heap/Heap.h: (JSC::Heap::heap): (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding a layer of indirection through MarkedSpace.

(JSC::Heap::allocate): See above.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::create): (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::allocate): Updated to match changes above.
2:28 PM Changeset in webkit [87652] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
​https://bugs.webkit.org/show_bug.cgi?id=61710

When taking the documentElement full screen, we don't create a RenderFullScreen
object and thus never enter accelerated compositing mode for the animation. Tell
the WKFullScreenWindowController to enter accelerated compositing mode anyway
(with an empty layer context) so as to fulfill its expectations and cause the
full screen animation to complete.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a

comment explaining when we expect the animation to complete.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):

Remove an ASSERT which is no longer valid.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess

to enter then exit full-screen mode.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

2:01 PM Changeset in webkit [87651] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87633.

2:01 PM Changeset in webkit [87650] by mrowe@apple.com
  • 11 edits
    2 adds in branches/safari-534-branch

Merge r87628.

1:57 PM Changeset in webkit [87649] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87637.

1:56 PM Changeset in webkit [87648] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87634.

1:54 PM Changeset in webkit [87647] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87639.

1:54 PM Changeset in webkit [87646] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source/WebKit2

Merge r87638.

1:45 PM Changeset in webkit [87645] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-29 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Element: Micro-cleanup of scroll methods.
​https://bugs.webkit.org/show_bug.cgi?id=61705

Do an early return without calculating element boundaries when asked
to scroll an element without a renderer().

  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::scrollByUnits):
1:12 PM Changeset in webkit [87644] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=61707

Saw this while debugging a crash. We don't have a way to make regression tests for this
kind of issue at this time.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller here since we are keeping a pointer to it. (exitCompositedModeRepaintCompleted): Release the controller here.
1:12 PM Changeset in webkit [87643] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Fix assertion seen when entering full screen mode for standalone video
​https://bugs.webkit.org/show_bug.cgi?id=61708

We don't currently have a way to make a regression test for this.

  • dom/Document.cpp: (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc, because scheduleStyleRecalc is intended to only be called when the style system itself detects recalc is needed.
1:06 PM Changeset in webkit [87642] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
​https://bugs.webkit.org/show_bug.cgi?id=61706
<rdar://problem/9521970>

If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
12:38 PM Changeset in webkit [87641] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-29 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
​https://bugs.webkit.org/show_bug.cgi?id=61162

Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
that omits a line count. In particular, the chunk range regular expression does
not match a chunk range line that omits a line count. GNU diff(1) will omit the
line count in the chunk range if the line count is exactly 1. For example, appending
a new line to the end of an existing file F that contains exactly one line of text will
be represented in a diff with a chunk range line that omits the line count for F.

  • Scripts/VCSUtils.pm: (parseChunkRange): Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added unit test "Git: Append new line to the end of an existing file".
12:13 PM Changeset in webkit [87640] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Andreas Kling <​kling@webkit.org>

Reviewed by James Robinson.

[Qt] Add area check to ImageBufferData::getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
12:00 PM Changeset in webkit [87639] by Darin Adler
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <Beth Dakin> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.

  • page/ChromeClient.h:

(WebCore::ChromeClient::setRenderTreeSize):

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

  • rendering/RenderArena.h:

(WebCore::RenderArena::totalRenderArenaSize):

11:13 AM Changeset in webkit [87638] by Darin Adler
  • 7 edits in trunk/Source/WebKit2

2011-05-29 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

  • UIProcess/API/C/WKPage.cpp: (WKPageGetRenderTreeSize):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::renderTreeSize): (WebKit::WebPageProxy::setRenderTreeSize):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setRenderTreeSize):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:03 AM Changeset in webkit [87637] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

2:49 AM Changeset in webkit [87636] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-27 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Data directory is webkitgtk-x.y not webkit-x.y
​https://bugs.webkit.org/show_bug.cgi?id=61642

  • GNUmakefile.am: updated data directory.
1:30 AM Changeset in webkit [87635] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87566.
​http://trac.webkit.org/changeset/87566
​https://bugs.webkit.org/show_bug.cgi?id=61702

It made all tests assert on Qt in debug mode (Requested by
Ossy_weekend on #webkit).

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suggestedMIMEType): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • platform/mac/HTMLConverter.mm: (fileWrapperForElement):
12:04 AM Changeset in webkit [87634] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't add sub-frames to global history when navigating via back/forward
​https://bugs.webkit.org/show_bug.cgi?id=61701
<rdar://problem/9521222>

Instead of just checking whether the load is the first in the frame, we also need to
check to make sure we're loading in the main frame.

Not testable due to lack of global history infrastructure in DRT.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

May 28, 2011:

9:42 PM Changeset in webkit [87633] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Suggested by Simon Fraser.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
​https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use ASSERT_UNUSED here.
7:46 PM Changeset in webkit [87632] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87624.

7:44 PM Changeset in webkit [87631] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87622.

7:42 PM Changeset in webkit [87630] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebKit2

Merge r87627.

7:41 PM Changeset in webkit [87629] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87598.

6:37 PM Changeset in webkit [87628] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Geoff Garen.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
​https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

Test: fast/dom/gc-image-element-2.html

Manually verified that tests from bug 59604 and from bug 40926 still pass.

The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::wasCanceled): (WebCore::CachedResource::errorOccurred): Track whether the load was canceled. We want to always notify clients of load outcome, as that's the only way they could make intelligent decisions.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now get a notifyFinished call on cancellation. Handle this case, where we don't need the execute the script, but also don't need to fire an error event.
  • html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single function call now.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large window between when CachedResource::isLoading() becomes false and events are queued. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting an event to fire.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do anything on cancellation.
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to give an accurate result while looping over the list of events to dispatch. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to switch to a broken image icon, or to dispatch events. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching list, as the event is no longer pending when it's being dispatched.
  • loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one is already pending, we only care if one is expected at some time in the future, and !haveFiredLoadEvent() is our best idea of that.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to handle cancellation.
4:45 PM Changeset in webkit [87627] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

2011-05-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Maciej Stachowiak.

Denying access to your keychain on login crashes WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=61695
<rdar://problem/9520570>

Fix two sources of crashes if you hit the Deny button when WebKit2 is
doing HTTP authentication.

First, SecKeychainItemRequestData::attributeList() failed to initialize the
length and data members of SecKeychainAttributes in the list if there was no data.
This caused invalid memory reads later.

Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
would cause a later crash in a system framework, which is not set up to handle
errors. Instead, we always return noErr, and allow the authentication to fail.

Finally, paranoically initialize the SecKeychainItemContext in two places
to avoid uninitialized data members, and initialize length and outData
to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
fails to set them on error.

  • Shared/mac/SecKeychainItemRequestData.cpp: (WebKit::SecKeychainItemRequestData::attributeList):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::secKeychainItemCopyContent):
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCopyContent): (WebKit::webSecKeychainItemCreateFromContent):
3:26 PM Changeset in webkit [87626] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS builds patches that fail to build twice, which seems useless and slows down the bots
​https://bugs.webkit.org/show_bug.cgi?id=55585

This patch switches all the early warning system bots over to the new
PatchAnalysisTask-based infrastructure. This patch makes these bots
more efficient (in the case where patches fail to build) and paves the
way for running tests on these bots!

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
2:45 PM Changeset in webkit [87625] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-05-28 Martin Robinson <​mrobinson@igalia.com>

Skip a failing test and better classify some existing skipped tests.

  • platform/gtk/Skipped: Update the skipped list.
1:39 PM Changeset in webkit [87624] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r86578): Flash content missing from mercurynews.com
​https://bugs.webkit.org/show_bug.cgi?id=61691
<rdar://problem/9519893>

If the plug-in doesn't have access to the toplevel URL, make sure to
return *something* to the plug-in.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
12:59 PM Changeset in webkit [87623] by abarth@webkit.org
  • 23 edits in trunk/Source

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::cancelledError): (WebCore::FrameLoaderClientQt::blockedError): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest): (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::cancelledError): (WebCore::FrameLoaderClientEfl::blockedError):
  • ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): (ewk_frame_uri_changed):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_frame_create): (ewk_view_plugin_create):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

As far as I can tell, all the callers of this API are confused. There
seems to be a cargo cult of using the "pretty" version of a URL, but in
reality folks just want the URL itself. The only case I'm unsure about
is location.href, which could have some compatibility constraints.
I've renamed prettyURL to deprecatedString to discourage folks from
further cargo-culting.

  • WebCore.exp.in:
  • page/Location.cpp: (WebCore::Location::href): (WebCore::Location::toString):
  • platform/KURL.cpp: (WebCore::KURL::deprecatedString):
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURL::deprecatedString):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::href): (WebCore::WorkerLocation::toString):

2011-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
​https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::cancelledError): (WebKit::blockedError):
12:41 PM Changeset in webkit [87622] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-28 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Mouse clicks propagate outside full-screen media controls.
​https://bugs.webkit.org/show_bug.cgi?id=61689

Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block

propagation of all mouse click events.

(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):

Renamed from setDefaultHandled.

(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

  • html/shadow/MediaControlElements.h:
11:49 AM Changeset in webkit [87621] by mrowe@apple.com
  • 5 edits in tags/Safari-534.40.1/Source

Versioning.

11:37 AM Changeset in webkit [87620] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40.1

New tag.

11:37 AM Changeset in webkit [87619] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87331.

11:18 AM Changeset in webkit [87618] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-28 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-28 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
10:55 AM Changeset in webkit [87617] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
10:02 AM Changeset in webkit [87616] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial lyAligned
​https://bugs.webkit.org/show_bug.cgi?id=61606

Removed duplicated statement within if condition.

No new tests. Obvious clean up patch.

  • page/SpatialNavigation.cpp: (WebCore::areRectsPartiallyAligned):
9:16 AM Changeset in webkit [87615] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, clean up GPU tests expectations

8:43 AM Changeset in webkit [87614] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX when building only the interpreter

Fixes the following compiler warning:

JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]

void releaseExecutableMemory(JSGlobalData& globalData)


  • jit/ExecutableAllocator.h: Moved declaration of

JSC::releaseExecutableMemory().

8:27 AM Changeset in webkit [87613] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

8:24 AM Changeset in webkit [87612] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode): Added missing argument.

5:15 AM Changeset in webkit [87611] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-28 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=60311

If there is no editable text Qt interprets backspace as a navigation
command, regardless of platform.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.
5:06 AM Changeset in webkit [87610] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

3:32 AM Changeset in webkit [87609] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

1:50 AM Changeset in webkit [87608] by mnaganov@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed. Test expectations update after r87605

  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.
1:27 AM Changeset in webkit [87607] by bashi@chromium.org
  • 2 edits in trunk/Tools

2011-05-28 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

Add bashi as a committer.

​https://bugs.webkit.org/show_bug.cgi?id=61685

  • Scripts/webkitpy/common/config/committers.py:
12:17 AM Changeset in webkit [87606] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-05-28 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/style/non-inheritable-styles should be dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=61681

Converts the test to dump-as-markup and cleans up the HTML a bit.

  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html:
  • platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.