⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 30, 2011:

11:28 PM Changeset in webkit [87713] by koz@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-30 James Kozianski <​koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
​https://bugs.webkit.org/show_bug.cgi?id=61759

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt: Added.

2011-05-30 James Kozianski <​koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
​https://bugs.webkit.org/show_bug.cgi?id=61759

Also, detect syntax errors before security errors; some syntax errors
will also trigger a security error, but it's more helpful to the
programmer to know if they have a syntax error, which are well-defined
in the spec, rather than a security error, which aren't.

  • page/Navigator.cpp: (WebCore::Navigator::registerProtocolHandler): Detect syntax errors before security errors.
  • platform/KURLGoogle.cpp: (WebCore::isSchemeChar): Include '+' in the list of valid characters.
10:22 PM Changeset in webkit [87712] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

10:21 PM Changeset in webkit [87711] by mrowe@apple.com
  • 1 copy in tags/Safari-534.42

New tag.

10:12 PM Changeset in webkit [87710] by mrowe@apple.com
  • 9 edits in branches/safari-534-branch/Source/WebCore

Merge r87692.

10:00 PM Changeset in webkit [87709] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-05-30 Andrey Petrov <​andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
​https://bugs.webkit.org/show_bug.cgi?id=31721

  • editing/pasteboard/copy-standalone-image-crash-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image-crash.html: Added.

2011-05-30 Andrey Petrov <​andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
​https://bugs.webkit.org/show_bug.cgi?id=31721

For platform code, do not assert nodes always have renderer at
the time context menu action is invoked.
Renderer can actually be empty for a given node if it was hidden
or removed from domtree by some non-user generated event (e.g timeout)
after the popup menu had been created.

Changing Chromium, Gtk, Mac, Qt, Win and WinCE.

Test: editing/pasteboard/copy-standalone-image-crash.html

  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage):
9:03 PM Changeset in webkit [87708] by dbates@webkit.org
  • 10 edits
    3 moves in trunk

2011-05-30 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • XSSAuditor: Copied from PerformanceTests/XSSFilter.
  • XSSFilter: Removed.
  • XSSFilter/large-post-many-events.html: Removed.
  • XSSFilter/large-post-many-inline-scripts-and-events.html: Removed.
  • XSSFilter/resources: Removed.
  • XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Removed.

2011-05-30 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::init): (WebCore::XSSAuditor::filterToken): (WebCore::XSSAuditor::filterTokenInitial): (WebCore::XSSAuditor::filterTokenAfterScriptStartTag): (WebCore::XSSAuditor::filterScriptToken): (WebCore::XSSAuditor::filterObjectToken): (WebCore::XSSAuditor::filterParamToken): (WebCore::XSSAuditor::filterEmbedToken): (WebCore::XSSAuditor::filterAppletToken): (WebCore::XSSAuditor::filterIframeToken): (WebCore::XSSAuditor::filterMetaToken): (WebCore::XSSAuditor::filterBaseToken): (WebCore::XSSAuditor::filterFormToken): (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): (WebCore::XSSAuditor::eraseAttributeIfInjected): (WebCore::XSSAuditor::snippetForRange): (WebCore::XSSAuditor::snippetForAttribute): (WebCore::XSSAuditor::isContainedInRequest): (WebCore::XSSAuditor::isSameOriginResource):
  • html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
  • html/parser/XSSFilter.cpp: Removed.
  • html/parser/XSSFilter.h: Removed.
7:21 PM Changeset in webkit [87707] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Expose a public clearAll() function to reset WebCore::Animation.

No new functionality, so no new tests.

  • platform/animation/Animation.h: (WebCore::Animation::clearAll):

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Create an ArgumentCoder for WebCore::Animation.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
7:18 PM Changeset in webkit [87706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-30 Raphael Kubo da Costa <​kubo@profusion.mobi>

Reviewed by Kent Tamura.

[efl] Fix _ewk_frame_children_iterator_next().
​https://bugs.webkit.org/show_bug.cgi?id=61749

The iterator was returning always the first child, making tests like
fast/history/history-back-initial-vs-final-url.html to timeout and
eventually run out of memory.

  • ewk/ewk_frame.cpp: (_ewk_frame_children_iterator_next): (ewk_frame_children_iterator_new):
7:04 PM Changeset in webkit [87705] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-30 Kent Tamura <​tkent@chromium.org>

[Mac] Skip a flaky test: svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/mac/Skipped:
6:44 PM Changeset in webkit [87704] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Audio and video files saved to the Application Cache should preserve the original file extension
​https://bugs.webkit.org/show_bug.cgi?id=61750
<rdar://9524922>

No new tests, it isn't possible to check the name of the file in the cache from within
DRT. Changes verified manually.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache

file name.

(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.

  • loader/appcache/ApplicationCacheStorage.h:
5:05 PM Changeset in webkit [87703] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 Jer Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

Play/Pause button in wrong state when entering full screen on Vimeo
​https://bugs.webkit.org/show_bug.cgi?id=61754

Update the play/pause button inside reset(). This ensures the button is in
the correct state when the controls are created after playback has already
started.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
4:49 PM Changeset in webkit [87702] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-30 Hojong Han <​hojong.han@samsung.com>

Reviewed by Geoffrey Garen.

[JSC] malfunction during arithmetic condition check with negative number (-2147483648)
​https://bugs.webkit.org/show_bug.cgi?id=61416

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
  • tests/mozilla/ecma/Expressions/11.12-1.js: (getTestCases):
4:43 PM Changeset in webkit [87701] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Added a public TimingFunction::type() method.

No new functionality, so no new tests.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::type):

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for WebCore::TimingFunction. This serializer can create the appropriate
TimingFunction subclass based on the type of timing function.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
3:29 PM Changeset in webkit [87700] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 Noam Rosenthal <​noam.rosenthal@nokia.com>

BUILD FIX for r87697 on Windows/Symbian

For now enabling TextureMapper for Mac/Linux only.

  • WebCore.pri:
3:02 PM Changeset in webkit [87699] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Add WebCore::Length and WebCore::TransformationMatrix to the types that use SimpleArgumentCoder.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
3:00 PM Changeset in webkit [87698] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior): Mark
shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).

1:57 PM Changeset in webkit [87697] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
​https://bugs.webkit.org/show_bug.cgi?id=61740

Make CONFIG+=texmap an opt-out instead of an opt-in.

No new functionality so no new tests.

  • WebCore.pri:
1:08 PM Changeset in webkit [87696] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=61693

  • platform/gtk/Skipped: Unskip the test which is no longer crashing.

2011-05-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=61693

Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
may now be null.

No new tests. This change should cause fast/css/font-face-zero-hash-key.html
to stop crashing.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing m_scaledFont.
12:23 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
12:02 PM Changeset in webkit [87695] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-30 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
​https://bugs.webkit.org/show_bug.cgi?id=61711

The loadFinished() signal was emitted directly inside the call for setHtml, so
the test was waiting the loadFinished() signal with a big timeout. Change this by
a very small timeout and a verification with signal spy.

In practice, setHtml() will either directly call loadFinished() or queue it to
the next event loop run, and test will work for both situations.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::scrollbarsOff):
11:28 AM Changeset in webkit [87694] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

2011-05-30 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media until they're working.
​https://bugs.webkit.org/show_bug.cgi?id=61687

Until this works properly, we should indicate that our media implementation
in texture mapper doesn't support accelerated compositing.

This makes LayoutTests/compositing/video/* work again.

  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::platformLayer):

2011-05-30 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media in until they're working.
​https://bugs.webkit.org/show_bug.cgi?id=61687

Turn off accelerated compositing for media and plugins when in texture-mapper.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
10:21 AM Changeset in webkit [87693] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-30 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Adam Barth.

[Chromium] Fix regression after r87628.
​https://bugs.webkit.org/show_bug.cgi?id=61733

Having r87628 in place, Chrome reliability bot crashes in
WebCore::HTMLLinkElement::onloadTimerFired.

This is because the change makes WebCore::CachedResource::setRequest to
call checkNotify on request reset. HTMLLinkElement registers itself as
CachedResource client via m_cachedSheet, which can happen even if
m_cachedLinkResource wasn't set. As a result,
WebCore::HTMLLinkElement::notifyFinished is got called with unset
m_cachedLinkResource, which causes a crash in
HTMLLinkElement::onloadTimerFired

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::notifyFinished):
10:09 AM Changeset in webkit [87692] by Darin Adler
  • 9 edits in trunk/Source/WebCore

2011-05-30 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler and Simon Fraser.

REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
​https://bugs.webkit.org/show_bug.cgi?id=61717
rdar://problem/9522272

May be some good way to test this later. No immediate idea about the best way.

When a media element is taken into full-screen mode, stop events from propagating
outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
has been changed to take a shadow root node. In our full screen media element check,
we check to see if the passed shadow root is the shadow root of the full screen media
element, and if so, specify events should StayInsideShadowDOM. The end result is that
inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
way from the SliderThumb to the video element's shadow root, but no further.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the shadow DOM when showing a full screen video.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls. The events telling us about activity in the shadow DOM no longer bubble out so we need to handle this inside the shadow DOM on the root element. (WebCore::HTMLMediaElement::play): Ditto. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto. (WebCore::HTMLMediaElement::defaultEventHandler): Ditto. (WebCore::HTMLMediaElement::enterFullscreen): Ditto. (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
  • html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out changes that tried to make special rules for events using preDispatchEventHandler and such. This rolls out both r87622 and r87655. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
  • html/shadow/MediaControlElements.h: Ditto.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members. (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider hiding the controls later. (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse is no longer over the controls. (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide automatically if we're playing. (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer. (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care if we are full screen. (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function. (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions as the mouse is moved in and out. (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if needed. (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions are met. (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
  • html/shadow/MediaControlRootElement.h: Added new functions and data members.
10:05 AM Changeset in webkit [87691] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-30 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

2011-05-30 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
​https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:25 AM Changeset in webkit [87690] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-05-30 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement JavaScript dialogs in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=61725

  • MiniBrowser/gtk/BrowserWindow.c: (WKStringGetCString): Helper function to get a UTF-8 c string from a WKStringRef. (WKURLGetCString): Helper function to get a UTF-8 c string from a WKURLRef. (browserWindowUpdateURL): Update to use WKURLGetCString. (didReceiveTitleForFrame): Update to use WKStringGetCString. (createMessageDialog): Create a GtkMessageDialog. (runJavaScriptAlert): (runJavaScriptConfirm): (runJavaScriptPrompt): (browserWindowUIClientInit):
9:17 AM Changeset in webkit [87689] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

2011-05-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
​https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
9:14 AM Changeset in webkit [87688] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
​https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
8:44 AM Changeset in webkit [87687] by pvarga@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-30 Peter Varga <​pvarga@webkit.org>

Unreviewed build fix.

[Qt][V8] Fix debug build.

No new tests needed.

  • css/CSSStyleDeclaration.cpp: Add missing header.
  • dom/Text.cpp: Ditto.
  • rendering/InlineTextBox.cpp: Ditto.
8:03 AM QtWebKitForQt5 created by Simon Hausmann
7:50 AM Changeset in webkit [87686] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
​http://trac.webkit.org/changeset/87683
​https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-05-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
​http://trac.webkit.org/changeset/87683
​https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
7:13 AM Changeset in webkit [87685] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

2011-05-30 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove some unneeded header includes
​https://bugs.webkit.org/show_bug.cgi?id=60536

  • Platform/CoreIPC/Connection.cpp: Remove WebProcess.h.
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove ProcessLauncher.h and WebProcessProxy.h. Add <wtf/OwnArrayPtr.h>.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Remove PluginView.h.
7:06 AM Changeset in webkit [87684] by rgabor@webkit.org
  • 2 edits
    5 deletes in trunk/LayoutTests

[Qt] Remove passing tests from ARM Skipped list

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
  • platform/qt-arm/fast: Removed.
  • platform/qt-arm/fast/block: Removed.
  • platform/qt-arm/fast/block/float: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
  • platform/qt-arm/fast/transforms: Removed.
  • platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Removed.
  • platform/qt-arm/transforms: Removed.
  • platform/qt-arm/transforms/2d: Removed.
  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Removed.
  • platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/qt-arm/transforms/svg-vs-css-expected.txt: Removed.
6:48 AM Changeset in webkit [87683] by apavlov@chromium.org
  • 10 edits in trunk

2011-05-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-url-linkify.html:

2011-05-25 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend up front.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
3:36 AM Changeset in webkit [87682] by mnaganov@chromium.org
  • 49 edits
    39 adds in trunk/LayoutTests

2011-05-30 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed.
[Chromium] Rebaseline tests after r87680.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
2:18 AM Changeset in webkit [87681] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

011-05-30 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not issue frontendReused for reload or navigation.
​https://bugs.webkit.org/show_bug.cgi?id=61192

  • only issue frontendReused when inspector is attached after main resource committed load
  • upon committing loading main resource, reset agents before sending FrameNavigated to page agent
  • Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
  • do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::clearFrontend): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._resetResourcesTree): (WebInspector.DatabaseTreeElement.prototype.onpopulate): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.frontendReused):
1:30 AM Changeset in webkit [87680] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-30 Ryan Sleevi <​rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
​https://bugs.webkit.org/show_bug.cgi?id=61603

  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
  • svg/filters/feConvolveFilter-y-bounds.svg: Added.

2011-05-30 Ryan Sleevi <​rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
​https://bugs.webkit.org/show_bug.cgi?id=61603

Test: svg/filters/feConvolveFilter-y-bounds.svg

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::getPixelValue):
12:45 AM Changeset in webkit [87679] by Nate Chapin
  • 6 edits in trunk/Source/WebCore

2011-05-30 Nate Chapin <Nate Chapin>

Reviewed by Antti Koivisto.

Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
flow so it's a little less circular.
​https://bugs.webkit.org/show_bug.cgi?id=61666

  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::beginLoadIfNeeded):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::load):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::loadStarted):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
12:22 AM Changeset in webkit [87678] by abarth@webkit.org
  • 7 edits
    2 deletes in trunk

2011-05-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
​http://trac.webkit.org/changeset/87618
​https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
​http://trac.webkit.org/changeset/87618
​https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

May 29, 2011:

11:25 PM Changeset in webkit [87677] by mrowe@apple.com
  • 5 edits in tags/Safari-534.41.1/Source

Versioning.

11:23 PM Changeset in webkit [87676] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41.1

New tag.

11:22 PM Changeset in webkit [87675] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87657.

11:22 PM Changeset in webkit [87674] by yutak@chromium.org
  • 21 edits
    4 copies
    2 adds in trunk

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-29 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
​https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
11:17 PM Changeset in webkit [87673] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

More IMAGE results.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
11:07 PM Changeset in webkit [87672] by abarth@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Add image baselines for all these beautiful platforms.

  • platform/chromium-linux-x86/fullscreen: Added.
  • platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac/fullscreen: Added.
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-win-vista/fullscreen: Added.
  • platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
10:54 PM Changeset in webkit [87671] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-29 Adam Barth <​abarth@webkit.org>

Attempt to fix build by implementing pure virtual function.

  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::shouldHideControls):
  • html/shadow/MediaControlRootElementChromium.h:
10:20 PM Changeset in webkit [87670] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

10:19 PM Changeset in webkit [87669] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41

New tag.

9:41 PM Changeset in webkit [87668] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87654.

9:40 PM Changeset in webkit [87667] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87642.

9:34 PM Changeset in webkit [87666] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87643.

9:32 PM Changeset in webkit [87665] by mrowe@apple.com
  • 14 edits
    3 adds in branches/safari-534-branch

Merge r87660.

9:20 PM Changeset in webkit [87664] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87655.

9:18 PM Changeset in webkit [87663] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87661.

9:14 PM Changeset in webkit [87662] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87652.

8:37 PM Changeset in webkit [87661] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-29 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Darin Adler.

Controls never hide in full screen after user stops moving mouse
​https://bugs.webkit.org/show_bug.cgi?id=61715
<rdar://problem/9522182>

When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
show the media controls, and then start a timer.

The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
move), and hides the controls.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer. (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen

controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
to play.

(WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future

if we are in full screen.

(WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and

we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.

(WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
(WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the

controls and start a timer to hide them.

(WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't

have the move the mouse once they enter full screen to hide the controls.

(WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls. (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that

the caller should hide the controls if the panel is not hovered.

  • html/shadow/MediaControlRootElement.h:
7:05 PM Changeset in webkit [87660] by jer.noble@apple.com
  • 14 edits
    3 adds in trunk

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
​https://bugs.webkit.org/show_bug.cgi?id=61712

  • fullscreen/full-screen-iframe-zIndex-expected.txt: Added.
  • fullscreen/full-screen-iframe-zIndex.html: Added.
  • platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
​https://bugs.webkit.org/show_bug.cgi?id=61712

Tests: fullscreen/full-screen-iframe-zIndex.html

Walk up the ancestor chain for the full-screen element, marking them as full-screen
ancestors. Then, we apply a pseudo-class to those elements, which disable all their
stacking-context-creating styles. Set the z-index of all full-screen elements (and
the iframes which contain them) to a large value, ensuring they appear above other
sibling elements.

This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
and pesudo-class, so remove it and replace it with the new pseudo-class.

  • css/CSSSelector.cpp: (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove

-webkit-full-screen-media-document.

(WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove

PseudoFullScreenMediaDocument

(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the

PseudoFullScreenMediaDocument implementation and replace it with
PseudoFullScreenAncestor.

  • css/fullscreen.css: (:-webkit-full-screen): Add a z-index property. (:-webkit-full-screen-ancestor:not(iframe)): Added. Reset the z-index to

auto, and reset other stacking-context creating properties.

  • dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element

instead of just the iframe elements.

(WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.

  • dom/Element.cpp: (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property. (WebCore::Element::insertedIntoTree): Ditto. (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase. (WebCore::Element::setContainsFullScreenElement): Ditto.
  • dom/Element.h:
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for

m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
  • html/HTMLFrameElementBase.h:
  • rendering/style/RenderStyleConstants.h:
5:49 PM Changeset in webkit [87659] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Add expected result.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
5:42 PM Changeset in webkit [87658] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-29 Adam Barth <​abarth@webkit.org>

Slightly adjust the type of the expected failure.

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [87657] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
​https://bugs.webkit.org/show_bug.cgi?id=61714

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
new full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
the full screen element.

  • dom/Element.h:

(WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
(WebCore::Element::willStopBeingFullscreenElement): Ditto.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
MediaControls::enteredFullscreen().
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
MediaControls::exitedFullscreen().

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
changes to the fullscreen-ness of the element.

5:19 PM Changeset in webkit [87656] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=61707

Second try at this. First try could lead to a WKView leak.

  • UIProcess/mac/WKFullScreenWindowController.h: Added _isExitingAcceleratedCompositingMode. Needed to track whether we have retained so we don't leak if the page goes away before we get the callback.
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Added code to set the new variable to YES. (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Added code to deal with the new boolean and to release. (exitCompositedModeRepaintCompleted): Removed the release that was here. (-[WKFullScreenWindowController close]): Added a call to exitCompositedModeRepaintCompleted here. We're as complete as we'll ever be when we're closed; we can't get the callback after that point.
5:00 PM Changeset in webkit [87655] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
​https://bugs.webkit.org/show_bug.cgi?id=61713

We need to come up with a way to regression-test these changes. Nothing at the moment.

The bug is that we removed calls to preventDefault, but we still do need to prevent
default handling of this event.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault that was in here before r87622 as well as the stopPropagation that was added in r87622. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
3:14 PM Changeset in webkit [87654] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r87637): nytimes.com freezes after going back to it
<rdar://problem/9521928>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
Add call to setShouldNotifyAfterNextScheduledLayerFlush(false) to prevent a
redundant call to layerHostDidFlushLayers which would cause the layer state
to get out of sync with the UIProcess.

2:56 PM Changeset in webkit [87653] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-05-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Some heap refactoring
​https://bugs.webkit.org/show_bug.cgi?id=61704


SunSpider says no change.

  • heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

(JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

(JSC::Heap::allocate): Changed inline allocation code to only select the
size class, since this can be optimized out at compile time -- everything
else is now inlined into this out-of-line function.


No need to duplicate ASSERTs made in our caller.

  • heap/Heap.h: (JSC::Heap::heap): (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding a layer of indirection through MarkedSpace.

(JSC::Heap::allocate): See above.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::create): (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::allocate): Updated to match changes above.
2:28 PM Changeset in webkit [87652] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
​https://bugs.webkit.org/show_bug.cgi?id=61710

When taking the documentElement full screen, we don't create a RenderFullScreen
object and thus never enter accelerated compositing mode for the animation. Tell
the WKFullScreenWindowController to enter accelerated compositing mode anyway
(with an empty layer context) so as to fulfill its expectations and cause the
full screen animation to complete.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a

comment explaining when we expect the animation to complete.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):

Remove an ASSERT which is no longer valid.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess

to enter then exit full-screen mode.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

2:01 PM Changeset in webkit [87651] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87633.

2:01 PM Changeset in webkit [87650] by mrowe@apple.com
  • 11 edits
    2 adds in branches/safari-534-branch

Merge r87628.

1:57 PM Changeset in webkit [87649] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87637.

1:56 PM Changeset in webkit [87648] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87634.

1:54 PM Changeset in webkit [87647] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87639.

1:54 PM Changeset in webkit [87646] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source/WebKit2

Merge r87638.

1:45 PM Changeset in webkit [87645] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-29 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Element: Micro-cleanup of scroll methods.
​https://bugs.webkit.org/show_bug.cgi?id=61705

Do an early return without calculating element boundaries when asked
to scroll an element without a renderer().

  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::scrollByUnits):
1:12 PM Changeset in webkit [87644] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=61707

Saw this while debugging a crash. We don't have a way to make regression tests for this
kind of issue at this time.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller here since we are keeping a pointer to it. (exitCompositedModeRepaintCompleted): Release the controller here.
1:12 PM Changeset in webkit [87643] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Fix assertion seen when entering full screen mode for standalone video
​https://bugs.webkit.org/show_bug.cgi?id=61708

We don't currently have a way to make a regression test for this.

  • dom/Document.cpp: (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc, because scheduleStyleRecalc is intended to only be called when the style system itself detects recalc is needed.
1:06 PM Changeset in webkit [87642] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
​https://bugs.webkit.org/show_bug.cgi?id=61706
<rdar://problem/9521970>

If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
12:38 PM Changeset in webkit [87641] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-29 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
​https://bugs.webkit.org/show_bug.cgi?id=61162

Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
that omits a line count. In particular, the chunk range regular expression does
not match a chunk range line that omits a line count. GNU diff(1) will omit the
line count in the chunk range if the line count is exactly 1. For example, appending
a new line to the end of an existing file F that contains exactly one line of text will
be represented in a diff with a chunk range line that omits the line count for F.

  • Scripts/VCSUtils.pm: (parseChunkRange): Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added unit test "Git: Append new line to the end of an existing file".
12:13 PM Changeset in webkit [87640] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Andreas Kling <​kling@webkit.org>

Reviewed by James Robinson.

[Qt] Add area check to ImageBufferData::getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
12:00 PM Changeset in webkit [87639] by Darin Adler
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <Beth Dakin> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.

  • page/ChromeClient.h:

(WebCore::ChromeClient::setRenderTreeSize):

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

  • rendering/RenderArena.h:

(WebCore::RenderArena::totalRenderArenaSize):

11:13 AM Changeset in webkit [87638] by Darin Adler
  • 7 edits in trunk/Source/WebKit2

2011-05-29 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

  • UIProcess/API/C/WKPage.cpp: (WKPageGetRenderTreeSize):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::renderTreeSize): (WebKit::WebPageProxy::setRenderTreeSize):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setRenderTreeSize):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:03 AM Changeset in webkit [87637] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

2:49 AM Changeset in webkit [87636] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-27 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Data directory is webkitgtk-x.y not webkit-x.y
​https://bugs.webkit.org/show_bug.cgi?id=61642

  • GNUmakefile.am: updated data directory.
1:30 AM Changeset in webkit [87635] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87566.
​http://trac.webkit.org/changeset/87566
​https://bugs.webkit.org/show_bug.cgi?id=61702

It made all tests assert on Qt in debug mode (Requested by
Ossy_weekend on #webkit).

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suggestedMIMEType): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • platform/mac/HTMLConverter.mm: (fileWrapperForElement):
12:04 AM Changeset in webkit [87634] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't add sub-frames to global history when navigating via back/forward
​https://bugs.webkit.org/show_bug.cgi?id=61701
<rdar://problem/9521222>

Instead of just checking whether the load is the first in the frame, we also need to
check to make sure we're loading in the main frame.

Not testable due to lack of global history infrastructure in DRT.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
Note: See TracTimeline for information about the timeline view.