⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 1, 2011:

11:41 PM Changeset in webkit [87880] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-01 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer::convertToLayerCoords to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61818

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::flooredIntSize):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::createLocalTransformState): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox): (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
11:30 PM Changeset in webkit [87879] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Remove superfluous renderer() test
​https://bugs.webkit.org/show_bug.cgi?id=61907

No new tests. (trivial)

  • dom/Document.cpp: (WebCore::Document::recalcStyle):
9:51 PM Changeset in webkit [87878] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Hajime Morita.

Add IntPoint + IntPoint operator
​https://bugs.webkit.org/show_bug.cgi?id=61876

Adding an operator+ convenience method to IntPoint that sums two points
and returns the result as an IntPoint. Changing doImageDrag to use it
as a proof of concept.

No new tests since there is no change in behavior.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • platform/graphics/IntPoint.h: (WebCore::operator+):
9:21 PM Changeset in webkit [87877] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Jaehun Lim <​ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
​https://bugs.webkit.org/show_bug.cgi?id=61836

Add functions for rendering drop-down list when style attributes are applied.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustMenuListButtonStyle): (WebCore::RenderThemeEfl::paintMenuListButton):
  • platform/efl/RenderThemeEfl.h:
7:53 PM Changeset in webkit [87876] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketChannel::fail() should close the connection immediately
​https://bugs.webkit.org/show_bug.cgi?id=61851

The effect of this change is almost unobservable. The difference between m_handle->close() and
m_handle->disconnect() is that the former does not close the connection if the handle has
unsent data while the latter immediately closes the connection regardless of unsent data.
Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
for user scripts to observe the difference between close() and disconnect() (it should take some time
for onclose() to be called if there are any unsent data, but there ought to be no other difference
in user scripts' perspective).

No new tests are added, because writing a test for this issue is not feasible due to the above reason.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
7:49 PM Changeset in webkit [87875] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Coding style nit. Move ec=0 initialization, change
recommended by Alexey in bug.
​https://bugs.webkit.org/show_bug.cgi?id=60831

  • dom/Document.cpp: (WebCore::Document::setBody):
7:23 PM Changeset in webkit [87874] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-01 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Move {Next,Previous}FocusableNode functions from Document to FocusController.
​https://bugs.webkit.org/show_bug.cgi?id=61839

There are some member functions in Document which use 'this'
pointer, but we should use TreeScope instead of Document in some
places to handle focus issues nicely. We have to move these
functions out of Document class so that we can give the TreeScope
as a parameter.

No new tests since no functionality was changed.

  • dom/Document.cpp:
  • dom/Document.h:
  • page/FocusController.cpp: (WebCore::FocusController::deepFocusableNode): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::nextNodeWithExactTabIndex): (WebCore::previousNodeWithExactTabIndex): (WebCore::nextNodeWithGreaterTabIndex): (WebCore::previousNodeWithLowerTabIndex): (WebCore::FocusController::nextFocusableNode): (WebCore::FocusController::previousFocusableNode):
  • page/FocusController.h:
7:09 PM Changeset in webkit [87873] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

old-run-webkit-tests: add support for audio files
​https://bugs.webkit.org/show_bug.cgi?id=57992

  • Scripts/old-run-webkit-tests:
6:36 PM Changeset in webkit [87872] by abarth@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

There seems to be something odd about registerProtocolHandler on Mac.
The "no-crash" seems to "pass" because the test does not crash, where
as the "register-protocol-handler" test fails, apparently due to the
API being disabled.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt.
    • This expectation file is misplaced.
6:11 PM Changeset in webkit [87871] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Now that this test doesn't time out, we can see that it fails. That's
progress, of a sort.

  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [87870] by abarth@webkit.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Move expected result to the correct location. The script put it in the
wrong location.

  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt: Removed.
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt: Removed.
  • platform/chromium/fast/js/property-getters-and-setters-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt.
6:00 PM Changeset in webkit [87869] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

These test time out on debug, probably because drop shadows are slow in debug skia.

  • platform/chromium/test_expectations.txt:
5:53 PM Changeset in webkit [87868] by enne@google.com
  • 4 edits in trunk/Source

2011-06-01 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
​https://bugs.webkit.org/show_bug.cgi?id=61895

  • platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):

2011-06-01 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
​https://bugs.webkit.org/show_bug.cgi?id=61895

  • tests/TreeSynchronizerTest.cpp: (WebCore::TEST):
5:53 PM Changeset in webkit [87867] by jchaffraix@webkit.org
  • 12 edits
    4 adds in trunk

2011-06-01 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Simon Fraser.

CSSStyleSheet#insertRule doesn't work well with imported stylesheets
​https://bugs.webkit.org/show_bug.cgi?id=56981

Test that a combination of insertRule and @import works properly.

  • fast/css/import-and-insert-rule-no-update-expected.txt: Added.
  • fast/css/import-and-insert-rule-no-update.html: Added.
  • fast/css/resources/red.css: Added. (div):
  • fast/css/resources/redimport.css: Added.

2011-06-01 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Simon Fraser.

CSSStyleSheet#insertRule doesn't work well with imported stylesheets
​https://bugs.webkit.org/show_bug.cgi?id=56981

Test: fast/css/import-and-insert-rule-no-update.html

The bug arises from the fact that <link> element did not know about a programmatically
loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
This is needed to make sure our style selector contains an up-to-date list of stylesheets.

The gist of the patch adds a way for style sheet owner element to know if we are
programmatically loading a style sheet. This is needed as <link> keeps the information
about that last loaded stylesheet.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet on our parent style sheet instead of directly adding a pending style sheet.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet on our owner element if we have one.
  • css/CSSStyleSheet.h:
  • dom/Node.h: (WebCore::Node::startLoadingDynamicSheet): Added common implementation of startLoadingDynamicSheet, which should never be called.
  • dom/StyleElement.cpp: (WebCore::StyleElement::startLoadingDynamicSheet):
  • dom/StyleElement.h: Common implementation of startLoadingDynamicSheet for style elements.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
  • html/HTMLLinkElement.h: Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
  • html/HTMLStyleElement.h: (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
  • svg/SVGStyleElement.h: (WebCore::SVGStyleElement::startLoadingDynamicSheet): Forward the call to StyleElement.
5:46 PM Changeset in webkit [87866] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCustomHighlight to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61562

Switching paintCustomHighlight to use an IntPoint for
its paint offset instead of a pair of ints.

No new tests since this is refactoring.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
4:19 PM Changeset in webkit [87865] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-01 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Switch MouseRelatedEvent to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61574

Covered by existing tests.

  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent): (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::contentsScrollOffset): (WebCore::MouseRelatedEvent::initCoordinates): (WebCore::MouseRelatedEvent::computeRelativePosition): (WebCore::MouseRelatedEvent::layerX): (WebCore::MouseRelatedEvent::layerY): (WebCore::MouseRelatedEvent::offsetX): (WebCore::MouseRelatedEvent::offsetY): (WebCore::MouseRelatedEvent::pageX): (WebCore::MouseRelatedEvent::pageY): (WebCore::MouseRelatedEvent::pageLocation): (WebCore::MouseRelatedEvent::x): (WebCore::MouseRelatedEvent::y):
  • dom/MouseRelatedEvent.h: (WebCore::MouseRelatedEvent::screenX): (WebCore::MouseRelatedEvent::screenY): (WebCore::MouseRelatedEvent::screenLocation): (WebCore::MouseRelatedEvent::clientX): (WebCore::MouseRelatedEvent::clientY): (WebCore::MouseRelatedEvent::clientLocation): (WebCore::MouseRelatedEvent::absoluteLocation):
  • dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent): (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create): (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY): (WebCore::WheelEvent::rawDeltaX): (WebCore::WheelEvent::rawDeltaY): (WebCore::WheelEvent::isHorizontal):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::scale):
4:15 PM Changeset in webkit [87864] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintOverflowControls to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61884

Switching paintOverflowControls to use an IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
4:13 PM Changeset in webkit [87863] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix setting of document.body
​https://bugs.webkit.org/show_bug.cgi?id=60831

  1. Only allowing setting to an element if it has a body tag.
  2. If element is from another document, import it.

Test: fast/dom/document-set-body.html

  • dom/Document.cpp: (WebCore::Document::setBody):

2011-06-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Tests setting document.body to non body elements, elements in other
documents.
​https://bugs.webkit.org/show_bug.cgi?id=60831

  • fast/dom/document-set-body-expected.txt: Added.
  • fast/dom/document-set-body.html: Added.
4:03 PM Changeset in webkit [87862] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Add Windows baseline for this new test.

  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
3:59 PM Changeset in webkit [87861] by abarth@webkit.org
  • 22 edits
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Update image baselines for these drop shadows. They differ from each
other only by minor rendering differences in the shadow.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feDropShadow-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [87860] by jochen@chromium.org
  • 6 edits
    1 copy
    5 adds in trunk

2011-06-01 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Add a test for FrameLoaderClient::allowImages
​https://bugs.webkit.org/show_bug.cgi?id=34314

  • platform/chromium/permissionclient/image-permissions-expected.txt: Added.
  • platform/chromium/permissionclient/image-permissions.html: Added.
  • platform/chromium/permissionclient/resources/boston.gif: Added.
  • platform/chromium/permissionclient/resources/image.html: Added.

2011-06-01 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
​https://bugs.webkit.org/show_bug.cgi?id=34314

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setImagesAllowed): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h. (WebPermissions::WebPermissions): (WebPermissions::~WebPermissions): (WebPermissions::allowImages): (WebPermissions::allowStorage): (WebPermissions::setImagesAllowed): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
  • DumpRenderTree/chromium/WebPermissions.h:
3:54 PM Changeset in webkit [87859] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

These tests no longer time out. Yay!

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [87858] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Update expected results to match V8 rather than JSC.

  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
3:48 PM Changeset in webkit [87857] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Non-users need access to the mds caches for SSL support.
<rdar://problem/9471799>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
3:37 PM Changeset in webkit [87856] by Chris Fleizach
  • 5 edits in trunk/Source/WebCore

Safari always crashes on ​http://bbc.co.uk when VoiceOver enabled
​https://bugs.webkit.org/show_bug.cgi?id=61886

Reviewed by Darin Adler.

This crash can happen on webpages that remove an element from the DOM when the element receives focus.
When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
However by posting that notification, a render tree update is performed. This causes the element to disappear, but
AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.

To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method
will not be called in time.

No test could be created because to cause it depends on an internal AppKit mechanism
that is only triggered remotely through the accessibility runtime.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
2:57 PM Changeset in webkit [87855] by commit-queue@webkit.org
  • 7 edits in trunk

2011-06-01 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
​https://bugs.webkit.org/show_bug.cgi?id=61721

  • platform/chromium-win/plugins/keyboard-events-expected.txt: New windows result.
  • platform/chromium/test_expectations.txt: New expectations.
  • plugins/keyboard-events.html: Add attribute windowPlugin="false" to force the Chromium windows port to load the test plugin in windowless mode. The plugin will then receive events and can log them to the console as required by this test.
  • plugins/mouse-events.html: Ditto.

2011-06-01 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
​https://bugs.webkit.org/show_bug.cgi?id=61721

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Well, handle them.
2:55 PM Changeset in webkit [87854] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

... and finally Windows.

  • platform/chromium-win-vista/fullscreen/full-screen-zIndex-after-expected.png: Added.
2:42 PM Changeset in webkit [87853] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-01 David Carson <​dacarson@apple.com>

Reviewed by Antti Koivisto.

Don't flatten frames that have a zero size.
​https://bugs.webkit.org/show_bug.cgi?id=61831

This tests creates an iframe that has a width and height of zero
and ensures that the iframe is not flattened to the size of the
containing content.

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html: Added.
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size-expected.txt: Added.

2011-06-01 David Carson <​dacarson@apple.com>

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=61831
If width and height of an iframe is fixed and should not be visible, then
it shouldn't be flattened.

Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html

  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
2:32 PM Changeset in webkit [87852] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Linux image baselines for this new test. Leviw confirms that this results are correct.

  • platform/chromium-linux-x86/svg/text: Added.
  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
2:28 PM Changeset in webkit [87851] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Image baselines for this new test.

  • platform/chromium-linux-x86/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png: Added.
2:25 PM Changeset in webkit [87850] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

... and now Windows results.

  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.txt: Added.
2:17 PM Changeset in webkit [87849] by kerz@chromium.org
  • 1 add in branches/chromium/782/codereview.settings

Adding codereview settings file so drover will work correctly on this branch

2:13 PM Changeset in webkit [87848] by dcheng@chromium.org
  • 11 edits
    2 adds in trunk

2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

  • fast/events/drag-image-filename-expected.txt: Added.
  • fast/events/drag-image-filename.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

  • The filename suggested in the HTTP header.
  • The last path component of the source URL.
  • The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
  • DumpRenderTree/chromium/EventSender.h:
2:09 PM Changeset in webkit [87847] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-06-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: make webaudio work w/o content-length header
​https://bugs.webkit.org/show_bug.cgi?id=61819

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
2:00 PM Changeset in webkit [87846] by leviw@chromium.org
  • 3 edits
    3 adds in trunk

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
​https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

Test: svg/text/scaling-font-with-geometric-precision.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
​https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • svg/text/scaling-font-with-geometric-precision.html: Added.
1:58 PM Changeset in webkit [87845] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintResizer to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61883

Switch paintResizer to take an IntPoint instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
1:57 PM Changeset in webkit [87844] by jer.noble@apple.com
  • 3 edits
    3 adds in trunk

2011-06-01 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
​https://bugs.webkit.org/show_bug.cgi?id=61755

  • fullscreen/full-screen-zIndex-after-expected.txt: Added.
  • fullscreen/full-screen-zIndex-after.html: Added.
  • platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.

2011-06-01 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
​https://bugs.webkit.org/show_bug.cgi?id=61755
<rdar://problem/9525277>

Test: fullscreen/full-screen-zIndex-after.html

Fix the incomplete implementation of r87660. Make parameters to
setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
inconsistent..

  • dom/Document.cpp: (WebCore::Document::webkitWillExitFullScreenForElement):
1:52 PM Changeset in webkit [87843] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Image baselines for this test. More to follow once the bots catch up.

  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/chromium-linux/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-linux/svg/custom/embedding-external-svgs-expected.txt: Added.
1:42 PM Changeset in webkit [87842] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Image baselines for these platforms.

  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
1:38 PM Changeset in webkit [87841] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintScrollCorner to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61874

Changing paintScrollCorner to take an IntPoint representing the paint
offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
1:24 PM Changeset in webkit [87840] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG graphics do not actually work in IMG tags or as background-image properties
​https://bugs.webkit.org/show_bug.cgi?id=18228

Adding the nice testcase from the bug 18228, all issues are fully resolved now.

  • platform/mac/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt: Added.
  • svg/custom/embedding-external-svgs.xhtml: Added.
  • svg/custom/resources/spinner.svg: Added.
1:14 PM Changeset in webkit [87839] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-06-01 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Flash of old video frame at the end of full screen transition
​https://bugs.webkit.org/show_bug.cgi?id=61752

Add a new method and message, DisposeOfLayerClient, which will invalidate and release
the WKRemoteLayerClient used during the full-screen animation. This ensures that
the root layer used for the full-screen animation will be in a clean state at the start
of the next transition.

  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::disposeOfLayerClient): Added.
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Call disposeOfLayerClient.
  • WebProcess/FullScreen/WebFullScreenManager.h: (WebKit::WebFullScreenManager::disposeOfLayerClient): Added.
  • WebProcess/FullScreen/WebFullScreenManager.messages.in: Added DisposeOfLayerClient.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::disposeOfLayerClient): Added, invalidates and clears m_rootLayerClient.
1:09 PM Changeset in webkit [87838] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Add single character lookup cache to IdentifierArena
​https://bugs.webkit.org/show_bug.cgi?id=61879

Add a simple lookup cache for single ascii character
identifiers. Produces around a 2% improvement in parse
time for my adhoc parser test.

  • parser/ParserArena.h: (JSC::IdentifierArena::IdentifierArena): (JSC::IdentifierArena::clear): (JSC::IdentifierArena::makeIdentifier):
12:52 PM Changeset in webkit [87837] by kbr@google.com
  • 5 edits in trunk/Source/WebCore

2011-06-01 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

[V8] Optimize fetches of indexed properties in custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=61821

Avoid allocating garbage in affected custom bindings. This speeds
up one test case by at least a factor of two. No new tests;
covered by existing layout tests (typed array and otherwise).

  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray): (WebCore::setWebGLArrayHelper):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray):
12:20 PM Changeset in webkit [87836] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Add new results for this new test. Our results are different by one
pixel. Mac results likely to follow once those bots catch up.

  • platform/chromium-linux-x86/svg/as-image: Added.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/chromium-win-vista/svg/as-image: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
11:58 AM Changeset in webkit [87835] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Ryosuke Niwa <​rniwa@webkit.org>

Skip editing/pasteboard/drag-drop-list.html on GTK after r87778
since smart paste isn't supported by GTK (tracked by the bug 61661).

  • platform/gtk/Skipped:
11:54 AM Changeset in webkit [87834] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Build fix after r87831

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
Added some HAVE(WKQCA) guards.

11:44 AM Changeset in webkit [87833] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-01 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

LayoutTests/editing/pasteboard/drag-drop-list fails on webkit2
​https://bugs.webkit.org/show_bug.cgi?id=61871

Renames editing/pasteboard/4861080.html to drag-drop-list.html, since it was renamed in r87778.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
11:41 AM Changeset in webkit [87832] by Adam Roben
  • 4 edits in trunk/Source/WebKit2

Delete a bunch of dead code in DrawingAreaImpl

LayerTreeHost::participatesInDisplay always returns false now, which means a bunch of code
in DrawingAreaImpl no longer runs.

Cleanup after fixing <​http://webkit.org/b/58054>
<rdar://problem/9249839> REGRESSION (WebKit2): Accelerated CSS animations have a lower
framerate than in WebKit1

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::displayTimerFired):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:

Reverted r82959.

11:39 AM Changeset in webkit [87831] by Adam Roben
  • 12 edits
    1 copy
    1 add in trunk/Source/WebKit2

Render accelerated content into a web process-owned child HWND

This allows us to use WKCACFView's far more efficient kWKCACFViewDrawingDestinationWindow
mode, which gives us asynchronous rendering on a background thread and doesn't require us to
read bits off the GPU back into system memory.

A new class, WKCACFViewWindow, represents the child HWND. The child HWND is placed at the
bottom of the z-order so it won't obscure any other child HWNDs (i.e., windowed plugins).
The child HWND is made transparent to mouse events so that WKView will continue to receive
mouse events even though it is obscured by the child HWND.

There is now a bunch of dead code in DrawingAreaImpl to handle our old rendering model. I'll
remove that in a future patch.

Fixes <​http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2): Accelerated
CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • Shared/LayerTreeContext.h: Added HWND member on Windows.
  • Shared/win/CoalescedWindowGeometriesUpdater.cpp:

(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):

  • Shared/win/CoalescedWindowGeometriesUpdater.h:

Added new BringToTopOrNot argument. Allows the caller to specify that all windows being
updated should also be brought to the top of the z-order.

  • Shared/win/LayerTreeContextWin.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
Implemented based on new window member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Initialize new member.
(WebKit::WebView::onSizeEvent): Resize the layer host window to cover our entire view, if we
have one.
(WebKit::WebView::enterAcceleratedCompositingMode): Store, position, and show the layer host
window.
(WebKit::WebView::exitAcceleratedCompositingMode): Destroy the layer host window.
(WebKit::WebView::updateChildWindowGeometries): Updated for change to
CoalescedWindowGeometriesUpdater.

  • UIProcess/win/WebView.h: Added m_layerHostWindow member.
  • WebProcess/WebPage/LayerTreeHost.h: Added scheduleChildWindowGeometryUpdate.
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Simplified by using
WKCACFViewWindow.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Removed initialization of a removed
member.
(WebKit::LayerTreeHostCAWin::platformInitialize): Changed to use WKCACFViewWindow,
kWKCACFViewDrawingDestinationWindow, and to initialize the LayerTreeContext.
(WebKit::LayerTreeHostCAWin::invalidate): Leak our window and tell it to clean up after
itself. The UI process will take care of destroying the window when it finishes switching
out of accelerated compositing mode. Removed a WKCACFViewUpdate call that is now handled by
WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::scheduleChildWindowGeometryUpdate): Added. Calls through to
m_geometriesUpdater.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Updated to use WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::contextDidChange): Update child window geometries now to keep
them (almost) in sync with the accelerated content. <​http://webkit.org/b/61867> covers the
slight asynchrony that still exists.
(WebKit::LayerTreeHostCAWin::setRootCompositingLayer): Don't flush any changes when we don't
have a root layer. This prevents a flash of white when switching out of compositing mode.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added m_window and m_geometriesUpdater.

Removed code related to the old, synchronous display model.

  • WebProcess/WebPage/ca/win/WKCACFViewWindow.cpp: Added.

(WebKit::WKCACFViewWindow::WKCACFViewWindow): Initialize members and create our window.
(WebKit::WKCACFViewWindow::~WKCACFViewWindow): Destroy our window if needed.
(WebKit::WKCACFViewWindow::onCustomDestroy): Just call ::DestroyWindow.
(WebKit::WKCACFViewWindow::onDestroy): Tell our view not to render into our window anymore.
(WebKit::WKCACFViewWindow::onEraseBackground): Tell Windows not to erase us.
(WebKit::WKCACFViewWindow::onNCDestroy): Clear out m_window since it's now pointing to a
destroy window, and destroy ourselves if requested.
(WebKit::WKCACFViewWindow::onPaint): Tell the view to draw, then clear our invalid region.
(WebKit::WKCACFViewWindow::onPrintClient): Tell our view to draw into the given HDC.
(WebKit::WKCACFViewWindow::registerClass): Register our class (duh).
(WebKit::WKCACFViewWindow::staticWndProc): Get the WKCACFViewWindow pointer, or store the
pointer if needed, then call through to wndProc.
(WebKit::WKCACFViewWindow::wndProc): Call out to the appropriate handler function.

  • WebProcess/WebPage/ca/win/WKCACFViewWindow.h: Added.

(WebKit::WKCACFViewWindow::setDeletesSelfWhenWindowDestroyed): Simple setter.
(WebKit::WKCACFViewWindow::window): Simple getter.

  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp:

(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate): Let the LayerTreeHost handle
the geometry update, if we have one.

  • win/WebKit2.vcproj: Added WKCACFViewWindow files.
11:38 AM Changeset in webkit [87830] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Explictly request the size of a pointer in malloc. Otherwise this
explodes in 64bit architectures, at least.

  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_mimetypes): ditto.
11:36 AM Changeset in webkit [87829] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Permanent red background when SVG is used as a background image (DEBUG ONLY)
​https://bugs.webkit.org/show_bug.cgi?id=16518

The problem seems gone, I can't reproduce it anymore, add Beths test to svg/as-image.

  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • svg/as-image/resources/svg-as-background-with-relative-size.svg: Added.
  • svg/as-image/svg-as-background-with-relative-size.html: Added.
11:16 AM Changeset in webkit [87828] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the Phonon build when logging is disabled
​https://bugs.webkit.org/show_bug.cgi?id=61869

No new tests needed.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards. (WebCore::MediaPlayerPrivatePhonon::networkState): (WebCore::MediaPlayerPrivatePhonon::readyState): (WebCore::MediaPlayerPrivatePhonon::updateStates): (WebCore::MediaPlayerPrivatePhonon::stateChanged):
11:12 AM Changeset in webkit [87827] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Antti Koivisto.

Do not use the pushed style selector if it is not equal to the
parent document's style selector. It usually means that it is
in a bad state, e.g. already cleared.
​https://bugs.webkit.org/show_bug.cgi?id=61737

  • dom/Element.cpp: (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
11:08 AM Changeset in webkit [87826] by oliver@apple.com
  • 10 edits in trunk

2011-05-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Freezing a function and its prototype causes browser to crash.
​https://bugs.webkit.org/show_bug.cgi?id=61758

Add test to ensure correct behaviour

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js: (f):

2011-05-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Freezing a function and its prototype causes browser to crash.
​https://bugs.webkit.org/show_bug.cgi?id=61758

Make JSObject::preventExtensions virtual so that we can override it
and instantiate all lazy

  • JavaScriptCore.exp:
  • runtime/JSFunction.cpp: (JSC::createPrototypeProperty): (JSC::JSFunction::preventExtensions): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSFunction.h:
  • runtime/JSObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::seal): (JSC::JSObject::seal):
10:59 AM Changeset in webkit [87825] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLineBoxList intersection functions to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61794

Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
to take IntPoint instead of a tx/ty to represent the offset to be applied match
the rect and lines' coordinates.

No new tests since this is merely refactoring.

  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::rangeIntersectsRect): (WebCore::RenderLineBoxList::anyLineIntersectsRect): (WebCore::RenderLineBoxList::lineIntersectsDirtyRect): (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
10:55 AM Changeset in webkit [87824] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-06-01 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Add QGLWidget viewport support to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=61802

Add command line parameter and menu item to MiniBrowser application
enabling use of QGLWidget for browser viewport.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::toggleGLViewport):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
10:41 AM Changeset in webkit [87823] by xan@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-06-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Utility methods for UA spellchecking
​https://bugs.webkit.org/show_bug.cgi?id=61788

Adds a couple of utility methods needed to implement some aspects
of spell checking support in a browser.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_replace_selection): method to replace the current selection with a string of text. (webkit_web_frame_get_range_for_word_around_caret): returns the DOM range for the word where the caret/selection currently is.
  • webkit/webkitwebframe.h: declare new methods.
10:36 AM Changeset in webkit [87822] by enne@google.com
  • 5 edits in trunk

2011-05-19 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Don't split long, narrow layers into multiple tiles.
​https://bugs.webkit.org/show_bug.cgi?id=60821

These tests have imperceptible pixel changes on horizontal scrollbars
as a result of this patch. Marking them as failing temporarily so
that they can be rebaselined.

  • platform/chromium/test_expectations.txt:

2011-05-19 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Don't split long, narrow layers into multiple tiles.
​https://bugs.webkit.org/show_bug.cgi?id=60821

This changes the heuristic for when we tile layers to be less bad
about wasting texture space. Long, narrow layers that are tiled with
a large tile size waste texture space. Now layers are only tiled if
they are above 512px in one dimension and extend into a second tile in
the other. If they are not tiled, their layer texture will exactly
fit their layer bounds. In particular, this will help scrollbars.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateLayerSize):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::maxTextureSize):
10:27 AM BuildingGtk edited by Martin Robinson
(diff)
10:19 AM Changeset in webkit [87821] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Ready Chromium port for Skia on Mac
​https://bugs.webkit.org/show_bug.cgi?id=61800

Skia on Mac is not enabled. The executing
code is unchanged, so there are no new tests.

  • platform/chromium/DragImageRef.h: Use Skia for DragImageRef instead of CG.
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Get the total matrix from Skia for the scrollbar. Convert the SkCanvas into a CGContext to draw.
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::paintStepper): Ditto.
10:08 AM Changeset in webkit [87820] by kerz@chromium.org
  • 1 copy in branches/chromium/782

Branch for Chrome 13

10:03 AM Changeset in webkit [87819] by Martin Robinson
  • 2 edits in trunk/Tools

2011-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Print out autogen arguments when they differ from the last set, to help
with debugging build issues.

  • Scripts/webkitdirs.pm: Print out previous and current build arguments when they differ.
9:58 AM Changeset in webkit [87818] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-01 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
​https://bugs.webkit.org/show_bug.cgi?id=59345

KURL and QUrl disagree whether certain URLs are valid or not. The regression here
was caused by the fact that now KURL accepts "http:/example.com" (note only one
slash) and our test case used a strange edge case that's transformed into a
"one-slash" URL that now KURL can handle.

QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
can understand it. So I've updated the test to use a more meaningful example and
show that an invalid URL gets converted to a valid URL if possible.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlToInvalid):
9:27 AM Changeset in webkit [87817] by sjl@chromium.org
  • 5 edits
    4 deletes in trunk/LayoutTests

2011-06-01 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Remove layout test http/tests/media/video-seekable-stall

http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
​https://bugs.webkit.org/show_bug.cgi?id=35271

  • http/tests/media/video-seekable-stall-expected.txt: Removed.
  • http/tests/media/video-seekable-stall.html: Removed.
  • platform/chromium-linux/http/tests/media/video-seekable-stall-expected.png: Removed.
  • platform/chromium-win/http/tests/media/video-seekable-stall-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
9:22 AM Changeset in webkit [87816] by mario@webkit.org
  • 1 edit
    25 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87779.

  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/gtk/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/gtk/svg/hixie/intrinsic/003-expected.txt: Added.
9:15 AM Changeset in webkit [87815] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-01 Adam Barth <​abarth@webkit.org>

Add baselines for these tests.

  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
9:14 AM Changeset in webkit [87814] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87726.

  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
9:14 AM Changeset in webkit [87813] by mario@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87721.

  • platform/gtk/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/gtk/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-uri-stroke-expected.png: Added.
9:13 AM Changeset in webkit [87812] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87680.

  • platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
  • platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
9:12 AM Changeset in webkit [87811] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87605.

  • platform/gtk/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/gtk/svg/wicd/test-scalable-background-image2-expected.png: Added.
9:11 AM Changeset in webkit [87810] by mario@webkit.org
  • 1 edit
    35 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87526.

  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/gtk/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/gtk/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
9:10 AM Changeset in webkit [87809] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87387.

  • platform/gtk/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/gtk/fast/borders/border-antialiasing-expected.png: Added.
9:08 AM Changeset in webkit [87808] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-01 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] run-launcher should run MiniBrowser in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=61858

  • Scripts/run-launcher: Check whether -2 command line option has been passed and run MiniBrowser instead of GtkLauncher.
9:01 AM Changeset in webkit [87807] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

SVGs with a viewbox specified do not seem to work as SVGImages
​https://bugs.webkit.org/show_bug.cgi?id=16517

SVGs with a viewBox work as background image nowadays, add a testcase covering it, originally from Beth Dakin.

  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Added.
  • svg/as-image/svg-as-background-with-viewBox.html: Added.
8:28 AM Changeset in webkit [87806] by Adam Roben
  • 7 edits
    1 add in trunk/Source/WebKit2

Route plugin window geometry updates through the DrawingArea

This will allow the geometry updates to be handled by the LayerTreeHost in compositing mode
in the future.

More rep work for <​http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate): Tell the DrawingArea, not the
WebPage, about the geometry update.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Added.

(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate):
Moved code here...

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

...from here.

  • win/WebKit2.vcproj: Added DrawingAreaImplWin.cpp.
8:12 AM Changeset in webkit [87805] by Adam Roben
  • 4 edits
    2 adds in trunk/Source/WebKit2

Move WebView's window geometry updating code to a new class

This will allow us to share this code with LayerTreeHostCAWin.

Prep work for <​http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • Shared/win/CoalescedWindowGeometriesUpdater.cpp: Added.

(WebKit::CoalescedWindowGeometriesUpdater::CoalescedWindowGeometriesUpdater):
(WebKit::CoalescedWindowGeometriesUpdater::~CoalescedWindowGeometriesUpdater):
Simple constructor/destructor.

(WebKit::CoalescedWindowGeometriesUpdater::addPendingUpdate):
(WebKit::setWindowRegion):
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):

  • Shared/win/CoalescedWindowGeometriesUpdater.h: Added.

Moved code here...

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:

...from here.

  • win/WebKit2.vcproj: Added new files.
7:51 AM Changeset in webkit [87804] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Windows build fix after r87755

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Fixed
typo.

7:34 AM Changeset in webkit [87803] by yurys@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-01 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow opening inspector for existing workers
​https://bugs.webkit.org/show_bug.cgi?id=61853

Added sidebar pane with a list of all workers. Each worker has a check box
that allows opening inspector for the worker.

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::connectToWorker): (WebCore::InspectorWorkerAgent::disconnectFromWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/Settings.js:
  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager): (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype.closeWorkerInspector): (WebInspector.WorkerManager.prototype._workerInspectorClosing): (WebInspector.WorkerMessageForwarder): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._createCheckbox): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):
7:32 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
Adding note on Fshell (diff)
7:29 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
added note on GCC 4.4 with Qt SDK 1.1. (diff)
7:15 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
7:11 AM Changeset in webkit [87802] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-01 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
​https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
​http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • fast/events/page-visibility-iframe-delete-test.html:
  • fast/events/page-visibility-iframe-move-test-expected.txt:
  • fast/events/page-visibility-iframe-move-test.html:
  • fast/events/page-visibility-iframe-propagation-test-expected.txt:
  • fast/events/page-visibility-iframe-propagation-test.html:
  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-01 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
​https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
​http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:
7:10 AM Changeset in webkit [87801] by Nikolas Zimmermann
  • 8 edits in trunk/Source/WebCore

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Remove duplicated code in various computeReplacedLogical*() functions
​https://bugs.webkit.org/show_bug.cgi?id=61860

Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());

int maxLogicalWidth = !includeMaxWidth
style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());

return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));

Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));

Use the new helper methods where possible, deduplicating lots of code.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeReplacedLogicalWidth): (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): (WebCore::RenderBox::computeReplacedLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::computeReplacedLogicalWidth): (WebCore::RenderImage::computeReplacedLogicalHeight):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
6:51 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:48 AM Changeset in webkit [87800] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Gabor Loki <​loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Skip a flakey test on ARM.

  • platform/qt-arm/Skipped:
6:31 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:21 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:04 AM Changeset in webkit [87799] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
​http://trac.webkit.org/changeset/87788
​https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • wtf/DateMath.cpp: (WTF::timeClip):
  • wtf/DateMath.h:

2011-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
​http://trac.webkit.org/changeset/87788
​https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • loader/archive/mhtml/MHTMLArchive.cpp:
  • loader/archive/mhtml/MHTMLArchive.h:
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:

2011-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
​http://trac.webkit.org/changeset/87788
​https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp:
5:44 AM Changeset in webkit [87798] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Skip new failing test because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped:
5:42 AM QtWebKitGardening created by andreas.kling@nokia.com
5:39 AM Changeset in webkit [87797] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-06-01 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
​https://bugs.webkit.org/show_bug.cgi?id=49650

Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
This lets the QNAM backend finish with the reply without handing over ownership to the user code.

No new tests since this doesn't fail for qrc:// or ​file:// URLs and our tests can't depend on ​http:// URLs.

To correctly solve this issue, we need changes to Qt, tracked here:
​http://bugreports.qt.nokia.com/browse/QTBUG-18718

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::download):
  • WebCoreSupport/FrameLoaderClientQt.h:
5:16 AM Changeset in webkit [87796] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-01 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Tor Arne Vestbø.

[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
​https://bugs.webkit.org/show_bug.cgi?id=61739

The skipped test was imported from Qt source repository, and used private headers
to peek in the QML Grid element. This patch changes the QML used to expose the
information we want to test: number of pages opened and the first page opened.

  • tests/qdeclarativewebview/resources/newwindows.html: Added <body> tags. We have no reason to not use them in the test.
  • tests/qdeclarativewebview/resources/newwindows.qml: Moved the timer out of the page component, used anchors for setting webview size, changed the way we count pages opened. Also changed coding style a bit.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: (tst_QDeclarativeWebView::multipleWindows): We now look for properties with the information we want in the rootItem: pagesOpened and firstPageOpened.
5:01 AM Changeset in webkit [87795] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK 64-bit bot.

  • platform/gtk/Skipped: Skipped test.
4:52 AM QtWebKitForQt5 edited by jocelyn.turcotte@nokia.com
(diff)
4:40 AM Changeset in webkit [87794] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-01 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add null checking condition to EditorClientEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=61846

Add null checking condition for using settings() of frame.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
4:17 AM Changeset in webkit [87793] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-06-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
​https://bugs.webkit.org/show_bug.cgi?id=61835

Add a JSLock call before possible allocations in jsFunction and toString.

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody):
4:03 AM Changeset in webkit [87792] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix after r87778.

  • platform/qt/Skipped: Rename editing/pasteboard/4861080.html to editing/pasteboard/drag-drop-list.html.
2:53 AM Changeset in webkit [87791] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Gabor Loki <​loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip flakey tests on ARM

  • platform/qt-arm/Skipped:
2:40 AM Changeset in webkit [87790] by jknotten@chromium.org
  • 1 edit
    76 adds in trunk/LayoutTests

2011-06-01 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Add in baselines for new SVG tests following ​https://bugs.webkit.org/show_bug.cgi?id=15473
​https://bugs.webkit.org/show_bug.cgi?id=61849

  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.txt: Added.
2:23 AM Changeset in webkit [87789] by mario@webkit.org
  • 5 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed. Test rebaselines for GTK after revision 87526.

  • platform/gtk/svg/hixie/text/003-expected.png:
  • platform/gtk/svg/hixie/text/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
2:17 AM Changeset in webkit [87788] by jcivelli@chromium.org
  • 12 edits in trunk/Source

2011-06-01 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Adam Barth.

Added a method to generate RFC 2822 compliant date strings.
​https://bugs.webkit.org/show_bug.cgi?id=7169

  • wtf/DateMath.cpp: (WTF::twoDigitStringFromNumber): (WTF::makeRFC2822DateString):
  • wtf/DateMath.h:

2011-06-01 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
​https://bugs.webkit.org/show_bug.cgi?id=7169

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::generateRandomBoundary): (WebCore::replaceNonPrintableCharacters): (WebCore::MHTMLArchive::generateMHTMLData):
  • loader/archive/mhtml/MHTMLArchive.h:
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:

2011-06-01 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
​https://bugs.webkit.org/show_bug.cgi?id=7169

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML):
2:10 AM Changeset in webkit [87787] by Nikolas Zimmermann
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
​https://bugs.webkit.org/show_bug.cgi?id=15483

The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
it happened somewhen after executing this test, which is probably why it was flakey.

  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
  • svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
1:47 AM Changeset in webkit [87786] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
​https://bugs.webkit.org/show_bug.cgi?id=61803

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
1:29 AM Changeset in webkit [87785] by mario@webkit.org
  • 5 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed. Test rebaselines for GTK after revision 87721.

  • platform/gtk/svg/custom/invalid-fill-expected.png:
  • platform/gtk/svg/custom/invalid-fill-expected.txt:
  • platform/gtk/svg/custom/invalid-fill-hex-expected.png:
  • platform/gtk/svg/custom/invalid-fill-hex-expected.txt:
1:07 AM Changeset in webkit [87784] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87781.
​http://trac.webkit.org/changeset/87781
​https://bugs.webkit.org/show_bug.cgi?id=61842

breaks chromium linux release (Requested by mnaganov on
#webkit).

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
1:04 AM Changeset in webkit [87783] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-01 Oleg Romashin <​romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

platformGeometryDidChange function definition was changed everywhere except Qt.
This is fix for Qt WK2 plugins compilation
​https://bugs.webkit.org/show_bug.cgi?id=61832

  • PluginProcess/qt/PluginControllerProxyQt.cpp: (WebKit::PluginControllerProxy::platformGeometryDidChange):
1:02 AM Changeset in webkit [87782] by Nikolas Zimmermann
  • 5 edits
    72 moves
    10 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Barth.

Move fast/images/*svg* to svg/as-image/
​https://bugs.webkit.org/show_bug.cgi?id=61840

The SVG crowd regulary runs pixel tests, and we'd like to also include the SVG-as-image tests in our daily runs.
Also it makes more sense to have these tests in a single place, just like eg. svg/in-html (html5+svg).

  • fast/images/animated-svg-as-image.html: Removed.
  • fast/images/drag-svg-as-image-expected.txt: Removed.
  • fast/images/drag-svg-as-image.html: Removed.
  • fast/images/resources/animated-rect-fixed-size.svg: Removed.
  • fast/images/resources/animated-rect-relative-size.svg: Removed.
  • fast/images/resources/butterfly.svg: Removed.
  • fast/images/resources/circle.svg: Removed.
  • fast/images/resources/green-fixed-size-rect.svg: Removed.
  • fast/images/resources/green-relative-size-rect.svg: Removed.
  • fast/images/resources/load-script.html: Removed.
  • fast/images/resources/width-100-percent.svg: Removed.
  • fast/images/svg-as-background.html: Removed.
  • fast/images/svg-as-image.html: Removed.
  • fast/images/svg-as-relative-image.html: Removed.
  • fast/images/svg-as-tiled-background.html: Removed.
  • fast/images/svg-background-crash-on-refresh.html-disabled: Removed.
  • fast/images/svg-background-partial-redraw.html: Removed.
  • fast/images/svg-image-leak-loader-expected.txt: Removed.
  • fast/images/svg-image-leak-loader.html: Removed.
  • fast/images/svg-nested-expected.txt: Removed.
  • fast/images/svg-nested.html: Removed.
  • fast/images/svg-width-100p-as-background.html: Removed.
  • platform/chromium-linux/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-linux/svg/as-image: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-linux/fast/images/animated-svg-as-image-expected.png.
  • platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-image: Added.
  • platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/svg/as-image: Added.
  • platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-as-background-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.png.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/gtk/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-background-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-image-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/gtk/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-image: Added.
  • platform/gtk/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.png.
  • platform/gtk/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-background-expected.png: Copied from platform/gtk/fast/images/svg-as-background-expected.png.
  • platform/gtk/svg/as-image/svg-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-background-expected.txt.
  • platform/gtk/svg/as-image/svg-as-image-expected.png: Copied from platform/gtk/fast/images/svg-as-image-expected.png.
  • platform/gtk/svg/as-image/svg-as-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.png.
  • platform/gtk/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.png.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.txt.
  • platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.png.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/mac-leopard/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac-leopard/svg/as-image: Added.
  • platform/mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac-leopard/fast/images/animated-svg-as-image-expected.png.
  • platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
  • platform/mac/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/mac/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-background-expected.png: Removed.
  • platform/mac/fast/images/svg-as-background-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-image-expected.png: Removed.
  • platform/mac/fast/images/svg-as-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/mac/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-tiled-background-expected.png: Removed.
  • platform/mac/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/mac/fast/images/svg-background-crash-on-refresh-expected.png: Removed.
  • platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt: Removed.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/mac/svg/as-image: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac/fast/images/animated-svg-as-image-expected.png.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/mac/fast/images/animated-svg-as-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-background-expected.png: Copied from platform/mac/fast/images/svg-as-background-expected.png.
  • platform/mac/svg/as-image/svg-as-background-expected.txt: Copied from platform/mac/fast/images/svg-as-background-expected.txt.
  • platform/mac/svg/as-image/svg-as-image-expected.png: Copied from platform/mac/fast/images/svg-as-image-expected.png.
  • platform/mac/svg/as-image/svg-as-image-expected.txt: Copied from platform/mac/fast/images/svg-as-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/mac/fast/images/svg-as-relative-image-expected.png.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/mac/fast/images/svg-as-relative-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.png.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.txt.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.png.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.png.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.png.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-background-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/qt/svg/as-image: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/qt/fast/images/animated-svg-as-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-background-expected.txt: Copied from platform/qt/fast/images/svg-as-background-expected.txt.
  • platform/qt/svg/as-image/svg-as-image-expected.txt: Copied from platform/qt/fast/images/svg-as-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/qt/fast/images/svg-as-relative-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/fast/images/svg-as-tiled-background-expected.txt.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.png.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/fast/images/svg-width-100p-as-background-expected.txt.
  • svg/as-image: Added.
  • svg/as-image/animated-svg-as-image.html: Copied from fast/images/animated-svg-as-image.html.
  • svg/as-image/drag-svg-as-image-expected.txt: Copied from fast/images/drag-svg-as-image-expected.txt.
  • svg/as-image/drag-svg-as-image.html: Copied from fast/images/drag-svg-as-image.html.
  • svg/as-image/resources: Added.
  • svg/as-image/resources/animated-rect-fixed-size.svg: Copied from fast/images/resources/animated-rect-fixed-size.svg.
  • svg/as-image/resources/animated-rect-relative-size.svg: Copied from fast/images/resources/animated-rect-relative-size.svg.
  • svg/as-image/resources/butterfly.svg: Copied from fast/images/resources/butterfly.svg.
  • svg/as-image/resources/circle.svg: Copied from fast/images/resources/circle.svg.
  • svg/as-image/resources/green-fixed-size-rect.svg: Copied from fast/images/resources/green-fixed-size-rect.svg.
  • svg/as-image/resources/green-relative-size-rect.svg: Copied from fast/images/resources/green-relative-size-rect.svg.
  • svg/as-image/resources/load-script.html: Copied from fast/images/resources/load-script.html.
  • svg/as-image/resources/width-100-percent.svg: Copied from fast/images/resources/width-100-percent.svg.
  • svg/as-image/svg-as-background.html: Copied from fast/images/svg-as-background.html.
  • svg/as-image/svg-as-image.html: Copied from fast/images/svg-as-image.html.
  • svg/as-image/svg-as-relative-image.html: Copied from fast/images/svg-as-relative-image.html.
  • svg/as-image/svg-as-tiled-background.html: Copied from fast/images/svg-as-tiled-background.html.
  • svg/as-image/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html-disabled.
  • svg/as-image/svg-background-partial-redraw.html: Copied from fast/images/svg-background-partial-redraw.html.
  • svg/as-image/svg-image-leak-loader-expected.txt: Copied from fast/images/svg-image-leak-loader-expected.txt.
  • svg/as-image/svg-image-leak-loader.html: Copied from fast/images/svg-image-leak-loader.html.
  • svg/as-image/svg-nested-expected.txt: Copied from fast/images/svg-nested-expected.txt.
  • svg/as-image/svg-nested.html: Copied from fast/images/svg-nested.html.
  • svg/as-image/svg-width-100p-as-background.html: Copied from fast/images/svg-width-100p-as-background.html.
12:46 AM Changeset in webkit [87781] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
​https://bugs.webkit.org/show_bug.cgi?id=61803

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
12:40 AM Changeset in webkit [87780] by Dimitri Glazkov
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-06-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
​https://bugs.webkit.org/show_bug.cgi?id=61816

This is a near-mechanical move-and-rename of ShadowElement, which is now only
used by input[type=file]. Next step -- switch it over to new shadow DOM.

Refactoring, no change in behavior.

  • CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore/rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton. (WebCore::UploadButton::detach): Ditto. (WebCore::UploadButton::UploadButton): Ditto. (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
  • rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
  • rendering/RenderProgress.cpp: Ditto.
  • rendering/ShadowElement.cpp: Removed.
  • rendering/ShadowElement.h: Removed.
12:30 AM Changeset in webkit [87779] by Nikolas Zimmermann
  • 5 edits
    54 adds in trunk

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG fails all 3 of Hixie's CSS intrinsic sizing tests
​https://bugs.webkit.org/show_bug.cgi?id=15473

Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.

Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic: Added.
  • platform/mac/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/003-expected.txt: Added.
  • svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/resources/object-sizing-height-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p-height-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p-height-75p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-75p-height-50p.svg: Added.
  • svg/hixie/intrinsic: Added.
  • svg/hixie/intrinsic/001.html: Added.
  • svg/hixie/intrinsic/002.html: Added.
  • svg/hixie/intrinsic/003.html: Added.
  • svg/hixie/intrinsic/resources: Added.
  • svg/hixie/intrinsic/resources/001.svg: Added.
  • svg/hixie/intrinsic/resources/002.svg: Added.
  • svg/hixie/intrinsic/resources/003.svg: Added.
  • svg/hixie/intrinsic/resources/test-bl: Added.
  • svg/hixie/intrinsic/resources/test-br: Added.
  • svg/hixie/intrinsic/resources/test-tl: Added.
  • svg/hixie/intrinsic/resources/test-tr: Added.

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG fails all 3 of Hixie's CSS intrinsic sizing tests
​https://bugs.webkit.org/show_bug.cgi?id=15473

Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.

Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml

svg/custom/object-sizing-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
svg/hixie/intrinsic/001.html
svg/hixie/intrinsic/002.html
svg/hixie/intrinsic/003.html

  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicRatio):
  • rendering/svg/RenderSVGRoot.h:
12:16 AM Changeset in webkit [87778] by commit-queue@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-06-01 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert editing/pasteboard/4861010 to dump-as-markup
​https://bugs.webkit.org/show_bug.cgi?id=61683

Renamed test to drag-drop-list.html, cleaned up html, and updated description.

  • editing/pasteboard/4861080.html: Removed.
  • editing/pasteboard/drag-drop-list.html: Copied from LayoutTests/editing/pasteboard/4861080.html.
  • platform/chromium-linux/editing/pasteboard/4861080-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4861080-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4861080-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/4861080-expected.png: Removed.
  • platform/gtk/editing/pasteboard/4861080-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/4861080-expected.png: Removed.
  • platform/mac/editing/pasteboard/4861080-expected.png: Removed.
  • platform/mac/editing/pasteboard/4861080-expected.txt: Removed.

May 31, 2011:

11:57 PM Changeset in webkit [87777] by tkent@chromium.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

Convert fast/forms/date-input-visible-strings.html to dumpAsText().
​https://bugs.webkit.org/show_bug.cgi?id=61777

  • fast/forms/date-input-visible-strings.html:
  • fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/win/fast/forms/date-input-visible-strings-expected.txt: Removed.
11:25 PM Changeset in webkit [87776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Timeline panel improvements for managing current selection
​https://bugs.webkit.org/show_bug.cgi?id=61468

Enables X-axis dragging of the selected area.
Double click zoom-out.
Fixes slightly wrong selection area position.

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum): (WebInspector.TimelineOverviewPane.prototype.scrollWindow): (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel):
11:18 PM Changeset in webkit [87775] by commit-queue@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-05-31 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
​https://bugs.webkit.org/show_bug.cgi?id=61682

Convert test to dump-as-markup and clean up HTML. Also update test description.

  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote-2.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
10:54 PM Changeset in webkit [87774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-31 Hao Zheng <​zhenghao@chromium.org>

Reviewed by Dirk Pranke.

Fix exception in verbose printing mode.
​https://bugs.webkit.org/show_bug.cgi?id=61723

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
10:46 PM Changeset in webkit [87773] by keishi@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-05-31 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Fix to enable page scroll of select element
​https://bugs.webkit.org/show_bug.cgi?id=53628

Manual test: select-page-scroll.html

  • manual-tests/select-page-scroll.html: Added.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
10:09 PM Changeset in webkit [87772] by kinuko@chromium.org
  • 8 edits
    3 adds in trunk

2011-05-31 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
​https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/storageinfo-no-callbacks-expected.txt: Added.
  • storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
​https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):
7:40 PM Changeset in webkit [87771] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-31 Yong Li <​yoli@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • bytecode/StructureStubInfo.h:

2011-05-31 Yong Li <​yoli@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.h:
  • rendering/InlineBox.h:
  • rendering/RenderBlock.h:

2011-05-31 Yong Li <​yoli@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

  • Scripts/webkitpy/style/checkers/cpp.py:
7:39 PM QtWebKitForQt5 edited by noam.rosenthal@nokia.com
(diff)
7:25 PM Changeset in webkit [87770] by morrita@google.com
  • 15 edits
    2 adds in trunk

2011-05-31 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
​https://bugs.webkit.org/show_bug.cgi?id=50952

This adds a new layout test to verify that we can receive input events
when we change the text direction of a <textarea> element and an <input>
element.

  • fast/html/set-text-direction-expected.txt: Added.
  • fast/html/set-text-direction.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-31 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
​https://bugs.webkit.org/show_bug.cgi?id=50952

Both Safari and Chrome call Editor::setBaseWritingDirection() to change
the text direction of an editable element with their UIs. This change
calls dispatchInputEvent() to send an input event when the function
actually changes the "dir" attribute so we can send an input event as
written in the HTML5 spec.

Test: fast/html/set-text-direction.html

  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):

2011-05-31 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

Add a JavaScript function layoutTestController.setTextDirection().
​https://bugs.webkit.org/show_bug.cgi?id=50952

This change adds a new JavaScript function setTextDirection() to the
LayoutTestController class of Safari and Chrome to write layout tests
that changes the text direction of an editable element.

  • DumpRenderTree/LayoutTestController.cpp: (setTextDirectionCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setTextDirection):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTextDirection):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTextDirection):
7:22 PM Changeset in webkit [87769] by cevans@google.com
  • 2 edits in trunk/Websites/webkit.org

2011-05-31 Chris Evans <​cevans@chromium.org>

Reviewed by Drew Yao.

Add "Collaboration" to WebKit Security Group Privileges and Responsibilities section.

  • security/index.html: Add "Collaboration" section with text discussed on webkit-security.
6:48 PM Changeset in webkit [87768] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-05-31 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
​https://bugs.webkit.org/show_bug.cgi?id=61756

Added two new entries to the WebCore exports list.

  • WebCore.exp.in:

2011-05-31 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
​https://bugs.webkit.org/show_bug.cgi?id=61756

The @"WebKitLayerHostChanged" notification is causing the QTMovie to tear down its layer
(which is good) at the wrong time (which is bad). Send this notification only after
the dragImage snapshot is taken. This exposed another problem, that the snapshot has
a white background. Set the default background color and transparency for the view (making
sure to reset them afterwards) to transparent.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
6:47 PM Changeset in webkit [87767] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-31 Rafael Brandao <​rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
​https://bugs.webkit.org/show_bug.cgi?id=60893

Due a problem on QPicture (​http://bugreports.qt.nokia.com/browse/QTBUG-19496),
this test was calculating the final geometry incorrectly. As the order between
a translate and a draw operation could be relevant for it, but not for the
final rendered result, they were changed on ScrollbarThemeQt::paint.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):

2011-05-31 Rafael Brandao <​rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
​https://bugs.webkit.org/show_bug.cgi?id=60893

The test was expecting the frame contents to be already loaded
before rendering it into a QPicture. Renamed the test to fit
its real purpose more accordingly.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::renderGeometry):
6:42 PM Rebaseline edited by dpranke@chromium.org
(diff)
6:26 PM Changeset in webkit [87766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-31 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] gtkdoc run produces many warnings about missing declarations
​https://bugs.webkit.org/show_bug.cgi?id=61797

  • docs/webkitgtk-sections.txt: Remove inexistent symbols from this file to reduce the number of gtkdoc warnings.
6:05 PM Changeset in webkit [87765] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-31 Raphael Kubo da Costa <​kubo@profusion.mobi>

Reviewed by Adam Barth.

[efl] Add ewk API to enable/disable developer extras.
​https://bugs.webkit.org/show_bug.cgi?id=61746

Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_developer_extras_get): (ewk_view_setting_enable_developer_extras_set):
  • ewk/ewk_view.h:
5:43 PM Changeset in webkit [87764] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Daniel Erat <​derat@chromium.org>

Reviewed by Tony Chang.

Make WebScreenInfoFactory return fresh screen dimensions.
​https://bugs.webkit.org/show_bug.cgi?id=61679

  • public/x11/WebScreenInfoFactory.h:
  • src/x11/WebScreenInfoFactory.cpp: (WebKit::WebScreenInfoFactory::screenInfo):
5:14 PM Changeset in webkit [87763] by Ademar Reis
  • 3 edits in trunk/Tools

2011-05-31 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Simon Hausmann.

[Qt] User-agent list of Qt test browsers is very outdated
​https://bugs.webkit.org/show_bug.cgi?id=61531

The user can edit the user-agent manually, so there's no need to have
a super complete and up to date list, but it's nice to have it
minimally updated.

  • MiniBrowser/qt/useragentlist.txt:
  • QtTestBrowser/useragentlist.txt:
4:49 PM Changeset in webkit [87762] by enne@google.com
  • 4 edits
    2 adds in trunk

2011-05-27 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
​https://bugs.webkit.org/show_bug.cgi?id=61654

  • compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
  • compositing/reflections/empty-reflection-with-mask.html: Added.

2011-05-27 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
​https://bugs.webkit.org/show_bug.cgi?id=61654

Change the iteration for updateCompositorResources to match that being
done in the paint and draw steps. This mismatch of iteration style
was causing layers with replica masks to correctly get skipped while
painting but not get skipped during texture upload.

Test: compositing/reflections/empty-reflection-with-mask.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerRendererChromium.h:
4:37 PM Changeset in webkit [87761] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 87743

BUG=84452
Review URL: ​http://codereview.chromium.org/7057049

4:35 PM Changeset in webkit [87760] by Martin Robinson
  • 11 edits
    4 copies
    6 adds in trunk

2011-03-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57068

  • GNUmakefile.am: Added reference to WebKitTestRunner GNUmakefile.

2011-03-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57068

Added InjectedBundle support for GTK+.

  • WebProcess/InjectedBundle/InjectedBundle.h: Added typedef for GTK+.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added implementation. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Remove unnecessary method definition.

2011-03-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=57068

Add an implementation of WebKitTestRunner for GTK+.

  • Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
  • Scripts/old-run-webkit-tests: Ditto.
  • Scripts/run-launcher: Ditto.
  • Scripts/webkitdirs.pm: Ditto.
  • WebKitTestRunner/GNUmakefile.am: Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
  • WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (main): Added.
4:35 PM Changeset in webkit [87759] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 87737

BUG=84333
Review URL: ​http://codereview.chromium.org/7057048

3:40 PM Changeset in webkit [87758] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-31 Berend-Jan Wever <​skylined@chromium.org>

Reviewed by Adam Barth.

Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
when no error callback is supplied does not cause a NULL ptr.
​https://bugs.webkit.org/show_bug.cgi?id=49539

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.

2011-05-31 B.J. Wever <​skylined@chromium.org>

Reviewed by Adam Barth.

requestFileSystem and resolveLocalFileSystemURI are not checking if
errorCallback is NULL before scheduling a callback on error.
​https://bugs.webkit.org/show_bug.cgi?id=49539

Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::scheduleCallback): Only call callback if one is supplied.
3:26 PM Changeset in webkit [87757] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-31 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
​https://bugs.webkit.org/show_bug.cgi?id=60241

  • Scripts/new-run-webkit-tests:
3:13 PM Changeset in webkit [87756] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

Another swipe at resolving <rdar://problem/9125145> and ​https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Re-land ​http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
3:11 PM Changeset in webkit [87755] by mitz@apple.com
  • 12 edits in trunk/Source/WebKit2

<rdar://problem/9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigating between pages on wsj.com, other sites (when navigating away from composited page)
​https://bugs.webkit.org/show_bug.cgi?id=61808

Reviewed by Simon Fraser.

WebKit1 has a mechanism to prevent the stale bits from the outgoing page from being erased
until the incoming page has layout. Adapt this in WebKit2 to prevent the composited layer tree
of the outgoing page from being torn down or updated until the incoming page has layout.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Unfreeze the layer tree state.
(WebKit::WebFrameLoaderClient::frameLoadCompleted): Ditto.
(WebKit::WebFrameLoaderClient::provisionalLoadStarted): Freeze the layer tree state.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setLayerTreeStateIsFrozen): Added.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member variables.
(WebKit::DrawingAreaImpl::setLayerTreeStateIsFrozen): Added. When freezing, sets the flag and
disables layer flush scheduling and exiting accelerated compositing mode. When unfreezing,
clears the flag and exits compositing mode if needed.
(WebKit::DrawingAreaImpl::setRootCompositingLayer): Reset m_wantsToExitAcceleratedCompositingMode.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon): If the layer tree state is frozen,
bail out but set m_wantsToExitAcceleratedCompositingMode.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Initialize m_layerFlushSchedulingEnabled.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Added an assertion.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
3:03 PM Changeset in webkit [87754] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-31 Hao Zheng <​zhenghao@chromium.org>

Reviewed by Tony Chang.

Flush output buffer of php.
​https://bugs.webkit.org/show_bug.cgi?id=56060

On Lucid, the output buffer is enabled by default, but it's not
enabled on Hardy. Fix test http/tests/loading/preload-slow-loading.php
​http://www.php.net/manual/en/function.ob-flush.php

  • http/tests/loading/preload-slow-loading.php:
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [87753] by leviw@chromium.org
  • 20 edits in trunk/Source/WebCore

2011-05-31 Levi Weintraub <​leviw@chromium.org>

Reviewed by Simon Fraser.

Change InlineBox::paint and its overloaded variants to use IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61804

Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
to use IntPoint for their paint offset instead of a pair of ints.

No new tests since this is just a refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint):
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • rendering/svg/SVGRootInlineBox.h:
2:50 PM Changeset in webkit [87752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
​https://bugs.webkit.org/show_bug.cgi?id=61593

Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
This is extremely defensive and not strictly necessary, but not harmful either.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::~CCLayerImpl):
2:15 PM Changeset in webkit [87751] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-31 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

webkitpy should create zips with zip -9
​https://bugs.webkit.org/show_bug.cgi?id=61789

Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
2:02 PM Changeset in webkit [87750] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Stephen White <​senorblanco@chromium.org>

Unreviewed; build fix.

Silence some warnings on the Safari/Mac release build.

  • platform/graphics/gpu/TilingData.h: (WebCore::TilingData::assertTile):
1:53 PM Changeset in webkit [87749] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-31 Adam Barth <​abarth@webkit.org>

Add chromium-mac-leopard image results for these SVG tests.

  • platform/chromium-mac-leopard/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-uri-stroke-expected.png: Added.
1:21 PM Changeset in webkit [87748] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 Justin Novosad <​junov@chromium.org>

Reviewed by Stephen White.

[Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
​https://bugs.webkit.org/show_bug.cgi?id=61790
Changing the build guards in these two files that are required
by the accelerated compositing feature.

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  • platform/graphics/gpu/TilingData.cpp:
12:56 PM WebKit Team edited by tonikitoo@webkit.org
(diff)
12:51 PM Changeset in webkit [87747] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-31 Rob Buis <​rbuis@rim.com>

RS=Dirk Schulze.

run-webkit-tests on animate-path-nested-transform.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=61798

"Fix" the crashing test by choosing safer values.

  • svg/animations/script-tests/animate-path-nested-transforms.js: (executeTest):
12:38 PM Changeset in webkit [87746] by rwlbuis@webkit.org
  • 6 edits
    5 adds in trunk

2011-05-31 Rob Buis <​rbuis@rim.com>

Reviewed by Dirk Schulze.

​https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

​https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Add missing idl files.

Test: svg/animations/animate-mpath-insert.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAnimateMotionElement.idl: Added.
  • svg/SVGMPathElement.idl: Added.

2011-05-31 Rob Buis <​rbuis@rim.com>

Reviewed by Dirk Schulze.

​https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

​https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Verify that adding mpath via javascript works.

  • svg/animations/animate-mpath-insert-expected.txt: Added.
  • svg/animations/animate-mpath-insert.html: Added.
  • svg/animations/script-tests/animate-mpath-insert.js: Added. (mpath.setAttributeNS.animateMotion.appendChild.g.appendChild.rootSVGElement.appendChild.passIfCloseEnough): (startSample): (endSample): (executeTest):
12:21 PM Changeset in webkit [87745] by kevino@webkit.org
  • 10 edits in trunk/Source

Reviewed by Kevin Ollivier.

[wx] Implement printing support for wxWidgets 2.9.x and above.

​https://bugs.webkit.org/show_bug.cgi?id=61796

11:53 AM Changeset in webkit [87744] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-05-31 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
​https://bugs.webkit.org/show_bug.cgi?id=61751

Add missing stub function causing an error on load.

  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
11:16 AM Changeset in webkit [87743] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Improve hasMediaControls logic to check that node has
media controls. This can be false when cloning nodes.
​https://bugs.webkit.org/show_bug.cgi?id=61765

Test: media/media-controls-clone-crash.html

  • dom/Node.h: (WebCore::Node::isMediaControls):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): (WebCore::HTMLMediaElement::hasMediaControls):
  • html/shadow/MediaControls.h: (WebCore::MediaControls::isMediaControls): (WebCore::toMediaControls):

2011-05-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that cloning an audio element with media controls does
not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=61765

  • media/media-controls-clone-crash-expected.txt: Added.
  • media/media-controls-clone-crash.html: Added.
11:14 AM Changeset in webkit [87742] by xan@webkit.org
  • 2 edits in trunk

2011-05-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Bump version to 1.5.1.

  • configure.ac:
11:10 AM Changeset in webkit [87741] by xan@webkit.org
  • 4 edits
    2 adds in trunk/Source

2011-05-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
​https://bugs.webkit.org/show_bug.cgi?id=61791

  • bindings/gobject/GNUmakefile.am: add new files.
  • bindings/gobject/WebKitDOMCustom.cpp: Added. (webkit_dom_html_text_area_element_is_edited): (webkit_dom_html_input_element_is_edited):
  • bindings/gobject/WebKitDOMCustom.h: Added.

2011-05-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
​https://bugs.webkit.org/show_bug.cgi?id=61791

  • GNUmakefile.am: add new files.
10:55 AM Changeset in webkit [87740] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-31 Andreas Kling <​kling@webkit.org>

Unreviewed. Rebaseline Mac after JSC/Canvas bindings changes.

  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
10:22 AM Changeset in webkit [87739] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-31 Noam Rosenthal <​noam.rosenthal@nokia.com>

Unreviewed build fix for Symbian.
Opt-out Symbian for TextureMapper.

No new tests: build fix.

  • WebCore.pri:
10:12 AM Changeset in webkit [87738] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-31 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFocusRing to IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=61580

Switching paintFocusRing to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests as this is just refactoring.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
9:51 AM Changeset in webkit [87737] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Convert raw ptr to RefPtr for documentElement.
​https://bugs.webkit.org/show_bug.cgi?id=61688

Test: fast/dom/xml-parser-error-message-crash.svg

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock):

2011-05-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Test that we do not crash when a DOMNodeInsertedIntoDocument event
is fired while generating a error message block in xml parsing.
​https://bugs.webkit.org/show_bug.cgi?id=61688

  • fast/dom/xml-parser-error-message-crash-expected.txt: Added.
  • fast/dom/xml-parser-error-message-crash.svg: Added.
9:28 AM Changeset in webkit [87736] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
​https://bugs.webkit.org/show_bug.cgi?id=61786

Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-setShadow.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
​https://bugs.webkit.org/show_bug.cgi?id=61786

Add a test to verify the behavior of setShadow() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-setShadow-expected.txt: Added.
  • fast/canvas/canvas-overloads-setShadow.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setShadow.js: Added.
9:25 AM Changeset in webkit [87735] by andreas.kling@nokia.com
  • 5 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
​https://bugs.webkit.org/show_bug.cgi?id=61709

Add a test to verify the behavior of drawImageFromRect() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImageFromRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImageFromRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js: Added.

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
​https://bugs.webkit.org/show_bug.cgi?id=61709

Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
Side effect: calling drawImageFromRect() with zero arguments will now raise
SyntaxError instead of TypeError.

Test: fast/canvas/canvas-overloads-drawImageFromRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
9:22 AM Changeset in webkit [87734] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
​https://bugs.webkit.org/show_bug.cgi?id=61703

Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-drawImage.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
​https://bugs.webkit.org/show_bug.cgi?id=61703

Add a test to verify the behavior of drawImage() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImage-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImage.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImage.js: Added.
9:20 AM Changeset in webkit [87733] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
​https://bugs.webkit.org/show_bug.cgi?id=61641

Add a test to verify the behavior of strokeRect() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-strokeRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeRect.js: Added.

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
​https://bugs.webkit.org/show_bug.cgi?id=61641

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

No behavioral change.

Test: fast/canvas/canvas-overloads-strokeRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:15 AM Changeset in webkit [87732] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
​https://bugs.webkit.org/show_bug.cgi?id=61635

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setFillColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
​https://bugs.webkit.org/show_bug.cgi?id=61635

Add a test to verify the behavior of setFillColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setFillColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setFillColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setFillColor.js: Added.
9:12 AM Changeset in webkit [87731] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
​https://bugs.webkit.org/show_bug.cgi?id=61629

Add a test to verify the behavior of setStrokeColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setStrokeColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setStrokeColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setStrokeColor.js: Added.

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
​https://bugs.webkit.org/show_bug.cgi?id=61629

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setStrokeColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:10 AM Changeset in webkit [87730] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
​https://bugs.webkit.org/show_bug.cgi?id=61626

Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-strokeText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
​https://bugs.webkit.org/show_bug.cgi?id=61626

Add a test to verify the behavior of strokeText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling strokeText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-strokeText-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeText.js: Added.
9:08 AM Changeset in webkit [87729] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
​https://bugs.webkit.org/show_bug.cgi?id=61623

Add a test to verify the behavior of fillText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling fillText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-fillText-expected.txt: Added.
  • fast/canvas/canvas-overloads-fillText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-fillText.js: Added.

2011-05-31 Andreas Kling <​kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
​https://bugs.webkit.org/show_bug.cgi?id=61623

Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-fillText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:05 AM Changeset in webkit [87728] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Allow Chromium porting layer to use Skia on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=61548

  • public/WebCommon.h: Don't allow WebKit to use CG if it is already using Skia.
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::paintScrollbarThumb): Allow scrollbar thumb draw to take WebCanvas.
8:38 AM Changeset in webkit [87727] by commit-queue@webkit.org
  • 2 edits
    7 adds in trunk/Source/WebKit2

2011-05-31 ChangeLog <​james.cooley@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Qt port needs test content for QWKHistory
​https://bugs.webkit.org/show_bug.cgi?id=57850

Created data-driven QTestLib tests for existing QWKHistory APIs.

This walks through loading four simple pages, navigating
backwards and forwards.

We check the results at each action by creating expected forward/back
lists and comparing those lists in count and membership to those kept by
WebKit and retrieved via the QWKHistory APIs.

  • UIProcess/API/qt/tests/html/a.htm: Added.
  • UIProcess/API/qt/tests/html/b.htm: Added.
  • UIProcess/API/qt/tests/html/c.htm: Added.
  • UIProcess/API/qt/tests/html/d.htm: Added. Four added simple pages
  • UIProcess/API/qt/tests/qwkhistory: Added.
  • UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro: Added. Created qwkhistory folder and pro
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Added. (TestHistoryItem::title): (TestHistoryItem::url): (TestHistoryItem::TestHistoryItem): Utility class to hold expected url,title for test

(tst_QWKHistory::initTestCase):
(tst_QWKHistory::historyFBTest_data):
(tst_QWKHistory::historyFBTest):
init, data, and data-driven test case

  • UIProcess/API/qt/tests/tests.pro: Included qwkhistory in tests.pro
7:20 AM Changeset in webkit [87726] by Simon Fraser
  • 3 edits
    5 adds in trunk

2011-05-31 Simon Fraser <Simon Fraser>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
​https://bugs.webkit.org/show_bug.cgi?id=61491

  • fast/frames/flattening/iframe-flattening-nested.html: Added.
  • fast/frames/flattening/resources/inner-frame.html: Added.
  • fast/frames/flattening/resources/intermediate-frame.html: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.

2011-05-31 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
​https://bugs.webkit.org/show_bug.cgi?id=61491

After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.

Test: fast/frames/flattening/iframe-flattening-nested.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
6:46 AM Changeset in webkit [87725] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Tommy Widenflycht <​tommyw@google.com>

Reviewed by Tony Gentilcore.

Fix getUserMedia callback bindings for JSC.
​https://bugs.webkit.org/show_bug.cgi?id=60174

This patch initializes the exception code variable to 0.

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
6:32 AM Changeset in webkit [87724] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] Implement find feature for QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=61425

Patch by Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-31
Reviewed by Csaba Osztrogonác.

Buildfix for --minimal and CONFIG+=qt_minimal build.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:
5:43 AM Changeset in webkit [87723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Oleg Romashin <​oleg.romashin@nokia.com>

Reviewed by Benjamin Poulain.

Fix compilation with debug enabled, m_lightSource.type is not valid anymore
​https://bugs.webkit.org/show_bug.cgi?id=61719

  • platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):
5:39 AM QtWebKitForQt5 edited by Simon Hausmann
(diff)
4:49 AM Changeset in webkit [87722] by mnaganov@chromium.org
  • 4 edits
    3 copies
    12 adds in trunk/LayoutTests

2011-05-31 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed tests results rebaseline after r87721.

  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.png:
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.txt: Added.
3:46 AM Changeset in webkit [87721] by commit-queue@webkit.org
  • 13 edits
    10 adds in trunk

2011-05-31 Oliver Varga <​Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
​https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (​http://www.w3.org/TR/SVG/).

  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/mac/svg/custom/invalid-fill-expected.png:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.png:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/mac/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/qt/svg/custom/invalid-fill-expected.txt:
  • platform/qt/svg/custom/invalid-fill-hex-expected.txt:
  • platform/qt/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/qt/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • svg/custom/invalid-fill-hex.svg:
  • svg/custom/invalid-fill.svg:
  • svg/custom/invalid-stroke-hex.svg: Added.
  • svg/custom/invalid-uri-stroke.svg: Added.

2011-05-31 Oliver Varga <​Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
​https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (​http://www.w3.org/TR/SVG/).

Tests: svg/custom/invalid-stroke-hex.svg

svg/custom/invalid-uri-stroke.svg

  • rendering/svg/RenderSVGResource.cpp: (WebCore::inheritColorFromParentStyleIfNeeded): (WebCore::requestPaintingResource):
3:42 AM Changeset in webkit [87720] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-31 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement find feature for QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=61425

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::showFindBar): (LauncherWindow::find):
  • QtTestBrowser/launcherwindow.h:
3:20 AM Changeset in webkit [87719] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-31 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Make the output of client-close.html more verbose
​https://bugs.webkit.org/show_bug.cgi?id=61770

  • http/tests/websocket/tests/client-close-expected.txt:
  • http/tests/websocket/tests/client-close.html:
  • http/tests/websocket/tests/client-close_wsh.py: Echo back the first two bytes received from the client.
2:58 AM Changeset in webkit [87718] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kent Tamura.

[chromium] Avoid double deletion of DrawingBuffer's color buffer
texture.
​https://bugs.webkit.org/show_bug.cgi?id=61761

Test: Verified that the DCHECK in GraphicsContext3D implementation
doesn't trigger.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer):
2:10 AM Changeset in webkit [87717] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Ossyize editing/pasteboard/copy-standalone-image-crash.html since eventSender is not implemented.

  • platform/qt-wk2/Skipped:
1:50 AM QtWebKitForQt5 edited by Simon Hausmann
More cleanups (diff)
1:49 AM QtWebKitForQt5 edited by Simon Hausmann
AC wording cleanup (diff)
1:45 AM QtWebKitForQt5 edited by Simon Hausmann
Mentioning theming (diff)
12:39 AM Changeset in webkit [87716] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-30 Hayato Ito <​hayato@chromium.org>

Reviewed by Ryosuke Niwa.

Add a utility function for dumping a tree for the Node, including a document of a frame.
​https://bugs.webkit.org/show_bug.cgi?id=61727

No new tests since added functions are only available in debug builds.

  • dom/Node.cpp: (WebCore::parentOrHostOrFrameOwner): (WebCore::traverseNextNodeAcrossFrame): (WebCore::Node::showTreeForThisAcrossFrame):
  • dom/Node.h:
12:29 AM Changeset in webkit [87715] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-31 Yuta Kitamura <​yutak@chromium.org>

Unreviewed. Update Chromium test expectation for http/tests/websocket/tests/client-close.html.

  • platform/chromium/test_expectations.txt:
12:01 AM Changeset in webkit [87714] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-30 Gabor Loki <​loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip crashed test after r87691-r87693 on ARM
​https://bugs.webkit.org/show_bug.cgi?id=61764

  • platform/qt-arm/Skipped:
Note: See TracTimeline for information about the timeline view.