⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 5, 2011:

11:12 PM Changeset in webkit [88143] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
10:54 PM Changeset in webkit [88142] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix.

  • platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518.
10:49 PM Changeset in webkit [88141] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Skip new failing tests.

  • platform/qt-mac/Skipped:
10:38 PM Changeset in webkit [88140] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:56 PM Changeset in webkit [88139] by inferno@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-04 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kent Tamura.

Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
​https://bugs.webkit.org/show_bug.cgi?id=62085

Testing ComplexTextControllerLinux change requires a testcase

32 kb which is not feasible. All other changes are tested by

existing layouttests.

  • platform/graphics/TextRun.h: (WebCore::TextRun::operator[]): add assert. (WebCore::TextRun::data): add assert.
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance): bail early and prevent access to one byte across the text run boundary.
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): wrong int16 vs int comparison.
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk): bail early when from and to is outside the text run boundary. this hit easily after adding the assert when from = to = end and read in run.data(from).
9:07 PM Changeset in webkit [88138] by tkent@chromium.org
  • 3 edits
    2 deletes in branches/chromium/782

Merge 88137

2011-06-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
​http://trac.webkit.org/changeset/84528
​https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
​http://trac.webkit.org/changeset/84528
​https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):

TBR=​tkent@chromium.org
BUG=84819
Review URL: ​http://codereview.chromium.org/6993052

7:01 PM Changeset in webkit [88137] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk

2011-06-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
​http://trac.webkit.org/changeset/84528
​https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
​http://trac.webkit.org/changeset/84528
​https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
1:13 PM Changeset in webkit [88136] by ap@apple.com
  • 2 edits in trunk/Tools

Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
works properly).

  • Scripts/webkitpy/common/config/committers.py:
1:12 PM Changeset in webkit [88135] by robert@webkit.org
  • 5 edits
    3 copies
    3 adds
    2 deletes in trunk

2011-06-05 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
​https://bugs.webkit.org/show_bug.cgi?id=62089

We're unskipping acid2.html event though it's just a landing
page for the acid2 test. Some elements of the test are loaded by
the landing page so it is testing something, but acid2-pixel covers the same
ground.

  • platform/qt/Skipped:
  • platform/qt/fast/css/acid2-expected.txt: Updated
  • platform/qt/fast/css/acid2-pixel-expected.png: Added.
  • platform/qt/fast/css/acid2-pixel-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Removed.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Removed.
  • platform/qt/http/tests/misc/acid2-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-expected.txt: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt: Added

2011-06-04 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
​https://bugs.webkit.org/show_bug.cgi?id=62089

shouldFallBack() tells the DOM if it should attempt to render
the next nested <object> if its parent fails to load.

This fix is only required for the fast/css version of the ACID2
test, which loads a non-existent ​file:// url. The HTTP version of the
test already passes because the loader will render fallback content
on a failed HTTP load without delegating the decision to the client
( see MainResourceLoader::continueAfterContentPolicy).

Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
what to return. This error isn't currently set by Qt so we don't check
it. (Other ports set it when the erring document is a MediaDocument, maybe
we should do that too at some point).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldFallBack):
11:34 AM Changeset in webkit [88134] by commit-queue@webkit.org
  • 6 edits in trunk

2011-06-05 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
​https://bugs.webkit.org/show_bug.cgi?id=47481

Rebaseline tests.

  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • platform/qt/Skipped:

2011-06-05 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
​https://bugs.webkit.org/show_bug.cgi?id=47481

computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
10:03 AM Changeset in webkit [88133] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4

2011-09-09 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Update the library and user-facing version in preparation
for the 1.4.1 release.

  • configure.ac: Update the versions.

Jun 4, 2011:

10:28 PM Changeset in webkit [88132] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx.

10:07 PM Changeset in webkit [88131] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac.

9:38 PM Changeset in webkit [88130] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fixes for recent trunk changes.

9:33 PM Changeset in webkit [88129] by cevans@google.com
  • 4 edits in branches/chromium/782/Source/WebCore/accessibility

Merge 87856
BUG=84950
Review URL: ​http://codereview.chromium.org/7058064

8:21 PM Changeset in webkit [88128] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over some ChangeLogs.

7:08 PM Changeset in webkit [88127] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-06-04 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Disable WebProcess side display throttling when in a user scroll
<rdar://problem/9517175>
​https://bugs.webkit.org/show_bug.cgi?id=62095

Add the ability to disable WebProcess side display throttling that
takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
when in a user or animated scroll.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::enableDisplayThrottling): (WebKit::DrawingArea::disableDisplayThrottling):
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::enableDisplayThrottling): (WebKit::DrawingAreaImpl::disableDisplayThrottling): (WebKit::DrawingAreaImpl::displayTimerFired):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::wheelEvent):
5:46 PM Changeset in webkit [88126] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
​https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
5:37 PM Changeset in webkit [88125] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

2011-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez

Update the news file for the 1.4.1 release.

  • NEWS: Update news.
5:09 PM Changeset in webkit [88124] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
​https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.list.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
2:03 PM Changeset in webkit [88123] by Darin Adler
  • 9 edits
    2 adds in trunk/Source

2011-06-04 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
​https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
  • platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.

2011-06-04 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
​https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebKit2.xcodeproj/project.pbxproj: Added new source files.
  • WebProcess/mac/CoreIPCClientRunLoop.h: Added.
  • WebProcess/mac/CoreIPCClientRunLoop.mm: Added. (-[WKFunctionAdapter perform]): Added. (WebKit::createCoreIPCRunLoopModesArray): Added. (WebKit::coreIPCRunLoopModesArray): Added. (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait. (WebKit::webFreeKeychainItemContent): Ditto. (WebKit::webSecKeychainItemCopyContent): Ditto. (WebKit::webSecKeychainItemCreateFromContent): Ditto. (WebKit::webSecKeychainItemModifyContent): Ditto.
  • WebProcess/mac/SecItemShimMethods.mm: (WebKit::webSecItemCopyMatching): Ditto. (WebKit::webSecItemAdd): Ditto. (WebKit::webSecItemUpdate): Ditto. (WebKit::webSecItemDelete): Ditto.
12:34 PM Changeset in webkit [88122] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add InlineWalker class to hold state for repeated calls to bidiNext
​https://bugs.webkit.org/show_bug.cgi?id=60724

This is one more little step towards removing (naked) bidiNext usage.
More refactoring is required before all callers of bidiNext can move
onto using an InlineWalker instead of bidiNext directly.

No change in behavior, thus no tests.

  • rendering/InlineIterator.h: (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::root): (WebCore::InlineWalker::current): (WebCore::InlineWalker::atEndOfInline): (WebCore::InlineWalker::atEnd): (WebCore::InlineWalker::advance):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:20 PM Changeset in webkit [88121] by weinig@apple.com
  • 10 edits in trunk/Source

2011-06-04 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
​https://bugs.webkit.org/show_bug.cgi?id=62093

Add additional ChromeClient functions to indicate the beginning and end of
the various ScrollAnimator animations. Change existing notification that a
rubber-band has completed for the main frame to be triggered for all frames.

  • page/ChromeClient.h: (WebCore::ChromeClient::didStartRubberBandForFrame): (WebCore::ChromeClient::didCompleteRubberBandForFrame): (WebCore::ChromeClient::didStartAnimatedScroll): (WebCore::ChromeClient::didCompleteAnimatedScroll):
  • page/FrameView.cpp: (WebCore::FrameView::didStartRubberBand): (WebCore::FrameView::didCompleteRubberBand): (WebCore::FrameView::didStartAnimatedScroll): (WebCore::FrameView::didCompleteAnimatedScroll):
  • page/FrameView.h:
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::didStartRubberBand): (WebCore::ScrollableArea::didStartAnimatedScroll): (WebCore::ScrollableArea::didCompleteAnimatedScroll):
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

2011-06-04 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
​https://bugs.webkit.org/show_bug.cgi?id=62093

Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
animated scrolls, and update logic for rubber-band ending to check for main frame
now that it is called for all frames.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:59 AM Changeset in webkit [88120] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-06-04 Martin Robinson <​mrobinson@igalia.com>

Touch a file to try to fix the GTK+ build on the 32-bit bot.

  • testing/Internals.idl: Touch this IDL file in an effort to fix the build.
11:55 AM Changeset in webkit [88119] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix formatting of the output generated by KeywordLookupGenerator.py
​https://bugs.webkit.org/show_bug.cgi?id=62083

  • Uses correct year for copyright.
  • Puts ending brace on same line as "else if"
  • Puts starting brace of function on its own line.
  • Adds some tasteful whitespace.
  • Adds comments to make clear that scopes are ending
  • Make macros actually split on two lines.
  • KeywordLookupGenerator.py:
11:18 AM Changeset in webkit [88118] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.4

Merging r87696

10:45 AM Changeset in webkit [88117] by dcheng@chromium.org
  • 8 edits
    2 copies in branches/chromium/782

Merge 87848 - 2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

  • fast/events/drag-image-filename-expected.txt: Added.
  • fast/events/drag-image-filename.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

  • The filename suggested in the HTTP header.
  • The last path component of the source URL.
  • The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
​https://bugs.webkit.org/show_bug.cgi?id=24887

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
  • DumpRenderTree/chromium/EventSender.h:

TBR=​dcheng@chromium.org
Review URL: ​http://codereview.chromium.org/7054067

10:23 AM Changeset in webkit [88116] by Martin Robinson
  • 4 edits in trunk

2011-06-04 Martin Robinson <​mrobinson@igalia.com>

Fix the GTK+ build.

  • bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.

2011-06-04 Martin Robinson <​mrobinson@igalia.com>

Fix the GTK+ build.

  • GNUmakefile.am: Add some missing newline escape.
10:14 AM Changeset in webkit [88115] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-06-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Convert file <input> to use the new shadow DOM model
​https://bugs.webkit.org/show_bug.cgi?id=59005

Refactoring, covered by existing tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/html.css: (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
  • html/FileInputType.cpp: (WebCore::UploadButtonElement::create): Added. (WebCore::UploadButtonElement::UploadButtonElement): Added. (WebCore::UploadButtonElement::shadowPseudoId): Added. (WebCore::FileInputType::createShadowSubtree): Added.
  • html/FileInputType.h: Added createShadowSubtree decl.
  • page/DragController.cpp: (WebCore::asFileInput): Changed the logic to use new shadow DOM.
  • rendering/RenderFileUploadControl.cpp: Removed UploadButton class. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary. (WebCore::nodeWidth): Added a helper. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
  • rendering/RenderFileUploadControl.h: Changed decls.
  • rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
9:15 AM Changeset in webkit [88114] by kov@webkit.org
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-1.4

Merging ​http://trac.webkit.org/changeset/87523

5:56 AM Changeset in webkit [88113] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator.py spams stdout in Chromium Linux build
​https://bugs.webkit.org/show_bug.cgi?id=62087

This action does not appear to be needed.

5:06 AM Changeset in webkit [88112] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ResourceHandleInternal's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62073

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
4:35 AM Changeset in webkit [88111] by Laszlo Gombos
  • 2 edits in trunk/LayoutTests

2011-06-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Andreas Kling.

[Qt] Enable passing File API tests
​https://bugs.webkit.org/show_bug.cgi?id=62020

File API has been enabled for QtWebKit in r74115,
let's also enable the passing related tests.

  • platform/qt/Skipped:
4:23 AM Changeset in webkit [88110] by ap@apple.com
  • 6 edits
    1 delete in trunk

2011-06-04 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:
  • fast/forms/paste-multiline-text-input.html:
  • fast/forms/script-tests/input-value-sanitization.js: Removed.

2011-06-04 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

Newline characters should be removed according to HTML5, not replaced with spaces.
This also matches Safari 5 behavior.

  • html/TextFieldInputType.cpp: (WebCore::isASCIILineBreak): A functor for removeCharacters(). (WebCore::limitLength): Do one thing at once. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising) code that replaces newlines with spaces here.
4:14 AM Changeset in webkit [88109] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ChromePrintContext's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62076

Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
4:06 AM Changeset in webkit [88108] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62074

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
3:58 AM Changeset in webkit [88107] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make PlatformMessagePortChannel's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62072

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/PlatformMessagePortChannel.h:
3:50 AM Changeset in webkit [88106] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Give VoidCallbackClient a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=62067

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
3:42 AM Changeset in webkit [88105] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebFrameImpl destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62065

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebFrameImpl.h:
3:32 AM Changeset in webkit [88104] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-04 Jeffrey Pfau <​jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
​https://bugs.webkit.org/show_bug.cgi?id=57897

Added simple test that hits the relevant code.

  • mathml/msubsup-remove-children-expected.txt: Added.
  • mathml/msubsup-remove-children.xhtml: Added.

2011-06-04 Jeffrey Pfau <​jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
​https://bugs.webkit.org/show_bug.cgi?id=57897

Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml

  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::baselinePosition):
3:24 AM Changeset in webkit [88103] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

Give IDBBackingStore::Transaction a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=62063

IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.

  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Transaction::~Transaction):
2:53 AM Changeset in webkit [88102] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::overflowClipRect to IntPoint
​https://bugs.webkit.org/show_bug.cgi?id=62032

Covered by existing tests.

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • platform/graphics/IntRect.h: (WebCore::IntRect::contract):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::overflowClipRect):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect): (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
2:24 AM Changeset in webkit [88101] by abarth@webkit.org
  • 2 edits in trunk/Source/ThirdParty
  • glu: Added property svn:ignore.
    • For glu.xcodeproj, which is generated from glu.gyp.
2:22 AM Changeset in webkit [88100] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

V8Proxy::disconnectFrame doesn't do anything
​https://bugs.webkit.org/show_bug.cgi?id=62051

Dead code should die.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
2:05 AM Changeset in webkit [88099] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

Make the destructors of DataTransferItem and DataTransferItems virtual
​https://bugs.webkit.org/show_bug.cgi?id=62052

Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)

  • dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
  • dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):
2:02 AM Changeset in webkit [88098] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make LayerPainterChromium destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62056

LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
means that without this patch, the destructor of classes implementing
LayerPainterChromium wasn't called correctly in that case.

  • platform/graphics/chromium/LayerPainterChromium.h: (WebCore::LayerPainterChromium::~LayerPainterChromium):
1:08 AM Changeset in webkit [88097] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

Configure new commit-queue instance. (Please ignore.)

12:02 AM Changeset in webkit [88096] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <​eae@chromium.org>

Reviewed by Andreas Kling.

Fix IntRect::expand(const IntSize& size)
​https://bugs.webkit.org/show_bug.cgi?id=62042

No new tests.

  • platform/graphics/IntRect.h: (WebCore::IntRect::expand): Fix IntRect::expand to expand the size rather than move the location. Currently unused.
Note: See TracTimeline for information about the timeline view.