Context Navigation

https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.

WebCore.gypi:
bindings/v8/ChildThreadDOMData.cpp: Removed.
bindings/v8/ChildThreadDOMData.h: Removed.
bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
bindings/v8/DOMDataStore.h:
bindings/v8/MainThreadDOMData.cpp: Removed.
bindings/v8/MainThreadDOMData.h: Removed.
bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
bindings/v8/V8DOMMap.h:
bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):

11:11 PM Changeset in webkit [88220] by thakis@chromium.org

3 edits in trunk/Source/WebCore

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

[chromium] Make VideoFrameChromium's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62186

This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
deletes a VideoFrameChromium subclass type through this interface
class, causing ~VideoFrameChromiumImpl's destructor not to run.
(VideoFrameChroimumImpl happens to not have a destructor or any
non-POD member variables, so it's more a latent bug.)

platform/graphics/chromium/VideoFrameChromium.cpp: (WebCore::VideoFrameChromium::~VideoFrameChromium):
platform/graphics/chromium/VideoFrameChromium.h:

10:52 PM Changeset in webkit [88219] by morrita@google.com

2 edits in trunk/LayoutTests

2011-06-06 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fix flakiness on Snow Leopard.

fast/replaced/resources/focus-test.js:

10:24 PM Changeset in webkit [88218] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-06-06 Simon Fraser <Simon Fraser>

Reviewed by Sammy Weinig.

Remove some unnecessary includes from AnimationBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=62183

page/animation/AnimationBase.cpp:

10:14 PM Changeset in webkit [88217] by koz@chromium.org

2 edits
3 adds in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Rebaseline outline-replaced-elements windows/linux image results.
https://bugs.webkit.org/show_bug.cgi?id=57439

platform/chromium-linux-x86/fast/replaced/outline-replaced-elements-expected.png: Added.
platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png: Added.
platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png: Added.
platform/chromium/test_expectations.txt:

9:52 PM Changeset in webkit [88216] by tkent@chromium.org

7 edits in trunk/Source/WebCore

Unreviewed, a crash fix by a roll out.

REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
https://bugs.webkit.org/show_bug.cgi?id=62116

Roll out the WebCore part of r87980.

html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):

html/SearchInputType.h:

(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):

html/TextFieldInputType.h:

(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):

html/shadow/TextControlInnerElements.cpp:
html/shadow/TextControlInnerElements.h:

9:42 PM Changeset in webkit [88215] by noam.rosenthal@nokia.com

2 edits in trunk/Source/WebCore

2011-06-06 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Allow copying of KeyframeValueList.
https://bugs.webkit.org/show_bug.cgi?id=62171

Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.

No new functionality so no new tests.

platform/graphics/GraphicsLayer.h: (WebCore::FloatAnimationValue::clone): (WebCore::TransformAnimationValue::TransformAnimationValue): (WebCore::TransformAnimationValue::clone): (WebCore::TransformAnimationValue::value): (WebCore::KeyframeValueList::KeyframeValueList):

9:12 PM Changeset in webkit [88214] by Simon Fraser

3 edits
2 adds in trunk

2011-06-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Incorrect rounding of color values during transitions
https://bugs.webkit.org/show_bug.cgi?id=62141

When blending integers, round to the nearest integer, instead of always rounding down.

Test: transitions/color-transition-rounding.html

page/animation/AnimationBase.cpp: (WebCore::blendFunc):

9:06 PM Changeset in webkit [88213] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88202.
http://trac.webkit.org/changeset/88202
https://bugs.webkit.org/show_bug.cgi?id=62182

This broke the mac clang bot (Requested by koz on #webkit).

dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
rendering/InlineBox.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
rendering/RenderBox.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
rendering/RenderInline.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
rendering/RenderText.h:
rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
rendering/RenderView.h:

9:04 PM Changeset in webkit [88212] by commit-queue@webkit.org

5 edits
14 adds in trunk

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439

fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
fast/replaced/no-focus-ring-embed-1.html: Added.
fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
fast/replaced/no-focus-ring-embed-2.html: Added.
fast/replaced/no-focus-ring-iframe-expected.txt: Added.
fast/replaced/no-focus-ring-iframe.html: Added.
fast/replaced/no-focus-ring-object-1-expected.txt: Added.
fast/replaced/no-focus-ring-object-1.html: Added.
fast/replaced/no-focus-ring-object-2-expected.txt: Added.
fast/replaced/no-focus-ring-object-2.html: Added.
fast/replaced/outline-replaced-elements-expected.txt: Added.
fast/replaced/outline-replaced-elements.html: Added.
fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
platform/chromium/test_expectations.txt:
platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439

Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.

Tests: fast/replaced/no-focus-ring-embed-1.html

fast/replaced/no-focus-ring-embed-2.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object-1.html
fast/replaced/no-focus-ring-object-2.html
fast/replaced/outline-replaced-elements.html

css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.

6:44 PM Changeset in webkit [88211] by morrita@google.com

3 edits
2 adds in trunk

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
editing/spelling/spellcheck-input-search-crash.html: Added.

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

Added a guard bofore TextCheckingHelper construction sites.

Test: editing/spelling/spellcheck-input-search-crash.html

editing/Editor.cpp: (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):

6:35 PM Changeset in webkit [88210] by rniwa@webkit.org

2 edits in trunk/Tools

2011-06-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dirk Pranke.

[chromium] Chromium bots on build.webkit.org don't upload results.html
https://bugs.webkit.org/show_bug.cgi?id=61961

Don't fix the path on chromium port erroneously.

BuildSlaveSupport/test-result-archive:

6:17 PM Changeset in webkit [88209] by gyuyoung.kim@samsung.com

3 edits in trunk/Source

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload): Change prettyURL() with string().

6:12 PM Changeset in webkit [88208] by jamesr@google.com

2 edits in branches/chromium/782/Source/WebCore

Merge 87960 - 2011-06-02 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7125002

6:03 PM Changeset in webkit [88207] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit/efl

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):

5:56 PM Changeset in webkit [88206] by koz@chromium.org

2 edits in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed, update test_expectations.txt.

platform/chromium/test_expectations.txt:

5:53 PM Changeset in webkit [88205] by eae@chromium.org

2 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Update RenderBlock::paint to use IntPoint internally
https://bugs.webkit.org/show_bug.cgi?id=62140

Covered by existing tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):

5:07 PM Changeset in webkit [88204] by sullivan@apple.com

2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62165>
<rdar://problem/9555835>
WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages

Reviewed by Dan Bernstein.

UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::findString):
Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
number that would be ignored.

5:03 PM Changeset in webkit [88203] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebViewImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62155

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/WebViewImpl.h:

4:45 PM Changeset in webkit [88202] by eae@chromium.org

15 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Covered by existing tests.

dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
rendering/RenderBox.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
rendering/RenderInline.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
rendering/RenderText.h:
rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
rendering/RenderView.h:

4:31 PM Changeset in webkit [88201] by qi.2.zhang@nokia.com

2 edits in trunk/LayoutTests

2011-06-06 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean scalePage related LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=62142

platform/qt/Skipped:

4:21 PM Changeset in webkit [88200] by leviw@chromium.org

4 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch shouldPaint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62158

Switching shouldPaint to take an IntPoint representing the paint offset instead
of a pair of ints.

No new tests as this is simple refactoring.

rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
rendering/RenderReplaced.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):

4:04 PM Changeset in webkit [88199] by simonjam@chromium.org

5 edits in trunk/Source

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

wtf/CurrentTime.cpp: Add monotonicallyIncreasingTime() for mac and a fallback implementation that just wraps currentTime(). (WTF::monotonicallyIncreasingTime):
wtf/CurrentTime.h: Add monotonicallyIncreasingTime().

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().

4:01 PM Changeset in webkit [88198] by eae@chromium.org

6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::pushContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62133

Covered by existing tests.

rendering/RenderBlock.cpp: (WebCore::Covered by existing tests.RenderBlock::paint):
rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
rendering/RenderBox.h:
rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):

3:28 PM Changeset in webkit [88197] by Nate Chapin

1 edit
3 copies in branches/chromium/782

Merge r87959 to chromium/782.

< rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.
Reviewed by Oliver Hunt.
Source/WebCore:
Test: webarchive/loading/javascript-url-iframe-crash.html

bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
cause the DocumentLoader to be destroyed, so protect it with a Ref here.
LayoutTests:

webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
webarchive/loading/javascript-url-iframe-crash.html: Added.
webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.

3:27 PM Changeset in webkit [88196] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156

Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
offset instead of a pair of ints.

No new tests as this is simple refactoring.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintMask):
rendering/InlineFlowBox.h:

3:13 PM Changeset in webkit [88195] by eae@chromium.org

10 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert hitTest to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62144

Covered by existing tests.

rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestContents):
rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
rendering/RenderLayer.h: (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
rendering/RenderLineBoxList.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
rendering/RenderObject.h:

3:03 PM Changeset in webkit [88194] by simonjam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-06-06 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html

platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.

3:00 PM Changeset in webkit [88193] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151

Switching paintScrollbar to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar):
rendering/RenderListBox.h:

2:52 PM Changeset in webkit [88192] by dcheng@chromium.org

4 edits
6 deletes in trunk/Source

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

No new tests since this change only deleted unused code.

WebCore.gypi:
platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
platform/chromium/ChromiumDataObjectLegacy.h: Removed.
platform/chromium/ReadableDataObject.cpp: Removed.
platform/chromium/ReadableDataObject.h: Removed.
platform/chromium/WritableDataObject.cpp: Removed.
platform/chromium/WritableDataObject.h: Removed.

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

src/WebDragData.cpp:

2:45 PM Changeset in webkit [88191] by thakis@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):

2:35 PM Changeset in webkit [88190] by leviw@chromium.org

6 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137

Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
representing the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintContinuationOutlines):
rendering/RenderBlock.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
rendering/RenderInline.h:
rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):

2:30 PM Changeset in webkit [88189] by eae@chromium.org

6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::popContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62132

Covered by existing tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
rendering/RenderBox.cpp: (WebCore::RenderBox::popContentsClip):
rendering/RenderBox.h:
rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):

2:26 PM Changeset in webkit [88188] by leviw@chromium.org

9 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Remove tx/ty offset from selectionRect
https://bugs.webkit.org/show_bug.cgi?id=62146

Removing unused offset parameters from selectionRect.

No new tests since this is just cleanup.

rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::selectionRect):
rendering/EllipsisBox.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
rendering/InlineTextBox.h:
rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::ellipsisRectForBox): (WebCore::RenderText::absoluteQuadsForRange): (WebCore::RenderText::selectionRectForRepaint):
rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect):
rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRect):
rendering/svg/SVGInlineTextBox.h:

2:15 PM Changeset in webkit [88187] by commit-queue@webkit.org

5 edits
2 adds in trunk

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Adds a test for firing popstate, using window.dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=62099

fast/events/fire-popstate-event-expected.txt: Added.
fast/events/fire-popstate-event.html: Added.

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Let developers call createEvent("PopStateEvent"), previously it wasn't
exposed and threw an exeception.
https://bugs.webkit.org/show_bug.cgi?id=62099

WebCore/dom/Document.cpp:
WebCore/dom/PopStateEvent.cpp:
WebCore/dom/PopStateEvent.h:

2:12 PM QtWebKitBuildBots edited by Laszlo Gombos

Update Szeged slaves with links (diff)

2:02 PM QtWebKitBuildBots edited by Laszlo Gombos

Wiki syntax this time (diff)

1:58 PM QtWebKitBuildBots edited by Laszlo Gombos

Add links to the Apple master slaves (diff)

1:42 PM Changeset in webkit [88186] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62059

Switching paintSelection to use an IntPoint to represent the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::paintSelection):
rendering/EllipsisBox.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
rendering/RenderBlock.h:

1:40 PM BuildBot edited by rniwa@webkit.org

Added a reference to … (diff)

1:18 PM Changeset in webkit [88185] by Martin Robinson

4 edits in trunk

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

GNUmakefile.am: Assign libWebCoreInternals built sources to libwebcoreinternals_built_sources before adding to the source list and to BUILT_SOURCES.

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.

1:14 PM Changeset in webkit [88184] by jberlin@webkit.org

4 edits in trunk/LayoutTests

Update the Windows-specific results after r88020 in order to get the bots green.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

1:00 PM BuildBot edited by rniwa@webkit.org

Added instruction to connect to bot master (diff)

12:57 PM Changeset in webkit [88183] by eae@chromium.org

5 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::clipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62045

Covered by existing tests.

rendering/RenderBox.cpp: (WebCore::RenderBox::clipRect):
rendering/RenderBox.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
rendering/RenderLayerBacking.cpp: (WebCore::clipBox):

12:57 PM Changeset in webkit [88182] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Skip more tests on Windows that use the Shadow DOM to get the bots green.

platform/win/Skipped:

12:42 PM Changeset in webkit [88181] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2011-06-06 Anna Cavender <annacc@chromium.org>

Reviewed by David Levin.

Marking media/video-canvas-alpha.html as SKIP for GPU MAC.
https://bugs.webkit.org/show_bug.cgi?id=62068

platform/chromium/test_expectations.txt:

12:40 PM Changeset in webkit [88180] by vangelis@chromium.org

2 edits in trunk/LayoutTests

2011-06-06 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Layout test expectations fix.

[chromium] Adjusting expectations for failing huge-layer-img.html

platform/chromium/test_expectations.txt:

12:36 PM Changeset in webkit [88179] by commit-queue@webkit.org

3 edits in trunk/Tools

2011-06-06 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=62097
Fix the problem that integral bitfield check incorrectly barked at ?: expressions.

Scripts/webkitpy/style/checkers/cpp.py:
Scripts/webkitpy/style/checkers/cpp_unittest.py:

12:21 PM Changeset in webkit [88178] by commit-queue@webkit.org

15 edits in trunk/Source

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

No behavior change, so no tests.

WebCore.exp.in:
WebCore.order:
dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
editing/FrameSelection.cpp: (WebCore::FrameSelection::revealSelection):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea): (WebCore::RenderBox::canBeProgramaticallyScrolled):
rendering/RenderBox.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::autoscroll):
rendering/RenderLayer.h:
rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):

12:03 PM BuildBot edited by rniwa@webkit.org

Fixed indentation (diff)

12:02 PM BuildBot edited by rniwa@webkit.org

Added instruction to run buildbot locally (diff)

11:55 AM QtWebKitForQt5 edited by Simon Hausmann

Responding to comments (diff)

11:51 AM QtWebKitForQt5 edited by Simon Hausmann

Clean ups, clear up focus on browser development (diff)

11:51 AM Changeset in webkit [88177] by xan@webkit.org

2 edits in trunk/Tools

2011-06-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable feature/symbol detection in NWRT/GTK
https://bugs.webkit.org/show_bug.cgi?id=62136

Disable feature detection through DRT, since we don't support it,
and set the libwebcore patch correctly so that symbol detection
through 'nm' works.

Scripts/webkitpy/layout_tests/port/gtk.py:

11:43 AM Changeset in webkit [88176] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62134

Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
IntPoint representing the paint offset instead of a pair of ints.

No new tests as this simple refactoring.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
rendering/RenderBlock.h:

11:38 AM WikiStart edited by rniwa@webkit.org

Added a link to BuildBot (diff)

11:32 AM Changeset in webkit [88175] by yael.aharon@nokia.com

3 edits
3 adds in trunk

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

fast/inline/inline-wrap-with-parent-padding.html: Added.
platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.

Test: fast/inline/inline-wrap-with-parent-padding.html

rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::nextLineBreak):

11:03 AM Changeset in webkit [88174] by commit-queue@webkit.org

12 edits in trunk

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

fast/events/page-visibility-transition-test-expected.txt:
fast/events/page-visibility-transition-test.html:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
page/PageVisibilityState.h:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

public/WebPageVisibilityState.h:
src/AssertMatchingEnums.cpp:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):

11:01 AM Changeset in webkit [88173] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-06-06 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Fix typo in CachedFont.cpp #define
https://bugs.webkit.org/show_bug.cgi?id=62127

No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.

loader/cache/CachedFont.cpp: change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME

10:50 AM Changeset in webkit [88172] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62058

Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
their paint offsets instead of pairs of ints.

No new tests since this is simple refactoring.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes):
rendering/RenderBlock.h:

10:27 AM BuildBot edited by rniwa@webkit.org

Added an instruction to use easy_install-2.6 on SL (diff)

10:10 AM Changeset in webkit [88171] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
https://bugs.webkit.org/show_bug.cgi?id=62124

WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setException):

9:48 AM Changeset in webkit [88170] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

webkit/glue/webmediaplayer_impl.cc deletes an object of type
WebVideoFrame, which means this patch fixes a real bug, not just
a theoretical one.

[chromium] Give WebVideoFrame a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=61742

public/WebVideoFrame.h: (WebKit::WebVideoFrame::~WebVideoFrame):

8:49 AM Changeset in webkit [88169] by kinuko@chromium.org

8 edits
3 copies in branches/chromium/782

Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
storage/storageinfo-no-callbacks-expected.txt: Added.
storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):

BUG=84527
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/7054073

7:57 AM Changeset in webkit [88168] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml.

7:52 AM Changeset in webkit [88167] by Csaba Osztrogonác

3 edits in trunk/Tools

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.

QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):

QtTestBrowser/launcherwindow.h:

7:15 AM Changeset in webkit [88166] by steveblock@google.com

2 edits in trunk/Source/WebCore

2011-06-06 Steve Block <steveblock@google.com>

Reviewed by Yury Semikhatsky.

Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118

Correctly guard implementation of ScriptProfiler.

No new tests, build fix only.

bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::initialize):

7:12 AM Changeset in webkit [88165] by dominicc@chromium.org

2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build fix after r88159.

win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.

6:53 AM Changeset in webkit [88164] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

platform/qt-mac/Skipped:

6:33 AM Changeset in webkit [88163] by Csaba Osztrogonác

2 edits
45 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip new failing tests.
platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
platform/qt/svg/custom/embedding-external-svgs-expected.png: Added.
platform/qt/svg/custom/embedding-external-svgs-expected.txt: Added.
platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
platform/qt/svg/hixie/intrinsic/001-expected.png: Added.
platform/qt/svg/hixie/intrinsic/001-expected.txt: Added.
platform/qt/svg/hixie/intrinsic/002-expected.png: Added.
platform/qt/svg/hixie/intrinsic/002-expected.txt: Added.
platform/qt/svg/hixie/intrinsic/003-expected.png: Added.
platform/qt/svg/hixie/intrinsic/003-expected.txt: Added.
platform/qt/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
platform/qt/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.

6:27 AM Changeset in webkit [88162] by bulach@chromium.org

2 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, new baseline for GPU test.
https://bugs.webkit.org/show_bug.cgi?id=62123

platform/chromium/test_expectations.txt:

6:19 AM Changeset in webkit [88161] by commit-queue@webkit.org

3 edits in trunk/Tools

2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::downloadRequest): (LauncherWindow::fileDownloadFinished):
QtTestBrowser/launcherwindow.h:

5:41 AM Changeset in webkit [88160] by loki@webkit.org

2 edits in trunk/LayoutTests

2011-06-06 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác

Skip a flakey test on ARM.

platform/qt-arm/Skipped:

5:32 AM Changeset in webkit [88159] by dominicc@chromium.org

12 edits
1 add in trunk

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Unskip window.internals test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=61076

platform/win/Skipped:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project.
https://bugs.webkit.org/show_bug.cgi?id=61076

WebCore.vcproj/WebCoreCommon.vsprops:
WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project containing window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

WebKit.vcproj/WebKit.sln:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Re-export JSC and WebCore symbols required by WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=61076

win/WebKit2.def:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Make DumpRenderTree initialize window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):

5:23 AM Changeset in webkit [88158] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml.

5:16 AM Changeset in webkit [88157] by bulach@chromium.org

3 edits in trunk/LayoutTests

2011-06-06 Csaba Osztrogonác <Csaba Osztrogonác>

[Qt][WK2] Remove previously deleted tests from the Skipped list.

platform/qt-wk2/Skipped:

4:58 AM Changeset in webkit [88156] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Remove previously deleted tests from the Skipped list.

platform/qt-wk2/Skipped:

4:53 AM Changeset in webkit [88155] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Skip failing tests.

platform/qt-wk2/Skipped:

4:37 AM Changeset in webkit [88154] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

platform/qt-mac/Skipped:

4:22 AM Changeset in webkit [88153] by bulach@chromium.org

32 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077
https://bugs.webkit.org/show_bug.cgi?id=62115

platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
platform/chromium-gpu-linux/media/video-zoom-expected.png:
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
platform/chromium-gpu-mac/media/video-zoom-expected.png:
platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
platform/chromium-gpu-win/media/video-zoom-expected.png:
platform/chromium/test_expectations.txt:

4:12 AM Changeset in webkit [88152] by Csaba Osztrogonác

2 edits
70 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip new failing tests.
platform/qt/editing/selection/select-across-readonly-input-1-expected.png: Added.
platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Added.
platform/qt/editing/selection/select-across-readonly-input-2-expected.png: Added.
platform/qt/editing/selection/select-across-readonly-input-2-expected.txt: Added.
platform/qt/editing/selection/select-across-readonly-input-3-expected.png: Added.
platform/qt/editing/selection/select-across-readonly-input-3-expected.txt: Added.
platform/qt/editing/selection/select-across-readonly-input-4-expected.png: Added.
platform/qt/editing/selection/select-across-readonly-input-4-expected.txt: Added.
platform/qt/editing/selection/select-across-readonly-input-5-expected.png: Added.
platform/qt/editing/selection/select-across-readonly-input-5-expected.txt: Added.
platform/qt/fast/block/float/float-overhangs-root-expected.png: Added.
platform/qt/fast/block/float/float-overhangs-root-expected.txt: Added.
platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
platform/qt/fast/forms/date-input-visible-strings-expected.png: Added.
platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Added.
platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Added.
platform/qt/fast/html/details-add-details-child-1-expected.png: Added.
platform/qt/fast/html/details-add-details-child-1-expected.txt: Added.
platform/qt/fast/html/details-add-details-child-2-expected.png: Added.
platform/qt/fast/html/details-add-details-child-2-expected.txt: Added.
platform/qt/fast/html/details-nested-1-expected.png: Added.
platform/qt/fast/html/details-nested-1-expected.txt: Added.
platform/qt/fast/html/details-nested-2-expected.png: Added.
platform/qt/fast/html/details-nested-2-expected.txt: Added.
platform/qt/fast/html/details-replace-summary-child-expected.png: Added.
platform/qt/fast/html/details-replace-summary-child-expected.txt: Added.
platform/qt/fast/html/details-replace-text-expected.png: Added.
platform/qt/fast/html/details-replace-text-expected.txt: Added.
platform/qt/fast/inline/nested-top-alignment-expected.png: Added.
platform/qt/fast/inline/nested-top-alignment-expected.txt: Added.
platform/qt/fast/table/dynamic-caption-add-before-child-expected.png: Added.
platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
platform/qt/fast/table/multiple-captions-display-expected.png: Added.
platform/qt/fast/table/multiple-captions-display-expected.txt: Added.
platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
platform/qt/svg/custom/fill-opacity-update-expected.png: Added.
platform/qt/svg/custom/fill-opacity-update-expected.txt: Added.
platform/qt/svg/custom/object-sizing-expected.png: Added.
platform/qt/svg/custom/object-sizing-expected.txt: Added.
platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Added.
platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Added.
platform/qt/svg/custom/stroke-opacity-update-expected.png: Added.
platform/qt/svg/custom/stroke-opacity-update-expected.txt: Added.
platform/qt/svg/wicd/rightsizing-grid-expected.png: Added.
platform/qt/svg/wicd/rightsizing-grid-expected.txt: Added.
platform/qt/svg/wicd/test-rightsizing-a-expected.png: Added.
platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Added.
platform/qt/svg/wicd/test-rightsizing-b-expected.png: Added.
platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Added.
platform/qt/svg/wicd/test-scalable-background-image1-expected.png: Added.
platform/qt/svg/wicd/test-scalable-background-image1-expected.txt: Added.
platform/qt/svg/wicd/test-scalable-background-image2-expected.png: Added.
platform/qt/svg/wicd/test-scalable-background-image2-expected.txt: Added.

3:45 AM Changeset in webkit [88151] by commit-queue@webkit.org

13 edits in trunk