⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 11, 2011:

11:01 PM Changeset in webkit [88611] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-11 Michael Saboff <​msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
​https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

  • platform/graphics/FontCache.cpp:
9:19 PM Changeset in webkit [88610] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary strlen from DocumentWriter
​https://bugs.webkit.org/show_bug.cgi?id=62505

This ugly piece of code appears not to be needed. Rejoice.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/DocumentWriter.h:
5:51 PM Changeset in webkit [88609] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
​https://bugs.webkit.org/show_bug.cgi?id=62499

This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.

There's still lots of on contorting to do here, but it's a start.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/DocumentWriter.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
1:34 PM Changeset in webkit [88608] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-11 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaseline after r85560.

Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [88607] by Stephanie Lewis
  • 5 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::warmInitialProcess):

  • UIProcess/WebContext.h:
1:21 PM Changeset in webkit [88606] by Dimitri Glazkov
  • 3 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
​http://trac.webkit.org/changeset/88569
​https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/database-name-undefined-expected.txt: Removed.
  • storage/indexeddb/database-name-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
​http://trac.webkit.org/changeset/88569
​https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBFactory.idl:
1:16 PM Changeset in webkit [88605] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):

  • wtf/DateMath.cpp:

(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

1:07 PM Changeset in webkit [88604] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):

  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:
  • wtf/Platform.h:
11:09 AM Changeset in webkit [88603] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Remove expectation of failure after clobber.
​https://bugs.webkit.org/show_bug.cgi?id=62364

  • platform/chromium/test_expectations.txt: Removed.
10:12 AM Changeset in webkit [88602] by Dimitri Glazkov
  • 4 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
​http://trac.webkit.org/changeset/88565
​https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/setVersion-undefined-expected.txt: Removed.
  • storage/indexeddb/setVersion-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
​http://trac.webkit.org/changeset/88565
​https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.idl:
9:37 AM Changeset in webkit [88601] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-06-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
​https://bugs.webkit.org/show_bug.cgi?id=62230

When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.

Tests: fast/dom/body-link-decl-parent-crash.html

fast/dom/styled-inline-style-decl-parent-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
  • html/HTMLBodyElement.h:

2011-06-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=62230

  • fast/dom/body-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-link-decl-parent-crash.html: Added.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Added.

Jun 10, 2011:

11:45 PM Changeset in webkit [88600] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-10 Adam Barth <​abarth@webkit.org>

Remove bogus ASSERTs. These ASSERTs used to be correct before I
changed DocumentWriter to put the onus for ignoring empty writes onto
the parser.

This patch should stop these test from triggering ASSERTs:

plugins/plugin-document-back-forward.html
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
userscripts/user-script-plugin-document.html

  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
11:23 PM Changeset in webkit [88599] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-06-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

AVPlayerLayer is adding a "fade" animation during Safari full-screen
​https://bugs.webkit.org/show_bug.cgi?id=62433

CoreAnimation will add default animations when certain properties are changed, unless
those changes are wrapped in a CATransaction which has had its disableActions property set
to true. Wrap each of these three property changes in a CATransaction and disable its actions,
so that the default "fade" animation is not created in response.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction. (-[WKFullScreenWindowController _swapView:with:]): Ditto:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto.
11:04 PM Changeset in webkit [88598] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: 'images' links on results.html don't work
​https://bugs.webkit.org/show_bug.cgi?id=62194

Use relative path when generating images-diffs.html

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname.
10:52 PM Changeset in webkit [88597] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and
svg/custom/focus-event-handling-keyboard.html on Mac WebKit2
because they use DRT features not supported by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
9:56 PM Changeset in webkit [88596] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

GTK and Qt rebaselines after r88555.

  • platform/gtk/svg/custom/focus-ring-expected.txt:
  • platform/qt/svg/custom/focus-ring-expected.txt:
9:53 PM Changeset in webkit [88595] by jamesr@google.com
  • 12 edits
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-10 James Robinson <​jamesr@chromium.org>

[chromium] Update chromium gpu baselines

  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/chromium/test_expectations.txt:
9:35 PM Changeset in webkit [88594] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows.

  • platform/chromium/fast/harness/results-expected.txt:
  • platform/win/fast/harness/results-expected.txt:
9:14 PM Changeset in webkit [88593] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac
because it has been failing on the bot; the failure is tracked by the bug 62364.

  • platform/chromium/test_expectations.txt:
9:05 PM Changeset in webkit [88592] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: results.html don't list the same list of failed tests as bots do
​https://bugs.webkit.org/show_bug.cgi?id=62425

Fixed the bug by hiding expected crash, timeout, pass, etc... by default.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
8:36 PM Changeset in webkit [88591] by jer.noble@apple.com
  • 6 edits
    3 adds in trunk

2011-06-10 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
​https://bugs.webkit.org/show_bug.cgi?id=62411

  • fullscreen/full-screen-remove-ancestor-after-expected.txt: Added.
  • fullscreen/full-screen-remove-ancestor-after.html: Added.
  • platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.

2011-06-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
​https://bugs.webkit.org/show_bug.cgi?id=62411

Test: fullscreen/full-screen-remove-ancestor-after.html

The placeholder for RenderFullScreen was being created as a non-anonymous object, which led
to the document's renderer being set to 0 when the placeholder was removed due to its parent
being removed. Setting the placeholder to be anonymous, however, means that it will be
coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the
list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder
being so coalesced. To do so, made the placeholder object a true subclass, and add and
override its destroy() function to notify the RenderFullScreen object that it has been
destroyed.

  • rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder

has been destroyed.

(RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it.
(RenderFullScreen::setPlaceholder): Added.
(RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous.

  • rendering/RenderFullScreen.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added. (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of

objects which are not anonymous blocks.

7:51 PM Changeset in webkit [88590] by jamesr@google.com
  • 14 edits
    13 adds in trunk/LayoutTests

2011-06-10 James Robinson <​jamesr@chromium.org>

[chromium] Update chromium compositor baselines for r88580

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [88589] by Lucas Forschler
  • 1 edit
    2 adds in trunk/Tools

2011-06-10 Lucas Forschler <Lucas Forschler>

Reviewed by Stephanie Lewis.

Script to kill old processes on Mac.
This matches the windows version.
​https://bugs.webkit.org/show_bug.cgi?id=62479

  • BuildSlaveSupport/mac: Added.
  • BuildSlaveSupport/mac/kill-old-processes: Added.
7:04 PM Changeset in webkit [88588] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

REGRESSION (WebKit2): window.showModalDialog() broken
​https://bugs.webkit.org/show_bug.cgi?id=62496
<rdar://problem/9581492>

If dispatching a message ends up creating a nested run loop, some incoming messages can end up not being
delivered until we exit from the run loop.

Fix this by using a Deque instead of a Vector for incoming messages, and get one message at a time and then
dispatch it. That prevents us from having any lingering messages lying around in stack allocated space.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::dispatchMessages):
  • Platform/CoreIPC/Connection.h:
7:03 PM Changeset in webkit [88587] by barraclough@apple.com
  • 25 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.

Remove JSC::Inf, JSC::NaN, switch some cases of (isnan
isinf) to !isfinite.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::toNumber):

  • API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

(JSC::CachedTranscendentalFunction::initialize):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toNumber):

  • runtime/JSValue.cpp:
  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::jsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

  • runtime/NumberConstructor.cpp:

(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/UString.cpp:
  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

  • wtf/dtoa.cpp:

(WTF::dtoa):

Source/WebCore:

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

6:56 PM Changeset in webkit [88586] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-10 James Simonsen <​simonjam@chromium.org>

Unreviewed, missing expectations for non-V8 from change 88584.
​https://bugs.webkit.org/show_bug.cgi?id=62412

  • html5lib/runner-expected.txt:
6:18 PM Changeset in webkit [88585] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-10 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Unresponsive cursor is shown when displaying a modal dialog
Part of <rdar://problem/9581492>
​https://bugs.webkit.org/show_bug.cgi?id=62494

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runModal):
  • UIProcess/WebPageProxy.h: Stop the responsiveness timer when calling out to show a modal dialog.
6:08 PM Changeset in webkit [88584] by simonjam@chromium.org
  • 6 edits
    10 adds
    2 deletes in trunk

2011-06-10 James Simonsen <​simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
​https://bugs.webkit.org/show_bug.cgi?id=62412

  • platform/chromium/html5lib/runner-expected.txt: Passes another test.
  • svg/dom/range-delete-expected.txt: Removed.
  • svg/dom/range-delete.html: Removed.
  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
  • svg/dom/use-style-recalc-script-execute-crash.html:
  • svg/in-html/resources/external.js: Added.
  • svg/in-html/script-expected.txt: Added.
  • svg/in-html/script-external-expected.txt: Added.
  • svg/in-html/script-external.html: Added.
  • svg/in-html/script-nested-expected.txt: Added.
  • svg/in-html/script-nested.html: Added.
  • svg/in-html/script-write-expected.txt: Added.
  • svg/in-html/script-write.html: Added.
  • svg/in-html/script.html: Added.

2011-06-10 James Simonsen <​simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
​https://bugs.webkit.org/show_bug.cgi?id=62412

Tests: svg/in-html/script-external.html

svg/in-html/script-nested.html
svg/in-html/script-write.html
svg/in-html/script.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
5:56 PM Changeset in webkit [88583] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
​https://bugs.webkit.org/show_bug.cgi?id=62336

Triggering this condition is very hard to do deterministically. This
test attempts to trigger the condition by sending exactly the right
number of bytes for the Chromium network stack. As network stacks vary
and evolve, it's likely we'll lose test coverage for this issue, but
this is the best test I could come up with.

  • fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
  • fast/parser/document-write-ignores-later-network-bytes.html: Added.

2011-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
​https://bugs.webkit.org/show_bug.cgi?id=62336

If the network packet boundaries line up just right, we can end up
feeding network data to a parser created by document.write (or
document.open). That's incorrect.

This patch causes DocumentWriter to grab hold of the original parser
and direct all input to that parser.

Test: fast/parser/document-write-ignores-later-network-bytes.html

  • dom/Document.cpp: (WebCore::Document::explicitClose):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource): (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
  • loader/DocumentWriter.h:
5:39 PM Changeset in webkit [88582] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebKit/chromium

2011-06-10 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by James Robinson.

Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
​https://bugs.webkit.org/show_bug.cgi?id=62149

Added page overlay for inspector highlight support.

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
  • src/PageOverlay.cpp: Added. (WebKit::PageOverlay::create): (WebKit::PageOverlay::PageOverlay): (WebKit::OverlayGraphicsLayerClientImpl::create): (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl): (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted): (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired): (WebKit::OverlayGraphicsLayerClientImpl::paintContents): (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders): (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter): (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl): (WebKit::PageOverlay::clear): (WebKit::PageOverlay::update): (WebKit::PageOverlay::paintWebFrame): (WebKit::PageOverlay::invalidateWebFrame):
  • src/PageOverlay.h: Added. (WebKit::PageOverlay::~PageOverlay): (WebKit::PageOverlay::setClient):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::paintPageOverlay): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight):
  • src/WebDevToolsAgentImpl.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setPageOverlayClient): (WebKit::WebViewImpl::setOverlayLayer): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setRootPlatformLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::pageOverlay):
5:38 PM Changeset in webkit [88581] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
​https://bugs.webkit.org/show_bug.cgi?id=62489

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
5:22 PM Changeset in webkit [88580] by Simon Fraser
  • 17 edits
    4 adds in trunk

2011-06-10 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Keep overlap testing logic until real 3d transforms are being used
​https://bugs.webkit.org/show_bug.cgi?id=49857

For pages that use the translateZ(0) hack to force compositing layers, it's
advantageous to keep overlap testing, to avoid putting too many other
elements into layers.

Only turn off overlap testing if non-identity 3D transforms are used.

Tests: compositing/layer-creation/rotate3d-overlap.html

compositing/layer-creation/translatez-overlap.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
  • rendering/RenderLayerCompositor.h:
5:21 PM Changeset in webkit [88579] by levin@chromium.org
  • 3 edits
    2 adds in trunk

Web Worker fails to fire error event when a resource fetch fails.
​https://bugs.webkit.org/show_bug.cgi?id=62475

Reviewed by Dmitry Titov.

Source/WebCore:

Test: http/tests/workers/worker-workerScriptNotThere.html

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.

LayoutTests:

  • http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
  • http/tests/workers/worker-workerScriptNotThere.html: Added.
5:11 PM Changeset in webkit [88578] by levin@chromium.org
  • 10 edits
    2 adds in trunk

Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
​https://bugs.webkit.org/show_bug.cgi?id=62469

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/workers/worker-crash-with-invalid-location.html

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.

  • workers/Worker.cpp:

(WebCore::Worker::create): Ditto.

  • workers/Worker.h: Ditto.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts): Ditto.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.

  • workers/WorkerScriptLoader.h: Made this RefCounted to allow for

keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):

Source/WebKit/chromium:

Test: fast/workers/worker-crash-with-invalid-location.html

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.

LayoutTests:

  • fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
  • fast/workers/worker-crash-with-invalid-location.html: Added.
4:55 PM Changeset in webkit [88577] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-10 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Top portion of page is rendered messed up with accelerated drawing
​https://bugs.webkit.org/show_bug.cgi?id=62484

Fixed the math in flipping the texture from bottom-up to top-down.
Test: compositing/repaint/shrink-layer.html (existing)

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
4:35 PM Changeset in webkit [88576] by tony@chromium.org
  • 13 edits in trunk

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • Scripts/build-webkit:

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
​https://bugs.webkit.org/show_bug.cgi?id=62049

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
4:27 PM Changeset in webkit [88575] by levin@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-10 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

Add tests for Web Workers at invalid urls.
​https://bugs.webkit.org/show_bug.cgi?id=62486

  • http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
  • http/tests/workers/shared-worker-invalid-url.html: Added.
  • http/tests/workers/worker-invalid-url-expected.txt: Added.
  • http/tests/workers/worker-invalid-url.html: Added.
3:55 PM Changeset in webkit [88574] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Turns out, linux baseline isn't spurious.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
3:43 PM Changeset in webkit [88573] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Roll out r88568. It is not the right fix for the problem.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

3:21 PM Changeset in webkit [88572] by Dimitri Glazkov
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

Remove all spurious copies of test expectations that somehow made it into the tree.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
3:20 PM Changeset in webkit [88571] by mrowe@apple.com
  • 5 edits in trunk

<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.

Reviewed by Dimitri Glazkov.

Source/WebCore:

Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.

Install the library and its associated header file in a more appropriate location
for the production configuration.

  • Configurations/WebCoreTestSupport.xcconfig:

Tools:

Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
2:53 PM Changeset in webkit [88570] by Simon Fraser
  • 10 edits in trunk/Source/WebCore

2011-06-10 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=62471

RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
in a way that was safe to call during existing style recalc or layout.

Move this code to ContainerElement so it can be called elsewhere.
Also add a param to the node callback so we can pass the style change type.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): (WebCore::ContainerNode::dispatchPostAttachCallbacks): (WebCore::needsStyleRecalcCallback): (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
  • dom/ContainerNode.h:
  • dom/Node.h: (WebCore::Node::scheduleSetNeedsStyleRecalc):
  • html/HTMLFormControlElement.cpp: (WebCore::focusPostAttach): (WebCore::updateFromElementCallback):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
  • html/HTMLPlugInImageElement.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::attachRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
  • rendering/RenderLayerCompositor.h:
  • svg/SVGUseElement.cpp: (WebCore::updateFromElementCallback):
2:42 PM Changeset in webkit [88569] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-10 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62398

  • storage/indexeddb/database-name-undefined-expected.txt: Added.
  • storage/indexeddb/database-name-undefined.html: Added.

2011-06-10 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62398

Test: storage/indexeddb/database-name-undefined.html

  • storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
2:34 PM Changeset in webkit [88568] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>

Reviewed by Beth Dakin.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.

2:25 PM Changeset in webkit [88567] by eae@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-10 Emil A Eklund <​eae@chromium.org>

Land Windows expectations for new test added in r88556.

  • platform/win/printing/page-count-relayout-shrink-expected.txt: Added.
2:16 PM Changeset in webkit [88566] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Document::finishParsing
​https://bugs.webkit.org/show_bug.cgi?id=62474

This function appears to exist only to confuse and befuddle us. This
patch prepares for DocumentWriter to grab hold of the parser.

This patch removes one of the print statements from
INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finish):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stop):
2:14 PM Changeset in webkit [88565] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-10 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-10 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
2:04 PM Changeset in webkit [88564] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-06-10 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Null-check the layer owner again when painting layers
​https://bugs.webkit.org/show_bug.cgi?id=62473

Speculative fix for a crash that occurs when the layer's owner
gets destroyed during painting.

  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
1:59 PM Changeset in webkit [88563] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Land expectations for a test, added in r88556.

  • platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.
1:54 PM Changeset in webkit [88562] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

[V8] Add failure expectation for a test, added in r88559.

  • platform/chromium/test_expectations.txt: Added.
1:49 PM Changeset in webkit [88561] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Lighten the --no-svg build a little
​https://bugs.webkit.org/show_bug.cgi?id=62314

Only generate source from SVG*.idl if the build is svg-enabled.

  • CodeGenerators.pri:
1:39 PM Changeset in webkit [88560] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Remove expectation of crash, fixed in r88551.

  • platform/chromium/test_expectations.txt: Removed expectation.
1:33 PM Changeset in webkit [88559] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

This arises from chapter 15 of the spec:

"Every other property described in this clause has the attributes
{ Writable: true, Enumerable: false, Configurable: true }
unless otherwise specified."

Standardized properties are not enumerable.

Source/JavaScriptCore:

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

LayoutTests:

  • fast/js/exception-properties-expected.txt: Added.
  • fast/js/exception-properties.html: Added.
  • fast/js/script-tests/exception-properties.js: Added.

(enumerableProperties):

1:29 PM Changeset in webkit [88558] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r88555.

  • platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.
1:15 PM Changeset in webkit [88557] by Nikolas Zimmermann
  • 7 edits in trunk/Source/WebCore

2011-06-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
​https://bugs.webkit.org/show_bug.cgi?id=59085

Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
​https://bugs.webkit.org/show_bug.cgi?id=62441

Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.

Doesn't affect any test so far.

  • platform/graphics/SVGGlyph.h: (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk):
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::collectGlyphsForString): (WebCore::SVGFontElement::collectGlyphsForGlyphName): (WebCore::SVGFontElement::svgGlyphForGlyph): (WebCore::SVGFontElement::missingGlyph):
  • svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair):
  • svg/SVGGlyphMap.h: (WebCore::SVGGlyphMap::addGlyphByUnicodeString): (WebCore::SVGGlyphMap::addGlyphByName): (WebCore::SVGGlyphMap::appendToGlyphTable): (WebCore::SVGGlyphMap::collectGlyphsForString): (WebCore::SVGGlyphMap::clear): (WebCore::SVGGlyphMap::svgGlyphForGlyph): (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
12:44 PM Changeset in webkit [88556] by eae@chromium.org
  • 3 edits
    3 adds in trunk

2011-06-10 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
​https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

  • platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • printing/page-count-relayout-shrink.html: Added.

2011-06-10 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
​https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

Test: printing/page-count-relayout-shrink.html

  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
12:43 PM Changeset in webkit [88555] by rwlbuis@webkit.org
  • 19 edits
    6 adds in trunk

2011-06-10 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

animation event handling broken: focusin
​https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
​https://bugs.webkit.org/show_bug.cgi?id=40545

Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.

  • platform/mac/svg/custom/focus-ring-expected.txt:
  • svg/custom/focus-event-handling-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard.xhtml: Added.
  • svg/custom/focus-event-handling.xhtml: Added.
  • svg/custom/resources/focus-event-handling-keyboard.js: Added. (focusinHandler): (focusoutHandler):
  • svg/custom/resources/focus-event-handling.js: Added. (clearFocusSeen): (): (focusoutHandler): (clickAt):

2011-06-10 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

amation event handling broken: focusin
​https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
​https://bugs.webkit.org/show_bug.cgi?id=40545

Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:

​http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute

Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.

Tests: svg/custom/focus-event-handling-keyboard.xhtml

svg/custom/focus-event-handling.xhtml

  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeRectForRepaint):
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::supportsFocus):
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::supportsFocus):
  • svg/SVGGElement.h: (WebCore::SVGGElement::supportsFocus):
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::supportsFocus):
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::supportsFocus):
  • svg/SVGPathElement.h: (WebCore::SVGPathElement::supportsFocus):
  • svg/SVGPolyElement.h: (WebCore::SVGPolyElement::supportsFocus):
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::supportsFocus):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::supportsFocus):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isMouseFocusable): (WebCore::SVGStyledElement::isKeyboardFocusable):
  • svg/SVGStyledElement.h:
  • svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::supportsFocus):
  • svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::supportsFocus):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::supportsFocus):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::supportsFocus):
11:35 AM Changeset in webkit [88554] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
11:17 AM Changeset in webkit [88553] by macpherson@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-10 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Clean up CSSPrimitiveValue::computeLength*
​https://bugs.webkit.org/show_bug.cgi?id=61612

No new tests as no functionality changed.

  • css/CSSGradientValue.cpp: Use new computeLength functions.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthIntForLength): Reduce to a single function using default parameter values. (WebCore::CSSPrimitiveValue::computeLength): Redefine existing functions with separate names as a single function using templated function specialization.
  • css/CSSPrimitiveValue.h: Prototypes for computeLengthIntForLength and computeLength.
  • css/CSSStyleApplyProperty.cpp: Use new computeLength functions.
  • css/CSSStyleSelector.cpp: Use new computeLength functions.
  • css/MediaQueryEvaluator.cpp: Use new computeLength functions.
  • css/SVGCSSStyleSelector.cpp: Use new computeLength functions.
11:10 AM Changeset in webkit [88552] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-06-10 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Add utility to RenderLayer to determine if the layer is scrollable
​https://bugs.webkit.org/show_bug.cgi?id=62467

New method that returns true if either scrollbar is present and enabled.
Not called anywhere yet.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::allowsScrolling):
  • rendering/RenderLayer.h:
10:56 AM Changeset in webkit [88551] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Tony Chang.

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
​https://bugs.webkit.org/show_bug.cgi?id=62460

Test: fast/dom/prototype-inheritance-2.html

  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.
10:51 AM Changeset in webkit [88550] by Dimitri Glazkov
  • 4 edits
    14 deletes in branches/chromium/782

Revert r87319 on 782 branch.

10:31 AM Changeset in webkit [88549] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Tony Gentilcore.

Tests that trying to remove all document children while building a svg <use>
element shadow and instance tree does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=62225

  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
  • svg/dom/use-style-recalc-script-execute-crash.html: Added.

2011-06-10 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Don't execute scripts in shadow SVG.
​https://bugs.webkit.org/show_bug.cgi?id=62225

Test: svg/dom/use-style-recalc-script-execute-crash.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::prepareScript):
10:31 AM Changeset in webkit [88548] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-10 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] make features.gypi the same as features_override.gypi
​https://bugs.webkit.org/show_bug.cgi?id=62399

Make the file the same as chromium's features_override.gypi so we
can remove features_override.gypi in chromium.

Remove ENABLE_DATAGRID=0 since the define is gone and remove
ENABLE_FULLSCREEN_API=1 since we want to disable it.

  • features.gypi:
10:29 AM Changeset in webkit [88547] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-10 Konstantin Tokarev <​ktokarev@smartlabs.tv>

Reviewed by Joseph Pecoraro.

Fixed build with enabled workers and disabled inspector
​https://bugs.webkit.org/show_bug.cgi?id=62461

  • inspector/InspectorWorkerAgent.cpp: Added inspector guard
10:05 AM Changeset in webkit [88546] by Darin Adler
  • 4 edits in trunk/Source/WebCore

2011-06-10 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

REGRESSION: Fullscreen video controller can't be dragged
​https://bugs.webkit.org/show_bug.cgi?id=62462

No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new booleans related to dragging. (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging is allowed and a drag isn't already in progress. (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if dragging is already in progress. (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is done during the dragging process. (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel using explicit top/left. (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning done by setPosition. (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag, continueDrag, and endDrag in response to mouse events. (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
  • html/shadow/MediaControlElements.h: Added new function and data members as mentioned above.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true) so you can drag the panel while in fullscreen. (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false) so you can't drag the panel while not in fullscreen. Also call resetPosition so position changes from dragging don't affect the panel in other contexts.
10:00 AM Changeset in webkit [88545] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

Remove tests that are now passing.

  • platform/chromium/test_expectations.txt: Removed passing tests.
9:52 AM Changeset in webkit [88544] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-06-10 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

REGRESSION: Full screen video HUD is positioned too low for standalone video documents
​https://bugs.webkit.org/show_bug.cgi?id=62463

No test because we don't currently have machinery for testing fullscreen.

  • css/fullscreen.css: Removed rule that said bottom: 0px for the control panel for full page media in full screen mode. This is not needed because the control panel for full screen mode already has style rules to set its vertical position. (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said -webkit-tranform. This will fix a potential problem where fullscreen would malfunction on a page that had a media element inside a transform.
9:06 AM Changeset in webkit [88543] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-10 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Add support for non-ASCII filenames in Content-Disposition header
​https://bugs.webkit.org/show_bug.cgi?id=62454

Try latin1 as fallback for header parameter values as some servers
do not follow RFC 2045 for example with filename parameter in
Content-Disposition.

No new tests required as no functionality changed.

  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
8:55 AM Changeset in webkit [88542] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-10 Dimitri Glazkov <Dimitri Glazkov>

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
​https://bugs.webkit.org/show_bug.cgi?id=62460

  • platform/chromium/test_expectations.txt: Updated test expectations.
4:56 AM Changeset in webkit [88541] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-10 No'am Rosenthal <​noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add layer factory to GraphicsLayer for creating non-default layer type.
​https://bugs.webkit.org/show_bug.cgi?id=61925

Added a static factory protected member to GraphicsLayer, which should be accessed from
a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.

This is needed for accelerated compositing across processes in WebKit2, since WebCore
doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
different implementations of GraphicsLayer coexist impossible without some runtime
factory that can be overridden by the web process.

Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
would have to explicitly call it, in order to be unintrusive with current implementations.

No new functionality, so no new tests.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setGraphicsLayerFactory):
  • platform/graphics/GraphicsLayer.h:
4:34 AM Changeset in webkit [88540] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/Source/WebKit2

2011-06-10 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
​https://bugs.webkit.org/show_bug.cgi?id=62346

Add WebProcess/WebCoreSupport/efl directory and files.

  • WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added. (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added. (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError): (WebKit::pluginWillHandleLoadError):
  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
  • WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
4:32 AM Changeset in webkit [88539] by commit-queue@webkit.org
  • 6 edits in trunk

2011-06-10 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
​https://bugs.webkit.org/show_bug.cgi?id=62376

Add files that need to be compiled in every port for supporting WebGL.
Each port still needs to add its specific files to
CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
yet.

  • Source/CMakeLists.txt: Add files needed to support WebGL.
  • Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
  • Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is enabled.

2011-06-10 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
​https://bugs.webkit.org/show_bug.cgi?id=62376

Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.

No change in functionality so no new tests.

  • CMakeLists.txt:
4:31 AM Changeset in webkit [88538] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-06-10 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Fix 'headers' autotest when building inside Qt.
​https://bugs.webkit.org/show_bug.cgi?id=62449

  • Api/qwebkitplatformplugin.h:
4:30 AM Changeset in webkit [88537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-10 KwangHyuk Kim <​hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL]add image content hint information for tile image object when it is created
​https://bugs.webkit.org/show_bug.cgi?id=62436

When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
In order to support this enhanced feature, image content hint information must be
specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC

  • ewk/ewk_tiled_model.c: (ewk_tile_new):
4:23 AM Changeset in webkit [88536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-10 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
​https://bugs.webkit.org/show_bug.cgi?id=62435

No new tests required as just fixed warning.

  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::PlatformContextCairo):

2011-06-11-06-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
​https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
3:15 AM Changeset in webkit [88535] by loislo@chromium.org
  • 5 edits in trunk

2011-06-10 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
​https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-11-06-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
​https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
3:06 AM Changeset in webkit [88534] by Laszlo Gombos
  • 3 edits in trunk/Source/WebKit/qt

2011-06-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
​https://bugs.webkit.org/show_bug.cgi?id=62420

ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
but they meant to be independent.

  • Api/qwebframe.cpp: (QWebFramePrivate::_q_orientationChanged): (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
2:09 AM Changeset in webkit [88533] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-10 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Repaint throttling API.
​https://bugs.webkit.org/show_bug.cgi?id=56178

The API allows to set the values for repaint throttling.
It should ensure displaying a content with many css/gif animations.

  • ewk/ewk_settings.cpp: (ewk_settings_repaint_throttling_set):
  • ewk/ewk_settings.h:
1:56 AM Changeset in webkit [88532] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-10 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use makeString() when getting os version
​https://bugs.webkit.org/show_bug.cgi?id=62434

When os version string is created, to use makeString() is better than
String operation.

  • ewk/ewk_settings.cpp: (_ewk_settings_webkit_os_version_get):
1:41 AM Changeset in webkit [88531] by loislo@chromium.org
  • 5 edits in trunk

2011-06-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
​http://trac.webkit.org/changeset/88530
​https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
​http://trac.webkit.org/changeset/88530
​https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/InspectorValues.cpp:
1:33 AM Changeset in webkit [88530] by loislo@chromium.org
  • 5 edits in trunk

2011-06-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
​https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
​https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
12:35 AM Changeset in webkit [88529] by yurys@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Worker object may be garbage collected even if it has message handlers
​https://bugs.webkit.org/show_bug.cgi?id=62292

I'd like to convert the test case into a layout test but I don't see yet
how to do this so that the test isn't too slow and reliable. The problem
with test is that full-GC needs to be triggered right after
WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
So no test for now.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending activity state every time a message is confirmed since the message may have created a new activity.
  • src/WebWorkerClientImpl.h:
12:10 AM Changeset in webkit [88528] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
​https://bugs.webkit.org/show_bug.cgi?id=62402

Sites are able to override the "overflow:hidden" rule for root full-screen nodes
simply by adding a "html {}" rule. Make this rule !important, and also make it apply
to root nodes who are merely ancestors of full-screen elements, to cover the case of
a root node containing an <iframe> whose contents have gone full-screen.

  • css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen),

:root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
who are full-screen ancestors, and make them !important.

Note: See TracTimeline for information about the timeline view.