⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 12, 2011:

11:38 PM Changeset in webkit [88630] by morrita@google.com
  • 10 edits in trunk

2011-06-12 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r88625.
​http://trac.webkit.org/changeset/88625
​https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • platform/mac-wk2/Skipped:

2011-06-12 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r88625.
​http://trac.webkit.org/changeset/88625
​https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKit.vcproj/WebKit.sln:

2011-06-12 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r88625.
​http://trac.webkit.org/changeset/88625
​https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
11:20 PM Changeset in webkit [88629] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
​https://bugs.webkit.org/show_bug.cgi?id=62507

No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.

If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

  • dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
10:15 PM Changeset in webkit [88628] by abarth@webkit.org
  • 41 edits in trunk/Source

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

As requested by Alexey in ​https://bugs.webkit.org/show_bug.cgi?id=62510.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/MainResourceLoader.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
  • src/FrameLoaderClientImpl.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
  • WebFrame.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
​https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
9:55 PM Changeset in webkit [88627] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-12 Hironori Bono <​hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
​https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

  • editing/spelling/spellcheck-api-crash-expected.txt: Added.
  • editing/spelling/spellcheck-api-crash.html: Added.

2011-06-12 Hironori Bono <​hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
​https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

Test: editing/spelling/spellcheck-api-crash.html

  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
9:13 PM Changeset in webkit [88626] by mahesh.kulkarni@nokia.com
  • 5 edits in trunk

2011-06-12 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
​https://bugs.webkit.org/show_bug.cgi?id=62442

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2011-06-12 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
​https://bugs.webkit.org/show_bug.cgi?id=62442

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
8:05 PM Changeset in webkit [88625] by dominicc@chromium.org
  • 10 edits in trunk

2011-06-12 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=61073

  • platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html

2011-06-12 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=61073

  • WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport

2011-06-12 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=61073

Test: fast/harness/internals-object.html

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
7:17 PM Changeset in webkit [88624] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-12 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
7:05 PM Changeset in webkit [88623] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes should use size_t for length instead of int
​https://bugs.webkit.org/show_bug.cgi?id=62508

size_t is the proper type for distances in memory, especially on 64 bit
machines.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
7:03 PM Changeset in webkit [88622] by abarth@webkit.org
  • 14 edits in trunk/Source

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=62519

This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.

This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=62519

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=62519

Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
4:34 PM Changeset in webkit [88621] by xan@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-06-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit_web_view_get_selected_text
​https://bugs.webkit.org/show_bug.cgi?id=62512

It's no longer used and it's a private method, so it can be
removed.

  • webkit/webkitwebview.cpp: kill it.
  • webkit/webkitwebviewprivate.h: ditto.
2:24 PM Changeset in webkit [88620] by commit-queue@webkit.org
  • 5 edits in trunk

2011-06-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
​http://trac.webkit.org/changeset/88616
​https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-06-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
​http://trac.webkit.org/changeset/88616
​https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
1:01 PM Changeset in webkit [88619] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <​abarth@webkit.org>

Fix fullscreen/full-screen-iframe-legacy.html.

  • html/HTMLVideoElement.idl:
12:21 PM Changeset in webkit [88618] by abarth@webkit.org
  • 21 edits in trunk/Source

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=62510

Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.

  • webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=62510

Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
  • loader/FrameLoader.h:
    • cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
11:27 AM Changeset in webkit [88617] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
​https://bugs.webkit.org/show_bug.cgi?id=61557

Reviewed by Darin Adler.

Replaced the fix for bug 58500 with a refined version.

  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.

10:23 AM Changeset in webkit [88616] by mahesh.kulkarni@nokia.com
  • 5 edits in trunk

[Qt] LayoutTestController needs setTextDirection implementation
​https://bugs.webkit.org/show_bug.cgi?id=62442

Reviewed by Antonio Gomes.

Tools:

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setTextDirection):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
9:57 AM Changeset in webkit [88615] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Andreas Kling.

Minor user-gesture related cleanup
​https://bugs.webkit.org/show_bug.cgi?id=62511

In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.

  • bindings/v8/NPV8Object.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLVideoElement.idl:
7:52 AM Changeset in webkit [88614] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-12 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Build fix for !ENABLE(JIT) after r88604.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
5:40 AM Changeset in webkit [88613] by Nikolas Zimmermann
  • 11 edits in trunk/Source/WebCore

2011-06-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add TextRun charactersLength member
​https://bugs.webkit.org/show_bug.cgi?id=62501

Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).

This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.

  • platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
  • platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
  • platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer

that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.

(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
  • rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
  • rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
4:51 AM Changeset in webkit [88612] by robert@webkit.org
  • 5 edits
    13 adds in trunk

2011-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
​https://bugs.webkit.org/show_bug.cgi?id=62221

Our expectations for the unskipped tests have the following differences from the mac
platform:

  • POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
  • DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
  • platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html

http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html

  • platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.

2011-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
​https://bugs.webkit.org/show_bug.cgi?id=62221

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest (WebCore::QNetworkReplyHandler::getIODevice): ditto (WebCore::QNetworkReplyHandler::sendNetworkRequest):
    • Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
    • If a custom HTTP operation contains data, send it.
  • platform/network/qt/QNetworkReplyHandler.h:

Jun 11, 2011:

11:01 PM Changeset in webkit [88611] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-11 Michael Saboff <​msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
​https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

  • platform/graphics/FontCache.cpp:
9:19 PM Changeset in webkit [88610] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary strlen from DocumentWriter
​https://bugs.webkit.org/show_bug.cgi?id=62505

This ugly piece of code appears not to be needed. Rejoice.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/DocumentWriter.h:
5:51 PM Changeset in webkit [88609] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
​https://bugs.webkit.org/show_bug.cgi?id=62499

This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.

There's still lots of on contorting to do here, but it's a start.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/DocumentWriter.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
1:34 PM Changeset in webkit [88608] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-11 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaseline after r85560.

Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [88607] by Stephanie Lewis
  • 5 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::warmInitialProcess):

  • UIProcess/WebContext.h:
1:21 PM Changeset in webkit [88606] by Dimitri Glazkov
  • 3 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
​http://trac.webkit.org/changeset/88569
​https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/database-name-undefined-expected.txt: Removed.
  • storage/indexeddb/database-name-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
​http://trac.webkit.org/changeset/88569
​https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBFactory.idl:
1:16 PM Changeset in webkit [88605] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):

  • wtf/DateMath.cpp:

(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

1:07 PM Changeset in webkit [88604] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):

  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:
  • wtf/Platform.h:
11:09 AM Changeset in webkit [88603] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Remove expectation of failure after clobber.
​https://bugs.webkit.org/show_bug.cgi?id=62364

  • platform/chromium/test_expectations.txt: Removed.
10:12 AM Changeset in webkit [88602] by Dimitri Glazkov
  • 4 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
​http://trac.webkit.org/changeset/88565
​https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/setVersion-undefined-expected.txt: Removed.
  • storage/indexeddb/setVersion-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
​http://trac.webkit.org/changeset/88565
​https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.idl:
9:37 AM Changeset in webkit [88601] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-06-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
​https://bugs.webkit.org/show_bug.cgi?id=62230

When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.

Tests: fast/dom/body-link-decl-parent-crash.html

fast/dom/styled-inline-style-decl-parent-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
  • html/HTMLBodyElement.h:

2011-06-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=62230

  • fast/dom/body-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-link-decl-parent-crash.html: Added.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Added.
Note: See TracTimeline for information about the timeline view.