Timeline
Jun 13, 2011:
- 11:44 PM Changeset in webkit [88781] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/win/media/audio-repaint-expected.txt:
- 11:31 PM Changeset in webkit [88780] by
-
- 2 edits in trunk/Tools
2011-06-13 Hayato Ito <hayato@chromium.org>
Reviewed by Ojan Vafai.
[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188
A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.
No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 11:11 PM Changeset in webkit [88779] by
-
- 4 edits in branches/chromium/782/Source/WebCore
Merge 88139
BUG=84002
Review URL: http://codereview.chromium.org/7145023
- 10:55 PM Changeset in webkit [88778] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
More Leopard and GTK rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/gtk/fast/forms/input-appearance-range-expected.txt: Added.
- platform/mac-leopard/media/audio-repaint-expected.txt: Added.
- platform/mac-leopard/media/media-document-audio-repaint-expected.txt: Added.
- 10:42 PM Changeset in webkit [88777] by
-
- 10 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/win/media/audio-controls-rendering-expected.txt:
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-strict-expected.txt:
- platform/win/media/controls-styling-expected.txt:
- platform/win/media/controls-without-preload-expected.txt:
- platform/win/media/media-document-audio-repaint-expected.txt:
- platform/win/media/video-controls-rendering-expected.txt:
- platform/win/media/video-display-toggle-expected.txt:
- platform/win/media/video-no-audio-expected.txt:
- 10:34 PM Changeset in webkit [88776] by
-
- 3 edits2 copies in branches/chromium/742
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145022
- 10:25 PM Changeset in webkit [88775] by
-
- 2 edits in trunk/Tools
2011-06-13 Kent Tamura <tkent@chromium.org>
[Chromium-win] Fix two wrong assertions exposed by r88757.
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar):
- 10:19 PM Changeset in webkit [88774] by
-
- 3 edits2 copies in branches/chromium/782
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145021
- 10:15 PM Changeset in webkit [88773] by
-
- 22 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[GTK] Rebaseline for r88757.
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
- platform/gtk/fast/forms/slider-padding-expected.txt:
- platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
- platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
- platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/fast/multicol/client-rects-expected.txt:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- 10:07 PM Changeset in webkit [88772] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125
Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871
- platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
- 10:02 PM Changeset in webkit [88771] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224
Fix the expected result and remove the test from the Skipped list.
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/Skipped:
- 10:00 PM Changeset in webkit [88770] by
-
- 8 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Leopard expectation files for r88757.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/controls-without-preload-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- 9:53 PM Changeset in webkit [88769] by
-
- 3 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Rebaseline for r88757.
- media/audio-repaint-expected.txt:
- media/media-document-audio-repaint-expected.txt:
- 9:45 PM Changeset in webkit [88768] by
-
- 2 edits in trunk/Tools
Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.
- Scripts/webkitpy/common/config/committers.py:
- 9:34 PM Changeset in webkit [88767] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Fix a typo in Mac WebKit2's skipped list.
svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.
- platform/mac-wk2/Skipped:
- 9:29 PM Changeset in webkit [88766] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip editing/pasteboard/smart-paste-004.html per bug 61633.
- platform/win/Skipped:
- 9:23 PM Changeset in webkit [88765] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.
- platform/chromium/test_expectations.txt:
- 9:15 PM Changeset in webkit [88764] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] The second try to fix a build break.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:08 PM Changeset in webkit [88763] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Fix a typo.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:07 PM Changeset in webkit [88762] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Try to fix a build break by r88757.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:05 PM Changeset in webkit [88761] by
-
- 3 edits in branches/chromium/782/Source
Merge 88444
BUG=85559
Review URL: http://codereview.chromium.org/7145019
- 9:02 PM Changeset in webkit [88760] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.
- platform/chromium/test_expectations.txt:
- 8:49 PM Changeset in webkit [88759] by
-
- 1 edit in branches/chromium/782/Source/WebCore/dom/Element.cpp
Merge 87827
BUG=84335
Review URL: http://codereview.chromium.org/7155001
- 8:48 PM Changeset in webkit [88758] by
-
- 1 edit in branches/chromium/742/Source/WebCore/dom/Element.cpp
Merge 87827
BUG=84355
Review URL: http://codereview.chromium.org/7111044
- 8:46 PM Changeset in webkit [88757] by
-
- 46 edits5 adds in trunk
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Add two new tests, and update tests with sliders.
- fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
- fast/forms/input-appearance-range.html: Added.
- fast/forms/slider-thumb-stylability.html: Remove text.
- fast/forms/validation-message-on-range-expected.txt: Added.
- fast/forms/validation-message-on-range.html: Added.
- fast/multicol/client-rects-expected.txt:
- fast/repaint/slider-thumb-float-expected.txt:
- media/audio-repaint-expected.txt:
- media/controls-without-preload-expected.txt:
- media/media-document-audio-repaint-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped: Skip validaiton-message-on-range.html because this platform doesn't support the interactive validation.
- platform/mac-wk2/Skipped: Skip validaiton-message-on-range.html.
- platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
- platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-range-expected.png: Added.
- platform/mac/fast/forms/input-appearance-range-expected.txt: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.txt:
- platform/mac/fast/forms/slider-padding-expected.png:
- platform/mac/fast/forms/slider-padding-expected.txt:
- platform/mac/fast/forms/slider-thumb-shared-style-expected.png:
- platform/mac/fast/forms/slider-thumb-shared-style-expected.txt:
- platform/mac/fast/forms/slider-thumb-stylability-expected.png:
- platform/mac/fast/forms/slider-thumb-stylability-expected.txt:
- platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
- platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.png:
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.png:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.png:
- platform/mac/media/controls-styling-expected.txt:
- platform/qt/Skipped: Skip validaiton-message-on-range.html.
- platform/win/Skipped: Skip validaiton-message-on-range.html.
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Remove RenderSlider::layout().
In order to remove it, we introduce new three shadow nodes:
- A flex box container occupying the whole box
- A flex box item representing a movable area of the thumb
- A flex box item limiting the movable area of the thumb
The thumb position is specified by percentage position in the second element.
This change also fixes Bug 60353.
Tests: fast/forms/input-appearance-range.html
fast/forms/validation-message-on-range.html
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect): Use Node::getRect() for the thumb element.
- css/html.css: Add new style definitions for the new node layout. (input[type="range"]::-webkit-slider-container): (input[type="range"]::-webkit-slider-runnable-track): (input[type="range"]::-webkit-slider-thumb):
- html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Accepts events on shadow nodes, use sliderThumbElementOf(). (WebCore::RangeInputType::createShadowSubtree): Creates new nodes layout. (WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
- html/RangeInputType.h: Remove shadowSliderThumb().
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Moved from RenderSlider.cpp.
(WebCore::hasVerticalAppearance): New utility function.
(WebCore::sliderThumbElementOf): New utility function.
(WebCore::RenderSliderThumb::layout):
Sets CSS top/left values.
(WebCore::RenderSliderContainer::RenderSliderContainer):
(WebCore::RenderSliderContainer::layout):
Add some adjustment code.
- Setting box-orient
- Adjust heights of some nodes. It is required to pass existing tests.
(WebCore::SliderThumbElement::setPositionFromValue):
Update comments.
(WebCore::SliderThumbElement::setPositionFromPoint):
Calculate the current position from absolute positions.
(WebCore::SliderThumbElement::hostInput):
Removed unnecessary variable.
(WebCore::TrackLimiterElement::TrackLimiterElement):
(WebCore::TrackLimiterElement::create): Adjust style.
(WebCore::TrackLimiterElement::createRenderer):
This node uses RenderSliderThumb.
(WebCore::TrackLimiterElement::shadowPseudoId):
This node also uses -webkit-slider-thumb.
(WebCore::SliderContainerElement::SliderContainerElement):
(WebCore::SliderContainerElement::create):
(WebCore::SliderContainerElement::createRenderer):
Uses RenderSliderContainer.
(WebCore::SliderContainerElement::shadowPseudoId):
- html/shadow/SliderThumbElement.h: Make hostInput() public, add declarations of TrackLimiterElement and SliderContainerElement.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): Added an assertion. (WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
- rendering/RenderSlider.h: Remove declarations of removed functions.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Calls adjustSliderThumbSize().
- 8:30 PM Changeset in webkit [88756] by
-
- 1 edit in branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
Merge 87911
BUG=84597
Review URL: http://codereview.chromium.org/7154001
- 7:55 PM Changeset in webkit [88755] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-13 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, rolled DEPS.
- DEPS:
- 7:27 PM Changeset in webkit [88754] by
-
- 7 edits in trunk
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.
- configure.ac: Add configure option to enable/disable register protocol handler.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
- GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::registerProtocolHandler): Added.
- WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
- 7:19 PM Changeset in webkit [88753] by
-
- 3 edits in trunk/Source/WebCore
2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174
Implement paintMediaSliderThumb() function to show thumb of media slider.
adjustSliderThumbSize() should be implemented in order to call paintMediaSliderThumb().
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
- platform/efl/RenderThemeEfl.h:
- 7:15 PM Changeset in webkit [88752] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- 7:09 PM Changeset in webkit [88751] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Keishi Hattori <keishi@webkit.org>
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 7:08 PM Changeset in webkit [88750] by
-
- 1 edit2 copies in branches/chromium/742
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149011
- 7:07 PM Changeset in webkit [88749] by
-
- 1 edit2 copies in branches/chromium/782
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149010
- 6:59 PM Changeset in webkit [88748] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaselines after r88617. The test is now passing on all platforms.
- platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:46 PM Changeset in webkit [88747] by
-
- 2 edits2 adds in trunk/LayoutTests
REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566
Add/update the (failing?) expected results for Windows in order to get the bots green.
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/tiling: Added.
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- 6:15 PM Changeset in webkit [88746] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609
- fast/workers/worker-close.html: Move a setTimeout to start after the response message is received to make the ordering of messages deterministic.
- 6:13 PM Changeset in webkit [88745] by
-
- 6 edits in trunk/Source
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
- platform/chromium/PlatformBridge.h:
- platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
- public/WebKitClient.h: (WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
- src/PlatformBridge.cpp: (WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
- 6:10 PM Changeset in webkit [88744] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.
- platform/chromium/test_expectations.txt:
- 6:00 PM Changeset in webkit [88743] by
-
- 2 edits in branches/chromium/782/Source/WebKit/chromium
Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592
Reviewed by David Levin.
- public/WebNotification.h:
- src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.
TBR=jianli@chromium.org
BUG=84660
Review URL: http://codereview.chromium.org/7148005
- 5:58 PM Changeset in webkit [88742] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip test added by r88578 on GTK per bug 62585.
- platform/gtk/Skipped:
- 5:53 PM Changeset in webkit [88741] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602
No new tests, build cleanup only.
- config.h:
- 5:42 PM Changeset in webkit [88740] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612
This parameter defaults to true anyway.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- 5:39 PM Changeset in webkit [88739] by
-
- 1 edit3 adds in trunk/LayoutTests
Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).
- platform/win/svg/hixie/intrinsic: Added.
- platform/win/svg/hixie/intrinsic/003-expected.png: Added.
- platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
- 5:38 PM Changeset in webkit [88738] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592
Reviewed by David Levin.
- public/WebNotification.h:
- src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.
- 5:22 PM Changeset in webkit [88737] by
-
- 11 edits2 adds in trunk
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256
Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.
- printing/page-count-with-one-word-expected.txt: Added.
- printing/page-count-with-one-word.html: Added.
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebCore.exp.in:
- page/Frame.cpp: (WebCore::Frame::resizePageRectsKeepingRatio):
- page/Frame.h:
- page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::begin):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]): (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): (-[WebHTMLView _endPrintMode]): (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): (-[WebHTMLView _endScreenPaginationMode]): (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]): (-[WebHTMLView layout]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView setPageWidthForPrinting:]):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebFrame.cpp: (WebFrame::setPrinting): (WebFrame::setInPrintingMode):
- WebFrame.h:
- 5:11 PM Changeset in webkit [88736] by
-
- 7 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r88734
- 5:10 PM Changeset in webkit [88735] by
-
- 5 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611
<rdar://problem/9058370>
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::getPluginInfo): Get the plug-in version string instead of the version number.
(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.
(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.
- Shared/Plugins/PluginQuirks.h: Add the ReturnsNonRetainedScriptableNPObject quirk.
- UIProcess/Plugins/PluginInfoStore.h: Use a version string. Eventually this should hold the PluginVersion class we added.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginScriptableNPObject): If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
- 5:09 PM Changeset in webkit [88734] by
-
- 7 edits in trunk/Source/WebKit/gtk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.
- docs/webkitgtk-sections.txt: Add missing sections to the list and remove unneeded sections.
- docs/webkitgtk.types: Update the types list.
- webkit/webkithittestresult.cpp: Fix inline documentation errors. (webkit_hit_test_result_class_init): Ditto.
- webkit/webkiticondatabase.cpp: Ditto.
- webkit/webkitwebsettings.cpp: Ditto. (webkit_web_settings_class_init): Ditto.
- webkit/webkitwebview.cpp: Ditto. (webkit_web_view_class_init): Ditto.
- 4:51 PM Changeset in webkit [88733] by
-
- 4 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Mac, GTK, and Qt rebaselines after r88717.
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- 4:49 PM Changeset in webkit [88732] by
-
- 2 edits in trunk/Tools
2011-06-13 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- 4:28 PM Changeset in webkit [88731] by
-
- 18 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601
Previously, our user-gesture state was per-frame. Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture. Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.
This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code. Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
- bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp):
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h: (WebCore::ScriptController::setProcessingTimerCallback):
- bindings/v8/V8Utilities.cpp:
- bindings/v8/V8Utilities.h:
- bindings/v8/specialization/V8BindingState.cpp:
- bindings/v8/specialization/V8BindingState.h:
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitFromJavaScript): (WebCore::HTMLFormElement::submit):
- page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::createWindow): (WebCore::DOMWindow::open):
- 4:20 PM Changeset in webkit [88730] by
-
- 4 edits2 adds in trunk
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Added a test that tries to remove the children of munder, mover and munderover elements.
- mathml/munderover-remove-children-expected.txt: Added.
- mathml/munderover-remove-children.html: Added.
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.
Test: mathml/munderover-remove-children.html
- rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
- rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
- 4:06 PM Changeset in webkit [88729] by
-
- 11 edits in trunk/Source
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
- bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::create): (WebCore::V8BindingPerIsolateData::ensureInitialized): (WebCore::V8BindingPerIsolateData::dispose): (WebCore::getToStringName): (WebCore::getToStringTemplate):
- bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::get): (WebCore::V8BindingPerIsolateData::current): (WebCore::V8BindingPerIsolateData::rawTemplateMap): (WebCore::V8BindingPerIsolateData::templateMap): (WebCore::V8BindingPerIsolateData::toStringName): (WebCore::V8BindingPerIsolateData::toStringTemplate):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
- bindings/v8/V8Utilities.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
- tests/IDBBindingUtilitiesTest.cpp: (WebCore::TEST):
- 3:56 PM Changeset in webkit [88728] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-06-13 Lei Zhang <thestig@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
- src/WebSettingsImpl.h:
- 3:53 PM Changeset in webkit [88727] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Adam Barth.
Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598
Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressCompleted):
- 3:50 PM Changeset in webkit [88726] by
-
- 6 edits in trunk/Tools
2011-06-13 Chris Rogers <crogers@google.com>
Reviewed by Dirk Pranke.
Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::setEncodedAudioData):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::encodedAudioData): (LayoutTestController::shouldDumpAsAudio): (LayoutTestController::setShouldDumpAsAudio):
- DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleAudioHeader): (TestShellPrinter::handleAudioHeader):
- DumpRenderTree/chromium/TestEventPrinter.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::dump):
- 3:47 PM Changeset in webkit [88725] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>
Reviewed by Eric Seidel.
[EFL] Input method hints not updated while clicking non-input field editable area
https://bugs.webkit.org/show_bug.cgi?id=62539
This fixes a minor bug when input method hints are not updated while focus is
changed from editable area with input tags to other which are does not have input
tag i.e. textarea.
- ewk/ewk_view.cpp: (ewk_view_input_method_state_set):
- 3:46 PM Changeset in webkit [88724] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605
A simple rename
- parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
- parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):
- 3:45 PM Changeset in webkit [88723] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536
Implements basic functions for "redo" command.
- WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
- WebCoreSupport/EditorClientEfl.h:
- 3:44 PM Changeset in webkit [88722] by
-
- 1 edit13 adds in trunk/Source/WebKit2
2011-06-13 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445
Add Efl related directory and files in WebKit2/WebProcess/.
- WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
- WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
- WebProcess/WebPage/efl/WebPageEfl.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL):
- WebProcess/efl/WebProcessEfl.cpp: Added. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformTerminate):
- WebProcess/efl/WebProcessMainEfl.cpp: Added. (WebKit::WebProcessMainEfl):
- WebProcess/efl/WebProcessMainEfl.h: Added.
- efl/MainEfl.cpp: Added. (main):
- 3:39 PM Changeset in webkit [88721] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88704.
http://trac.webkit.org/changeset/88704
https://bugs.webkit.org/show_bug.cgi?id=62466
Caused layout test failures on Chromium Mac.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- 3:39 PM Changeset in webkit [88720] by
-
- 2 edits in trunk
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Need to report whether touch icon loading is enabled
https://bugs.webkit.org/show_bug.cgi?id=62532
It needs to report whether touch icon loading is enabled.
- configure.ac: Updated option parsing code for loading touch icons.
- 3:38 PM Changeset in webkit [88719] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600
Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases. This comes out as a reasonable parsing speed
boost.
- parser/JSParser.cpp: (JSC::JSParser::nextExpectIdentifier): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
- parser/Lexer.cpp:
- parser/Lexer.h: (JSC::Lexer::makeIdentifier): (JSC::Lexer::lexExpectIdentifier):
- 3:38 PM Changeset in webkit [88718] by
-
- 2 edits in trunk/Source/WebCore
Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562
<rdar://problem/9313885>
Patch by Morgan Winer <mwiner@apple.com> on 2011-06-13
Reviewed by Enrica Casucci.
The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.
There are no layout tests for this, since it can be tested only at API level.
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().
- 3:37 PM Changeset in webkit [88717] by
-
- 6 edits3 deletes in trunk/LayoutTests
2011-06-13 Wyatt Carss <wcarss@google.com>
Reviewed by Ryosuke Niwa.
dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159
Converted to dump the key part of page as text. The platform-dependent files are
copied from the previous setup of this test, as mac appears to do something different
in its delegate info -- 'insertText' instead of 'insertNode', and some differences
in how it counts indices. Note that chromium-mac works the same as chromium-win, but
would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
a bit accordingly.
- editing/pasteboard/paste-xml.xhtml:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/win/editing/pasteboard/paste-xml-expected.txt:
- 3:36 PM Changeset in webkit [88716] by
-
- 4 edits in trunk
2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277
Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.
- Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277
Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.
No change in functionality so no new tests.
- CMakeLists.txt: move .idl files to be conditionally generated.
- 3:32 PM Changeset in webkit [88715] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: Infinity as key
https://bugs.webkit.org/show_bug.cgi?id=62285
- storage/indexeddb/key-type-infinity-expected.txt: Added.
- storage/indexeddb/key-type-infinity.html: Added.
- 3:30 PM Changeset in webkit [88714] by
-
- 2 edits in trunk/Tools
2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add load error handler to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62347
Add a handler function of "load,error" to EWebLauncher.
EWebLauncher now displays a simple error page on load errors.
- EWebLauncher/main.c: (on_load_error): (browserCreate):
- 3:29 PM Changeset in webkit [88713] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: odd database names
https://bugs.webkit.org/show_bug.cgi?id=62322
- storage/indexeddb/database-odd-names-expected.txt: Added.
- storage/indexeddb/database-odd-names.html: Added.
- 3:25 PM Changeset in webkit [88712] by
-
- 6 edits1 delete in trunk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
since the TestPlugin no longer prints this event.
- platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Do not set the plugin as windowless always. Doing this breaks some results on Qt and this seems to be unnecessary for the moment. (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the XP_UNIX block is first by guarding against using a null instance.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add the XP_UNIX define for Linux.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
- GNUmakefile.am: Update source list.
- 3:23 PM Changeset in webkit [88711] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
without plugin support
https://bugs.webkit.org/show_bug.cgi?id=62394
No behaviour changes, so no new tests.
- CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and Plugin{Package,View}None.cpp and move them to CMakeListWinCE and CMakeListsEfl, respectively.
- CMakeListsEfl.txt:
- CMakeListsWinCE.txt:
- 3:22 PM Changeset in webkit [88710] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Eric Seidel.
[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
https://bugs.webkit.org/show_bug.cgi?id=62365
These functions do not exist in any public headers and
they are not used internally.
Moreover ewk_view has the same functionality added
https://bugs.webkit.org/show_bug.cgi?id=60435
- ewk/ewk_frame.cpp:
- 3:22 PM Changeset in webkit [88709] by
-
- 35 edits in trunk/LayoutTests
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Rewrite a bunch of XHR-based tests to use waitUntilDone()/notifyDone().
https://bugs.webkit.org/show_bug.cgi?id=62066
- fast/xmlhttprequest/xmlhttprequest-gc.html:
- fast/xmlhttprequest/xmlhttprequest-get.xhtml:
- fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
- html5lib/runner.html:
- html5lib/webkit-resumer.html:
- http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html:
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html:
- http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html:
- http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html:
- http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:
- http/tests/xmlhttprequest/cross-origin-preflight-get.html:
- http/tests/xmlhttprequest/event-listener-gc.html:
- http/tests/xmlhttprequest/interactive-state.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html:
- http/tests/xmlhttprequest/response-encoding.html:
- http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-004.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-005.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-006.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-007.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-008.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-009.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-010.html:
- http/tests/xmlhttprequest/web-apps/001.html:
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html:
- http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html:
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
- http/tests/xmlhttprequest/zero-length-response.html:
- 3:17 PM Changeset in webkit [88708] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: readonly properties
https://bugs.webkit.org/show_bug.cgi?id=62392
- storage/indexeddb/readonly-expected.txt: Added.
- storage/indexeddb/readonly.html: Added.
- 3:16 PM Changeset in webkit [88707] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62524
- UIProcess/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformDidClose): (WebKit::WebInspectorProxy::platformBringToFront): (WebKit::WebInspectorProxy::platformInspectedURLChanged): (WebKit::WebInspectorProxy::inspectorPageURL): (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
- 3:14 PM Changeset in webkit [88706] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62438
- UIProcess/efl/TextCheckerEfl.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkSpellingOfString): (WebKit::TextChecker::checkGrammarOfString): (WebKit::TextChecker::spellingUIIsShowing): (WebKit::TextChecker::toggleSpellingUIIsShowing): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::updateSpellingUIWithGrammarString): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
- 3:09 PM Changeset in webkit [88705] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Eric Seidel.
Web Inspector: [refactoring] remove dead code from NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=62481
- inspector/front-end/NetworkPanel.js:
- 3:06 PM Changeset in webkit [88704] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Daniel Cheng <dcheng@chromium.org>
Reviewed by Eric Seidel.
[chromium] Dragging images to Mail.app results in broken attachments
https://bugs.webkit.org/show_bug.cgi?id=62466
No new tests.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- 3:00 PM Changeset in webkit [88703] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-06-13 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Dimitri Glazkov.
Add accessors for selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=62596
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::selectionEnd): (WebKit::WebAccessibilityObject::selectionStart):
- 2:58 PM Changeset in webkit [88702] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Sangyong Park <sy302.park@gmail.com>
Reviewed by Eric Seidel.
implement to handle wheel event of plugin on x11
https://bugs.webkit.org/show_bug.cgi?id=62522
Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
for to handle wheel event on plugins
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent (WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent (WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin
- 2:51 PM Changeset in webkit [88701] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62523
- UIProcess/efl/WebContextEfl.cpp: Added. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformInvalidateContext): (WebKit::WebContext::platformDefaultDatabaseDirectory): (WebKit::WebContext::platformDefaultIconDatabasePath): (WebKit::WebContext::platformDefaultLocalStorageDirectory):
- 2:44 PM Changeset in webkit [88700] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[efl] Disable tiled backing store debug messages by default.
https://bugs.webkit.org/show_bug.cgi?id=61745
These messages pollute the output and are only useful to people
working on TBS itself. It makes more sense to have them disabled by
default.
- ewk/ewk_tiled_backing_store.h:
- 2:36 PM Changeset in webkit [88699] by
-
- 2 edits1 add11 deletes in trunk/LayoutTests
2011-06-13 Annie Sullivan <sullivan@chromium.org>
Reviewed by Dimitri Glazkov.
Convert editing/execCommand/outdent-selection.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=62582
Convert the test to dump as markup and clean up the HTML.
- editing/execCommand/outdent-selection-expected.txt: Added.
- editing/execCommand/outdent-selection.html:
- platform/chromium-linux/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/gtk/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/mac/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/mac/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/qt/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/qt/editing/execCommand/outdent-selection-expected.txt: Removed.
- 2:33 PM Changeset in webkit [88698] by
-
- 3 edits3 adds in trunk
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465
- compositing/layer-creation/overlap-child-layer-expected.png: Added.
- compositing/layer-creation/overlap-child-layer-expected.txt: Added.
- compositing/layer-creation/overlap-child-layer.html: Added.
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465
Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.
Test: compositing/layer-creation/overlap-animated-layer.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 2:29 PM Changeset in webkit [88697] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Correctly classify the test as failing.
- platform/chromium/test_expectations.txt: It's failing.
- 2:23 PM Changeset in webkit [88696] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Touch this to try to fix the build...
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget):
- 2:22 PM Changeset in webkit [88695] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Record more flakiness...
- platform/chromium/test_expectations.txt: Added expectation of flakiness.
- 2:20 PM Changeset in webkit [88694] by
-
- 2 edits in trunk/LayoutTests
[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597
Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.
- platform/win/Skipped:
- 2:14 PM Changeset in webkit [88693] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
- GNUmakefile.list.am: remove CredentialStorage.cpp
- 2:10 PM Changeset in webkit [88692] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Improve GPU canvas startup time on the SkiaGPU path.
https://bugs.webkit.org/show_bug.cgi?id=62594
Fixed by skipping creation of shaders used only by the legacy path.
Covered by existing canvas tests.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
- 2:08 PM Changeset in webkit [88691] by
-
- 6 edits in trunk/Source/WebCore
2011-06-13 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498
Added some needed and speculative FontCachePurgePreventer objects.
Built and ran Safari with debug version of webkit that purges all
purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
to find system fallback fonts access via code paths that aren't
protected with FontCachePurgePreventer objects. Also examined
platform specific code that calls either Font::drawText() or
Canvas::drawText(). For those methods that may be called from currently
unprotected paths, added FontCachePurgePreventer objects.
No new functionality so no new tests.
- inspector/DOMNodeHighlighter.cpp:
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: (PlatformCALayerWinInternal::displayCallback):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::drawHudContents):
- platform/mac/DragImageMac.mm: (WebCore::widthWithFont): (WebCore::drawAtPoint):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
- 1:59 PM Changeset in webkit [88690] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Windows rebaseline after r62565. The failure is tracked by the bug 62565.
- platform/win/fast/harness/results-expected.txt:
- 1:58 PM Changeset in webkit [88689] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
Unreviewed fix - removed parts of r88659 that were committed by mistake.
The patch accidentally included parts that weren't supposed to be there, namely the whole
code was duplicated. This patch rectifies that and brings it to the original reviewed code.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- 1:56 PM Changeset in webkit [88688] by
-
- 2 edits in trunk/LayoutTests
Test fix for Windows.
[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595
- platform/win/Skipped: Skipped the test with the problem.
- 1:52 PM Changeset in webkit [88687] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r88683
- 1:49 PM Changeset in webkit [88686] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r87766
- 1:46 PM Changeset in webkit [88685] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544
Fixed the crash by adding null pointer checks.
No new tests since there's no way to open dictionary panel.
- dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
- editing/VisiblePosition.cpp: (WebCore::makeRange):
- page/Frame.cpp: (WebCore::Frame::rangeForPoint):
- 1:41 PM Changeset in webkit [88684] by
-
- 3 edits in trunk/LayoutTests
plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973
Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.
- platform/win/plugins/mouse-events-expected.txt:
- platform/win/plugins/mouse-events-fixedpos-expected.txt:
- 1:39 PM Changeset in webkit [88683] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the list of ignored GTK+ header files for the documentation
generation.
- docs/GNUmakefile.am: Update ignored header list.
- 1:36 PM Changeset in webkit [88682] by
-
- 16 edits2 adds in trunk/Source
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::iconURLs):
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509
This new class contains all the icon-related logic from FrameLoader.
The icon-related logic and state has almost zero interaction with the
rest of FrameLoader and is better handled as a separate concern.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setIconURL):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): (WebCore::DocumentLoader::continueIconLoadWithDecision):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stop):
- loader/FrameLoader.h: (WebCore::FrameLoader::icon):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
- loader/icon/IconLoader.h:
- 1:25 PM Changeset in webkit [88681] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Update NEWS for 1.5.1 release.
- NEWS: update.
- 1:20 PM Changeset in webkit [88680] by
-
- 7 edits1 delete in trunk/Tools
2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88671.
http://trac.webkit.org/changeset/88671
https://bugs.webkit.org/show_bug.cgi?id=62591
"didn't work" (Requested by dpranke on #webkit).
- Scripts/new-run-webkit-httpd:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 1:19 PM Changeset in webkit [88679] by
-
- 5 edits2 adds in trunk
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
mostly written by Kelly Norton (knorton@google.com).
- plugins/npruntime/embed-property-equality-expected.txt: Added.
- plugins/npruntime/embed-property-equality.html: Added.
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
[V8] Cache V8NPObjects so that we don't create multiple
NPObjects for the same v8::Object.
https://bugs.webkit.org/show_bug.cgi?id=61482
Test: plugins/npruntime/embed-property-equality.html
- bindings/v8/NPV8Object.cpp: (WebCore::freeV8NPObject): (WebCore::npCreateV8ScriptObject):
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
- 1:16 PM Changeset in webkit [88678] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-06-13 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
https://bugs.webkit.org/show_bug.cgi?id=49316
The bug got fixed, thus just landing the test case. Including another test case from
http://code.google.com/p/chromium/issues/detail?id=61562
which should have the same root cause.
- fast/html/crash-style-first-letter-expected.txt: Added.
- fast/html/crash-style-first-letter.html: Added.
- svg/custom/svg-use-style-float-crash-expected.txt: Added.
- svg/custom/svg-use-style-float-crash.svg: Added.
- 1:07 PM Changeset in webkit [88677] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
BankID plug-in isn't instantiated correctly
https://bugs.webkit.org/show_bug.cgi?id=62588
<rdar://problem/9586600>
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can use the half-baked QuickDraw support.
- WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout): Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events and we don't want the plug-in to die while it's waiting for a reply.
- 1:03 PM Changeset in webkit [88676] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 James Robinson <jamesr@chromium.org>
[chromium] Fix up a boo-boo in GPU test expectations
- platform/chromium/test_expectations.txt:
- 1:01 PM Changeset in webkit [88675] by
-
- 2 edits in trunk/LayoutTests
Test run fix.
[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585
- platform/gtk/Skipped: Skipping a test which depends on this.
- 12:47 PM Changeset in webkit [88674] by
-
- 8 edits in trunk/Source
Source/WebCore:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit/gtk:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
Source/JavaScriptCore:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
- GNUmakefile.list.am:
- 12:37 PM Changeset in webkit [88673] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Robert Hogan <robert@webkit.org>
Unreviewed, cleanup r87611.
[Qt]Unskip fast/events/backspace-navigates-back.html
This should have been unskipped by http://trac.webkit.org/changeset/87611
- platform/qt/Skipped:
- 12:33 PM Changeset in webkit [88672] by
-
- 2 edits in trunk/LayoutTests
Remove an extra space in the Windows-specific failing expected results to ge the bots
green.
- platform/win/printing/page-count-relayout-shrink-expected.txt:
- 12:15 PM Changeset in webkit [88671] by
-
- 7 edits1 add in trunk/Tools
2011-06-13 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
https://bugs.webkit.org/show_bug.cgi?id=62251
shut_down_http_server() was a total hack that was only used by
new-run-webkit-httpd, so I've moved the code there and switched
to using executive.kill_process() for the common case. The
method itself will be removed in the patch on bug 59993.
- Scripts/new-run-webkit-httpd:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 12:12 PM Changeset in webkit [88670] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed build fix of mac.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
Forgot to add SVGAnimatedLength.cpp.
- WebCore.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [88669] by
-
- 16 edits in trunk/Source/WebKit2
kAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547
Reviewed by Darin Adler.
Implement the missing screenToWindow method for WK2.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToWindow):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::screenToWindow):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::screenToWindow):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::screenToWindow):
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::screenToWindow):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::screenToWindow):
- WebProcess/WebPage/WebPage.h:
- 12:09 PM Changeset in webkit [88668] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584
Move Identifier::equal to the Identifier header file.
- runtime/Identifier.cpp:
- runtime/Identifier.h: (JSC::Identifier::equal):
- 11:59 AM Changeset in webkit [88667] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.
- 11:58 AM Changeset in webkit [88666] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 James Robinson <jamesr@chromium.org>
[chromium] Clean up GPU test expectations.
- platform/chromium/test_expectations.txt:
- 11:53 AM Changeset in webkit [88665] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB test: complex keyPaths
https://bugs.webkit.org/show_bug.cgi?id=62468
- storage/indexeddb/keyPath-expected.txt: Added.
- storage/indexeddb/keyPath.html: Added.
- 11:50 AM Changeset in webkit [88664] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Print out bounds origin in layer dump
https://bugs.webkit.org/show_bug.cgi?id=62583
Include m_boundsOrigin in the layer dump, which is used by layerTreeAsText().
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- 11:48 AM Changeset in webkit [88663] by
-
- 17 edits55 adds in trunk
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
Added new tests to check correct behavior of SVGLength animations.
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-1.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-2.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-3.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-number-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-cm.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-ems.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-exs.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-in.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pc.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pt.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-px.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-values.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
- svg/animations/svglength-animation-LengthModeHeight-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeHeight.html: Added.
- svg/animations/svglength-animation-LengthModeOther-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeOther.html: Added.
- svg/animations/svglength-animation-LengthModeWidth-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeWidth.html: Added.
- svg/animations/svglength-animation-invalid-value-1-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-1.html: Added.
- svg/animations/svglength-animation-invalid-value-2-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-2.html: Added.
- svg/animations/svglength-animation-invalid-value-3-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-3.html: Added.
- svg/animations/svglength-animation-number-to-number-expected.txt: Added.
- svg/animations/svglength-animation-number-to-number.html: Added.
- svg/animations/svglength-animation-px-to-cm-expected.txt: Added.
- svg/animations/svglength-animation-px-to-cm.html: Added.
- svg/animations/svglength-animation-px-to-ems-expected.txt: Added.
- svg/animations/svglength-animation-px-to-ems.html: Added.
- svg/animations/svglength-animation-px-to-exs-expected.txt: Added.
- svg/animations/svglength-animation-px-to-exs.html: Added.
- svg/animations/svglength-animation-px-to-in-expected.txt: Added.
- svg/animations/svglength-animation-px-to-in.html: Added.
- svg/animations/svglength-animation-px-to-number-expected.txt: Added.
- svg/animations/svglength-animation-px-to-number.html: Added.
- svg/animations/svglength-animation-px-to-pc-expected.txt: Added.
- svg/animations/svglength-animation-px-to-pc.html: Added.
- svg/animations/svglength-animation-px-to-percentage-expected.txt: Added.
- svg/animations/svglength-animation-px-to-percentage.html: Added.
- svg/animations/svglength-animation-px-to-pt-expected.txt: Added.
- svg/animations/svglength-animation-px-to-pt.html: Added.
- svg/animations/svglength-animation-px-to-px-expected.txt: Added.
- svg/animations/svglength-animation-px-to-px.html: Added.
- svg/animations/svglength-animation-values-expected.txt: Added.
- svg/animations/svglength-animation-values.html: Added.
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
When running SMIL animations within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
gets asked for its current value. This value gets transformed to a string. In SVGAnimateElement we try to parse this string again and
split it into a number and its unit. In the further steps we just animate the number. This number gets transformed back to a string
together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAngle, SVGColor, ...), relayout and rerendering.
In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.
This patch does not attempt to change the string transformations, but addresses the parsing of the string back to a number and unit in the
SVG animation code. There's no need to write a new parser in SVGAnimateElement to parse SVG primitive datatypes, we can instead reuse the existing ones.
Also the current parser of SVGAnimateElement does not handle most unit types, nor is it possible to animate lists like SVGLengthList with the
parsed content. An animation of values with different unit types is not possible:
<rect width="20" height="20">
<animate animateAttribute="width" from="20px" to="10%" dur="4s"/>
</rect>
For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
animation.
With using the parsers of SVG primitive datatypes we will also use the SVG primitive datatypes in the animation code itself. And that makes
it possible to do such animations.
In short: SVG primitive datatype -> string -> SVG primitive datatype animation -> string -> SVG primitive datatype.
It will be easier to avoid the string transformation once all SVG primitive datatypes are supported.
To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElement itself just works with the new added generic datatype SVGAnimationType.
SVGAnimatorFactory creates the SVG primitive datatype specific animators. This makes the main animation code a lot more readable and
maintainable.
With this patch I add the SVGAnimatorFactory and convert SVGLength animation to the new concept.
Tests: svg/animations/svglength-animation-LengthModeHeight.html
svg/animations/svglength-animation-LengthModeOther.html
svg/animations/svglength-animation-LengthModeWidth.html
svg/animations/svglength-animation-invalid-value-1.html
svg/animations/svglength-animation-invalid-value-2.html
svg/animations/svglength-animation-invalid-value-3.html
svg/animations/svglength-animation-number-to-number.html
svg/animations/svglength-animation-px-to-cm.html
svg/animations/svglength-animation-px-to-ems.html
svg/animations/svglength-animation-px-to-exs.html
svg/animations/svglength-animation-px-to-in.html
svg/animations/svglength-animation-px-to-number.html
svg/animations/svglength-animation-px-to-pc.html
svg/animations/svglength-animation-px-to-percentage.html
svg/animations/svglength-animation-px-to-pt.html
svg/animations/svglength-animation-px-to-px.html
svg/animations/svglength-animation-values.html
- CMakeLists.txt: Added new files to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other build systems.
- svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. Use SVGLength parser directly. (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurrentColor public as preperation for SVGAnimatedColor. (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property. (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheritance as preperation for SVGAnimated* files. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now. (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
- svg/SVGAnimateElement.h:
- svg/SVGAnimatedLength.cpp: Added. (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): (WebCore::sharedSVGLength): (WebCore::SVGAnimatedLengthAnimator::constructFromString): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
- svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator which is responsible for the actual animation. (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
- svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement. (WebCore::SVGAnimatedType::createLength): (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::type): (WebCore::SVGAnimatedType::length): (WebCore::SVGAnimatedType::SVGAnimatedType):
- svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLengthAnimator and future SVG unit animators. (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator): (WebCore::SVGAnimatedTypeAnimator::setContextElement): (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use parseNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespaces shouldn't be stripped on the following attributes: 'from', 'to' and 'by'. This is not the case for SVGLength anymore. Added new tests to check this behavior. (WebCore::SVGAnimationElement::animationMode): Enum is accessible in WebCore namespace now. (WebCore::SVGAnimationElement::calcMode): Ditto.
- svg/SVGAnimationElement.h:
- svg/SVGAnimatorFactory.h: Added. (WebCore::SVGAnimatorFactory::create):
- svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): New setter with string and SVGLengthMode. (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMode for SVGLength depending on the attribute name.
- svg/SVGLength.h:
- 11:42 AM WebKit Team edited by
- (diff)
- 11:37 AM Changeset in webkit [88662] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
r87539 broke HTMLMediaElement url logging
https://bugs.webkit.org/show_bug.cgi?id=62551
Returning pointers to temporaries is bad times!
- html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::sourceWasAdded): (WebCore::HTMLMediaElement::sourceWillBeRemoved):
- 11:36 AM Changeset in webkit [88661] by
-
- 13 edits in trunk
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Scripts/build-webkit:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 11:29 AM Changeset in webkit [88660] by
-
- 4 edits2 adds in trunk
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
- storage/indexeddb/setVersion-undefined-expected.txt: Added.
- storage/indexeddb/setVersion-undefined.html: Added.
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
Test: storage/indexeddb/setVersion-undefined.html
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
- storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
- 11:22 AM Changeset in webkit [88659] by
-
- 1 edit2 adds in trunk/Source/WebKit2
2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Added WebGraphicsLayer, a subclass of WebCore::GraphicsLayer that serializes the state of the layer
tree to the UI process WebLayerTreeInfo.
For now this patch doesn't serialize the animation information, a feature that will be upstreamed later on.
Together with Viatcheslav Ostapenko.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: Added.
- WebProcess/WebCoreSupport/WebGraphicsLayer.h: Added.
- 11:20 AM Changeset in webkit [88658] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Clean up test expectations, add a flake.
- platform/chromium/test_expectations.txt: Cleaned up.
- 11:18 AM Changeset in webkit [88657] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Add utility method to report whether a RenderLayer has any scrollbars
https://bugs.webkit.org/show_bug.cgi?id=62579
New method that returns true with either scrollbar is present.
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasScrollbars):
- 11:10 AM Changeset in webkit [88656] by
-
- 1 edit2 copies in branches/chromium/742
Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
- fast/files/blob-builder-crash-expected.txt: Added.
- fast/files/blob-builder-crash.html: Added.
TBR=jianli@chromium.org
BUG=85659
Review URL: http://codereview.chromium.org/7134095
- 11:09 AM Changeset in webkit [88655] by
-
- 1 edit2 adds in trunk/Source/WebKit2
2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Added WebLayerTreeInfo: a set of structures that can serialize a tree of GraphicsLayers
across to the UI process.
Together with Viatcheslav Ostapenko.
- Scripts/webkit2/messages.py:
- Shared/WebLayerTreeInfo.cpp: Added.
- Shared/WebLayerTreeInfo.h: Added.
- 11:05 AM Changeset in webkit [88654] by
-
- 7 edits in trunk/Source
2011-06-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338
No new tests; covered by the existing full-screen tests.
Now that we are forcing a repaint inside of setRootFullScreenLayer() instead of during
the next run loop, make sure that we have disabled animation before calling
setRootFullScreenLayer() so that the RenderFullScreen renderer and its contents are
painted.
- dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement):
2011-06-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338
Instead of making a round-trip between processes by calling forceRepaint
and waiting for a callback, instead make a WebProcess-side call to
forceRepaintWithoutCallback before sending the ExitAcceleratedCompositingMode
message to the WebFullScreenControllerProxy. This also means we can get rid of
the dragImage creation and display.
Because this redraw will happen during the current run-loop instead of a future
one, make sure the background color has been set before the redraw in
didEnterFullScreen().
Wait to hide the full-screen window until after we have received the
ExitAcceleratedCompositingMode message. By this time, repaint will have already
completed.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Disable
screen updates, to be re-enabled during exitAcceleratedCompositingMode.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Don't hide
the full-screen window here; wait for exitAcceleratedCompositing instead.
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Collapse
the redrawCompleted method into this one.
(-[WKFullScreenWindowController close]): Remove the reference to
exitCompositedModeRepaintCompleted.
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::didEnterFullScreen): Set the full screen
background color first.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Repaint before
sending the ExitAcceleratedCompositingMode message.
- 11:02 AM Changeset in webkit [88653] by
-
- 6 edits in trunk/Source/WebCore
2011-06-10 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
https://bugs.webkit.org/show_bug.cgi?id=62491
<rdar://problem/9584427>
No new tests; should be covered by existing fullscreen pixel tests.
On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
creation of a tiled CALayer (instead of a normal CALayer). Painting in these layers necessarily
happens asynchronously, so the flash is occurring because of the async painting of the RenderFullScreen
renderer's background color. Since we know the RenderFullScreen does not otherwise paint its contents,
we can add a special case in the RenderLayerBacking to set the GraphicsLayer contents to be the
renderer's background color. Fill in support for creating a contentLayer to contain the background
color inside GraphicsLayerCA.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from setContentsBackgroundColor to match
the other setContentsTo... functions.
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the
background color.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a comment only.
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen
renderer to call updateBackgroundColor.
(WebCore::RenderLayerBacking::updateBackgroundColor): Added.
(WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen
renderer does not paint its contents.
- rendering/RenderLayerBacking.h:
- 10:59 AM Changeset in webkit [88652] by
-
- 2 edits2 adds in trunk
2011-06-13 Tim Horton <timothy_horton@apple.com>
Reviewed by Simon Fraser.
REGRESSION(87152): Crash on page with svg fonts
https://bugs.webkit.org/show_bug.cgi?id=61556
We can't assume that the parent of a SVG-font-styled
text node won't be an anonymous block.
Test: svg/text/text-font-anonymous-parent.xhtml
- rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::firstParentRendererForNonTextNode): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
- 10:49 AM Changeset in webkit [88651] by
-
- 2 edits3 deletes in trunk/LayoutTests
2011-06-13 Dirk Schulze <krit@webkit.org>
Rubber-stamped by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
Removing 'transform' animation test. It was added as an example for animateTransform tests but fails on some platforms.
Also it is not part of the fix for 'patternTransform' animation. The test for 'patternTransform' works.
Adding animateTransform-pattern-transform to the skip list of Mac WebKit2, like all other animation or dynamic-update tests.
- platform/mac-wk2/Skipped:
- svg/animations/animateTransform-transformable-transform-expected.txt: Removed.
- svg/animations/animateTransform-transformable-transform.html: Removed.
- svg/animations/script-tests/animateTransform-transformable-transform.js: Removed.
- 10:47 AM Changeset in webkit [88650] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Add radar number.
- 10:32 AM Changeset in webkit [88649] by
-
- 13 edits in trunk
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Scripts/build-webkit:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 10:25 AM Changeset in webkit [88648] by
-
- 4 edits3 adds in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Updated Leopard pixel baselines.
- platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:24 AM Changeset in webkit [88647] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Don't access freed memory in the UI process when a plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=62548
Call pluginProcessCrashedOrFailedToLaunch after sending messages to all processes about the plug-in crash,
otherwise we'll try to dereference m_pluginInfo.path after the PluginProcessProxy object has been deleted.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose):
- 10:14 AM Changeset in webkit [88646] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix a crash when drawing area has been deleted
https://bugs.webkit.org/show_bug.cgi?id=62541
Check whether WebPageProxy::drawingArea() returns a valid pointer
before using it, it might be null, for example, when the web
process crashes.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): (webkitWebViewBaseSizeAllocate):
- 10:12 AM Changeset in webkit [88645] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Some distcheck fixes. Still broken, but this is moves us closer to
the target.
- GNUmakefile.am: fix vpath syntax and add missing files to EXTRA_DIST.
- GNUmakefile.list.am: add missing files and remove dead files.
- bindings/gobject/GNUmakefile.am: fix comment.
- 9:54 AM Changeset in webkit [88644] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 9:16 AM Changeset in webkit [88643] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925
Use the new factory function in TextureMapper.
No new functionality so no new tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):
- 8:48 AM Changeset in webkit [88642] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [88641] by
-
- 3 edits3 adds in trunk
2011-06-13 Young Han Lee <joybro@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281
syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
- animations/animation-direction-normal-expected.png: Added.
- animations/animation-direction-normal-expected.txt: Added.
- animations/animation-direction-normal.html: Added.
2011-06-13 Young Han Lee <joybro@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281
syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
Test: animations/animation-direction-normal.html
- platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimations):
- 8:28 AM Changeset in webkit [88640] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62429
- UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
- UIProcess/API/efl/PageClientImpl.h:
- 8:09 AM Changeset in webkit [88639] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-06-13 KwangHyuk Kim <hyuki.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
https://bugs.webkit.org/show_bug.cgi?id=62448
Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter
- ewk/ewk_tiled_model.c: (ewk_tile_new):
- ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
- 7:58 AM Changeset in webkit [88638] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62525
- UIProcess/efl/WebPreferencesEfl.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey):
- 7:28 AM Changeset in webkit [88637] by
-
- 3 edits6 adds in trunk
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
SVG animation did not take attribute 'patternTransform' into account. Added support for combination of
SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransformElement.
Tests: svg/animations/animateTransform-pattern-transform.html
svg/animations/animateTransform-transformable-transform.html
- svg/SVGAnimateTransformElement.cpp: (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
Test SVG animateTransform for attributes 'transform' and 'patternTransform'.
- svg/animations/animateTransform-pattern-transform-expected.txt: Added.
- svg/animations/animateTransform-pattern-transform.html: Added.
- svg/animations/animateTransform-transformable-transform-expected.txt: Added.
- svg/animations/animateTransform-transformable-transform.html: Added.
- svg/animations/script-tests/animateTransform-pattern-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/animateTransform-transformable-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
- 7:12 AM Changeset in webkit [88636] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 6:41 AM Changeset in webkit [88635] by
-
- 3 edits in trunk/Source/WebCore
2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
https://bugs.webkit.org/show_bug.cgi?id=62330
This patch is based on the draft patch by Noam Rosenthal in bug 60842.
Qt API autotests cover the bridge behavior and pass after this patch.
- bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types. In particular, we got rid of Strong<JSObject> members. Renamed some members and arguments to follow existing naming in QObject::connect().
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper function to create a connection, passing the ExecState* that will be used when the connection is activated (signal emitted). Use JSC API types when looking up the matching signal to disconnect.
(JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
protect the receiver and receiverFunction from being garbage
collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in current
code were Strong<>) anymore.
(JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
to use m_originalSender here. Unprotect values that we protected in constructor.
(JSC::Bindings::isJavaScriptFunction): Helper function to identify whether a
JSObjectRef is a JS function (in contrast to a native function exposed to JS).
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
Both updated to use JSC API when appliable. Note that convertQVariantToValue
still returns JSC internal types, will be handled in a different patch.
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
Convenince for the existing caller until it is converted to JSC as well.
- 2:35 AM Changeset in webkit [88634] by
-
- 9 edits1 copy1 add in trunk/Source
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827
- platform/ContextMenuItem.h: Add gtkAction().
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): Implement constructor that receives a platform menu. (WebCore::ContextMenu::setPlatformDescription): Make sure we don't destroy the menu if the new context menu is the current one. (WebCore::contextMenuItemVector): Implement this method to return the list of menu items in the given context menu, required by WebKit2. (WebCore::platformMenuDescription): Implement this method to return a platform menu for the given menu items.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::createPlatformMenuItemDescription): Helper function to create a platform context menu item. (WebCore::ContextMenuItem::ContextMenuItem): Use createPlatformMenuItemDescription(). (WebCore::ContextMenuItem::title): Convert the title from UTF-8. (WebCore::ContextMenuItem::setTitle): Use gtkAction(). (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu() that receives a list of items. (WebCore::ContextMenuItem::setChecked): Use gtkAction(). (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2. (WebCore::ContextMenuItem::enabled): Ditto. (WebCore::ContextMenuItem::setEnabled): Use gtkAction(). (WebCore::ContextMenuItem::gtkAction): Return the GtkAction associated to the context menu item.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createContextMenuProxy): Create a context menu proxy.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (globalPointForClientPoint): Function copied from webkit1 to convert a point in widget coordinates to global coordinates. (popupMenuPositionFunction): (webkitWebViewBaseShowContextMenu): Show the given context menu at the given position.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added. (WebKit::contextMenuItemActivatedCallback): (WebKit::WebContextMenuProxyGtk::createGtkMenu): (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
- UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h. (WebKit::WebContextMenuProxyGtk::create):
- 2:03 AM Changeset in webkit [88633] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py
2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>
Fix mistake I made in 88632
- 2:00 AM Changeset in webkit [88632] by
-
- 3 edits in trunk
2011-06-13 Keishi Hattori <keishi@webkit.org>
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 1:56 AM Changeset in webkit [88631] by
-
- 10 edits5 adds in trunk
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
- GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
- webkit/webkitwebview.h: Move declarations common to WebKit2 to webkitwebviewcommon.h.
- webkit/webkitwebviewcommon.h: Added.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
Add first implementation of WebKitWebView, a class with the same
API than webkit1, that wraps the C API to provide a high level
WebKit2 API for GTK port.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebView.cpp: Added. (webkit_web_view_init): (webkit_web_view_class_init): (webkit_web_view_new): (webkit_web_view_load_uri): (webkit_web_view_go_back): (webkit_web_view_go_forward):
- UIProcess/API/gtk/WebKitWebView.h: Added.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreate): (webkitWebViewBaseCreateWebPage):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/webkit/webkit.h: Added.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
code, but linking to libwebkit2gtk.
- GNUmakefile.am:
- GtkLauncher/main.c: (createBrowser): (main):
Jun 12, 2011:
- 11:38 PM Changeset in webkit [88630] by
-
- 10 edits in trunk
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- platform/mac-wk2/Skipped:
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- WebKit.vcproj/WebKit.sln:
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 11:20 PM Changeset in webkit [88629] by
-
- 2 edits in trunk/Source/WebCore
2011-06-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507
No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.
If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
- dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
- 10:15 PM Changeset in webkit [88628] by
-
- 41 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
- loader/FrameLoaderClient.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/MainResourceLoader.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
- src/FrameLoaderClientImpl.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientEfl.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientGtk.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientHaiku.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientQt.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
- WebFrame.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientWinCE.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
- WebKitSupport/FrameLoaderClientWx.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebProcess/WebCoreSupport/WebErrors.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
- 9:55 PM Changeset in webkit [88627] by
-
- 5 edits2 adds in trunk
2011-06-12 Hironori Bono <hbono@chromium.org>
Reviewed by Hajime Morita.
Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526
This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().
- editing/spelling/spellcheck-api-crash-expected.txt: Added.
- editing/spelling/spellcheck-api-crash.html: Added.
2011-06-12 Hironori Bono <hbono@chromium.org>
Reviewed by Hajime Morita.
Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526
This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().
Test: editing/spelling/spellcheck-api-crash.html
- html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
- 9:13 PM Changeset in webkit [88626] by
-
- 5 edits in trunk
2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Antonio Gomes.
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Implements LayoutController.setTextDirection.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Antonio Gomes.
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Unskipping fast/html/set-text-direction.html.
- platform/qt/Skipped:
- 8:05 PM Changeset in webkit [88625] by
-
- 10 edits in trunk
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
Test: fast/harness/internals-object.html
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 7:17 PM Changeset in webkit [88624] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-12 Adam Barth <abarth@webkit.org>
Attempt to fix Qt build.
- WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
- 7:05 PM Changeset in webkit [88623] by
-
- 8 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
DocumentParser::appendBytes should use size_t for length instead of int
https://bugs.webkit.org/show_bug.cgi?id=62508
size_t is the proper type for distances in memory, especially on 64 bit
machines.
- dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
- dom/DecodedDataDocumentParser.h:
- dom/DocumentParser.h:
- html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
- html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
- 7:03 PM Changeset in webkit [88622] by
-
- 14 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.
This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
- loader/FrameLoader.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
- 4:34 PM Changeset in webkit [88621] by
-
- 3 edits in trunk/Source/WebKit/gtk
2011-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove webkit_web_view_get_selected_text
https://bugs.webkit.org/show_bug.cgi?id=62512
It's no longer used and it's a private method, so it can be
removed.
- webkit/webkitwebview.cpp: kill it.
- webkit/webkitwebviewprivate.h: ditto.
- 2:24 PM Changeset in webkit [88620] by
-
- 5 edits in trunk
2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517
It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).
- platform/qt/Skipped:
2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517
It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 1:01 PM Changeset in webkit [88619] by
-
- 2 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Fix fullscreen/full-screen-iframe-legacy.html.
- html/HTMLVideoElement.idl:
- 12:21 PM Changeset in webkit [88618] by
-
- 21 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.
- webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
- loader/FrameLoader.h:
- cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
- loader/MainResourceLoader.h:
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
- loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
- loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
- 11:27 AM Changeset in webkit [88617] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557
Reviewed by Darin Adler.
Replaced the fix for bug 58500 with a refined version.
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.
- 10:23 AM Changeset in webkit [88616] by
-
- 5 edits in trunk
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Reviewed by Antonio Gomes.
Tools:
Implements LayoutController.setTextDirection.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setTextDirection):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
Unskipping fast/html/set-text-direction.html.
- platform/qt/Skipped:
- 9:57 AM Changeset in webkit [88615] by
-
- 4 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
Minor user-gesture related cleanup
https://bugs.webkit.org/show_bug.cgi?id=62511
In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.
- bindings/v8/NPV8Object.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLVideoElement.idl:
- 7:52 AM Changeset in webkit [88614] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-06-12 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Build fix for !ENABLE(JIT) after r88604.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- 5:40 AM Changeset in webkit [88613] by
-
- 11 edits in trunk/Source/WebCore
2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add TextRun charactersLength member
https://bugs.webkit.org/show_bug.cgi?id=62501
Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).
This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.
- platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
- platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
- platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer
that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.
(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):
- platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
- rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
- rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
- 4:51 AM Changeset in webkit [88612] by
-
- 5 edits13 adds in trunk
2011-06-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221
Our expectations for the unskipped tests have the following differences from the mac
platform:
- POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
- DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
- platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html
http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
- platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
2011-06-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest
(WebCore::QNetworkReplyHandler::getIODevice): ditto
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
- If a custom HTTP operation contains data, send it.
- platform/network/qt/QNetworkReplyHandler.h:
