Context Navigation

added Internals::createShadowContentElement(), which creates, ShadowContentElement instance which includes all host children,
added Internals::elementRenderTreeAsText() to help content layout testing, and
Unabstracted ShadowContentElement by giving a default shouldInclude() implementation.

Test: fast/dom/shadow/create-content-element.html

WebCore.exp.in:
dom/ShadowContentElement.cpp: (WebCore::ShadowContentElement::create): Added. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::~ShadowContentElement): (WebCore::ShadowContentElement::shouldInclude): Gave a default implementation which always returns true.
dom/ShadowContentElement.h:
html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement):
rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Factored out for supportin per-element render tree dump.
rendering/RenderTreeAsText.h:
testing/Internals.cpp: (WebCore::Internals::createShadowContentElement): Added. (WebCore::Internals::elementRenderTreeAsText): dded.
testing/Internals.h:
testing/Internals.idl:

2011-06-19 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

The internals object should have createShadowContentElement()
https://bugs.webkit.org/show_bug.cgi?id=62432

win/WebKit2.def: Added some more symbols necessary for window.internals to function to the global symbol list.

9:47 PM Changeset in webkit [89229] by keishi@webkit.org

3 edits
2 adds in trunk

2011-06-19 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262

fast/forms/checkbox-click-indeterminate-expected.txt: Added.
fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.

2011-06-19 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262

Test: fast/forms/checkbox-click-indeterminate.html

html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.

8:50 PM Changeset in webkit [89228] by oliver@apple.com

5 edits in trunk

2011-06-19 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Correct logic for putting errors on the correct line when handling JSONP
https://bugs.webkit.org/show_bug.cgi?id=62962

Add test case this time

fast/js/parser-syntax-check-expected.txt:
fast/js/script-tests/parser-syntax-check.js:

2011-06-19 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Correct logic for putting errors on the correct line when handling JSONP
https://bugs.webkit.org/show_bug.cgi?id=62962

Minor fix for the minor fix. *sigh*

interpreter/Interpreter.cpp: (JSC::Interpreter::execute):

8:05 PM Changeset in webkit [89227] by commit-queue@webkit.org

8 edits in trunk

2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394

configure.ac:

2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394

Unskipped the Media Stream tests.

platform/gtk/Skipped:

2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394

GNUmakefile.am:

2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394

Scripts/build-webkit:

7:57 PM Changeset in webkit [89226] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Minor fix to correct layout test results.

7:44 PM Changeset in webkit [89225] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-06-19 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

DEPS:

7:26 PM Changeset in webkit [89224] by mrowe@apple.com

25 edits in trunk/Source/WebCore

Roll out r89223 since it appears to have broken all of the builds.

2:07 PM Changeset in webkit [89223] by Darin Adler

25 edits in trunk/Source/WebCore

2011-06-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955

dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
dom/DataTransferItem.h:
dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
dom/DataTransferItems.h:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
editing/CompositeEditCommand.h:
inspector/InspectorConsoleInstrumentation.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl):
inspector/InspectorInstrumentation.h:
inspector/InspectorProfilerAgent.h:
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::inspectorStyleForId): (WebCore::InspectorStyleSheet::rememberInspectorStyle):
inspector/InspectorStyleSheet.h:
page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
page/WebKitAnimationList.h:
svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
svg/graphics/filters/SVGFEImage.h:
svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
svg/graphics/filters/SVGFilterBuilder.h:
websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
websockets/ThreadableWebSocketChannelClientWrapper.h:
websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
websockets/WorkerThreadableWebSocketChannel.h: Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.

1:48 PM Changeset in webkit [89222] by krit@webkit.org

2 edits in trunk/LayoutTests

2011-06-19 Dirk Schulze <krit@webkit.org>

Uneviewed.

SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938

Add animation tests of previous patch to skip list for webkit2.

platform/mac-wk2/Skipped:

1:48 PM Changeset in webkit [89221] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-06-19 Una Sabovic <una.sabovic@palm.com>

Reviewed by Darin Adler.

Optimization: avoid call to clearRect() when bgColor is valid when painting the root background in RenderBoxModelObject::paintFillLayerExtended
https://bugs.webkit.org/show_bug.cgi?id=62908

When root layers base color is fully transparent backgroundRect was cleared before bgColor is applied.
Instead of clearing the rect we apply CompositeCopy operation when painting the background color.

No new tests. This is an optimization, it doesn't change any existing functionality.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRect):
platform/graphics/GraphicsContext.h:
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):

1:11 PM Changeset in webkit [89220] by krit@webkit.org

14 edits
11 adds in trunk

2011-06-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumber. With the new animator for the
With the new animator for SVGNumber we also support the scientific notation, and everything else that's supported by
the SVGNumber parsing, removing the SVGAnimate* specific number parsing functionality.

Moving the content of SVGAnimatedType header into its own cpp.

Changed behavior of parseNumberFromString(). It checks if the String simply consits of a number now. parseNumberFromString()
is using genericParseNumber() for parsing numbers. But this method just stops at the first char that does not belong to a number and
returns true. I added a check if the current char pointer is at the last char of the String and return false if not.

Tests: svg/animations/svgnumber-animation-1.html

svg/animations/svgnumber-animation-2.html
svg/animations/svgnumber-animation-3.html

CMakeLists.txt: Added new files to build system.
GNUmakefile.list.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
svg/SVGAllInOne.cpp: Ditto.
svg/SVGAnimateElement.cpp: Use SVGAnimatedNumberAnimator for animations of SVGNumbers. (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
svg/SVGAnimateElement.h: Remove floats for value storage. This is done by SVGAnimatedTypes now.
svg/SVGAnimatedNumber.cpp: Added. Animator for SVGNumbers. (WebCore::SVGAnimatedNumberAnimator::SVGAnimatedNumberAnimator): (WebCore::SVGAnimatedNumberAnimator::constructFromString): (WebCore::SVGAnimatedNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberAnimator::calculateDistance):
svg/SVGAnimatedNumber.h: (WebCore::SVGAnimatedNumberAnimator::~SVGAnimatedNumberAnimator):
svg/SVGAnimatedType.cpp: Added. Moved content from header to cpp. (WebCore::SVGAnimatedType::SVGAnimatedType): (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createAngle): (WebCore::SVGAnimatedType::createLength): (WebCore::SVGAnimatedType::createNumber): (WebCore::SVGAnimatedType::angle): (WebCore::SVGAnimatedType::length): (WebCore::SVGAnimatedType::number): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
svg/SVGAnimatedType.h: Removed method create(). Allways call type specific create funtcions.
svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
svg/SVGParserUtilities.cpp: (WebCore::parseNumberFromString): Check if String simply consits of a number. Return false otherwise.

2011-06-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938

Added new tests to check behavior on SVGNumber animation.

svg/animations/script-tests/svgnumber-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/svgnumber-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/svgnumber-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/svgnumber-animation-1-expected.txt: Added.
svg/animations/svgnumber-animation-1.html: Added.
svg/animations/svgnumber-animation-2-expected.txt: Added.
svg/animations/svgnumber-animation-2.html: Added.
svg/animations/svgnumber-animation-3-expected.txt: Added.
svg/animations/svgnumber-animation-3.html: Added.

12:47 PM Changeset in webkit [89219] by oliver@apple.com

9 edits in trunk/Source/JavaScriptCore

2011-06-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920

JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will

only be run once, so the vast amount of logic we dump to handle caching of accesses is unnecessary.
We are doing codegen that is directly proportional to just creating the object in the first place.

This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.

API/JSValueRef.cpp: (JSValueMakeFromJSONString):
interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::execute):
parser/Lexer.cpp: (JSC::Lexer::isKeyword):
parser/Lexer.h:
runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
runtime/JSONObject.cpp: (JSC::JSONProtoFuncParse):
runtime/LiteralParser.cpp: (JSC::LiteralParser::tryJSONPParse): (JSC::LiteralParser::makeIdentifier): (JSC::LiteralParser::Lexer::lex): (JSC::LiteralParser::Lexer::next): (JSC::isSafeStringCharacter): (JSC::LiteralParser::Lexer::lexString): (JSC::LiteralParser::Lexer::lexNumber): (JSC::LiteralParser::parse):
runtime/LiteralParser.h: (JSC::LiteralParser::LiteralParser): (JSC::LiteralParser::tryLiteralParse): (JSC::LiteralParser::Lexer::Lexer):

11:32 AM Changeset in webkit [89218] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

2011-06-19 Stephen White <senorblanco@chromium.org>

Unreviewed.

Marking several tests as crashing on Mac GPU.

platform/chromium/test_expectations.txt:

11:16 AM Changeset in webkit [89217] by senorblanco@chromium.org

4 edits in trunk/Tools

2011-06-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89198.
http://trac.webkit.org/changeset/89198
https://bugs.webkit.org/show_bug.cgi?id=62953

Chromium breakage on "Linux Tests" (Requested by senorblanco
on #webkit).

Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

10:00 AM Changeset in webkit [89216] by Dimitri Glazkov

49 edits
2 copies in trunk/Source

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

Loading an icon and choosing files have similar async nature, but completely different
lifetimes: FileChooser should only exist when we are actually attempting to choose a file,
not anytime we need to render an input with a proper icon.

This patch introduces FileIconLoader, a separate abstraction for loading an icon, and removes
any notion of an icon from the FileChooser.

Also, the loaded icon is now stored on the RenderFileUploadControl, which better matches its
purpose.

Refactoring, covered by existing tests.

CMakeLists.txt: Added FileIconLoader to build system.
GNUmakefile.list.am: Ditto.
WebCore.exp.in: Updated.
WebCore.gypi: Added FileIconLoader to build system.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
loader/EmptyClients.h: Updated. (WebCore::EmptyChromeClient::loadIconForFiles): Renamed function to better reflect what it does.
page/Chrome.cpp: (WebCore::Chrome::loadIconForFiles): Ditto.
page/Chrome.h: Ditto.
page/ChromeClient.h: Ditto.
platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Removed now-unnecessary bool. (WebCore::FileChooser::create): Removed the tangled web. (WebCore::FileChooser::clear): Removed icon-related code. (WebCore::FileChooser::chooseFiles): Ditto.
platform/FileChooser.h:
platform/FileIconLoader.cpp: Copied from Source/WebCore/platform/FileChooser.cpp. (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Added. (WebCore::FileIconLoader::create): Added. (WebCore::FileIconLoader::disconnectClient): Added. (WebCore::FileIconLoader::notifyFinished): Added. (WebCore::FileIconLoader::FileIconLoader): Added.
platform/FileIconLoader.h: Copied from Source/WebCore/platform/FileChooser.cpp.
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Added new member initializations. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Added FileIconLoader disconnect.s (WebCore::RenderFileUploadControl::requestIcon): Added a helper. (WebCore::RenderFileUploadControl::valueChanged): Changed to request an icon load. (WebCore::RenderFileUploadControl::updateRendering): Added implementation of FileIconLoaderClient func. (WebCore::RenderFileUploadControl::updateFromElement): Added clearing of icon. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use new member directly. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
rendering/RenderFileUploadControl.h: Updated decls.

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::loadIconForFiles): Renamed to better reflect the intent.
src/ChromeClientImpl.h: Ditto.
src/WebIconLoadingCompletionImpl.cpp: (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): Changed to use FileIconLoader. (WebKit::WebIconLoadingCompletionImpl::didLoadIcon): Ditto.
src/WebIconLoadingCompletionImpl.h: Dito.

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::loadIconForFiles): Renamed.
WebCoreSupport/ChromeClientEfl.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::loadIconForFiles): Renamed.
WebCoreSupport/ChromeClientGtk.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::loadIconForFiles): Renamed.
WebCoreSupport/ChromeClientHaiku.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::loadIconForFiles): Renamed.

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::loadIconForFiles): Renamed.
WebCoreSupport/ChromeClientQt.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::loadIconForFiles): Renamed.
WebCoreSupport/WebChromeClient.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebCoreSupport/ChromeClientWinCE.cpp: (WebKit::ChromeClientWinCE::loadIconForFiles): Renamed.
WebCoreSupport/ChromeClientWinCE.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles): Renamed.
WebKitSupport/ChromeClientWx.h:

2011-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::loadIconForFiles): Renamed.
WebProcess/WebCoreSupport/WebChromeClient.h:

6:42 AM Changeset in webkit [89215] by dbates@webkit.org

1 edit in trunk/Tools/ChangeLog

2011-06-19 Daniel Bates <dbates@webkit.org>

Fix change log entry; Change "should use password", "Git.push_local_commits_to_server"
to "should use passed" and "Git.push_local_commits_to_server()", respectively,
in the bug title for changeset 89209 <http://trac.webkit.org/changeset/89209>. Now
the bug title makes sense.

5:55 AM Changeset in webkit [89214] by msaboff@apple.com

2 edits in trunk/Source/WebCore

2011-06-19 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Add notify handler to trigger MemoryPressureHandler in all builds
https://bugs.webkit.org/show_bug.cgi?id=62679

Removed SIGUSR2 trigger and added a notify trigger for the
MemoryPressureHandler. The notify trigger is enabled for all builds.

No test added as only added new memory pressure trigger.

platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::install):

3:53 AM Changeset in webkit [89213] by robert@webkit.org

4 edits in trunk

2011-06-19 Robert Hogan <robert@webkit.org>

Reviewed by Alexey Proskuryakov.

[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514

platform/qt/Skipped: Unskip http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

2011-06-19 Robert Hogan <robert@webkit.org>

Reviewed by Alexey Proskuryakov.

[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514

platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::willSendRequest):

Jun 18, 2011:

10:48 PM WebKit Team edited by abarth@webkit.org

(diff)

9:13 PM Changeset in webkit [89212] by commit-queue@webkit.org

15 edits in trunk

2011-06-18 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766

fast/events/touch/document-create-touch-expected.txt:
fast/events/touch/script-tests/document-create-touch.js:

2011-06-18 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766

dom/Document.cpp: (WebCore::Document::createTouch):
dom/Document.h:
dom/Document.idl:
dom/Touch.cpp: (WebCore::Touch::Touch):
dom/Touch.h: (WebCore::Touch::create): (WebCore::Touch::webkitForce):
dom/Touch.idl:
page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::force):

2011-06-18 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766

public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
src/WebInputEventConversion.cpp: (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):

8:44 PM Changeset in webkit [89211] by commit-queue@webkit.org

4 edits
1 copy
5 adds in trunk/Source/WebKit2

2011-06-18 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Sam Weinig.

[EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent, NativeWebWheelEvent and NativeWebKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=61993

Add native mouse and keyboard event classes to convert EFL's events to NativeWebEvent.

Shared/NativeWebKeyboardEvent.h: (WebKit::NativeWebKeyboardEvent::nativeEvent):
Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
Shared/NativeWebWheelEvent.h: (WebKit::NativeWebWheelEvent::nativeEvent):
Shared/efl/NativeWebKeyboardEventEfl.cpp: Added. (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
Shared/efl/NativeWebMouseEventEfl.cpp: Added. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
Shared/efl/NativeWebWheelEventEfl.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
Shared/efl/WebEventFactory.cpp: Added. (WebKit::modifiersForEvent): (WebKit::buttonForEvent): (WebKit::clickCountForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
Shared/efl/WebEventFactory.h: Added.

8:42 PM Changeset in webkit [89210] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

2011-06-18 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Sam Weinig.

[EFL][WK2] Add missing functions of EFL port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62711

Three functions are added in the PageClient.h, so add them to the EFL's PageClientImpl.

UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::screenToWindow): (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
UIProcess/API/efl/PageClientImpl.h:

6:55 PM Changeset in webkit [89209] by dbates@webkit.org

3 edits in trunk/Tools

2011-06-18 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

Git.push_local_commits_to_server should use password username and
password when we don't have cached credentials
https://bugs.webkit.org/show_bug.cgi?id=62941

Fixes a issue where Git.push_local_commits_to_server() would always look
for cached credentials regardless of whether a username and password
were passed as arguments. Instead, if given both a username and password
then we shouldn't look for cached credentials (since we were explicitly given
credentials).

Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.

5:41 PM Changeset in webkit [89208] by dbates@webkit.org

2 edits in trunk/Tools

2011-06-18 Daniel Bates <dbates@rim.com>

Rubber-stamped by Eric Seidel.

Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
https://bugs.webkit.org/show_bug.cgi?id=62767

Part 3 of 3

Remove the command-line option --skip-build now that the master BuildBot has been restarted
following <http://trac.webkit.org/changeset/89138>.

Instead, specify --no-build to get analogous functionality.

Scripts/run-javascriptcore-tests:

2:04 PM Changeset in webkit [89207] by andrew@webkit.org

2 edits in trunk/Source/WebKit/mac

2011-06-18 Andrew Wellington <andrew@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=62843
WebKit Mac API calls didReceiveAuthenticationChallenge instead of
didCancelAuthenticationChallenge

WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]):

1:36 PM Changeset in webkit [89206] by dpranke@chromium.org

5 edits in trunk/Tools

2011-06-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: fix test sorting
https://bugs.webkit.org/show_bug.cgi?id=58691

This changes the sorting to use a "natural" sort order such that
foo2.html sorts before foo13.html, and sorts the tests so
that all the tests in a directory are run before any test in a
subdirectory.

This change also adds a split() method to the filesystem since
that is needed to cluster files into a directory otherwise.

Scripts/webkitpy/common/system/filesystem.py:
Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/layout_tests/layout_package/manager.py:
Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:

1:34 PM Changeset in webkit [89205] by jer.noble@apple.com

5 edits in trunk/Source/WebCore

2011-06-18 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Rename Document::setContainsFullScreenElementRecursively
https://bugs.webkit.org/show_bug.cgi?id=62528

No new tests; no net change in functionality, so this is covered by existing tests.

The name of setContainsFullScreenElementRecursively is confusing, since it doesn't actually use
recursion, and it walks the ancestor tree instead of the descendent tree (as recursive might
otherwise imply). Move the function into Element, turn it into a member function, and change
the behavior so that the function operates on the called object's parents (as opposed to the
object itself).

dom/Element.h:
dom/Element.cpp: (WebCore::parentCrossingFrameBoundaries): Added. (WebCore::Element::setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries): Renamed and

moved from Document.

(WebCore::Element::willRemove): Use the newly renamed function.
(WebCore::Element::insertedIntoTree): Ditto.

dom/Document.h:
dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::fullScreenElementRemoved): Ditto.

1:27 PM Changeset in webkit [89204] by commit-queue@webkit.org

8 edits
2 adds in trunk

2011-06-18 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Chris Fleizach.

Accessibility description for an element should make use of aria-labelledby.
https://bugs.webkit.org/show_bug.cgi?id=61995

accessibility/aria-labelledby-on-input.html:
accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
accessibility/aria-labelledby-overrides-aria-label.html: Added.
accessibility/aria-labelledby-overrides-label-expected.txt:
accessibility/aria-labelledby-overrides-label.html:
accessibility/aria-labelledby-stay-within.html:
platform/mac/accessibility/aria-labelledby-on-input-expected.txt:

2011-06-18 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Chris Fleizach.

Accessibility description for an element should make use of aria-labelledby.
https://bugs.webkit.org/show_bug.cgi?id=61995

Tests: accessibility/aria-labelledby-overrides-aria-label.html

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::title): Don't return value from aria-labelledby. (WebCore::AccessibilityRenderObject::ariaAccessibilityDescription): Return value from aria-labelledby in preference to value from aria-label.

1:18 PM Changeset in webkit [89203] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

2011-06-18 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Tony Gentilcore.

Media Stream no-interface-object test should not have ReferenceError message in expected results
https://bugs.webkit.org/show_bug.cgi?id=60391

Fixed no-interface-object test to not include ReferenceError message in expected results

fast/dom/MediaStream/no-interface-object-expected.txt:
fast/dom/MediaStream/script-tests/no-interface-object.js: (shouldThrowReferenceError): (test):

1:10 PM Changeset in webkit [89202] by evan@chromium.org

2 edits in trunk/Tools

2011-06-18 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Compiler warning in double->int conversion in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=51554

This code is providing a JS API for removing a property by numeric ID.
We get it from JS as a double, and must convert it to an int before using it.

Test: LayoutTests/plugins/npruntime/remove-property.html

DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: (NPRuntimeRemoveProperty::TestObject::invoke):

1:03 PM Changeset in webkit [89201] by Patrick Gansterer

2 edits in trunk/Tools

2011-06-18 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Don't exit webkit-patch when running on Win32 python
https://bugs.webkit.org/show_bug.cgi?id=55811

Most of the basic actions work in the meantime,
so let people play with in on Win32 now.

Scripts/webkit-patch:

12:53 PM Changeset in webkit [89200] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-06-18 Christoph Mende <mende.christoph@gmail.com>

Reviewed by Darin Adler.

compilation fails with libpng-1.5
https://bugs.webkit.org/show_bug.cgi?id=61738

platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::writeOutput): Use getter function instead of direct access

12:52 PM Changeset in webkit [89199] by jeremy@chromium.org

3 edits
2 adds in trunk

2011-06-18 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Set text-align:-webkit-match-parent for li elements in the default style sheet.
https://bugs.webkit.org/show_bug.cgi?id=57232

fast/css/list-item-text-align-expected.txt: Added.
fast/css/list-item-text-align.html: Added.

2011-06-18 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Set text-align:-webkit-match-parent for li elements in the default style sheet.
https://bugs.webkit.org/show_bug.cgi?id=57232

Test: fast/css/list-item-text-align.html

css/html.css: (li): Specify text-align:-webkit-match-parent .

12:45 PM Changeset in webkit [89198] by commit-queue@webkit.org

4 edits in trunk/Tools

2011-06-18 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

12:43 PM Changeset in webkit [89197] by commit-queue@webkit.org

10 edits in trunk/Source

2011-06-18 Holger Hans Peter Freyther <holger@moiji-mobile.com>

Reviewed by Brent Fulgham.

[misc] JSC/wtf/text/*.h should not be included via #include ""
https://bugs.webkit.org/show_bug.cgi?id=60836

Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.

CMakeListsEfl.txt: Remove JavaScriptCore/wtf/text.
CMakeListsWinCE.txt: Remove JavaScriptCore/wtf/text.
platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h include.
platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include.
platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h include.

2011-06-18 Holger Hans Peter Freyther <holger@moiji-mobile.com>

Reviewed by Brent Fulgham.

[misc] JSC/wtf/text/*.h should not be included via #include ""
https://bugs.webkit.org/show_bug.cgi?id=60836

Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.

WebEdit.cpp: Include file via <wtf/text/File.h>.

12:33 PM Changeset in webkit [89196] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-06-18 Berend-Jan Wever <skylined@chromium.org>

Reviewed by Eric Seidel.

Some names with spaces are incorrectly reported as not containing spaces
while running prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=55572

Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow non-alphanumeric characters in names.

12:24 PM Changeset in webkit [89195] by msaboff@apple.com

1 edit
1 add in trunk/Tools

2011-06-18 Michael Saboff <msaboff@apple.com>

Reviewed by Eric Seidel.

Enhancement: New Script to Format malloc_history output as tree
https://bugs.webkit.org/show_bug.cgi?id=56378

New script to process malloc_history output to tree format.

Scripts/malloc-tree: Added.

11:50 AM Changeset in webkit [89194] by weinig@apple.com

8 edits in trunk/Source/WebCore

REGRESSION (r63854-63958): placeholder not shown for number inputs
https://bugs.webkit.org/show_bug.cgi?id=61095

Reviewed by Darin Adler.

Refactor HTMLInputElement supportsPlaceholder support to delegate to the
InputType. Make BaseTextInputType and NumberInputType return true, matching
the current HTML5 spec.

html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::supportsPlaceholder):

html/BaseTextInputType.h:

Add override implementation of supportsPlaceholder that returns true.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::supportsPlaceholder):
Delegate to the InputType.

html/InputType.cpp:

(WebCore::InputType::supportsPlaceholder):

html/InputType.h:

Add base implementation of supportsPlaceholder that returns false.

html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsPlaceholder):

html/NumberInputType.h:

Add override implementation of supportsPlaceholder that returns true.

2:01 AM Changeset in webkit [89193] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

platform/qt-mac/Skipped:

1:47 AM Changeset in webkit [89192] by commit-queue@webkit.org

9 edits in trunk/Source/JavaScriptCore

2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89184.
http://trac.webkit.org/changeset/89184
https://bugs.webkit.org/show_bug.cgi?id=62927

It broke 22 tests on all bot (Requested by Ossy_weekend on
#webkit).

API/JSValueRef.cpp: (JSValueMakeFromJSONString):
interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::execute):
parser/Lexer.cpp:
parser/Lexer.h:
runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
runtime/JSONObject.cpp: (JSC::JSONProtoFuncParse):
runtime/LiteralParser.cpp: (JSC::LiteralParser::Lexer::lex): (JSC::isSafeStringCharacter): (JSC::LiteralParser::Lexer::lexString): (JSC::LiteralParser::Lexer::lexNumber): (JSC::LiteralParser::parse):
runtime/LiteralParser.h: (JSC::LiteralParser::LiteralParser): (JSC::LiteralParser::tryLiteralParse): (JSC::LiteralParser::Lexer::Lexer): (JSC::LiteralParser::Lexer::next):

1:42 AM Changeset in webkit [89191] by commit-queue@webkit.org