Timeline
Jun 22, 2011:
- 11:58 PM Changeset in webkit [89540] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-06-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaseline chromium expectation.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:46 PM Changeset in webkit [89539] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[UNIX] Increment/decrement module load conter in NetscapePluginModule::getPluginInfo()
https://bugs.webkit.org/show_bug.cgi?id=63150
Since the method is static, we are using
NetscapePluginModule::getOrCreate() to get the module. If it's
created, the load counter is 0, so that when module is deleted,
shutdown() hasn't been called and the destructor crashes in the
assert that checks the module has been removed from the
initialized module list. We should increment the load counter, and
decrement it before getPluginInfo() returns, so that
decrementLoadCount() will call shutdown() if counter is 0 and the
module will be deleted from the list.
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::NetscapePluginModule::getPluginInfo):
- 11:46 PM Changeset in webkit [89538] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium expectations update.
- platform/chromium/test_expectations.txt:
- 11:44 PM Changeset in webkit [89537] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs
https://bugs.webkit.org/show_bug.cgi?id=63149
NetscapePlugin::fromNPP() shouldn't be called with a null npp, it
contains an assert that make it crash when building with debug enabled.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue):
- 11:31 PM Changeset in webkit [89536] by
-
- 14 edits8 adds3 deletes in trunk
2011-06-22 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
Convert SVGPointList to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63171
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGPointList.
Added support for from-by animations of SVGPointLists.
Tests: svg/animations/svgpointlist-animation-1.html
svg/animations/svgpointlist-animation-2.html
- CMakeLists.txt: Added new files to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Added SVGAnimatedPointList.cpp
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
- svg/SVGAnimateElement.h:
- svg/SVGAnimatedPointList.cpp: Added. (WebCore::SVGAnimatedPointListAnimator::SVGAnimatedPointListAnimator): (WebCore::SVGAnimatedPointListAnimator::constructFromString): (WebCore::SVGAnimatedPointListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPointListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPointListAnimator::calculateDistance):
- svg/SVGAnimatedPointList.h: Added. (WebCore::SVGAnimatedPointListAnimator::~SVGAnimatedPointListAnimator):
- svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPointList): (WebCore::SVGAnimatedType::pointList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
2011-06-22 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
Convert SVGPointList to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63171
Renamed test animate-points to svgpointlist-animation-1 and cleaned it up.
svgpointlist-animation-2 checks from-by animations of SVGPointLists.
- svg/animations/animate-points-expected.txt: Removed.
- svg/animations/animate-points.html: Removed.
- svg/animations/script-tests/animate-points.js: Removed.
- svg/animations/script-tests/svgpointlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svgpointlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svgpointlist-animation-1-expected.txt: Added.
- svg/animations/svgpointlist-animation-1.html: Added.
- svg/animations/svgpointlist-animation-2-expected.txt: Added.
- svg/animations/svgpointlist-animation-2.html: Added.
- 11:04 PM Changeset in webkit [89535] by
-
- 10 edits in trunk/Source/WebCore
2011-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Move file-choosing and icon-loading management to FileInputType
https://bugs.webkit.org/show_bug.cgi?id=62069
1) Moved the duties of FileChooserClient and FileIconLoaderClient from
RenderFileUploadControl to FileInputType, along with all of the
supporting functions.
2) Moved Icon ownership to FileInputType and exposed accessor on
HTMInputElement to allow RenderFileUploadControl to query current icon.
As a result, RenderFileUploadControl is now completely stateless, which is
neat and clean.
Refactoring, covered by existing tests.
- html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Moved logic here from RenderFileUploadControl. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto. (WebCore::FileInputType::receiveDropForDirectoryUpload): Ditto. (WebCore::FileInputType::updateRendering): Ditto. (WebCore::FileInputType::chrome): Ditto. (WebCore::FileInputType::receiveDroppedFiles): Ditto. (WebCore::FileInputType::icon): Added.
- html/FileInputType.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer): Updated comment. (WebCore::HTMLInputElement::receiveDroppedFiles): Added to replace setFileListFromRenderer. (WebCore::HTMLInputElement::icon): Added.
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::InputType::receiveDroppedFiles): Added. (WebCore::InputType::icon): Added.
- html/InputType.h:
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Changed to use HTMLInputElement. Ahh, nice and clean!
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed code that is no longer necessary. (WebCore::RenderFileUploadControl::updateFromElement): Ditto. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use HTMLInputElement icon accessor. (WebCore::RenderFileUploadControl::paintObject): Ditto.
- rendering/RenderFileUploadControl.h:
- 11:00 PM Changeset in webkit [89534] by
-
- 4 edits in trunk/Source/WebCore
2011-06-22 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
Add NSError wrapper functions in ResourceError when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63155
Add wrapper functions to ResourceError when building with USE(CFNETWORK). We need to create
a new NSError in ResourceError::nsError() since Safari has category methods on NSError and
passing a CFErrorRef back does not work even though CFErrorRef/NSErrror are toll-free
bridged.
No tests because no change in functionality.
- WebCore.exp.in:
- platform/network/cf/ResourceError.h:
- platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::nsError): (WebCore::ResourceError::operator NSError *):
- 10:59 PM Changeset in webkit [89533] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium expectations update.
- platform/chromium/test_expectations.txt:
- 10:33 PM Changeset in webkit [89532] by
-
- 2 edits in trunk/Tools
2011-06-22 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
test-webkitpy --all errors out because scm_unittest.py can't find module checkout
https://bugs.webkit.org/show_bug.cgi?id=62943
Remove "from .checkout import Checkout" from scm_unittest.py since it's included
by Scripts/webkitpy/common/checkout/init.py.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- 10:25 PM Changeset in webkit [89531] by
-
- 1 copy in tags/Safari-534.49
New tag.
- 10:09 PM Changeset in webkit [89530] by
-
- 16 edits in trunk
2011-06-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Mark Rowe.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html
2011-06-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Mark Rowe.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- Configurations/WebCoreTestSupport.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
2011-06-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Mark Rowe.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Mark Rowe.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 9:54 PM Changeset in webkit [89529] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
[chromium] Remove calls to Position::deprecatedNode
https://bugs.webkit.org/show_bug.cgi?id=63226
Call containerNode instead of deprecatedNode.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType):
- 9:19 PM Changeset in webkit [89528] by
-
- 2 edits in branches/safari-534-branch/Source/WebKit2
Merge r89436.
- 9:18 PM Changeset in webkit [89527] by
-
- 2 edits in branches/safari-534-branch/Source/WebKit2
Merge r89398.
- 8:55 PM Changeset in webkit [89526] by
-
- 5 edits in trunk/Source/WebCore
2011-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient.
https://bugs.webkit.org/show_bug.cgi?id=63224
Refactoring, covered by existing tests.
- platform/FileIconLoader.cpp: (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Changed to discard loader. (WebCore::FileIconLoaderClient::newFileIconLoader): Added. (WebCore::FileIconLoaderClient::discardLoader): Added.
- platform/FileIconLoader.h: Updated defs.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed initialization of icon loader. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Remove discarding of loader. (WebCore::RenderFileUploadControl::requestIcon): Changed to use newFileIconLoader.
- rendering/RenderFileUploadControl.h: Updated defs.
- 8:49 PM Changeset in webkit [89525] by
-
- 2 edits in trunk/Source/WebCore
Another unreviewed build fix after r89472.
No new tests, just a build fix.
- rendering/svg/SVGResources.cpp:
- 8:26 PM Changeset in webkit [89524] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r89472.
No new tests, just a build fix.
- rendering/InlineBox.cpp:
- rendering/RenderCounter.cpp:
- 8:07 PM Changeset in webkit [89523] by
-
- 4 edits in trunk/Source/WebCore
2011-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Add a helper function to FileList to retrieve a list of filenames.
https://bugs.webkit.org/show_bug.cgi?id=63222
Refactoring, covered by existing tests.
- fileapi/FileList.cpp: (WebCore::FileList::filenames): Added.
- fileapi/FileList.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use newly added helper. (WebCore::RenderFileUploadControl::click): Ditto. (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
- 7:31 PM Changeset in webkit [89522] by
-
- 5 edits6 deletes in trunk
Lower HTML parser DOM depth limit to 2048
https://bugs.webkit.org/show_bug.cgi?id=63219
Reviewed by Adam Barth.
Source/WebCore:
Lower the default depth limit from 4096 to 2048. There isn't a good
reason to have such pathologically nested content, and by-and-large,
the rendering code is not setup to support it that well. Adding this
aggressive limit now will allow us to see if anything breaks in the
nightlies.
- page/Settings.h:
LayoutTests:
Update nest test to reflect new limit and remove tests that were
testing specific behaviors of the old parser.
- fast/parser/block-nesting-cap-expected.txt:
- fast/parser/block-nesting-cap-table-expected.txt: Removed.
- fast/parser/block-nesting-cap-table.html: Removed.
- fast/parser/element-nesting-cap-expected.txt: Removed.
- fast/parser/element-nesting-cap.html: Removed.
- fast/parser/script-tests/block-nesting-cap-table.js: Removed.
- fast/parser/script-tests/block-nesting-cap.js:
- fast/parser/script-tests/element-nesting-cap.js: Removed.
- 7:26 PM Changeset in webkit [89521] by
-
- 9 edits in trunk/Source/WebCore
2011-06-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Dimitri Glazkov.
Tighten type usage in the Shadow tree code
https://bugs.webkit.org/show_bug.cgi?id=63210
Refactoring only, no new test required.
- dom/Document.cpp: (WebCore::Document::buildAccessKeyMap):
- dom/Document.h: Changed the argument of buildAccessKeyMap to TreeScope.
- dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::removeShadowRoot):
- html/ColorInputType.cpp: (WebCore::ColorInputType::shadowColorSwatch):
- html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::shadowSelect):
- html/shadow/SliderThumbElement.cpp: (WebCore::sliderThumbElementOf): Use ShadowRoot for the previous call sites as this is what is returned by shadowRoot().
- dom/Node.cpp: (WebCore::traverseTreeAndMark): Renamed the parameter here as it is not expected to be a shadow object. Just the rootNode of our traversal.
- dom/ShadowRoot.h: Made attach() public as it is public in ContainerNode and we would do some casting to avoid the private attribute in ShadowRoot.
- 7:14 PM Changeset in webkit [89520] by
-
- 2 edits in trunk/Tools
2011-06-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107
itertools.chain.from_iterable is new in 2.6,
use itertools.chain(*list) for 2.5 compat.
- Scripts/webkitpy/tool/bot/irc_command.py:
- 7:09 PM Changeset in webkit [89519] by
-
- 1 edit1 add in trunk/LayoutTests
2011-06-22 Kent Tamura <tkent@chromium.org>
[Win] media/media-controls-clone.html failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63195
- platform/win/media/media-controls-clone-expected.txt: Added.
- 6:44 PM Changeset in webkit [89518] by
-
- 3 edits in trunk/Tools
2011-06-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make sheriff-bot robust against exceptions from commands
https://bugs.webkit.org/show_bug.cgi?id=63211
sheriff-bot was acting strange this afternoon.
We don't know if this will fix the cause, but
at least it adds some unit tests and catches
one possible cause.
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 6:43 PM Changeset in webkit [89517] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Remove comment about pages with frames not being page-cachable
https://bugs.webkit.org/show_bug.cgi?id=63207
This comment was out of date. Caching pages with Frames in
the PageCache has worked since 2009:
<http://webkit.org/b/13631> Page Cache should support pages with frames
- history/PageCache.cpp: (WebCore::PageCache::canCache):
- 6:36 PM Changeset in webkit [89516] by
-
- 7 edits in trunk/Source
2011-06-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
- wtf/Platform.h:
2011-06-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
No new tests. If this new flag was set by default, we could unskip
existing xmlviewer tests.
- CodeGenerators.pri:
- WebCore.pri:
- WebCore.pro:
- features.pri:
- 6:34 PM Changeset in webkit [89515] by
-
- 2 edits in trunk/Tools
<http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
Reviewed by David Levin.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
be relative to the built products directory rather than using a hard-coded path. Remove the
explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
rather than in the .xcodeproj directly.
- 6:27 PM Changeset in webkit [89514] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Yet another build fix after r89472.
- html/parser/HTMLFormattingElementList.cpp:
- 6:20 PM Changeset in webkit [89513] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Another build fix after r89472.
- dom/DocumentMarkerController.cpp:
- 6:17 PM Changeset in webkit [89512] by
-
- 10 edits in trunk/Tools
2011-06-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: remove obsolete port.shut_down_http_server method
https://bugs.webkit.org/show_bug.cgi?id=59993
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Scripts/webkitpy/layout_tests/port/qt.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- 6:15 PM Changeset in webkit [89511] by
-
- 3 edits1 move3 adds in trunk/LayoutTests
2011-06-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by James Robinson.
Fixing test spanOverlapsCanvas.html to properly use layer tree text and rebaselining test off that for windows and mac.
https://bugs.webkit.org/show_bug.cgi?id=63190
- compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
- compositing/layer-creation/spanOverlapsCanvas.html:
- platform/mac-snowleopard/compositing: Added.
- platform/mac-snowleopard/compositing/layer-creation: Added.
- platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
- platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
- platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- 6:10 PM Changeset in webkit [89510] by
-
- 2 edits in trunk/Tools
2011-06-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Andreas Kling.
Move macpherson from contributor list to committer list.
https://bugs.webkit.org/show_bug.cgi?id=63179
- Scripts/webkitpy/common/config/committers.py: Move macpherson from contributor list to committer list.
- 6:07 PM Changeset in webkit [89509] by
-
- 6 edits in trunk
2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120
ADD ENABLE_DEVICE_ORIENTATION.
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120
- CMakeListsEfl.txt: Add files to build with ENABLE_DEVICE_ORIENTATION.
- ewk/ewk_view.cpp: (_ewk_view_priv_new): Create DeviceOrientationClientEfl and DeviceMotionClientEfl.
- 6:05 PM Changeset in webkit [89508] by
-
- 3 edits in trunk/Tools
2011-06-22 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
https://bugs.webkit.org/show_bug.cgi?id=63204
- Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined with similar code for the parameter checking.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from those done for single lines since they don't make sense in that case (variable decls look like function decls). Removed some redundant comments (one of which was slightly wrong). Added checks for the new functionality and minor other test changes.
- 6:05 PM Changeset in webkit [89507] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Build fix after r89472.
- css/CSSStyleDeclaration.cpp:
- 5:57 PM Changeset in webkit [89506] by
-
- 7 edits in trunk
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110
- storage/indexeddb/database-name-undefined-expected.txt:
- storage/indexeddb/database-name-undefined.html: removed some code here because it's duplicated in the mozilla/open-database-null-name test
- storage/indexeddb/mozilla/open-database-null-name-expected.txt:
- storage/indexeddb/mozilla/open-database-null-name.html: fixed expected behavior (db.name ends up as four-character string "null")
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110
- storage/IDBFactory.idl: remove ConvertNullToNullString flag on name argument, let IDL code generator stringify null value to "null"
- 5:45 PM Changeset in webkit [89505] by
-
- 9 edits in trunk/Source/WebCore
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Add a Position constructor that takes (Text*, unsigned offset)
https://bugs.webkit.org/show_bug.cgi?id=63181
Added Position::Position(PassRefPtr<Text*>, unsigned offset) and deployed in a couple of places
by replacing the calls to the old constructor.
- dom/Position.cpp: (WebCore::Position::Position): Added.
- dom/Position.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceSelectedTextInNode): Calls new constructor; extracted from InsertTextCommand::performTrivialReplace and ReplaceSelectionCommand::performTrivialReplace. (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Calls new constructor
- editing/CompositeEditCommand.h:
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): Calls replaceSelectedTextInNode. (WebCore::InsertTextCommand::input): Calls new constructor. (WebCore::InsertTextCommand::insertTab): Use RefPtr instead of a raw pointer.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
- editing/visible_units.cpp: (WebCore::startPositionForLine): Calls new constructor.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex): Calls new constructor; calls endPosition on Range instead of avoid manually constructing a VisiblePosition out of endContainer and endOffset.
- 5:39 PM Changeset in webkit [89504] by
-
- 10 edits in trunk/Source
2011-06-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831
- dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
- This function exists to service a Chromium WebKit API, but it's generally purpose and might be useful to other ports. The algorithm has some strange early exits, which I've marked with FIXME comments.
- dom/Document.h:
2011-06-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831
The next phase will be to change all the callers and then remove all
the code inside the ifdef.
- public/WebDocument.h:
- Add new APIs.
- public/WebFrame.h:
- These two APIs were too disgusting. I could not, in good conscience, touch them.
- public/WebSecurityOrigin.h:
- Turns out this API is supposed to be on WebSecurityOrigin, not WebDocument.
- src/WebDocument.cpp:
- Implement the APIs.
(WebKit::WebDocument::url):
(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::encoding):
(WebKit::WebDocument::openSearchDescriptionURL):
(WebKit::WebDocument::forms):
(WebKit::WebDocument::insertStyleText):
- src/WebFrameImpl.cpp:
- Change these implements to just be stubs that call into the real implementations in WebDocument.
(WebKit::WebFrameImpl::url):
(WebKit::WebFrameImpl::openSearchDescriptionURL):
(WebKit::WebFrameImpl::encoding):
(WebKit::WebFrameImpl::forms):
(WebKit::WebFrameImpl::securityOrigin):
(WebKit::WebFrameImpl::grantUniversalAccess):
(WebKit::WebFrameImpl::insertStyleText):
(WebKit::WebFrameImpl::contentAsMarkup):
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::grantUniversalAccess):
- 5:28 PM Changeset in webkit [89503] by
-
- 27 edits1 delete in trunk
2011-06-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add symbols required for window.internals.
https://bugs.webkit.org/show_bug.cgi?id=62066
- Source/autotools/symbols.filter:
2011-06-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066.
- fast/preloader/scan-body-from-head-import.html: Use window.internals.
- fast/preloader/scan-body-from-head-script.html: Use window.internals.
- http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
- http/tests/loading/cross-origin-XHR-willLoadRequest.html:
- http/tests/loading/preload-append-scan-expected.txt:
- http/tests/loading/preload-append-scan.php: Use window.internals.
- http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt:
- http/tests/misc/link-rel-icon-beforeload-expected.txt:
- platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt: Removed.
2011-06-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Don't let all subresources keep isLoadingInAPISense() from
returning false, only requests that affect
CachedResourceRequest::requestCount().
Also, add a callback to Internals to determine whether
a resource has been preloaded.
- WebCore.exp.in:
- dom/Document.cpp: Add m_loadEventFinished.
- dom/Document.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::isPreloaded):
- loader/cache/CachedResourceLoader.h:
- testing/Internals.cpp: (WebCore::Internals::isPreloaded):
- testing/Internals.h:
- testing/Internals.idl:
2011-06-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add win symbols for new window.internals functionality.
https://bugs.webkit.org/show_bug.cgi?id=62066
- win/WebKit2.def:
2011-06-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add libsoup to libWebCoreInternals build.
https://bugs.webkit.org/show_bug.cgi?id=62066
- GNUmakefile.am:
- 5:18 PM Changeset in webkit [89502] by
-
- 3 edits in trunk/Tools
2011-06-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027
We had reverted the change in r89414, so this adds it back in
(modifying check_sys_deps() in port/base.py to check for an
installed web server).
This change then fixes the change in r89414 to stub out the
check_sys_deps() in the test port so that the unit tests run correctly.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- 5:17 PM Changeset in webkit [89501] by
-
- 5 edits in trunk/Source/WebKit/mac
Roll out r89469 (Add preference for setting the html parser depth limit)
The preference is not needed at this time, so there is no reason to expose it.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 5:16 PM Changeset in webkit [89500] by
-
- 1 edit3 adds in trunk/LayoutTests
[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in
r88679.
https://bugs.webkit.org/show_bug.cgi?id=63205
Add expected failing result in order to get the bots green.
- platform/mac-wk2/plugins: Added.
- platform/mac-wk2/plugins/npruntime: Added.
- platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
- 5:01 PM Changeset in webkit [89499] by
-
- 3 edits in trunk/Source/WebCore
2011-06-22 Chris Rogers <crogers@google.com>
Reviewed by David Levin.
Use create() method for AsyncAudioDecoder::DecodingTask
https://bugs.webkit.org/show_bug.cgi?id=63198
No new tests. This doesn't change any JS API.
- webaudio/AsyncAudioDecoder.cpp: (WebCore::AsyncAudioDecoder::decodeAsync): (WebCore::AsyncAudioDecoder::DecodingTask::create):
- webaudio/AsyncAudioDecoder.h:
- 4:57 PM Changeset in webkit [89498] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Ojan Vafai <ojan@chromium.org>
Update listing for perf tests to list each individual test.
A number of the tests in this directory are not flaky.
- platform/chromium/test_expectations.txt:
- 4:56 PM Changeset in webkit [89497] by
-
- 3 edits in trunk/Tools
2011-06-22 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
https://bugs.webkit.org/show_bug.cgi?id=63188
- Scripts/webkitpy/style/checkers/cpp.py: Added the check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
- 4:55 PM Changeset in webkit [89496] by
-
- 27 edits in trunk/Source
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203
Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).
- wtf/Platform.h:
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203
Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).
- WebCore.gyp/WebCore.gyp:
- loader/cache/CachedFont.cpp:
- platform/chromium/DragImageRef.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203
Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).
- WebKit.gyp:
- features.gypi:
- public/WebCommon.h:
- 4:53 PM Changeset in webkit [89495] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by James Robinson.
Remove comment that snuck in via copy & paste.
https://bugs.webkit.org/show_bug.cgi?id=63177
No new tests / no code changes.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator short): Removed incorrect comment.
- 4:51 PM Changeset in webkit [89494] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Unreviewed, baseline for a new test added in http://trac.webkit.org/changeset/89490
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- 4:43 PM Changeset in webkit [89493] by
-
- 4 edits1 add in trunk/LayoutTests
[Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/
- platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
- platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
- platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
- platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png:
- 4:18 PM Changeset in webkit [89492] by
-
- 3 edits4 adds in trunk
2011-06-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
and places the cursor in the correct position.
- editing/inserting/return-key-before-br-in-span-expected.txt: Added.
- editing/inserting/return-key-before-br-in-span.html: Added.
- editing/inserting/return-key-middle-of-span-expected.txt: Added.
- editing/inserting/return-key-middle-of-span.html: Added.
2011-06-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
split at to be at the end of a text node. The code assumes the position is at the start of the node, so
pass the correct node into splitTreeToNode() in that case.
Tests: editing/inserting/return-key-before-br-in-span.html
editing/inserting/return-key-middle-of-span.html
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- 4:09 PM Changeset in webkit [89491] by
-
- 2 edits in trunk/LayoutTests
Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2
Skipped list to get the bots green.
- platform/mac-wk2/Skipped:
- 3:42 PM Changeset in webkit [89490] by
-
- 5 edits5 adds in trunk
2011-06-22 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109
- platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg: Added.
- svg/custom/pointer-events-invalid-fill-expected.txt: Added.
- svg/custom/pointer-events-invalid-fill.svg: Added.
2011-06-22 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109
Properly detect fill/stroke properties of type SVG_PAINTTYPE_URI_NONE, store it in SVGPaint
and don't apply the paint if the uri lookup fails.
Tests: svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg
svg/custom/pointer-events-invalid-fill.svg
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
- rendering/svg/RenderSVGResource.cpp: (WebCore::requestPaintingResource):
- svg/SVGPaint.h: (WebCore::SVGPaint::createURIAndNone):
- 3:35 PM Changeset in webkit [89489] by
-
- 27 edits in trunk/Source
2011-06-22 Cary Clark <caryclark@google.com>
Reviewed by Darin Fisher.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
- wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.
2011-06-22 Cary Clark <caryclark@google.com>
Reviewed by Darin Fisher.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
No new tests. This does not affect existing
functionality.
- WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
- loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
- platform/chromium/DragImageRef.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.
2011-06-22 Cary Clark <caryclark@google.com>
Reviewed by Darin Fisher.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
- WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
- features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
- public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
- 3:28 PM Changeset in webkit [89488] by
-
- 1 edit1 add in trunk/LayoutTests
2011-06-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Adam Roben.
Setting expected results for platform/win
https://bugs.webkit.org/show_bug.cgi?id=63190
- platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
- 3:27 PM Changeset in webkit [89487] by
-
- 1 edit4 adds in trunk/LayoutTests
Add Windows expected results for some new tests from r87779
These differ from Mac due to some small rounding differences in a path.
- platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- 3:12 PM Changeset in webkit [89486] by
-
- 2 edits in trunk/Tools
2011-06-22 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62891
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:07 PM Changeset in webkit [89485] by
-
- 2 edits in trunk/LayoutTests
Skip some flaky animation tests on Windows
See <http://webkit.org/b/62561> and <http://webkit.org/b/62569>.
- platform/win/Skipped: Added animations/animation-direction-normal.html and
animations/play-state-paused.html.
- 3:02 PM Changeset in webkit [89484] by
-
- 5 edits7 moves in trunk/LayoutTests
Disable zoom-svg-through-object-with-*.xhtml
These tests are flaky. See <http://webkit.org/b/63186>.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
Removed mentions of these tests.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml.
- svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html.
- svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml.
- svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html.
- svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml.
- svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml.
- 2:52 PM Changeset in webkit [89483] by
-
- 3 edits in trunk/Tools
2011-06-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
nrwt: don't look for http lock when running the test port
https://bugs.webkit.org/show_bug.cgi?id=63158
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- 2:40 PM Changeset in webkit [89482] by
-
- 6 edits in trunk
2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
- platform/qt-wk2/Skipped: Unskip passing plugin tests and create a new group for those that still fail for some reason.
2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Force windowless mode for the test plugin because we don't support windowed plugins yet.
2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
- WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::initializeTestPluginDirectory): Use the QTWEBKIT_PLUGIN_PATH environment variable as the path of the test plugin like DRT does.
- 2:38 PM Changeset in webkit [89481] by
-
- 2 edits in trunk/LayoutTests
WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197
Add more tests that use layoutTestController.overridePreference to the WK2 Skipped list.
- platform/mac-wk2/Skipped:
- 2:33 PM Changeset in webkit [89480] by
-
- 5 edits in trunk/Tools
2011-06-22 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107
It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
into urls myself. So I have now fixed its "preparing" message to include a url.
I also figured that I should make the messages mention all of the responsible parties
so that rollouts are never surprises. If you're in the channel and were involved
in a patch, you will see if someone is using sheriff-bot to rollout a patch.
As part of doing this I also changed (and tested) _parse_args to fail-fast
when given invalid args.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 2:23 PM Changeset in webkit [89479] by
-
- 5 edits in trunk
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
- storage/indexeddb/mozilla/create-index-null-name-expected.txt:
- storage/indexeddb/mozilla/create-index-null-name.html:
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
- storage/IDBObjectStore.idl: remove ConvertNullToNullString flag so null values will be stringified as "null", as per WebIDL spec.
- 2:14 PM Changeset in webkit [89478] by
-
- 7 edits4 adds in trunk/Source/WebCore
2011-06-22 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
AudioContext needs non-blocking call to create AudioBuffer from audio file data
https://bugs.webkit.org/show_bug.cgi?id=61947
No new tests since audio API is not yet implemented.
- DerivedSources.make:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- webaudio/AsyncAudioDecoder.cpp: Added. (WebCore::AsyncAudioDecoder::AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::decodeAsync): (WebCore::AsyncAudioDecoder::threadEntry): (WebCore::AsyncAudioDecoder::runLoop): (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask): (WebCore::AsyncAudioDecoder::DecodingTask::decode): (WebCore::AsyncAudioDecoder::DecodingTask::notifyCompleteDispatch): (WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete):
- webaudio/AsyncAudioDecoder.h: Added. (WebCore::AsyncAudioDecoder::DecodingTask::audioData): (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate): (WebCore::AsyncAudioDecoder::DecodingTask::successCallback): (WebCore::AsyncAudioDecoder::DecodingTask::errorCallback): (WebCore::AsyncAudioDecoder::DecodingTask::audioBuffer):
- webaudio/AudioBufferCallback.h: Added. (WebCore::AudioBufferCallback::~AudioBufferCallback):
- webaudio/AudioBufferCallback.idl: Added.
- webaudio/AudioContext.cpp: (WebCore::AudioContext::decodeAudioData):
- webaudio/AudioContext.h:
- webaudio/AudioContext.idl:
- 1:55 PM Changeset in webkit [89477] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
SnowLeopard Intel Release (Tests), Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63178
Add failing expected results in order to get the bots green.
- platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
- 1:44 PM Changeset in webkit [89476] by
-
- 1 edit1 move in trunk/LayoutTests
2011-06-22 Tony Chang <tony@chromium.org>
Add test that got renamed. Should have been included with r89466.
- storage/indexeddb/keypath-basics.html: Renamed from LayoutTests/storage/indexeddb/keypath-as-array.html.
- 1:43 PM Changeset in webkit [89475] by
-
- 3 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=63174
Don't draw the borders as one path unless there really are 4 borders
-and corresponding-
<rdar://problem/9457997>
Reviewed by Simon Fraser.
Source/WebCore:
If any of the border edges have no width, then allEdgesVisible should be set to
false since borders without width will not be visible.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
LayoutTests:
- fast/borders/only-one-border-with-width.html: Added.
- platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
- platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
- 1:39 PM Changeset in webkit [89474] by
-
- 3 edits4 adds in trunk
2011-06-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
Test: compositing/layer-creation/spanOverlapsCanvas.html
- rendering/RenderLayer.cpp: Added checks for canvas to be layered properly. (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
2011-06-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
- compositing/layer-creation/spanOverlapsCanvas.html: Added.
- platform/mac/compositing/layer-creation: Added.
- platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
- platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
- 1:35 PM Changeset in webkit [89473] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
SnowLeopard Intel Release (Tests) and Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63175
Add platform-specific results to in order to get the bots green.
- platform/mac/inspector/console: Added.
- platform/mac/inspector/console/console-trace-in-eval-expected.txt: Added.
- 1:29 PM Changeset in webkit [89472] by
-
- 9 edits in trunk/Source
Source/JavaScriptCore: * interpreter/RegisterFile.h: Removed unnecessary #include <stdio.h>.
Reviewed by Oliver Hunt.
Source/WebKit2: Removed unnecessary #include <stdio.h>.
Reviewed by Oliver Hunt.
- PluginProcess/mac/PluginProcessMainMac.mm:
- Shared/WebMemorySampler.cpp:
- UIProcess/WebFrameProxy.cpp:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
- WebProcess/mac/WebProcessMac.mm: Added #include back to places where it
was needed.
- 1:17 PM Changeset in webkit [89471] by
-
- 3 edits in trunk/Source/WebCore
2011-06-22 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
AudioContext noteGrainOn() method should not apply explicit windowing
https://bugs.webkit.org/show_bug.cgi?id=63005
No new tests since audio API is not yet implemented.
- webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::readFromBuffer):
- webaudio/AudioBufferSourceNode.h:
- 1:15 PM Changeset in webkit [89470] by
-
- 18 edits48 deletes in branches/chromium/782
Revert 87526 - 2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976
Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793
WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)
CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)
SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972
Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086
- http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
- http/tests/misc/resources/embedded.svg: Added.
- http/tests/misc/resources/svg-slow.pl: Added.
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
- platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
- platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-expected.png: Added.
- platform/mac/svg/custom/object-sizing-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
- platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
- platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
- platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
- platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
- platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
- platform/mac/svg/hixie/text/003-expected.png:
- platform/mac/svg/hixie/text/003-expected.txt:
- platform/mac/svg/in-html/by-reference-expected.txt:
- platform/mac/svg/wicd: Added.
- platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
- platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
- platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
- platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
- platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
- svg/custom/object-no-size-attributes.xhtml: Added.
- svg/custom/object-sizing-explicit-height.xhtml: Added.
- svg/custom/object-sizing-explicit-width-height.xhtml: Added.
- svg/custom/object-sizing-explicit-width.xhtml: Added.
- svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
- svg/custom/object-sizing-no-width-height.xhtml: Added.
- svg/custom/object-sizing.xhtml: Added.
- svg/custom/resources/embedded.svg: Added.
- svg/custom/resources/red-circle.svg: Added.
- svg/in-html/by-reference-expected.png:
- svg/wicd: Added.
- svg/wicd/resources: Added.
- svg/wicd/resources/a.svg: Added.
- svg/wicd/resources/bcde.svg: Added.
- svg/wicd/resources/empty1.svg: Added.
- svg/wicd/resources/empty2.svg: Added.
- svg/wicd/resources/empty3.svg: Added.
- svg/wicd/resources/f.svg: Added.
- svg/wicd/resources/g.svg: Added.
- svg/wicd/resources/h.svg: Added.
- svg/wicd/resources/i.svg: Added.
- svg/wicd/resources/j.svg: Added.
- svg/wicd/resources/k.svg: Added.
- svg/wicd/resources/l.svg: Added.
- svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
- svg/wicd/resources/mnop.svg: Added.
- svg/wicd/resources/q.svg: Added.
- svg/wicd/resources/r.svg: Added.
- svg/wicd/resources/s.svg: Added.
- svg/wicd/resources/t.svg: Added.
- svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
- svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
- svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
- svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
- svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
- svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
- svg/wicd/rightsizing-grid.xhtml: Added.
- svg/wicd/test-rightsizing-a.xhtml: Added.
- svg/wicd/test-rightsizing-b.xhtml: Added.
- svg/zoom/page/resources: Added.
- svg/zoom/page/resources/absolute-sized-svg.png: Added.
- svg/zoom/page/resources/absolute-sized-svg.svg: Added.
- svg/zoom/page/resources/huge-rect.svg: Added.
- svg/zoom/page/resources/percentage-sized-svg.png: Added.
- svg/zoom/page/resources/percentage-sized-svg.svg: Added.
- svg/zoom/page/resources/text.svg: Added.
- svg/zoom/page/resources/tux.svg: Added.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
- svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
- svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
- svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
- svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976
Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793
WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)
CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)
SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972
Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086
Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).
SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.
If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)
Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".
Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml
svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml
- platform/Length.h: (WebCore::Length::isSpecified):
- rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
- rendering/RenderPart.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
- rendering/svg/RenderSVGRoot.h:
- svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
- svg/SVGSVGElement.h:
BUG=86700
TBR=Nikolas Zimmermann
- 1:13 PM Changeset in webkit [89469] by
-
- 5 edits in trunk/Source/WebKit/mac
2011-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Add preference for setting the html parser depth limit
https://bugs.webkit.org/show_bug.cgi?id=63163
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]): (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Add private preference for setting the parser depth limit.
- 1:12 PM Changeset in webkit [89468] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=42331
Add another test that uses dumpFrameLoadCallbacks to the WK2 Skipped list.
- platform/mac-wk2/Skipped:
- 1:11 PM Changeset in webkit [89467] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r89461.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformSetFocus):
Forgot to name the parameter, fix it.
- 1:09 PM Changeset in webkit [89466] by
-
- 5 edits1 add1 delete in trunk
2011-06-22 Kentaro Hara <haraken@google.com>
Reviewed by Tony Chang.
Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054
At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.
- storage/indexeddb/keypath-as-array-expected.txt: Removed.
- storage/indexeddb/keypath-as-array.html: Removed.
- storage/indexeddb/keypath-basics-expected.txt: Added.
- storage/indexeddb/keypath-basics.html: Added.
2011-06-22 Kentaro Hara <haraken@google.com>
Reviewed by Tony Chang.
Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054
At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.
Tests: storage/indexeddb/keypath-basics.html
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
- storage/IDBKeyPath.cpp: (WebCore::IDBIsValidKeyPath):
- storage/IDBKeyPath.h:
- 1:07 PM Changeset in webkit [89465] by
-
- 12 edits in trunk
Removed the conceit that global variables are local variables when running global code
https://bugs.webkit.org/show_bug.cgi?id=63106
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is required for write barrier correctness.
SunSpider reports about a 0.5% regression, mostly from bitops-bitwise-and.js.
I was able to reduce the regression with a tiny peephole optimization in
the bytecompiler, but not eliminate it. I'm committing this assuming
that turning on generational GC will win back at least 0.5%.
(FWIW, the DFG JIT can easily eliminate any regression by sharing loads of
the global object's var storage. I considered doing the same kind of
optimization in the existing JIT, but it seemed like moving in the wrong
direction.)
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator): Don't give global variables
negative indices, since they're no longer negatively offset from the
current stack frame.
Do give global variables monotonically increasing positive indices, since
that's much easier to work with.
Don't limit the number of optimizable global variables, since it's no
longer limited by the register file, since they're no longer stored in
the register file.
(JSC::BytecodeGenerator::registerFor): Global code never has any local
registers because a var in global code is actually a property of the
global object.
(JSC::BytecodeGenerator::constRegisterFor): Ditto.
(JSC::BytecodeGenerator::emitResolve): Did a tiny bit of constant
propagation and dead code elimination to speed up our compiles and
reduce WTFs / minute.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor): Removed special handling of globals.
(JSC::BytecodeGenerator::shouldOptimizeLocals): Don't optimize locals in
global code, since there are none.
(JSC::BytecodeGenerator::canOptimizeNonLocals): Do optimize non-locals
in global code (i.e., global vars), since there are some.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
- interpreter/Interpreter.h: Updated for deleted / renamed code.
- interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
(JSC::RegisterFile::releaseExcessCapacity): Updated for deleted / renamed
data members.
- interpreter/RegisterFile.h:
(JSC::RegisterFile::begin):
(JSC::RegisterFile::size):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink): Removed all code and comments dealing with
global variables stored in the register file.
(JSC::RegisterFile::grow): Updated for same.
Also, a slight correctness fix: Test the VM commit end, and not just the
in-use end, when checking for stack overflow. In theory, it's invalid to
commit past the end of your allocation, even if you never touch that
memory. This makes the usable size of the stack slightly smaller. No test
because we don't know of any case in practice where this crashes.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Updated for changes above.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
- runtime/JSGlobalObject.h: Simplified globals to have monotonically
increasing indexes, always located in our external storage.
LayoutTests:
- fast/js/recursion-limit-equal-expected.txt: Updated to reflect slightly
changed recursion limit.
- 1:06 PM Changeset in webkit [89464] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing
on SnowLeopard Intel Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63169
Add (failing?) expected results to get the bots green.
- platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added.
- 1:04 PM Changeset in webkit [89463] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
- platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Added.
- platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Added.
- 12:57 PM Changeset in webkit [89462] by
-
- 3 edits2 adds in trunk
2011-06-22 Young Han Lee <joybro@company100.net>
Reviewed by Simon Fraser.
animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303
When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.
The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.
- animations/multiple-animations-timing-function-expected.txt: Added.
- animations/multiple-animations-timing-function.html: Added.
2011-06-22 Young Han Lee <joybro@company100.net>
Reviewed by Simon Fraser.
animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303
When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.
The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.
Test: animations/multiple-animations-timing-function.html
- page/animation/KeyframeAnimation.cpp: (WebCore::getAnimationFromStyleByName): (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
- 12:55 PM Changeset in webkit [89461] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Darin Adler.
[X11][WK2] Implement NetscapePlugin::platformSetFocus
https://bugs.webkit.org/show_bug.cgi?id=63154
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformSetFocus): Implement focus setting based on the WebKit1 path.
- 12:55 PM Changeset in webkit [89460] by
-
- 86 edits1 delete in trunk
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89407, r89409, r89410, and r89411.
http://trac.webkit.org/changeset/89407
http://trac.webkit.org/changeset/89409
http://trac.webkit.org/changeset/89410
http://trac.webkit.org/changeset/89411
https://bugs.webkit.org/show_bug.cgi?id=63168
Broke Chromium tests for Forms and Autofill (Requested by
dimich on #webkit).
- fast/css/text-input-with-webkit-border-radius-expected.txt:
- fast/forms/search-abs-pos-cancel-button.html:
- fast/forms/search-cancel-button-mouseup.html:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/placeholder-set-value-expected.txt:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/repaint/search-field-cancel-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/css/input-search-padding-expected.png:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/pseudo-cache-stale-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/placeholder-set-value-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-styled-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/qt/fast/css/pseudo-cache-stale-expected.txt:
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/placeholder-set-value-expected.txt:
- platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-styled-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-vertical-alignment-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
- platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/win/media/media-controls-clone-expected.txt: Removed.
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89407, r89409, r89410, and r89411.
http://trac.webkit.org/changeset/89407
http://trac.webkit.org/changeset/89409
http://trac.webkit.org/changeset/89410
http://trac.webkit.org/changeset/89411
https://bugs.webkit.org/show_bug.cgi?id=63168
Broke Chromium tests for Forms and Autofill (Requested by
dimich on #webkit).
- css/html.css: (input[type="search"]::-webkit-search-cancel-button): (input[type="search"]::-webkit-search-decoration): (input[type="search"]::-webkit-search-results-decoration): (input[type="search"]::-webkit-search-results-button): (input::-webkit-inner-spin-button): (input::-webkit-input-speech-button):
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/InputType.h:
- html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): (WebCore::SearchInputType::createShadowSubtree): (WebCore::SearchInputType::destroyShadowSubtree):
- html/SearchInputType.h: (WebCore::SearchInputType::innerBlockElement):
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::destroyShadowSubtree):
- html/TextFieldInputType.h: (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::innerTextElement): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
- rendering/RenderTextControlSingleLine.h:
- 12:52 PM Changeset in webkit [89459] by
-
- 4 edits in trunk/Tools
2011-06-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
run-webkit-websocketserver fails to stop websocket server
https://bugs.webkit.org/show_bug.cgi?id=63123
There's a ten-character change in new-run-webkit-websocketserver
that fixes the actual bug, and then we update the code in
new-run-webkit-httpd to do the actual stop call, and add more tests
(refactoring the existing test code so that it is shared).
- Scripts/new-run-webkit-httpd:
- Scripts/new-run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
- 12:47 PM Changeset in webkit [89458] by
-
- 1 edit4 adds in trunk/Source/WebKit/efl
2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=63125
Add dummy files to build with ENABLE_DEVICE_ORIENTATION.
- WebCoreSupport/DeviceMotionClientEfl.cpp: Added. (WebCore::DeviceMotionClientEfl::DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::~DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientEfl::setController): (WebCore::DeviceMotionClientEfl::startUpdating): (WebCore::DeviceMotionClientEfl::stopUpdating): (WebCore::DeviceMotionClientEfl::currentDeviceMotion):
- WebCoreSupport/DeviceMotionClientEfl.h: Added.
- WebCoreSupport/DeviceOrientationClientEfl.cpp: Added. (WebCore::DeviceOrientationClientEfl::DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::~DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientEfl::setController): (WebCore::DeviceOrientationClientEfl::startUpdating): (WebCore::DeviceOrientationClientEfl::stopUpdating): (WebCore::DeviceOrientationClientEfl::lastOrientation):
- WebCoreSupport/DeviceOrientationClientEfl.h: Added.
- 12:39 PM Changeset in webkit [89457] by
-
- 4 edits in trunk/Source/WebCore
2011-06-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Improve speed of heap profiles dominators view.
https://bugs.webkit.org/show_bug.cgi?id=62979
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice.prototype.item): (WebInspector.HeapSnapshotArraySlice.prototype.slice): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode): (WebInspector.HeapSnapshot.prototype._buildReverseIndex.var): (WebInspector.HeapSnapshot.prototype._buildReverseIndex): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshot.prototype._buildDominatedNodes): (WebInspector.HeapSnapshot.prototype._getDominatedIndex): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): (WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get length): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotNodesProvider):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
- 12:26 PM Changeset in webkit [89456] by
-
- 4 edits in trunk/Source/WebCore
2011-06-22 Sreeram Ramachandran <sreeram@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Restore console messages when restoring inspector state
https://bugs.webkit.org/show_bug.cgi?id=63146
No new tests (no change in functionality, only in display).
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::restore):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
- 12:10 PM WikiStart edited by
- Added an entry for WebAPIReviewChecklist (diff)
- 12:09 PM WebAPIReviewChecklist edited by
- (diff)
- 12:07 PM WebAPIReviewChecklist created by
- Add WebAPIReviewChecklist
- 12:02 PM Changeset in webkit [89455] by
-
- 2 edits in trunk/Source/WebCore
2011-06-22 Adam Barth <abarth@webkit.org>
Attempt to fix the GTK build after my incomplete rollout of 88332.
- GNUmakefile.list.am:
- 11:57 AM Changeset in webkit [89454] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-22 Ademar de Souza Reis Jr. <Ademar Reis>
Reviewed by Holger Freyther.
[Qt] Fix Qt namespace on QDeclarativeWebView autotest
https://bugs.webkit.org/show_bug.cgi?id=63147
Applications (such as the test runner) are not supposed to be wrapped
by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
QtWebKit) with a specific namespace won't work (will result in main
being undefined).
This was the only test wrapped by these macros, all others are fine.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove namespace macros.
- 11:26 AM Changeset in webkit [89453] by
-
- 14 edits in trunk
2011-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
HTML parser should limit element depth of produced tree
https://bugs.webkit.org/show_bug.cgi?id=63082
Test by:
fast/parser/block-nesting-cap.html
fast/parser/element-nesting-cap.html
- html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::HTMLConstructionSite):
- html/parser/HTMLConstructionSite.h: Limit the DOM tree depth by turning attempts to add a child passed a certain threshold (configurable by Settings::maximumDOMTreeDepth) into a sibling.
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::maximumDOMTreeDepth):
- html/parser/HTMLDocumentParser.h: Pass the maximumDOMTreeDepth to the TreeBuilder.
- html/parser/HTMLElementStack.cpp: (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonTopCommon):
- html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::size): Keep track of the size of the element stack.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create): Pass the maximumDOMTreeDepth to the construction site.
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: (WebCore::Settings::setMaximumHTMLParserDOMTreeDepth): (WebCore::Settings::maximumHTMLParserDOMTreeDepth): Add a setting to control the maximum DOM tree depth that the parser will produce.
2011-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
HTML parser should limit element depth of produced tree
https://bugs.webkit.org/show_bug.cgi?id=63082
- fast/parser/block-nesting-cap-expected.txt:
- fast/parser/element-nesting-cap-expected.txt: Update expectations for new parser depth limit.
- 11:12 AM Changeset in webkit [89452] by
-
- 27 edits9 deletes in trunk
2011-06-22 Adam Barth <abarth@webkit.org>
Rollout 88332.
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebRuntimeFeatures.cpp:
2011-06-22 Adam Barth <abarth@webkit.org>
Rollout 88332. As discussed on webkit-dev, we'd like to iterate on
both the API and it's implementation a bit.
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- dom/DocumentMarker.h: (WebCore::DocumentMarker::activeMatch):
- dom/DocumentMarkerController.cpp:
- dom/DocumentMarkerController.h:
- html/HTMLDivElement.cpp:
- html/HTMLDivElement.h:
- html/HTMLDivElement.idl:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/HTMLTextAreaElement.cpp:
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.idl:
- html/SpellcheckRange.cpp: Removed.
- html/SpellcheckRange.h: Removed.
- html/SpellcheckRange.idl: Removed.
- html/SpellcheckRangeList.cpp: Removed.
- html/SpellcheckRangeList.h: Removed.
- html/SpellcheckRangeList.idl: Removed.
- rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): (WebCore::InlineTextBox::paintDocumentMarkers):
2011-06-22 Adam Barth <abarth@webkit.org>
Rollout 88332.
- editing/spelling/spellcheck-api-expected.txt: Removed.
- editing/spelling/spellcheck-api-pixel.html: Removed.
- editing/spelling/spellcheck-api.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 11:03 AM Changeset in webkit [89451] by
-
- 13 edits12 copies in trunk
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: fix multiple issues in IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=63140
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt: Added.
- storage/indexeddb/createObjectStore-name-argument-required.html: Added.
- storage/indexeddb/createObjectStore-null-name-expected.txt: Added.
- storage/indexeddb/createObjectStore-null-name.html: Added.
- storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt: Added.
- storage/indexeddb/deleteObjectStore-name-argument-required.html: Added.
- storage/indexeddb/deleteObjectStore-null-name-expected.txt: Added.
- storage/indexeddb/deleteObjectStore-null-name.html: Added.
- storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-null-name.html:
- storage/indexeddb/setVersion-null-expected.txt: Added.
- storage/indexeddb/setVersion-null.html: Added.
- storage/indexeddb/setVersion-undefined-expected.txt:
- storage/indexeddb/setVersion-undefined.html:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-crash-on-abort-expected.txt:
- storage/indexeddb/transaction-crash-on-abort.html:
- storage/indexeddb/transaction-read-only-expected.txt:
- storage/indexeddb/transaction-read-only.html:
- storage/indexeddb/transaction-storeNames-required-expected.txt: Added.
- storage/indexeddb/transaction-storeNames-required.html: Added.
2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: fix multiple issues in IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=63140
Tests: storage/indexeddb/createObjectStore-name-argument-required.html
storage/indexeddb/createObjectStore-null-name.html
storage/indexeddb/deleteObjectStore-name-argument-required.html
storage/indexeddb/deleteObjectStore-null-name.html
storage/indexeddb/setVersion-null.html
storage/indexeddb/transaction-storeNames-required.html
- storage/IDBDatabase.idl: remove LegacyDefaultOptionalArguments so all functions will throw TypeError when called with too few arguments, as per WebIDL spec. Also remove ConvertNullToNullString flags so null values are stringified as "null" (also as per WebIDL spec).
- 10:53 AM Changeset in webkit [89450] by
-
- 1 edit1 add in trunk/LayoutTests
Adding a mac platform expected result for webgl test to help fix burning bot.
Filed https://bugs.webkit.org/show_bug.cgi?id=63151 for a real fix
- platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Added.
- 10:51 AM Changeset in webkit [89449] by
-
- 9 edits in trunk/Source/WebCore
2011-06-22 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
- 10:42 AM Changeset in webkit [89448] by
-
- 3 edits in trunk/Source/WebCore
2011-06-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.
https://bugs.webkit.org/show_bug.cgi?id=62964
No new tests / refactoring only.
- css/CSSPrimitiveValueMappings.h: Support cast to/from short.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to short to allow CSSPropertWidows and CSSPropertyOrphans to use existing macro.
- 10:27 AM Changeset in webkit [89447] by
-
- 5 edits1 add in trunk/Tools
Add links to existing bugs related to failing tests on TestFailures page
I changed the layout of the page a little to make it easier to read with all the new
information. Passing/failing revisions have been moved down below the list of tests to be
closer to the existing bugs and the new bug link. And each set of tests and its relevant
information is in a light gray box.
Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
possible
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
(Bugzilla): This new class represents a single Bugzilla instance.
(Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
passing the resulting bug titles and URLs to the callback when complete. If called multiple
times with the same query before the query returns, caches the callbacks so that only one
query is sent over the wire. When the query completes, all pending callbacks are called.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history): Reduce the margin/padding on the top-level list a bit.
(#failure-history > li): Put each set of tests in a gray box, and indent most information
inside the box.
(.test-list): Unindent the list of failing tests so it is visually at the top level.
(.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
each box isn't a big empty space.
(.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
quite long.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(addQueryParametersToURL): New function extracted from
ViewController.prototype._domForNewAndExistingBugs.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Take and store an optional Bugzilla instance.
(ViewController.prototype._displayBuilder): Give the top-level list an id for styling
purposes and move the list of failing tests above all other information. Only show bug
information once we've determined the most-recent passing revision for a set of tests. It's
not that useful to file a new bug before this information has been determined, and searching
for existing bugs before we've figured out which tests started failing at the same time
would end up giving you information about a bunch of unrelated tests.
(ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
failing tests, and adds links to the bugs when the search completes.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
Bugzilla instance for bugs.webkit.org to the ViewController.
- 10:19 AM Changeset in webkit [89446] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline
https://bugs.webkit.org/show_bug.cgi?id=23753
The bug got fixed, so landing the test case.
- fast/dom/legend-display-inline-expected.txt: Added.
- fast/dom/legend-display-inline.html: Added.
- 10:17 AM Changeset in webkit [89445] by
-
- 3 edits2 copies in branches/chromium/782
Merge 89183 - 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
- svg/custom/assert-empty-layout-attributes-expected.txt: Added.
- svg/custom/assert-empty-layout-attributes.svg: Added.
2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
Test: svg/custom/assert-empty-layout-attributes.svg
- rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here. It is not needed to do the text layout algorithm if you don't have any layout information as your size is (0, 0) anyway.
TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/7231014
- 10:14 AM Changeset in webkit [89444] by
-
- 2 edits in trunk/LayoutTests
Undoing possibly incorrect rebaseline from r89434 for webgl test. Filed follow up bug.
- 10:13 AM Changeset in webkit [89443] by
-
- 3 edits2 copies in branches/chromium/782
Merge 88474 - 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
- fast/css/webkit-keyframes-crash-expected.txt: Added.
- fast/css/webkit-keyframes-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
- css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.
TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/7231013
- 9:57 AM Changeset in webkit [89442] by
-
- 10 edits1 move1 add in trunk/Source
2011-06-22 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Martin Robinson.
Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62848
This patch will make GtkWidgetBackingStore shareable with EFL port.
It is a preparation to integrate WebKit2's BackingStoreGtk.cpp and
BackingStoreEfl.cpp as a BackingStoreCairo.cpp.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyRectFromOneSurfaceToAnother):
- platform/graphics/cairo/CairoUtilities.h:
- platform/cairo/WidgetBackingStore.h: Added.
- platform/gtk/GtkWidgetBackingStore.h: Removed.
- platform/gtk/GtkWidgetBackingStoreCairo.cpp: (WebCore::createSurfaceForBackingStore): (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll):
- platform/gtk/GtkWidgetBackingStoreX11.cpp: (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::~WidgetBackingStorePrivate): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll):
2011-06-22 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Martin Robinson.
Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62848
Change GtkWidgetBackingStore to WidgetBackingStore in the BackingStore.h and
gtk/BackingStoreGtk.cpp.
- UIProcess/BackingStore.h:
- UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::incorporateUpdate):
- 9:46 AM Changeset in webkit [89441] by
-
- 3 edits in trunk/Source/WebCore
2011-06-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Update position, bounds and anchor point in GraphicsLayerCA all at once
https://bugs.webkit.org/show_bug.cgi?id=63148
Since position, bounds and anchor point are inter-dependent, avoid
redundant work by simply updating them all at the same time.
No behavior changes, so no new tests.
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setPosition): (WebCore::GraphicsLayerCA::setAnchorPoint): (WebCore::GraphicsLayerCA::setSize): (WebCore::GraphicsLayerCA::setBoundsOrigin): (WebCore::GraphicsLayerCA::setAllowTiledLayer): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateGeometry): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
- 9:45 AM Changeset in webkit [89440] by
-
- 18 edits in trunk/Source
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Make instantiation of legacy editing position more explicit
https://bugs.webkit.org/show_bug.cgi?id=63037
Create new positions since we can't create a legacy editing position outside of WebCore anymore.
- WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Make instantiation of legacy editing position more explicit
https://bugs.webkit.org/show_bug.cgi?id=63037
Replaced the constructor of Position class that used to instantiate a legacy editing position
by a function called createLegacyEditingPosition.
- WebCore.exp.in: Removed the constructor from the list.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData): Calls createLegacyEditingPosition.
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): No longer uses Positions to instantiate a range.
- dom/Position.cpp: (WebCore::Position::Position): New constructor takes LegacyEditingOffset, which can only be instantiated by createLegacyEditingPosition. (WebCore::Position::previous): Calls createLegacyEditingPosition. (WebCore::Position::next): Ditto. (WebCore::Position::upstream): Ditto. (WebCore::Position::downstream): Ditto.
- dom/Position.h: Added new Position::LegacyEditingOffset class to hide the legacy constructor from the world. (WebCore::Position::LegacyEditingOffset::value): Added. (WebCore::Position::LegacyEditingOffset::LegacyEditingOffset): Added. (WebCore::createLegacyEditingPosition): Added.
- dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Calls createLegacyEditingPosition.
- dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::toPosition): Ditto.
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): Instantiates new Position instead of old one; this is always safe since the anchor node is always a text node.
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Calls createLegacyEditingPosition. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::renderedText): Ditto.
- editing/visible_units.cpp: (WebCore::previousBoundary): Ditto. (WebCore::previousLinePosition): Ditto. (WebCore::nextLinePosition): Ditto.
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): Ditto. (WebCore::DOMSelection::setBaseAndExtent): Ditto. (WebCore::DOMSelection::setPosition): Ditto. (WebCore::DOMSelection::extend): Ditto.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox): Ditto.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): Calls Position() instead of Position(0, 0).
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Calls createLegacyEditingPosition.s
- 9:24 AM Changeset in webkit [89439] by
-
- 8 edits in trunk
2011-06-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138
- inspector/elements/set-attribute.html:
- inspector/elements/set-attribute-expected.txt:
2011-06-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributeValue): (WebCore::InspectorDOMAgent::setAttributesText):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.setAttributeValue):
- 9:21 AM Changeset in webkit [89438] by
-
- 2 edits in trunk/Tools
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Apply current view settings to newly created views in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63142
- GtkLauncher/main.c: (createWebViewCb):
- 9:20 AM Changeset in webkit [89437] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Added rev to ChangeLog for tree burning fix.
- 9:11 AM Changeset in webkit [89436] by
-
- 2 edits in trunk/Source/WebKit2
Don't use an alpha channel when drawing the web page on Windows
We never use the alpha channel in the end anyway (because we never render into a layered
window, which is the only kind of window that supports alpha). And using an alpha channel is
tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
channel).
Fixes <http://webkit.org/b/63075> <rdar://problem/9648113> REGRESSION (r88978): Text inside
form controls looks really awful on Windows XP
Reviewed by Anders Carlsson.
- WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
to the GraphicsContext constructor.
- 9:03 AM Changeset in webkit [89435] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
video-loop.html sometimes fails on slow system
https://bugs.webkit.org/show_bug.cgi?id=63143
- media/video-loop.html: Don't seek if an exception will be generated.
- 8:57 AM Changeset in webkit [89434] by
-
- 3 edits in trunk/LayoutTests
Fixing burning mac SL trees. These tests's expected results needed
updating after parts of them were fixed recently.
- 8:44 AM Changeset in webkit [89433] by
-
- 5 edits in trunk/Source/WebKit2
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination()
https://bugs.webkit.org/show_bug.cgi?id=61627
Don't use Connection::setShouldCloseConnectionOnProcessTermination() for the
GTK port, when the process finishes the connection is closed and
the other process is already notified. We still need to monitor
the child process so that it doesn't become a zombie when it dntabi
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::childFinishedFunction): (WebKit::ProcessLauncher::launchProcess):
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching):
- 8:27 AM Changeset in webkit [89432] by
-
- 2 edits in trunk/Tools
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use GOption to parse main arguments in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63060
Instead of getting the settings from the view, create a new
settings object not associated with any view so that we can parse
the command line arguments before creating the view. It will also
allows to use the same settings for more than one view if we
eventually support passing more than one uri from the command
line.
- GtkLauncher/main.c: (parseOptionEntryCallback): Make this function static. Also use g_ascii_strtoll/g_ascii_strtod to parse int/float values instead of atoi/atof to provide better error messages. And always fill the error struct when the function fails. (getOptionEntriesFromWebKitWebSettings): Use an array of GOptionEntry structs instead of a GArray, since that is what g_option_group_add_entries() expects and the array size doesn't change. (addWebSettingsGroupToContext): Helper function to add the websettings group to the option context. (main): Create the option context to parse command line arguments.
- 8:24 AM Changeset in webkit [89431] by
-
- 16 edits7 adds in trunk
2011-06-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Animate viewBox attribute in SVG
https://bugs.webkit.org/show_bug.cgi?id=20057
Test SVGRect animation with from-to and from-by animations.
- svg/animations/script-tests/svgrect-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svgrect-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svgrect-animation-1-expected.txt: Added.
- svg/animations/svgrect-animation-1.html: Added.
- svg/animations/svgrect-animation-2-expected.txt: Added.
- svg/animations/svgrect-animation-2.html: Added.
2011-06-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Animate viewBox attribute in SVG
https://bugs.webkit.org/show_bug.cgi?id=20057
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGRect. With the new animator we support
interpolation between SVGRects. A feature that can be used to get smooth zooming animations for SVGs.
Added parseRect() to SVGParserUtilities for parsing Strings to FloatRects.
Tests: svg/animations/svgrect-animation-1.html
svg/animations/svgrect-animation-2.html
- CMakeLists.txt: Added new file SVGAnimatedRect.cpp to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/FloatRect.h: Added new operators + and +=. (WebCore::operator+=): (WebCore::operator+):
- svg/SVGAllInOne.cpp: Added SVGAnimatedRect.cpp for Win build.
- svg/SVGAnimateElement.cpp: Handle AnimatedRect explicitly. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): Ditto. (WebCore::SVGAnimateElement::calculateAnimatedValue): Ditto. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
- svg/SVGAnimatedRect.cpp: Added. The new Animator for SVGRect. (WebCore::SVGAnimatedRectAnimator::SVGAnimatedRectAnimator): (WebCore::SVGAnimatedRectAnimator::constructFromString): (WebCore::SVGAnimatedRectAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedRectAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedRectAnimator::calculateDistance):
- svg/SVGAnimatedRect.h: (WebCore::SVGAnimatedRectAnimator::~SVGAnimatedRectAnimator):
- svg/SVGAnimatedType.cpp: Support for FloatRect. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createRect): (WebCore::SVGAnimatedType::rect): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
- svg/SVGParserUtilities.cpp: Parse String as FloatRect. (WebCore::parseRect):
- svg/SVGParserUtilities.h:
- 7:38 AM Changeset in webkit [89430] by
-
- 25 edits in trunk/Source
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
1) Introduce FileChooserSettings to decouple setting querying from
FileChooser. It's a simple copyable settings object, which allows us
to capture the settings atomically and treat them as discardable data.
2) Encapsulate lifetime management of FileChooser entirely in
FileChooserClient. It's now a "smart" client, and allows us to
completely remove FileChooser management concerns from a FileChooserClient
implementor.
3) Change creation of FileChooser to be on-demand, only when we actually
need to choose file.
4) Rearrange calling of dispatchFormControlChangeEvent to be at the end
of a function and remove "am-I-dead" checks that are now unnecessary.
5) Clean up directory upload code a bit, and make use of FileChooserSettings
to pass directory name.
Refactoring, covered by existing tests.
- WebCore.exp.in: Removed unneeded export.
- loader/EmptyClients.h: Removed now-unneded param. (WebCore::EmptyChromeClient::enumerateChosenDirectory): Ditto.
- page/Chrome.cpp: (WebCore::Chrome::enumerateChosenDirectory): Ditto.
- page/Chrome.h: Ditto.
- page/ChromeClient.h: Ditto.
- platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient): Added discarding of chooser. (WebCore::FileChooserClient::newFileChooser): Added. (WebCore::FileChooserClient::discardChooser): Added. (WebCore::FileChooser::FileChooser): Changed to use FileChooserSettings. (WebCore::FileChooser::create): Ditto. (WebCore::FileChooser::~FileChooser): Removed unneeded code. (WebCore::FileChooser::chooseFiles): Changed to pass results to the client.
- platform/FileChooser.h: (WebCore::FileChooser::settings): Added.
- rendering/RenderFileUploadControl.cpp: (WebCore::filenamesFromFileList): Added a helper. (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use the helper, removed
chooser initialization code.
(WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed disconnection code, now
handled in FileChooserClient.
(WebCore::RenderFileUploadControl::filesChosen): Renamed from valueChanged, rearranged to
fire dispatchFormControlChangeEvent last.
(WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): Changed to use settings.
(WebCore::RenderFileUploadControl::click): Ditto.
(WebCore::RenderFileUploadControl::updateFromElement): Removed now-unneeded check.
(WebCore::RenderFileUploadControl::receiveDroppedFiles): Changed to avoid using the chooser, since
it is not necessary.
(WebCore::RenderFileUploadControl::fileTextValue): Changed to use input data, not chooser data.
- rendering/RenderFileUploadControl.h: Updated decls.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel): Changed to use settings. (WebKit::ChromeClientImpl::enumerateChosenDirectory): Updated decls.
- src/ChromeClientImpl.h:
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel): Changed to use settings.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): Changed to use settings.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): Changed to use settings.
2011-06-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::runOpenPanel): Changed to use settings.
- 7:13 AM Changeset in webkit [89429] by
-
- 14 edits in trunk/Source/WebCore
2011-06-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: DOMAgent.resolveNode should receive objectGroup.
https://bugs.webkit.org/show_bug.cgi?id=63137
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapNode):
- inspector/InjectedScript.h:
- inspector/InjectedScriptSource.js: (.):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resume):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (.): ():
- inspector/front-end/PropertiesSidebarPane.js:
- inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
- 7:08 AM Changeset in webkit [89428] by
-
- 5 edits in trunk/Source/WebCore
2011-06-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix exceptions in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62865
Resource.requestContent callback may be fired after navigation when scripts panel
is already reset.
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged): (WebInspector.DebuggerPresentationModel.prototype._addScript):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory): (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
- inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.reload):
- 7:01 AM Changeset in webkit [89427] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Yuta Kitamura <yutak@chromium.org>
Unreviewed, apply a couple of Chromium test expectation changes to test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [89426] by
-
- 11 edits1 copy1 move2 adds in trunk
2011-06-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242
- GNUmakefile.am: Reference the new ImageDiff GNUmakefile.
2011-06-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242
- GNUmakefile.am: Added new Cairo specific image handling files to the build.
- Shared/API/c/cairo/WKImageCairo.cpp: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp. (WKImageCreateCairoSurface): Added (WKImageCreateFromCairoSurface): Added
- Shared/API/c/cairo/WKImageCairo.h: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp.
2011-06-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242
- DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
- GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
- Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
- WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
- WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent file so that we can share it across platforms. (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
- WebKitTestRunner/TestInvocation.h: Updated method list.
- WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
- WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
- 6:34 AM Changeset in webkit [89425] by
-
- 3 edits in trunk/Source/WebCore
2011-06-21 Michael Saboff <msaboff@apple.com>
Reviewed by Adam Roben.
REGRESSION (r88260): Assertion failure in FontCache::getCachedFontData when typing in Safari's address field
https://bugs.webkit.org/show_bug.cgi?id=63078
Added FontCachePurgePreventer in WebCore::WebCoreTextFloatWidth to handle
assertion failure when typing in address field on windows. Investigated
other possible code paths that need purge prevention. Added
FontCachePurgeProtection to WebCore::createDragImageForLink and
WebCore::doDrawTextAtPoint.
No change to functionality, therefore no new tests.
- platform/win/DragImageWin.cpp: (WebCore::createDragImageForLink):
- platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint): (WebCore::WebCoreTextFloatWidth):
- 5:31 AM Changeset in webkit [89424] by
-
- 3 edits in trunk/Source/WebCore
2011-06-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
A couple setTextAsOfLastFormControlChangeEvent tweaks
https://bugs.webkit.org/show_bug.cgi?id=63108
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): Use emptyString() instead of String("") because it is better style and faster.
- html/HTMLFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent non-virtual so it actually gets inlined, since there are no overrides of it. Also make it take a const String& to avoid unnecessary reference count churn.
- 4:47 AM Changeset in webkit [89423] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed. Update platform specific exprected results after r89367 and r89381.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- platform/qt/svg/custom/pointer-events-text-expected.png:
- platform/qt/svg/custom/pointer-events-text-expected.txt:
- 4:25 AM Changeset in webkit [89422] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Yuta Kitamura <yutak@chromium.org>
Unreviewed, fix a syntax error in the last change in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 4:22 AM Changeset in webkit [89421] by
-
- 2 edits in trunk/Tools
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89414.
http://trac.webkit.org/changeset/89414
https://bugs.webkit.org/show_bug.cgi?id=63130
It broke webkitpy tests (Requested by Ossy on #webkit).
- Scripts/webkitpy/layout_tests/port/base.py:
- 4:15 AM Changeset in webkit [89420] by
-
- 17 edits in trunk/Source/WebCore
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89402.
http://trac.webkit.org/changeset/89402
https://bugs.webkit.org/show_bug.cgi?id=63129
It made 6 tests crash (Requested by Ossy on #webkit).
- dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
- dom/DataTransferItem.h:
- dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
- dom/DataTransferItems.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
- editing/CompositeEditCommand.h:
- page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
- page/WebKitAnimationList.h: (WebCore::WebKitAnimationList::create):
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
- svg/graphics/filters/SVGFilterBuilder.h:
- websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
- websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::Peer::create):
- 4:10 AM Changeset in webkit [89419] by
-
- 9 edits in trunk/Source/WebCore
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89368.
http://trac.webkit.org/changeset/89368
https://bugs.webkit.org/show_bug.cgi?id=63128
It made http/tests/inspector/extensions-resources-
redirect.html crash (Requested by Ossy on #webkit).
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
- 3:52 AM Changeset in webkit [89418] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Yuta Kitamura <yutak@chromium.org>
Unreviewed, add Chromium test expectations for tests started to fail since V8 3.4.5.1 roll.
- platform/chromium/test_expectations.txt:
- 3:22 AM Changeset in webkit [89417] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
https://bugs.webkit.org/show_bug.cgi?id=63124
Fixes a crash when building with --enable-debug.
- webkit/webkitsoupauthdialog.h: Define LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY before including libsoup.h.
- 3:16 AM Changeset in webkit [89416] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
2011-06-22 Yuta Kitamura <yutak@chromium.org>
Unreviewed, check in new Chromium-Leopard baselines.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/pointer-events-text-expected.png: Added.
- 2:35 AM Changeset in webkit [89415] by
-
- 6 edits in trunk/Source/WebCore
2011-06-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use stack trace to create anchors for console messages.
https://bugs.webkit.org/show_bug.cgi?id=62856
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._completions.reportCompletions): (WebInspector.ConsoleView.prototype._completions): (WebInspector.ConsoleMessage.prototype._formatMessage):
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createAnchor):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.createAnchor): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._updateAnchor):
- inspector/front-end/inspector.js: (WebInspector.linkifyResourceAsNode): (WebInspector.linkifyCallFrameAsNode):
- 1:22 AM Changeset in webkit [89414] by
-
- 2 edits in trunk/Tools
2011-06-22 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
Reviewed by Dirk Pranke.
[NRWT] Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=62027
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- 12:12 AM Changeset in webkit [89413] by
-
- 2 edits in trunk/LayoutTests
2011-06-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, whitespace expectations change to trigger a round of
builds.
- platform/chromium/test_expectations.txt:
Jun 21, 2011:
- 11:37 PM Changeset in webkit [89412] by
-
- 3 edits in trunk/Tools
2011-06-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix crashes in new-run-webkit-tests resulting from the
change to the http_server logic in r89400. Python 2.5
on Mac 10.5 has some weird error paths.
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/common/system/executive.py:
- 11:07 PM Changeset in webkit [89411] by
-
- 2 edits1 copy in trunk/LayoutTests
2011-06-21 Kent Tamura <tkent@chromium.org>
[Win][Mac] Correct an accidental change in r89410.
- platform/mac/media/media-controls-clone-expected.txt:
- platform/win/media/media-controls-clone-expected.txt: Copied from LayoutTests/platform/mac/media/media-controls-clone-expected.txt.
- 10:43 PM Changeset in webkit [89410] by
-
- 30 edits in trunk/LayoutTests
2011-06-21 Kent Tamura <tkent@chromium.org>
[Win][GTK] Test expectation update for r89407.
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/placeholder-set-value-expected.txt:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/repaint/search-field-cancel-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
- 10:08 PM Changeset in webkit [89409] by
-
- 14 edits in trunk/LayoutTests
2011-06-21 Kent Tamura <tkent@chromium.org>
[Qt] Test expectation update for r89407.
- platform/qt/fast/css/pseudo-cache-stale-expected.txt:
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/placeholder-set-value-expected.txt:
- platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-styled-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-vertical-alignment-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
- 10:03 PM Changeset in webkit [89408] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Kent Tamura <tkent@chromium.org>
[Chromium] Update expectation for some speech tests.
- platform/chromium/test_expectations.txt:
- 9:36 PM Changeset in webkit [89407] by
-
- 45 edits in trunk
2011-06-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415
Update tests including <input type=search> or <input type=number>. Their
internal structures are changed.
Slight position changes for search result buttons and search cancel
buttons are expected.
- fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/css/input-search-padding-expected.png:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/pseudo-cache-stale-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/placeholder-set-value-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-styled-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- fast/forms/search-cancel-button-mouseup.html: Adjust click position for the cancel button.
- fast/forms/search-abs-pos-cancel-button.html: ditto.
2011-06-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415
If a text field has a search results button, a search cancel
button, a speech button, or a spin button, the editable inner text
element and they are wrapped by a flexible box container, and the
editable inner text element has flexibility.
As the result of applying the flexible box, we don't need any
horizontal layout code in RenderTextControlSingleLine except the
inner spin button.
Also, we remove custom hit-testing code in nodeAtPoint(). If a
user clicks on a position left of the inner editable text but not
on the search results button, the search results button doesn't
work though it worked.
- css/html.css: (input::-webkit-textfield-decoration-container): New style definition for the "container" element. (input[type="search"]::-webkit-search-cancel-button): It should be a block element because it's a child of the flexible box. Also, this doesn't have flexibility. (input[type="search"]::-webkit-search-decoration): ditto. (input[type="search"]::-webkit-search-results-decoration): ditto. (input[type="search"]::-webkit-search-results-button): ditto. (input::-webkit-inner-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::containerElement): Add an accessor of the flexible box container. It just calls InputType::containerElement().
- html/HTMLInputElement.h: Declare it.
- html/InputType.h: (WebCore::InputType::containerElement): New accessor for a shadow element.
- html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): m_innerBlock is moved to TextFieldInputType. (WebCore::SearchInputType::needsContainer): A search field always needs the flexible box container because of the results button and the cancel button. (WebCore::SearchInputType::createShadowSubtree): Use TextFieldInputType::createShadowSubtree(), then modify the tree. (WebCore::SearchInputType::destroyShadowSubtree): m_innerBlock is moved to TextFieldInputType.
- html/SearchInputType.h:
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initialize the new members. (WebCore::TextFieldInputType::needsContainer): Returns true if x-webkit-speech. We check a spin button separately. (WebCore::TextFieldInputType::createShadowSubtree): Wrap everything with the flexible box container if needsContainer() or we need a spin button. (WebCore::TextFieldInputType::containerElement): Added an accessor. (WebCore::TextFieldInputType::innerBlockElement): ditto. (WebCore::TextFieldInputType::innerTextElement): ditto. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear references to new shadow nodes.
- html/TextFieldInputType.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::containerElement): Added an accessor.
(WebCore::RenderTextControlSingleLine::innerTextElement):
(WebCore::RenderTextControlSingleLine::layout):
- Correct heights check Comparing with height(), not contentHeigth(), was incorrect.
- Adjust the container height like the editable inner text.
- Remove width adjustment
- Remove the speech button layout code The flexible box layout is enough.
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
Remove custom code for results/cancel/speech buttons, and
Simplify comments.
(WebCore::RenderTextControlSingleLine::forwardEvent):
Remove custom forwarding code for results/cancel buttons.
(WebCore::RenderTextControlSingleLine::styleDidChange):
Clear the style of the container because we update it in layout().
(WebCore::RenderTextControlSingleLine::hasControlClip):
Decoration buttons should be clipped by the container.
(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
We don't need to use display:inline-block any more.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
The text wrapper element should have flexibility.
(WebCore::RenderTextControlSingleLine::textBlockInsetTop):
Updated for the tree structure change.
- rendering/RenderTextControlSingleLine.h:
- 9:15 PM Changeset in webkit [89406] by
-
- 25 edits in trunk
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- configure.ac:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- Configurations/FeatureDefines.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- features.pri:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- Configurations/FeatureDefines.xcconfig:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- Configurations/FeatureDefines.xcconfig:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- Scripts/build-webkit:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 9:00 PM Changeset in webkit [89405] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Yuta Kitamura <yutak@chromium.org>
Unreviewed, remove duplicate Chromium test expectation.
- platform/chromium/test_expectations.txt:
- 8:41 PM Changeset in webkit [89404] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-21 Yuta Kitamura <yutak@chromium.org>
Unreviewed. Update Chromium test expectations and baselines.
- platform/chromium-win/fast/css/color-leakage-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [89403] by
-
- 6 edits in trunk
2011-06-21 Kent Tamura <tkent@chromium.org>
[Mac] Sort Xcode project files.
- JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-21 Kent Tamura <tkent@chromium.org>
[Mac] Sort Xcode project files.
- WebCore.xcodeproj/project.pbxproj:
2011-06-21 Kent Tamura <tkent@chromium.org>
[Mac] Sort Xcode project files.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 7:36 PM Changeset in webkit [89402] by
-
- 17 edits in trunk/Source/WebCore
2011-06-21 Darin Adler <Darin Adler>
Reviewed by Ryosuke Niwa.
RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955
- dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
- dom/DataTransferItem.h:
- dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
- dom/DataTransferItems.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
- editing/CompositeEditCommand.h:
- page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
- page/WebKitAnimationList.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
- svg/graphics/filters/SVGFilterBuilder.h:
- websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
- websockets/WorkerThreadableWebSocketChannel.h: Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.
- 7:27 PM Changeset in webkit [89401] by
-
- 23 edits in trunk
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
- configure.ac:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
No new tests, changing only build related files
- Configurations/FeatureDefines.xcconfig:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
No new tests, changing only build related files
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- features.pri:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
No new tests, changing only build related files
- Configurations/FeatureDefines.xcconfig:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
No new tests, changing only build related files
- Configurations/FeatureDefines.xcconfig:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
- Scripts/build-webkit:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 7:20 PM Changeset in webkit [89400] by
-
- 9 edits1 add in trunk/Tools
2011-06-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: attempt #3 at fixing server startup/shutdown
https://bugs.webkit.org/show_bug.cgi?id=62829
Attempt yet again to make starting and stopping servers
reliable. It turns out that apache has races between when the
ctl process exists and when it writes/removes the pid file.
This change accounts for the races.
- Scripts/new-run-webkit-httpd:
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 6:04 PM Changeset in webkit [89399] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-06-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
bugs.webkit.org should use Strict-Transport-Security
https://bugs.webkit.org/show_bug.cgi?id=63097
Strict-Transport-Security forces all connections to bugs.webkit.org to
use HTTPS, preventing sslstrip and other attacks.
- .htaccess:
- 5:50 PM Changeset in webkit [89398] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-21 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
https://bugs.webkit.org/show_bug.cgi?id=63098
<rdar://problem/9645393>
Force a repaint after completing entering full-screen mode only after the notification
is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
layer again during the repaint.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
- 5:40 PM Changeset in webkit [89397] by
-
- 3 edits3 adds in trunk
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093
Test: fast/css/color-leakage.html
- platform/graphics/cg/GraphicsContextCG.cpp: Swap out CGContextSave/Restore with GraphicsContext::save/restore to keep the context in sync with its CG context (WebCore::GraphicsContext::beginTransparencyLayer): Added save(), removed redundant calls. (WebCore::GraphicsContext::endTransparencyLayer): Added restore(), removed redundant calls.
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093
- fast/css/color-leakage.html: Added pixel regression test that previously would have the border's color spilling into the text.
- platform/mac/fast/css/color-leakage-expected.png: Added.
- platform/mac/fast/css/color-leakage-expected.txt: Added.
- 5:26 PM Changeset in webkit [89396] by
-
- 17 edits8 adds in trunk
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
Add a new script-test, but skip it on all platforms since we don't
build with ENABLE_CSS3_FLEXBOX anywhere.
- css3/flexbox/flex-parsing-expected.txt: Added.
- css3/flexbox/flex-parsing.html: Added.
- css3/flexbox/script-tests/TEMPLATE.html: Added.
- css3/flexbox/script-tests/flex-parsing.js: Added. (testFlex):
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
Test: css3/flexbox/flex-parsing.html
- CMakeLists.txt: Add CSSFlexValue.*
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSFlexValue.cpp: Added. (WebCore::CSSFlexValue::~CSSFlexValue): (WebCore::CSSFlexValue::cssText):
- css/CSSFlexValue.h: Added. (WebCore::CSSFlexValue::create): Hold positive flex, negative flex and sizing. (WebCore::CSSFlexValue::CSSFlexValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValidPrimitive): Pull out code from parseValue. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFlex): Parse the different version of flex().
- css/CSSParser.h:
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
- features.gypi: Add a gyp flag (enable_css3_flexbox) for setting ENABLE_CSS3_FLEXBOX.
- 5:09 PM Changeset in webkit [89395] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Ryosuke Niwa <rniwa@webkit.org>
Remove failing test expectations from various tests for Chromium Windows.
- platform/chromium/test_expectations.txt:
- 4:52 PM Changeset in webkit [89394] by
-
- 4 edits3 adds in trunk
2011-06-21 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181
- compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
- compositing/layer-creation/overlap-transformed-layer.html: Added.
2011-06-21 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMapRecursive): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
- 4:46 PM Changeset in webkit [89393] by
-
- 13 edits4 adds in trunk
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
- fast/canvas/webgl/webgl-specific-expected.txt:
- fast/canvas/webgl/webgl-specific.html: Test drawingBufferWidth/Height attributes.
- fast/canvas/webgl/canvas-zero-size-expected.txt:
- fast/canvas/webgl/canvas-zero-size.html: Added.
- fast/canvas/webgl/drawingbuffer-test-expected.txt:
- fast/canvas/webgl/drawingbuffer-test.html: Added.
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
- src/GraphicsContext3DChromium.cpp: Make getInternalFramebufferSize method const. (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize): (WebCore::GraphicsContext3D::getInternalFramebufferSize):
- src/GraphicsContext3DInternal.h:
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
- html/canvas/WebGLRenderingContext.cpp: Add drawingBufferWidth/Height method and call getInternalFramebufferSize(). (WebCore::WebGLRenderingContext::drawingBufferWidth): (WebCore::WebGLRenderingContext::drawingBufferHeight):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl: Add readonly attributes drawingBufferWidth/Height.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Make getInternalFramebufferSize const. (WebCore::GraphicsContext3D::getInternalFramebufferSize):
- platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto. (WebCore::GraphicsContext3D::getInternalFramebufferSize):
- 4:39 PM Changeset in webkit [89392] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-06-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved 'const' off the global-variable-as-local-variable crack pipe
https://bugs.webkit.org/show_bug.cgi?id=63105
This is necessary for moving the rest of the code off of same.
Many problems remain in our handling of const. I have fixed none of them.
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::scopeChain): New accessor, needed to enable const to directly implement its unique scoping rules.
- bytecompiler/NodesCodegen.cpp: (JSC::PrefixResolveNode::emitBytecode): Do specify that our resolve is for writing, so we don't overwrite const variables.
(JSC::ConstDeclNode::emitCodeSingle): Don't assume that all declared const
variables are available as local variables, since this won't be the case
once global variables are not available as local variables. Instead, use
put_scoped_var in the case where there is no local variable. Like a local
variable, put_scoped_var succeeds even though const properties are
read-only, since put_scoped_var skips read-only checks. (Yay?)
- 4:12 PM Changeset in webkit [89391] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
- platform/chromium/test_expectations.txt:
- 4:09 PM Changeset in webkit [89390] by
-
- 8 edits in trunk/Source
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
This moves StringCache into V8BindingPerIsolateData.
- bindings/v8/V8Binding.cpp: (WebCore::cachedStringCallback): (WebCore::StringCache::remove): (WebCore::StringCache::v8ExternalStringSlow):
- bindings/v8/V8Binding.h: (WebCore::StringCache::StringCache): (WebCore::StringCache::v8ExternalString): (WebCore::StringCache::clearOnGC): (WebCore::V8BindingPerIsolateData::stringCache): (WebCore::v8ExternalString):
- bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
- src/WebKit.cpp: (WebKit::initialize): Initialize V8PerIsolateBindingData eagerly
- src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode): StringCache is now per-isolate, so ok in multithreaded contexts.
- 3:51 PM Changeset in webkit [89389] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Adjust some GPU test expectations to match bot reality.
- platform/chromium/test_expectations.txt:
- 3:51 PM Changeset in webkit [89388] by
-
- 2 edits in trunk/Source/WebCore
Clang build fix.
- platform/mac/WebCoreSystemInterface.h: Give the enum a name.
- 3:35 PM Changeset in webkit [89387] by
-
- 3 edits in trunk/Source/WebCore
Fix Mac build in some configurations.
- platform/mac/WebCoreSystemInterface.h: Added an enum matching WKSI one, since we cannot use WKSI in WebCore.
- platform/mac/WebVideoFullscreenHUDWindowController.mm: Removed an include of WebKitSystemInterface.h. It's not meant to be used from WebCore, and if included, a wrong copy may be used. (createControlWithMediaUIControlType): Added a FIXME about problems with Leopard build. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Ditto. Switched enum values to WCSI style (lower level "wk").
- 3:31 PM Changeset in webkit [89386] by
-
- 27 edits1 delete in trunk
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::destroyInspectorView):
- WebCoreSupport/WebInspectorClient.h:
- WebInspector.cpp: (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::webViewClosed): (WebInspector::showConsole): (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript): (WebInspector::isProfilingJavaScript): (WebInspector::toggleProfilingJavaScript): (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled): (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
- WebInspector.h:
- WebView.cpp: (WebView::WebView): (WebView::close): (WebView::initWithFrame): (WebView::inspector):
- WebView.h:
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController destroyInspectorView:]):
- WebInspector/WebInspector.mm: (-show:): (-showConsole:): (-isDebuggingJavaScript): (-toggleDebuggingJavaScript:): (-startDebuggingJavaScript:): (-stopDebuggingJavaScript:): (-isProfilingJavaScript): (-toggleProfilingJavaScript:): (-startProfilingJavaScript:): (-stopProfilingJavaScript:): (-isJavaScriptProfilingEnabled): (-setJavaScriptProfilingEnabled:): (-isTimelineProfilingEnabled): (-setTimelineProfilingEnabled:): (-setFrontend:): (-showWindow:):
- WebInspector/WebInspectorFrontend.h:
- WebInspector/WebInspectorFrontend.mm:
- WebInspector/WebInspectorPrivate.h:
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
- inspector/InspectorFrontendClientLocal.h:
- inspector/front-end/InspectorFrontendAPI.js: Removed.
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._enableProfiling):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:28 PM Changeset in webkit [89385] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations after r89381.
- platform/chromium-linux/svg/custom/pointer-events-text-expected.png:
- platform/chromium-win/svg/custom/pointer-events-text-expected.png:
- platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
- 2:31 PM Changeset in webkit [89384] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Add an internal API for accessing the QGraphicsView.
https://bugs.webkit.org/show_bug.cgi?id=63095
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::ownerWidget):
- UIProcess/API/qt/qwkpage_p.h:
- 2:20 PM Changeset in webkit [89383] by
-
- 3 edits2 adds in trunk
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087
- storage/indexeddb/objectStore-required-arguments-expected.txt: Added.
- storage/indexeddb/objectStore-required-arguments.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087
Test: storage/indexeddb/objectStore-required-arguments.html
- storage/IDBObjectStore.idl: Remove LegacyDefaultOptionalArguments flag so missing required arguments will throw TypeError, as per WebIDL spec.
- 2:18 PM Changeset in webkit [89382] by
-
- 2 edits1 add7 deletes in trunk/LayoutTests
2011-06-21 Wyatt Carss <wcarss@chromium.org>
Reviewed by Ryosuke Niwa.
convert editing/deleting/delete-3608430-fix.html to DumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=62823
Fixed a superfluous quote, added a doctype, fixed a broken reference to 'abe.gif'
(now points to abe.png, in the correct location), added a description, and converted
to a DumpAsTextEditingTest. This test checks that deletion over an image will correctly
remove an empty element before the image.
- editing/deleting/delete-3608430-fix-expected.txt: Added.
- editing/deleting/delete-3608430-fix.html:
- platform/chromium-linux/editing/deleting/delete-3608430-fix-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-3608430-fix-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Removed.
- platform/mac/editing/deleting/delete-3608430-fix-expected.png: Removed.
- platform/mac/editing/deleting/delete-3608430-fix-expected.txt: Removed.
- platform/qt/editing/deleting/delete-3608430-fix-expected.txt: Removed.
- 2:13 PM Changeset in webkit [89381] by
-
- 6 edits in trunk
2011-06-21 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209
Update test results (improvement).
- platform/mac/svg/custom/pointer-events-text-expected.png:
- platform/mac/svg/custom/pointer-events-text-expected.txt:
2011-06-21 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209
Use PointerEventsHitRules to make hit-testing for SVG text inline boxes work.
No new tests; covered by existing test pointer-events-text.svg.
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
- rendering/svg/SVGInlineTextBox.h:
- 2:09 PM Changeset in webkit [89380] by
-
- 3 edits2 adds in trunk
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085
- storage/indexeddb/keyrange-required-arguments-expected.txt: Added.
- storage/indexeddb/keyrange-required-arguments.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085
Test: storage/indexeddb/keyrange-required-arguments.html
- storage/IDBKeyRange.idl: remove LegacyDefaultOptionalArguments flag so missing required arguments throw TypeError, as per WebIDL spec.
- 2:08 PM Changeset in webkit [89379] by
-
- 3 edits3 deletes in trunk/LayoutTests
[Chromium] Unreviewed, updating test expectations after r89367,
fixing typo in test_expectations.txt
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
- platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
- platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:07 PM Changeset in webkit [89378] by
-
- 5 edits in trunk
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
- storage/indexeddb/database-name-undefined-expected.txt:
- storage/indexeddb/database-name-undefined.html:
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
- storage/IDBFactory.idl: remove LegacyDefaultOptionalArguments flag and fix function argument flags
- 1:57 PM Changeset in webkit [89377] by
-
- 3 edits2 adds in trunk
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
- storage/indexeddb/index-get-key-argument-required-expected.txt: Added.
- storage/indexeddb/index-get-key-argument-required.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
Test: storage/indexeddb/index-get-key-argument-required.html
- storage/IDBIndex.idl: remove LegacyDefaultOptionalArguments flag so missing required arguments throw a TypeError as per WebIDL spec.
- 1:54 PM Changeset in webkit [89376] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-06-21 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
Wire in checkIfRunInsecureContent to the chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=63026
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::checkIfRunInsecureContent): add in basic plumbing.
- src/WebFrameImpl.h:
- 1:42 PM Changeset in webkit [89375] by
-
- 3 edits2 adds in trunk
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032
- storage/indexeddb/cursor-update-value-argument-required-expected.txt: Added.
- storage/indexeddb/cursor-update-value-argument-required.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032
Test: storage/indexeddb/cursor-update-value-argument-required.html
- storage/IDBCursor.idl: remove LegacyDefaultOptionalArguments flag so calling functions with missing required arguments will raise a TypeError
- 1:30 PM Changeset in webkit [89374] by
-
- 4 edits in trunk
2011-06-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045
- platform/gtk/Skipped: Unskip tests that are now passing.
2011-06-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045
Use prepareForFilling and prepareForStroking when rendering the shadowed
image of a path. This ensures that the shadowed image has the proper alpha.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): Properly prepare the shadow image.
- 12:58 PM Changeset in webkit [89373] by
-
- 2 edits in trunk/Tools
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=63080
Unit-tests step on test-only bot is broken.
Removing the step until run-api-tests is fixed.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 12:52 PM Changeset in webkit [89372] by
-
- 14 edits1 delete in trunk
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049
- inspector/profiler/detailed-heapshots-test.js:
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
- inspector/Inspector.json:
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
- inspector/InspectorProfilerAgent.h:
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.get profile): (WebInspector.DetailedHeapshotView.prototype.get baseProfile): (WebInspector.DetailedHeapshotView.prototype._profiles): (WebInspector.DetailedHeapshotProfileType): (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
- inspector/front-end/HeapSnapshotView.js: Removed.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/heapProfiler.css:
- inspector/front-end/inspector.html:
- 12:30 PM Changeset in webkit [89371] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63052
Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.
- parser/JSParser.cpp: (JSC::JSParser::updateErrorMessage): (JSC::JSParser::updateErrorWithNameAndMessage):
- 12:29 PM Changeset in webkit [89370] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
2011-06-21 Dmitry Titov <dimich@chromium.org>
[Chromium] Not reviewed, updating expectations for a flaky test.
- platform/chromium/test_expectations.txt:
- 12:18 PM Changeset in webkit [89369] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004
Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can
be accepted by QDrag.
Call event->accepted() and not event->acceptProposedAction(), because the
later ignores the dropAction specified in JavaScript.
Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
and did not see any issue.
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
and they all pass.
- Api/qwebpage.cpp: (dropActionToDragOp): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent):
- 11:16 AM Changeset in webkit [89368] by
-
- 9 edits in trunk/Source/WebCore
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
- 11:14 AM Changeset in webkit [89367] by
-
- 7 edits3 adds in trunk
2011-06-21 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085
Check for AnimatedString, AnimatedBoolean and AnimatedEnumeration on 'values' calculation.
If the property type matches one of the above values, fallback to discrete animation.
The patch also changes behavior for String animation. The animation code doesn't handle inheritance
for strings anymore. This is done by the CSS parser itself now, we just need to handle inheritance
on animations that interpolate between two values like for calcMode="linear".
Test: svg/animations/svgstring-animation-fallback-to-discrete.html
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue):
- svg/SVGAnimateElement.h:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
2011-06-21 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085
Added new test to check fallback to discrete animations on string values. One
test needed rebaseline. Even if we do not pass the test it is still a progression.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svgstring-animation-fallback-to-discrete-expected.txt: Added.
- svg/animations/svgstring-animation-fallback-to-discrete.html: Added.
- 11:05 AM Changeset in webkit [89366] by
-
- 2 edits in trunk/Source/WebCore
2011-06-21 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Update GraphicsContextSkia when the Chromium platform is Mac
https://bugs.webkit.org/show_bug.cgi?id=62867
No new tests. This does not modify existing code;
there is no change in functionality.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::drawOuterPath): (WebCore::drawInnerPath): (WebCore::getFocusRingOutset): (WebCore::GraphicsContext::drawFocusRing): The OS X framework draws a fatter focus ring than the Chromium port. Increase the diameter, and add an inner stroke with more transparency, to match the look of Chromium on Mac when Skia is the rendering engine.
(WebCore::deviceRGBColorSpaceRef):
Add deviceRGBColorSpaceRef, a static cache of
CGColorSpaceCreateDeviceRGB(). This is called by
the Mac-specific UI when Skia is the rendering engine.
- 11:04 AM Changeset in webkit [89365] by
-
- 3 edits3 copies in branches/chromium/782
Merge 87846 - 2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317
Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.
Test: svg/text/scaling-font-with-geometric-precision.html
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317
Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.
- platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
- svg/text/scaling-font-with-geometric-precision.html: Added.
TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/7218014
- 11:03 AM Changeset in webkit [89364] by
-
- 2 edits in trunk/Source/WebCore
2011-06-21 Tony Chang <tony@chromium.org>
Try to fix WinCE build. Replace cat with perl -ne "print".
- CMakeLists.txt:
- 10:47 AM Changeset in webkit [89363] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Adding version of fast/events/offsetX-offsetY.html without text run or line height deps
https://bugs.webkit.org/show_bug.cgi?id=63073
- fast/events/document-elementFromPoint-expected.txt: Added.
- fast/events/document-elementFromPoint.html: Added.
- 10:32 AM Changeset in webkit [89362] by
-
- 15 edits in trunk/Source/WebCore
2011-06-21 Alexandru Chiculita <Alexandru Chiculita>
Reviewed by Tony Chang.
"WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should take ENABLE_ flags into account
https://bugs.webkit.org/show_bug.cgi?id=62114
Changed the line commenting style in WebCore/css/*.in files from "#" prefixed to "" prefixed.
That's needed because we now pre-process the files with the C++ pre-processor. Also, there's
no need to manually strip the comments anymore.
Moved the duplication checks from project files to makeprop.pl and makevalues.pl.
In addition makevalues.pl will also lower case the values.
This is a build script refactoring, so no tests are provided.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_csspropertynames.py:
- WebCore.gyp/scripts/action_cssvaluekeywords.py:
- css/CSSPropertyNames.in: comment style only
- css/CSSValueKeywords.in: comment style only
- css/SVGCSSPropertyNames.in: comment style only
- css/SVGCSSValueKeywords.in: comment style only
- css/WCSSValueKeywords.in: comment style only
- css/makeprop.pl:
- css/makevalues.pl:
- 10:30 AM Changeset in webkit [89361] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-21 Ryosuke Niwa <rniwa@webkit.org>
Rolled DEPS.
- DEPS:
- 9:59 AM Changeset in webkit [89360] by
-
- 4 edits in trunk/Source/WebKit2
2011-06-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Sam Weinig.
[GTK] [WK2] WebKit2 build break fixes.
https://bugs.webkit.org/show_bug.cgi?id=62950
When building WebKit2 for GTK there are few build breaks connected with missing include files.
- Platform/unix/SharedMemoryUnix.cpp:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
- UIProcess/API/gtk/PageClientImpl.cpp:
- 9:00 AM Changeset in webkit [89359] by
-
- 2 edits in trunk/Source/WebCore
2011-06-21 Peter Varga <pvarga@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
https://bugs.webkit.org/show_bug.cgi?id=61187
No new tests needed.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
- 8:58 AM Changeset in webkit [89358] by
-
- 6 edits in trunk/Source/WebCore
2011-06-21 Peter Varga <pvarga@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8] Enable marking objects with complex GC rules
https://bugs.webkit.org/show_bug.cgi?id=61291
No new tests needed.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 8:17 AM Changeset in webkit [89357] by
-
- 1 edit in branches/chromium/782/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
Merge 89344 - 2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Fix path finding to window objects.
https://bugs.webkit.org/show_bug.cgi?id=63051
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/7224001
- 8:11 AM Changeset in webkit [89356] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Remove a now-passing test from chromium's text_expectations. Also
comment out expectations for a few newly-added tests which were
removed by a revert. This makes lint-test-files run cleanly.
- platform/chromium/test_expectations.txt:
- 7:45 AM Changeset in webkit [89355] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Removing a now-passing test from chromium's test_expectations.
- platform/chromium/test_expectations.txt:
- 7:32 AM Changeset in webkit [89354] by
-
- 27 edits1 add in trunk
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::isDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::setDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::startProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::evaluateAsBoolean): (WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
- inspector/InspectorFrontendClientLocal.h:
- inspector/front-end/InspectorFrontendAPI.js: Added. (InspectorFrontendAPI.isDebuggingEnabled): (InspectorFrontendAPI.setDebuggingEnabled): (InspectorFrontendAPI.isJavaScriptProfilingEnabled): (InspectorFrontendAPI.setJavaScriptProfilingEnabled): (InspectorFrontendAPI.isTimelineProfilingEnabled): (InspectorFrontendAPI.setTimelineProfilingEnabled): (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript): (InspectorFrontendAPI.setAttachedWindow):
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.isRecordingProfile): (WebInspector.CPUProfileType.prototype.startRecordingProfile): (WebInspector.CPUProfileType.prototype.stopRecordingProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get profilerEnabled): (WebInspector.ProfilesPanel.prototype.enableProfiler): (WebInspector.ProfilesPanel.prototype.disableProfiler):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get debuggingEnabled): (WebInspector.ScriptsPanel.prototype.enableDebugging): (WebInspector.ScriptsPanel.prototype.disableDebugging): (WebInspector.ScriptsPanel.prototype.toggleDebugging):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected): (WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled): (WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController destroyInspectorView:]):
- WebInspector/WebInspector.mm: (-showWindow): (-show:): (-showConsole:): (-isDebuggingJavaScript): (-toggleDebuggingJavaScript:): (-startDebuggingJavaScript:): (-stopDebuggingJavaScript:): (-isProfilingJavaScript): (-toggleProfilingJavaScript:): (-startProfilingJavaScript:): (-stopProfilingJavaScript:): (-isJavaScriptProfilingEnabled): (-setJavaScriptProfilingEnabled:): (-isTimelineProfilingEnabled): (-setTimelineProfilingEnabled:): (-setFrontend:): (-releaseFrontend): (-showWindow:):
- WebInspector/WebInspectorFrontend.h:
- WebInspector/WebInspectorFrontend.mm: (-[WebInspectorFrontend isDebuggingEnabled]): (-[WebInspectorFrontend setDebuggingEnabled:]): (-[WebInspectorFrontend isProfilingJavaScript]): (-[WebInspectorFrontend startProfilingJavaScript]): (-[WebInspectorFrontend stopProfilingJavaScript]): (-[WebInspectorFrontend isJavaScriptProfilingEnabled]): (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]): (-[WebInspectorFrontend isTimelineProfilingEnabled]): (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
- WebInspector/WebInspectorPrivate.h:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
- WebInspector.cpp: (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::webViewClosed): (WebInspector::showConsole): (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript): (WebInspector::isProfilingJavaScript): (WebInspector::toggleProfilingJavaScript): (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled): (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
- WebInspector.h:
- WebView.cpp: (WebView::WebView): (WebView::close): (WebView::initWithFrame): (WebView::inspector):
- WebView.h:
- 7:28 AM Changeset in webkit [89353] by
-
- 6 edits in trunk/Source
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068
For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).
- bindings/v8/V8Binding.cpp: (WebCore::enableStringImplCache): (WebCore::getStringCache): (WebCore::cachedStringCallback): (WebCore::v8ExternalStringSlow):
- bindings/v8/V8Binding.h: (WebCore::v8ExternalString):
- bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue):
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068
For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).
- src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
- 7:16 AM Changeset in webkit [89352] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Skip a test that takes too long on the GPU.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [89351] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-06-20 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
New test for patch introduced in r89250
https://bugs.webkit.org/show_bug.cgi?id=63016
- fast/canvas/script-tests/text-globalAlpha.js: Added.
- fast/canvas/text-globalAlpha-expected.txt: Added.
- fast/canvas/text-globalAlpha.html: Added.
- 6:25 AM Changeset in webkit [89350] by
-
- 14 edits in trunk/Source/WebCore
2011-06-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename editScriptSource to setScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=63059
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setScriptSource):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/DebuggerScript.js: ():
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setScriptSource):
- bindings/v8/ScriptDebugServer.h:
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setScriptSource):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setScriptSource):
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.setScriptSource): (WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
- inspector/front-end/Script.js: (WebInspector.Script.prototype.editSource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.editContent): (WebInspector.SourceFrameDelegate.prototype.setScriptSource):
- 6:00 AM Changeset in webkit [89349] by
-
- 8 edits2 adds in trunk
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992
- http/tests/inspector/network/network-cachedresources-with-same-urls.html: Added.
- http/tests/inspector/network/resources/resource.php:
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992
Test: http/tests/inspector/network/network-cachedresources-with-same-urls.html
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::getResourceContent):
- inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::addCachedResource):
- inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::cachedResource): (WebCore::NetworkResourcesData::ResourceData::setCachedResource):
- 5:38 AM Changeset in webkit [89348] by
-
- 3 edits in trunk/Source/WebCore
2011-06-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Attached state changes do not affect the drawer height
https://bugs.webkit.org/show_bug.cgi?id=63061
- inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.enterPanelMode): (WebInspector.Drawer.prototype.exitPanelMode): (WebInspector.Drawer.prototype.updateHeight):
- inspector/front-end/inspector.js: (WebInspector.set attached):
- 5:29 AM Changeset in webkit [89347] by
-
- 4 edits in trunk/LayoutTests
2011-06-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Chromium layout test failure after r89317
https://bugs.webkit.org/show_bug.cgi?id=63031
Event Listener sidebar output prints out the full path
to the source file in the sourceName property. For testing
purposes, since the path will be different per system,
clip the early part of the path and leave the expected part.
- http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementEventListeners): (initialize_ElementTest.InspectorTest.dumpObjectPropertySection):
- platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:
- 3:30 AM Changeset in webkit [89346] by
-
- 6 edits in trunk
2011-06-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
- inspector/debugger/debugger-pause-on-breakpoint-expected.txt:
- inspector/debugger/debugger-pause-on-breakpoint.html:
2011-06-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
- 2:58 AM Changeset in webkit [89345] by
-
- 15 edits3 adds in trunk
2011-06-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996
- http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt: Added.
- http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html: Added.
- http/tests/inspector-enabled/resources/console-clear-arguments-iframe.html: Added.
2011-06-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996
When DOMWindow is detached from its frame run through all console messages and clear
their arguments and ScriptState references. The message text in this case will be
the first argument serialized to string.
Test: http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html
- bindings/js/ScriptState.cpp: (WebCore::domWindowFromScriptState):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::domWindow): (WebCore::domWindowFromScriptState):
- bindings/v8/ScriptState.h:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::windowCleared):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::discardInjectedScriptsFor):
- inspector/InjectedScriptManager.h:
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::domWindowCleared):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::pageDestroyedImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::pageDestroyed):
- page/DOMWindow.cpp: (WebCore::DOMWindow::pageDestroyed):
- 2:51 AM Changeset in webkit [89344] by
-
- 2 edits in trunk/Source/WebCore
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Fix path finding to window objects.
https://bugs.webkit.org/show_bug.cgi?id=63051
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
- 1:56 AM Changeset in webkit [89343] by
-
- 2 edits in trunk/LayoutTests
2011-06-21 Yuta Kitamura <yutak@chromium.org>
Unreviewed, update Chromium test expectations for some flaky tests.
- platform/chromium/test_expectations.txt:
- 1:43 AM Changeset in webkit [89342] by
-
- 2 edits in trunk/Source/WebCore
2011-06-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: hovering over linkified nodes
in the UI does not highlight elements on the page.
https://bugs.webkit.org/show_bug.cgi?id=60630
- inspector/front-end/inspector.js: (WebInspector.wireElementWithDOMNode):
- 12:10 AM Changeset in webkit [89341] by
-
- 68 edits9 deletes in trunk/LayoutTests
[Qt] Unreviewed rollout r89237, r89238 and part of r89243,
because the original patch r89233 was rolled out by r89320.
