Timeline
Jun 25, 2011:
- 11:33 PM Changeset in webkit [89764] by
-
- 4 edits in trunk
2011-06-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
2011-06-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::queueLoad):
- 10:43 PM Changeset in webkit [89763] by
-
- 13 edits10 adds in trunk/LayoutTests
2011-06-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: new chromium baselines.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
- platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-linux/svg/custom/linking-uri-01-b-expected.png: Added.
- platform/chromium-linux/svg/custom/linking-uri-01-b-expected.txt: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
- platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt:
- platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.txt:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/chromium-win/svg/custom/linking-uri-01-b-expected.png: Added.
- platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt: Added.
- 9:33 PM Changeset in webkit [89762] by
-
- 4 edits2 adds in trunk
2011-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393
- fast/dom/shadow/frameless-media-element-crash.html: Added.
- fast/dom/shadow/frameless-media-element-crash-expected.txt: Added.
2011-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393
Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
in the calling code.
Test: fast/dom/shadow/frameless-media-element-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created. (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation. (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
- html/HTMLMediaElement.h: Adjusted def.
- 9:09 PM Changeset in webkit [89761] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-25 Adam Barth <abarth@webkit.org>
Roll Chromium DEPS.
- DEPS:
- 9:04 PM Changeset in webkit [89760] by
-
- 3 edits in trunk/Source/WebCore
2011-06-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Fix some minor style issues
https://bugs.webkit.org/show_bug.cgi?id=63391
- inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): The explicit WebCore namespace usage can be dropped.
- rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): Use ASSERT_UNUSED for a parameter that we want to ASSERT on for a debug build, but is UNUSED in a release build.
- 5:39 PM Changeset in webkit [89759] by
-
- 3 edits in trunk/Tools
Unreviewed build correction after r89426.
- WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Link with Cairo DLL for new functionality.
- WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility code for snprintf.
- 5:36 PM Changeset in webkit [89758] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build correction after r89426.
- Shared/API/c/cairo/WKImageCairo.h: Declare cairo type as struct (in keeping with other declarations).
- win/WebKit2.vcproj: Add new WKImageCairo.cpp file to WinCairo build.
- 5:22 PM Changeset in webkit [89757] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build correction after r89503.
See http://trac.webkit.org/changeset/89503. The modifications
to the WebKit2.def need to be mirrored in WebKit2CFLite.def.
- win/WebKit2CFLite.def: Add new exported symbol for isPreloaded.
- 4:32 PM Changeset in webkit [89756] by
-
- 2 edits in trunk/Source/WebCore
2011-06-25 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed build fix.
Use UNUSED_PARAM on the correct param!
- rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
- 4:10 PM Changeset in webkit [89755] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build correction after r89426.
See http://trac.webkit.org/changeset/89426. The new WebKit2
header file (WKImageCairo.h) is needed.
- win/WebKit2Generated.make: Make sure to copy the WKImageCairo.h
header file to the WebKit2 API directory after building.
- 4:01 PM Changeset in webkit [89754] by
-
- 22 edits in trunk/Source/WebCore
2011-06-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Simon Fraser.
Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627
Part 2: Only adjust for the FrameView's scroll position when
the localToAbsolute mapping did not end with fixed content.
Content that is inside of a fixed position container is already
adjusted for the FrameView's scrollPosition when RenderView
maps local to container.
This patch uses a "wasFixed" out parameter to determine if
the localToAbsolute transformation ended inside a fixed block,
and if so does not apply the scroll position.
- page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): Respect wasFixed as described above.
- rendering/RenderBox.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): This is the only time that "fixed" ever changed. So when fixed changes, update the optional wasFixed out parameter.
- rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
- rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): Ignore wasFixed by default, but pipe it though where needed.
- rendering/RenderView.h:
- rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): This is the final recursive call, so wasFixed goes no further. We sanity check its value in debug builds.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint):
- rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderInline.h:
- rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
- rendering/svg/RenderSVGText.h:
- rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
- rendering/svg/SVGRenderSupport.h: Pipe wasFixed through where needed.
- 4:01 PM Changeset in webkit [89753] by
-
- 8 edits in trunk/Source/WebCore
2011-06-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Simon Fraser.
Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627
Part 1: Provide FloatQuad versions of convertFromRenderer,
convertToContainingView, and convertChildToSelf, so that we
can get the fully transformed quad of a renderer all the
way up to the root widget.
- page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToContainingView):
- page/FrameView.h:
- platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf):
- platform/Widget.h:
- platform/Widget.cpp: (WebCore::Widget::convertToContainingView): Provide FloatQuad versions of these already existing functions.
(WebCore::Widget::convertToRootContainingView):
Provide a helper conversion function to recursively
convert a given FloatQuad up to the root widget.
- inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): Use the new methods to convert the FloatQuad for the highlighted node to the root container, without losing transformation information. Add a FIXME for SVG, which is still broken.
- WebCore.exp.in: Export the new Widget functions so WebKit can link properly.
- 3:16 PM Changeset in webkit [89752] by
-
- 2 edits in trunk/Source/WebCore
2011-06-25 Dirk Schulze <krit@webkit.org>
Unreviewed build fix.
SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387
- svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
- 3:08 PM Changeset in webkit [89751] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-25 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Remove ifdefs around these two functions because
we're not planning to move them. This patch makes WebFrameImpl.h
consistent with WebFrame.h so we can build with the new API
configuration.
- src/WebFrameImpl.h:
- 3:02 PM Changeset in webkit [89750] by
-
- 15 edits7 adds in trunk
2011-06-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumberList.
Animations of attributes with type SVGNumberList can be interpolated now.
Tests: svg/animations/svgnumberlist-animation-1.html
svg/animations/svgnumberlist-animation-2.html
- CMakeLists.txt: Added new file to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
- svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedNumber): Made method static for reuse in SVGAnimatedNumberList (and SVGAnimatedNumberOptionalNumber later). (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): Use new static function.
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.cpp: Added. New animator for SVGNumberList. (WebCore::SVGAnimatedNumberListAnimator::SVGAnimatedNumberListAnimator): (WebCore::SVGAnimatedNumberListAnimator::constructFromString): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberListAnimator::calculateDistance):
- svg/SVGAnimatedNumberList.h: (WebCore::SVGAnimatedNumberListAnimator::~SVGAnimatedNumberListAnimator):
- svg/SVGAnimatedType.cpp: Use new Animator. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberList): (WebCore::SVGAnimatedType::numberList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
2011-06-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387
Test animation of attributes with type SVGNumberList.
- svg/animations/script-tests/svgnumberlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svgnumberlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svgnumberlist-animation-1-expected.txt: Added.
- svg/animations/svgnumberlist-animation-1.html: Added.
- svg/animations/svgnumberlist-animation-2-expected.txt: Added.
- svg/animations/svgnumberlist-animation-2.html: Added.
- 2:36 PM Changeset in webkit [89749] by
-
- 16 edits2 adds in trunk/Source/WebCore
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336
Convert <animate attributeName="d"> parsing to the new SVGAnimatorFactory concept, removing
the last special data types from SVGAnimateElement: SVGPathByteStream m_fromPath/m_toPath/m_animatedPath.
All existing non-string primitives have been converted to the new concept.
Doesn't change any functionality.
- CMakeLists.txt: Added SVGAnimatedPath.*.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
- svg/SVGAnimateElement.h:
- svg/SVGAnimatedPath.cpp: Added. (WebCore::SVGAnimatedPathAnimator::SVGAnimatedPathAnimator): (WebCore::SVGAnimatedPathAnimator::constructFromString): (WebCore::SVGAnimatedPathAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPathAnimator::calculateDistance):
- svg/SVGAnimatedPath.h: Added. (WebCore::SVGAnimatedPathAnimator::~SVGAnimatedPathAnimator):
- svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPath): (WebCore::SVGAnimatedType::path): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
- svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::initializeFrom):
- svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
- 2:20 PM Changeset in webkit [89748] by
-
- 2 edits in trunk/Source/WebCore
2011-06-25 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
SOFT_LINK_POINTER_OPTIONAL isn't optional.
https://bugs.webkit.org/show_bug.cgi?id=63378
Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.
- platform/mac/SoftLinking.h:
- 12:02 PM Changeset in webkit [89747] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Gardening.
Skip css3/flexbox tests on Qt since ENABLE(CSS3_FLEXBOX) is disabled.
- platform/qt/Skipped:
- 11:53 AM Changeset in webkit [89746] by
-
- 2 edits in trunk/Tools
2011-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
run-bindings-tests does not work on Chromium Windows.
https://bugs.webkit.org/show_bug.cgi?id=63382
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
- 11:41 AM Changeset in webkit [89745] by
-
- 12 edits6 adds in trunk
2011-06-25 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322
Allow navigating to internal <view> targets. When choosing Back ensure
the <svg> current view is initialized correctly.
Tests: svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg
svg/custom/linking-uri-01-b.svg
- page/FrameView.cpp: Delegate to setupInitialView. (WebCore::FrameView::scrollToAnchor):
- svg/SVGAElement.cpp: Allow navigating to internal <view> targets. (WebCore::SVGAElement::defaultEventHandler):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setupInitialView): Initialize current view depending on fragment identifier. (WebCore::SVGSVGElement::inheritViewAttributes):
- svg/SVGSVGElement.h:
2011-06-25 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322
Add a test for navigating to an inner <view> anchor. The changed test results
are improvements.
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/mac/svg/custom/linking-a-03-b-all-expected.png:
- platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
- platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/mac/svg/custom/linking-uri-01-b-expected.png: Added.
- platform/mac/svg/custom/linking-uri-01-b-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg: Added.
- svg/custom/linking-uri-01-b.svg: Added.
- 10:44 AM Changeset in webkit [89744] by
-
- 3 edits in trunk/Source/WebKit/qt
2011-06-20 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Duplicate entry in context menu
https://bugs.webkit.org/show_bug.cgi?id=62139
contextMenuController()->populate() is called from
ContextMenuController::handleContextMenuEvent() so
QWebPage::updatePositionDependentActions() does not need
to call it independently.
Related changesets:
http://trac.webkit.org/changeset/73535
http://trac.webkit.org/changeset/32389
- Api/qwebpage.cpp: (QWebPage::updatePositionDependentActions):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy): (tst_QWebPage::contextMenuPopulatedOnce):
- 10:21 AM Changeset in webkit [89743] by
-
- 3 edits1 delete in trunk/LayoutTests
2011-06-25 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update expectations after r89732.
https://bugs.webkit.org/show_bug.cgi?id=59085
- platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/chromium/test_expectations.txt:
- 10:04 AM Changeset in webkit [89742] by
-
- 7 edits in trunk
2011-06-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373
- fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
- fast/css/unknown-pseudo-element-matching.html: Added more tests.
2011-06-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement. (WebCore::CSSStyleSelector::pushParent): Ditto.
- dom/Node.cpp: (WebCore::Node::parentOrHostElement): Added.
- dom/Node.h:
- 8:15 AM Writing Layout Tests for DumpRenderTree edited by
- Documents window.internals. (diff)
- 3:20 AM Changeset in webkit [89741] by
-
- 2 edits18 adds in trunk/LayoutTests
2011-06-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: chromium rebaselines.
- platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.txt: Added.
- platform/chromium-linux/svg/custom/svg-fonts-segmented-expected.png: Added.
- platform/chromium-linux/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/chromium-linux/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/chromium-mac-leopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-win/svg/custom/svg-fonts-fallback-expected.txt: Added.
- platform/chromium-win/svg/custom/svg-fonts-segmented-expected.png: Added.
- platform/chromium-win/svg/custom/svg-fonts-segmented-expected.txt: Added.
- platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
- platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:43 AM Changeset in webkit [89740] by
-
- 17 edits in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
Update gtk baseline. The rebaselines should be done now.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- platform/gtk/svg/batik/text/textEffect-expected.txt:
- platform/gtk/svg/batik/text/textEffect3-expected.txt:
- platform/gtk/svg/batik/text/xmlSpace-expected.txt:
- platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
- platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
- platform/gtk/svg/text/text-text-04-t-expected.txt:
- platform/gtk/svg/text/text-text-05-t-expected.txt:
- platform/gtk/svg/text/text-text-06-t-expected.txt:
- platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
- 1:01 AM Changeset in webkit [89739] by
-
- 3 edits2 adds in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
Update win baseline.
- platform/win-wk2/Skipped: Skip newly added svg/text test just like in mac-wk2.
- platform/win-xp/svg/custom: Added.
- platform/win-xp/svg/custom/svg-fonts-fallback-expected.txt: Added. XP has different metrics here.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Update result from Win7 slave.
- 12:44 AM Changeset in webkit [89738] by
-
- 2 edits in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
Skip svg/text/select-text-svgfont.html on mac-wk2, just like the other svg/text tests.
- platform/mac-wk2/Skipped:
- 12:36 AM Changeset in webkit [89737] by
-
- 2 edits in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Gardening.
http/tests/inspector/network/network-iframe-load-and-delete.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63379
http/tests/navigation/anchor-basic.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63380
Skip last two tests that kept Leopard red, should turn green again now.
- platform/mac-leopard/Skipped:
- 12:34 AM Changeset in webkit [89736] by
-
- 2 edits in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Gardening.
REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on Leopard/SnowLeopard release
https://bugs.webkit.org/show_bug.cgi?id=63169
Skip failing test for mac, to turn bots green again.
- platform/mac/Skipped:
- 12:31 AM Changeset in webkit [89735] by
-
- 2 edits in trunk/LayoutTests
2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
Update a stale Leopard result.
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
- 12:02 AM Changeset in webkit [89734] by
-
- 3 edits in trunk/Tools
Try to fix the Qt and Chromium builds.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setEncodedAudioData):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
Jun 24, 2011:
- 11:49 PM Changeset in webkit [89733] by
-
- 51 edits4 adds in trunk
Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363
Reviewed by Anders Carlsson.
Source/WebCore:
Restored most of text rounding hacks which were removed in r78846, with a global flag to control
whether rounding hacks are allowed, which defaults to false.
Test: platform/mac/fast/text/rounding-hacks.html
- CMakeLists.txt: Added TextRun.cpp.
- GNUmakefile.list.am: Ditto.
- WebCore.exp.in: Export new TextRun function and global and updated StringTruncator functions.
- WebCore.gypi: Added TextRun.cpp.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Disable rounding hacks in the one place
they used to be disabled.
- platform/graphics/Font.cpp: Re-added the rounding character table.
- platform/graphics/Font.h:
(WebCore::Font::isRoundingHackCharacter): Re-added.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Account for final rounding width.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::adjustedSpaceWidth): Re-added.
- platform/graphics/StringTruncator.cpp:
(WebCore::stringWidth): Re-added disableRoundingHacks parameter.
(WebCore::truncateString): Ditto.
(WebCore::StringTruncator::centerTruncate): Added EnableRoundingHacksOrNot parameter.
(WebCore::StringTruncator::rightTruncate): Ditto.
(WebCore::StringTruncator::width): Ditto.
- platform/graphics/StringTruncator.h:
- platform/graphics/TextRun.cpp: Added.
(WebCore::TextRun::setAllowsRoundingHacks): Added.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Added RoundingHacks parameter to the constructors, used to initialize
the m_applyRunRounding and m_applyWordRounding member variables, subject to rounding hacks being allowed.
(WebCore::TextRun::applyRunRounding): Re-added this accessor.
(WebCore::TextRun::applyWordRounding): Ditto.
(WebCore::TextRun::disableRoundingHacks): Re-added.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Re-added code to apply rounding hacks.
(WebCore::WidthIterator::advance): Ditto.
- platform/graphics/WidthIterator.h:
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ceilCGFloat): Re-added.
(WebCore::ComplexTextController::ComplexTextController): Re-added code to apply rounding hacks.
(WebCore::ComplexTextController::advance): Ditto.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::finalRoundingWidth): Re-added this accessor.
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Accound for final rounding width.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::fileListNameForWidth): Enabled rounding hacks in the string truncator.
- platform/mac/DragImageMac.mm:
(WebCore::widthWithFont): Disable rounding hacks when measuring.
(WebCore::drawAtPoint): Disable rounding hacks when drawing.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Enable rounding hacks in the string truncator.
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreTextFloatWidth): Ditto.
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject): Disable rounding hacks.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth): Ditto.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::fileListNameForWidth): Enabled rounding hacks in the string truncator.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::fileListNameForWidth): Ditto.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun): Disabled rounding hacks.
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::constructTextRun): Ditto.
Source/WebKit/mac:
- Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
Disabled rounding hacks.
(-[NSString _web_widthWithFont:]): Ditto.
- WebView/WebView.mm:
(+[WebView _setAllowsRoundingHacks:]): Added this setter.
- WebView/WebViewPrivate.h:
Source/WebKit/win:
- WebKitGraphics.cpp:
(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.
Tools:
Added layoutTestController.allowRoundingHacks() and implemented it
on OS X.
- DumpRenderTree/LayoutTestController.cpp:
(allowRoundingHacksCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::allowRoundingHacks):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::allowRoundingHacks):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::allowRoundingHacks):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::allowRoundingHacks):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::allowRoundingHacks):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::allowRoundingHacks):
LayoutTests:
- platform/mac/fast/text/rounding-hacks.html: Added.
- platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Added.
- platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Added.
- 11:28 PM Changeset in webkit [89732] by
-
- 141 edits23 adds in trunk
2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608
Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460
With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227
When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236
SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840
REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934
Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.
Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.png:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/xmlSpace-expected.png:
- platform/mac/svg/batik/text/xmlSpace-expected.txt:
- platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
- platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
- platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
- platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
- platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
- platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/text/text-altglyph-01-b-expected.png:
- platform/mac/svg/text/text-altglyph-01-b-expected.txt:
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
- platform/mac/svg/text/text-text-04-t-expected.png:
- platform/mac/svg/text/text-text-04-t-expected.txt:
- platform/mac/svg/text/text-text-05-t-expected.png:
- platform/mac/svg/text/text-text-05-t-expected.txt:
- platform/mac/svg/text/text-text-06-t-expected.png:
- platform/mac/svg/text/text-text-06-t-expected.txt:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-b-expected.png:
- platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.png: Added.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.png: Added.
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
- platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/qt/svg/custom/svg-features-expected.png: Added.
- platform/qt/svg/custom/svg-features-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-in-html-expected.png:
- platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/qt/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
- svg/custom/resources/ABCFont.svg:
- svg/custom/svg-fonts-fallback.xhtml: Added.
- svg/custom/svg-fonts-segmented.xhtml: Added.
- svg/custom/svg-fonts-word-spacing.html: Added.
- svg/text/select-text-svgfont-expected.txt: Added.
- svg/text/select-text-svgfont.html: Added.
- svg/text/text-overflow-ellipsis-svgfont.html: Added.
2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
- wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608
Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460
With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227
When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236
SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840
REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934
Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)
svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)
Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.
This makes text selection using SVG Fonts possible again.
- features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
- page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
- platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well. (WebCore::Font::drawText): (WebCore::Font::drawEmphasisMarks): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition): (WebCore::Font::codePath):
- platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair
std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
handle font fallback glyph matching for SVG Fonts..
(WebCore::Font::fontList): Add FontFallbackList accessor.
- platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext. (WebCore::FontFallbackList::glyphPageZero): (WebCore::FontFallbackList::glyphPages): (WebCore::FontFallbackList::setGlyphPageZero): (WebCore::FontFallbackList::setGlyphPages):
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here. (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer. (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case. (WebCore::Font::drawGlyphBuffer): Ditto.
- platform/graphics/FontMetrics.h: (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
- platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
- platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int. (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData. (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
- platform/graphics/TextRun.h:
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::glyphDataForCharacter): (WebCore::WidthIterator::advance):
- platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)
and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).
(WebCore::WidthIterator::run):
(WebCore::WidthIterator::runWidthSoFar):
(WebCore::WidthIterator::lastGlyphName):
(WebCore::WidthIterator::setLastGlyphName):
(WebCore::WidthIterator::arabicForms):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
- platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
- platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
- rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
- rendering/svg/SVGTextMetrics.h:
- rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont. (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects. (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun. (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength(). (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method. (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths. (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
- svg/SVGAltGlyphElement.h:
- svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData): Changed font size from int to float. (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width. (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code. (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font. (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation. (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
- svg/SVGFontData.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage. (WebCore::SVGFontElement::ensureGlyphCache):
- svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly. (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone. (WebCore::SVGGlyphMap::collectGlyphsForString):
- svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
- 7:42 PM Changeset in webkit [89731] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[CMAKE] Replace ";" with space in FEATURE_DEFINES macro
https://bugs.webkit.org/show_bug.cgi?id=62211
html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
as separator. So, let the html.css to use new feature macro with space separator.
- CMakeLists.txt:
- 7:26 PM Changeset in webkit [89730] by
-
- 1 copy in tags/Safari-534.50
New tag.
- 7:15 PM Changeset in webkit [89729] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-06-24 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
https://bugs.webkit.org/show_bug.cgi?id=63345
The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
return 9 and 10 bit quantities, therefore changed their return type from
uint8_t to uint16_t. Also casted the places where they are used as they
are currently shifted and used as 7 or 8 bit values.
These methods are currently used for literals for stack offsets,
including creating and destroying stack frames. The prior truncation of
the upper bits caused stack frames to be too small, thus allowing a
JIT'ed function to access and overwrite stack space outside of the
incorrectly sized stack frame.
- assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::getUInt9): (JSC::ARMThumbImmediate::getUInt10): (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S):
- 7:14 PM Changeset in webkit [89728] by
-
- 2 edits in branches/safari-534-branch/Source/WebCore
Merge 89714.
- 7:12 PM Changeset in webkit [89727] by
-
- 4 edits in branches/safari-534-branch/Source/WebKit2
89706.
- 7:05 PM Changeset in webkit [89726] by
-
- 4 edits in tags/Safari-534.48.3/Source/WebKit2
Merge 89706.
- 7:01 PM Changeset in webkit [89725] by
-
- 5 edits in tags/Safari-534.48.3/Source
Versioning.
- 7:00 PM Changeset in webkit [89724] by
-
- 1 copy in tags/Safari-534.48.3
New tag.
- 6:55 PM Changeset in webkit [89723] by
-
- 2 edits in tags/Safari-534.48.2/Source/WebCore
Merge r89714.
- 6:38 PM Changeset in webkit [89722] by
-
- 5 edits in tags/Safari-534.48.2/Source
Versioning.
- 6:21 PM Changeset in webkit [89721] by
-
- 4 edits in trunk/Source/WebKit/efl
2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Remove ewk_frame_theme_get/set.
https://bugs.webkit.org/show_bug.cgi?id=63370
Remove ewk_frame_theme_get/set to avoid confusion.
Setting theme on each frame is meaningless and ewk_view_thjeme_set can
do same thing.
- ewk/ewk_frame.cpp:
- ewk/ewk_frame.h:
- ewk/ewk_view.cpp: (ewk_view_theme_set):
- 5:45 PM Changeset in webkit [89720] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-24 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Drag-and-drop tab in same window makes web process falsely report unresponsiveness
https://bugs.webkit.org/show_bug.cgi?id=63369
<rdar://problem/9673120>
If the view becomes invisible, stop the responsiveness timer, because we might not get any
messages that will cause it to stop (such as painting notifications since we don't paint
when we're not visible).
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
- 5:39 PM Changeset in webkit [89719] by
-
- 3 edits in trunk/Source/WebCore
2011-06-24 Gavin Peters <gavinp@chromium.org>
Reviewed by Darin Adler.
fix possible race in LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=63360
In chromium bug 80729
http://code.google.com/p/chromium/issues/detail?id=80729 I am
seeing some kind of double triggering of the timer; I am concerned
that it is possible that a Link element errors out or succeeds,
sets a timer, and shortly before the timer is triggered it is
editted, launches another request. After that, the first timer
triggers, zeroing out m_cachedResource. Then, the second load
finishes, and *crash*. If this is the case, this fix should stop
it.
No new tests; I haven't reproduced this. I hope chrome's crash
telemetry will give good feedback; this crash is occuring many times a
day so the difference should be obvious.
- loader/LinkLoader.cpp: (WebCore::LinkLoader::LinkLoader): (WebCore::LinkLoader::linkLoadTimerFired): (WebCore::LinkLoader::linkLoadingErrorTimerFired): (WebCore::LinkLoader::notifyFinished):
- loader/LinkLoader.h:
- 5:16 PM Changeset in webkit [89718] by
-
- 3 edits in trunk/Source/WebCore
2011-06-24 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332
<rdar://problem/9661650>
No new tests; Only affects machines with QTKit < 7.6.3 installed.
Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
as it is only defined in QTKit >= 7.6.3. If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys. To avoid ASSERTs when running
debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
- platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.
- 5:13 PM Changeset in webkit [89717] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Windows build failure.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.
- 5:11 PM Changeset in webkit [89716] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-06-24 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
https://bugs.webkit.org/show_bug.cgi?id=63015
Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList(). These
adjustments are a bug. These need to reflect the pages that are released
in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
Made ReleaseFreeList a member of TCMalloc_PageHeap in the process. Updated
Check() and helper method CheckList() to check the number of actual free pages
with free_committed_pages_.
The symptom of the problem of the existing code is that the scavenger may
run unneccesarily without any real work to do, i.e. pages on the free lists.
The scanvenger would also end up freeing too many pages, that is going below
the current 528 target free pages.
Note that the style of the changes was kept consistent with the
existing style.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::TCMalloc_PageHeap::ReleaseFreeList):
- 5:09 PM Changeset in webkit [89715] by
-
- 9 edits in trunk/Source/WebCore
2011-06-23 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Remove some unneeded functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=63295
Removing 7 of the functions in FrameLoader.h is probably a step
in the right direction.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::handledOnloadEvents): Moved the call to stopDeferringEvents in here from FrameLoader.
- loader/DocumentLoader.h: Ditto.
- loader/DocumentWriter.h: Fixed a typo.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to use a non-recursive tree walk instead of recursion. (WebCore::FrameLoader::stopAllLoaders): Moved the code from stopLoadingSubframes inline, since it's only two lines of code. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved the code from markLoadComplete inline, since it's only one line. (WebCore::FrameLoader::checkLoadComplete): Changed this to use a non-recursive tree walk instead of recursion, eliminating the recursiveCheckLoadComplete function completely. (WebCore::FrameLoader::handledOnloadEvents): Moved the call to stopDeferringEvents into DocumentLoader.
- loader/FrameLoader.h: Removed unneeded forward declarations, and now-unneeded functions setupForReplaceByMIMEType, isStopping, isLoadingFromCachedPage, stopLoadingSubframes, markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete. Also made allChildrenAreComplete private.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Call DocumentLoader::isStopping so we can remove the function from FrameLoader that just calls through. Other call sites were using DocumentLoader::isStopping directly. (WebCore::MainResourceLoader::didReceiveResponse): Call DocumentLoader::setupForReplaceByMIMEType so we can remove the function from FrameLoader that just calls through. This was the only call site.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Call the ResourceLoader::cancelledError function instead of calling directly to FrameLoader.
- loader/ResourceLoader.h: Made response an inline function.
- 5:03 PM Changeset in webkit [89714] by
-
- 2 edits in trunk/Source/WebCore
Rubber-stamped by Maciej Stachowiak.
REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading
No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix for bug 62764.
- 4:50 PM Changeset in webkit [89713] by
-
- 1 copy in tags/Safari-534.48.2
New tag.
- 4:39 PM Changeset in webkit [89712] by
-
- 4 edits3 adds in trunk
2011-06-24 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361
- css3/flexbox/display-property-expected.txt: Added.
- css3/flexbox/display-property.html: Added.
- css3/flexbox/script-tests/display-property.js: Added. (testFlex):
2011-06-24 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361
Test: css3/flexbox/display-property.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSValueKeywords.in:
- 4:06 PM Changeset in webkit [89711] by
-
- 19 edits5 deletes in trunk/Source/WebCore
2011-06-24 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Loading out-of-band text track files from <track>.
https://bugs.webkit.org/show_bug.cgi?id=62881
Uses the src attribute of <track> urls to load out-of-band text track
files using ThreadableLoader. Also removes TextTrackPrivateInterface
(as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.
No new tests because feature is hidden behind VIDEO_TRACK feature
define, which is turned off.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLTrackElement.cpp:
- html/HTMLTrackElement.h:
- html/LoadableTextTrack.cpp:
- html/LoadableTextTrack.h:
- html/LoadableTextTrackImpl.cpp: Removed.
- html/LoadableTextTrackImpl.h: Removed.
- html/MutableTextTrack.cpp:
- html/MutableTextTrack.h:
- html/MutableTextTrackImpl.cpp: Removed.
- html/MutableTextTrackImpl.h: Removed.
- html/TextTrack.cpp:
- html/TextTrack.h:
- html/TextTrackPrivate.h: Removed.
- platform/track/CueParser.cpp:
- platform/track/CueParser.h:
- 3:32 PM Changeset in webkit [89710] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Rob Buis <rbuis@rim.com>
Rubber-stamped by Nikolas Zimmermann.
All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209
Do not use writing mode aware code for SVG Text.
No new tests needed.
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
- 3:15 PM Changeset in webkit [89709] by
-
- 13 edits in trunk/LayoutTests
2011-06-24 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63343
These tests were failing since they were introduced in r89687. The
layerTreeAsText dump on the iframe document was causing the outer
layerTreeAsText dump to be affected by font metrics. Fixed in this
case by not putting layerTreeAsText output in an element when inside
an iframe.
- compositing/rtl/rtl-absolute-overflow-scrolled.html:
- compositing/rtl/rtl-absolute-overflow.html:
- compositing/rtl/rtl-absolute.html:
- compositing/rtl/rtl-fixed-overflow-scrolled.html:
- compositing/rtl/rtl-fixed-overflow.html:
- compositing/rtl/rtl-fixed.html:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative.html:
- 3:07 PM Changeset in webkit [89708] by
-
- 7 edits in trunk/Source/WebCore
2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Darin Adler.
Change NDEBUG to !LOG_DISABLED macro in databases for logging.
https://bugs.webkit.org/show_bug.cgi?id=63346
Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
This change resolves also build break in Release build when logging enabled.
No new tests because there is no new behavior or feature exposed.
- loader/icon/IconDatabase.cpp: Macro fixes. (WebCore::IconDatabase::iconDatabaseSyncThread): (WebCore::IconDatabase::syncThreadMainLoop): (WebCore::IconDatabase::readFromDatabase): (WebCore::IconDatabase::writeToDatabase): (WebCore::IconDatabase::cleanupSyncThread):
- storage/AbstractDatabase.h: Macro fixes.
- storage/DatabaseTask.cpp: Macro fixes.
- storage/DatabaseTask.h: Macro fixes.
- storage/SQLTransaction.cpp: Macro fixes.
- storage/SQLTransaction.h: Macro fixes.
- 3:05 PM Changeset in webkit [89707] by
-
- 17 edits in trunk/Source/WebCore
2011-06-24 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
Pass Strings by const reference to functions
https://bugs.webkit.org/show_bug.cgi?id=63341
Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not
change the value of the passed in String.
- loader/FrameLoader.h:
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::setFileDescriptorData):
- platform/win/ClipboardUtilitiesWin.h:
- storage/DatabaseTracker.h:
- storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
- storage/IDBLevelDBBackingStore.h:
- storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
- storage/IDBSQLiteBackingStore.h:
- storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::getOpenDatabases):
- svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
- svg/SVGPaint.h:
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
- websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 3:03 PM Changeset in webkit [89706] by
-
- 4 edits in trunk/Source/WebKit2
2011-06-24 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Not possible for plug-ins to override the internal PDF viewer
https://bugs.webkit.org/show_bug.cgi?id=63356
<rdar://problem/9673382>
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Pass the entire resource response to shouldUseCustomRepresentationForResponse.
- WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ask for the plug-in path for a plug-in that can handle the given resource response. If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in that can handle it.
(WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
a plug-in that can handle the given response. If that is the case, it should have precedence over
the custom representation.
- WebProcess/WebProcess.h: Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.
- 2:45 PM Changeset in webkit [89705] by
-
- 10 edits2 adds in trunk
2011-06-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Match other clampTo* functions in style with clampToInteger(float)
function.
https://bugs.webkit.org/show_bug.cgi?id=53449
- wtf/MathExtras.h: (clampToInteger): (clampToFloat): (clampToPositiveInteger):
2011-06-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Add clamping for CSSPrimitiveValues and SVGInlineText font size.
https://bugs.webkit.org/show_bug.cgi?id=53449
Test: svg/text/svg-zoom-large-value.xhtml
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the number created is valid.
- css/CSSPrimitiveValue.h: add clamping checks to prevent overflows. (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two static functions, one specific to CSSStyleSelector and other generic to help in clamping font size for other callers like svg text, etc.
- css/CSSStyleSelector.h:
- platform/graphics/FontDescription.h: add asserts to detect if the new font size is valid. (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize):
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper from CSSStyleSelector to help in clamping new scaled font size. do not use "smart minimum" since svg allows really small unreadable fonts (tested by existing layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon check in CSSStyleSelector function should still hold for svg.
2011-06-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that font size for svg text zoom is clamped and we do not
crash on ASSERT(isfinite(s)) in FontDescription.h
https://bugs.webkit.org/show_bug.cgi?id=53449
- svg/text/svg-zoom-large-value-expected.txt: Added.
- svg/text/svg-zoom-large-value.xhtml: Added.
- 2:22 PM Changeset in webkit [89704] by
-
- 9 edits in trunk/Source/WebCore
2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Remove unsafe static_cast inside the InlineBox hierarchy
https://bugs.webkit.org/show_bug.cgi?id=63077
Refactoring only, no new test.
- rendering/InlineFlowBox.h: (WebCore::toInlineFlowBox):
- rendering/InlineTextBox.h: (WebCore::toInlineTextBox): Added the proper cast methods to those 2 classes from an InlineBox.
- rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): (WebCore::InlineFlowBox::addToLine): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::placeBoxesInInlineDirection): (WebCore::InlineFlowBox::requiresIdeographicBaseline): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild): (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): (WebCore::RenderText::positionLineBox):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ascentAndDescentForBox): (WebCore::RootInlineBox::includeFontForBox): (WebCore::RootInlineBox::includeGlyphsForBox): Replaced the static_cast in those previous call sites with the new cast methods.
- 1:54 PM Changeset in webkit [89703] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix.
Build fix on Linux when using the GStreamer backend.
No new tests, just a build fix.
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::keyPressEvent):
- 1:54 PM Changeset in webkit [89702] by
-
- 3 edits in trunk/Tools
Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit
Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.
- 1:53 PM Changeset in webkit [89701] by
-
- 3 edits in trunk/Tools
Include links to Trac in bugs filed from TestFailures
Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.
- 1:46 PM Changeset in webkit [89700] by
-
- 19 edits9 deletes in trunk
2011-06-24 Nat Duca <nduca@chromium.org>
Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408
Test shell still not ready for animate changes.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
- platform/graphics/chromium/cc/CCMainThreadTask.h:
- platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
- platform/graphics/chromium/cc/CCThreadTask.h:
2011-06-24 Nat Duca <nduca@chromium.org>
Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408
Test shell still not ready for animate changes.
- WebKit.gypi:
- public/WebWidget.h: (WebKit::WebWidget::animate): (WebKit::WebWidget::composite):
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererViewport): (WebKit::WebViewImpl::graphicsContext3D):
- src/WebViewImpl.h:
- tests/CCLayerTreeHostTest.cpp: Removed.
- tests/CCThreadTest.cpp: (WebCore::TEST):
2011-06-24 Nat Duca <nduca@chromium.org>
Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408
Test shell still not ready for animate changes.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
- 1:33 PM Changeset in webkit [89699] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Fix Chromium Linux Build
https://bugs.webkit.org/show_bug.cgi?id=63349
- WebCore.gyp/WebCore.gyp:
- 12:56 PM Changeset in webkit [89698] by
-
- 2 edits in trunk/Tools
Fix typos introduced in r89696
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.
- 12:49 PM Changeset in webkit [89697] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Henry Song <hsong@sisa.samsung.com>
Reviewed by Martin Robinson.
Correct _sharedTimer value in SharedTimerEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=62380
SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
timerEvent(), we have observed addNewTimer() can be triggered
by either inside timerFunction() or others that are not within
timerFunction(). We have observed the following case:
- add a new Timer within timerFunction()
- timerFunction returns, set _sharedTimer = 0
- addNewTimer() is triggered again within webkit, don't know it triggers this.
- because at this moment, _sharedTimer == 0, the previous registered timer (in step 1) did not get removed.
- Now in ecore_timer, there are two timers with same callbacks
- From now on, timerFunction() will be called twice back-to-back in each ecore_timer loop. To correct this, we should set _sharedTimer = 0 before timerFunction() so that when addNewTimer() triggered within, we have a valid timer object.
- platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent):
- 12:37 PM Changeset in webkit [89696] by
-
- 2 edits in trunk/Tools
Make TestFailures correctly remember whether old-run-webkit-tests exited early
Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.
- 12:36 PM Changeset in webkit [89695] by
-
- 3 edits1 add in trunk/Tools
Add links to regression ranges in Trac to the TestFailures page
Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
- 12:29 PM Changeset in webkit [89694] by
-
- 19 edits5 copies4 adds in trunk
2011-05-17 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408
Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.
- WebCore.gypi:
- platform/chromium/TraceEvent.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
- platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
- platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
- platform/graphics/chromium/cc/CCMainThreadTask.h:
- platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
- platform/graphics/chromium/cc/CCThreadTask.h:
2011-05-17 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408
Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.
- WebKit.gypi:
- public/WebWidget.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
- src/WebViewImpl.h:
- tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
- tests/CCThreadTest.cpp: (WebCore::TEST):
2011-05-17 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
- 12:20 PM Changeset in webkit [89693] by
-
- 3 edits in trunk/Source
2011-06-24 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Enable Web Audio for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=63338
- features.gypi:
- 12:16 PM Changeset in webkit [89692] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Adrienne Walker <enne@google.com>
Unreviewed, remove assertion about root layers in RenderLayerBacking.
https://bugs.webkit.org/show_bug.cgi?id=60741
This was added in r89687, but somehow is not true on Safari Leopard.
However, as the tests that were added with that revision are passing
correctly, the assertion is most likely not correct.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 12:11 PM Changeset in webkit [89691] by
-
- 2 edits in trunk/LayoutTests
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Unreviewed: Skipping failing progress-clone.html on win.
r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
on win, but it should stay skipped because there is no progress
element on win (bug 49769)
- platform/win/Skipped:
- 11:48 AM Changeset in webkit [89690] by
-
- 9 edits1 copy1 add in trunk/Source/WebCore
2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Refactor text iterator code respecting surrogate pairs from WidthIterator
https://bugs.webkit.org/show_bug.cgi?id=63319
WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:
UChar32 character = 0;
unsigned clusterLength = 0;
SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
while (textIterator.consume(character, clusterLength)) {
Either clusterLength is 1 and UChar32 fits into a single UChar.
Or clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
...
textIterator.advance(clusterLength);
}
SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
Doesn't affect any tests, just refactoring.
- CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
- platform/graphics/SurrogatePairAwareTextIterator.h: Added. (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
- platform/graphics/WidthIterator.h:
- 11:47 AM Changeset in webkit [89689] by
-
- 2 edits in trunk/Source/WebKit2
Mac build fix after r89685
- WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.
- 11:43 AM Changeset in webkit [89688] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115
Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.
- fast/css/font-face-in-shadow-DOM.html: Removed.
- fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
- platform/win-xp/fast/css: Removed.
- platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.
- 11:35 AM Changeset in webkit [89687] by
-
- 5 edits42 adds in trunk
2011-06-24 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741
Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.
The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.
- compositing/rtl/rtl-absolute-expected.png: Added.
- compositing/rtl/rtl-absolute-expected.txt: Added.
- compositing/rtl/rtl-absolute-overflow-expected.png: Added.
- compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
- compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
- compositing/rtl/rtl-absolute-overflow.html: Added.
- compositing/rtl/rtl-absolute.html: Added.
- compositing/rtl/rtl-fixed-expected.png: Added.
- compositing/rtl/rtl-fixed-expected.txt: Added.
- compositing/rtl/rtl-fixed-overflow-expected.png: Added.
- compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
- compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
- compositing/rtl/rtl-fixed-overflow.html: Added.
- compositing/rtl/rtl-fixed.html: Added.
- compositing/rtl/rtl-iframe-absolute-expected.png: Added.
- compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
- compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
- compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
- compositing/rtl/rtl-iframe-absolute.html: Added.
- compositing/rtl/rtl-iframe-fixed-expected.png: Added.
- compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
- compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
- compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
- compositing/rtl/rtl-iframe-fixed.html: Added.
- compositing/rtl/rtl-iframe-relative-expected.png: Added.
- compositing/rtl/rtl-iframe-relative-expected.txt: Added.
- compositing/rtl/rtl-iframe-relative.html: Added.
- compositing/rtl/rtl-relative-expected.png: Added.
- compositing/rtl/rtl-relative-expected.txt: Added.
- compositing/rtl/rtl-relative.html: Added.
- compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
- compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
- compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/Skipped:
2011-06-24 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741
Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.
Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html
compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 11:24 AM Changeset in webkit [89686] by
-
- 1 edit2 adds in trunk/LayoutTests
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115
Add expected (failing?) results for win-xp to get the bots green.
- platform/win-xp/fast/css: Added.
- platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
- 11:09 AM Changeset in webkit [89685] by
-
- 2 edits in trunk/Source/WebKit2
Make the web process pause dialog look better on Vista/7 and robust against executable renames
Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7
Reviewed by Brian Weinstein.
- WebProcess/WebKitMain.cpp:
(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.
- 10:52 AM Changeset in webkit [89684] by
-
- 3 edits in trunk/LayoutTests
2011-06-24 Matthew Delaney <mdelaney@apple.com>
Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
Adding new platform specific results since the new layout in the tests changes the render tree spew.
Pixel tests are still good.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
- 10:45 AM Changeset in webkit [89683] by
-
- 7 edits in trunk/Source/WebCore
2011-06-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
Add BeforeChildren and AfterChildren to the Position's anchor types
https://bugs.webkit.org/show_bug.cgi?id=63100
Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
firstPositionInNode and lastPositionInNode.
These new types of positions will let us express the first and the last positions in a non-text node in O(1).
No new tests because there is no new behavior or feature exposed.
- dom/Position.cpp: (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes. (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node. (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and the offset in the anchor node for AfterChildren. (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren. (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick for table and ignored contents like before or after anchor. (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of the anchor node for AfterChildren. (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children. (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type is AfterChildren. (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
- dom/Position.h: (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren. (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren. (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node, the anchor type shouldn't be BeforeChildren or AfterChildren.
- editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset on BeforeChildren or AfterChildren position.
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder after paragraphs below the block is moved into, it needs to be the position after the current last child in the block instead of after children in the block; otherwise the position will move to the end of block.
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after children or before/after anchor, just return null for these anchor types.
- 10:37 AM Changeset in webkit [89682] by
-
- 68 edits in trunk
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
- Source/autotools/symbols.filter: Export symbols for GTK.
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Update tests to use internals.{ensureShadowRoot, shadowRoot,
shadowPseudoId, removeShadowRoot} instead of layoutTestController.
- fast/dom/HTMLKeygenElement/keygen-expected.txt:
- fast/dom/HTMLKeygenElement/keygen.html:
- fast/dom/HTMLMeterElement/meter-clone-expected.txt:
- fast/dom/HTMLMeterElement/meter-clone.html:
- fast/dom/HTMLProgressElement/progress-clone-expected.txt:
- fast/dom/HTMLProgressElement/progress-clone.html:
- fast/dom/shadow/activeelement-should-be-shadowhost.html:
- fast/dom/shadow/create-content-element.html:
- fast/dom/shadow/gc-shadow-expected.txt:
- fast/dom/shadow/gc-shadow.html:
- fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
- fast/dom/shadow/layout-tests-can-access-shadow.html:
- fast/dom/shadow/nodetype.html:
- fast/dom/shadow/tab-order-iframe-and-shadow.html:
- fast/events/shadow-boundary-crossing.html:
- fast/forms/resources/common.js: (getValidationMessageBubbleNode):
- fast/html/clone-keygen-expected.txt:
- fast/html/clone-keygen.html:
- fast/html/clone-range-expected.txt:
- fast/html/clone-range.html:
- fast/html/details-clone.html:
- fullscreen/video-controls-override-expected.txt:
- fullscreen/video-controls-override.html:
- media/audio-controls-do-not-fade-out.html:
- media/media-controls.js: (mediaControlsButtonCoordinates):
- media/video-controls-in-media-document.html:
- platform/win/Skipped: shadowRoot and friends now available on win.
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
- WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
- testing/Internals.cpp: The new home of shadowRoot and friends. (WebCore::Internals::ensureShadowRoot): (WebCore::Internals::shadowRoot): (WebCore::Internals::removeShadowRoot): (WebCore::Internals::shadowPseudoId):
- testing/Internals.h:
- testing/Internals.idl:
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove shadow DOM-related methods from Chromium API. These are not
required any more.
- public/WebElement.h:
- src/WebElement.cpp:
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove shadow-DOM related methods from GTK DRT API. These are not
required any more.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove shadow DOM-related methods from Mac API. These are not
required any more.
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow-DOM related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove shadow-DOM related methods from Qt DRT API. These are not
required any more.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove shadow DOM-related methods from WebKit2 API. These are not
required any more.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
- win/WebKit2CFLite.def: Same for Cairo.
2011-06-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671
Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
removeShadowRoot from layoutTestController; these have been
replaced by equivalents in window.internals instead.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 9:57 AM Changeset in webkit [89681] by
-
- 3 edits in trunk/LayoutTests
2011-06-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
https://bugs.webkit.org/show_bug.cgi?id=63327
- transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
- transforms/3d/point-mapping/3d-point-mapping.html:
- 9:35 AM Changeset in webkit [89680] by
-
- 4 edits in trunk/Source/WebCore
2011-06-24 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Refactor creation of primitive values in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=63270
Covered by existing tests.
- css/CSSParser.cpp: (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values
to keep the cast in one place.
(WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):
- css/CSSParser.h:
- css/CSSPrimitiveValueCache.h: (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference
- 9:28 AM Changeset in webkit [89679] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328
Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.
- platform/win-wk2/fast/forms: Added.
- platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
- 9:26 AM Changeset in webkit [89678] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[X11] Do not call NPP_SetWindow with a null window handle on destroy
https://bugs.webkit.org/show_bug.cgi?id=62981
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::destroy):
- 9:09 AM Changeset in webkit [89677] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328
Add (failing?) expected results for mac-wk2 to get the bots green.
- platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.
- 8:59 AM Changeset in webkit [89676] by
-
- 2 edits in trunk/LayoutTests
2011-06-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Exit immediately if the last condition tested fails.
Make <video> app cache test exit immediately on failure
https://bugs.webkit.org/show_bug.cgi?id=63323
- 8:54 AM Changeset in webkit [89675] by
-
- 2 edits in trunk
2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add more debug options to compilation
https://bugs.webkit.org/show_bug.cgi?id=63318
Add --enable-debug-symbols to enable/disable compilation with
debug symbols and --enable-debug-features to enable/disable debug
features. Both options are unconditionally enabled for debug
builds.
- configure.ac:
- 8:43 AM Changeset in webkit [89674] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325
Skip those tests to get the bots green.
- platform/mac-wk2/Skipped:
- 8:42 AM Changeset in webkit [89673] by
-
- 2 edits in trunk/Source/WebCore
2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix runtime critical warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63256
Check whether there's a view widget before trying to use it in
PlatformScreenGtk. If there isn't a view widget, which is the case
in WebKit2, try to use the default GdkScreen and monitor.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getToplevel): Helper function to get the toplevel widget. (WebCore::getVisual): Use getToplevel(). (WebCore::getScreen): Helper funtion to get the screen of a widget. (WebCore::screenRect): Use getToplevel() and getScreen().
- 7:14 AM Changeset in webkit [89672] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321
- platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.
- 6:10 AM Changeset in webkit [89671] by
-
- 2 edits in trunk/LayoutTests
2011-06-24 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed.
Remove non-existent items from the qt-wk2 skipped list.
- platform/qt-wk2/Skipped:
- 5:37 AM Changeset in webkit [89670] by
-
- 2 edits in trunk/Tools
Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320
Reviewed by Dirk Schulze.
- Scripts/run-bindings-tests:
- 5:18 AM Changeset in webkit [89669] by
-
- 14 edits in trunk/Source
2011-06-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Adam Barth.
WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348
Add a flag in Setting so that WebSocket protocols can be switched
dynamically. The protocol we have implemented so far is based on
older Hixie-76 specification. A new protocol is being discussed in
IETF HyBi working group, and I'm planning to implement the new protocol
behind this Settings flag.
I will add a method to LayoutTestController which flips this flag in
a later patch. In this way, we can put tests for both protocols in
the same place and test implementation for both protocols at the same time.
This patch only adds a flag. The flag is not used yet, thus there is
no change in functionality. Therefore, no tests were added.
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: (WebCore::Settings::setUseHixie76WebSocketProtocol): (WebCore::Settings::useHixie76WebSocketProtocol):
2011-06-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Adam Barth.
WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348
Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChanged:]):
2011-06-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Adam Barth.
WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348
Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setHixie76WebSocketProtocolEnabled): (WebPreferences::hixie76WebSocketProtocolEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 5:02 AM Changeset in webkit [89668] by
-
- 7 edits2 adds17 deletes in trunk/LayoutTests
2011-06-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Clean up some tests for search cancel buttons.
https://bugs.webkit.org/show_bug.cgi?id=63121
- Introduce a function to retrieve a reliable position of a search cancel button.
- Convert two tests to dumpAsText().
- fast/forms/resources/common.js: (searchCancelButtonPosition): Added.
- fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
- fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
- fast/forms/search-transformed-expected.txt: Added.
- fast/forms/search-transformed.html:
- Use searchCancelButtonPosition().
- Convert to dumpAsText().
- fast/forms/search-zoomed-expected.txt: Added.
- fast/forms/search-zoomed.html:
- Use searchCancelButtonPosition().
- Convert to dumpAsText().
- platform/chromium/test_expectation.txt: search-transformed.html should pass.
- platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
- platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
- platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
- platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
- platform/gtk/fast/forms/search-transformed-expected.png: Removed.
- platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
- platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
- platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
- platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
- platform/mac/fast/forms/search-transformed-expected.png: Removed.
- platform/mac/fast/forms/search-transformed-expected.txt: Removed.
- platform/mac/fast/forms/search-zoomed-expected.png: Removed.
- platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
- platform/qt/fast/forms/search-transformed-expected.txt: Removed.
- platform/qt/fast/forms/search-zoomed-expected.txt: Removed.
- 4:52 AM Changeset in webkit [89667] by
-
- 6 edits in trunk/LayoutTests
2011-06-24 Kent Tamura <tkent@chromium.org>
Remove an JavaScript error in media-controls-clone.html.
https://bugs.webkit.org/show_bug.cgi?id=63195
- media/media-controls-clone.html: Remove run() call.
- platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
- platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
- platform/mac/media/media-controls-clone-expected.txt: ditto.
- platform/win/media/media-controls-clone-expected.txt: ditto.
- 4:47 AM Changeset in webkit [89666] by
-
- 4 edits in trunk/Source/WebCore
2011-06-23 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
- inspector/front-end/utilities.js: ():
- 4:18 AM Changeset in webkit [89665] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-24 Pavel Feldman <pfeldman@google.com>
Not reviewed: uncommenting chromium devtools tests.
- platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:17 AM Changeset in webkit [89664] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Add ewk_auth.h to EWebKit.h
https://bugs.webkit.org/show_bug.cgi?id=63311
- ewk/EWebKit.h: Add ewk_auth.h
- 3:42 AM Changeset in webkit [89663] by
-
- 3 edits in trunk/Tools
2011-06-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=63216
Deleted m_webViewHost which looks leaked.
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell):
- 3:39 AM Changeset in webkit [89662] by
-
- 3 edits in trunk/Source/WebCore
2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: HTML preview should delete old iframe on show().
https://bugs.webkit.org/show_bug.cgi?id=63170
- inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype._createIFrame):
- inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
- 3:21 AM Changeset in webkit [89661] by
-
- 13 edits1 add in trunk/Source/WebCore
2011-06-24 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Convert AnimatedString to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63296
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.
No new tests added. No change of functionality.
- CMakeLists.txt: Added new file to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
- svg/SVGAnimateElement.h:
- svg/SVGAnimatedString.cpp: Added. Animator for SVGString. (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator): (WebCore::SVGAnimatedStringAnimator::constructFromString): (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedStringAnimator::calculateDistance):
- svg/SVGAnimatedString.h: (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
- svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createString): (WebCore::SVGAnimatedType::string): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
- 2:06 AM Changeset in webkit [89660] by
-
- 5 edits in trunk
2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718
Unskip accessibility test that will be passing from now on.
- platform/gtk/Skipped: Unskipped passing test.
2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718
Hide row objects in tables in GTK's accessibility wrapper.
This is a different approach in the way WebCore's accessible
rows are exposed to assistive technologies in the GTK port,
since from now on those objects are kept in WebCore (they do not
declare to ignore accessibility) and just bypassed in the mapping
to ATK, allowing to hide them in the ATK hierarchy while, at the
same time, keeping them internally to be able to provide enough
information to determine tables related information, such as rows
counting or finding an cell for specific coordinates.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Do not ignore accessibility for table rows here.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Bypass rows when needed. (getNChildrenForTable): New, find the number of children for a table, which will be the addition of all cells for its rows. (webkit_accessible_get_n_children): Call to getNChildrenForTable for accessibility tables if needed. (getChildForTable): New, bypass rows when needed, retrieving cells as if they were direct children for tables. (webkit_accessible_ref_child): Call to refChildForTable if needed. (getIndexInParentForCellInRow): New, get the index for a given cell in its parent table, considering other rows' cells. (webkit_accessible_get_index_in_parent): Call to getIndexInParentForCellInRow if needed.
- 1:43 AM Changeset in webkit [89659] by
-
- 12 edits in trunk
2011-06-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype.createClientIframe):
- inspector/front-end/inspector.css: (iframe.extension): (iframe.panel.extension):
2011-06-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel): ():
- http/tests/inspector/inspector-test.js: ():
- http/tests/inspector/resources/extension-main.html:
- http/tests/inspector/resources/extension-main.js: (dumpObject): (dumpArray): (evaluateOnFrontend.callbackWrapper): (evaluateOnFrontend): ():
- http/tests/inspector/resources/extension-panel.html:
- inspector/extensions/extensions-events.html:
- inspector/extensions/extensions-expected.txt:
- inspector/extensions/extensions.html:
- 1:25 AM Changeset in webkit [89658] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Darin Fisher.
Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
https://bugs.webkit.org/show_bug.cgi?id=62396
- public/WebURLError.h: (WebKit::WebURLError::WebURLError):
- src/WebURLError.cpp: (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
- 1:24 AM Changeset in webkit [89657] by
-
- 4 edits in trunk/Source/WebCore
2011-06-24 David Grogan <dgrogan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
https://bugs.webkit.org/show_bug.cgi?id=61653
roll out r86838
No new tests - refactoring.
- dom/Document.h:
- dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::create): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::~EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
- dom/EventQueue.h:
- 1:02 AM Changeset in webkit [89656] by
-
- 7 edits in trunk/LayoutTests
2011-06-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
https://bugs.webkit.org/show_bug.cgi?id=63160
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest._replyToExtension): (initialize_ExtensionsTest):
- http/tests/inspector/resources/extension-main.html:
- http/tests/inspector/resources/extension-main.js: (onError): (onTestsDone):
- inspector/extensions/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
- inspector/extensions/extensions-events.html:
- inspector/extensions/extensions.html:
- 12:43 AM Changeset in webkit [89655] by
-
- 14 edits3 deletes in trunk/Source
2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316
It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- icu/unicode/uscript.h: Removed.
- wtf/unicode/ScriptCodesFromICU.h: Removed.
- wtf/unicode/brew/UnicodeBrew.h:
- wtf/unicode/glib/UnicodeGLib.h:
- wtf/unicode/icu/UnicodeIcu.h:
- wtf/unicode/qt4/UnicodeQt4.h:
- wtf/unicode/wince/UnicodeWinCE.h:
2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316
It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).
- icu/unicode/uscript.h: Removed.
2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316
It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).
- WebCore.exp.in:
- icu/unicode/uscript.h:
- page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
- page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
- 12:09 AM Changeset in webkit [89654] by
-
- 2 edits in trunk/Tools
2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build.
- WebKitTestRunner/GNUmakefile.am:
