Timeline

Jun 27, 2011:

11:46 PM Changeset in webkit [89897] by commit-queue@webkit.org

• 9 edits in trunk/Tools

2011-06-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r89881.
​http://trac.webkit.org/changeset/89881
​https://bugs.webkit.org/show_bug.cgi?id=63513

Makes Qt massively slow (Requested by abarth on #webkit).

• Scripts/webkitpy/common/system/crashlogs.py:
• Scripts/webkitpy/common/system/crashlogs_unittest.py:
• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/mac.py:
• Scripts/webkitpy/layout_tests/port/server_process.py:
• Scripts/webkitpy/tool/commands/queries.py:

11:02 PM Changeset in webkit [89896] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/782

Merge 89780
BUG=86648
Review URL: ​http://codereview.chromium.org/7273023

10:55 PM Changeset in webkit [89895] by barraclough@apple.com

• 4 edits
  3 adds in trunk

Source/JavaScriptCore: Build fix attempt after r89885.

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2011-06-27

• JavaScriptCore.exp:
• jsc.cpp:

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=50554
RegExp.prototype.toString does not escape slashes

Reviewed by Darin Adler & Oliver Hunt.

The problem here is that we don't escape forwards slashes when converting
a RegExp to a string. This means that RegExp("/").toString() is "/",
which is not a valid RegExp literal. Also, we return an invalid literal
for RegExp.prototype.toString() ("", which is an empty single-line comment).

From ES5:
"NOTE: The returned String has the form of a RegularExpressionLiteral that
evaluates to another RegExp object with the same behaviour as this object."

Added test cases.

• fast/regex/script-tests/toString.js: Added.

(testFwdSlash):

• fast/regex/toString-expected.txt: Added.
• fast/regex/toString.html: Added.

10:39 PM Changeset in webkit [89894] by yutak@chromium.org

• 5 edits in trunk/Source/WebKit2

2011-06-27 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

[WebKit2] Add hixie76WebSocketProtocolEnabled flag to WebPreferences
​https://bugs.webkit.org/show_bug.cgi?id=63447

Make a new flag added in WebCore::Settings (useHixie76WebSocketProtocol)
switchable from WebPage and WebPreferences.

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetHixie76WebSocketProtocolEnabled): (WKPreferencesGetHixie76WebSocketProtocolEnabled):
• UIProcess/API/C/WKPreferencesPrivate.h:
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):

10:35 PM Changeset in webkit [89893] by cevans@google.com

• 1 edit
  36 copies in branches/chromium/782

Merge 89836
BUG=87148
Review URL: ​http://codereview.chromium.org/7253035

10:13 PM Changeset in webkit [89892] by cevans@google.com

• 2 edits
  3 copies in branches/chromium/782

Merge 89782
BUG=87339
Review URL: ​http://codereview.chromium.org/7273022

10:08 PM Changeset in webkit [89891] by pfeldman@chromium.org

• 1 edit
  1 add in trunk/LayoutTests

2011-06-27 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium baselines update.

• platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Added.

10:02 PM Changeset in webkit [89890] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix style error related to wrong include order.

• platform/graphics/efl/ImageEfl.cpp:

9:30 PM Changeset in webkit [89889] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

[chromium] editing/style/smoosh-styles-003.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=63509

Don't let spellcheck kick in this test because it's nothing to do with spellcheck.

• editing/style/smoosh-styles-003.html:

9:19 PM Changeset in webkit [89888] by commit-queue@webkit.org

• 4 edits in trunk/Tools

2011-06-27 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
​https://bugs.webkit.org/show_bug.cgi?id=60869

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

8:43 PM WebAPIReviewChecklist edited by rniwa@webkit.org

(diff)

7:30 PM Changeset in webkit [89887] by rniwa@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Build fix attempt after r89885.

• JavaScriptCore.exp:
• jsc.cpp:

7:19 PM Changeset in webkit [89886] by rniwa@webkit.org

• 1 edit
  2 moves in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Fix r89879.

• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Removed.
• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png.
• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt.

6:32 PM Changeset in webkit [89885] by oliver@apple.com

• 16 edits in trunk/Source/JavaScriptCore

2011-06-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Support throwing away non-running code even while other code is running
​https://bugs.webkit.org/show_bug.cgi?id=63485

Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.

The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.

• JavaScriptCore.exp:
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls): (JSC::CodeBlock::clearEvalCache):
• bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::unlink):
• bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::clear):
• heap/Heap.cpp: (JSC::Heap::getConservativeRegisterRoots):
• heap/Heap.h:
• jit/JIT.cpp: (JSC::JIT::privateCompile):
• jit/JIT.h:
• jit/JITCall.cpp: (JSC::JIT::compileOpCall):
• jit/JITWriteBarrier.h: (JSC::JITWriteBarrierBase::clear):
• jsc.cpp: (GlobalObject::GlobalObject): (functionReleaseExecutableMemory):
• runtime/Executable.cpp: (JSC::EvalExecutable::unlinkCalls): (JSC::ProgramExecutable::unlinkCalls): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::unlinkCalls):
• runtime/Executable.h:
• runtime/JSGlobalData.cpp: (JSC::SafeRecompiler::returnValue): (JSC::SafeRecompiler::operator()): (JSC::JSGlobalData::releaseExecutableMemory):

6:16 PM Changeset in webkit [89884] by leviw@chromium.org

• 1 edit
  1 move in trunk/LayoutTests

2011-06-27 Levi Weintraub <​leviw@chromium.org>

Unreviewed.

Renaming incorrectly named linux test expectation.

• platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
• platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png.

6:12 PM Changeset in webkit [89883] by commit-queue@webkit.org

• 1 edit
  2 moves
  2 adds
  10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <​wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5156801-2.html to dumpAsText and rename
​https://bugs.webkit.org/show_bug.cgi?id=63359

converted editing/deleting/5156801-2.html to dump-as-markup test, with
new results. Renamed 5156801.html to delete-node-after-DOMNodeRemoved,
and 5156801-2.html to delete-table-cell-contents.html; they were only
noticeably related by their rdar number, which is now included in each.

• editing/deleting/5156801.html: Removed.
• editing/deleting/5156801-expected.txt: Removed.
• editing/deleting/5156801-2.html: Removed.
• editing/deleting/delete-node-after-DOMNodeRemoved.html: Added.
• editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt: Added.
• editing/deleting/delete-table-cell-contents.html: Added.
• editing/deleting/delete-table-cell-contents-expected.txt: Added.
• platform/chromium-linux/editing/deleting/5156801-2-expected.png: Removed.
• platform/chromium-win/editing/deleting/5156801-2-expected.png: Removed.
• platform/chromium-win/editing/deleting/5156801-2-expected.txt: Removed.
• platform/gtk/editing/deleting/5156801-2-expected.txt: Removed.
• platform/mac-leopard/editing/deleting/5156801-2-expected.png: Removed.
• platform/mac/editing/deleting/5156801-2-expected.png: Removed.
• platform/mac/editing/deleting/5156801-2-expected.txt: Removed.
• platform/qt/editing/deleting/5156801-2-expected.png: Removed.
• platform/qt/editing/deleting/5156801-2-expected.txt: Removed.

5:34 PM Changeset in webkit [89882] by barraclough@apple.com

• 5 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=63497
Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.

Reviewed by Oliver Hunt.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGNode.h:
• dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:33 PM Changeset in webkit [89881] by abarth@webkit.org

• 9 edits in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
​https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

• Scripts/webkitpy/common/system/crashlogs.py:
• Scripts/webkitpy/common/system/crashlogs_unittest.py:
• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/mac.py:
• Scripts/webkitpy/layout_tests/port/server_process.py:
• Scripts/webkitpy/tool/commands/queries.py:

5:15 PM Changeset in webkit [89880] by bweinstein@apple.com

• 2 edits in trunk/Source/WebCore

Fix the WebCore vcproj file after r89851.

• WebCore.vcproj/WebCore.vcproj:

5:08 PM Changeset in webkit [89879] by leviw@chromium.org

• 1 edit
  1 add in trunk/LayoutTests

2011-06-27 Levi Weintraub <​leviw@chromium.org>

Unreviewed.

Windows rebaseline for my commit r89864.

• platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.

4:57 PM Changeset in webkit [89878] by Joseph Pecoraro

• 4 edits in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Allow non-main thread text drawing in ICU ports
​https://bugs.webkit.org/show_bug.cgi?id=63482

Some ports allow multiple threads to draw strings.
LineBreakIteratorPool is not thread safe and the existing
ASSERT caught cases where multiple threads were trying
to access the shared pool. This makes the pool a lazily
created per-thread pool to allow for thread safe pool use.

• platform/ThreadGlobalData.h:
• platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): start with null. (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create. (WebCore::ThreadGlobalData::destroy): delete. Manage the lifetime of the per-thread pool instance.

• platform/text/LineBreakIteratorPoolICU.h: (WebCore::LineBreakIteratorPool::sharedPool): Use the per-thread pool instance and remove the ASSERT that this needs to be on the main thread.

(WebCore::LineBreakIteratorPool::create):
Create a PassOwnPtr so we can use OwnPtr on pools.

(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
Private now that there is a public create function.

4:50 PM Changeset in webkit [89877] by leviw@chromium.org

• 1 edit
  3 adds in trunk/LayoutTests

2011-06-27 Levi Weintraub <​leviw@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89864

• platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
• platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Added.

4:26 PM Changeset in webkit [89876] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

2011-06-27 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
​https://bugs.webkit.org/show_bug.cgi?id=56393

Tests that a plugin of a swf file in a hidden iframe will not
crash. This test required more than 1 content file and a
timeout or else it would not repeat the error condition.

This test will only crash on platforms (like Symbian) that
don't allow nonvirtual functions to have a null this pointer.

• plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
• plugins/hidden-iframe-with-swf-plugin.html: Added.
• plugins/resources/iframe-content-with-swf-plugin.html: Added.

2011-06-27 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
​https://bugs.webkit.org/show_bug.cgi?id=56393

Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".

Test: plugins/hidden-iframe-with-swf-plugin.html

• page/FrameView.cpp: (WebCore::FrameView::windowClipRect):

4:16 PM Changeset in webkit [89875] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Juan C. Montemayor <​jmont@apple.com>

Reviewed by Mark Rowe.

Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
​https://bugs.webkit.org/show_bug.cgi?id=63392

When both TextPosition.h and XPathGrammar.h are included a compile-error
is caused, since XPathGrammar.h defines a macro called NUMBER and
TextPosition has a typedef named NUMBER.

• wtf/text/TextPosition.h: (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition):

4:09 PM Changeset in webkit [89874] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-06-27 Raymes Khoury <​raymes@chromium.org>

Reviewed by Tony Chang.

WebCore fails to compile in thumb mode when neon instructions are
enabled.

There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
which fail to build when -mthumb is passed to gcc. These contain inline
assembly for neon instructions on arm. This patch forces the -marm flag
to be passed when compiling these files to work around this.

​https://bugs.webkit.org/show_bug.cgi?id=62916

Built WebKit in Chromium and checked that -marm is passed
only when building these files.

​https://bugs.webkit.org/show_bug.cgi?id=62916

• WebCore.gyp/WebCore.gyp:

4:05 PM Changeset in webkit [89873] by abarth@webkit.org

• 7 edits in trunk

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
​https://bugs.webkit.org/show_bug.cgi?id=55907

• fast/harness/resources/results-test.js:
• fast/harness/results.html:

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
​https://bugs.webkit.org/show_bug.cgi?id=55907

NRWT used to have a different name for crash logs. I've changed the
name to patch ORWT.

• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

3:52 PM Changeset in webkit [89872] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Rolled DEPS.

• DEPS:

3:51 PM Changeset in webkit [89871] by Nate Chapin

• 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

• platform/chromium/fast/js/recursion-limit-equal-expected.txt: Rebaseline after r89842.

3:31 PM Changeset in webkit [89870] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

2011-06-27 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
​https://bugs.webkit.org/show_bug.cgi?id=63486

• fast/filesystem/filesystem-no-callback-null-ptr-crash.html:

3:18 PM Changeset in webkit [89869] by jcivelli@chromium.org

• 12 edits
  2 adds in trunk

2011-06-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
​https://bugs.webkit.org/show_bug.cgi?id=63310

• mhtml/multi_frames_binary.mht: Added.
• platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.

2011-06-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
​https://bugs.webkit.org/show_bug.cgi?id=63310

• loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::MHTMLArchive::generateMHTMLData): (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
• loader/archive/mhtml/MHTMLArchive.h:
• loader/archive/mhtml/MHTMLParser.cpp: (WebCore::MHTMLParser::parseNextPart):
• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
• platform/SharedBuffer.h:
• platform/network/MIMEHeader.cpp: (WebCore::MIMEHeader::parseContentTransferEncoding):
• platform/network/MIMEHeader.h:

2011-06-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
​https://bugs.webkit.org/show_bug.cgi?id=63310

• public/WebPageSerializer.h:
• src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML): (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):

3:17 PM Changeset in webkit [89868] by eric@webkit.org

• 16 edits in trunk/Tools

2011-06-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
​https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

• Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
• Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
• Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
• Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
• Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
• Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
• Scripts/webkitpy/layout_tests/port/config.py:
  • build_dumprendertree had no business in this class, removed it.
  • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
  • Exposed _script_path as script_path() (this probably belongs elsewhere).
• Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Moved these tests to webkit_unittests.
• Scripts/webkitpy/layout_tests/port/webkit.py:
  • Now respects the --webkit-test-runner option.
  • setup_test_run is empty in base.py too, no need to override it.
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Test the new hotness.
  • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Add the option.
• Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Remove optional args option.
• Scripts/webkitpy/tool/commands/commandtest.py:
  • Remove optional args option.
• Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Remove optional args option.

3:15 PM Changeset in webkit [89867] by jeffm@apple.com

• 1 edit in trunk/Source/WebKit2/ChangeLog

Really fix the revision number in the last entry

3:14 PM Changeset in webkit [89866] by jeffm@apple.com

• 1 edit in trunk/Source/WebKit2/ChangeLog

Fix revision number that I referenced in my last checkin

3:11 PM Changeset in webkit [89865] by jeffm@apple.com

• 2 edits in trunk/Source/WebKit2

Web process always pauses on launch
​https://bugs.webkit.org/show_bug.cgi?id=63487

Reviewed by Oliver Hunt.

In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
web process to pause if the shift and alt keys were not held down.

• WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Add some parentheses.

3:01 PM Changeset in webkit [89864] by leviw@chromium.org

• 9 edits
  4 adds in trunk

2011-06-27 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
​https://bugs.webkit.org/show_bug.cgi?id=50949
Adding support for the 'plaintext' mode of unicode-bidi.

• fast/text/international/unicode-bidi-plaintext.html: Added.
• platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: added
• platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
• platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.

2011-06-27 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
​https://bugs.webkit.org/show_bug.cgi?id=50949

Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
of the Unicode BiDi algorithm on each paragraph of a block with that style.
This is similar to dir=auto but done per-paragraph instead of per element.

Test: fast/text/international/unicode-bidi-plaintext.html

• css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Added plaintext.
• css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
• css/CSSValueKeywords.in: Ditto.
• html/HTMLElement.cpp: (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto to their proper unicode-bidi attribute. (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea when dir=auto.
• platform/text/UnicodeBidi.h: Added plaintext.
• rendering/RenderBlockLineLayout.cpp: (WebCore::determineParagraphDirection): Determines the direction of a paragraph based on the first strong character. Stops at first paragraph separator. (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection when in unicode-bidi: plaintext mode (and operating at the block's BidiContext) to set each paragraph to the proper base BidiContext. (WebCore::RenderBlock::determineStartPosition): Ditto.
• rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate for plaintext.

2:45 PM Changeset in webkit [89863] by jberlin@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89745.

I checked these results with Rob - they are not failing expected results.

• platform/win/svg/custom/linking-uri-01-b-expected.png: Added.
• platform/win/svg/custom/linking-uri-01-b-expected.txt: Added.

2:38 PM Changeset in webkit [89862] by commit-queue@webkit.org

• 2 edits
  1 add
  10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <​wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/whitespace-pre-1.html to dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=63372

converted editing/deleting/whitespace-pre-1.html to dump-as-markup, removed
old baselines, and added the new one.

• editing/deleting/whitespace-pre-1-expected.txt: Added.
• editing/deleting/whitespace-pre-1.html:
• platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/chromium-win/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/chromium-win/editing/deleting/whitespace-pre-1-expected.txt: Removed.
• platform/gtk/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/gtk/editing/deleting/whitespace-pre-1-expected.txt: Removed.
• platform/mac-leopard/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/mac/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/mac/editing/deleting/whitespace-pre-1-expected.txt: Removed.
• platform/qt/editing/deleting/whitespace-pre-1-expected.png: Removed.
• platform/qt/editing/deleting/whitespace-pre-1-expected.txt: Removed.

2:38 PM Changeset in webkit [89861] by commit-queue@webkit.org

• 12 edits in trunk/Source/JavaScriptCore

2011-06-27 Filip Pizlo <​fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform put_by_id caching.
​https://bugs.webkit.org/show_bug.cgi?id=63409

• bytecode/StructureStubInfo.h:
• dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
• dfg/DFGJITCodeGenerator.h:
• dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
• dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
• dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchByIdSelfAccess): (JSC::DFG::tryCacheGetByID): (JSC::DFG::appropriatePutByIdFunction): (JSC::DFG::tryCachePutByID): (JSC::DFG::dfgRepatchPutByID):
• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):

2:32 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

2:27 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

2:24 PM Changeset in webkit [89860] by Lucas Forschler

• 5 edits in branches/safari-534-branch/Source

Versioning.

2:23 PM Changeset in webkit [89859] by Lucas Forschler

• 1 copy in tags/Safari-534.50.1

New tag.

2:23 PM Changeset in webkit [89858] by alexis.menard@openbossa.org

• 5 edits in trunk/Source

2011-06-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
​https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

No new tests, it's just a little cosmetic change.

• platform/mac/WebVideoFullscreenController.h:
• platform/mac/WebVideoFullscreenHUDWindowController.h:

2011-06-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
​https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

• WebCoreSupport/QTKitFullScreenVideoHandler.mm:

2:22 PM Changeset in webkit [89857] by Lucas Forschler

• 2 edits in branches/safari-534-branch/Source/WebCore

Merge r89748.

2:21 PM Changeset in webkit [89856] by jberlin@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89769.

I checked these results with Dan - they are not failing expected results.

• platform/win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
• platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.

2:20 PM Changeset in webkit [89855] by Lucas Forschler

• 3 edits in branches/safari-534-branch/Source/WebCore

Merge r89718.

2:20 PM Changeset in webkit [89854] by abarth@webkit.org

• 8 edits in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests does not report stderr output
​https://bugs.webkit.org/show_bug.cgi?id=37739

Almost all the infrastructure appears to be in place to report stderr
in results.html. We just need to wire up a bool to tell results.html
to create the hyperlink.

• Scripts/webkitpy/layout_tests/layout_package/manager.py:
• Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
• Scripts/webkitpy/layout_tests/layout_package/test_results.py:
• Scripts/webkitpy/layout_tests/port/base.py:

2:19 PM Changeset in webkit [89853] by Lucas Forschler

• 5 edits in branches/safari-534-branch/Source

Versioning.

2:18 PM Changeset in webkit [89852] by abarth@webkit.org

• 4 edits in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Dirk Pranke.

webkitpy unit tests should have more descriptive names than just "Test"
​https://bugs.webkit.org/show_bug.cgi?id=63479

Luckily we kept these classes in separate namespaces in the harness so
we were actually running them all even though they had the same name.

• Scripts/webkitpy/common/system/stack_utils_unittest.py:
• Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
• Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:

2:09 PM Changeset in webkit [89851] by Joseph Pecoraro

• 6 edits
  1 add in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Extract LineBreakIteratorPool class into its own file
​https://bugs.webkit.org/show_bug.cgi?id=63471

• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj: Add the new file to builds that used TextBreakIteratorPoolICU.h.

• platform/text/LineBreakIteratorPoolICU.h: Added. (WebCore::LineBreakIteratorPool::sharedPool): (WebCore::LineBreakIteratorPool::LineBreakIteratorPool): Expose the constructor so it can be used by others.

• platform/text/TextBreakIteratorICU.cpp: Remove the old LineBreakIteratorPool implementation.

1:57 PM Changeset in webkit [89850] by jberlin@webkit.org

• 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implemenation of allowRoundingHacks.
​https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks.html to the mac-wk2 skipped list to get the bots
green.

• platform/mac-wk2/Skipped:

1:57 PM Changeset in webkit [89849] by leviw@chromium.org

• 2 edits in trunk/Tools

2011-06-27 Greg Simon <​gregsimon@chromium.org>

No review necessary.

Add email addr to contributor list
​https://bugs.webkit.org/show_bug.cgi?id=63478

• Scripts/webkitpy/common/config/committers.py:

1:53 PM Changeset in webkit [89848] by commit-queue@webkit.org

• 15 edits in trunk/Tools

2011-06-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r89834.
​http://trac.webkit.org/changeset/89834
​https://bugs.webkit.org/show_bug.cgi?id=63476

Broke test-webkitpy (Requested by abarth on #webkit).

• Scripts/webkitpy/common/net/layouttestresults.py:
• Scripts/webkitpy/common/system/outputcapture.py:
• Scripts/webkitpy/layout_tests/layout_package/manager.py:
• Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
• Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/config.py:
• Scripts/webkitpy/layout_tests/port/config_unittest.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
• Scripts/webkitpy/tool/bot/queueengine_unittest.py:
• Scripts/webkitpy/tool/commands/commandtest.py:
• Scripts/webkitpy/tool/commands/queues_unittest.py:

1:18 PM Changeset in webkit [89847] by jeffm@apple.com

• 4 edits in trunk/Tools

2011-06-27 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Stop copying obsolete WebKit libraries on Windows
​https://bugs.webkit.org/show_bug.cgi?id=63474

Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.

• DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
• MiniBrowser/MiniBrowserPostBuild.cmd:
• WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:

1:14 PM Changeset in webkit [89846] by inferno@chromium.org

• 1 edit
  48 adds in trunk/LayoutTests

2011-06-27 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89836.

• platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
• platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
• platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
• platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
• platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
• platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
• platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
• platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
• platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
• platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
• platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.

12:39 PM Changeset in webkit [89845] by rniwa@webkit.org

• 2 edits in trunk/Tools

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Add Wyatt Carss to the list of non-committer contributors.

• Scripts/webkitpy/common/config/committers.py:

12:08 PM Changeset in webkit [89844] by justin.garcia@apple.com

• 4 edits in trunk/Source/WebCore

2011-06-27 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Ryosuke Niwa.

CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
​https://bugs.webkit.org/show_bug.cgi?id=62921

• editing/CompositeEditCommand.cpp:
• editing/CompositeEditCommand.h:
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):

11:47 AM Changeset in webkit [89843] by abarth@webkit.org

• 6 edits
  2 adds in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkitpy should understand crash logs
​https://bugs.webkit.org/show_bug.cgi?id=63468

We're planning to use this functionality to upload crash logs along
with test results for new-run-webkit-tests.

• Scripts/webkitpy/common/system/crashlog.py: Added.
• Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/common/system/executive_unittest.py:
• Scripts/webkitpy/common/system/filesystem.py:
• Scripts/webkitpy/common/system/filesystem_mock.py:
• Scripts/webkitpy/tool/commands/queries.py:

11:40 AM Changeset in webkit [89842] by barraclough@apple.com

• 3 edits in trunk/LayoutTests

The fast/js/recursion-limit-equal test is too fragile
​https://bugs.webkit.org/show_bug.cgi?id=63352

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-06-27
Reviewed by Gavin Barraclough.

• fast/js/recursion-limit-equal-expected.txt:
• fast/js/script-tests/recursion-limit-equal.js:

11:36 AM Changeset in webkit [89841] by Adam Roben

• 2 edits in trunk/Tools

Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many failures

Fixes <​http://webkit.org/b/63470> TestFailures page for a particular builder forgets
old-run-webkit-tests exited early after reload

Reviewed by Anders Carlsson.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
old-run-webkit-tests exited early due to too many failures in PersistentCache.

11:28 AM Changeset in webkit [89840] by Adam Roben

• 3 edits in trunk/Tools

Make TestFailures load build names from build.webkit.org/old-results too

Build results are periodically moved from results to old-results. This change makes those
builds still visible to TestFailures.

Fixes <​http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
have been moved to build.webkit.org/old-results

Reviewed by Anders Carlsson.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Extracted code to parse build names from a
build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
we now only include directory entries whose names are parseable as build names (since
old-results sometimes contains other random files/directories from who knows what). We now
fetch both results and old-results (with a FIXME about loading old-results on demand),
extract build names from each, and concatenate the two sets of names.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:

(WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
parseable, rather than throwing an exception.

11:28 AM Changeset in webkit [89839] by Adam Roben

• 2 edits in trunk/Tools

Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache

It seems silly to have a whole generic cache just to store a single object.

Fixes <​http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
need one

Reviewed by Anders Carlsson.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
(LayoutTestHistoryAnalyzer.prototype.start): Ditto.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
no-longer-needed history argument.

11:27 AM Changeset in webkit [89838] by Adam Roben

• 4 edits
  2 adds in trunk/Tools

Move some inappropriate code out of Builder

Fixes <​http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
isn't really about a builder

Reviewed by Anders Carlsson.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
called by other objects.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

Added. Code came from Builder.
(LayoutTestHistoryAnalyzer):
(LayoutTestHistoryAnalyzer.prototype.start):
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

Added. Code came from Builder.
(LayoutTestResultsLoader):
(LayoutTestResultsLoader.prototype.start):

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new

scripts.

11:05 AM Changeset in webkit [89837] by nduca@chromium.org

• 19 edits
  5 copies
  4 adds in trunk

2011-05-17 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

• WebCore.gypi:
• platform/chromium/TraceEvent.h:
• platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
• platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
• platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
• platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
• platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
• platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
• platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
• platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
• platform/graphics/chromium/cc/CCMainThreadTask.h:
• platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
• platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

• WebKit.gypi:
• public/WebWidget.h:
• src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
• src/WebPopupMenuImpl.h:
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
• src/WebViewImpl.h:
• tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
• tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=58408

• DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

10:48 AM Changeset in webkit [89836] by inferno@chromium.org

• 3 edits
  36 adds in trunk

2011-06-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Fix removal of overhanging floats on style changes to absolute/fixed position.
​https://bugs.webkit.org/show_bug.cgi?id=63355

1. If we are not currently positioned.
2. And we are not floating. (If we are floating, then this will be automatically done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
3. And we have overhanging floats from previous sibling blocks.
4. And our new new style tells that we will have absolute or fixed position.

Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.

Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html

fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):

2011-06-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that overhanging floats are removed during style changes to absolute/fixed
position and gets added back when coming back to static position.
​https://bugs.webkit.org/show_bug.cgi?id=63355

• fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
• fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
• fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
• fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
• fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
• fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
• fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
• fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
• fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
• fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
• fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
• fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
• platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
• platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
• platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
• platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.

10:44 AM Changeset in webkit [89835] by Nate Chapin

• 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

Add chromium mac failure after r89733.

• platform/chromium/test_expectations.txt:

10:43 AM Changeset in webkit [89834] by eric@webkit.org

• 15 edits in trunk/Tools

2011-06-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
​https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

• Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
• Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
• Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
• Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
• Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
• Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
• Scripts/webkitpy/layout_tests/port/config.py:
  • build_dumprendertree had no business in this class, removed it.
  • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
  • Exposed _script_path as script_path() (this probably belongs elsewhere).
• Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Moved these tests to webkit_unittests.
• Scripts/webkitpy/layout_tests/port/webkit.py:
  • Now respects the --webkit-test-runner option.
  • setup_test_run is empty in base.py too, no need to override it.
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Test the new hotness.
  • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Add the option.
• Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Remove optional args option.
• Scripts/webkitpy/tool/commands/commandtest.py:
  • Remove optional args option.
• Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Remove optional args option.

10:33 AM Changeset in webkit [89833] by krit@webkit.org

• 14 edits
  4 adds in trunk

2011-06-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
​https://bugs.webkit.org/show_bug.cgi?id=63456

Test for animation of SVGPreserveAspectRatio.

• svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/svgPreserveAspectRatio-animation-1-expected.txt: Added.
• svg/animations/svgPreserveAspectRatio-animation-1.html: Added.

2011-06-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
​https://bugs.webkit.org/show_bug.cgi?id=63456

Follow up of "SVGAnimation should use direct unit animation for SVGLength": ​https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedPreserveAspectRatio.

The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgPreserveAspectRatio-animation-1.html

• CMakeLists.txt: Added new file.
• GNUmakefile.list.am: Ditto.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• svg/SVGAllInOne.cpp: Ditto.
• svg/SVGAnimateElement.cpp: Handle AnimatedPreserveAspectRatio. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
• svg/SVGAnimatedPreserveAspectRatio.cpp: Added. New animator for SVGAnimatedPreserveAspectRatio. (WebCore::SVGAnimatedPreserveAspectRatioAnimator::SVGAnimatedPreserveAspectRatioAnimator): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateDistance):
• svg/SVGAnimatedPreserveAspectRatio.h: (WebCore::SVGAnimatedPreserveAspectRatioAnimator::~SVGAnimatedPreserveAspectRatioAnimator):
• svg/SVGAnimatedType.cpp: Support for SVGPreserveAspectRatio. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPreserveAspectRatio): (WebCore::SVGAnimatedType::preserveAspectRatio): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): (WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
• svg/SVGAnimatedType.h:
• svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):

10:26 AM Changeset in webkit [89832] by alexis.menard@openbossa.org

• 11 edits
  2 deletes in trunk

2011-06-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
​https://bugs.webkit.org/show_bug.cgi?id=63448

Remvove from the build.

• Source/WebKit.pri:

2011-06-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
​https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.

• WebCore.gypi:
• WebCore.pri:
• WebCore.pro:
• features.pri:
• platform/graphics/MediaPlayer.cpp:
• platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
• platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.

2011-06-27 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
​https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon related stuff.

• docs/qtwebkit.qdocconf:
• qt_webkit_version.pri:

10:21 AM Changeset in webkit [89831] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
​https://bugs.webkit.org/show_bug.cgi?id=63334

Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.

Also add more assertions to help detecting similar bugs.

Test: editing/text-iterator/first-letter-rtl-crash.html

• editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::emitText):

2011-06-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
​https://bugs.webkit.org/show_bug.cgi?id=63334

Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
with first-letter rule applied where letters are not contiguous.

• editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
• editing/text-iterator/first-letter-rtl-crash.html: Added.

10:18 AM Changeset in webkit [89830] by caio.oliveira@openbossa.org

• 4 edits in trunk/Source

2011-06-27 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
​https://bugs.webkit.org/show_bug.cgi?id=37319

This patch is based on Noam Rosenthal original patch in the same bug.

When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

• bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason why we have the implicit conversion.

2011-06-27 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
​https://bugs.webkit.org/show_bug.cgi?id=37319

• tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::overloadedSlots): Remove expected failure and fix the comment.

10:16 AM Changeset in webkit [89829] by kbalazs@webkit.org

• 3 edits in trunk/LayoutTests

2011-06-27 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=63458

Put a failing test to the mac list because all wk2 platforms are affected.
Move the group to the section where the items have bug report.

• platform/mac-wk2/Skipped:
• platform/qt-wk2/Skipped:

10:04 AM Changeset in webkit [89828] by commit-queue@webkit.org

• 4 edits in trunk/Source

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
​https://bugs.webkit.org/show_bug.cgi?id=63425

Some missing files in ANGLE are just added to fix build-break.

No test reqired

• GNUmakefile.list.am:

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
​https://bugs.webkit.org/show_bug.cgi?id=63425

A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl

• webkit/webkitwebview.cpp: (webkit_web_view_update_settings):

9:57 AM Changeset in webkit [89827] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-06-27 Hyowon Kim <​hw1008.kim@samsung.com>

Reviewed by Martin Robinson.

[EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
​https://bugs.webkit.org/show_bug.cgi?id=62959

Add PLATFORM(EFL) ifdefs to use GraphicsContextInternal.

• platform/graphics/GraphicsContext3D.h:

9:55 AM Changeset in webkit [89826] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
​https://bugs.webkit.org/show_bug.cgi?id=47971

• fast/css/div_plus_nav_bug47971-expected.txt: Added.
• fast/css/div_plus_nav_bug47971.html: Added.

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
​https://bugs.webkit.org/show_bug.cgi?id=47971

Added a new state in css/tokenizer.flex for the "nth" rule. The state begins
at nth-*( functions and ends at the first ")". It avoids parsing selectors
like "#div+nav" as: "#div" "+n" "av".

Test: fast/css/div_plus_nav_bug47971.html

• css/maketokenizer:
• css/tokenizer.flex:

9:32 AM Changeset in webkit [89825] by commit-queue@webkit.org

• 2 edits in trunk/Tools

2011-06-27 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

[WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
​https://bugs.webkit.org/show_bug.cgi?id=63457

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):

8:51 AM Changeset in webkit [89824] by commit-queue@webkit.org

• 11 edits in trunk

2011-06-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
​http://trac.webkit.org/changeset/89822
​https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

• inspector/styles/get-set-stylesheet-text.html:
• inspector/styles/styles-new-API.html:
• inspector/styles/styles-source-offsets.html:

2011-06-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
​http://trac.webkit.org/changeset/89822
​https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

• inspector/Inspector.json:
• inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
• inspector/InspectorCSSAgent.h:
• inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
• inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):

8:37 AM Changeset in webkit [89823] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-06-27 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Adam Roben.

Send keypress events to windowless plugins on the windows port.
​https://bugs.webkit.org/show_bug.cgi?id=63144

No new tests. Covered by existing windowless plugin tests plugins/mouse-events.html
and plugins/keyboard-events.html. Both are not yet working as desired because focus
events are not being fowarded to windowed plugins on the win port (bug 62375). Test
plugin logging on the win port was added in bug 61721. New failing expectations for
plugins/keyboard-events.html were subsequently added in bug 33973 so there's no need
to update test expectations in this patch.

• plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::handleKeyboardEvent): Add an ASSERT(m_plugin && !m_isWindowed)
to indicate that the routine is for windowless plugins. Remove trailing whitespace.
Add handling for keyPress events (map to WM_CHAR).
(WebCore::PluginView::handleMouseEvent): Add the ASSERT to indicate that the routine
is for windowless plugins. Add FIXME note. Remove trailing whitespace.

8:33 AM Changeset in webkit [89822] by apavlov@chromium.org

• 11 edits in trunk

2011-06-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
​https://bugs.webkit.org/show_bug.cgi?id=63446

WebCore:

• inspector/Inspector.json:
• inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
• inspector/InspectorCSSAgent.h:
• inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
• inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):

LayoutTests:

• inspector/styles/get-set-stylesheet-text.html:
• inspector/styles/styles-new-API.html:
• inspector/styles/styles-source-offsets.html:

8:12 AM Changeset in webkit [89821] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/Tools

2011-06-27 Raphael Kubo da Costa <​kubo@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
It will be plugged into the build system as soon as the rest of the
DRT code is fully upstreamed.
​https://bugs.webkit.org/show_bug.cgi?id=63086

• DumpRenderTree/efl/DumpRenderTreeView.cpp: Added. (onConsoleMessage): (onJavaScriptAlert): (onJavaScriptConfirm): (onJavaScriptPrompt): (drtViewTiledAdd):
• DumpRenderTree/efl/DumpRenderTreeView.h: Added.

8:10 AM Changeset in webkit [89820] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/Tools

2011-06-27 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add an EventSender implementation to EFL's DumpRenderTree along
with support files.
Build system changes will be made as soon as the whole DumpRenderTree
is upstreamed.
​https://bugs.webkit.org/show_bug.cgi?id=61962

• DumpRenderTree/efl/EventSender.cpp: Added. (setEvasModifiers): (translateMouseButtonNumber): (sendMouseEvent): (sendClick): (scheduleAsynchronousClickCallback): (updateClickCount): (modifierFromJSValue): (modifiersFromJSValue): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (evasMouseEventFromHorizontalAndVerticalOffsets): (mouseScrollByCallback): (continuousMouseScrollByCallback): (keyPadNameFromJSValue): (keyNameFromJSValue): (keyDownCallback): (scalePageByCallback): (getClass): (makeEventSender):
• DumpRenderTree/efl/EventSender.h: Added.

7:38 AM Changeset in webkit [89819] by kov@webkit.org

• 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r89817.

7:36 AM Changeset in webkit [89818] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit/efl

2011-06-27 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove private header files from EWebKit_HEADERS.
​https://bugs.webkit.org/show_bug.cgi?id=63441

Remove ewk_tiled_private.h, ewk_tiled_backing_store.h, ewk_tiled_matrix.h,
ewk_tiled_model.h and check WTF_USE_SOUP to remove ewk_auth_soup.h.

• CMakeListsEfl.txt:

7:31 AM Changeset in webkit [89817] by kov@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. One more filed missing during distcheck, for
the MIPS build.

• GNUmakefile.list.am:

7:08 AM Changeset in webkit [89816] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <​pfeldman@google.com>

Not reviewed: updating chromium expectations.

• platform/chromium/test_expectations.txt:

4:54 AM Changeset in webkit [89815] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight
​https://bugs.webkit.org/show_bug.cgi?id=63405

We should not call layout from paint.

• inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
• inspector/DOMNodeHighlighter.h:
• inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::drawNodeHighlight):

4:33 AM Changeset in webkit [89814] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[WK2] Daily gardening.

Remove non-existent svg/animations/animate-points.html from the Skipped list.

• platform/mac-wk2/Skipped:

4:32 AM Changeset in webkit [89813] by pfeldman@chromium.org

• 3 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <​pfeldman@google.com>

Not reviewed: naive approach to fixing flaky inspector tests.

• inspector/styles/styles-cancel-editing.html:
• inspector/styles/styles-commit-editing.html:

3:45 AM Changeset in webkit [89812] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/efl

2011-06-27 Jongseok Yang <​js45.yang@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use accept attribute when executing the file picker for input element
​https://bugs.webkit.org/show_bug.cgi?id=63063

This patch:

• remove the argument "suggested_filenames" from ewk_view_run_open_panel
• add the argument "accept" to ewk_view_run_open_panel
• get the accept attribute and pass to ewk_view_run_open_panel within runOpenPanel

• WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel):
• ewk/ewk_view.cpp: (ewk_view_run_open_panel):
• ewk/ewk_view.h

3:44 AM Changeset in webkit [89811] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebKit/efl

2011-06-27 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

Remove meaningless parameter from WebCoreSupport's header files.

• WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::scrollRectIntoView):
• WebCoreSupport/DragClientEfl.h:
• WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::setWebFrame):

3:18 AM Changeset in webkit [89810] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix style error in EFL port.

• platform/efl/PlatformKeyboardEventEfl.cpp:
• platform/efl/PlatformScreenEfl.cpp:
• platform/efl/SharedBufferEfl.cpp:

1:51 AM Changeset in webkit [89809] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <​hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove ewk_tile_matrix_updates_process() call from _ewk_tiled_backing_store_item_process_idler_cb().
​https://bugs.webkit.org/show_bug.cgi?id=62963

As repaint_process on ewk_view_tiled already takes care of dirty area in visible area
and in order to let pre-render work more efficiently,
_ewk_tiled_backing_store_item_process_idler_cb() better not call ewk_tile_matrix_updates_process().

• ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb):

1:41 AM Changeset in webkit [89808] by eric@webkit.org

• 3 edits in trunk/Tools

2011-06-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove evil uses of hasattr
​https://bugs.webkit.org/show_bug.cgi?id=63430

For some reason these classes believe that they may be called with
various flavors of "option" elements and so carefully check to make
sure that the options element has their option before checking it.

We had a set_option_default method which was never called, so I made it
do what callsites seemed to want it to do and replaced 3 callers
who previously used hasattr manually to use set_option_default instead.

• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:

1:37 AM Changeset in webkit [89807] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
​https://bugs.webkit.org/show_bug.cgi?id=63132

• platform/qt-mac/Skipped: Skip fast/css/custom-font-xheight.html.

1:35 AM Changeset in webkit [89806] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=60813

• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):

1:34 AM Changeset in webkit [89805] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
​https://bugs.webkit.org/show_bug.cgi?id=63396

• platform/mac-wk2/Skipped: Skip new tests introduced in r89783.

1:15 AM Changeset in webkit [89804] by pfeldman@chromium.org

• 30 edits in trunk

2011-06-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
​https://bugs.webkit.org/show_bug.cgi?id=63422

• http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.waitForStyles): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.nodeSelected): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.stylesUpdated): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles):
• http/tests/inspector/inspect-iframe-from-different-domain.html:
• inspector/elements/edit-dom-actions.html:
• inspector/elements/elements-delete-inline-style.html:
• inspector/elements/elements-panel-styles.html:
• inspector/styles/metrics-box-sizing.html:
• inspector/styles/parse-utf8-bom.html:
• inspector/styles/styles-add-blank-property.html:
• inspector/styles/styles-add-invalid-property.html:
• inspector/styles/styles-cancel-editing.html:
• inspector/styles/styles-commit-editing.html:
• inspector/styles/styles-computed-trace.html:
• inspector/styles/styles-disable-inherited.html:
• inspector/styles/styles-disable-then-change.html:
• inspector/styles/styles-disable-then-delete.html:
• inspector/styles/styles-disable-then-enable.html:
• inspector/styles/styles-iframe-expected.txt:
• inspector/styles/styles-iframe.html:
• inspector/styles/styles-source-lines-expected.txt:
• inspector/styles/styles-source-lines-inline.html:
• inspector/styles/styles-source-lines.html:
• inspector/styles/styles-update-from-js-expected.txt:
• inspector/styles/styles-update-from-js.html:
• inspector/styles/styles-url-linkify.html:
• inspector/styles/up-down-numerics-and-colors-expected.txt:
• inspector/styles/up-down-numerics-and-colors.html:

2011-06-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
​https://bugs.webkit.org/show_bug.cgi?id=63422

• inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateStyles): (WebInspector.ElementsPanel.prototype._stylesUpdated):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):

1:10 AM Changeset in webkit [89803] by commit-queue@webkit.org

• 4 edits in trunk/Source

2011-06-27 Huang Dongsung <​luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
​https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

• platform/graphics/TiledBackingStore.cpp: (WebCore::innerBottomRight): (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):

2011-06-27 Huang Dongsung <​luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
​https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

• UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::innerBottomRight): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):

1:07 AM Changeset in webkit [89802] by tkent@chromium.org

• 2 edits in trunk/Tools

2011-06-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] WebViewHost should be destructed before LayoutTestController, etc.
​https://bugs.webkit.org/show_bug.cgi?id=63427

~WebViewHost() navigates to about:blank, so it calls some
callbacks and LayoutTestController functions.

• DumpRenderTree/chromium/TestShell.h: Move m_printer upper and move m_webViewHost lower.

1:04 AM Changeset in webkit [89801] by abarth@webkit.org

• 2 edits
  2 moves in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move server config files to webkitpy.layout_tests.servers
​https://bugs.webkit.org/show_bug.cgi?id=63436

The config files belong with the servers.

• Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
• Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
• Scripts/webkitpy/layout_tests/servers/http_server.py:
• Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
• Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.

1:01 AM Changeset in webkit [89800] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <​hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item's update field.
​https://bugs.webkit.org/show_bug.cgi?id=62967

As some code do not affect any logical flow of tiled backing store except condition check,
I would like to clean dead code related with Ewk_Tiled_Backing_Store_Item's update field
and Ewk_Tiled_Backing_Store_Data's queue field

• ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del):

12:59 AM Changeset in webkit [89799] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
​https://bugs.webkit.org/show_bug.cgi?id=63396

• platform/mac-wk2/Skipped: Skip a new test.

12:59 AM Changeset in webkit [89798] by abarth@webkit.org

• 7 edits
  4 moves in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move websocket_server and http_server to webkitpy.layout_package.servers
​https://bugs.webkit.org/show_bug.cgi?id=63434

These classes do not represent ports. They represent servers.

• Scripts/new-run-webkit-httpd:
• Scripts/new-run-webkit-websocketserver:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/chromium.py:
• Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
• Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
• Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
• Scripts/webkitpy/layout_tests/port/port_testcase.py:
• Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
• Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
• Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
• Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
• Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
• Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.

12:54 AM Changeset in webkit [89797] by eric@webkit.org

• 3 edits in trunk/Tools

2011-06-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=63428

• Scripts/webkitpy/layout_tests/port/chromium.py:
• Scripts/webkitpy/layout_tests/port/chromium_mac.py:

12:46 AM Changeset in webkit [89796] by Csaba Osztrogonác

• 8 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results after r89745.

• platform/qt/Skipped: Revert accidentally committed (r89732) changes.
• platform/qt/svg/custom/linking-a-03-b-all-expected.png:
• platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
• platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
• platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
• platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
• platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:

12:43 AM Changeset in webkit [89795] by abarth@webkit.org

• 2 edits
  1 move
  2 adds in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move apache_http_server.py to webkitpy.layout_package.servers
​https://bugs.webkit.org/show_bug.cgi?id=63433

The apache_http_server.py is a server, not a port.

• Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/servers: Added.
• Scripts/webkitpy/layout_tests/servers/init.py: Added.
• Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.

12:34 AM Changeset in webkit [89794] by abarth@webkit.org

• 2 edits
  2 moves in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
​https://bugs.webkit.org/show_bug.cgi?id=63432

This code isn't in the dependency cone of new-run-webkit-tests. It's
unclear what it's final home should be, but this patch moves it out of
layout_tests to simply the package.

• Scripts/rebaseline-chromium-webkit-tests:
• Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
• Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
• Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
• Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.

12:20 AM Changeset in webkit [89793] by abarth@webkit.org

• 2 edits
  2 moves in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
​https://bugs.webkit.org/show_bug.cgi?id=63429

This package as nothing to do with the layout_tests package.

• Scripts/update-webgl-conformance-tests:
• Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
• Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
• Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
• Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.

12:11 AM Changeset in webkit [89792] by yutak@chromium.org

• 4 edits in trunk/Source/WebKit/chromium

2011-06-27 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Adam Barth.

[Chromium] Add useHixie76WebSocketProtocol to WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=63424

• public/WebSettings.h:
• src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHixie76WebSocketProtocolEnabled):
• src/WebSettingsImpl.h:

12:10 AM Changeset in webkit [89791] by abarth@webkit.org

• 3 edits
  2 moves
  2 adds in trunk/Tools

2011-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move deduplicate_tests.py into webkitpy.to_be_moved
​https://bugs.webkit.org/show_bug.cgi?id=63426

deduplicate_tests.py doesn't haven anything to do with layout tests.
It's really a separate script. This patch moves it to the (new)
to_be_moved package so that it doesn't distract us when working on NRWT.

• Scripts/deduplicate-tests:
• Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
• Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
• Scripts/webkitpy/test/main.py:
• Scripts/webkitpy/to_be_moved: Added.
• Scripts/webkitpy/to_be_moved/init.py: Added.
• Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
• Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.

Jun 26, 2011:

11:50 PM Changeset in webkit [89790] by mrowe@apple.com

• 4 edits in trunk/Source

Use a separate file name for Lion's WebKitSystemInterface.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

• Configurations/DebugRelease.xcconfig:

Source/WebKit2:

• Configurations/DebugRelease.xcconfig:

11:49 PM Changeset in webkit [89789] by abarth@webkit.org

• 8 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from WebAudio IDL files
​https://bugs.webkit.org/show_bug.cgi?id=63416

WebAudio isn't that widely used, so it's seems somewhat safe to remove
legacy code generation hacks. I'm not an expert on WebAudio, but the
API doesn't appear to need many optional arguments.

There are a bunch of APIs that have custom bindings that look like they
could be autogenerated. I've added FIXME comments where appropriate.

• webaudio/AudioBuffer.idl:
• webaudio/AudioContext.idl:
• webaudio/AudioListener.idl:
• webaudio/AudioNode.idl:
• webaudio/AudioPannerNode.idl:
• webaudio/AudioParam.idl:
• webaudio/RealtimeAnalyserNode.idl:

11:40 PM Changeset in webkit [89788] by abarth@webkit.org

• 1 edit
  1 delete in trunk/Tools

2011-06-26 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Remove empty directory.

• Scripts/webkitpy/layout_tests/test_types: Removed.

11:40 PM Changeset in webkit [89787] by yurys@chromium.org

• 2 edits in trunk/Source/WebCore

2011-06-26 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
​https://bugs.webkit.org/show_bug.cgi?id=63421

Show generic sidebar menu only if no pane-specific menu has been shown.

• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

11:39 PM Changeset in webkit [89786] by abarth@webkit.org

• 2 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <​abarth@webkit.org>

Build fix for clang. Apparently clang doesn't want us to use the std
namespace in headers, which makes sense.

• svg/SVGAnimatedType.h:

11:31 PM Changeset in webkit [89785] by abarth@webkit.org

• 3 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
​https://bugs.webkit.org/show_bug.cgi?id=63418

The XMLHttpRequest.idl interface used to implement the new behavior
manually using the RequiresAllArguments attribute. Now that we have
that behavior by default, we can simply remove the
LegacyDefaultOptionalArguments attribute.

• xml/XMLHttpRequest.idl:
• xml/XMLHttpRequestUpload.idl:

11:22 PM Changeset in webkit [89784] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.

Rubber-stamped by Maciej Stachowiak.

• WebProcess/mac/WebProcessMac.mm:

11:16 PM Changeset in webkit [89783] by krit@webkit.org

• 15 edits
  13 adds in trunk

2011-06-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
​https://bugs.webkit.org/show_bug.cgi?id=63399

Test animations of attributes with type SVGLengthList.

• svg/animations/script-tests/svglengthlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svglengthlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svglengthlist-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svglengthlist-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/svglengthlist-animation-1-expected.txt: Added.
• svg/animations/svglengthlist-animation-1.html: Added.
• svg/animations/svglengthlist-animation-2-expected.txt: Added.
• svg/animations/svglengthlist-animation-2.html: Added.
• svg/animations/svglengthlist-animation-3-expected.txt: Added.
• svg/animations/svglengthlist-animation-3.html: Added.
• svg/animations/svglengthlist-animation-4-expected.txt: Added.
• svg/animations/svglengthlist-animation-4.html: Added.

2011-06-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
​https://bugs.webkit.org/show_bug.cgi?id=63399

Follow up of "SVGAnimation should use direct unit animation for SVGLength": ​https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.

Interpolated animations of glyph positions are possible now.

Tests: svg/animations/svglengthlist-animation-1.html

svg/animations/svglengthlist-animation-2.html
svg/animations/svglengthlist-animation-3.html
svg/animations/svglengthlist-animation-4.html

• CMakeLists.txt: Add new file to build system.
• GNUmakefile.list.am: Ditto.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• svg/SVGAllInOne.cpp: Ditto.
• svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
• svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList. (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator): (WebCore::SVGAnimatedLengthListAnimator::constructFromString): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
• svg/SVGAnimatedLengthList.h: (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
• svg/SVGAnimatedType.cpp: Add SVGLengthList. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createLengthList): (WebCore::SVGAnimatedType::lengthList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
• svg/SVGAnimatedType.h:
• svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
• svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value. (WebCore::SVGLength::SVGLength):
• svg/SVGLength.h:

9:49 PM Changeset in webkit [89782] by abarth@webkit.org

• 4 edits
  3 adds in trunk

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=63411

• http/tests/security/location-prototype-expected.txt: Added.
• http/tests/security/location-prototype.html: Added.
• http/tests/security/resources/location-prototype-overwrite.html: Added.

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=63411

This patch corrects the prototype chain for Location, but we really
should do a complete cleanup of the prototype chain generation, like we
did for JavaScriptCore.

Test: http/tests/security/location-prototype.html

• bindings/scripts/CodeGeneratorV8.pm:

9:45 PM Changeset in webkit [89781] by abarth@webkit.org

• 18 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add [Optional] attributes where appropriate for addEventListener and removeEventListener
​https://bugs.webkit.org/show_bug.cgi?id=63417

This patch doesn't actually change behavior because these interfaces
have the LegacyDefaultOptionalArguments attribute. This patch paves
the way to removing LegacyDefaultOptionalArguments from some of these
interfaces as well as making the project safer for copy-and-pasting
these methods into new IDL files that don't have the
LegacyDefaultOptionalArguments attribute.

• bindings/scripts/test/TestObj.idl:
• dom/EventTarget.idl:
• dom/MediaStream.idl:
• dom/MessagePort.idl:
• dom/Node.idl:
• loader/appcache/DOMApplicationCache.idl:
• notifications/Notification.idl:
• page/DOMWindow.idl:
• page/EventSource.idl:
• storage/IDBRequest.idl:
• storage/IDBTransaction.idl:
• svg/SVGElementInstance.idl:
• websockets/WebSocket.idl:
• workers/AbstractWorker.idl:
• workers/WorkerContext.idl:
• xml/XMLHttpRequest.idl:
• xml/XMLHttpRequestUpload.idl:

8:43 PM Changeset in webkit [89780] by abarth@webkit.org

• 3 edits
  2 adds in trunk

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
​https://bugs.webkit.org/show_bug.cgi?id=62956

• fast/forms/form-associated-element-crash3-expected.txt: Added.
• fast/forms/form-associated-element-crash3.html: Added.

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
​https://bugs.webkit.org/show_bug.cgi?id=62956

Test: fast/forms/form-associated-element-crash3.html

• dom/Document.h:

8:34 PM Changeset in webkit [89779] by takano.naoki@gmail.com

• 2 edits in trunk/Tools

Change committers entry.w

8:15 PM Changeset in webkit [89778] by abarth@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove WebSecurityOrigin::grantUniversalAccess
​https://bugs.webkit.org/show_bug.cgi?id=63415

This function has no callers and is downright dangerous.

• public/WebSecurityOrigin.h:
• src/WebSecurityOrigin.cpp:

6:47 PM Changeset in webkit [89777] by Dimitri Glazkov

• 5 edits in trunk/Source/WebCore

2011-06-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

FileList::filenames should be FileList::paths, because it's more accurate.
​https://bugs.webkit.org/show_bug.cgi?id=63414

Refactoring, no change in behavior.

• fileapi/FileList.cpp: (WebCore::FileList::paths): Renamed from filenames.
• fileapi/FileList.h:
• html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto.
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::fileTextValue): Ditto.

5:31 PM Changeset in webkit [89776] by ryuan.choi@samsung.com

• 3 edits in trunk/Source/WebKit/efl

2011-06-26 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API.
​https://bugs.webkit.org/show_bug.cgi?id=62688

Move functions which use Ewk_View_Private_Data and may not be required by
applications to ewk_private.h.

• ewk/ewk_private.h:
• ewk/ewk_view.h:

4:06 PM Changeset in webkit [89775] by abarth@webkit.org

• 1 edit
  4 adds in trunk/LayoutTests

2011-06-26 Adam Barth <​abarth@webkit.org>

Baselines for new test.

• platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
• platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
• platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
• platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.

2:26 PM Changeset in webkit [89774] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

2011-06-26 Young Han Lee <​joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
​https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
​http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

• svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
• svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
• svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-06-26 Young Han Lee <​joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
​https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
​http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

• svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex):

1:21 PM Changeset in webkit [89773] by abarth@webkit.org

• 4 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove code behind WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
​https://bugs.webkit.org/show_bug.cgi?id=63402

These old APIs are no longer needed.

• public/WebFrame.h:
• src/WebFrameImpl.cpp:
• src/WebFrameImpl.h:

12:30 PM Changeset in webkit [89772] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

2011-06-26 Filip Pizlo <​fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
​https://bugs.webkit.org/show_bug.cgi?id=63347

• dfg/DFGNonSpeculativeJIT.cpp:
  • Changed arithmetic operations to speculate in favor of integers.

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

• dfg/DFGNonSpeculativeJIT.h:
• dfg/DFGOperations.cpp:
  • Added slow-path routines for arithmetic that perform no speculation; the non-speculative JIT will generate calls to these in cases where its speculation fails.
• dfg/DFGOperations.h:

10:17 AM Changeset in webkit [89771] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

2011-06-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Don't use a Mutex for protecting access to the connection queue clients
​https://bugs.webkit.org/show_bug.cgi?id=63403

Make sure to only access the queue client vector from the connection work queue.
This gets rid of a lock and ensures that adding/removing clients from callbacks works correctly.

• Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::addQueueClientOnWorkQueue): (CoreIPC::Connection::removeQueueClientOnWorkQueue): (CoreIPC::Connection::processIncomingMessage):
• Platform/CoreIPC/Connection.h:

10:04 AM Changeset in webkit [89770] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <​abarth@webkit.org>

Darn. Need BUGWG to make the file parse.

• platform/chromium/test_expectations.txt:

9:09 AM Changeset in webkit [89769] by mitz@apple.com

• 3 edits
  3 adds in trunk

With word-break: break-all, words do not break correctly before a surrogate pair
​https://bugs.webkit.org/show_bug.cgi?id=63401

Reviewed by Darin Adler.

Source/WebCore:

The code to check for mid-word breaks accumulates width one character at a time. It was actually
measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
Fixed by checking for surrogate pairs and measuring the pair as one unit.

Test: fast/text/midword-break-before-surrogate-pair.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

• fast/text/midword-break-before-surrogate-pair.html: Added.

7:22 AM Changeset in webkit [89768] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <​abarth@webkit.org>

Note that this test ASSERTs on Linux Debug.

• platform/chromium/test_expectations.txt:

6:12 AM Changeset in webkit [89767] by kbalazs@webkit.org

• 3 edits in trunk/LayoutTests

Unreviewed gardening.

[WK2] SVG animation pause API missing
​https://bugs.webkit.org/show_bug.cgi?id=63396

Skip new tests that depend on pause API. Put them to the
mac list that is used by all WebKit2 platforms.

• platform/mac-wk2/Skipped:
• platform/qt-wk2/Skipped:

4:24 AM Changeset in webkit [89766] by krit@webkit.org

• 13 edits
  14 adds in trunk

2011-06-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
​https://bugs.webkit.org/show_bug.cgi?id=63397

Follow up of "SVGAnimation should use direct unit animation for SVGLength": ​https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.

Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
growing shadows with feGaussianBlur, feDropShadow or other filter effects.

Tests: svg/animations/svgnumberoptionalnumber-animation-1.html

svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html

• CMakeLists.txt: Added new files to build system.
• GNUmakefile.list.am: Ditto.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• svg/SVGAllInOne.cpp: Ditto.
• svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
• svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
• svg/SVGAnimatedNumberOptionalNumber.h: Added. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
• svg/SVGAnimatedType.cpp: Added new type: pair<float, float>. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberOptionalNumber): (WebCore::SVGAnimatedType::numberOptionalNumber): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
• svg/SVGAnimatedType.h:
• svg/SVGAnimatorFactory.h: Add new animator to factory. (WebCore::SVGAnimatorFactory::create):

2011-06-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
​https://bugs.webkit.org/show_bug.cgi?id=63397

Test animation of SVGNumberOptionalNumber values with and without optional number, as well as 'to' and 'by' animations.

• svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
• svg/animations/svgnumberoptionalnumber-animation-1-expected.txt: Added.
• svg/animations/svgnumberoptionalnumber-animation-1.html: Added.
• svg/animations/svgnumberoptionalnumber-animation-2-expected.txt: Added.
• svg/animations/svgnumberoptionalnumber-animation-2.html: Added.
• svg/animations/svgnumberoptionalnumber-animation-3-expected.txt: Added.
• svg/animations/svgnumberoptionalnumber-animation-3.html: Added.
• svg/animations/svgnumberoptionalnumber-animation-4-expected.txt: Added.
• svg/animations/svgnumberoptionalnumber-animation-4.html: Added.

2:35 AM Changeset in webkit [89765] by kbalazs@webkit.org

• 2 edits in trunk/LayoutTests

2011-06-26 Balazs Kelemen <​kbalazs@webkit.org>

Unreviewed. Skip failing tests.

[Qt][WK2] svgnumberlist-animation-[1,2] fails since added
​https://bugs.webkit.org/show_bug.cgi?id=63396

• platform/qt-wk2/Skipped: