Timeline
Jul 2, 2011:
- 9:02 PM Changeset in webkit [90335] by
-
- 2 edits in trunk/LayoutTests
2011-07-02 Mihai Parparita <mihaip@chromium.org>
Remove failing expectation for fast/events/panScroll-click-hyperlink.html
(Chromium still doesn't pass the test, since it doesn't have pan
scrolling enabled, but r90235 added failing expectations for the Windows
port, which Chromium Win and Linux pick up)
Also remove flaky expectations for some tests that have not failed as
far back as the flakiness dashboard has data for.
- platform/chromium/test_expectations.txt:
- 7:26 PM Changeset in webkit [90334] by
-
- 6 edits in trunk/PerformanceTests/SunSpider
2011-07-02 Maciej Stachowiak <mjs@apple.com>
Update SunSpider versioning to 1.0
https://bugs.webkit.org/show_bug.cgi?id=63870
Reviewed by Dan Bernstein.
- hosted/sunspider.html:
- hosted/versions.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- sunspider:
- 6:35 PM Changeset in webkit [90333] by
-
- 3 edits in trunk/PerformanceTests/SunSpider
2011-07-02 Maciej Stachowiak <mjs@apple.com>
Sunspider 0.9.1 harness doesn't actually close() its test documents
https://bugs.webkit.org/show_bug.cgi?id=47045
Reviewed by Daniel Bates.
- hosted/versions.html:
- resources/driver-TEMPLATE.html:
- 6:19 PM Changeset in webkit [90332] by
-
- 3 edits in trunk/Source/WebKit2
Have another go at fixing the Windows build.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- 6:15 PM Changeset in webkit [90331] by
-
- 5 edits in trunk/Source/WebKit2
2011-07-02 Anders Carlsson <andersca@apple.com>
Null out the plug-in controller after destroying the plug-in.
https://bugs.webkit.org/show_bug.cgi?id=63869
Reviewed by Maciej Stachowiak.
- PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::destroy): Call destroyPlugin.
- WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::destroyPlugin): Call destroy and null out the plug-in controller.
- WebProcess/Plugins/Plugin.h: Add destroyPlugin, make destroy private.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Call destroyPlugin.
- 5:57 PM Changeset in webkit [90330] by
-
- 2 edits in trunk/LayoutTests
Update skipped list.
- platform/wk2/Skipped:
- 5:51 PM Changeset in webkit [90329] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build for real.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
- 4:55 PM Changeset in webkit [90328] by
-
- 5 edits in trunk/Source/WebKit2
2011-07-02 Anders Carlsson <andersca@apple.com>
Implement NPN_PluginThreadAsyncCall
https://bugs.webkit.org/show_bug.cgi?id=63868
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PluginThreadAsyncCall): Call NetscapePlugin::pluginThreadAsyncCall.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginThreadAsyncCall): Schedule a work item to call the function on the main run loop.
(WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
If the plug-in is still running, run the function.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add new member function.
- WebProcess/Plugins/Plugin.h: Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially ref the plug-in from other threads.
- 4:41 PM Changeset in webkit [90327] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- 4:40 PM Changeset in webkit [90326] by
-
- 8 edits in trunk/Source/WebKit2
2011-07-02 Anders Carlsson <andersca@apple.com>
Move the plug-in controller member variable up to the shared Plugin base class
https://bugs.webkit.org/show_bug.cgi?id=63867
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Remove m_pluginController.
(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::userAgent):
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::setStatusbarText):
(WebKit::NetscapePlugin::evaluate):
(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
(WebKit::NetscapePlugin::tryToShortCircuitInvoke):
(WebKit::NetscapePlugin::cancelStreamLoad):
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
(WebKit::NetscapePlugin::getAuthenticationInfo):
Use controller() instead of m_pluginController.
(WebKit::NetscapePlugin::initialize):
This doesn't take a PluginController parameter anymore.
(WebKit::NetscapePlugin::destroy):
No need to null out the plug-in controller.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Remove m_pluginController member variable.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::windowFocusChanged): Use controller() instead of m_pluginController.
- WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Plugin): Initialize m_pluginController.
(WebKit::Plugin::initialize):
New function that initializes the plug-in controller and then calls the real
virtual initialize member function.
- WebProcess/Plugins/Plugin.h: Add m_pluginController member variable and a new initialize virtual member function that doesn't take a PluginController parameter. Make the "old" initialize member function set up the plug-in controller.
(WebKit::Plugin::controller):
This is now a simple getter.
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::PluginProxy): Remove m_pluginController.
(WebKit::PluginProxy::pluginProcessCrashed):
Use controller(), remove a bogus null check.
(WebKit::PluginProxy::initialize):
This doesn't take a PluginController parameter now.
(WebKit::PluginProxy::destroy):
No need to null out the plug-in controller member variable.
(WebKit::PluginProxy::loadURL):
(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
(WebKit::PluginProxy::getAuthenticationInfo):
(WebKit::PluginProxy::windowNPObjectID):
(WebKit::PluginProxy::getPluginElementNPObject):
(WebKit::PluginProxy::evaluate):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):
(WebKit::PluginProxy::setComplexTextInputEnabled):
(WebKit::PluginProxy::update):
Use controller() instead of m_pluginController.
- WebProcess/Plugins/PluginProxy.h: Remove m_pluginController.
- 4:20 PM Changeset in webkit [90325] by
-
- 2 edits in trunk/LayoutTests
2011-07-02 Mihai Parparita <mihaip@chromium.org>
Remove Chromium Leopard failing expectations for two tests (fast/dom/
HTMLMeterElement/meter-writing-mode.html and fast/images/
imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.
- platform/chromium/test_expectations.txt:
- 4:08 PM Changeset in webkit [90324] by
-
- 9 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof
Reviewed by Sam Weinig.
Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jitAssertIsCell):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitAssertIsCell):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:59 PM Changeset in webkit [90323] by
-
- 2 edits in trunk/LayoutTests
2011-07-02 Mihai Parparita <mihaip@chromium.org>
Meant to actually remove expectations in r90322, not just comment them
out.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [90322] by
-
- 2 edits8 adds in trunk/LayoutTests
2011-07-02 Mihai Parparita <mihaip@chromium.org>
Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
since the regular Mac baselines can't be used due to single-pixel
differences in character rendering (presumably caused by 32-bit vs.
64-bit binaries).
- platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 2:12 PM Changeset in webkit [90321] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
Not Reviewed.
Fix obviou typo in previous commit.
- tests/sunspider-1.0/bitops-bitwise-and.js:
- 2:11 PM Changeset in webkit [90320] by
-
- 2 edits2 deletes in trunk/LayoutTests
2011-07-02 Mihai Parparita <mihaip@chromium.org>
Chromium expectations update:
- Add failing expectation for fast/css/last-of-type-pseudo-class.html, which fails in debug only.
- Remove Chromium-specific baselines for fast/js/reserved-words.html, the test now passes with the regular baselines.
- platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
- platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:09 PM Changeset in webkit [90319] by
-
- 5 edits in trunk/PerformanceTests/SunSpider
2011-07-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
SunSpider: all four bitops benchmarks can be replaced with NOP
https://bugs.webkit.org/show_bug.cgi?id=38446
- tests/sunspider-1.0/bitops-3bit-bits-in-byte.js: (TimeFunc): Save the result.
- tests/sunspider-1.0/bitops-bits-in-byte.js: (TimeFunc): Save the result.
- tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly save the results.
- tests/sunspider-1.0/bitops-nsieve-bits.js: (sieve): Save the result.
- 1:57 PM Changeset in webkit [90318] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
2011-07-02 Maciej Stachowiak <mjs@apple.com>
SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
https://bugs.webkit.org/show_bug.cgi?id=60937
Reviewed by Dan Bernstein.
- tests/sunspider-1.0/string-validate-input.js: (doTest): Rename the variable to username
- 1:45 PM Changeset in webkit [90317] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
2011-07-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
SunSpider: The main function of math-cordic is dead code
https://bugs.webkit.org/show_bug.cgi?id=63863
Try to prevent math-cordic from being eliminated as dead code or
compiled down to a constant.
- tests/sunspider-1.0/math-cordic.js: (cordicsincos): (cordic):
- 10:26 AM Changeset in webkit [90316] by
-
- 2 edits in trunk/WebKitLibraries
Update the header file too.
- WebKitSystemInterface.h:
- 9:25 AM Changeset in webkit [90315] by
-
- 3 edits1 add in trunk/WebKitLibraries
Update WebKitSystemInterface binaries.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a: Added.
- libWebKitSystemInterfaceSnowLeopard.a:
- 3:46 AM Changeset in webkit [90314] by
-
- 2 edits1 delete in trunk/LayoutTests
[GTK] Update expectation of fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=49245
- platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
- platform/gtk/fast/forms/input-file-re-render-expected.txt:
Jul 1, 2011:
- 11:00 PM Changeset in webkit [90313] by
-
- 10 edits in trunk
2011-07-01 Kent Tamura <tkent@chromium.org>
[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733
Also, input-file-label.html passes now.
- platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
- platform/chromium-linux/fast/forms/input-file-re-render-expected.txt:
- platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
- platform/chromium-mac/fast/forms/input-file-re-render-expected.png:
- platform/chromium-win/fast/forms/input-file-re-render-expected.png:
- platform/chromium-win/fast/forms/input-file-re-render-expected.txt:
- platform/chromium/test_expectations.txt:
2011-07-01 Kent Tamura <tkent@chromium.org>
[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733
- DEPS: Update chromium revision to 91405 to have "Choose Files" string.
- 9:47 PM Changeset in webkit [90312] by
-
- 3 edits in trunk/LayoutTests
2011-07-01 Kent Tamura <tkent@chromium.org>
[Chromium] Update the expectation of search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:45 PM Changeset in webkit [90311] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Remove GTK baseline added in r90294 since the test was fixed in r90309.
(File name was wrong. It was supposed to be -expected.txt)
- platform/gtk/editing/selection/directionality-after-undo-replace.html: Removed.
- 7:38 PM Changeset in webkit [90310] by
-
- 2 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Fix typo in master.cfg, hoping to trigger a master restart.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 7:34 PM Changeset in webkit [90309] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
[GTK] editing/selection/directionality-after-undo-replace.html is failing
https://bugs.webkit.org/show_bug.cgi?id=63853
Reviewed by Ojan Vafai.
Don't do leapForward between mouseDown and mouseUp so that GTK recognizes the double-click.
- editing/selection/directionality-after-undo-replace.html:
- 7:20 PM Changeset in webkit [90308] by
-
- 9 edits in trunk/Source
2011-07-01 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
[Chromium] FileSystem API can be used to learn about installed software on the user's computer
https://bugs.webkit.org/show_bug.cgi?id=63220
- public/WebMimeRegistry.h: (WebKit::WebMimeRegistry::wellKnownMimeTypeForExtension):
- src/PlatformBridge.cpp: (WebCore::PlatformBridge::wellKnownMimeTypeForExtension):
2011-07-01 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
[Chromium] FileSystem API can be used to learn about installed software on the user's computer.
Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
without consulting the OS/registry.
https://bugs.webkit.org/show_bug.cgi?id=63220
No new tests, existing layout tests that invoke file.type apply.
- fileapi/File.cpp: Refactored the factory methods. (WebCore::createBlobDataForFileWithType): (WebCore::createBlobDataForFile): (WebCore::createBlobDataForFileSystemFile): (WebCore::File::File):
- platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::mediaMIMETypeMap): (WebCore::findMimeType): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
- platform/MIMETypeRegistry.h:
- platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): (WebCore::findMimeType):
- platform/chromium/PlatformBridge.h:
- 6:05 PM Changeset in webkit [90307] by
-
- 2 edits in trunk/Source/WebCore
2011-07-01 Tim Horton <timothy_horton@apple.com>
Reviewed by Darin Adler.
SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
https://bugs.webkit.org/show_bug.cgi?id=54325
Add image/svg+xml to the list of acceptable MIME types for the Image type.
- inspector/front-end/inspector.js: (WebInspector):
- 5:55 PM Changeset in webkit [90306] by
-
- 3 edits in trunk/LayoutTests
2011-07-01 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
Use common functions in fast/forms/search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787
- fast/forms/search-rtl.html: Use searchCancelButtonPosition() to make this work on Chromium Windows and Chromium Linux.
- platform/chromium/test_expectations.txt:
- 5:45 PM Changeset in webkit [90305] by
-
- 3 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Turn off new-run-webkit-tests and remove some debug logging.
- Scripts/run-webkit-tests:
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 5:43 PM Changeset in webkit [90304] by
-
- 4 edits in trunk/Source/WebCore
2011-07-01 Tim Horton <timothy_horton@apple.com>
Reviewed by Darin Adler.
Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
Add SVGElement::reportAttributeParsingError, which will
write a Web Inspector console message if passed an SVGParsingError
and the attribute which was being applied, only in the case where
there is actually an error.
Include the SVG document's URI when writing to the Web Inspector
console, so that the UI displays both the filename and the line number.
- svg/SVGDocumentExtensions.cpp: (WebCore::reportMessage):
- svg/SVGElement.cpp: (WebCore::SVGElement::reportAttributeParsingError):
- svg/SVGElement.h:
- 5:26 PM Changeset in webkit [90303] by
-
- 4 edits in trunk/Source
2011-07-01 Scott Byer <scottbyer@chromium.org>
Reviewed by Adam Barth.
Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770
Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace
Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.
- platform/ScrollAnimatorNone.cpp: (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters): (WebCore::ScrollAnimatorNone::scroll):
2011-07-01 Scott Byer <scottbyer@chromium.org>
Reviewed by Adam Barth.
Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770
Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.
- tests/ScrollAnimatorNoneTest.cpp: (ScrollAnimatorNoneTest::updateDataFromParameters): (TEST_F):
- 5:16 PM Changeset in webkit [90302] by
-
- 22 edits in trunk/Source/WebCore
2011-07-01 Levi Weintraub <leviw@chromium.org>
Switch primary virtual layout functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63852
Reviewed by Eric Seidel.
Switching the primary overloaded layout functions over to the new layout unit abstraction.
No new tests, no functionality changes.
- html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::layout):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::layout):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
- rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::layout):
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout):
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
- rendering/RenderView.cpp: (WebCore::RenderView::layout):
- rendering/RenderView.h: (WebCore::RenderView::layoutDelta): (WebCore::RenderView::addLayoutDelta):
- rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout):
- rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::layout):
- rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::layout):
- rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout):
- 5:09 PM Changeset in webkit [90301] by
-
- 5 edits in trunk
2011-07-01 Sam Weinig <sam@webkit.org>
Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856
Reviewed by Dan Bernstein.
Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
the nesting cap to 512 to cover more cases where rending recursion was biting us.
- page/Settings.h: Reduce the nesting cap to 512.
2011-07-01 Sam Weinig <sam@webkit.org>
Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856
Update test for new cap.
- fast/parser/block-nesting-cap-expected.txt:
- fast/parser/script-tests/block-nesting-cap.js:
- 5:09 PM Changeset in webkit [90300] by
-
- 2 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Add some more debug logging to try to understand why we're getting
stuck acquring the HTTP lock.
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 5:05 PM Changeset in webkit [90299] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=63855
Reviewed by Ryosuke Niwa.
Allow a trailing whitespace in the expected result, since Windows
has different word iterating behavior.
- editing/selection/directionality-after-undo-replace.html:
- 4:45 PM Changeset in webkit [90298] by
-
- 2 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854
Reviewed by Dirk Pranke.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 4:41 PM Changeset in webkit [90297] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Remove Chromium Windows 7 and Vista media test expectations, since
clobbering the bots appears to have fixed the timeouts and failures.
- platform/chromium/test_expectations.txt:
- 4:30 PM Changeset in webkit [90296] by
-
- 5 edits in tags/Safari-534.50.2/Source
Versioning
- 4:24 PM Changeset in webkit [90295] by
-
- 2 edits in trunk/Source/WebCore
Add change accidentally left out of last commit.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
backing scale.
- 4:19 PM Changeset in webkit [90294] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853.
- platform/gtk/editing/selection/after-line-break-expected.txt: Added.
- platform/gtk/editing/selection/directionality-after-undo-replace.html: Added.
- 4:13 PM Changeset in webkit [90293] by
-
- 6 edits in trunk/Source
2011-07-01 Darin Adler <Darin Adler>
Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848
Reviewed by Simon Fraser.
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::clampedContentsScaleForScale): Increased the maximum scale since scale factor can now include both page contents scale and backing scale.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the backing scale as well as the page contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageContentsScale): Added. (WebCore::RenderLayerBacking::backingScale): Added.
- rendering/RenderLayerBacking.h: Added new private functions.
2011-07-01 Darin Adler <Darin Adler>
Consider backing scale factor when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848
Reviewed by Simon Fraser.
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): Set contents scale on the non-composited content layer based on the backing scale factor. (WebKit::LayerTreeHostCA::createPageOverlayLayer): Set contents scale on the page overlay layer based on the backing scale factor.
- 4:09 PM Changeset in webkit [90292] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Nate Chapin <Nate Chapin>
Unreviewed, remove extraneous newlines from
expected results for fast/workers/worker-finish-crash.html.
- fast/workers/worker-finish-crash-expected.txt:
- 4:06 PM Changeset in webkit [90291] by
-
- 3 edits in trunk/LayoutTests
The commit-bot checked in files without Subversion properties, so adding them now.
- fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added property svn:eol-style.
- fast/loader/create-frame-in-DOMContentLoaded.html: Added properties svn:mime-type and svn:eol-style.
- 4:02 PM Changeset in webkit [90290] by
-
- 4 edits in trunk/Source
../WebCore: WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
Reviewed by Darin Adler.
No new tests. I tried to make a test in DumpRenderTree with an editable WebView,
but was unsuccessful in getting the crash to happen in that instance.
- editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT.
../WebKit/mac: WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
Reviewed by Darin Adler.
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
space, and after-white-space properties to subframes in the editable document.
- 3:43 PM Changeset in webkit [90289] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner.
- platform/wk2/Skipped:
- 3:31 PM Changeset in webkit [90288] by
-
- 6 edits in trunk/Source/WebCore
2011-07-01 Levi Weintraub <leviw@chromium.org>
Switch overflow and collapsedMargins to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63840
Reviewed by Eric Seidel.
Switching overflow and collapsedMargins over to the new layout unit abstraction.
Also removing an unused function: blockDirectionOverflow
No new tests, no functionality changes.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapsedMarginBeforeForChild): (WebCore::RenderBlock::collapsedMarginAfterForChild):
- rendering/RenderBlock.h: (WebCore::RenderBlock::collapsedMarginBefore): (WebCore::RenderBlock::collapsedMarginAfter):
- rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
- rendering/RenderBox.h: (WebCore::RenderBox::layoutOverflowRect): (WebCore::RenderBox::minYLayoutOverflow): (WebCore::RenderBox::maxYLayoutOverflow): (WebCore::RenderBox::minXLayoutOverflow): (WebCore::RenderBox::maxXLayoutOverflow): (WebCore::RenderBox::maxLayoutOverflow): (WebCore::RenderBox::logicalLeftLayoutOverflow): (WebCore::RenderBox::logicalRightLayoutOverflow): (WebCore::RenderBox::visualOverflowRect): (WebCore::RenderBox::minYVisualOverflow): (WebCore::RenderBox::maxYVisualOverflow): (WebCore::RenderBox::minXVisualOverflow): (WebCore::RenderBox::maxXVisualOverflow): (WebCore::RenderBox::logicalLeftVisualOverflow): (WebCore::RenderBox::logicalRightVisualOverflow): (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::collapsedMarginBefore): (WebCore::RenderBox::collapsedMarginAfter):
- rendering/RenderOverflow.h: (WebCore::RenderOverflow::RenderOverflow): (WebCore::RenderOverflow::minYLayoutOverflow): (WebCore::RenderOverflow::maxYLayoutOverflow): (WebCore::RenderOverflow::minXLayoutOverflow): (WebCore::RenderOverflow::maxXLayoutOverflow): (WebCore::RenderOverflow::minYVisualOverflow): (WebCore::RenderOverflow::maxYVisualOverflow): (WebCore::RenderOverflow::minXVisualOverflow): (WebCore::RenderOverflow::maxXVisualOverflow): (WebCore::RenderOverflow::setMinYLayoutOverflow): (WebCore::RenderOverflow::setMaxYLayoutOverflow): (WebCore::RenderOverflow::setMinXLayoutOverflow): (WebCore::RenderOverflow::setMaxXLayoutOverflow): (WebCore::RenderOverflow::setMinYVisualOverflow): (WebCore::RenderOverflow::setMaxYVisualOverflow): (WebCore::RenderOverflow::setMinXVisualOverflow): (WebCore::RenderOverflow::setMaxXVisualOverflow): (WebCore::RenderOverflow::layoutOverflowRect): (WebCore::RenderOverflow::visualOverflowRect): (WebCore::RenderOverflow::move): (WebCore::RenderOverflow::addLayoutOverflow): (WebCore::RenderOverflow::addVisualOverflow): (WebCore::RenderOverflow::setLayoutOverflow): (WebCore::RenderOverflow::setVisualOverflow): (WebCore::RenderOverflow::resetLayoutOverflow):
- 3:30 PM Changeset in webkit [90287] by
-
- 4 edits in trunk
2011-07-01 Hans Wennborg <hans@chromium.org>
IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817
Reviewed by Tony Chang.
Disable IndexedDB quota teset since quota enforcement is not yet
supported by the LevelDB back-end.
- platform/chromium/test_expectations.txt:
2011-07-01 Hans Wennborg <hans@chromium.org>
IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817
Reviewed by Tony Chang.
Use LevelDB as the default back-end.
Covered by existing layout tests for indexeddb, which will now be
using the LevelDB back-end.
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
- 3:25 PM Changeset in webkit [90286] by
-
- 1 edit1 add in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
(r90261 added a Leopard expectation for the Mac port, but Chromium
Leopard can pass with the default baseline).
- platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
- 3:11 PM Changeset in webkit [90285] by
-
- 4 edits in trunk/Tools
2011-07-01 Eric Seidel <eric@webkit.org>
new-run-webkit-tests results does not understand that mac uses test_expectations files
https://bugs.webkit.org/show_bug.cgi?id=63838
Reviewed by Adam Barth.
We've decided to "enable" test_expectations for the Mac port for now.
It makes the results.html results much more confusing to read, but at least they're
no longer lying to us.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 3:06 PM Changeset in webkit [90284] by
-
- 4 edits2 adds in trunk
2011-07-01 Nate Chapin <Nate Chapin>
Reviewed by Dmitry Titov.
- fast/workers/worker-finish-crash-expected.txt: Added.
- fast/workers/worker-finish-crash.html: Added.
2011-07-01 Nate Chapin <Nate Chapin>
Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
https://bugs.webkit.org/show_bug.cgi?id=63835
Reviewed by Dmitry Titov.
Test: fast/workers/worker-finish-crash.html
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::notifyFinished):
- workers/WorkerScriptLoader.h:
- 3:04 PM Changeset in webkit [90283] by
-
- 2 edits in trunk/Source/WebCore
2011-07-01 Adrienne Walker <enne@google.com>
[chromium] Upload root layer textures first so that it is less likely to be skipped
https://bugs.webkit.org/show_bug.cgi?id=63850
Reviewed by James Robinson.
This is a tiny follow-on patch to bug 63760. If the root layer is not
uploaded first, then it may not have enough space to fit into texture
memory and might be skipped, leaving a blue background.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
- 3:02 PM Changeset in webkit [90282] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-07-01 Oliver Hunt <oliver@apple.com>
IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=63732
Reviewed by Gavin Barraclough.
Initialise the memory at the head of the new storage so that
GC is safe if triggered by reportExtraMemoryCost.
- runtime/JSArray.cpp: (JSC::JSArray::increaseVectorPrefixLength):
- 3:02 PM Changeset in webkit [90281] by
-
- 3 edits4 adds in trunk
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777
- fast/history/location-replace-hash-expected.txt: Added.
- fast/history/location-replace-hash.html: Added.
- fast/history/resources/location-replace-hash-1.html: Added.
- fast/history/resources/location-replace-hash-2.html: Added.
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777
location.replace('#foo') would not update the HistoryItem with the
new URL, thus navigating back to the page would use the previous
URL, even though it had been replaced. Make
HistoryController::updateForSameDocumentNavigation mirror
HistoryController::replaceState.
Test: fast/history/location-replace-hash.html
- loader/HistoryController.cpp: (WebCore::HistoryController::updateForSameDocumentNavigation):
- 3:01 PM Changeset in webkit [90280] by
-
- 4 edits6 copies in trunk/LayoutTests
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Fix expected results after r90275. I checked in Mac-specific results for these tests.
Move them to platform/mac and revert the changes in platform-independent results.
Also copy results to platform/win because they fallback to Mac by default.
- editing/deleting/delete-br-011-expected.txt:
- editing/selection/anchor-focus2-expected.txt:
- editing/selection/anchor-focus3-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
- platform/mac/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
- platform/mac/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
- platform/win/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
- platform/win/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
- platform/win/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
- 2:47 PM Changeset in webkit [90279] by
-
- 3 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Temporarily disable waiting for ReportCrash to see how this code
affects performance on the bots.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 2:44 PM Changeset in webkit [90278] by
-
- 3 edits in trunk/Tools
2011-07-01 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=63818
Test bots shouldn't attempt to build TestWebKitAPI on Windows.
TestWebKitAPI builds as a part of general webkit build and is a
part of build products archive.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- Scripts/run-api-tests:
- 2:21 PM Changeset in webkit [90277] by
-
- 3 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837
Reviewed by Eric Seidel.
Instead, we should move this check to worker.py.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 2:09 PM Changeset in webkit [90276] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-07-01 Jade Han <jade.han@nokia.com>
[Qt][Symbian] Update .def file for Symbian to build Tools
https://bugs.webkit.org/show_bug.cgi?id=61200
Reviewed by Laszlo Gombos.
Add newly introduced symbols to fix building the Tools directory for Symbian.
- symbian/eabi/QtWebKitu.def:
- 2:07 PM Changeset in webkit [90275] by
-
- 43 edits2 adds in trunk
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473
Added a test to ensure WebKit preserves non-directional selection after undo on Mac.
The directionality of selection is still lost after undoing DeleteSelectionCommand or TypingCommand
and this will be fixed in follow up patches.
- editing/deleting/delete-br-011-expected.txt:
- editing/selection/after-line-break-expected.txt:
- editing/selection/anchor-focus2-expected.txt:
- editing/selection/anchor-focus3-expected.txt:
- editing/selection/directionality-after-undo-replace-expected.txt: Added.
- editing/selection/directionality-after-undo-replace.html: Added.
- platform/mac/editing/deleting/delete-br-002-expected.txt:
- platform/mac/editing/deleting/delete-br-004-expected.txt:
- platform/mac/editing/deleting/delete-br-005-expected.txt:
- platform/mac/editing/deleting/delete-br-006-expected.txt:
- platform/mac/editing/deleting/delete-br-009-expected.txt:
- platform/mac/editing/deleting/delete-br-010-expected.txt:
- platform/mac/editing/deleting/smart-delete-002-expected.txt:
- platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
- platform/mac/editing/inserting/insert-at-end-01-expected.txt:
- platform/mac/editing/inserting/insert-at-end-02-expected.txt:
- platform/mac/editing/inserting/insert-div-010-expected.txt:
- platform/mac/editing/inserting/insert-div-013-expected.txt:
- platform/mac/editing/inserting/insert-div-015-expected.txt:
- platform/mac/editing/inserting/insert-div-019-expected.txt:
- platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
- platform/mac/editing/pasteboard/3976872-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/paste-text-014-expected.txt:
- platform/mac/editing/selection/4932260-1-expected.txt:
- platform/mac/editing/selection/expanding-selections-expected.txt:
- platform/mac/editing/selection/expanding-selections2-expected.txt:
- platform/mac/editing/selection/fake-drag-expected.txt:
- platform/mac/editing/selection/move-by-word-001-expected.txt:
- platform/mac/editing/selection/triple-click-in-pre-expected.txt:
- platform/mac/editing/style/create-block-for-style-008-expected.txt:
- platform/mac/editing/undo/4063751-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-expected.txt:
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473
Don't pass MakeNonDirectionalSelection to setSelection since no other port does this.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectRange):
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473
Move m_isDirectional from FrameSelection to VisibleSelection.
Also fixed a bug that WebKit does not preserve non-directional selection after undo.
Test: editing/selection/directionality-after-undo-replace.html
- WebCore.exp.in: Updated the signature of setSelection.
- editing/FrameSelection.cpp: (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional. (WebCore::shouldAlwaysUseDirectionalSelection): Added. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy. Calls setIsDirectional(true) when the platform doesn't support non-directional selection. Passes align and granularity to setSelection of the base end point as expected. No longer updates granularity when updating the selection of a different frame. (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional(). (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional because the directionality is passed from m_selection automatically. Also calls shouldAlwaysUseDirectionalSelection.
- editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true. This should be changed to false to fix the bug 60529.
- editing/VisibleSelection.h: (WebCore::VisibleSelection::isDirectional): Added. (WebCore::VisibleSelection::setIsDirectional): Added.
- page/EventHandler.cpp: (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of calling setSelection with MakeNonDirectionalSelection. (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional because it already calls setNonDirectionalSelectionIfNeeded.
- 1:52 PM Changeset in webkit [90274] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Add more Chromium flaky expectations.
- platform/chromium/test_expectations.txt:
- 1:45 PM Changeset in webkit [90273] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-07-01 Oliver Hunt <oliver@apple.com>
GC sweep can occur before an object is completely initialised
https://bugs.webkit.org/show_bug.cgi?id=63836
Reviewed by Gavin Barraclough.
In rare cases it's possible for a GC sweep to occur while a
live, but not completely initialised object is on the stack.
In such a case we may incorrectly choose to mark it, even
though it has no children that need marking.
We resolve this by always zeroing out the structure of any
value returned from JSCell::operator new(), and making the
markstack tolerant of a null structure.
- runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell): (JSC::JSCell::JSCell::operator new):
- runtime/Structure.h: (JSC::MarkStack::internalAppend):
- 1:42 PM Changeset in webkit [90272] by
-
- 2 edits in tags/Safari-534.50.2/Source/WebKit/mac
Merge 90223.
- 1:29 PM Changeset in webkit [90271] by
-
- 5 edits in trunk/Source/WebCore
2011-07-01 Tony Chang <tony@chromium.org>
cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=63827
Reviewed by Ojan Vafai.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::boxAlign): (WebCore::InheritedFlags::boxFlex): (WebCore::InheritedFlags::boxFlexGroup): (WebCore::InheritedFlags::boxLines): (WebCore::InheritedFlags::boxOrdinalGroup): (WebCore::InheritedFlags::boxOrient): (WebCore::InheritedFlags::boxPack): (WebCore::InheritedFlags::marqueeIncrement): (WebCore::InheritedFlags::marqueeSpeed): (WebCore::InheritedFlags::marqueeLoopCount): (WebCore::InheritedFlags::marqueeBehavior): (WebCore::InheritedFlags::marqueeDirection): (WebCore::InheritedFlags::setBoxAlign): (WebCore::InheritedFlags::setBoxFlex): (WebCore::InheritedFlags::setBoxFlexGroup): (WebCore::InheritedFlags::setBoxLines): (WebCore::InheritedFlags::setBoxOrdinalGroup): (WebCore::InheritedFlags::setBoxOrient): (WebCore::InheritedFlags::setBoxPack): (WebCore::InheritedFlags::setMarqueeIncrement): (WebCore::InheritedFlags::setMarqueeSpeed): (WebCore::InheritedFlags::setMarqueeDirection): (WebCore::InheritedFlags::setMarqueeBehavior): (WebCore::InheritedFlags::setMarqueeLoopCount):
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee
- 1:27 PM Changeset in webkit [90270] by
-
- 3 edits in trunk/Source/WebCore
2011-07-01 Mike Reed <reed@google.com>
Stop using deprecated SkDeviceFactory API
https://bugs.webkit.org/show_bug.cgi?id=63488
Reviewed by James Robinson.
No new tests. Check-point for removing Factory API from Skia
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
- 1:08 PM Changeset in webkit [90269] by
-
- 12 edits6 moves1 add in trunk/Source/WebCore
2011-07-01 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Adam Barth.
Move XMLDocumentParser to new folder xml/parser/
https://bugs.webkit.org/show_bug.cgi?id=63666
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::insert): (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::detach): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::XMLDocumentParser::finishWasCalled): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing): (WebCore::XMLDocumentParser::parseDocumentFragment):
- xml/parser/XMLDocumentParser.h: (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::create): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
- xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::create): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::switchToUTF16): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getParser): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
- xml/parser/XMLDocumentParserQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
- xml/parser/XMLDocumentParserScope.cpp: (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
- 1:04 PM Changeset in webkit [90268] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-07-01 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG non-speculative JIT always performs slow C calls for div and mod.
https://bugs.webkit.org/show_bug.cgi?id=63684
- dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
- 12:54 PM Changeset in webkit [90267] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Add more failing test expectations for Chromium media tests on Windows 7
and Vista.
- platform/chromium/test_expectations.txt:
- 12:49 PM Changeset in webkit [90266] by
-
- 2 edits in trunk
2011-07-01 Tony Chang <tony@chromium.org>
Add chromium sql directory to git ignore.
- .gitignore:
- 12:47 PM Changeset in webkit [90265] by
-
- 45 edits in trunk
2011-07-01 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340
Updated expected test results.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/kde/parse-expected.txt:
- fast/js/kde/string-1-n-expected.txt:
- fast/js/kde/string-2-n-expected.txt:
- fast/js/numeric-escapes-in-string-literals-expected.txt:
- fast/js/removing-Cf-characters-expected.txt:
- fast/regex/non-pattern-characters-expected.txt:
- http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
- loader/reload-subresource-when-type-changes-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.1_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T1-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T1-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T2-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T1-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T2-expected.txt:
2011-07-01 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340
Added error messages for the Lexer. These messages will be displayed
instead of the lexer error messages from the parser that are currently
shown.
- parser/Lexer.cpp: (JSC::Lexer::getInvalidCharMessage): (JSC::Lexer::setCode): (JSC::Lexer::parseString): (JSC::Lexer::lex): (JSC::Lexer::clear):
- parser/Lexer.h: (JSC::Lexer::getErrorMessage): (JSC::Lexer::setOffset):
- parser/Parser.cpp: (JSC::Parser::parse):
- 12:39 PM Changeset in webkit [90264] by
-
- 2 edits in trunk/Tools
Stop setting unsafe headers on POSTs via XHR from TestFailures page
Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
Inspector's console about unsafe headers
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
- 12:36 PM Changeset in webkit [90263] by
-
- 2 edits in trunk/Tools
2011-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786
We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.
If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).
- Scripts/run-webkit-tests:
- 12:33 PM Changeset in webkit [90262] by
-
- 2 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Add a compat shim for --leaks. Support for --leaks will be added in
https://bugs.webkit.org/show_bug.cgi?id=63832.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:25 PM Changeset in webkit [90261] by
-
- 1 edit1 add in trunk/LayoutTests
Add Leopard expected failure result for media/media-blocked-by-beforeload.html
The failure is tracked by <http://webkit.org/b/63829>.
- platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
- 12:24 PM Changeset in webkit [90260] by
-
- 12 edits in trunk/Source/WebCore
2011-07-01 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Reserve all tile textures at layer update time to guarantee
that they will be available at draw time.
https://bugs.webkit.org/show_bug.cgi?id=63760
In addition, this patch unreserves textures used by RenderSurface's
right after the RenderSurface has been used to free up memory for
subsequent RenderSurfaces.
This patch also "fixes" the pages that display a blue background when
running out of texture memory as the root layer tiles get reserved first
and are guaranteed to get textures.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::setIsMask):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::unreserve):
- platform/graphics/chromium/LayerTexture.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::drawTiles):
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::releaseContentsTexture):
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectTexture):
- platform/graphics/chromium/TextureManager.h:
- 12:23 PM Changeset in webkit [90259] by
-
- 14 edits3 adds in trunk/Source
2011-07-01 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- icu/unicode/uscript.h: Added for UScriptCode enum.
- wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
- wtf/unicode/icu/UnicodeIcu.h:
- wtf/unicode/brew/UnicodeBrew.h:
- wtf/unicode/glib/UnicodeGLib.h:
- wtf/unicode/qt4/UnicodeQt4.h:
- wtf/unicode/wince/UnicodeWinCE.h:
2011-07-01 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same
file was added to JavaScriptCore/icu/unicode.
- icu/unicode/uscript.h: Added.
2011-07-01 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Allow generic font family settings per script code.
https://bugs.webkit.org/show_bug.cgi?id=20797
Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.
uscript.h has been updated to that of ICU 3.6 (the version of ICU on
Mac OS 10.5)
There should be no change in layout and no new layout test
is added.
- WebCore.exp.in:
- icu/unicode/uscript.h: updated to ICU 4.6
- page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily):
- page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
- 12:14 PM Changeset in webkit [90258] by
-
- 2 edits1 add in trunk/LayoutTests
Reviewed by Andreas Kling.
[Qt][WK2] netscape-dom-access.html needs new result
https://bugs.webkit.org/show_bug.cgi?id=63454
- platform/qt-wk2/Skipped:
- platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
- 12:10 PM Changeset in webkit [90257] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90254.
http://trac.webkit.org/changeset/90254
https://bugs.webkit.org/show_bug.cgi?id=63825
"committed with a totally broken changelog" (Requested by
kbalazs on #webkit).
- platform/qt-wk2/Skipped:
- platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed.
- 11:55 AM Changeset in webkit [90256] by
-
- 5 edits in tags/Safari-534.50.2/Source
Versioning.
- 11:54 AM Changeset in webkit [90255] by
-
- 1 copy in tags/Safari-534.50.2
New tag.
- 11:53 AM Changeset in webkit [90254] by
-
- 2 edits1 add in trunk/LayoutTests
2011-07-01 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- 11:50 AM Changeset in webkit [90253] by
-
- 11 edits2 moves in trunk/Source/WebCore
2011-07-01 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData
https://bugs.webkit.org/show_bug.cgi?id=63773
We will have a similar struct to hold CSS3 flexible box data, so
this makes way for the new class.
I will rename the member variable in RenderStyle.h in a follow up
change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/style/RenderStyle.h:
- rendering/style/StyleAllInOne.cpp:
- rendering/style/StyleDeprecatedFlexibleBoxData.cpp: (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): (WebCore::StyleDeprecatedFlexibleBoxData::operator==):
- rendering/style/StyleDeprecatedFlexibleBoxData.h: (WebCore::StyleDeprecatedFlexibleBoxData::create): (WebCore::StyleDeprecatedFlexibleBoxData::copy): (WebCore::StyleDeprecatedFlexibleBoxData::operator!=):
- rendering/style/StyleRareNonInheritedData.h:
- 11:40 AM Changeset in webkit [90252] by
-
- 6 edits in trunk
2011-07-01 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
2011-07-01 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
constants. Douglas Stockwell pointed out that these were reverse
of what the spec says.
- storage/IDBTransaction.h:
- storage/IDBTransaction.idl:
- 11:39 AM Changeset in webkit [90251] by
-
- 2 edits in trunk
2011-07-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Daniel Bates.
[CMake] Add cpu detection for MIPS
https://bugs.webkit.org/show_bug.cgi?id=63693
- Source/CMakeLists.txt:
- 11:33 AM Changeset in webkit [90250] by
-
- 22 edits in trunk/Source/WebCore
2011-07-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch positionForPoint to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63774
Switching positionForPoint functions to new layout unit abstraction.
No new tests, no functionality changes.
- rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
- rendering/RenderReplaced.h:
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
- rendering/RenderText.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
- rendering/RenderTextControlSingleLine.h:
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint):
- rendering/svg/RenderSVGText.h:
- 11:30 AM Changeset in webkit [90249] by
-
- 4 edits in trunk/Source
2011-07-01 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Darin Fisher.
Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783
- features.gypi:
2011-07-01 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Darin Fisher.
Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783
- WebCore.gyp/WebCore.gyp:
- 11:19 AM Changeset in webkit [90248] by
-
- 2 edits in trunk/Source/WebCore
2011-07-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Daniel Bates.
[CMake] Don't compile unused bindings
https://bugs.webkit.org/show_bug.cgi?id=63741
- UseJSC.cmake: Added IF (ENABLE_XXX) around files.
- 11:19 AM Changeset in webkit [90247] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.
Reviewed by Sam Weinig.
Source/JavaScriptCore:
The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!
- runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
LayoutTests:
Add tests with multiple forward slashes.
- fast/regex/script-tests/toString.js:
- fast/regex/toString-expected.txt:
- 11:14 AM Changeset in webkit [90246] by
-
- 5 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
ReportCrash destabilizes new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63795
ReportCrash chews up too many system resources that it destablizes
tests run concurrently. This patch causes us to spin down all the
worker processes when ReportCrash is running.
Also, this patch causes the master process to tell the user we're
waiting for the crash reporter rather than having that be the worker's
job. This stops the user from getting spammed with too many "waiting
for crash reporter" messages and also cleans up some minor UI issues
with the meter.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/server_process.py:
- 10:57 AM Changeset in webkit [90245] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-07-01 Tony Chang <tony@chromium.org>
Fix the chromium build. sql is a new top level directory.
- DEPS:
- 10:36 AM Changeset in webkit [90244] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
Rolled DEPS.
- DEPS:
- 10:29 AM Changeset in webkit [90243] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Mihai Parparita <mihaip@chromium.org>
Add failing test expectations for Chromium media tests on Windows 7 and
Vista.
- platform/chromium/test_expectations.txt:
- 9:56 AM Changeset in webkit [90242] by
-
- 2 edits in trunk/LayoutTests
2011-07-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Clean up skipped list
https://bugs.webkit.org/show_bug.cgi?id=61644
- platform/qt-wk2/Skipped: Remove everything that we skip via the common wk2 list.
- 9:56 AM Changeset in webkit [90241] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-07-01 Adam Roben <Adam Roben>
Roll out r90194
http://trac.webkit.org/changeset/90194
https://bugs.webkit.org/show_bug.cgi?id=63778
Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing
assertions in WriteBarrierBase<JSC::Structure>::get
- runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell):
- 9:56 AM Changeset in webkit [90240] by
-
- 7 edits4 adds in trunk
2011-07-01 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720
Add configure option to enable/disable DeviceOrientation feature.
- configure.ac:
2011-07-01 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720
Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
- GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
2011-07-01 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720
Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
- GNUmakefile.am:
- WebCoreSupport/DeviceMotionClientGtk.cpp: Added. (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientGtk::setController): (WebCore::DeviceMotionClientGtk::startUpdating): (WebCore::DeviceMotionClientGtk::stopUpdating): (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
- WebCoreSupport/DeviceMotionClientGtk.h: Added.
- WebCoreSupport/DeviceOrientationClientGtk.cpp: Added. (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientGtk::setController): (WebCore::DeviceOrientationClientGtk::startUpdating): (WebCore::DeviceOrientationClientGtk::stopUpdating): (WebCore::DeviceOrientationClientGtk::lastOrientation):
- WebCoreSupport/DeviceOrientationClientGtk.h: Added.
- webkit/webkitwebview.cpp: (webkit_web_view_init):
- 9:54 AM Changeset in webkit [90239] by
-
- 3 edits in trunk/Tools
Teach webkitpy about the new format of our ChangeLog template
r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
template. But webkitpy didn't know this, so the various rollout-related commands were
leaving that line in the ChangeLog.
Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
rollout are broken
Reviewed by Dan Bates.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
description and bug URL" line instead of the "Reviewed by" line as the first line of the
ChangeLog template.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
generates.
- 9:51 AM Changeset in webkit [90238] by
-
- 4 edits in trunk
WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=63753
Reviewed by Darin Adler.
Source/WebKit2:
When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
LayoutTests:
Unskip WebKit2 tests that now pass.
- platform/wk2/Skipped:
- 9:33 AM Changeset in webkit [90237] by
-
- 14 edits in trunk/Source/JavaScriptCore
2011-06-30 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757
Relanding as a Mac only patch.
This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble):
- assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
- assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
- assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr):
- create_hash_table:
- jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble):
- jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator):
- jit/ThunkGenerators.h:
- 9:22 AM Changeset in webkit [90236] by
-
- 2 edits in trunk/LayoutTests
Skip one asserting and one timing-out test on Windows
Failures are tracked by <http://webkit.org/b/63806> and <http://webkit.org/b/63807>.
- platform/win/Skipped: Added
http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and
fast/loader/create-frame-in-DOMContentLoaded.html.
- 9:21 AM Changeset in webkit [90235] by
-
- 2 edits in trunk/LayoutTests
Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html
The failure is tracked by <http://webkit.org/b/63809>.
- platform/win/fast/events/panScroll-click-hyperlink-expected.txt:
- 9:21 AM Changeset in webkit [90234] by
-
- 2 edits in trunk/LayoutTests
Land new expected (failure?) results for an accessibility test on Windows
The failure is tracked by <http://webkit.org/b/63811>.
- platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
- 9:21 AM Changeset in webkit [90233] by
-
- 2 edits in trunk/LayoutTests
Update expected results after r90159
Fixes <http://webkit.org/b/63810> REGRESSION (r90159): fast/events/window-onerror5.html
failing
- fast/events/window-onerror5-expected.txt: Updated for progression.
- 9:18 AM Changeset in webkit [90232] by
-
- 2 edits in trunk/Source/JavaScriptCore
<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp
Fixes the following build error in clang:
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
( )
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~
1 error generated.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary expression evaluate first.
- 9:17 AM Changeset in webkit [90231] by
-
- 4 edits in trunk
2011-07-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
- platform/qt-wk2/Skipped:
2011-07-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
- 8:55 AM Changeset in webkit [90230] by
-
- 2 edits in trunk/Tools
Make TestFailures stop loading old builds once we've explained all current failures
We used to do this, but some refactoring in r90165 broke this logic.
Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.
- 8:21 AM Changeset in webkit [90229] by
-
- 3 edits in trunk/Tools
commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804
Reviewed by Darin Adler.
commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
commit message in order to make git-based tools, which expect the first line of the commit
message to be a summary of the change, to work better. But this reordering of the ChangeLog
entry was unpredictable and unexpected.
I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
try to move them.
- Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
line and try to move it down below the bug title and URL. The order of the text in the
ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
by" line in cases where the committer and author are not the same person.
- Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
- 7:51 AM Changeset in webkit [90228] by
-
- 2 edits in trunk/Tools
2011-07-01 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Adam Roben.
[CSSRegions] Add build slave
https://bugs.webkit.org/show_bug.cgi?id=62372
- BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of Mac.
- 7:29 AM Changeset in webkit [90227] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-07-01 Jade Han <jade.han@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=61200
Add newly introduced symbols to fix the Symbian build.
- symbian/eabi/QtWebKitu.def:
- 7:18 AM Changeset in webkit [90226] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
2011-07-01 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Adam Roben.
accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=63191
- accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
- accessibility/aria-labelledby-overrides-aria-label.html:
- platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
- platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
- 6:58 AM Changeset in webkit [90225] by
-
- 3 edits2 adds in trunk
2011-07-01 Kentaro Hara <haraken@google.com>
Reviewed by Kent Tamura.
Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709
Added a test that checks whether the content in 'search' input forms with 'disabled' attribute
or 'readonly' attribute is cleared or not, when an [X] button is clicked.
- fast/forms/search-disabled-readonly-expected.txt: Added.
- fast/forms/search-disabled-readonly.html: Added.
2011-07-01 Kentaro Hara <haraken@google.com>
Reviewed by Kent Tamura.
Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709
Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
'readonly' attribute is set to the input form.
Test: fast/forms/search-disabled-readonly.html
- html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- 6:25 AM Changeset in webkit [90224] by
-
- 9 edits in trunk/Source/WebKit2
Unreviewed due to fixing of a broken world.
REGRESSION (r90163): WebKit2 bot is failing 100% of the tests.
r90163 bumped the version of the WKBundlePageLoaderClient passed in by WebKitTestRunner from 0 to 1.
This made it run in to the ad-hoc client version checking implemented directly in WKBundlePageSetPageLoaderClient,
resulting in no client being set. After r90162 the ad-hoc checking is not necessary as the APIClient
template takes care of the relevant version checks.
- Shared/APIClient.h:
(WebKit::APIClient::initialize): Fix a bug I noticed along the way: don't attempt to copy anything if
the client version is newer than what we support. This matches the behavior of the ad-hoc version checking.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetInjectedBundleClient): Drop the ad-hoc version checking.
(WKContextSetHistoryClient): Ditto.
(WKContextSetDownloadClient): Ditto.
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetClient): Ditto.
- UIProcess/API/C/WKGeolocationManager.cpp:
(WKGeolocationManagerSetProvider): Ditto.
- UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient): Ditto.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient): Ditto.
(WKPageSetPageFindClient): Ditto.
(WKPageSetPageFormClient): Ditto.
(WKPageSetPageLoaderClient): Ditto.
(WKPageSetPagePolicyClient): Ditto.
(WKPageSetPageResourceLoadClient): Ditto.
(WKPageSetPageUIClient): Ditto.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetClient): Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient): Ditto.
(WKBundlePageSetEditorClient): Ditto.
(WKBundlePageSetFormClient): Ditto.
(WKBundlePageSetPageLoaderClient): Ditto.
(WKBundlePageSetResourceLoadClient): Ditto.
(WKBundlePageSetPolicyClient): Ditto.
(WKBundlePageSetUIClient): Ditto.
(WKBundlePageSetFullScreenClient): Ditto.
- 5:51 AM Changeset in webkit [90223] by
-
- 2 edits in trunk/Source/WebKit/mac
2011-07-01 Andy Estes <aestes@apple.com>
Reviewed by Mark Rowe.
Simplify MailQuirksUserScript.js
https://bugs.webkit.org/show_bug.cgi?id=63800
MailQuirksUserScript.js is injected into WebViews in Mail.app on
Leopard to resolve an incompatibility between it and the HTML5 parser.
It did so by taking all nodes in the document between <html> and <body>
and moving them to be children of <body>. This maintains Mail.app's
assumption that document.firstChild.firstChild == document.body.
While this script fixed a specific issue with the Signature panel in
Mail.app, it caused regressions in other WebViews. Since the issue with
the Signature panel is with the empty <head> node implicitly created by
the parser, we can simplify this script by removing this implicit
<head> in the case it has no attributes and no children. This fixes the
Signature panel without affecting other WebViews that have non-trivial
<head> nodes.
- Misc/MailQuirksUserScript.js: If <head> exists but has no attributes and no children, remove it.
- 4:29 AM Changeset in webkit [90222] by
-
- 2 edits in trunk/Source/WebCore
2011-06-30 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
https://bugs.webkit.org/show_bug.cgi?id=63703
- inspector/front-end/HeapSnapshotWorker.js: (.Function.prototype.bind.return.bound): (.Function.prototype.bind):
- 3:38 AM Changeset in webkit [90221] by
-
- 2 edits1 copy in trunk/PerformanceTests/SunSpider
2011-06-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Create sunspider-1.0 directory in preparation for fixing a bunch of bugs
https://bugs.webkit.org/show_bug.cgi?id=63782
- make-hosted: Learn about the new directory.
- tests/sunspider-1.0: Copied from PerformanceTests/SunSpider/tests/sunspider-0.9.1.
- 2:03 AM Changeset in webkit [90220] by
-
- 1 edit5 adds in trunk/LayoutTests
2011-07-01 Kent Tamura <tkent@chromium.org>
[Chromium] Update text expectation for Vista.
- platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
- 1:51 AM Changeset in webkit [90219] by
-
- 7 edits6 adds in trunk
2011-07-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705
Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
necessary.
SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.
Tests: svg/animations/svglength-animation-unitType.html
svg/animations/svglengthlist-animation-5.html
- svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
- svg/SVGAnimatedLengthList.cpp: Add support for additive animations. (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
- svg/SVGLength.h:
2011-07-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705
Tests additive animations for SVGLengthLists as well as unit animations on SVGLength.
- svg/animations/script-tests/svglength-animation-unitType.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglengthlist-animation-5.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svglength-animation-unitType-expected.txt: Added.
- svg/animations/svglength-animation-unitType.html: Added.
- svg/animations/svglengthlist-animation-5-expected.txt: Added.
- svg/animations/svglengthlist-animation-5.html: Added.
- 1:37 AM Changeset in webkit [90218] by
-
- 14 edits4 adds in trunk
2011-07-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789
Test animation of SVGAnimatedInteger. Added the test to the wk2 skip list.
- platform/mac-wk2/Skipped:
- svg/animations/script-tests/svginteger-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/svginteger-animation-1-expected.txt: Added.
- svg/animations/svginteger-animation-1.html: Added.
2011-07-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.
SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.
Test: svg/animations/svginteger-animation-1.html
- CMakeLists.txt: Added file to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimateElement.cpp: Make use of AnimatedInteger. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
- svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger. (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator): (WebCore::SVGAnimatedIntegerAnimator::constructFromString): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
- svg/SVGAnimatedInteger.h: (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
- svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createInteger): (WebCore::SVGAnimatedType::integer): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
- svg/SVGAnimatedType.h:
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
- 12:52 AM Changeset in webkit [90217] by
-
- 2 edits in trunk/Tools
2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90213.
http://trac.webkit.org/changeset/90213
https://bugs.webkit.org/show_bug.cgi?id=63792
The SL bot has an errant HTTP server holding port 8080
(Requested by abarth on #webkit).
- Scripts/run-webkit-tests:
- 12:50 AM Changeset in webkit [90216] by
-
- 2 edits in trunk/Tools
2011-07-01 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r90163.
- MiniBrowser/gtk/WebBundle/WebBundleMain.c: (didCreatePage):
- 12:47 AM Changeset in webkit [90215] by
-
- 14 edits in trunk/Source/JavaScriptCore
2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90177 and r90179.
http://trac.webkit.org/changeset/90177
http://trac.webkit.org/changeset/90179
https://bugs.webkit.org/show_bug.cgi?id=63790
It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::sqrtDouble):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
- assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
- assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::sqrtDouble):
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86Common.h:
- assembler/MacroAssemblerX86_64.h:
- assembler/X86Assembler.h:
- create_hash_table:
- jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble):
- jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- 12:39 AM Changeset in webkit [90214] by
-
- 2 edits in trunk/Tools
2011-07-01 Adam Barth <abarth@webkit.org>
Exit faster when we get a keyboard interrupt. Previously, we'd open
Safari if you C NRWT after it found a failure.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- 12:31 AM Changeset in webkit [90213] by
-
- 2 edits in trunk/Tools
2011-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786
We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.
If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).
- Scripts/run-webkit-tests:
- 12:28 AM Changeset in webkit [90212] by
-
- 1 edit1 add in trunk/LayoutTests
2011-07-01 Kent Tamura <tkent@chromium.org>
[Chromium] More test expectation update for r90089
Need to update a Windows XP expectation because the corresponding
chromium-win expectation was updated.
- platform/chromium-win-xp/fast/forms/search-styled-expected.png: Added.
- 12:13 AM Changeset in webkit [90211] by
-
- 3 edits in trunk/Tools
2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90192.
http://trac.webkit.org/changeset/90192
https://bugs.webkit.org/show_bug.cgi?id=63788
Appears to have caused NRWT on Chromium WebKit Vista to hang
(Requested by abarth on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
- 12:01 AM Changeset in webkit [90210] by
-
- 6 edits in trunk/LayoutTests
2011-06-30 Kent Tamura <tkent@chromium.org>
[Mac][Chromium] Update test expectations for r90089
The placeholder position changes are expected because we respect
paddings for text fields.
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/placeholder-position-expected.png:
