⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 4, 2011:

9:21 PM Changeset in webkit [90384] by dominicc@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-04 Dominic Cooney <​dominicc@chromium.org>

Simplify <progress> element's isDeterminate logic.
​https://bugs.webkit.org/show_bug.cgi?id=63889

Reviewed by Hajime Morita.

Covered by existing tests
fast/dom/HTMLProgressElement/indeterminate-progress-*.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
  • html/HTMLProgressElement.h:
7:59 PM Changeset in webkit [90383] by barraclough@apple.com
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
7:19 PM Changeset in webkit [90382] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-07-04 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
​https://bugs.webkit.org/show_bug.cgi?id=63884

As MediaControlRootElement decides whether it will display timeline
according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
RenderThemeEfl has to implement this function.

Existing tests cover the visibility of the controls.

  • platform/efl/RenderThemeEfl.h: (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
7:18 PM Changeset in webkit [90381] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Mihai Parparita <​mihaip@chromium.org>

As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
pass in Chromium, just like other platform-specific tests.

  • platform/chromium/test_expectations.txt:
6:54 PM Changeset in webkit [90380] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Moved handling of frame size changes into its own method.

Reviewed by Oliver Hunt.

  • WebView/WebFrameView.mm:

(-[WebFrameView _frameSizeChanged]): Added. Moved code here...
(-[WebFrameView setFrameSize:]): ...from here.

  • WebView/WebFrameViewInternal.h:
6:27 PM Changeset in webkit [90379] by tkent@chromium.org
  • 5 edits
    3 adds in trunk

2011-07-04 Kent Tamura <​tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
​https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

  • fast/forms/textfield-overflow-by-value-update.html: Added.
  • platform/chromium/test_expectations.txt: Add textfield-overflow-by-value-update.html.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.

2011-07-04 Kent Tamura <​tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
​https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

Since r87067, the RenderStyle for the inner text element is reset
by the value update, but the renderer for the inner text element
keeps to have metrics calculated by the previous style. So
RenderTextControlSingleLine::layout() didn't set a desired height
to the renderer for the inner text element.

This patch changes the style creation code so that it has the
desired height initially.

Test: fast/forms/textfield-overflow-by-value-update.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Initialize m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::layout): Update m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::styleDidChange): Reset m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Sets the height if m_desiredInnerTextHeight has a concrete value.
  • rendering/RenderTextControlSingleLine.h: Declare m_desiredInnerTextHeight.
6:11 PM Changeset in webkit [90378] by morrita@google.com
  • 5 edits
    2 adds in trunk

2011-07-04 MORITA Hajime <​morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
​http://webkit.org/b/63798

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/shadow-root-node-list-expected.txt: Added.
  • fast/dom/shadow/shadow-root-node-list.html: Added.

2011-07-04 MORITA Hajime <​morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
​http://webkit.org/b/63798

The TreeScope destructor did clear the reference to TreeScope,
then the Node destructor accessing treeScope(), which results
an inconsistent state during the NodeList cache cleanup.

This change clears NodeList cache during the TreeScope destructor.
The Node destructor no longer does problematic NodeList cache
manipulation.

Test: fast/dom/shadow/shadow-root-node-list.html

Reviewed by Dimitri Glazkov.

  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::clearRareData):
  • dom/Node.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::~TreeScope):
2:30 PM QtWebKitReleases edited by Ademar Reis
(diff)
2:22 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
1:29 PM Changeset in webkit [90377] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations change.

Mark four tests as passing on the GPU step.

  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [90376] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
​https://bugs.webkit.org/show_bug.cgi?id=63873

Reviewed by Alexey Proskuryakov.

  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1:26 PM Changeset in webkit [90375] by commit-queue@webkit.org
  • 33 edits
    9 deletes in trunk

2011-07-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
​http://trac.webkit.org/changeset/90373
​https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • Source/autotools/symbols.filter:

2011-07-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
​http://trac.webkit.org/changeset/90373
​https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-embed.html: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
  • http/tests/inspector/network/network-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-embed.html: Removed.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Removed.
  • http/tests/inspector/network/resources/plugin-data.php: Removed.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Removed.
  • platform/chromium/test_expectations.txt:

2011-07-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
​http://trac.webkit.org/changeset/90373
​https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::appendContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::addResourceContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged): (WebCore::NetworkResourcesData::ResourceData::textEncodingName): (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
​http://trac.webkit.org/changeset/90373
​https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
1:17 PM Changeset in webkit [90374] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix Qt build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1:07 PM Changeset in webkit [90373] by vsevik@chromium.org
  • 33 edits
    9 adds in trunk

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • Source/autotools/symbols.filter:

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-embed.html: Added.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Added.
  • http/tests/inspector/network/network-embed-expected.txt: Added.
  • http/tests/inspector/network/network-embed.html: Added.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Added.
  • http/tests/inspector/network/resources/plugin-data.php: Added.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Added.
  • platform/chromium/test_expectations.txt:

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/network/network-content-replacement-embed.html

http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/network-embed.html

  • WebCore.exp.in:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::setContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::ResourceData::createDecoder): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::decoder): (WebCore::NetworkResourcesData::ResourceData::buffer): (WebCore::NetworkResourcesData::ResourceData::setBuffer): (WebCore::NetworkResourcesData::ResourceData::hasData):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentEncoded):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createEmptyView): (WebInspector.ResourcePreviewView.prototype._createPreviewView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveData): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
12:58 PM Changeset in webkit [90372] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2011-07-04 Anders Carlsson <​andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::deleteProperty): Call NP_RemoveProperty on the NPObject.
  • WebProcess/Plugins/Netscape/JSNPObject.h: Add deleteProperty.

2011-07-04 Anders Carlsson <​andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Add a test. I made this Mac-WebKit2 specific for now since no other plug-in implementations support this,
and there doesn't seem to be a way to make a WebKit2 specific test.

  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript-expected.txt: Added.
  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript.html: Added.

2011-07-04 Anders Carlsson <​andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_IdentifierIsString): (PluginTest::NPN_UTF8FromIdentifier): (PluginTest::NPN_IntFromIdentifier): (PluginTest::NPN_RetainObject): (PluginTest::NPN_ReleaseObject):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: (PluginTest::Object::removeProperty): (PluginTest::Object::identifierIs): (PluginTest::Object::NP_RemoveProperty): (PluginTest::Object::npClass):
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: (NPRuntimeRemoveProperty::TestObject::TestObject): (NPRuntimeRemoveProperty::TestObject::hasProperty): (NPRuntimeRemoveProperty::TestObject::getProperty): (NPRuntimeRemoveProperty::TestObject::removeProperty): (NPRuntimeRemoveProperty::PluginObject::PluginObject): (NPRuntimeRemoveProperty::PluginObject::~PluginObject): (NPRuntimeRemoveProperty::PluginObject::hasMethod): (NPRuntimeRemoveProperty::PluginObject::invoke): (NPRuntimeRemoveProperty::PluginObject::hasProperty): (NPRuntimeRemoveProperty::PluginObject::getProperty): (NPRuntimeRemoveProperty::NPP_GetValue):
12:26 PM Changeset in webkit [90371] by barraclough@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=63881
Need separate bytecodes for handling >, >= comparisons.

Reviewed by Oliver Hunt.

This clears the way to fix Bug#63880. We currently handle greater-than comparisons
as being using the corresponding op_less, etc opcodes. This is incorrect with
respect to evaluation ordering of the implicit conversions performed on operands -
we should be calling ToPrimitive on the LHS and RHS operands to the greater than,
but instead convert RHS then LHS.

This patch adds opcodes for greater-than comparisons mirroring existing ones used
for less-than.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_greater):
(JSC::JIT::emitSlow_op_loop_if_greater):
(JSC::JIT::emit_op_loop_if_greatereq):
(JSC::JIT::emitSlow_op_loop_if_greatereq):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitBinaryDoubleOp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • parser/NodeConstructors.h:

(JSC::GreaterNode::GreaterNode):
(JSC::GreaterEqNode::GreaterEqNode):

  • parser/Nodes.h:
11:25 AM Changeset in webkit [90370] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations change.


Mark two tests as failing on the GPU step.

  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [90369] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Jeff Timanus <​twiz@chromium.org>

Reviewed by Stephen White.

Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
​https://bugs.webkit.org/show_bug.cgi?id=63756

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
11:03 AM Changeset in webkit [90368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] r90148 did not apply to X11 platforms in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=63862

Correct the guard for an X11 specific piece of code. TARGET(X11) not
defined for the GTK+ port.

No new tests. This is covered by an existing test.

  • plugins/npapi.cpp: Correct the X11 guard. (NPN_InvalidateRect):
8:53 AM Changeset in webkit [90367] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: network-preflight-options.html test is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=63904

Unreviewed test fix.

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:
  • platform/qt/Skipped:
8:31 AM Changeset in webkit [90366] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Andras Becsi <​abecsi@webkit.org>

[Qt] http/tests/inspector/network-preflight-options.html fails frequently
​https://bugs.webkit.org/show_bug.cgi?id=63910

Unreviewed.

  • platform/qt/Skipped: Skip http/tests/inspector/network-preflight-options.html.
7:48 AM Changeset in webkit [90365] by pfeldman@chromium.org
  • 26 edits
    1 move
    1 add in trunk

2011-07-04 Pavel Feldman <​pfeldman@google.com>

Web Inspector: implement settings panel.
​https://bugs.webkit.org/show_bug.cgi?id=63907

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction): (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype): ():
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype.hide): (WebInspector.HelpScreen.prototype._onKeyDown):
  • inspector/front-end/NetworkItemView.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.saveSidebarWidth):
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Setting): (WebInspector.Setting.prototype.addChangeListener): (WebInspector.Setting.prototype.removeChangeListener): (WebInspector.Setting.prototype.get var): (WebInspector.Setting.prototype): (WebInspector.Setting.prototype.set if):
  • inspector/front-end/SettingsScreen.js: Added. (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._appendSection): (WebInspector.SettingsScreen.prototype._columnElement): (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener): (WebInspector.SettingsScreen.prototype._createRadioSetting):
  • inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js. (WebInspector.ShortcutsScreen):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WatchExpressionsSidebarPane.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-content): (.help-close-button): (body.attached .help-close-button): (body.attached .help-content): (.help-table): (body.platform-mac .help-key): (.help-combine-keys): (.help-content p): (.help-content fieldset): (.help-content fieldset p): (.help-content p.help-section): (.help-section-title): (.help-content input[type=checkbox]):
  • inspector/front-end/inspector.css: (button.settings-status-bar-item): (.settings-status-bar-item .glyph):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._toggleAttach): (WebInspector._toggleSettings): (WebInspector._registerShortcuts): (WebInspector.documentKeyDown):
7:09 AM Changeset in webkit [90364] by vsevik@chromium.org
  • 5 edits
    3 adds in trunk

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
​https://bugs.webkit.org/show_bug.cgi?id=63701

Added a test that checks mime type when resources are loaded from cache by InspectorPageAgent.

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/resource-tree/resource-tree-mimetype-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html: Added.
  • http/tests/inspector/resource-tree/resources/empty.png: Added.

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
​https://bugs.webkit.org/show_bug.cgi?id=63701

Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.

Reviewed by Yury Semikhatsky.

Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype._createResource):
6:29 AM Changeset in webkit [90363] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Marcus Bulach <​bulach@chromium.org>

[chromium] Updates expectations for failures on svg/animations/svgtransform-animation-1.html
​https://bugs.webkit.org/show_bug.cgi?id=63902

Unreviewed expectations fix.

  • platform/chromium/test_expectations.txt:
5:50 AM Changeset in webkit [90362] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Yury Semikhatsky <​yurys@chromium.org>

Web Inspector: repeated message counter should be aligned with other message icons
​https://bugs.webkit.org/show_bug.cgi?id=63901

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css: (.console-message .bubble):
5:18 AM Changeset in webkit [90361] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-07-04 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add LayoutTestControllerEfl.
​https://bugs.webkit.org/show_bug.cgi?id=61974

Only the core features are implemented. Most functions are actually
stubs and will be implemented as soon as its features are needed.
Build system changes will be made as soon as DRT is completely
upstreamed.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added. (LayoutTestController::~LayoutTestController): (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::copyDecodedHostName): (LayoutTestController::copyEncodedHostName): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::display): (LayoutTestController::counterValueForElementById): (LayoutTestController::keepWebHistory): (LayoutTestController::computedStyleIncludingVisitedInfo): (LayoutTestController::nodesFromRect): (LayoutTestController::layerTreeAsText): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages): (LayoutTestController::pageProperty): (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageSizeAndMarginsInPixels): (LayoutTestController::webHistoryItemCount): (LayoutTestController::workerThreadCount): (LayoutTestController::notifyDone): (LayoutTestController::pathToLocalResource): (LayoutTestController::queueLoad): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::addOriginAccessWhitelistEntry): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setValueForUser): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setWindowIsKey): (LayoutTestController::setSmartInsertDeleteEnabled): (waitToDumpWatchdogFired): (LayoutTestController::setWaitToDump): (LayoutTestController::windowCount): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setSpatialNavigationEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setAutofilled): (LayoutTestController::disableImageLoading): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setGeolocationPermission): (LayoutTestController::numberOfPendingGeolocationPermissionRequests): (LayoutTestController::addMockSpeechInputResult): (LayoutTestController::setIconDatabaseEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::setPluginsEnabled): (LayoutTestController::elementDoesAutoCompleteForElementWithId): (LayoutTestController::execCommand): (LayoutTestController::findString): (LayoutTestController::isCommandEnabled): (LayoutTestController::setCacheModel): (LayoutTestController::setPersistentUserStyleSheetLocation): (LayoutTestController::clearPersistentUserStyleSheet): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota): (LayoutTestController::clearApplicationCacheForOrigin): (LayoutTestController::localStorageDiskUsageForOrigin): (LayoutTestController::originsWithApplicationCache): (LayoutTestController::applicationCacheDiskUsageForOrigin): (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::syncLocalStorage): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): (LayoutTestController::setAppCacheMaximumSize): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations): (LayoutTestController::overridePreference): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::setAsynchronousSpellCheckingEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::evaluateScriptInIsolatedWorld): (LayoutTestController::removeAllVisitedLinks): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::apiTestNewWindowDataLoadBaseURL): (LayoutTestController::apiTestGoToCurrentBackForwardItem): (LayoutTestController::setWebViewEditable): (LayoutTestController::markerTextForListItem): (LayoutTestController::authenticateSession): (LayoutTestController::setEditingBehavior): (LayoutTestController::abortModal): (LayoutTestController::hasSpellingMarker): (LayoutTestController::hasGrammarMarker): (LayoutTestController::dumpConfigurationForViewport): (LayoutTestController::setSerializeHTTPLoads): (LayoutTestController::setMinimumTimerInterval): (LayoutTestController::setTextDirection): (LayoutTestController::allowRoundingHacks):
4:55 AM Changeset in webkit [90360] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Adding new CSS rules should be more discoverable in the UI
​https://bugs.webkit.org/show_bug.cgi?id=63803

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):
3:56 AM Changeset in webkit [90359] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk>

[Qt] Fixing build with --media-stream flag enabled
​https://bugs.webkit.org/show_bug.cgi?id=63831

Reviewed by Benjamin Poulain.

  • features.pri: Adding support to ENABLE_MEDIA_STREAM flag.
3:07 AM Changeset in webkit [90358] by vsevik@chromium.org
  • 2 edits in trunk/Tools

2011-06-24 Vsevolod Vlasov <​vsevik@chromium.org>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
2:51 AM Changeset in webkit [90357] by bulach@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-07-04 Marcus Bulach <​bulach@chromium.org>

[chromium] Rebaseline following r90338
​https://bugs.webkit.org/show_bug.cgi?id=63896

Unreviewed rebaseline.

  • platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
2:36 AM Changeset in webkit [90356] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Update network resource url from response data.
​https://bugs.webkit.org/show_bug.cgi?id=63736

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
2:20 AM Changeset in webkit [90355] by caseq@chromium.org
  • 5 edits in trunk

2011-07-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
​https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits.html:

2011-07-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
​https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.AuditResultImpl):
2:18 AM Changeset in webkit [90354] by yutak@chromium.org
  • 45 edits in trunk/LayoutTests

2011-07-04 Yuta Kitamura <​yutak@chromium.org>

WebSocket: Use jsTestIsAsync and finishJSTest() wherever possible in WebSocket tests
​https://bugs.webkit.org/show_bug.cgi?id=63892

Reviewed by Kent Tamura.

Use jsTestIsAsync and finishJSTest() in WebSocket tests which are run asynchronously.
Script tags loading js-test-post-function.js must be removed, and instead js-test-post.js
must be loaded after each test.

  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html: This test is done synchronously, thus there is no need to use jsTestIsAsync and finishJSTest(). As we are moving away from js-test-post-function.js, isSuccessfullyParsed() should not be used anymore.
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/close-before-open.html:
  • http/tests/websocket/tests/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/close-on-unload.html:
  • http/tests/websocket/tests/close-unref-websocket.html:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-overflow.html: Add close tags for <body> and <html> elements which were not present for some reason.
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/reload-crash.html:
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
12:49 AM Changeset in webkit [90353] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-03 Balazs Kelemen <​kbalazs@webkit.org>

[Qt][WK2] Remove passing tests from the qt-wk2 list
​https://bugs.webkit.org/show_bug.cgi?id=63877

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-wk2/Skipped:

Jul 3, 2011:

10:59 PM Changeset in webkit [90352] by barraclough@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=63879
Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.

Reviewed by Sam Weinig.

There is a lot of copy & paste code here; we can reduce duplication by making
a shared implementation.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::commute):

  • Make these function platform agnostic.
  • assembler/MacroAssemblerX86Common.h:
    • Moved branch32/commute up to MacroAssembler.
  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):

  • Add an implementation matching that for op_loop_if_less, which just calls op_jless.
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

  • Common implmentations of these methods for JSVALUE64 & JSVALUE32_64.

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE64.
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE32_64.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
    • Remove old implementation of emit_op_loop_if_lesseq.
10:56 PM Changeset in webkit [90351] by dominicc@chromium.org
  • 5 edits in trunk

2011-07-03 Dominic Cooney <​dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
​https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Updates test result, and adds a test for setting value < 0.

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:

2011-07-03 Dominic Cooney <​dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
​https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Test: fast/dom/HTMLProgressElement/set-progress-properties.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::value):
10:20 PM Changeset in webkit [90350] by yutak@chromium.org
  • 8 edits in trunk/LayoutTests

2011-07-03 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: pywebsocket handlers should raise exception to abort the connection
​https://bugs.webkit.org/show_bug.cgi?id=63794

pywebsocket automatically sends handshake response when web_socket_do_extra_handshake()
finishes, and starts closing handshake (sends a close frame and waits for client's response)
after web_socket_transfer_data() exits. To stop this behavior, a handler must raise an
exception.

Some of our handlers send broken handshake in web_socket_do_extra_handshake(). If this handler
function exits without raising an exception, pywebsocket automatically sends another handshake
response, which is not really necessary. Normally this extra handshake message is not a problem,
because the client does not read any data beyond the end of the first (broken) handshake if
the client is working correctly. However, if the client erroneously accepts the first handshake,
it will be hard to diagnose the problem because of the extra message. The same can happen for
web_socket_transfer_data().

Generally, pywebsocket handlers should raise an exception if they do not want to send any more
data. However, this fact has been overlooked in past changes, and handlers in many tests exit
normally where they should raise an exception. This change fix these errors.

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Do not need to cycle until disconnection.
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Some ports (Chromium) intercept handshake messages and do not pass server's response to WebCore until they find the end of handshake response (i.e. "\r\n\r\n" and 16-byte data). If the handler aborts the connection without sending this end-of-response marker, entire response is ignored, which causes the test to fail.
8:54 PM Changeset in webkit [90349] by tkent@chromium.org
  • 7 edits
    3 deletes in trunk

2011-07-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
​http://trac.webkit.org/changeset/90347
​https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • fast/js/number-toString-expected.txt:

2011-07-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
​http://trac.webkit.org/changeset/90347
​https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/BigInteger.h: Removed.
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToPrecision): (JSC::numberProtoFuncToString):
  • runtime/Uint16WithFraction.h: Removed.
  • wtf/MathExtras.h:

2011-07-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
​http://trac.webkit.org/changeset/90347
​https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
7:01 PM Changeset in webkit [90348] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-07-03 Daniel Bates <​dbates@webkit.org>

Import Checkout in scm_unittests.py and logging in svn.py to fix
Python missing global variable errors

Rubber-stamped by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
  • Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
3:27 PM Changeset in webkit [90347] by barraclough@apple.com
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
1:34 PM Changeset in webkit [90346] by robert@webkit.org
  • 4 edits
    8 adds in trunk

2011-07-03 Robert Hogan <​robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
​https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <​robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
​https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
1:22 PM Changeset in webkit [90345] by krit@webkit.org
  • 4 edits
    3 adds in trunk

2011-07-03 Dirk Schulze <​krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
​https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


Test accumulate=sum on SVGAnimateTransform. The animation shouldn't start with initial value
on every repeat for accumulation.

  • svg/animations/script-tests/svgtransform-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgtransform-animation-1-expected.txt: Added.
  • svg/animations/svgtransform-animation-1.html: Added.

2011-07-03 Dirk Schulze <​krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
​https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
the first repeat, from 200% on the second and so on.

Test: svg/animations/svgtransform-animation-1.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
11:29 AM Changeset in webkit [90344] by commit-queue@webkit.org
  • 4 edits
    8 deletes in trunk

2011-07-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
​http://trac.webkit.org/changeset/90342
​https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Removed.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-location-reload.html: Removed.

2011-07-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
​http://trac.webkit.org/changeset/90342
​https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
  • loader/NavigationScheduler.cpp:
10:42 AM Changeset in webkit [90343] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-03 Robert Hogan <​robert@webkit.org>

Skip Qt platform-specific test after r90341
​https://bugs.webkit.org/show_bug.cgi?id=45455

Unreviewed, skip test.

The Skipped list needs the platform-specific path of the test.

  • platform/qt/Skipped:
10:27 AM Changeset in webkit [90342] by robert@webkit.org
  • 4 edits
    8 adds in trunk

2011-07-03 Robert Hogan <​robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
​https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <​robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
​https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
10:14 AM Changeset in webkit [90341] by robert@webkit.org
  • 15 edits
    6 adds in trunk

2011-04-02 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

Add a new test and move third-party cookie tests to 'pending
unskipping' for when bots move to 4.8.

See also: ​http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

​http://bugreports.qt.nokia.com/browse/QTBUG-13601

​https://bugs.webkit.org/show_bug.cgi?id=45455

  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html: Added.
  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking-expected.txt: Added. This test is a stricter version of third-party-cookie-relaxing.html with the expected behaviour that all third-party cookies are blocked.
  • platform/qt/Skipped: Prepare tests for unskipping on Qt-4.8.
  • platform/qt/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added. Qt returns cookie lists in a different order from other ports.

2011-04-02 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
​https://bugs.webkit.org/show_bug.cgi?id=45455

Identifying third-party cookies is facilitated by API new to QUrl from
Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
list to determine the top-level registry-controlled domain of the Url.

See also: ​http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

​http://bugreports.qt.nokia.com/browse/QTBUG-13601

Test: http/tests/cookies/strict-third-party-cookie-blocking.html

  • WebCore.pro:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/qt/ThirdPartyCookiesQt.cpp: Added. (WebCore::cookieJar): (WebCore::isFirstPartyCookie): (WebCore::cookieAllowed): (WebCore::allowThirdPartyCookies):
  • platform/qt/ThirdPartyCookiesQt.h: Added.

2011-04-02 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

This adds new API to QWebSettings that allows clients to
select one of three third-party cookie blocking policies:

AlwaysAllowThirdPartyCookies
AlwaysBlockThirdPartyCookies
AllowThirdPartyWithExistingCookies

The first two are self-explanatory, the third mimics Safari's
default behaviour of permitting third-party cookies when the user
already has cookies from the third-party site. This was
introduced to allow third-party cookie blocking to play well with
facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.

There is scope for adding an 'exceptions' list API and clients would
struggle to implement it themselves given the paucity of information
available from setCookiesForUrl().

See also: ​http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

​http://bugreports.qt.nokia.com/browse/QTBUG-13601

​https://bugs.webkit.org/show_bug.cgi?id=45455

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setThirdPartyCookiePolicy): (QWebSettings::thirdPartyCookiePolicy):
  • Api/qwebsettings.h:

2011-04-02 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
​https://bugs.webkit.org/show_bug.cgi?id=45455

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setAlwaysBlockCookies):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
8:58 AM Changeset in webkit [90340] by vsevik@chromium.org
  • 6 edits in trunk

2011-07-03 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
​https://bugs.webkit.org/show_bug.cgi?id=63712

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:

2011-07-03 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
​https://bugs.webkit.org/show_bug.cgi?id=63712

Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
8:51 AM Changeset in webkit [90339] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-07-03 Robert Hogan <​robert@webkit.org>

Add platform-specific results after r90338

Unreviewed, add platform-specific results for new rendertree test.
​https://bugs.webkit.org/show_bug.cgi?id=30355

​http://trac.webkit.org/changeset/90338

  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
8:04 AM Changeset in webkit [90338] by robert@webkit.org
  • 6 edits
    3 adds in trunk

2011-06-23 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
​https://bugs.webkit.org/show_bug.cgi?id=30355

Unfortunately this has to be a rendertree test, as there is no rendertext way of
determining if a selection is still highlighted.

  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection.html: Added.

2011-06-23 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
​https://bugs.webkit.org/show_bug.cgi?id=30355

Test: plugins/mouse-click-plugin-clears-selection.html

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebCore.exp.in: Add symbol for FocusController::setFocusedNode
  • plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
redundant, since it calls both.

2011-06-23 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
​https://bugs.webkit.org/show_bug.cgi?id=30355

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebProcess/Plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() redundant, since the
former calls it.

4:09 AM Changeset in webkit [90337] by abarth@webkit.org
  • 3 edits
    1 move
    1 add in trunk/Tools

2011-07-03 Adam Barth <​abarth@webkit.org>

Factor ReflectionHandler out of the rebaseline server. Just code motion.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
3:45 AM Changeset in webkit [90336] by abarth@webkit.org
  • 2 edits
    6 moves
    5 adds in trunk/Tools

2011-07-03 Adam Barth <​abarth@webkit.org>

Move the rebaseline server out of the commands package and into the
(new) servers package. This patch prepares for refactoring this code
to share server infrastructure with the (forthcoming) garden-o-matic
command.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/init.py: Added.
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.
Note: See TracTimeline for information about the timeline view.