Timeline
Jul 9, 2011:
- 1:43 PM Changeset in webkit [90688] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix unaligned userspace access for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=62993
Patch by Thouraya Andolsi <thouraya.andolsi@st.com> on 2011-07-09
- wtf/Platform.h:
- 1:06 PM Changeset in webkit [90687] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix MIPS build due to readInt32 and readPointer
https://bugs.webkit.org/show_bug.cgi?id=63962
Patch by Chao-ying Fu <fu@mips.com> on 2011-07-09
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::readInt32):
(JSC::MIPSAssembler::readPointer):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::rshift32):
- 12:47 PM Changeset in webkit [90686] by
-
- 2 edits in trunk/Source/WebKit2
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-09
Reviewed by Adam Roben.
[WebKit2] Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63251
No new tests. Covered by existing tests: plugins/mouse-events.html and
plugins/keyboard-events.html.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformSetFocus):
- 12:44 PM Changeset in webkit [90685] by
-
- 7 edits in trunk/Source/WebKit/wx
Reviewed by Kevin Ollivier.
[wx] In load events, specify the wxWebFrame that sent them.
https://bugs.webkit.org/show_bug.cgi?id=64233
- 12:40 PM Changeset in webkit [90684] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed WinCE build fix for r90680.
Repeat the change done in r90681 for all other SVGAnimated*PropertyTearOff.h files.
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Make create public and remove friendship with SVGAnimatedProperty.
- svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.
- svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.
- 12:29 PM Changeset in webkit [90683] by
-
- 2 edits in trunk/Source/WebKit/wx
Reviewed by Kevin Ollivier.
Make sure wxPrintData grabs the default print settings to calculate page width,
and readjusts settings after the print dialog is displayed.
https://bugs.webkit.org/show_bug.cgi?id=64232
- 12:05 PM Changeset in webkit [90682] by
-
- 4 edits in trunk/Tools
Teach TestFailures to abbreviate the examples of test flakiness
These lists can get quite long, and it's not really helpful in most cases to have soooooo
many examples of flakiness.
Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
long they're hard to navigate
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
(FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
of examples, replace the middle items with a separator.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.flakiness-example-separator): Added styles for the separator.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
the separator.
- 7:35 AM Changeset in webkit [90681] by
-
- 2 edits in trunk/Source/WebCore
2011-07-09 Nikolas Zimmermann <nzimmermann@rim.com>
Add a possibility to retrieve the associated SVGAnimatedProperty object for a certain XML attribute
https://bugs.webkit.org/show_bug.cgi?id=63797
Fix WinCE build. Funny none other platform complained.
- svg/properties/SVGAnimatedStaticPropertyTearOff.h: Make create public, SVGAnimatedProperty needs it - remove friendship with it.
- 4:26 AM Changeset in webkit [90680] by
-
- 168 edits3 adds in trunk/Source/WebCore
2011-07-09 Nikolas Zimmermann <nzimmermann@rim.com>
Add a possibility to retrieve the associated SVGAnimatedProperty object for a certain XML attribute
https://bugs.webkit.org/show_bug.cgi?id=63797
Reviewed by Dirk Schulze.
In order to prepare animVal support we need a way to map a given SVG DOM attribute to a SVGAnimatedProperty.
eg. SVGNames::xAttr -> SVGRectElement::xAnimated(), etc. This will be needed to update the animVal of the
SVGAnimatedProperty, if an animation is running. It would required adding a new method to all SVG* classes
that define animated properties. Unfortunately we already have lots of repeated code in methods like
synchronizeProperty / fillAttributeToPropertyTypeMap. Look at SVGRectElement for example:
void SVGRectElement::synchronizeProperty(const QualifiedName& attrName)
{
if (attrName == anyQName()) {
synchronizeX();
synchronizeY();
...
}
if (attrName == SVGNames::xAttr) {
synchronizeX();
return;
}
if (attrName == SVGNames::yAttr) {
synchronizeY();
return;
}
...
}
or
void SVGRectElement::fillAttributeToPropertyTypeMap()
{
AttributeToPropertyTypeMap& attributeToPropertyTypeMap = this->attributeToPropertyTypeMap();
SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap(attributeToPropertyTypeMap);
attributeToPropertyTypeMap.set(SVGNames::xAttr, AnimatedLength);
attributeToPropertyTypeMap.set(SVGNames::yAttr, AnimatedLength);
...
}
These lookups are all performed dynamically. Each synchronizeProperty() call does a lot of comparisons.
fillAttributeToPropertyTypeMap() isn't that bad as the result is cached in a static HashMap per-SVGRectElement.
There's no reason to do these things dynamically!
Inspired by JSC, I'm adding a "static const SVGPropertyInfo s_fooPropertyInfo" object for each animated SVG property.
For example, for SVGRectElements SVGAnimatedLength x property we're storing:
- "AnimatedPropertyType type" (AnimatedLength -- note the enum was named AnimatedAttributeType, I renamed it to AnimatedPropertyType for clarity)
- "const QualifiedName& attributeName" (SVGNames::xAttr)
- "const AtomicString& propertyIdentifier" (SVGNames::xAttr.localName() -- only different if N-wrappers map to a single XML DOM attribute, eg. orientAttr)
- "SynchronizeProperty synchronizeProperty" (callback to SVGRectElement::synchronizeX)
- "LookupOrCreateWrapperForAnimatedProperty lookupOrCreateWrapperForAnimatedProperty" (callback to SVGRectElement::xAnimated)
Using this information, we can replace all the various synchronizeProperty/fillAttributeToPropertyMap implementations, with a single one in SVGElement.
All these are auto-generated, using the standard macros used to define/declare SVG animated properties. This required several changes to the macros.
Here's a summary:
#1) In all headers, wrap DECLARE_ANIMATED_* calls, in BEGIN_DECLARE_ANIMATED_PROPERTIES(ClassName) / END_DECLARE_ANIMATED_PROPERTIES blocks.
Sample change for SVGRectElement:
- DECLARE_ANIMATED_LENGTH(X, x)
- DECLARE_ANIMATED_LENGTH(Y, y)
- ...
+ BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGRectElement)
+ DECLARE_ANIMATED_LENGTH(X, x)
+ DECLARE_ANIMATED_LENGTH(Y, y)
+ ...
+ END_DECLARE_ANIMATED_PROPERTIES
#2) In all cpp files, add a new section wrapped in BEGIN_REGISTER_ANIMATED_PROPERTIES(ClassName / END_REGISTER_ANIMATED_PROPERTIES blocks:
Sample change for SVGRectElement:
+BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGRectElement)
+ REGISTER_LOCAL_ANIMATED_PROPERTY(x)
+ REGISTER_LOCAL_ANIMATED_PROPERTY(y)
+ ...
+ REGISTER_PARENT_ANIMATED_PROPERTIES(SVGStyledTransformableElement)
+ REGISTER_PARENT_ANIMATED_PROPERTIES(SVGTests)
+END_REGISTER_ANIMATED_PROPERTIES
This is the main piece of the logic that replaces the manual synchronizeProperty/fillAttributeToPropertyMap implementation. It expands to following:
SVGAttributeToPropertyMap& SVGRectElement::attributeToPropertyMap()
{
DEFINE_STATIC_LOCAL(SVGAttributeToPropertyMap, s_attributeToPropertyMap, ());
}
static void registerAnimatedPropertiesForSVGRectElement()
{
SVGAttributeToPropertyMap& map = SVGRectElement::attributeToPropertyMap();
if (!map.isEmpty())
return;
map.addProperty(SVGRectElement::xPropertyInfo());
map.addProperty(SVGRectElement::yPropertyInfo());
...
map.addProperties(SVGStyledTransformableElement::attributeToPropertyMap());
map.addProperties(SVGTests::attributeToPropertyMap());
}
A single-instance of SVGAttributeToPropertyMap is created for each SVG*Element. The constructor of SVGRectElement is supposed to call
registerAnimatedPropertiesForSVGRectElement(), which collects all properties of SVGRectElement and all its parent classes and stores them
in a Vector<const SVGPropertyInfo*>. This Vector is stored in a HashMap<QualifiedName, Vector<const SVGPropertyInfo*> > where the key
is the attribute name (eg. SVGNames::xAttr -> SVGRectElement::xPropertyInfo). This is only done _once_ per SVGRectElement.
SVGElement contains a "virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap()" method, and SVGRectElement overrides it
and returns SVGRectElement::attributeToPropertyMap() (which is static!) -- this is hidden again in the macros, no need to write any code.
SVGAttributeToPropertyMap provides following API:
- bool synchronizeProperty(SVGElement* contextElement, const QualifiedName& attributeName)
- void synchronizeProperties(SVGElement* contextElement)
A generic way to synchronize a SVGAnimatedProperty with its XML DOM attribute. Any SVG DOM change to eg. <rect>s x property will now trigger
contextElement->localAttributeToPropertyMap().synchronizeProperty(this, SVGNames::xAttr)
The SVGAttributeToPropertyMap will ask its HashMap for the Vector containing the properties for SVGNames::xAttr (in that case, just one xAnimated()).
- void animatedPropertyTypeForAttribute(const QualifiedName& attributeName, Vector<AnimatedPropertyType>& propertyTypes)
This method replaces the fillAttributeToPropertyMap implementations everywhere.
- void animatedPropertiesForAttribute(SVGElement* contextElement, const QualifiedName& attributeName, Vector<RefPtr<SVGAnimatedProperty> >& properties);
This method is not used yet, but allows us to collect all SVGAnimatedProperties for a QualifiedName -- the initial goal for this patch.
#3) In all cpp files, add a call to "registerAnimatedPropertiesForClassName()" in the constructor. Forgetting this will result in a compile error.
Doesn't affect any tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm: (NativeToJSValue):
- bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement):
- svg/SVGAElement.h: (WebCore::SVGAElement::synchronizeRequiredFeatures): (WebCore::SVGAElement::synchronizeRequiredExtensions): (WebCore::SVGAElement::synchronizeSystemLanguage):
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedPropertyType): (WebCore::SVGAnimateElement::determinePropertyValueTypes): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance): (WebCore::SVGAnimateElement::ensureAnimator):
- svg/SVGAnimateElement.h:
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedPropertyType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedAngle.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedEnumeration.h:
- svg/SVGAnimatedInteger.h:
- svg/SVGAnimatedLength.h:
- svg/SVGAnimatedLengthList.h:
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.h:
- svg/SVGAnimatedPreserveAspectRatio.h:
- svg/SVGAnimatedRect.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::SVGAnimatedType):
- svg/SVGAnimatedType.h: (WebCore::SVGAnimatedType::type):
- svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::synchronizeRequiredFeatures): (WebCore::SVGAnimationElement::synchronizeRequiredExtensions): (WebCore::SVGAnimationElement::synchronizeSystemLanguage):
- svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement):
- svg/SVGCircleElement.h: (WebCore::SVGCircleElement::synchronizeRequiredFeatures): (WebCore::SVGCircleElement::synchronizeRequiredExtensions): (WebCore::SVGCircleElement::synchronizeSystemLanguage):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement):
- svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::synchronizeRequiredFeatures): (WebCore::SVGClipPathElement::synchronizeRequiredExtensions): (WebCore::SVGClipPathElement::synchronizeSystemLanguage):
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement):
- svg/SVGCursorElement.h: (WebCore::SVGCursorElement::synchronizeRequiredFeatures): (WebCore::SVGCursorElement::synchronizeRequiredExtensions): (WebCore::SVGCursorElement::synchronizeSystemLanguage):
- svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h: (WebCore::SVGDefsElement::synchronizeRequiredFeatures): (WebCore::SVGDefsElement::synchronizeRequiredExtensions): (WebCore::SVGDefsElement::synchronizeSystemLanguage):
- svg/SVGElement.cpp: (WebCore::SVGElement::animatedPropertyTypeForAttribute): (WebCore::SVGElement::updateAnimatedSVGAttribute): (WebCore::SVGElement::localAttributeToPropertyMap): (WebCore::SVGElement::synchronizeRequiredFeatures): (WebCore::SVGElement::synchronizeRequiredExtensions): (WebCore::SVGElement::synchronizeSystemLanguage):
- svg/SVGElement.h: (WebCore::SVGElement::svgAttributeChanged): (WebCore::SVGElement::synchronizeRequiredFeatures): (WebCore::SVGElement::synchronizeRequiredExtensions): (WebCore::SVGElement::synchronizeSystemLanguage):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement):
- svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::synchronizeRequiredFeatures): (WebCore::SVGEllipseElement::synchronizeRequiredExtensions): (WebCore::SVGEllipseElement::synchronizeSystemLanguage):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFitToViewBox.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement):
- svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
- svg/SVGForeignObjectElement.h: (WebCore::SVGForeignObjectElement::synchronizeRequiredFeatures): (WebCore::SVGForeignObjectElement::synchronizeRequiredExtensions): (WebCore::SVGForeignObjectElement::synchronizeSystemLanguage):
- svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement):
- svg/SVGGElement.h: (WebCore::SVGGElement::synchronizeRequiredFeatures): (WebCore::SVGGElement::synchronizeRequiredExtensions): (WebCore::SVGGElement::synchronizeSystemLanguage):
- svg/SVGGlyphElement.cpp:
- svg/SVGGlyphElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::svgAttributeChanged):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
- svg/SVGImageElement.h: (WebCore::SVGImageElement::synchronizeRequiredFeatures): (WebCore::SVGImageElement::synchronizeRequiredExtensions): (WebCore::SVGImageElement::synchronizeSystemLanguage):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement):
- svg/SVGLineElement.h: (WebCore::SVGLineElement::synchronizeRequiredFeatures): (WebCore::SVGLineElement::synchronizeRequiredExtensions): (WebCore::SVGLineElement::synchronizeSystemLanguage):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypePropertyInfo): (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper): (WebCore::SVGMarkerElement::orientTypeAnimated):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement):
- svg/SVGMaskElement.h: (WebCore::SVGMaskElement::synchronizeRequiredFeatures): (WebCore::SVGMaskElement::synchronizeRequiredExtensions): (WebCore::SVGMaskElement::synchronizeSystemLanguage):
- svg/SVGMissingGlyphElement.cpp:
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::dPropertyInfo): (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::svgAttributeChanged): (WebCore::SVGPathElement::lookupOrCreateDWrapper): (WebCore::SVGPathElement::synchronizeD): (WebCore::SVGPathElement::pathSegList): (WebCore::SVGPathElement::animatedPathSegList):
- svg/SVGPathElement.h: (WebCore::SVGPathElement::pathByteStream): (WebCore::SVGPathElement::synchronizeRequiredFeatures): (WebCore::SVGPathElement::synchronizeRequiredExtensions): (WebCore::SVGPathElement::synchronizeSystemLanguage):
- svg/SVGPathSegWithContext.h: (WebCore::SVGPathSegWithContext::animatedProperty):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
- svg/SVGPatternElement.h: (WebCore::SVGPatternElement::synchronizeRequiredFeatures): (WebCore::SVGPatternElement::synchronizeRequiredExtensions): (WebCore::SVGPatternElement::synchronizeSystemLanguage):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::pointsPropertyInfo): (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::lookupOrCreatePointsWrapper): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints):
- svg/SVGPolyElement.h: (WebCore::SVGPolyElement::synchronizeRequiredFeatures): (WebCore::SVGPolyElement::synchronizeRequiredExtensions): (WebCore::SVGPolyElement::synchronizeSystemLanguage):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement):
- svg/SVGRectElement.h: (WebCore::SVGRectElement::synchronizeRequiredFeatures): (WebCore::SVGRectElement::synchronizeRequiredExtensions): (WebCore::SVGRectElement::synchronizeSystemLanguage):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGSVGElement.h: (WebCore::SVGSVGElement::synchronizeRequiredFeatures): (WebCore::SVGSVGElement::synchronizeRequiredExtensions): (WebCore::SVGSVGElement::synchronizeSystemLanguage):
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement):
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForAttribute):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement):
- svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::synchronizeRequiredFeatures): (WebCore::SVGSwitchElement::synchronizeRequiredExtensions): (WebCore::SVGSwitchElement::synchronizeSystemLanguage):
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement):
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp:
- svg/SVGTSpanElement.h:
- svg/SVGTests.cpp: (WebCore::SVGTests::requiredFeaturesPropertyInfo): (WebCore::SVGTests::requiredExtensionsPropertyInfo): (WebCore::SVGTests::systemLanguagePropertyInfo): (WebCore::SVGTests::attributeToPropertyMap): (WebCore::SVGTests::synchronizeRequiredFeatures): (WebCore::SVGTests::synchronizeRequiredExtensions): (WebCore::SVGTests::synchronizeSystemLanguage):
- svg/SVGTests.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::textLengthPropertyInfo): (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeTextLength): (WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper): (WebCore::SVGTextContentElement::textLengthAnimated):
- svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::synchronizeRequiredFeatures): (WebCore::SVGTextContentElement::synchronizeRequiredExtensions): (WebCore::SVGTextContentElement::synchronizeSystemLanguage):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp:
- svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement):
- svg/SVGUseElement.h: (WebCore::SVGUseElement::synchronizeRequiredFeatures): (WebCore::SVGUseElement::synchronizeRequiredExtensions): (WebCore::SVGUseElement::synchronizeSystemLanguage):
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement):
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h:
- svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): (WebCore::SVGAnimatedProperty::lookupWrapper):
- svg/properties/SVGAnimatedPropertyMacros.h:
- svg/properties/SVGAnimatedPropertySynchronizer.h:
- svg/properties/SVGAttributeToPropertyMap.cpp: Added. (WebCore::SVGAttributeToPropertyMap::addProperties): (WebCore::SVGAttributeToPropertyMap::addProperty): (WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute): (WebCore::SVGAttributeToPropertyMap::animatedPropertyTypeForAttribute): (WebCore::SVGAttributeToPropertyMap::synchronizeProperties): (WebCore::SVGAttributeToPropertyMap::synchronizeProperty): (WebCore::SVGAttributeToPropertyMap::animatedProperty):
- svg/properties/SVGAttributeToPropertyMap.h: Added. (WebCore::SVGAttributeToPropertyMap::SVGAttributeToPropertyMap): (WebCore::SVGAttributeToPropertyMap::~SVGAttributeToPropertyMap): (WebCore::SVGAttributeToPropertyMap::isEmpty):
- svg/properties/SVGPropertyInfo.h: Added. (WebCore::SVGPropertyInfo::SVGPropertyInfo):
- 4:21 AM Changeset in webkit [90679] by
-
- 6 edits in trunk/Tools
nrwt: stack traces from worker-side exceptions aren't very useful inside test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=64218
Reviewed by Eric Seidel.
Exceptions aren't picklable and can't be sent across the
manager/worker message queue without losing information. NRWT
handles this by turning the stack trace into a set of strings,
and logging the strings when we receive an exception from the
worker. However, when you are running tests and something
crashes on the worker side, test-webkitpy prints the
manager-side stack trace, which is just confusing and useless.
This patch changes the logic so that exceptions are passed
through as-is when the worker and manager are in the same
process (the --worker-model=inline option). This increases the
code paths slightly but makes crashes much more useful.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/controllers/message_broker.py:
- Scripts/webkitpy/layout_tests/controllers/worker.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- 3:55 AM Changeset in webkit [90678] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r90676.
- platform/graphics/ImageBuffer.cpp:
- 3:36 AM WinCE edited by
- Fixed build exmple after r76656 (diff)
- 2:58 AM Changeset in webkit [90677] by
-
- 2 edits in trunk/Tools
Eliminate bad dependency on gfx::Point.
https://bugs.webkit.org/show_bug.cgi?id=64228
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/EventSender.cpp:
(initMouseEvent):
Jul 8, 2011:
- 11:05 PM Changeset in webkit [90676] by
-
- 5 edits in trunk/Source/WebCore
Refactoring luminance code in RenderSVGResourceMasker
https://bugs.webkit.org/show_bug.cgi?id=64146
Reviewed by Simon Fraser.
Moved luminance calculcation code to ImageBuffer. The code is doing pixel manipulations and can now get replaced
by platform specific algorithms in the ImmageBuffer*.cpp files.
No change of functionality. No new tests.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
(WebCore::ImageBuffer::genericConvertToLuminanceMask):
(WebCore::ImageBuffer::convertToLuminanceMask):
- platform/graphics/ImageBuffer.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- 5:43 PM Changeset in webkit [90675] by
-
- 42 edits in trunk/Source/WebCore
2011-07-08 Simon Fraser <Simon Fraser>
Clean up RenderWidget::destroy() to share more code
https://bugs.webkit.org/show_bug.cgi?id=64138
Reviewed by James Robinson.
RenderWidget::destroy() copied code from various other
destroy() methods, which made code maintenance in this
area very risky.
Fix by adding a virtual willBeDestroyed() method, which
replaces most instances of destroy(). Now, only RenderWidget
and RenderObject implement destroy(), and each just calls
willBeDestroyed(). Code duplication is averted.
No behavior change, so no tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::willBeDestroyed):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::willBeDestroyed):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::willBeDestroyed): (RenderFullScreen::willBeDestroyed):
- rendering/RenderFullScreen.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::willBeDestroyed):
- rendering/RenderInline.h:
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::willBeDestroyed):
- rendering/RenderListItem.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): (WebCore::RenderObject::destroy):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::willBeDestroyed):
- rendering/RenderReplaced.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::willBeDestroyed):
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::willBeDestroyed):
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::willBeDestroyed):
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp: (WebCore::RenderText::willBeDestroyed):
- rendering/RenderText.h:
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::willBeDestroyed):
- rendering/RenderTextFragment.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::willBeDestroyed): (WebCore::RenderWidget::destroy):
- rendering/RenderWidget.h:
- rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::willBeDestroyed):
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::willBeDestroyed):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::willBeDestroyed):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::willBeDestroyed):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::willBeDestroyed):
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::willBeDestroyed):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/SVGResourcesCache.h:
- 5:39 PM WikiStart edited by
- (diff)
- 5:02 PM Changeset in webkit [90674] by
-
- 6 edits14 adds4 deletes in trunk/Tools
pull static dashboard files into the appengine server from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=64208
Reviewed by Dirk Pranke.
These files belong in the WebKit repo since they are tied primarily to the webkit tests.
They have some extra bits to support chromium's gtests, but that seems fine.
Mainly, this will allow other WebKit hackers to hack on the dashboards.
As a nice side-effect, we can now push the dashboard files when we do appengine pushes
instead of the weird thing we used to do of pulling them from the Chromium repository
and storing them in the appengine datastore. This allows for cleaning up a lot of code
and will likely make the dashboards load a bit faster.
The new JS files don't fully match WebKit style, but I'd like to clean that up in a
followup patch if possible to maintain my sanity with this patch.
- TestResultServer/app.yaml:
- TestResultServer/handlers/dashboardhandler.py: Removed.
- TestResultServer/handlers/menu.py:
- TestResultServer/main.py:
- TestResultServer/model/dashboardfile.py: Removed.
- TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
- TestResultServer/static-dashboards/README.dygraph.txt: Added.
- TestResultServer/static-dashboards/README.webtreemap.txt: Added.
- TestResultServer/static-dashboards/aggregate_results.html: Added.
- TestResultServer/static-dashboards/builders.js: Added.
- TestResultServer/static-dashboards/dashboard_base.js: Added.
- TestResultServer/static-dashboards/dygraph-combined.js: Added.
- TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
- TestResultServer/static-dashboards/timeline_explorer.html: Added.
- TestResultServer/static-dashboards/treemap.html: Added.
- TestResultServer/static-dashboards/webtreemap.css: Added.
- TestResultServer/static-dashboards/webtreemap.js: Added.
- TestResultServer/stylesheets/dashboardfile.css: Removed.
- TestResultServer/stylesheets/menu.css:
- TestResultServer/templates/dashboardfilelist.html: Removed.
- TestResultServer/templates/menu.html:
- 4:40 PM Changeset in webkit [90673] by
-
- 12 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=64181
REGRESSION (r90602): Gmail doesn't load
- dfg/DFGAliasTracker.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::dfgLinkCall):
- dfg/DFGRepatch.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
- 4:35 PM Changeset in webkit [90672] by
-
- 3 edits in trunk/Tools
Make TestFailures's list of flaky tests look more like the list of non-flaky tests
Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.
- 3:57 PM Changeset in webkit [90671] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r90662.
http://trac.webkit.org/changeset/90662
https://bugs.webkit.org/show_bug.cgi?id=64210
Introduced regressions in Chromium browser tests (Requested by
rniwa on #webkit).
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::selectionChanged):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selectionStart):
(WebCore::RenderTextControl::selectionEnd):
(WebCore::RenderTextControl::hasVisibleTextArea):
(WebCore::setSelectionRange):
(WebCore::setContainerAndOffsetForRange):
(WebCore::RenderTextControl::selection):
- rendering/RenderTextControl.h:
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
- 3:32 PM Changeset in webkit [90670] by
-
- 2 edits in trunk/Source/WebCore
Make GL context current before updating layer texture using skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=64206
Patch by Brian Salomon <bsalomon@google.com> on 2011-07-08
Reviewed by James Robinson.
Covered by existing tests (when accelerated drawing and compositing are on).
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- 3:25 PM Changeset in webkit [90669] by
-
- 2 edits in trunk/Tools
2011-07-08 Jeffrey Pfau <jpfau@apple.com>
Unreviewed, add myself as committer.
- Scripts/webkitpy/common/config/committers.py:
- 3:15 PM Changeset in webkit [90668] by
-
- 8 edits in trunk/Source/WebCore
Refactor override size to be a size rather than just an int
https://bugs.webkit.org/show_bug.cgi?id=64195
Reviewed by David Hyatt.
Also convert to LayoutSize and LayoutUnit.
Covered by existing tests.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::overrideSize): Pass in a LayoutSize.
(WebCore::RenderBox::setOverrideSize):
(WebCore::RenderBox::clearOverrideSize): New method for clearing the
override size (previous we would pass in -1)
(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
- rendering/RenderBox.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideSizeFromRowHeight):
- rendering/RenderTableCell.h: Remove setOverrideSize since it was
only called in one place to clear the override size. Inline this
logic instead.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
- 3:01 PM Changeset in webkit [90667] by
-
- 16 edits in trunk/Source/WebCore
Switch pointInContainer and accumulatedOffset to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64112
Reviewed by Eric Seidel.
Convert remaining IntPoint versions of the pointInContainer and
accumulatedOffset arguments to the new layout abstraction.
No new tests, no functionality changes.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/HitTestResult.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
- rendering/RenderBox.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderListBox.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
- rendering/RenderObject.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
- 2:50 PM Changeset in webkit [90666] by
-
- 4 edits in trunk/LayoutTests
Unreviewed; new chromium GPU pixel results for overflow-scroll-expected.
- platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- 2:18 PM Changeset in webkit [90665] by
-
- 3 edits1 add in trunk/Tools
TestResultsServer should keep old test results
https://bugs.webkit.org/show_bug.cgi?id=64199
Reviewed by Ojan Vafai.
Having historical data will help us do failure archeology.
- TestResultServer/handlers/testfilehandler.py:
- TestResultServer/model/testfile.py:
- TestResultServer/templates/showfilelist.jsonp: Added.
- 1:58 PM Changeset in webkit [90664] by
-
- 2 edits in trunk/Tools
Remove commit-log-editor's dependency on Module::Load::Conditional
This module isn't available in Perl 5.8.8 (the version used on Leopard).
Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
webkitpy.common.checkout.checkout_unittest failing on Leopard
Reviewed by Daniel Bates.
- Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of
Module::Load::Conditional::can_load.
(loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.
- 1:37 PM Changeset in webkit [90663] by
-
- 2 edits in trunk/LayoutTests
Skip all HTMLProgressElement tests on Windows
<http://webkit.org/b/49769> tracks implementing this element on Windows. For now it's just a
source of failing tests.
- platform/win/Skipped: Skip the entire HTMLProgressElement directory so we don't have to
keep adding new tests one-by-one.
- 1:30 PM Changeset in webkit [90662] by
-
- 9 edits in trunk/Source
Move selection related code from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64133
Reviewed by Dimitri Glazkov.
Source/WebCore:
Moved selectionStart, selectionEnd, hasVisibleTextArea, setSelectionRange, setContainerAndOffsetForRange
and selection from RenderTextControl.cpp to HTMLFormControlElement.cpp.
This refactoring removes RenderTextControl's dependency on FrameSelection.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::selectedText): Calls HTMLTextFromControl::selectedText.
(WebCore::AccessibilityRenderObject::selectedTextRange): Calls selectionStart and selectionEnd.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::selectedText): Extracted from AccessibilityRenderObject::selectedText.
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange): Merged with the function of the same name in
RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionStart): Ditto.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::setContainerAndOffsetForRange): Moved from RenderTextControl.cpp
(WebCore::HTMLTextFormControlElement::selection): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls selectionStart and selectionEnd.
- html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Moved from HTMLFormControlElement.cpp now that
all functions are self-contained in HTMLTextFormControlElement.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Calls setSelectionRange.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement): Added.
- rendering/RenderTextControl.h:
Source/WebKit/qt:
Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.
- Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
- 1:28 PM Changeset in webkit [90661] by
-
- 3 edits1 delete in trunk/Source/WebCore
remove (empty) indirection between GraphicsContextPlatformPrivate and PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=64178
Patch by Mike Reed <reed@google.com> on 2011-07-08
Reviewed by Stephen White.
No new tests. no functionality change, other than removing an indirection that is not needed
- platform/graphics/GraphicsContext.h:
- platform/graphics/skia/GraphicsContextPlatformPrivate.h: Removed.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):
- 1:28 PM Changeset in webkit [90660] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; chromium test_expectations update.
Add some MAC GPU failing tests from r90464.
- platform/chromium/test_expectations.txt:
- 1:02 PM Changeset in webkit [90659] by
-
- 2 edits in trunk/Tools
Make checkout_unittest more robust against files moving around
Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
Scripts directory
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
object and use it to get the path to the Scripts directory, rather than hard-coding the
relative path from this file to Scripts.
- 1:01 PM Changeset in webkit [90658] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; chromium test_expectations update.
Add some WIN GPU failing tests from r90464 to test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 12:54 PM Changeset in webkit [90657] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; chromium test rebaseline.
New baseline for a failing test on GPU linux introduced in r90646.
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 12:51 PM Changeset in webkit [90656] by
-
- 2 edits in trunk/Tools
Make TestFailures remember that run-webkit-tests timed out, even across reloads
Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
When true, it indicates that there was an error retrieving the results for this build and
that the errorCallback should be called.
- 12:47 PM Changeset in webkit [90655] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; chromium test expectations cleanup.
Removed some duplicate expectations.
- platform/chromium/test_expectations.txt:
- 12:31 PM Changeset in webkit [90654] by
-
- 3 edits2 adds in trunk/Source/WebCore
Add framework for a new/dummy XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=63955
Reviewed by Adam Barth.
Added a dummy framework NewXMLDocumentParser
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::createParser):
- xml/parser/NewXMLDocumentParser.cpp: Added.
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):
(WebCore::NewXMLDocumentParser::insert):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::detach):
(WebCore::NewXMLDocumentParser::hasInsertionPoint):
(WebCore::NewXMLDocumentParser::finishWasCalled):
(WebCore::NewXMLDocumentParser::processingData):
(WebCore::NewXMLDocumentParser::prepareToStopParsing):
(WebCore::NewXMLDocumentParser::stopParsing):
(WebCore::NewXMLDocumentParser::isWaitingForScripts):
(WebCore::NewXMLDocumentParser::isExecutingScript):
(WebCore::NewXMLDocumentParser::executeScriptsWaitingForStylesheets):
- xml/parser/NewXMLDocumentParser.h: Added.
(WebCore::NewXMLDocumentParser::create):
- 12:27 PM Changeset in webkit [90653] by
-
- 2 edits in trunk/Source/WebCore
Remove unused function parameters.
Patch by David Reveman <reveman@chromium.org> on 2011-07-08
Reviewed by Ryosuke Niwa.
- platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::textureOffset):
- 12:26 PM Changeset in webkit [90652] by
-
- 9 edits in trunk/Tools
Teach garden-o-matic how to display test results
https://bugs.webkit.org/show_bug.cgi?id=64141
Reviewed by Ojan Vafai.
This patch includes basic infrastructure for probing build.chromium.org
for test results. We only handle text and image tests, not anything
complicated like reftests. Also, we're using the revision/build
independent results store on the server, so we're avoiding that
complication for now.
It's slightly hacky that we need to probe the server to see what kinds
of results exist. A better solution would be to add CORS support to
the server or to use the local server to help.
- Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
- Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
- Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
- Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
- Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
- Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
- 12:21 PM Changeset in webkit [90651] by
-
- 3 edits in trunk/Tools
REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
https://bugs.webkit.org/show_bug.cgi?id=64092
Reviewed by Tony Chang.
The code was incorrectly creating empty shards in the
shard_in_two case.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
- 12:05 PM Changeset in webkit [90650] by
-
- 2 edits in trunk/Tools
Teach buildbot to figure out how many webkitpy/webkitperl tests failed
Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
tests failed when looking at build.webkit.org
Reviewed by Eric Seidel.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestWithFailureCount): New class that represents a test build step which has an associated
failure count. Eventually we should move more of our test classes to deriving from this.
(TestWithFailureCount.countFailures): Method for subclasses to override to say how many
failures occurred.
(TestWithFailureCount.commandComplete):
(TestWithFailureCount.evaluateCommand):
(TestWithFailureCount.getText):
(TestWithFailureCount.getText2):
These were all based on RunGtkAPITests.
(RunPythonTests): Changed to inherit from TestWithFailureCount.
(RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
failures.
(RunPerlTests): Changed to inherit from TestWithFailureCount.
(RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
failures.
- 11:59 AM Changeset in webkit [90649] by
-
- 3 edits in trunk/Source/JavaScriptCore
Patch by Kalev Lember <kalev@smartlink.ee> on 2011-07-08
Reviewed by Adam Roben.
Add missing _WIN32_WINNT and WINVER definitions
https://bugs.webkit.org/show_bug.cgi?id=59702
Moved _WIN32_WINNT and WINVER definitions to config.h so that they are
available for all source files.
In particular, wtf/FastMalloc.cpp uses CreateTimerQueueTimer and
DeleteTimerQueueTimer which are both guarded by
#if (_WIN32_WINNT >= 0x0500)
in MinGW headers.
- config.h:
- wtf/Assertions.cpp:
- 11:47 AM Changeset in webkit [90648] by
-
- 2 edits in trunk/Tools
Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
bots due to commit-log-editor errors
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
$CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
commit-log-editor can find a value for the committer's email, and that the committer and
author email addresses match, which will prevent commit-log-editor from inserting a "Patch
by" line in the commit message.
- 11:37 AM Changeset in webkit [90647] by
-
- 16 edits2 adds in trunk
[Qt][WK2] Views should expose QActions for basic navigation.
https://bugs.webkit.org/show_bug.cgi?id=64174
Source/WebKit2:
Add navigationAction() methods to the views to provide default
QActions for Back, Forward, Stop and Reload.
Reviewed by Benjamin Poulain.
- UIProcess/API/qt/WKView.h:
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::navigationAction):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::navigationAction):
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qwebkittypes.h: Added.
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::triggerNavigationAction):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
- UIProcess/API/qt/tests/html/basic_page2.html: Added.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::navigationAction):
- UIProcess/qt/QtWebPageProxy.h:
- WebKit2API.pri:
Tools:
Reviewed by Benjamin Poulain.
Bring the toolbar in Qt's MiniBrowser back to life.
- MiniBrowser/qt/BrowserView.cpp:
(BrowserView::navigationAction):
- MiniBrowser/qt/BrowserView.h:
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
- 11:33 AM Changeset in webkit [90646] by
-
- 13 edits3 adds in trunk
Patch by David Reveman <reveman@chromium.org> on 2011-07-08
Reviewed by Stephen White.
[Chromium] Edge anti-aliasing for composited layers.
https://bugs.webkit.org/show_bug.cgi?id=61388
Source/WebCore:
Add transparent outer border to tiled layers and adjust vertex
coordinates so that use of a bilinear filter creates a smooth
layer edge.
Tests: platform/chromium/compositing/tiny-layer-rotated.html
platform/chromium/compositing/huge-layer-rotated.html (existing)
TilingDataTest in webkit_unit_tests
- platform/graphics/chromium/ContentLayerChromium.cpp:
Change maxUntiledSize to 510 to ensure that tiles are not greater
than 512 with outer borders.
(WebCore::ContentLayerChromium::updateLayerSize): We can't use the
layer size as tile size when we want to avoid tiling as this will
not be enough space to include possible outer borders. We instead use
an empty size, which allows the tiler to automatically adjust the
tile size to be large enough for the layer to fit in one tile.
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::setIsMask): Don't use border texels
for layer used as mask.
- platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::m_borderTexels) Added.
- platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::tileTexRect): Added.
(WebCore::LayerTilerChromium::tileLayerRect): m_tileSize is no
longer the correct layer size. Size of bounds with border should
be the correct layer size.
(WebCore::LayerTilerChromium::growLayerToContain): Adjust texture
size to include outer borders and handle empty m_tileSize.
(WebCore::LayerTilerChromium::invalidateRect): Use size of rectangle
returned by tileTexRect instead of m_tileSize for texture size.
(WebCore::LayerTilerChromium::prepareToUpdate): Ditto.
(WebCore::LayerTilerChromium::draw): Compute and intersect tile edges
instead of using tile coordinates directly. Edges are adjusted to
include outer borders and make sure all partially covered pixels are
processed.
(WebCore::LayerTilerChromium::drawTexturedQuad): Pass quad to
shader using point uniform.
(WebCore::LayerTilerChromium::invalidateRect): Invalidate old layer
area to clear any contents left from previous layer size.
- platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::tileTexRect) Added.
(WebCore::LayerTilerChromium::drawTexturedQuad): Add quad parameter.
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTexTransform::getShaderString) Get X/Y vertex
components from point uniform.
(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform)
Added point uniform.
(WebCore::VertexShaderPosTexTransform::init) Ditto.
(WebCore::VertexShaderPosTexTransform::pointLocation) Added.
- platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderPosTexTransform::pointLocation) Added.
- platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithOuterBorder): Added.
(WebCore::TilingData::computeNumTiles): Adjust for outer border.
(WebCore::TilingData::tileXIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileYIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileSizeX): Ditto.
(WebCore::TilingData::tileSizeY): Ditto.
(WebCore::TilingData::intersectDrawQuad): Ditto.
(WebCore::TilingData::textureOffset): Ditto.
- platform/graphics/gpu/TilingData.h:
(WebCore::TilingData::tileBoundsWithOuterBorder): Added.
Source/WebKit:
Track changes to TilingData class which now uses an outer border.
- chromium/tests/TilingDataTest.cpp:
LayoutTests:
- platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
- platform/chromium/compositing/tiny-layer-rotated-expected.txt: Added.
- platform/chromium/compositing/tiny-layer-rotated.html: Added.
- platform/chromium/test_expectations.txt:
- 11:13 AM Changeset in webkit [90645] by
-
- 2 edits in trunk/Source/WebCore
[skia] don't rely on lockPixels failure to detect gpu-backed device (in prep for skia roll)
https://bugs.webkit.org/show_bug.cgi?id=64162
Patch by Mike Reed <reed@google.com> on 2011-07-08
Reviewed by Stephen White.
No new tests. preparing for skia roll, where lockPixels always succeeds (but slowly for gpu-backed)
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::putImageData):
- 11:06 AM Changeset in webkit [90644] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Get rid of the check for TILED_BACKING_STORE in Qt
https://bugs.webkit.org/show_bug.cgi?id=64175
Reviewed by Kenneth Rohde Christiansen.
Qt no longer supports building WebKit2 without TILED_BACKING_STORE.
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPagePrivate::onScaleChanged):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setResizesToContentsUsingLayoutSize):
- UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
- UIProcess/qt/TiledDrawingAreaTileQt.cpp:
- WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:
- 10:54 AM Changeset in webkit [90643] by
-
- 11 edits in trunk/Source
Source/JavaScriptCore: Rename "makeSecure" to "fill" and remove the support for displaying last character
to avoid layering violatation.
https://bugs.webkit.org/show_bug.cgi?id=59114
Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.
- JavaScriptCore.exp:
- JavaScriptCore.order:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::fill):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.h:
(WTF::String::fill):
Source/WebCore: Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114
Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.
No new tests, just refactoring.
- editing/visible_units.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
- rendering/RenderText.cpp:
(WebCore::RenderText::setTextInternal):
Source/WebKit/win: Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114
Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.
- WebKitGraphics.cpp:
(WebDrawText):
- 10:51 AM WebKit2 edited by
- (diff)
- 10:29 AM Changeset in webkit [90642] by
-
- 12 edits3 adds in trunk
[CSSRegions]Parse content: -webkit-from-flow
https://bugs.webkit.org/show_bug.cgi?id=63133
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-08
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/content-webkit-from-flow-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFromFlowContent):
- css/CSSParser.h:
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):
- css/CSSPrimitiveValue.h:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionThread):
(WebCore::InheritedFlags::setRegionThread):
(WebCore::InheritedFlags::initialRegionThread):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
- fast/regions/content-webkit-from-flow-parsing.html: Added.
- fast/regions/script-tests/content-webkit-from-flow-parsing.js: Added.
- 10:24 AM Changeset in webkit [90641] by
-
- 2 edits in trunk/Source/WebKit/chromium
Check activeDocumentLoader() in
WebFrameImpl::currentHistoryItem() and return
early if null, since that should mean we're
shutting down.
https://bugs.webkit.org/show_bug.cgi?id=52923
Reviewed by Darin Fisher.
No known repro, so no new test.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::currentHistoryItem):
- 9:13 AM Changeset in webkit [90640] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r90557): http/tests/inspector/network/network-embed.html fails
https://bugs.webkit.org/show_bug.cgi?id=64103
Unreviewed test fix (typo).
- http/tests/inspector/network/network-embed.html:
- 9:09 AM Changeset in webkit [90639] by
-
- 3 edits in trunk/Tools
Teach TestFailures how to find test names in commit-log-editor-style commit messages
TestFailures was relying on Trac turning the list of modified files in our commit messages
into an HTML list. But Trac only does this when the list of modified files is indented.
commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
list, which was confusing TestFailures.
TestFailures now does much simpler parsing of the commit message (i.e., just a substring
search) without relying at all on its structure.
Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
fast/dom/HTMLProgressElement/progress-element-markup.html on Windows
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
message, just return its text.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForRegressionRange): Instead of searching for test names in
each commit's list of modified files, just search for test names anywhere in the commit's
message.
- 9:04 AM Changeset in webkit [90638] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: styles-disable-then-delete was flaky.
https://bugs.webkit.org/show_bug.cgi?id=64170
Reviewed by Yury Semikhatsky.
- inspector/styles/styles-add-invalid-property.html:
- inspector/styles/styles-disable-then-delete.html:
- 9:01 AM Changeset in webkit [90637] by
-
- 2 edits2 adds in trunk/LayoutTests
Web Inspector: inspector/styles/styles-url-linkify.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=64171
Added image files because the behavior differs when they are not available.
Unreviewed test fix: added image files.
- inspector/styles/resources/fromcss.png: Added.
- inspector/styles/resources/iframed.png: Added.
- inspector/styles/styles-url-linkify-expected.txt:
- 8:58 AM Changeset in webkit [90636] by
-
- 3 edits in trunk/Tools
sheriffbot is too spammy in IRC
https://bugs.webkit.org/show_bug.cgi?id=64153
Reviewed by Eric Seidel.
Reporting failures in IRC worked well when the tree was greener than it
is today. Nowadays, this feature mostly just results in spam about
false positives. If we reach a greener state, we can bring this code
back.
(Another possibility is to restrict this feature to builder bots,
rather than including testers, as we did before this patch.)
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 8:53 AM Changeset in webkit [90635] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: NetworkPanel search failed if the matched sting is in the query part of url
https://bugs.webkit.org/show_bug.cgi?id=64167
Reviewed by Yury Semikhatsky.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._matchResource):
(WebInspector.NetworkPanel.prototype._highlightNthMatchedResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get folder):
- 8:50 AM Changeset in webkit [90634] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Enable HTTP Pipelining by default
https://bugs.webkit.org/show_bug.cgi?id=64169
Reviewed by Andreas Kling.
QNetworkAccessManager disables HTTP pipelining by default. We enable it by
setting an attribute on the request.
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
- 8:46 AM Changeset in webkit [90633] by
-
- 3 edits in trunk/LayoutTests
[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168
Unreviewed gardening.
The cause of the crash revealed itself as a side effect thus
it is better to expect the test to CRASH rather than skipping it.
- platform/qt/Skipped: Unskip test.
- platform/qt/test_expectations.txt: Mark as CRASH
- 8:22 AM Changeset in webkit [90632] by
-
- 2 edits in trunk/Tools
Ensure commit-log-editor adds a "Patch by" line when the author and committer are different
Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
by" line. But some patches (like rollout patches) don't contain that line. Now we always add
"Patch by" to the commit log regardless of the ChangeLog's contents.
Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
should have been abarth@webkit.org
Reviewed by Anders Carlsson.
- Scripts/commit-log-editor:
(createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
before. If there is no "Reviewed by" line, try to put it just above the first modified file.
If all else fails, put it at the end of the commit message.
(patchAuthorshipString): Added. Code came from createCommitMessage.
- 7:58 AM Changeset in webkit [90631] by
-
- 2 edits in trunk/LayoutTests
[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168
Unreviewed gardening.
- platform/qt/Skipped: Skip the test.
- 7:51 AM Changeset in webkit [90630] by
-
- 5 edits in trunk
Web Inspector: CSS inspector gets confused about specificity of !important properties
https://bugs.webkit.org/show_bug.cgi?id=64074
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
LayoutTests:
- inspector/elements/elements-panel-styles-expected.txt:
- inspector/elements/resources/elements-panel-styles.css:
(#container .foo):
(.foo):
- 7:42 AM Changeset in webkit [90629] by
-
- 7 edits in trunk/Source
[WK2] Do not forward touch events to the web process when it does not need them
https://bugs.webkit.org/show_bug.cgi?id=64164
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
Add a convenience function to obtain a reference to the last element of a Deque.
- wtf/Deque.h:
(WTF::Deque::last):
Source/WebKit2:
The call to ChromeClient::needTouchEvent() is now forwarded to the WebPageProxy
to change the way events are delivered.
When the WebPage does not need touch events, and there is no queued touch events,
the incoming events just bounce back through PageClient::doneWithTouchEvent().
In the case when new events come to WebPageProxy and there are still touch events
incoming from the WebProcess, the new events are deferred with the corresponding
pending touch events.
Deferring the new events iafter the corresponding forwarded event ensure
the delivery is always done in order when PageClient::doneWithTouchEvent()
is called.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::needTouchEvents):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
(WebKit::QueuedTouchEvents:::forwardedEvent):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::needTouchEvents):
- 7:34 AM Changeset in webkit [90628] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed, clang build fix.
- inspector/InspectorStyleTextEditor.h:
- 6:51 AM TestExpectations edited by
- A few small formatting tweaks, and replaced the Contents section with … (diff)
- 6:44 AM NewRunWebKitTests edited by
- Just a few formatting tweaks, and replaced the Contents section with … (diff)
- 6:42 AM Changeset in webkit [90627] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
https://bugs.webkit.org/show_bug.cgi?id=64159
Rework the icon-uri change test so that the condition for quitting
the mainloop is the icon-uri change itself, along with a timeout
to avoid taking too long in case of failure. Since the conditions
for considering a page loaded were changed we can't rely on that
for this test anymore.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-07-08
Reviewed by Xan Lopez.
- tests/testwebview.c:
(timeout_cb): error out if it takes too long for the icon-uri
change to happen.
(icon_uri_changed_cb): quit the loop here instead of waiting on
the page being loaded.
(test_webkit_web_view_icon_uri):
- 6:25 AM Changeset in webkit [90626] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add support for drag'n'drop of non-elements (comments, text, etc.)
https://bugs.webkit.org/show_bug.cgi?id=64163
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::moveTo):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):
- 6:21 AM Changeset in webkit [90625] by
-
- 6 edits in trunk
2011-07-08 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080
Reviewed by Pavel Feldman.
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):
2011-07-08 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080
Reviewed by Pavel Feldman.
- inspector/extensions/extensions.html: add explicit base paths to extension resource being loaded.
- 6:19 AM Changeset in webkit [90624] by
-
- 2 edits in trunk/Tools
Reviewed by Andreas Kling.
Adding myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 5:55 AM Changeset in webkit [90623] by
-
- 2 edits in trunk/LayoutTests
Add BUG modifier which was accidentally removed in the previous commit
Unreviewed.
- platform/qt/test_expectations.txt:
- 5:29 AM Changeset in webkit [90622] by
-
- 2 edits in trunk/LayoutTests
[Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002
Unreviewed gardening.
- platform/qt/test_expectations.txt: Skip fast/forms/textfield-overflow-by-value-update.html
because it sometimes does not produce any output.
- 4:56 AM Changeset in webkit [90621] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r90615.
http://trac.webkit.org/changeset/90615
https://bugs.webkit.org/show_bug.cgi?id=64158
broke inspector/extensions/extensions.html (Requested by caseq
on #webkit).
- inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
- 4:53 AM Changeset in webkit [90620] by
-
- 2 edits in trunk/LayoutTests
Rebaseline expected file after r90567
Unreviewed.
- inspector/styles/styles-url-linkify-expected.txt:
- 4:32 AM Changeset in webkit [90619] by
-
- 14 edits4 adds in trunk
Web Inspector: Adding CSS properties results in messy style rules
https://bugs.webkit.org/show_bug.cgi?id=63622
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/styles-formatting.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPropertySourceData.cpp:
(WebCore::SourceRange::length):
- css/CSSPropertySourceData.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyle::applyStyleText):
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
- inspector/InspectorStyleSheet.h:
- inspector/InspectorStyleTextEditor.cpp: Added.
(WebCore::InspectorStyleTextEditor::InspectorStyleTextEditor):
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::replaceProperty):
(WebCore::InspectorStyleTextEditor::removeProperty):
(WebCore::InspectorStyleTextEditor::enableProperty):
(WebCore::InspectorStyleTextEditor::disableProperty):
(WebCore::InspectorStyleTextEditor::disabledIndexByOrdinal):
(WebCore::InspectorStyleTextEditor::shiftDisabledProperties):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):
- inspector/InspectorStyleTextEditor.h: Added.
(WebCore::InspectorStyleTextEditor::styleText):
LayoutTests:
- inspector/styles/styles-formatting-expected.txt: Added.
- inspector/styles/styles-formatting.html: Added.
- inspector/styles/styles-new-API-expected.txt:
- inspector/styles/styles-new-API.html:
- 4:25 AM Changeset in webkit [90618] by
-
- 9 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Add basic support for panning gestures to the QTouchWebView
https://bugs.webkit.org/show_bug.cgi?id=64105
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-08
Reviewed by Kenneth Rohde Christiansen.
This patch adds basic support for the panning gesture on the UI process side.
The events coming back from the WebProcess are processed through
the QtPanGestureRecognizer to recognize the pan gesture. When the
gesture is recognized, the actions are performed on the view through
the TouchViewInterface.
Currently, the viewport just move the page around without limit.
This will be improved when a physics engine is integrated.
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scroll):
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qtouchwebview_p.h:
- UIProcess/qt/QtPanGestureRecognizer.cpp: Added.
(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
(WebKit::QtPanGestureRecognizer::reset):
- UIProcess/qt/QtPanGestureRecognizer.h: Added.
- UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::panGestureStarted):
(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::panGestureEnded):
(WebKit::TouchViewInterface::panGestureCancelled):
- UIProcess/qt/TouchViewInterface.h:
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
(QTouchWebPageProxy::processDidCrash):
(QTouchWebPageProxy::doneWithTouchEvent):
- UIProcess/qt/qtouchwebpageproxy.h:
- WebKit2.pro:
- 4:16 AM Changeset in webkit [90617] by
-
- 5 edits in trunk
Web Inspector: Quotes are rendered as " in the DOM tree
https://bugs.webkit.org/show_bug.cgi?id=64154
Reviewed by Yury Semikhatsky.
Source/WebCore:
Since we currently rely on setting textContent rather than innerHTML for the DOM tree elements,
escapeHTML() calls unnecessarily HTML-escape certain characters in the DOM tree contents.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
():
LayoutTests:
- inspector/elements/elements-panel-structure-expected.txt:
- inspector/elements/elements-panel-structure.html:
- 4:03 AM Changeset in webkit [90616] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unused code from InspectorAgent.h.
https://bugs.webkit.org/show_bug.cgi?id=64120
Reviewed by Joseph Pecoraro.
- inspector/InspectorAgent.h:
- 3:39 AM Changeset in webkit [90615] by
-
- 4 edits in trunk/Source/WebCore
2011-07-08 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080
Reviewed by Pavel Feldman.
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):
- 3:12 AM Changeset in webkit [90614] by
-
- 3 edits3 adds in trunk
Web Inspector: typing undefined = 1 in console crashes browser
https://bugs.webkit.org/show_bug.cgi?id=64155
Source/WebCore:
Do not access undefined value directly when producing JSON objects as undefined
may be overriden by the inspected page.
Reviewed by Pavel Feldman.
Test: inspector/console/console-eval-undefined-override.html
- inspector/InjectedScriptSource.js:
(.):
():
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/console/console-eval-undefined-override-expected.txt: Added.
- inspector/console/console-eval-undefined-override.html: Added.
- platform/chromium/inspector/console/console-eval-undefined-override-expected.txt: Added.
- 1:37 AM Changeset in webkit [90613] by
-
- 1 edit1 move in trunk/LayoutTests
2011-07-08 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Moving test expectation from platform-specific to generic.
- fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt.
