Timeline

Jul 16, 2011:

10:40 PM Changeset in webkit [91165] by cevans@google.com

• 1 edit
  3 copies in branches/chromium/782

Merge 91152
BUG=89520
Review URL: ​http://codereview.chromium.org/7395022

10:04 PM Changeset in webkit [91164] by barraclough@apple.com

• 9 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=64657
Converted this value not preserved when accessed via direct eval.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Upon entry into a non-strict function, primitive this values should be boxed as Object types
(or substituted with the global object) - which is done by op_convert_this. However we only
do so where this is used lexically within the function (we omit the conversion op if not).
The problem comes if a direct eval (running within the function's scope) accesses the this
value.

We are safe in the case of a single eval, since the this object will be converted within
callEval, however the converted value is not preserved, and a new wrapper object is allocated
each time eval is invoked. This is inefficient and incorrect, since any changes to the wrapper
object will be lost between eval statements.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• If a function uses eval, we always need to convert this.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• Don't convert primitive values here - this is too late!

(JSC::Interpreter::privateExecute):

• Changed op_convert_this to call new isPrimitive method.

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• Changed op_convert_this to call new isPrimitive method.

• runtime/JSCell.h:

(JSC::JSCell::JSValue::isPrimitive):

• Added JSValue::isPrimitive.

• runtime/JSValue.h:
  • Added JSValue::isPrimitive.

LayoutTests:

Added test case.

• fast/js/read-modify-eval-expected.txt:
• fast/js/script-tests/read-modify-eval.js:

(primitiveThisTest):

9:56 PM Changeset in webkit [91163] by dbates@webkit.org

• 3 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Fix Win Cairo Debug build after <​http://trac.webkit.org/changeset/91085>.

Add stub implementation of scale factor overloaded ShareableBitmap::paint() for
Cairo WebKit2 port after its usage in changeset <​http://trac.webkit.org/changeset/91085>.

Also add stub implementation for GTK.

We'll need to actually implement this. See <​https://bugs.webkit.org/show_bug.cgi?id=64664>
and <​https://bugs.webkit.org/show_bug.cgi?id=64665> for Cairo and GTK, respectively.

• Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
• Shared/gtk/ShareableBitmapGtk.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.

9:21 PM Changeset in webkit [91162] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Fix Qt Linux Release build after changeset <​http://trac.webkit.org/changeset/91085>
(​https://bugs.webkit.org/show_bug.cgi?id=64611).

Stub out scale factor-variant implementation of ShareableBitmap::paint().
We'll need to implement this. See <​https://bugs.webkit.org/show_bug.cgi?id=64663>
for more details.

• Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.

7:34 PM Changeset in webkit [91161] by Simon Fraser

• 16 edits in trunk/Source

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Implemented a new behavior on GraphicsLayerCA which attempts to keep layers pixel
aligned as page scale changes.

This requires denoting which layer has the page scale on it (it is assumed to be
already aligned), via setAppliesPageScale(). We also now pass a scale and offset
down through the GraphicsLayer commits, which are used to map layer bounds to display
coordinates for rounding.

• platform/graphics/GraphicsLayer.h: New flags and getters/setters for pixel alignment, and the layer that is the applier of the scale. (WebCore::GraphicsLayer::setMaintainsPixelAlignment): (WebCore::GraphicsLayer::maintainsPixelAlignment): (WebCore::GraphicsLayer::setAppliesPageScale): (WebCore::GraphicsLayer::appliesPageScale):

• platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Initialize the new flags. (WebCore::GraphicsLayer::backingScaleFactor): Utility method that calls the client if there is one. (WebCore::GraphicsLayer::pageScaleFactor): Ditto.

• platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::backingScaleFactor): Provide default implementation. (WebCore::GraphicsLayerClient::pageScaleFactor): Ditto.

• platform/graphics/ca/GraphicsLayerCA.h: Pass scale and base-relative offset around to methods that need to update geometry during commit. Some new methods related to pixel alignment.

• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::computePositionRelativeToBase): For single-layer commits, we have to compute the base-relative offset, and whether we're under the layer applying the scale by walking up the tree.

(WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly): Call
computePositionRelativeToBase() to get scaling parameters for the target layer.

(WebCore::GraphicsLayerCA::recursiveCommitChanges): Pass flags related to scaling.
positionRelativeToBase is an offset relative to the ancestor layer known to be pixel
aligned. affectedByPageScale is true for layers which are descendants of the layer
which applies the scale.

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Pass scale and offset.
(WebCore::GraphicsLayerCA::updateGeometry): Call computePixelAlignment() to get
pixel-aligned geometry. This only needs to be applied to layers which render content,
so re-organize the code to use the unchanged layer geometry for the structural layer,
but to apply the adjusted geometry to the m_layer.

(WebCore::GraphicsLayerCA::updateStructuralLayer): Pass scale and offset.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Ditto.
(WebCore::GraphicsLayerCA::updateLayerDrawsContent): Ditto.
(WebCore::GraphicsLayerCA::updateContentsScale): Ditto.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::setKeepPixelAligned): When set, dirties flags
for properties that need to be recomputed.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
(WebCore::isIntegral):
(WebCore::GraphicsLayerCA::computePixelAlignment): Map our bounds to screen
scale, round out to an integral rect, then map it back, adding a fudge factor
so that CA backing stores don't end up being smaller than we expect because
of integer truncation.

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Turn on pixel alignment if the compositor says so. (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Set the RenderView's layer as the one applying the scale, for the main frame.

• rendering/RenderLayerCompositor.h: New method.
• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::keepLayersPixelAligned): Master switch for pixel alignment. Default to on. (WebCore::RenderLayerCompositor::ensureRootLayer): Give the two root-ish layers a client so they can ask for page scale if necessary.

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementation of pageScaleFactor() now that GraphicsLayerClient has
a default implementation.

• WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
• WebProcess/WebPage/ca/LayerTreeHostCA.h:

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

• WebView.h:

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

• src/PageOverlay.cpp:

6:47 PM Changeset in webkit [91160] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

DFG JIT compare/branch code emits is-integer tests even when a value is
definitely not an integer.
​https://bugs.webkit.org/show_bug.cgi?id=64654

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Added the isKnownNotInteger() method, which returns true if a node is
definitely not an integer and will always fail any is-integer test. Then
modified the compare and branch code to use this method; if it returns
true then is-int tests are omitted and the compiler always emits a slow
call.

• dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

• dfg/DFGJITCodeGenerator.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):

5:46 PM Changeset in webkit [91159] by dbates@webkit.org

• 3 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Attempt to fix the Qt Linux Release build after changeset <​http://trac.webkit.org/changeset/91097>
(​https://bugs.webkit.org/show_bug.cgi?id=64615).

• UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::setCursorHiddenUntilMouseMoves): Added stub method.
• UIProcess/qt/QtWebPageProxy.h:

5:33 PM Changeset in webkit [91158] by enrica@apple.com

• 4 edits
  2 adds in trunk

REGRESSION: Pressing return in a particular document sends the cursor to the end of the document.
​https://bugs.webkit.org/show_bug.cgi?id=64140
<rdar://problem/9737491>

Source/WebCore:

Inserting a paragraph separator at a break element, inside an inline, generates redundant markup
and moves the selection at the end of the inserted block.
The fix consists in detecting that the insertion point is a break element and simply inserting another
break element. This solves the problem of the wrong final selection and also produces less redundant
markup.

Reviewed by Simon Fraser.

Test: editing/inserting/insert-paragraph-separator-at-break.html

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Modified logic for insertion at a break
element.

LayoutTests:

Added new test to cover this case and updated results for one test that now
produces simpler markup.

Reviewed by Simon Fraser.

• editing/inserting/insert-paragraph-separator-at-break-expected.txt: Added.
• editing/inserting/insert-paragraph-separator-at-break.html: Added.
• platform/mac/editing/inserting/5058163-1-expected.txt:

4:29 PM Changeset in webkit [91157] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

SubresourceLoader::didReceiveDataArray can crash when calling m_client->didReceiveData()
​https://bugs.webkit.org/show_bug.cgi?id=64656
<rdar://problem/9754425>

Reviewed by Alexey Proskuryakov.

• loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray): Check for m_client before calling
m_client->didReceiveData().

4:14 PM Changeset in webkit [91156] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

DFG speculative JIT has dead code for slow calls for branches.
​https://bugs.webkit.org/show_bug.cgi?id=64653

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Removed SpeculativeJIT::compilePeepHoleCall.

• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT.h:

4:01 PM Changeset in webkit [91155] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Qt] Compilation fails on disabling TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=64408

Fix compilation error due to API name change in GraphicsLayer

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2011-07-16
Reviewed by Noam Rosenthal.

• platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQt::setContentsToBackgroundColor):

• platform/graphics/qt/GraphicsLayerQt.h:

3:59 PM Changeset in webkit [91154] by psolanki@apple.com

• 13 edits in trunk

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

New WebKitSystemInterface functions for CFNetwork-based loader.

../../git/opensource/WebKit.git/Source/WebCore:

• WebCore.exp.in:
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

../../git/opensource/WebKit.git/Source/WebKit/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/Source/WebKit2:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/WebKitLibraries:

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceSnowLeopard.a:

3:39 PM Changeset in webkit [91153] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
​https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <​jberlin@apple.com> on 2011-07-16
Reviewed by Darin Adler.

No loads should be going on for a DocumentLoader that has been detached from its frame, but
that appears to be what is happening in this bug.

Add assertions with the hope that someone will run into this while debugging and thereby find
a reproducible case.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

1:12 PM Changeset in webkit [91152] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

DOMWindow::open performs a security check on a wrong window
​https://bugs.webkit.org/show_bug.cgi?id=64651

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-07-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-window-open-parent.html

• page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

LayoutTests:

• http/tests/security/resources/xss-DENIED-window-open-parent-attacker.html: Added.
• http/tests/security/xss-DENIED-window-open-parent-expected.txt: Added.
• http/tests/security/xss-DENIED-window-open-parent.html: Added.

12:07 PM Changeset in webkit [91151] by weinig@apple.com

• 103 edits in trunk

Attribute selectors don't handle glob namespaces (e.g. *|E)
​https://bugs.webkit.org/show_bug.cgi?id=64567

Reviewed by Anders Carlsson.

Source/WebCore:

Change checking of attribute selectors to match CSS 3 Selectors in
the presence of namespaces. This entails changing the algorithm to
check each attribute on an element as a match for the attribute selector
and taking into account a prefix of *.

• css/CSSStyleSelector.cpp:

(WebCore::attributeQualifiedNameMatches):
Checks if the a particular attributes qualified name matches
the attribute selector, taking into account a prefix of *.

(WebCore::attributeValueMatches):
Checks if a particular attribute on an element, matches
the attribute selector.

(WebCore::anyAttributeMatches):
Top level attribute check. Checks if any of an elements attributes
match the attribute selector.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Factor out attribute checking code into the above functions.

LayoutTests:

Update results for correct handling of a * prefix in an attribute selector.
Fixes 50 tests.

• platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt:
• platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.png:
• platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-104-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-104-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-105-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-105-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-106-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-106-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-107-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-107-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-108-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-108-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-109-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-109-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-110-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-110-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-130-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-130-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-131-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-131-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-132-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-132-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-133-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-133-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-134-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-134-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-135-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-135-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-136-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-136-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt:
• platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.png:
• platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt:

12:06 PM Changeset in webkit [91150] by cevans@google.com

• 3 edits
  2 copies in branches/chromium/782

Merge 91005
BUG=88730
Review URL: ​http://codereview.chromium.org/7396010

5:37 AM Changeset in webkit [91149] by jhoneycutt@apple.com

• 2 edits in trunk/Source/WebCore

WinCE build fix. Unreviewed.

• dom/SelectElement.cpp:

12:33 AM Changeset in webkit [91148] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

Patch by Kulanthaivel Palanichamy <​kulanthaivel@codeaurora.org> on 2011-07-16
Reviewed by Nikolas Zimmermann.

SVG animation API crashes on SVGAnimateTransform
​https://bugs.webkit.org/show_bug.cgi?id=64104

Source/WebCore:

This patch ensures the update in AnimatedTransform list in
SVGAnimateTransformElement.cpp is in sync with its wrapper list.

Test: svg/animations/svgtransform-animation-discrete.html

• svg/SVGAnimateTransformElement.cpp:

(WebCore::animatedTransformListFor):
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):

LayoutTests:

Added the test to cover assertion in AnimatedTransform list where its
value and wrapper length mismatch occurs.

• svg/animations/script-tests/svgtransform-animation-discrete.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/svgtransform-animation-discrete-expected.txt: Added.
• svg/animations/svgtransform-animation-discrete.html: Added.

Jul 15, 2011:

10:55 PM Changeset in webkit [91147] by Simon Fraser

• 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix the build.

• platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::updateEnabledState):

10:15 PM Changeset in webkit [91146] by commit-queue@webkit.org

• 12 edits in trunk/Source

Overlay scrollbars in overflow areas no longer pulse when revealed
​https://bugs.webkit.org/show_bug.cgi?id=64606
<rdar://problem/9390674>

Patch by Tim Horton <​timothy_horton@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

Ensure that the state of the scrollbar implementation is kept in sync
with WebCore's internal representation. Previously, we synchronized them
at paint time, causing pulsing to be skipped due to the scrollbars being
disabled.

Source/WebKit/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

9:41 PM Changeset in webkit [91145] by Simon Fraser

• 2 edits in trunk/Source/WebKit/win

2011-07-15 Simon Fraser <Simon Fraser>

Fix Windows build.

• WebView.h: (WebView::backingScaleFactor): (WebView::pageScaleFactor):

9:03 PM Changeset in webkit [91144] by abarth@webkit.org

• 7 edits in trunk/Tools

gardening server should proxy buildbot status for garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=64588

Reviewed by Eric Seidel.

This information will be used to detect build breaks. I took this
opportunity to make ChromiumBuildBot non-static.

• Scripts/webkitpy/common/host.py:
• Scripts/webkitpy/tool/commands/rebaseline.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
• Scripts/webkitpy/tool/mocktool.py:
• Scripts/webkitpy/tool/servers/gardeningserver.py:
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

7:11 PM Changeset in webkit [91143] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/782

Merge 90936
BUG=88846
Review URL: ​http://codereview.chromium.org/7390020

7:08 PM Changeset in webkit [91142] by cevans@google.com

• 2 edits
  4 copies in branches/chromium/782

Merge 90914
BUG=86705
Review URL: ​http://codereview.chromium.org/7398018

7:04 PM Changeset in webkit [91141] by cevans@google.com

• 1 edit
  6 copies in branches/chromium/782

Merge 91044
BUG=88337
Review URL: ​http://codereview.chromium.org/7401011

6:41 PM Changeset in webkit [91140] by Simon Fraser

• 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Another Windows build fix; make this method non-pure virtual.

• platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::didCommitChangesForLayer):

6:40 PM Changeset in webkit [91139] by Simon Fraser

• 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix build error in 32-bit builds.

• rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect):

6:33 PM Changeset in webkit [91138] by Simon Fraser

• 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix Windows build.

• platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::backingScaleFactor): (WebCore::MediaPlayerPrivate::pageScaleFactor):

6:30 PM Changeset in webkit [91137] by Simon Fraser

• 18 edits in trunk/Source

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

RenderLayerBacking would set the contentsScale on GraphicsLayers
on creation, and update it when the pageScaleFactor changed. However,
RenderLayerBacking doesn't really know what contentsScale is best
for a layer, so instead, have GraphicsLayers call back through the
GraphicsLayerClient to get the two relevant scale factors, and do
their own computation of contentsScale.

No testable behavior changes.

• page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): No need to pass the scale.

• platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants): Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on each layer.

• platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::pageScaleFactorChanged): Remove contentsScale/setContentsScale

• platform/graphics/GraphicsLayerClient.h: Add methods to fetch the backingScaleFactor() and pageScaleFactor().

• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges defaults to ContentsScaleChanged so we update contentsScale on the first flush.

(WebCore::GraphicsLayerCA::setContentsToBackgroundColor):
This was the wrong time to call updateContentsRect() and setupContentsLayer();
those should be done at commit time, so moved to updateLayerBackgroundColor().
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we
have any changes, and call didCommitChangesForLayer() on the client.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here.
(WebCore::clampedContentsScaleForScale): No longer has any hysteresis
on the scale, and now just clamps.
(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales
from the client, and multiply them, then clamp.
(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes
contentsScale into account when deciding to use tiled layer,
so that zooming in will cause layers to start tiling.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call
setContentsScale(), but rather updateContentsScale().
(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits
for properties that depend on the scale.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
Note that contentsScale needs to be updated. At some point we might also
need to dirty other properties.

• platform/graphics/ca/GraphicsLayerCA.h: Moved the m_allowTiledLayer bool for better packing. No need for a m_contentsScale member now.
• rendering/RenderLayer.cpp: Removed pageScaleFactorChanged().
• rendering/RenderLayer.h: Ditto.
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to push the contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::didCommitChangesForLayer): Send through to the compositor.
• rendering/RenderLayerBacking.h: GraphicsLayerClient methods.
• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::didFlushChangesForLayer): We'll use this later. (WebCore::RenderLayerCompositor::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerCompositor::pageScaleFactor): Ditto. (WebCore::RenderLayerCompositor::didCommitChangesForLayer): Ditto. (WebCore::RenderLayerCompositor::ensureRootLayer): No need to push the contents scale. (WebCore::RenderLayerCompositor::pageScaleFactorChanged): Just call notePageScaleFactorChangedIncludingDescendants() on the root GraphicsLayer.
• rendering/RenderLayerCompositor.h: Added GraphicsLayerClient methods.

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale,
and don't push the scale.

• WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): (WebKit::LayerTreeHostCA::backingScaleFactor): (WebKit::LayerTreeHostCA::pageScaleFactor): (WebKit::LayerTreeHostCA::createPageOverlayLayer):
• WebProcess/WebPage/ca/LayerTreeHostCA.h: (WebKit::LayerTreeHostCA::didCommitChangesForLayer):

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale.

• src/PageOverlay.cpp: (WebKit::OverlayGraphicsLayerClientImpl::backingScaleFactor): (WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):

6:10 PM Changeset in webkit [91136] by jchaffraix@webkit.org

• 5 edits in trunk/Tools

[NRWT] Add support for --no-http
​https://bugs.webkit.org/show_bug.cgi?id=64564

Reviewed by Dirk Pranke.

Added support for --no-http, which disables both HTTP and websockets tests.
It also matches the old-run-webkit-tests behavior if --force is used.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine
what is worth have an HTTP lock as --no-http to avoid badness.

• Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that

we do skip properly HTTP / websocket tests inside platform/.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Added tests that we properly skip all the tests.

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Added checks for the command line arguments.

5:27 PM Changeset in webkit [91135] by jhoneycutt@apple.com

• 2 edits in trunk/Source/WebCore

Build fix. Unreviewed.

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Cast size_t to int for comparison.

5:16 PM Changeset in webkit [91134] by aestes@apple.com

• 6 edits in trunk/Source

Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
​https://bugs.webkit.org/show_bug.cgi?id=64641

Reviewed by Brian Weinstein.

Source/WebCore:

• WebCore.exp.in: Update to new symbol.
• platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolarWalkMac): Renamed from applicationIsSolarWalk.

• platform/RuntimeApplicationChecks.h: Ditto.

Source/WebKit/mac:

• WebView/WebView.mm:

(needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().

5:03 PM Changeset in webkit [91133] by mrowe@apple.com

• 2 edits in trunk/Source/WebCore

Fix the build.

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextStateSaver::context): Remove a bogus type qualifier.

4:55 PM Changeset in webkit [91132] by jhoneycutt@apple.com

• 15 edits in trunk

Focus and selection events are not fired when a <select>'s selection
changes
​https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

• accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

• accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

• accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

• accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

• accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

• dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

• rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

• DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

• DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

• platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
• platform/win/accessibility/option-element-selection-and-focus-events.html: Added.

4:52 PM Changeset in webkit [91131] by mrowe@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix the build.

• dfg/DFGGraph.h:

4:52 PM Changeset in webkit [91130] by cmarrin@apple.com

• 4 edits in trunk/Source/WebCore

Fixing style issues pointed out by Simon for
​https://bugs.webkit.org/show_bug.cgi?id=64542

Unreviewed.

4:49 PM Changeset in webkit [91129] by jhoneycutt@apple.com

• 5 edits
  1 add in trunk/Source/WebCore

ALT + DOWN arrow key does not open select

​https://bugs.webkit.org/show_bug.cgi?id=14407
<rdar://problem/5319507>

Reviewed by Alexey Proskuryakov.

No test, because eventSender sends events to the WebView, rather than
the popup menu, so the popup isn't closed.

• WebCore.vcproj/WebCore.vcproj:

Add SelectElementWin.cpp to project.

• dom/SelectElement.cpp:

(WebCore::SelectElement::platformHandleKeydownEvent):
Moved ARROW_KEYS_POP_MENU code here. Updated to return whether the
function has handled the key, or whether the caller needs to process it
further.
(WebCore::SelectElement::menuListDefaultEventHandler):
Allow the platform the first chance at handling the keyboard event.

• dom/SelectElement.h:

Declare platformHandleKeydownEvent().

• dom/SelectElementWin.cpp: Added.

(WebCore::SelectElement::platformHandleKeyboardEvent):
Allow (Shift) F4 and (Ctrl/Shift) Alt/AltGr + Up/Down
arrow to show the popup. After the popup is dismissed, call
setSelectedIndex(), and report that we handled the event.

• platform/win/PopupMenuWin.cpp:

Declare HIGH_BIT_MASK_SHORT.
(WebCore::PopupMenuWin::show):
Forward WM_SYSKEYDOWN to the popup's HWND.
(WebCore::PopupMenuWin::wndProc):
Allow the same shortcuts that show the menu to hide it, matching
Firefox.

4:48 PM Changeset in webkit [91128] by jhoneycutt@apple.com

• 3 edits
  2 adds in trunk

Ensure that a single select element's child option elements are
reported correctly to accessibility clients if the children are
changed.

​https://bugs.webkit.org/show_bug.cgi?id=64500
<rdar://problem/9773066>

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/win/accessibility/single-select-children-changed.html

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):
Remove a comment about WML, which we no longer support.
(WebCore::AccessibilityMenuListPopup::childrenChanged):
Don't just remove children that were detached - this will miss childen
that were dynamically added. Clear the children and re-add them.

LayoutTests:

• platform/win/accessibility/single-select-children-changed-expected.txt: Added.
• platform/win/accessibility/single-select-children-changed.html: Added.

4:39 PM Changeset in webkit [91127] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

• DEPS:

4:17 PM Changeset in webkit [91126] by scheib@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

• platform/chromium/test_expectations.txt:

4:00 PM Changeset in webkit [91125] by rwlbuis@webkit.org

• 5 edits
  6 adds in trunk

2011-07-15 Rob Buis <​rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
​https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

• platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
• rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
• rendering/svg/RenderSVGPath.h:

3:49 PM Changeset in webkit [91124] by Dimitri Glazkov

• 2 edits in trunk/Tools

Refactor TestExpectationModel to use TestExpectationLine as data item.
​https://bugs.webkit.org/show_bug.cgi?id=64635

This is a bit largish in scope. Does the following things:

1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,

and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
needs to have any port knowledge.

2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,

and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
Now all expectations are added to the model in the same way!

3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.

3:42 PM Changeset in webkit [91123] by Adam Roben

• 4 edits in trunk/Tools

Teach TestFailures how to detect interrupted build steps

Fixes <​http://webkit.org/b/64619> TestFailures page thinks all tests passed in
​http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
build step was interrupted. Treat it as an error (by returning a failureCount of -1).

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cache data that was afflicted by the above bug.

3:40 PM Changeset in webkit [91122] by tony@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, unskip css3/selectors3 tests so we can rebaseline them.

• platform/chromium/test_expectations.txt:

3:40 PM Changeset in webkit [91121] by eric@webkit.org

• 2 edits in trunk/Tools

new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
​https://bugs.webkit.org/show_bug.cgi?id=64533

Reviewed by Adam Roben.

Blind removal of Chromium-specific code (now that Chromium does not use this file).

• Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

3:32 PM Changeset in webkit [91120] by enne@google.com

• 2 edits in trunk/LayoutTests

[chromium] Rebaseline overflow-scroll on Linux after r91114.

Unreviewed.

• platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:

3:30 PM Changeset in webkit [91119] by Adam Roben

• 2 edits in trunk/Tools

Make TestFailures's list of possibly-flaky tests not so tall

Fixes <​http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
much room

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Removed a no-longer-used .flakiness-example-separator selector.

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
Use a lot less padding for the possibly-flaky tests.

3:13 PM Changeset in webkit [91118] by tony@chromium.org

• 4 edits
  2 moves
  1 add in trunk

[chromium] land linux selection color layout test
​https://bugs.webkit.org/show_bug.cgi?id=64631

Reviewed by Ojan Vafai.

Tools:

I had removed this code in r76620 because I thought it wasn't used.
Turns out there was a layout test in the chromium tree that never
got migrated that used it. Re-add the code and land the layout
test (I will remove it from the chromium tree soon).

• DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::forceRedSelectionColors):

• DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

• platform/chromium-linux/editing/selection/linux_selection_color.html: Added.

3:10 PM Changeset in webkit [91117] by scheib@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

• platform/chromium/test_expectations.txt:

3:03 PM Changeset in webkit [91116] by barraclough@apple.com

• 5 edits
  3 adds in trunk

NativeError.prototype objects have Class of "Object" but should be "Error"
​https://bugs.webkit.org/show_bug.cgi?id=55346

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

• Switch to putDirect since we're not the only ones tranitioning this Structure now.

• runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

• runtime/NativeErrorPrototype.h:
  • Switch base class to ErrorPrototype.

LayoutTests:

Added test case.

• fast/js/native-error-prototype-expected.txt: Added.
• fast/js/native-error-prototype.html: Added.
• fast/js/script-tests/native-error-prototype.js: Added.

2:57 PM Changeset in webkit [91115] by barraclough@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG JIT - Where arguments passed are integers, speculate this.
​https://bugs.webkit.org/show_bug.cgi?id=64630

Reviewed by Sam Weinig.

Presently the DFG JIT is overly aggressively predicting double.
Use a bit of dynamic information, and curtail this a little.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

• Check for integer arguments.

• dfg/DFGGraph.h:
  • Function declaration.
• runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::FunctionExecutable::compileForCallInternal):

• Add call to predictArgumentTypes.

2:54 PM Changeset in webkit [91114] by enne@google.com

• 6 edits
  2 adds
  2 deletes in trunk

Reviewed by Simon Fraser.

Overlap map for compositing needs to consider clipping
​https://bugs.webkit.org/show_bug.cgi?id=63493

Source/WebCore:

Test: compositing/layer-creation/overlap-clipping.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Added new test. limit-layer-bounds-clipping-ancestor had changed
behavior because some layers no longer needed to become composited.
Adjusted that test to be less platform-specific as well.

• compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
• compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
• compositing/layer-creation/overlap-clipping-expected.txt: Added.
• compositing/layer-creation/overlap-clipping.html: Added.
• platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
• platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.

2:24 PM Changeset in webkit [91113] by commit-queue@webkit.org

• 2 edits
  1 delete in trunk/Source/WebCore

Unreviewed, rolling out r90592.
​http://trac.webkit.org/changeset/90592
​https://bugs.webkit.org/show_bug.cgi?id=64627

Causes crashes with the web audio async decoding API
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

• html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

• manual-tests/array-buffer-memory.html: Removed.

2:22 PM Changeset in webkit [91112] by kbr@google.com

• 11 edits in trunk

Don't restore WebGL context if it was guilty of a graphics reset
​https://bugs.webkit.org/show_bug.cgi?id=64497

Reviewed by Stephen White.

Source/WebCore:

Use getGraphicsResetStatusARB already defined in Extensions3D to
determine why the context was lost, and respond to guilty context
notifications by forbidding restoration of the context.

It isn't currently possible to write an automated test for this.
We might consider extending the WEBKIT_lose_context extension to
allow a reason to be provided why the context was lost. It was
tested manually in Chromium on Windows and Linux with some test
cases that provoke actual graphics card resets.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

• html/canvas/WebGLRenderingContext.h:

Source/WebKit/chromium:

Actually implement getGraphicsResetStatusARB rather than inferring
the status based on whether the context has been lost.

• public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):

• src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):

• src/GraphicsContext3DChromium.cpp:
• src/GraphicsContext3DInternal.h:

LayoutTests:

Updated expectations for context-lost test and added comment about
the order of event delivery. Per the specification of the
WEBKIT_lose_context extension, the previous expectations were wrong.

• fast/canvas/webgl/context-lost-expected.txt:
• fast/canvas/webgl/context-lost.html:

2:17 PM Changeset in webkit [91111] by Lucas Forschler

• 5 edits in branches/safari-534.51-branch/Source

Update Versioning.

2:17 PM Changeset in webkit [91110] by cmarrin@apple.com

• 10 edits
  2 copies
  2 moves in trunk/Source/WebCore

Move TransformState to platform/graphics and give it the option to transform just a FloatQuad
​https://bugs.webkit.org/show_bug.cgi?id=64542

Reviewed by Simon Fraser.

This is to make it possible to use TransformState in some GraphicsLayer work. HitTestingTransformState
was split out and left in rendering since it's not needed in the platform code. Also added a FIXME
because HitTestingTransformState should eventually be replaced by TransformState.

2:07 PM Changeset in webkit [91109] by Lucas Forschler

• 1 copy in branches/safari-534.51-branch

New branch.

2:00 PM Changeset in webkit [91108] by adachan@apple.com

• 5 edits in trunk/Source/WebKit2

Implement "Jump to Selection" in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=64569

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm:

(-[WKView centerSelectionInVisibleArea:]): Call WebPageProxy::centerSelectionInVisibleArea().
(-[WKView validateUserInterfaceItem:]): Enable the centerSelectionInVisibleArea: selector if there's a selection
range or if there's an insertion point in an editable area.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::showFindIndicatorInSelection): Call updateFindIndicator() to show the find indicator.

• WebProcess/WebPage/FindController.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea): Use the selection in the focused or main frame.
After scrolling the selection into view, flash the find indicator.

1:54 PM Changeset in webkit [91107] by mitz@apple.com

• 3 edits in trunk/Source/WebKit/chromium

Chromium build fix.

• src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::setCursorHiddenUntilMouseMoves):

• src/WebPopupMenuImpl.h:

1:49 PM Changeset in webkit [91106] by Dimitri Glazkov

• 2 edits in trunk/Tools

Revert ​http://trac.webkit.org/changeset/91091, since Python 2.5
does not support enumerate() start argument.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.

1:49 PM Changeset in webkit [91105] by enne@google.com

• 2 edits in trunk/LayoutTests

[chromium] Re-mark tests as failing as a result of r91069
​https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

senorblanco checked in baselines, but these tests appear to still be failing.

• platform/chromium/test_expectations.txt:

1:41 PM Changeset in webkit [91104] by weinig@apple.com

• 4 edits
  2596 adds in trunk/LayoutTests

Reviewed by Simon Fraser.

We should import the CSS 3 Selectors test suite
​https://bugs.webkit.org/show_bug.cgi?id=64610

Add dump of the CSS 3 Selectors test suite from ​http://www.w3.org/Style/CSS/Test/CSS3/Selectors/current/.
Add standalone versions of the html, xhtml and xml suites.

• css3/selectors3: Added.
• css3/selectors3/html: Added.
• css3/selectors3/xhtml: Added.
• css3/selectors3/xml: Added.
• platform/mac/css3/selectors3: Added.
• platform/mac/css3/selectors3/html: Added.
• platform/mac/css3/selectors3/xhtml: Added.
• platform/mac/css3/selectors3/xml: Added.

[Individual tests elided]

• platform/gtk/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

Added css3/selectors3 pending results.

1:41 PM Changeset in webkit [91103] by Dimitri Glazkov

• 4 edits in trunk/Tools

Clean up test_expectations.py after refactorings.
​https://bugs.webkit.org/show_bug.cgi?id=64620

• Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with its sub-part, the actual expectation.
• Renamed all references to options to modifier to eliminate dual terminology.
• Made a bunch of parser constants and changed all callsites to use them.
• Various other minor clean-ups.

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
• Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.

1:35 PM Changeset in webkit [91102] by psolanki@apple.com

• 5 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Minor changes needed to keep the compiler happy.

No new tests because no change in functionality.

• platform/network/cf/FormDataStreamCFNet.cpp:
• platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCopy):

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::WebCoreSynchronousLoaderClient::willSendRequest):

• platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::toTimeT):

1:22 PM Changeset in webkit [91101] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

• platform/chromium/test_expectations.txt:

1:17 PM Changeset in webkit [91100] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Windows build fix.

• UIProcess/win/WebView.cpp:

1:14 PM Changeset in webkit [91099] by commit-queue@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches.
​https://bugs.webkit.org/show_bug.cgi?id=64573

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-15
Reviewed by Gavin Barraclough.

This patch moves some of NonSpeculativeJIT's functionality up into the
JITCodeGenerator superclass so that it can be used from both JITs. Now,
in cases where the speculative JIT doesn't want to speculate but still
wants to emit good code, it can reliably emit the same code sequence as
the non-speculative JIT. This patch also extends the non-speculative
JIT's compare optimizations to include compare/branch fusing, and
extends the speculative JIT's compare optimizations to cover StrictEqual.

• dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::detectPeepHoleBranch):

• dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

• dfg/DFGNonSpeculativeJIT.h:
• dfg/DFGOperations.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT.h:
• wtf/Platform.h:

1:10 PM Changeset in webkit [91098] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Windows build fix.

• UIProcess/win/WebView.h:

1:03 PM Changeset in webkit [91097] by mitz@apple.com

• 46 edits in trunk/Source

REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
​https://bugs.webkit.org/show_bug.cgi?id=64615

Reviewed by Anders Carlsson.

Source/WebCore:

• html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
entering full screen.
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
hiding the HUD.

• loader/EmptyClients.h:

(WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.

• page/Chrome.cpp:

(WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.

• page/Chrome.h:
• page/ChromeClient.h:
• platform/HostWindow.h:

Source/WebKit/chromium:

• src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

• src/ChromeClientImpl.h:

Source/WebKit/efl:

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.

• WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

• WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

• WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.

• WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
+[NSCursor setHiddenUntilMouseMoves:].

Source/WebKit/qt:

• WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit/win:

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

• WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

• WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.

• WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

• WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit2:

• UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

• UIProcess/API/efl/PageClientImpl.h:
• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.

• UIProcess/API/gtk/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
• UIProcess/win/WebView.cpp:

(WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
to the page proxy.

• WebProcess/WebCoreSupport/WebChromeClient.h:

12:59 PM Changeset in webkit [91096] by scheib@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

• platform/chromium/test_expectations.txt:

12:51 PM Changeset in webkit [91095] by barraclough@apple.com

• 48 edits
  2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=64250
Global strict mode function leaking global object as "this".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The root problem here is that we pass the wrong values into
calls, and then try to fix them up in the callee. Correct
behaviour per the spec is to pass in the value undefined,
as this unless either (1) the function call is based on an
explicit property access or (2) the base of the call comes
directly from a 'with'.

This change does away with the need for this conversion of
objects (non strict code should only box primitives), and
does away with all this conversion for strict functions.

This patch may have web compatibility ramifications, and may
require some advocacy.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

• Removed op_convert_this_strict, added op_resolve_with_this.

• bytecode/Opcode.h:
  • Removed op_convert_this_strict, added op_resolve_with_this.
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitResolveWithThis):

• Removed op_convert_this_strict, added op_resolve_with_this.

• bytecompiler/BytecodeGenerator.h:
  • Removed op_convert_this_strict, added op_resolve_with_this.
• bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):

• Removed op_convert_this_strict, added op_resolve_with_this.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).

• interpreter/Interpreter.cpp:

(JSC::Interpreter::resolveThisAndProperty):

• Based on resolveBaseAndProperty, but produce correct this value.

(JSC::Interpreter::privateExecute):

• Removed op_convert_this_strict, added op_resolve_with_this.

• interpreter/Interpreter.h:
• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• Removed op_convert_this_strict, added op_resolve_with_this.

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_with_this):

• Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

• Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_with_this):

• Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

• Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• Removed op_convert_this_strict, added op_resolve_with_this.

• jit/JITStubs.h:
  • Removed op_convert_this_strict, added op_resolve_with_this.
• runtime/JSActivation.h:
  • removed NeedsThisConversion flag, added IsEnvironmentRecord.
• runtime/JSStaticScopeObject.h:
  • removed NeedsThisConversion flag, added IsEnvironmentRecord.
• runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

• removed NeedsThisConversion.

• runtime/JSTypeInfo.h:

(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):

• removed NeedsThisConversion flag, added IsEnvironmentRecord.

• runtime/JSValue.h:
  • removed NeedsThisConversion.
• runtime/JSVariableObject.h:
  • Corrected StructureFlags inheritance.
• runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

• Added IsEnvironmentRecord to StructureFlags, addded createStructure.

• runtime/Structure.h:
  • removed NeedsThisConversion.
• tests/mozilla/ecma/String/15.5.4.6-2.js:

(getTestCases):

• Removed invalid test case.

Source/WebCore:

• bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit/mac:

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

• Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit2:

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

• Change call to pass DOM Window shell, instead of the global varaible object.

LayoutTests:

Add test case / update test results.

• fast/js/call-base-resolution-expected.txt: Added.
• fast/js/call-base-resolution.html: Added.
  • Add test for ES5 correct this value resolution in calls.
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
  • Check in failing results for these tests - these tests were asserting incorrect behaviour, and have since been fixed in test-262, see ​https://bugs.ecmascript.org/show_bug.cgi?id=117

12:46 PM Changeset in webkit [91094] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r91082, r91087, and r91089.
​http://trac.webkit.org/changeset/91082
​http://trac.webkit.org/changeset/91087
​http://trac.webkit.org/changeset/91089
​https://bugs.webkit.org/show_bug.cgi?id=64616

gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

• wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):

• wtf/ThreadIdentifierDataPthreads.h:
• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

12:44 PM Changeset in webkit [91093] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
​https://bugs.webkit.org/show_bug.cgi?id=64612

Patch by Brian Salomon <​bsalomon@google.com> on 2011-07-15
Reviewed by Stephen White.

Tested by compositing/shadows/shadow-drawing.html

• platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):

12:33 PM Changeset in webkit [91092] by Dimitri Glazkov

• 3 edits in trunk/Tools

Move expectation parsing code to TestExpectationParser.
​https://bugs.webkit.org/show_bug.cgi?id=64605

This is a somewhat mechanical move, with two interesting bits:

1) TestExpectationParser.parse methods renamed to tokenize, to better
reflect what they do

2) TestExpectationLine now carries all of its info, from tokens to parsed data,
and even the list of tests that it matches (a line may refer to more than one test).

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods

to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
to "tokenize", changed callsites to use new code.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.

12:29 PM Changeset in webkit [91091] by Dimitri Glazkov

• 2 edits in trunk/Tools

Switch to use Python enumerate function to enumerate line numbers.
​https://bugs.webkit.org/show_bug.cgi?id=64602

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.

12:27 PM Changeset in webkit [91090] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Avoid rounded rect corner-drawing overhead if no corners are visible
​https://bugs.webkit.org/show_bug.cgi?id=64584

Patch by Ian Henderson <​ianh@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

No new tests, rendering is visually identical.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations): Pass PaintInfo into
paintBorder.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

• rendering/RenderBoxModelObject.cpp:

(WebCore::unroundClippedCorners):
(WebCore::RenderBoxModelObject::paintBorder):
Any invisible corner may be replaced with a corner of radius zero, as
long as the stroke style is solid. Change the GraphicsContext
parameter into a PaintInfo parameter so we can get the rect to be
drawn.

• rendering/RenderBoxModelObject.h:
• rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
paintBorder.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

12:23 PM Changeset in webkit [91089] by levin@chromium.org

• 2 edits in trunk/Source/JavaScriptCore

Another attempted build fix.

• wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:16 PM Changeset in webkit [91088] by jeffm@apple.com

• 2 edits in trunk/Source/WebCore

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
​https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

• WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.

12:15 PM Changeset in webkit [91087] by levin@chromium.org

• 2 edits in trunk/Source/JavaScriptCore

Chromium build fix.

• wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:14 PM Changeset in webkit [91086] by senorblanco@chromium.org

• 3 edits in trunk/LayoutTests

Unreviewed. Yet more chromium test baselines.

Somehow I messed these up in my mass-rebaselining.

• platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
• platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:

12:10 PM Changeset in webkit [91085] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Find indicator should take scale factor into account
​https://bugs.webkit.org/show_bug.cgi?id=64611
<rdar://problem/9761020>

Reviewed by Sam Weinig.

• UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
Keep track of the scale factor of the find indicator bitmap.

(WebKit::FindIndicator::draw):
Pass the scale factor to ShareableBitmap::draw.

• UIProcess/FindIndicator.h:

Add scale factor member variable.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
This now takes the content image scale factor.

• UIProcess/WebPageProxy.messages.in:

Add the scale factor.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Size the backing store correctly, and apply the scale factor to
the graphics context.

(WebKit::FindController::hideFindIndicator):
Pass the scale factor along.

11:52 AM Changeset in webkit [91084] by psolanki@apple.com

• 4 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

No new tests because no change in functionality and option is not enabled on Mac.

• platform/network/cf/AuthenticationCF.h: Just use AuthenticationMac.h instead of having

Mac-specific declarations here.

• platform/network/cf/CredentialStorageCFNet.cpp:
• platform/network/mac/AuthenticationMac.h:

11:51 AM Changeset in webkit [91083] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations update.

Remove some now-passing tests from chromium's text_expectations.

• platform/chromium/test_expectations.txt:

11:49 AM Changeset in webkit [91082] by levin@chromium.org

• 4 edits in trunk/Source/JavaScriptCore

currentThread is too slow!
​https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

• wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

• wtf/ThreadIdentifierDataPthreads.h:
• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

11:38 AM Changeset in webkit [91081] by psolanki@apple.com

• 3 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get LoaderRunLoop to work on Mac when USE(CFNETWORK) is enabled. Although we could use the
main run loop, it's better to have a separate thread handling the loads so that it can work
in parallel to the main thread. This is similar to what NSURLConnection does for us
internally when we use the NS APIs.

No new tests because no change in functionality and option is not enabled on Mac.

• platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread): Create an autorelease pool for objc code that might be called in
the run loop.
(WebCore::loaderRunLoop):

• platform/network/cf/LoaderRunLoopCF.h:

11:34 AM Changeset in webkit [91080] by senorblanco@chromium.org

• 207 edits
  55 adds
  7 deletes in trunk/LayoutTests

Unreviewed. New chromium test baselines after r91069.

• platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
• platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
• platform/chromium-win-vista/fast/block: Added.
• platform/chromium-win-vista/fast/block/positioning: Added.
• platform/chromium-win-vista/fast/block/positioning/auto: Added.
• platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr: Added.
• platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
• platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl: Added.
• platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
• platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png: Added.
• platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png:
• platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Added.
• platform/chromium-win-vista/fast/text/stroking-expected.png: Added.
• platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
• platform/chromium-win-vista/svg/W3C-I18N: Added.
• platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
• platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
• platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
• platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: Removed.
• platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
• platform/chromium-win-vista/svg/zoom/text: Added.
• platform/chromium-win-vista/svg/zoom/text/zoom-foreignObject-expected.png: Added.
• platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
• platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
• platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png:
• platform/chromium-win-xp/fast/blockflow/japanese-lr-text-expected.png: Added.
• platform/chromium-win-xp/fast/blockflow/japanese-rl-text-expected.png: Added.
• platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
• platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
• platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png:
• platform/chromium-win-xp/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
• platform/chromium-win-xp/fast/dynamic: Added.
• platform/chromium-win-xp/fast/dynamic/text-combine-expected.png: Added.
• platform/chromium-win-xp/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
• platform/chromium-win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
• platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
• platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
• platform/chromium-win-xp/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
• platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
• platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
• platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
• platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
• platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
• platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
• platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
• platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png:
• platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png:
• platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png:
• platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
• platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
• platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
• platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
• platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
• platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
• platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
• platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
• platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
• platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
• platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png:
• platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png:
• platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
• platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
• platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png:
• platform/chromium-win/fast/forms/placeholder-position-expected.png:
• platform/chromium-win/fast/html/details-writing-mode-expected.png:
• platform/chromium-win/fast/lists/001-vertical-expected.png:
• platform/chromium-win/fast/lists/002-vertical-expected.png:
• platform/chromium-win/fast/lists/003-vertical-expected.png:
• platform/chromium-win/fast/lists/005-vertical-expected.png:
• platform/chromium-win/fast/lists/006-vertical-expected.png:
• platform/chromium-win/fast/lists/007-vertical-expected.png:
• platform/chromium-win/fast/lists/008-vertical-expected.png:
• platform/chromium-win/fast/lists/009-vertical-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
• platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
• platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
• platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
• platform/chromium-win/fast/repaint/selection-rl-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
• platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
• platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
• platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
• platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
• platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
• platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Removed.
• platform/chromium-win/fast/table/027-vertical-expected.png:
• platform/chromium-win/fast/table/028-vertical-expected.png:
• platform/chromium-win/fast/table/035-vertical-expected.png:
• platform/chromium-win/fast/table/038-vertical-expected.png:
• platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png:
• platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png:
• platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
• platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
• platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
• platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
• platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
• platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
• platform/chromium-win/fast/transforms/shadows-expected.png:
• platform/chromium-win/fast/transforms/transform-on-inline-expected.png:
• platform/chromium-win/fast/transforms/transform-table-row-expected.png:
• platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
• platform/chromium-win/media/audio-repaint-expected.png:
• platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
• platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
• platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
• platform/chromium-win/svg/batik/text/textDecoration-expected.png:
• platform/chromium-win/svg/batik/text/textFeatures-expected.png:
• platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
• platform/chromium-win/svg/batik/text/textLayout2-expected.png:
• platform/chromium-win/svg/batik/text/textOnPath-expected.png:
• platform/chromium-win/svg/batik/text/textOnPath2-expected.png:
• platform/chromium-win/svg/batik/text/textOnPath3-expected.png:
• platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
• platform/chromium-win/svg/batik/text/textProperties-expected.png:
• platform/chromium-win/svg/batik/text/textStyles-expected.png:
• platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
• platform/chromium-win/svg/carto.net/colourpicker-expected.png:
• platform/chromium-win/svg/carto.net/combobox-expected.png:
• platform/chromium-win/svg/carto.net/selectionlist-expected.png:
• platform/chromium-win/svg/carto.net/window-expected.png:
• platform/chromium-win/svg/css/group-with-shadow-expected.png:
• platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
• platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
• platform/chromium-win/svg/custom/focus-ring-expected.png:
• platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
• platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
• platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
• platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
• platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
• platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
• platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
• platform/chromium-win/svg/custom/pointer-events-text-expected.png:
• platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
• platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
• platform/chromium-win/svg/custom/text-linking-expected.png:
• platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
• platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
• platform/chromium-win/svg/custom/text-rotation-expected.png:
• platform/chromium-win/svg/custom/use-detach-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
• platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
• platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.png:
• platform/chromium-win/svg/custom/use-on-text-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
• platform/chromium-win/svg/hixie/error/017-expected.png:
• platform/chromium-win/svg/text/selection-background-color-expected.png:
• platform/chromium-win/svg/text/selection-styles-expected.png:
• platform/chromium-win/svg/text/text-deco-01-b-expected.png:
• platform/chromium-win/svg/text/text-gradient-positioning-expected.png:
• platform/chromium-win/svg/text/text-path-01-b-expected.png:
• platform/chromium-win/svg/text/text-path-middle-align-expected.png:
• platform/chromium-win/svg/text/text-text-07-t-expected.png:
• platform/chromium-win/svg/text/text-text-08-b-expected.png:
• platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
• platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
• platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
• platform/chromium-win/transforms/2d/compound-transforms-vs-containers-expected.png:
• platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
• platform/chromium/test_expectations.txt:

11:25 AM Changeset in webkit [91079] by kenneth@webkit.org

• 2 edits in trunk/Source/WebKit/qt

REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect

Reviewed by Antonio Gomes.

Only set setFixedVisibleContentRect when in resizesToContents mode.

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

11:11 AM Changeset in webkit [91078] by Martin Robinson

• 9 edits in trunk

Build fixes for WebKit2. Ensure that all generated sources are
on nodist primaries, that they are on forward declared variables
so that BUILT_SOURCES is calculated properly and that zlib is
included during linking (for WOFF support).

.:

• GNUmakefile.am:
• Source/autotools/webkit.m4: Include test for zlib.

Source/WebKit/gtk:

• GNUmakefile.am:

Source/WebKit2:

• GNUmakefile.am:

Tools:

• WebKitTestRunner/GNUmakefile.am:

10:23 AM Changeset in webkit [91077] by xji@chromium.org

• 5 edits
  2 adds in trunk

--webkit-visual-word crash on mixed editability
​https://bugs.webkit.org/show_bug.cgi?id=61978

--webkit-visual-word crashes (VisiblePosition.getInlineBoxAndOffset could return null box)
​https://bugs.webkit.org/show_bug.cgi?id=62814

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace previousWordPosition/nextWordPosition with previousBoundary/nextBoundary which do
not honor editable bounary. Honor editable boundary as the last stage of leftWordPosition
and rightWordPosition.

Check previousBoundary/nextBoundary against NULL. Have a static function to encapsulate the
usage of getInlineBoxAndOffset and check the visible position is not NULL before passing to
getInlineBoxAndOffset. Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Test: editing/selection/move-by-word-visually-null-box.html

• editing/visible_units.cpp:

(WebCore::positionIsInBox):
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::positionIsInsideBox):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

Add a standalone test for testing getInlineBoxAndOffset returning null box.

• editing/selection/move-by-word-visually-null-box-expected.txt: Added.
• editing/selection/move-by-word-visually-null-box.html: Added.
• editing/selection/move-by-word-visually-others-expected.txt:
• editing/selection/move-by-word-visually-others.html:

10:17 AM Changeset in webkit [91076] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Mopping up some more expectations after r91069.

• platform/chromium/test_expectations.txt:

10:12 AM Changeset in webkit [91075] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

Remove unncessary creation of connectionProperties dictionary
​https://bugs.webkit.org/show_bug.cgi?id=63958

Reviewed by Alexey Proskuryakov.

No new tests because no change in functionality.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

9:50 AM Changeset in webkit [91074] by enne@google.com

• 2 edits in trunk/LayoutTests

[chromium] Mark more tests failing as a result of r91069
​https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

• platform/chromium/test_expectations.txt:

8:58 AM Changeset in webkit [91073] by Dimitri Glazkov

• 3 edits in trunk/Tools

Store error and warning information on TestExpectationLine.
​https://bugs.webkit.org/show_bug.cgi?id=64565

Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,

converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.

8:55 AM Changeset in webkit [91072] by Dimitri Glazkov

• 2 edits in trunk/Tools

Plumb the use of TestExpectationLine deeper, clean up.
​https://bugs.webkit.org/show_bug.cgi?id=64559

Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
also cleaning up names and remove an unused TestExpectations._get_options_list member.

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

8:51 AM Changeset in webkit [91071] by Dimitri Glazkov

• 4 edits in trunk/Tools

Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
​https://bugs.webkit.org/show_bug.cgi?id=64554

This moves us toward the world where errors are collected on the expectations, which allows us to
easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.

Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
parsing.

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,

changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
• Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.

8:34 AM Changeset in webkit [91070] by pfeldman@chromium.org

• 8 edits
  2 adds in trunk

Web Inspector: Focusing on another node while editing CSS property does not update styles
​https://bugs.webkit.org/show_bug.cgi?id=64283

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-change-node-while-editing.html

• inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):

• inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype.updateStyles):

• inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.callback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.inlineStyleCallback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
(WebInspector.MetricsSidebarPane.prototype._styleSheetChanged):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylesSidebarPane.prototype._styleSheetChanged):
(WebInspector.StylesSidebarPane.prototype._attributesUpdated):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

• http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

• inspector/styles/styles-change-node-while-editing-expected.txt: Added.
• inspector/styles/styles-change-node-while-editing.html: Added.

8:27 AM Changeset in webkit [91069] by commit-queue@webkit.org

• 8 edits in trunk

[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
​https://bugs.webkit.org/show_bug.cgi?id=64368

Patch by Mike Reed <​reed@google.com> on 2011-07-15
Reviewed by James Robinson.

Source/WebCore:

• platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

• platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):

• platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

• platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

• platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

• platform/chromium/test_expectations.txt:

8:10 AM Changeset in webkit [91068] by Adam Roben

• 4 edits
  2 moves in trunk/Tools

Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <​http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Updated for renames.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and

reordered <script>s to put files which others depend on for parsing first.

7:38 AM Changeset in webkit [91067] by commit-queue@webkit.org

• 4 edits in trunk

Pixel difference in FEMorphology effect
​https://bugs.webkit.org/show_bug.cgi?id=63930

Source/WebCore:

Patch by Piroska András <​Piroska.Andras@stud.u-szeged.hu> on 2011-07-15
Reviewed by Zoltan Herczeg.

Using short-circuit evaluation in the setFilterEffectAttribute function
was wrong. We should call both setRadius functions and evaluate the
changes separately.

• svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):

LayoutTests:

Patch by Gabor Loki <​loki@webkit.org> on 2011-07-15
Reviewed by Zoltan Herczeg.

Layout test is updated to follow the bugfix.

• platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:

7:02 AM Changeset in webkit [91066] by jeffm@apple.com

• 6 edits in trunk

Fullscreen content doesn't use fullscreen controller on Windows
​https://bugs.webkit.org/show_bug.cgi?id=64540
<rdar://problem/9510455>

Source/WebCore:

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.

• rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests:

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

• fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.

• fullscreen/video-controls-override.html: Add new test to check the height of the panel, and

log errors if window.internals or window.layoutTestController are undefined.

6:10 AM Changeset in webkit [91065] by Nikolas Zimmermann

• 2 edits in trunk/Source/WebCore

2011-07-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix build failure introduced in r91061.

• page/Console.cpp: (WebCore::Console::markTimeline): Remove argument name from unused parameter.

5:02 AM Changeset in webkit [91064] by kenneth@webkit.org

• 15 edits in trunk/Source

Upstream QtWebKit/N9 changes related to visibleContentRect
​https://bugs.webkit.org/show_bug.cgi?id=64589

Reviewed by Simon Hausmann.

Source/WebCore:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

Make visibleContentRect return the fixed value if set, and remove
all calls to actualVisibleContentRect.

Also updated the documentation.

This is similar to what we have on our QtWebKit/N9 branch and is
pretty well tested.

• platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
If a fixed visibleContentRect is set, return that.
Remove the code returning the contents size when in
paintsEntireContents mode as that is wrong and already
ifdeffed out for EFL.
(WebCore::ScrollView::setScrollPosition):
Do not try to be smart and update the fixed visibleContentsRect
automatically, as the embedder might ignore the scroll request
for various reasons.

• platform/ScrollView.h:

(WebCore::ScrollView::setFixedVisibleContentRect):
(WebCore::ScrollView::fixedVisibleContentRect):

Source/WebKit/qt:

• Api/qwebpage.cpp:

(QWebPage::setActualVisibleContentRect):
Change to use setFixedVisibleContentRect.

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

• symbian/eabi/QtWebKitu.def:

Source/WebKit2:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFixedVisibleContentRect):

• UIProcess/WebPageProxy.h:
• UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleArea):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

4:09 AM Changeset in webkit [91063] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] Build plugin process by default when building WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=64592

Reviewed by Philippe Normand.

• configure.ac:

3:40 AM Changeset in webkit [91062] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

Reviewed by Martin Robinson.

[GTK] Install a custom X error handler in plugin process
​https://bugs.webkit.org/show_bug.cgi?id=63248

Some plugins, specially flash, can cause X errors that when
handled by the default X error handler (or the GDK one) abort the
process. Since we don't want to crash due to buggy plugins, we
install a custom error handler to show a warning when a X error
happens without aborting.

• PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::webkitgtkXError):
(WebKit::PluginProcessMainGtk):

3:06 AM Changeset in webkit [91061] by commit-queue@webkit.org

• 23 edits
  2 copies
  1 add in trunk

Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.
​https://bugs.webkit.org/show_bug.cgi?id=63317

Patch by Mike West <​mkwst@chromium.org> on 2011-07-15
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-time-stamp.html

• inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::consoleTimeStamp):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleTimeStampImpl):

• inspector/InspectorInstrumentation.h:
• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didTimeStamp):

• inspector/InspectorTimelineAgent.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimeStampData):

• inspector/TimelineRecordFactory.h:
• inspector/front-end/TimelineAgent.js:
• inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype.update):

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

• page/Console.cpp:

(WebCore::Console::markTimeline):
(WebCore::Console::timeStamp):

• page/Console.h:
• page/Console.idl:

LayoutTests:

• inspector/timeline/resources/timeline-iframe-data.html:
• inspector/timeline/timeline-enum-stability-expected.txt:
• inspector/timeline/timeline-event-dispatch.html:
• inspector/timeline/timeline-mark-timeline-expected.txt:
• inspector/timeline/timeline-mark-timeline.html:
• inspector/timeline/timeline-script-tag-1-expected.txt:
• inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.dumpTimelineRecord):

• inspector/timeline/timeline-time-stamp-expected.txt: Added.
• inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
• platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
• platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.

1:35 AM Changeset in webkit [91060] by commit-queue@webkit.org

• 5 edits
  1 add in trunk/Source/WebCore

LocalStorage: Changed the value type of ItemTable from TEXT to BLOB
to avoid string truncation.
This patch will also convert the exsisting ItemTable and perform
the DATA MIGRATION job.
​https://bugs.webkit.org/show_bug.cgi?id=58762

Patch by Jonathan Dong <Jonathan Dong> on 2011-07-15
Reviewed by Jeremy Orlow.

Tests: manual-tests/localstorage-value-truncation.html

• manual-tests/localstorage-value-truncation.html: Added.

Demostrate the testcase shown in bug 58762.

• platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclearedAsBlob):
Test if the pre-defined type of column is BLOB.

• platform/sql/SQLiteStatement.h:
• storage/StorageAreaSync.cpp:

Change the localStorage value type from Text to BLOB to avoid the
value string truncation at \x00.
(WebCore::StorageAreaSync::openDatabase):
Change the database structure, use BLOB to replace the TEXT type of
value segment in ItemTable.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
Migrate the ItemTable if the pre-defined type of value is TEXT.
(WebCore::StorageAreaSync::performImport):
Use getColumnBlobAsString() to import the BLOB value.
(WebCore::StorageAreaSync::sync):
Use bindBlob() to bind value string to the SQLiteStatement for the
database execution.

• storage/StorageAreaSync.h:

1:25 AM WebKitGTK edited by plaes@plaes.org

Looking for 1.4.3 ;) (diff)

1:22 AM Changeset in webkit [91059] by abarth@webkit.org

• 3 edits in trunk/Tools

NRWT stores the Chromium revision number in full_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64586

I have no earthly idea how to test this change.

• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/port/base.py:

1:10 AM Changeset in webkit [91058] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Clear the content of a search input form when 'Escape' is pressed.
​https://bugs.webkit.org/show_bug.cgi?id=51897

Source/WebCore:

This change added handleKeydownEvent() to a search input form,
which clears the form and triggers a 'search' event when 'Escape' is pressed.

Patch by Kentaro Hara <​haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

Test: fast/forms/input-search-press-escape-key.html

• html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

• html/SearchInputType.h:

LayoutTests:

The added test checks if the value in a search input form is cleared
and a 'search' event is triggered, when we press 'Escape' key.

Patch by Kentaro Hara <​haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

• fast/forms/input-search-press-escape-key-expected.txt: Added.
• fast/forms/input-search-press-escape-key.html: Added.

12:23 AM Changeset in webkit [91057] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
​https://bugs.webkit.org/show_bug.cgi?id=64360

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-15
Reviewed by Hajime Morita.

No new tests needed because the patch is just a refactor.

• rendering/RenderBlock.h:
• rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):