Context Navigation

← Previous Period
Next Period →

Timeline

Jul 18, 2011:

10:33 PM Changeset in webkit [91239] by aestes@apple.com

2 edits in trunk/Source/WebKit/mac

Solar Walk app-specific hack accidentally strips stylesheets from the document.
https://bugs.webkit.org/show_bug.cgi?id=64777

Reviewed by Adam Barth.

Solar Walk uses a self-closed title tag in its documents ("<title />").
The HTML5 parser does not recognize this as a valid self-closing tag,
so it treats the remainder of the document as title text.

We work around this in WebKit by injecting a script that calls
document.write() on the contents of document.title, thereby restoring
the contents of the document. Unfortunately this overwrote several
<style> tags that existed before the <title>, thereby causing the
document to not have the intended styling.

Fix this by having the injected script concatenate document.title to
the document instead of overwriting it during document.write(). We can
also take the opportunity to remove document.title since it does not
contain useful information.

Misc/SolarWalkQuirksUserScript.js:

10:04 PM Changeset in webkit [91238] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix Chromium test expectations.

platform/chromium/test_expectations.txt:

9:14 PM Changeset in webkit [91237] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Add a runtime check for font cascading optimization.

It's a constant value in Mac port so hopefully gcc will constant-propagate the value
and eliminate the function altogether.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::canSetCascadeListForCustomFont): Added.
(WebCore::FontPlatformData::ctFont):

9:03 PM Changeset in webkit [91236] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Chromium test expectation update after r91229.

platform/chromium/test_expectations.txt:

7:55 PM Changeset in webkit [91235] by morrita@google.com

23 edits
2 adds in trunk

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
Updated the set on inclusion list changes.
Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

Renamed NodeRenderingContext::m_contentElement to m_includer
ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

WebCore.exp.in:
dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

dom/ShadowContentElement.cpp:

(WebCore::removeFromSet):
(WebCore::addToSet):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

dom/ShadowContentSelector.h:
dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

dom/ShadowRoot.h:

(WebCore::toShadowRoot):

testing/Internals.cpp:

(WebCore::Internals::includerFor):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added a new test.
Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.

fast/dom/shadow/content-element-includer-expected.txt: Added.
fast/dom/shadow/content-element-includer.html: Added.
platform/chromium-win/fast/html/details-nested-2-expected.txt:
platform/gtk/fast/html/details-nested-2-expected.txt:
platform/mac/fast/html/details-nested-2-expected.txt:
platform/qt/fast/html/details-nested-2-expected.txt:

7:42 PM Changeset in webkit [91234] by barraclough@apple.com

13 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-18

platform/chromium/test_expectations.txt:

7:25 PM Changeset in webkit [91233] by commit-queue@webkit.org

2 edits in trunk/Tools

Tab Atkins is not in committers.py (as a non-committer)
https://bugs.webkit.org/show_bug.cgi?id=64770

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Eric Seidel.

Scripts/webkitpy/common/config/committers.py:

7:21 PM Changeset in webkit [91232] by dino@apple.com

20 edits in trunk/Source

2011-07-18 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=64742
Expose WebPreferences for media playback requiring user gestures and inline playback

Reviewed by Simon Fraser.

Media playback already tested if it should require user gestures, but
no setting was ever exposed to clients. Also, some ports only allow media
playback to be fullscreen, so exposing a new setting for them.

Two new WebPreferences: MediaPlaybackRequiresUserGesture and
MediaPlaybackAllowsInline.

WebCore:

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Examine the new Setting for user gestures.
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h: Two new settings. (WebCore::Settings::setMediaPlaybackRequiresUserGesture): (WebCore::Settings::mediaPlaybackRequiresUserGesture): (WebCore::Settings::setMediaPlaybackAllowsInline): (WebCore::Settings::mediaPlaybackAllowsInline):

WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences mediaPlaybackRequiresUserGesture]): (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): (-[WebPreferences mediaPlaybackAllowsInline]): (-[WebPreferences setMediaPlaybackAllowsInline:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChanged:]):

WebKit/win:

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setMediaPlaybackRequiresUserGesture): (WebPreferences::mediaPlaybackRequiresUserGesture): (WebPreferences::setMediaPlaybackAllowsInline): (WebPreferences::mediaPlaybackAllowsInline):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit2:

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMediaPlaybackRequiresUserGesture): (WKPreferencesGetMediaPlaybackRequiresUserGesture): (WKPreferencesSetMediaPlaybackAllowsInline): (WKPreferencesGetMediaPlaybackAllowsInline):
UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):

6:42 PM Changeset in webkit [91231] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Leopard build fix after r91229.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont):

6:25 PM Changeset in webkit [91230] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

platform/chromium/test_expectations.txt:

6:21 PM Changeset in webkit [91229] by mitz@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Reviewed by Sam Weinig.

platform/graphics/Font.h:
platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Undo the cascade list optimization on Leopard for custom
fonts, because adding a cascade list apparently breaks the font.

5:54 PM Changeset in webkit [91228] by mdelaney@apple.com

9 edits in trunk/Source/WebCore

Remove drawsUsingCopy now that all ports handle the copying
https://bugs.webkit.org/show_bug.cgi?id=64768

Introduced in https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy
was used to know whether or not an ImageBuffer should be explicitly copied before being
painted into a context (as was used in HTMLCanvasElement::paint). All platforms now
handle the logic of copying or not in their ImageBuffer::draw() implementations, so
drawsUsingCopy() is no longer needed. This patch removes it.

Reviewed by Dan Bernstein.

No new tests; does not affect behavior.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::isAccelerated):

platform/graphics/cairo/ImageBufferCairo.cpp:
platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/qt/ImageBufferQt.cpp:
platform/graphics/skia/ImageBufferSkia.cpp:
platform/graphics/wince/ImageBufferWinCE.cpp:
platform/graphics/wx/ImageBufferWx.cpp:

5:39 PM Changeset in webkit [91227] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated event is dispatched on NetworkPanel.
https://bugs.webkit.org/show_bug.cgi?id=64748

Reviewed by Pavel Feldman.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

5:36 PM Changeset in webkit [91226] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize strict equality as effectively as the old JIT does.
https://bugs.webkit.org/show_bug.cgi?id=64759

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

This adds a more complete set of strict equality optimizations. If either
operand is known numeric, then the code reverts to the old style of optimizing
(first try integer comparison). Otherwise it uses the old JIT's trick of
first simultaneously checking if both operands are either numbers or cells;
if not then a fast path is taken.

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):

dfg/DFGJITCodeGenerator.h:
dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:26 PM Changeset in webkit [91225] by barraclough@apple.com

5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=64760
DFG JIT - Should be able to compile program code.

Reviewed by Geoff Garen.

Add support for op_end, hooks to compile program code in Executable.cpp.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Add support for op_end

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

Added, separate out steps of compileFunction.

(JSC::DFG::JITCompiler::compile):

Added, compile program code.

(JSC::DFG::JITCompiler::compileFunction):

Sections separated out to helper functions.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

Added m_exceptionCheckCount.

runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.

5:25 PM Changeset in webkit [91224] by barraclough@apple.com

8 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to the global object,
also, to toLocaleString should be calling the ToObject & invoking the object's toString
function, even for values that are already strings.

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

LayoutTests:

fast/js/resources/js-test-pre.js:
- Updated harness to not call Object.prototype.toString on undefined.
fast/js/eval-var-decl-expected.txt:
fast/js/object-prototype-properties-expected.txt: Added.
fast/js/object-prototype-properties.html: Added.
fast/js/object-prototype-toLocaleString-expected.txt
fast/js/script-tests/eval-var-decl.js:
- Fix test case, calling hasProperty with undefined as the this value should throw.
fast/js/script-tests/object-prototype-properties.js: Added.
- Place for test cases for Object.prototype properties; to being with, check that calling these methods on undefined throws!
fast/js/script-tests/object-prototype-toLocaleString.js:
- Added test cases for correct behaviour when this is a string primitive.
sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
- These test cases are all incorrect. (See https://bugs.ecmascript.org/show_bug.cgi?id=117). We were incorrectly passing 15.5.4.11_String.prototype.replace, this should fail, as the others do. All the other 15.5.4 tests were failing & are still failing, but now have a better error message. S11.1.1_A2 is also invalid, calling toString() passing undefined as this should throw.

5:20 PM Changeset in webkit [91223] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix a typo.

platform/chromium/test_expectations.txt:

5:14 PM Changeset in webkit [91222] by bweinstein@apple.com

3 edits in trunk/Source/WebCore

Prep work for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Darin Adler.

Add a DragClient function that is called when a drag is ended, and call it from DragController::dragEnded.
This isn't used yet, but will be used by WebKit2 on Mac.

This patch also cleans up style in DragClient.h.

No change in behavior, no tests needed.

page/DragClient.h:

(WebCore::DragClient::dragEnded): Stub virtual implementation for now, this will be used by

WebKit2 on Mac.

page/DragController.cpp:

(WebCore::DragController::dragEnded): Call DragClient::dragEnded.

4:59 PM Changeset in webkit [91221] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add Chromium failing expectations for some font tests; failures are tracked by the bug 64767.

platform/chromium/test_expectations.txt:

4:19 PM Changeset in webkit [91220] by ojan@chromium.org

2 edits in trunk/Tools

Load ToT chromium bots by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64756

Reviewed by Adam Barth.

For now, these are the most useful bots to look at. Eventually,
we may want to load the build.webkit.org bots by default once
most of the bots there upload results.

TestResultServer/static-dashboards/dashboard_base.js:

4:16 PM Changeset in webkit [91219] by jhoneycutt@apple.com

15 edits
2 adds in trunk

Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
platform/win/accessibility/option-element-selection-and-focus-events.html: Added.

4:11 PM BuildingGtk edited by levin@chromium.org

Fix formatting of recent change. (diff)

3:55 PM Changeset in webkit [91218] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

JSC GC lazy sweep does not inline the common cases of cell destruction.
https://bugs.webkit.org/show_bug.cgi?id=64745

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This inlines the case of JSFinalObject destruction.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::lazySweep):

3:49 PM Changeset in webkit [91217] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Add regression tests for legacy color parsing of valid CSS colors
https://bugs.webkit.org/show_bug.cgi?id=64576

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Simon Fraser.

fast/dom/attribute-legacy-colors-expected.txt:
fast/dom/script-tests/attribute-legacy-colors.js:

3:42 PM Changeset in webkit [91216] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Interpreter build-fix

3:36 PM Changeset in webkit [91215] by commit-queue@webkit.org

3 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Unreviewed. Just updating unit test results after bug 64751.

Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

3:27 PM Changeset in webkit [91214] by abarth@webkit.org

5 edits in trunk/Tools

simplejson has trouble on chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=64757

Reviewed by Eric Seidel.

Use the native JSON, if available.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

2:59 PM Changeset in webkit [91213] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18

DEPS:

2:51 PM Changeset in webkit [91212] by ojan@chromium.org

5 edits in trunk/Tools

update the flakiness dashboard to understand the new platforms/formats in test_expectations
https://bugs.webkit.org/show_bug.cgi?id=64743

Reviewed by Adam Barth.

The test expectations format changed a long time ago and the flakiness dashboard
was never updated to match.

TestResultServer/static-dashboards/dashboard_base.js:
TestResultServer/static-dashboards/flakiness_dashboard.html:
TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
TestResultServer/static-dashboards/timeline_explorer.html:

2:33 PM BuildingQtOnLinux edited by phihag@phihag.de

Outdated Mesa (when compiling on debian stable or other old distros) (diff)

2:27 PM Changeset in webkit [91211] by rniwa@webkit.org

2 edits
3 adds in trunk/LayoutTests

[SVG] [Chromium]: painting-control-04-f.svg and zero-path-square-cap-rendering.svg are failing
https://bugs.webkit.org/show_bug.cgi?id=64675

Rebaseline painting-control-04-f.svg since r91191 fixed it.

platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:16 PM Changeset in webkit [91210] by commit-queue@webkit.org

37 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Reviewed by Adam Barth.

Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
is a step that we run for most commands (as one of the earliest steps).
EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
the CWD to the checkout root. This magically made a bunch of otherwise
wrong code work.

When I realized that apply-attachment no longer worked as expected today,
I went and fixed the bug, then realizing that we were not testing
what the cwd was when running various commands. I fixed our MockExecutive
to always log what the cwd is and fixed a whole bunch of places
where we needed to be setting the cwd.

Hopefully this will solve our cwd problems once and for-all, and webkit-patch
will again correctly work when called from any directory (including outside
of a webkit checkout).

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/common/system/workspace_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
Scripts/webkitpy/layout_tests/port/mac_unittest.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/irc_command_unittest.py:
Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/servers/gardeningserver.py:
Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
Scripts/webkitpy/tool/steps/build.py:
Scripts/webkitpy/tool/steps/checkstyle.py:
Scripts/webkitpy/tool/steps/editchangelog.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
Scripts/webkitpy/tool/steps/runtests.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/update.py:

2:10 PM Changeset in webkit [91209] by mitz@apple.com

2 edits in trunk/Source/WebCore

Specify a cascade list consisting of the last resort font for Core Text
https://bugs.webkit.org/show_bug.cgi?id=64747

Reviewed by Sam Weinig.

No new tests, because this does not affect behavior.

This prevents Core Text from taking its default, longer fallback list when the primary font does
not include a character. This is OK to do because WebKit never uses the results of Core Text
fallback anyway.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::cascadeToLastResortFontDescriptor): Added. Returns a CTFontDescriptor with a cascade
list consisting of the last resort font.
(WebCore::FontPlatformData::ctFont): Changed to include the cascadeToLastResortFontDescriptor
in the returned font.

2:04 PM Changeset in webkit [91208] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize equal-null comparisons and branches.
https://bugs.webkit.org/show_bug.cgi?id=64659

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

Added a peephole-aware compare-to-null implementation to JITCodeGenerator,
which is used by both the speculative and non-speculative JIT. Through
the use of the new isNullConstant helper, the two JITs invoke the
nonSpecualtiveCompareNull() helper instead of their regular comparison
helpers when compiling CompareEq. Through the use of the new isKnownCell
helper, the compare-null code will skip the is-a-cell check if the
speculative JIT had been speculating cell.

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isNullConstant):

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGOperations.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:56 PM Changeset in webkit [91207] by ctguil@chromium.org

2 edits in branches/chromium/782/Source/WebCore

Merge 90599 - Work around Skia PDF's lack of inverted path support.
https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7398032

1:38 PM Changeset in webkit [91206] by commit-queue@webkit.org

30 edits in trunk/Source

Timer scheduling should be based off the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64544

Patch by James Robinson <jamesr@chromium.org> on 2011-07-18
Reviewed by Darin Adler.

Source/JavaScriptCore:

Switches ThreadCondition::timedWait and related utility functions from currentTime() to
monotonicallyIncreasingTime().

Add WTF::monotonicallyIncreasingTime() to list of exported functions so it can be accessed from WebCore/WebKit.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
wtf/ThreadingPthreads.cpp:

(WTF::ThreadCondition::timedWait):

wtf/ThreadingWin.cpp:

(WTF::absoluteTimeToWaitTimeoutInterval):

wtf/gtk/ThreadingGtk.cpp:

(WTF::ThreadCondition::timedWait):

wtf/qt/ThreadingQt.cpp:

(WTF::ThreadCondition::timedWait):

Source/WebCore:

Changes the Timer scheduling logic from using absolute values in terms of currentTime() to using relative
intervals in terms of monotonicallyIncreasingTime(). This provides better standards compliance, compatibility,
and predictability when the system clock is adjusted.

No automated tests since there is no way to modify the system clock from DRT.

platform/SharedTimer.h:

(WebCore::MainThreadSharedTimer::setFireInterval):

platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

platform/Timer.cpp:

(WebCore::TimerBase::start):
(WebCore::TimerBase::nextFireInterval):

platform/android/SharedTimerAndroid.cpp: