Timeline
Aug 6, 2011:
- 8:44 PM Changeset in webkit [92569] by
-
- 8 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.
Reviewed by Oliver Hunt.
This is a 1% win on SunSpider.
- dfg/DFGOperations.cpp:
- Use fastGetOwnProperty.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Use fastGetOwnProperty.
- runtime/JSCell.h:
- runtime/JSObject.h:
(JSC::JSCell::fastGetOwnProperty):
- Fast call to get a property without creating an identifier the first time.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
- Add interface to look up by either strinsg or identifiers.
- runtime/Structure.h:
(JSC::Structure::get):
- Add a get() call that takes a UString, not an Identifier.
- wtf/text/StringImpl.h:
(WTF::StringImpl::hasHash):
- Add a call to check if the has has been set (to detect the first use as a property name).
- 6:09 PM Changeset in webkit [92568] by
-
- 2 edits in trunk/Source/WebKit2
Fix a memory leak found via code inspection.
Rubber-stamped by Dan Bernstein.
- WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.
- 6:09 PM Changeset in webkit [92567] by
-
- 2 edits in trunk/Source/WebCore
Fix a memory leak found via code inspection.
Rubber-stamped by Dan Bernstein.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): Adopt the newly-allocated WebHTMLConverter
instance so that it does not leak.
- 4:35 PM Changeset in webkit [92566] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Fix environmental differencies in the results added in r92564.
I was in the wrong chroot.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- 3:36 PM Changeset in webkit [92565] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Add Siddharth Mathur to committer list. Unreviewed
- 3:29 PM Changeset in webkit [92564] by
-
- 2 edits27 adds in trunk/LayoutTests
Unreviewed gardening.
Add missing Qt results.
- platform/qt/Skipped:
- platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
- platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
- platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
- platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
- platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
- platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
- 3:19 PM Changeset in webkit [92563] by
-
- 6 edits6 deletes in trunk/Tools
Remove dead code in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=65818
Reviewed by Dimitri Glazkov.
This code was added to support the rebaseline2 command six months ago,
but the rebaseline2 command was never finished and no one else has used
this code since it was landed. This patch removes the dead code. If
we revive rebaseline2, then we can revert this patch and recover the
code. Until then, this code is just dead weight.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- Scripts/webkitpy/common/net/testoutput.py: Removed.
- Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
- Scripts/webkitpy/common/net/testoutputset.py: Removed.
- Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
- Scripts/webkitpy/common/system/directoryfileset.py: Removed.
- Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 3:17 PM Changeset in webkit [92562] by
-
- 3 edits in trunk/Tools
webkit-patch optimize-baselines can't handle promotions to base results directory
https://bugs.webkit.org/show_bug.cgi?id=65819
Reviewed by Dimitri Glazkov.
This bug came up when testing the optimizer on some editing baselines.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
- 3:04 PM Changeset in webkit [92561] by
-
- 1 edit2 adds in trunk/LayoutTests
Fix baselines for cross-origin-xsl-BLOCKED.html. These results
uncovered a subtle bug in webkit-patch bulk-optimize-baselines, which
I'll fix in a follow-up patch.
- platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
- platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
- 2:24 PM Changeset in webkit [92560] by
-
- 1 edit3 adds8 deletes in trunk/LayoutTests
Optimize expected results for editing.
This patch was created with webkit-patch bulk-optimize-baselines.
- platform/chromium-mac/editing/pasteboard/copy-paste-float-expected.txt: Removed.
- platform/chromium-mac/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
- platform/chromium-mac/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
- platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/copy-paste-float-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
- platform/chromium/editing/pasteboard/5761530-1-expected.txt: Removed.
- platform/chromium/editing/pasteboard/copy-paste-float-expected.txt: Added.
- platform/chromium/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
- platform/chromium/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
- 2:11 PM Changeset in webkit [92559] by
-
- 1 edit2 adds3 deletes in trunk/LayoutTests
Optimize expected results for animations.
This patch was created with webkit-patch bulk-optimize-baselines.
- platform/chromium-mac/animations/keyframes-rule-expected.txt: Removed.
- platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
- platform/chromium-win/animations/keyframes-rule-expected.txt: Removed.
- platform/chromium/animations/keyframes-rule-expected.txt: Added.
- platform/chromium/animations/opacity-transform-animation-expected.png: Removed.
- 2:07 PM Changeset in webkit [92558] by
-
- 2 edits in trunk/Tools
Add a small command to optimize baselines in bulk.
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 1:48 PM Changeset in webkit [92557] by
-
- 1 edit50 adds82 deletes in trunk/LayoutTests
Optimize expected results for http/tests/security.
This patch was created with webkit-patch optimize-baselines.
- platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/xss-eval-expected.txt: Removed.
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
- platform/chromium-win/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
- platform/chromium-win/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
- platform/chromium-win/http/tests/security/xss-eval-expected.txt: Removed.
- platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
- platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-get-override-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
- platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt: Added.
- platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/chromium/http/tests/security/dataURL: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
- platform/chromium/http/tests/security/frameNavigation: Added.
- platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium/http/tests/security/listener: Added.
- platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
- platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
- platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
- platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
- platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
- platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
- platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium/http/tests/security/xss-eval-expected.txt: Added.
- 1:17 PM Changeset in webkit [92556] by
-
- 3 edits in trunk/Source/WebCore
Fix Timer heap implementation to work with more libraries (other versions of STL)
https://bugs.webkit.org/show_bug.cgi?id=65782
Reviewed by Anders Carlsson.
No behavior change, so no tests needed. Existing tests pass.
- platform/Timer.cpp: Added TimerHeapPointer and TimerHeapReference class
alongside the TimerHeapIterator class. Also added a swap function. Also
added a TimerHeapLessThanFunction class.
(WebCore::TimerBase::heapDecreaseKey): Pass pointers in to the TimerHeapIterator
since that's how the class works now. Pass a TimerHeapLessThanFunction object
instead of letting the library use the < operator directly.
(WebCore::TimerBase::heapPopMin): Ditto.
- platform/Timer.h: Updated for above changes.
- 12:52 PM Changeset in webkit [92555] by
-
- 11 edits in trunk
Patch by Aron Rosenberg <arosenberg@logitech.com> on 2011-08-06
Reviewed by Benjamin Poulain.
[Qt] Fix build with Intel compiler on Windows
https://bugs.webkit.org/show_bug.cgi?id=65088
.:
Disable Intel Compiler warning 873 - function "" has no corresponding operator
delete (to be called if an exception is thrown during initialization of an
allocated object).
- Source/WebKit.pri:
Source/JavaScriptCore:
Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays
- JavaScriptCore.pri:
- jsc.cpp:
- wtf/ByteArray.h:
- wtf/NullPtr.h:
Source/WebCore:
Intel compiler needs .lib suffixes instead of .a
- WebCore.pri:
Source/WebKit2:
Intel compiler needs .lib suffixes instead of .a
- WebKit2.pri:
- 10:09 AM Changeset in webkit [92554] by
-
- 6 edits2 deletes in trunk/LayoutTests
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186
Rebaseline some tests on Leopard/gtk/qt in order to get the bots greener.
Not reviewed.
- platform/gtk/Skipped:
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- 10:00 AM Changeset in webkit [92553] by
-
- 4 edits in trunk/Source/WebCore
Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
https://bugs.webkit.org/show_bug.cgi?id=65809
Reviewed by Darin Adler and Sam Weinig.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.
- platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.
- 9:17 AM Changeset in webkit [92552] by
-
- 5 edits in trunk/Source
Potential Leaks - RetainPtr<> over retaining Create'd objects
https://bugs.webkit.org/show_bug.cgi?id=65806
Reviewed by Darin Adler.
Fix a possible leak by adopting an allocation instead of retaining it.
Source/WebCore:
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- plugins/mac/PluginPackageMac.cpp:
(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView previousValidKeyView]):
- 8:57 AM Changeset in webkit [92551] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (r91540): Favicons are not loaded
https://bugs.webkit.org/show_bug.cgi?id=65692
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.
The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.
- loader/icon/IconController.cpp:
(WebCore::IconController::startLoader):
- loader/icon/IconDatabase.cpp:
- loader/icon/IconDatabase.h:
- loader/icon/IconDatabaseBase.cpp:
(WebCore::documentCanHaveIcon):
- loader/icon/IconDatabaseBase.h:
- 8:23 AM Changeset in webkit [92550] by
-
- 2 edits in trunk/LayoutTests
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186
It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)
- try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.
Rubber-stamped by Antti Koivisto.
- svg/zoom/resources/testPageZoom.js: (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().
- 3:02 AM Changeset in webkit [92549] by
-
- 2 edits in trunk/Source/WebCore
Should use C++-style cast in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=65807
Replaces C-style cast with C++style cast.
Reviewed by Shinichiro Hamaji.
No new tests because no behavior change.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):
- 2:40 AM Changeset in webkit [92548] by
-
- 3 edits6 adds in trunk/LayoutTests
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.
Not reviewed.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/mac-wk2/svg/W3C-SVG-1.1: Added.
- platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
- platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
- 2:27 AM Changeset in webkit [92547] by
-
- 4 edits2 adds in trunk/LayoutTests
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.
Not reviewed.
- platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
- 2:19 AM Changeset in webkit [92546] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Follow-up for r92545.
Rebaseline some tests on gtk/qt and win.
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- 1:25 AM Changeset in webkit [92545] by
-
- 6 edits6 moves30 adds in trunk
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974
svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186
Reviewed by Zoltan Herczeg.
Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
Add several new tests in svg/as-object - covering bug 64974.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
- platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
- platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
- svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
- svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
- svg/as-object/embedded-svg-size-changes-expected.txt: Added.
- svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
- svg/as-object/embedded-svg-size-changes.html: Added.
- svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
- svg/as-object/nested-embedded-svg-size-changes.html: Added.
- svg/as-object/resources: Added.
- svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
- svg/as-object/resources/embedded-svg-size-changes.svg: Added.
- svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
- svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
- svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
- svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
- svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
- svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
- svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
- svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
- svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
- svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
- svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
- svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.
2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974
svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186
Reviewed by Zoltan Herczeg.
Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
through RenderSVGRoot::layout.
And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
document to be laid out again, now that the size of the embedded SVG document is known.
As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
right before painting.
A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
FrameView::layout().
Consider following document:
<body><iframe src="some.svg"></body>
After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
(in the simplest case, where width/height are both auto).
Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.
After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).
The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).
Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.
Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/embedded-svg-immediate-offsetWidth-query.html
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
- page/FrameView.cpp: (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished. (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method. (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
- page/FrameView.h:
- rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
- rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
- rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic. (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).
Aug 5, 2011:
- 9:19 PM BuildingQtOnLinux edited by
- (diff)
- 9:14 PM Changeset in webkit [92544] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove HaltablePlugin references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=65808
HaltablePlugin and related classes were removed in r92492. Remove any
reference to the deleted files from the gyp project files.
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Adam Barth.
- WebCore.gypi: remove HaltablePlugin.h reference.
- 8:49 PM Changeset in webkit [92543] by
-
- 6 edits13 moves in trunk/LayoutTests
Renamed fast/blockflow to fast/writing-mode.
Rubber-stamped by Sam Weinig.
- fast/blockflow: Removed.
- fast/writing-mode: Copied from fast/blockflow.
- platform/chromium-linux/fast/blockflow: Removed.
- platform/chromium-linux/fast/writing-mode: Copied from platform/chromium-linux/fast/blockflow.
- platform/chromium-mac-leopard/fast/blockflow: Removed.
- platform/chromium-mac-leopard/fast/writing-mode: Copied from platform/chromium-mac-leopard/fast/blockflow.
- platform/chromium-mac/fast/blockflow: Removed.
- platform/chromium-mac/fast/writing-mode: Copied from platform/chromium-mac/fast/blockflow.
- platform/chromium-win-vista/fast/blockflow: Removed.
- platform/chromium-win-vista/fast/writing-mode: Copied from platform/chromium-win-vista/fast/blockflow.
- platform/chromium-win-xp/fast/blockflow: Removed.
- platform/chromium-win-xp/fast/writing-mode: Copied from platform/chromium-win-xp/fast/blockflow.
- platform/chromium-win/fast/blockflow: Removed.
- platform/chromium-win/fast/writing-mode: Copied from platform/chromium-win/fast/blockflow.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/blockflow: Removed.
- platform/gtk/fast/writing-mode: Copied from platform/gtk/fast/blockflow.
- platform/mac-leopard/fast/blockflow: Removed.
- platform/mac-leopard/fast/writing-mode: Copied from platform/mac-leopard/fast/blockflow.
- platform/mac-wk2/fast/blockflow: Removed.
- platform/mac-wk2/fast/writing-mode: Copied from platform/mac-wk2/fast/blockflow.
- platform/mac/Skipped:
- platform/mac/fast/blockflow: Removed.
- platform/mac/fast/writing-mode: Copied from platform/mac/fast/blockflow.
- platform/qt-mac/Skipped:
- platform/qt/Skipped:
- platform/qt/fast/blockflow: Removed.
- platform/qt/fast/writing-mode: Copied from platform/qt/fast/blockflow.
- platform/win/fast/blockflow: Removed.
- platform/win/fast/writing-mode: Copied from platform/win/fast/blockflow.
- platform/wk2/Skipped:
- 8:09 PM Changeset in webkit [92542] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the build after r92538.
Like all of the recent "track"-related work the new files in r92538 appear to have
been added to completely random places in the Xcode project. However, this time
the file paths were marked as being relative to their containing group resulting in
Xcode being unable to find the files on disk.
I've attempted to clean up all of the "track"-related mess in the Xcode project.
The location of the files in the project now reflect their locations on disk, and
are all correctly marked as being relative to their containing group as is our
convention.
- WebCore.xcodeproj/project.pbxproj:
- 7:25 PM Changeset in webkit [92541] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.
Patch by Tom Hudson <tomhudson@google.com> on 2011-08-05
Reviewed by James Robinson.
No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
- 7:17 PM Changeset in webkit [92540] by
-
- 2 edits in trunk/Source/JavaScriptCore
String replace with the empty string means string removal
https://bugs.webkit.org/show_bug.cgi?id=65799
Reviewed by Sam Weinig.
Optimization for String.prototype.replace([RegExp], ""), this improves v8-regexp by ~3%.
- runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::stringProtoFuncReplace):
- 7:07 PM Changeset in webkit [92539] by
-
- 1 edit3 adds in trunk/LayoutTests
r92330 has been rolled out so its rebaseline needs to be reverted as well
https://bugs.webkit.org/show_bug.cgi?id=65805
- platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Added.
- platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Added.
- platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
- 7:00 PM Changeset in webkit [92538] by
-
- 11 edits2 adds in trunk/Source/WebCore
Adding a WebVTTParser for <track>.
https://bugs.webkit.org/show_bug.cgi?id=62882
Patch by Anna Cavender <annacc@chromium.org> on 2011-08-05
Reviewed by Eric Carlson.
Feature is hidden behind VIDEO_TRACK feature define, which is turned off, but
new tests have been added in media/track/ (and are skipped).
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- html/TextTrackCue.cpp:
- html/TextTrackCue.h:
- platform/track/CueParser.cpp:
- platform/track/CueParser.h:
- platform/track/CueParserPrivate.h:
- platform/track/WebVTTParser.cpp: Added.
- platform/track/WebVTTParser.h: Added.
- 6:47 PM Changeset in webkit [92537] by
-
- 10 edits2 deletes in trunk
Unreviewed, rolling out r92330.
http://trac.webkit.org/changeset/92330
https://bugs.webkit.org/show_bug.cgi?id=65804
caused various regressions in paste (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05
Source/WebCore:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::doApply):
- editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearance):
- editing/markup.h:
LayoutTests:
- editing/pasteboard/5065605-expected.txt:
- editing/pasteboard/copy-paste-text-in-h1-expected.txt: Removed.
- editing/pasteboard/copy-paste-text-in-h1.html: Removed.
- editing/pasteboard/display-block-on-spans-expected.txt:
- editing/pasteboard/paste-pre-001-expected.txt:
- editing/pasteboard/paste-pre-002-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- 6:45 PM Changeset in webkit [92536] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Chromium] Remove JSZombie references from gyp project files.
https://bugs.webkit.org/show_bug.cgi?id=65798
JSC runtime/JSZombie.{cpp,h} were removed in r92046. Remove references to these
file names from the gyp projects.
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Darin Adler.
- JavaScriptCore.gypi: zombies be gone.
- 6:33 PM Changeset in webkit [92535] by
-
- 1 edit2 copies in branches/chromium/835
Merge 91908
BUG=90668
- 6:31 PM Changeset in webkit [92534] by
-
- 1 edit2 copies in branches/chromium/782
Merge 91908
BUG=90668
Review URL: http://codereview.chromium.org/7550057
- 6:06 PM Changeset in webkit [92533] by
-
- 15 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r92477.
http://trac.webkit.org/changeset/92477
https://bugs.webkit.org/show_bug.cgi?id=62619
Layering violation. We should not use WebCore/dom/ in
WebCore/platform/.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::valueChanged):
- html/ColorInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::chrome):
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::detach):
- html/InputType.cpp:
- html/InputType.h:
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
- platform/ColorChooser.cpp: Removed.
- platform/ColorChooser.h: Removed.
- 5:47 PM Changeset in webkit [92532] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Qt Mac build.
- plugins/mac/PluginViewMac.mm: Removed PluginHalter functions.
- 5:41 PM Changeset in webkit [92531] by
-
- 2 edits in trunk/LayoutTests
Skip a failing test added by r92526 to Qt's skipped list.
The failure is tracked by the bug 65801.
- platform/qt/Skipped:
- 5:24 PM Changeset in webkit [92530] by
-
- 2 edits in trunk/Source/WebCore
Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
https://bugs.webkit.org/show_bug.cgi?id=65789
Reviewed by David Kilzer.
Fix a leak by adopting an allocation instead of retaining it.
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::httpBodyFromRequest):
- 5:15 PM Changeset in webkit [92529] by
-
- 2 edits in trunk/Source/WebCore
Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
https://bugs.webkit.org/show_bug.cgi?id=65762
Patch by Ben Wells <benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.
No intended change in behaviour, no new tests.
- rendering/RenderBoxModelObject.cpp:
(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
- 5:06 PM Changeset in webkit [92528] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix on 32-bit Mac.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag): Added a cast to int.
- 4:53 PM Changeset in webkit [92527] by
-
- 2 edits in trunk/LayoutTests
Skip test eeza-Pro-vertical-metrics-adjustment.html in chromium.
- platform/chromium/test_expectations.txt:
- 4:41 PM Changeset in webkit [92526] by
-
- 3 edits4 copies in trunk
Upwards cursor movement incorrect when previous block ends with <br>
https://bugs.webkit.org/show_bug.cgi?id=33247
Reviewed by Tony Chang.
Source/WebCore:
The bug was caused by previousLinePosition's trying to obtain the root line box at the position
after the previous line's br. This obviously fails because the the position after br is considered
as a part of the next line.
Fixed the bug by obtaining root inline boxes using position at the minimum caret offset as supposed
to maximum caret offset. The code was initially introduced by r32508 to fix arrow key movement in RTL text
but the test added by the revision continues to pass after this change. Furthermore, this change makes
new code consistent with nextLinePosition.
Also reverted the change added by r55613 because it is no longer needed.
Tests: editing/execCommand/move-selection-back-line-rtl.html
editing/execCommand/move-selection-back-line-strict.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
LayoutTests:
Added tests to ensure WebKit lets user move caret up in strict mode and in RTL content
when the previous line ends with a br.
- editing/execCommand/move-selection-back-line-rtl-expected.txt: Copied from
LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.
- editing/execCommand/move-selection-back-line-rtl.html: Copied from
LayoutTests/editing/execCommand/move-selection-back-line.html.
- editing/execCommand/move-selection-back-line-strict-expected.txt: Copied from
LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.
- editing/execCommand/move-selection-back-line-strict.html: Copied from
LayoutTests/editing/execCommand/move-selection-back-line.html.
- 4:03 PM Changeset in webkit [92525] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:02 PM Changeset in webkit [92524] by
-
- 1 copy in tags/Safari-534.51.7
New tag.
- 3:36 PM Changeset in webkit [92523] by
-
- 3 edits in trunk/Source/JavaScriptCore
<http://webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
is tied to a particular dispatch queue
A RefCounted object can be opted in to this mode by calling setDispatchQueueForVerifier
with the dispatch queue it will be tied to. This will cause ThreadRestrictionVerifier
to ensure that all operations are performed on the given dispatch queue.
Reviewed by Anders Carlsson.
- wtf/RefCounted.h:
(WTF::RefCountedBase::setDispatchQueueForVerifier):
- wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::~ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::setShared):
(WTF::ThreadRestrictionVerifier::isSafeToUse):
- 3:33 PM Changeset in webkit [92522] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Build Fix.
- 3:15 PM Changeset in webkit [92521] by
-
- 1 edit2 copies in branches/chromium/782
Merge 91531
BUG=89552
Review URL: http://codereview.chromium.org/7585022
- 3:14 PM Changeset in webkit [92520] by
-
- 24 edits2 adds in trunk/Source
[chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402
Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.
Source/WebCore:
Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.
- page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
- page/Page.h:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.h:
Source/WebKit/chromium:
Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.
- public/WebGraphicsContext3D.h:
- src/Extensions3DChromium.cpp:
- src/GraphicsContext3DChromium.cpp:
- src/GraphicsContext3DInternal.h:
- 3:12 PM Changeset in webkit [92519] by
-
- 1 edit2 copies in branches/chromium/782
Merge 91308
BUG=89575
Review URL: http://codereview.chromium.org/7541053
- 3:08 PM Changeset in webkit [92518] by
-
- 6 edits5 copies9 adds in trunk/LayoutTests
Add more Lion specific test results and add more tests to the skipped list.
- platform/mac-lion/Skipped:
- platform/mac-snowleopard/fast/dom: Added.
- platform/mac-snowleopard/fast/dom/52776-expected.png: Copied from platform/mac/fast/dom/52776-expected.png.
- platform/mac-snowleopard/fast/dom/52776-expected.txt: Copied from platform/mac/fast/dom/52776-expected.txt.
- platform/mac-snowleopard/fast/loader: Added.
- platform/mac-snowleopard/fast/preloader: Added.
- platform/mac-snowleopard/fast/preloader/document-write-2-expected.txt: Copied from fast/preloader/document-write-2-expected.txt.
- platform/mac-snowleopard/fast/preloader/document-write-expected.txt: Copied from fast/preloader/document-write-expected.txt.
- platform/mac-snowleopard/fast/preloader/script-expected.txt: Copied from fast/preloader/script-expected.txt.
- platform/mac/fast/dom/52776-expected.png:
- platform/mac/fast/dom/52776-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- platform/mac/fast/preloader: Added.
- platform/mac/fast/preloader/document-write-2-expected.txt: Added.
- platform/mac/fast/preloader/document-write-expected.txt: Added.
- platform/mac/fast/preloader/script-expected.txt: Added.
- 3:02 PM Changeset in webkit [92517] by
-
- 2 edits in trunk/LayoutTests
Skip canvas-putImageData.html in chromium.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [92516] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Build Fix.
- 2:33 PM Changeset in webkit [92515] by
-
- 2 edits in trunk/Tools
Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
- Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
- 2:09 PM Changeset in webkit [92514] by
-
- 2 edits in trunk/Tools
Garden-o-matic updateexpectations needs a unit test.
https://bugs.webkit.org/show_bug.cgi?id=65780
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
- 2:07 PM Changeset in webkit [92513] by
-
- 5 edits in trunk
Future proof an Objective-C test
https://bugs.webkit.org/show_bug.cgi?id=65788
Tools:
Reviewed by Dan Bernstein.
Add isObjectInstanceOf to ObjCController.
- DumpRenderTree/mac/ObjCController.m:
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController isObject:instanceOf:]):
LayoutTests:
Don't check explicitly for class names; just check that the objects are instances of the right classes.
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- 2:00 PM Changeset in webkit [92512] by
-
- 6 edits in branches/safari-534.51-branch/Source/WebKit/win
Merge r92414.
- 1:55 PM Changeset in webkit [92511] by
-
- 8 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92404.
- 1:50 PM Changeset in webkit [92510] by
-
- 2 edits4 copies in branches/chromium/782
Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7569017
- 1:49 PM Changeset in webkit [92509] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r92345.
- 1:47 PM Changeset in webkit [92508] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92398.
- 1:40 PM Changeset in webkit [92507] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92309.
- 1:38 PM Changeset in webkit [92506] by
-
- 3 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92308.
- 1:34 PM Changeset in webkit [92505] by
-
- 2 edits4 copies in branches/chromium/835
Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7585017
- 1:33 PM Changeset in webkit [92504] by
-
- 4 edits in branches/safari-534.51-branch/Source
Merge r92210.
- 1:33 PM Changeset in webkit [92503] by
-
- 2 edits4 copies in branches/chromium/782
Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7491067
- 1:29 PM Changeset in webkit [92502] by
-
- 1 edit1 copy2 adds in trunk/LayoutTests
Add a Lion specific test for fast/repaint/canvas-putImageData.html
- platform/mac-snowleopard/fast/repaint: Added.
- platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from fast/repaint/canvas-putImageData-expected.txt.
- platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
- 1:26 PM Changeset in webkit [92501] by
-
- 1 edit2 copies in branches/chromium/782
Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7550046
- 1:20 PM Changeset in webkit [92500] by
-
- 1 edit in trunk/Source/WebCore/WebCore.gypi
Actually commit the file.
- 1:19 PM Changeset in webkit [92499] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix Chromium build.
- WebCore.gypi:
- 1:03 PM Changeset in webkit [92498] by
-
- 7 edits in trunk/Source/JavaScriptCore
Inline allocation of function objects
https://bugs.webkit.org/show_bug.cgi?id=65779
Reviewed by Gavin Barraclough.
Inline allocation and initilisation of function objects
in generated code. This ended up being a 60-70% improvement
in function allocation performance. This improvement shows
up as a ~2% improvement in 32bit sunspider and V8, but is a
wash on 64-bit.
We currently don't inline the allocation of named function
expressions, as that requires being able to gc allocate a
variable object.
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JSC::JIT::emitStoreCell):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):
- jit/JITOpcodes32_64.cpp:
Removed duplicate implementation of op_new_func and op_new_func_exp
- runtime/JSFunction.h:
(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):
- 12:55 PM Changeset in webkit [92497] by
-
- 2 edits1 add in trunk/Tools
trac.js needs unittests
https://bugs.webkit.org/show_bug.cgi?id=65673
Reviewed by Dimitri Glazkov.
This tests also have somewhat large fixtures. I've trimmed the example
XML down a bunch while still hitting interesting cases in the parsing.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
- 12:49 PM Changeset in webkit [92496] by
-
- 24 edits20 copies1 add in trunk/LayoutTests
Add more Lion specific test results.
- platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Copied from platform/mac/fast/text/capitalize-boundaries-expected.png.
- platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.txt: Copied from platform/mac/fast/text/capitalize-boundaries-expected.txt.
- platform/mac-snowleopard/fast/text/complex-text-opacity-expected.png: Copied from platform/mac/fast/text/complex-text-opacity-expected.png.
- platform/mac-snowleopard/fast/text/complex-text-opacity-expected.txt: Copied from platform/mac/fast/text/complex-text-opacity-expected.txt.
- platform/mac-snowleopard/fast/text/international: Added.
- platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
- platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
- platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
- platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.png.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
- platform/mac-snowleopard/fast/text/international/bold-bengali-expected.png: Copied from platform/mac/fast/text/international/bold-bengali-expected.png.
- platform/mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Copied from platform/mac/fast/text/international/bold-bengali-expected.txt.
- platform/mac-snowleopard/fast/text/international/khmer-selection-expected.png: Copied from platform/mac/fast/text/international/khmer-selection-expected.png.
- platform/mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Copied from platform/mac/fast/text/international/khmer-selection-expected.txt.
- platform/mac/fast/text/capitalize-boundaries-expected.png:
- platform/mac/fast/text/capitalize-boundaries-expected.txt:
- platform/mac/fast/text/complex-text-opacity-expected.png:
- platform/mac/fast/text/complex-text-opacity-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.png:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- platform/mac/fast/text/international/bold-bengali-expected.png:
- platform/mac/fast/text/international/bold-bengali-expected.txt:
- platform/mac/fast/text/international/khmer-selection-expected.png:
- platform/mac/fast/text/international/khmer-selection-expected.txt:
- platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
- platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
- platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
- 12:41 PM Changeset in webkit [92495] by
-
- 2 edits in trunk/LayoutTests
Add two fast/text tests to the skipped list.
- platform/mac-lion/Skipped:
- 12:24 PM Changeset in webkit [92494] by
-
- 11 edits10 copies3 adds in trunk/LayoutTests
Add Lion specific test results for css1 and css2.1.
- platform/mac-snowleopard/css1: Added.
- platform/mac-snowleopard/css1/font_properties: Added.
- platform/mac-snowleopard/css1/font_properties/font-expected.png: Copied from platform/mac/css1/font_properties/font-expected.png.
- platform/mac-snowleopard/css1/font_properties/font-expected.txt: Copied from platform/mac/css1/font_properties/font-expected.txt.
- platform/mac-snowleopard/css2.1: Added.
- platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.png.
- platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.txt.
- platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.png.
- platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.txt.
- platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.png.
- platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.txt.
- platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.png.
- platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.txt.
- platform/mac/css1/font_properties/font-expected.png:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css2.1/t1202-counter-09-b-expected.png:
- platform/mac/css2.1/t1202-counter-09-b-expected.txt:
- platform/mac/css2.1/t1202-counters-09-b-expected.png:
- platform/mac/css2.1/t1202-counters-09-b-expected.txt:
- platform/mac/css2.1/t1508-c527-font-05-b-expected.png:
- platform/mac/css2.1/t1508-c527-font-05-b-expected.txt:
- platform/mac/css2.1/t1508-c527-font-10-c-expected.png:
- platform/mac/css2.1/t1508-c527-font-10-c-expected.txt:
- 11:50 AM Changeset in webkit [92493] by
-
- 10 edits in trunk/Tools
Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
https://bugs.webkit.org/show_bug.cgi?id=65759
Reviewed by Dimitri Glazkov.
rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
architecture, is poorly tested, and has a bunch of quirks. This patch
rebuilds the core functionality of rebaseline-chromium-webkit-tests on
top of more modern infrastructure. In the process, we get more code
re-use and better testing.
Once we're satisfied with this new implementation, we can delete the
old implementation.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/net/web.py:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- 11:44 AM Changeset in webkit [92492] by
-
- 45 edits9 deletes in trunk
Remove PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=65729
Reviewed by Darin Adler.
Source/WebCore:
Remove plug-in halter and associated classes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h:
- page/HaltablePlugin.h: Removed.
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
- page/PluginHalter.cpp: Removed.
- page/PluginHalter.h: Removed.
- page/PluginHalterClient.h: Removed.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
- plugins/gtk/PluginViewGtk.cpp:
- plugins/qt/PluginViewQt.cpp:
- plugins/win/PluginViewWin.cpp:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/RenderWidget.h:
Source/WebKit:
Remove deleted files from Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Remove plug-in halter and associated classes.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):
- WebCoreSupport/WebPluginHalterClient.h: Removed.
- WebCoreSupport/WebPluginHalterClient.mm: Removed.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):
- WebView/WebViewPrivate.h:
Source/WebKit/win:
Remove plug-in halter and associated classes.
- Interfaces/IWebPluginHalterDelegate.idl: Removed.
- Interfaces/IWebPreferencesPrivate.idl:
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebPluginHalterClient.cpp: Removed.
- WebCoreSupport/WebPluginHalterClient.h: Removed.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
- WebPreferences.h:
- WebView.cpp:
(WebView::close):
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
(WebView::unused1):
(WebView::unused2):
(WebView::unused3):
(WebView::unused4):
(WebView::unused5):
- WebView.h:
Source/WebKit/wx:
Don't include PluginHalterClient.h, it's been removed.
- WebView.cpp:
Tools:
Remove call to set the allowed plug-in run time.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- 11:23 AM Changeset in webkit [92491] by
-
- 3 edits in trunk/Source/WebKit2
Reviewed by Anders Carlsson.
[WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state
https://bugs.webkit.org/show_bug.cgi?id=63779
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent): Unrelated cleanup. Removed unneeded local variable.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates): Rearranged code so that the call to
setPaintBehavior is after the early exit. Also got rid of unneeded save/restore since
the function uses a graphics context that it then throws away.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Ditto.
- 11:18 AM Changeset in webkit [92490] by
-
- 3 edits2 copies in branches/safari-534.51-branch/Source/WebCore
Merge r92035.
- 11:14 AM Changeset in webkit [92489] by
-
- 3 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92034.
- 11:04 AM Changeset in webkit [92488] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip those tests still failing on chromium due to incomplete
baseline caused by r92466.
- platform/chromium/test_expectations.txt:
- 11:02 AM Changeset in webkit [92487] by
-
- 5 edits in trunk/Source
Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544
Reviewed by Darin Fisher.
Source/WebCore:
- platform/network/chromium/ResourceRequest.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit/chromium:
- public/WebURLRequest.h:
- 10:58 AM Changeset in webkit [92486] by
-
- 2 edits in branches/chromium/835/Source/WebCore
Merge 92319 - Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575
This change adjusts the position of search tickmarks so that they are correctly centered.
Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7584008
- 10:56 AM Changeset in webkit [92485] by
-
- 2 edits in branches/chromium/835/Source/WebCore
Merge 92316 - Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586
On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.
- platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7582015
- 10:19 AM BuildingQtOnLinux edited by
- Note about how to choose webkit2 as the build target. (diff)
- 10:13 AM Changeset in webkit [92484] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r92433): media/video-src-change.html fails
https://bugs.webkit.org/show_bug.cgi?id=65771
Reviewed by Dimitri Glazkov.
Give the listener as the second argument to removeEventListener.
- media/video-src-change.html:
- 9:56 AM Changeset in webkit [92483] by
-
- 2 edits in trunk/LayoutTests
compositing/video/video-background-color.html test does not produce correct output
https://bugs.webkit.org/show_bug.cgi?id=55519
Unreviewed.
Chromium doesn't support video codecs that support alpha, so stop
running (and failing) a test that depends on codecs supporting alpha.
Patch by Ami Fischman <fischman@chromium.org> on 2011-08-05
- platform/chromium/test_expectations.txt:
- 9:27 AM Changeset in webkit [92482] by
-
- 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Merge 92388 - Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700
Reviewed by James Robinson.
No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7582010
- 8:40 AM Changeset in webkit [92481] by
-
- 2 edits in trunk/Tools
Unreviewed build fix for Qt-Minimal buildbot
Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
is disabled.
Rubber-stamped by Holger Freyther.
- QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
- 8:08 AM BuildingQtOnLinux edited by
- Adding a small remark about QT5 and QTDIR environment variable. (diff)
- 7:36 AM Changeset in webkit [92480] by
-
- 6 edits6 adds in trunk
dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428
Reviewed by Darin Adler.
Source/WebCore:
Changed the directionality algorithm to evaluate the value of input elements and textarea elements when
they have the attribute dir-auto Set.
Also skip these elements when evaluating the directionality of their ancestors.
HTMLTextAreaElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().
HTMLInputElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().
Tests: fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::directionality):
- html/HTMLElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
LayoutTests:
- fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
- fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
- fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
- fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
- fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
- fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.
- 7:17 AM Changeset in webkit [92479] by
-
- 2 edits in trunk/Source/WebKit/qt
Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-05
Reviewed by Andreas Kling.
Reverted commit r87797, http://trac.webkit.org/changeset/87797, because it
causes the regression reported under bug# 63582.
[Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.
https://bugs.webkit.org/show_bug.cgi?id=63582
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):
- 7:03 AM Changeset in webkit [92478] by
-
- 5 edits2 adds in trunk/Tools
[Qt] QtTestBrowser: Add support for saving cookies on disk
https://bugs.webkit.org/show_bug.cgi?id=65328
Simple cookiejar that saves cookies on disk.
Added menu options to clear cookies (Edit->Clear cookies) and
disable disk cookies (Settings->[ ]Save Cookies on Disk).
Option -no-disk-cookies is also available.
Reviewed by Andreas Kling.
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/cookiejar.cpp: Added.
- QtTestBrowser/cookiejar.h: Added.
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/main.cpp:
- 6:45 AM Changeset in webkit [92477] by
-
- 15 edits2 adds in trunk/Source/WebCore
Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619
Reviewed by Kent Tamura.
- WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and
ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE
- WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
- html/ColorInputType.cpp:
(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::closeColorChooserIfClientIsInDocument): Close color chooser if element is in
document. Called when the page navigates away.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.
- html/ColorInputType.h:
- html/FileInputType.cpp:
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::detach): Calls InputType::detach
- html/InputType.cpp:
(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.
- html/InputType.h:
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::openColorChooser): Added.
(WebCore::EmptyChromeClient::closeColorChooser): Added.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Added.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Close color chooser when
navigating away from the page.
- page/Chrome.cpp:
(WebCore::Chrome::openColorChooser): Added. Opens the color chooser.
(WebCore::Chrome::closeColorChooser): Added. Tries to close the color chooser. Might not close if the
listener of the color chooser is another part of the browser or another render process.
(WebCore::Chrome::setSelectedColorInColorChooser): Added. Sets the selected color in the color chooser.
Again, might not be executed if the listener of the color chooser is another part of the browser or another render process.
- page/Chrome.h:
- page/ChromeClient.h:
- platform/ColorChooser.cpp: Added.
(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::closeColorChooserIfClientIsInDocument): Close the color chooser if the client is
inside the document.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.
- platform/ColorChooser.h: Added.
(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.
- 6:16 AM Changeset in webkit [92476] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: check that detaching frame has been attached before removing it from the console selector
https://bugs.webkit.org/show_bug.cgi?id=65686
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
- 5:18 AM Changeset in webkit [92475] by
-
- 2 edits in trunk/Source/WebCore
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 4:39 AM Changeset in webkit [92474] by
-
- 2 edits in trunk/LayoutTests
[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364
Unreviewed: unskipping tests now that the test was fixed.
- platform/qt/Skipped:
- 3:16 AM Changeset in webkit [92473] by
-
- 19 edits in trunk/Source/WebKit/efl
[EFL] Move API documentation of ewk files to the headers
https://bugs.webkit.org/show_bug.cgi?id=65373
There are two arguments for this:
- Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
- It will be consistent with structures descriptions.
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-05
Reviewed by Kent Tamura.
- ewk/ewk_auth.cpp:
- ewk/ewk_auth.h:
- ewk/ewk_contextmenu.cpp:
- ewk/ewk_contextmenu.h:
- ewk/ewk_cookies.cpp:
- ewk/ewk_cookies.h:
- ewk/ewk_frame.cpp:
- ewk/ewk_frame.h:
- ewk/ewk_history.cpp:
- ewk/ewk_history.h:
- ewk/ewk_main.cpp:
- ewk/ewk_main.h:
- ewk/ewk_network.cpp:
- ewk/ewk_network.h:
- ewk/ewk_settings.cpp:
- ewk/ewk_settings.h:
- ewk/ewk_window_features.cpp:
- ewk/ewk_window_features.h:
- 2:40 AM Changeset in webkit [92472] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip 2 crashy tests on Qt SnowLeopard Intel Release bot to make a green world,
- platform/qt-mac/Skipped:
- 2:37 AM Changeset in webkit [92471] by
-
- 8 edits in trunk
Web Inspector: constrain maximum depth for returnByValue objects
https://bugs.webkit.org/show_bug.cgi?id=65761
Source/WebCore:
Set maximum depth to 20 for objects returned by value as a result of evaluations.
Reviewed by Pavel Feldman.
- bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
- bindings/v8/ScriptValue.cpp:
(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::makeCall):
- inspector/InspectorValues.h:
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/protocol/runtime-agent-expected.txt:
- inspector/protocol/runtime-agent.html:
- 2:30 AM Changeset in webkit [92470] by
-
- 2 edits in trunk/LayoutTests
[Qt] Add http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
to Skiplist because it makes ARMv5 Linux Qt Release weepy.
- platform/qt-arm/Skipped:
- 1:57 AM Changeset in webkit [92469] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from appcache IDL files
https://bugs.webkit.org/show_bug.cgi?id=65752
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- loader/appcache/DOMApplicationCache.idl:
- 1:42 AM Changeset in webkit [92468] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Stop using free-lists for database/object store/index ids.
https://bugs.webkit.org/show_bug.cgi?id=65678
Reviewed by Tony Chang.
Don't use free-lists for database/object store/index ids,
just assign increasing numbers.
It turns out that deleting an object store and creating a new one with
the same id would cause the delete markers from the old object store to
slow down lookups into the new one. Therefore we should generate
a new id every time. Running out of ids (64 bits for databases and
object stores, 32 bits for indices) is not realistic.
Also make functions that generate new ids report errors, and make the
callers of those functions check the return values.
We must still delete free-lists when deleting an object store, and we
must keep the code for encoding/decoding/comparison of free-list keys
since users might have them in their databases.
This is just a performance optimization, so no new tests.
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
- 1:37 AM Changeset in webkit [92467] by
-
- 2 edits in trunk/LayoutTests
[Qt] Ossyize fast/forms/enter-clicks-buttons.html because
it makes Qt SnowLeopard Intel Release bot bleeding after r92375.
- platform/qt-mac/Skipped:
- 1:33 AM Changeset in webkit [92466] by
-
- 48 edits in trunk/LayoutTests
[chromium] Rebaseline following r92255.
https://bugs.webkit.org/show_bug.cgi?id=65736
Patch by David Reveman <reveman@chromium.org> on 2011-08-05
Reviewed by James Robinson.
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
- platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-transformed-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
- platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
- platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-gpu-mac/media/video-transformed-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
- platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-gpu-win/media/video-transformed-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
- platform/chromium/test_expectations.txt:
- 1:28 AM Changeset in webkit [92465] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758
Chromium test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 1:24 AM Changeset in webkit [92464] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757
Chromium test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 1:21 AM Changeset in webkit [92463] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed: change an instance of isImportRule() that was overlooked in commit 92448.
No new tests. (No functional change)
- xml/XSLImportRule.h:
(WebCore::XSLImportRule::isImportRule):
- 1:19 AM Changeset in webkit [92462] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from remaining SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65751
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- svg/SVGElementInstance.idl:
- 12:51 AM Changeset in webkit [92461] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: do not delay scroll event handling - scroll is already async.
https://bugs.webkit.org/show_bug.cgi?id=65693
Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-05
Reviewed by Yury Semikhatsky.
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncScroll):
- 12:48 AM Changeset in webkit [92460] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754
Chromium test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 12:45 AM Changeset in webkit [92459] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from web audio API
https://bugs.webkit.org/show_bug.cgi?id=65750
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- webaudio/AudioBufferSourceNode.idl:
- 12:43 AM Changeset in webkit [92458] by
-
- 5 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from Web Workers
https://bugs.webkit.org/show_bug.cgi?id=65746
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- workers/AbstractWorker.idl:
- workers/DedicatedWorkerContext.idl:
- workers/Worker.idl:
- workers/WorkerContext.idl:
- 12:34 AM Changeset in webkit [92457] by
-
- 17 edits6 adds in trunk
Parsing CSS3 font-feature-settings property
https://bugs.webkit.org/show_bug.cgi?id=63618
Source/WebCore:
Introduces CSS3 font-feature-settings property as -webkit-font-feature-settings. This change only contains parsing part. Parsed information are stored in FontDescription class.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.
Test: css3/font-feature-settings-parsing.html
- CMakeLists.txt: Added FontFeatureValue.{h,cpp} and FontFeatureSettings.{h,cpp}.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added CSSPropertyWebkitFontFeatureSettings.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Added parsing code for -webkit-font-feature-settings.
(WebCore::CSSParser::parseFontFeatureTag): Added.
(WebCore::CSSParser::parseFontFeatureSettings): Added.
- css/CSSParser.h: Added parseFontFeatureSettings().
- css/CSSPropertyNames.in: Added -webkit-font-feature-settings.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations): Modified a compile assert to follow adding -webkit-font-feature-settings.
(WebCore::CSSStyleSelector::applyProperty): Added a case clause for CSSPropertyWebkitFontFeatureSettings.
- css/CSSValue.h:
(WebCore::CSSValue::isFontFeatureValue): Added.
- css/CSSValueKeywords.in: Added 'on' and 'off' keywords.
- css/FontFeatureValue.cpp: Added.
(WebCore::FontFeatureValue::FontFeatureValue):
(WebCore::FontFeatureValue::value):
(WebCore::FontFeatureValue::cssText):
- css/FontFeatureValue.h: Added.
(WebCore::FontFeatureValue::create):
(WebCore::FontFeatureValue::tag):
(WebCore::FontFeatureValue::isFontFeatureValue):
- platform/graphics/FontDescription.cpp:
(WebCore::FontDescription::makeNormalFeatureSettings): Added.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription): Added m_featureSettings member variable.
(WebCore::FontDescription::featureSettings): Added.
(WebCore::FontDescription::setFeatureSettings): Added.
(WebCore::FontDescription::operator==): Modified to take into account m_featureSettings
- platform/graphics/FontFeatureSettings.cpp: Added.
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator=):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):
- platform/graphics/FontFeatureSettings.h: Added.
(WebCore::FontFeature::tag):
(WebCore::FontFeature::value):
(WebCore::FontFeatureSettings::create):
(WebCore::FontFeatureSettings::append):
(WebCore::FontFeatureSettings::size):
(WebCore::FontFeatureSettings::operator[]):
(WebCore::FontFeatureSettings::at):
LayoutTests:
Add parsing test case for -webkit-font-feature-settings property.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.
- css3/font-feature-settings-parsing-expected.txt: Added.
- css3/font-feature-settings-parsing.html: Added.
- 12:32 AM Changeset in webkit [92456] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from websockets
https://bugs.webkit.org/show_bug.cgi?id=65749
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- websockets/WebSocket.idl:
- 12:30 AM Changeset in webkit [92455] by
-
- 2 edits in trunk/Source/WebCore
Attempt to heal media/video-can-play-type.html and media/video-src-change.html.
- html/HTMLMediaElement.idl:
- 12:18 AM Changeset in webkit [92454] by
-
- 3 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from notifications IDL files
https://bugs.webkit.org/show_bug.cgi?id=65747
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- notifications/Notification.idl:
- notifications/NotificationCenter.idl:
- 12:00 AM Changeset in webkit [92453] by
-
- 4 edits4 deletes in trunk
Unreviewed, rolling out r92439.
http://trac.webkit.org/changeset/92439
https://bugs.webkit.org/show_bug.cgi?id=65753
Caused 9 tests to fail on Qt (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::implicitOpen):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):
LayoutTests:
- loader/document-destruction-within-unload-expected.txt: Removed.
- loader/document-destruction-within-unload.html: Removed.
- loader/resources/document-destruction-within-unload-iframe.html: Removed.
- loader/resources/document-destruction-within-unload.svg: Removed.
