⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 7, 2011:

11:38 PM Changeset in webkit [92583] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=65754

Unreviewed chromium test_expectations.txt update
No more failure as r92439 was rolled out by r92453

  • platform/chromium/test_expectations.txt:
11:02 PM Changeset in webkit [92582] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
9:06 PM Changeset in webkit [92581] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix after r92578. I accidentally added the call to dumpAsText(true).

  • editing/pasteboard/nested-blocks-with-text-area.html:
8:46 PM Changeset in webkit [92580] by rniwa@webkit.org
  • 3 edits
    2 adds
    17 deletes in trunk/LayoutTests

Dump-as-markup conversion: paste-blockquote-into-blockquote.html and prevent-block-nesting-01.html
​https://bugs.webkit.org/show_bug.cgi?id=65837

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
  • editing/pasteboard/prevent-block-nesting-01.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
8:31 PM Changeset in webkit [92579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65758

Test is now green on chromium and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:47 PM Changeset in webkit [92578] by rniwa@webkit.org
  • 3 edits
    2 adds
    23 deletes in trunk/LayoutTests

Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html
​https://bugs.webkit.org/show_bug.cgi?id=65836

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-area.html:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-field.html:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
7:28 PM Changeset in webkit [92577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65757

This test and the others mentioned in the bug are now green on chromium
and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [92576] by koz@chromium.org
  • 8 edits in trunk/Source

Make the fullscreen JS API enabled at runtime.
​https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

  • dom/Document.idl:
  • dom/Element.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

3:16 PM Changeset in webkit [92575] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-through-* results diverging between bots
​https://bugs.webkit.org/show_bug.cgi?id=65831

Unreviewed Qt gardening.

  • platform/qt/Skipped:
12:42 PM Changeset in webkit [92574] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
​https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

  • UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

6:47 AM Changeset in webkit [92573] by Martin Robinson
  • 5 edits in trunk/Source

Distribution fix for GTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Strip removed files from the source list.

Source/WebCore:

  • GNUmakefile.am: Add some files to the distribution list.
  • GNUmakefile.list.am: Strip removed files from the source list.
4:29 AM Changeset in webkit [92572] by jochen@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

Move FrameLoadRequest to loader/
​https://bugs.webkit.org/show_bug.cgi?id=65817

Reviewed by Alexey Proskuryakov.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::requester):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):

2:48 AM Changeset in webkit [92571] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Source/WebCore: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

New AccessibilityObject cache search functionality and API for the mac
platform to expose it. At this point the AccessibilityObject cache can
be searched using one of the supported search keys that have been defined
in AccessibilityObject.h, or by passing search text.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-predicate.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::accessibilityObjectContainsText):
(WebCore::AccessibilityObject::accessibleObjectsWithAccessibilitySearchPredicate):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Added testing support for AccessibilityObject cache searching. Currently,
only the mac platform is full supported and has had API exposed. Other
platforms have only have this new functionality stubbed. Full implementation
is a job suited only for an accessibility expert of each respective platform.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Tests for the new AccessibilityObject cache search API and the additional
functionality in the AccessibilityObject class that makes AccessibilityObject
cache searching possible.

Additional tests for finding frames, misspellings, and visited links will be
included in a subsequent patch.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/search-predicate-expected.txt: Added.
  • platform/mac/accessibility/search-predicate.html: Added.
1:01 AM Changeset in webkit [92570] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Rebaseline a test on GTK+ for which r92554 checked in an
incorrect result.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Update results.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Ditto.

Aug 6, 2011:

8:44 PM Changeset in webkit [92569] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.

Reviewed by Oliver Hunt.

This is a 1% win on SunSpider.

  • dfg/DFGOperations.cpp:
    • Use fastGetOwnProperty.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Use fastGetOwnProperty.
  • runtime/JSCell.h:
  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnProperty):

  • Fast call to get a property without creating an identifier the first time.
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

  • Add interface to look up by either strinsg or identifiers.
  • runtime/Structure.h:

(JSC::Structure::get):

  • Add a get() call that takes a UString, not an Identifier.
  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasHash):

  • Add a call to check if the has has been set (to detect the first use as a property name).
6:09 PM Changeset in webkit [92568] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.

6:09 PM Changeset in webkit [92567] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Adopt the newly-allocated WebHTMLConverter
instance so that it does not leak.

4:35 PM Changeset in webkit [92566] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.
Fix environmental differencies in the results added in r92564.
I was in the wrong chroot.

  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
3:36 PM Changeset in webkit [92565] by siddharth.mathur@nokia.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add Siddharth Mathur to committer list. Unreviewed

3:29 PM Changeset in webkit [92564] by kbalazs@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed gardening.
Add missing Qt results.

  • platform/qt/Skipped:
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
3:19 PM Changeset in webkit [92563] by abarth@webkit.org
  • 6 edits
    6 deletes in trunk/Tools

Remove dead code in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=65818

Reviewed by Dimitri Glazkov.

This code was added to support the rebaseline2 command six months ago,
but the rebaseline2 command was never finished and no one else has used
this code since it was landed. This patch removes the dead code. If
we revive rebaseline2, then we can revert this patch and recover the
code. Until then, this code is just dead weight.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/testoutput.py: Removed.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:17 PM Changeset in webkit [92562] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit-patch optimize-baselines can't handle promotions to base results directory
​https://bugs.webkit.org/show_bug.cgi?id=65819

Reviewed by Dimitri Glazkov.

This bug came up when testing the optimizer on some editing baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3:04 PM Changeset in webkit [92561] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Fix baselines for cross-origin-xsl-BLOCKED.html. These results
uncovered a subtle bug in webkit-patch bulk-optimize-baselines, which
I'll fix in a follow-up patch.

  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
2:24 PM Changeset in webkit [92560] by abarth@webkit.org
  • 1 edit
    3 adds
    8 deletes in trunk/LayoutTests

Optimize expected results for editing.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-paste-float-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
2:11 PM Changeset in webkit [92559] by abarth@webkit.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Optimize expected results for animations.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium/animations/keyframes-rule-expected.txt: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Removed.
2:07 PM Changeset in webkit [92558] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add a small command to optimize baselines in bulk.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
1:48 PM Changeset in webkit [92557] by abarth@webkit.org
  • 1 edit
    50 adds
    82 deletes in trunk/LayoutTests

Optimize expected results for http/tests/security.
This patch was created with webkit-patch optimize-baselines.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium/http/tests/security/dataURL: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/frameNavigation: Added.
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/listener: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-eval-expected.txt: Added.
1:17 PM Changeset in webkit [92556] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Fix Timer heap implementation to work with more libraries (other versions of STL)
​https://bugs.webkit.org/show_bug.cgi?id=65782

Reviewed by Anders Carlsson.

No behavior change, so no tests needed. Existing tests pass.

  • platform/Timer.cpp: Added TimerHeapPointer and TimerHeapReference class

alongside the TimerHeapIterator class. Also added a swap function. Also
added a TimerHeapLessThanFunction class.
(WebCore::TimerBase::heapDecreaseKey): Pass pointers in to the TimerHeapIterator
since that's how the class works now. Pass a TimerHeapLessThanFunction object
instead of letting the library use the < operator directly.
(WebCore::TimerBase::heapPopMin): Ditto.

  • platform/Timer.h: Updated for above changes.
12:52 PM Changeset in webkit [92555] by commit-queue@webkit.org
  • 11 edits in trunk

Patch by Aron Rosenberg <​arosenberg@logitech.com> on 2011-08-06
Reviewed by Benjamin Poulain.

[Qt] Fix build with Intel compiler on Windows
​https://bugs.webkit.org/show_bug.cgi?id=65088

.:

Disable Intel Compiler warning 873 - function "" has no corresponding operator
delete (to be called if an exception is thrown during initialization of an
allocated object).

  • Source/WebKit.pri:

Source/JavaScriptCore:

Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays

Source/WebCore:

Intel compiler needs .lib suffixes instead of .a

  • WebCore.pri:

Source/WebKit2:

Intel compiler needs .lib suffixes instead of .a

  • WebKit2.pri:
10:09 AM Changeset in webkit [92554] by Nikolas Zimmermann
  • 6 edits
    2 deletes in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Rebaseline some tests on Leopard/gtk/qt in order to get the bots greener.

Not reviewed.


  • platform/gtk/Skipped:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
10:00 AM Changeset in webkit [92553] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
​https://bugs.webkit.org/show_bug.cgi?id=65809

Reviewed by Darin Adler and Sam Weinig.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.

  • platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.

9:17 AM Changeset in webkit [92552] by Joseph Pecoraro
  • 5 edits in trunk/Source

Potential Leaks - RetainPtr<> over retaining Create'd objects
​https://bugs.webkit.org/show_bug.cgi?id=65806

Reviewed by Darin Adler.

Fix a possible leak by adopting an allocation instead of retaining it.

Source/WebCore:

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView previousValidKeyView]):

8:57 AM Changeset in webkit [92551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION (r91540): Favicons are not loaded
​https://bugs.webkit.org/show_bug.cgi?id=65692

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.

The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::documentCanHaveIcon):

  • loader/icon/IconDatabaseBase.h:
8:23 AM Changeset in webkit [92550] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)

  • try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.

Rubber-stamped by Antti Koivisto.

  • svg/zoom/resources/testPageZoom.js: (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().
3:02 AM Changeset in webkit [92549] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should use C++-style cast in CSSParser.cpp
​https://bugs.webkit.org/show_bug.cgi?id=65807

Replaces C-style cast with C++style cast.

Reviewed by Shinichiro Hamaji.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):

2:40 AM Changeset in webkit [92548] by Nikolas Zimmermann
  • 3 edits
    6 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.


Not reviewed.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
2:27 AM Changeset in webkit [92547] by Nikolas Zimmermann
  • 4 edits
    2 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.

Not reviewed.

  • platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
2:19 AM Changeset in webkit [92546] by Nikolas Zimmermann
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Follow-up for r92545.


Rebaseline some tests on gtk/qt and win.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
1:25 AM Changeset in webkit [92545] by Nikolas Zimmermann
  • 6 edits
    6 moves
    30 adds in trunk

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
​https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
Add several new tests in svg/as-object - covering bug 64974.

  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
  • svg/as-object/embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
  • svg/as-object/embedded-svg-size-changes.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes.html: Added.
  • svg/as-object/resources: Added.
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
  • svg/as-object/resources/embedded-svg-size-changes.svg: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
​https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
through RenderSVGRoot::layout.

And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
document to be laid out again, now that the size of the embedded SVG document is known.

As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
right before painting.

A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
FrameView::layout().

Consider following document:
<body><iframe src="some.svg"></body>


After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
(in the simplest case, where width/height are both auto).

Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.

After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).

The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).

Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.

Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html

svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/embedded-svg-immediate-offsetWidth-query.html
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished. (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method. (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
  • page/FrameView.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
  • rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
  • rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic. (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).
Note: See TracTimeline for information about the timeline view.