Timeline

Aug 8, 2011:

9:08 PM Changeset in webkit [92664] by tkent@chromium.org

• 7 edits in trunk/LayoutTests

[Chromium] Update baseline files for r92585.

• platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium/test_expectations.txt:

9:02 PM Changeset in webkit [92663] by cevans@google.com

• 1 edit in branches/chromium/835/Source/WebCore/rendering/CounterNode.cpp

Merge 92630
BUG=88216
Review URL: ​http://codereview.chromium.org/7601020

8:58 PM Changeset in webkit [92662] by tkent@chromium.org

• 2 edits in trunk/LayoutTests

[Windows] input-number-size.html is expected to fail because of no spin-button.

• platform/win/Skipped:

8:55 PM Changeset in webkit [92661] by tkent@chromium.org

• 2 edits in trunk/LayoutTests

[Qt] Grouping spin-button related tests.
​https://bugs.webkit.org/show_bug.cgi?id=65896

• platform/qt/Skipped:

6:26 PM Changeset in webkit [92660] by abarth@webkit.org

• 3 edits in trunk/Tools

Chromium Windows bots can't figure out what SVN revision they're running
​https://bugs.webkit.org/show_bug.cgi?id=65893

Reviewed by Eric Seidel.

The comment in _engage_awesome_windows_hacks explains why we're making
this change. It's ugly and rediculous, but this approach seems better
than using shell=True when calling popen.

• Scripts/webkitpy/common/checkout/scm/svn.py:
• Scripts/webkitpy/layout_tests/port/chromium_win.py:

5:55 PM Changeset in webkit [92659] by steveblock@google.com

• 7 edits
  1 move
  5 deletes in trunk/Source/WebCore

Removes V8's JavaInstanceJobject, JavaClassJobject and JavaFieldJobject.
​https://bugs.webkit.org/show_bug.cgi?id=57859

Reviewed by Alexey Proskuryakov.

This effectively reverts the changes made in Bugs 55383, 57533 and

55766. These classes were only used by Android. In the future, Android

will use the Chromium WebKit API to implement the Java bridge.

Towards this goal, this patch ...

• Simplfies the JavaInstance, JavaClass and JavaField interfaces for V8. These interfaces will be implemented in Chromium's WebKit layer.
• Adds a JavaMethod interface for V8
• Removes the jvalue <-> JavaValue conversion functions for V8, which are now superfluous
• Removes the calls to JavaInstance::begin()/end() for V8, which are now superfluous

Will be covered by existing tests once the Chromium WebKit layer is complete.

• WebCore.gypi:
• bridge/jni/v8/JNIUtilityPrivate.cpp:
• bridge/jni/v8/JNIUtilityPrivate.h:
• bridge/jni/v8/JavaClassJobjectV8.cpp: Removed.
• bridge/jni/v8/JavaFieldJobjectV8.cpp: Removed.
• bridge/jni/v8/JavaFieldJobjectV8.h: Removed.
• bridge/jni/v8/JavaFieldV8.h:
• bridge/jni/v8/JavaInstanceJobjectV8.cpp: Removed.
• bridge/jni/v8/JavaInstanceJobjectV8.h: Removed.
• bridge/jni/v8/JavaInstanceV8.h:
• bridge/jni/v8/JavaMethodV8.h:

(JSC::Bindings::JavaMethod::~JavaMethod):

• bridge/jni/v8/JavaNPObjectV8.cpp:

(JSC::Bindings::JavaNPObjectHasMethod):
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectHasProperty):
(JSC::Bindings::JavaNPObjectGetProperty):

5:49 PM Changeset in webkit [92658] by crogers@google.com

• 3 edits in trunk/Source/WebCore

Fix thread-safety of AudioNode deletion
​https://bugs.webkit.org/show_bug.cgi?id=65888

Reviewed by Kenneth Russell

No new tests - JavaScript API is not affected.

• webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodesDispatch):
(WebCore::AudioContext::deleteMarkedNodes):

• webaudio/AudioContext.h:

5:25 PM Changeset in webkit [92657] by cmarrin@apple.com

• 2 edits in trunk/Source/WebCore

2011-08-08 Chris Marrin <​cmarrin@apple.com>

Fix build breakage caused by ​http://trac.webkit.org/changeset/92651

Unreviewed.

• WebCore.exp.in:

5:19 PM Changeset in webkit [92656] by abarth@webkit.org

• 1 edit
  3 deletes in trunk/Tools

Remove deduplicate-tests
​https://bugs.webkit.org/show_bug.cgi?id=65886

Reviewed by Tony Chang.

This script is redundant with "webkit-patch bulk-optimize-baselines",
which can find many more duplicates than deduplicate-tests because
bulk-optimize-baselines can move results around whereas
deduplicate-tests can only remove results.

• Scripts/deduplicate-tests: Removed.
• Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
• Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.

5:11 PM Changeset in webkit [92655] by abarth@webkit.org

• 3 edits in trunk/Tools

scm.delete should delete empty parent directories as well
​https://bugs.webkit.org/show_bug.cgi?id=65878

Reviewed by Eric Seidel.

This behavior makes SVN match GIT (which has no concept of empty
directories). This bug comes up a lot when optimizing baselines, which
often create empty directories when we're able to optimize everything
out of a given folder.

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
• Scripts/webkitpy/common/checkout/scm/svn.py:

5:05 PM Changeset in webkit [92654] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

This should actually be the correct fix for
fast/js/regexp-overflow.html. The bug in bulk-optimize-baselines is
​https://bugs.webkit.org/show_bug.cgi?id=65891.

• platform/chromium/fast/js/regexp-overflow-expected.txt:

4:34 PM Changeset in webkit [92653] by abarth@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

Add fast/js/regexp-overflow.html result back for Chromium. I'm not
sure why bulk-rebaseline-tests remove it. There's some bug in the
script I need to track down.

• platform/chromium/fast/js/regexp-overflow-expected.txt: Added.

4:32 PM Changeset in webkit [92652] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, mark gradient-after-transparent-border.html as failed on chromium.

• platform/chromium/test_expectations.txt:

4:21 PM Changeset in webkit [92651] by cmarrin@apple.com

• 14 edits in trunk/Source

Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
​https://bugs.webkit.org/show_bug.cgi?id=65708

Source/WebCore:

Add logic to syncCompositingState to compute the visible rect for each
layer. This can be used to synchronously render the visible tiles of a
TiledLayer and avoid the flashing that often occurs when tiles are rendered
asynchronously. A new synchronouslyDisplayTilesInRect is also added to do
the actual rendering, but the call is not currently being made.

Reviewed by Simon Fraser.

• page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::syncCompositingState):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::syncCompositingState):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::synchronouslyDisplayTilesInRect):

• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):

• platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::TransformState):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/mac:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

• WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

Source/WebKit2:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

• WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

4:09 PM Changeset in webkit [92650] by Lucas Forschler

• 5 edits in branches/safari-534.51-branch/Source

Versioning.

4:07 PM Changeset in webkit [92649] by Lucas Forschler

• 1 copy in tags/Safari-534.51.9

New tag.

3:55 PM Changeset in webkit [92648] by abarth@webkit.org

• 1 edit
  58 adds
  119 deletes in trunk/LayoutTests

Optimize baselines for fast/js.
This patch was created with webkit-patch bulk-optimize-baselines.

• fast/js/exception-linenums-in-html-3-expected.txt: Added.
• fast/js/global-constructors-expected.txt: Removed.
• fast/js/missing-style-end-tag-js-expected.txt: Added.
• platform/chromium-mac/fast/js/array-every-expected.txt: Removed.
• platform/chromium-mac/fast/js/array-foreach-expected.txt: Removed.
• platform/chromium-mac/fast/js/array-functions-non-arrays-expected.txt: Removed.
• platform/chromium-mac/fast/js/array-some-expected.txt: Removed.
• platform/chromium-mac/fast/js/assign-expected.txt: Removed.
• platform/chromium-mac/fast/js/break-ASI-expected.txt: Removed.
• platform/chromium-mac/fast/js/const-expected.txt: Removed.
• platform/chromium-mac/fast/js/constructor-attributes-expected.txt: Removed.
• platform/chromium-mac/fast/js/cyclic-proto-expected.txt: Removed.
• platform/chromium-mac/fast/js/cyclic-prototypes-expected.txt: Removed.
• platform/chromium-mac/fast/js/date-proto-generic-invocation-expected.txt: Removed.
• platform/chromium-mac/fast/js/date-toisostring-expected.txt: Removed.
• platform/chromium-mac/fast/js/deep-recursion-test-expected.txt: Removed.
• platform/chromium-mac/fast/js/delete-getters-setters-expected.txt: Removed.
• platform/chromium-mac/fast/js/exception-codegen-crash-expected.txt: Removed.
• platform/chromium-mac/fast/js/exception-for-nonobject-expected.txt: Removed.
• platform/chromium-mac/fast/js/exception-sequencing-binops2-expected.txt: Removed.
• platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt: Removed.
• platform/chromium-mac/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-declaration-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-toString-object-literals-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-toString-parentheses-expected.txt: Removed.
• platform/chromium-mac/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
• platform/chromium-mac/fast/js/instance-of-immediates-expected.txt: Removed.
• platform/chromium-mac/fast/js/invalid-syntax-for-function-expected.txt: Removed.
• platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/StringObject-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/encode_decode_uri-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/function-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/garbage-n-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/lval-exceptions-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/parse-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/string-1-n-expected.txt: Removed.
• platform/chromium-mac/fast/js/kde/string-2-n-expected.txt: Removed.
• platform/chromium-mac/fast/js/modify-non-references-expected.txt: Removed.
• platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
• platform/chromium-mac/fast/js/number-toString-expected.txt: Removed.
• platform/chromium-mac/fast/js/number-tofixed-expected.txt: Removed.
• platform/chromium-mac/fast/js/object-extra-comma-expected.txt: Removed.
• platform/chromium-mac/fast/js/postfix-syntax-expected.txt: Removed.
• platform/chromium-mac/fast/js/prefix-syntax-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-compile-crash-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-compile-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-no-extensions-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-range-out-of-order-expected.txt: Removed.
• platform/chromium-mac/fast/js/regexp-test-null-string-expected.txt: Removed.
• platform/chromium-mac/fast/js/string-capitalization-expected.txt: Removed.
• platform/chromium-mac/fast/js/toString-and-valueOf-override-expected.txt: Removed.
• platform/chromium-mac/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
• platform/chromium-mac/fast/js/toString-stack-overflow-expected.txt: Removed.
• platform/chromium-mac/fast/js/uncaught-exception-line-number-expected.txt: Removed.
• platform/chromium-win/fast/js/array-every-expected.txt: Removed.
• platform/chromium-win/fast/js/array-foreach-expected.txt: Removed.
• platform/chromium-win/fast/js/array-functions-non-arrays-expected.txt: Removed.
• platform/chromium-win/fast/js/array-some-expected.txt: Removed.
• platform/chromium-win/fast/js/assign-expected.txt: Removed.
• platform/chromium-win/fast/js/break-ASI-expected.txt: Removed.
• platform/chromium-win/fast/js/const-expected.txt: Removed.
• platform/chromium-win/fast/js/constructor-attributes-expected.txt: Removed.
• platform/chromium-win/fast/js/cyclic-proto-expected.txt: Removed.
• platform/chromium-win/fast/js/cyclic-prototypes-expected.txt: Removed.
• platform/chromium-win/fast/js/date-proto-generic-invocation-expected.txt: Removed.
• platform/chromium-win/fast/js/date-toisostring-expected.txt: Removed.
• platform/chromium-win/fast/js/deep-recursion-test-expected.txt: Removed.
• platform/chromium-win/fast/js/delete-getters-setters-expected.txt: Removed.
• platform/chromium-win/fast/js/exception-codegen-crash-expected.txt: Removed.
• platform/chromium-win/fast/js/exception-for-nonobject-expected.txt: Removed.
• platform/chromium-win/fast/js/exception-sequencing-binops2-expected.txt: Removed.
• platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt: Removed.
• platform/chromium-win/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
• platform/chromium-win/fast/js/function-declaration-expected.txt: Removed.
• platform/chromium-win/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
• platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Removed.
• platform/chromium-win/fast/js/function-toString-object-literals-expected.txt: Removed.
• platform/chromium-win/fast/js/function-toString-parentheses-expected.txt: Removed.
• platform/chromium-win/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
• platform/chromium-win/fast/js/instance-of-immediates-expected.txt: Removed.
• platform/chromium-win/fast/js/invalid-syntax-for-function-expected.txt: Removed.
• platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/RegExp-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/StringObject-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/encode_decode_uri-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/function-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/garbage-n-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/lval-exceptions-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/parse-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/string-1-n-expected.txt: Removed.
• platform/chromium-win/fast/js/kde/string-2-n-expected.txt: Removed.
• platform/chromium-win/fast/js/modify-non-references-expected.txt: Removed.
• platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
• platform/chromium-win/fast/js/number-toString-expected.txt: Removed.
• platform/chromium-win/fast/js/number-tofixed-expected.txt: Removed.
• platform/chromium-win/fast/js/object-extra-comma-expected.txt: Removed.
• platform/chromium-win/fast/js/postfix-syntax-expected.txt: Removed.
• platform/chromium-win/fast/js/prefix-syntax-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-compile-crash-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-compile-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-no-extensions-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-range-out-of-order-expected.txt: Removed.
• platform/chromium-win/fast/js/regexp-test-null-string-expected.txt: Removed.
• platform/chromium-win/fast/js/string-capitalization-expected.txt: Removed.
• platform/chromium-win/fast/js/toString-and-valueOf-override-expected.txt: Removed.
• platform/chromium-win/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
• platform/chromium-win/fast/js/toString-stack-overflow-expected.txt: Removed.
• platform/chromium-win/fast/js/uncaught-exception-line-number-expected.txt: Removed.
• platform/chromium/fast/js/array-every-expected.txt: Added.
• platform/chromium/fast/js/array-foreach-expected.txt: Added.
• platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Added.
• platform/chromium/fast/js/array-some-expected.txt: Added.
• platform/chromium/fast/js/assign-expected.txt: Added.
• platform/chromium/fast/js/break-ASI-expected.txt: Added.
• platform/chromium/fast/js/const-expected.txt: Added.
• platform/chromium/fast/js/constructor-attributes-expected.txt: Added.
• platform/chromium/fast/js/cyclic-proto-expected.txt: Added.
• platform/chromium/fast/js/cyclic-prototypes-expected.txt: Added.
• platform/chromium/fast/js/date-proto-generic-invocation-expected.txt: Added.
• platform/chromium/fast/js/date-toisostring-expected.txt: Added.
• platform/chromium/fast/js/deep-recursion-test-expected.txt: Added.
• platform/chromium/fast/js/delete-getters-setters-expected.txt: Added.
• platform/chromium/fast/js/exception-codegen-crash-expected.txt: Added.
• platform/chromium/fast/js/exception-for-nonobject-expected.txt: Added.
• platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Added.
• platform/chromium/fast/js/exception-thrown-from-new-expected.txt: Added.
• platform/chromium/fast/js/exceptions-thrown-in-callbacks-expected.txt: Added.
• platform/chromium/fast/js/function-declaration-expected.txt: Added.
• platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Added.
• platform/chromium/fast/js/function-prototype-descriptor-expected.txt: Added.
• platform/chromium/fast/js/function-toString-object-literals-expected.txt: Added.
• platform/chromium/fast/js/function-toString-parentheses-expected.txt: Added.
• platform/chromium/fast/js/function-toString-semicolon-insertion-expected.txt: Added.
• platform/chromium/fast/js/instance-of-immediates-expected.txt: Added.
• platform/chromium/fast/js/invalid-syntax-for-function-expected.txt: Added.
• platform/chromium/fast/js/js-continue-break-restrictions-expected.txt: Added.
• platform/chromium/fast/js/kde: Added.
• platform/chromium/fast/js/kde/RegExp-expected.txt: Added.
• platform/chromium/fast/js/kde/StringObject-expected.txt: Added.
• platform/chromium/fast/js/kde/encode_decode_uri-expected.txt: Added.
• platform/chromium/fast/js/kde/function-expected.txt: Added.
• platform/chromium/fast/js/kde/garbage-n-expected.txt: Added.
• platform/chromium/fast/js/kde/lval-exceptions-expected.txt: Added.
• platform/chromium/fast/js/kde/parse-expected.txt: Added.
• platform/chromium/fast/js/kde/string-1-n-expected.txt: Added.
• platform/chromium/fast/js/kde/string-2-n-expected.txt: Added.
• platform/chromium/fast/js/modify-non-references-expected.txt: Added.
• platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Removed.
• platform/chromium/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
• platform/chromium/fast/js/number-toString-expected.txt: Added.
• platform/chromium/fast/js/number-tofixed-expected.txt: Added.
• platform/chromium/fast/js/object-extra-comma-expected.txt: Added.
• platform/chromium/fast/js/postfix-syntax-expected.txt: Added.
• platform/chromium/fast/js/prefix-syntax-expected.txt: Added.
• platform/chromium/fast/js/regexp-compile-crash-expected.txt: Added.
• platform/chromium/fast/js/regexp-compile-expected.txt: Added.
• platform/chromium/fast/js/regexp-no-extensions-expected.txt: Added.
• platform/chromium/fast/js/regexp-overflow-expected.txt: Removed.
• platform/chromium/fast/js/regexp-range-out-of-order-expected.txt: Added.
• platform/chromium/fast/js/regexp-test-null-string-expected.txt: Added.
• platform/chromium/fast/js/string-capitalization-expected.txt: Added.
• platform/chromium/fast/js/toString-and-valueOf-override-expected.txt: Added.
• platform/chromium/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
• platform/chromium/fast/js/toString-stack-overflow-expected.txt: Added.
• platform/chromium/fast/js/uncaught-exception-line-number-expected.txt: Added.
• platform/gtk/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
• platform/gtk/fast/js/missing-style-end-tag-js-expected.txt: Removed.
• platform/mac/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
• platform/mac/fast/js/global-constructors-expected.txt: Added.
• platform/mac/fast/js/missing-style-end-tag-js-expected.txt: Removed.
• platform/qt/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
• platform/qt/fast/js/missing-style-end-tag-js-expected.txt: Removed.

3:49 PM Changeset in webkit [92647] by Lucas Forschler

• 2 edits in trunk/Tools

Add triggers for Lion WK2 test bots.

Reviewed by Stephanie Lewis.

• BuildSlaveSupport/build.webkit.org-config/config.json:

3:29 PM Changeset in webkit [92646] by abarth@webkit.org

• 1 edit
  5 adds
  7 deletes in trunk/LayoutTests

Optimize baselines for fast/inspector-support.
This patch was created with webkit-patch bulk-optimize-baselines.

• fast/inspector-support/style-expected.txt: Added.
• platform/chromium-mac/fast/inspector-support: Removed.
• platform/chromium-mac/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
• platform/chromium-mac/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
• platform/chromium-mac/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
• platform/chromium-win/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
• platform/chromium-win/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
• platform/chromium-win/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
• platform/chromium/fast/inspector-support: Added.
• platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt: Added.
• platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt: Added.
• platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt: Added.
• platform/gtk/fast/inspector-support/style-expected.txt: Removed.
• platform/mac/fast/inspector-support/style-expected.txt: Removed.
• platform/qt/fast/inspector-support/style-expected.txt: Removed.

3:24 PM Changeset in webkit [92645] by abarth@webkit.org

• 1 edit
  13 adds
  23 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/HTMLAnchorElement and fast/dom/Window.
This patch was created with webkit-patch bulk-optimize-baselines.
(Note: I massaged the two results that enumerate the global object to
leave the "base" results as matching mac even though the tool wanted to
push those results down into the mac directory.)

• platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
• platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Removed.
• platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
• platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
• platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/get-set-properties-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
• platform/chromium-mac/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
• platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
• platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
• platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/get-set-properties-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
• platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
• platform/chromium-win/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
• platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
• platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
• platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
• platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
• platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
• platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt: Added.
• platform/chromium/fast/dom/Window/get-set-properties-expected.txt: Added.
• platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt: Added.
• platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Added.
• platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
• platform/chromium/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
• platform/chromium/fast/dom/Window/window-properties-geolocation-expected.txt: Added.
• platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt: Added.

3:18 PM Changeset in webkit [92644] by abarth@webkit.org

• 1 edit
  5 adds
  2 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/DOMException.
This patch was created with webkit-patch bulk-optimize-baselines.
(I've manually remove the README file because we don't use these sorts
of README files anymore.)

• platform/chromium-mac/fast/dom/DOMException: Removed.
• platform/chromium-mac/fast/dom/DOMException/EventException-expected.txt: Removed.
• platform/chromium-mac/fast/dom/DOMException/README: Removed.
• platform/chromium-mac/fast/dom/DOMException/RangeException-expected.txt: Removed.
• platform/chromium-mac/fast/dom/DOMException/XPathException-expected.txt: Removed.
• platform/chromium-mac/fast/dom/DOMException/prototype-object-expected.txt: Removed.
• platform/chromium-win/fast/dom/DOMException: Removed.
• platform/chromium-win/fast/dom/DOMException/EventException-expected.txt: Removed.
• platform/chromium-win/fast/dom/DOMException/README: Removed.
• platform/chromium-win/fast/dom/DOMException/RangeException-expected.txt: Removed.
• platform/chromium-win/fast/dom/DOMException/XPathException-expected.txt: Removed.
• platform/chromium-win/fast/dom/DOMException/prototype-object-expected.txt: Removed.
• platform/chromium/fast/dom/DOMException: Added.
• platform/chromium/fast/dom/DOMException/EventException-expected.txt: Added.
• platform/chromium/fast/dom/DOMException/RangeException-expected.txt: Added.
• platform/chromium/fast/dom/DOMException/XPathException-expected.txt: Added.
• platform/chromium/fast/dom/DOMException/prototype-object-expected.txt: Added.

3:17 PM Changeset in webkit [92643] by commit-queue@webkit.org

• 14 edits in trunk/Source

Unreviewed, rolling out r92619.
​http://trac.webkit.org/changeset/92619
​https://bugs.webkit.org/show_bug.cgi?id=65881

This patch breaks chromium canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

• bindings/v8/V8Binding.h:
• bindings/v8/V8GCController.cpp:

(WebCore::globalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

• bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

• bindings/v8/V8HiddenPropertyName.h:
• bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

• bindings/v8/V8NPObject.cpp:
• bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

• bindings/v8/V8Utilities.h:

(WebCore::AllowAllocation::AllowAllocation):
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::SafeAllocation::newInstance):

• bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

• bindings/v8/WorkerContextExecutionProxy.h:
• bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium:

• src/BoundObject.cpp:

3:04 PM Changeset in webkit [92642] by Lucas Forschler

• 5 edits in branches/safari-534.51-branch/Source

Versioning.

3:04 PM Changeset in webkit [92641] by abarth@webkit.org

• 2 edits in trunk/Tools

bulk-optimize-baselines should take directories on the command line
​https://bugs.webkit.org/show_bug.cgi?id=65879

Reviewed by Dimitri Glazkov.

Passing lists of tests via stdin is a pain. It's easier if the command
takes a list of tests on the command line, like run-webkit-tests.

• Scripts/webkitpy/tool/commands/rebaseline.py:

3:03 PM Changeset in webkit [92640] by Lucas Forschler

• 1 copy in tags/Safari-534.51.8

New tag.

3:01 PM Changeset in webkit [92639] by commit-queue@webkit.org

• 5 edits in trunk/Source

Scroll animator changes to nail the framerate
​https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

• platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

• platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

• tests/ScrollAnimatorNoneTest.cpp:

(TEST):

2:53 PM Changeset in webkit [92638] by eae@chromium.org

• 3 edits in trunk/Source/WebCore

Switch legacy flexbox to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=65340

Reviewed by Eric Seidel.

No new tests, no new functionality.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::placeChild):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

• rendering/RenderDeprecatedFlexibleBox.h:

2:37 PM Changeset in webkit [92637] by abarth@webkit.org

• 2 edits in trunk/Tools

Deprecate rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=65873

Reviewed by Dimitri Glazkov.

This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests. This patch deprecates
the script in order to flush out any issues with the new tools. Once
folks are happy with the new tools, we'll delete this script.

• Scripts/rebaseline-chromium-webkit-tests:

2:35 PM Changeset in webkit [92636] by Dimitri Glazkov

• 5 edits in trunk/Tools

garden-o-matic should only touch expectations that need updating.
​https://bugs.webkit.org/show_bug.cgi?id=65876

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,

so that a caller could influence which lines to serialize from values.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
• Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.

2:28 PM Changeset in webkit [92635] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Using mprotect to create guard pages breaks our use of madvise to release executable memory
​https://bugs.webkit.org/show_bug.cgi?id=65870

Reviewed by Gavin Barraclough.

Use mmap rather than mprotect to clear guard page permissions.

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

2:28 PM Changeset in webkit [92634] by Dimitri Glazkov

• 3 edits in trunk/Tools

TestExpectationsEditor should return a list of updated expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65872

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.

2:16 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

2:07 PM Changeset in webkit [92633] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, mark preventExtensions.html as failed on chromium.

• platform/chromium/test_expectations.txt:

2:04 PM Changeset in webkit [92632] by abarth@webkit.org

• 3 edits in trunk/Tools

Fix SCM webkitpy unit test failures
​https://bugs.webkit.org/show_bug.cgi?id=65823

Patch by Jochen Eisinger <​jochen@chromium.org> on 2011-08-08
Reviewed by Eric Seidel.

• Scripts/webkitpy/common/checkout/scm/git.py:
• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

1:49 PM Changeset in webkit [92631] by eae@chromium.org

• 5 edits in trunk/Source/WebCore

Switch RenderStyle to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=65208

Reviewed by Eric Seidel.

No new tests, no new functionality.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::addShadowOverflow):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

• rendering/style/RenderStyle.h:
• rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):

1:39 PM Changeset in webkit [92630] by cdn@chromium.org

• 2 edits in trunk/Source/WebCore

Remove counter nodes from the tree and fix-up children when they are removed from the counter map.
​https://bugs.webkit.org/show_bug.cgi?id=65346

Reviewed by Adam Barth.

Covered by existing CSS counter tests.

• rendering/CounterNode.cpp:

(WebCore::CounterNode::~CounterNode):

1:37 PM Changeset in webkit [92629] by eric@webkit.org

• 2 edits in trunk/Tools

Move the --leaks bot back over to NRWT now that I'm back
from vacation and able to debug it.

Unreviewed.

• Scripts/run-webkit-tests:

(usingWebKit2):
(useNewRunWebKitTests):

1:32 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:29 PM Changeset in webkit [92628] by tony@chromium.org

• 8 edits
  4 adds in trunk

implement basic horizontal flexing
​https://bugs.webkit.org/show_bug.cgi?id=65045

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/001.html

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::FlexibleBoxIterator::FlexibleBoxIterator): flexitem iterator
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::first):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::next):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::reset):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::preferredFlexItemContentWidth): Returns the intrinsic size of a flex item's content.
(WebCore::RenderFlexibleBox::layoutHorizontalBlock): Runs the flex algorithm
(WebCore::preferredSizeForMarginsAndPadding):
(WebCore::RenderFlexibleBox::computePreferredSize): Calculate the preferred size of the

flex items.

• rendering/RenderFlexibleBox.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

• rendering/style/RenderStyleConstants.h:

LayoutTests:

• css3/flexbox/001-expected.txt: Added.
• css3/flexbox/001.html: Added.
• css3/flexbox/resources/flexbox.js: Added. I plan on using this file for other tests.

(insertAfter):
(checkHorizontalBoxen):

1:18 PM Changeset in webkit [92627] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add detail to ASSERT message in IDBTransaction::enqueueEvent
​https://bugs.webkit.org/show_bug.cgi?id=65735

I've hit this a few times but haven't been able to pin it down. The
extra detail could be helpful.

Patch by David Grogan <​dgrogan@chromium.org> on 2011-08-08
Reviewed by Nate Chapin.

No new tests, just an error message.

• storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

1:13 PM Changeset in webkit [92626] by commit-queue@webkit.org

• 9 edits in trunk

Unreviewed, rolling out r92610.
​http://trac.webkit.org/changeset/92610
​https://bugs.webkit.org/show_bug.cgi?id=65868

Caused assertion failures when running fast/multicol tests
(Requested by andersca on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

PerformanceTests:

• Layout/floats.html:

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• platform/PODIntervalTree.h:

(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

• platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):

• rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::set):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

1:11 PM Changeset in webkit [92625] by eae@chromium.org

• 7 edits in trunk/Source/WebCore

Rename absoluteQuadsForRange and InlineTextBox::selectionRect to local*
​https://bugs.webkit.org/show_bug.cgi?id=65722

Reviewed by Simon Fraser.

No new tests, no new functionality.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):
Rename InlineTextBox::selectionRect to localSelectionRect to reflect that
it, unlike RenderObject::selectionRect returns a rect in the local
coordinate space.

• rendering/InlineTextBox.h:
• rendering/RenderText.cpp:

(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint):
Rename absoluteQuadForTextBox to localQuadForTextBox to reflect that it
returns a quad in the local coordinate space.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

• rendering/svg/SVGInlineTextBox.h:

12:59 PM Changeset in webkit [92624] by Dimitri Glazkov

• 5 edits in trunk/Tools

Wire up updating expectations in garden-o-matic.
​https://bugs.webkit.org/show_bug.cgi?id=65794

Reviewed by Adam Barth.

• Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
• Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
• Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.

12:54 PM Changeset in webkit [92623] by jochen@chromium.org

• 6 edits in trunk/Source/WebCore

Use a raw pointer to the security origin in the ctor of FrameLoadRequest
​https://bugs.webkit.org/show_bug.cgi?id=65852

Reviewed by Alexey Proskuryakov.

• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):

• loader/FrameLoader.h:
• loader/NavigationScheduler.cpp:

(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::NavigationScheduler::scheduleLocationChange):

• loader/NavigationScheduler.h:

12:47 PM Changeset in webkit [92622] by Dimitri Glazkov

• 5 edits
  2 deletes in branches/chromium/835

Revert r91125 for Chromium 835.

12:41 PM Changeset in webkit [92621] by bfulgham@webkit.org

• 2 edits in trunk/Source/WebKit/win

WebView::performLayeredWindowUpdate() crashes with
NULL pointer when using layered window updates.
​https://bugs.webkit.org/show_bug.cgi?id=60618

Reviewed by Adam Roben.

During resize operations, the backing store will be destroyed if
the window's size (either height or width) is set to zero. The
bug was identified when a user first resized a WebView to zero
dimensions, then attempted to perform a MoveWindow. The paint
message triggered by the MoveWindow attempted to use the layered
window update logic, which encountered the nulled backing store.

• WebView.cpp:

(WebView::performLayeredWindowUpdate): Add an early

return when there is no backing store to blend with.

12:15 PM Changeset in webkit [92620] by rniwa@webkit.org

• 15 edits
  2 adds in trunk

Remove redundant inline styles from the pasted contents more aggressively
​https://bugs.webkit.org/show_bug.cgi?id=65833

Reviewed by Tony Chang.

Source/WebCore:

Make removeRedundantStylesAndKeepStyleSpanInline more aggressively remove redundant styles by realizing that
when an editing inheritable property in an inline style declaration of an element can be safely removed
if it is present either in style rules or in its ancestor and not overridden by style rules or default style
of the element.

Test: editing/pasteboard/paste-with-redundant-style.html

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Do not match author style sheets if AuthorCSSRules
is not included in the rules to include. This is used in EditingStyle::removePropertiesInElementDefaultStyle.

• editing/ApplyStyleCommand.cpp:

(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute): Added; returns true if the element is a style span or
span possibly with a style attribute.

• editing/ApplyStyleCommand.h:
• editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement): Takes rulesToInclude.
(WebCore::EditingStyle::mergeStyleFromRules): Calls styleFromMatchedRulesForElement with AuthorCSSRules
| CrossOriginCSSRules to keep the original behavior.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Renamed from removeStyleFromRules; removes styles that
are present in context and not overridden by matched rules.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Added.

• editing/EditingStyle.h:
• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See the description above.

LayoutTests:

Added a test to paste contents with many redundant styles. WebKit should remove as much style spans as possible
(all of this in this case).

• editing/pasteboard/4930986-2-expected.txt: style attribute now has a trailing space.
• editing/pasteboard/interchange-newline-1-expected.txt: No longer has a wrapping span without any attributes.
• editing/pasteboard/nested-blocks-with-text-area-expected.txt: Ditto.
• editing/pasteboard/nested-blocks-with-text-field-expected.txt: Ditto.
• editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Ditto.
• editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Ditto.
• editing/pasteboard/prevent-block-nesting-01-expected.txt: Ditto.
• editing/pasteboard/paste-with-redundant-style-expected.txt: Added.
• editing/pasteboard/paste-with-redundant-style.html: Added.

12:11 PM Changeset in webkit [92619] by dslomov@google.com

• 14 edits in trunk/Source

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by David Levin.

Covered by existing tests.

• bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):

• bindings/v8/V8GCController.cpp:

(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

• bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

• bindings/v8/V8HiddenPropertyName.h:
• bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

• bindings/v8/V8NPObject.cpp:
• bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

• bindings/v8/V8Utilities.h:
• bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):

• bindings/v8/WorkerContextExecutionProxy.h:
• bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by David Levin.

• src/BoundObject.cpp: AllowAllocation moved from V8Utilities.h to V8Binding.h

12:09 PM Changeset in webkit [92618] by oliver@apple.com

• 5 edits in trunk

Non-extensibility does not prevent mutating Prototype
​https://bugs.webkit.org/show_bug.cgi?id=65832

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add tests to ensure we can't assign to proto when an object
is not extensible.

• fast/js/preventExtensions-expected.txt:
• fast/js/script-tests/preventExtensions.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Disallow mutation of proto on objects that are not extensible.

• runtime/JSObject.cpp:

(JSC::JSObject::put):

12:09 PM Changeset in webkit [92617] by commit-queue@webkit.org

• 14 edits in trunk/Source

Unreviewed, rolling out r92607.
​http://trac.webkit.org/changeset/92607
​https://bugs.webkit.org/show_bug.cgi?id=65865

This patch breaks Chromium Mac Canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

• platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

• features.gypi:
• public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

• public/mac/WebInputEventFactory.h:
• src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

• src/WebInputEventConversion.h:
• src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

• src/WebPopupMenuImpl.h:
• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

• src/WebViewImpl.h:
• src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::mouseWheelEvent):

11:59 AM Changeset in webkit [92616] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, mark 1 test as flaky in chromium.

• platform/chromium/test_expectations.txt:

11:42 AM Changeset in webkit [92615] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests cover this.

Implement WebGL antialiasing for Qt desktop.
Existing code in GraphicsContext3DOpenGL.cpp manages the
multisample FBO. GraphicsContext3DQt.cpp creates it and blits
it to the regular FBO when painting.
Requires adoption of Extensions3DOpenGL to be fully functional.

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::multisampleResolve):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

11:39 AM Changeset in webkit [92614] by kerz@chromium.org

• 3 edits
  3 deletes in branches/chromium/835

Reverting for crbug.com/91858
Revert 91958 - Merge 91915 - 2011-07-28 Rob Buis <​rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
​https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

• rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

TBR=​rwlbuis@webkit.org
Review URL: ​http://codereview.chromium.org/7532014

TBR=​kerz@chromium.org
Review URL: ​http://codereview.chromium.org/7529030

11:35 AM Changeset in webkit [92613] by kerz@chromium.org

• 1 edit
  2 deletes in branches/chromium/835/LayoutTests

Beginning revert chain to fix crbug.com/91858

Revert 91968 - Merge 91927 - [chromium] New expectations for r91915
​https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

• platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
• platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

TBR=​tonyg@chromium.org
Review URL: ​http://codereview.chromium.org/7474011

TBR=​kerz@chromium.org
Review URL: ​http://codereview.chromium.org/7558004

11:33 AM Changeset in webkit [92612] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, update chromium test_expectations.

• platform/chromium/test_expectations.txt:

11:26 AM Changeset in webkit [92611] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Fix build.

• platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::Counter::visit):

11:09 AM Changeset in webkit [92610] by commit-queue@webkit.org

• 9 edits in trunk

Optimize floating elements lookup
​https://bugs.webkit.org/show_bug.cgi?id=65668

PerformanceTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-08
Reviewed by David Hyatt.

• Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-08
Reviewed by David Hyatt.

No new tests, just a refactor on the floating objects data structure.

• WebCore.xcodeproj/project.pbxproj:
• platform/PODIntervalTree.h:

(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

• platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):

• rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

11:02 AM Changeset in webkit [92609] by jochen@chromium.org

• 3 edits in trunk/Tools

webkit-patch doesn't get along with renamed files
​https://bugs.webkit.org/show_bug.cgi?id=48075

Possibly a bit heavy handed - I removed all instances of -C and
changed every instance of -M with '--no-renames' in git.py. This
forces git to not try to tell us about renames at all, which is
ultimately the behaviour we want. The old file is shown deleted,
then the new file is shown added, followed by any changes that
occurred. Also gets rid of the problem where deleting one file
and adding another file which has similar content would
unexpectedly show up as a rename, and fall out of a diff.

Based on a patch by Wyatt Carss.

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/checkout/scm/git.py:

11:00 AM Changeset in webkit [92608] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, mark some tests as flaky on chromium.

• platform/chromium/test_expectations.txt:

10:56 AM Changeset in webkit [92607] by commit-queue@webkit.org

• 14 edits in trunk/Source

[Chromium] Enable rubber banding when scrolling.

​https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-08
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

• platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

• features.gypi:
• public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

• public/mac/WebInputEventFactory.h:
• src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

• src/WebInputEventConversion.h:
• src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

• src/WebPopupMenuImpl.h:
• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):

• src/WebViewImpl.h:
• src/mac/WebInputEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

10:54 AM Changeset in webkit [92606] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS from 95576 to 95783.

• DEPS:

10:52 AM Changeset in webkit [92605] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[Cairo][Gtk] Get more of the philip suite of canvas tests passing
​https://bugs.webkit.org/show_bug.cgi?id=54458

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-08-08
Reviewed by Martin Robinson.

Update the list of skipped canvas tests and describe why platform-specific
failures occur.

• platform/gtk/Skipped:

10:43 AM Changeset in webkit [92604] by andersca@apple.com

• 6 edits
  2 copies
  5 adds in trunk/LayoutTests

More Lion specific results.

• platform/mac-lion/Skipped:
• platform/mac-snowleopard/editing: Added.
• platform/mac-snowleopard/editing/input: Added.
• platform/mac-snowleopard/editing/input/devanagari-ligature-expected.png: Copied from platform/mac/editing/input/devanagari-ligature-expected.png.
• platform/mac-snowleopard/editing/input/devanagari-ligature-expected.txt: Copied from platform/mac/editing/input/devanagari-ligature-expected.txt.
• platform/mac-snowleopard/fast/xsl: Added.
• platform/mac-snowleopard/fast/xsl/sort-locale-expected.txt: Added.
• platform/mac/editing/input/devanagari-ligature-expected.png:
• platform/mac/editing/input/devanagari-ligature-expected.txt:
• platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
• platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
• platform/mac/fast/xsl/sort-locale-expected.txt: Added.

10:28 AM Changeset in webkit [92603] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
​https://bugs.webkit.org/show_bug.cgi?id=65860

Reviewed by Simon Fraser.

When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
unconditionally.

• WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):

• WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):

10:20 AM Changeset in webkit [92602] by jianli@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, fix more typo in test_expectations.txt.

• platform/chromium/test_expectations.txt:

9:27 AM Changeset in webkit [92601] by podivilov@chromium.org

• 2 edits in trunk/LayoutTests

2011-08-08 Pavel Podivilov <​podivilov@chromium.org>

Web Inspector: unreviewed, build fix for r92598.

• inspector/debugger/script-formatter.html:

9:26 AM Changeset in webkit [92600] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.

• html/NumberInputType.cpp:

(WebCore::NumberInputType::sizeShouldIncludeDecoration): Fixed an obvious typo.

9:13 AM Changeset in webkit [92599] by abecsi@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt] Clean up project file after r92492.

Unreviewed gardening.

No new tests needed.

• WebCore.pro: remove nonexistent PluginHalterClient.h, PluginHalter.h, HaltablePlugin.h.

8:50 AM Changeset in webkit [92598] by podivilov@chromium.org

• 11 edits in trunk/Source/WebCore

Web Inspector: refactor links creation.
​https://bugs.webkit.org/show_bug.cgi?id=65612

Reviewed by Pavel Feldman.

No new tests - it is refactoring, modified code covered by script-formatter.html test.

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

• inspector/front-end/EventListenersSidebarPane.js:
• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

• inspector/front-end/Panel.js:
• inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.linkifyUncopyable):
(WebInspector.StylePropertiesSection):

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

• inspector/front-end/inspector.js:

(WebInspector._showSettingsScreen):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):

8:34 AM Changeset in webkit [92597] by andreip@google.com

• 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <​andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Fix typo in test_expectations.txt.

• platform/chromium/test_expectations.txt:

8:29 AM Changeset in webkit [92596] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests.

Adopt Extensions3DOpenGL for Qt desktop as a prerequisite
for implementing WebGL antialiasing.
Extensions3DQt is still used for ES2.

• WebCore.pri:
• WebCore.pro:
• platform/graphics/GraphicsContext3D.h:
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getExtensions):

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::layerComposited):

8:05 AM Changeset in webkit [92595] by andreip@google.com

• 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <​andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Marks the tests as failing on Chromium.

• platform/chromium/test_expectations.txt:

7:25 AM Changeset in webkit [92594] by benjamin.poulain@nokia.com

• 2 edits in trunk/Source/WebCore

Build fix after r92589, defaultSize is not used.

Reviewed by Andreas Kling.

• html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

5:50 AM Changeset in webkit [92593] by fpizlo@apple.com

• 6 edits in trunk/Source/JavaScriptCore

DFG JIT does not track speculation decisions for global variables
​https://bugs.webkit.org/show_bug.cgi?id=65825

Reviewed by Gavin Barraclough.

Added the capability to track predictions for global variables, and
ensured that code can abstract over the source of prediction (local
versus global variable) wherever it is appropriate to do so. Also
cleaned up the code in SpeculativeJIT that decides how to speculate
based on recorded predictions (for example instead of using isInteger,
which makes sense for local predictions where the GetLocal would
return an integer value, we now tend to use shouldSpeculateInteger,
which checks if the value is either already an integer or should be
speculated to be an integer).

This is an 0.8% win on SunSpider, almost entirely thanks to a 25%
win on controlflow-recursive. It's also a 4.8% win on v8-crypto.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::getPrediction):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):

5:44 AM Changeset in webkit [92592] by keishi@webkit.org

• 15 edits
  2 adds in trunk/Source/WebCore

Implement <input type=color> UI behavior WebCore part
​https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

• WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and

ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE

• WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
• html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::isColorInputType): Returns true.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.

• html/ColorInputType.h:
• html/FileInputType.cpp:
• html/FileInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach): Calls InputType::detach

• html/InputType.cpp:

(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.

• html/InputType.h:
• loader/EmptyClients.h:

(WebCore::EmptyChromeClient::openColorChooser):
(WebCore::EmptyChromeClient::closeColorChooser):
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Close color chooser when navigating away from the page. We do this here
because ColorInputType::detach() is called seconds after the page transition so it is too slow.

• page/Chrome.cpp:

(WebCore::Chrome::openColorChooser): Added.
(WebCore::Chrome::closeColorChooser): Added.
(WebCore::Chrome::setSelectedColorInColorChooser): Added.

• page/Chrome.h:
• page/ChromeClient.h:
• platform/ColorChooser.cpp: Added.

(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.

• platform/ColorChooser.h: Added.

(WebCore::ColorChooserClient::isColorInputType): Added.
(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

5:16 AM Changeset in webkit [92591] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] fast/forms/input-number-size.html added in r92589 fails
​https://bugs.webkit.org/show_bug.cgi?id=65851

Unreviewed gardening.

• platform/qt/Skipped: Skip the test.

3:56 AM Changeset in webkit [92590] by jknotten@chromium.org

• 2 edits in trunk/LayoutTests

Adjust test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65847

Unreviewed.

• platform/chromium/test_expectations.txt:

2:16 AM Changeset in webkit [92589] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk

Source/WebCore: The input[type=number] element should be as wide as necessary to show the widest possible value.
​https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

The size of input[type=number] is calculated from min/max/step attributes to show the widest possible value.
If min or max attribute is absent, the default size is used.
Also, if its css width is not auto, the width is used with priority.

If min/max/attribute is set dynamically, the size of the input[type=number] will be recalculated.

Test: fast/forms/input-number-size.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

Added stepAttributeChanged handler.

(WebCore::HTMLInputElement::sizeShouldIncludeDecoration):

Returns true if a renderer should include decoration (e.g. inner spinbox).
Also returns the preferred size of the input.

• html/HTMLInputElement.h:
• html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.

(WebCore::InputType::stepAttributeChanged):

Will be called When step attribute is changed.
Sets a flag to recalculate layout.

• html/InputType.h:
• html/NumberInputType.cpp:

(WebCore::lengthBeforeDecimalPoint):

Calculates the width before the decimal point.

(WebCore::NumberInputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.
However, this will calculate the preferred size from min/max/step attribute.

(WebCore::NumberInputType::minOrMaxAttributeChanged):

Sets a flag to recalculate layout.

(WebCore::NumberInputType::stepAttributeChanged): ditto.

• html/NumberInputType.h:
• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentWidth):

Uses preferredSize instead of size.
Also, adds innerSpinButtonElement size to width if sizeShouldIncludeDecoration returns true.

LayoutTests: Added the test to check the width of input[type=number].
​https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

• fast/forms/input-number-size-expected.txt: Added.
• fast/forms/input-number-size.html: Added.

1:42 AM Changeset in webkit [92588] by bashi@chromium.org

• 2 edits in trunk/Source/WebCore

Should not use C-style cast in CSSParser.cpp
​https://bugs.webkit.org/show_bug.cgi?id=65807

Remove C-style cast.

Reviewed by Kent Tamura.

No new tests because no behavior change.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction): Replaced a cast with clampToInteger().
(WebCore::CSSParser::parseFontFeatureTag): Ditto.
(WebCore::CSSParser::createKeyframeRule): Replaced a cast with C++-style cast.

1:12 AM Changeset in webkit [92587] by pfeldman@chromium.org

• 23 edits in trunk/Source

Web Inspector: implement dock/undock in WebKit2 without getting into WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=65763

Source/WebCore:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

• WebCore.exp.in:
• inspector/InspectorController.cpp:
• inspector/InspectorController.h:
• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.h:
• inspector/front-end/inspector.js:

(windowLoaded):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

• src/InspectorFrontendClientImpl.cpp:
• src/InspectorFrontendClientImpl.h:
• src/js/DevTools.js:

(devtools.domContentLoaded):

Source/WebKit2:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):

• UIProcess/WebInspectorProxy.h:
• UIProcess/WebInspectorProxy.messages.in:
• UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

• UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

• UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

• UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didLoadInspectorPage):

• WebProcess/WebPage/WebInspector.h:
• WebProcess/WebPage/WebInspector.messages.in:

12:32 AM Changeset in webkit [92586] by zoltan@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] Skip divergent tests
​https://bugs.webkit.org/show_bug.cgi?id=65831

• platform/qt/Skipped:

12:25 AM Changeset in webkit [92585] by tkent@chromium.org

• 14 edits
  2 adds in trunk

[Chromium] Make form validation bubble fit with Chrome UI style
​https://bugs.webkit.org/show_bug.cgi?id=65359

Reviewed by Hajime Morita.

Source/WebCore:

Change the appearance of validation message bubble for
Chromium. Basically it doesn't change for other ports.

• Introduce a new element to put an icon, and enclose it and the

message text by a flexible box.

• Repesent the message text by two elements. One for the heading,

another for the remaining.

• Introduce themeChromium.css

• WebCore.gyp/WebCore.gyp: Add themeChromium.css.
• css/html.css:

(::-webkit-validation-bubble-message): Make this a flexible box container.
(::-webkit-validation-bubble-text-block): Takes flexibility.
(::-webkit-validation-bubble-heading):
Make the content bold because we removed <b></b>.

• css/themeChromium.css: Added.

(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
(::-webkit-validation-bubble-icon):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-body):

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Sets the text into m_messageHeading and m_messageBody, instead of m_bubbleMessage.
Use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::buildBubbleTree):
Build the new structure, and use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::deleteBubbleTree):
Clear m_messageHeading and m_messageBody.

• html/ValidationMessage.h:
• rendering/RenderThemeChromiumMac.h: Add extraDefaultStyleSheet().
• rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::extraDefaultStyleSheet): Append themeChromium.css.

• rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): Append themeChromium.css.

LayoutTests:

• fast/forms/validation-message-appearance.html: Need to wait for a litle because of image loading.
• platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium/test_expectations.txt:
• platform/mac/fast/forms/validation-message-appearance-expected.png:
• platform/mac/fast/forms/validation-message-appearance-expected.txt:

12:03 AM Changeset in webkit [92584] by kerz@chromium.org

• 2 edits in branches/chromium/835/Source/WebCore

Merge 92529 - Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
​https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

• rendering/RenderBoxModelObject.cpp:

(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7585032

Aug 7, 2011:

11:38 PM Changeset in webkit [92583] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=65754

Unreviewed chromium test_expectations.txt update
No more failure as r92439 was rolled out by r92453

• platform/chromium/test_expectations.txt:

11:02 PM Changeset in webkit [92582] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

• WebCore.xcodeproj/project.pbxproj:

9:06 PM Changeset in webkit [92581] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed test fix after r92578. I accidentally added the call to dumpAsText(true).

• editing/pasteboard/nested-blocks-with-text-area.html:

8:46 PM Changeset in webkit [92580] by rniwa@webkit.org

• 3 edits
  2 adds
  17 deletes in trunk/LayoutTests

Dump-as-markup conversion: paste-blockquote-into-blockquote.html and prevent-block-nesting-01.html
​https://bugs.webkit.org/show_bug.cgi?id=65837

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

• editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
• editing/pasteboard/paste-blockquote-into-blockquote.html:
• editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
• editing/pasteboard/prevent-block-nesting-01.html:
• platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
• platform/chromium-linux/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
• platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
• platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
• platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
• platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
• platform/mac-leopard/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
• platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
• platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
• platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
• platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
• platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.

8:31 PM Changeset in webkit [92579] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65758

Test is now green on chromium and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

• platform/chromium/test_expectations.txt:

7:47 PM Changeset in webkit [92578] by rniwa@webkit.org

• 3 edits
  2 adds
  23 deletes in trunk/LayoutTests

Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html
​https://bugs.webkit.org/show_bug.cgi?id=65836

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

• editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
• editing/pasteboard/nested-blocks-with-text-area.html:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
• editing/pasteboard/nested-blocks-with-text-field.html:
• platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
• platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
• platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
• platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
• platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
• platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
• platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
• platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
• platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
• platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.

7:28 PM Changeset in webkit [92577] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65757

This test and the others mentioned in the bug are now green on chromium
and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

• platform/chromium/test_expectations.txt:

7:06 PM Changeset in webkit [92576] by koz@chromium.org

• 8 edits in trunk/Source

Make the fullscreen JS API enabled at runtime.
​https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

• bindings/generic/RuntimeEnabledFeatures.cpp:
• bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

• dom/Document.idl:
• dom/Element.idl:

Source/WebKit/chromium:

• public/WebRuntimeFeatures.h:
• src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

3:16 PM Changeset in webkit [92575] by kbalazs@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-through-* results diverging between bots
​https://bugs.webkit.org/show_bug.cgi?id=65831

Unreviewed Qt gardening.

• platform/qt/Skipped:

12:42 PM Changeset in webkit [92574] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit2

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
​https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

• UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

6:47 AM Changeset in webkit [92573] by Martin Robinson

• 5 edits in trunk/Source

Distribution fix for GTK+.

Source/JavaScriptCore:

• GNUmakefile.list.am: Strip removed files from the source list.

Source/WebCore:

• GNUmakefile.am: Add some files to the distribution list.
• GNUmakefile.list.am: Strip removed files from the source list.

4:29 AM Changeset in webkit [92572] by jochen@chromium.org

• 5 edits
  1 move in trunk/Source/WebCore

Move FrameLoadRequest to loader/
​https://bugs.webkit.org/show_bug.cgi?id=65817

Reviewed by Alexey Proskuryakov.

• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::requester):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):

2:48 AM Changeset in webkit [92571] by commit-queue@webkit.org

• 12 edits
  2 adds in trunk

Source/WebCore: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

New AccessibilityObject cache search functionality and API for the mac
platform to expose it. At this point the AccessibilityObject cache can
be searched using one of the supported search keys that have been defined
in AccessibilityObject.h, or by passing search text.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-predicate.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::accessibilityObjectContainsText):
(WebCore::AccessibilityObject::accessibleObjectsWithAccessibilitySearchPredicate):

• accessibility/AccessibilityObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Added testing support for AccessibilityObject cache searching. Currently,
only the mac platform is full supported and has had API exposed. Other
platforms have only have this new functionality stubbed. Full implementation
is a job suited only for an accessibility expert of each respective platform.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

• DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Tests for the new AccessibilityObject cache search API and the additional
functionality in the AccessibilityObject class that makes AccessibilityObject
cache searching possible.

Additional tests for finding frames, misspellings, and visited links will be
included in a subsequent patch.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

• platform/mac/accessibility/bounds-for-range-expected.txt:
• platform/mac/accessibility/search-predicate-expected.txt: Added.
• platform/mac/accessibility/search-predicate.html: Added.

1:01 AM Changeset in webkit [92570] by Martin Robinson

• 2 edits in trunk/LayoutTests

Rebaseline a test on GTK+ for which r92554 checked in an
incorrect result.

• platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Update results.
• platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Ditto.