Timeline
Aug 14, 2011:
- 11:57 PM Changeset in webkit [93033] by
-
- 2 edits in trunk/LayoutTests
[QT]REGRESSION after r93011
https://bugs.webkit.org/show_bug.cgi?id=66212
Unreviewed gardening.
- platform/qt-4.8/Skipped:
- 4:08 PM Changeset in webkit [93032] by
-
- 3 edits2 adds in trunk
Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
https://bugs.webkit.org/show_bug.cgi?id=66187
Reviewed by Adam Barth.
RefPtr a few ContainerNodes to prevent premature deletion.
Test: fast/html/process-end-tag-for-inbody-crash.html
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody.
https://bugs.webkit.org/show_bug.cgi?id=66187
Reviewed by Adam Barth.
- fast/html/process-end-tag-for-inbody-crash-expected.txt: Added.
- fast/html/process-end-tag-for-inbody-crash.html: Added.
- 10:54 AM Changeset in webkit [93031] by
-
- 1 copy in tags/Safari-534.51.15
New tag.
- 5:21 AM Changeset in webkit [93030] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK Windows build after r92308.
https://bugs.webkit.org/show_bug.cgi?id=66140
Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-14
Reviewed by Xan Lopez.
- config.h: Don't try to include WebCoreHeaderDetection.h for GTK.
- 12:02 AM Changeset in webkit [93029] by
-
- 7 edits2 adds in trunk/Tools
Switch results detail view over to new-style object-oriented UI widgets
https://bugs.webkit.org/show_bug.cgi?id=66200
Reviewed by Dimitri Glazkov.
This patch replaces my goofy template-based UI for the results
comparison screen with new object-oriented UI widgets.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
Aug 13, 2011:
- 11:55 PM Changeset in webkit [93028] by
-
- 30 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of some PNG files to image/png
- 1:38 PM Changeset in webkit [93027] by
-
- 4 edits in trunk/Source/WebKit
Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
Reviewed by Joseph Pecoraro.
../WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
../WebKit/win:
- WebPreferenceKeysPrivate.h:
- 12:27 PM Changeset in webkit [93026] by
-
- 2 edits in trunk/Source/WebCore
Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.
- bindings/objc/WebScriptObject.mm:
- 12:25 PM Changeset in webkit [93025] by
-
- 2 edits in trunk/Source/WebCore
Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.
- bindings/objc/WebScriptObject.mm:
(-[WebUndefined dealloc]):
- 12:12 PM Changeset in webkit [93024] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove unused variables from WebView/WebFullScreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66194
Reviewed by Dan Bernstein.
- WebView/WebFullScreenController.h:
Remove a few variables which were not used.
- 12:03 PM Changeset in webkit [93023] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused variables from WKFullScreenWindowController.h
https://bugs.webkit.org/show_bug.cgi?id=66193
Reviewed by Dan Bernstein.
- UIProcess/mac/WKFullScreenWindowController.h:
Remove _layerViewPlaceholder, _isWindowLoaded and _initialFrame which were not used.
- 11:57 AM Changeset in webkit [93022] by
-
- 2 edits in trunk/Source/WebCore
Remove unused variables from WebVideoFullscreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66192
Reviewed by Dan Bernstein.
- platform/mac/WebVideoFullscreenController.h:
Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.
- 11:51 AM Changeset in webkit [93021] by
-
- 3 edits in trunk/Source/WebCore
Fix incorrect objective-c initialize in WebCore
https://bugs.webkit.org/show_bug.cgi?id=66191
Reviewed by David Kilzer.
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
- rendering/RenderThemeMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.
- 11:31 AM Changeset in webkit [93020] by
-
- 2 edits in trunk/Source/WebCore
Fix clang build.
- platform/chromium/PopupMenuChromium.h:
- 11:06 AM Changeset in webkit [93019] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj: Remove duplicate entries
by using uniq. Originally noticed by Xcode 4.
- 10:54 AM Changeset in webkit [93018] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190
Reviewed by David Kilzer.
- wtf/Assertions.h:
Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.
- 10:48 AM Changeset in webkit [93017] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66182
Reviewed by Dan Bernstein.
Fixes 10 warnings in JavaScriptCore and 2 in testapi.
- API/tests/testapi.c:
(main):
Remove dead variables.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).
- wtf/dtoa.cpp:
(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.
- 8:39 AM Changeset in webkit [93016] by
-
- 5 edits in trunk/Tools
garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
https://bugs.webkit.org/show_bug.cgi?id=66166
Also changed base.RequestTracker to:
a) fire callback immediately if requestsInFlight is 0;
b) not barf if callback is not supplied.
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
- 12:00 AM Changeset in webkit [93015] by
-
- 2 edits in trunk/Source/WebKit/win
Build fix.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
