Timeline
Aug 21, 2011:
- 9:04 PM Changeset in webkit [93493] by
-
- 6 edits in branches/chromium/835/Source/WebCore
Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063
Reviewed by Darin Fisher.
Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.
Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.
Patch originally by Tom Hudson.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
BUG=93558
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7696019
- 6:10 PM Changeset in webkit [93492] by
-
- 5 edits in trunk/Source
Fix 'make dist' for WebKitGTK+.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add a missing header to the sources list.
Source/WebCore:
- GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
- GNUmakefile.list.am: Update the sources list to reflect reality.
- 1:22 PM Changeset in webkit [93491] by
-
- 14 edits in trunk/LayoutTests
Update results for more tests affected by the addition of the
HTMLSourceElement class.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 8:53 AM Changeset in webkit [93490] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fixes premature plugin unload bug
https://bugs.webkit.org/show_bug.cgi?id=66628
Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.
The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.
- WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::loadSpellChecker):
- WebCoreSupport/TextCheckerClientQt.h:
Aug 20, 2011:
- 11:26 PM Changeset in webkit [93489] by
-
- 1 edit2 copies in branches/chromium/835
Merge 93382 - REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
LayoutTests:
- fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
- fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/7703003
- 10:27 PM Changeset in webkit [93488] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
- ewk/ewk_view.h:
Fixes description of method, parameters and returned value of API
related to settings.
- 10:21 PM Changeset in webkit [93487] by
-
- 5 edits in trunk
JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572
Source/JavaScriptCore:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Changed the handling of const to add the dynamic scope depth.
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
LayoutTests:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Added tests that reproduce the failure.
- fast/js/const-expected.txt:
- fast/js/resources/const.js:
(tryCatch1):
(tryCatch2):
(with1):
(with2):
- 10:14 PM Changeset in webkit [93486] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.
- ewk/ewk_view.h:
- 9:50 PM Changeset in webkit [93485] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.
- ewk/ewk_view.h:
- 9:37 PM Changeset in webkit [93484] by
-
- 5 edits in trunk/Source
Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
Covered by existing tests, and no code was changed.
- WebCore.gyp/WebCore.gyp:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
- DEPS:
- 1:37 PM Changeset in webkit [93483] by
-
- 7 edits2 adds in trunk/Tools
garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625
Reviewed by Dimitri Glazkov.
This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction. The
patch also adds an Examine button to failure notifications. In a
future patch, I'll add a controller that wires this button up to
something useful.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
- 11:40 AM Changeset in webkit [93482] by
-
- 14 edits in trunk
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.
Source/WebCore:
Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
- bindings/generic/RuntimeEnabledFeatures.h:
- page/DOMWindow.idl:
LayoutTests:
Updated test results after adding HTMLSourceElement to the DOMWindow
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- 11:11 AM Changeset in webkit [93481] by
-
- 9 edits2 adds in trunk
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/dom/Range/insertNode-empty-fragment-crash.html
- dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.
LayoutTests:
- fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
- fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
- 8:54 AM Changeset in webkit [93480] by
-
- 4 edits in trunk/Tools
garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624
Reviewed by Dimitri Glazkov.
This patch creates a notification-based UI for build failures. The new
UI displays the same information that used to be displayed in the
infobar. There's lots of room for improvement in surfacing more
information, but this is a start.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 5:27 AM Changeset in webkit [93479] by
-
- 2 edits in trunk/LayoutTests
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515
Unreviewed gardening.
- platform/wk2/Skipped: Skip dependent test.
- 5:15 AM Changeset in webkit [93478] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626
Unreviewed gardening.
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [93477] by
-
- 3 edits2 adds in trunk
OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.
Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):
LayoutTests:
Added test case covering keySpline array length problem.
- svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
- svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.
